Re: [Qemu-devel] [PATCH 28/28] ppc: replace cpu_ppc_init() with cpu_generic_init()

2017-07-14 Thread Hervé Poussineau
Le 14/07/2017 à 15:52, Igor Mammedov a écrit : it's just a wrapper, drop it and use cpu_generic_init() directly Signed-off-by: Igor Mammedov Reviewed-by: Hervé Poussineau --- CC: Alexander Graf CC: David Gibson CC: "Hervé Poussineau" CC: "Edgar E. Iglesias" CC: qemu-...@nongnu.org ---

Re: [Qemu-devel] [PATCH 03/28] mips: replace cpu_mips_init() with cpu_generic_init()

2017-07-14 Thread Hervé Poussineau
Le 14/07/2017 à 15:51, Igor Mammedov a écrit : now cpu_mips_init() reimplements subset of cpu_generic_init() tasks, so just drop it and use cpu_generic_init() directly. Signed-off-by: Igor Mammedov Reviewed-by: Hervé Poussineau --- CC: Aurelien Jarno CC: Yongbok Kim CC: "Hervé Poussineau

Re: [Qemu-devel] [PATCH v2 1/8] qemu-error: introduce error_report_nolf

2017-07-14 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Thu, Jul 13, 2017 at 03:48:02PM +0200, Ladi Prosek wrote: >> On Thu, Jul 13, 2017 at 3:32 PM, Stefan Hajnoczi wrote: >> > On Thu, Jul 13, 2017 at 01:02:30PM +0200, Ladi Prosek wrote: >> >> +/* >> >> + * Print an error message to current monitor if we have one, else t

Re: [Qemu-devel] [Qemu-ppc] [PATCHv2 0/8] spapr: DRC cleanups (part VI)

2017-07-14 Thread David Gibson
On Fri, Jul 14, 2017 at 10:50:06AM -0300, Daniel Henrique Barboza wrote: > > > On 07/14/2017 03:53 AM, David Gibson wrote: > > On Thu, Jul 13, 2017 at 07:13:23AM -0300, Daniel Henrique Barboza wrote: > > > > > > On 07/12/2017 09:57 PM, David Gibson wrote: > > > > On Wed, Jul 12, 2017 at 10:48:38

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] spapr: ignore decr interrupts when MSR_EE is disabled

2017-07-14 Thread Nikunj Dadhania
On 15-Jul-2017 8:10 AM, "Benjamin Herrenschmidt" wrote: On Fri, 2017-07-14 at 09:34 +0530, Nikunj A Dadhania wrote: > Rebooting a SMP TCG guest is broken for both single/multi threaded TCG. > > When reset happens, all the CPUs are in halted state. First CPU is brought out > of reset and secondary

Re: [Qemu-devel] [PATCH] test-i386: Make x86 test program compile on clang

2017-07-14 Thread Theodore Dubois
ping http://patchwork.ozlabs.org/patch/786393/ ~Theodore > On Jul 10, 2017, at 1:57 PM, Theodore Dubois wrote: > > Clang's assembler is slightly incompatible with GCC's assembler, which > caused the program to not compile on Clang for these reasons: > > - The "q" constraint was specified for

Re: [Qemu-devel] [PULL 00/18] ppc-for-2.10 queue 20170714

2017-07-14 Thread David Gibson
2' > > into staging (2017-07-13 16:56:06 +0100) > > > > are available in the git repository at: > > > > git://github.com/dgibson/qemu.git tags/ppc-for-2.10-20170714 > > > > for you to fetch changes up to e11134d2ac7744569d7c387102368c507d340c30:

Re: [Qemu-devel] [PATCH 28/28] ppc: replace cpu_ppc_init() with cpu_generic_init()

2017-07-14 Thread David Gibson
On Fri, Jul 14, 2017 at 03:52:19PM +0200, Igor Mammedov wrote: > it's just a wrapper, drop it and use cpu_generic_init() directly > > Signed-off-by: Igor Mammedov Acked-by: David Gibson > --- > CC: Alexander Graf > CC: David Gibson > CC: "Hervé Poussineau" > CC: "Edgar E. Iglesias" > CC: q

Re: [Qemu-devel] [PULL 00/18] ppc-for-2.10 queue 20170714

2017-07-14 Thread David Gibson
2' > > into staging (2017-07-13 16:56:06 +0100) > > > > are available in the git repository at: > > > > git://github.com/dgibson/qemu.git tags/ppc-for-2.10-20170714 > > > > for you to fetch changes up to e11134d2ac7744569d7c387102368c507d340c30:

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] spapr: ignore decr interrupts when MSR_EE is disabled

2017-07-14 Thread Benjamin Herrenschmidt
On Fri, 2017-07-14 at 09:34 +0530, Nikunj A Dadhania wrote: > Rebooting a SMP TCG guest is broken for both single/multi threaded TCG. > > When reset happens, all the CPUs are in halted state. First CPU is brought out > of reset and secondary CPUs would be initialized by the guest kernel using a >

Re: [Qemu-devel] [PATCH] qapi: Fix error handling code on alternate conflict

2017-07-14 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20170714203313.31041-1-ehabk...@redhat.com Subject: [Qemu-devel] [PATCH] qapi: Fix error handling code on alternat

Re: [Qemu-devel] [PATCH v3 1/8] target/s390x: Implement CSST

2017-07-14 Thread Richard Henderson
On 07/14/2017 11:01 AM, Aurelien Jarno wrote: +if (parallel_cpus) { +int mask = 0; +#if !defined(CONFIG_ATOMIC64) +mask = -8; +#elif !defined(CONFIG_ATOMIC128) +mask = -16; +#endif +if (((4 << fc) | (1 << sc)) & mask) { +cpu_loop_exit_atomic(ENV_GET

Re: [Qemu-devel] [PATCH v3 2/8] target/s390x: Implement CONVERT UNICODE insns

2017-07-14 Thread Richard Henderson
On 07/14/2017 11:08 AM, Aurelien Jarno wrote: On 2017-07-11 17:18, Thomas Huth wrote: On 10.07.2017 22:45, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/s390x/helper.h | 6 + target/s390x/mem_helper.c | 310 + targe

Re: [Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and macros

2017-07-14 Thread gengdongjiu
Hi Michael Thanks for your comments. > -邮件原件- > 发件人: Michael S. Tsirkin [mailto:m...@redhat.com] > 主题: Re: [Qemu-devel] [PATCH v5 1/3] ACPI: Add new ACPI structures and > macros > > On Thu, Jul 13, 2017 at 08:00:26PM +0800, gengdongjiu wrote: > >Laszlo, I pasted Michael's comments h

Re: [Qemu-devel] [PATCH qemu v3] vfio-pci, ppc64/spapr: Reorder group-to-container attaching

2017-07-14 Thread Alexey Kardashevskiy
On 15/07/17 07:17, Alex Williamson wrote: > On Tue, 11 Jul 2017 15:32:18 +1000 > Alexey Kardashevskiy wrote: > >> At the moment VFIO PCI device initialization works as follows: >> vfio_realize >> vfio_get_group >> vfio_connect_container >> register memory li

Re: [Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device

2017-07-14 Thread Marc-André Lureau
On Sat, Jul 15, 2017 at 1:40 AM, Michael S. Tsirkin wrote: > On Sat, Jul 15, 2017 at 01:30:56AM +0200, Marc-André Lureau wrote: >> Hi >> >> On Sat, Jul 15, 2017 at 1:09 AM Michael S. Tsirkin wrote: >> > >> > On Sat, Jul 15, 2017 at 12:12:06AM +0200, Marc-André Lureau wrote: >> > > Hi >> > > >> >

Re: [Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device

2017-07-14 Thread Michael S. Tsirkin
On Sat, Jul 15, 2017 at 01:30:56AM +0200, Marc-André Lureau wrote: > Hi > > On Sat, Jul 15, 2017 at 1:09 AM Michael S. Tsirkin wrote: > > > > On Sat, Jul 15, 2017 at 12:12:06AM +0200, Marc-André Lureau wrote: > > > Hi > > > > > > On Fri, Jul 14, 2017 at 10:17 PM, Michael S. Tsirkin > > > wrote:

Re: [Qemu-devel] [PATCH v4 0/8] KASLR kernel dump support

2017-07-14 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170714182012.4595-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH v4 0/8] KASLR kernel dump support Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(

Re: [Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device

2017-07-14 Thread Marc-André Lureau
Hi On Sat, Jul 15, 2017 at 1:09 AM Michael S. Tsirkin wrote: > > On Sat, Jul 15, 2017 at 12:12:06AM +0200, Marc-André Lureau wrote: > > Hi > > > > On Fri, Jul 14, 2017 at 10:17 PM, Michael S. Tsirkin > > wrote: > > > On Fri, Jul 14, 2017 at 10:04:31PM +0200, Laszlo Ersek wrote: > > >> > It worr

Re: [Qemu-devel] [PATCH v4 0/8] KASLR kernel dump support

2017-07-14 Thread Michael S. Tsirkin
On Sat, Jul 15, 2017 at 12:31:36AM +0200, Marc-André Lureau wrote: > Hi > > On Sat, Jul 15, 2017 at 12:23 AM, Michael S. Tsirkin wrote: > > On Fri, Jul 14, 2017 at 10:21:43PM +0200, Laszlo Ersek wrote: > >> On 07/14/17 21:59, Michael S. Tsirkin wrote: > >> > On Fri, Jul 14, 2017 at 08:20:03PM +02

Re: [Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device

2017-07-14 Thread Michael S. Tsirkin
On Sat, Jul 15, 2017 at 12:12:06AM +0200, Marc-André Lureau wrote: > Hi > > On Fri, Jul 14, 2017 at 10:17 PM, Michael S. Tsirkin wrote: > > On Fri, Jul 14, 2017 at 10:04:31PM +0200, Laszlo Ersek wrote: > >> > It worries me that the format of this seems completely undefined > >> > except in the pa

Re: [Qemu-devel] [PATCH v4 0/8] KASLR kernel dump support

2017-07-14 Thread Marc-André Lureau
Hi On Sat, Jul 15, 2017 at 12:23 AM, Michael S. Tsirkin wrote: > On Fri, Jul 14, 2017 at 10:21:43PM +0200, Laszlo Ersek wrote: >> On 07/14/17 21:59, Michael S. Tsirkin wrote: >> > On Fri, Jul 14, 2017 at 08:20:03PM +0200, Marc-André Lureau wrote: >> >> Recent linux kernels enable KASLR to randomi

Re: [Qemu-devel] [PATCH v4 0/8] KASLR kernel dump support

2017-07-14 Thread Michael S. Tsirkin
On Fri, Jul 14, 2017 at 10:21:43PM +0200, Laszlo Ersek wrote: > On 07/14/17 21:59, Michael S. Tsirkin wrote: > > On Fri, Jul 14, 2017 at 08:20:03PM +0200, Marc-André Lureau wrote: > >> Recent linux kernels enable KASLR to randomize phys/virt memory > >> addresses. This series aims to provide enough

Re: [Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device

2017-07-14 Thread Marc-André Lureau
Hi On Fri, Jul 14, 2017 at 10:17 PM, Michael S. Tsirkin wrote: > On Fri, Jul 14, 2017 at 10:04:31PM +0200, Laszlo Ersek wrote: >> > It worries me that the format of this seems completely undefined >> > except in the patchset cover letter. >> > I don't think we should merge this before it is. >> >

Re: [Qemu-devel] [PATCH V3 1/9] specs/qcow2: add compress format extension

2017-07-14 Thread Peter Lieven
Am 14.07.2017 um 16:52 schrieb Eric Blake: > On 07/14/2017 04:56 AM, Peter Lieven wrote: >> Signed-off-by: Peter Lieven >> --- >> docs/interop/qcow2.txt | 35 ++- >> 1 file changed, 34 insertions(+), 1 deletion(-) >> >> diff --git a/docs/interop/qcow2.txt b/docs/in

Re: [Qemu-devel] [edk2] investigating TPM for OVMF-on-QEMU

2017-07-14 Thread Laszlo Ersek
On 07/14/17 22:30, Peter Jones wrote: > On Fri, Jul 14, 2017 at 08:04:14PM +0200, Laszlo Ersek wrote: >> (2e) Modules that we should use. Again, in increasing order of >> dependence. And here I'll comment as well on what these do: >> >>Tcg2Config/Tcg2ConfigPei.inf -- Informs the firmw

Re: [Qemu-devel] [PATCH qemu v3] vfio-pci, ppc64/spapr: Reorder group-to-container attaching

2017-07-14 Thread Alex Williamson
On Tue, 11 Jul 2017 15:32:18 +1000 Alexey Kardashevskiy wrote: > At the moment VFIO PCI device initialization works as follows: > vfio_realize > vfio_get_group > vfio_connect_container > register memory listeners (1) > update QEMU gr

Re: [Qemu-devel] [PATCH v3 2/8] target/s390x: Implement CONVERT UNICODE insns

2017-07-14 Thread Aurelien Jarno
On 2017-07-11 17:18, Thomas Huth wrote: > On 10.07.2017 22:45, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > > --- > > target/s390x/helper.h | 6 + > > target/s390x/mem_helper.c | 310 > > + > > target/s390x/translate.c | 4

Re: [Qemu-devel] [PATCH v3 2/8] target/s390x: Implement CONVERT UNICODE insns

2017-07-14 Thread Aurelien Jarno
On 2017-07-10 10:45, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/s390x/helper.h | 6 + > target/s390x/mem_helper.c | 310 > + > target/s390x/translate.c | 43 +++ > target/s390x/insn-data.def | 13 ++ > 4

Re: [Qemu-devel] [PATCH v3 1/8] target/s390x: Implement CSST

2017-07-14 Thread Aurelien Jarno
On 2017-07-10 10:45, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/s390x/helper.h | 1 + > target/s390x/cpu_models.c | 2 + > target/s390x/mem_helper.c | 189 > + > target/s390x/translate.c | 13 +++- > target

[Qemu-devel] [PATCH] qapi: Fix error handling code on alternate conflict

2017-07-14 Thread Eduardo Habkost
The conflict check added by commit c0644771 ("qapi: Reject alternates that can't work with keyval_parse()") doesn't work with the following declaration: { 'alternate': 'Alt', 'data': { 'one': 'bool', 'two': 'str' } } It crashes with: Traceback (most recent call last): F

Re: [Qemu-devel] investigating TPM for OVMF-on-QEMU

2017-07-14 Thread Peter Jones
On Fri, Jul 14, 2017 at 08:04:14PM +0200, Laszlo Ersek wrote: > - TPM2 is basically the standardized version of TrEE, the most > recent set of specs, and what we should focus on. 100% agreed. > (2) Drivers (and features) in edk2/SecurityPkg/Tcg. > > There are 19 modules under Secu

Re: [Qemu-devel] [PATCH v4 0/8] KASLR kernel dump support

2017-07-14 Thread Laszlo Ersek
On 07/14/17 21:59, Michael S. Tsirkin wrote: > On Fri, Jul 14, 2017 at 08:20:03PM +0200, Marc-André Lureau wrote: >> Recent linux kernels enable KASLR to randomize phys/virt memory >> addresses. This series aims to provide enough information in qemu >> dumps so that crash utility can work with rand

Re: [Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device

2017-07-14 Thread Michael S. Tsirkin
On Fri, Jul 14, 2017 at 10:04:31PM +0200, Laszlo Ersek wrote: > > It worries me that the format of this seems completely undefined > > except in the patchset cover letter. > > I don't think we should merge this before it is. > > I'm not sure what you mean, this patch adds "docs/specs/vmcoreinfo.tx

Re: [Qemu-devel] [PATCH v4 4/8] tests: add simple vmcoreinfo test

2017-07-14 Thread Laszlo Ersek
On 07/14/17 20:20, Marc-André Lureau wrote: > This test is based off vmgenid test from Ben Warren > . It simply checks the vmcoreinfo ACPI device > is present and that the memory region associated can be read. > > Signed-off-by: Marc-André Lureau > --- > tests/vmcoreinfo-test.c | 141 >

Re: [Qemu-devel] [PATCH v4 3/8] stubs: add vmcoreinfo_get() stub

2017-07-14 Thread Laszlo Ersek
On 07/14/17 20:20, Marc-André Lureau wrote: > Common dump code may call vmcoreinfo_get() which is not available on > all targets. > > Signed-off-by: Marc-André Lureau > --- > stubs/vmcoreinfo.c | 9 + > stubs/Makefile.objs | 1 + > 2 files changed, 10 insertions(+) > create mode 100644

Re: [Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device

2017-07-14 Thread Laszlo Ersek
On 07/14/17 21:26, Michael S. Tsirkin wrote: > On Fri, Jul 14, 2017 at 08:20:05PM +0200, Marc-André Lureau wrote: >> The VM coreinfo (vmcoreinfo) device is an emulated device which >> exposes a 4k memory range to the guest to store various informations >> useful to debug the guest OS. (it is greatl

Re: [Qemu-devel] [PATCH v4 0/8] KASLR kernel dump support

2017-07-14 Thread Michael S. Tsirkin
On Fri, Jul 14, 2017 at 08:20:03PM +0200, Marc-André Lureau wrote: > Recent linux kernels enable KASLR to randomize phys/virt memory > addresses. This series aims to provide enough information in qemu > dumps so that crash utility can work with randomized kernel too (it > hasn't been tested on othe

Re: [Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device

2017-07-14 Thread Michael S. Tsirkin
On Fri, Jul 14, 2017 at 08:20:05PM +0200, Marc-André Lureau wrote: > The VM coreinfo (vmcoreinfo) device is an emulated device which > exposes a 4k memory range to the guest to store various informations > useful to debug the guest OS. (it is greatly inspired by the VMGENID > device implementation)

Re: [Qemu-devel] [PATCH v4 1/8] vmgenid: replace x-write-pointer-available hack

2017-07-14 Thread Michael S. Tsirkin
On Fri, Jul 14, 2017 at 08:20:04PM +0200, Marc-André Lureau wrote: > This compat property sole function is to prevent the device from being > instantiated. Instead of requiring an extra compat property, check if > fw_cfg has DMA enabled. > > fw_cfg is a built-in device that is initialized very ear

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-14 Thread Michael S. Tsirkin
On Fri, Jul 14, 2017 at 02:30:23PM +0200, Michal Hocko wrote: > On Wed 12-07-17 20:40:19, Wei Wang wrote: > > This patch adds support for reporting blocks of pages on the free list > > specified by the caller. > > > > As pages can leave the free list during this call or immediately > > afterwards,

Re: [Qemu-devel] Supporting unsafe create when backing file is not accessible

2017-07-14 Thread Nir Soffer
On Wed, Jul 12, 2017 at 5:40 PM Eric Blake wrote: > On 07/12/2017 03:56 AM, Ala Hino wrote: > > Hi, > > > > We encountered a performance issue when creating a volume for a running > VM > > and we'd like to share the info with you. The root cause of the issue is > in > > our code but we found a wo

[Qemu-devel] [PATCH 4/5] qtest: Avoid passing raw strings through hmp()

2017-07-14 Thread Eric Blake
The next patch will add __attribute__((__format__)) to hmp(), which in turn causes gcc to warn about non-literal format strings. Rather than risk an arbitrary string containing % being mis-handled, always pass variable strings along with a %s format. Signed-off-by: Eric Blake --- tests/test-hmp

[Qemu-devel] [PATCH 1/5] qapi: Further enhance visitor virtual walk doc example

2017-07-14 Thread Eric Blake
Markus pointed out that the example given for virtual walks did not discuss how to do a virtual walk of an alternate type. It turns out that for output, we don't need to visit an alternate (just directly visit the type that we want); and for input, visit_start_alternate() is not currently wired up

[Qemu-devel] [PATCH 3/5] qapi: Visitor documentation tweak

2017-07-14 Thread Eric Blake
Make it clear that the name parameter to visit_start_struct() has the same semantics as for visit_start_int(). Signed-off-by: Eric Blake --- include/qapi/visitor.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h i

[Qemu-devel] [PATCH 5/5] qtest: Document calling conventions

2017-07-14 Thread Eric Blake
We have two flavors of vararg usage in qtest; make it clear that qmp() has different semantics than hmp(), and let the compiler enforce that hmp() is used correctly. Since qmp() only accepts a subset of printf flags (namely, those that our JSON parser understands), I figured that it is probably not

[Qemu-devel] [PATCH 2/5] tests: Enhance qobject output to cover partial visit

2017-07-14 Thread Eric Blake
Add a test that proves (at least when run under valgrind) that we are correctly handling allocated memory even when a visit is aborted in the middle for whatever other reason. See commit f24582d "qapi: fix double free in qmp_output_visitor_cleanup()" for a fix that was lacking testsuite exposure p

[Qemu-devel] [PATCH 0/5] random qapi cleanups

2017-07-14 Thread Eric Blake
Trying to flush some of the random patches I have lying around locally. Some of these may have been posted to the list before, perhaps as part of larger series, but I didn't bother to research which parts came from where. I'm not sure if this is in time for softfreeze; and if not, I'm not sure ho

Re: [Qemu-devel] [PATCHv9 3/3] fw_cfg: move QOM type defines and fw_cfg types into fw_cfg.h

2017-07-14 Thread Eduardo Habkost
On Fri, Jul 14, 2017 at 08:28:37PM +0200, Laszlo Ersek wrote: > On 07/14/17 20:09, Eduardo Habkost wrote: > > On Fri, Jul 14, 2017 at 10:40:08AM +0100, Mark Cave-Ayland wrote: > >> By exposing FWCfgIoState and FWCfgMemState internals we allow the > >> possibility > >> for the internal MemoryRegion

[Qemu-devel] [PATCH 1/2] nbd: Trace client command being sent

2017-07-14 Thread Eric Blake
Make the client trace slightly more legible by including the name of the command being sent. Signed-off-by: Eric Blake --- nbd/client.c | 3 ++- nbd/trace-events | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/nbd/client.c b/nbd/client.c index c3ee9f3..4c12fff 100644 -

[Qemu-devel] [PATCH 2/2] nbd: Fix server reply to NBD_OPT_EXPORT_NAME of older clients

2017-07-14 Thread Eric Blake
A typo in commit 23e099c set the size of buf[] used in response to NBD_OPT_EXPORT_NAME according to the length needed for old-style negotiation (4 bytes of flag information) instead of the intended 2 bytes used in new style. If the client doesn't enable NBD_FLAG_C_NO_ZEROES, then the server sends

[Qemu-devel] [PATCH 0/2] NBD fixes before softfreeze

2017-07-14 Thread Eric Blake
Paolo's inclusion of my NBD series in his miscellaneous tree ended up with a couple of bugs that were pointed out in the thread after the pull request was first created; these are the fixes. They are small enough that I don't mind using maintainer status to bundle them up as a PULL request for NBD

Re: [Qemu-devel] [PATCHv9 3/3] fw_cfg: move QOM type defines and fw_cfg types into fw_cfg.h

2017-07-14 Thread Laszlo Ersek
On 07/14/17 20:09, Eduardo Habkost wrote: > On Fri, Jul 14, 2017 at 10:40:08AM +0100, Mark Cave-Ayland wrote: >> By exposing FWCfgIoState and FWCfgMemState internals we allow the possibility >> for the internal MemoryRegion fields to be mapped by name for boards that >> wish >> to wire up the fw_c

[Qemu-devel] [PATCH v4 2/8] acpi: add vmcoreinfo device

2017-07-14 Thread Marc-André Lureau
The VM coreinfo (vmcoreinfo) device is an emulated device which exposes a 4k memory range to the guest to store various informations useful to debug the guest OS. (it is greatly inspired by the VMGENID device implementation) This is an early-boot alternative to the qemu-ga VMDUMP_INFO event propos

[Qemu-devel] [PATCH v4 3/8] stubs: add vmcoreinfo_get() stub

2017-07-14 Thread Marc-André Lureau
Common dump code may call vmcoreinfo_get() which is not available on all targets. Signed-off-by: Marc-André Lureau --- stubs/vmcoreinfo.c | 9 + stubs/Makefile.objs | 1 + 2 files changed, 10 insertions(+) create mode 100644 stubs/vmcoreinfo.c diff --git a/stubs/vmcoreinfo.c b/stubs/v

[Qemu-devel] [PATCH v4 6/8] kdump: add vmcoreinfo ELF note

2017-07-14 Thread Marc-André Lureau
kdump header provides offset and size of the vmcoreinfo ELF note, append it if available. crash-7.1.9 was the first version that started looking in the vmcoreinfo data for phys_base instead of in the kdump_sub_header. Signed-off-by: Marc-André Lureau Reviewed-by: Laszlo Ersek --- dump.c | 20 +

[Qemu-devel] [PATCH v4 8/8] MAINTAINERS: add Dump maintainers

2017-07-14 Thread Marc-André Lureau
Proposing myself, since I have some familiarity with the code now. Signed-off-by: Marc-André Lureau Acked-by: Laszlo Ersek --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b9aa878b84..391a28315c 100644 --- a/MAINTAINERS +++ b/MAINTAINE

[Qemu-devel] [PATCH v4 1/8] vmgenid: replace x-write-pointer-available hack

2017-07-14 Thread Marc-André Lureau
This compat property sole function is to prevent the device from being instantiated. Instead of requiring an extra compat property, check if fw_cfg has DMA enabled. fw_cfg is a built-in device that is initialized very early by the machine init code. We have at least one other device that also ass

[Qemu-devel] [PATCH v4 7/8] scripts/dump-guest-memory.py: add vmcoreinfo

2017-07-14 Thread Marc-André Lureau
Add vmcoreinfo ELF note if vmcoreinfo device is ready. To help the python script, add a static vmcoreinfo_gdb_helper value to be looked up to get vmcoreinfo device singleton. Signed-off-by: Marc-André Lureau Acked-by: Laszlo Ersek --- scripts/dump-guest-memory.py | 47 +

[Qemu-devel] [PATCH v4 5/8] dump: add vmcoreinfo ELF note

2017-07-14 Thread Marc-André Lureau
Read the vmcoreinfo ELF PT_NOTE from guest memory when vmcoreinfo device provides the location, and write it as an ELF note in the dump. There are now 2 possible sources of phys_base information. (1) arch guessed value from cpu_get_dump_info() (2) vmcoreinfo ELF note NUMBER(phys_base)= field

[Qemu-devel] [PATCH v6 17/18] tests: crypto: add hash speed benchmark support

2017-07-14 Thread longpeng . mike
From: "Longpeng(Mike)" This patch add a hash speed benchmark, it helps us to measure the performance by using "make check-speed" or using "./tests/benchmark-crypto-hash" directly. Signed-off-by: Longpeng(Mike) --- tests/Makefile.include| 2 ++ tests/benchmark-crypto-hash.c | 67 ++

[Qemu-devel] [PATCH v4 4/8] tests: add simple vmcoreinfo test

2017-07-14 Thread Marc-André Lureau
This test is based off vmgenid test from Ben Warren . It simply checks the vmcoreinfo ACPI device is present and that the memory region associated can be read. Signed-off-by: Marc-André Lureau --- tests/vmcoreinfo-test.c | 141 tests/Makefile.incl

[Qemu-devel] [PATCH v4 0/8] KASLR kernel dump support

2017-07-14 Thread Marc-André Lureau
Recent linux kernels enable KASLR to randomize phys/virt memory addresses. This series aims to provide enough information in qemu dumps so that crash utility can work with randomized kernel too (it hasn't been tested on other archs than x86 though, help welcome). The vmcoreinfo device is an emulat

[Qemu-devel] [PATCH v6 16/18] tests: crypto: add cipher speed benchmark support

2017-07-14 Thread longpeng . mike
From: "Longpeng(Mike)" Now we have two qcrypto backends, libiary-backend and afalg-backend, but which one is faster? This patch add a cipher speed benchmark, it helps us to measure the performance by using "make check-speed" or using "./tests/benchmark-crypto-cipher" directly. Signed-off-by: Lon

Re: [Qemu-devel] [RFC PATCH 7/8] VFIO: Add new IOCTL for IOMMU TLB invalidate propagation

2017-07-14 Thread Alex Williamson
On Fri, 14 Jul 2017 08:58:02 + "Liu, Yi L" wrote: > Hi Alex, > > Against to the opaque open, I'd like to propose the following definition > based on the existing comments. Pls note that I've merged the pasid > table binding and iommu tlb invalidation into a single IOCTL and make > different

[Qemu-devel] [PATCH v6 15/18] crypto: hmac: add af_alg-backend hmac support

2017-07-14 Thread longpeng . mike
From: "Longpeng(Mike)" Adds afalg-backend hmac support: introduces some private APIs firstly, and then intergrates them into qcrypto_hmac_afalg_driver. Signed-off-by: Longpeng(Mike) --- crypto/hash-afalg.c | 104 +--- crypto/hmac.c | 22 ++

[Qemu-devel] [PATCH v6 14/18] crypto: hash: add afalg-backend hash support

2017-07-14 Thread longpeng . mike
From: "Longpeng(Mike)" Adds afalg-backend hash support: introduces some private APIs firstly, and then intergrates them into qcrypto_hash_afalg_driver. Signed-off-by: Longpeng(Mike) --- crypto/Makefile.objs | 1 + crypto/afalgpriv.h | 1 + crypto/hash-afalg.c | 136 +

Re: [Qemu-devel] [PATCHv9 3/3] fw_cfg: move QOM type defines and fw_cfg types into fw_cfg.h

2017-07-14 Thread Eduardo Habkost
On Fri, Jul 14, 2017 at 10:40:08AM +0100, Mark Cave-Ayland wrote: > By exposing FWCfgIoState and FWCfgMemState internals we allow the possibility > for the internal MemoryRegion fields to be mapped by name for boards that wish > to wire up the fw_cfg device themselves. > > Signed-off-by: Mark Cave

[Qemu-devel] [PATCH v6 12/18] crypto: introduce some common functions for af_alg backend

2017-07-14 Thread longpeng . mike
From: "Longpeng(Mike)" The AF_ALG socket family is the userspace interface for linux crypto API, this patch adds af_alg family support and some common functions for af_alg backend. It'll be used by afalg-backend crypto latter. Signed-off-by: Longpeng(Mike) --- configure| 30 ++

[Qemu-devel] [PATCH v6 13/18] crypto: cipher: add afalg-backend cipher support

2017-07-14 Thread longpeng . mike
From: "Longpeng(Mike)" Adds afalg-backend cipher support: introduces some private APIs firstly, and then intergrates them into qcrypto_cipher_afalg_driver. Signed-off-by: Longpeng(Mike) --- crypto/Makefile.objs | 1 + crypto/afalgpriv.h| 9 ++ crypto/cipher-afalg.c | 226 +

[Qemu-devel] [PATCH v6 18/18] tests: crypto: add hmac speed benchmark support

2017-07-14 Thread longpeng . mike
From: "Longpeng(Mike)" This patch add a hmac speed benchmark, it helps us to measure the performance by using "make check-speed" or using "./tests/benchmark-crypto-hmac" directly. Signed-off-by: Longpeng(Mike) --- tests/Makefile.include| 2 ++ tests/benchmark-crypto-hmac.c | 82 ++

[Qemu-devel] investigating TPM for OVMF-on-QEMU

2017-07-14 Thread Laszlo Ersek
Hi, I spent most of today reading TPM related material (specs, guides and source code), and below I'd like to describe what I think should be our initial attack on enabling TPM on QEMU/OVMF. (1) Versions of UEFI abstractions regarding TPM (very roughly speaking): There have been three sets o

[Qemu-devel] [PATCH v6 10/18] crypto: hmac: introduce qcrypto_hmac_ctx_new for glib-backend

2017-07-14 Thread longpeng . mike
From: "Longpeng(Mike)" Extracts qcrypto_hmac_ctx_new() from qcrypto_hmac_new() for glib-backend impls. Reviewed-by: Daniel P. Berrange Reviewed-by: Gonglei Signed-off-by: Longpeng(Mike) --- crypto/hmac-glib.c | 34 -- 1 file changed, 24 insertions(+), 10 delet

[Qemu-devel] [PATCH v6 11/18] crypto: hmac: add hmac driver framework

2017-07-14 Thread longpeng . mike
From: "Longpeng(Mike)" 1) makes the public APIs in hmac-nettle/gcrypt/glib static, and rename them with "nettle/gcrypt/glib" prefix. 2) introduces hmac framework, including QCryptoHmacDriver and new public APIs. Reviewed-by: Daniel P. Berrange Signed-off-by: Longpeng(Mike) --- crypto/h

[Qemu-devel] [PATCH v6 05/18] crypto: cipher: add cipher driver framework

2017-07-14 Thread longpeng . mike
From: "Longpeng(Mike)" 1) makes the public APIs in cipher-nettle/gcrypt/builtin static, and rename them with "nettle/gcrypt/builtin" prefix. 2) introduces cipher framework, including QCryptoCipherDriver and new public APIs. Reviewed-by: Daniel P. Berrange Reviewed-by: Gonglei Signed-off

[Qemu-devel] [PATCH v6 08/18] crypto: hmac: introduce qcrypto_hmac_ctx_new for gcrypt-backend

2017-07-14 Thread longpeng . mike
From: "Longpeng(Mike)" 1) Fix a handle-leak problem in qcrypto_hmac_new(), didn't free ctx->handle if gcry_mac_setkey fails. 2) Extracts qcrypto_hmac_ctx_new() from qcrypto_hmac_new() for gcrypt-backend impls. Reviewed-by: Daniel P. Berrange Reviewed-by: Gonglei Signed-off-by: Longpeng(

[Qemu-devel] [PATCH v6 09/18] crypto: hmac: introduce qcrypto_hmac_ctx_new for nettle-backend

2017-07-14 Thread longpeng . mike
From: "Longpeng(Mike)" Extracts qcrypto_hmac_ctx_new() from qcrypto_hmac_new() for nettle-backend impls. Reviewed-by: Daniel P. Berrange Reviewed-by: Gonglei Signed-off-by: Longpeng(Mike) --- crypto/hmac-nettle.c | 34 -- 1 file changed, 24 insertions(+), 10 d

[Qemu-devel] [PATCH v6 07/18] crypto: hmac: move crypto/hmac.h into include/crypto/

2017-07-14 Thread longpeng . mike
From: "Longpeng(Mike)" Moves crypto/hmac.h into include/crypto/, likes cipher.h and hash.h Reviewed-by: Daniel P. Berrange Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Gonglei Signed-off-by: Longpeng(Mike) --- crypto/hmac.h | 166 -

[Qemu-devel] [PATCH v6 00/18] crypto: add afalg-backend support

2017-07-14 Thread longpeng . mike
From: "Longpeng(Mike)" The AF_ALG socket family is the userspace interface for linux crypto API, users can use it to access hardware accelerators. This patchset adds a afalg-backend for qemu crypto subsystem. QEMU would try to use afalg-backend first if configures '--enable-crypto -afalg' and ho

[Qemu-devel] [PATCH v6 04/18] crypto: cipher: introduce qcrypto_cipher_ctx_new for builtin-backend

2017-07-14 Thread longpeng . mike
From: "Longpeng(Mike)" Extracts qcrypto_cipher_ctx_new() from qcrypto_cipher_new() for builtin-backend impls. Reviewed-by: Daniel P. Berrange Reviewed-by: Gonglei Signed-off-by: Longpeng(Mike) --- crypto/cipher-builtin.c | 101 ++-- 1 file changed,

[Qemu-devel] [PATCH v6 03/18] crypto: cipher: introduce qcrypto_cipher_ctx_new for nettle-backend

2017-07-14 Thread longpeng . mike
From: "Longpeng(Mike)" Extracts qcrypto_cipher_ctx_new() from qcrypto_cipher_new() for nettle-backend impls. Reviewed-by: Daniel P. Berrange Reviewed-by: Gonglei Signed-off-by: Longpeng(Mike) --- crypto/cipher-nettle.c | 41 + 1 file changed, 29 insert

[Qemu-devel] [PATCH v6 06/18] crypto: hash: add hash driver framework

2017-07-14 Thread longpeng . mike
From: "Longpeng(Mike)" 1) makes the public APIs in hash-nettle/gcrypt/glib static, and rename them with "nettle/gcrypt/glib" prefix. 2) introduces hash framework, including QCryptoHashDriver and new public APIs. Reviewed-by: Daniel P. Berrange Reviewed-by: Gonglei Signed-off-by: Longpen

[Qemu-devel] [PATCH v6 01/18] crypto: cipher: introduce context free function

2017-07-14 Thread longpeng . mike
From: "Longpeng(Mike)" Refactors the qcrypto_cipher_free(), splits it into two parts. One is gcrypt/nettle__cipher_free_ctx() to free the special context. This makes code more clear, what's more, it would be used by the later patch. Reviewed-by: Daniel P. Berrange Reviewed-by: Gonglei Signed-

[Qemu-devel] [PATCH v6 02/18] crypto: cipher: introduce qcrypto_cipher_ctx_new for gcrypt-backend

2017-07-14 Thread longpeng . mike
From: "Longpeng(Mike)" Extracts qcrypto_cipher_ctx_new() from qcrypto_cipher_new() for gcrypt-backend impls. Reviewed-by: Daniel P. Berrange Reviewed-by: Gonglei Signed-off-by: Longpeng(Mike) --- crypto/cipher-gcrypt.c | 50 +- 1 file changed,

Re: [Qemu-devel] [PATCH v13 18/26] target/arm: [tcg] Port to breakpoint_check

2017-07-14 Thread Richard Henderson
On 07/14/2017 07:26 AM, Richard Henderson wrote: On 07/13/2017 11:26 PM, Lluís Vilanova wrote: Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova Reviewed-by: Richard Henderson --- target/arm/translate.c | 53 +

Re: [Qemu-devel] qapi: Stop abusing "special" values for something entirely different

2017-07-14 Thread Eric Blake
On 07/14/2017 12:12 PM, Markus Armbruster wrote: > > Instead of the last part, I prefer either > > * so we add a *new* value, such as JSON null. I like that idea. > > 1. Stop abusing values the schema accepts, but are invalid to mean "do > something else entirely". > > 2. Add a first class nu

Re: [Qemu-devel] [PATCH v13 22/26] target/arm: [tcg] Port to tb_stop

2017-07-14 Thread Richard Henderson
On 07/13/2017 11:42 PM, Lluís Vilanova wrote: -dc->base.is_jmp = DISAS_SKIP; +dc->base.is_jmp = DISAS_NORETURN; Really should fold this back into the patch that introduced SKIP temporarily. r~

Re: [Qemu-devel] [PATCH v13 18/26] target/arm: [tcg] Port to breakpoint_check

2017-07-14 Thread Richard Henderson
On 07/13/2017 11:26 PM, Lluís Vilanova wrote: Incrementally paves the way towards using the generic instruction translation loop. Signed-off-by: Lluís Vilanova Reviewed-by: Richard Henderson --- target/arm/translate.c | 53 +++- 1 file changed,

Re: [Qemu-devel] [PATCHv9 1/3] fw_cfg: switch fw_cfg_find() to locate the fw_cfg device by type rather than path

2017-07-14 Thread Eduardo Habkost
On Fri, Jul 14, 2017 at 10:40:06AM +0100, Mark Cave-Ayland wrote: > This will enable the fw_cfg device to be placed anywhere within the QOM tree > regardless of its machine location. > > Note that we also add a comment to document the behaviour that we return NULL > to > indicate failure where ei

Re: [Qemu-devel] [RFC 16/29] vhost+postcopy: Stash RAMBlock and offset

2017-07-14 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Jun 28, 2017 at 08:00:34PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Stash the RAMBlock and offset for later use looking up > > addresses. > > > > Signed-off-by: Dr. David Alan Gilbert > > --- > > hw/vi

Re: [Qemu-devel] [PATCHv9 2/3] fw_cfg: move qdev_init_nofail() from fw_cfg_init1() to callers

2017-07-14 Thread Eduardo Habkost
On Fri, Jul 14, 2017 at 10:40:07AM +0100, Mark Cave-Ayland wrote: > When looking to instantiate a TYPE_FW_CFG_MEM or TYPE_FW_CFG_IO device to be > able to wire it up differently, it is much more convenient for the caller to > instantiate the device and have the fw_cfg default files already preloade

[Qemu-devel] qapi: Stop abusing "special" values for something entirely different

2017-07-14 Thread Markus Armbruster
Back in March, we discussed Dan's "[PATCH] migration: allow clearing migration string parameters". The patch extends command migrate-set-parameters to interpret empty string arguments to parameters tls-creds and tls-hostname specially: # @tls-creds: ID of the 'tls-creds' object that provides

Re: [Qemu-devel] [PATCH v4 1/2] docs: document support lifetime for features

2017-07-14 Thread Eduardo Habkost
On Fri, Jul 14, 2017 at 11:15:48AM +0100, Daniel P. Berrange wrote: > There is currently no explicit guidance on the duration of support > for features such as versioned machine types, which have a finite > useful lifespan. Thus apps / users cannot predict how much time > they might be able to use

Re: [Qemu-devel] [PATCH 00/11] Make memory_region_init_ram() and friends handle migration

2017-07-14 Thread Peter Maydell
On 10 July 2017 at 11:05, Paolo Bonzini wrote: > On 07/07/2017 16:42, Peter Maydell wrote: >> This patchset changes the memory region functions >> - memory_region_init_ram() >> - memory_region_init_rom() >> - memory_region_init_rom_device() >> to all automatically register the backing memory th

Re: [Qemu-devel] [PULL 22/42] configure: factor out list of supported Xen/KVM/HAX targets

2017-07-14 Thread Paolo Bonzini
- Original Message - > From: "Philippe Mathieu-Daudé" > To: "Paolo Bonzini" , "Peter Maydell" > > Cc: "Anthony PERARD" , "Stefano Stabellini" > , "Alex Bennée" > , "QEMU Developers" > Sent: Friday, July 14, 2017 5:26:36 PM > Subject: Re: [Qemu-devel] [PULL 22/42] configure: factor ou

Re: [Qemu-devel] [PATCH v5 14/18] qcow2: Switch qcow2_measure() to byte-based iteration

2017-07-14 Thread Eric Blake
On 07/13/2017 01:49 PM, John Snow wrote: > > > On 07/12/2017 09:05 PM, Eric Blake wrote: >> This is new code, but it is easier to read if it makes passes over >> the image using bytes rather than sectors (and will get easier in >> the future when bdrv_get_block_status is converted to byte-based).

Re: [Qemu-devel] [PATCH v13 03/26] target: [tcg] Add generic translation framework

2017-07-14 Thread Richard Henderson
On 07/13/2017 10:25 PM, Lluís Vilanova wrote: +/* Pass breakpoint hits to target for further processing */ +if (unlikely(!QTAILQ_EMPTY(&cpu->breakpoints))) { +CPUBreakpoint *bp; +QTAILQ_FOREACH(bp, &cpu->breakpoints, entry) { +if (bp->pc ==

Re: [Qemu-devel] [PATCH 0/6] seccomp: feature refactoring

2017-07-14 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 20170714113700.21319-1-ot...@redhat.com Subject: [Qemu-devel] [PATCH 0/6] seccomp: feature refactorin

Re: [Qemu-devel] [PATCH v5 00/18] crypto: add afalg-backend support

2017-07-14 Thread Longpeng(Mike)
2017-07-14 21:04 GMT+08:00 Daniel P. Berrange : > On Fri, Jul 14, 2017 at 07:38:22AM -0400, longpeng.m...@gmail.com wrote: >> From: "Longpeng(Mike)" >> [...] >> >> NOTE: If we use specific hardware crypto cards, I think afalg-backend >> would even faster. >> >> test-environment: Intel(R) Co

Re: [Qemu-devel] [PATCH v2] vmgenid-test: use boot-sector infrastructure

2017-07-14 Thread Peter Maydell
On 14 July 2017 at 16:49, Ben Warren wrote: > Hi Michael, > > Looks good. Thanks for taking care of this. > > On Jul 14, 2017, at 8:30 AM, Michael S. Tsirkin wrote: > > There's no requirement for RSDP to be installed last > by the firmware, so in rare cases vmgen id test hits > a race: RSDP is t

  1   2   3   4   5   6   >