On Tue, Jul 25, 2017 at 9:37 AM, Bruce Hoult wrote:
> Do you have any good estimates for how much of the execution time is
> typically spent in instruction decode?
>
> RISC-V qemu is twice as fast as ARM or Aarch64 qemu, so it's doing something
> right!
>
> (I suspect it's probably mostly the lack
Let's avoid creating an in-memory list of keys and query for each value
and use `iteritems` which is an iterator of key-value pairs.
Signed-off-by: Lukáš Doktor
Reviewed-by: Eduardo Habkost
Reviewed-by: Philippe Mathieu-Daudé
---
scripts/qemu.py | 6 +++---
1 file changed, 3 insertions(+), 3 d
Dne 26.7.2017 v 16:35 Lukáš Doktor napsal(a):
> Hello guys,
>
> I'm reading the available python modules to exercise qemu and while reading
> them
> I fixed some issues that caught my attention. It usually starts with a simple
> pylint/docstring fixes and slowly graduates to more controversial on
On 26/07/2017 16:47, Thomas Huth wrote:
> If you're willing to maintain that "mess", sure, please go ahead! But
> please remove my SoB, I don't want to be responsible for all those files ;-)
Changed it to suggested-by then, and pushed. :>
Please test!
Paolo
There is no need to define QEMUMonitorProtocol as old-style class.
Signed-off-by: Lukáš Doktor
Reviewed-by: Eduardo Habkost
---
scripts/qmp/qmp-shell | 4 ++--
scripts/qmp/qmp.py| 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-sh
No actual code changes, just several pylint/style fixes and docstring
clarifications.
Signed-off-by: Lukáš Doktor
---
scripts/qemu.py | 76 -
1 file changed, 53 insertions(+), 23 deletions(-)
diff --git a/scripts/qemu.py b/scripts/qemu.py
Hello guys,
I'm reading the available python modules to exercise qemu and while reading them
I fixed some issues that caught my attention. It usually starts with a simple
pylint/docstring fixes and slowly graduates to more controversial ones so I'm
open to suggestion to remove some of them.
Kind
The list object is mutable in python and potentially might modify other
object's arguments when used as default argument. Reproducer:
>>> vm1 = QEMUMachine("qemu")
>>> vm2 = QEMUMachine("qemu")
>>> vm1._wrapper.append("foo")
>>> print vm2._wrapper
['foo']
In this case the `arg
No actual code changes, just few pylint/style fixes.
Signed-off-by: Lukáš Doktor
Reviewed-by: John Snow
---
scripts/qtest.py | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/scripts/qtest.py b/scripts/qtest.py
index ab183c0..df0daf2 100644
--- a/scripts/qtest.py
+
The "has_key" is deprecated in favor of "__in__" operator.
Signed-off-by: Lukáš Doktor
Reviewed-by: Eduardo Habkost
Reviewed-by: Philippe Mathieu-Daudé
---
scripts/qmp/qmp.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/qmp/qmp.py b/scripts/qmp/qmp.py
index 95ff5
* Amarnath Valluri (amarnath.vall...@intel.com) wrote:
> On Tue, 2017-07-25 at 20:18 -0400, Stefan Berger wrote:
> > On 07/18/2017 04:49 AM, Amarnath Valluri wrote:
> > > diff --git a/hw/tpm/Makefile.objs b/hw/tpm/Makefile.objs
> > > index 64cecc3..41f0b7a 100644
> > > --- a/hw/tpm/Makefile.objs
>
The naked Exception should not be widely used. It makes sense to be a
bit more specific and use better-suited custom exceptions. As a benefit
we can store the full reply in the exception in case someone needs it
when catching the exception.
Signed-off-by: Lukáš Doktor
Reviewed-by: Eduardo Habkost
The QMP key conversion consist of '_'s to be replaced with '-'s, which
can easily be done by a single `str.replace` method which is faster and
does not require `string` module import.
Signed-off-by: Lukáš Doktor
Reviewed-by: Eduardo Habkost
---
scripts/qemu.py | 5 +
1 file changed, 1 inser
On Wed, Jul 26, 2017 at 04:17:38PM +0200, Thomas Huth wrote:
> On 26.07.2017 16:02, Daniel P. Berrange wrote:
> > On Wed, Jul 26, 2017 at 03:27:30PM +0200, Thomas Huth wrote:
> >> Most browsers try to download a /favicon.ico file from the web servers
> >> which is then e.g. used in the browser tabs
The "id" is a builtin method to get object's identity and should not be
overridden. This might bring some issues in case someone was directly
calling "cmd(..., id=id)" but I haven't found such usage on brief search
for "cmd\(.*id=".
Signed-off-by: Lukáš Doktor
Reviewed-by: Eduardo Habkost
---
s
No actual code changes, just several pylint/style fixes and docstring
clarifications.
Signed-off-by: Lukáš Doktor
---
scripts/qemu.py | 76 -
1 file changed, 53 insertions(+), 23 deletions(-)
diff --git a/scripts/qemu.py b/scripts/qemu.py
There is no need to define QEMUMonitorProtocol as old-style class.
Signed-off-by: Lukáš Doktor
Reviewed-by: Eduardo Habkost
---
scripts/qmp/qmp-shell | 4 ++--
scripts/qmp/qmp.py| 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-sh
No actual code changes, just few pylint/style fixes.
Signed-off-by: Lukáš Doktor
Reviewed-by: John Snow
---
scripts/qtest.py | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/scripts/qtest.py b/scripts/qtest.py
index ab183c0..df0daf2 100644
--- a/scripts/qtest.py
+
The list object is mutable in python and potentially might modify other
object's arguments when used as default argument. Reproducer:
>>> vm1 = QEMUMachine("qemu")
>>> vm2 = QEMUMachine("qemu")
>>> vm1._wrapper.append("foo")
>>> print vm2._wrapper
['foo']
In this case the `arg
The "id" is a builtin method to get object's identity and should not be
overridden. This might bring some issues in case someone was directly
calling "cmd(..., id=id)" but I haven't found such usage on brief search
for "cmd\(.*id=".
Signed-off-by: Lukáš Doktor
Reviewed-by: Eduardo Habkost
---
s
From: Kevin Wolf
Commits 70f17a1 ('error: Revert unwanted change of warning messages')
and e1824e5 ('qemu-iotests: Test 'info block'') had a semantic merge
conflict, which results in failure for qemu-iotests case 186. Fix the
reference output to consider the changes of 70f17a1.
Signed-off-by: Ke
Let's avoid creating an in-memory list of keys and query for each value
and use `iteritems` which is an iterator of key-value pairs.
Signed-off-by: Lukáš Doktor
Reviewed-by: Eduardo Habkost
Reviewed-by: Philippe Mathieu-Daudé
---
scripts/qemu.py | 6 +++---
1 file changed, 3 insertions(+), 3 d
No actual code changes, just initializing attributes earlier to avoid
AttributeError on early introspection, a few pylint/style fixes and
docstring clarifications.
Signed-off-by: Lukáš Doktor
Reviewed-by: Philippe Mathieu-Daudé
---
scripts/qmp/qmp.py | 37 -
The naked Exception should not be widely used. It makes sense to be a
bit more specific and use better-suited custom exceptions. As a benefit
we can store the full reply in the exception in case someone needs it
when catching the exception.
Signed-off-by: Lukáš Doktor
Reviewed-by: Eduardo Habkost
The "has_key" is deprecated in favor of "__in__" operator.
Signed-off-by: Lukáš Doktor
Reviewed-by: Eduardo Habkost
Reviewed-by: Philippe Mathieu-Daudé
---
scripts/qmp/qmp.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/qmp/qmp.py b/scripts/qmp/qmp.py
index 95ff5
From: Peter Maydell
Signed-off-by: Peter Maydell
---
VERSION | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/VERSION b/VERSION
index 12ca1d1..a0700e6 100644
--- a/VERSION
+++ b/VERSION
@@ -1 +1 @@
-2.9.50
+2.9.90
--
2.9.4
The QMP key conversion consist of '_'s to be replaced with '-'s, which
can easily be done by a single `str.replace` method which is faster and
does not require `string` module import.
Signed-off-by: Lukáš Doktor
Reviewed-by: Eduardo Habkost
---
scripts/qemu.py | 5 +
1 file changed, 1 inser
From: Vladimir Sementsov-Ogievskiy
Fix possible crash on error path in
qcow2_remove_persistent_dirty_bitmap. Although bitmap_free was added in
88ddffae8fc the bug was introduced later in commit 469c71edc72 (when
qcow2_remove_persistent_dirty_bitmap was added).
Signed-off-by: Vladimir Sementsov-O
From: "Daniel P. Berrange"
Fix leak of the 'encryptopts' string, which was mistakenly
declared const.
Fix leak of QemuOpts entry which should not have been deleted
from the opts array.
Reported by: coverity
Signed-off-by: Daniel P. Berrange
Message-id: 20170714103105.5781-1-berra...@redhat.com
Hello guys,
I'm reading the available python modules to exercise qemu and while reading them
I fixed some issues that caught my attention. It usually starts with a simple
pylint/docstring fixes and slowly graduates to more controversial ones so I'm
open to suggestion to remove some of them.
Kind
On Wed, 26 Jul 2017 14:42:23 +1000
Alexey Kardashevskiy wrote:
> On 26/07/17 04:01, Greg Kurz wrote:
> > From: Michael Roth
> >
> > The 'dr_phb_enabled' field of that class can be set as
> > part of machine-specific init code, and is then propagated
> > to sPAPREnvironment to conditionally enab
On Wed, 26 Jul 2017 02:18:36 -0400
Yi Wang wrote:
> This patch add output of CPUs' socket-id, core-id, thread-id and
> apic-id for 'info registers', which can be used for querying other
> hmp commands.
>
> Signed-off-by: Yi Wang
> Signed-off-by: Yun Liu
> ---
> target/i386/helper.c | 8 ++
On Wed, 26 Jul 2017 11:01:14 -0300
Eduardo Habkost wrote:
> On Wed, Jul 26, 2017 at 02:18:36AM -0400, Yi Wang wrote:
> > This patch add output of CPUs' socket-id, core-id, thread-id and
> > apic-id for 'info registers', which can be used for querying other
> > hmp commands.
> >
> > Signed-off-by
On Wed, 26 Jul 2017 14:06:29 +1000
David Gibson wrote:
> On Tue, Jul 25, 2017 at 07:59:44PM +0200, Greg Kurz wrote:
> > When hot-unplugging a PHB, all its PCI DRC connectors get unrealized. This
> > patch adds an unrealize method to the physical DRC class, in order to undo
> > registrations perfo
This proposal follows a discussion we had with Kevin and Stefan on
filter node management.
With block filter drivers arises a need to configure filter nodes on
runtime with QMP on live graphs. A problem with doing live graph
modifications is that some block jobs modify the graph when they are
On 26.07.2017 16:02, Daniel P. Berrange wrote:
> On Wed, Jul 26, 2017 at 03:27:30PM +0200, Thomas Huth wrote:
>> Most browsers try to download a /favicon.ico file from the web servers
>> which is then e.g. used in the browser tabs or bookmark lists. So let's
>> add such a file for the QEMU website,
On 26 July 2017 at 15:02, Eric Blake wrote:
> These days, many programs are including a bug-reporting address,
> or better yet, a link to the project web site, at the tail of
> their --help output. However, we were not very consistent at
> doing so: only qemu-nbd and qemu-qa mentioned anything, w
On Tue, 25 Jul 2017 16:36:06 +0300
"Michael S. Tsirkin" wrote:
> On Mon, Jul 24, 2017 at 03:50:20PM +0200, Igor Mammedov wrote:
> > w2k used to boot on QEMU until revision of FADT has
> > been bumped to rev3
> > (commit 77af8a2b hw/i386: Use Rev3 FADT (ACPI 2.0) instead of Rev1 to
> > improve gu
On Wed, Jul 26, 2017 at 03:27:30PM +0200, Thomas Huth wrote:
> Most browsers try to download a /favicon.ico file from the web servers
> which is then e.g. used in the browser tabs or bookmark lists. So let's
> add such a file for the QEMU website, too. The .ico has been created
> resizing the logo
On Wed, Jul 26, 2017 at 03:43:43PM +0200, Igor Mammedov wrote:
> On Wed, 26 Jul 2017 15:33:37 +0200
> Paolo Bonzini wrote:
>
> > On 26/07/2017 15:30, Igor Mammedov wrote:
> > > On Wed, 26 Jul 2017 15:10:40 +0200
> > > Paolo Bonzini wrote:
> > >
> > >> On 26/07/2017 15:08, Igor Mammedov wrote:
On Tue, 25 Jul 2017 22:47:18 +0300
"Michael S. Tsirkin" wrote:
> On Tue, Jul 25, 2017 at 10:44:38AM +0200, Igor Mammedov wrote:
> > On Mon, 24 Jul 2017 23:50:00 +0300
> > "Michael S. Tsirkin" wrote:
> >
> > > On Mon, Jul 24, 2017 at 11:14:19AM +0200, Igor Mammedov wrote:
> > > > On Sun, 23
Include the package version information (useful for detecting
builds from git or downstream backports), and the copyright notice.
Signed-off-by: Eric Blake
---
qemu-io.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/qemu-io.c b/qemu-io.c
index 4cfa41c8f9..ec175630a6 1006
These days, many programs are including a bug-reporting address,
or better yet, a link to the project web site, at the tail of
their --help output. However, we were not very consistent at
doing so: only qemu-nbd and qemu-qa mentioned anything, with the
latter pointing to an individual person inste
Include the package version information (useful for detecting
builds from git or downstream backports), and the copyright notice.
Signed-off-by: Eric Blake
---
qga/main.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/qga/main.c b/qga/main.c
index 1b381d0bf3..b64c7ac2a
On Wed, Jul 26, 2017 at 02:18:36AM -0400, Yi Wang wrote:
> This patch add output of CPUs' socket-id, core-id, thread-id and
> apic-id for 'info registers', which can be used for querying other
> hmp commands.
>
> Signed-off-by: Yi Wang
> Signed-off-by: Yun Liu
> ---
> target/i386/helper.c | 8 +
Consistently letting --help point users back to the full resources
of the project is a good idea. Also enhance some --version outputs.
Eric Blake (3):
qemu-io: Give more --version information
qga: Give more --version information
maint: Include bug-reporting info in --help output.
include/
On Wed, Jul 26, 2017 at 03:30:20PM +0200, Igor Mammedov wrote:
> On Wed, 26 Jul 2017 15:10:40 +0200
> Paolo Bonzini wrote:
>
> > On 26/07/2017 15:08, Igor Mammedov wrote:
> > > On Tue, 25 Jul 2017 18:23:22 +0200
> > > Paolo Bonzini wrote:
> > >
> > >> On 25/07/2017 18:14, Laszlo Ersek wrote:
On Wed, 26 Jul 2017 14:29:26 +1000
Alexey Kardashevskiy wrote:
> On 26/07/17 03:59, Greg Kurz wrote:
> > This memory region should be owned by the PHB. This ensures the PHB
> > cannot be finalized as long as the the region is guest visible, or
> > used by a CPU or a device.
>
> Out of curiosit
>
> On Tue, 2017-07-25 at 07:46 -0700, Dan Williams wrote:
> > On Tue, Jul 25, 2017 at 7:27 AM, Pankaj Gupta
> > wrote:
> > >
> > > Looks like only way to send flush(blk dev) from guest to host with
> > > nvdimm
> > > is using flush hint addresses. Is this the correct interface I am
> > > looki
On Wed, 26 Jul 2017 15:33:37 +0200
Paolo Bonzini wrote:
> On 26/07/2017 15:30, Igor Mammedov wrote:
> > On Wed, 26 Jul 2017 15:10:40 +0200
> > Paolo Bonzini wrote:
> >
> >> On 26/07/2017 15:08, Igor Mammedov wrote:
> >>> On Tue, 25 Jul 2017 18:23:22 +0200
> >>> Paolo Bonzini wrote:
> >>>
On 26/07/2017 15:30, Igor Mammedov wrote:
> On Wed, 26 Jul 2017 15:10:40 +0200
> Paolo Bonzini wrote:
>
>> On 26/07/2017 15:08, Igor Mammedov wrote:
>>> On Tue, 25 Jul 2017 18:23:22 +0200
>>> Paolo Bonzini wrote:
>>>
On 25/07/2017 18:14, Laszlo Ersek wrote:
> "No regressions beca
On 26/07/2017 15:27, Thomas Huth wrote:
> Most browsers try to download a /favicon.ico file from the web servers
> which is then e.g. used in the browser tabs or bookmark lists. So let's
> add such a file for the QEMU website, too. The .ico has been created
> resizing the logo from http://wiki.qemu
On Wed, 26 Jul 2017 15:10:40 +0200
Paolo Bonzini wrote:
> On 26/07/2017 15:08, Igor Mammedov wrote:
> > On Tue, 25 Jul 2017 18:23:22 +0200
> > Paolo Bonzini wrote:
> >
> >> On 25/07/2017 18:14, Laszlo Ersek wrote:
> >>> "No regressions became apparent in tests with a range of Windows
> >>
Most browsers try to download a /favicon.ico file from the web servers
which is then e.g. used in the browser tabs or bookmark lists. So let's
add such a file for the QEMU website, too. The .ico has been created
resizing the logo from http://wiki.qemu.org/Logo to 16x16 pixels.
Signed-off-by: Thoma
On Wed, Jul 26, 2017 at 02:07:13PM +0100, Daniel P. Berrange wrote:
> On Wed, Jul 26, 2017 at 03:52:43PM +0300, Michael S. Tsirkin wrote:
> > On Wed, Jul 26, 2017 at 11:31:36AM +0200, Paolo Bonzini wrote:
> > > The tables that QEMU provides are not ACPI 1.0 compatible since commit
> > > 77af8a2b95
On 26/07/2017 15:08, Igor Mammedov wrote:
> On Tue, 25 Jul 2017 18:23:22 +0200
> Paolo Bonzini wrote:
>
>> On 25/07/2017 18:14, Laszlo Ersek wrote:
>>> "No regressions became apparent in tests with a range of Windows
>>>(XP-10)"
>>>
>>> In theory, w2k falls within that range.
>>
>> Nope,
On Wed, Jul 26, 2017 at 02:03:37PM +0100, Stefan Hajnoczi wrote:
> Block driver documentation is available in qemu-doc.html. It would be
> convenient to have documentation for formats, protocols, and filter
> drivers in a man page.
>
> Extract the relevant part of qemu-doc.html into a new file ca
On Wed, Jul 26, 2017 at 06:39:28AM +0200, Lukáš Doktor wrote:
> Dne 25.7.2017 v 18:06 Eduardo Habkost napsal(a):
> > On Tue, Jul 25, 2017 at 05:09:46PM +0200, Lukáš Doktor wrote:
> >> The naked Exception should not be widely used. It makes sense to be a
> >> bit more specific and use better-suited
On Wed, Jul 26, 2017 at 06:46:30AM +0200, Lukáš Doktor wrote:
> Dne 25.7.2017 v 21:34 Eduardo Habkost napsal(a):
> > On Tue, Jul 25, 2017 at 05:09:50PM +0200, Lukáš Doktor wrote:
> >> The "id" is a builtin method to get object's identity and should not be
> >> overridden. This might bring some issu
On Tue, 25 Jul 2017 18:23:22 +0200
Paolo Bonzini wrote:
> On 25/07/2017 18:14, Laszlo Ersek wrote:
> > "No regressions became apparent in tests with a range of Windows
> >(XP-10)"
> >
> > In theory, w2k falls within that range.
>
> Nope, Windows 2000 is like NT 5.0, XP is like NT 5.1. :
On Wed, Jul 26, 2017 at 03:52:43PM +0300, Michael S. Tsirkin wrote:
> On Wed, Jul 26, 2017 at 11:31:36AM +0200, Paolo Bonzini wrote:
> > The tables that QEMU provides are not ACPI 1.0 compatible since commit
> > 77af8a2b95 ("hw/i386: Use Rev3 FADT (ACPI 2.0) instead of Rev1 to improve
> > guest OS
On 07/26/2017 07:49 AM, Gerd Hoffmann wrote:
> Hi,
>
>> error message). I suspect this is caused by your use of '@ac_*'
>> instead
>> of spelling out all the ac_ members added in qapi-schema.json in 4/5
>> -
>
> Hmm, adding them all will be a pretty long list, and it will probably
> become alo
Block driver documentation is available in qemu-doc.html. It would be
convenient to have documentation for formats, protocols, and filter
drivers in a man page.
Extract the relevant part of qemu-doc.html into a new file called
docs/qemu-block-drivers.texi. This file can also be built as a
stand-
On Mon, Jul 24, 2017 at 11:46:14AM +0200, Kevin Wolf wrote:
> Am 27.06.2017 um 17:41 hat Stefan Hajnoczi geschrieben:
> > Extract the relevant part of qemu-doc.html into a new file called
> > docs/qemu-block-drivers.texi. This file can also be built as a
> > stand-alone document (man, html, etc).
On 26/07/2017 14:59, Thomas Huth wrote:
> The list in the Wiki is not up to date anymore, so let's simply point
> the users to the file list on the download server instead.
>
> Signed-off-by: Thomas Huth
> ---
> _includes/releases.html | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
On 26/07/2017 14:52, Michael S. Tsirkin wrote:
> On Wed, Jul 26, 2017 at 11:31:36AM +0200, Paolo Bonzini wrote:
>> The tables that QEMU provides are not ACPI 1.0 compatible since commit
>> 77af8a2b95 ("hw/i386: Use Rev3 FADT (ACPI 2.0) instead of Rev1 to improve
>> guest OS support.", 2017-05-03).
The list in the Wiki is not up to date anymore, so let's simply point
the users to the file list on the download server instead.
Signed-off-by: Thomas Huth
---
_includes/releases.html | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/_includes/releases.html b/_includes/releases
On Wed, Jul 26, 2017 at 11:31:36AM +0200, Paolo Bonzini wrote:
> The tables that QEMU provides are not ACPI 1.0 compatible since commit
> 77af8a2b95 ("hw/i386: Use Rev3 FADT (ACPI 2.0) instead of Rev1 to improve
> guest OS support.", 2017-05-03). This is visible with Windows 2000,
> which refuses
Hi,
> error message). I suspect this is caused by your use of '@ac_*'
> instead
> of spelling out all the ac_ members added in qapi-schema.json in 4/5
> -
Hmm, adding them all will be a pretty long list, and it will probably
become alot longer when we add more missing keys in 2.11 ...
Should
On Wednesday, July 26, 2017 7:55 PM, Michal Hocko wrote:
> On Wed 26-07-17 19:44:23, Wei Wang wrote:
> [...]
> > I thought about it more. Probably we can use the callback function
> > with a little change like this:
> >
> > void walk_free_mem(void *opaque1, void (*visit)(void *opaque2,
> > unsigned
On Wed, Jul 26, 2017 at 02:33:10PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > FYI, after adding qcodes to the keycodemapdb, (but not having picked
> > your branch),
>
> I don't think this is a good idea. qkeycode numbers are a qemu-private
> thing, they can (and did in the past) change. The nam
Stefan Hajnoczi writes:
> On Tue, Jul 25, 2017 at 06:11:43PM +0300, Lluís Vilanova wrote:
>> Peter Maydell writes:
>>
>> > On 25 July 2017 at 14:19, Stefan Hajnoczi wrote:
>> >> Instead I suggest adding a trace backend generates calls to registered
>> >> "callback" functions:
>> >>
>> >> $ cat
> I wondered if this would work, but didn't mention anything on the
> assumption that it built for you. But now that patchew is
> complaining
> about a failed build, I suspect your attempt at abbreviation here is
> the
> reason.
It worked for me, but only because it didn't build the docs.
Insta
On Wed, 2017-07-26 at 07:12 -0500, Eric Blake wrote:
> On 07/26/2017 07:08 AM, Daniel P. Berrange wrote:
> > On Wed, Jul 26, 2017 at 07:02:48AM -0500, Eric Blake wrote:
> > > On 07/26/2017 06:56 AM, Gerd Hoffmann wrote:
> > > > Add multimedia keys to QKeyCodes and to the keymaps.
> > > >
> > > > S
Hi,
> FYI, after adding qcodes to the keycodemapdb, (but not having picked
> your branch),
I don't think this is a good idea. qkeycode numbers are a qemu-private
thing, they can (and did in the past) change. The names are api and
must not change.
> I was actually just going add an entry for
Stefan Hajnoczi writes:
> On Tue, Jul 25, 2017 at 05:47:08PM +0300, Lluís Vilanova wrote:
>> Stefan Hajnoczi writes:
>>
>> > On Mon, Jul 24, 2017 at 08:02:24PM +0300, Lluís Vilanova wrote:
>> >> This series adds a basic interface to instrument tracing events and
>> >> control
>> >> their tracing
On 26/07/2017 14:19, Daniel P. Berrange wrote:
> On Wed, Jul 26, 2017 at 01:57:35PM +0200, Thomas Huth wrote:
>> On 26.07.2017 13:44, Paolo Bonzini wrote:
>>> We don't want the page to become too long, but these are good suggestions.
>>>
>>> Also tone down the sentence about using the latest releas
On 07/26/2017 07:19 AM, Daniel P. Berrange wrote:
> On Wed, Jul 26, 2017 at 01:57:35PM +0200, Thomas Huth wrote:
>> On 26.07.2017 13:44, Paolo Bonzini wrote:
>>> We don't want the page to become too long, but these are good suggestions.
>>>
>>> Also tone down the sentence about using the latest rel
Peter Maydell writes:
> On 26 July 2017 at 12:26, Stefan Hajnoczi wrote:
>> On Tue, Jul 25, 2017 at 02:30:06PM +0100, Peter Maydell wrote:
>>> Is your proposal that my-instrumentation.c gets compiled into
>>> QEMU at this point? That doesn't seem like a great idea to
>>> me, because it means you
On 07/26/2017 06:56 AM, Gerd Hoffmann wrote:
> Fixes: 8c10e0baf0260b59a4e984744462a18016662e3e
> Signed-off-by: Gerd Hoffmann
> ---
> hw/input/ps2.c | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/hw/input/ps2.c b/hw/input/ps2.c
Code fix by deletion is always fun (but is it really b
On 07/26/2017 06:56 AM, Gerd Hoffmann wrote:
> Add recently added QKeyCodes to the keymaps.
>
> Signed-off-by: Gerd Hoffmann
> ---
> ui/input-keymap.c | 7 +++
> 1 file changed, 7 insertions(+)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Hi Diana,
On 23/05/2017 13:12, Diana Craciun wrote:
> The PCI requester ID field is 16 bits. The requester_id field
> from MemTxAttrs is used for MSIs to specify the device ID for
> the platforms where this device ID is needed (e.g virt machine + GICv3
> ITS). However, if more entities that uses MS
On 07/26/2017 06:56 AM, Gerd Hoffmann wrote:
> Add multimedia keys to QKeyCodes and to the keymaps.
>
> Signed-off-by: Gerd Hoffmann
> ---
> ui/input-keymap.c | 44
> qapi-schema.json | 17 -
> 2 files changed, 60 insertions(+), 1 del
Hi Diana,
On 23/05/2017 13:12, Diana Craciun wrote:
> Device IDs are required by the ARM GICv3 ITS for IRQ remapping.
> Currently, for PCI devices, the requester ID was used as device
> ID in the virt machine. If the system has multiple masters that
if the system has multiple root complex?
> use MS
On 07/26/2017 07:09 AM, no-re...@patchew.org wrote:
> Hi,
>
> This series failed build test on s390x host. Please find the details below.
>
> Message-id: 20170726115637.21558-1-kra...@redhat.com
> Subject: [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10
> Type: series
>
> GEN docs/inte
On Wed, Jul 26, 2017 at 01:57:35PM +0200, Thomas Huth wrote:
> On 26.07.2017 13:44, Paolo Bonzini wrote:
> > We don't want the page to become too long, but these are good suggestions.
> >
> > Also tone down the sentence about using the latest release or latest git
> > tree, though we do prefer tho
On 07/26/2017 06:56 AM, Gerd Hoffmann wrote:
> Move from input-linux.c to input-keymap.c and export it,
> so the function is available elsewhere too.
>
> Signed-off-by: Gerd Hoffmann
> ---
> include/ui/input.h | 1 +
> ui/input-keymap.c | 115
> +++
On 26/07/2017 13:52, Peter Maydell wrote:
>> * Reproduce the problem directly with a QEMU command-line. Avoid frontends
>> and management stacks, to ensure that the bug is in QEMU itself and not in a
>> frontend.
>>
>> -* Include as information about the guest (operating system, version,
>> 32
On 07/26/2017 07:08 AM, Daniel P. Berrange wrote:
> On Wed, Jul 26, 2017 at 07:02:48AM -0500, Eric Blake wrote:
>> On 07/26/2017 06:56 AM, Gerd Hoffmann wrote:
>>> Add multimedia keys to QKeyCodes and to the keymaps.
>>>
>>> Signed-off-by: Gerd Hoffmann
>>> ---
>>> ui/input-keymap.c | 44
Hi,
This series failed build test on s390x host. Please find the details below.
Message-id: 20170726115637.21558-1-kra...@redhat.com
Subject: [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git check
On Wed, Jul 26, 2017 at 01:44:07PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > qcodes as currently defined cover only a subset of the AT set1
> > scancodes,
> > so we need to define countless more qcodes before we consider
> > converting
> > UIs to use qcodes.
> >
> > Aside from the pause/break bug
On 26/07/2017 13:57, Thomas Huth wrote:
> On 26.07.2017 13:44, Paolo Bonzini wrote:
>> We don't want the page to become too long, but these are good suggestions.
>>
>> Also tone down the sentence about using the latest release or latest git
>> tree, though we do prefer those.
>
> Well, sometimes p
On Wed, Jul 26, 2017 at 07:02:48AM -0500, Eric Blake wrote:
> On 07/26/2017 06:56 AM, Gerd Hoffmann wrote:
> > Add multimedia keys to QKeyCodes and to the keymaps.
> >
> > Signed-off-by: Gerd Hoffmann
> > ---
> > ui/input-keymap.c | 44
> > qapi-schem
When the function no success value to transmit, it usually make the
function return void. It has turned out not to be a success, because
it means that the extra local_err variable and error_propagate() will
be needed. It leads to cumbersome code, therefore, transmit success/
failure in the return v
Quoting David Gibson (2017-07-26 00:24:43)
> On Tue, Jul 25, 2017 at 08:00:47PM +0200, Greg Kurz wrote:
> > From: Michael Roth
> >
> > device_unparent(dev, ...) is called when a device is unparented,
> > either directly, or as a result of a parent device being
> > finalized, and handles some fina
Pass the error message to errp directly rather than the local
variable local_err and propagate it to errp via error_propagate().
Cc: John Snow
Cc: Kevin Wolf
Cc: Max Reitz
Cc: Keith Busch
Cc: Stefan Hajnoczi
Cc: "Michael S. Tsirkin"
Cc: Paolo Bonzini
Cc: Gerd Hoffmann
Cc: Markus Armbruster
On 26/07/2017 13:42, Laszlo Ersek wrote:
> Not exactly; the PCD controls whether the EFI_ACPI_TABLE_PROTOCOL will
> expose an RSDT, an XSDT, or both (with matching contents).
You're right that the code does not produce a v1 FADT, I mis-skimmed the
awful code of AcpiTableDxe. Though the intentions
The function name of usb_msd_{realize,unrealize}_*,
usb_msd_class_initfn_* are unusual. Rename it to
usb_msd_*_{realize,unrealize}, usb_msd_class_*_initfn.
Cc: Gerd Hoffmann
Signed-off-by: Mao Zhongyi
---
hw/usb/dev-storage.c | 20 ++--
1 file changed, 10 insertions(+), 10 dele
On 07/26/2017 06:56 AM, Gerd Hoffmann wrote:
> Add multimedia keys to QKeyCodes and to the keymaps.
>
> Signed-off-by: Gerd Hoffmann
> ---
> ui/input-keymap.c | 44
> qapi-schema.json | 17 -
> 2 files changed, 60 insertions(+), 1 del
On 07/26/2017 05:31 AM, Dong Jia Shi wrote:
> * Halil Pasic [2017-07-26 00:44:41 +0200]:
>
>> According to the PoP channel command words (CCW) must be doubleword
>> aligned and 31 bit addressable for format 1 and 24 bit addressable for
>> format 0 CCWs.
>>
>> If the channel subsystem encounters
201 - 300 of 398 matches
Mail list logo
