On Mon, Jun 26, 2017 at 09:20:45PM +0200, Patrick Steinhardt wrote:
> The function `v9fs_xattrcreate` makes use of the define `XATTR_SIZE_MAX`
> to reject attempts of creating xattrs with an invalid size, which is
> defined in . On glibc-based systems, this header is
> indirectly included via , ,
>
Paolo Bonzini writes:
> On 10/08/2017 18:36, Markus Armbruster wrote:
+while (!QSIMPLEQ_EMPTY(&oo_queue)) {
+ObjectOptionsQueueEntry *e = QSIMPLEQ_FIRST(&oo_queue);
+
+QSIMPLEQ_REMOVE_HEAD(&oo_queue, entry);
+qapi_free_ObjectOptions(e->oo);
>>>
On 2017年08月11日 03:22, Radim Krčmář wrote:
> 2017-08-10 15:16-0300, Eduardo Habkost:
>> On Thu, Aug 10, 2017 at 02:41:03PM +0200, Radim Krčmář wrote:
>>> 2017-08-10 19:02+0800, Lan Tianyu:
On 2017年08月10日 18:26, Daniel P. Berrange wrote:
> On Thu, Aug 10, 2017 at 06:08:07PM +0800, Lan Tianyu
Now that we've got a firmware that can do TFTP booting on s390x (i.e.
the pc-bios/s390-netboot.img), we can enable the PXE tester for this
architecture, too.
Signed-off-by: Thomas Huth
---
tests/Makefile.include | 1 +
tests/boot-sector.c| 20
tests/pxe-test.c |
Re-using the boot_sector code buffer from x86 for other architectures
is not very nice, especially if we add more architectures later. It's
also ugly that the test uses a huge pre-initialized array at all - the
size of the executable is very huge due to this array. So let's use a
separate buffer fo
The first patch improves the buffer handling in the pxe tester a
little bit by allocating a separate buffer on the heap for each
architecture. This also gets rid of the huge pre-initialized
array in the tester, shrinking the size of the executable by
half of a megabyte!
The second patch adds s390x
On Tue, Aug 08, 2017 at 06:26:25PM +0200, Juan Quintela wrote:
> We make the locking and the transfer of information specific, even if we
> are still receiving things through the main thread.
>
> Signed-off-by: Juan Quintela
>
> --
>
> We split when we create the main channel and where we start
On Tue, Aug 08, 2017 at 06:26:29PM +0200, Juan Quintela wrote:
> Each time that we sync the bitmap, it is a possiblity that we receive
> a page that is being processed by a different thread. We fix this
> problem just making sure that we wait for all receiving threads to
> finish its work before w
On Tue, Aug 08, 2017 at 06:26:12PM +0200, Juan Quintela wrote:
> As this is defined on glib 2.32, add compatibility macros for older glibs.
>
> Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
--
Peter Xu
On Tue, Aug 08, 2017 at 06:26:11PM +0200, Juan Quintela wrote:
[...]
> void migration_fd_process_incoming(QEMUFile *f)
> {
> -Coroutine *co = qemu_coroutine_create(process_incoming_migration_co, f);
> -
> +Coroutine *co = qemu_coroutine_create(process_incoming_migration_co,
> NULL);
>
On 08/10/2017 01:28 PM, Markus Armbruster wrote:
Eric Blake writes:
On 08/10/2017 07:25 AM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
for the refactor:
Reviewed-by: Philippe Mathieu-Daudé
---
vl.c | 21 ++---
1 file changed, 10 insertions(+), 11 deleti
---
nbd/server.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/nbd/server.c b/nbd/server.c
index 82a78bf439..d6fbd46370 100644
--- a/nbd/server.c
+++ b/nbd/server.c
@@ -919,6 +919,17 @@ static int nbd_send_reply(QIOChannel *ioc, NBDReply
*reply, Error **errp)
stl_be_p(buf
As soon as the server is sending us garbage, we should quit
trying to send further messages to the server, and allow all
pending coroutines for any remaining replies to error out.
Failure to do so can let a malicious server cause the client
to hang, for example, if the server sends an invalid magic
Patch 1 is a much smaller patch than Vladimir's attempt [1] at fixing
the client in the face of a malicious server.
[1] https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg01501.html
Patch 2 is not to be applied; it is a hack for easily creating a
malicious server; by setting NBD_SERVER_DEBU
NBD_CMD_DISC is a disconnect request, not a data discard request.
Signed-off-by: Eric Blake
---
Although this is not 2.10 material in isolation (it is only a
bad trace message), I don't mind including it in a larger pull
request; I'm still planning to fix the issue of a client hanging
on a malic
在 8/10/2017 8:26 PM, Vladimir Sementsov-Ogievskiy 写道:
09.08.2017 17:11, Vladimir Sementsov-Ogievskiy wrote:
Hi Wen!
I'm trying to understand block/replication code and have a question.
Why should we block the region from intersecting cow requests when
read? If I understand correctly
regardl
Using '-cpu 486' gets past the assertion error. I guess Windows NT 4.0
is not compatible with newer Intel processors.
Currently I can install Windows NT 4.0, but booting from the
installation has its problems. It won't boot unless you use the NTFS
file system. Even with this file system I still se
On PCI init PCI bridges may need some extra info about bus number,
IO, memory and prefetchable memory to reserve. QEMU can provide this
with a special vendor-specific PCI capability.
Signed-off-by: Aleksandr Bezzubikov
Reviewed-by: Marcel Apfelbaum
---
hw/pci/pci_bridge.c | 54 +
Signed-off-by: Aleksandr Bezzubikov
---
docs/pcie.txt| 49 ++--
docs/pcie_pci_bridge.txt | 115 +++
2 files changed, 141 insertions(+), 23 deletions(-)
create mode 100644 docs/pcie_pci_bridge.txt
diff --git a/docs/pcie.txt
Introduce a new PCIExpress-to-PCI Bridge device,
which is a hot-pluggable PCI Express device and
supports devices hot-plug with SHPC.
This device is intended to replace the DMI-to-PCI Bridge.
Signed-off-by: Aleksandr Bezzubikov
---
hw/pci-bridge/Makefile.objs | 2 +-
hw/pci-bridge/pcie_pc
This series introduces a new device - Generic PCI Express to PCI bridge,
and also makes all necessary changes to enable hotplug of the bridge itself
and any device into the bridge.
Changes v4->v5:
1. Change PCIE-PCI Bridge license (addresses Marcel's comment)
2. The capability layout changes (adre
To enable hotplugging of a newly created pcie-pci-bridge,
we need to tell firmware (e.g. SeaBIOS) to reserve
additional buses or IO/MEM/PREF space for pcie-root-port.
Additional bus reservation allows us to hotplug pcie-pci-bridge into this root
port.
The number of buses and IO/MEM/PREF space to r
In case of Red Hat Generic PCIE Root Port reserve additional buses
and/or IO/MEM/PREF space, which values are provided in a vendor-specific
capability.
Signed-off-by: Aleksandr Bezzubikov
---
src/fw/dev-pci.h | 2 +-
src/fw/pciinit.c | 125 +
On PCI init PCI bridge devices may need some
extra info about bus number to reserve, IO, memory and
prefetchable memory limits. QEMU can provide this
with special vendor-specific PCI capability.
This capability is intended to be used only
for Red Hat PCI bridges, i.e. QEMU cooperation.
Signed-off
Now PCI bridges get a bus range number on a system init,
basing on currently plugged devices. That's why when one wants to hotplug
another bridge,
it needs his child bus, which the parent is unable to provide (speaking about
virtual device).
The suggested workaround is to have vendor-specific cap
One of the cases of the SSE4.2 pcmpestri / pcmpestrm / pcmpistri /
pcmpistrm instructions does a substring search. The implementation of
this case in the pcmpxstrx helper is incorrect. The operation in this
case is a search for a string (argument d to the helper) in another
string (argument s to
On Thu, Aug 10, 2017 at 05:52:55PM +0100, Richard W.M. Jones wrote:
> Since Linux switched to blk-mq as the default in Linux commit
> 5c279bd9e406 ("scsi: default to scsi-mq"), virtio-scsi LUNs consume
> about 10x as much guest kernel memory.
>
> This commit allows you to choose the virtqueue size
Host:
Operating system: Mac OS 10.12.5
GCC: Apple LLVM version 8.1.0 (clang-802.0.42)
Command to reproduce: ./configure --target-list=ppc-softmmu,i386-softmmu &&
make -j 4
During compiling I saw these warning messages:
CC ppc-softmmu/hw/char/virtio-serial-bus.o
/Users/john/Documents/Dev
Host: Mac OS 10.12.5
Compiler: Apple LLVM version 8.1.0 (clang-802.0.42)
Command used: ./configure --target-list=ppc-softmmu,i386-softmmu && make -j 4
While compiling I saw these error messages:
slirp/ip6_icmp.c:79:32: warning: taking address of packed member 'ip_src' of
class or
structure
Host info:
Operating system: Mac OS 10.12.5
Compiler: Apple LLVM version 8.1.0 (clang-802.0.42)
Command to reproduce: ./configure --target-list=ppc-softmmu,i386-softmmu &&
make -j 4
When compiling QEMU I see these warning messages:
CC block/vdi.o
block/qcow.c:138:19: warning: taking addr
Hi,
I am having an issue with getting a CPU external interrupt to occur from my own
device model. The custom device is a set of registers than can be read and
written to. The plan is whenever a particular register is written into, an
external interrupt will occur.
I tried to use the function c
2017-08-10 15:16-0300, Eduardo Habkost:
> On Thu, Aug 10, 2017 at 02:41:03PM +0200, Radim Krčmář wrote:
> > 2017-08-10 19:02+0800, Lan Tianyu:
> > > On 2017年08月10日 18:26, Daniel P. Berrange wrote:
> > >> On Thu, Aug 10, 2017 at 06:08:07PM +0800, Lan Tianyu wrote:
> > >>> Intel Xeon phi chip will su
On 08/10/2017 10:55 AM, Daniel P. Berrange wrote:
> Always use QKeyCode in the InputKeyEvent struct, by converting key
> numbers to QKeyCode at the time the event is created.
>
> Signed-off-by: Daniel P. Berrange
> ---
> ui/input.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
On 08/10/2017 10:55 AM, Daniel P. Berrange wrote:
> Now that keycode numbers are converted to QKeyCodes immediately
> when creating input events, the InputKeyEvent struct can be
> changed to only accept a QKeyCode, instead of a KeyValue.
>
> Signed-off-by: Daniel P. Berrange
> ---
> +++ b/qapi-s
On 08/10/2017 10:55 AM, Daniel P. Berrange wrote:
> Replace the number_to_qcode, qcode_to_number and linux_to_qcode
> tables with automatically generated tables.
>
> Missing entries in linux_to_qcode now fixed:
> In additionsome fixes:
s/additionsome/addition, some/
>
> - KEY_PLAYPAUSE now ma
On 08/10/2017 01:30 PM, Markus Armbruster wrote:
> A command is a query if it has no side effect and yields a result.
> Such commands are typically named query-FOO, but there are exceptions.
>
> The basic idea is to find candidates with query-qmp-schema, filter out
> the ones that aren't queries w
> On Aug 10, 2017, at 3:37 AM, Michael Tokarev wrote:
>
> 10.08.2017 06:51, Thomas Huth wrote:
> []
>
>> I guess you'll end up with QEMU 2.1 as good version and 2.2 as the first
>> "bad" version. According the qemu-doc:
>>
>> -vga type
>>
>>Select type of VGA card to emulate. Valid values
On 08/10/2017 11:04 AM, Daniel P. Berrange wrote:
> The inet_parse() function looks for 'ipv4' and 'ipv6'
> flags, but only treats them as bare bool flags. The normal
> QemuOpts parsing would allow on/off values to be set too.
>
> This updated inet_parse() so that its handling of the
s/updated/up
A command is a query if it has no side effect and yields a result.
Such commands are typically named query-FOO, but there are exceptions.
The basic idea is to find candidates with query-qmp-schema, filter out
the ones that aren't queries with an explicit blacklist, and test the
remaining ones agai
On 08/10/2017 11:04 AM, Daniel P. Berrange wrote:
> Instead of creating a QIOChannelSocket directly for the NBD
> server socket, use a QIONetListener. This provides the ability
> to listen on multiple sockets at the same time, so enables
> full support for IPv4/IPv6 dual stack.
>
> Signed-off-by:
On 08/10/2017 10:55 AM, Daniel P. Berrange wrote:
> The https://gitlab.com/keycodemap/keycodemapdb/ repo contains a
> data file mapping between all the different scancode/keycode/keysym
> sets that are known, and a tool to auto-generate lookup tables for
> different combinations.
>
> It is used by
Michael,
This fixes annoying bugs introduced by the CVE-2016-9602 fixes in 2.9.
Please consider picking it for 2.9.1.
Cheers,
--
Greg
On Thu, 10 Aug 2017 18:02:41 +0200
Greg Kurz wrote:
> This function has to ensure it doesn't follow a symlink that could be used
> to escape the virtfs directo
On Thu, Aug 10, 2017 at 02:41:03PM +0200, Radim Krčmář wrote:
> 2017-08-10 19:02+0800, Lan Tianyu:
> > On 2017年08月10日 18:26, Daniel P. Berrange wrote:
> >> On Thu, Aug 10, 2017 at 06:08:07PM +0800, Lan Tianyu wrote:
> >>> Intel Xeon phi chip will support 352 logical threads. For HPC
> >>> usage cas
On 08/10/2017 11:04 AM, Daniel P. Berrange wrote:
> Instead of creating a QIOChannelSocket directly for the NBD
> server socket, use a QIONetListener. This provides the ability
> to listen on multiple sockets at the same time, so enables
> full support for IPv4/IPv6 dual stack.
>
> Signed-off-by:
On 08/10/2017 11:04 AM, Daniel P. Berrange wrote:
> The existing QIOChannelSocket class provides the ability to
> listen on a single socket at a time. This patch introduces
> a QIONetListener class that provides a higher level API
> concept around listening for network services, allowing
> for list
On Wed, Aug 09, 2017 at 11:58:20PM -0400, Lan Tianyu wrote:
> Intel Xeon phi chip will support 352 logical threads. For HPC
> usage case, it will create a huge VM with vcpus number as same as host
> cpus. This patch is to increase max vcpu number to 352.
There is this ioctl called KVM_CAP_MAX_VCPU
Hi,
This series failed build test on s390x host. Please find the details below.
Subject: [Qemu-devel] [PATCH 0/2] QEMU Backup Tool
Type: series
Message-id: 1502387075-29078-1-git-send-email-chugh.ish...@research.iiit.ac.in
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked un
From: Kevin Wolf
Signed-off-by: Kevin Wolf
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Signed-off-by: Stefan Hajnoczi
Message-id: 20170809160212.29976-3-stefa...@redhat.com
Signed-off-by: Stefan Hajnoczi
---
tests/ide-test.c | 19 +++
1 file changed, 19 insertions(+)
d
The block backend changed in a way that flushing empty CDROM drives now
crashes. Amend IDE to avoid doing so until the root problem can be
addressed for 2.11.
Original patch by John Snow .
Reported-by: Kieron Shorrock
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
Message-id: 20170809
If blk_getlength() fails in virtio_blk_update_config() consider the disk
image length to be 0 bytes.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Fam Zheng
Message-id: 20170808122251.29815-1-stefa...@redhat.com
Signed-off-by: Stefan Hajnoczi
---
hw/block/virtio-blk.c | 4 +++-
1 file changed, 3
The following changes since commit b38df311c174c98ef8cce7dec9f46603b083018e:
Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.10-20170809'
into staging (2017-08-10 11:12:36 +0100)
are available in the git repository at:
git://github.com/stefanha/qemu.git tags/block-pull-request
On 10/08/2017 13:44, Thomas Huth wrote:
> While Andrew S. Tanenbaum has a point by saying "Never underestimate the
> bandwidth of a station wagon full of tapes hurtling down the highway",
> we don't support that way of transportation in QEMU yet, so replace the
> typo with the correct word "vlan".
On 10 August 2017 at 17:02, Greg Kurz wrote:
> The following changes since commit b38df311c174c98ef8cce7dec9f46603b083018e:
>
> Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.10-20170809'
> into staging (2017-08-10 11:12:36 +0100)
>
> are available in the git repository at:
>
>
qemu-backup will be a command-line tool for performing full and
incremental disk backups on running VMs. It is intended as a
reference implementation for management stack and backup developers
to see QEMU's backup features in action. The tool writes details of
guest in a configuration file and the
qemu-backup will be a command-line tool for performing full and
incremental disk backups on running VMs. It is intended as a
reference implementation for management stack and backup developers
to see QEMU's backup features in action. The following commit is an
initial implementation of manpage list
This patch series is intended to introduce QEMU Backup tool.
qemu-backup will be a command-line tool for performing full and
incremental disk backups on running VMs. It is intended as a
reference implementation for management stack and backup developers
to see QEMU's backup features in action.
This
On Thu, Aug 10, 2017 at 9:18 AM, Ashijeet Acharya
wrote:
> On Thu, Aug 10, 2017 at 1:41 PM, Stefan Hajnoczi wrote:
>>
>> On Thu, Jul 27, 2017 at 3:33 PM, Ashijeet Acharya
>> wrote:
>> > Previously posted series patches:
>> > v1 -
>> > http://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg02
Since Linux switched to blk-mq as the default in Linux commit
5c279bd9e406 ("scsi: default to scsi-mq"), virtio-scsi LUNs consume
about 10x as much guest kernel memory.
This commit allows you to choose the virtqueue size for each
virtio-scsi-pci controller like this:
-device virtio-scsi-pci,id=
On Thu, Aug 10, 2017 at 09:10:51AM -0700, no-re...@patchew.org wrote:
> Hi,
>
> This series failed build test on s390x host. Please find the details below.
>
> Subject: [Qemu-devel] [PATCH 00/15] Convert over to use keycodemapdb
> Type: series
> Message-id: 20170810155522.31099-1-berra...@redhat.
On 10/08/2017 18:36, Markus Armbruster wrote:
>>> +while (!QSIMPLEQ_EMPTY(&oo_queue)) {
>>> +ObjectOptionsQueueEntry *e = QSIMPLEQ_FIRST(&oo_queue);
>>> +
>>> +QSIMPLEQ_REMOVE_HEAD(&oo_queue, entry);
>>> +qapi_free_ObjectOptions(e->oo);
>>> +g_free(e);
>>> +}
Paolo Bonzini writes:
> On 10/08/2017 14:25, Markus Armbruster wrote:
>> We've wanted -object to support non-scalar properties for a while.
>> Dan Berrange tried in "[PATCH v4 00/10]Provide a QOM-based
>> authorization API". Review led to the conclusion that we need to
>> replace rather than add
Hi,
This series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.
Message-id: 20170810160451.32723-1-berra...@redhat.com
Subject: [Qemu-devel] [PATCH 0/8] Enable full IPv4/IPv6 dual stack supp
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20170810160451.32723-1-berra...@redhat.com
Subject: [Qemu-devel] [PATCH 0/8] Enable full IPv4/IPv6 dual stack support
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
tot
Eric Blake writes:
> On 08/10/2017 09:06 AM, Pradeep Jagadeesh wrote:
>
It's not "moving it back", it's keeping it where it is. But I see no big
problem with moving it to a common file either.
>>>
>>> I'd rather not put every struct shared across subsystem boundaries in
>>> its own file
Eric Blake writes:
> On 08/10/2017 07:25 AM, Markus Armbruster wrote:
>> We've wanted -object to support non-scalar properties for a while.
>> Dan Berrange tried in "[PATCH v4 00/10]Provide a QOM-based
>> authorization API". Review led to the conclusion that we need to
>> replace rather than add
Eric Blake writes:
> On 08/10/2017 07:25 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster
>> ---
>> vl.c | 21 ++---
>> 1 file changed, 10 insertions(+), 11 deletions(-)
>>
>
>> +++ b/vl.c
>> @@ -2845,7 +2845,6 @@ static bool object_create_initial(const char *ty
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20170810155522.31099-1-berra...@redhat.com
Subject: [Qemu-devel] [PATCH 00/15] Convert over to use keycodemapdb
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(g
Hi,
This series failed build test on s390x host. Please find the details below.
Subject: [Qemu-devel] [PATCH 00/15] Convert over to use keycodemapdb
Type: series
Message-id: 20170810155522.31099-1-berra...@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under th
Hi,
This series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.
Message-id: 20170810155522.31099-1-berra...@redhat.com
Subject: [Qemu-devel] [PATCH 00/15] Convert over to use keycodemapdb
Ty
The VNC server already has the ability to listen on multiple sockets.
Converting it to use the QIONetListener APIs though, will reduce the
amount of code in the VNC server and improve the clarity of what is
left.
Signed-off-by: Daniel P. Berrange
---
ui/vnc.c | 194 ++
Hi,
This series failed build test on FreeBSD host. Please find the details below.
Subject: [Qemu-devel] [PATCH 00/15] Convert over to use keycodemapdb
Type: series
Message-id: 20170810155522.31099-1-berra...@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/sh
# Testing script will be invoked under th
The inet_parse() function looks for 'ipv4' and 'ipv6'
flags, but only treats them as bare bool flags. The normal
QemuOpts parsing would allow on/off values to be set too.
This updated inet_parse() so that its handling of the
'ipv4' and 'ipv6' flags matches that done by QemuOpts.
Signed-off-by: Da
Instead of creating a QIOChannelSocket directly for the NBD
server socket, use a QIONetListener. This provides the ability
to listen on multiple sockets at the same time, so enables
full support for IPv4/IPv6 dual stack.
Signed-off-by: Daniel P. Berrange
---
qemu-nbd.c | 50 +
The existing QIOChannelSocket class provides the ability to
listen on a single socket at a time. This patch introduces
a QIONetListener class that provides a higher level API
concept around listening for network services, allowing
for listening on multiple sockets.
Signed-off-by: Daniel P. Berrang
The semantics around handling ipv4=on|off & ipv6=on|off are quite
subtle to understand in combination with the various hostname addresses
and backend types. Introduce a massive test matrix that launches QEMU
and validates the ability to connect a client on each protocol as
appropriate.
The test re
Instead of creating a QIOChannelSocket directly for the chardev
server socket, use a QIONetListener. This provides the ability
to listen on multiple sockets at the same time, so enables
full support for IPv4/IPv6 dual stack.
Signed-off-by: Daniel P. Berrange
---
chardev/char-socket.c | 70 +
Currently all the network listeners in QEMU, except the VNC server,
are restricted to listening on a single socket. This makes it
impossible to fully support IPv4/IPv6 dual stack. We're restricted
to using IPV6_V6ONLY=0 to listen on both protocols from a single
socket, but this doesn't work at all
Instead of creating a QIOChannelSocket directly for the migration
server socket, use a QIONetListener. This provides the ability
to listen on multiple sockets at the same time, so enables
full support for IPv4/IPv6 dual stack.
Signed-off-by: Daniel P. Berrange
---
migration/socket.c | 44
The following changes since commit b38df311c174c98ef8cce7dec9f46603b083018e:
Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.10-20170809'
into staging (2017-08-10 11:12:36 +0100)
are available in the git repository at:
https://github.com/gkurz/qemu.git tags/for-upstream
for yo
Instead of creating a QIOChannelSocket directly for the NBD
server socket, use a QIONetListener. This provides the ability
to listen on multiple sockets at the same time, so enables
full support for IPv4/IPv6 dual stack.
Signed-off-by: Daniel P. Berrange
---
blockdev-nbd.c | 50 -
This function has to ensure it doesn't follow a symlink that could be used
to escape the virtfs directory. This could be easily achieved if fchmodat()
on linux honored the AT_SYMLINK_NOFOLLOW flag as described in POSIX, but
it doesn't. There was a tentative to implement a new fchmodat2() syscall
wi
Replace the scancode2linux table with an automatically
generated table. In doing so, the XenFB keyboard
handler is also converted to the modern InputEvent
framework.
Signed-off-by: Daniel P. Berrange
---
hw/display/xenfb.c | 131 -
1 file chang
The qemu_input_linux_to_qcode method is only used in one place and
no new code should require it, so inline it at the only caller.
Signed-off-by: Daniel P. Berrange
---
include/ui/input.h | 1 -
ui/input-keymap.c | 8
ui/input-linux.c | 4 ++--
3 files changed, 2 insertions(+), 11 de
Replace the mac_to_qkeycode_map table with automatically
generated table.
Signed-off-by: Daniel P. Berrange
---
include/ui/input.h | 3 ++
ui/Makefile.objs | 1 +
ui/cocoa.m | 129 +
ui/input-keymap.c | 1 +
4 files changed, 7
The x_keycode_to_pc_keycode and evdev_keycode_to_pc_keycode
tables are replaced with automatically generated tables.
In addition the X11 heuristics are improved to detect running
on XQuartz and XWin X11 servers, to activate the correct OS-X
and Win32 keycode maps.
Signed-off-by: Daniel P. Berrange
Replace the qcode_to_adb_keycode table with automatically
generated tables.
Missing entries in qcode_to_adb_keycode now fixed:
- Q_KEY_CODE_KP_COMMA -> 0x47
Signed-off-by: Daniel P. Berrange
---
hw/input/adb.c | 124 +-
include/hw/input/adb-key
Replace the keymap_qcode table with automatically generated
tables.
Missing entries in keymap_qcode now fixed:
Q_KEY_CODE_ASTERISK -> KEY_KPASTERISK
Q_KEY_CODE_KP_MULTIPLY -> KEY_KPASTERISK
Q_KEY_CODE_STOP -> KEY_STOP
Q_KEY_CODE_AGAIN -> KEY_AGAIN
Q_KEY_CODE_PROPS -> KEY_PROPS
Q_KEY_C
Replace the qcode_to_keycode table with automatically
generated tables.
Missing entries in qcode_to_keycode now fixed:
- Q_KEY_CODE_KP_COMMA -> 0x2d
Signed-off-by: Daniel P. Berrange
---
hw/char/escc.c | 126 +++--
include/ui/input.h | 3 +
The qemu_input_qcode_to_number method is only used in one place and
no new code should require it, so inline it at the only caller.
Signed-off-by: Daniel P. Berrange
---
include/ui/input.h | 1 -
ui/input-keymap.c | 16 +++-
2 files changed, 7 insertions(+), 10 deletions(-)
diff -
Replace the qcode_to_keycode_set1, qcode_to_keycode_set2,
and qcode_to_keycode_set3 tables with automatically
generated tables.
Missing entries in qcode_to_keycode_set1 now fixed:
- Q_KEY_CODE_SYSRQ -> 0x54
- Q_KEY_CODE_PRINT -> 0x54 (NB ignored due to special case)
- Q_KEY_CODE_AGAIN -> 0xe00
Always use QKeyCode in the InputKeyEvent struct, by converting key
numbers to QKeyCode at the time the event is created.
Signed-off-by: Daniel P. Berrange
---
ui/input.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/ui/input.c b/ui/input.c
index af05f06368..64e9103a61
Now that keycode numbers are converted to QKeyCodes immediately
when creating input events, the InputKeyEvent struct can be
changed to only accept a QKeyCode, instead of a KeyValue.
Signed-off-by: Daniel P. Berrange
---
hw/char/escc.c | 2 +-
hw/input/adb.c | 2 +-
hw
All public code should use qemu_input_event_send_key* functions
instead of creating an event directly.
Signed-off-by: Daniel P. Berrange
---
include/ui/input.h | 1 -
ui/input.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/ui/input.h b/include/ui/input.h
The https://gitlab.com/keycodemap/keycodemapdb/ repo contains a
data file mapping between all the different scancode/keycode/keysym
sets that are known, and a tool to auto-generate lookup tables for
different combinations.
It is used by GTK-VNC, SPICE-GTK and libvirt for mapping keys.
Using it in
The SDL2 scancodes are conveniently identical to the USB
scancodes. Replace the sdl2_scancode_to_qcode table with
an automatically generated table.
Missing entries in sdl2_scancode_to_qcode now fixed:
- 0x32 -> Q_KEY_CODE_BACKSLASH
- 0x66 -> Q_KEY_CODE_POWER
- 0x67 -> Q_KEY_CODE_KP_EQUALS
Replace the number_to_qcode, qcode_to_number and linux_to_qcode
tables with automatically generated tables.
Missing entries in linux_to_qcode now fixed:
KEY_LINEFEED -> Q_KEY_CODE_LF
KEY_KPEQUAL -> Q_KEY_CODE_KP_EQUALS
KEY_COMPOSE -> Q_KEY_CODE_COMPOSE
KEY_AGAIN -> Q_KEY_CODE_AGAIN
KEY_
The keycodemap project[1] provides a database mapping between
many different keysym/keycode/scancode sets, along with a
tool to generate mapping/lookup tables in various programming
languages. It is already used by GTK-VNC, SPICE-GTK and
libvirt.
This series enables its use in QEMU, thus fixing a
Tested-by: Zhi Yong Wu
Regards,
Zhi Yong Wu
At 2017-08-10 00:40:57, "Greg Kurz" wrote:
>This function has to ensure it doesn't follow a symlink that could be used
>to escape the virtfs directory. This could be easily achieved if fchmodat()
>on linux honored the AT_SYMLINK_NOFOLLOW flag as de
** Also affects: qemu
Importance: Undecided
Status: New
** Also affects: qemu (Ubuntu)
Importance: Undecided
Status: New
** No longer affects: qemu
** Changed in: ubuntu-power-systems
Assignee: (unassigned) => Canonical Server Team (canonical-server)
--
You received th
On 08/08/2017 11:26 AM, Juan Quintela wrote:
> This functions allows us to decide when to close the listener socket.
s/functions/function/
> For now, we only need one connection.
>
> Signed-off-by: Juan Quintela
> ---
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-30
1 - 100 of 197 matches
Mail list logo
