[Qemu-devel] [PATCH] x86: Skip check apic_id_limit for Xen

2017-08-15 Thread Lan Tianyu
Xen vIOMMU device model will be in Xen hypervisor. Skip vIOMMU check for Xen here when vcpu number is more than 255. Signed-off-by: Lan Tianyu --- hw/i386/pc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 5943539..fc17885 100644 --- a/hw/i

Re: [Qemu-devel] [PATCH for-2.11 v2 4/5] qmp-shell: Accept QMP command as argument

2017-08-15 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, Aug 15, 2017 at 12:03:53PM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> Suggest to insert here: >> >> If additional arguments QMP-COMMAND ARG=VAL... are given, run just >> that QMP command instead of the REPL. >> >> Question: is this l

[Qemu-devel] ask a question

2017-08-15 Thread 皮智
Hi,I meet a problem with vm, my environment is qemu-kvm-2.3, virtio-win-0.1.126, host(centos7.2), guest(windows10). libvirt xml has four virtio-serial channel as follows:

Re: [Qemu-devel] [PATCH v6 3/7] qemu.py: use python logging system

2017-08-15 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, Aug 15, 2017 at 10:10:12AM +0200, Markus Armbruster wrote: >> Please spell "Python" with a capital "P" (it's a proper name). >> >> Amador Pahim writes: >> >> > Let's provide extra control and flexibility by using python logging >> > system instead of print and

[Qemu-devel] [PATCH v3 2/2] x86: Increase max vcpu number to 8192

2017-08-15 Thread Lan Tianyu
For HPC usage case, it will create a huge VM with vcpus number as same as host cpus and this requires more vcpus support in a single VM. This patch is to increase max vcpu number from 288 to 8192 which is current default maximum cpu number for Linux kernel. Signed-off-by: Lan Tianyu --- hw/i386/

[Qemu-devel] [PATCH v3 1/2] pc: add 2.11 machine type

2017-08-15 Thread Lan Tianyu
Signed-off-by: Lan Tianyu --- hw/i386/pc_piix.c| 14 +++--- hw/i386/pc_q35.c | 14 +++--- include/hw/compat.h | 3 +++ include/hw/i386/pc.h | 3 +++ 4 files changed, 28 insertions(+), 6 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 11b4336..e99e

Re: [Qemu-devel] [PATCH v5 2/3] qmp: introduce query-memory-size-summary command

2017-08-15 Thread Markus Armbruster
Vadim Galitsyn writes: > Hi Guys, > > Thank you for the input! > >> "hotunpluggable" is ugly. What about just "pluggable"? > > Markus, I think "pluggable" is a bit misleading here. Some people can take > it like a maximum amount of memory that can be hot-added to a guest (i.e., > difference betw

Re: [Qemu-devel] a tiny tool for checking and repairing damaged qcow2 image

2017-08-15 Thread Markus Armbruster
Cc'ing QCOW2 maintainer. ÕÅÓÑ¼Ó writes: > Hi, > > I want to introduce a tiny tool(https://github.com/zhangyoujia/qcow2-dump) > for checking and repairing damaged qcow2 image. > > I met many damaged qcow2 images when I work. > > It does't always work by using the qemu-img command to check and re

[Qemu-devel] [PATCH] hw/s390x/ipl: The s390-ipl device is not hot-pluggable

2017-08-15 Thread Thomas Huth
The s390-ipl device can not be created by the user, since it is meant only to be instantiated once internally to load the ROMs and kernel. If the user tries to do a "device_add s390-ipl" via the monitor later, QEMU aborts with a "ROM images must be loaded at startup" error message. Signed-off-by:

[Qemu-devel] Crash when deleting the diag288 watchdog

2017-08-15 Thread Thomas Huth
Hi, I recently noticed that QEMU abort()s if you try to remove the diag288 watchdog. For example: $ qemu-system-s390x -nographic -nodefaults -S -monitor stdio QEMU 2.9.92 monitor - type 'help' for more information (qemu) device_add diag288,id=x (qemu) device_del x ** ERROR:/home/thuth/devel/qemu

Re: [Qemu-devel] [PATCH qemu v4 1/3] spapr_iommu: Realloc guest visible TCE table when hot(un)plugging vfio-pci

2017-08-15 Thread Alexey Kardashevskiy
On 09/08/17 17:33, David Gibson wrote: > On Mon, Jul 24, 2017 at 08:48:45PM +1000, Alexey Kardashevskiy wrote: >> On 24/07/17 15:53, David Gibson wrote: >>> On Thu, Jul 20, 2017 at 05:22:29PM +1000, Alexey Kardashevskiy wrote: This replaces g_malloc() with spapr_tce_alloc_table() as this is >>

Re: [Qemu-devel] [PATCH v2 0/4] i386/kvm: advertise Hyper-V frequency MSRs

2017-08-15 Thread Konrad Rzeszutek Wilk
On Tue, Aug 08, 2017 at 09:50:53PM -0300, Marcelo Tosatti wrote: > On Mon, Aug 07, 2017 at 10:56:59AM +0200, Ladi Prosek wrote: > > This is the QEMU part of the changes required for nested Hyper-V to read > > timestamps with RDTSC + TSC page. Without exposing the frequency MSRs, > > Windows with th

[Qemu-devel] [PATCH v3] hw/acpi-build: Fix SRAT memory building when there is no memory in node0

2017-08-15 Thread Dou Liyang
Currently, Using the fisrt node without memory on the machine makes QEMU unhappy. With this example command line: ... \ -m 1024M,slots=4,maxmem=32G \ -numa node,nodeid=0 \ -numa node,mem=1024M,nodeid=1 \ -numa node,nodeid=2 \ -numa node,nodeid=3 \ Guest reports "No NUMA configuration fo

[Qemu-devel] [PATCH v2] hw/acpi: Select an node with memory for mapping memory hole to

2017-08-15 Thread Dou Liyang
Currently, Using the fisrt node without memory on the machine makes QEMU unhappy. With this example command line: ... \ -m 1024M,slots=4,maxmem=32G \ -numa node,nodeid=0 \ -numa node,mem=1024M,nodeid=1 \ -numa node,nodeid=2 \ -numa node,nodeid=3 \ Guest reports "No NUMA configuration fo

Re: [Qemu-devel] [PATCH for-2.10] mmio-interface: Mark as not user creatable

2017-08-15 Thread Edgar E. Iglesias
On Tue, Aug 15, 2017 at 06:16:22PM +0200, Thomas Huth wrote: > On 15.08.2017 16:30, Peter Maydell wrote: > > The mmio-interface device is not something we want to allow > > users to create on the command line: > > * it is intended as an implementation detail of the memory > >subsystem, which g

Re: [Qemu-devel] Help with Windows NT 4.0

2017-08-15 Thread Paolo Bonzini
On 15/08/2017 20:46, Programmingkid wrote: > >> On Aug 14, 2017, at 2:51 AM, Paolo Bonzini wrote: >> >> On 13/08/2017 21:13, Programmingkid wrote: >>> Lately I found out that Windows NT 4.0 seems to work well with the >>> 486 and pentium processors. Using "-cpu 486" made installing it >>> actuall

Re: [Qemu-devel] [PATCH RFC] block: add block-insert-node QMP command

2017-08-15 Thread Eric Blake
On 08/15/2017 02:45 AM, Manos Pitsidianakis wrote: > block-insert-node and its pair command block-remove-node provide runtime > insertion and removal of filter nodes. > > block-insert-node takes a (parent, child) and (node, child) pair of > edges and unrefs the (parent, child) BdrvChild relationsh

Re: [Qemu-devel] [PATCH v3 1/1] PPC: KVM: Support machine option to set VSMT mode

2017-08-15 Thread Greg Kurz
On Tue, 15 Aug 2017 14:42:21 +1000 Sam Bobroff wrote: > KVM now allows writing to KVM_CAP_PPC_SMT which has previously been > read only. Doing so causes KVM to act, for that VM, as if the host's > SMT mode was the given value. This is particularly important on Power > 9 systems because their defa

[Qemu-devel] [ANNOUNCE] QEMU 2.10.0-rc3 is now available

2017-08-15 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 2.10 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-2.10.0-rc3.tar.xz http://do

Re: [Qemu-devel] [PATCH for-2.11 v2 4/5] qmp-shell: Accept QMP command as argument

2017-08-15 Thread Eduardo Habkost
On Tue, Aug 15, 2017 at 12:03:53PM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > Suggest to insert here: > > If additional arguments QMP-COMMAND ARG=VAL... are given, run just > that QMP command instead of the REPL. > > Question: is this limited to simple arguments? If no,

[Qemu-devel] [PATCH] hw/ppc: disable hotplug before CAS is completed

2017-08-15 Thread Daniel Henrique Barboza
This patch is a follow up on the discussions that started with Laurent's patch series "spapr: disable hotplugging without OS" [1] and discussions made at patch "spapr: reset DRCs on migration pre_load" [2]. At this moment, we do not support CPU/memory hotplug in early boot stages, before CAS. The

[Qemu-devel] [PATCH v2] net: rtl8139: do not use old_mmio accesses

2017-08-15 Thread Matt Parker
Both io and memory use the same mmio functions in the rtl8139 device. This patch removes the separate MemoryRegionOps and old_mmio accessors for memory, and replaces it with an alias to the io memory region. Signed-off-by: Matt Parker --- hw/net/rtl8139.c | 53 +++

Re: [Qemu-devel] [PATCH for-2.11 v2 1/5] qmp-shell: Use optparse module

2017-08-15 Thread Eduardo Habkost
On Tue, Aug 15, 2017 at 10:56:07AM +0100, Daniel P. Berrange wrote: > On Tue, Aug 15, 2017 at 11:47:28AM +0200, Markus Armbruster wrote: > > Eduardo Habkost writes: > > > > > It makes command-line parsing and generation of help text much > > > simpler. > > > > There's really no excuse for parsin

Re: [Qemu-devel] [PATCH] tests: switch tests to accel=kvm:tcg

2017-08-15 Thread Philippe Mathieu-Daudé
On 08/15/2017 12:47 PM, Richard Henderson wrote: On 08/14/2017 08:33 AM, Cornelia Huck wrote: On Mon, 14 Aug 2017 17:34:15 +0300 "Michael S. Tsirkin" wrote: Speed up tests on host systems with kvm support. In particular, this fixes tests with --disable-tcg. Cc: Paolo Bonzini Cc: Thomas Huth

Re: [Qemu-devel] [PATCH v6 3/7] qemu.py: use python logging system

2017-08-15 Thread Eduardo Habkost
On Tue, Aug 15, 2017 at 10:10:12AM +0200, Markus Armbruster wrote: > Please spell "Python" with a capital "P" (it's a proper name). > > Amador Pahim writes: > > > Let's provide extra control and flexibility by using python logging > > system instead of print and/or sys.std*.write(). > > > > Sign

Re: [Qemu-devel] [PATCH] tests: switch tests to accel=kvm:tcg

2017-08-15 Thread Thomas Huth
On 15.08.2017 17:47, Richard Henderson wrote: > On 08/14/2017 08:33 AM, Cornelia Huck wrote: >> On Mon, 14 Aug 2017 17:34:15 +0300 >> "Michael S. Tsirkin" wrote: >> >>> Speed up tests on host systems with kvm support. >>> In particular, this fixes tests with --disable-tcg. >>> >>> Cc: Paolo Bonzin

Re: [Qemu-devel] [PATCH] tests: switch tests to accel=kvm:tcg

2017-08-15 Thread Richard Henderson
On 08/15/2017 12:28 PM, Michael S. Tsirkin wrote: >> Ouch. This is the only real smoke test we have for the tcg backend for the >> host. While it is still going to test tcg for whatever machines do not run >> natively on the host, I can't help think we've lost testing. >> >> Can we use accel=tcg:

Re: [Qemu-devel] [RFC v4 00/13] qmp: query-device-slots command

2017-08-15 Thread Eduardo Habkost
On Tue, Aug 15, 2017 at 01:57:50PM -0500, Eric Blake wrote: > On 08/14/2017 04:57 PM, Eduardo Habkost wrote: > > Changelog > > - > > > > Changes v3 -> v4: > > * New compact representation of slot sets. > > * New generic code to automatically merge similar slots > > into a single entry in

Re: [Qemu-devel] [PATCH] tests: switch tests to accel=kvm:tcg

2017-08-15 Thread Michael S. Tsirkin
On Tue, Aug 15, 2017 at 08:47:35AM -0700, Richard Henderson wrote: > On 08/14/2017 08:33 AM, Cornelia Huck wrote: > > On Mon, 14 Aug 2017 17:34:15 +0300 > > "Michael S. Tsirkin" wrote: > > > >> Speed up tests on host systems with kvm support. > >> In particular, this fixes tests with --disable-tc

Re: [Qemu-devel] Help with Windows NT 4.0

2017-08-15 Thread Programmingkid
> On Aug 14, 2017, at 3:18 AM, Mark Cave-Ayland > wrote: > > On 14/08/17 07:51, Paolo Bonzini wrote: > >> On 13/08/2017 21:13, Programmingkid wrote: >>> Lately I found out that Windows NT 4.0 seems to work well with the >>> 486 and pentium processors. Using "-cpu 486" made installing it >>> ac

Re: [Qemu-devel] [PATCH for-2.10 v2 1/2] hw/acpi: Call acpi_set_pci_info when no ACPI tables needed

2017-08-15 Thread Michael S. Tsirkin
On Tue, Aug 15, 2017 at 02:07:51PM +0200, Igor Mammedov wrote: > On Tue, 15 Aug 2017 12:15:48 +0100 > Anthony PERARD wrote: > > > To do PCI passthrough with Xen, the property acpi-pcihp-bsel needs to be > > set, but this was done only when ACPI tables are built which is not > > needed for a Xen g

Re: [Qemu-devel] [RFC PATCH 1/2] libqtest: add qtest_accel() to avoid warnings when kvm is not available

2017-08-15 Thread Philippe Mathieu-Daudé
On 08/15/2017 03:39 PM, Peter Maydell wrote: On 15 August 2017 at 19:27, Philippe Mathieu-Daudé wrote: On 08/15/2017 03:13 PM, Eric Blake wrote: On 08/15/2017 11:39 AM, Philippe Mathieu-Daudé wrote: only warn once about it. - kernel without kvm: # make check-qtest-x86_64 GTE

Re: [Qemu-devel] [RFC PATCH 1/2] libqtest: add qtest_accel() to avoid warnings when kvm is not available

2017-08-15 Thread Philippe Mathieu-Daudé
On 08/15/2017 03:40 PM, Eric Blake wrote: On 08/15/2017 01:27 PM, Philippe Mathieu-Daudé wrote: On 08/15/2017 03:13 PM, Eric Blake wrote: On 08/15/2017 11:39 AM, Philippe Mathieu-Daudé wrote: only warn once about it. - kernel without kvm: # make check-qtest-x86_64 GTESTER check

Re: [Qemu-devel] [RFC v4 00/13] qmp: query-device-slots command

2017-08-15 Thread Eric Blake
On 08/14/2017 04:57 PM, Eduardo Habkost wrote: > Changelog > - > > Changes v3 -> v4: > * New compact representation of slot sets. > * New generic code to automatically merge similar slots > into a single entry in the command output while keeping > implementations of the method simpler.

Re: [Qemu-devel] [RFC PATCH 1/2] libqtest: add qtest_accel() to avoid warnings when kvm is not available

2017-08-15 Thread Eric Blake
On 08/15/2017 01:40 PM, Eric Blake wrote: > On 08/15/2017 01:27 PM, Philippe Mathieu-Daudé wrote: >> On 08/15/2017 03:13 PM, Eric Blake wrote: >>> On 08/15/2017 11:39 AM, Philippe Mathieu-Daudé wrote: only warn once about it. - kernel without kvm: # make check-qtest-x8

Re: [Qemu-devel] Help with Windows NT 4.0

2017-08-15 Thread Programmingkid
> On Aug 14, 2017, at 2:51 AM, Paolo Bonzini wrote: > > On 13/08/2017 21:13, Programmingkid wrote: >> Lately I found out that Windows NT 4.0 seems to work well with the >> 486 and pentium processors. Using "-cpu 486" made installing it >> actually work. Now I am seeing another issue. When I boot

Re: [Qemu-devel] [RFC PATCH 1/2] libqtest: add qtest_accel() to avoid warnings when kvm is not available

2017-08-15 Thread Eric Blake
On 08/15/2017 01:27 PM, Philippe Mathieu-Daudé wrote: > On 08/15/2017 03:13 PM, Eric Blake wrote: >> On 08/15/2017 11:39 AM, Philippe Mathieu-Daudé wrote: >>> only warn once about it. >>> >>> - kernel without kvm: >>> >>> # make check-qtest-x86_64 >>>GTESTER check-qtest-x86_64 >>>

Re: [Qemu-devel] [RFC PATCH 1/2] libqtest: add qtest_accel() to avoid warnings when kvm is not available

2017-08-15 Thread Peter Maydell
On 15 August 2017 at 19:27, Philippe Mathieu-Daudé wrote: > On 08/15/2017 03:13 PM, Eric Blake wrote: >> >> On 08/15/2017 11:39 AM, Philippe Mathieu-Daudé wrote: >>> >>> only warn once about it. >>> >>> - kernel without kvm: >>> >>> # make check-qtest-x86_64 >>>GTESTER check-qtest-x86

Re: [Qemu-devel] [RFC PATCH 1/2] libqtest: add qtest_accel() to avoid warnings when kvm is not available

2017-08-15 Thread Philippe Mathieu-Daudé
On 08/15/2017 03:13 PM, Eric Blake wrote: On 08/15/2017 11:39 AM, Philippe Mathieu-Daudé wrote: only warn once about it. - kernel without kvm: # make check-qtest-x86_64 GTESTER check-qtest-x86_64 Could not access KVM kernel module: No such device qemu-system-x86_64: faile

Re: [Qemu-devel] [RFC PATCH 1/2] libqtest: add qtest_accel() to avoid warnings when kvm is not available

2017-08-15 Thread Eric Blake
On 08/15/2017 11:39 AM, Philippe Mathieu-Daudé wrote: > only warn once about it. > > - kernel without kvm: > > # make check-qtest-x86_64 > GTESTER check-qtest-x86_64 > Could not access KVM kernel module: No such device > qemu-system-x86_64: failed to initialize KVM: No such devi

Re: [Qemu-devel] How to implement different endian accesses per MMU page?

2017-08-15 Thread Richard Henderson
[CC Peter re MemTxAttrs below] On 08/15/2017 09:38 AM, Mark Cave-Ayland wrote: > Working through an incorrect endian issue on qemu-system-sparc64, it has > become apparent that at least one OS makes use of the IE (Invert Endian) > bit in the SPARCv9 MMU TTE to map PCI memory space without the > pr

Re: [Qemu-devel] [RFC v4 02/13] qapi: qobject_compare() helper

2017-08-15 Thread Eduardo Habkost
On Tue, Aug 15, 2017 at 11:16:57AM -0500, Eric Blake wrote: > On 08/14/2017 04:57 PM, Eduardo Habkost wrote: > > The helper function will be useful when writing support code to > > deal with device slot information. > > > > TODO: documentation is incomplete and unclear, needs to be > > improved. >

Re: [Qemu-devel] [PULL for 2.10-rc3 0/7] NBD changes for 2.10-rc3

2017-08-15 Thread Peter Maydell
On 15 August 2017 at 16:09, Eric Blake wrote: > The following changes since commit 47025a0193f1f910300adfa443305ccf8482ef87: > > qxl: call qemu_spice_display_init_common for secondary devices (2017-08-15 > 15:04:51 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/e

Re: [Qemu-devel] [PATCH v2 for-2.10 3/3] target/arm: Require alignment for load exclusive

2017-08-15 Thread Philippe Mathieu-Daudé
On 08/15/2017 01:32 PM, Richard Henderson wrote: On 08/15/2017 08:56 AM, Philippe Mathieu-Daudé wrote: @@ -1885,7 +1886,7 @@ static void gen_load_exclusive(DisasContext *s, int rt, int rt2, tcg_gen_mov_i64(cpu_reg(s, rt2), cpu_exclusive_high); } } else { -

Re: [Qemu-devel] [PATCH v2 for-2.10 3/3] target/arm: Require alignment for load exclusive

2017-08-15 Thread Philippe Mathieu-Daudé
On 08/15/2017 01:14 PM, Peter Maydell wrote: On 15 August 2017 at 16:56, Philippe Mathieu-Daudé wrote: Hi Richard, On 08/15/2017 11:57 AM, Richard Henderson wrote: From: Alistair Francis Acording to the ARM ARM exclusive loads require the same allignment as exclusive stores. Let's update t

Re: [Qemu-devel] [PATCH v2 for-2.10 0/3] Fixup logic for exclusive pair

2017-08-15 Thread Peter Maydell
On 15 August 2017 at 15:57, Richard Henderson wrote: > In reviewing my previous patch, Peter pointed out that it is > CONSTRAINED UNPREDICTABLE what happens when you mix the number > of registers in a LDX[PR] + STX[RP] pair. So most of the bug > that I thought that I was fixing isn't a bug at all

Re: [Qemu-devel] [PATCH for-2.10] mmio-interface: Mark as not user creatable

2017-08-15 Thread Peter Maydell
On 15 August 2017 at 17:16, Thomas Huth wrote: > On 15.08.2017 16:30, Peter Maydell wrote: >> The mmio-interface device is not something we want to allow >> users to create on the command line: >> * it is intended as an implementation detail of the memory >>subsystem, which gets created and d

[Qemu-devel] [PATCH v3] target-i386/cpu: Add new EPYC CPU model

2017-08-15 Thread Brijesh Singh
Add a new base CPU model called 'EPYC' to model processors from AMD EPYC family (which includes EPYC 76xx,75xx,74xx, 73xx and 72xx). The following features bits have been added/removed compare to Opteron_G5 Added: monitor, movbe, rdrand, mmxext, ffxsr, rdtscp, cr8legacy, osvw, fsgsbase, bm

Re: [Qemu-devel] [PULL 7/7] nbd-client: Fix regression when server sends garbage

2017-08-15 Thread Eric Blake
On 08/15/2017 10:50 AM, Vladimir Sementsov-Ogievskiy wrote: > 15.08.2017 18:09, Eric Blake wrote: >> When we switched NBD to use coroutines for qemu 2.9 (in particular, >> commit a12a712a), we introduced a regression: if a server sends us >> garbage (such as a corrupted magic number), we quit the r

[Qemu-devel] [PATCH 2/2] tests: use qtest_accel()

2017-08-15 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/bios-tables-test.c | 2 +- tests/boot-serial-test.c | 5 +++-- tests/postcopy-test.c| 10 ++ tests/pxe-test.c | 5 +++-- tests/vmgenid-test.c | 4 ++-- 5 files changed, 15 insertions(+), 11 deletions(-) diff --git a/test

[Qemu-devel] [RFC PATCH 1/2] libqtest: add qtest_accel() to avoid warnings when kvm is not available

2017-08-15 Thread Philippe Mathieu-Daudé
only warn once about it. - kernel without kvm: # make check-qtest-x86_64 GTESTER check-qtest-x86_64 Could not access KVM kernel module: No such device qemu-system-x86_64: failed to initialize KVM: No such device qemu-system-x86_64: Back to tcg accelerator - tests ran as use

[Qemu-devel] [RFC PATCH 0/2] tests: avoid kvm accel when it is not accessible

2017-08-15 Thread Philippe Mathieu-Daudé
This series reduce warnings when kvm is not accessible: - kernel without kvm: # make check-qtest-x86_64 GTESTER check-qtest-x86_64 Could not access KVM kernel module: No such device qemu-system-x86_64: failed to initialize KVM: No such device qemu-system-x86_64: Back to tcg

[Qemu-devel] How to implement different endian accesses per MMU page?

2017-08-15 Thread Mark Cave-Ayland
Hi all, Working through an incorrect endian issue on qemu-system-sparc64, it has become apparent that at least one OS makes use of the IE (Invert Endian) bit in the SPARCv9 MMU TTE to map PCI memory space without the programmer having to manually endian-swap accesses. In other words, to quote the

Re: [Qemu-devel] [PATCH v2 for-2.10 3/3] target/arm: Require alignment for load exclusive

2017-08-15 Thread Richard Henderson
On 08/15/2017 08:56 AM, Philippe Mathieu-Daudé wrote: >> @@ -1885,7 +1886,7 @@ static void gen_load_exclusive(DisasContext *s, int rt, >> int rt2, >> tcg_gen_mov_i64(cpu_reg(s, rt2), cpu_exclusive_high); >> } >> } else { >> -memop |= size; >> +memop |=

Re: [Qemu-devel] [RFC v4 02/13] qapi: qobject_compare() helper

2017-08-15 Thread Eric Blake
On 08/14/2017 04:57 PM, Eduardo Habkost wrote: > The helper function will be useful when writing support code to > deal with device slot information. > > TODO: documentation is incomplete and unclear, needs to be > improved. > > Signed-off-by: Eduardo Habkost > --- > include/qapi/util.h| 39

Re: [Qemu-devel] [PATCH v2 for-2.10 1/3] target/arm: Correct exclusive store cmpxchg memop mask

2017-08-15 Thread Alistair Francis
On Tue, Aug 15, 2017 at 8:41 AM, Philippe Mathieu-Daudé wrote: > On 08/15/2017 11:57 AM, Richard Henderson wrote: >> >> From: Alistair Francis >> >> When we perform the atomic_cmpxchg operation we want to perform the >> operation on a pair of 32-bit registers. Previously we were just passing >> t

Re: [Qemu-devel] [PATCH for-2.10] mmio-interface: Mark as not user creatable

2017-08-15 Thread Thomas Huth
On 15.08.2017 16:30, Peter Maydell wrote: > The mmio-interface device is not something we want to allow > users to create on the command line: > * it is intended as an implementation detail of the memory >subsystem, which gets created and deleted by that >subsystem on demand; it makes no s

Re: [Qemu-devel] [PATCH v2 for-2.10 3/3] target/arm: Require alignment for load exclusive

2017-08-15 Thread Peter Maydell
On 15 August 2017 at 16:56, Philippe Mathieu-Daudé wrote: > Hi Richard, > > On 08/15/2017 11:57 AM, Richard Henderson wrote: >> >> From: Alistair Francis >> >> Acording to the ARM ARM exclusive loads require the same allignment as >> exclusive stores. Let's update the memops used for the load to

Re: [Qemu-devel] [PATCH v5 2/3] qmp: introduce query-memory-size-summary command

2017-08-15 Thread Igor Mammedov
On Tue, 15 Aug 2017 17:43:00 +0200 Vadim Galitsyn wrote: > Hi Guys, > > Thank you for the input! > > > "hotunpluggable" is ugly. What about just "pluggable"? > > Markus, I think "pluggable" is a bit misleading here. Some people can take > it like a maximum amount of memory that can be hot-a

Re: [Qemu-devel] [PATCH] target-i386/cpu: Add new EYPC CPU model

2017-08-15 Thread Brijesh Singh
Hi Eduardo, On 08/15/2017 06:35 AM, Eduardo Habkost wrote: Hi, Thanks for the patch. On Mon, Aug 14, 2017 at 10:52:17AM -0500, Brijesh Singh wrote: Add a new base CPU model called 'EPYC' to model processors from AMD EPYC family (which includes EPYC 76xx,75xx,74xx,73xx and 72xx). I suggest

Re: [Qemu-devel] [PATCH v2 for-2.10 3/3] target/arm: Require alignment for load exclusive

2017-08-15 Thread Philippe Mathieu-Daudé
Hi Richard, On 08/15/2017 11:57 AM, Richard Henderson wrote: From: Alistair Francis Acording to the ARM ARM exclusive loads require the same allignment as exclusive stores. Let's update the memops used for the load to match that of the store. This adds the alignment requirement to the memops.

[Qemu-devel] [PATCH] PCI: PCIe access should always be little endian

2017-08-15 Thread Matt Redfearn
PCIe busses are always little endian, so set the endianness of the memory region to little endian rather than native such that operations work as expected on big endian targets. Signed-off-by: Matt Redfearn --- hw/pci/pcie_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PULL 7/7] nbd-client: Fix regression when server sends garbage

2017-08-15 Thread Vladimir Sementsov-Ogievskiy
15.08.2017 18:09, Eric Blake wrote: When we switched NBD to use coroutines for qemu 2.9 (in particular, commit a12a712a), we introduced a regression: if a server sends us garbage (such as a corrupted magic number), we quit the read loop but do not stop sending further queued commands, resulting i

Re: [Qemu-devel] [PATCH] tests: switch tests to accel=kvm:tcg

2017-08-15 Thread Richard Henderson
On 08/14/2017 08:33 AM, Cornelia Huck wrote: > On Mon, 14 Aug 2017 17:34:15 +0300 > "Michael S. Tsirkin" wrote: > >> Speed up tests on host systems with kvm support. >> In particular, this fixes tests with --disable-tcg. >> >> Cc: Paolo Bonzini >> Cc: Thomas Huth >> Cc: Laurent Vivier >> Sugge

Re: [Qemu-devel] [PATCH v5 3/3] hmp: introduce 'info memory-size-summary' command

2017-08-15 Thread Vadim Galitsyn
Hi Eric, Thank you for the input. I will update it with the next version. Btw, most of HMP "info *" commands use '-' instead of '_' in names =) Best regards, Vadim On Fri, Jul 28, 2017 at 8:27 PM, Eric Blake wrote: > On 07/28/2017 07:10 AM, Vadim Galitsyn wrote: > > This command is an equivale

Re: [Qemu-devel] [PATCH v5 2/3] qmp: introduce query-memory-size-summary command

2017-08-15 Thread Vadim Galitsyn
Hi Guys, Thank you for the input! > "hotunpluggable" is ugly. What about just "pluggable"? Markus, I think "pluggable" is a bit misleading here. Some people can take it like a maximum amount of memory that can be hot-added to a guest (i.e., difference between static memory size and value specif

Re: [Qemu-devel] [PATCH v2 for-2.10 1/3] target/arm: Correct exclusive store cmpxchg memop mask

2017-08-15 Thread Philippe Mathieu-Daudé
On 08/15/2017 11:57 AM, Richard Henderson wrote: From: Alistair Francis When we perform the atomic_cmpxchg operation we want to perform the operation on a pair of 32-bit registers. Previously we were just passing the register size in which was set to MO_32. This would result in the high registe

Re: [Qemu-devel] [PATCH v2 for-2.11 0/2] Improvements for the pxe tester

2017-08-15 Thread Cornelia Huck
On Fri, 11 Aug 2017 07:57:54 +0200 Thomas Huth wrote: > The first patch improves the buffer handling in the pxe tester a > little bit by allocating a separate buffer on the heap for each > architecture. This also gets rid of the huge pre-initialized > array in the tester, shrinking the size of th

Re: [Qemu-devel] [PATCH v2 for-2.10 3/3] target/arm: Require alignment for load exclusive

2017-08-15 Thread Eric Blake
On 08/15/2017 09:57 AM, Richard Henderson wrote: > From: Alistair Francis > > Acording to the ARM ARM exclusive loads require the same allignment as s/Acording/According/ s/allignmnet/alignment/ > exclusive stores. Let's update the memops used for the load to match > that of the store. This add

Re: [Qemu-devel] [PATCH v2 for-2.11 2/2] tests/pxe: Check virtio-net-ccw on s390x

2017-08-15 Thread Cornelia Huck
On Fri, 11 Aug 2017 07:57:56 +0200 Thomas Huth wrote: > Now that we've got a firmware that can do TFTP booting on s390x (i.e. > the pc-bios/s390-netboot.img), we can enable the PXE tester for this > architecture, too. > > Signed-off-by: Thomas Huth > --- > tests/Makefile.include | 1 + > test

[Qemu-devel] [PULL 6/7] iotests: Add non-shared storage migration case 192

2017-08-15 Thread Eric Blake
From: Fam Zheng Signed-off-by: Fam Zheng Message-Id: <20170815130740.31229-5-f...@redhat.com> Tested-by: Eric Blake Signed-off-by: Eric Blake --- tests/qemu-iotests/192 | 63 ++ tests/qemu-iotests/192.out | 7 ++ tests/qemu-iotests/group

[Qemu-devel] [PULL 4/7] nbd: Fix order of bdrv_set_perm and bdrv_invalidate_cache

2017-08-15 Thread Eric Blake
From: Kevin Wolf The "inactive" state of BDS affects whether the permissions can be granted, we must call bdrv_invalidate_cache before bdrv_set_perm to support "-incoming defer" case. Reported-by: Christian Ehrhardt Signed-off-by: Fam Zheng Message-Id: <20170815130740.31229-3-f...@redhat.com>

[Qemu-devel] [PULL 5/7] block-backend: Defer shared_perm tightening migration completion

2017-08-15 Thread Eric Blake
From: Fam Zheng As in the case of nbd_export_new(), bdrv_invalidate_cache() can be called when migration is still in progress. In this case we are not ready to tighten the shared permissions fenced by blk->disable_perm. Defer to a VM state change handler. Signed-off-by: Fam Zheng Message-Id: <

[Qemu-devel] [PULL 3/7] stubs: Add vm state change handler stubs

2017-08-15 Thread Eric Blake
From: Fam Zheng They will be used by BlockBackend code in block-obj-y, which doesn't always get linked with common-obj-y. Add stubs to keep ld happy. Signed-off-by: Fam Zheng Message-Id: <20170815130740.31229-2-f...@redhat.com> Signed-off-by: Eric Blake --- stubs/change-state-handler.c | 14 +

[Qemu-devel] [PULL 7/7] nbd-client: Fix regression when server sends garbage

2017-08-15 Thread Eric Blake
When we switched NBD to use coroutines for qemu 2.9 (in particular, commit a12a712a), we introduced a regression: if a server sends us garbage (such as a corrupted magic number), we quit the read loop but do not stop sending further queued commands, resulting in the client hanging when it never rea

[Qemu-devel] [PULL 1/7] nbd: Fix trace message for disconnect

2017-08-15 Thread Eric Blake
NBD_CMD_DISC is a disconnect request, not a data discard request. Signed-off-by: Eric Blake Message-Id: <20170811015749.20365-1-ebl...@redhat.com> Reviewed-by: Stefan Hajnoczi --- nbd/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nbd/common.c b/nbd/common.c index

[Qemu-devel] [PULL for 2.10-rc3 0/7] NBD changes for 2.10-rc3

2017-08-15 Thread Eric Blake
The following changes since commit 47025a0193f1f910300adfa443305ccf8482ef87: qxl: call qemu_spice_display_init_common for secondary devices (2017-08-15 15:04:51 +0100) are available in the git repository at: git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2017-08-15 for you to fetch changes

[Qemu-devel] [PULL 2/7] qemu-iotests: step clock after each test iteration

2017-08-15 Thread Eric Blake
From: Stefan Hajnoczi The 093 throttling test submits twice as many requests as the throttle limit in order to ensure that we reach the limit. The remaining requests are left in-flight at the end of each test iteration. Commit 452589b6b47e8dc6353df257fc803dfc1383bed8 ("vl.c/exit: pause cpus bef

[Qemu-devel] [PATCH v2 for-2.10 3/3] target/arm: Require alignment for load exclusive

2017-08-15 Thread Richard Henderson
From: Alistair Francis Acording to the ARM ARM exclusive loads require the same allignment as exclusive stores. Let's update the memops used for the load to match that of the store. This adds the alignment requirement to the memops. Reviewed-by: Edgar E. Iglesias Signed-off-by: Alistair Francis

[Qemu-devel] [PATCH v2 for-2.10 1/3] target/arm: Correct exclusive store cmpxchg memop mask

2017-08-15 Thread Richard Henderson
From: Alistair Francis When we perform the atomic_cmpxchg operation we want to perform the operation on a pair of 32-bit registers. Previously we were just passing the register size in which was set to MO_32. This would result in the high register to be ignored. To fix this issue we hardcode the

[Qemu-devel] [PATCH v2 for-2.10 2/3] target/arm: Correct load exclusive pair atomicity

2017-08-15 Thread Richard Henderson
We are not providing the required single-copy atomic semantics for the 64-bit operation that is the 32-bit paired load. At the same time, leave the entire 64-bit value in cpu_exclusive_val and stop writing to cpu_exclusive_high. This means that we do not have to re-assemble the 64-bit quantity wh

[Qemu-devel] [PATCH v2 for-2.10 0/3] Fixup logic for exclusive pair

2017-08-15 Thread Richard Henderson
In reviewing my previous patch, Peter pointed out that it is CONSTRAINED UNPREDICTABLE what happens when you mix the number of registers in a LDX[PR] + STX[RP] pair. So most of the bug that I thought that I was fixing isn't a bug at all. That said, the patch does still fix a real bug wrt single-c

Re: [Qemu-devel] [PATCH for-2.10 v2] nbd-client: Fix regression when server sends garbage

2017-08-15 Thread Eric Blake
On 08/15/2017 09:45 AM, Vladimir Sementsov-Ogievskiy wrote: > 15.08.2017 00:34, Eric Blake wrote: >> When we switched NBD to use coroutines for qemu 2.9 (in particular, >> commit a12a712a), we introduced a regression: if a server sends us >> garbage (such as a corrupted magic number), we quit the r

Re: [Qemu-devel] [PATCH v2 for-2.11 1/2] tests/boot-sector: Do not overwrite the x86 buffer on other architectures

2017-08-15 Thread Cornelia Huck
On Fri, 11 Aug 2017 07:57:55 +0200 Thomas Huth wrote: > Re-using the boot_sector code buffer from x86 for other architectures > is not very nice, especially if we add more architectures later. It's > also ugly that the test uses a huge pre-initialized array at all - the > size of the executable i

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 v2] nbd-client: Fix regression when server sends garbage

2017-08-15 Thread Stefan Hajnoczi
On Mon, Aug 14, 2017 at 04:34:26PM -0500, Eric Blake wrote: > When we switched NBD to use coroutines for qemu 2.9 (in particular, > commit a12a712a), we introduced a regression: if a server sends us > garbage (such as a corrupted magic number), we quit the read loop > but do not stop sending furthe

Re: [Qemu-devel] [PATCH for-2.10 v2] nbd-client: Fix regression when server sends garbage

2017-08-15 Thread Vladimir Sementsov-Ogievskiy
15.08.2017 00:34, Eric Blake wrote: When we switched NBD to use coroutines for qemu 2.9 (in particular, commit a12a712a), we introduced a regression: if a server sends us garbage (such as a corrupted magic number), we quit the read loop but do not stop sending further queued commands, resulting i

Re: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb

2017-08-15 Thread Programmingkid
> On Aug 15, 2017, at 9:49 AM, Daniel P. Berrange wrote: > > On Tue, Aug 15, 2017 at 09:49:00AM -0400, Programmingkid wrote: >> >>> On Aug 15, 2017, at 4:38 AM, Daniel P. Berrange wrote: >>> >>> On Mon, Aug 14, 2017 at 02:46:22PM -0400, Programmingkid wrote: Sorry but there appears to be

Re: [Qemu-devel] [PATCH 01/26] qapi: fix type_seen key error

2017-08-15 Thread Markus Armbruster
Marc-André Lureau writes: > The type_seen member can be of a different type than the 'qtype' being > checked, since a string create several conflicts. Lookup the real > conflicting type in the conflict set, that one must be present in > type_seen. > > This fixes the following error, reproducible

Re: [Qemu-devel] [PATCH for 2.10?] qxl: call qemu_spice_display_init_common for secondary devices

2017-08-15 Thread Peter Maydell
On 15 August 2017 at 14:39, Stefan Hajnoczi wrote: > On Tue, Aug 15, 2017 at 01:15:52AM +0200, Paolo Bonzini wrote: >> Fixes this 2.10 regression: >> >> $ qemu-system-x86_64 -cpu host -m 6144 -vga qxl -device qxl >> qemu-system-x86_64: util/qemu-thread-posix.c:64: qemu_mutex_lock: >> Asserti

[Qemu-devel] [PATCH for-2.10] mmio-interface: Mark as not user creatable

2017-08-15 Thread Peter Maydell
The mmio-interface device is not something we want to allow users to create on the command line: * it is intended as an implementation detail of the memory subsystem, which gets created and deleted by that subsystem on demand; it makes no sense to create it by hand on the command line *

Re: [Qemu-devel] [PATCH for-2.10 v2 4/4] iotests: Add non-shared storage migration case 192

2017-08-15 Thread Eric Blake
On 08/15/2017 08:07 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/192 | 63 > ++ > tests/qemu-iotests/192.out | 7 ++ > tests/qemu-iotests/group | 1 + > 3 files changed, 71 insertions(+) > create mode 100755 t

Re: [Qemu-devel] [PATCH for-2.10 v2 3/4] block-backend: Defer shared_perm tightening migration completion

2017-08-15 Thread Eric Blake
On 08/15/2017 08:07 AM, Fam Zheng wrote: > As in the case of nbd_export_new(), bdrv_invalidate_cache() can be > called when migration is still in progress. In this case we are not > ready to tighten the shared permissions fenced by blk->disable_perm. > > Defer to a VM state change handler. > > Si

Re: [Qemu-devel] [PATCH v2 2/6] block: add options parameter to bdrv_new_open_driver()

2017-08-15 Thread Alberto Garcia
On Wed 09 Aug 2017 04:02:52 PM CEST, Manos Pitsidianakis wrote: > Allow passing a QDict *options parameter to bdrv_new_open_driver() so > that it can be used if a driver needs it upon creation. The previous > behaviour (empty bs->options and bs->explicit_options) remains when > options is NULL. > >

Re: [Qemu-devel] [PATCH for-2.10 v2 2/4] nbd: Fix order of bdrv_set_perm and bdrv_invalidate_cache

2017-08-15 Thread Eric Blake
On 08/15/2017 08:07 AM, Fam Zheng wrote: > From: Kevin Wolf > > The "inactive" state of BDS affects whether the permissions can be > granted, we must call bdrv_invalidate_cache before bdrv_set_perm to > support "-incoming defer" case. > > Reported-by: Christian Ehrhardt > Signed-off-by: Fam Zhe

Re: [Qemu-devel] [PULL 0/2] Tracing patches

2017-08-15 Thread Peter Maydell
On 15 August 2017 at 14:27, Stefan Hajnoczi wrote: > The following changes since commit 5681da292242550f37ba4c03f46a8a6f8ee9278a: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20170815' into > staging (2017-08-15 09:39:14 +0100) > > are availa

Re: [Qemu-devel] [PATCH v2 for 2.10] block/nbd-client: always return EIO on and after the first io channel error

2017-08-15 Thread Eric Blake
On 08/15/2017 02:26 AM, Vladimir Sementsov-Ogievskiy wrote: >>> The only doubt: is it possible to hang on nbd_rwv because some fail in >>> connection or server? >> We _already_ have the bug that we are hanging in trying to talk to a >> broken server, which is a regression introduced in 2.9 and not

Re: [Qemu-devel] [PATCH for-2.10 v2 1/4] stubs: Add vm state change handler stubs

2017-08-15 Thread Eric Blake
On 08/15/2017 08:07 AM, Fam Zheng wrote: > They will be used by BlockBackend code in block-obj-y, which doesn't > always get linked with common-obj-y. Add stubs to keep ld happy. > > Signed-off-by: Fam Zheng > --- > stubs/Makefile.objs | 1 + > stubs/change-state-handler.c | 14 +++

Re: [Qemu-devel] [PATCH v2 1/6] block: skip implicit nodes in snapshots, blockjobs

2017-08-15 Thread Manos Pitsidianakis
On Tue, Aug 15, 2017 at 03:24:38PM +0200, Alberto Garcia wrote: On Wed 09 Aug 2017 04:02:51 PM CEST, Manos Pitsidianakis wrote: @@ -2988,6 +3004,9 @@ void qmp_block_stream(bool has_job_id, const char *job_id, const char *device, return; } +/* Skip implicit filter nodes */ +

Re: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb

2017-08-15 Thread Daniel P. Berrange
On Tue, Aug 15, 2017 at 09:49:00AM -0400, Programmingkid wrote: > > > On Aug 15, 2017, at 4:38 AM, Daniel P. Berrange wrote: > > > > On Mon, Aug 14, 2017 at 02:46:22PM -0400, Programmingkid wrote: > >> Sorry but there appears to be an issue with your patchset. I ran this > >> command: > >> > >

Re: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb

2017-08-15 Thread Programmingkid
> On Aug 15, 2017, at 4:38 AM, Daniel P. Berrange wrote: > > On Mon, Aug 14, 2017 at 02:46:22PM -0400, Programmingkid wrote: >> Sorry but there appears to be an issue with your patchset. I ran this >> command: >> >> ./configure --target-list=ppc-softmmu,i386-softmmu >> >> Then saw this error

  1   2   3   >