Re: [Qemu-devel] [PATCH v1 09/11] target/s390x: tcg_s390_program_interrupt() will never return

On 30.08.2017 19:05, David Hildenbrand wrote: > The assert should hold in both scenarios. > > Signed-off-by: David Hildenbrand > --- > target/s390x/interrupt.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/target/s390x/interrupt.c

Re: [Qemu-devel] [PATCH v2 1/2] tests: Use real size for iov tests

On 08/30/2017 07:33 AM, Juan Quintela wrote: > We were using -1 instead of the real size because the functions check > what is bigger, size in bytes or the size of the iov. Recent gcc's > barf at this. > > Signed-off-by: Juan Quintela > > -- > > Remove comments about

Re: [Qemu-devel] [PATCH v2 2/2] tests: Make vmgenid test compile

On 08/30/2017 07:33 AM, Juan Quintela wrote: > Just make sure that nr_tables is size_t not int. > > Suggested-by: Cédric Le Goater > Signed-off-by: Juan Quintela > > -- > > Drop the s/g_new0/g_malloc0/ change. > --- > tests/vmgenid-test.c | 2 +- > 1

[Qemu-devel] [Bug 1701971] Re: multithreading not working right under qemu user mode for sh4

A patch for this has apparently been included in QEMU v2.10: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=4bfa602bc2227f5b5a506a4 Is this issue now completely fixed (so that we can close this ticket), or is there something left to do? -- You received this bug notification because you are a

Re: [Qemu-devel] [RFC v2] [OVS/NOVA] Vhost-user backends cross-version migration support

On Wed, Aug 30, 2017 at 11:19:08PM +0300, Michael S. Tsirkin wrote: > On Wed, Aug 30, 2017 at 04:25:10PM -0300, Eduardo Habkost wrote: > > On Wed, Aug 30, 2017 at 05:23:39PM +0300, Michael S. Tsirkin wrote: > > > On Wed, Aug 30, 2017 at 10:17:27AM -0300, Eduardo Habkost wrote: > > > > I'm CCing

[Qemu-devel] [Bug 1545052] Re: RDMA migration will hang forever if target QEMU fails to load vmstate

Patch series has apparently been merged in time for QEMU v2.10: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=9cf2bab2edca1e651eef https://git.qemu.org/?p=qemu.git;a=commitdiff;h=3a0f2ceaedcf70ff79b6 https://git.qemu.org/?p=qemu.git;a=commitdiff;h=9c98cfbe72b21d9d84b9

[Qemu-devel] [Bug 984516] Re: should use sdl-config for static build not pkg-config

** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/984516 Title: should use sdl-config for static build not pkg-config Status in QEMU:

[Qemu-devel] [Bug 1599539] Re: 2.6.0: vvfat driver generates bad FAT entries

Another patch has apparently been included here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=f80256b7eebfbe20683 I assume we can close this ticket now as fixed? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 533613] Re: fr-ca keymap is wrong

** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/533613 Title: fr-ca keymap is wrong Status in QEMU: Fix Released Bug description:

[Qemu-devel] [Bug 1694998] Re: PPC: msgsnd instruction leads to assertion

** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1694998 Title: PPC: msgsnd instruction leads to assertion Status in QEMU: Fix

[Qemu-devel] [Bug 1701821] Re: floating-point operation bugs in qemu-sh4

Seems like two patches for this have been included in QEMU v2.10: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=57f5c1b093e1c3ec https://git.qemu.org/?p=qemu.git;a=commitdiff;h=fea7d77d3ea287d3 Can we close this ticket now, or is there something left to do here? -- You received this bug

[Qemu-devel] [Bug 893208] Re: qemu on ARM hosts can't boot i386 image

** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/893208 Title: qemu on ARM hosts can't boot i386 image Status in QEMU: Fix Released

[Qemu-devel] [Bug 1662468] Re: [feature request] qemu-img convert should respond to control-T like dd

Fix has been included in v2.10.0: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=262fbae692722d5c8b ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [RFC v2] [OVS/NOVA] Vhost-user backends cross-version migration support

On Wed, Aug 30, 2017 at 04:25:10PM -0300, Eduardo Habkost wrote: > On Wed, Aug 30, 2017 at 05:23:39PM +0300, Michael S. Tsirkin wrote: > > On Wed, Aug 30, 2017 at 10:17:27AM -0300, Eduardo Habkost wrote: > > > I'm CCing libvir-list and qemu-devel because I would like to get > > > feedback from

Re: [Qemu-devel] [PATCH v2 1/7] block/ssh: don't call libssh2_init() in block_init()

On 08/30/2017 03:11 PM, Jeff Cody wrote: > On Wed, Aug 30, 2017 at 02:40:16PM -0500, Eric Blake wrote: >> On 08/30/2017 11:56 AM, Jeff Cody wrote: >>> We don't need libssh2 failure to be fatal (we could just opt to not >>> register the driver on failure). But, it is probably a good idea to >>>

Re: [Qemu-devel] [PATCH v2 1/7] block/ssh: don't call libssh2_init() in block_init()

On Wed, Aug 30, 2017 at 02:40:16PM -0500, Eric Blake wrote: > On 08/30/2017 11:56 AM, Jeff Cody wrote: > > We don't need libssh2 failure to be fatal (we could just opt to not > > register the driver on failure). But, it is probably a good idea to > > avoid external library calls during the

Re: [Qemu-devel] [PATCH 2/6] tests: Add network filter tests to the check-qtest-s390x list

On 08/18/2017 03:54 AM, Cornelia Huck wrote: > On Thu, 17 Aug 2017 16:02:00 +0200 > Thomas Huth wrote: > >> On 17.08.2017 10:41, Cornelia Huck wrote: >>> On Thu, 17 Aug 2017 08:25:09 +0200 >>> Thomas Huth wrote: >>> With some small modifications, we

Re: [Qemu-devel] [PATCH 2/6] tests: Add network filter tests to the check-qtest-s390x list

On 08/17/2017 04:41 AM, Cornelia Huck wrote: > On Thu, 17 Aug 2017 08:25:09 +0200 > Thomas Huth wrote: > >> With some small modifications, we can also use the the netfilter, >> the fiter-mirror and the filter-redirector tests on s390x. > > s/fiter/filter/ > >> >>

[Qemu-devel] [ANNOUNCE] QEMU 2.10.0 is now available

Hello, On behalf of the QEMU Team, I'd like to announce the availability of the QEMU 2.10.0 release. This release contains 2600+ commits from 208 authors. You can grab the tarball from our download page here: http://www.qemu.org/download/#source The full list of changes are available at:

Re: [Qemu-devel] [PATCH v2 7/7] block/curl: code cleanup to comply with coding style

On 08/30/2017 11:57 AM, Jeff Cody wrote: > This addresses non-functional changes to help curl.c better comply > with the coding styles (comments, indentation, brackets, etc.). > > One minor code change is the combination of two if statements into > a single if statement. > > Signed-off-by: Jeff

Re: [Qemu-devel] [PATCH 0/8] QOMify MIPS cpu

Hi James, On 08/30/2017 03:19 PM, James Hogan wrote: [...] git://github.com/philmd/qemu.git tags/mips-qomify-20170830 A sanity check of your branch doesn't reveal any obvious regressions when booting a Malta KVM guest kernel with KVM. Thank you for your time to test this! Does

Re: [Qemu-devel] [PATCH v2 6/7] block/curl: fix minor memory leaks

On 08/30/2017 11:57 AM, Jeff Cody wrote: > Signed-off-by: Jeff Cody > --- > block/curl.c | 6 ++ > 1 file changed, 6 insertions(+) > > +++ b/block/curl.c > @@ -857,6 +857,9 @@ out_noclean: > qemu_mutex_destroy(>mutex); > g_free(s->cookie); > g_free(s->url);

Re: [Qemu-devel] [PATCH v2 5/7] block/curl: check error return of curl_global_init()

On 08/30/2017 11:57 AM, Jeff Cody wrote: > If curl_global_init() fails, per the documentation no other curl > functions may be called, so make sure to check the return value. > > Also, some minor changes to the initialization latch variable 'inited': > > - Make it static in the file, for clarity

Re: [Qemu-devel] [PATCH v2 4/7] block/sheepdog: code beautification

On 08/30/2017 11:57 AM, Jeff Cody wrote: > No functional changes, just whitespace manipulation. > > Signed-off-by: Jeff Cody > --- > block/sheepdog.c | 162 > +++ > 1 file changed, 81 insertions(+), 81 deletions(-) > >

Re: [Qemu-devel] [PATCH v2 3/7] block/sheepdog: remove spurious NULL check

On 08/30/2017 11:57 AM, Jeff Cody wrote: > 'tag' is already checked in the lines immediately preceding this check, > and set to non-NULL if NULL. No need to check again, it hasn't changed. > > Signed-off-by: Jeff Cody > --- > block/sheepdog.c | 2 +- > 1 file changed, 1

Re: [Qemu-devel] [PATCH v2 2/7] block/ssh: make compliant with coding guidelines

On 08/30/2017 11:56 AM, Jeff Cody wrote: > Signed-off-by: Jeff Cody > --- > block/ssh.c | 32 ++-- > 1 file changed, 18 insertions(+), 14 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat,

Re: [Qemu-devel] [PATCH v2 1/7] block/ssh: don't call libssh2_init() in block_init()

On 08/30/2017 11:56 AM, Jeff Cody wrote: > We don't need libssh2 failure to be fatal (we could just opt to not > register the driver on failure). But, it is probably a good idea to > avoid external library calls during the block_init(), and call the > libssh2 global init function on the first

Re: [Qemu-devel] [PATCH 1/6] tests: Run filter-redirector and -mirror test only on POSIX systems

On 08/17/2017 02:25 AM, Thomas Huth wrote: > This way we can get rid of the ugly #ifdefs in the code which makes > it easier to extend later. > > Signed-off-by: Thomas Huth > --- > tests/Makefile.include | 8 > tests/test-filter-mirror.c | 5 - >

Re: [Qemu-devel] [PATCH] io: add new qio_channel_{readv, writev, read, write}_all functions

On 08/30/2017 08:56 AM, Daniel P. Berrange wrote: > These functions wait until they are able to read / write the full > requested data buffer(s). > Hmm, sounds like the NBD code would benefit from using this in a followup patch. > Signed-off-by: Daniel P. Berrange > --- >

Re: [Qemu-devel] [PATCH v2 0/3] Live block optional disable

On 08/30/2017 12:01 PM, Jeff Cody wrote: > This series adds a configurable option to disable live block operations. > > The default is that live block operations are 'enabled'. > > Jeffrey Cody (3): > configure: Add option in configure to disable live block ops > block-jobs: Optionally

Re: [Qemu-devel] [RFC v2] [OVS/NOVA] Vhost-user backends cross-version migration support

On Wed, Aug 30, 2017 at 05:23:39PM +0300, Michael S. Tsirkin wrote: > On Wed, Aug 30, 2017 at 10:17:27AM -0300, Eduardo Habkost wrote: > > I'm CCing libvir-list and qemu-devel because I would like to get > > feedback from libvirt and QEMU developers too. > > > > On Tue, Aug 08, 2017 at 10:49:21PM

Re: [Qemu-devel] [PATCH v2 2/3] block-jobs: Optionally unregister live block operations

On 08/30/2017 12:24 PM, Eduardo Habkost wrote: > On Wed, Aug 30, 2017 at 01:01:41PM -0400, Jeff Cody wrote: >> From: Jeffrey Cody >> >> If configured without live block operations enabled, unregister the >> live block operation commands. >> >> Signed-off-by: Jeff Cody

Re: [Qemu-devel] [PATCH v2 0/3] Live block optional disable

On 08/30/2017 12:01 PM, Jeff Cody wrote: > This series adds a configurable option to disable live block operations. > > The default is that live block operations are 'enabled'. > > Jeffrey Cody (3): > configure: Add option in configure to disable live block ops > block-jobs: Optionally

[Qemu-devel] [PATCH 2/3] Backup Tool: Support for Incremental Backup

Adds incremental backup functionality. Signed-off-by: Ishani Chugh --- contrib/backup/qemu-backup.py | 101 +- 1 file changed, 99 insertions(+), 2 deletions(-) diff --git a/contrib/backup/qemu-backup.py

[Qemu-devel] [PATCH 1/3] Backup Tool: Manpage for Incremental Backup

Adds command description to perform incremental backup and a full example for the same. Signed-off-by: Ishani Chugh --- contrib/backup/qemu-backup.texi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/contrib/backup/qemu-backup.texi

[Qemu-devel] [PATCH 0/3] Backup Tool: Incremental backup

This patch series is intended to add incremental backup functionality to Backup Tool. This patch series contains three patches, 1) QEMU Backup command line tool(With Incremental backup). 2) Test for incremental backup. 3) Manpage for the tool(Incremental backup

[Qemu-devel] [PATCH 3/3] Backup Tool: Test for Incremental Backup

This patch is the test for incremental backup implementation in Backup tool. The test employs two basic subtests: 1) Backing up an empty guest and comparing it with base image. 2) Writing a pattern to the guest, creating backup, writing a pattern again, creating backup and comparing with base

Re: [Qemu-devel] [PATCH v1 10/11] target/s390x: use trigger_pgm_exception() in s390_cpu_handle_mmu_fault()

On 30.08.2017 19:06, David Hildenbrand wrote: > This looks cleaner. > > Signed-off-by: David Hildenbrand > --- > target/s390x/excp_helper.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/target/s390x/excp_helper.c b/target/s390x/excp_helper.c >

Re: [Qemu-devel] [PATCH v1 08/11] s390x: allow only 1 CPU with TCG

On 30.08.2017 19:05, David Hildenbrand wrote: > Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the > guest tries to bring these CPUs up but fails), because we don't support > multiple CPUs on s390x under TCG. > > Let's bail out if more than 1 are specified, so we don't raise

Re: [Qemu-devel] [PATCH v1 01/11] exec, dump: don't include exec/exec-all.h explicitly

On 30.08.2017 19:05, David Hildenbrand wrote: > All but two, namely exec.c and dump.c, include exec/exec-all.h via > cpu.h only. as these files already include cpu.h, let's just drop the > additional include. > > Signed-off-by: David Hildenbrand > --- > dump.c | 1 - > exec.c

Re: [Qemu-devel] [PATCH v3 5/5] qemu-iotests: add option to save temp files on error

On 08/30/2017 11:52 AM, Jeff Cody wrote: > Now that ./check takes care of cleaning up after each tests, it > can also selectively not clean up. Add option to leave all output from > tests intact if that test encountered an error. > > Note: this currently only works for bash tests, as the python

Re: [Qemu-devel] [PATCH v3 4/5] qemu-iotests: make python tests attempt to leave intermediate files

On 08/30/2017 11:52 AM, Jeff Cody wrote: > Now that 'check' will clean up after tests, try and make python > tests leave intermediate files so that they might be inspectable > on failure. > > This isn't perfect; the python unittest framework runs multiple > tests, even if previous tests failed.

[Qemu-devel] [PATCH for-2.11 v3 3/3] hw/ppc: CAS reset on early device hotplug

This patch is a follow up on the discussions made in patch "hw/ppc: disable hotplug before CAS is completed" that can be found at [1]. At this moment, we do not support CPU/memory hotplug in early boot stages, before CAS. When a hotplug occurs, the event is logged in an internal RTAS event log

[Qemu-devel] [PATCH for-2.11 v3 1/3] hw/ppc/spapr_drc.c: change spapr_drc_needed to use drc->dev

This patch makes a small fix in 'spapr_drc_needed' to change how we detect if a DRC has a device attached. Previously it used dr_entity_sense for this, which works for physical DRCs. However, for logical DRCs, it didn't cover the case where a logical DRC has a drc->dev but the state is

[Qemu-devel] [PATCH for-2.11 v3 2/3] hw/ppc: clear pending_events on machine reset

The sPAPR machine isn't clearing up the pending events QTAILQ on machine reboot. This allows for unprocessed hotplug/epow events to persist in the queue after reset and, when reasserting the IRQs in check_exception later on, these will be being processed by the OS. This patch implements a new

[Qemu-devel] [PATCH for-2.11 v3 0/3] hw/ppc: CAS reset on early device hotplug

v3: - split into 3 patches, first 2 are fixes that are independent of the reboot code that can be applied separately: - patch 1: spapr_drc_needed fix - patch 2: clear pending_events on reboot, following David's suggestions on the v2 review. - patch 3: CAS reboot v2: - rebased with

Re: [Qemu-devel] [PATCH 0/8] QOMify MIPS cpu

time it is available in my git repository at: > >git://github.com/philmd/qemu.git tags/mips-qomify-20170830 A sanity check of your branch doesn't reveal any obvious regressions when booting a Malta KVM guest kernel with KVM. Cheers James signature.asc Description: Digital signature

Re: [Qemu-devel] [PATCH v3 3/5] qemu-iotests: add 'blind_remove' for python tests

On 08/30/2017 11:52 AM, Jeff Cody wrote: > Add a function to attempt to 'blindly' remove a file, without > throwing an error if the file doesn't exist. > > Signed-off-by: Jeff Cody > --- > tests/qemu-iotests/iotests.py | 7 +++ > 1 file changed, 7 insertions(+) > > diff

[Qemu-devel] [PULL 07/11] nbd/client: refactor nbd_receive_reply

From: Vladimir Sementsov-Ogievskiy Refactor nbd_receive_reply to return 1 on success, 0 on eof, when no data was read and <0 for other cases, because returned size of read data is not actually used. Signed-off-by: Vladimir Sementsov-Ogievskiy

[Qemu-devel] [PULL 04/11] qemu-iotests: test NBD over UNIX domain sockets in 083

From: Stefan Hajnoczi 083 only tests TCP. Some failures might be specific to UNIX domain sockets. A few adjustments are necessary: 1. Generating a port number and waiting for server startup is TCP-specific. Use the new nbd-fault-injector.py startup protocol to

[Qemu-devel] [PULL 10/11] block/nbd-client: rename nbd_recv_coroutines_enter_all

From: Vladimir Sementsov-Ogievskiy Rename nbd_recv_coroutines_enter_all to nbd_recv_coroutines_wake_all, as it most probably just adds all recv coroutines into co_queue_wakeup, rather than directly enter them. Signed-off-by: Vladimir Sementsov-Ogievskiy

[Qemu-devel] [PULL 08/11] nbd/client: fix nbd_send_request to return int

From: Vladimir Sementsov-Ogievskiy Fix nbd_send_request to return int, as it returns a return value of nbd_write (which is int), and the only user of nbd_send_request's return value (nbd_co_send_request) consider it as int too. Signed-off-by: Vladimir

[Qemu-devel] [PULL 03/11] qemu-iotests: improve nbd-fault-injector.py startup protocol

From: Stefan Hajnoczi Currently 083 waits for the nbd-fault-injector.py server to start up by looping until netstat shows the TCP listen socket. The startup protocol can be simplified by passing a 0 port number to nbd-fault-injector.py. The kernel will allocate a port in

[Qemu-devel] [PULL 02/11] nbd-client: avoid read_reply_co entry if send failed

From: Stefan Hajnoczi The following segfault is encountered if the NBD server closes the UNIX domain socket immediately after negotiation: Program terminated with signal SIGSEGV, Segmentation fault. #0 aio_co_schedule (ctx=0x0, co=0xd3c0ff2ef0) at util/async.c:441

[Qemu-devel] [PULL 09/11] block/nbd-client: get rid of ssize_t

From: Vladimir Sementsov-Ogievskiy Use int variable for nbd_co_send_request return value (as nbd_co_send_request returns int). Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20170804151440.320927-6-vsement...@virtuozzo.com>

[Qemu-devel] [PULL 11/11] block/nbd-client: refactor request send/receive

From: Vladimir Sementsov-Ogievskiy Add nbd_co_request, to remove code duplications in nbd_client_co_{pwrite,pread,...} functions. Also this is needed for further refactoring. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id:

[Qemu-devel] [PULL 05/11] nbd/client: fix nbd_opt_go

From: Vladimir Sementsov-Ogievskiy Do not send NBD_OPT_ABORT to the broken server. After sending NBD_REP_ACK on NBD_OPT_GO server is most probably in transmission phase, when option sending is finished. Signed-off-by: Vladimir Sementsov-Ogievskiy

[Qemu-devel] [PULL 01/11] qemu-iotests: Extend non-shared storage migration test (194)

From: Kashyap Chamarthy This is the follow-up patch that was discussed[*] as part of feedback to qemu-iotest 194. Changes in this patch: - Supply 'job-id' parameter to `drive-mirror` invocation. - Once migration completes, issue QMP `block-job-cancel` command on

[Qemu-devel] [PULL 06/11] nbd/client: refactor nbd_read_eof

From: Vladimir Sementsov-Ogievskiy Refactor nbd_read_eof to return 1 on success, 0 on eof, when no data was read and <0 for other cases, because returned size of read data is not actually used. Signed-off-by: Vladimir Sementsov-Ogievskiy

[Qemu-devel] [PULL 00/11] NBD patches for 2.11

The following changes since commit 1ab5eb4efb91a3d4569b0df6e824cc08ab4bd8ec: Update version for v2.10.0 release (2017-08-30 17:02:54 +0100) are available in the git repository at: git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2017-08-30 for you to fetch changes up to

[Qemu-devel] [PATCH v1 1/1] target/xtensa: Use the pre-defined MEMTXATTRS_UNSPECIFIED macro

Instead of using the hardcoded (MemTxAttrs){0} for no memory attributes let's use the already defined MEMTXATTRS_UNSPECIFIED macro instead. Signed-off-by: Alistair Francis --- target/xtensa/op_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [Qemu-devel] [Qemu-discuss] Accessing a shared folder

On Wed, 30 Aug 2017 14:35:00 + (UTC) Mahmood wrote: > OK. I reconfigured 2.9.0 with --enable-virtfs. Please note: > 1- If I use -virtfs option, I get > qemu-option.c:547: opt_set: Assertion `opt->str' failed > If you use the local fsdriver, security_model is

Re: [Qemu-devel] virtio: network: lost tcp/ip packets

Hello Stefan, Am 30.08.2017 um 19:17 schrieb Stefan Hajnoczi: > On Fri, Aug 18, 2017 at 04:40:36PM +0200, Stefan Priebe - Profihost AG wrote: >> i've a problem with two VMs running on the SAME host machine using qemu >> 2.7.1 or 2.9.0 and vhost_net + virtio. >> >> Sometimes TCP packets going

Re: [Qemu-devel] [PATCH v2 2/3] block-jobs: Optionally unregister live block operations

On Wed, Aug 30, 2017 at 01:01:41PM -0400, Jeff Cody wrote: > From: Jeffrey Cody > > If configured without live block operations enabled, unregister the > live block operation commands. > > Signed-off-by: Jeff Cody > --- > monitor.c | 16 >

Re: [Qemu-devel] [PATCH v2 3/7] block/sheepdog: remove spurious NULL check

On Wed, Aug 30, 2017 at 1:57 PM, Jeff Cody wrote: > 'tag' is already checked in the lines immediately preceding this check, > and set to non-NULL if NULL. No need to check again, it hasn't changed. > > Signed-off-by: Jeff Cody > --- > block/sheepdog.c | 2 +-

[Qemu-devel] [PATCH v3 1/3] backup: QEMU Backup Tool

qemu-backup will be a command-line tool for performing full and incremental disk backups on running VMs. It is intended as a reference implementation for management stack and backup developers to see QEMU's backup features in action. The tool writes details of guest in a configuration file and the

[Qemu-devel] [PATCH v1 11/11] target/s390x: use program_interrupt() in per_check_exception()

I am not sure if we are handling ilen the right way here. ilen should always match the instruction triggering the exception. This is relevant for per exceptions triggered via EXECUTE instructions. The ilen to be indicated has to match the EXECUTE instruction. Clean it up for now but leave ilen as

[Qemu-devel] [PATCH] Add BSD systems to the download section

Add basic notes about FreeBSD, NetBSD and OpenBSD. Add BSD link to source code subsection. Signed-off-by: Kamil Rytarowski --- _download/bsd.md | 19 +++ _download/source.html | 1 + download.html | 8 3 files changed, 28 insertions(+)

[Qemu-devel] [PATCH v1 09/11] target/s390x: tcg_s390_program_interrupt() will never return

The assert should hold in both scenarios. Signed-off-by: David Hildenbrand --- target/s390x/interrupt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/s390x/interrupt.c b/target/s390x/interrupt.c index 058e219fe5..79bab5e2f3 100644 ---

[Qemu-devel] [PATCH v1 08/11] s390x: allow only 1 CPU with TCG

Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the guest tries to bring these CPUs up but fails), because we don't support multiple CPUs on s390x under TCG. Let's bail out if more than 1 are specified, so we don't raise people's hope. Signed-off-by: David Hildenbrand

[Qemu-devel] [PATCH v1 06/11] target/s390x: cleanup cpu number/address handling

Some time ago we discussed that using "id" as property name is not the right thing to do, as it is a reserved property for other devices. Switch to the term "addr" instead, which matches the definition in the PoP called "CPU address". There is no such thing as cpu number, so rename env.cpu_num to

Re: [Qemu-devel] virtio: network: lost tcp/ip packets

On Fri, Aug 18, 2017 at 04:40:36PM +0200, Stefan Priebe - Profihost AG wrote: > i've a problem with two VMs running on the SAME host machine using qemu > 2.7.1 or 2.9.0 and vhost_net + virtio. > > Sometimes TCP packets going from machine a to machine b are simply lost. > I see them in VM A using

[Qemu-devel] [PATCH v1 07/11] target/s390x: rename next_cpu_id to next_cpu_addr

Adapt the term address/adddr. While at it, fix the type and drop the initialization to 0 (which is superfluous). Signed-off-by: David Hildenbrand --- target/s390x/cpu-qom.h | 2 +- target/s390x/cpu.c | 9 - target/s390x/helper.c | 4 ++-- 3 files changed, 7

[Qemu-devel] [PATCH v1 03/11] s390x: store cpu states inside machine state

Let's avoid global variables. While at it, move both functions using it, so we won't have to temporarily add includes (we'll be getting rid of s390-virtio.c soon). Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 39

[Qemu-devel] [PATCH v3 3/3] Add manpage for QEMU Backup Tool

qemu-backup will be a command-line tool for performing full and incremental disk backups on running VMs. It is intended as a reference implementation for management stack and backup developers to see QEMU's backup features in action. This commit is an initial implementation of manpage listing the

[Qemu-devel] [PATCH v1 05/11] s390x: rename s390-virtio.h to s390-virtio-hcall.h

The only interface left, so let's properly rename it. Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 2 +- hw/s390x/s390-virtio-hcall.c| 2 +- hw/s390x/{s390-virtio.h => s390-virtio-hcall.h} | 2 +- 3 files changed, 3

[Qemu-devel] [PATCH v1 02/11] cpu: drop old comments describing members

These comments are obviously stale. Signed-off-by: David Hildenbrand --- include/qom/cpu.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/qom/cpu.h b/include/qom/cpu.h index 25eefea7ab..6b4b838e8f 100644 --- a/include/qom/cpu.h +++

[Qemu-devel] [PATCH v3 0/3] QEMU Backup Tool

This patch series is intended to introduce QEMU Backup tool. qemu-backup will be a command-line tool for performing full and incremental disk backups on running VMs. It is intended as a reference implementation for management stack and backup developers to see QEMU's backup features in action.

[Qemu-devel] [PATCH v1 04/11] s390x: get rid of s390-virtio.c

It is a leftover from the days where we had still the !ccw virtio machine. As this one is long gone, let's move everything to s390-virtio-ccw.c. Cornelia Huck Signed-off-by: David Hildenbrand --- hw/s390x/Makefile.objs | 1 -

Re: [Qemu-devel] [PATCH v4] vl: exit if maxcpus is negative

Hi Seeteena, On 08/29/2017 02:45 AM, Seeteena Thoufeek wrote: ---Steps to Reproduce--- When passed a negative number to 'maxcpus' parameter, Qemu aborts with a core dump. Run the following command with maxcpus argument as negative number ppc64-softmmu/qemu-system-ppc64 --nographic -vga none

[Qemu-devel] [PATCH v2 2/3] block-jobs: Optionally unregister live block operations

From: Jeffrey Cody If configured without live block operations enabled, unregister the live block operation commands. Signed-off-by: Jeff Cody --- monitor.c | 16 1 file changed, 16 insertions(+) diff --git a/monitor.c b/monitor.c index

Re: [Qemu-devel] [PATCH 0/4] net: introduce common net_crc32() and net_crc32_le() functions

On 18/08/17 15:15, Mark Cave-Ayland wrote: > Whilst trying to debug a CRC32 endian issue for NIC multicast hash lookups, it > struck me that it would make sense to have a common set of standard ethernet > CRC32 functions (both little and big endian variants) in net.c. > > The first two patches

[Qemu-devel] [PATCH v1 00/11] next round of s390x cleanups

No new functionality, only cleanups, some of the discussed during the last round of cleanups. Not sure if the first two patches should be sent separatly? Anyhow, they are most probably not worth the trouble :) The biggest part of this series is getting rid of s390-virtio.c and cleaning up our

[Qemu-devel] [PATCH v1 01/11] exec, dump: don't include exec/exec-all.h explicitly

All but two, namely exec.c and dump.c, include exec/exec-all.h via cpu.h only. as these files already include cpu.h, let's just drop the additional include. Signed-off-by: David Hildenbrand --- dump.c | 1 - exec.c | 1 - 2 files changed, 2 deletions(-) diff --git a/dump.c

[Qemu-devel] [PATCH v2 0/3] Live block optional disable

This series adds a configurable option to disable live block operations. The default is that live block operations are 'enabled'. Jeffrey Cody (3): configure: Add option in configure to disable live block ops block-jobs: Optionally unregister live block operations hmp: Optionally disable

[Qemu-devel] [PATCH v2 3/3] hmp: Optionally disable live block operations in HMP monitor

From: Jeffrey Cody If live block operations are disabled, disable the corresponding HMP commands. Signed-off-by: Jeff Cody --- hmp-commands-info.hx | 4 hmp-commands.hx | 12 hmp.c| 12 3 files changed,

Re: [Qemu-devel] [PATCH] qcow2: allocate cluster_cache/cluster_data on demand

On Tue, Aug 22, 2017 at 02:56:00PM +1000, Alexey Kardashevskiy wrote: > On 19/08/17 12:46, Alexey Kardashevskiy wrote: > > On 19/08/17 01:18, Eric Blake wrote: > >> On 08/18/2017 08:31 AM, Stefan Hajnoczi wrote: > >>> Most qcow2 files are uncompressed so it is wasteful to allocate (32 + 1) > >>> *

[Qemu-devel] [PATCH v2 4/7] block/sheepdog: code beautification

No functional changes, just whitespace manipulation. Signed-off-by: Jeff Cody --- block/sheepdog.c | 162 +++ 1 file changed, 81 insertions(+), 81 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index

Re: [Qemu-devel] [Qemu-block] [PATCH v2] qcow2: allocate cluster_cache/cluster_data on demand

On Mon, Aug 21, 2017 at 02:55:30PM +0100, Stefan Hajnoczi wrote: > Most qcow2 files are uncompressed so it is wasteful to allocate (32 + 1) > * cluster_size + 512 bytes upfront. Allocate s->cluster_cache and > s->cluster_data when the first read operation is performance on a > compressed cluster.

[Qemu-devel] [PATCH v2 1/3] configure: Add option in configure to disable live block ops

From: Jeffrey Cody This adds in the option to disable the live block operations. The resultant config option is not checked until subsequent patches. Signed-off-by: Jeff Cody --- configure | 11 +++ 1 file changed, 11 insertions(+) diff --git

[Qemu-devel] [PATCH v3 2/3] Test for full Backup

This patch is the test for full backup implementation in Backup tool. The test employs two basic substests: 1) Backing up an empty guest and comparing it with base image. 2) Writing a pattern to the guest, creating backup and comparing with the base image. Signed-off-by: Ishani Chugh

Re: [Qemu-devel] [Qemu-block] [PATCH 10/10] scsi: add persistent reservation manager using qemu-pr-helper

On Tue, Aug 22, 2017 at 03:18:32PM +0200, Paolo Bonzini wrote: > +/* Called with lock held. */ > +static int pr_manager_helper_read(PRManagerHelper *pr_mgr, > + void *buf, int sz, Error **errp) > +{ > +ssize_t r = qio_channel_read_all(pr_mgr->ioc, buf, sz,

[Qemu-devel] [PULL 41/44] s390x/s390-stattrib: Mark the storage attribute as not user_creatable

From: Thomas Huth The storage attribute devices are only meant to be instantiated one time, internally. They can not be used by the user, so mark them with user_creatable = false. Suggested-by: Claudio Imbrenda Signed-off-by: Thomas Huth

[Qemu-devel] [PATCH v2 7/7] block/curl: code cleanup to comply with coding style

This addresses non-functional changes to help curl.c better comply with the coding styles (comments, indentation, brackets, etc.). One minor code change is the combination of two if statements into a single if statement. Signed-off-by: Jeff Cody --- block/curl.c | 100

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

On Sat, Aug 19, 2017 at 10:58:44PM -0700, David Michael wrote: > This allows building with "./configure --python=python3", where > the python3 program is at least version 3.6. It preserves > compatibility with Python 2. The changes include: > > - Avoiding "print" usage > - Using bytes with

[Qemu-devel] [PATCH v2 6/7] block/curl: fix minor memory leaks

Signed-off-by: Jeff Cody --- block/curl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/curl.c b/block/curl.c index 00a9879..35cf417 100644 --- a/block/curl.c +++ b/block/curl.c @@ -857,6 +857,9 @@ out_noclean: qemu_mutex_destroy(>mutex);

[Qemu-devel] [PULL 37/44] target/s390x: move a couple of functions to cpu.c

From: David Hildenbrand Prepare to move more stuff (especially KVM related) from cpu.h to internal.h. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Signed-off-by:

[Qemu-devel] [PATCH v2 3/7] block/sheepdog: remove spurious NULL check

'tag' is already checked in the lines immediately preceding this check, and set to non-NULL if NULL. No need to check again, it hasn't changed. Signed-off-by: Jeff Cody --- block/sheepdog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/sheepdog.c

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

On Mon, Aug 21, 2017 at 04:29:44PM +0200, Markus Armbruster wrote: > What is our Python 2 -> 3 migration strategy? > > Don't support Python 3 until a flag day, then flip and don't support > Python 2? Add support for Python 3 so that both Python 2.6+ and Python 3 are supported. When Python 2 is

[Qemu-devel] [PATCH v2 2/7] block/ssh: make compliant with coding guidelines

Signed-off-by: Jeff Cody --- block/ssh.c | 32 ++-- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index cbb0e34..97f7673 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -241,7 +241,7 @@ static int

<    1   2   3   4   5   >