[Qemu-devel] [PULL 21/29] sh4: replace cpu_sh4_init() with cpu_generic_init()

From: Igor Mammedov it's just a wrapper, drop it and use cpu_generic_init() directly Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Message-Id: <1503592308-93913-18-git-send-email-imamm...@redhat.com> Signed-off-by:

[Qemu-devel] [PULL 09/29] sparc: move adhoc CPUSPARCState initialization to realize time

From: Igor Mammedov SPARCCPU::env was initialized from previously set properties (with help of sparc_cpu_parse_features) in cpu_sparc_register(). However there is not reason to keep it there as this task is typically done at realize time. So move post properties

[Qemu-devel] [PULL 24/29] x86: replace cpu_x86_init() with cpu_generic_init()

From: Igor Mammedov it's just a wrapper, drop it and use cpu_generic_init() directly Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Message-Id: <1503592308-93913-21-git-send-email-imamm...@redhat.com> Signed-off-by:

[Qemu-devel] [PULL 11/29] sparc: replace cpu_sparc_init() with cpu_generic_init()

From: Igor Mammedov it's just a wrapper, drop it and use cpu_generic_init() directly Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id:

[Qemu-devel] [PULL 20/29] tricore: replace cpu_tricore_init() with cpu_generic_init()

From: Igor Mammedov it's just a wrapper, drop it and use cpu_generic_init() directly Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Message-Id: <1503592308-93913-17-git-send-email-imamm...@redhat.com> Signed-off-by:

[Qemu-devel] [PULL 08/29] sparc: convert cpu features to qdev properties

From: Igor Mammedov SPARC is the last target that uses legacy way of parsing and initializing cpu features, drop legacy approach and convert features to properties so that SPARC could as minimum benefit from generic cpu_generic_init(), common with x86 +-feat parser PS: the

[Qemu-devel] [PULL 13/29] alpha: replace cpu_alpha_init() with cpu_generic_init()

From: Igor Mammedov cpu_alpha_init() used to provide default fallback if invalid (i.e. non existent) cpu_model were provided. dp264 machine provides its own default so sole user of fallback is [bsd|linux]-user targets which specifies 'any' cpu model that fallbacks to "ev67"

[Qemu-devel] [PULL 07/29] sparc: embed sparc_def_t into CPUSPARCState

From: Igor Mammedov Make CPUSPARCState::def embedded so it would be allocated as part of cpu instance and we won't have to worry about cleaning def pointer up mannualy on cpu destruction. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé

[Qemu-devel] [PULL 14/29] hppa: replace cpu_hppa_init() with cpu_generic_init()

From: Igor Mammedov drop custom cpu_hppa_init() in favor of cpu_generic_init(), to make cpu_generic_init() work all we need is to provide cc->class_by_name callback that would resolve any cpu_model to the sole TYPE_HPPA_CPU to match current behaviour. Signed-off-by: Igor

[Qemu-devel] [PULL 04/29] target-i386/cpu: Add new EPYC CPU model

From: Brijesh Singh Add a new base CPU model called 'EPYC' to model processors from AMD EPYC family (which includes EPYC 76xx,75xx,74xx, 73xx and 72xx). The following features bits have been added/removed compare to Opteron_G5 Added: monitor, movbe, rdrand, mmxext,

[Qemu-devel] [PULL 06/29] sparc: convert cpu models to SPARC cpu subclasses

From: Igor Mammedov QOMfy cpu models handling introducing propper cpu types for each cpu model. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id:

[Qemu-devel] [PULL 03/29] hmp: allow apic-id for "info lapic"

From: Yi Wang Add [apic-id] support for hmp command "info lapic", which is useful when debugging ipi and so on. Current behavior is not changed when the parameter isn't specified. Signed-off-by: Yi Wang Signed-off-by: Yun Liu

[Qemu-devel] [PULL 05/29] qom: cpu: fix parsed feature string length

From: Igor Mammedov since commit ( 9262685b cpu: Factor out cpu_generic_init() ) features parsed by it were truncated only to the 1st feature after CPU name due to fact that featurestr = strtok(NULL, ","); cc->parse_features(cpu, featurestr, ); would extract exactly

[Qemu-devel] [PULL 01/29] qom: Remove unused errp parameter from can_be_deleted()

The errp argument is ignored by all implementations of the method, and user_creatable_del() would break if any implementation set an error (because it calls error_setg(errp) if the function returns false). Remove the unused parameter. Signed-off-by: Eduardo Habkost

[Qemu-devel] [PULL 02/29] cpu: cpu_by_arch_id() helper

The helper can be used for CPU object lookup using the CPU's arch-specific ID (the one returned by CPUClass::get_arch_id()). Signed-off-by: Eduardo Habkost [Yi Wang: Added documentation comments] Signed-off-by: Yi Wang Signed-off-by: Yun Liu

[Qemu-devel] [PULL 00/29] x86 & cpu queue, 2017-09-01

The following changes since commit 223cd0e13f2e46078d7b573f0b8402bfbee339be: Merge remote-tracking branch 'remotes/elmarco/tags/tidy-pull-request' into staging (2017-08-31 15:52:43 +0100) are available in the git repository at: git://github.com/ehabkost/qemu.git

Re: [Qemu-devel] [PATCH 0/2] Fix / skip recent iotests with LUKS driver

On Fri, 09/01 11:54, Daniel P. Berrange wrote: > Two recently added iotests are currently breaking 'check -luks', > fix the easy one and disable the hard one. I can add -luks to the test-block series with this, thanks for the quick fix! Tested-by: Fam Zheng

Re: [Qemu-devel] [PATCH RESEND v3 0/3] Generic PCIe host bridge INTx determination for INTx routing

On Jul 9, 2017 2:04 PM, "Eric Auger" wrote: This series implements INTx to gsi routing for ARM VIRT/Gpex. This is a respin of [1] which was lost in limbo. ARM virt uses GPEX PCIe bridge. This latter does not implement INTx to GSI routing. PCIe/INTx assignment works but

Re: [Qemu-devel] [PULL 00/47] QAPI patches for 2017-09-01

no-re...@patchew.org writes: > Hi, > > This series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. What? How did this tree survive my testing? *sigh* v2 coming.

Re: [Qemu-devel] [PATCH] tests/qmp-test: Add generic, basic test of query commands

Thomas Huth writes: > On 11.08.2017 11:08, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 08/10/2017 01:30 PM, Markus Armbruster wrote: > [...] We get basic test coverage for the following commands: >>> >>> Cool! >>>

Re: [Qemu-devel] [PATCH 0/2] Fix / skip recent iotests with LUKS driver

On Fri, Sep 01, 2017 at 09:26:30AM -0500, Eric Blake wrote: > On 09/01/2017 05:54 AM, Daniel P. Berrange wrote: > > Two recently added iotests are currently breaking 'check -luks', > > fix the easy one and disable the hard one. > > > > Daniel P. Berrange (2): > > iotests: rewrite 192 to use

Re: [Qemu-devel] [PATCH v2 2/2] Add a unique ID in the virt machine to be used as device ID

On 08/23/2017 11:29 PM, Edgar E. Iglesias wrote: > On Tue, Aug 22, 2017 at 10:04:25PM +0300, Michael S. Tsirkin wrote: >> On Tue, Aug 22, 2017 at 03:13:57PM +, Diana Madalina Craciun wrote: >>> On 08/11/2017 06:50 PM, Edgar E. Iglesias wrote: On Fri, Aug 11, 2017 at 02:35:28PM +,

Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

i82374 is compiled in only on ppc and sh4, so I'm CCing the maintainers for those architectures. On Fri, Sep 01, 2017 at 01:03:32PM +0200, Eduardo Otubo wrote: > When used with the following command line: > > ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374 > > QEMU

Re: [Qemu-devel] [PATCH 0/2] Fix / skip recent iotests with LUKS driver

On 09/01/2017 05:54 AM, Daniel P. Berrange wrote: > Two recently added iotests are currently breaking 'check -luks', > fix the easy one and disable the hard one. > > Daniel P. Berrange (2): > iotests: rewrite 192 to use _launch_qemu to fix LUKS support > iotests: blacklist 194 with the luks

Re: [Qemu-devel] [PATCH 2/2] iotests: blacklist 194 with the luks driver

On 09/01/2017 05:54 AM, Daniel P. Berrange wrote: > The 194 test has alot of code that assumes a simple image file. Rewriting s/alot/a lot/ > this to work with luks is possible, but non-trivial, so blacklist the > luks format for now. > > Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] [PATCH 1/2] iotests: rewrite 192 to use _launch_qemu to fix LUKS support

On 09/01/2017 05:54 AM, Daniel P. Berrange wrote: > The LUKS driver requires extra args to QEMU to setup passwords. > The _launch_qemu function takes care of this, so convert the > test to use this function and use correct -drive syntax > > Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] RFC: changing ROM bundling in tar dists for releases

Hi, > I think it makes sense to create a separate project for the firmware > blobs.  Move over the firmware binaries and source submodules to the > new project.  This way updating both firmware sources and binaries > can > be done with a single commit, like we handle this today, just in the >

Re: [Qemu-devel] S390 bios breaks in qemu 2.10.rc3

On 09/01/2017 02:06 AM, Christian Ehrhardt wrote: > On Thu, Aug 31, 2017 at 7:44 PM, Michael Roth > > wrote: > >> Quoting Thomas Huth (2017-08-29 04:35:22) >>> On 28.08.2017 09:18, Christian Borntraeger wrote: On 08/25/2017 10:29 AM, Cornelia Huck wrote:

Re: [Qemu-devel] [PULL 00/47] QAPI patches for 2017-09-01

Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20170901125611.29295-1-arm...@redhat.com Subject: [Qemu-devel] [PULL 00/47] QAPI patches for 2017-09-01 Type:

Re: [Qemu-devel] [PATCH] tests/qmp-test: Add generic, basic test of query commands

On 11.08.2017 11:08, Markus Armbruster wrote: > Eric Blake writes: > >> On 08/10/2017 01:30 PM, Markus Armbruster wrote: [...] >>> We get basic test coverage for the following commands: >> >> Cool! >> >>> >>> qom-list-types >>> query-acpi-ospm-status >>>

[Qemu-devel] [PULL 2/5] vga: stop passing pointers to vga_draw_line* functions

Instead pass around the address (aka offset into vga memory). Add vga_read_* helper functions which apply vbe_size_mask to the address, to make sure the address stays within the valid range, similar to the cirrus blitter fixes (commits ffaf857778 and 026aeffcb4). Impact: DoS for privileged guest

Re: [Qemu-devel] [PATCH v2] tests: Enable the drive_del test also on s390x

On Thu, 31 Aug 2017 16:40:08 +0200 Thomas Huth wrote: > We can use the drive_del test on s390x, too, to check that adding and > deleting also works fine with the virtio-ccw bus. But we have to make > sure that we use the devices with the "-ccw" suffix instead of the > "-pci"

[Qemu-devel] [PULL 24/47] qapi-schema: Collect migration stuff in qapi/migration.json

Cc: Juan Quintela Cc: Dr. David Alan Gilbert Signed-off-by: Markus Armbruster Message-Id: <1503602048-12268-10-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau Reviewed-by: Dr. David Alan

Re: [Qemu-devel] [RFC v2 00/32] postcopy+vhost-user/shared ram

Hello David, You wrote in previous version: We've had a postcopy migrate work now, with a few hacks we're still cleaning up, both on vhost-user-bridge and dpdk; so I'll get this updated and reposted. I want to know more about DPDK work, do you know, is somebody assigned to that task? On

[Qemu-devel] [PULL 23/47] qapi-schema: Collect UI stuff in qapi/ui.json

UI stuff is remote desktop stuff (Spice, VNC) and input stuff (mouse, keyboard). Cc: Gerd Hoffmann Signed-off-by: Markus Armbruster Message-Id: <1503602048-12268-9-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau

[Qemu-devel] [PATCH] wm8750: add record buffer underrun check

Reported-by: niuguoxi...@huawei.com Signed-off-by: Gerd Hoffmann --- hw/audio/wm8750.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/audio/wm8750.c b/hw/audio/wm8750.c index f8b5bebfc2..d2bf2e1da1 100644 --- a/hw/audio/wm8750.c +++

[Qemu-devel] [PULL 44/47] qapi: Mechanically convert FOO_lookup[...] to FOO_str(...)

Signed-off-by: Markus Armbruster Message-Id: <1503564371-26090-14-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- backends/hostmem.c | 2 +- block/backup.c | 2 +- block/file-posix.c

Re: [Qemu-devel] [PATCH v2 2/2] Add a unique ID in the virt machine to be used as device ID

On 08/22/2017 10:04 PM, Michael S. Tsirkin wrote: > On Tue, Aug 22, 2017 at 03:13:57PM +, Diana Madalina Craciun wrote: >> On 08/11/2017 06:50 PM, Edgar E. Iglesias wrote: >>> On Fri, Aug 11, 2017 at 02:35:28PM +, Diana Madalina Craciun wrote: Hi Edgar, On 07/31/2017 06:16

[Qemu-devel] [PULL 42/47] qapi: Avoid unnecessary use of enum lookup table's sentinel

Currently, the FOO_lookup[] generated for QAPI enum types are terminated by a NULL sentinel. A future patch will generate enums with "holes". NULL-termination will cease to work then. To prepare for that, replace "have we reached the sentinel?" predicates by "have we reached the FOO__MAX

Re: [Qemu-devel] [PATCH 02/14] qlit: move qlit from check-qjson to qobject/

On Fri, Sep 01, 2017 at 11:05:11AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Thu, Aug 24, 2017 at 12:33:38PM +0200, Marc-André Lureau wrote: > >> Fix code style issues while at it, to please check-patch. > >> > >> Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH] isa-fdc: assert replaced by proper error exit

Eduardo Otubo writes: > When not available, isa-fdc falls into assert instead of proper error > exit. This patch fixes this behavior. When what exactly isn't available? > > Signed-off-by: Eduardo Otubo > --- > hw/block/fdc.c | 6 +- > 1 file changed, 5

Re: [Qemu-devel] [RFC v2 00/32] postcopy+vhost-user/shared ram

Hello Alexey, On 09/01/2017 03:34 PM, Alexey Perevalov wrote: Hello David, You wrote in previous version: We've had a postcopy migrate work now, with a few hacks we're still cleaning up, both on vhost-user-bridge and dpdk; so I'll get this updated and reposted. I want to know more about

[Qemu-devel] [PULL 3/5] qxl: drop mono cursor support

The chunk size sanity check in qxl_render_cursor works for SPICE_CURSOR_TYPE_ALPHA cursors only. So support for SPICE_CURSOR_TYPE_MONO cursors must be broken for ages without anyone noticing. Most likely it simply isn't used any more by guest drivers. Drop the dead code. Signed-off-by: Gerd

[Qemu-devel] [PULL 46/47] qapi: Change data type of the FOO_lookup generated for enum FOO

From: Marc-André Lureau Currently, a FOO_lookup is an array of strings terminated by a NULL sentinel. A future patch will generate enums with "holes". NULL-termination will cease to work then. To prepare for that, store the length in the FOO_lookup by wrapping it

[Qemu-devel] [PULL 5/5] vga/migration: Update memory map in post_load

From: "Dr. David Alan Gilbert" After migration the chain4 alias mapping added by 80763888 (in 2011) might be missing, since there's no call to vga_update_memory_access in the post_load after the registers are updated. Add it back. Signed-off-by: Dr. David Alan Gilbert

[Qemu-devel] [PULL 0/5] Vga 20170901 patches

The following changes since commit 223cd0e13f2e46078d7b573f0b8402bfbee339be: Merge remote-tracking branch 'remotes/elmarco/tags/tidy-pull-request' into staging (2017-08-31 15:52:43 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/vga-20170901-pull-request

[Qemu-devel] [PULL 43/47] qapi: Generate FOO_str() macro for QAPI enum FOO

The next commit will put it to use. May look pointless now, but we're going to change the FOO_lookup's type, and then it'll help. Signed-off-by: Markus Armbruster Message-Id: <1503564371-26090-13-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau

[Qemu-devel] [PULL 39/47] quorum: Use qapi_enum_parse() in quorum_open()

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20170822132255.23945-12-marcandre.lur...@redhat.com> Reviewed-by: Markus Armbruster [Rebased, qemu_opt_get() factored out, commit message tweaked]

[Qemu-devel] [PULL 4/5] qxl: add support for chunked cursors.

Signed-off-by: Gerd Hoffmann Message-id: 20170828123933.30323-3-kra...@redhat.com --- hw/display/qxl-render.c | 36 +--- 1 file changed, 29 insertions(+), 7 deletions(-) diff --git a/hw/display/qxl-render.c b/hw/display/qxl-render.c index

[Qemu-devel] [PULL 08/47] qlit: rename compare_litqobj_to_qobj() to qlit_equal_qobject()

From: Marc-André Lureau compare_litqobj_to_qobj() lacks a qlit_ prefix. Moreover, "compare" suggests -1, 0, +1 for less than, equal and greater than. The function actually returns non-zero for equal, zero for unequal. Rename to qlit_equal_qobject(). Its return

[Qemu-devel] [PULL 47/47] qapi: drop the sentinel in enum array

From: Marc-André Lureau Now that all usages have been converted to user lookup helpers. Signed-off-by: Marc-André Lureau Message-Id: <20170822132255.23945-14-marcandre.lur...@redhat.com> [Rebased, superfluous local variable dropped,

[Qemu-devel] [PULL 1/5] vga: fix display update region calculation (split screen)

vga display update mis-calculated the region for the dirty bitmap snapshot in case split screen mode is used. This can trigger an assert in cpu_physical_memory_snapshot_get_dirty(). Impact: DoS for privileged guest users. Fixes: CVE-2017-13673 Fixes: fec5e8c92becad223df9d972770522f64aafdb72

[Qemu-devel] [PULL 19/47] qapi-schema: Collect sockets stuff in qapi/sockets.json

Cc: "Daniel P. Berrange" Cc: Gerd Hoffmann Cc: Paolo Bonzini Signed-off-by: Markus Armbruster Message-Id: <1503602048-12268-5-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau

[Qemu-devel] [PULL 34/47] tpm: Clean up driver registration & lookup

From: Marc-André Lureau We have a strict separation between enum TpmType and be_drivers[]: * TpmType may have any number of members. It just happens to have one. * tpm_register_driver() uses the first empty slot in be_drivers[]. If you register more than

[Qemu-devel] [PULL 25/47] qapi-schema: Collect transaction stuff in qapi/transaction.json

Signed-off-by: Markus Armbruster Message-Id: <1503602048-12268-11-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- MAINTAINERS | 1 + Makefile | 1 + qapi-schema.json | 151

[Qemu-devel] [PULL 38/47] block: Use qemu_enum_parse() in blkdebug_debug_breakpoint()

From: Marc-André Lureau The error message on invalid blkdebug events changes from qemu-system-x86_64: LOCATION: Invalid event name "VALUE" to qemu-system-x86_64: LOCATION: invalid parameter value: VALUE Slight degradation, but the message is sub-par even

[Qemu-devel] [PULL 21/47] qapi-schema: Collect char device stuff in qapi/char.json

Cc: Paolo Bonzini Cc: Marc-André Lureau Signed-off-by: Markus Armbruster Message-Id: <1503602048-12268-7-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- MAINTAINERS |

[Qemu-devel] [PULL 22/47] qapi-schema: Collect net device stuff in qapi/net.json

Cc: Jason Wang Signed-off-by: Markus Armbruster Message-Id: <1503602048-12268-8-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- MAINTAINERS | 1 + Makefile | 1 + qapi-schema.json | 675

[Qemu-devel] [PULL 09/47] qlit: make qlit_equal_qobject return a bool

From: Marc-André Lureau Make it more obvious about the expected return values. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Message-Id: <20170825105913.4060-7-marcandre.lur...@redhat.com>

[Qemu-devel] [PULL 45/47] qapi: Convert indirect uses of FOO_lookup[...] to qapi_enum_lookup()

Signed-off-by: Markus Armbruster Message-Id: <1503564371-26090-15-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- hw/core/qdev-properties.c | 7 +-- qapi/qapi-visit-core.c| 2 +- 2 files changed, 6 insertions(+), 3

[Qemu-devel] [PULL 20/47] qapi-schema: Collect run state stuff in qapi/run-state.json

Cc: Paolo Bonzini Signed-off-by: Markus Armbruster Message-Id: <1503602048-12268-6-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- MAINTAINERS | 1 + Makefile| 1 +

[Qemu-devel] [PULL 30/47] qapi-schema: Move queries from common.json to qapi-schema.json

query-version and query-commands are in common.json for no good reason. Several similar queries are in qapi-schema.json. Move them there. Signed-off-by: Markus Armbruster Message-Id: <1503602048-12268-16-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau

[Qemu-devel] [PULL 36/47] hmp: Use qapi_enum_parse() in hmp_migrate_set_capability()

From: Marc-André Lureau The error message on invalid capability name changes from Invalid parameter "NAME" to invalid parameter value: NAME No worse than before. Signed-off-by: Marc-André Lureau Message-Id:

[Qemu-devel] [PULL 40/47] crypto: Use qapi_enum_parse() in qcrypto_block_luks_name_lookup()

Cc: "Daniel P. Berrange" Signed-off-by: Markus Armbruster Message-Id: <1503564371-26090-10-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau Acked-by: Daniel P. Berrange ---

[Qemu-devel] [PULL 28/47] qapi-schema: Fold event.json back into qapi-schema.json

Signed-off-by: Markus Armbruster Message-Id: <1503602048-12268-14-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- Makefile | 2 +- qapi-schema.json | 134 -

[Qemu-devel] [PULL 41/47] qapi: Use qapi_enum_parse() in input_type_enum()

Signed-off-by: Markus Armbruster Message-Id: <1503564371-26090-11-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- qapi/qapi-visit-core.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [PULL 35/47] tpm: Clean up model registration & lookup

We have a strict separation between enum TpmModel and tpm_models[]: * TpmModel may have any number of members. It just happens to have one. * tpm_register_model() uses the first empty slot in tpm_models[]. If you register more than tpm_models[] has space, tpn_register_model() fails. Its

[Qemu-devel] [PULL 11/47] qlit: add QLIT_QNULL and QLIT_BOOL

From: Marc-André Lureau As they are going to be used in the following patches. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Message-Id: <20170825105913.4060-9-marcandre.lur...@redhat.com>

[Qemu-devel] [PULL 15/47] qlit: Tighten QLit list vs QList comparison

From: Marc-André Lureau We check that all members of the QLit list are also in the QList. We neglect to check the other direction. Fix that. While there, use QLIST_FOREACH_ENTRY() to simplify the code and break the loop on the first mismatch. Signed-off-by:

[Qemu-devel] [PULL 10/47] qlit: make qlit_equal_qobject() take const arguments

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Message-Id: <20170825105913.4060-8-marcandre.lur...@redhat.com> Signed-off-by: Markus Armbruster ---

[Qemu-devel] [PULL 12/47] qlit: Replace open-coded qnum_get_int() by call

From: Marc-André Lureau Bonus: rids us of a side effect in an assertion. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Message-Id: <20170825105913.4060-10-marcandre.lur...@redhat.com> Signed-off-by:

[Qemu-devel] [PULL 18/47] qapi-schema: Rocker doc section contains unrelated stuff, fix

Bug: section "Rocker switch device" starts with the rocker stuff, but then has unrelated stuff, like ReplayMode, xen-load-devices-state, ... Cause: rocker.json is included in the middle of section "QMP commands". Fix: include it in a sane place, namely next to the other sub-schemas.

[Qemu-devel] [PULL 26/47] qapi-schema: Collect TPM stuff in qapi/tpm.json

Sadly, we don't have a TPM maintainer, not even a MAINTAINERS entry. Create one, and mark it orphaned. Signed-off-by: Markus Armbruster Message-Id: <1503602048-12268-12-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau ---

[Qemu-devel] [PULL 37/47] hmp: Use qapi_enum_parse() in hmp_migrate_set_parameter()

From: Marc-André Lureau The error message on invalid parameter name changes from Invalid parameter "NAME" to invalid parameter value: NAME Slight degratation, perhaps. Signed-off-by: Marc-André Lureau Message-Id:

[Qemu-devel] [PULL 17/47] qapi-schema: Introspection doc is in the wrong section, fix

Bug: introspection documentation is in section "Tracing commands". Cause: sub-schema qapi/introspect.json lacks a section header, and therefore goes into whatever section precedes its include. Fix: add a section header. Signed-off-by: Markus Armbruster Reviewed-by:

[Qemu-devel] [PULL 06/47] qlit: use QLit prefix consistently

From: Marc-André Lureau Rename from LiteralQ to QLit. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Message-Id: <20170825105913.4060-4-marcandre.lur...@redhat.com> Signed-off-by: Markus Armbruster

[Qemu-devel] [PULL 27/47] qapi-schema: Move block events from event.json to block.json

Cc: Alberto Garcia Signed-off-by: Markus Armbruster Message-Id: <1503602048-12268-13-git-send-email-arm...@redhat.com> Reviewed-by: Alberto Garcia Reviewed-by: Marc-André Lureau --- qapi/block.json | 68

[Qemu-devel] [PULL 00/47] QAPI patches for 2017-09-01

The following changes since commit 223cd0e13f2e46078d7b573f0b8402bfbee339be: Merge remote-tracking branch 'remotes/elmarco/tags/tidy-pull-request' into staging (2017-08-31 15:52:43 +0100) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2017-09-01

[Qemu-devel] [PULL 32/47] qapi: Update qapi-code-gen.txt examples to match current code

Signed-off-by: Markus Armbruster Message-Id: <1503564371-26090-2-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- docs/devel/qapi-code-gen.txt | 47 +++- 1 file changed, 38 insertions(+),

[Qemu-devel] [PULL 05/47] qlit: move qlit from check-qjson to qobject/

From: Marc-André Lureau Fix code style issues while at it, to please checkpatch. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Message-Id: <20170825105913.4060-3-marcandre.lur...@redhat.com>

[Qemu-devel] [PULL 31/47] qapi-schema: Improve section headings

The generated QEMU QMP reference is now structured as follows: 1.1 Introduction 1.2 Stability Considerations 1.3 Common data types 1.4 Socket data types 1.5 VM run state 1.6 Cryptography 1.7 Block devices 1.7.1 Block core (VM unrelated) 1.7.2 QAPI block

[Qemu-devel] [PULL 02/47] tests/qmp-test: Add generic, basic test of query commands

A command is a query if it has no side effect and yields a result. Such commands are typically named query-FOO, but there are exceptions. The basic idea is to find candidates with query-qmp-schema, filter out the ones that aren't queries with an explicit blacklist, and test the remaining ones

[Qemu-devel] [PULL 29/47] qapi-schema: Make block-core.json self-contained

Except for block-core.json, the sub-schemas are self-contained: if they use a symbol defined in another sub-schema, they include that sub-schema. To check, feed the sub-schema to qapi2texi (or any other QAPI generator) along with the pragma from qapi-schema.json. Fix up things to make

[Qemu-devel] [PULL 13/47] tests/check-qlit: New, covering qobject/qlit.c

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20170825105913.4060-11-marcandre.lur...@redhat.com> [Copyright notice correction squashed in, commit message tweaked] Signed-off-by: Markus Armbruster

[Qemu-devel] [PULL 03/47] qobject: Explain how QNum works, and why

Suggested-by: Max Reitz Signed-off-by: Markus Armbruster Message-Id: <1503384739-17207-1-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau [Comment typos fixed] --- include/qapi/qmp/qnum.h | 21

[Qemu-devel] [PULL 07/47] qlit: Change compound literals to initializers

From: Marc-André Lureau The QLIT_QFOO() macros expand into compound literals. Sadly, gcc doesn't recognizes these as constant expressions (clang does), which makes the macros useless for initializing objects with static storage duration. There is a gcc bug about

[Qemu-devel] [PULL 33/47] qapi: Drop superfluous qapi_enum_parse() parameter max

The lookup tables have a sentinel, no need to make callers pass their size. Signed-off-by: Markus Armbruster Message-Id: <1503564371-26090-3-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau Reviewed-by: Eric Blake

[Qemu-devel] [PULL 14/47] qlit: Tighten QLit dict vs QDict comparison

From: Marc-André Lureau We check that all members of the QLit dictionary are also in the QDict. We neglect to check the other direction. Comparing the number of members suffices, because QDict can't contain duplicate members, and putting duplicates in a QLit is a

[Qemu-devel] [PULL 04/47] qdict: Add qdict_put_null() helper, and put it to use

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Message-Id: <20170825105913.4060-2-marcandre.lur...@redhat.com> [Update to qobject.cocci squashed in, commit message tweaked]

[Qemu-devel] [PULL 16/47] qapi-schema: Document how generated documentation is ordered

Documentation generated with qapi2texi.py is in source order, with included sub-schemas inserted at the first include directive (subsequent include directives have no effect). To get a sane and stable order, it's best to include each sub-schema just once, or include it first in qapi-schema.json.

[Qemu-devel] [PULL 01/47] qapi: Fix error handling code on alternate conflict

From: Eduardo Habkost The conflict check added by commit c0644771 ("qapi: Reject alternates that can't work with keyval_parse()") doesn't work with the following declaration: { 'alternate': 'Alt', 'data': { 'one': 'bool', 'two': 'str' } } It crashes

Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io throttling

On 8/31/2017 3:34 PM, Alberto Garcia wrote: On Wed 30 Aug 2017 05:12:22 PM CEST, Pradeep Jagadeesh wrote: On 8/30/2017 5:10 PM, Alberto Garcia wrote: On Wed 30 Aug 2017 05:07:29 PM CEST, Pradeep Jagadeesh wrote: Thanks for the steps, I did reproduce the issue easily. Looking into the code,

Re: [Qemu-devel] [PATCH 00/16] qapi: Rework mapping of enum value to string

Markus Armbruster writes: > The purpose of this work is to make holes in QAPI enumerations > possible. > > Why holes? Because we want to be able to suppress enumeration > constants with #if. Holes could be avoided, e.g. by letting the > compiler assign the values. Falls

Re: [Qemu-devel] [PATCH v2 00/16] qapi-schema: Reorganize along maintenance boundaries

Markus Armbruster writes: > Cc: "Daniel P. Berrange" > Cc: Alberto Garcia > Cc: Dr. David Alan Gilbert > Cc: Gerd Hoffmann > Cc: Jason Wang > Cc: Juan Quintela

Re: [Qemu-devel] [PATCH v4 1/2] tests: Use real size for iov tests

On Fri, Sep 01, 2017 at 01:54:59PM +0200, Juan Quintela wrote: > We were using -1 instead of the real size because the functions check > what is bigger, size in bytes or the size of the iov. Recent gcc's > barf at this. > > Signed-off-by: Juan Quintela > Reviewed-by: Peter

Re: [Qemu-devel] [PATCH v4 2/2] tests: Make vmgenid test compile

On Fri, Sep 01, 2017 at 01:55:00PM +0200, Juan Quintela wrote: > Just make sure that nr_tables is size_t not int. > Once there, do the assert in the right place and be sure that we don't > have a division by zero. > > Suggested-by: Cédric Le Goater > Signed-off-by: Juan Quintela

Re: [Qemu-devel] [PATCH v2 09/16] qapi-schema: Collect migration stuff in qapi/migration.json

Markus Armbruster writes: > "Dr. David Alan Gilbert" writes: > >> * Markus Armbruster (arm...@redhat.com) wrote: >>> Cc: Juan Quintela >>> Cc: Dr. David Alan Gilbert >>> Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2 00/14] Generate a literal qobject for introspection

Marc-André Lureau writes: > Hi, > > This series is based on patches 2-5 from "[PATCH v2 00/54] qapi: add #if > pre-processor conditions to generated code". Generating a literal qobject > will allow to easily introduce #if conditionals from the original series. > >

Re: [Qemu-devel] [PATCH v3 0/2] Fix tests on recent gcc

Juan Quintela wrote: > Hi > > changes from v2: > - change assert from position SelfNAK Just sent the v2 patches instead of v3. A v4 is already on list with the right patches. Sorry, Juan.

[Qemu-devel] [PATCH v4 0/2] Fix tests on recent gcc

Hi v4: really sent the patches for v3, not for v2. Sorry folks [v3] - change assert from position Please review. [v2] - move all uses of -1 for memtest. - remove docs about the feature. - use size_t for the second patch (cedric) Please, review. [v1] On Fedora 26 (gcc-7.1.1 and glib2

<    1   2   3   4   >