Re: [Qemu-devel] [PATCH v11 4/6] target-arm: kvm64: detect guest RAS EXTENSION feature

2017-09-05 Thread Peter Maydell
On 18 August 2017 at 15:23, Dongjiu Geng wrote: > check if kvm supports guest RAS EXTENSION. if so, set > corresponding feature bit for vcpu. > > Signed-off-by: Dongjiu Geng > --- > linux-headers/linux/kvm.h | 1 + > target/arm/cpu.h | 3 +++ > target/arm/kvm64.c| 8 >

Re: [Qemu-devel] [PATCH 2/9] s390x: fix invalid use of cc 1 for SSCH

2017-09-05 Thread Halil Pasic
On 09/05/2017 05:46 PM, Cornelia Huck wrote: > On Tue, 5 Sep 2017 17:24:19 +0200 > Halil Pasic wrote: > >> My problem with a program check (indicated by SCSW word 2 bit 10) is >> that, in my reading of the architecture, the semantic behind it is: The >> channel subsystem (not the cu or device)

Re: [Qemu-devel] [PATCH] vhost-user: disable broken test

2017-09-05 Thread Daniel P. Berrange
On Tue, Sep 05, 2017 at 02:08:22PM -0300, Philippe Mathieu-Daudé wrote: > tests/vhost-user-test keeps failing on build-system since Aug 15: > > ERROR:tests/vhost-user-test.c:835:test_flags_mismatch: child process > (/i386/vhost-user/flags-mismatch/subprocess [4836]) failed unexpectedly > ... >

Re: [Qemu-devel] [PULL v2 0/4] 9pfs/virtfs patches for 2.11 20170905

2017-09-05 Thread Peter Maydell
On 5 September 2017 at 17:00, Greg Kurz wrote: > The following changes since commit 53e2c48d3f0db6a1598f49baf0b56dd4975e53a7: > > Merge remote-tracking branch 'remotes/mcayland/tags/qemu-sparc-signed' into > staging (2017-09-04 18:53:46 +0100) > > are available in the git repository at: > > h

Re: [Qemu-devel] [PATCH] vhost-user: disable broken test

2017-09-05 Thread Peter Maydell
On 5 September 2017 at 18:08, Philippe Mathieu-Daudé wrote: > tests/vhost-user-test keeps failing on build-system since Aug 15: > > ERROR:tests/vhost-user-test.c:835:test_flags_mismatch: child process > (/i386/vhost-user/flags-mismatch/subprocess [4836]) failed unexpectedly > ... > ERROR:test

[Qemu-devel] [Bug 1715186] Re: websockets: Improve error messages

2017-09-05 Thread Daniel Berrange
At very least we should also use 404 if given a invalid path -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1715186 Title: websockets: Improve error messages Status in QEMU: New Bug description:

Re: [Qemu-devel] [PATCH 10/20] nvic: Add NS alias SCS region

2017-09-05 Thread Peter Maydell
On 5 September 2017 at 17:48, Richard Henderson wrote: > On 09/05/2017 09:26 AM, Peter Maydell wrote: >> We don't map the hole. The container is 0x21000 in size, the normal >> nvic_sysregs region is 0x1000 at offset 0x0 (which will be 0xe000e000 >> in the system address space), and the NS alias re

[Qemu-devel] [PATCH] vhost-user: disable broken test

2017-09-05 Thread Philippe Mathieu-Daudé
tests/vhost-user-test keeps failing on build-system since Aug 15: ERROR:tests/vhost-user-test.c:835:test_flags_mismatch: child process (/i386/vhost-user/flags-mismatch/subprocess [4836]) failed unexpectedly ... ERROR:tests/vhost-user-test.c:807:test_connect_fail: child process (/x86_64/vhost

Re: [Qemu-devel] [PATCH] virtfs: error out gracefully when mandatory suboptions are missing

2017-09-05 Thread Greg Kurz
On Tue, 05 Sep 2017 10:20:22 -0500 Michael Roth wrote: [...] > > > > Well, it's been there forever and it isn't a critical fix... but the > > thread on qemu-discuss the other day showed that it was confusing > > people, and the fix is trivial. So I guess it doesn't hurt to have > > this in stable

[Qemu-devel] [Bug 1715186] [NEW] websockets: Improve error messages

2017-09-05 Thread Brian Rak
Public bug reported: Since 2.9 / 07e95cd529af345fdeea230913f68eff5b925bb6 , whenever the VNC websocket server finds an error with the incoming connection request, it just closes the socket with no further information. This makes figuring out what's wrong with the request nearly impossible. I wou

Re: [Qemu-devel] [RFC PATCH] tests: Add a device_add/del HMP test

2017-09-05 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Thomas Huth writes: > > > People tend to forget to mark internal devices with "user_creatable = false > > or hotpluggable = false, and these devices can crash QEMU if added via the > > HMP monitor. So let's add a test to run through all devices and

Re: [Qemu-devel] [PATCH 10/20] nvic: Add NS alias SCS region

2017-09-05 Thread Richard Henderson
On 09/05/2017 09:26 AM, Peter Maydell wrote: > We don't map the hole. The container is 0x21000 in size, the normal > nvic_sysregs region is 0x1000 at offset 0x0 (which will be 0xe000e000 > in the system address space), and the NS alias region > is 0x1000 at offset 0x2 (0xe002e000 in the system

Re: [Qemu-devel] [PATCH 14/20] target/arm: Make MPU_RNR register banked for v8M

2017-09-05 Thread Peter Maydell
On 29 August 2017 at 17:09, Richard Henderson wrote: > On 08/29/2017 09:06 AM, Peter Maydell wrote: >> On 29 August 2017 at 17:05, Richard Henderson >> wrote: >>> On 08/22/2017 08:08 AM, Peter Maydell wrote: +env->pmsav7.rnr[M_REG_NS] = 0; +env->pmsav7.rnr[M_REG_S] = 0;

Re: [Qemu-devel] [PATCH 16/20] target/arm: Make CCR register banked for v8M

2017-09-05 Thread Peter Maydell
On 29 August 2017 at 17:08, Richard Henderson wrote: > On 08/22/2017 08:08 AM, Peter Maydell wrote: >> +if (attrs.secure) { >> +/* the BFHFNMIGN bit is not banked; keep that in the NS copy */ >> +int new_bfhnmign = !!(value & R_V7M_CCR_BFHFNMIGN_MASK); >> + >> +

Re: [Qemu-devel] [PATCH v2 23/54] qapi-commands: add #if conditions to commands

2017-09-05 Thread Markus Armbruster
Marc-André Lureau writes: > - Original Message - >> Hi >> >> - Original Message - >> > Marc-André Lureau writes: >> > >> > > Wrap generated code with #if/#endif using the ifcond_decorator. >> > > >> > > Signed-off-by: Marc-André Lureau >> > > --- >> > > scripts/qapi-commands.

Re: [Qemu-devel] [PATCH v2 17/54] qapi: add 'if' condition on entity objects

2017-09-05 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> Marc-André Lureau writes: >> >> > Take 'if' from expression, and use it to construct entity objects. >> > Shared implicit objects must share the same 'if' condition. >> >> Shared by what? > > Shared by various make_implicit_obj

Re: [Qemu-devel] [PATCH 10/20] nvic: Add NS alias SCS region

2017-09-05 Thread Peter Maydell
On 29 August 2017 at 17:00, Richard Henderson wrote: > On 08/22/2017 08:08 AM, Peter Maydell wrote: >> +regionlen = arm_feature(&s->cpu->env, ARM_FEATURE_V8) ? 0x21000 : >> 0x1000; >> +memory_region_init(&s->container, OBJECT(s), "nvic", regionlen); >> /* The system register region g

Re: [Qemu-devel] [PATCH 4/9] s390x: refactor error handling for SSCH and RSCH

2017-09-05 Thread Cornelia Huck
On Tue, 5 Sep 2017 17:55:17 +0200 Halil Pasic wrote: > On 08/31/2017 11:55 AM, Cornelia Huck wrote: > > On Wed, 30 Aug 2017 18:36:04 +0200 > > Halil Pasic wrote: > > > >> Simplify the error handling of the SSCH and RSCH handler avoiding > >> arbitrary and cryptic error codes being mapped to w

Re: [Qemu-devel] [PATCH v2 22/54] qapi-introspect: add preprocessor conditions to generated QLit

2017-09-05 Thread Marc-André Lureau
On Tue, Sep 5, 2017 at 4:24 PM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> Add 'ifcond' condition to QLit objects. >> >> to_qlit() handles the (obj, ifcond) tuples. >> >> Signed-off-by: Marc-André Lureau >> --- >> scripts/qapi-introspect.py | 20 +++- >> 1 file ch

[Qemu-devel] [Bug 1545052] Re: RDMA migration will hang forever if target QEMU fails to load vmstate

2017-09-05 Thread Dr. David Alan Gilbert
Yes, we probably can - I'd still not be that sure we've got all the races in the RDMA code, but we're probably a chunk better of than we were. ** Changed in: qemu Status: In Progress => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which i

Re: [Qemu-devel] clang-tidy: use g_new() family of functions

2017-09-05 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > >> Suggest you show us cool things you can do with clang-tidy that haven't >> been done with Coccinelle :) >> > Well to do that I would have to have a transformations to do & know the > limits/strength of coccinelle & clang-tidy, I am not there yet... Today, I >

Re: [Qemu-devel] [PATCH v6 3/6] gicv3: Convert to DEFINE_PROP_LINK

2017-09-05 Thread Philippe Mathieu-Daudé
On 09/05/2017 12:35 PM, Fam Zheng wrote: On Tue, 09/05 10:44, Philippe Mathieu-Daudé wrote: Hi Fam, On 09/05/2017 10:11 AM, Fam Zheng wrote: Signed-off-by: Fam Zheng --- hw/intc/arm_gicv3_its_kvm.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/h

Re: [Qemu-devel] [PATCH v9 6/6] qemu-iotests: add 184 for throttle filter driver

2017-09-05 Thread Kevin Wolf
Am 25.08.2017 um 15:20 hat Manos Pitsidianakis geschrieben: > Reviewed-by: Alberto Garcia > Signed-off-by: Manos Pitsidianakis Does this test actually (still) pass for you? I can't see that it's related to any recent change in master, but this is the diff that I get. I can update the reference

[Qemu-devel] [PULL v2 3/4] 9pfs: local: clarify fchmodat_nofollow() implementation

2017-09-05 Thread Greg Kurz
Since fchmodat(2) on Linux doesn't support AT_SYMLINK_NOFOLLOW, we have to implement it using workarounds. There are two different ways, depending on whether the system supports O_PATH or not. In the case O_PATH is supported, we rely on the behavhior of openat(2) when passing O_NOFOLLOW | O_PATH a

[Qemu-devel] [PULL v2 1/4] 9pfs: avoid sign conversion error simplifying the code

2017-09-05 Thread Greg Kurz
From: Philippe Mathieu-Daudé (note this is how other functions also handle the errors). hw/9pfs/9p.c:948:18: warning: Loss of sign in implicit conversion offset = err; ^~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Greg Kurz

[Qemu-devel] [PULL v2 0/4] 9pfs/virtfs patches for 2.11 20170905

2017-09-05 Thread Greg Kurz
The following changes since commit 53e2c48d3f0db6a1598f49baf0b56dd4975e53a7: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-sparc-signed' into staging (2017-09-04 18:53:46 +0100) are available in the git repository at: https://github.com/gkurz/qemu.git tags/for-upstream for you t

Re: [Qemu-devel] [PATCH v2 1/3] boards.h: Define new flag ignore_memory_transaction_failures

2017-09-05 Thread Richard Henderson
On 09/05/2017 08:53 AM, Peter Maydell wrote: > Define a new MachineClass field ignore_memory_transaction_failures. > If this is flag is true then the CPU will ignore memory transaction > failures which should cause the CPU to take an exception due to an > access to an unassigned physical address; t

[Qemu-devel] [PULL v2 4/4] virtfs: error out gracefully when mandatory suboptions are missing

2017-09-05 Thread Greg Kurz
We internally convert -virtfs to -fsdev/-device. If the user doesn't provide the path or security_model suboptions, and the fsdev backend requires them, we hit an assertion when populating the internal -fsdev option: util/qemu-option.c:547: opt_set: Assertion `opt->str' failed. Aborted (core dumpe

[Qemu-devel] [PULL v2 2/4] fsdev: fix memory leak in main()

2017-09-05 Thread Greg Kurz
From: ZhiPeng Lu @rpath and @sock_name are not freed and leaked. [groug, not really leaked since the program exits just after that. But it is always good practice to free allocated memory] Signed-off-by: Zhipeng Lu Signed-off-by: Greg Kurz --- fsdev/virtfs-proxy-helper.c | 2 ++ 1 file chan

Re: [Qemu-devel] [PATCH] target/alpha: Switch to do_transaction_failed() hook

2017-09-05 Thread Peter Maydell
On 8 August 2017 at 13:42, Peter Maydell wrote: > Switch the alpha target from the old unassigned_access hook > to the new do_transaction_failed hook. This allows us to > resolve a ??? in the old hook implementation. > > The only part of the alpha target that does physical > memory accesses is rea

[Qemu-devel] [PATCH v2 3/3] target/arm: Implement new do_transaction_failed hook

2017-09-05 Thread Peter Maydell
Implement the new do_transaction_failed hook for ARM, which should cause the CPU to take a prefetch abort or data abort. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Edgar E. Iglesias --- target/arm/internals.h | 10 ++ target/arm/cpu.c | 1 + target/

Re: [Qemu-devel] [PATCH 4/9] s390x: refactor error handling for SSCH and RSCH

2017-09-05 Thread Halil Pasic
On 08/31/2017 11:55 AM, Cornelia Huck wrote: > On Wed, 30 Aug 2017 18:36:04 +0200 > Halil Pasic wrote: > >> Simplify the error handling of the SSCH and RSCH handler avoiding >> arbitrary and cryptic error codes being mapped to what a subchannel is >> supposed to do. Let the code detecting the

Re: [Qemu-devel] clang-tidy: use g_new() family of functions

2017-09-05 Thread Marc-André Lureau
Hi > Suggest you show us cool things you can do with clang-tidy that haven't > been done with Coccinelle :) > > Well to do that I would have to have a transformations to do & know the limits/strength of coccinelle & clang-tidy, I am not there yet... Today, I prefer invest in clang-tidy for what I

[Qemu-devel] [PATCH v2 0/3] Add do_transaction_failed hook for ARM

2017-09-05 Thread Peter Maydell
I sent these patches earlier, but only realized when I put them in the target-arm pull request that they broke the user-mode emulators. Only change in these 3 patches from v1 is that patch 1 now checks that what it gets from qdev_get_machine() is really an instance of TYPE_MACHINE before using it

[Qemu-devel] [PATCH v2 1/3] boards.h: Define new flag ignore_memory_transaction_failures

2017-09-05 Thread Peter Maydell
Define a new MachineClass field ignore_memory_transaction_failures. If this is flag is true then the CPU will ignore memory transaction failures which should cause the CPU to take an exception due to an access to an unassigned physical address; the transaction will instead return zero (for a read)

[Qemu-devel] [PATCH v2 2/3] hw/arm: Set ignore_memory_transaction_failures for most ARM boards

2017-09-05 Thread Peter Maydell
Set the MachineClass flag ignore_memory_transaction_failures for almost all ARM boards. This means they retain the legacy behaviour that accesses to unimplemented addresses will RAZ/WI rather than aborting, when a subsequent commit adds support for external aborts. The exceptions are: * virt -- w

Re: [Qemu-devel] [PULL 0/4] 9pfs/virtfs patches for 2.11 20170905

2017-09-05 Thread Greg Kurz
Peter, You can ignore this pull request, I hadn't realized that Zhipeng's patch has an ill-formed Signed-off-by tag: Signed-off-by: Zhipeng Lu lu.zhip...@zte.com.cn The missing <> around the email address breaks the dialog between git send-email and the mail relay... I'll fix that and send a v2.

Re: [Qemu-devel] [PATCH] hw/arm/allwinner-a10: Mark the allwinner-a10 device with user_creatable = false

2017-09-05 Thread Peter Maydell
On 5 September 2017 at 14:57, Thomas Huth wrote: > On 23.08.2017 20:00, Eduardo Habkost wrote: >> On Wed, Aug 23, 2017 at 06:51:28PM +0100, Peter Maydell wrote: >>> On 23 August 2017 at 18:21, Eduardo Habkost wrote: On Tue, Aug 22, 2017 at 05:46:29PM +0200, Thomas Huth wrote: > QEMU curr

Re: [Qemu-devel] [PATCH v6 0/6] arm: Make use of DEFINE_PROP_LINK

2017-09-05 Thread Peter Maydell
On 5 September 2017 at 14:11, Fam Zheng wrote: > v6: Rebase and resend v5: Add Philippe's rev-bys and fix one typo in bitband > patch. > > This is the arm part that was left out from: > > https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg04006.html > > Make use of the new DEFINE_PROP_LI

Re: [Qemu-devel] [PATCH 2/9] s390x: fix invalid use of cc 1 for SSCH

2017-09-05 Thread Cornelia Huck
On Tue, 5 Sep 2017 17:24:19 +0200 Halil Pasic wrote: > My problem with a program check (indicated by SCSW word 2 bit 10) is > that, in my reading of the architecture, the semantic behind it is: The > channel subsystem (not the cu or device) has detected, that the > the channel program (previousl

[Qemu-devel] [PULL 0/4] 9pfs/virtfs patches for 2.11 20170905

2017-09-05 Thread Greg Kurz
The following changes since commit 53e2c48d3f0db6a1598f49baf0b56dd4975e53a7: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-sparc-signed' into staging (2017-09-04 18:53:46 +0100) are available in the git repository at: https://github.com/gkurz/qemu.git tags/for-upstream for you t

[Qemu-devel] [PULL 1/4] 9pfs: avoid sign conversion error simplifying the code

2017-09-05 Thread Greg Kurz
From: Philippe Mathieu-Daudé (note this is how other functions also handle the errors). hw/9pfs/9p.c:948:18: warning: Loss of sign in implicit conversion offset = err; ^~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Greg Kurz

Re: [Qemu-devel] [PATCH v2 17/54] qapi: add 'if' condition on entity objects

2017-09-05 Thread Marc-André Lureau
Hi - Original Message - > Marc-André Lureau writes: > > > Take 'if' from expression, and use it to construct entity objects. > > Shared implicit objects must share the same 'if' condition. > > Shared by what? Shared by various make_implicit_object_type() users. > > > > > Signed-off-b

Re: [Qemu-devel] [PULL 0/4] Block patches

2017-09-05 Thread Peter Maydell
On 5 September 2017 at 14:29, Stefan Hajnoczi wrote: > The following changes since commit 2b483739791b33c46e6084b51edcf62107058ae1: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20170904-2' into staging (2017-09-04 > 17:21:24 +0100) > > are available in the git repo

Re: [Qemu-devel] [PATCH v6 3/6] gicv3: Convert to DEFINE_PROP_LINK

2017-09-05 Thread Fam Zheng
On Tue, 09/05 10:44, Philippe Mathieu-Daudé wrote: > Hi Fam, > > On 09/05/2017 10:11 AM, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > hw/intc/arm_gicv3_its_kvm.c | 19 +++ > > 1 file changed, 7 insertions(+), 12 deletions(-) > > > > diff --git a/hw/intc/arm_gicv3_

Re: [Qemu-devel] clang-tidy: use g_new() family of functions

2017-09-05 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Tue, Sep 5, 2017 at 2:56 PM Markus Armbruster wrote: > >> Marc-André Lureau writes: >> >> > Hi, >> > >> > I have a series of changes generated with clang-tidy qemu [1] pending >> > for review [2]. >> > >> > It translates calloc/*malloc*/*realloc() calls to

Re: [Qemu-devel] [PATCH] configure: Drop AIX host support

2017-09-05 Thread Peter Maydell
On 5 September 2017 at 08:36, Thomas Huth wrote: > OTOH, AIX support is really very, very like broken since years It turns out there's an AIX box in the gcc compile farm, so just out of curiosity I had a look. (1) we don't recognize the cpu so you have to pass --cpu=ppc64 (2) we unconditionally

Re: [Qemu-devel] [PATCH 0/2] buildsys: Move -lnettle and -lgnutls to per object variables

2017-09-05 Thread Daniel P. Berrange
On Tue, Sep 05, 2017 at 11:13:17PM +0800, Fam Zheng wrote: > Not all targets need the flags and libs of nettle/gnutls, so move > them out from global variables, as done with other libraries. > > Fam Zheng (2): > buildsys: Move nettle cflags/libs to per object > buildsys: Move gnutls cflags/lib

Re: [Qemu-devel] [PATCH 2/9] s390x: fix invalid use of cc 1 for SSCH

2017-09-05 Thread Halil Pasic
On 09/05/2017 10:02 AM, Cornelia Huck wrote: > On Thu, 31 Aug 2017 12:41:05 +0200 > Halil Pasic wrote: > >> On 08/31/2017 11:19 AM, Cornelia Huck wrote: >>> On Wed, 30 Aug 2017 18:36:02 +0200 >>> Halil Pasic wrote: >>> According to the POP a start subchannel instruction (SSCH) returnin

Re: [Qemu-devel] [PATCH v9 4/6] block: convert ThrottleGroup to object with QOM

2017-09-05 Thread Kevin Wolf
Am 25.08.2017 um 15:20 hat Manos Pitsidianakis geschrieben: > ThrottleGroup is converted to an object. This will allow the future > throttle block filter drive easy creation and configuration of throttle > groups in QMP and cli. > > A new QAPI struct, ThrottleLimits, is introduced to provide a sha

Re: [Qemu-devel] [PATCH] virtfs: error out gracefully when mandatory suboptions are missing

2017-09-05 Thread Michael Roth
Quoting Greg Kurz (2017-09-05 09:24:25) > On Tue, 5 Sep 2017 15:35:34 +0200 > Thomas Huth wrote: > > > On 04.09.2017 09:59, Greg Kurz wrote: > > > We internally convert -virtfs to -fsdev/-device. If the user doesn't > > > provide the path or security_model suboptions, and the fsdev backend > > >

[Qemu-devel] [PATCH 1/3] iotests: use -ccw on s390x for 040, 139, and 182

2017-09-05 Thread Cornelia Huck
The default cpu model on s390x does not provide zPCI, which is not yet wired up on tcg. Moreover, virtio-ccw is the standard on s390x, so use the -ccw instead of the -pci versions of virtio devices on s390x. Signed-off-by: Cornelia Huck --- tests/qemu-iotests/040 | 6 +- tests/qemu-iotests/

[Qemu-devel] [PATCH 3/3] iotests: use -ccw on s390x for 067

2017-09-05 Thread Cornelia Huck
The default cpu model on s390x does not provide zPCI, which is not yet wired up on tcg. Moreover, virtio-ccw is the standard on s390x, so use the -ccw instead of the -pci versions of virtio devices on s390x. Provide an output file for s390x. Signed-off-by: Cornelia Huck --- tests/qemu-iotests/0

[Qemu-devel] [PATCH 2/3] iotests: use -ccw on s390x for 051

2017-09-05 Thread Cornelia Huck
The default cpu model on s390x does not provide zPCI, which is not yet wired up on tcg. Moreover, virtio-ccw is the standard on s390x, so use the -ccw instead of the -pci versions of virtio devices on s390x. Provide an output file for s390x. Signed-off-by: Cornelia Huck --- tests/qemu-iotests/0

[Qemu-devel] [PATCH 0/3] iotests: cure s390x failures by switching to ccw

2017-09-05 Thread Cornelia Huck
Recent changes in s390x made pci support dependant on the zpci cpu feature, which is not provided on all models (and not on by default). This means we cannot instatiate pci devices on a standard qemu invocation for s390x. Moreover, the zpci instructions are not even wired up for tcg yet, so actuall

[Qemu-devel] [PATCH 2/2] buildsys: Move gnutls cflags/libs to per object

2017-09-05 Thread Fam Zheng
Signed-off-by: Fam Zheng --- configure | 4 ++-- crypto/Makefile.objs | 7 +++ tests/Makefile.include | 10 +- 3 files changed, 14 insertions(+), 7 deletions(-) diff --git a/configure b/configure index 6a4cb3832b..d24a7eab37 100755 --- a/configure +++ b/configure @@

[Qemu-devel] [PATCH 0/2] buildsys: Move -lnettle and -lgnutls to per object variables

2017-09-05 Thread Fam Zheng
Not all targets need the flags and libs of nettle/gnutls, so move them out from global variables, as done with other libraries. Fam Zheng (2): buildsys: Move nettle cflags/libs to per object buildsys: Move gnutls cflags/libs to per object configure | 9 - crypto/Makefil

[Qemu-devel] [PATCH 1/2] buildsys: Move nettle cflags/libs to per object

2017-09-05 Thread Fam Zheng
Signed-off-by: Fam Zheng --- configure| 5 ++--- crypto/Makefile.objs | 6 ++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/configure b/configure index fb7e34a901..6a4cb3832b 100755 --- a/configure +++ b/configure @@ -2616,9 +2616,6 @@ if test "$nettle" != "no"; t

Re: [Qemu-devel] [PATCH 1/1] block: add block device shared field

2017-09-05 Thread Brian Steffens
Thanks for taking a look at the patch and fixing the missing CC addresses! > Have you considered extending the 'migrate' command with a list of > drives instead? That was my original plan but I thought having information on whether a device is shared or not could potentially be useful to other sy

Re: [Qemu-devel] [PATCH v2 23/54] qapi-commands: add #if conditions to commands

2017-09-05 Thread Marc-André Lureau
- Original Message - > Hi > > - Original Message - > > Marc-André Lureau writes: > > > > > Wrap generated code with #if/#endif using the ifcond_decorator. > > > > > > Signed-off-by: Marc-André Lureau > > > --- > > > scripts/qapi-commands.py | 2 ++ > > > tests/test-qmp-comma

Re: [Qemu-devel] [PATCH v2 23/54] qapi-commands: add #if conditions to commands

2017-09-05 Thread Marc-André Lureau
Hi - Original Message - > Marc-André Lureau writes: > > > Wrap generated code with #if/#endif using the ifcond_decorator. > > > > Signed-off-by: Marc-André Lureau > > --- > > scripts/qapi-commands.py | 2 ++ > > tests/test-qmp-commands.c | 4 ++-- > > 2 files changed, 4 insertions(+),

Re: [Qemu-devel] [PULL v1 0/2] Merge QEMU crypto 2017/09/05

2017-09-05 Thread Peter Maydell
> > are available in the git repository at: > > git://github.com/berrange/qemu tags/pull-qcrypto-20170905-1 > > for you to fetch changes up to 23c1595b0297e6ca8f37559af6f0b8533aa1fd99: > > crypto: fix test cert generation to not

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/1] ppc: spapr: Move VCPU ID calculation into sPAPR

2017-09-05 Thread Greg Kurz
On Tue, 5 Sep 2017 09:31:47 +1000 Sam Bobroff wrote: > On Mon, Sep 04, 2017 at 12:18:57PM +0200, Greg Kurz wrote: > > On Thu, 31 Aug 2017 16:38:46 +1000 > > Sam Bobroff wrote: > > > > > Move the calculation of a CPU's VCPU ID out of the generic PPC code > > > (ppc_cpu_realizefn()) and into sP

Re: [Qemu-devel] [PATCH 0/7] serial: add serial_chr_nonnull()

2017-09-05 Thread Peter Maydell
On 31 August 2017 at 04:52, Philippe Mathieu-Daudé wrote: > Hi, > > This series add the serial_chr_nonnull() which connect to the "null" chardev > backend if none is provided. > > Inspired by Peter's suggestion: > http://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg05987.html > which also r

Re: [Qemu-devel] [PATCH v2 23/54] qapi-commands: add #if conditions to commands

2017-09-05 Thread Markus Armbruster
Marc-André Lureau writes: > Wrap generated code with #if/#endif using the ifcond_decorator. > > Signed-off-by: Marc-André Lureau > --- > scripts/qapi-commands.py | 2 ++ > tests/test-qmp-commands.c | 4 ++-- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/scripts/qapi-comma

Re: [Qemu-devel] [PATCH v2 4/4] target/arm/kvm: pmu: improve error handling

2017-09-05 Thread Andrew Jones
On Mon, Sep 04, 2017 at 03:17:21PM +0100, Peter Maydell wrote: > On 19 July 2017 at 14:39, Andrew Jones wrote: > > If a KVM PMU init or set-irq attr call fails we just silently stop > > the PMU DT node generation. The only way they could fail, though, > > is if the attr's respective KVM has-attr c

Re: [Qemu-devel] [PATCH v3 4/7] block: remove legacy I/O throttling

2017-09-05 Thread Stefan Hajnoczi
On Fri, Aug 25, 2017 at 04:23:29PM +0300, Manos Pitsidianakis wrote: > void blk_io_limits_disable(BlockBackend *blk) > { > -assert(blk->public.throttle_group_member.throttle_state); > -bdrv_drained_begin(blk_bs(blk)); > -throttle_group_unregister_tgm(&blk->public.throttle_group_member

Re: [Qemu-devel] Persistent bitmaps for non-qcow2 formats

2017-09-05 Thread Kevin Wolf
Am 05.09.2017 um 15:39 hat Fam Zheng geschrieben: > On Tue, 09/05 15:27, Kevin Wolf wrote: > > Am 05.09.2017 um 15:18 hat Fam Zheng geschrieben: > > > On Tue, 09/05 15:01, Kevin Wolf wrote: > > > > Am 28.08.2017 um 04:57 hat Fam Zheng geschrieben: > > > > > On Fri, 08/25 15:44, Max Reitz wrote: > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/4] ppc: fix migration with KVM PR (nested)

2017-09-05 Thread Greg Kurz
I wanted to Cc Sam also but it was late and I forgot :) On Mon, 04 Sep 2017 23:46:44 +0200 Greg Kurz wrote: > A guest running with KVM PR ends up irresponsive after migration most of the > time. This happens because the HPT allocated by QEMU is likely to have a > different address on the destina

Re: [Qemu-devel] [PATCH] virtfs: error out gracefully when mandatory suboptions are missing

2017-09-05 Thread Greg Kurz
On Tue, 5 Sep 2017 15:35:34 +0200 Thomas Huth wrote: > On 04.09.2017 09:59, Greg Kurz wrote: > > We internally convert -virtfs to -fsdev/-device. If the user doesn't > > provide the path or security_model suboptions, and the fsdev backend > > requires them, we hit an assertion when populating the

[Qemu-devel] 答复: [PATCH] intc: arm_gicv3: limit GICR ipriority index

2017-09-05 Thread niuguoxiang
I think only assert is not enough, because assert() depends on NDEBUG preprocessing, please check : /usr/include/assert.h 37#if defined __cplusplus && __GNUC_PREREQ (2,95) 38# define __ASSERT_VOID_CAST static_cast 39#else 40# define __ASSERT_VOID_CAST (void) 41#endif 48#ifdef NDEBUG

Re: [Qemu-devel] [PATCH v2 22/54] qapi-introspect: add preprocessor conditions to generated QLit

2017-09-05 Thread Markus Armbruster
Marc-André Lureau writes: > Add 'ifcond' condition to QLit objects. > > to_qlit() handles the (obj, ifcond) tuples. > > Signed-off-by: Marc-André Lureau > --- > scripts/qapi-introspect.py | 20 +++- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/scripts/qapi

Re: [Qemu-devel] [PATCH v6 02/29] tests: Sort .gitignore

2017-09-05 Thread Eric Blake
On 09/05/2017 05:10 AM, Daniel P. Berrange wrote: > Fairly even split between 'test' as a prefix vs suffix. 'check' as a > prefix should clearly be killed as a minority pattern. Any appetite > for standardizing naming of everything else ? > > A further idea might be to actually have separate sub-

Re: [Qemu-devel] [PULL v2 0/5] Merge QEMU I/O 2017/09/05 v2

2017-09-05 Thread Peter Maydell
> > are available in the git repository at: > > git://github.com/berrange/qemu tags/pull-qio-20170905-2 > > for you to fetch changes up to 689ed13e73bdb5a5ca3366524475e3065fae854a: > > io: fix check for handshake com

[Qemu-devel] [Bug 1715162] [NEW] qemu-user crashing when writing core dump

2017-09-05 Thread Ross Burton
Public bug reported: I've a binary I'm running in qemux86-64 but it is segfaulting. Whilst qemu writes the core dump for that, qemu itself is segfaulting. (gdb) bt full #0 0x7efdd962e32e in sigsuspend () from /data/poky-tmp/master/build/sysroots-uninative/x86_64-linux/lib/libc.so.6 No symb

Re: [Qemu-devel] [PATCH] util/qemu-thread-posix.c: Replace OS ifdefs with CONFIG_HAVE_SEM_TIMEDWAIT

2017-09-05 Thread Eric Blake
On 09/05/2017 07:19 AM, Peter Maydell wrote: > In qemu-thread-posix.c we have two implementations of the > various qemu_sem_* functions, one of which uses native POSIX > sem_* and the other of which emulates them with pthread conditions. > This is necessary because not all our host OSes support > s

Re: [Qemu-devel] [PATCH v2 3/3] hmp: Optionally disable live block operations in HMP monitor

2017-09-05 Thread Dr. David Alan Gilbert
* Jeff Cody (jc...@redhat.com) wrote: > From: Jeffrey Cody > > If live block operations are disabled, disable the corresponding > HMP commands. > > Signed-off-by: Jeff Cody OK from HMP side, although perhaps it's worth squashing some of the commands so they're adjacent in the files. Dave > -

Re: [Qemu-devel] [PATCH v9 0/6] add throttle block driver filter

2017-09-05 Thread Stefan Hajnoczi
On Fri, Aug 25, 2017 at 04:20:22PM +0300, Manos Pitsidianakis wrote: > This series adds a throttle block driver filter. Currently throttling is done > at the BlockBackend level. Using block driver interfaces we can move the > throttling to any point in the BDS graph using a throttle node which uses

Re: [Qemu-devel] [PATCH v9 6/6] qemu-iotests: add 184 for throttle filter driver

2017-09-05 Thread Stefan Hajnoczi
On Fri, Aug 25, 2017 at 04:20:28PM +0300, Manos Pitsidianakis wrote: > Reviewed-by: Alberto Garcia > Signed-off-by: Manos Pitsidianakis > --- > tests/qemu-iotests/184 | 205 +++ > tests/qemu-iotests/184.out | 300 > + >

[Qemu-devel] [PATCH v2 0/2] drop pixman submodule

2017-09-05 Thread Gerd Hoffmann
v2: also drop the pixman configure switches. Gerd Hoffmann (2): pixman: drop submodule pixman: drop configure switches configure| 44 Makefile | 10 -- ui/qemu-pixman.c | 4 .gitmodules | 3 --- pixman

[Qemu-devel] [PATCH v2 2/2] pixman: drop configure switches

2017-09-05 Thread Gerd Hoffmann
Remove pixman switches from configure, should not be needed any more, configure can figure by itself whenever pixman is needed or not. Signed-off-by: Gerd Hoffmann --- configure | 24 ++-- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git a/configure b/configure in

[Qemu-devel] [PATCH v2 1/2] pixman: drop submodule

2017-09-05 Thread Gerd Hoffmann
Drop pixman submodule and support for the "internal" pixman build. pixman should be reasonably well established meanwhile so we don't need the fallback submodule any more. While being at it also drop some #ifdefs for pixman versions older than what we require in configure anyway. Signed-off-by: G

Re: [Qemu-devel] [PATCH v9 5/6] block: add throttle block filter driver

2017-09-05 Thread Stefan Hajnoczi
On Fri, Aug 25, 2017 at 04:20:27PM +0300, Manos Pitsidianakis wrote: > +static int throttle_configure_tgm(BlockDriverState *bs, > + ThrottleGroupMember *tgm, > + QDict *options, Error **errp) > +{ > +int ret; > +const char *g

Re: [Qemu-devel] [PATCH] hw/arm/allwinner-a10: Mark the allwinner-a10 device with user_creatable = false

2017-09-05 Thread Thomas Huth
On 23.08.2017 20:00, Eduardo Habkost wrote: > On Wed, Aug 23, 2017 at 06:51:28PM +0100, Peter Maydell wrote: >> On 23 August 2017 at 18:21, Eduardo Habkost wrote: >>> On Tue, Aug 22, 2017 at 05:46:29PM +0200, Thomas Huth wrote: QEMU currently exits unexpectedly when the user accidentially >>>

Re: [Qemu-devel] [PATCH v2 15/54] qapi: add 'if' to top-level expressions

2017-09-05 Thread Marc-André Lureau
Hi On Mon, Sep 4, 2017 at 3:27 PM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> Accept 'if' key in top-level elements, accepted as string or list of >> string type. The following patches will modify the test visitor to >> check the value is correctly saved, and generate #if/#endif c

Re: [Qemu-devel] [PATCH v9 4/6] block: convert ThrottleGroup to object with QOM

2017-09-05 Thread Stefan Hajnoczi
On Fri, Aug 25, 2017 at 04:20:26PM +0300, Manos Pitsidianakis wrote: > ThrottleGroup is converted to an object. This will allow the future > throttle block filter drive easy creation and configuration of throttle > groups in QMP and cli. > > A new QAPI struct, ThrottleLimits, is introduced to prov

Re: [Qemu-devel] [PATCH v6 3/6] gicv3: Convert to DEFINE_PROP_LINK

2017-09-05 Thread Philippe Mathieu-Daudé
Hi Fam, On 09/05/2017 10:11 AM, Fam Zheng wrote: Signed-off-by: Fam Zheng --- hw/intc/arm_gicv3_its_kvm.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/hw/intc/arm_gicv3_its_kvm.c b/hw/intc/arm_gicv3_its_kvm.c index 1f8991b8a6..39903d5eab 100644 ---

Re: [Qemu-devel] Persistent bitmaps for non-qcow2 formats

2017-09-05 Thread Fam Zheng
On Tue, 09/05 15:27, Kevin Wolf wrote: > Am 05.09.2017 um 15:18 hat Fam Zheng geschrieben: > > On Tue, 09/05 15:01, Kevin Wolf wrote: > > > Am 28.08.2017 um 04:57 hat Fam Zheng geschrieben: > > > > On Fri, 08/25 15:44, Max Reitz wrote: > > > > > Well, OK. The main argument against supporting anyth

Re: [Qemu-devel] [PATCH 2/2] i386/cpu/hyperv: support over 64 vcpus for windows guests

2017-09-05 Thread Eduardo Habkost
On Tue, Sep 05, 2017 at 05:30:05PM +0800, Gonglei wrote: > Starting with Windows Server 2012 and Windows 8, if > CPUID.4005.EAX contains a value of -1, Windows assumes specific > limit to the number of VPs. In this case, Windows Server 2012 > guest VMs may use more than 64 VPs, up to the maximu

Re: [Qemu-devel] [PATCH 1/2] pc: add 2.11 machine type

2017-09-05 Thread Eduardo Habkost
On Tue, Sep 05, 2017 at 05:30:04PM +0800, Gonglei wrote: > CC: "Michael S. Tsirkin" > CC: Paolo Bonzini > CC: Richard Henderson > CC: Eduardo Habkost > Signed-off-by: Gonglei > --- > hw/i386/pc_piix.c| 15 --- > hw/i386/pc_q35.c | 13 +++-- > include/hw/i386/pc.h |

Re: [Qemu-devel] [PATCH] virtfs: error out gracefully when mandatory suboptions are missing

2017-09-05 Thread Thomas Huth
On 04.09.2017 09:59, Greg Kurz wrote: > We internally convert -virtfs to -fsdev/-device. If the user doesn't > provide the path or security_model suboptions, and the fsdev backend > requires them, we hit an assertion when populating the internal -fsdev > option: > > util/qemu-option.c:547: opt_set

Re: [Qemu-devel] clang-tidy: use g_new() family of functions

2017-09-05 Thread Marc-André Lureau
Hi On Tue, Sep 5, 2017 at 2:56 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > Hi, > > > > I have a series of changes generated with clang-tidy qemu [1] pending > > for review [2]. > > > > It translates calloc/*malloc*/*realloc() calls to > > g_new/g_newa/g_new0/g_renew() where th

[Qemu-devel] [PULL 4/4] block: document semantics of bdrv_co_preadv|pwritev

2017-09-05 Thread Stefan Hajnoczi
From: "Daniel P. Berrange" Reviewed-by: Stefan Hajnoczi Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange Message-id: 20170831105456.9558-1-berra...@redhat.com Signed-off-by: Stefan Hajnoczi --- include/block/block_int.h | 31 +++ 1 file changed, 31 insert

[Qemu-devel] [PULL 2/4] iotests.py: add FilePath context manager

2017-09-05 Thread Stefan Hajnoczi
The scratch/ (TEST_DIR) directory is not automatically cleaned up after test execution. It is the responsibility of tests to remove any files they create. A nice way of doing this is to declare files at the beginning of the test and automatically remove them with a context manager: with iotest

[Qemu-devel] [PULL 1/4] qemu.py: make VM() a context manager

2017-09-05 Thread Stefan Hajnoczi
There are a number of ways to ensure that the QEMU process is shut down when the test ends, including atexit.register(), try: finally:, or unittest.teardown() methods. All of these require extra code and the programmer must remember to add vm.shutdown(). A nice solution is context managers: wi

[Qemu-devel] [PULL 3/4] qemu-iotests: use context managers for resource cleanup in 194

2017-09-05 Thread Stefan Hajnoczi
Switch from atexit.register() to a more elegant idiom of declaring resources in a with statement: with FilePath('monitor.sock') as monitor_path, VM() as vm: ... The files and VMs will be automatically cleaned up whether the test passes or fails. Signed-off-by: Stefan Hajnoczi Mes

[Qemu-devel] [PULL 0/4] Block patches

2017-09-05 Thread Stefan Hajnoczi
The following changes since commit 2b483739791b33c46e6084b51edcf62107058ae1: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20170904-2' into staging (2017-09-04 17:21:24 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-r

Re: [Qemu-devel] Persistent bitmaps for non-qcow2 formats

2017-09-05 Thread Kevin Wolf
Am 05.09.2017 um 15:18 hat Fam Zheng geschrieben: > On Tue, 09/05 15:01, Kevin Wolf wrote: > > Am 28.08.2017 um 04:57 hat Fam Zheng geschrieben: > > > On Fri, 08/25 15:44, Max Reitz wrote: > > > > Well, OK. The main argument against supporting anything but qcow2 is > > > > "if you want features, u

[Qemu-devel] [PATCH v2] watchdog: Allow setting action on the fly

2017-09-05 Thread Michal Privoznik
Currently, the only time that users can set watchdog action is at the start as all we expose is this -watchdog-action command line argument. This is suboptimal when users want to plug the device later via monitor. Alternatively, they might want to change the action for already existing device on th

[Qemu-devel] [PATCH v6 4/6] xlnx_zynqmp: Convert to DEFINE_PROP_LINK

2017-09-05 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Philippe Mathieu-Daudé --- hw/arm/xlnx-zynqmp.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c index 9eceadbdc8..22c2a33719 100644 --- a/hw/arm/xlnx-zynqmp.c +++ b/hw/arm/xlnx-zynqmp.c @

<    1   2   3   4   >