[Qemu-devel] [RFC 04/15] monitor: move skip_flush into monitor_data_init

2017-09-14 Thread Peter Xu
It's part of the data init. Collect it. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- monitor.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 9239f7a..8b32519 100644 ---

[Qemu-devel] [RFC 06/15] monitor: move the cur_mon hack deeper for QMP

2017-09-14 Thread Peter Xu
In monitor_qmp_read(), we have the hack to temporarily replace the cur_mon pointer. Now we move this hack deeper inside the QMP dispatcher routine since the Monitor pointer can be passed in to that using the new JSON Parser opaque field now. This does not make much sense as a single patch.

[Qemu-devel] [RFC 02/15] qobject: allow NULL for qstring_get_str()

2017-09-14 Thread Peter Xu
Then I can get NULL rather than crash when calling things like: qstring_get_str(qobject_to_qstring(object)); when key does not exist. CC: Markus Armbruster Signed-off-by: Peter Xu --- qobject/qstring.c | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-14 Thread Peter Xu
This series was born from this one: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg04310.html The design comes from Markus, and also the whole-bunch-of discussions in previous thread. My heartful thanks to Markus, Daniel, Dave, Stefan, etc. on discussing the topic (...again!),

[Qemu-devel] [RFC 01/15] char-io: fix possible race on IOWatchPoll

2017-09-14 Thread Peter Xu
This is not a problem if we are only having one single loop thread like before. However, after per-monitor thread is introduced, this is not true any more, and the race can happen. The race can be triggered with "make check -j8" sometimes: qemu-system-x86_64:

Re: [Qemu-devel] [PATCH] filter-mirror: segfault when specifying non existent device

2017-09-14 Thread Michael Tokarev
21.08.2017 18:50, Eduardo Otubo wrote: > When using filter-mirror like the example below where the interface > 'ndev0' does not exist on the host, QEMU crashes into segmentation > fault. Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH v2 5/5] arm: drop intermediate cpu_model -> cpu type parsing and use cpu type directly

2017-09-14 Thread Igor Mammedov
On Thu, 14 Sep 2017 00:47:20 -0300 Philippe Mathieu-Daudé wrote: > Hi Igor, > > awesome clean refactor! Thanks, there is more patches on this topic for other targets to post but it's waiting on 1-3/5 to land in master so it would be easier for maintainers to verify/test them

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3 00/15] add missing entries in MAINTAINERS

2017-09-14 Thread Michael Tokarev
08.09.2017 20:31, Philippe Mathieu-Daudé wrote: > Hi, > > I tried to have a more helpful ./scripts/get_maintainer.pl output, filling > missing entries in MAINTAINERS. Applied all to -trivial, thank you! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-2.11] tests: Fix broken ivshmem-server-msi/-irq tests

2017-09-14 Thread Michael Tokarev
29.08.2017 21:13, Thomas Huth wrote: > Broken with commit b4ba67d9a7025 ("libqos: Change PCI accessors to take > opaque BAR handle") a while ago, but nobody noticed since the tests are > only run in SPEED=slow mode: The msix_pba_bar is not correctly initialized > anymore if bir_pba has the same

Re: [Qemu-devel] [PATCH for-2.11] hw/misc/ivshmem: Fix ivshmem_recv_msg() to also work on big endian systems

2017-09-14 Thread Michael Tokarev
30.08.2017 16:39, Thomas Huth пишет: > The "slow" ivshmem-tests currently fail when they are running on a > big endian host: Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] Replace round_page() with TARGET_PAGE_ALIGN()

2017-09-14 Thread Michael Tokarev
11.09.2017 23:16, Kamil Rytarowski пишет: > This change fixes conflict with the DragonFly BSD headers. Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH for-2.9?] configure: Remove unused code (found by shellcheck)

2017-09-14 Thread Michael Tokarev
16.08.2017 15:57, Stefan Weil пишет: > It looks like this patch got lost somehow. > > Stefan > > See also https://patchwork.codeaurora.org/patch/210129/ > > > Am 28.03.2017 um 20:49 schrieb Stefan Weil: >> smartcard_cflags is no longer needed since commit >>

Re: [Qemu-devel] [PATCH] spapr_pci: make index property mandatory

2017-09-14 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] spapr_pci: make index property mandatory Message-id: 150537259490.3298.1180094221641142666.stgit@bahia Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PATCH] spapr_pci: make index property mandatory

2017-09-14 Thread Greg Kurz
Creating several PHBs without index property confuses the DRC code and causes issues: - only the first index-less PHB is functional, the other ones will silently ignore hotplugging of PCI devices - QEMU will even terminate if these PHBs have cold-plugged devices qemu-system-ppc64: -device

[Qemu-devel] QEMU terminates during reboot after memory unplug with vhost=on

2017-09-14 Thread Bharata B Rao
Hi, QEMU hits the below assert qemu-system-ppc64: used ring relocated for ring 2 qemu-system-ppc64: qemu/hw/virtio/vhost.c:649: vhost_commit: Assertion `r >= 0' failed. in the following scenario: 1. Boot guest with vhost=on -netdev

Re: [Qemu-devel] [PATCH v4 2/4] hmp: fix "dump-quest-memory" segfault (arm)

2017-09-14 Thread Auger Eric
Hi Laurent, On 13/09/2017 16:20, Laurent Vivier wrote: > Running QEMU with > qemu-system-aarch64 -M none -nographic -m 256 > and executing > dump-guest-memory /dev/null 0 8192 > results in segfault > > Fix by checking if we have CPU, and exit with > error if there is no CPU: > >

Re: [Qemu-devel] [PATCH v3] spapr: disable decrementer during reset

2017-09-14 Thread Nikunj A Dadhania
David Gibson writes: > On Wed, Jul 19, 2017 at 09:20:52AM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> > On Tue, Jul 18, 2017 at 10:53:01AM +0530, Nikunj A Dadhania wrote: >> >> David Gibson

Re: [Qemu-devel] [PATCH v3 0/9] virtio: enhance virtio_error messages

2017-09-14 Thread Ladi Prosek
On Fri, Jul 21, 2017 at 5:21 PM, Stefan Hajnoczi wrote: > On Mon, Jul 17, 2017 at 10:11:43AM +0200, Ladi Prosek wrote: >> Output like "Virtqueue size exceeded" is not much useful in identifying the >> culprit. This series beefs up virtio_error to print the virtio device name

<    1   2   3   4