[Qemu-devel] [PATCH v3 5/6] tcg/i386: Add vector operations

2017-09-15 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.h | 36 +++- tcg/i386/tcg-target.inc.c | 423 +- 2 files changed, 413 insertions(+), 46 deletions(-) diff --git a/tcg/i386/tcg-target.h b/tcg/i386/tcg-target.h

Re: [Qemu-devel] [PATCH v3 0/6] TCG vectorization and example conversion

2017-09-15 Thread Richard Henderson
On 09/15/2017 07:34 PM, Richard Henderson wrote: > Now addressing the complex vector op issue. I now expose TCGv_vec > to target front-ends, but opaque wrt the vector size. One can thus > compose vector operations, as demonstrated in target/arm/. > > The actual host vector length now becomes an

[Qemu-devel] [PATCH v3 2/6] tcg: Add vector expanders

2017-09-15 Thread Richard Henderson
Signed-off-by: Richard Henderson --- Makefile.target | 2 +- accel/tcg/tcg-runtime.h | 24 ++ tcg/tcg-gvec-desc.h | 49 +++ tcg/tcg-op-gvec.h| 143 accel/tcg/tcg-runtime-gvec.c | 255 +

[Qemu-devel] [PATCH v3 1/6] tcg: Add types and operations for host vectors

2017-09-15 Thread Richard Henderson
Nothing uses or enables them yet. Signed-off-by: Richard Henderson --- tcg/tcg-op.h | 26 +++ tcg/tcg-opc.h | 37 ++ tcg/tcg.h | 34 + tcg/tcg-op.c | 234 ++ tcg/tcg.c | 77

[Qemu-devel] [PATCH v3 4/6] target/arm: Use vector infrastructure for aa64 add/sub/logic

2017-09-15 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 216 ++--- 1 file changed, 143 insertions(+), 73 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index a3984c9a0d..4759cc9829

[Qemu-devel] [PATCH v3 6/6] tcg/aarch64: Add vector operations

2017-09-15 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 20 ++- tcg/aarch64/tcg-target.inc.c | 340 +-- 2 files changed, 315 insertions(+), 45 deletions(-) diff --git a/tcg/aarch64/tcg-target.h

[Qemu-devel] [PATCH v3 3/6] target/arm: Align vector registers

2017-09-15 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 98b9b26fd3..c346bd148f 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -486,7 +486,7 @@

[Qemu-devel] [PATCH v3 0/6] TCG vectorization and example conversion

2017-09-15 Thread Richard Henderson
Now addressing the complex vector op issue. I now expose TCGv_vec to target front-ends, but opaque wrt the vector size. One can thus compose vector operations, as demonstrated in target/arm/. The actual host vector length now becomes an argument to the *_vec opcodes. It's a little awkward, but

Re: [Qemu-devel] [PULL 00/11] Ide patches

2017-09-15 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/11] Ide patches Message-id: 20170916010330.10435-1-js...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE..

[Qemu-devel] [PULL 08/11] AHCI: Replace DPRINTF with trace-events

2017-09-15 Thread John Snow
There are a few hangers-on that will be dealt with individually in forthcoming patches. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id:

[Qemu-devel] [PULL 10/11] AHCI: pretty-print FIS to buffer instead of stderr

2017-09-15 Thread John Snow
The current FIS printing routines dump the FIS to screen. adjust this such that it dumps to buffer instead, then use this ability to have FIS dump mechanisms via trace-events instead of compiled defines. Signed-off-by: John Snow Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PULL 09/11] AHCI: Rework IRQ constants

2017-09-15 Thread John Snow
Create a new enum so that we can name the IRQ bits, which will make debugging them a little nicer if we can print them out. Not handled in this patch, but this will make it possible to get a nice debug printf detailing exactly which status bits are set, as it can be multiple at any given time. As

[Qemu-devel] [PULL 11/11] AHCI: remove DPRINTF macro

2017-09-15 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 20170901001502.29915-10-js...@redhat.com

[Qemu-devel] [PULL 03/11] IDE: replace DEBUG_IDE with tracing system

2017-09-15 Thread John Snow
Remove the DEBUG_IDE preprocessor definition with something more appropriately flexible, using the trace-events subsystem. This will be less prone to bitrot and will more effectively allow us to target just the functions we care about. Signed-off-by: John Snow Reviewed-by:

[Qemu-devel] [PULL 04/11] IDE: Add register hints to tracing

2017-09-15 Thread John Snow
Name the registers for tracing purposes. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 20170901001502.29915-3-js...@redhat.com Signed-off-by: John Snow --- hw/ide/core.c

[Qemu-devel] [PULL 01/11] ide: ahci: unparent children buses before freeing their memory

2017-09-15 Thread John Snow
From: Igor Mammedov Fixes read after freeing error reported https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg04243.html Message-Id: <59a56959-ca12-ea75-33fa-ff07eba1b...@redhat.com> ich9-ahci device creates ide buses and attaches them as QOM children at realize

[Qemu-devel] [PULL 07/11] IDE: replace DEBUG_AIO with trace events

2017-09-15 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Stefan Hajnoczi Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Message-id: 20170901001502.29915-6-js...@redhat.com Signed-off-by: John Snow ---

[Qemu-devel] [PULL 05/11] IDE: add tracing for data ports

2017-09-15 Thread John Snow
To be used sparingly, but still interesting in the case of small firmwares designed to reproduce bugs in QEMU IDE. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PULL 02/11] hw/ide/microdrive: Mark the dscm1xxxx device with user_creatable = false

2017-09-15 Thread John Snow
From: Thomas Huth QEMU currently aborts with an assertion message when the user is trying to remove a dscm1 again: $ aarch64-softmmu/qemu-system-aarch64 -S -M integratorcp -nographic QEMU 2.9.93 monitor - type 'help' for more information (qemu) device_add dscm1,id=xyz

[Qemu-devel] [PULL 06/11] ATAPI: Replace DEBUG_IDE_ATAPI with tracing events

2017-09-15 Thread John Snow
As part of the ongoing effort to modernize the tracing facilities for the IDE family of devices, remove PRINTFs in the ATAPI device with actual tracing events. Signed-off-by: John Snow Reviewed-by: Stefan Hajnoczi Reviewed-by: Eric Blake

[Qemu-devel] [PULL 00/11] Ide patches

2017-09-15 Thread John Snow
The following changes since commit 5faf2d376af3cb4eb92da44c2580e08d39832caa: Merge remote-tracking branch 'remotes/huth/tags/check-20170915' into staging (2017-09-15 20:29:44 +0100) are available in the git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull-request for you

Re: [Qemu-devel] [PATCH qemu v2 11/13] memory: Share FlatView's and dispatch trees between address spaces

2017-09-15 Thread Alexey Kardashevskiy
On 15/09/17 19:25, Paolo Bonzini wrote: > On 15/09/2017 10:40, Alexey Kardashevskiy wrote: >> + >> +static bool flatview_can_share(FlatView *old_view, FlatView *new_view) >> +{ >> +MemoryRegion *old_root = memory_region_unalias_entire(old_view->root); >> +MemoryRegion *new_root =

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add Python scripts

2017-09-15 Thread Eduardo Habkost
On Fri, Sep 15, 2017 at 08:17:18PM -0400, John Snow wrote: > > > On 09/15/2017 07:07 PM, Eduardo Habkost wrote: > > Cleber and I are volunteering to review and queue patches for the > > Python scripts and modules in scripts/. > > > > I'm setting "M: Odd fixes" because not all scripts are

Re: [Qemu-devel] [PATCH v2 7/7] mips: update mips_cpu_list() to use object_class_get_list()

2017-09-15 Thread Eduardo Habkost
On Wed, Aug 30, 2017 at 07:52:25PM -0300, Philippe Mathieu-Daudé wrote: > while here, move it from translate_init.c to helper.c > > Signed-off-by: Philippe Mathieu-Daudé > Tested-by: Igor Mammedov > Tested-by: James Hogan > --- >

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add Python scripts

2017-09-15 Thread John Snow
On 09/15/2017 07:07 PM, Eduardo Habkost wrote: > Cleber and I are volunteering to review and queue patches for the > Python scripts and modules in scripts/. > > I'm setting "M: Odd fixes" because not all scripts are actively > maintained. > > Signed-off-by: Eduardo Habkost

Re: [Qemu-devel] [PATCH v2 6/7] mips: replace cpu_mips_init() with cpu_generic_init()

2017-09-15 Thread Eduardo Habkost
On Wed, Aug 30, 2017 at 07:52:24PM -0300, Philippe Mathieu-Daudé wrote: > From: Igor Mammedov > > now cpu_mips_init() reimplements subset of cpu_generic_init() > tasks, so just drop it and use cpu_generic_init() directly. > > Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [PATCH v2 5/7] mips: MIPSCPU model subclasses

2017-09-15 Thread Eduardo Habkost
On Wed, Aug 30, 2017 at 07:52:23PM -0300, Philippe Mathieu-Daudé wrote: > From: Igor Mammedov > > Register separate QOM types for each mips cpu model, > so it would be possible to reuse generic CPU creation > routines. > > Signed-off-by: Igor Mammedov

[Qemu-devel] [PULL 15/15] qemu.py: include debug information on launch error

2017-09-15 Thread Eduardo Habkost
From: Amador Pahim When launching a VM, if an exception happens and the VM is not initiated, it might be useful to see the qemu command line and the qemu command output. This patch creates that message. Notice that self._iolog needs to be cleaned up in the beginning of the

Re: [Qemu-devel] [PATCH v2 4/7] mips: call cpu_mips_realize_env() from mips_cpu_realizefn()

2017-09-15 Thread Eduardo Habkost
On Wed, Aug 30, 2017 at 07:52:22PM -0300, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > Tested-by: Igor Mammedov > Tested-by: James Hogan > --- > target/mips/cpu.c | 3 +++ > target/mips/translate.c |

[Qemu-devel] [PULL 14/15] qemu.py: improve message on negative exit code

2017-09-15 Thread Eduardo Habkost
From: Amador Pahim The current message shows 'self._args', which contains only part of the options used in the Qemu command line. This patch makes the qemu full args list an instance variable and then uses it in the negative exit code message. Message was moved outside the

[Qemu-devel] [PULL 13/15] qemu.py: use os.path.null instead of /dev/null

2017-09-15 Thread Eduardo Habkost
From: Amador Pahim For increased portability, let's use os.path.devnull. Signed-off-by: Amador Pahim Message-Id: <20170901112829.2571-4-apa...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Fam Zheng

[Qemu-devel] [PULL 08/15] qmp.py: Avoid "has_key" usage

2017-09-15 Thread Eduardo Habkost
From: Lukáš Doktor The "has_key" is deprecated in favor of "__in__" operator. Signed-off-by: Lukáš Doktor Reviewed-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[Qemu-devel] [PULL 07/15] qmp.py: Use object-based class for QEMUMonitorProtocol

2017-09-15 Thread Eduardo Habkost
From: Lukáš Doktor There is no need to define QEMUMonitorProtocol as old-style class. Signed-off-by: Lukáš Doktor Reviewed-by: Eduardo Habkost Message-Id: <20170818142613.32394-8-ldok...@redhat.com> Signed-off-by: Eduardo Habkost

[Qemu-devel] [PULL 10/15] qtest.py: Few pylint/style fixes

2017-09-15 Thread Eduardo Habkost
From: Lukáš Doktor No actual code changes, just few pylint/style fixes. Signed-off-by: Lukáš Doktor Reviewed-by: John Snow Message-Id: <20170818142613.32394-11-ldok...@redhat.com> Signed-off-by: Eduardo Habkost

[Qemu-devel] [PULL 05/15] qemu.py: Use custom exceptions rather than Exception

2017-09-15 Thread Eduardo Habkost
From: Lukáš Doktor The naked Exception should not be widely used. It makes sense to be a bit more specific and use better-suited custom exceptions. As a benefit we can store the full reply in the exception in case someone needs it when catching the exception. Signed-off-by:

[Qemu-devel] [PULL 09/15] qmp.py: Avoid overriding a builtin object

2017-09-15 Thread Eduardo Habkost
From: Lukáš Doktor The "id" is a builtin method to get object's identity and should not be overridden. This might bring some issues in case someone was directly calling "cmd(..., id=id)" but I haven't found such usage on brief search for "cmd\(.*id=". Signed-off-by: Lukáš

[Qemu-devel] [PULL 04/15] qemu.py: Simplify QMP key-conversion

2017-09-15 Thread Eduardo Habkost
From: Lukáš Doktor The QMP key conversion consist of '_'s to be replaced with '-'s, which can easily be done by a single `str.replace` method which is faster and does not require `string` module import. Signed-off-by: Lukáš Doktor Reviewed-by: Eduardo

[Qemu-devel] [PULL 11/15] qemu.py: fix is_running() return before first launch()

2017-09-15 Thread Eduardo Habkost
From: Amador Pahim is_running() returns None when called before the first time we call launch(): >>> import qemu >>> vm = qemu.QEMUMachine('qemu-system-x86_64') >>> vm.is_running() >>> It should return False instead. This patch fixes that. For consistence,

[Qemu-devel] [PULL 06/15] qmp.py: Couple of pylint/style fixes

2017-09-15 Thread Eduardo Habkost
From: Lukáš Doktor No actual code changes, just initializing attributes earlier to avoid AttributeError on early introspection, a few pylint/style fixes and docstring clarifications. Signed-off-by: Lukáš Doktor Reviewed-by: Philippe Mathieu-Daudé

[Qemu-devel] [PULL 12/15] qemu.py: avoid writing to stdout/stderr

2017-09-15 Thread Eduardo Habkost
From: Amador Pahim This module should not write directly to stdout/stderr. Instead, it should either raise exceptions or just log the messages and let the callers handle them and decide what to do. For example, scripts could choose to send the log messages stderr or/and write

[Qemu-devel] [PULL 02/15] qemu|qtest: Avoid dangerous arguments

2017-09-15 Thread Eduardo Habkost
From: Lukáš Doktor The list object is mutable in python and potentially might modify other object's arguments when used as default argument. Reproducer: >>> vm1 = QEMUMachine("qemu") >>> vm2 = QEMUMachine("qemu") >>> vm1._wrapper.append("foo") >>> print

[Qemu-devel] [PULL 01/15] qemu.py: Pylint/style fixes

2017-09-15 Thread Eduardo Habkost
From: Lukáš Doktor No actual code changes, just several pylint/style fixes and docstring clarifications. Signed-off-by: Lukáš Doktor Reviewed-by: Stefan Hajnoczi Message-Id: <20170818142613.32394-2-ldok...@redhat.com> Reviewed-by:

[Qemu-devel] [PULL 03/15] qemu.py: Use iteritems rather than keys()

2017-09-15 Thread Eduardo Habkost
From: Lukáš Doktor Let's avoid creating an in-memory list of keys and query for each value and use `iteritems` which is an iterator of key-value pairs. Signed-off-by: Lukáš Doktor Reviewed-by: Eduardo Habkost Reviewed-by: Philippe

[Qemu-devel] [PULL 00/15] Python queue, 2017-09-15

2017-09-15 Thread Eduardo Habkost
request before the MAINTAINERS patch is applied. The following changes since commit 5faf2d376af3cb4eb92da44c2580e08d39832caa: Merge remote-tracking branch 'remotes/huth/tags/check-20170915' into staging (2017-09-15 20:29:44 +0100) are available in the git repository at: git://github.com

[Qemu-devel] [Bug 1594394] Re: Using setreuid / setegid crashes x86_64 user-mode target

2017-09-15 Thread James Clarke
And to confirm, while somewhat of a hack, that patch does indeed fix aptitude as expected (as well as my minimal test case I wrote when debugging this before stumbling upon this bug report). -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [Bug 1594394] Re: Using setreuid / setegid crashes x86_64 user-mode target

2017-09-15 Thread James Clarke
What's the status of this? This is causing aptitude in Debian chroots to reliably segfault under qemu-arm-user. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1594394 Title: Using setreuid /

[Qemu-devel] [PATCH] MAINTAINERS: Add Python scripts

2017-09-15 Thread Eduardo Habkost
Cleber and I are volunteering to review and queue patches for the Python scripts and modules in scripts/. I'm setting "M: Odd fixes" because not all scripts are actively maintained. Signed-off-by: Eduardo Habkost --- Even before this patch is merged, I plan to send a pull

Re: [Qemu-devel] [PATCH v2 1/1] target/xtensa: Use the pre-defined MEMTXATTRS_UNSPECIFIED macro

2017-09-15 Thread Max Filippov
On Fri, Sep 15, 2017 at 2:56 PM, Alistair Francis wrote: > Instead of using the hardcoded (MemTxAttrs){0} for no memory attributes > let's use the already defined MEMTXATTRS_UNSPECIFIED macro instead. > > This is technically a change of behaviour as

Re: [Qemu-devel] [PATCH v2 1/2] x86_iommu: Move machine check to x86_iommu_realize()

2017-09-15 Thread Eduardo Habkost
On Fri, Sep 15, 2017 at 05:04:36PM +0200, Mohammed Gamal wrote: > Instead of having the same error checks in vtd_realize() > and amdvi_realize(), move that over to the generic > x86_iommu_realize(). > > Signed-off-by: Mohammed Gamal > --- > hw/i386/amd_iommu.c | 10

Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-15 Thread Eduardo Habkost
On Fri, Sep 15, 2017 at 12:18:11PM +0200, Paolo Bonzini wrote: > On 15/09/2017 11:06, Eduardo Otubo wrote: > > QEMU fails when used with the following command line: > > > > ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374 > > qemu-system-ppc64: hw/isa/isa-bus.c:110:

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH] tests: Add a device_add/del HMP test

2017-09-15 Thread Eduardo Habkost
On Wed, Sep 13, 2017 at 07:45:11AM +0200, Thomas Huth wrote: > On 12.09.2017 19:37, Eduardo Habkost wrote: > > On Mon, Sep 11, 2017 at 08:13:21AM +0200, Thomas Huth wrote: > >> On 09.09.2017 22:41, Eduardo Habkost wrote: > >>> On Wed, Sep 06, 2017 at 08:59:32AM +0200, Markus Armbruster wrote: >

Re: [Qemu-devel] [PATCH v2 2/6] hw/block/fdc: Convert to realize

2017-09-15 Thread John Snow
On 08/04/2017 06:26 AM, Mao Zhongyi wrote: > Convert floppy_drive_init() to realize and rename it to > floppy_drive_realize(). > > Cc: John Snow > Cc: Kevin Wolf > Cc: Max Reitz > Cc: Markus Armbruster > >

Re: [Qemu-devel] [PATCH] rbd: Detect rbd image resizes and propagate them

2017-09-15 Thread Eric Blake
On 09/15/2017 07:33 AM, Kevin Wolf wrote: > Am 13.09.2017 um 18:44 hat Adam Wolfe Gordon geschrieben: >> Register a watcher with rbd so that we get notified when an image is >> resized. Propagate resizes to parent block devices so that guest devices >> get resized without user intervention. >> >>

Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/6] hw/ide: Convert DeviceClass init to realize

2017-09-15 Thread John Snow
On 09/15/2017 05:35 PM, John Snow wrote: > > > On 08/04/2017 06:26 AM, Mao Zhongyi wrote: >> Replace init with realize in IDEDeviceClass, which has errp >> as a parameter. So all the implementations now use error_setg >> instead of error_report for reporting error. >> >> Cc: John Snow

[Qemu-devel] [PATCH v2 1/1] target/xtensa: Use the pre-defined MEMTXATTRS_UNSPECIFIED macro

2017-09-15 Thread Alistair Francis
Instead of using the hardcoded (MemTxAttrs){0} for no memory attributes let's use the already defined MEMTXATTRS_UNSPECIFIED macro instead. This is technically a change of behaviour as MEMTXATTRS_UNSPECIFIED sets the unspecified field to 1, but it doesn't look like anything is checking this

Re: [Qemu-devel] [PATCH v2 1/6] hw/ide: Convert DeviceClass init to realize

2017-09-15 Thread John Snow
On 09/15/2017 05:42 PM, Eric Blake wrote: > On 09/15/2017 04:35 PM, John Snow wrote: >> >> >> On 08/04/2017 06:26 AM, Mao Zhongyi wrote: >>> Replace init with realize in IDEDeviceClass, which has errp >>> as a parameter. So all the implementations now use error_setg >>> instead of error_report

Re: [Qemu-devel] [PATCH v2 1/6] hw/ide: Convert DeviceClass init to realize

2017-09-15 Thread Eric Blake
On 09/15/2017 04:35 PM, John Snow wrote: > > > On 08/04/2017 06:26 AM, Mao Zhongyi wrote: >> Replace init with realize in IDEDeviceClass, which has errp >> as a parameter. So all the implementations now use error_setg >> instead of error_report for reporting error. >> >> @@ -2398,7 +2399,7 @@

Re: [Qemu-devel] [PATCH v2 1/6] hw/ide: Convert DeviceClass init to realize

2017-09-15 Thread John Snow
On 08/04/2017 06:26 AM, Mao Zhongyi wrote: > Replace init with realize in IDEDeviceClass, which has errp > as a parameter. So all the implementations now use error_setg > instead of error_report for reporting error. > > Cc: John Snow > Cc: Markus Armbruster

Re: [Qemu-devel] [PULL 0/9] Fixes and improvements for various qtests

2017-09-15 Thread Peter Maydell
are available in the git repository at: > > git://github.com/huth/qemu.git tags/check-20170915 > > for you to fetch changes up to 7b899f4dd596dbb7d271f7fab36fbfffec84868e: > > qtest: Avoid passing raw string

Re: [Qemu-devel] [PATCH v3] linux-user/syscall.c: Handle SH4's exceptional alignment for p{read, write}64

2017-09-15 Thread Philippe Mathieu-Daudé
On 09/15/2017 04:33 PM, James Clarke wrote: Fixes: https://bugs.launchpad.net/qemu/+bug/1716767 Signed-off-by: James Clarke Reviewed-by: Philippe Mathieu-Daudé --- Changes since v2: * Fixed opening curly brace formatting, both for my new SH4-specific

Re: [Qemu-devel] [PULL v4 00/38] Test and build patches

2017-09-15 Thread Fam Zheng
On Fri, 09/15 11:47, Philippe Mathieu-Daudé wrote: > why not generate 1 key in > tests/vm/ (or clever ~/.cache/qemu-vm/ already used by those scripts) once > when the make vm-test rule is called, that would be 1 key per repository > clone (or 1 per user using ~/.cache). Like I explained

Re: [Qemu-devel] [PATCH v3] linux-user/syscall.c: Handle SH4's exceptional alignment for p{read, write}64

2017-09-15 Thread John Paul Adrian Glaubitz
(re-sent because GPG messed up the line endings) On 09/15/2017 09:33 PM, James Clarke wrote: > Fixes: https://bugs.launchpad.net/qemu/+bug/1716767 > Signed-off-by: James Clarke > --- > > Changes since v2: > * Fixed opening curly brace formatting, both for my new SH4-specific

Re: [Qemu-devel] [PATCH v3] linux-user/syscall.c: Handle SH4's exceptional alignment for p{read, write}64

2017-09-15 Thread John Paul Adrian Glaubitz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 09/15/2017 09:33 PM, James Clarke wrote: > Fixes: https://bugs.launchpad.net/qemu/+bug/1716767 Signed-off-by: James > Clarke --- > > Changes since v2: * Fixed opening curly brace formatting, both for my new > SH4-specific

Re: [Qemu-devel] [PATCH v3] linux-user/syscall.c: Handle SH4's exceptional alignment for p{read, write}64

2017-09-15 Thread Richard Henderson
On 09/15/2017 12:33 PM, James Clarke wrote: > Fixes: https://bugs.launchpad.net/qemu/+bug/1716767 > Signed-off-by: James Clarke > --- > > Changes since v2: > * Fixed opening curly brace formatting, both for my new SH4-specific >regpairs_aligned function, as well as the

Re: [Qemu-devel] [PATCH v3] linux-user/syscall.c: Handle SH4's exceptional alignment for p{read, write}64

2017-09-15 Thread Laurent Vivier
Le 15/09/2017 à 21:33, James Clarke a écrit : > Fixes: https://bugs.launchpad.net/qemu/+bug/1716767 > Signed-off-by: James Clarke > --- > > Changes since v2: > * Fixed opening curly brace formatting, both for my new SH4-specific >regpairs_aligned function, as well as the

Re: [Qemu-devel] [PATCH v3] linux-user/syscall.c: Handle SH4's exceptional alignment for p{read, write}64

2017-09-15 Thread Eric Blake
On 09/15/2017 02:33 PM, James Clarke wrote: > Fixes: https://bugs.launchpad.net/qemu/+bug/1716767 > Signed-off-by: James Clarke > --- > > Changes since v2: > * Fixed opening curly brace formatting, both for my new SH4-specific >regpairs_aligned function, as well as the

[Qemu-devel] [PATCH v3] linux-user/syscall.c: Handle SH4's exceptional alignment for p{read, write}64

2017-09-15 Thread James Clarke
Fixes: https://bugs.launchpad.net/qemu/+bug/1716767 Signed-off-by: James Clarke --- Changes since v2: * Fixed opening curly brace formatting, both for my new SH4-specific regpairs_aligned function, as well as the Arm one I touched, to appease checkpatch.pl Changes

Re: [Qemu-devel] [PULL 00/18] ppc-for-2.11 queue 20170915

2017-09-15 Thread Peter Maydell
> > are available in the git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.11-20170915 > > for you to fetch changes up to 70a0c19e83aa4c71c879d51e426e89e4b3d4e014: > > ppc/kvm: use kvm_vm_check_extension() in kv

Re: [Qemu-devel] [PATCH v2] linux-user/syscall.c: Handle SH4's exceptional alignment for p{read, write}64

2017-09-15 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2] linux-user/syscall.c: Handle SH4's exceptional alignment for p{read, write}64 Message-id: 20170915190748.82389-1-jrt...@jrtc27.com Type: series === TEST SCRIPT

Re: [Qemu-devel] [PATCH 7/6] qemu-iotests: Test change-backing-file command

2017-09-15 Thread Eric Blake
On 09/15/2017 12:02 PM, Kevin Wolf wrote: > This involves a temporary read-write reopen if the backing file link in > the middle of a backing file chain should be changed and is therefore a > good test for the latest bdrv_reopen() vs. op blockers fixes. > > Signed-off-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v4 2/3] backup: Adds Backup Tool

2017-09-15 Thread John Snow
On 09/08/2017 12:41 PM, Ishani Chugh wrote: > qemu-backup will be a command-line tool for performing full and > incremental disk backups on running VMs. It is intended as a > reference implementation for management stack and backup developers > to see QEMU's backup features in action. The tool

Re: [Qemu-devel] [PATCH v4 1/3] Add manpage for QEMU Backup Tool

2017-09-15 Thread John Snow
On 09/08/2017 12:41 PM, Ishani Chugh wrote: > qemu-backup will be a command-line tool for performing full and > incremental disk backups on running VMs. It is intended as a > reference implementation for management stack and backup developers > to see QEMU's backup features in action. This

[Qemu-devel] [PATCH v2] linux-user/syscall.c: Handle SH4's exceptional alignment for p{read, write}64

2017-09-15 Thread James Clarke
Fixes: https://bugs.launchpad.net/qemu/+bug/1716767 Signed-off-by: James Clarke --- Changes since v1: * Removed all changes in v1 :) * Added syscall num argument to regpairs_aligned * Added SH4-specific implementation of regpairs_aligned to return 1 for p{read,write}64

Re: [Qemu-devel] [PATCH 6/6] block: Fix permissions after bdrv_reopen()

2017-09-15 Thread Eric Blake
On 09/15/2017 05:10 AM, Kevin Wolf wrote: > If we switch between read-only and read-write, the permissions that > image format drivers need on bs->file change, too. Make sure to update > the permissions during bdrv_reopen(). > > Signed-off-by: Kevin Wolf > --- >

Re: [Qemu-devel] [PATCH 5/6] block: reopen: Queue children after their parents

2017-09-15 Thread Eric Blake
On 09/15/2017 05:10 AM, Kevin Wolf wrote: > We will calculate the required new permissions in the prepare stage of a > reopen. Required permissions of children can be influenced by the > changes made to their parents, but parents are independent from their > children. This means that permissions

Re: [Qemu-devel] [PATCH 4/6] block: Base permissions on rw state after reopen

2017-09-15 Thread Eric Blake
On 09/15/2017 05:10 AM, Kevin Wolf wrote: > When new permissions are calculated during bdrv_reopen(), they need to > be based on the state of the graph as it will be after the reopen has > completed, not on the current state of the involved nodes. > > This patch makes bdrv_is_writable()

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Handle SH4's exceptional alignment for p{read, write}64

2017-09-15 Thread Laurent Vivier
Le 15/09/2017 à 17:41, Philippe Mathieu-Daudé a écrit : > On 09/15/2017 03:58 AM, James Clarke wrote: >> Fixes: https://bugs.launchpad.net/qemu/+bug/1716767 >> Signed-off-by: James Clarke > > Congratulations! You have won yourself a R: entry (Designated reviewer) > in the

Re: [Qemu-devel] [PATCH 3/6] block: Add reopen queue to bdrv_check_perm()

2017-09-15 Thread Eric Blake
On 09/15/2017 05:10 AM, Kevin Wolf wrote: > In the context of bdrv_reopen(), we'll have to look at the state of the > graph as it will be after the reopen. This interface addition is in > preparation for the change. > > Signed-off-by: Kevin Wolf > --- > block.c | 34

Re: [Qemu-devel] [RFC 14/15] qmp: support out-of-band (oob) execution

2017-09-15 Thread Eric Blake
On 09/14/2017 09:59 PM, Peter Xu wrote: > On Thu, Sep 14, 2017 at 04:33:34PM +0100, Stefan Hajnoczi wrote: >> On Thu, Sep 14, 2017 at 03:50:35PM +0800, Peter Xu wrote: >>> diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt >>> index 61fa167..47d16bb 100644 >>> ---

Re: [Qemu-devel] [PATCH v5 08/12] char: convert the escc device to keycodemapdb

2017-09-15 Thread Programmingkid
Sorry but I saw this error when I tried your patches: OBJCui/cocoa.o CC ui/curses.o ui/input-keymap.c:17:10: fatal error: 'ui/input-keymap-qcode-to-sun.c' file not found #include "ui/input-keymap-qcode-to-sun.c" ^ 1 error generated. make: *** [ui/input-keymap.o] Error

Re: [Qemu-devel] [PATCH RFC 0/6] xen: xen-domid-restrict improvements

2017-09-15 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH RFC 0/6] xen: xen-domid-restrict improvements Message-id: 1505498999-17427-1-git-send-email-ian.jack...@eu.citrix.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH RFC 0/6] xen: xen-domid-restrict improvements

2017-09-15 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH RFC 0/6] xen: xen-domid-restrict improvements Message-id:

Re: [Qemu-devel] [PATCH] iotests: Print full path of bad output if mismatch

2017-09-15 Thread Eric Blake
On 09/15/2017 12:45 AM, Fam Zheng wrote: > So it is easier to copy paste the path. > > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/check | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check > index

[Qemu-devel] [PATCH RFC 3/6] xen: restrict: use xentoolcore_restrict_all

2017-09-15 Thread Ian Jackson
And insist that it works. Signed-off-by: Ian Jackson --- include/hw/xen/xen_common.h | 26 ++ 1 file changed, 2 insertions(+), 24 deletions(-) diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h index 86c7f26..b6cb024 100644

[Qemu-devel] [PATCH RFC 6/6] os-posix: Provide new -runasid option

2017-09-15 Thread Ian Jackson
This allows the caller to specify a uid and gid to use, even if there is no corresponding password entry. This will be useful in certain Xen configurations. Signed-off-by: Ian Jackson --- os-posix.c | 30 ++ qemu-options.hx | 12

[Qemu-devel] [PATCH RFC 5/6] xen: destroy_hvm_domain: Try xendevicemodel_shutdown

2017-09-15 Thread Ian Jackson
xc_interface_open etc. is not going to work if we have dropped privilege, but xendevicemodel_shutdown will if everything is new enough. Signed-off-by: Ian Jackson --- hw/i386/xen/xen-hvm.c | 9 + 1 file changed, 9 insertions(+) diff --git

[Qemu-devel] [PATCH RFC 1/6] xen: link against xentoolcore

2017-09-15 Thread Ian Jackson
Signed-off-by: Ian Jackson --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index fd7e3a5..c59a0c0 100755 --- a/configure +++ b/configure @@ -2072,14 +2072,14 @@ if test "$xen" != "no" ; then

[Qemu-devel] [PATCH RFC 2/6] xen: defer call to xen_restrict until running

2017-09-15 Thread Ian Jackson
Signed-off-by: Ian Jackson --- hw/i386/xen/xen-hvm.c | 8 hw/xen/xen-common.c | 10 ++ 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index d9ccd5d..7b60ec6 100644 ---

[Qemu-devel] [PATCH RFC 4/6] xen: destroy_hvm_domain: Move reason into a variable

2017-09-15 Thread Ian Jackson
We are going to want to reuse this. No functional change. Signed-off-by: Ian Jackson --- hw/i386/xen/xen-hvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index 7b60ec6..83420cd 100644 ---

[Qemu-devel] [PATCH RFC 0/6] xen: xen-domid-restrict improvements

2017-09-15 Thread Ian Jackson
I have been working on trying to get qemu, when running as a Xen device model, to _actually_ not have power equivalent to root. I think I have achieved this, with some limitations (which will be discussed in my series against xen.git, which I am about to post). However, there are changes to qemu

Re: [Qemu-devel] [PULL 00/18] target-arm queue

2017-09-15 Thread Peter Maydell
On 14 September 2017 at 18:52, Peter Maydell wrote: > ARM queue: nothing particularly exciting, but 18 patches > is enough to send out. > > thanks > -- PMM > > The following changes since commit 3dabde1128b671f36ac6cb36b97b273139964420: > > Merge remote-tracking branch

Re: [Qemu-devel] [PATCH 2/6] block: Add reopen_queue to bdrv_child_perm()

2017-09-15 Thread Eric Blake
On 09/15/2017 05:10 AM, Kevin Wolf wrote: > In the context of bdrv_reopen(), we'll have to look at the state of the > graph as it will be after the reopen. This interface addition is in > preparation for the change. > > Signed-off-by: Kevin Wolf > --- >

Re: [Qemu-devel] [PATCH 1/6] qemu-io: Reset qemuio_blk permissions before each command

2017-09-15 Thread Eric Blake
On 09/15/2017 05:10 AM, Kevin Wolf wrote: > qemu-io provides a 'reopen' command that allows switching from writable > to read-only access. We need to make sure that we don't try to keep > write permissions to a BlockBackend that becomes read-only, otherwise > things are going to fail. > >

[Qemu-devel] [PULL 1/1] trace: Immediately apply per-vCPU state changes if a vCPU is being created

2017-09-15 Thread Stefan Hajnoczi
From: Lluís Vilanova Right now, function trace_event_set_vcpu_state_dynamic() asynchronously enables events in the case a vCPU is executing TCG code. If the vCPU is being created this makes some events like "guest_cpu_enter" to not be traced. Signed-off-by: Lluís Vilanova

[Qemu-devel] [PULL 0/1] Tracing patches

2017-09-15 Thread Stefan Hajnoczi
The following changes since commit 3dabde1128b671f36ac6cb36b97b273139964420: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20170914' into staging (2017-09-14 16:33:02 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request

Re: [Qemu-devel] [RFC v2 11/32] vhub: Open userfaultfd

2017-09-15 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Thu, Aug 24, 2017 at 08:27:09PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Open a userfaultfd (on a postcopy_advise) and send it back in > > the reply to the qemu for it to monitor. > > >

Re: [Qemu-devel] [virtio-dev] Re: [RFC 0/8] virtio-crypto: add multiplexing mode support

2017-09-15 Thread Halil Pasic
On 09/14/2017 02:58 AM, Longpeng (Mike) wrote: > > > On 2017/9/14 2:14, Halil Pasic wrote: > >> >> >> On 09/11/2017 03:10 AM, Longpeng(Mike) wrote: >>> *NOTE* >>> The code realization is based on the latest virtio crypto spec: >>> [PATCH v19 0/2] virtio-crypto: virtio crypto device

Re: [Qemu-devel] [PATCH 3/3] iotests: Add "quit during block migration" case 195

2017-09-15 Thread Eric Blake
On 09/15/2017 12:44 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/195 | 97 > ++ > tests/qemu-iotests/195.out | 19 + > tests/qemu-iotests/group | 1 + > 3 files changed, 117 insertions(+) >

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Handle SH4's exceptional alignment for p{read, write}64

2017-09-15 Thread Richard Henderson
On 09/15/2017 08:41 AM, Philippe Mathieu-Daudé wrote: > On 09/15/2017 03:58 AM, James Clarke wrote: >> Fixes: https://bugs.launchpad.net/qemu/+bug/1716767 >> Signed-off-by: James Clarke > > Congratulations! You have won yourself a R: entry (Designated reviewer) in the > "Linux

Re: [Qemu-devel] [PATCH] virtio-serial: add enable_backend callback

2017-09-15 Thread Paolo Bonzini
On 07/07/2017 16:21, Pavel Butsykin wrote: > We should guarantee that RAM will not be modified while VM has a stopped > state, otherwise it can lead to negative consequences during post-copy > migration. In RUN_STATE_FINISH_MIGRATE step, it's expected that RAM on > source side will not be modified

  1   2   3   4   >