Re: [Qemu-devel] kvm_intel fails to load on Conroe CPUs running Linux 4.12

2017-09-15 Thread Paolo Bonzini
On 15/09/2017 16:43, Gerhard Wiesinger wrote: > On 27.08.2017 20:55, Paolo Bonzini wrote: >> >> >> Il 27 ago 2017 4:48 PM, "Gerhard Wiesinger" > > ha scritto: >> >> On 27.08.2017 14 :03, Paolo Bonzini wrote: >> >> >>

[Qemu-devel] [PATCH 7/6] qemu-iotests: Test change-backing-file command

2017-09-15 Thread Kevin Wolf
This involves a temporary read-write reopen if the backing file link in the middle of a backing file chain should be changed and is therefore a good test for the latest bdrv_reopen() vs. op blockers fixes. Signed-off-by: Kevin Wolf --- I actually managed to find a simple case

Re: [Qemu-devel] [PATCH v2 12/16] tcg: Remove tcg_regset_set

2017-09-15 Thread Richard Henderson
On 09/15/2017 03:21 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> Signed-off-by: Richard Henderson > > This breaks the mips cross build: > > In file included from /tmp/qemu-test/src/tcg/tcg.c:254:0: >

[Qemu-devel] [Qemu devel v9 PATCH 3/5] msf2: Add Smartfusion2 SPI controller

2017-09-15 Thread Subbaraya Sundeep
Modelled Microsemi's Smartfusion2 SPI controller. Signed-off-by: Subbaraya Sundeep Reviewed-by: Alistair Francis --- hw/ssi/Makefile.objs | 1 + hw/ssi/mss-spi.c | 404 +++

Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

2017-09-15 Thread Cornelia Huck
On Fri, 15 Sep 2017 09:27:58 +0200 Cornelia Huck wrote: > On Thu, 14 Sep 2017 18:50:29 +0200 > Halil Pasic wrote: > > > On 09/14/2017 04:26 PM, Cornelia Huck wrote: > > > There's quite some potential in this. We may want to make this a > > >

[Qemu-devel] [Qemu devel v9 PATCH 1/5] msf2: Add Smartfusion2 System timer

2017-09-15 Thread Subbaraya Sundeep
Modelled System Timer in Microsemi's Smartfusion2 Soc. Timer has two 32bit down counters and two interrupts. Signed-off-by: Subbaraya Sundeep Reviewed-by: Alistair Francis --- hw/timer/Makefile.objs | 1 + hw/timer/mss-timer.c

[Qemu-devel] [Qemu devel v9 PATCH 5/5] msf2: Add Emcraft's Smartfusion2 SOM kit

2017-09-15 Thread Subbaraya Sundeep
Emulated Emcraft's Smartfusion2 System On Module starter kit. Signed-off-by: Subbaraya Sundeep Reviewed-by: Philippe Mathieu-Daudé --- hw/arm/Makefile.objs | 2 +- hw/arm/msf2-som.c| 94 2 files

[Qemu-devel] [Qemu devel v9 PATCH 0/5] Add support for Smartfusion2 SoC

2017-09-15 Thread Subbaraya Sundeep
Hi Qemu-devel, I am trying to add Smartfusion2 SoC. SoC is from Microsemi and System on Module(SOM) board is from Emcraft systems. Smartfusion2 has hardened Microcontroller(Cortex-M3)based Sub System and FPGA fabric. At the moment only system timer, sysreg and SPI controller are modelled.

[Qemu-devel] [Qemu devel v9 PATCH 4/5] msf2: Add Smartfusion2 SoC

2017-09-15 Thread Subbaraya Sundeep
Smartfusion2 SoC has hardened Microcontroller subsystem and flash based FPGA fabric. This patch adds support for Microcontroller subsystem in the SoC. Signed-off-by: Subbaraya Sundeep Reviewed-by: Alistair Francis ---

[Qemu-devel] [Qemu devel v9 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block

2017-09-15 Thread Subbaraya Sundeep
Added Sytem register block of Smartfusion2. This block has PLL registers which are accessed by guest. Signed-off-by: Subbaraya Sundeep Reviewed-by: Alistair Francis --- hw/misc/Makefile.objs | 1 + hw/misc/msf2-sysreg.c |

Re: [Qemu-devel] [PATCH 04/10] disas: Support the Capstone disassembler library

2017-09-15 Thread Richard Henderson
On 09/14/2017 09:46 PM, Philippe Mathieu-Daudé wrote: >>   +static bool cap_disas(disassemble_info *info, uint64_t pc, size_t size) > > I'd rather use: > > ..,, target_ulong code, ... >> +{ > > uint64_t pc = (uint64_t)code; Why? > >> +    bool ret = false; > > Isn't it cleaner to have a

[Qemu-devel] [PATCH RFC v2 0/1] s390x: pci compat handling

2017-09-15 Thread Cornelia Huck
As David has identified the reason why only 2.7 and older are affected (thanks!), we can fix migration of these machines by unconditionally providing the zpci feature bit if cpu models are off. Still RFC, as I have only sniff-tested it. We still need to think about what to do with compat

[Qemu-devel] [PATCH RFC v2 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-15 Thread Cornelia Huck
d32bd032d8 ("s390x/ccw: create s390 phb conditionally") made registering the s390 pci host bridge conditional on presense of the zpci facility bit. Sadly, that breaks migration from machines that did not use the cpu model (2.7 and previous). Create the s390 phb for pre-cpu model machines as well.

Re: [Qemu-devel] [RFC 15/15] qmp: let migrate-incoming allow out-of-band

2017-09-15 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > So it can get rid of being run on main thread. > > Signed-off-by: Peter Xu > --- > qapi/migration.json | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/qapi/migration.json b/qapi/migration.json > index

Re: [Qemu-devel] [PATCH] target/arm: Remove out of date ARM ARM section references in A64 decoder

2017-09-15 Thread Alex Bennée
Peter Maydell writes: > In the A64 decoder, we have a lot of references to section numbers > from version A.a of the v8A ARM ARM (DDI0487). This version of the > document is now long obsolete (we are currently on revision B.a), > and various intervening versions

Re: [Qemu-devel] [PATCH REPOST v19 1/2] virtio-crypto: Add virtio crypto device specification

2017-09-15 Thread Halil Pasic
On 09/11/2017 03:12 AM, Longpeng(Mike) wrote: > From: Gonglei > > The virtio crypto device is a virtual crypto device (ie. hardware > crypto accelerator card). Currently, the virtio crypto device provides > the following crypto services: CIPHER, MAC, HASH, and AEAD. >

Re: [Qemu-devel] [RFC 14/15] qmp: support out-of-band (oob) execution

2017-09-15 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Having "allow-oob" to true for a command does not mean that this command > will always be run in out-of-band mode. The out-of-band quick path will > only be executed if we specify the extra "run-oob" flag when sending the > QMP request: > > { "execute":

Re: [Qemu-devel] [RFC PATCH for-2.11 v3 15/16] travis/osx: build using more Xcode versions

2017-09-15 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > currently default builder is based on Xcode 7.3.1: > OS X 10.11 (darwin14.5.0) > Apple LLVM version 7.3.0 > > add the oldest available Xcode (6.4): > OS X 10.10 (darwin14.5.0) > Apple LLVM 6.1.0 (based on LLVM 3.6.0svn) > > and

Re: [Qemu-devel] [RFC PATCH for-2.11 v3 14/16] travis: allow_failures for gprof/gcov

2017-09-15 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé why? We should document the reason in the commit. > --- > .travis.yml | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/.travis.yml b/.travis.yml > index

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Handle SH4's exceptional alignment for p{read, write}64

2017-09-15 Thread John Paul Adrian Glaubitz
On 09/15/2017 05:41 PM, Philippe Mathieu-Daudé wrote: I'd rather use arch_type from "sysemu/arch_init.h":   case TARGET_NR_pwrite64:   /* SH4 doesn't align register pairs, except for p{read,write}64 */   if (arch_type == QEMU_ARCH_SH4 || regpairs_aligned(cpu_env)) {   arg4 =

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Handle SH4's exceptional alignment for p{read, write}64

2017-09-15 Thread Philippe Mathieu-Daudé
On 09/15/2017 03:58 AM, James Clarke wrote: Fixes: https://bugs.launchpad.net/qemu/+bug/1716767 Signed-off-by: James Clarke Congratulations! You have won yourself a R: entry (Designated reviewer) in the "Linux user" and "SH4" sections of MAINTAINERS! ---

Re: [Qemu-devel] [RFC v2 16/32] vhost+postcopy: Send address back to qemu

2017-09-15 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Sep 13, 2017 at 01:15:32PM +0100, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > On Tue, Sep 12, 2017 at 06:15:13PM +0100, Dr. David Alan Gilbert wrote: > > > > * Peter Xu (pet...@redhat.com) wrote: > > > > > On Thu,

Re: [Qemu-devel] [PATCH for-2.11 v3 10/16] travis: check ./configure outcome, dump config.log on failure

2017-09-15 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > also de-duplicate 'before_script' > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > .travis.yml | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH for-2.11 v3 08/16] travis: reorder matrix to speedup failure

2017-09-15 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > .travis.yml | 36 +++- > 1 file changed, 19 insertions(+), 17 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH for-2.11 v3 01/16] travis: update sudo-enabled Trusty images

2017-09-15 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > see https://blog.travis-ci.com/2017-06-19-trusty-updates-2017-Q2 > and > https://blog.travis-ci.com/2017-06-21-trusty-updates-2017-Q2-launch I guess we drop this now? Either we are working or we are not :-/ > > Signed-off-by: Philippe

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-15 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Fri, Sep 15, 2017 at 01:29:13PM +0100, Daniel P. Berrange wrote: > > On Fri, Sep 15, 2017 at 01:19:56PM +0100, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > > On Fri, Sep 15, 2017 at 01:06:44PM +0100,

Re: [Qemu-devel] [PATCH 1/3] kvm: check KVM_CAP_SYNC_MMU with kvm_vm_check_extension()

2017-09-15 Thread Greg Kurz
On Fri, 15 Sep 2017 07:32:10 +0200 Thomas Huth wrote: > On 14.09.2017 21:25, Greg Kurz wrote: > > On a server-class ppc host, this capability depends on the KVM type, > > ie, HV or PR. If both KVM are present in the kernel, we will always > > get the HV specific value, even if

[Qemu-devel] [PATCH] target/arm: Remove out of date ARM ARM section references in A64 decoder

2017-09-15 Thread Peter Maydell
In the A64 decoder, we have a lot of references to section numbers from version A.a of the v8A ARM ARM (DDI0487). This version of the document is now long obsolete (we are currently on revision B.a), and various intervening versions renumbered all the sections. The most recent B.a version of the

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Handle SH4's exceptional alignment for p{read, write}64

2017-09-15 Thread John Paul Adrian Glaubitz
On 09/15/2017 08:58 AM, James Clarke wrote: Fixes: https://bugs.launchpad.net/qemu/+bug/1716767 Signed-off-by: James Clarke --- linux-user/syscall.c | 12 1 file changed, 12 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index

[Qemu-devel] [PATCH v2 0/2] x86_iommu: Fix segfault when starting on non-PCI machines

2017-09-15 Thread Mohammed Gamal
Starting qemu with qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu leads to a segfault. The code assume PCI bus is present and tries to access the bus structure without checking. The patch series moves the error checks from vtd_realize() and amdvi_realize() to the generic

[Qemu-devel] [PATCH v2 2/2] x86_iommu: check if machine has PCI bus

2017-09-15 Thread Mohammed Gamal
Starting qemu with qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu leads to a segfault. The code assume PCI bus is present and tries to access the bus structure without checking. Since Intel VT-d and AMDVI should only work with PCI, add a check for PCI bus and return error if not

[Qemu-devel] [PATCH v2 1/2] x86_iommu: Move machine check to x86_iommu_realize()

2017-09-15 Thread Mohammed Gamal
Instead of having the same error checks in vtd_realize() and amdvi_realize(), move that over to the generic x86_iommu_realize(). Signed-off-by: Mohammed Gamal --- hw/i386/amd_iommu.c | 10 +- hw/i386/intel_iommu.c | 10 +- hw/i386/x86-iommu.c | 13

Re: [Qemu-devel] [PATCH v2 0/5] generalize parsing of cpu_model (x86/arm)

2017-09-15 Thread Igor Mammedov
On Wed, 13 Sep 2017 18:04:52 +0200 Igor Mammedov wrote: > Changelog since v1: > * fix merge conflicts with ignore_memory_transaction_failures > * fix couple merge conflicts where SoC type string where replaced by type > macro > * keep plain prefix string in:

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-15 Thread Stefan Hajnoczi
On Fri, Sep 15, 2017 at 01:29:13PM +0100, Daniel P. Berrange wrote: > On Fri, Sep 15, 2017 at 01:19:56PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > On Fri, Sep 15, 2017 at 01:06:44PM +0100, Dr. David Alan Gilbert wrote: > > > > * Daniel P.

Re: [Qemu-devel] [PATCH] 9pfs: check the size of transport buffer before marshaling

2017-09-15 Thread Greg Kurz
On Thu, 14 Sep 2017 19:31:36 +0300 Jan Dakinevich wrote: > v9fs_do_readdir_with_stat() and v9fs_do_readdir() stores as much data in > the buffer as can fit unless marshaling erorr occurs. However, after > commit 23a006d the behavior pdu_marshal was changed, and on error

Re: [Qemu-devel] [PATCH v7 12/13] tests: Add README for vm tests

2017-09-15 Thread Fam Zheng
On Fri, 09/15 15:24, Alex Bennée wrote: > > Fam Zheng writes: > > > Signed-off-by: Fam Zheng > > --- > > tests/vm/README | 63 > > + > > 1 file changed, 63 insertions(+) > > create mode 100644

Re: [Qemu-devel] [Qemu-arm] [PATCH v7 13/20] hw/arm/smmuv3: Implement IOMMU memory region replay callback

2017-09-15 Thread Auger Eric
Hi, On 15/09/2017 12:42, tn wrote: > Hi Eric, > > On 15.09.2017 09:30, Auger Eric wrote: >> Hi Tomasz, >> >> On 14/09/2017 16:43, Tomasz Nowicki wrote: >>> On 14.09.2017 16:31, Tomasz Nowicki wrote: Hi Eric, On 14.09.2017 11:27, Linu Cherian wrote: > Hi Eric, > > On

Re: [Qemu-devel] [PULL v4 00/38] Test and build patches

2017-09-15 Thread Philippe Mathieu-Daudé
Hi Daniel, On 09/15/2017 08:40 AM, Daniel P. Berrange wrote: On Fri, Sep 15, 2017 at 11:55:44AM +0100, Peter Maydell wrote: [...] So, before I commit an ssh private key to our git repo, can you explain why it's ok that this is public? The commit message for the relevant patch doesn't really

Re: [Qemu-devel] kvm_intel fails to load on Conroe CPUs running Linux 4.12

2017-09-15 Thread Gerhard Wiesinger
On 27.08.2017 20:55, Paolo Bonzini wrote: Il 27 ago 2017 4:48 PM, "Gerhard Wiesinger" > ha scritto: On 27.08.2017 14 :03, Paolo Bonzini wrote: We will revert the patch, but 4.13.0 will not have the fix.

[Qemu-devel] [Bug 1384892] Re: RTL8168 NIC VFIO not working anymore since QEMU 2.1

2017-09-15 Thread Thomas Huth
The patch that has been mentioned in the last comment has been included here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=31e6a7b17b35711eb44f0e ... and has been released with QEMU v2.8 already, so marking this as "fix released" now. ** Changed in: qemu Status: New => Fix Released --

[Qemu-devel] [PATCH v3 1/2] virtio-gpu: Handle endian conversion

2017-09-15 Thread Farhan Ali
Virtio GPU code currently only supports litte endian format, and so using the Virtio GPU device on a big endian machine does not work. Let's fix it by supporting the correct host cpu byte order. Signed-off-by: Farhan Ali --- hw/display/virtio-gpu.c | 70

Re: [Qemu-devel] [Qemu-arm] [PATCH v7 13/20] hw/arm/smmuv3: Implement IOMMU memory region replay callback

2017-09-15 Thread tn
Hi Eric, On 15.09.2017 09:30, Auger Eric wrote: Hi Tomasz, On 14/09/2017 16:43, Tomasz Nowicki wrote: On 14.09.2017 16:31, Tomasz Nowicki wrote: Hi Eric, On 14.09.2017 11:27, Linu Cherian wrote: Hi Eric, On Fri Sep 01, 2017 at 07:21:16PM +0200, Eric Auger wrote:

[Qemu-devel] [PATCH v3 2/2] virtio-gpu-ccw: Create a virtio gpu device for the ccw bus

2017-09-15 Thread Farhan Ali
Wire up the virtio-gpu device for the CCW bus. The virtio-gpu is a virtio-1 device, so disable revision 0. Signed-off-by: Farhan Ali Acked-by: Christian Borntraeger Reviewed-by: Halil Pasic Reviewed-by: Thomas Huth

[Qemu-devel] [PATCH v3 0/2] Virtio GPU for S390

2017-09-15 Thread Farhan Ali
These patches wire up the virtio-gpu device for CCW bus for S390. For the S390 architecture which does not natively support any graphics device, virtio gpu in 2D mode could be used to emulate a simple graphics card and use VNC as the display. eg: qemu-system-s390x ... -device

Re: [Qemu-devel] [PATCH REPOST v19 1/2] virtio-crypto: Add virtio crypto device specification

2017-09-15 Thread Halil Pasic
On 09/11/2017 03:12 AM, Longpeng(Mike) wrote: > From: Gonglei > > The virtio crypto device is a virtual crypto device (ie. hardware > crypto accelerator card). Currently, the virtio crypto device provides > the following crypto services: CIPHER, MAC, HASH, and AEAD. >

[Qemu-devel] [Bug 1717414] [NEW] Sending certain keysyms results in wrong symbol input

2017-09-15 Thread Iordan Iordanov
Public bug reported: I develop bVNC, an Android VNC client. I noticed that when I connect to qemu VMs that have a VNC console, Keysyms that are usually sent over with SHIFT modifier when connecting from a PC have wrong symbols typed within the VM. A very short list of examples: exclam

Re: [Qemu-devel] [PATCH] target/s390x/kvm: Fix problem when running with SELinux under z/VM

2017-09-15 Thread Thomas Huth
On 29.03.2017 16:25, Christian Borntraeger wrote: > On 03/29/2017 04:21 PM, Thomas Huth wrote: >> On 24.03.2017 10:39, Christian Borntraeger wrote: >>> On 03/24/2017 10:26 AM, Thomas Huth wrote: When running QEMU with KVM under z/VM, the memory for the guest is allocated via

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-15 Thread Daniel P. Berrange
On Fri, Sep 15, 2017 at 03:29:46PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Fri, Sep 15, 2017 at 01:19:56PM +0100, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > > On Fri, Sep 15, 2017 at 01:06:44PM

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-15 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Fri, Sep 15, 2017 at 01:19:56PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > On Fri, Sep 15, 2017 at 01:06:44PM +0100, Dr. David Alan Gilbert wrote: > > > > * Daniel P. Berrange

Re: [Qemu-devel] [PATCH v7 12/13] tests: Add README for vm tests

2017-09-15 Thread Alex Bennée
Fam Zheng writes: > Signed-off-by: Fam Zheng > --- > tests/vm/README | 63 > + > 1 file changed, 63 insertions(+) > create mode 100644 tests/vm/README > > diff --git a/tests/vm/README b/tests/vm/README

Re: [Qemu-devel] [PATCH RFC 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-15 Thread Halil Pasic
On 09/15/2017 03:37 PM, David Hildenbrand wrote: > On 15.09.2017 15:22, Cornelia Huck wrote: >> On Fri, 15 Sep 2017 15:09:02 +0200 >> David Hildenbrand wrote: >> >>> On 15.09.2017 15:07, Cornelia Huck wrote: On Fri, 15 Sep 2017 13:57:40 +0200 David Hildenbrand

Re: [Qemu-devel] [PATCH 1/2] x86_iommu: Move machine check to x86_iommu_realize()

2017-09-15 Thread Peter Xu
On Fri, Sep 15, 2017 at 09:52:23PM +0800, Peter Xu wrote: > On Fri, Sep 15, 2017 at 01:13:45PM +0200, Mohammed Gamal wrote: > > Instead of having the same error checks in vtd_realize() > > and amdvi_realize(), move that over to the generic > > x86_iommu_realize(). > > > > Signed-off-by: Mohammed

Re: [Qemu-devel] [PATCH 2/2] x86_iommu: check if machine has PCI bus

2017-09-15 Thread Peter Xu
On Fri, Sep 15, 2017 at 01:13:46PM +0200, Mohammed Gamal wrote: > Starting qemu with > qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu > leads to a segfault. The code assume PCI bus is present and > tries to access the bus structure without checking. > > Since Intel VT-d and AMDVI should

Re: [Qemu-devel] [PATCH 1/2] x86_iommu: Move machine check to x86_iommu_realize()

2017-09-15 Thread Peter Xu
On Fri, Sep 15, 2017 at 01:13:45PM +0200, Mohammed Gamal wrote: > Instead of having the same error checks in vtd_realize() > and amdvi_realize(), move that over to the generic > x86_iommu_realize(). > > Signed-off-by: Mohammed Gamal > --- > hw/i386/amd_iommu.c | 10

Re: [Qemu-devel] [PATCH v5 00/22] instrument: Add basic event instrumentation

2017-09-15 Thread Peter Maydell
On 15 September 2017 at 14:45, Lluís Vilanova wrote: > Do you have an opinion on specific trace points, or an observation in general? > > I wanted to have the following events: > > * cpu hotplug/hotunplug > * cpu reset > * memory access translation/execution > * BBL/TB

Re: [Qemu-devel] [PATCH v5 00/22] instrument: Add basic event instrumentation

2017-09-15 Thread Lluís Vilanova
Peter Maydell writes: > On 12 September 2017 at 22:01, Lluís Vilanova wrote: >> This series adds an API to add instrumentation events. >> >> It also provides additional APIs for: >> * Controlling tracing events. >> * Peek/poke guest memory. >> Future APIs (for later

Re: [Qemu-devel] [PATCH v6 01/22] instrument: Add documentation

2017-09-15 Thread Lluís Vilanova
Peter Maydell writes: > On 13 September 2017 at 10:57, Lluís Vilanova wrote: >> Signed-off-by: Lluís Vilanova >> --- >> MAINTAINERS |6 ++ >> docs/instrument.txt | 173 >> +++ >> 2 files

Re: [Qemu-devel] [PATCH RFC 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-15 Thread David Hildenbrand
On 15.09.2017 15:22, Cornelia Huck wrote: > On Fri, 15 Sep 2017 15:09:02 +0200 > David Hildenbrand wrote: > >> On 15.09.2017 15:07, Cornelia Huck wrote: >>> On Fri, 15 Sep 2017 13:57:40 +0200 >>> David Hildenbrand wrote: >>> As an alternative, simply

Re: [Qemu-devel] [PATCH v5 11/22] s390x: allow only 1 CPU with TCG

2017-09-15 Thread David Hildenbrand
On 15.09.2017 15:17, Alex Bennée wrote: > > David Hildenbrand writes: > >> On 13.09.2017 18:13, Alex Bennée wrote: >>> >>> David Hildenbrand writes: >>> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the guest tries to bring these

Re: [Qemu-devel] [Qemu-arm] [PATCH v7 13/20] hw/arm/smmuv3: Implement IOMMU memory region replay callback

2017-09-15 Thread Auger Eric
Hi Tomasz, On 15/09/2017 12:42, tn wrote: > Hi Eric, > > On 15.09.2017 09:30, Auger Eric wrote: >> Hi Tomasz, >> >> On 14/09/2017 16:43, Tomasz Nowicki wrote: >>> On 14.09.2017 16:31, Tomasz Nowicki wrote: Hi Eric, On 14.09.2017 11:27, Linu Cherian wrote: > Hi Eric, > >

Re: [Qemu-devel] [PATCH RFC 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-15 Thread Cornelia Huck
On Fri, 15 Sep 2017 15:09:02 +0200 David Hildenbrand wrote: > On 15.09.2017 15:07, Cornelia Huck wrote: > > On Fri, 15 Sep 2017 13:57:40 +0200 > > David Hildenbrand wrote: > > > >> As an alternative, simply > >> > >> diff --git a/target/s390x/cpu_models.c

Re: [Qemu-devel] [PATCH 1/4] ppc/kvm: drop kvmppc_has_cap_htab_fd()

2017-09-15 Thread Thomas Huth
On 15.09.2017 15:15, Greg Kurz wrote: > It never got used since its introduction (commit 7c43bca004af). > > Signed-off-by: Greg Kurz > --- > target/ppc/kvm.c |5 - > target/ppc/kvm_ppc.h |6 -- > 2 files changed, 11 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v5 11/22] s390x: allow only 1 CPU with TCG

2017-09-15 Thread Alex Bennée
David Hildenbrand writes: > On 13.09.2017 18:13, Alex Bennée wrote: >> >> David Hildenbrand writes: >> >>> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the >>> guest tries to bring these CPUs up but fails), because we don't support >>>

[Qemu-devel] [PATCH 4/4] ppc/kvm: generalize the use of kvmppc_get_htab_fd()

2017-09-15 Thread Greg Kurz
The use of KVM_PPC_GET_HTAB_FD is open-coded in kvmppc_read_hptes() and kvmppc_write_hpte(). This patch modifies kvmppc_get_htab_fd() so that it can be used everywhere we need to access the in-kernel htab: - add an index argument => only kvmppc_read_hptes() passes an actual index, all other

[Qemu-devel] [PATCH 2/4] spapr: introduce helpers to migrate HPT chunks and the end marker

2017-09-15 Thread Greg Kurz
This consolidates some duplicated code in a single helper. Signed-off-by: Greg Kurz --- hw/ppc/spapr.c | 38 +- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index f680f28a15ea..841117f6d185

[Qemu-devel] [PATCH 3/4] ppc/kvm: change kvmppc_get_htab_fd() to return -errno on error

2017-09-15 Thread Greg Kurz
When kvmppc_get_htab_fd() fails, its return value is propagated up to qemu_savevm_state_iterate() or to qemu_savevm_state_complete_precopy(). All savevm handlers expect to receive a negative errno on error. Let's patch kvmppc_get_htab_fd() accordingly. While here, let's change htab_load() in the

[Qemu-devel] [PATCH 0/4] ppc/kvm: htab fd code improvements

2017-09-15 Thread Greg Kurz
This series drops unused code and consolidates some duplicated code that deals with KVM's htab fd feature. It also fixes some potential bugs. -- Greg --- Greg Kurz (4): ppc/kvm: drop kvmppc_has_cap_htab_fd() spapr: introduce helpers to migrate HPT chunks and the end marker

[Qemu-devel] [PATCH 1/4] ppc/kvm: drop kvmppc_has_cap_htab_fd()

2017-09-15 Thread Greg Kurz
It never got used since its introduction (commit 7c43bca004af). Signed-off-by: Greg Kurz --- target/ppc/kvm.c |5 - target/ppc/kvm_ppc.h |6 -- 2 files changed, 11 deletions(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 1deaf106d2b9..00d7029b8d7a

Re: [Qemu-devel] [PATCH RFC 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-15 Thread David Hildenbrand
On 15.09.2017 15:07, Cornelia Huck wrote: > On Fri, 15 Sep 2017 13:57:40 +0200 > David Hildenbrand wrote: > >> As an alternative, simply >> >> diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c >> index 0f28ebd162..0f22efc3b6 100644 >> ---

Re: [Qemu-devel] [PATCH RFC 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-15 Thread Cornelia Huck
On Fri, 15 Sep 2017 13:57:40 +0200 David Hildenbrand wrote: > As an alternative, simply > > diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c > index 0f28ebd162..0f22efc3b6 100644 > --- a/target/s390x/cpu_models.c > +++ b/target/s390x/cpu_models.c > @@ -195,6

Re: [Qemu-devel] [PATCH v2 2/2] virtio-gpu-ccw: Create a virtio gpu device for the ccw bus

2017-09-15 Thread Farhan Ali
On 09/15/2017 03:40 AM, Thomas Huth wrote: On 14.09.2017 17:55, Farhan Ali wrote: Wire up the virtio-gpu device for the CCW bus. The virtio-gpu is a virtio-1 device, so disable revision 0. Signed-off-by: Farhan Ali Acked-by: Christian Borntraeger

Re: [Qemu-devel] [PATCH v2 1/2] virtio-gpu: Handle endian conversion

2017-09-15 Thread Farhan Ali
On 09/15/2017 03:31 AM, Gerd Hoffmann wrote: Hi, +static void +virtio_gpu_ctrl_hdr_bswap_cpu(struct virtio_gpu_ctrl_hdr *hdr) +{ +hdr->type = le32_to_cpu(hdr->type); +hdr->flags = le32_to_cpu(hdr->flags); +hdr->fence_id = le64_to_cpu(hdr->fence_id); +hdr->ctx_id =

Re: [Qemu-devel] [PATCH 4/7] tcg: Add support for "inlining" regions of code

2017-09-15 Thread Lluís Vilanova
Richard Henderson writes: > On 09/14/2017 08:20 AM, Lluís Vilanova wrote: >> Richard Henderson writes: >> >>> On 09/10/2017 09:27 AM, Lluís Vilanova wrote: TCG BBLs and instructions have multiple exit points from where to raise tracing events, but some of the necessary information in

Re: [Qemu-devel] [PULL v4 00/38] Test and build patches

2017-09-15 Thread Fam Zheng
On Fri, 09/15 13:31, Daniel P. Berrange wrote: > On Fri, Sep 15, 2017 at 08:21:53PM +0800, Fam Zheng wrote: > > On Fri, 09/15 12:40, Daniel P. Berrange wrote: > > > On Fri, Sep 15, 2017 at 11:55:44AM +0100, Peter Maydell wrote: > > > > On 15 September 2017 at 10:02, Fam Zheng

Re: [Qemu-devel] [PATCH 4/4] ppc: ensure we update the decrementer value during migration

2017-09-15 Thread Mark Cave-Ayland
On 14/09/17 04:52, David Gibson wrote: > On Wed, Sep 13, 2017 at 07:58:23PM +0200, Laurent Vivier wrote: >> On 13/09/2017 19:11, Mark Cave-Ayland wrote: >>> On 13/09/17 08:12, David Gibson wrote: >>> This is subtly incorrect. It sets the DECR on load to exactly the value that was

Re: [Qemu-devel] [PATCH] rbd: Detect rbd image resizes and propagate them

2017-09-15 Thread Kevin Wolf
Am 13.09.2017 um 18:44 hat Adam Wolfe Gordon geschrieben: > Register a watcher with rbd so that we get notified when an image is > resized. Propagate resizes to parent block devices so that guest devices > get resized without user intervention. > > Signed-off-by: Adam Wolfe Gordon

Re: [Qemu-devel] [PULL v4 00/38] Test and build patches

2017-09-15 Thread Daniel P. Berrange
On Fri, Sep 15, 2017 at 08:21:53PM +0800, Fam Zheng wrote: > On Fri, 09/15 12:40, Daniel P. Berrange wrote: > > On Fri, Sep 15, 2017 at 11:55:44AM +0100, Peter Maydell wrote: > > > On 15 September 2017 at 10:02, Fam Zheng wrote: > > > > The following changes since commit > > > >

Re: [Qemu-devel] [PATCH] iotests: Print full path of bad output if mismatch

2017-09-15 Thread Fam Zheng
On Fri, 09/15 14:16, Kevin Wolf wrote: > Am 15.09.2017 um 07:45 hat Fam Zheng geschrieben: > > So it is easier to copy paste the path. > > > > Signed-off-by: Fam Zheng > > I don't think I ever tried to do anything with the diff that would have > required the full path, but if

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-15 Thread Daniel P. Berrange
On Fri, Sep 15, 2017 at 01:19:56PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Fri, Sep 15, 2017 at 01:06:44PM +0100, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > > On Fri, Sep 15, 2017 at 11:49:26AM

Re: [Qemu-devel] [PULL v4 00/38] Test and build patches

2017-09-15 Thread Fam Zheng
On Fri, 09/15 12:40, Daniel P. Berrange wrote: > On Fri, Sep 15, 2017 at 11:55:44AM +0100, Peter Maydell wrote: > > On 15 September 2017 at 10:02, Fam Zheng wrote: > > > The following changes since commit > > > 04ef33052c205170c92df21ca0b4be4f3b102188: > > > > > > tcg/tci: do

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-15 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Fri, Sep 15, 2017 at 01:06:44PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > On Fri, Sep 15, 2017 at 11:49:26AM +0100, Stefan Hajnoczi wrote: > > > > On Fri, Sep 15, 2017 at 11:50:57AM +0800,

Re: [Qemu-devel] [PATCH] iotests: Print full path of bad output if mismatch

2017-09-15 Thread Kevin Wolf
Am 15.09.2017 um 07:45 hat Fam Zheng geschrieben: > So it is easier to copy paste the path. > > Signed-off-by: Fam Zheng I don't think I ever tried to do anything with the diff that would have required the full path, but if you say so... :-) Thanks, applied to the block

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-15 Thread Daniel P. Berrange
On Fri, Sep 15, 2017 at 01:06:44PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Fri, Sep 15, 2017 at 11:49:26AM +0100, Stefan Hajnoczi wrote: > > > On Fri, Sep 15, 2017 at 11:50:57AM +0800, Peter Xu wrote: > > > > On Thu, Sep 14, 2017 at

Re: [Qemu-devel] [PATCH v2 0/3] iotests: cure s390x failures by switching to ccw/aliases

2017-09-15 Thread Kevin Wolf
Am 13.09.2017 um 11:10 hat Cornelia Huck geschrieben: > Recent changes in s390x made pci support dependant on the zpci cpu > feature, which is not provided on all models (and not on by default). > This means we cannot instatiate pci devices on a standard qemu > invocation for s390x. Moreover, the

Re: [Qemu-devel] [PULL v4 00/38] Test and build patches

2017-09-15 Thread Daniel P. Berrange
On Fri, Sep 15, 2017 at 01:03:54PM +0100, Peter Maydell wrote: > On 15 September 2017 at 12:40, Daniel P. Berrange wrote: > > IIUC, the public part of the key gets exposed to the guest images via > > cloud-init metadata. During boot the guest read this metadata and add > >

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-15 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Fri, Sep 15, 2017 at 11:49:26AM +0100, Stefan Hajnoczi wrote: > > On Fri, Sep 15, 2017 at 11:50:57AM +0800, Peter Xu wrote: > > > On Thu, Sep 14, 2017 at 04:19:11PM +0100, Stefan Hajnoczi wrote: > > > > On Thu, Sep 14, 2017 at 01:15:09PM

Re: [Qemu-devel] [PULL v4 00/38] Test and build patches

2017-09-15 Thread Peter Maydell
On 15 September 2017 at 12:40, Daniel P. Berrange wrote: > IIUC, the public part of the key gets exposed to the guest images via > cloud-init metadata. During boot the guest read this metadata and add > the public key to authorized_keys. The private key is used by the test >

Re: [Qemu-devel] [PATCH RFC 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-15 Thread David Hildenbrand
On 15.09.2017 12:14, Cornelia Huck wrote: > d32bd032d8 ("s390x/ccw: create s390 phb conditionally") made > registering the s390 pci host bridge conditional on presense > of the zpci facility bit. Sadly, that breaks migration from > some old machines. > > Create the s390 phb if we need it for

Re: [Qemu-devel] [PATCH v7 05/13] tests: Add vm test lib

2017-09-15 Thread Fam Zheng
On Fri, 09/15 12:37, Alex Bennée wrote: > > Fam Zheng writes: > > > This is the common code to implement a "VM test" to > > > > 1) Download and initialize a pre-defined VM that has necessary > > dependencies to build QEMU and SSH access. > > > > 2) Archive $SRC_PATH to a

Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-15 Thread Eduardo Otubo
On Fri, Sep 15, 2017 at 12:18:11PM +0200, Paolo Bonzini wrote: > On 15/09/2017 11:06, Eduardo Otubo wrote: > > QEMU fails when used with the following command line: > > > > ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374 > > qemu-system-ppc64: hw/isa/isa-bus.c:110:

Re: [Qemu-devel] [PULL v4 00/38] Test and build patches

2017-09-15 Thread Daniel P. Berrange
On Fri, Sep 15, 2017 at 11:55:44AM +0100, Peter Maydell wrote: > On 15 September 2017 at 10:02, Fam Zheng wrote: > > The following changes since commit 04ef33052c205170c92df21ca0b4be4f3b102188: > > > > tcg/tci: do not use ldst label (never implemented) (2017-09-11 19:24:05 > >

Re: [Qemu-devel] [PATCH v7 05/13] tests: Add vm test lib

2017-09-15 Thread Alex Bennée
Fam Zheng writes: > This is the common code to implement a "VM test" to > > 1) Download and initialize a pre-defined VM that has necessary > dependencies to build QEMU and SSH access. > > 2) Archive $SRC_PATH to a .tar file. > > 3) Boot the VM, and pass the source tar

Re: [Qemu-devel] [PULL v4 00/38] Test and build patches

2017-09-15 Thread Fam Zheng
On Fri, 09/15 11:55, Peter Maydell wrote: > On 15 September 2017 at 10:02, Fam Zheng wrote: > > The following changes since commit 04ef33052c205170c92df21ca0b4be4f3b102188: > > > > tcg/tci: do not use ldst label (never implemented) (2017-09-11 19:24:05 > > +0100) > > > > are

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-15 Thread Daniel P. Berrange
On Fri, Sep 15, 2017 at 11:49:26AM +0100, Stefan Hajnoczi wrote: > On Fri, Sep 15, 2017 at 11:50:57AM +0800, Peter Xu wrote: > > On Thu, Sep 14, 2017 at 04:19:11PM +0100, Stefan Hajnoczi wrote: > > > On Thu, Sep 14, 2017 at 01:15:09PM +0200, Marc-André Lureau wrote: > > > > There should be a limit

[Qemu-devel] [PATCH 2/2] x86_iommu: check if machine has PCI bus

2017-09-15 Thread Mohammed Gamal
Starting qemu with qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu leads to a segfault. The code assume PCI bus is present and tries to access the bus structure without checking. Since Intel VT-d and AMDVI should only work with PCI, add a check for PCI bus and return error if not

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-15 Thread Marc-André Lureau
Hi On Thu, Sep 14, 2017 at 9:46 PM, Peter Xu wrote: > On Thu, Sep 14, 2017 at 07:53:15PM +0100, Dr. David Alan Gilbert wrote: >> * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: >> > Hi >> > >> > On Thu, Sep 14, 2017 at 9:50 AM, Peter Xu wrote: >> >

[Qemu-devel] [PATCH 0/2] x86_iommu: Fix segfault when starting on non-PCI machines

2017-09-15 Thread Mohammed Gamal
Starting qemu with qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu leads to a segfault. The code assume PCI bus is present and tries to access the bus structure without checking. The patch series moves the error checks from vtd_realize() and amdvi_realize() to the generic

[Qemu-devel] [PATCH 1/2] x86_iommu: Move machine check to x86_iommu_realize()

2017-09-15 Thread Mohammed Gamal
Instead of having the same error checks in vtd_realize() and amdvi_realize(), move that over to the generic x86_iommu_realize(). Signed-off-by: Mohammed Gamal --- hw/i386/amd_iommu.c | 10 +- hw/i386/intel_iommu.c | 10 +- hw/i386/x86-iommu.c | 13

Re: [Qemu-devel] [PULL v4 00/38] Test and build patches

2017-09-15 Thread Peter Maydell
On 15 September 2017 at 10:02, Fam Zheng wrote: > The following changes since commit 04ef33052c205170c92df21ca0b4be4f3b102188: > > tcg/tci: do not use ldst label (never implemented) (2017-09-11 19:24:05 > +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH v7 04/13] tests: Add a test key pair

2017-09-15 Thread Alex Bennée
Fam Zheng writes: > This will be used by setup test user ssh. > > Signed-off-by: Fam Zheng Reviewed-by: Alex Bennée > --- > tests/keys/id_rsa | 27 +++ > tests/keys/id_rsa.pub | 1 + > 2 files changed,

<    1   2   3   4   >