[Qemu-devel] [Bug 1181354] Re: assert failed in scsi-bus.c line 1539 in SCSI_XFER_NONE

2017-09-23 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1181354 Title: assert fail

Re: [Qemu-devel] [PATCH] docker: add installation to build tests

2017-09-23 Thread Fam Zheng
On Fri, 09/22 17:52, Paolo Bonzini wrote: > On 22/09/2017 14:47, Fam Zheng wrote: > > On Fri, 09/22 13:42, Paolo Bonzini wrote: > >> Drop ccache on Fedora, because it fails on RHEL 7.4, it is not used > >> by any other distro and it is not particularly useful on throwaway > >> containers. > > > >

[Qemu-devel] [PATCH] remove trailing whitespace from qemu-options.hx

2017-09-23 Thread Michael Tokarev
Remove trailing whitespace in qemu-options documentation, as it causes reproducibility issues depending on the echo implementation used by the Makefile. Reported-By: Vagrant Cascadian Signed-off-by: Michael Tokarev --- qemu-options.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) d

Re: [Qemu-devel] xen/disk: don't leak stack data via response ring

2017-09-23 Thread Michael Tokarev
28.06.2017 01:04, Stefano Stabellini wrote: > Rather than constructing a local structure instance on the stack, fill > the fields directly on the shared ring, just like other (Linux) > backends do. Build on the fact that all response structure flavors are > actually identical (aside from alignment

Re: [Qemu-devel] [PULL v3 00/32] Misc patches for 2017-09-22

2017-09-23 Thread Peter Maydell
On 22 September 2017 at 20:08, Paolo Bonzini wrote: > The following changes since commit b62b7ed0fc9c58e373b8946c9bd2e193be98dae6: > > Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging > (2017-09-20 20:33:48 +0100) > > are available in the git repository at: > > git:

Re: [Qemu-devel] nbd structured reply

2017-09-23 Thread Wouter Verhelst
On Fri, Sep 22, 2017 at 05:57:07PM +0300, Vladimir Sementsov-Ogievskiy wrote: > The obvious behavior of client is to fail the whole read if it received one > error chunk. Not necessarily. If a user-space program requests to read X bytes of data, but there is an error at X-N, then the obvious way

Re: [Qemu-devel] [PATCH v9 05/20] dirty-bitmap: Avoid size query failure during truncate

2017-09-23 Thread Vladimir Sementsov-Ogievskiy
19.09.2017 23:18, Eric Blake wrote: We've previously fixed several places where we failed to account for possible errors from bdrv_nb_sectors(). Fix another one by making bdrv_dirty_bitmap_truncate() take the new size from the caller instead of querying itself; then adjust the sole caller bdrv_t

Re: [Qemu-devel] [PATCH v9 18/20] qcow2: Switch store_bitmap_data() to byte-based iteration

2017-09-23 Thread Vladimir Sementsov-Ogievskiy
19.09.2017 23:19, Eric Blake wrote: Now that we have adjusted the majority of the calls this function makes to be byte-based, it is easier to read the code if it makes passes over the image using bytes rather than sectors. iotests 165 was rather weak - on a default 64k-cluster image, where bitma

[Qemu-devel] [PATCH v3 2/3] block: rename bdrv_co_drain to bdrv_co_drain_begin

2017-09-23 Thread Manos Pitsidianakis
Reviewed-by: Stefan Hajnoczi Reviewed-by: Fam Zheng Signed-off-by: Manos Pitsidianakis --- include/block/block_int.h | 4 ++-- block/io.c| 4 ++-- block/qed.c | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/block/block_int.h b/inc

[Qemu-devel] [PATCH v3 3/3] block/throttle.c: add bdrv_co_drain_begin/end callbacks

2017-09-23 Thread Manos Pitsidianakis
Reviewed-by: Stefan Hajnoczi Reviewed-by: Fam Zheng Signed-off-by: Manos Pitsidianakis --- block/throttle.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/block/throttle.c b/block/throttle.c index 5bca76300f..833175ac77 100644 --- a/block/throttle.c +++ b/block/throttle

[Qemu-devel] [PATCH v3 0/3] add bdrv_co_drain_begin/end BlockDriver callbacks

2017-09-23 Thread Manos Pitsidianakis
This patch series renames bdrv_co_drain to bdrv_co_drain_begin and adds a new bdrv_co_drain_end callback to match bdrv_drained_begin/end and drained_begin/end of BdrvChild. This is needed because the throttle driver (block/throttle.c) needs a way to mark the end of the drain in order to toggle

[Qemu-devel] [PATCH v3 1/3] block: add bdrv_co_drain_end callback

2017-09-23 Thread Manos Pitsidianakis
BlockDriverState has a bdrv_co_drain() callback but no equivalent for the end of the drain. The throttle driver (block/throttle.c) needs a way to mark the end of the drain in order to toggle io_limits_disabled correctly, thus bdrv_co_drain_end is needed. Signed-off-by: Manos Pitsidianakis --- in

Re: [Qemu-devel] [PATCH] block/qcow2-bitmap: fix use of uninitialized pointer

2017-09-23 Thread Vladimir Sementsov-Ogievskiy
22.09.2017 17:43, Vladimir Sementsov-Ogievskiy wrote: Without initialization to zero dirty_bitmap field may be not zero for a bitmap which should not be stored and qcow2_store_persistent_dirty_bitmaps will erroneously call store_bitmap for it which leads to SYGSEGV on bdrv_dirty_bitmap_name. pl

Re: [Qemu-devel] nbd structured reply

2017-09-23 Thread Vladimir Sementsov-Ogievskiy
22.09.2017 23:36, Eric Blake wrote: On 09/22/2017 09:57 AM, Vladimir Sementsov-Ogievskiy wrote: If you have suggestions for improving the NBD spec wording, feel free to propose a doc patch. Thanks, now I understand.. However I don't have good idea of wording.. Another thing: server can send

Re: [Qemu-devel] [PATCH v11 1/6] throttle: factor out duplicate code

2017-09-23 Thread Manos Pitsidianakis
On Fri, Sep 22, 2017 at 01:31:58PM +0200, Pradeep Jagadeesh wrote: On 9/18/2017 6:20 PM, Manos Pitsidianakis wrote: On Thu, Sep 14, 2017 at 06:40:05AM -0400, Pradeep Jagadeesh wrote: This patch factors out the duplicate throttle code that was still present in block and fsdev devices. Signed-of

Re: [Qemu-devel] [PATCH] pci: allow 32-bit PCI IO accesses to pass through the PCI bridge

2017-09-23 Thread Mark Cave-Ayland
On 22/09/17 23:18, Laszlo Ersek wrote: > On 09/22/17 14:18, Mark Cave-Ayland wrote: >> Whilst the underlying PCI bridge implementation supports 32-bit PCI IO >> accesses, unfortunately they are truncated at the legacy 64K limit. >> >> Signed-off-by: Mark Cave-Ayland >> --- >> hw/pci/pci_bridge.c