Re: [Qemu-devel] Make 9pfs buildable for Windows

2017-10-15 Thread Michael Fritscher
>> I see one thing: symlinks somewhere in the path (which seemed to be the >> reason introducing the *at family). But I think that this can be handled >> by canonlizing the path, too. realpath should do the job quite well. >> > > Unfortunately now because we have TOCTOU condition here: some path

[Qemu-devel] [PATCH qemu v3] RFC: ppc/spapr: Receive and store device tree blob from SLOF

2017-10-15 Thread Alexey Kardashevskiy
SLOF receives a device tree and updates it with various properties before switching to the guest kernel and QEMU is not aware of any changes made by SLOF. Since there is no real RTAS and QEMU implements it, it makes sense to pass the SLOF device tree to QEMU so the latter could implement RTAS

Re: [Qemu-devel] [PATCH v2 1/6] aspeed: add support for the witherspoon-bmc board

2017-10-15 Thread Andrew Jeffery
On Wed, 2017-10-11 at 09:28 +0200, Cédric Le Goater wrote: > On 10/11/2017 05:49 AM, Andrew Jeffery wrote: > > On Tue, 2017-10-10 at 15:30 +0200, Cédric Le Goater wrote: > > > On 10/09/2017 02:04 AM, Andrew Jeffery wrote: > > > > On Wed, 2017-09-20 at 09:01 +0200, Cédric Le Goater wrote: > > > > >

[Qemu-devel] [Bug 1723731] Re: Qemu turns to black screen while starting to copy installation files of Windows 7

2017-10-15 Thread Alexander Kuzmin
** Description changed: Distribution: Arch Linux, Kernel: linux-4.13.5, Qemu: 2.10.1, OVMF: git (built 06.10.17). Steps to reproduce: create Qemu VM with such config: QEMU_VM_NAME=$(basename $(dirname "$0")) #Qemu virtual machine name (taken from working directory)

Re: [Qemu-devel] [PATCH] spapr_cpu_core: instantiate CPUs separately

2017-10-15 Thread Greg Kurz
On Sat, 14 Oct 2017 20:33:37 +1100 David Gibson wrote: > On Fri, Oct 13, 2017 at 01:31:44PM +0200, Greg Kurz wrote: > > The current code assumes that only the CPU core object holds a > > reference on each individual CPU object, and happily frees their > > allocated

Re: [Qemu-devel] Make 9pfs buildable for Windows

2017-10-15 Thread Michael Fritscher
On 15.10.2017 21:50, Greg Kurz wrote: >> Hi again, >> >> I see one thing: symlinks somewhere in the path (which seemed to be the >> reason introducing the *at family). But I think that this can be handled >> by canonlizing the path, too. realpath should do the job quite well. >> > >

Re: [Qemu-devel] Make 9pfs buildable for Windows

2017-10-15 Thread Greg Kurz
On Sun, 15 Oct 2017 21:13:34 +0200 "Michael Fritscher" wrote: > > > > Hi, > > > > dumb question: what is the advantage of openat vs. open - only the thing > > that someone doesn't need to build the path together by hand? > > > > If I understand the man page of openat

Re: [Qemu-devel] Make 9pfs buildable for Windows

2017-10-15 Thread Greg Kurz
On Sun, 15 Oct 2017 21:02:56 +0200 "Michael Fritscher" wrote: > > On 29/09/2017 16:14, Michael Fritscher wrote: > >>> Yes, that's pretty much the only way to do it; it's not the easiest > >>> thing because you have to use NT kernel APIs (NtCreateFile) rather than > >>>

Re: [Qemu-devel] Make 9pfs buildable for Windows

2017-10-15 Thread Michael Fritscher
> > Hi, > > dumb question: what is the advantage of openat vs. open - only the thing > that someone doesn't need to build the path together by hand? > > If I understand the man page of openat correctly, it does _not_ prevent > someone to break out of the jail by using e.g. ../../../blah . > If

Re: [Qemu-devel] Make 9pfs buildable for Windows

2017-10-15 Thread Michael Fritscher
> On 29/09/2017 16:14, Michael Fritscher wrote: >>> Yes, that's pretty much the only way to do it; it's not the easiest >>> thing because you have to use NT kernel APIs (NtCreateFile) rather than >>> e.g. CreateFile. Likewise for NtQueryAttributesFile, >>> NtQueryDirectoryObject, etc.

Re: [Qemu-devel] Reading and writing functions for QEMU emulated peripherals

2017-10-15 Thread Ramy Sameh
Many thanks Peter On Sun, Oct 15, 2017 at 6:50 PM, Peter Maydell wrote: > On 15 October 2017 at 17:47, Ramy Sameh wrote: > > I was tracking the calling of function pl011_read, and I noticed that it > is > > called from function

[Qemu-devel] [PATCH v4 1/2] audio/paaudio: remove separate PA feeder threads

2017-10-15 Thread Martin Schrodt
Reduce latency when playing back via Pulse Audio, by removing the separate threads that feed PA. These are not needed, since feeding can be done in a non blocking way directly from the audio timer. This also exposes several new configuration settings that make it easier for the user to tune the

[Qemu-devel] [PATCH v4 2/2] audio/hda: create millisecond timers that handle IO

2017-10-15 Thread Martin Schrodt
Currently, the HDA device tries to sync itself with the QEMU audio backend by waiting for the guest driver to handle buffer completion interrupts. This causes the backend to often read too much data from the device, as well as running out of data whenever the guest takes too long to handle the

[Qemu-devel] [PATCH v4 0/2] Improve audio output quality

2017-10-15 Thread Martin Schrodt
Motivation for this: After being annoyed for too long with the crackling QEMU produces, I decided to dive in and try to fix this. This has already been tested by several people, please see the corresponding Reddit-thread:

Re: [Qemu-devel] [RFC PATCH 14/30] softfloat: 16 bit helpers for shr, clz and rounding and packing

2017-10-15 Thread Richard Henderson
On 10/13/2017 09:24 AM, Alex Bennée wrote: > Half-precision helpers for float16 maths. I didn't bother hand-coding > the count leading zeros as we could always fall-back to host-utils if > we needed to. > > Signed-off-by: Alex Bennée > --- > fpu/softfloat-macros.h | 39

Re: [Qemu-devel] [PATCH v2] oslib-posix: Fix compiler warning and some data types

2017-10-15 Thread Stefan Weil
Am 15.10.2017 um 19:46 schrieb Stefan Weil: > Am 15.10.2017 um 17:32 schrieb Paolo Bonzini: >> On 14/10/2017 18:53, Philippe Mathieu-Daudé wrote: @@ -328,7 +328,7 @@ static void *do_touch_pages(void *arg) * don't need to write at all so we don't cause *

Re: [Qemu-devel] [PATCH v2] oslib-posix: Fix compiler warning and some data types

2017-10-15 Thread Stefan Weil
Am 15.10.2017 um 17:32 schrieb Paolo Bonzini: > On 14/10/2017 18:53, Philippe Mathieu-Daudé wrote: >>> @@ -328,7 +328,7 @@ static void *do_touch_pages(void *arg) >>> * don't need to write at all so we don't cause >>> * wear on the storage backing the region... >>>

Re: [Qemu-devel] [PATCH v3 0/2] Improve audio output quality

2017-10-15 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20171015165858.19937-1-mar...@schrodt.org Subject: [Qemu-devel] [PATCH v3 0/2] Improve audio output quality === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

[Qemu-devel] [PATCH v3 2/2] audio/hda: create millisecond timers that handle IO

2017-10-15 Thread Martin Schrodt
Currently, the HDA device tries to sync itself with the QEMU audio backend by waiting for the guest driver to handle buffer completion interrupts. This causes the backend to often read too much data from the device, as well as running out of data whenever the guest takes too long to handle the

[Qemu-devel] [PATCH v3 0/2] Improve audio output quality

2017-10-15 Thread Martin Schrodt
v3 because I committed some whitespace only changes in v2. Sorry. Motivation for this: After being annoyed for too long with the crackling QEMU produces, I decided to dive in and try to fix this. This has already been tested by several people, please see the corresponding Reddit-thread:

[Qemu-devel] [PATCH v3 1/2] audio/paaudio: remove separate PA feeder threads

2017-10-15 Thread Martin Schrodt
Reduce latency when playing back via Pulse Audio, by removing the separate threads that feed PA. These are not needed, since feeding can be done in a non blocking way directly from the audio timer. This also exposes several new configuration settings that make it easier for the user to tune the

Re: [Qemu-devel] [RFC PATCH 10/30] softfloat: improve comments on ARM NaN propagation

2017-10-15 Thread Peter Maydell
On 13 October 2017 at 17:24, Alex Bennée wrote: > Mention the pseudo-code fragment from which this is based and correct > the spelling of signalling. We are following the IEEE spec here, which spells it "signaling" with one 'l', being American. (The ARM ARM also uses the

Re: [Qemu-devel] Reading and writing functions for QEMU emulated peripherals

2017-10-15 Thread Peter Maydell
On 15 October 2017 at 17:47, Ramy Sameh wrote: > I was tracking the calling of function pl011_read, and I noticed that it is > called from function *memory_region_read_accessor *in memory.c > > I also noticed that all peripherals reading functions (e.g. pl050_read, >

Re: [Qemu-devel] [PATCH v3] tpm: Use EMSGSIZE instead of EBADMSG to compile on OpenBSD

2017-10-15 Thread Peter Maydell
On 13 October 2017 at 17:36, Stefan Berger wrote: > This is NOT test code. It's determining whether the external TPM is a TPM > 1.2 or TPM 2 emulation. This avoids having to start QEMU with a '--tpm2' > parmeter equivalent as well as the external emulator. Passing this

Re: [Qemu-devel] [PATCH v6 01/22] instrument: Add documentation

2017-10-15 Thread Peter Maydell
On 15 October 2017 at 17:30, Lluís Vilanova wrote: > Thinking about it, shouldn't this always be the same given QEMU's TLB/page > table > consistency assurances? What TLB/page table consistency assurances? For ARM at least we will only update (ie flush) the TLB when the

[Qemu-devel] Reading and writing functions for QEMU emulated peripherals

2017-10-15 Thread Ramy Sameh
Hello all, I was tracking the calling of function pl011_read, and I noticed that it is called from function *memory_region_read_accessor *in memory.c I also noticed that all peripherals reading functions (e.g. pl050_read, pl190_read ... etc) in the emulated VersatilePB board, are called from the

Re: [Qemu-devel] [PATCH v6 01/22] instrument: Add documentation

2017-10-15 Thread Lluís Vilanova
Emilio G Cota writes: > On Fri, Oct 06, 2017 at 18:07:16 +0300, Lluís Vilanova wrote: >> Emilio G Cota writes: >> > On Thu, Oct 05, 2017 at 02:28:12 +0300, Lluís Vilanova wrote: >> >> The API takes care of telling you if the access could be performed >> >> successfully. If you access the

[Qemu-devel] [PATCH v2 1/2] audio/paaudio: remove separate PA feeder threads

2017-10-15 Thread Martin Schrodt
Reduce latency when playing back via Pulse Audio, by removing the separate threads that feed PA. These are not needed, since feeding can be done in a non blocking way directly from the audio timer. This also exposes several new configuration settings that make it easier for the user to tune the

[Qemu-devel] [PATCH v2 0/2] Improve audio output quality

2017-10-15 Thread Martin Schrodt
After being annoyed for too long with the crackling QEMU produces, I decided to dive in and try to fix this. This has already been tested by several people, please see the corresponding Reddit-thread: https://www.reddit.com/r/VFIO/comments/74vokw/improved_pulse_audio_driver_for_qemu/ I

[Qemu-devel] [PATCH v2 2/2] audio/hda: create millisecond timers that handle IO

2017-10-15 Thread Martin Schrodt
Currently, the HDA device tries to sync itself with the QEMU audio backend by waiting for the guest driver to handle buffer completion interrupts. This causes the backend to often read too much data from the device, as well as running out of data whenever the guest takes too long to handle the

Re: [Qemu-devel] [RFC PATCH 12/30] target/arm/translate-a64.c: handle_3same_64 comment fix

2017-10-15 Thread Richard Henderson
On 10/13/2017 09:24 AM, Alex Bennée wrote: > We do implement all the opcodes. > > Signed-off-by: Alex Bennée > --- > target/arm/translate-a64.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [RFC PATCH 10/30] softfloat: improve comments on ARM NaN propagation

2017-10-15 Thread Richard Henderson
On 10/13/2017 09:24 AM, Alex Bennée wrote: > Mention the pseudo-code fragment from which this is based and correct > the spelling of signalling. > > Signed-off-by: Alex Bennée > --- > fpu/softfloat-specialize.h | 10 +- > 1 file changed, 5 insertions(+), 5

Re: [Qemu-devel] [RFC PATCH 09/30] softfloat: propagate signalling NaNs in MINMAX

2017-10-15 Thread Richard Henderson
On 10/13/2017 09:24 AM, Alex Bennée wrote: > -if (float ## s ## _is_quiet_nan(a, status) && \ > +if (float ## s ## _is_signaling_nan(a, status) || \ > +float ## s ## _is_signaling_nan(b, status)) { \ > +

Re: [Qemu-devel] QEMU without X11 support

2017-10-15 Thread Paolo Bonzini
On 15/10/2017 16:01, Michal Suchánek wrote: >>> ./configure --disable-gtk --disable-sdl --disable-opengl >> You can also use the runtime -display options (assuming >> your development environment has the libraries >> and your runtime environment has them installed, there's >> no harm in having a

Re: [Qemu-devel] [PATCH v2] oslib-posix: Fix compiler warning and some data types

2017-10-15 Thread Paolo Bonzini
On 14/10/2017 18:53, Philippe Mathieu-Daudé wrote: >> @@ -328,7 +328,7 @@ static void *do_touch_pages(void *arg) >> * don't need to write at all so we don't cause >> * wear on the storage backing the region... >> */ >> -*(volatile char *)addr =

Re: [Qemu-devel] QEMU without X11 support

2017-10-15 Thread Michal Suchánek
On Fri, 13 Oct 2017 17:08:49 +0100 Peter Maydell wrote: > On 13 October 2017 at 08:00, Gerd Hoffmann wrote: > > On Thu, 2017-10-12 at 16:25 -0400, hanji unit wrote: > >> Hello, is it possible to run (or rebuild modifying build flags) > >> QEMU

Re: [Qemu-devel] ivshmem Windows Driver

2017-10-15 Thread Geoffrey McRae via Qemu-devel
On 2017-10-15 23:24, Yan Vugenfirer wrote: On 15 Oct 2017, at 15:21, ge...@hostfission.com wrote: Hi Yan, Thank you for the information. I am rather new to Windows Driver development and learning as I go, so this may take some time, but since the driver only needs to perform very basic

Re: [Qemu-devel] ivshmem Windows Driver

2017-10-15 Thread Yan Vugenfirer
> On 15 Oct 2017, at 15:21, ge...@hostfission.com wrote: > > Hi Yan, > > Thank you for the information. I am rather new to Windows Driver development > and learning as I go, so this may take some time, but since the driver only > needs to perform very basic functions I do not see this as

Re: [Qemu-devel] ivshmem Windows Driver

2017-10-15 Thread Geoffrey McRae via Qemu-devel
Hi Yan, Thank you for the information. I am rather new to Windows Driver development and learning as I go, so this may take some time, but since the driver only needs to perform very basic functions I do not see this as being too much of a challenge. -Geoff On 2017-10-15 22:14, Yan

[Qemu-devel] [Bug 1723731] [NEW] Qemu turns to black screen while starting to copy installation files of Windows 7

2017-10-15 Thread Alexander Kuzmin
Public bug reported: Distribution: Arch Linux, Kernel: linux-4.13.5, Qemu: 2.10.1, OVMF: git (built 06.10.17). Steps to reproduce: create Qemu VM with such config: QEMU_VM_NAME=$(basename $(dirname "$0")) #Qemu virtual machine name (taken from working directory) QEMU_WORKING_DIR="$(dirname

Re: [Qemu-devel] [Qemu-ppc] How to debug crash in TCG code?

2017-10-15 Thread BALATON Zoltan
On Sun, 8 Oct 2017, BALATON Zoltan wrote: I'm still trying to debug a crash that I don't understand why is happening and how to debug it further. Any hints are apreciated. I've described the problem previously in http://lists.nongnu.org/archive/html/qemu-ppc/2017-08/msg00249.html but I've dug

Re: [Qemu-devel] ivshmem Windows Driver

2017-10-15 Thread Yan Vugenfirer
He Geoff, The official virtio-win drivers upstream repository is here: https://github.com/virtio-win/kvm-guest-drivers-windows 1. There is no ivshmem Windows Driver for now as far as I know 2. We are signing the drivers for community usage https://fedoraproject.org/wiki/Windows_Virtio_Drivers

[Qemu-devel] ivshmem Windows Driver

2017-10-15 Thread geoff--- via Qemu-devel
Hi All, I am writing some code that needs to share a block of ram between a Windows guest and Linux host. For this I am using the ivshmem device and I have written a very primitive driver for windows that allows a single application to request to memory map the pci bar (shared memory) into

[Qemu-devel] [PATCH] sun4u: fix assert when adding NICs which aren't the in-built model

2017-10-15 Thread Mark Cave-Ayland
Commit 8d93297 introduced a bug whereby non-inbuilt NICs are realized before setting the default MAC address causing an assert. Switch NIC creation over from pci_create_simple() to pci_create() which works exactly the same except omitting the realize as originally intended. Signed-off-by: Mark

Re: [Qemu-devel] [PATCH qemu v2 REPOST] pci: Initialize pci_dev->name before use

2017-10-15 Thread Peter Xu
On Sun, Oct 15, 2017 at 03:24:52PM +1100, Alexey Kardashevskiy wrote: > This moves pci_dev->name initialization earlier so > pci_dev->bus_master_as could get a name instead of an empty string. Or use "name" instead of "pci_dev->name" when do address_space_init()? But I think this one works too.

Re: [Qemu-devel] [PATCHv3 00/13] sun4m: sparc32_dma tidy-ups

2017-10-15 Thread Mark Cave-Ayland
On 14/10/17 20:23, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 1508006342-5304-1-git-send-email-mark.cave-ayl...@ilande.co.uk > Subject: [Qemu-devel] [PATCHv3 00/13] sun4m: