Re: [Qemu-devel] [PULL 00/51] tcg queued patches

2017-10-26 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/51] tcg queued patches Type: series Message-id: 20171025093535.10175-1-richard.hender...@linaro.org === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-10-26 Thread ChristianEhrhardt
Thanks for the FYI Brian. I see it in pending-SRUs as it should be. I added the -needed tags to be "correct". @Andrew/Sean - could you test proposed and set verified then (assuming it works like the ppa did) Odd - this really seems to hit everything, not only LP timeouts. There are also dep8 reg

[Qemu-devel] [PATCH v4 12/13] xilinx_spips: Add support for the ZynqMP Generic QSPI

2017-10-26 Thread Francisco Iglesias
From: Francisco Iglesias Add support for the Zynq Ultrascale MPSoc Generic QSPI. Signed-off-by: Francisco Iglesias --- default-configs/arm-softmmu.mak | 1 + hw/ssi/xilinx_spips.c | 449 +++- include/hw/ssi/xilinx_spips.h | 29 ++- 3 files cha

[Qemu-devel] [PATCH v4 13/13] xlnx-zcu102: Add support for the ZynqMP QSPI

2017-10-26 Thread Francisco Iglesias
Add support for the ZynqMP QSPI (consisting of the Generic QSPI and Legacy QSPI) and connect Numonyx n25q512a11 flashes to it. Signed-off-by: Francisco Iglesias --- hw/arm/xlnx-zcu102.c | 23 +++ hw/arm/xlnx-zynqmp.c | 24 include/hw/a

[Qemu-devel] [PATCH v4 11/13] xilinx_spips: Don't set TX FIFO UNDERFLOW at cmd done

2017-10-26 Thread Francisco Iglesias
Don't set TX FIFO UNDERFLOW interrupt after done transmiting the commands. Also update interrupts after reading out the interrupt status. Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/

[Qemu-devel] [PATCH v4 10/13] xilinx_spips: Add support for 4 byte addresses in the LQSPI

2017-10-26 Thread Francisco Iglesias
Add support for 4 byte addresses in the LQSPI and correct LQSPI_CFG_SEP_BUS. Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index 3a98799..7f0f317 100644 --- a/hw/s

[Qemu-devel] [PATCH v4 08/13] xilinx_spips: Make tx/rx_data_bytes more generic and reusable

2017-10-26 Thread Francisco Iglesias
Make tx/rx_data_bytes more generic so they can be reused (when adding support for the Zynqmp Generic QSPI). Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 64 +-- 1 file changed, 37 insertions(+), 27 deletions(-) diff --git a/hw/ssi

[Qemu-devel] [PATCH v4 06/13] xilinx_spips: Update striping to be big-endian bit order

2017-10-26 Thread Francisco Iglesias
Update striping functionality to be big-endian bit order and output even bits into flash memory connected to the lower QSPI bus and odd bits into the flash memory connected to the upper QSPI bus. Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 19 ++- 1 file changed

[Qemu-devel] [PATCH v4 09/13] xilinx_spips: Add support for zero pumping

2017-10-26 Thread Francisco Iglesias
Add support for zero pumping according to the transfer size register. Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 47 --- include/hw/ssi/xilinx_spips.h | 2 ++ 2 files changed, 42 insertions(+), 7 deletions(-) diff --git a/hw/ss

[Qemu-devel] [PATCH v4 05/13] xilinx_spips: Move FlashCMD, XilinxQSPIPS and XilinxSPIPSClass

2017-10-26 Thread Francisco Iglesias
Move the FlashCMD enum, XilinxQSPIPS and XilinxSPIPSClass structures to the header for consistency. Also move out a define and remove two dubbel included headers (while touching the code). Finally, add 4 byte address commands to the FlashCMD enum. Signed-off-by: Francisco Iglesias --- hw/ssi/xil

[Qemu-devel] [PATCH v4 02/13] m25p80: Add support for SST READ ID 0x90/0xAB commands

2017-10-26 Thread Francisco Iglesias
Add support for SST READ ID 0x90/0xAB commands for reading out the flash manufacuter ID and device ID. Signed-off-by: Francisco Iglesias --- hw/block/m25p80.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 2971519..7a5c137

[Qemu-devel] [PATCH v4 07/13] xilinx_spips: Add support for RX discard and RX drain

2017-10-26 Thread Francisco Iglesias
Add support for the RX discard and RX drain functionality. Also transmit one byte per dummy cycle (to the flash memories) with commands that require these. Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 167 +- include/hw/ssi/xilinx_

[Qemu-devel] [PATCH v4 01/13] m25p80: Add support for continuous read out of RDSR and READ_FSR

2017-10-26 Thread Francisco Iglesias
Add support for continuous read out of the RDSR and READ_FSR status registers until the chip select is deasserted. This feature is supported by amongst others 1 or more flashtypes manufactured by Numonyx (Micron), Windbond, SST, Gigadevice, Eon and Macronix. Signed-off-by: Francisco Iglesias Acke

[Qemu-devel] [PATCH v4 00/13] Add support for the ZynqMP Generic QSPI

2017-10-26 Thread Francisco Iglesias
Hi, This patch series is an attempt to add support for the ZynqMP QSPI (consisting of the Generic QSPI and the legacy QSPI) to the xlnx-zcu102 board and connect Numonyx n25q512a11 flashes to the QSPI. Also some functionality is added to m25p80. The series starts by adding support in m25p80 for c

[Qemu-devel] [PATCH v4 04/13] m25p80: Add support for n25q512a11 and n25q512a13

2017-10-26 Thread Francisco Iglesias
Add support for Micron (Numonyx) n25q512a11 and n25q512a13 flashes. Signed-off-by: Francisco Iglesias Acked-by: Marcin Krzemiński --- hw/block/m25p80.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index cf39e36..054dc6f 100644 --- a/hw/block/m25p80

[Qemu-devel] [PATCH v4 03/13] m25p80: Add support for BRRD/BRWR and BULK_ERASE (0x60)

2017-10-26 Thread Francisco Iglesias
Add support for the bank address register access commands (BRRD/BRWR) and the BULK_ERASE (0x60) command. Signed-off-by: Francisco Iglesias --- hw/block/m25p80.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 7a5c137..cf39e36 100644 --- a/hw

Re: [Qemu-devel] [PATCH] build: allow automatic git submodule updates to be disabled

2017-10-26 Thread Alexey Kardashevskiy
On 27/10/17 00:04, Daniel P. Berrange wrote: > Some people building QEMU use VPATH builds where the source directory is on a > read-only volume. In such a case 'scripts/git-submodules.sh update' will > always > fail and users are required to run it manually themselves on their original > writable

Re: [Qemu-devel] [PATCH 1/2] tcg: Allow constant pool entries in the prologue

2017-10-26 Thread Laurent Desnogues
Hello, On Thu, Oct 26, 2017 at 5:27 PM, Richard Henderson wrote: > Both ARMv6 and AArch64 currently may drop complex guest_base values > into the constant pool. But generic code wasn't expecting that, and > the pool is not emitted. Correct that. > > Reported-by: Laurent Desnogues > Signed-off-

[Qemu-devel] [Bug 905095] Re: qemu-img can't convert vmdk file: Operation not permitted

2017-10-26 Thread Bug Watch Updater
Launchpad has imported 15 comments from the remote bug at https://bugzilla.redhat.com/show_bug.cgi?id=548723. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://hel

Re: [Qemu-devel] [PATCH] build: allow automatic git submodule updates to be disabled

2017-10-26 Thread Alexey Kardashevskiy
On 27/10/17 00:33, Philippe Mathieu-Daudé wrote: > On 10/26/2017 10:04 AM, Daniel P. Berrange wrote: >> Some people building QEMU use VPATH builds where the source directory is on a >> read-only volume. In such a case 'scripts/git-submodules.sh update' will >> always >> fail and users are required

Re: [Qemu-devel] [PATCH] build: don't create temporary files in source dir

2017-10-26 Thread Alexey Kardashevskiy
On 27/10/17 00:06, Daniel P. Berrange wrote: > There are cases where users do VPATH builds with the source directory being on > a read-only volume. In such a case they have to manually run the command > 'git-submodule.sh ...modules...' manually ahead of time. When checking for > status we should n

Re: [Qemu-devel] [PATCH v2 05/10] tests: check that migration parameters are really assigned

2017-10-26 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > --- > tests/migration-test.c | 27 --- > 1 file changed, 24 insertions(+), 3 deletions(-) > > diff --git a/tests/migration-test.c b/tests/migration-test.c > index c429a13403..be598d3257 100644 >

Re: [Qemu-devel] Qemu start VM in huge page without '-mem-prealloc' will get memory leak?

2017-10-26 Thread Sam
After restart ovs-dpdk(which is openvswitch with dpdk lib), memory is released. But problem is in product environment, I could not restart ovs-dpdk.. So I think I'd better wait for 10 second to avoid this bug, or use '-mem-prealloc' to start vm. The reason I want to remove '-mem-prealloc' is

[Qemu-devel] [PATCH v5] NUMA: Enable adding NUMA node implicitly

2017-10-26 Thread Dou Liyang
Linux and Windows need ACPI SRAT table to make memory hotplug work properly, however currently QEMU doesn't create SRAT table if numa options aren't present on CLI. Which breaks both linux and windows guests in certain conditions: * Windows: won't enable memory hotplug without SRAT table at all

Re: [Qemu-devel] [PATCH v4] NUMA: Enable adding NUMA node implicitly

2017-10-26 Thread Dou Liyang
Deer Eduardo, At 10/26/2017 04:02 PM, Eduardo Habkost wrote: Hi, Sorry for taking so long to review it: Not matter. It's my honor! On Mon, Oct 23, 2017 at 09:33:42AM +0800, Dou Liyang wrote: [...] + */ +if (ram_slots > 0 && QTAILQ_EMPTY(&numa_opts->head)) { +if (mc->aut

Re: [Qemu-devel] [PATCH v6]arm: Makefiles to kinetis k64 platform

2017-10-26 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Subject: [Qemu-devel] [PATCH v6]arm: Makefiles to kinetis k64 platform Type: series Message-id: 1509014053-28134-7-git-send-email-co...@advantech.ca === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invo

[Qemu-devel] [PATCH 1/2] e1000e: Infrastructure for e1000-ng

2017-10-26 Thread Ed Swierk via Qemu-devel
Generalize e1000e to support e1000 and other devices with a similar register spec: - plain PCI instead of PCIe, skipping setup of MSI-X, AER, etc. - model-specific PHY ID2, register values and access permissions - model-specific EEPROM template and read/write methods This is just infrastructure,

[Qemu-devel] [PATCH 0/2] e1000e: Reimplement e1000 as a variant of e1000e

2017-10-26 Thread Ed Swierk via Qemu-devel
>From a hardware functionality and register perspective, the Intel 8254x Gigabit Ethernet Controller[1] is roughly a subset of the Intel 82574[2], making it practical to implement e1000 device emulation as an extension of e1000e. That would be a step towards eliminating the existing e1000 implemen

[Qemu-devel] [PATCH 2/2] e1000e: Add e1000-ng devices

2017-10-26 Thread Ed Swierk via Qemu-devel
Implement e1000-compatible devices using the reworked e1000e code: - e1000-ng: Intel 82540EM - e1000-82544gc-ng: Intel 82544GC - e1000-82545em-ng: Intel 82545EM >From a guest's perspective, these should be drop-in replacements for the existing e1000 devices. Among other deficiencies, this versio

Re: [Qemu-devel] [PATCH v2 04/10] tests: Don't abuse global_qtest

2017-10-26 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > As we have two guests running, just pass always who we want to send a > message to. Once there, refactor return_or_event() into wait_command. > > Signed-off-by: Juan Quintela Hmm was there anything else anywhere that relied on global_qtest? Hopeful

Re: [Qemu-devel] [RFC v2] e1000: Faulty tx checksum offload corrupts packets

2017-10-26 Thread Ed Swierk via Qemu-devel
On Mon, Oct 23, 2017 at 8:28 PM, Jason Wang wrote: > > On 2017年10月24日 08:22, Ed Swierk wrote: > > (Another layer of icing on the cake is that QEMU ignores the > > requirement that a UDP checksum computed as zero be sent as 0x, > > since zero is a special value meaning no checksum. So ev

Re: [Qemu-devel] [PATCH v2 03/10] tests: Factorize out migrate_test_start/end

2017-10-26 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We fix global_test users left and right > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > tests/migration-test.c | 86 > -- > 1 file changed, 48 insertions(+), 38 deletio

Re: [Qemu-devel] [PATCH v2 02/10] tests: Refactor setting of parameters/capabilities

2017-10-26 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > So we can use them in future tests > > Signed-off-by: Juan Quintela > --- > tests/migration-test.c | 101 > +++-- > 1 file changed, 64 insertions(+), 37 deletions(-) > > diff --git a/tests/migration-test

Re: [Qemu-devel] [PATCH v2 01/10] tests: rename postcopy-test to migration-test

2017-10-26 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Instead of repeating the code, we are going to bo more tests on this file > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > MAINTAINERS | 1 + > tests/Makefile.include

Re: [Qemu-devel] [PATCH] x86: Skip check apic_id_limit for Xen

2017-10-26 Thread Lan Tianyu
On 2017年10月26日 22:27, Michael S. Tsirkin wrote: > On Thu, Oct 26, 2017 at 02:19:43PM +0200, Eduardo Habkost wrote: >> On Mon, Aug 21, 2017 at 10:22:15AM +0800, Lan Tianyu wrote: >>> On 2017年08月19日 00:38, Eduardo Habkost wrote: On Thu, Aug 17, 2017 at 09:37:10AM +0800, Lan Tianyu wrote: > O

Re: [Qemu-devel] Block format 'raw' does not support the option 'locking' when disable image locking with option locking=off

2017-10-26 Thread Changlimin
I tried locking=off, it supports qcow2 -drive file.filename=r 0605-share.img,format=qcow2,if=none,id=drive-virtio-disk1,cache=directsync,aio=native,file.locking=off Thank you very much. BR Chang Limin -Original Message- From: Max Reitz [mailto:mre...@redhat.com] Sent: Thursday, Octo

[Qemu-devel] [Bug 397212] Re: Scrolling artifacts on some guests

2017-10-26 Thread Bug Watch Updater
Launchpad has imported 36 comments from the remote bug at https://bugzilla.redhat.com/show_bug.cgi?id=503156. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://hel

[Qemu-devel] [PULL 1/4] qga-win: don't hang if vss hold writes timeout

2017-10-26 Thread Michael Roth
From: Chen Hanxiao When VM is in a heavy IO, if the command "guest-fsfreeze-freeze" is executed, VSS may timeout when trying to hold writes. Inside guest, Event ID 12298(VSS_ERROR_HOLD_WRITES_TIMEOUT) is logged in the Event Viewer. At that time, if we call AbortBackup, qga may hang forever. Th

[Qemu-devel] [PULL 3/4] qga: add network stats to guest-network-get-interfaces

2017-10-26 Thread Michael Roth
From: ZhiPeng Lu we can get the network interface statistics inside a virtual machine by guest-network-get-interfaces command. it is very useful for us tomonitor and analyze network traffic. Signed-off-by: ZhiPeng Lu * don't rely on sizeof(wchar[]) for wchar[] indexing * avoid camelCase variabl

[Qemu-devel] [PULL 4/4] qga-win: fix error-handling in getNameByStringSID()

2017-10-26 Thread Michael Roth
In one case we misconstrue a BOOL return as an HRESULT, and in the other case we don't check the BOOL return from LookupAccountSidW() before extracting the HRESULT from GetLastError(). Both can lead to getNameByStringSID() misreporting an error. Reported-by: Chen Hanxiao Suggested-by: Tomáš Golem

[Qemu-devel] [PULL 0/4] qemu-ga patch queue

2017-10-26 Thread Michael Roth
The following changes since commit ae49fbbcd8e4e9d8bf7131add34773f579e1aff7: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20171025' into staging (2017-10-25 16:38:57 +0100) are available in the git repository at: git://github.com/mdroth/qemu.git tags/qga-pull-2017-10-26-tag for

[Qemu-devel] [PULL 2/4] qga-win: Updating guest_set_time action

2017-10-26 Thread Michael Roth
From: Bishara AbuHattoum At the moment, Windows libraries don't provide a way to access RTC, so, a workaround is to use the Windows w32tm command to resync the time. Related bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1183874 Signed-off-by: Bishara AbuHattoum Reviewed-by: Same

Re: [Qemu-devel] [PATCH] qga-win: fall back to hardcoded user and group names if LookupAccountSidW failed

2017-10-26 Thread Michael Roth
Quoting Tomáš Golembiovský (2017-10-26 08:54:37) > On Wed, 25 Oct 2017 16:58:07 -0500 > Michael Roth wrote: > > > Quoting Tomáš Golembiovský (2017-09-29 16:31:02) > > > On Fri, 29 Sep 2017 17:11:22 +0800 > > > Chen Hanxiao wrote: > > > > > > > From: Chen Hanxiao > > > > > > > > On some of w

Re: [Qemu-devel] 答复: Re: [PATCH v7 RESEND] qga: Add support network interface statistics inguest-network-get-interfaces command

2017-10-26 Thread Michael Roth
Quoting lu.zhip...@zte.com.cn (2017-10-25 20:42:10) > > >> +if (NO_ERROR == GetIfEntry(&aMib_ifrow)) { > > > thanks, > > I found may be overflow using GetIfEntry,thus GetIfEntry2 instead of > GetIfEntry. I tried your fix-up patch at: https://patch-diff.githubusercontent.com/raw/mdroth/qe

Re: [Qemu-devel] [PATCH 0/3]

2017-10-26 Thread Michael Roth
Quoting Sameeh Jubran (2017-08-13 10:58:46) > From: Sameeh Jubran > > This series fixes qemu-ga's behaviour upon facing a missing serial/serial > driver by listening to the serial device's events. > > For more info on why this series is needed checkout the commit message > of the third patch and

Re: [Qemu-devel] [PATCH 0/6] qga: add support for re-opening channel on error

2017-10-26 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 0/6] qga: add support for re-opening channel on error Type: series Message-id: 20171026233054.21133-1-mdr...@linux.vnet.ibm.com === TEST SCRIPT BEGIN === #!/bin/bash BA

[Qemu-devel] [PATCH 2/6] qga: hang GAConfig/socket_activation off of GAState global

2017-10-26 Thread Michael Roth
For w32 services we rely on the global GAState to access resources associated with the agent within service_main(). Currently this is sufficient for starting the agent since we open the channel once prior to calling service_main(), and simply start the GMainLoop to start the agent from within servi

[Qemu-devel] [PATCH 6/6] qga-win: report specific error when failing to open channel

2017-10-26 Thread Michael Roth
Useful in general, but especially now that errors might occur more frequently with --retry-path set. Signed-off-by: Michael Roth --- qga/channel-win32.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qga/channel-win32.c b/qga/channel-win32.c index 7e6dc4d26f..335542f748 10

[Qemu-devel] [PATCH 4/6] qga: add --retry-path option for re-initializing channel on failure

2017-10-26 Thread Michael Roth
This adds an option to instruct the agent to periodically attempt re-opening the communication channel after a channel error has occurred. The main use-case for this is providing an OS-independent way of allowing the agent to survive situations like hotplug/unplug of the communication channel, or i

[Qemu-devel] [PATCH 1/6] qga: group agent init/cleanup init separate routines

2017-10-26 Thread Michael Roth
This patch better separates the init/cleanup routines out into separate functions to make make the start-up procedure a bit easier to follow. This will be useful when we eventually break out the actual start/stop of the agent's main loop into separates routines that can be called multiple times aft

[Qemu-devel] [PATCH 5/6] qga-win: install service with --retry-path set by default

2017-10-26 Thread Michael Roth
It's nicer from a management perspective that the agent can survive hotplug/unplug of the channel device, or be started prior to the installation of the channel device's driver without and still be able to resume normal function afterward. On linux there are alternatives like systemd to support thi

[Qemu-devel] [PATCH 3/6] qga: move w32 service handling out of run_agent()

2017-10-26 Thread Michael Roth
Eventually we want a w32 service to be able to restart the qga main loop from within service_main(). To allow for this we move service handling out of run_agent() such that service_main() calls run_agent() instead of the reverse. Signed-off-by: Michael Roth --- qga/main.c | 25 ++

[Qemu-devel] [PATCH 0/6] qga: add support for re-opening channel on error

2017-10-26 Thread Michael Roth
The following patches are also available at: https://github.com/mdroth/qemu/commits/qga-retry-path This series adds a --retry-path option to qemu-ga to allow the agent to periodically re-attempt opening a channel if the channel is not yet present (e.g. qemu-ga is installed before virtio-serial d

[Qemu-devel] [PULL 1/3] xen: add a global indicator for grant copy being available

2017-10-26 Thread Stefano Stabellini
From: Juergen Gross The Xen qdisk backend needs to test whether grant copy operations is available in the kernel. Unfortunately this collides with using xengnttab_set_max_grants() on some kernels as this operation has to be the first one after opening the gnttab device. In order to solve this pr

[Qemu-devel] [PULL 2/3] xen: dont try setting max grants multiple times

2017-10-26 Thread Stefano Stabellini
From: Juergen Gross Trying to call xengnttab_set_max_grants() with the same file handle might fail on some kernels, as this operation is allowed only once. This is a problem for the qdisk backend as blk_connect() can be called multiple times for a domain, e.g. in case grub-xen is being used to b

[Qemu-devel] [PULL 3/3] xen: Log errno rather than return value

2017-10-26 Thread Stefano Stabellini
From: Ross Lagerwall xen_modified_memory() sets errno to communicate what went wrong so log this rather than the return value which is not interesting. Signed-off-by: Ross Lagerwall Acked-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- hw/i386/xen/xen-hvm.c | 2 +- 1 file changed, 1

[Qemu-devel] [PULL 0/3] xen-20171026-tag

2017-10-26 Thread Stefano Stabellini
llini/qemu-dm.git tags/xen-20171026-tag for you to fetch changes up to 7cdcca725b6bfc96634c15e3f74ae4b148cf9c40: xen: Log errno rather than return value (2017-10-26 14:26:48 -0700) Xen

Re: [Qemu-devel] [PATCH v5.1 5/8] xen: move xc_interface compatibility fallback further up the file

2017-10-26 Thread Stefano Stabellini
On Fri, 20 Oct 2017, Ian Jackson wrote: > We are going to want to use the dummy xendevicemodel_handle type in > new stub functions in the CONFIG_XEN_CTRL_INTERFACE_VERSION < 41000 > section. So we need to provide that definition, or (as applicable) > include the appropriate header, earlier in the

Re: [Qemu-devel] [PATCH v5.1 1/8] xen: link against xentoolcore

2017-10-26 Thread Stefano Stabellini
On Fri, 20 Oct 2017, Ian Jackson wrote: > From: Anthony PERARD > > Xen libraries in 4.10 include a new xentoolcore library. This > contains the xentoolcore_restrict_all function which we are about to > want to use. > > Signed-off-by: Ian Jackson > --- > v5: More truthful commit message. > ---

Re: [Qemu-devel] [PATCH v5.1 7/8] os-posix: Provide new -runas : facility

2017-10-26 Thread Stefano Stabellini
CC'ing the maintainers (scripts/get_maintainer.pl is your friend) On Fri, 20 Oct 2017, Ian Jackson wrote: > This allows the caller to specify a uid and gid to use, even if there > is no corresponding password entry. This will be useful in certain > Xen configurations. > > We don't support just -

Re: [Qemu-devel] [PATCH v5.1 8/8] configure: do_compiler: Dump some extra info under bash

2017-10-26 Thread Stefano Stabellini
CC'ing the maintainers for this. On Fri, 20 Oct 2017, Ian Jackson wrote: > This makes it much easier to find a particular thing in config.log. > > The information may be lacking in other shells, resulting in harmless > empty output. (This is why we don't use the proper ${FUNCNAME[*]} > array syn

Re: [Qemu-devel] [PATCH v5.1 6/8] xen: destroy_hvm_domain: Try xendevicemodel_shutdown

2017-10-26 Thread Stefano Stabellini
On Fri, 20 Oct 2017, Ian Jackson wrote: > xc_interface_open etc. is not going to work if we have dropped > privilege, but xendevicemodel_shutdown will if everything is new > enough. > > xendevicemodel_shutdown is only availabe in Xen 4.10 and later, so > provide a stub for earlier versions. > > S

Re: [Qemu-devel] [PATCH] exec: Fix section_covers_addr() for sections with non-zero offset

2017-10-26 Thread BALATON Zoltan
On Sat, 21 Oct 2017, BALATON Zoltan wrote: When a section with non-0 offset_within_region field is tested to cover an address the offset should be taken into account as well. This fixes a crash caused by picking the wrong memory region in address_space_lookup_region seen with client code accessi

Re: [Qemu-devel] [PATCH v5.1 3/8] xen: defer call to xen_restrict until just before os_setup_post

2017-10-26 Thread Stefano Stabellini
This patch affects non-Xen components. CC'ing the relevant maintainers. On Fri, 20 Oct 2017, Ian Jackson wrote: > We need to restrict *all* the control fds that qemu opens. Looking in > /proc/PID/fd shows there are many; their allocation seems scattered > throughout Xen support code in qemu. > >

Re: [Qemu-devel] [PATCH v5.1 4/8] xen: destroy_hvm_domain: Move reason into a variable

2017-10-26 Thread Stefano Stabellini
On Fri, 20 Oct 2017, Ian Jackson wrote: > We are going to want to reuse this. > > No functional change. > > Signed-off-by: Ian Jackson > Reviewed-by: Anthony PERARD Acked-by: Stefano Stabellini > --- > hw/i386/xen/xen-hvm.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >

Re: [Qemu-devel] [PATCH v5.1 2/8] xen: restrict: use xentoolcore_restrict_all

2017-10-26 Thread Stefano Stabellini
On Fri, 20 Oct 2017, Ian Jackson wrote: > And insist that it works. > > Drop individual use of xendevicemodel_restrict and > xenforeignmemory_restrict. These are not actually effective in this > version of qemu, because qemu has a large number of fds open onto > various Xen control devices. > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: Use tcg_gen_lookup_and_goto_ptr

2017-10-26 Thread David Gibson
On Thu, Oct 26, 2017 at 02:22:57PM +0200, Thomas Huth wrote: > On 30.06.2017 20:37, Richard Henderson wrote: > > Cc: qemu-...@nongnu.org > > Signed-off-by: Richard Henderson > > --- > > target/ppc/translate.c | 23 --- > > 1 file changed, 8 insertions(+), 15 deletions(-) > >

Re: [Qemu-devel] [PATCH v2] linux-user: fix is_proc_myself to check the paths via realpath

2017-10-26 Thread Zach Riggle
Friendly ping :) I've updated the patch with v2 which addresses the style issue *Zach Riggle* On Tue, Oct 24, 2017 at 10:34 PM, Zach Riggle wrote: > Previously, it was possible to get a handle to the "real" /proc/self/mem > by creating a symlink to it and opening the symlink, or opening e.g.

Re: [Qemu-devel] [PATCH v2] s390-ccw: print carriage return with new lines

2017-10-26 Thread Collin L. Walling
On 10/26/2017 04:48 PM, Alexander Graf wrote: On 26.10.17 22:37, Collin L. Walling wrote: On 10/26/2017 04:25 PM, Alexander Graf wrote: On 26.10.17 20:52, Collin L. Walling wrote: The sclp console in the s390 bios writes raw data, leading console emulators (such as virsh console) to treat a n

Re: [Qemu-devel] [PATCH v2] s390-ccw: print carriage return with new lines

2017-10-26 Thread Alexander Graf
On 26.10.17 22:37, Collin L. Walling wrote: > On 10/26/2017 04:25 PM, Alexander Graf wrote: >> >> On 26.10.17 20:52, Collin L. Walling wrote: >>> The sclp console in the s390 bios writes raw data, >>> leading console emulators (such as virsh console) to >>> treat a new line ('\n') as just a new l

Re: [Qemu-devel] [PATCH v2] s390-ccw: print carriage return with new lines

2017-10-26 Thread Collin L. Walling
On 10/26/2017 04:25 PM, Alexander Graf wrote: On 26.10.17 20:52, Collin L. Walling wrote: The sclp console in the s390 bios writes raw data, leading console emulators (such as virsh console) to treat a new line ('\n') as just a new line instead of as a Unix line feed. Because of this, output ap

Re: [Qemu-devel] [PATCH v2] s390-ccw: print carriage return with new lines

2017-10-26 Thread Alexander Graf
On 26.10.17 20:52, Collin L. Walling wrote: > The sclp console in the s390 bios writes raw data, > leading console emulators (such as virsh console) to > treat a new line ('\n') as just a new line instead > of as a Unix line feed. Because of this, output > appears in a "stair case" pattern. > >

[Qemu-devel] [PATCH v1 1/3] tests: adding 'check_exception' RTAS implementation

2017-10-26 Thread Daniel Henrique Barboza
In the sPAPR guest, events such as device hotplug/unplug are retrieved by the check_exception RTAS call after the guest receives an IRQ pulse. For both hotplug and unplug operations, guest intervention is required to transit the DRC state of the attached device to the configured state. Without gue

[Qemu-devel] [PATCH v1 2/3] tests: adding 'set_indicator' RTAS call

2017-10-26 Thread Daniel Henrique Barboza
'set_indicator' is a RTAS hypercall that is used to change the state of both physical and logical devices DRCs by setting allocation-state, isolation-state and dr-indicator. This patch implements the set_indicator RTAS call in tests/libqos/rtas.c, adding its test in tests/rtas-test.c. Signed-off-

[Qemu-devel] [PATCH v1 0/3] ppc: adding some RTAS calls in tests/libqos

2017-10-26 Thread Daniel Henrique Barboza
This series implements a few RTAS hypercalls in tests/libqos that, used together, implement the DRC state transition described in PAPR 2.7+, 13.4. This started as an attempt of implementing hot unplug qtests for the sPAPR machine but I've found a few issues that will require more time solving: -

[Qemu-devel] [PATCH v1 3/3] tests: ibm, configure-connector RTAS call implementation

2017-10-26 Thread Daniel Henrique Barboza
'ibm,configure-connector' hypercall is used by the guest OS to start the configuration of a given device, where the machine configures the said device and all its sub-devices, giving back FDTs to the caller for each sub-device. This hypercall is supposed to be called multiple times by the guest OS

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-10-26 Thread Brian Murray
I accepted this but Launchpad timed out when the SRU testing comment was being added. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1719196 Title: [arm64 ocata] newly created instances are unable t

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-10-26 Thread Brian Murray
** Changed in: qemu (Ubuntu Zesty) Status: Incomplete => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1719196 Title: [arm64 ocata] newly created instances are unable to raise

Re: [Qemu-devel] [PATCH] tcg: Avoid setting tcg_initialize if !CONFIG_TCG

2017-10-26 Thread Philippe Mathieu-Daudé
Oops sent a bit too fast. On 10/26/2017 03:57 PM, Philippe Mathieu-Daudé wrote: > On 10/26/2017 02:37 PM, Emilio G. Cota wrote: >> AFAIK the only target that is so far supposed to work with >> --disable-tcg is i386. The configure script however lets you try to >> build without TCG if the host has

Re: [Qemu-devel] [PATCH] tcg: Avoid setting tcg_initialize if !CONFIG_TCG

2017-10-26 Thread Philippe Mathieu-Daudé
On 10/26/2017 02:37 PM, Emilio G. Cota wrote: > AFAIK the only target that is so far supposed to work with > --disable-tcg is i386. The configure script however lets you try to > build without TCG if the host has an alternative accelerator (e.g. KVM), > but that build is likely to fail. [ just conf

[Qemu-devel] [Bug 1368178] Re: Windows ME falsely detects qemu's videocards as Number Nine Imagine 128

2017-10-26 Thread Thomas Huth
** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1368178 Title: Windows ME falsely detects qemu's videocards as Number Nine Imagine 128 Status i

[Qemu-devel] [PATCH v2] s390-ccw: print carriage return with new lines

2017-10-26 Thread Collin L. Walling
The sclp console in the s390 bios writes raw data, leading console emulators (such as virsh console) to treat a new line ('\n') as just a new line instead of as a Unix line feed. Because of this, output appears in a "stair case" pattern. Let's print \r\n on every occurrence of a new line in the st

Re: [Qemu-devel] [PATCH 1/2] tcg: Allow constant pool entries in the prologue

2017-10-26 Thread Emilio G. Cota
On Thu, Oct 26, 2017 at 17:27:03 +0200, Richard Henderson wrote: > Both ARMv6 and AArch64 currently may drop complex guest_base values > into the constant pool. But generic code wasn't expecting that, and > the pool is not emitted. Correct that. > > Reported-by: Laurent Desnogues > Signed-off-b

Re: [Qemu-devel] [PATCH] tcg: Avoid setting tcg_initialize if !CONFIG_TCG

2017-10-26 Thread Emilio G. Cota
On Thu, Oct 26, 2017 at 15:58:14 +0200, Richard Henderson wrote: > Fix the build for --disable-tcg. > > Fixes: 55c3ceef61fcf06fc98ddc752b7cce788ce7680b > Signed-off-by: Richard Henderson > --- > target/arm/cpu.c| 2 ++ > target/i386/cpu.c | 2 ++ > target/mips/cpu.c

Re: [Qemu-devel] [Qemu-arm] [PATCH] hw/arm/virt: support 4 serial ports

2017-10-26 Thread Jason A. Donenfeld
On Thu, Oct 26, 2017 at 6:41 PM, Peter Maydell wrote: > Those are primarily about migration compatibility -- you should > be able to live migrate a guest from QEMU 2.6's virt-2.6 machine to > QEMU 2.7's virt-2.6 machine. That's a stricter requirement than > the compatibility we want to keep for no

Re: [Qemu-devel] [PULL v1 0/5] Merge tpm 2017/10/24

2017-10-26 Thread Peter Maydell
On 25 October 2017 at 15:47, Stefan Berger wrote: > The following series of patches primarily fixes a recent build problem > with --disable-tpm. > > Stefan > > > The following changes since commit 3d7196d43bfe12efe98568cb60057e273652b99b: > > Merge remote-tracking branch > 'remotes/kraxel/

Re: [Qemu-devel] [Qemu-arm] [PATCH] hw/arm/virt: support 4 serial ports

2017-10-26 Thread Peter Maydell
On 26 October 2017 at 17:36, Jason A. Donenfeld wrote: > On Thu, Oct 26, 2017 at 6:34 PM, Peter Maydell > wrote: >> Reordering it would break existing users of the trustzone uart, >> whose command lines would stop working. > > I thought this was the reason for all of those virt26, virt28,etc > t

Re: [Qemu-devel] [Qemu-arm] [PATCH] hw/arm/virt: support 4 serial ports

2017-10-26 Thread Jason A. Donenfeld
On Thu, Oct 26, 2017 at 6:34 PM, Peter Maydell wrote: > Reordering it would break existing users of the trustzone uart, > whose command lines would stop working. I thought this was the reason for all of those virt26, virt28,etc types -- people who want stability code the revision into their scrip

Re: [Qemu-devel] [Qemu-arm] [PATCH] hw/arm/virt: support 4 serial ports

2017-10-26 Thread Peter Maydell
On 26 October 2017 at 17:15, Jason A. Donenfeld wrote: > On Thu, Oct 26, 2017 at 4:36 PM, Peter Maydell > wrote: >> I'm still thinking about this. (You definitely can't have four, >> though, because we already have 2 in the trustzone-enabled >> config, so we can only add another 2.) > > The trus

[Qemu-devel] [Bug 1368178] Re: Windows ME falsely detects qemu's videocards as Number Nine Imagine 128

2017-10-26 Thread OIiver
Addition to my last comment. Ubuntu 17.10 is now shipped with QEMU 2.10. Thus we can expect that 18.04 LTS will be shipped with QEMU 2.10 or later, too. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/

[Qemu-devel] [Bug 1368178] Re: Windows ME falsely detects qemu's videocards as Number Nine Imagine 128

2017-10-26 Thread OIiver
I am still using Kubuntu 16.04.3 LTS and that is shipped with QEMU 2.5.0 # qemu-system-i386 --version QEMU emulator version 2.5.0 (Debian 1:2.5+dfsg-5ubuntu10.16) I am not planning to go into the hassle to install QEMU latest on 16.04.3 LTS. Could you delay the closing of the ticket until Kubunt

Re: [Qemu-devel] [Qemu-arm] [PATCH] hw/arm/virt: support 4 serial ports

2017-10-26 Thread Jason A. Donenfeld
On Thu, Oct 26, 2017 at 4:36 PM, Peter Maydell wrote: > This has *never* been guaranteed or indeed true. It's just happened > to be true for the x86 PC machine and perhaps for some others that > you've been using. For instance, the MIPS boston board only has > one uart. highbank has one. integrato

[Qemu-devel] [PATCH 2/2] tcg/s390x: Use constant pool for prologue

2017-10-26 Thread Richard Henderson
Rather than have separate code only used for guest_base, rely on a recent change to handle constant pool entries. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.inc.c | 44 1 file changed, 12 insertions(+), 32 deletions(-) diff --git a/tcg/

[Qemu-devel] [PATCH 0/2] tcg constant pool fixups

2017-10-26 Thread Richard Henderson
As noted by Laurent in private mail, foo-linux-user is currently broken on aarch64 host in unususal circumstances. By inspection, the same thing could happen for armv6 host. My testing is always on armv7 hardware, so I wouldn't have seen this. With that fixed, the s390x code can be simplified a

[Qemu-devel] [PATCH 1/2] tcg: Allow constant pool entries in the prologue

2017-10-26 Thread Richard Henderson
Both ARMv6 and AArch64 currently may drop complex guest_base values into the constant pool. But generic code wasn't expecting that, and the pool is not emitted. Correct that. Reported-by: Laurent Desnogues Signed-off-by: Richard Henderson --- tcg/tcg.c | 49 +++

Re: [Qemu-devel] host physical address width issues/questions for x86_64

2017-10-26 Thread Michael S. Tsirkin
On Thu, Oct 26, 2017 at 04:30:57PM +0800, Peter Xu wrote: > On Mon, Oct 23, 2017 at 10:23:43AM -0700, Prasad Singamsetty wrote: > > [...] > > > >>Proposal: > > >> > > >>We can simply change the VTD_HOST_ADDRESS_WIDTH to 48 bits > > >>with out any other changes to the code. The current set of > >

Re: [Qemu-devel] [v3 2/2] tests/pxe-test: add testcase using vhost-user-bridge

2017-10-26 Thread Michael S. Tsirkin
On Thu, Oct 26, 2017 at 02:44:25PM +0200, Jens Freimann wrote: > From: Jens Freimann > > Add a PXE testcase tunneling traffic through vhost-user-bridge process. > Create a vhost-user-bridge process and connect it to qemu via a socket. > > Signed-off-by: Jens Freimann > --- > tests/Makefile.inc

Re: [Qemu-devel] [PATCH] replication: Fix replication open fail

2017-10-26 Thread Xie Changlong
在 10/25/2017 2:51 PM, Wang Guang 写道: > replication_child_perm request write > permissions for all child which will lead bdrv_check_perm fail. > replication_child_perm() should request write > permissions only if it is writable itself. > > Signed-off-by: Wang Guang > Signed-off-by: Wang Yong Than

[Qemu-devel] [PATCH v5 5/5]arm: mk64fn1m0

2017-10-26 Thread Gabriel Costa
From: Gabriel Augusto Costa This Patch include mk64fn1m0.c that describe the kinetis k64 machine and some peripherals. Signed-off-by: Gabriel Augusto Costa --- hw/arm/mk64fn1m0.c | 136 + 1 file changed, 136 insertions(+) create mode 100644

[Qemu-devel] [PATCH v6]arm: Makefiles to kinetis k64 platform

2017-10-26 Thread Gabriel Costa
From: Gabriel Augusto Costa This file change the Makefiles to compile the mk64fn1m0 machine. Signed-off-by: Gabriel Augusto Costa --- default-configs/arm-softmmu.mak | 1 + hw/arm/Makefile.objs| 1 + hw/char/Makefile.objs | 1 + hw/misc/Makefile.objs | 3 +++ 4

  1   2   3   >