[Qemu-devel] [PULL 18/20] block/parallels: Do not update header or truncate image when INMIGRATE

2017-11-14 Thread Max Reitz
From: Jeff Cody If we write or modify the image file while the QEMU run state is INMIGRATE, then the BDRV_O_INACTIVE BDS flag is set. This will cause an assert, since the image is marked inactive. Make sure we obey this flag. Tested-by: Alexey Kardashevskiy Signed-off-by: Jeff Cody Message-i

[Qemu-devel] [PULL 16/20] iotests: 077: Filter out 'resume' lines

2017-11-14 Thread Max Reitz
From: Fam Zheng In the "Overlapping multiple requests" cases, the 3rd reqs (the break point B) doesn't wait for the 2nd, and once resumed the I/O will just continue. This is because the 2nd is already waiting for the 1st, and in wait_serialising_requests() there is: /* If the request is alr

[Qemu-devel] [PULL 13/20] iotests: Use new-style NBD connections

2017-11-14 Thread Max Reitz
From: Eric Blake Old-style NBD is deprecated upstream (it is documented, but no longer implemented in the reference implementation), and it is severely limited (it cannot support structured replies, which means it cannot support efficient handling of zeroes), when compared to new-style NBD. We a

[Qemu-devel] [PULL 06/20] qcow2: Add iotest for an empty refcount table

2017-11-14 Thread Max Reitz
From: Alberto Garcia This patch adds a simple iotest in which we try to write to an image with an empty refcount table (i.e. with all entries set to 0). This scenario was already handled by the existing consistency checks, but we add an explicit test case for completeness. Signed-off-by: Albert

[Qemu-devel] [PULL 12/20] iotests: Make 136 less flaky

2017-11-14 Thread Max Reitz
136 executes some AIO requests without a final aio_flush; then it advances the virtual clock and thus expects the last access time of the device to be less than the current time when queried (i.e. idle_time_ns to be greater than 0). However, without the aio_flush, some requests may be settled afte

[Qemu-devel] [PULL 14/20] qcow2: Check that corrupted images can be repaired in iotest 060

2017-11-14 Thread Max Reitz
From: Alberto Garcia We just fixed a few bugs that caused QEMU to crash when trying to write to corrupted qcow2 images, and iotest 060 was expanded to test all those scenarios. In almost all cases the corrupted images can be repaired using qemu-img, so this patch verifies that. Signed-off-by: A

[Qemu-devel] [PULL 08/20] iotests: Make 030 less flaky

2017-11-14 Thread Max Reitz
This patch fixes two race conditions in 030: 1. The first is in TestENOSPC.test_enospc(). After resuming the job, querying it to confirm it is no longer paused may fail because in the meantime it might have completed already. The same was fixed in TestEIO.test_ignore() already (in commi

[Qemu-devel] [PULL 03/20] qcow2: Prevent allocating compressed clusters at offset 0

2017-11-14 Thread Max Reitz
From: Alberto Garcia If the refcount data is corrupted then we can end up trying to allocate a new compressed cluster at offset 0 in the image, triggering an assertion in qcow2_alloc_bytes() that would crash QEMU: qcow2_alloc_bytes: Assertion `offset' failed. This patch adds an explicit check

[Qemu-devel] [PULL 11/20] iotests: Make 083 less flaky

2017-11-14 Thread Max Reitz
083 has (at least) two issues: 1. By launching the nbd-fault-injector in background, it may not be scheduled until the first grep on its output file is executed. However, until then, that file may not have been created yet -- so it either does not exist yet (thus making the grep emit an e

[Qemu-devel] [PULL 07/20] qcow2: Assert that the crypto header does not overlap other metadata

2017-11-14 Thread Max Reitz
From: Alberto Garcia The crypto header is initialized only when QEMU is creating a new image, so there's no chance of this happening on a corrupted image. If QEMU is really trying to allocate the header overlapping other existing metadata sections then this is a serious bug in QEMU itself so let

[Qemu-devel] [PULL 02/20] qcow2: Prevent allocating L2 tables at offset 0

2017-11-14 Thread Max Reitz
From: Alberto Garcia If the refcount data is corrupted then we can end up trying to allocate a new L2 table at offset 0 in the image, triggering an assertion in the qcow2 cache that would crash QEMU: qcow2_cache_entry_mark_dirty: Assertion `c->entries[i].offset != 0' failed This patch adds an

[Qemu-devel] [PULL 05/20] qcow2: Add iotest for an image with header.refcount_table_offset == 0

2017-11-14 Thread Max Reitz
From: Alberto Garcia This patch adds a simple iotest in which we try to write to an image with the refcount table offset set to 0. This scenario was already handled by the existing consistency checks, but we add an explicit test case for completeness. Signed-off-by: Alberto Garcia Message-id:

[Qemu-devel] [PULL 04/20] qcow2: Don't open images with header.refcount_table_clusters == 0

2017-11-14 Thread Max Reitz
From: Alberto Garcia qcow2_do_open() is checking that header.refcount_table_clusters is not too large, but it doesn't check that it's greater than zero. Apart from the fact that an image like that is obviously corrupted, trying to use it crashes QEMU since we end up with a null s->refcount_table

[Qemu-devel] [PULL 10/20] iotests: Make 055 less flaky

2017-11-14 Thread Max Reitz
First of all, test 055 does a valiant job of invoking pause_drive() sometimes, but that is worth nothing without blkdebug. So the first thing to do is to sprinkle a couple of "blkdebug::" in there -- with the exception of the transaction tests, because the blkdebug break points make the transactio

[Qemu-devel] [PULL 00/20] Block patches for 2.11.0-rc1

2017-11-14 Thread Max Reitz
The following changes since commit 191b5fbfa66e5b23e2150f3c6981d30eb84418a9: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2017-11-14 16:11:19 +) are available in the git repository at: git://github.com/XanClic/qemu.git tags/pull-block-2017-11-14

[Qemu-devel] [PULL 01/20] qcow2: Prevent allocating refcount blocks at offset 0

2017-11-14 Thread Max Reitz
From: Alberto Garcia Each entry in the qcow2 cache contains an offset field indicating the location of the data in the qcow2 image. If the offset is 0 then it means that the entry contains no data and is available to be used when needed. Because of that it is not possible to store in the cache t

Re: [Qemu-devel] [PULL for-2.11-rc2 0/5] Block patches

2017-11-14 Thread Peter Maydell
On 14 November 2017 at 10:37, Stefan Hajnoczi wrote: > The following changes since commit 508ba0f7e2092d3ca56e3f75e894d52d8b94818e: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20171109' into > staging (2017-11-13 11:41:47 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH 1/5 for-2.11?] qcow2: reject unaligned offsets in write compressed

2017-11-14 Thread Eric Blake
On 11/14/2017 04:16 AM, Anton Nefedov wrote: > Misaligned compressed write is not supported. > > Signed-off-by: Anton Nefedov > --- > block/qcow2.c | 4 > 1 file changed, 4 insertions(+) Should this one be applied in 2.11? Reviewed-by: Eric Blake > > diff --git a/block/qcow2.c b/block/

Re: [Qemu-devel] [PATCH 1/1] target-ppc: Fix booke206 tlbwe TLB instruction

2017-11-14 Thread Luc Michel
On 11/06/2017 07:16 AM, David Gibson wrote: > On Thu, Nov 02, 2017 at 11:35:59AM +0100, Luc MICHEL wrote: >> When overwritting a valid TLB entry with a new one, the previous page >> were not flushed in QEMU TLB, leading to incoherent mapping. This commit >> fixes this. > > I don't think this is ri

Re: [Qemu-devel] [Nbd] [Qemu-block] How to online resize qemu disk with nbd protocol?

2017-11-14 Thread Eric Blake
[reviving an old thread] On 01/23/2017 08:54 AM, Eric Blake wrote: > I'm still thinking that allowing the client to query the current size is > useful. Over the weekend, I was thinking of SEEK_SET/SEEK_END semantics > (SEEK_CUR doesn't really make sense, since we don't maintain a current > offse

Re: [Qemu-devel] [RFC 4/5] s390x/cpumodel: enable AP facilities for guest

2017-11-14 Thread David Hildenbrand
On 14.11.2017 16:11, Cornelia Huck wrote: > On Thu, 26 Oct 2017 11:54:53 -0400 > Tony Krowiak wrote: > >> Sets up the following STFLE bits to enable the specified AP >> facilities for the guest VM: >> * STFLE.12: Enables the AP Query Configuration Information >> facility.

Re: [Qemu-devel] [PATCH for-2.12 v3 08/11] spapr: introduce a XICSFabric irq_is_lsi() operation

2017-11-14 Thread Greg Kurz
On Fri, 10 Nov 2017 15:20:14 + Cédric Le Goater wrote: > It will be used later on to distinguish the allocation of an LSI > interrupt from an MSI and also to reduce the use of the ICSIRQState > array of the ICSState object, which is on our way to introduce XIVE. > > The 'irq' parameter conti

Re: [Qemu-devel] [PULL 0/2] ppc-for-2.11 queue 20171114

2017-11-14 Thread Peter Maydell
; > are available in the git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.11-20171114 > > for you to fetch changes up to dcb556fc6ad879f7d29fb233a273a1ea3aa0549c: > > xics/kvm: synchonize s

Re: [Qemu-devel] [PATCH 3/1] target/arm: Fix GETPC usage in do_paired_cmpxchg64_l/be

2017-11-14 Thread Alex Bennée
Richard Henderson writes: > Use of GETPC must be restricted to those functions that are > directly called from TCG generated code. > > Fixes: 2399d4e7cec22ecf1c51062d2ebfd45220dbaace > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/helper-a64.c | 14 ++-

Re: [Qemu-devel] [PATCH 2/1] target/arm: Use helper_retaddr in stxp helpers

2017-11-14 Thread Alex Bennée
Richard Henderson writes: > We use raw memory primitives along the !parallel_cpus paths in order to > simplify the endianness handling. Because of that, we did not benefit > from the generic changes to cpu_ldst_user_only_template.h. > > The simplest fix is to manipulate helper_retaddr here. > >

Re: [Qemu-devel] [PATCH] tcg: Record code_gen_buffer address for user-only memory helpers

2017-11-14 Thread Alex Bennée
Richard Henderson writes: > When we handle a signal from a fault within a user-only memory helper, > we cannot cpu_restore_state with the PC found within the signal frame. > Use a TLS variable, helper_retaddr, to record the unwind start point > to find the faulting guest insn. > > Reported-by: P

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] target/ppc: Use tcg_gen_lookup_and_goto_ptr

2017-11-14 Thread Daniel Henrique Barboza
On 10/27/2017 02:58 PM, Richard Henderson wrote: From: Richard Henderson Signed-off-by: Richard Henderson --- Rebased and updated for changes to tcg_gen_lookup_and_goto_ptr. --- I am experiencing a remarkable performance boost running a simple scenario up to SLOF prompt with this patch. I

Re: [Qemu-devel] [PATCH] iotests: Add test for failing qemu-img commit

2017-11-14 Thread Max Reitz
On 2017-11-10 22:21, Max Reitz wrote: > On 2017-06-16 15:58, Max Reitz wrote: >> Signed-off-by: Max Reitz >> --- >> In order to pass, this depends on "fix: avoid an infinite loop or a >> dangling pointer problem in img_commit" >> (http://lists.nongnu.org/archive/html/qemu-block/2017-06/msg00443.ht

Re: [Qemu-devel] [PATCH v6 0/6] block: Don't compare strings in bdrv_reopen_prepare()

2017-11-14 Thread Max Reitz
On 2017-10-04 17:25, Max Reitz wrote: > bdrv_reopen_prepare() assumes that all BDS options are strings, which is > not necessarily correct. This series introduces a new qobject_is_equal() > function which can be used to test whether any options have changed, > independently of their type. > > > v

Re: [Qemu-devel] [RFC 1/5] hw/vfio: Add function for getting reserved_region of device iommu group

2017-11-14 Thread Alex Williamson
On Tue, 14 Nov 2017 09:15:50 +0800 wrote: > From: Zhu Yijun > > With kernel 4.11, iommu/smmu will populate the MSI IOVA reserved window and > PCI reserved window which has to be excluded from Guest iova allocations. > > However, If it falls within the Qemu default virtual memory address space,

Re: [Qemu-devel] [PATCH for-2.12 v3 07/11] spapr: introduce an 'irq_base' number

2017-11-14 Thread Greg Kurz
On Fri, 10 Nov 2017 15:20:13 + Cédric Le Goater wrote: > 'irq_base' is a base IRQ number which lets us allocate only the subset > of the IRQ numbers used on the sPAPR platform. It is sync with the > ICSState 'offset' attribute and this is slightly redundant. We could > also choose to waste so

Re: [Qemu-devel] [PATCH for-2.11 4/5] qcow2: Add bounds check to get_refblock_offset()

2017-11-14 Thread Max Reitz
On 2017-11-14 16:38, Alberto Garcia wrote: > On Tue 14 Nov 2017 04:27:56 PM CET, Max Reitz wrote: +static int64_t get_refblock_offset(BlockDriverState *bs, uint64_t offset) +{ +BDRVQcow2State *s = bs->opaque; +uint32_t index = offset_to_reftable_index(s, offset); +

Re: [Qemu-devel] [PATCH for-2.11 4/5] qcow2: Add bounds check to get_refblock_offset()

2017-11-14 Thread Alberto Garcia
On Tue 14 Nov 2017 04:27:56 PM CET, Max Reitz wrote: >>> +static int64_t get_refblock_offset(BlockDriverState *bs, uint64_t offset) >>> +{ >>> +BDRVQcow2State *s = bs->opaque; >>> +uint32_t index = offset_to_reftable_index(s, offset); >>> +int64_t covering_refblock_offset = 0; >>> + >>>

Re: [Qemu-devel] [PATCH for-2.11 3/5] block: Guard against NULL bs->drv

2017-11-14 Thread Max Reitz
On 2017-11-10 22:46, Eric Blake wrote: > On 11/10/2017 02:31 PM, Max Reitz wrote: >> We currently do not guard everywhere against a NULL bs->drv where we >> should be doing so. Most of the places fixed here just do not care >> about that case at all. >> >> Some care implicitly, e.g. through a prio

Re: [Qemu-devel] [PATCH v6] NUMA: Enable adding NUMA node implicitly

2017-11-14 Thread Igor Mammedov
On Tue, 14 Nov 2017 10:34:01 +0800 Dou Liyang wrote: > Linux and Windows need ACPI SRAT table to make memory hotplug work properly, > however currently QEMU doesn't create SRAT table if numa options aren't > present > on CLI. > > Which breaks both linux and windows guests in certain conditions:

Re: [Qemu-devel] [PATCH for-2.11 5/5] qcow2: Refuse to get unaligned offsets from cache

2017-11-14 Thread Alberto Garcia
On Tue 14 Nov 2017 04:09:16 PM CET, Max Reitz wrote: >>> +static inline const char *qcow2_cache_get_name(BDRVQcow2State *s, >>> Qcow2Cache *c) >>> +{ >>> +if (c == s->refcount_block_cache) { >>> +return "refcount block"; >>> +} else if (c == s->l2_table_cache) { >>> +return

Re: [Qemu-devel] [PATCH v4 0/4] Don't write headers if BDS is INACTIVE

2017-11-14 Thread Max Reitz
On 2017-11-07 14:10, Jeff Cody wrote: > Changes from v3->v4: > > Patch 3: Add migrate_del_blocker and error_free (Thanks Stefan) Thanks, applied to my block branch: https://github.com/XanClic/qemu/commits/block Max signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH for-2.12 v3 05/11] spapr: introduce an IRQ allocator using a bitmap

2017-11-14 Thread Greg Kurz
On Tue, 14 Nov 2017 11:54:53 + Cédric Le Goater wrote: > On 11/14/2017 09:42 AM, Greg Kurz wrote: > > On Fri, 10 Nov 2017 15:20:11 + > > Cédric Le Goater wrote: > > > >> Let's define a new set of XICSFabric IRQ operations for the latest > >> pseries machine. These simply use a a bitma

Re: [Qemu-devel] [PATCH for-2.11 4/5] qcow2: Add bounds check to get_refblock_offset()

2017-11-14 Thread Max Reitz
On 2017-11-14 16:02, Alberto Garcia wrote: > On Fri 10 Nov 2017 09:31:10 PM CET, Max Reitz wrote: >> +static int64_t get_refblock_offset(BlockDriverState *bs, uint64_t offset) >> +{ >> +BDRVQcow2State *s = bs->opaque; >> +uint32_t index = offset_to_reftable_index(s, offset); >> +int64_t

Re: [Qemu-devel] [RFC 0/5] guest dedicated crypto adapters: QEMU usage

2017-11-14 Thread Cornelia Huck
On Thu, 26 Oct 2017 11:54:49 -0400 Tony Krowiak wrote: > I was asked to post this QEMU patch set to the mailing list to illustrate > how the KVM/kernel counterpart will be used. The KVM/kernel patches can be > viewed at: > > https://lkml.org/lkml/2017/10/13/706 > > The IBM Adjunct Processor (AP

Re: [Qemu-devel] [PULL 0/8] Net patches

2017-11-14 Thread Peter Maydell
On 14 November 2017 at 02:11, Jason Wang wrote: > The following changes since commit 4ffa88c99c54d2a30f79e3dbecec50b023eff1c8: > > Merge remote-tracking branch > 'remotes/berrange/tags/pull-qcrypto-2017-11-08-1' into staging (2017-11-10 > 16:01:35 +) > > are available in the git repository

Re: [Qemu-devel] [RFC 5/5] s390x/docs: documentation for ap-matrix

2017-11-14 Thread Cornelia Huck
On Thu, 26 Oct 2017 11:54:54 -0400 Tony Krowiak wrote: Cool, documentation! > Signed-off-by: Tony Krowiak > --- > docs/ap_matrix.txt | 529 > > 1 files changed, 529 insertions(+), 0 deletions(-) > create mode 100644 docs/ap_matrix.txt >

Re: [Qemu-devel] [PATCH for-2.12 3/3] block: Deprecate "backing": ""

2017-11-14 Thread Markus Armbruster
Max Reitz writes: > We have a clear replacement, so let's deprecate it. > > Signed-off-by: Max Reitz > --- > qapi/block-core.json | 4 ++-- > block.c | 4 > qemu-doc.texi| 7 +++ > qemu-options.hx | 4 ++-- > 4 files changed, 15 insertions(+), 4 deletions(-) >

Re: [Qemu-devel] [PATCH for-2.12 2/3] block: Handle null backing link

2017-11-14 Thread Max Reitz
On 2017-11-14 16:17, Markus Armbruster wrote: > Max Reitz writes: > >> Instead of converting all "backing": null instances into "backing": "", >> handle a null value directly in bdrv_open_inherit(). >> >> This enables explicitly null backing links for json:{} filenames. >> >> Signed-off-by: Max R

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.12 0/4] blockdev: Mark BD-{remove, insert}-medium stable

2017-11-14 Thread Alberto Garcia
On Fri 10 Nov 2017 11:42:58 PM CET, Max Reitz wrote: > Berto's "Test I/O limits with removable media" patch proves that > throttling survives a blockdev-remove-medium/blockdev-insert-medium pair > now, so let's mark them stable (because that was the reason they were > considered experimental, see c

Re: [Qemu-devel] [PATCH v4 1/4] block/vhdx.c: Don't blindly update the header

2017-11-14 Thread Max Reitz
On 2017-11-07 14:10, Jeff Cody wrote: > The VHDX specification requires that before user data modification of > the vhdx image, the VHDX header file and data GUIDs need to be updated. > In vhdx_open(), if the image is set to RDWR, we go ahead and update the > header. > > However, just because the

Re: [Qemu-devel] [PATCH for-2.12 2/3] block: Handle null backing link

2017-11-14 Thread Markus Armbruster
Max Reitz writes: > Instead of converting all "backing": null instances into "backing": "", > handle a null value directly in bdrv_open_inherit(). > > This enables explicitly null backing links for json:{} filenames. > > Signed-off-by: Max Reitz > --- > block.c| 2 +- > blo

Re: [Qemu-devel] [PATCH for-2.12 v3 06/11] spapr: store a reference IRQ bitmap

2017-11-14 Thread Greg Kurz
On Fri, 10 Nov 2017 15:20:12 + Cédric Le Goater wrote: > To save some state when the guest is migrated, we capture the IRQ > bitmap after all devices have been reseted and store it as a reference > for the machine. > > Signed-off-by: Cédric Le Goater > --- > > We should probably merge thi

Re: [Qemu-devel] [PATCH 1/8] sdl2: Fix broken display updating after the window is hidden

2017-11-14 Thread Gerd Hoffmann
> > The only thing I can say is that I submitted > > https://bugzilla.libsdl.org/show_bug.cgi?id=2818 as a result. Nobody > > has replied to that in three years, but when testing it on SDL 2.0.7, > > the issue appears to be fixed. > > Having done a bisect, SDL2 revision 11151:7cfe088fafba seems t

[Qemu-devel] [Bug 1717708] Re: QEMU aarch64 can't run Windows ARM64 iso's

2017-11-14 Thread Peter Maydell
If you want to argue for things being in UEFI images, you're in the wrong place, because this is the QEMU bug tracker, not a UEFI one... -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1717708 Title:

Re: [Qemu-devel] [RFC 4/5] s390x/cpumodel: enable AP facilities for guest

2017-11-14 Thread Cornelia Huck
On Thu, 26 Oct 2017 11:54:53 -0400 Tony Krowiak wrote: > Sets up the following STFLE bits to enable the specified AP > facilities for the guest VM: > * STFLE.12: Enables the AP Query Configuration Information > facility. The AP bus running in the guest uses >

Re: [Qemu-devel] [PATCH for-2.11 5/5] qcow2: Refuse to get unaligned offsets from cache

2017-11-14 Thread Max Reitz
On 2017-11-14 16:06, Alberto Garcia wrote: > On Fri 10 Nov 2017 09:31:11 PM CET, Max Reitz wrote: >> +static inline const char *qcow2_cache_get_name(BDRVQcow2State *s, >> Qcow2Cache *c) >> +{ >> +if (c == s->refcount_block_cache) { >> +return "refcount block"; >> +} else if (c == s

Re: [Qemu-devel] [RFC 3/5] s390x/ap-matrix: Configure AP matrix for KVM guest

2017-11-14 Thread Cornelia Huck
On Thu, 26 Oct 2017 11:54:52 -0400 Tony Krowiak wrote: > The VFIO AP matrix mediated device driver provides an ioctl interface > to configure the APM, ADM and APM fields contained in the > CRYCB referenced by the guest's SIE state description. The mask > values are specified in the mediated AP ma

Re: [Qemu-devel] [PATCH] iotests: 077: Filter out 'resume' lines

2017-11-14 Thread Max Reitz
On 2017-11-13 16:00, Fam Zheng wrote: > In the "Overlapping multiple requests" cases, the 3rd reqs (the break > point B) doesn't wait for the 2nd, and once resumed the I/O will just > continue. This is because the 2nd is already waiting for the 1st, and > in wait_serialising_requests() there is: >

Re: [Qemu-devel] [PATCH for-2.11 5/5] qcow2: Refuse to get unaligned offsets from cache

2017-11-14 Thread Alberto Garcia
On Fri 10 Nov 2017 09:31:11 PM CET, Max Reitz wrote: > +static inline const char *qcow2_cache_get_name(BDRVQcow2State *s, Qcow2Cache > *c) > +{ > +if (c == s->refcount_block_cache) { > +return "refcount block"; > +} else if (c == s->l2_table_cache) { > +return "L2 table"; >

Re: [Qemu-devel] [RFC 2/5] s390x/vfio: ap-matrix: Introduce VFIO AP Matrix device

2017-11-14 Thread Cornelia Huck
On Thu, 26 Oct 2017 11:54:51 -0400 Tony Krowiak wrote: > Introduces a VFIO based AP matrix device. This device will establish > a communication pathway to the VFIO AP Matrix kernel device driver > via a mediated AP matrix device file descriptor. This communication pathway > will be used to: > >

Re: [Qemu-devel] [PATCH for-2.11 4/5] qcow2: Add bounds check to get_refblock_offset()

2017-11-14 Thread Alberto Garcia
On Fri 10 Nov 2017 09:31:10 PM CET, Max Reitz wrote: > +static int64_t get_refblock_offset(BlockDriverState *bs, uint64_t offset) > +{ > +BDRVQcow2State *s = bs->opaque; > +uint32_t index = offset_to_reftable_index(s, offset); > +int64_t covering_refblock_offset = 0; > + > +if (inde

Re: [Qemu-devel] [PATCH for-2.12 1/3] qapi: Add qdict_is_null()

2017-11-14 Thread Max Reitz
On 2017-11-14 15:57, Markus Armbruster wrote: > Max Reitz writes: > >> Signed-off-by: Max Reitz >> --- >> include/qapi/qmp/qdict.h | 1 + >> qobject/qdict.c | 10 ++ >> 2 files changed, 11 insertions(+) >> >> diff --git a/include/qapi/qmp/qdict.h b/include/qapi/qmp/qdict.h >>

Re: [Qemu-devel] [RFC 1/5] s390x/ap-matrix: Adjunct Processor (AP) matrix object model

2017-11-14 Thread Cornelia Huck
On Thu, 26 Oct 2017 11:54:50 -0400 Tony Krowiak wrote: > This patch introduces the base object model for an AP matrix device. An AP > matrix is comprised of the AP adapters, usage domains and control domains > assigned to a KVM guest. The matrix is represented in three bit masks: > > * The AP Ma

Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch

2017-11-14 Thread Max Reitz
On 2017-10-23 11:29, Vladimir Sementsov-Ogievskiy wrote: > Snapshot-switch actually changes active state of disk so it should > reflect on dirty bitmaps. Otherwise next incremental backup using > these bitmaps will be invalid. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/snapsho

Re: [Qemu-devel] [PATCH for-2.12 1/3] qapi: Add qdict_is_null()

2017-11-14 Thread Markus Armbruster
Max Reitz writes: > Signed-off-by: Max Reitz > --- > include/qapi/qmp/qdict.h | 1 + > qobject/qdict.c | 10 ++ > 2 files changed, 11 insertions(+) > > diff --git a/include/qapi/qmp/qdict.h b/include/qapi/qmp/qdict.h > index fc218e7be6..c65ebfc748 100644 > --- a/include/qapi/q

Re: [Qemu-devel] [PATCH for-2.11 2/5] qcow2: Unaligned zero cluster in handle_alloc()

2017-11-14 Thread Alberto Garcia
On Fri 10 Nov 2017 09:31:08 PM CET, Max Reitz wrote: > We should check whether the cluster offset we are about to use is > actually valid; that is, whether it is aligned to cluster boundaries. > > Reported-by: R. Nageswara Sastry > Buglink: https://bugs.launchpad.net/qemu/+bug/1728643 > Buglink: h

[Qemu-devel] [Bug 1717708] Re: QEMU aarch64 can't run Windows ARM64 iso's

2017-11-14 Thread Googulator
I know it won't work in KVM. I'm arguing that something not working in KVM is not grounds for removal from the UEFI image, since qemu != KVM. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1717708 Tit

Re: [Qemu-devel] [RFC 4/5] hw/arm/boot: set fdt size cell of memory node from mem_list

2017-11-14 Thread Andrew Jones
On Tue, Nov 14, 2017 at 09:15:53AM +0800, zhuyi...@huawei.com wrote: > From: Zhu Yijun > > In case of accessing memory holes, we create memory fdt node by > traversing mem_list and adjust memory address if the addr is not > belong to RAM memory region. > > Signed-off-by: Zhu Yijun > --- > hw/a

Re: [Qemu-devel] [RFC 5/5] hw/arm/virt-acpi-build: Build srat table according to mem_list

2017-11-14 Thread Andrew Jones
On Tue, Nov 14, 2017 at 09:15:54AM +0800, zhuyi...@huawei.com wrote: > From: Zhu Yijun > > In case of accessing memory holes, we build srat table by > traversing mem_list. > > Signed-off-by: Zhu Yijun > --- > hw/arm/virt-acpi-build.c | 40 +++- > 1 file chan

[Qemu-devel] [Bug 1726394] Re: Passes through prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, address)

2017-11-14 Thread ChristianEhrhardt
LP, this was unfair to reverse-pass me :-) Anyway - done - thanks Julian and James C. for your work on that. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1726394 Title: Passes through prctl(PR_SET

[Qemu-devel] [Bug 1726394] Re: Passes through prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, address)

2017-11-14 Thread ChristianEhrhardt
See it passed [1] but britney not picking up. Giving it some time to do so. [1]: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac /autopkgtest-bionic/bionic/amd64/o/open- iscsi/20171114_135029_17bf1@/log.gz -- You received this bug notification because yo

Re: [Qemu-devel] [RFC 3/5] hw/arm: add scattered RAM memory region support

2017-11-14 Thread Andrew Jones
On Tue, Nov 14, 2017 at 09:15:52AM +0800, zhuyi...@huawei.com wrote: > From: Zhu Yijun > > Dig out reserved memory holes and collect scattered RAM memory > regions by adding mem_list member in arm_boot_info struct. > > Signed-off-by: Zhu Yijun > --- > hw/arm/boot.c| 8 > hw/arm/

Re: [Qemu-devel] [PATCH 1/8] sdl2: Fix broken display updating after the window is hidden

2017-11-14 Thread Max Reitz
On 2017-11-13 17:35, Max Reitz wrote: > On 2017-11-13 13:39, Gerd Hoffmann wrote: >> On Sun, Nov 12, 2017 at 08:30:25PM +0100, Jindrich Makovicka wrote: >>> With SDL 2.0.6, calling SDL_ShowWindow during SDL_WINDOWEVENT_HIDDEN >>> blocks all subsequent display updates. >>> >>> Instead of trying to o

Re: [Qemu-devel] [RFC 2/5] hw/arm/virt: Enable dynamic generation of guest RAM memory regions

2017-11-14 Thread Andrew Jones
On Tue, Nov 14, 2017 at 09:15:51AM +0800, zhuyi...@huawei.com wrote: > From: Zhu Yijun > > Register a ram_memory_region_init notify to allocate memory region > from system memory and add them as subregions. > > Signed-off-by: Zhu Yijun > --- > hw/arm/virt.c | 21 - >

Re: [Qemu-devel] [RESEND PATCH 5/6] vfio/pci: add notify framework based on IOMMUObject

2017-11-14 Thread Liu, Yi L
Hi Eric, On Tue, Nov 14, 2017 at 11:23:03AM +0100, Auger Eric wrote: > Hi Yi L, > > On 03/11/2017 13:01, Liu, Yi L wrote: > > This patch introduce a notify framework for IOMMUObject.iommu_notifiers. > > Introduce VFIOGuestIOMMUObject is to link VFIO Container and the new > > IOMMUObject notififie

[Qemu-devel] [Bug 1726394] Re: Passes through prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, address)

2017-11-14 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:2.10+dfsg-0ubuntu4 --- qemu (1:2.10+dfsg-0ubuntu4) bionic; urgency=medium * Apply linux-user-return-EINVAL-from-prctl-PR_-_SECCOMP.patch from James Cowgill to prevent qemu-user from forwarding prctl seccomp calls (LP: #1726394) --

[Qemu-devel] [PULL 1/1] seabios: update to 1.11 final

2017-11-14 Thread Gerd Hoffmann
Update our pre-release seabios snapshot to the final release. git shortlog Gerd Hoffmann (1): sercon: Disable ScreenAndDebug in case both serial console and serial debug are active Kevin O'Connor (2): timer: Avoid integer overflows in usec and nsec calculations do

[Qemu-devel] [PULL 0/1] Seabios 1.11 final 20171114 patches

2017-11-14 Thread Gerd Hoffmann
1.11-final-20171114-pull-request for you to fetch changes up to 6350b2a09b8a330cbfaea462a34bbb1b8c63d7b1: seabios: update to 1.11 final (2017-11-14 15:36:08 +0100) seabios: update to

Re: [Qemu-devel] [RESEND PATCH 2/6] memory: introduce AddressSpaceOps and IOMMUObject

2017-11-14 Thread Liu, Yi L
Hi Eric, On Tue, Nov 14, 2017 at 11:21:59AM +0100, Auger Eric wrote: > Hi Yi L, > > On 03/11/2017 13:01, Liu, Yi L wrote: > > From: Peter Xu > > > > AddressSpaceOps is similar to MemoryRegionOps, it's just for address > > spaces to store arch-specific hooks. > > > > The first hook I would like

Re: [Qemu-devel] [PATCH v6 4/5] crash: export paddr_vmcoreinfo_note()

2017-11-14 Thread Baoquan He
On 11/13/17 at 08:29pm, Marc-André Lureau wrote: > The following patch is going to use the symbol from the fw_cfg module, > to call the function and write the note location details in the > vmcoreinfo entry, so qemu can produce dumps with the vmcoreinfo note. > > CC: Andrew Morton > CC: Baoquan H

Re: [Qemu-devel] [RESEND PATCH 2/6] memory: introduce AddressSpaceOps and IOMMUObject

2017-11-14 Thread Liu, Yi L
On Tue, Nov 14, 2017 at 09:53:07AM +0100, Auger Eric wrote: Hi Eric, > Hi Yi L, > > On 13/11/2017 10:58, Liu, Yi L wrote: > > On Mon, Nov 13, 2017 at 04:56:01PM +1100, David Gibson wrote: > >> On Fri, Nov 03, 2017 at 08:01:52PM +0800, Liu, Yi L wrote: > >>> From: Peter Xu > >>> > >>> AddressSpac

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.12 1/3] qapi: Add qdict_is_null()

2017-11-14 Thread Max Reitz
On 2017-11-14 15:07, Alberto Garcia wrote: > On Fri 10 Nov 2017 11:13:27 PM CET, Max Reitz wrote: >> Signed-off-by: Max Reitz >> --- >> include/qapi/qmp/qdict.h | 1 + >> qobject/qdict.c | 10 ++ >> 2 files changed, 11 insertions(+) >> >> diff --git a/include/qapi/qmp/qdict.h b/

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.12 1/3] qapi: Add qdict_is_null()

2017-11-14 Thread Alberto Garcia
On Fri 10 Nov 2017 11:13:27 PM CET, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > include/qapi/qmp/qdict.h | 1 + > qobject/qdict.c | 10 ++ > 2 files changed, 11 insertions(+) > > diff --git a/include/qapi/qmp/qdict.h b/include/qapi/qmp/qdict.h > index fc218e7be6..c65ebfc

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.12 2/3] block: Handle null backing link

2017-11-14 Thread Alberto Garcia
On Fri 10 Nov 2017 11:13:28 PM CET, Max Reitz wrote: > Instead of converting all "backing": null instances into "backing": "", > handle a null value directly in bdrv_open_inherit(). > > This enables explicitly null backing links for json:{} filenames. > > Signed-off-by: Max Reitz Reviewed-by: Alb

Re: [Qemu-devel] Command-line option to change ungrab key(s)

2017-11-14 Thread Gerd Hoffmann
Hi, > > Certainly not this way. > > Did you have an idea on how something like this should look like? This > feature would only change the old mouse ungrab keys to a > user-specified one. So the basic algorithm would be change the text > that displays at the top of the QEMU window to say (Press

Re: [Qemu-devel] [PULL 0/9] target-arm queue

2017-11-14 Thread Peter Maydell
On 13 November 2017 at 14:11, Peter Maydell wrote: > ARM bugfixes for rc1... > > > The following changes since commit f291910db61b5812e68f1e76afb3ade41d567bea: > > Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2017-11-09' into > staging (2017-11-13 13:13:12 +) > > are available

Re: [Qemu-devel] [PATCH] qcow2: fix image corruption after committing qcow2 image into base

2017-11-14 Thread Max Reitz
On 2017-11-10 18:22, Daniel P. Berrange wrote: > On Fri, Nov 10, 2017 at 10:34:59AM -0600, Eric Blake wrote: >> On 11/03/2017 09:41 AM, Daniel P. Berrange wrote: >>> After committing the qcow2 image contents into the base image, qemu-img >>> will call bdrv_make_empty to drop the payload in the laye

[Qemu-devel] [Bug 1713825] Re: Booting Windows 2016 with qxl video crashes qemu

2017-11-14 Thread Gerd Hoffmann
Doesn't reproduce. It's a newer driver though (10.0.0.18000). Does updating the driver help? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1713825 Title: Booting Windows 2016 with qxl video crashe

[Qemu-devel] [Bug 1717708] Re: QEMU aarch64 can't run Windows ARM64 iso's

2017-11-14 Thread Peter Maydell
Plain linear framebuffer won't work with KVM, unfortunately. The best fix is for Windows to support virtio-gpu, then it will work in KVM as well as pure emulation. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad

Re: [Qemu-devel] Command-line option to change ungrab key(s)

2017-11-14 Thread Programmingkid
> On Nov 14, 2017, at 2:21 AM, Gerd Hoffmann wrote: > > Hi, > > Would this feature be something you would consider adding to QEMU? As context, virt-manager allows customization for the ungrab sequence, and so do spice-gtk/gtk-vnc at the API level. So conceptually I think it

[Qemu-devel] [PATCH 3/1] target/arm: Fix GETPC usage in do_paired_cmpxchg64_l/be

2017-11-14 Thread Richard Henderson
Use of GETPC must be restricted to those functions that are directly called from TCG generated code. Fixes: 2399d4e7cec22ecf1c51062d2ebfd45220dbaace Signed-off-by: Richard Henderson --- target/arm/helper-a64.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/tar

Re: [Qemu-devel] [RFC PATCH v2 18/26] cpu-exec: don't overwrite exception_index

2017-11-14 Thread Paolo Bonzini
On 14/11/2017 09:18, Pavel Dovgalyuk wrote: > This patch adds a condition before overwriting exception_index fiels. > It is needed when exception_index is already set to some meaningful value. > > Signed-off-by: Pavel Dovgalyuk > > --- > accel/tcg/cpu-exec.c |4 +++- > 1 file changed, 3 ins

[Qemu-devel] [Bug 1717708] Re: QEMU aarch64 can't run Windows ARM64 iso's

2017-11-14 Thread Googulator
virtio-gpu-pci will not work for booting Windows. Per https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup /uefi-requirements-that-apply-to-all-windows-platforms, Windows currently requires a linear framebuffer to be exposed through the UEFI Graphics Output Protocol: "Windows require

Re: [Qemu-devel] [RFC PATCH v2 14/26] replay/replay.c: bump REPLAY_VERSION again

2017-11-14 Thread Paolo Bonzini
On 14/11/2017 09:17, Pavel Dovgalyuk wrote: > From: Alex Bennée > > This time commit 802f045a5f61b781df55e4492d896b4d20503ba7 broke the > replay file format. Also add a comment about this to > replay-internal.h. > > Signed-off-by: Alex Bennée > Reviewed-off-by: Pavel Dovgalyuk > > --- > repl

Re: [Qemu-devel] [RFC PATCH v2 21/26] replay: check return values of fwrite

2017-11-14 Thread Paolo Bonzini
On 14/11/2017 09:18, Pavel Dovgalyuk wrote: > This patch adds error reporting when fwrite cannot completely > save the buffer to the file. > > Signed-off-by: Pavel Dovgalyuk > > --- > replay/replay-internal.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/replay

Re: [Qemu-devel] [RFC PATCH v2 19/26] cpu-exec: reset exit flag before calling cpu_exec_nocache

2017-11-14 Thread Paolo Bonzini
On 14/11/2017 09:18, Pavel Dovgalyuk wrote: > This patch resets icount_decr.u32.high before calling cpu_exec_nocache > when exception is pending. Exception is caused by the first instruction > in the block and it cannot be executed without resetting the flag. > > This patch also moves this check t

Re: [Qemu-devel] [RFC PATCH v2 10/26] icount: fixed saving/restoring of icount warp timers

2017-11-14 Thread Paolo Bonzini
On 14/11/2017 09:17, Pavel Dovgalyuk wrote: > This patch adds saving and restoring of the icount warp > timers in the vmstate. > It is needed because there timers affect the virtual clock value. > Therefore determinism of the execution in icount record/replay mode > depends on determinism of the ti

Re: [Qemu-devel] [RFC PATCH v2 20/26] replay: don't destroy mutex at exit

2017-11-14 Thread Paolo Bonzini
On 14/11/2017 09:18, Pavel Dovgalyuk wrote: > Replay mutex is held by vCPU thread and destroy function is called > from atexit of the main thread. Therefore we cannot destroy it safely. > > Signed-off-by: Pavel Dovgalyuk > > --- > replay/replay.c |1 - > 1 file changed, 1 deletion(-) > > d

Re: [Qemu-devel] [RFC PATCH v2 05/26] replay: fixed replay_enable_events

2017-11-14 Thread Paolo Bonzini
On 14/11/2017 09:17, Pavel Dovgalyuk wrote: > This patch fixes assignment to internal events_enabled variable. > Now it is set only in record/replay mode. This affects the behavior > of the external functions that check this flag. > > Signed-off-by: Pavel Dovgalyuk > > --- > replay/replay-event

Re: [Qemu-devel] [RFC PATCH v2 09/26] replay: save prior value of the host clock

2017-11-14 Thread Paolo Bonzini
On 14/11/2017 09:17, Pavel Dovgalyuk wrote: > This patch adds saving/restoring of the host clock field 'last'. > It is used in host clock calculation and therefore clock may > become incorrect when using restored vmstate. > > Signed-off-by: Pavel Dovgalyuk > > --- > include/qemu/timer.h |

Re: [Qemu-devel] [RFC PATCH v2 07/26] replay: added replay log format description

2017-11-14 Thread Paolo Bonzini
On 14/11/2017 09:17, Pavel Dovgalyuk wrote: > From: Pavel Dovgalyuk > > This patch adds description of the replay log file format > into the docs/replay.txt. > > Signed-off-by: Pavel Dovgalyuk > > --- > docs/replay.txt | 69 > +++ > 1 fil

Re: [Qemu-devel] [RFC PATCH v2 04/26] replay: fix processing async events

2017-11-14 Thread Paolo Bonzini
On 14/11/2017 09:16, Pavel Dovgalyuk wrote: > Asynchronous events saved at checkpoints may invoke > callbacks when processed. These callbacks may also generate/read > new events (e.g. clock reads). Therefore event processing flag must be > reset before callback invocation. > > Signed-off-by: Pavel

Re: [Qemu-devel] ppce500 usb-ehci-pci issue on last uboot

2017-11-14 Thread Gerd Hoffmann
> >How can this be reproduced? > > or just download my last e500 uboot build from here > https://www.dropbox.com/s/xxlu6ivg3izlqvu/u-boot?dl=0 > > qemu-system-ppc64 -M ppce500 -cpu e5500 -m 512 -bios (path to the uboot > image) -device usb-ehci (or another qemulated ehci pci device) -serial st

Re: [Qemu-devel] using "qemu-img convert -O qcow2" to convert qcow v1 to v2 creates a qcow v3 file?

2017-11-14 Thread Max Reitz
On 2017-11-13 19:08, Eric Blake wrote: > On 11/13/2017 11:58 AM, Eric Blake wrote: > qemu-system-aarch64: -drive if=none,file=hda.qcow2,format=qcow,id=hd: Unsupported qcow version 3 >>> >>> ah, this means it wants "format=qcow2". >> >> Oh, I should have read this followup before writing

<    1   2   3   4   >