Re: [Qemu-devel] [PATCH 2/2] pc-bios/s390-ccw: zero out bss section

2017-11-22 Thread Richard Henderson
On 11/22/2017 03:26 PM, Christian Borntraeger wrote: > The QEMU ELF loader does not zero the bss segment. > This resulted in several bugs, e.g. see > > commit 5d739a4787a5 (s390-ccw.img: Fix sporadic errors with ccw boot image - > initialize css) > commit 6a40fa2669d3 (s390-ccw.img: Initialize

Re: [Qemu-devel] [PATCH 00/17] iotests: Fix iotests for weird formats/options

2017-11-22 Thread Fam Zheng
On Thu, 11/23 03:08, Max Reitz wrote: > (I hate to write Python tests because the boilerplate seems so large and > the debugging is so hard. But there is test 194 which shows that it is > possible to write simple bash-like tests as well--and that is how I > should probably write tests from now

[Qemu-devel] [PATCH v2] rcu: reduce more than 7MB heap memory by malloc_trim()

2017-11-22 Thread Yang Zhong
Since there are some issues in memory alloc/free machenism in glibc for little chunk memory, if Qemu frequently alloc/free little chunk memory, the glibc doesn't alloc little chunk memory from free list of glibc and still allocate from OS, which make the heap size bigger and bigger. This patch

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.11.0-rc2 is now available

2017-11-22 Thread Fam Zheng
On Wed, 11/22 21:43, Jeff Cody wrote: > On Thu, Nov 23, 2017 at 08:47:47AM +0800, Fam Zheng wrote: > > On Wed, 11/22 04:55, Jeff Cody wrote: > > > On Wed, Nov 22, 2017 at 09:09:02AM +0100, Christian Borntraeger wrote: > > > > > > > > > > > > On 11/22/2017 04:23 AM, Michael Roth wrote: > > > > >

Re: [Qemu-devel] [PATCH v7 0/5] fw_cfg: add DMA operations & etc/vmcoreinfo support

2017-11-22 Thread Michael S. Tsirkin
On Mon, Nov 20, 2017 at 10:55:14AM +0100, Marc-André Lureau wrote: > Hi, > > This series adds DMA operations support to the qemu fw_cfg kernel > module and populates "etc/vmcoreinfo" with vmcoreinfo location > details. > > Note: the support for this entry handling has been merged for upcoming >

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-11-22 Thread Xiao Guangrong
On 11/22/2017 02:19 AM, Rik van Riel wrote: We can go with the "best" interface for what could be a relatively slow flush (fsync on a file on ssd/disk on the host), which requires that the flushing task wait on completion asynchronously. I'd like to clarify the interface of "wait on

[Qemu-devel] [PATCH for 2.11] virtio-net: don't touch virtqueue if vm is stopped

2017-11-22 Thread Jason Wang
Guest state should not be touched if VM is stopped, unfortunately we didn't check running state and tried to drain tx queue unconditionally in virtio_net_set_status(). A crash was then noticed as a migration destination when user type quit after virtqueue state is loaded but before region cache is

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Fix qemu crash when using scsi-block

2017-11-22 Thread Deepa Srinivasan
I agree that passing in QEMUIOVector to blk_aio_ioctl() as a holder of the void* buffer used in blk_aio_ioctl_entry() is unnecessary. But, as Kevin noted, read and write were using the QEMUIOVector in BlkRwCo. To avoid changes to the callers of blk_aio_ioctl(), I’ll change blk_aio_prwv() to

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.11.0-rc2 is now available

2017-11-22 Thread Jeff Cody
On Thu, Nov 23, 2017 at 08:47:47AM +0800, Fam Zheng wrote: > On Wed, 11/22 04:55, Jeff Cody wrote: > > On Wed, Nov 22, 2017 at 09:09:02AM +0100, Christian Borntraeger wrote: > > > > > > > > > On 11/22/2017 04:23 AM, Michael Roth wrote: > > > > Quoting Christian Borntraeger (2017-11-21 15:38:32)

[Qemu-devel] [PATCH 16/17] iotests: Make 191 work with qcow2 options

2017-11-22 Thread Max Reitz
In order for 191 to work with an explicit refcount_bits or compat=0.10, we should strip format-specific information from the output--and we can do so by using _filter_img_info. Signed-off-by: Max Reitz --- tests/qemu-iotests/191 | 5 +- tests/qemu-iotests/191.out | 313

Re: [Qemu-devel] [PATCH 00/17] iotests: Fix iotests for weird formats/options

2017-11-22 Thread Max Reitz
On 2017-11-23 03:08, Max Reitz wrote: > This series fixes the qemu-iotests for qcow, vmdk, qcow2 v2 and qcow2 v3 > with refcount_bits=1. (By the way, excuse me for calling vmdk a weird format. That was supposed to be a joke. (I know explaining a joke makes it unfunny, but I now feel a bit bad

[Qemu-devel] [PATCH 15/17] iotests: Make 184 image-less

2017-11-22 Thread Max Reitz
184 does not need an image, so don't use one. Signed-off-by: Max Reitz --- tests/qemu-iotests/184 | 25 -- tests/qemu-iotests/184.out | 63 +++--- 2 files changed, 14 insertions(+), 74 deletions(-) diff --git

[Qemu-devel] [PATCH 14/17] iotests: Make 089 compatible with compat=0.10

2017-11-22 Thread Max Reitz
The only thing that is missing is a _filter_img_info after the "$QEMU_IO -c info" invocations. Signed-off-by: Max Reitz --- tests/qemu-iotests/089 | 4 ++-- tests/qemu-iotests/089.out | 10 -- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git

[Qemu-devel] [PATCH 12/17] iotests: Fix 059's reference output

2017-11-22 Thread Max Reitz
As of commit 9877860e7bd1e26ee70ab9bb5ebc34c92bf23bf5, vmdk fails differently when opening the sample image. Signed-off-by: Max Reitz --- tests/qemu-iotests/059.out | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/059.out

[Qemu-devel] [PATCH 13/17] iotests: Fix 067 for compat=0.10

2017-11-22 Thread Max Reitz
067 works very well with compat=0.10 once you remove format-specific information from the QMP output. Signed-off-by: Max Reitz --- tests/qemu-iotests/067 | 3 +- tests/qemu-iotests/067.out | 97 +- 2 files changed, 28

[Qemu-devel] [PATCH 08/17] iotests: Skip 103 for refcount_bits=1

2017-11-22 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/103 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qemu-iotests/103 b/tests/qemu-iotests/103 index ecbd8ebd71..d0cfab8844 100755 --- a/tests/qemu-iotests/103 +++ b/tests/qemu-iotests/103 @@ -40,6 +40,8 @@ trap

[Qemu-devel] [PATCH 17/17] iotests: Filter compat-dependent info in 198

2017-11-22 Thread Max Reitz
There is a bit of image-specific information which depends on the qcow2 compat level. Filter it so that 198 works with compat=0.10 (and any refcount_bits value). Note that we cannot simply drop the --format-specific switch because we do need the "encrypt" information. Signed-off-by: Max Reitz

[Qemu-devel] [PATCH 06/17] iotests: Drop format-specific in _filter_img_info

2017-11-22 Thread Max Reitz
_filter_img_info should remove format-specific information, too. We already have such a filter in _img_info, and it is very useful for query-block-named-block-nodes (etc.), too. However, in 198 we need that information (but we still want the rest of the filter), so make that filtering optional.

[Qemu-devel] [PATCH 11/17] iotests: Fix 051 for compat=0.10

2017-11-22 Thread Max Reitz
051 has both compat=1.1 and compat=0.10 tests (once it uses lazy_refcounts, once it tests that setting them does not work). For the compat=0.10 tests, it already explicitly creates a suitable image. So let's just ignore the user-specified compat level for the lazy_refcounts test and explicitly

[Qemu-devel] [PATCH 05/17] iotests: Fix _img_info for backslashes

2017-11-22 Thread Max Reitz
read without -r eats backslashes. Signed-off-by: Max Reitz --- tests/qemu-iotests/common.rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc index dbae7d74ba..6fa0495e10 100644 ---

[Qemu-devel] [PATCH 04/17] block/vmdk: Add blkdebug events

2017-11-22 Thread Max Reitz
This is certainly not complete, but it includes at least write_aio and read_aio. Signed-off-by: Max Reitz --- block/vmdk.c | 16 1 file changed, 16 insertions(+) diff --git a/block/vmdk.c b/block/vmdk.c index 1ae47b1c2e..d71cec4f31 100644 --- a/block/vmdk.c

[Qemu-devel] [PATCH 10/17] iotests: Fix 020 for vmdk

2017-11-22 Thread Max Reitz
vmdk cannot work with anything but vmdk backing files, so make the backing file be the same format as the overlay. Reported-by: John Snow Signed-off-by: Max Reitz --- tests/qemu-iotests/020 | 9 ++--- tests/qemu-iotests/020.out | 6 -- 2 files

[Qemu-devel] [PATCH 09/17] iotests: Disable some tests for compat=0.10

2017-11-22 Thread Max Reitz
Tests 080, 130, 137, and 176 simply do not work with compat=0.10 for the reasons stated there. 177 is a bit more interesting: Originally, it was actually very much intended to work with compat=0.10 (it even had a special case for that). However, it now prints the test image's map twice, and

[Qemu-devel] [PATCH 03/17] block/qcow: Add blkdebug events

2017-11-22 Thread Max Reitz
This is not necessarily complete, but it should include the most important places. Signed-off-by: Max Reitz --- block/qcow.c | 16 1 file changed, 16 insertions(+) diff --git a/block/qcow.c b/block/qcow.c index 9569deeaf0..d552a6eba8 100644 ---

[Qemu-devel] [PATCH 07/17] iotests: Forbid 020 for non-file protocols

2017-11-22 Thread Max Reitz
This test does funny things like TEST_IMG="TEST_IMG.base" _make_test_img that usually only work with the file protocol. More specifically, they do not work with the most interesting non-file protocols, so we might as well skip this for anything but file. Signed-off-by: Max Reitz

[Qemu-devel] [PATCH 02/17] qcow2: No persistent dirty bitmaps for compat=0.10

2017-11-22 Thread Max Reitz
Persistent dirty bitmaps require a properly functioning autoclear_features field, or we cannot track when an unsupporting program might overwrite them. Therefore, we cannot support them for compat=0.10 images. Signed-off-by: Max Reitz --- block/qcow2-bitmap.c | 10 ++

[Qemu-devel] [PATCH 00/17] iotests: Fix iotests for weird formats/options

2017-11-22 Thread Max Reitz
This series fixes the qemu-iotests for qcow, vmdk, qcow2 v2 and qcow2 v3 with refcount_bits=1. Patches 1 and 2 contain real fixes (not urgent, though, so no need to hurry for 2.11--we can take them into 2.11 if we want to, but there is no absolute need for them). Patches 3 and 4 add blkdebug

[Qemu-devel] [PATCH 01/17] block/vmdk: Fix , instead of ; at end of line

2017-11-22 Thread Max Reitz
Signed-off-by: Max Reitz --- block/vmdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vmdk.c b/block/vmdk.c index c665bcc977..1ae47b1c2e 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1398,7 +1398,7 @@ static int vmdk_write_extent(VmdkExtent

Re: [Qemu-devel] [PATCH] Add a blog post about HAXM acceleration on Windows

2017-11-22 Thread Yu Ning
On 11/23/2017 1:03, Thomas Huth wrote: On 22.11.2017 15:52, Yu Ning wrote: On 11/22/2017 20:25, Thomas Huth wrote: [...] Would it be OK to remove the qemu-debian-wheezy-gui-with-haxm.png from the blog post? Yes, I'm fine with removing it.  Sorry I haven't installed Jekyll and didn't test

Re: [Qemu-devel] [PATCH qemu] vfio/spapr: Allow fallback to SPAPR TCE IOMMU v1

2017-11-22 Thread Alexey Kardashevskiy
On 23/11/17 00:39, David Gibson wrote: > On Wed, Nov 22, 2017 at 04:15:52PM +1100, Alexey Kardashevskiy wrote: >> The vfio_iommu_spapr_tce driver always advertises v1 and v2 IOMMU support, >> however PR KVM (a special version of KVM designed to work in >> a paravirtualized system; these days used

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.11.0-rc2 is now available

2017-11-22 Thread Fam Zheng
On Wed, 11/22 04:55, Jeff Cody wrote: > On Wed, Nov 22, 2017 at 09:09:02AM +0100, Christian Borntraeger wrote: > > > > > > On 11/22/2017 04:23 AM, Michael Roth wrote: > > > Quoting Christian Borntraeger (2017-11-21 15:38:32) > > >> forgot to cc qemu-devel > > >> > > >> On 11/21/2017 10:37

Re: [Qemu-devel] [PATCH v7 11/13] xilinx_spips: Don't set TX FIFO UNDERFLOW at cmd done

2017-11-22 Thread Alistair Francis
On Thu, Nov 2, 2017 at 5:01 PM, Francisco Iglesias wrote: > Don't set TX FIFO UNDERFLOW interrupt after done transmiting the commands. after transmitting the commands > Also update interrupts after reading out the interrupt status. > > Signed-off-by: Francisco

Re: [Qemu-devel] [PATCH v7 10/13] xilinx_spips: Add support for 4 byte addresses in the LQSPI

2017-11-22 Thread Alistair Francis
On Thu, Nov 2, 2017 at 5:01 PM, Francisco Iglesias wrote: > Add support for 4 byte addresses in the LQSPI and correct LQSPI_CFG_SEP_BUS. > > Signed-off-by: Francisco Iglesias Reviewed-by: Alistair Francis

Re: [Qemu-devel] [PATCH v7 06/13] xilinx_spips: Update striping to be big-endian bit order

2017-11-22 Thread Alistair Francis
On Thu, Nov 2, 2017 at 5:01 PM, Francisco Iglesias wrote: > Update striping functionality to be big-endian bit order (as according to > the Zynq-7000 Technical Reference Manual). Output thereafter the even bits > into the flash memory connected to the lower QSPI bus and

Re: [Qemu-devel] [PATCH v7 05/13] xilinx_spips: Move FlashCMD, XilinxQSPIPS and XilinxSPIPSClass

2017-11-22 Thread Alistair Francis
On Thu, Nov 2, 2017 at 5:01 PM, Francisco Iglesias wrote: > Move the FlashCMD enum, XilinxQSPIPS and XilinxSPIPSClass structures to the > header for consistency (struct XilinxSPIPS is found there). Also move out > a define and remove two dubbel included headers (while

Re: [Qemu-devel] [PATCH v7 00/13] Add support for the ZynqMP Generic QSPI

2017-11-22 Thread Alistair Francis
On Tue, Nov 21, 2017 at 10:39 AM, Peter Maydell wrote: > On 3 November 2017 at 00:00, Francisco Iglesias > wrote: >> Hi, >> >> This patch series is an attempt to add support for the ZynqMP QSPI >> (consisting >> of the Generic QSPI and the

Re: [Qemu-devel] [PATCH 3/5] nbd/server: add helper nbd_opt_invalid

2017-11-22 Thread Eric Blake
On 11/22/2017 04:19 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 74 > +--- > 1 file changed, 46 insertions(+), 28 deletions(-) > > @@ -418,8

Re: [Qemu-devel] [PATCH qemu] vfio/spapr: Allow fallback to SPAPR TCE IOMMU v1

2017-11-22 Thread David Gibson
On Wed, Nov 22, 2017 at 04:15:52PM +1100, Alexey Kardashevskiy wrote: > The vfio_iommu_spapr_tce driver always advertises v1 and v2 IOMMU support, > however PR KVM (a special version of KVM designed to work in > a paravirtualized system; these days used for nested virtualizaion) only > supports

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-22 Thread Emilio G. Cota
On Wed, Nov 22, 2017 at 09:32:04 -0300, Philippe Mathieu-Daudé wrote: > On 11/22/2017 05:41 AM, Juan Quintela wrote: > > This commit started use tb_unlock() and tlb_set_dirty() on non TCG > > code. Add the function as stubs. > > > > commit 27266271977c5a30f2f7d493e042be1897827bdd > > Author:

[Qemu-devel] [PATCH v3 7/7] s390x/pci: search for subregion inside the BARs

2017-11-22 Thread Pierre Morel
When dispatching memory access to PCI BAR region, we must look for possible subregions, used by the PCI device to map different memory areas inside the same PCI BAR. Since the data offset we received is calculated starting at the region start address we need to adjust the offset for the

[Qemu-devel] [PATCH v3 6/7] s390x/pci: move the memory region write from pcistg

2017-11-22 Thread Pierre Morel
Let's move the memory region write from pcistg into a dedicated function. This allows us to prepare a later patch searching for subregions inside of the memory region. Signed-off-by: Pierre Morel Reviewed-by: Yi Min Zhao ---

[Qemu-devel] [PATCH v3 2/7] s390x/pci: rework PCI STORE

2017-11-22 Thread Pierre Morel
Enhance the fault detection, correction of the fault reporting. Signed-off-by: Pierre Morel Reviewed-by: Yi Min Zhao --- hw/s390x/s390-pci-inst.c | 39 ++- 1 file changed, 22 insertions(+), 17

[Qemu-devel] [PATCH v3 1/7] s390x/pci: factor out endianess conversion

2017-11-22 Thread Pierre Morel
There are two places where the same endianness conversion is done. Let's factor this out into a static function. Signed-off-by: Pierre Morel Reviewed-by: Yi Min Zhao --- hw/s390x/s390-pci-inst.c | 59

[Qemu-devel] [PATCH v3 5/7] s390x/pci: move the memory region read from pcilg

2017-11-22 Thread Pierre Morel
Let's move the memory region read from pcilg into a dedicated function. This allows us to prepare a later patch. Signed-off-by: Pierre Morel Reviewed-by: Yi Min Zhao --- hw/s390x/s390-pci-inst.c | 15 +++ 1 file changed, 11

[Qemu-devel] [PATCH v3 0/7] s390x/pci: Improve zPCI to cover more cases

2017-11-22 Thread Pierre Morel
This patch fixes the following BUG: Even a guest is able to detect virtio_pci device, the init function the Linux virtio_pci driver will hang because zPCI does not support the subregions used by virtio_pci. It follows that right now the PCI support is very limited (e.g. pass through of a host

[Qemu-devel] [PATCH v3 4/7] s390x/pci: rework PCI STORE BLOCK

2017-11-22 Thread Pierre Morel
Enhance the fault detection. Fixup the precedence to check the destination path existance before checking for the source accessibility. Add the maxstbl entry to both the Query PCI Function Group response and the PCIBusDevice structure. Initialize the maxstbl to 128 per default until we get the

[Qemu-devel] [PATCH v3 3/7] s390x/pci: rework PCI LOAD

2017-11-22 Thread Pierre Morel
Enhance the fault detection, correction of the fault reporting. Signed-off-by: Pierre Morel Reviewed-by: Yi Min Zhao --- hw/s390x/s390-pci-inst.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 5/5] nbd/server: structurize option reply sending

2017-11-22 Thread Eric Blake
On 11/22/2017 04:19 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 40 +--- > 1 file changed, 13 insertions(+), 27 deletions(-) > Nice diffstat; shows that this one

Re: [Qemu-devel] [PATCH 3/5] nbd/server: add helper nbd_opt_invalid

2017-11-22 Thread Eric Blake
On 11/22/2017 04:19 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 74 > +--- > 1 file changed, 46 insertions(+), 28 deletions(-) > > +/*

Re: [Qemu-devel] [PATCH 4/5] nbd: rename nbd_option and nbd_opt_reply

2017-11-22 Thread Eric Blake
On 11/22/2017 04:19 AM, Vladimir Sementsov-Ogievskiy wrote: > Rename nbd_optino and nbd_opt_reply to NBDOption and NBDOptionReply s/optino/option/ > to correspond to Qemu coding style and other structures here. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- >

Re: [Qemu-devel] [PATCH v2 2/7] s390x/pci: rework PCI STORE

2017-11-22 Thread Pierre Morel
On 22/11/2017 14:25, Cornelia Huck wrote: On Tue, 21 Nov 2017 19:03:17 +0100 Pierre Morel wrote: On 21/11/2017 15:25, Cornelia Huck wrote: On Tue, 21 Nov 2017 11:38:45 +0100 Cornelia Huck wrote: On Thu, 16 Nov 2017 18:51:50 +0100 Pierre

Re: [Qemu-devel] [PATCH v3 29/30] i.MX: Add i.MX7 SOC implementation.

2017-11-22 Thread Andrey Smirnov
On Wed, Nov 22, 2017 at 7:34 AM, Igor Mammedov wrote: > On Mon, 6 Nov 2017 07:48:12 -0800 > Andrey Smirnov wrote: > >> The following interfaces are partially or fully emulated: >> >> * up to 2 Cortex A9 cores (SMP works with PSCI) >> * A7

Re: [Qemu-devel] [PATCH v3 19/30] i.MX: Add code to emulate SDMA IP block

2017-11-22 Thread Andrey Smirnov
On Tue, Nov 21, 2017 at 10:20 AM, Peter Maydell wrote: > On 6 November 2017 at 15:48, Andrey Smirnov wrote: >> Add minimal code needed to allow upstream Linux guest to boot. >> >> Cc: Peter Maydell >> Cc: Jason Wang

Re: [Qemu-devel] [PATCH v3 14/30] i.MX: Add code to emulate i.MX2 watchdog IP block

2017-11-22 Thread Andrey Smirnov
On Tue, Nov 21, 2017 at 10:10 AM, Peter Maydell wrote: > On 6 November 2017 at 15:47, Andrey Smirnov wrote: >> Add enough code to emulate i.MX2 watchdog IP block so it would be >> possible to reboot the machine running Linux Guest. >> >> Cc:

Re: [Qemu-devel] [PATCH v3 13/30] i.MX: Add code to emulate i.MX7 CCM, PMU and ANALOG IP blocks

2017-11-22 Thread Andrey Smirnov
On Tue, Nov 21, 2017 at 10:08 AM, Peter Maydell wrote: > On 6 November 2017 at 15:47, Andrey Smirnov wrote: >> Add minimal code needed to allow upstream Linux guest to boot. >> >> Cc: Peter Maydell >> Cc: Jason Wang

Re: [Qemu-devel] [PATCH] kvm: apic: save and restore x2APIC LDR

2017-11-22 Thread Radim Krčmář
2017-11-22 18:28-0200, Eduardo Habkost: > On Wed, Nov 22, 2017 at 07:09:08PM +0100, Radim Krčmář wrote: > > QEMU saves only 8 bits of APIC LDR, which means that it does not support > > x2APIC. The correct way of fixing this would be to save and restore the > > full 32 bit register, but because

Re: [Qemu-devel] [PATCH] kvm: apic: save and restore x2APIC LDR

2017-11-22 Thread Radim Krčmář
2017-11-22 20:26+0100, Paolo Bonzini: > On 22/11/2017 19:09, Radim Krčmář wrote: > > QEMU saves only 8 bits of APIC LDR, which means that it does not support > > x2APIC. The correct way of fixing this would be to save and restore the > > full 32 bit register, but because x2APIC LDR is a function

Re: [Qemu-devel] [PATCH v3 12/30] sdhci: Implement write method of ACMD12ERRSTS register

2017-11-22 Thread Andrey Smirnov
On Tue, Nov 21, 2017 at 10:04 AM, Peter Maydell wrote: > On 6 November 2017 at 15:47, Andrey Smirnov wrote: >> Cc: Peter Maydell >> Cc: Jason Wang >> Cc: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH v3 11/30] sdhci: Add i.MX specific subtype of SDHCI

2017-11-22 Thread Andrey Smirnov
On Tue, Nov 21, 2017 at 10:02 AM, Peter Maydell wrote: > On 6 November 2017 at 15:47, Andrey Smirnov wrote: >> IP block found on several generations of i.MX family does not use >> vanilla SDHCI implementation and it comes with a number of

Re: [Qemu-devel] [PATCH v2 4/7] s390x/pci: rework PCI STORE BLOCK

2017-11-22 Thread Pierre Morel
On 22/11/2017 14:28, Cornelia Huck wrote: On Wed, 22 Nov 2017 13:15:21 +0800 Yi Min Zhao wrote: 在 2017/11/22 上午2:07, Pierre Morel 写道: On 21/11/2017 11:42, Cornelia Huck wrote: On Thu, 16 Nov 2017 18:51:52 +0100 Pierre Morel wrote:

Re: [Qemu-devel] [PATCH v3 10/30] imx_fec: Reserve full 4K page for the register file

2017-11-22 Thread Andrey Smirnov
On Tue, Nov 21, 2017 at 9:48 AM, Peter Maydell wrote: > On 6 November 2017 at 15:47, Andrey Smirnov wrote: >> Some i.MX SoCs (e.g. i.MX7) have FEC registers going as far as offset >> 0x614, so to avoid getting aborts when accessing those on

Re: [Qemu-devel] [PATCH] kvm: apic: save and restore x2APIC LDR

2017-11-22 Thread Eduardo Habkost
On Wed, Nov 22, 2017 at 07:09:08PM +0100, Radim Krčmář wrote: > QEMU saves only 8 bits of APIC LDR, which means that it does not support > x2APIC. The correct way of fixing this would be to save and restore the > full 32 bit register, but because x2APIC LDR is a function of x2APIC ID, > we can

Re: [Qemu-devel] [PATCH v3 07/30] imx_fec: Add support for multiple Tx DMA rings

2017-11-22 Thread Andrey Smirnov
On Tue, Nov 21, 2017 at 9:44 AM, Peter Maydell wrote: > On 6 November 2017 at 15:47, Andrey Smirnov wrote: >> More recent version of the IP block support more than one Tx DMA ring, >> so add the code implementing that feature. >> >> Cc: Peter

Re: [Qemu-devel] [PATCH v3 03/30] imx_fec: Change queue flushing heuristics

2017-11-22 Thread Andrey Smirnov
On Tue, Nov 21, 2017 at 9:27 AM, Peter Maydell wrote: > On 6 November 2017 at 15:47, Andrey Smirnov wrote: >> In current implementation, packet queue flushing logic seem to suffer >> from a deadlock like scenario if a packet is received by the

Re: [Qemu-devel] [PATCH v3 04/30] imx_fec: Use ENET_FTRL to determine truncation length

2017-11-22 Thread Andrey Smirnov
On Tue, Nov 21, 2017 at 9:31 AM, Peter Maydell wrote: > On 6 November 2017 at 15:47, Andrey Smirnov wrote: >> Frame truncation length, TRUNC_FL, is determined by the contents of >> ENET_FTRL register, so convert the code to use it instead of a

Re: [Qemu-devel] [PATCH v3 00/30] Initial i.MX7 support

2017-11-22 Thread Andrey Smirnov
On Tue, Nov 21, 2017 at 10:34 AM, Peter Maydell wrote: > On 6 November 2017 at 15:47, Andrey Smirnov wrote: >> Hi everyone, >> - Added proper USB emulation code, so now it should be possible to >> emulated guest's USB bus > > The

Re: [Qemu-devel] [PATCH 2/5] nbd/server: add nbd_opt_{read, drop} to track client->optlen

2017-11-22 Thread Eric Blake
On 11/22/2017 04:19 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 34 ++ > 1 file changed, 22 insertions(+), 12 deletions(-) > Hmm, revisiting my idea about moving more of

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

2017-11-22 Thread Dr. David Alan Gilbert
* Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote: > Hello, > > Am 22.11.2017 um 20:41 schrieb Dr. David Alan Gilbert: > > * Paolo Bonzini (pbonz...@redhat.com) wrote: > >> On 06/11/2017 12:09, Stefan Priebe - Profihost AG wrote: > >>> HI Paolo, > >>> > >>> could this patchset be

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

2017-11-22 Thread Stefan Priebe - Profihost AG
Hello, Am 22.11.2017 um 20:41 schrieb Dr. David Alan Gilbert: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> On 06/11/2017 12:09, Stefan Priebe - Profihost AG wrote: >>> HI Paolo, >>> >>> could this patchset be related? >> >> Uh oh, yes it should. Jason, any ways to fix it? I suppose we need

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

2017-11-22 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 06/11/2017 12:09, Stefan Priebe - Profihost AG wrote: > > HI Paolo, > > > > could this patchset be related? > > Uh oh, yes it should. Jason, any ways to fix it? I suppose we need to > disable UFO in the newest machine types, but do we also have

Re: [Qemu-devel] [PATCH] kvm: apic: save and restore x2APIC LDR

2017-11-22 Thread Paolo Bonzini
On 22/11/2017 19:09, Radim Krčmář wrote: > QEMU saves only 8 bits of APIC LDR, which means that it does not support > x2APIC. The correct way of fixing this would be to save and restore the > full 32 bit register, but because x2APIC LDR is a function of x2APIC ID, > we can also compute it and

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Fix qemu crash when using scsi-block

2017-11-22 Thread Paolo Bonzini
On 22/11/2017 19:06, Kevin Wolf wrote: > Am 22.11.2017 um 17:34 hat Paolo Bonzini geschrieben: >> On 22/11/2017 16:33, Deepa Srinivasan wrote: >>> Starting qemu with the following arguments causes qemu to segfault: >>> ... -device lsi,id=lsi0 -drive >>>

Re: [Qemu-devel] [PATCH v3 30/30] Implement support for i.MX7 Sabre board

2017-11-22 Thread Andrey Smirnov
On Tue, Nov 21, 2017 at 10:22 AM, Peter Maydell wrote: > On 6 November 2017 at 15:48, Andrey Smirnov wrote: >> Implement code needed to set up emulation of MCIMX7SABRE board from >> NXP. For more info about the HW see: >> >>

Re: [Qemu-devel] [PATCH 2/5] nbd/server: add nbd_opt_{read, drop} to track client->optlen

2017-11-22 Thread Eric Blake
On 11/22/2017 04:19 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 34 ++ > 1 file changed, 22 insertions(+), 12 deletions(-) > @@ -299,7 +312,7 @@ static int

Re: [Qemu-devel] [PATCH for-2.12 v3 1/3] spapr/rtas: disable the decrementer interrupt when a CPU is unplugged

2017-11-22 Thread Cédric Le Goater
On 11/22/2017 03:33 AM, David Gibson wrote: > On Mon, Nov 20, 2017 at 11:03:45AM +0100, Cédric Le Goater wrote: >> When a CPU is stopped with the 'stop-self' RTAS call, its state >> 'halted' is switched to 1 and, in this case, the MSR is not taken into >> account anymore in the cpu_has_work()

Re: [Qemu-devel] qemu iotest 020 failing for vmdk after 2b7731938d9

2017-11-22 Thread Max Reitz
On 2017-11-21 23:16, John Snow wrote: > Commit 2b7731938d9 adds a blkdebug driver test for failing commits, but > the vmdk driver doesn't appear to appreciate this format: > > +_qemu_img_wrapper create -f vmdk -b "json:{'driver': 'raw', > + 'file': { > +

[Qemu-devel] [PATCH 3/3] hyperv: make SynIC version msr constant

2017-11-22 Thread Roman Kagan
The value of HV_X64_MSR_SVERSION is initialized once at vcpu init, and is reset to zero on vcpu reset, which is wrong. It is supposed to be a constant, so drop the field from X86CPU, set the msr with the constant value, and don't bother getting it. Signed-off-by: Roman Kagan

[Qemu-devel] [PATCH 1/3] hyperv: set partition-wide MSRs only on first vcpu

2017-11-22 Thread Roman Kagan
From: Evgeny Yakovlev Hyper-V has a notion of partition-wide MSRs. Those MSRs are read and written as usual on each VCPU, however the hypervisor maintains a single global value for all VCPUs. Thus writing such an MSR from any single VCPU affects the global value that

[Qemu-devel] [PATCH 2/3] hyperv: ensure SINTx msrs are reset properly

2017-11-22 Thread Roman Kagan
Initially SINTx msrs should be in "masked" state. To ensure that happens on *every* reset, move setting their values to kvm_arch_vcpu_reset. Signed-off-by: Roman Kagan --- target/i386/kvm.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH 0/3] hyperv: hv msr initialization fixes

2017-11-22 Thread Roman Kagan
These patches fix problems with hyperv msr initialization. Evgeny Yakovlev (1): hyperv: set partition-wide MSRs only on first vcpu Roman Kagan (2): hyperv: ensure SINTx msrs are reset properly hyperv: make SynIC version msr constant target/i386/cpu.h | 6 -- target/i386/kvm.c | 44

Re: [Qemu-devel] [RFC PATCH v2 1/3] s390x/ccs: add ccw-testdev emulated device

2017-11-22 Thread Cornelia Huck
On Wed, 8 Nov 2017 17:54:20 +0100 Halil Pasic wrote: Subject: s/ccs/css/ > Add a fake device meant for testing the correctness of our css emulation. > > What we currently have is writing a Fibonacci sequence of uint32_t to the > device via ccw write. The write is

[Qemu-devel] [PATCH] kvm: apic: save and restore x2APIC LDR

2017-11-22 Thread Radim Krčmář
QEMU saves only 8 bits of APIC LDR, which means that it does not support x2APIC. The correct way of fixing this would be to save and restore the full 32 bit register, but because x2APIC LDR is a function of x2APIC ID, we can also compute it and keep the migration format untouched. KVM always

Re: [Qemu-devel] [PATCH] block: Fix qemu crash when using scsi-block

2017-11-22 Thread Kevin Wolf
Am 22.11.2017 um 17:34 hat Paolo Bonzini geschrieben: > On 22/11/2017 16:33, Deepa Srinivasan wrote: > > Starting qemu with the following arguments causes qemu to segfault: > > ... -device lsi,id=lsi0 -drive > > file=iscsi:<...>,format=raw,if=none,node-name= > > iscsi1 -device

Re: [Qemu-devel] [PATCH] block: Fix qemu crash when using scsi-block

2017-11-22 Thread Kevin Wolf
Am 22.11.2017 um 18:06 hat Stefan Hajnoczi geschrieben: > On Wed, Nov 22, 2017 at 07:33:28AM -0800, Deepa Srinivasan wrote: > > Starting qemu with the following arguments causes qemu to segfault: > > ... -device lsi,id=lsi0 -drive > > file=iscsi:<...>,format=raw,if=none,node-name= > > iscsi1

Re: [Qemu-devel] [PATCH 01/12] e500: add board config options

2017-11-22 Thread Michael Davidsaver
On 11/21/2017 09:28 PM, David Gibson wrote: > On Sun, Nov 19, 2017 at 09:24:09PM -0600, Michael Davidsaver wrote: >> allow board code to skip common NIC and guest image setup >> and configure decrementor frequency. >> Existing boards unchanged. >> >> Signed-off-by: Michael Davidsaver

Re: [Qemu-devel] [RFC PATCH 1/1] s390x: deprecate s390-squash-mcss machine prop

2017-11-22 Thread Cornelia Huck
On Wed, 22 Nov 2017 15:18:32 +0100 Halil Pasic wrote: > With the cssids unrestricted (commit "s390x/css: unrestrict I think you can simply reference the title only. I plan to merge both in one go. > cssids") the s390-squash-mcss machine property should not be used. >

Re: [Qemu-devel] [PATCH 2/5] nbd/server: add nbd_opt_{read, drop} to track client->optlen

2017-11-22 Thread Eric Blake
On 11/22/2017 04:19 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy The subject line says what and sort of implies why, but the commit message body is rather sparse. > --- > nbd/server.c | 34 ++ >

Re: [Qemu-devel] [PATCH] block: Fix qemu crash when using scsi-block

2017-11-22 Thread Stefan Hajnoczi
On Wed, Nov 22, 2017 at 07:33:28AM -0800, Deepa Srinivasan wrote: > Starting qemu with the following arguments causes qemu to segfault: > ... -device lsi,id=lsi0 -drive file=iscsi:<...>,format=raw,if=none,node-name= > iscsi1 -device scsi-block,bus=lsi0.0,id=<...>,drive=iscsi1 > > This patch fixes

Re: [Qemu-devel] [PATCH] Add a blog post about HAXM acceleration on Windows

2017-11-22 Thread Thomas Huth
On 22.11.2017 15:52, Yu Ning wrote: > > On 11/22/2017 20:25, Thomas Huth wrote: [...] >> Would it be OK to remove the qemu-debian-wheezy-gui-with-haxm.png from >> the blog post? > > Yes, I'm fine with removing it.  Sorry I haven't installed Jekyll and > didn't test the rendering. > > Would you

[Qemu-devel] [Bug 1673976] Re: linux-user clone() can't handle glibc posix_spawn() (causes locale-gen to assert)

2017-11-22 Thread Peter Maydell
Thanks for tracking down the glibc change; I will try to set up a chroot with a more recent glibc to see whether we can do something that fixes that posix_spawn implementation... -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [qemu-web PATCH] css: avoid over-large images

2017-11-22 Thread Cornelia Huck
On Wed, 22 Nov 2017 17:48:28 +0100 Christian Borntraeger wrote: > On 11/22/2017 05:37 PM, Paolo Bonzini wrote: > > Make sure that images are scaled to fit inside their container. > > Thanks God. I was thinking "what is wrong with the channel subsystem in > QEMU?" when

Re: [Qemu-devel] [qemu-web PATCH] css: avoid over-large images

2017-11-22 Thread Christian Borntraeger
On 11/22/2017 05:37 PM, Paolo Bonzini wrote: > Make sure that images are scaled to fit inside their container. Thanks God. I was thinking "what is wrong with the channel subsystem in QEMU?" when reading your subject. > Tested-by: Thomas Huth > Reviewed-by: Thomas Huth

Re: [Qemu-devel] [PATCH 08/12] e500: add mpc8540 i2c controller to ccsr

2017-11-22 Thread Michael Davidsaver
On 11/21/2017 10:08 PM, David Gibson wrote: > On Sun, Nov 19, 2017 at 09:24:16PM -0600, Michael Davidsaver wrote: >> Signed-off-by: Michael Davidsaver > > You're adding what seems to be a fairly specific device to the general > e500 init - this again suggests that it

Re: [Qemu-devel] [PATCH 1/5] nbd/server: refactor negotiation functions parameters

2017-11-22 Thread Eric Blake
On 11/22/2017 04:19 AM, Vladimir Sementsov-Ogievskiy wrote: > Instead of passing currently negotiating option and its length to > many of negotiation functions let's just store them on NBDClient > struct to be state-variables of negotiation phase. > > This unifies semantics of negotiation

Re: [Qemu-devel] [PATCH] Add a blog post about HAXM acceleration on Windows

2017-11-22 Thread Paolo Bonzini
On 22/11/2017 16:37, Thomas Huth wrote: > On 22.11.2017 15:42, Paolo Bonzini wrote: >> On 22/11/2017 13:25, Thomas Huth wrote: >>> diff --git a/assets/css/skel-noscript.css b/assets/css/skel-noscript.css >>> index e0a141e..f574b9f 100644 >>> --- a/assets/css/skel-noscript.css >>> +++

[Qemu-devel] [qemu-web PATCH] css: avoid over-large images

2017-11-22 Thread Paolo Bonzini
Make sure that images are scaled to fit inside their container. Tested-by: Thomas Huth Reviewed-by: Thomas Huth Signed-off-by: Paolo Bonzini --- assets/css/style.css | 4 1 file changed, 4 insertions(+) diff --git

Re: [Qemu-devel] [PATCH 2/2] pc-bios/s390-ccw: zero out bss section

2017-11-22 Thread Thomas Huth
On 22.11.2017 15:26, Christian Borntraeger wrote: > The QEMU ELF loader does not zero the bss segment. > This resulted in several bugs, e.g. see > > commit 5d739a4787a5 (s390-ccw.img: Fix sporadic errors with ccw boot image - > initialize css) > commit 6a40fa2669d3 (s390-ccw.img: Initialize

Re: [Qemu-devel] [PATCH] block: Fix qemu crash when using scsi-block

2017-11-22 Thread Paolo Bonzini
On 22/11/2017 16:33, Deepa Srinivasan wrote: > Starting qemu with the following arguments causes qemu to segfault: > ... -device lsi,id=lsi0 -drive file=iscsi:<...>,format=raw,if=none,node-name= > iscsi1 -device scsi-block,bus=lsi0.0,id=<...>,drive=iscsi1 > > This patch fixes blk_aio_ioctl() so

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-22 Thread Cornelia Huck
On Wed, 22 Nov 2017 15:45:56 +0100 Boris Fiuczynski wrote: > On 11/22/2017 01:13 PM, Cornelia Huck wrote: > >> +object_class_property_add_bool(klass, "cssid-unrestricted", > >> + prop_get_true, NULL, NULL); > > This

Re: [Qemu-devel] [PATCH] iotests: fix 075 and 078

2017-11-22 Thread Kevin Wolf
Am 22.11.2017 um 01:16 hat John Snow geschrieben: > Both of these tests are for formats which now stipulate that they are > read-only. Adjust the tests to match. > > Signed-off-by: John Snow Oh, right, seems I forgot about the tests... Thanks, applied to the block branch.

  1   2   >