[Qemu-devel] [RFC PATCH] vhost-user: quit infinite loop while used memslots is more than the backend limit

2017-12-12 Thread Jay Zhou
Steps to 100% reproduce: (1) start a VM with two VFIO 82599 PCI NICs successfully (2) hot plug a RAM, which is attached successfully (3) hot plug another RAM, which is attached successfully (4) hot plug a vhost-user NIC, which is attached successfully (5) hot plug another vhost-user NIC, which is h

[Qemu-devel] [Bug 1716028] Re: qemu 2.10 locks images with no feature flag

2017-12-12 Thread ChristianEhrhardt
** Changed in: libvirt (Ubuntu) Importance: Undecided => Medium -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1716028 Title: qemu 2.10 locks images with no feature flag Status in QEMU: Opinio

[Qemu-devel] [Bug 1737883] [NEW] Cannot boot FreeBSD on versatilepb machine

2017-12-12 Thread MVoloshin
Public bug reported: I know some years ago it was possible to boot FreeBSD in QEMU versatilepb machine https://kernelnomicon.org/?p=229 (you can download image and kernel using web.archive.org) Now when I try to do that I get only black screen with no output even in QEMU console. I also added -

[Qemu-devel] [Bug 1737882] [NEW] QEMU Zaurus cannot boot 2.4.x kernels

2017-12-12 Thread MVoloshin
Public bug reported: I tried akita and spitz machines. 4.x, 3.x and 2.6.x kernels boot OK, but when I try to pass any 2.4.x, qemu crashes with "Trying to execute code outside RAM or ROM at 0x0080". ** Affects: qemu Importance: Undecided Status: New ** Tags: akita kernel linux

Re: [Qemu-devel] [PATCH v2 3/4] colo: compare the packet based on the tcp sequence number

2017-12-12 Thread Mao Zhongyi
Hi, Chen On 12/12/2017 11:21 PM, Zhang Chen wrote: On Wed, Dec 6, 2017 at 5:57 PM, Mao Zhongyi mailto:maozy.f...@cn.fujitsu.com>> wrote: The primary and secondary guest has the same TCP stream, but the the packet sizes are different due to the different fragmentation. Maybe comments

Re: [Qemu-devel] [PATCH qemu] fdc: Exit if ISA controller does not support DMA

2017-12-12 Thread Hervé Poussineau
Le 08/12/2017 à 22:29, John Snow a écrit : [...] It looks like Herve was working on decoupling floppies from i8257, but perhaps didn't get all the way through -- I'm not actually clear on what work remains to be done here, maybe he can chime in if he's still interested in the project? Indeed,

Re: [Qemu-devel] [PATCH v2 2/4] colo: modified the payload compare function

2017-12-12 Thread Mao Zhongyi
On 12/12/2017 11:19 PM, Zhang Chen wrote: On Wed, Dec 6, 2017 at 5:57 PM, Mao Zhongyi mailto:maozy.f...@cn.fujitsu.com>> wrote: Modified the function colo_packet_compare_common to prepare for the tcp packet comparison in the next patch. Cc: Zhang Chen mailto:zhangc...@gmail.com>

Re: [Qemu-devel] [PATCH v2 1/4] colo: remove the incorrect if conditions in colo_compare_packet_tcp()

2017-12-12 Thread Mao Zhongyi
Hi, Chen On 12/12/2017 11:19 PM, Zhang Chen wrote: This patch should be moved behind the patch with payload comparition. Well, it is not impossible, but I think it is better to be here. Because it is the correct logic to firstly ensure that there are no missing cases by fixing the small nits i

[Qemu-devel] [PATCH 3/4] hw/registerfields: add 64-bit extract/deposit macros

2017-12-12 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/registerfields.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/include/hw/registerfields.h b/include/hw/registerfields.h index ad9d7a82a3..f59e7f47bd 100644 --- a/include/hw/registerfields.h +++ b/include/hw/registerfields.h

[Qemu-devel] [PATCH 4/4] hw/registerfields: add missing include

2017-12-12 Thread Philippe Mathieu-Daudé
This allows to use this header in qtests. This fixes: CC tests/test.o include/hw/registerfields.h:32:41: error: implicit declaration of function ‘MAKE_64BIT_MASK’ [-Werror=implicit-function-declaration] MAKE_64BIT_MASK(shift, length)}; ^ include/hw/registe

[Qemu-devel] [PATCH 1/4] MAINTAINERS: add "hw/registerfields.h" in Register API entry

2017-12-12 Thread Philippe Mathieu-Daudé
Orphan since afb3141c660 Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0255113470..7edfa25542 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1538,6 +1538,7 @@ M: Alistair Francis S: Maintained F: hw/co

[Qemu-devel] [PATCH 2/4] hw/registerfields: fix a typo in the FIELD() documentation

2017-12-12 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/registerfields.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/registerfields.h b/include/hw/registerfields.h index af101d5ae6..ad9d7a82a3 100644 --- a/include/hw/registerfields.h +++ b/include/hw/registerfields

[Qemu-devel] [PATCH 0/4] Trivial changes in "registerfields.h"

2017-12-12 Thread Philippe Mathieu-Daudé
Philippe Mathieu-Daudé (4): MAINTAINERS: add "hw/registerfields.h" in Register API entry hw/registerfields: fix a typo in the FIELD() documentation hw/registerfields: add 64-bit extract/deposit macros hw/registerfields: add missing include include/hw/registerfields.h | 15 ++-

Re: [Qemu-devel] [PATCH v12 09/12] Move related hwpoison page function to accel/kvm/ folder

2017-12-12 Thread gengdongjiu
On 2017/11/13 16:27, Paolo Bonzini wrote: > On 13/11/2017 02:45, gengdongjiu wrote: >> On 2017/11/10 19:32, Paolo Bonzini wrote: >>> On 10/11/2017 20:19, Dongjiu Geng wrote: +typedef struct HWPoisonPage { +ram_addr_t ram_addr; +QLIST_ENTRY(HWPoisonPage) list; +} HWPoison

Re: [Qemu-devel] [PATCH v1] hmp: 'info snapshots' not showing the id

2017-12-12 Thread seeteena
Hi David, While creating snapshots when tag name '0' used in the very first and followed by tag name '1' then snapshot created with tag name '0' is getting erased. A snapshot is identified by a name computed either from an id, which is basically a numerical counter starting at 1 for qcow2, or f

Re: [Qemu-devel] [PATCH qemu] kvm: Add kvm_set_user_memory tracepoint

2017-12-12 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20171213042312.8781-1-...@ozlabs.ru Subject: [Qemu-devel] [PATCH qemu] kvm: Add kvm_set_user_memory tracepoint Typ

[Qemu-devel] [PATCH qemu] kvm: Add kvm_set_user_memory tracepoint

2017-12-12 Thread Alexey Kardashevskiy
This adds a tracepoint to trace the KVM_SET_USER_MEMORY_REGION ioctl parameters which is quite useful for debugging VFIO memory regions being actually registered with KVM. Signed-off-by: Alexey Kardashevskiy --- accel/kvm/kvm-all.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-12 Thread Fam Zheng
On Mon, 11/13 19:20, Vladimir Sementsov-Ogievskiy wrote: > Hi all. > > There are three qmp commands, needed to implement external backup API. > > Using these three commands, client may do all needed bitmap management by > hand: > > on backup start we need to do a transaction: > {disable old bit

Re: [Qemu-devel] [PATCH v13 00/12] Add ARMv8 RAS virtualization support in QEMU

2017-12-12 Thread gengdongjiu
Hi Peter, On 2017/12/11 21:32, Igor Mammedov wrote: > On Mon, 11 Dec 2017 19:31:14 +0800 > gengdongjiu wrote: > >> Hi maintainer, >> >> This patch set seems pending about one month, could you help review for >> them? Thanks. > I'm going to look at ACPI side of it this week. Hi Peter/shannon

[Qemu-devel] [PATCH v7 4/4] contrib/vhost-user-blk: introduce a vhost-user-blk sample application

2017-12-12 Thread Changpeng Liu
This commit introcudes a vhost-user-blk backend device, it uses UNIX domain socket to communicate with QEMU. The vhost-user-blk sample application should be used with QEMU vhost-user-blk-pci device. To use it, complie with: make vhost-user-blk and start like this: vhost-user-blk -b /dev/sdb -s /p

[Qemu-devel] [PATCH v7 2/4] vhost-user-blk: introduce a new vhost-user-blk host device

2017-12-12 Thread Changpeng Liu
This commit introduces a new vhost-user device for block, it uses a chardev to connect with the backend, same with Qemu virito-blk device, Guest OS still uses the virtio-blk frontend driver. To use it, start QEMU with command line like this: qemu-system-x86_64 \ -chardev socket,id=char0,path=

[Qemu-devel] [PATCH v7 3/4] contrib/libvhost-user: enable virtio config space messages

2017-12-12 Thread Changpeng Liu
Enable VHOST_USER_GET_CONFIG/VHOST_USER_SET_CONFIG/VHOST_USER_SET_CONFIG_FD messages in libvhost-user library, users can implement their own I/O target based on the library. This enable the virtio config space delivered between Qemu host device and the I/O target, also event notifier is added in ca

[Qemu-devel] [PATCH v7 1/4] vhost-user: add new vhost user messages to support virtio config space

2017-12-12 Thread Changpeng Liu
Add VHOST_USER_GET_CONFIG/VHOST_USER_SET_CONFIG messages which can be used for live migration of vhost user devices, also vhost user devices can benefit from the messages to get/set virtio config space from/to the I/O target. For the purpose to support virtio config space change, VHOST_USER_SET_CON

[Qemu-devel] [PATCH v7 0/4] Introduce a new vhost-user-blk host device to QEMU

2017-12-12 Thread Changpeng Liu
Although virtio scsi specification was designed as a replacement for virtio_blk, there are still many users using virtio_blk. QEMU 2.9 introduced a new device vhost user scsi which can process I/O in user space for virtio_scsi, this commit introduces a new vhost user block host device, which can su

Re: [Qemu-devel] [PATCH 2/2] ide: fix crash in IDE cdrom read

2017-12-12 Thread John Snow
Hi Den, the long email about IDE stuff: On 11/30/2017 07:01 AM, Denis V. Lunev wrote: > On 11/29/2017 02:50 AM, John Snow wrote: >> >> On 11/28/2017 07:10 AM, Denis V. Lunev wrote: >>> There is the following crash reported from the field in QEMU 2.9: >>> bdrv_inc_in_flight (bs=bs@entry=0x0) >>

Re: [Qemu-devel] [PATCH v2] 9pfs: Correctly handle cancelled requests

2017-12-12 Thread Stefano Stabellini
On Fri, 8 Dec 2017, Greg Kurz wrote: > Cc'ing Stefano using a more appropriate address :) Thanks Greg for the ping, one comment inline below. > On Thu, 7 Dec 2017 18:04:24 +0100 > Greg Kurz wrote: > > > On Mon, 4 Dec 2017 15:36:19 -0500 > > Keno Fischer wrote: > > > > > # Background > > >

Re: [Qemu-devel] [PATCH] qcow2: get rid of qcow2_backing_read1 routine

2017-12-12 Thread Eric Blake
On 12/12/2017 08:40 AM, Edgar Kaziakhmedov wrote: > Since bdrv_co_preadv does all neccessary checks including s/neccessary/necessary/ > reading after the end of the backing file, avoid duplication > of verification before bdrv_co_preadv call. > > Signed-off-by: Edgar Kaziakhmedov > Reviewed-by:

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-12 Thread John Snow
On 12/11/2017 07:18 AM, Vladimir Sementsov-Ogievskiy wrote: > 11.12.2017 14:15, Kevin Wolf wrote: >> Am 09.12.2017 um 01:57 hat John Snow geschrieben: >>> Here's an idea of what this API might look like without revealing >>> explicit merge/split primitives. >>> >>> A new bitmap property that lets

[Qemu-devel] [PATCH v2 0/2] Add vTPM emulator supportfor ppc64 platform

2017-12-12 Thread Stefan Berger
The following series of patches adds vTPM emulator support for the ppc64 platform (pSeries). It can be tested as follows with swtpm/libtpms: #> swtpm socket --tpmstate dir=/tmp/mytpm1 \ --ctrl type=unixio,path=/tmp/mytpm1/ctrl.sock \ --log level=2 If TPM 2 is desired, add --tpm2

[Qemu-devel] [PATCH v2 2/2] tpm_spapr: Support suspend and resume

2017-12-12 Thread Stefan Berger
Signed-off-by: Stefan Berger --- hw/tpm/tpm_spapr.c | 61 ++ 1 file changed, 57 insertions(+), 4 deletions(-) diff --git a/hw/tpm/tpm_spapr.c b/hw/tpm/tpm_spapr.c index ef5e62d..0b8a424 100644 --- a/hw/tpm/tpm_spapr.c +++ b/hw/tpm/tpm_spapr.c @

[Qemu-devel] [PATCH v2 1/2] tpm_spapr: Support TPM for ppc64 using CRQ based interface

2017-12-12 Thread Stefan Berger
Implement support for TPM on ppc64 by implementing the vTPM CRQ interface as a frontend. It can use the tpm_emulator driver backend with the external swtpm. The Linux vTPM driver for ppc64 works with this emulation. This TPM emulator also handles the TPM 2 case. Signed-off-by: Stefan Berger ---

Re: [Qemu-devel] [RFC PATCH 0/5] Scoped locks using attribute((cleanup))

2017-12-12 Thread Eric Blake
On 12/11/2017 03:32 PM, Paolo Bonzini wrote: > On 11/12/2017 15:11, Eric Blake wrote: >> I don't know if there is a way to make gcc insert stack-unwind >> directives that are honored across longjmp (I know C++ does it for >> exceptions; so there may be a way, and I just don't know it). > > Probabl

[Qemu-devel] No uhd (3840x2160) guest res?

2017-12-12 Thread Dr. David Alan Gilbert
My guests don't seem to offer the standard uhd resolution of 3840x2160 - what should be providing that? I'm running an f27 gnome (X or wayland) guest with: ./x86_64-softmmu/qemu-system-x86_64 -device virtio-vga --enable-kvm -m 2G /home/vmimages/fedora27.qcow2 and the guest lists: 4096x2160 2480

[Qemu-devel] [Bug 1670509] Re: sgabios outputs incorrect video modes

2017-12-12 Thread Nathan Rennie-Waldock
Fixed in qemu, yes. But not Ubuntu. Ubuntu strips prebuilt files from qemu and builds them from source. For sgabios, using the abandoned source from Google code. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.n

Re: [Qemu-devel] [PATCH v3 30/50] qapi: add #if conditions to generated alternate variants

2017-12-12 Thread Markus Armbruster
Marc-André Lureau writes: > Mostly covered by previous patches already. > > Signed-off-by: Marc-André Lureau > --- > scripts/qapi-introspect.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/qapi-introspect.py b/scripts/qapi-introspect.py > index ef2d5577db..d6

[Qemu-devel] [PATCH-2.12 v3 3/3] xilinx_spips: Use memset instead of a for loop to zero registers

2017-12-12 Thread Alistair Francis
Use memset() instead of a for loop to zero all of the registers. Signed-off-by: Alistair Francis Reviewed-by: KONRAD Frederic Reviewed-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ss

[Qemu-devel] [PATCH-2.12 v3 0/3] Update the reset values of the Xilinx ZynqMP QSPI

2017-12-12 Thread Alistair Francis
Update the reset values of the Xilinx ZynqMP QSPI device to match the resister spec here: https://www.xilinx.com/html_docs/registers/ug1087/ug1087-zynq-ultrascale-registers.html V3: - Match documented name V2: - Don't double set registers Based-on: 20171126231634.9531-14-frasse.igles...@gmail.c

[Qemu-devel] [PATCH-2.12 v3 2/3] xilinx_spips: Set all of the reset values

2017-12-12 Thread Alistair Francis
Following the ZynqMP register spec let's ensure that all reset values are set. Signed-off-by: Alistair Francis Reviewed-by: Francisco Iglesias --- V3: - Match documented name V2: - Don't bother double setting registers hw/ssi/xilinx_spips.c | 35 ++- i

[Qemu-devel] [PATCH-2.12 v3 1/3] xilinx_spips: Update the QSPI Mod ID reset value

2017-12-12 Thread Alistair Francis
Update the reset value to match the latest ZynqMP register spec. Signed-off-by: Alistair Francis Reviewed-by: KONRAD Frederic Reviewed-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index ad1b2

Re: [Qemu-devel] [PATCH-2.12 v2 2/3] xilinx_spips: Set all of the reset values

2017-12-12 Thread Alistair Francis
On Mon, Dec 11, 2017 at 1:17 PM, francisco iglesias wrote: > On 11 December 2017 at 18:27, Alistair Francis > wrote: > >> On Wed, Dec 6, 2017 at 3:39 PM, francisco iglesias >> wrote: >> > Hi Alistair, >> > >> > On 6 December 2017 at 23:22, Alistair Francis < >> alistair.fran...@xilinx.com> >> >

[Qemu-devel] [Bug 1723161] Re: Migration failing in qemu-2.10.1 but working qemu-2.9.1 and earlier with same options

2017-12-12 Thread Dr. David Alan Gilbert
This still seems to be present on current head -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1723161 Title: Migration failing in qemu-2.10.1 but working qemu-2.9.1 and earlier with same options

Re: [Qemu-devel] [PATCH] docs: Convert migration.txt to rst

2017-12-12 Thread Kashyap Chamarthy
On Tue, Dec 12, 2017 at 01:56:00PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Mostly just manual conversion with very minor fixes. > > Signed-off-by: Dr. David Alan Gilbert > --- > docs/devel/{migration.txt => migration.rst} | 326 > +++

Re: [Qemu-devel] [PATCH] blockjob: kick jobs on set-speed

2017-12-12 Thread John Snow
On 12/11/2017 07:08 PM, Jeff Cody wrote: > On Mon, Dec 11, 2017 at 06:46:09PM -0500, John Snow wrote: >> If users set an unreasonably low speed (like one byte per second), the >> calculated delay may exceed many hours. While we like to punish users >> for asking for stupid things, we do also like

Re: [Qemu-devel] [Qemu-arm] [PATCH] MAINTAINERS: replace the unavailable email address

2017-12-12 Thread Peter Maydell
On 12 December 2017 at 06:07, Shannon Zhao wrote: > From: Zhaoshenglong > > Since I'm not working as an assignee in Linaro, replace the Linaro email > address with my personal one. > > Signed-off-by: Zhaoshenglong > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > d

Re: [Qemu-devel] [PATCH v1] display: limit irq handler index to TC6393XB_GPIOS

2017-12-12 Thread Peter Maydell
On 12 December 2017 at 04:15, P J P wrote: > From: Prasad J Pandit > > The ctz32() routine could return value greater than > TC6393XB_GPIOS=16. This could lead to an OOB array access. > Mask 'level' to avoid it. > > Reported-by: Moguofang > Signed-off-by: Prasad J Pandit > --- > hw/display/tc6

Re: [Qemu-devel] [PATCH 12/13] sdhci: Add i.MX specific subtype of SDHCI

2017-12-12 Thread Peter Maydell
On 11 December 2017 at 21:30, Andrey Smirnov wrote: > IP block found on several generations of i.MX family does not use > vanilla SDHCI implementation and it comes with a number of quirks. > > Introduce i.MX SDHCI subtype of SDHCI block to add code necessary to > support unmodified Linux guest dri

Re: [Qemu-devel] Adding more function keys support

2017-12-12 Thread Programmingkid
> On Dec 12, 2017, at 9:34 AM, Daniel P. Berrange wrote: > > On Sun, Dec 10, 2017 at 02:10:41AM -0500, Programmingkid wrote: >> On Macintosh keyboards there is a key called fn that is used to give the >> function keys more functionality. Does this key exist in the keyboard keys >> database? > >

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 3/5] s390-ccw: parse and set boot menu options

2017-12-12 Thread David Hildenbrand
>>> + >>> +/* Store timeout value as seconds */ >>> +timeout /= 1000; >> So we pass ms on the command line? Why? > > > The QEMU user documentation specifies the splash-time as milliseconds. > I figured it would be best to conform to that. Makes sense then, maybe round up. --

Re: [Qemu-devel] [RFC v5 13/26] qmp: introduce some capability helpers

2017-12-12 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Introduce qmp_cap_enabled() and qmp_oob_enabled() helpers. > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > monitor.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/monitor.c b/monitor.c > index 097312e65f..

Re: [Qemu-devel] [RFC 1/1] virtio: fix IO request length in virtio SCSI/block

2017-12-12 Thread Paolo Bonzini
On 12/12/2017 16:16, Denis V. Lunev wrote: > The dark side of this patch is that we are tweaking guest visible > parameter, though this should be relatively safe as above transport > layer support is present in QEMU/host Linux for a very long time. > The patch adds configurable property for VirtIO

Re: [Qemu-devel] [PATCH 00/13] i.MX FEC and SD changes

2017-12-12 Thread Peter Maydell
On 11 December 2017 at 21:29, Andrey Smirnov wrote: > Hi everyone, > > This patchset is a spin-off from original i.MX7 support submission > found here [1], containing all of the patchest that are more or less > agreed upon and are ready (hopefully!) for inclusion. > > Changes since [1]: > >

Re: [Qemu-devel] [PATCH] target/arm: Make disas_thumb2_insn() generate its own UNDEF exceptions

2017-12-12 Thread Richard Henderson
On 12/12/2017 04:08 AM, Peter Maydell wrote: > Refactor disas_thumb2_insn() so that it generates the code for raising > an UNDEF exception for invalid insns, rather than returning a flag > which the caller must check to see if it needs to generate the UNDEF > code. This brings the function in to li

Re: [Qemu-devel] [RFC v5 12/26] qmp: negociate QMP capabilities

2017-12-12 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > After this patch, we will allow QMP clients to enable QMP capabilities > when sending the first "qmp_capabilities" command. Originally we are > starting QMP session with no arguments like: > > { "execute": "qmp_capabilities" } > > Now we can enable some

Re: [Qemu-devel] [PATCH 11/13] imx_fec: Reserve full FSL_IMX25_FEC_SIZE page for the register file

2017-12-12 Thread Peter Maydell
On 11 December 2017 at 21:30, Andrey Smirnov wrote: > Some i.MX SoCs (e.g. i.MX7) have FEC registers going as far as offset > 0x614, so to avoid getting aborts when accessing those on QEMU, extend > the register file to cover FSL_IMX25_FEC_SIZE(16K) of address space > instead of just 1K. > > Cc: P

Re: [Qemu-devel] [PATCH 10/13] imx_fec: Fix a typo in imx_enet_receive()

2017-12-12 Thread Peter Maydell
On 11 December 2017 at 21:30, Andrey Smirnov wrote: > Cc: Peter Maydell > Cc: Jason Wang > Cc: Philippe Mathieu-Daudé > Cc: qemu-devel@nongnu.org > Cc: qemu-...@nongnu.org > Cc: yurov...@gmail.com > Signed-off-by: Andrey Smirnov > --- > hw/net/imx_fec.c | 2 +- > 1 file changed, 1 insertion(+

Re: [Qemu-devel] [PATCH v2] dump-guest-memory.py: fix "You can't do that without a process to debug"

2017-12-12 Thread Laszlo Ersek
On 12/12/17 18:22, Marc-André Lureau wrote: > If the script is run with a core (no running process), it produces an > error: > > (gdb) dump-guest-memory /tmp/vmcore X86_64 > guest RAM blocks: > target_start target_end host_addrmessage count > --

Re: [Qemu-devel] [PATCH v2] dump-guest-memory.py: fix "You can't do that without a process to debug"

2017-12-12 Thread Laszlo Ersek
On 12/12/17 18:26, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Message-id: 20171212172208.13588-1-marcandre.lur...@redhat.com > Subject: [Qemu-devel] [PATCH v2] dump-guest-memory.py: fix "You can't do tha

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 3/5] s390-ccw: parse and set boot menu options

2017-12-12 Thread Collin L. Walling
On 12/12/2017 12:00 PM, David Hildenbrand wrote: On 11.12.2017 23:19, Collin L. Walling wrote: Set boot menu options for an s390 guest and store them in the iplb. These options are set via the QEMU command line option: -boot menu=on|off[,splash-time=X] or via the libvirt domain xml:

Re: [Qemu-devel] [PATCH] dump-guest-memory.py: fix "You can't do that without a process to debug"

2017-12-12 Thread Laszlo Ersek
On 12/12/17 18:17, Marc-André Lureau wrote: > > > - Original Message - >> On 12/12/17 17:35, Marc-André Lureau wrote:Hi >>> If the script is run with a core (no running process), it produces an >>> error: >>> >>> (gdb) dump-guest-memory /tmp/vmcore X86_64 >>> guest RAM blocks: >>> target

Re: [Qemu-devel] [Qemu-arm] [PATCH 2/2] nvic: Make systick banked

2017-12-12 Thread Peter Maydell
On 5 December 2017 at 04:13, Philippe Mathieu-Daudé wrote: > Anyway: > Reviewed-by: Philippe Mathieu-Daudé Thanks; I will squash this diff in when I apply to target-arm.next: --- a/hw/intc/armv7m_nvic.c +++ b/hw/intc/armv7m_nvic.c @@ -2068,9 +2068,14 @@ static void armv7m_nvic_realize(DeviceSta

[Qemu-devel] [PATCH v2] dump-guest-memory.py: fix "You can't do that without a process to debug"

2017-12-12 Thread Marc-André Lureau
If the script is run with a core (no running process), it produces an error: (gdb) dump-guest-memory /tmp/vmcore X86_64 guest RAM blocks: target_start target_end host_addrmessage count --- - 000a

Re: [Qemu-devel] [PATCH v1 16/19] fpu/softfloat: re-factor int/uint to float

2017-12-12 Thread Alex Bennée
Alex Bennée writes: > These are considerably simpler as the lower order integers can just > use the higher order conversion function. As the decomposed fractional > part is a full 64 bit rounding and inexact handling comes from the > pack functions. > > +/* > + * Integer to float conversions >

Re: [Qemu-devel] [PATCH] dump-guest-memory.py: fix "You can't do that without a process to debug"

2017-12-12 Thread Marc-André Lureau
- Original Message - > On 12/12/17 17:35, Marc-André Lureau wrote:Hi > > If the script is run with a core (no running process), it produces an > > error: > > > > (gdb) dump-guest-memory /tmp/vmcore X86_64 > > guest RAM blocks: > > target_start target_end host_addrmessa

Re: [Qemu-devel] Block Migration and CPU throttling

2017-12-12 Thread Dr. David Alan Gilbert
* Peter Lieven (p...@kamp.de) wrote: > Am 21.09.2017 um 14:36 schrieb Dr. David Alan Gilbert: > > * Peter Lieven (p...@kamp.de) wrote: > > > Am 19.09.2017 um 16:41 schrieb Dr. David Alan Gilbert: > > > > * Peter Lieven (p...@kamp.de) wrote: > > > > > Am 19.09.2017 um 16:38 schrieb Dr. David Alan Gi

[Qemu-devel] [Bug 1307225] Re: Running a virtual machine on a Haswell system produces machine check events

2017-12-12 Thread Tobias-leupold
The errors still keep appearing. The mcelog still shows the exact errors posted in the very fist comment. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307225 Title: Running a virtual machine on a

Re: [Qemu-devel] [PATCH v2 3/5] s390-ccw: parse and set boot menu options

2017-12-12 Thread David Hildenbrand
On 11.12.2017 23:19, Collin L. Walling wrote: > Set boot menu options for an s390 guest and store them in > the iplb. These options are set via the QEMU command line > option: > > -boot menu=on|off[,splash-time=X] > > or via the libvirt domain xml: > > > > > > Where X repre

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 4/5] s390-ccw: interactive boot menu for eckd dasd

2017-12-12 Thread Collin L. Walling
On 12/12/2017 11:30 AM, Farhan Ali wrote: On 12/11/2017 05:19 PM, Collin L. Walling wrote: When the boot menu options are present and the guest's disk has been configured by the zipl tool, then the user will be presented with an interactive boot menu with labeled entries. An example of what th

Re: [Qemu-devel] [PATCH] dump-guest-memory.py: fix "You can't do that without a process to debug"

2017-12-12 Thread Laszlo Ersek
On 12/12/17 17:35, Marc-André Lureau wrote: > If the script is run with a core (no running process), it produces an > error: > > (gdb) dump-guest-memory /tmp/vmcore X86_64 > guest RAM blocks: > target_start target_end host_addrmessage count > --

Re: [Qemu-devel] [PATCH v6 09/20] parallels: Switch to .bdrv_co_block_status()

2017-12-12 Thread Vladimir Sementsov-Ogievskiy
12.12.2017 19:32, Eric Blake wrote: On 12/11/2017 09:24 AM, Vladimir Sementsov-Ogievskiy wrote: On the other hand, '<< BDRV_SECTOR_BITS' only produces the same size output as the input; if the left side is 32 bits, it risks overflowing. But '* BDRV_SECTOR_SIZE' always produces a 64-bit value. 

Re: [Qemu-devel] [PATCH v1] hmp: 'info snapshots' not showing the id

2017-12-12 Thread Dr. David Alan Gilbert
* Seeteena Thoufeek (s1see...@linux.vnet.ibm.com) wrote: > (qemu) info snapshots > List of snapshots present on all disks: > IDTAG VM SIZEDATE VM CLOCK > -- 1 314M 2017-11-15 15:22:18 00:02:25.695 > -- 2

Re: [Qemu-devel] [PATCH 3/3] hw/arm/virt-acpi-build: Add second UART to ACPI tables

2017-12-12 Thread Laszlo Ersek
On 12/12/17 15:51, Andrew Jones wrote: > On Tue, Dec 12, 2017 at 02:31:05PM +, Ard Biesheuvel wrote: >> On 12 December 2017 at 14:17, Peter Maydell >> wrote: >>> On 12 December 2017 at 14:16, Ard Biesheuvel >>> wrote: On 12 December 2017 at 14:13, Peter Maydell wrote: > On 12 D

Re: [Qemu-devel] [PATCH v1 for-2-12 06/15] s390x/flic: factor out injection of floating interrupts

2017-12-12 Thread David Hildenbrand
On 12.12.2017 14:49, Cornelia Huck wrote: > On Mon, 11 Dec 2017 14:47:31 +0100 > David Hildenbrand wrote: > >> Let the flic device handle it internally. This will allow us to later >> on store floating interrupts in the flic for the TCG case. >> >> This now also simplifies kvm.c. All that's left

[Qemu-devel] [PATCH] dump-guest-memory.py: fix "You can't do that without a process to debug"

2017-12-12 Thread Marc-André Lureau
If the script is run with a core (no running process), it produces an error: (gdb) dump-guest-memory /tmp/vmcore X86_64 guest RAM blocks: target_start target_end host_addrmessage count --- - 000a

Re: [Qemu-devel] [PATCH v1 for-2-12 09/15] s390x/tcg: implement TEST PENDING INTERRUPTION

2017-12-12 Thread David Hildenbrand
On 12.12.2017 10:13, Cornelia Huck wrote: > On Mon, 11 Dec 2017 21:32:58 +0100 > David Hildenbrand wrote: > >> On 11.12.2017 19:01, Cornelia Huck wrote: >>> On Mon, 11 Dec 2017 14:47:34 +0100 >>> David Hildenbrand wrote: >>> Use s390_cpu_virt_mem_write() so we can actually revert what we

Re: [Qemu-devel] [PATCH v6 09/20] parallels: Switch to .bdrv_co_block_status()

2017-12-12 Thread Eric Blake
On 12/11/2017 09:24 AM, Vladimir Sementsov-Ogievskiy wrote: >> On the other hand, '<< BDRV_SECTOR_BITS' only produces the same size >> output as the input; if the left side is 32 bits, it risks overflowing. >> But '* BDRV_SECTOR_SIZE' always produces a 64-bit value.  So I've >> learned (from past

[Qemu-devel] [PATCH] qcow2: get rid of qcow2_backing_read1 routine

2017-12-12 Thread Edgar Kaziakhmedov
Since bdrv_co_preadv does all neccessary checks including reading after the end of the backing file, avoid duplication of verification before bdrv_co_preadv call. Signed-off-by: Edgar Kaziakhmedov Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 51 -

Re: [Qemu-devel] [PATCH v2 4/5] s390-ccw: interactive boot menu for eckd dasd

2017-12-12 Thread Farhan Ali
On 12/11/2017 05:19 PM, Collin L. Walling wrote: When the boot menu options are present and the guest's disk has been configured by the zipl tool, then the user will be presented with an interactive boot menu with labeled entries. An example of what the menu might look like: zIPL v1.37.1-

[Qemu-devel] [PATCH v2 1/3] qcow2-bitmap: add qcow2_reopen_bitmaps_rw_hint()

2017-12-12 Thread Vladimir Sementsov-Ogievskiy
Add version of qcow2_reopen_bitmaps_rw, which do the same work but also return a hint about was header updated or not. This will be used in the following fix for bitmaps reloading after migration. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow --- block/qcow2.h| 2 +

[Qemu-devel] [PATCH v2 0/3] fix bitmaps migration through shared storage

2017-12-12 Thread Vladimir Sementsov-Ogievskiy
Hi all. This fixes bitmaps migration through shared storage. Look at 02 for details. The bug introduced in 2.10 with the whole qcow2 bitmaps feature, so qemu-stable in CC. However I doubt that someone really suffered from this. v2: John, thank you for reviewing v1. changes: add John's

Re: [Qemu-devel] [PATCH qemu] RFC: vfio-pci: Allow mmap of MSIX BAR

2017-12-12 Thread Alex Williamson
On Tue, 12 Dec 2017 18:01:40 +1100 Alexey Kardashevskiy wrote: > On 12/12/17 17:06, Alexey Kardashevskiy wrote: > > On 12/12/17 16:54, Alex Williamson wrote: > >> On Tue, 12 Dec 2017 16:21:31 +1100 > >> Alexey Kardashevskiy wrote: > >> > >>> This makes use of a new VFIO_REGION_INFO_CAP_MSIX_

[Qemu-devel] [PATCH v2 2/3] qcow2: handle reopening bitmaps on bdrv_invalidate_cache

2017-12-12 Thread Vladimir Sementsov-Ogievskiy
Consider migration with shared storage. Persistent bitmaps are stored on bdrv_inactivate. Then, on destination process_incoming_migration_bh() calls bdrv_invalidate_cache_all() which leads to qcow2_load_autoloading_dirty_bitmaps() which fails if bitmaps are already loaded on destination start. In t

[Qemu-devel] [PATCH v2 3/3] iotests: add dirty bitmap migration test

2017-12-12 Thread Vladimir Sementsov-Ogievskiy
The test creates two vms (vm_a, vm_b), create dirty bitmap in the first one, do several writes to corresponding device and then migrate vm_a to vm_b with dirty bitmaps. For now, only migration through shared storage for persistent bitmaps is available, so it is tested here. Only offline variant is

[Qemu-devel] [RFC 1/1] virtio: fix IO request length in virtio SCSI/block

2017-12-12 Thread Denis V. Lunev
Linux guests submit IO requests no longer than PAGE_SIZE * max_seg field reported by SCSI controler. Thus typical sequential read with 1 MB size results in the following pattern of the IO from the guest: 8,16 115754 2.766095122 2071 D R 2095104 + 1008 [dd] 8,16 115755 2.

Re: [Qemu-devel] [libvirt-users] Inter Shared Memory ( Ivshmem ) : Cannot Bind

2017-12-12 Thread Martin Kletzander
On Mon, Dec 11, 2017 at 03:03:34PM +0800, Rogue S.T wrote: Hello, friends. I encounter a problem when i use ivshmem with my guest, my ivshmem server is not start, and output a error : Example code, do not use in production ,cannot bind. Detail distribution: Today, I know ivshmem from a topic

Re: [Qemu-devel] [PATCH 2/3] hw/arm/virt: Add another UART to the virt board

2017-12-12 Thread Peter Maydell
On 12 December 2017 at 15:16, Andrew Jones wrote: > OK, so this patch is fine, but it kills my suggestion for AAVMF to > only output debug messages to a debug port when the debug port is > actually useful. Now it won't be able to tell the difference unless > we can inform it some other way. Yeah,

Re: [Qemu-devel] [PATCH] sockets: remove obsolete code that updated listen address

2017-12-12 Thread Paolo Bonzini
On 12/12/2017 12:12, Daniel P. Berrange wrote: > When listening on unix/tcp sockets there was optional code that would update > the original SocketAddress struct with the info about the actual address that > was listened on. Since the conversion of everything to QIOChannelSocket, no > remaining cal

Re: [Qemu-devel] [PATCH v1 for-2-12 06/15] s390x/flic: factor out injection of floating interrupts

2017-12-12 Thread Cornelia Huck
On Tue, 12 Dec 2017 16:17:17 +0100 David Hildenbrand wrote: > On 12.12.2017 15:29, Cornelia Huck wrote: > > On Tue, 12 Dec 2017 15:13:46 +0100 > > Christian Borntraeger wrote: > > > >> On 12/12/2017 02:49 PM, Cornelia Huck wrote: > > > >>> One thing I noticed: You removed the caching of

Re: [Qemu-devel] [PATCH v2 4/4] colo: add trace for the tcp packet comparison

2017-12-12 Thread Zhang Chen
On Wed, Dec 6, 2017 at 5:57 PM, Mao Zhongyi wrote: > Cc: Zhang Chen > Cc: Li Zhijian > Cc: Jason Wang > > Signed-off-by: Mao Zhongyi > --- > net/colo-compare.c | 16 > net/colo.c | 1 + > net/colo.h | 1 + > net/trace-events | 1 + > 4 files changed, 19

Re: [Qemu-devel] [PATCH v2 3/4] colo: compare the packet based on the tcp sequence number

2017-12-12 Thread Zhang Chen
On Wed, Dec 6, 2017 at 5:57 PM, Mao Zhongyi wrote: > The primary and secondary guest has the same TCP stream, but the > the packet sizes are different due to the different fragmentation. > Maybe comments fix to this way is better: Packet size some time different or when network is busy. > > In

Re: [Qemu-devel] [PATCH] dump: fix note_name_equal()

2017-12-12 Thread Andrew Jones
On Tue, Dec 12, 2017 at 04:09:09PM +0100, Marc-André Lureau wrote: > Use the function argument "name" instead of hardcoded > "VMCOREINFO". All callers use "VMCOREINFO" as argument, so this isn't > an exposed bug, thankfully. > > Simplify a little bit the code while touching this. > > Suggested-by

Re: [Qemu-devel] [PATCH v2 2/4] colo: modified the payload compare function

2017-12-12 Thread Zhang Chen
On Wed, Dec 6, 2017 at 5:57 PM, Mao Zhongyi wrote: > Modified the function colo_packet_compare_common to prepare for the > tcp packet comparison in the next patch. > > Cc: Zhang Chen > Cc: Li Zhijian > Cc: Jason Wang > > Signed-off-by: Mao Zhongyi > --- > net/colo-compare.c | 71

Re: [Qemu-devel] [PATCH v2 1/4] colo: remove the incorrect if conditions in colo_compare_packet_tcp()

2017-12-12 Thread Zhang Chen
This patch should be moved behind the patch with payload comparition. People needs look your changes to understand why we need this patch. Thanks Zhang Chen On Wed, Dec 6, 2017 at 9:57 AM, Mao Zhongyi wrote: > The th_off field specifies the size of the TCP header, if th_off > 5, > it only mean

Re: [Qemu-devel] [PATCH v1 for-2-12 06/15] s390x/flic: factor out injection of floating interrupts

2017-12-12 Thread David Hildenbrand
On 12.12.2017 15:29, Cornelia Huck wrote: > On Tue, 12 Dec 2017 15:13:46 +0100 > Christian Borntraeger wrote: > >> On 12/12/2017 02:49 PM, Cornelia Huck wrote: > >>> One thing I noticed: You removed the caching of the flic (in the old >>> kvm inject routine), and you generally do more qom invoca

Re: [Qemu-devel] [PATCH 2/3] hw/arm/virt: Add another UART to the virt board

2017-12-12 Thread Andrew Jones
On Fri, Dec 08, 2017 at 03:02:07PM +, Peter Maydell wrote: > Currently we only provide one non-secure UART on the virt > board. This is OK for most purposes, but there are some > use cases where having a second UART would be useful (like > bare-metal testing where you don't really want to have

Re: [Qemu-devel] [PATCH 2/3] hw/arm/virt: Add another UART to the virt board

2017-12-12 Thread Andrew Jones
On Tue, Dec 12, 2017 at 02:50:50PM +, Peter Maydell wrote: > On 12 December 2017 at 14:45, Andrew Jones wrote: > > Should this be > > > > if (!vmc->no_second_uart && serial_hds[uart_count] != NULL) { > > > > A bit late now, but maybe the other UART resource allocations should have > > been

Re: [Qemu-devel] [PATCH] dump: fix note_name_equal()

2017-12-12 Thread Laszlo Ersek
On 12/12/17 16:09, Marc-André Lureau wrote: > Use the function argument "name" instead of hardcoded > "VMCOREINFO". All callers use "VMCOREINFO" as argument, so this isn't > an exposed bug, thankfully. > > Simplify a little bit the code while touching this. > > Suggested-by: Andrew Jones > Repor

Re: [Qemu-devel] [PATCH v19 1/7] xbitmap: Introduce xbitmap

2017-12-12 Thread Philippe Ombredanne
Matthew, Wei, On Tue, Dec 12, 2017 at 12:55 PM, Wei Wang wrote: > From: Matthew Wilcox > > The eXtensible Bitmap is a sparse bitmap representation which is > efficient for set bits which tend to cluster. It supports up to > 'unsigned long' worth of bits, and this commit adds the bare bones -- >

Re: [Qemu-devel] [PATCH] docs: Convert migration.txt to rst

2017-12-12 Thread Peter Xu
On Tue, Dec 12, 2017 at 01:56:00PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Mostly just manual conversion with very minor fixes. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Some nits below, but r-b is fine with/without changing them.

[Qemu-devel] [PATCH] dump: fix note_name_equal()

2017-12-12 Thread Marc-André Lureau
Use the function argument "name" instead of hardcoded "VMCOREINFO". All callers use "VMCOREINFO" as argument, so this isn't an exposed bug, thankfully. Simplify a little bit the code while touching this. Suggested-by: Andrew Jones Reported-by: Laszlo Ersek Signed-off-by: Marc-André Lureau ---

Re: [Qemu-devel] [PATCH 3/3] hw/arm/virt-acpi-build: Add second UART to ACPI tables

2017-12-12 Thread Andrew Jones
On Tue, Dec 12, 2017 at 12:06:39PM +0100, Laszlo Ersek wrote: > On 12/12/17 06:53, Shannon Zhao wrote: > > > > > > On 2017/12/8 23:02, Peter Maydell wrote: > >> Add the second UART to the ACPI tables. > >> > >> Signed-off-by: Peter Maydell > >> --- > >> Pure guesswork, as I don't have a UEFI set

  1   2   >