The following changes since commit af352675efb7e92a1f5f6461a042a12015ab3d12:
Merge remote-tracking branch 'remotes/aurel/tags/pull-target-sh4-20171218'
into staging (2017-12-19 19:11:11 +)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you
From: Mao Zhongyi
Convert nvme_init() to realize and rename it to nvme_realize().
Cc: John Snow
Cc: Keith Busch
Cc: Kevin Wolf
Cc: Max Reitz
Cc: Markus Armbruster
Signed-off-by: Mao Zhongyi
Signed-off-by: Kevin Wolf
---
hw/block/nvme.c | 18 ++
1 file changed, 10 inserti
On Wed, Dec 20, 2017 at 9:14 AM, Laurent Vivier wrote:
> It makes the code clearer to separate the bus implementation
> from the devices one.
>
> Replace ADB_DPRINTF() with trace events (and adding new ones in adb-kbd.c).
> Some minor changes to make checkpatch.pl happy.
>
> Signed-off-by: Laurent
On Wed, Dec 20, 2017 at 10:08 AM, Laurent Vivier wrote:
> It has been introduced by e6e5906b6e ("ColdFire target."),
> but the content is never used.
>
> Signed-off-by: Laurent Vivier
Reviewed-by: Philippe Mathieu-Daudé
> ---
> target/m68k/translate.c | 10 --
> 1 file changed, 10 del
On Wed, 12/20 11:33, Kevin Wolf wrote:
> bdrv_drain_begin() doesn't increase bs->quiesce_counter recursively,
Pretty trivial but:
s/bdrv_drain_begin/bdrv_drained_begin/
> which means that the child nodes are not actually drained. To keep this
> consistent, we also shouldn't call the block driver
It has been introduced by e6e5906b6e ("ColdFire target."),
but the content is never used.
Signed-off-by: Laurent Vivier
---
target/m68k/translate.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index b60909222c..dfb2d5dad2 100644
* Markus Armbruster (arm...@redhat.com) wrote:
> Jan Dakinevich writes:
>
> > On Tue, 19 Dec 2017 15:57:18 +0100
> > Markus Armbruster wrote:
> >
> >> QAPI/QMP interface review only.
> >>
> >> You neglected to cc: the maintainers of qapi-schema.json, so I'm doing
> >> that for you.
> >>
> >
>
Am 20.12.2017 um 12:31 hat Paolo Bonzini geschrieben:
> On 20/12/2017 12:18, Kevin Wolf wrote:
> > Am 20.12.2017 um 11:51 hat Paolo Bonzini geschrieben:
> >> On 20/12/2017 11:34, Kevin Wolf wrote:
> >>> .inherit_options = bdrv_inherited_options,
> >>> .drained_begin = bdrv_child_cb_drai
On Mon, 18 Dec 2017 11:41:23 +0100
Greg Kurz wrote:
> The 9p protocol mostly relies on a request/reply dialog between the
> client and the server. A notable exception to this rule is request
> cancellation (ie, flush in 9p wording): the server shouldn't send a
> reply when the request was flushed
On Tue, 12 Dec 2017 15:14:06 -0800 (PST)
Stefano Stabellini wrote:
> On Fri, 8 Dec 2017, Greg Kurz wrote:
> > Cc'ing Stefano using a more appropriate address :)
>
> Thanks Greg for the ping, one comment inline below.
>
>
> > On Thu, 7 Dec 2017 18:04:24 +0100
> > Greg Kurz wrote:
> >
> >
On Wed, 20 Dec 2017 11:16:46 +0100
Markus Armbruster wrote:
> Jan Dakinevich writes:
>
> > On Tue, 19 Dec 2017 15:57:18 +0100
> > Markus Armbruster wrote:
> >> Jan Dakinevich writes:
> Taking a step back: what's the intended purpose of query-virtio? The
> cover letter doesn't really say:
>
Public bug reported:
./ppc64-softmmu/qemu-system-ppc64 -version
QEMU emulator version 2.11.50 (v2.11.0-254-gaf35267)
1. Boot a power8 compat mode guest power9 HW.
./ppc64-softmmu/qemu-system-ppc64 -machine
pseries,accel=kvm,max-cpu-compat=power8 -m 4096 /home/sath/images/guest.qcow2
-smp 1,maxc
On Wed, Dec 20, 2017 at 06:34:36PM +0800, Wei Wang wrote:
> On 12/19/2017 10:05 PM, Tetsuo Handa wrote:
> > I think xb_find_set() has a bug in !node path.
>
> I think we can probably remove the "!node" path for now. It would be good to
> get the fundamental part in first, and leave optimization to
It makes the code clearer to separate the bus implementation
from the devices one.
Replace ADB_DPRINTF() with trace events (and adding new ones in adb-kbd.c).
Some minor changes to make checkpatch.pl happy.
Signed-off-by: Laurent Vivier
---
v2: move internal declarations to adb-internal.h
re
On Wed, 12/20 11:33, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf
> ---
> block/io.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/block/io.c b/block/io.c
> index cf780c3cb0..b94740b8ff 100644
> --- a/block/io.c
> +++ b/block/io.c
> @@ -330,6 +330,12 @@ void bdrv_drain_all_begi
On Mon, Dec 18, 2017 at 8:12 PM, Daniel P. Berrange wrote:
> In the 2.11 release we fixed CVE-2017-15268, which allowed the VNC websockets
> server to consume arbitrary memory when a slow client was connected. I have
> since discovered that this same type of problem can be triggered in several
> o
On Wed, Dec 20, 2017 at 12:32:51PM +0100, Marc-André Lureau wrote:
> Hi
>
> On Mon, Dec 18, 2017 at 8:12 PM, Daniel P. Berrange
> wrote:
> > The previous patches fix problems with throttling of forced framebuffer
> > updates
> > and audio data capture that would cause the QEMU output buffer si
Hi
On Mon, Dec 18, 2017 at 8:12 PM, Daniel P. Berrange wrote:
> The previous patches fix problems with throttling of forced framebuffer
> updates
> and audio data capture that would cause the QEMU output buffer size to grow
> without bound. Those fixes are graceful in that once the client catch
On 20/12/2017 12:18, Kevin Wolf wrote:
> Am 20.12.2017 um 11:51 hat Paolo Bonzini geschrieben:
>> On 20/12/2017 11:34, Kevin Wolf wrote:
>>> .inherit_options = bdrv_inherited_options,
>>> .drained_begin = bdrv_child_cb_drained_begin,
>>> .drained_end = bdrv_child_cb_drained_end
On 19 December 2017 at 04:29, David Gibson wrote:
> The following changes since commit eaefea537b476cb853e2edbdc68e969ec777e4bb:
>
> Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-fetch' into
> staging (2017-12-18 14:17:42 +)
>
> are available in the Git repository at:
>
>
On Wed, Dec 20, 2017 at 10:57:40AM +, Daniel P. Berrange wrote:
> On Wed, Dec 20, 2017 at 11:44:36AM +0100, Kashyap Chamarthy wrote:
> > On Mon, Dec 18, 2017 at 11:11:00AM +0100, Markus Armbruster wrote:
[...]
> > > Another thought: do we want to give qemu-system-* the necessary
> > > privile
On Wed, Dec 20, 2017 at 02:47:30PM +0800, Liu, Yi L wrote:
> On Mon, Dec 18, 2017 at 10:35:31PM +1100, David Gibson wrote:
> > On Wed, Nov 15, 2017 at 03:16:32PM +0800, Peter Xu wrote:
> > > On Tue, Nov 14, 2017 at 10:52:54PM +0100, Auger Eric wrote:
> > >
> > > [...]
> > >
> > > > I meant, in th
On Wed, Dec 20, 2017 at 02:32:42PM +0800, Liu, Yi L wrote:
> On Mon, Dec 18, 2017 at 10:22:18PM +1100, David Gibson wrote:
> > On Mon, Dec 18, 2017 at 05:17:35PM +0800, Liu, Yi L wrote:
> > > On Mon, Dec 18, 2017 at 05:14:42PM +1100, David Gibson wrote:
> > > > On Thu, Nov 16, 2017 at 04:57:09PM +0
Am 20.12.2017 um 11:51 hat Paolo Bonzini geschrieben:
> On 20/12/2017 11:34, Kevin Wolf wrote:
> > .inherit_options = bdrv_inherited_options,
> > .drained_begin = bdrv_child_cb_drained_begin,
> > .drained_end = bdrv_child_cb_drained_end,
> > +.attach = bdrv_child_c
On Fri, Dec 15, 2017 at 05:38:00PM +0100, Max Reitz wrote:
> Image creation in qemu-system-* vs. qemu-img:
> In order to get proper introspection for qemu-img create, we need a
> QAPI schema. If we have a QAPI schema, we might as well add
> blockdev-create to QMP.
> As long as we do not h
On 20/12/2017 11:33, Kevin Wolf wrote:
> This is the second part of my work to fix drain and hopefully to prevent
> it from attracting bugs as much as it did in the past. There is
> definitely at least a third part coming after this, see below.
>
> In this series, the following improvments are mad
On Wed, Dec 20, 2017 at 11:44:36AM +0100, Kashyap Chamarthy wrote:
> On Mon, Dec 18, 2017 at 11:11:00AM +0100, Markus Armbruster wrote:
> > Max Reitz writes:
>
> [...]
>
> Thanks, Max, for the detailed notes.
>
> > > Image creation in qemu-system-* vs. qemu-img:
> > > In order to get proper i
On 20/12/2017 11:34, Kevin Wolf wrote:
> If bdrv_do_drained_begin/end() are called in coroutine context, they
> first use a BH to get out of the coroutine context. Call some existing
> tests again from a coroutine to cover this code path.
>
> Signed-off-by: Kevin Wolf
> ---
> tests/test-bdrv-dra
On 20/12/2017 11:34, Kevin Wolf wrote:
> .inherit_options = bdrv_inherited_options,
> .drained_begin = bdrv_child_cb_drained_begin,
> .drained_end = bdrv_child_cb_drained_end,
> +.attach = bdrv_child_cb_attach,
> +.detach = bdrv_child_cb_detach,
>
We need to remember how many of the drain sections in which a node is
were recursive (i.e. subtree drain rather than node drain), so that they
can be correctly applied when children are added or removed during the
drained section.
With this change, it is safe to modify the graph even inside a
bdrv
On Mon, Dec 18, 2017 at 11:11:00AM +0100, Markus Armbruster wrote:
> Max Reitz writes:
[...]
Thanks, Max, for the detailed notes.
> > Image creation in qemu-system-* vs. qemu-img:
> > In order to get proper introspection for qemu-img create, we need a
> > QAPI schema. If we have a QAPI sch
Signed-off-by: Kevin Wolf
---
tests/test-bdrv-drain.c | 80 +
1 file changed, 80 insertions(+)
diff --git a/tests/test-bdrv-drain.c b/tests/test-bdrv-drain.c
index b7322c5826..6803e64950 100644
--- a/tests/test-bdrv-drain.c
+++ b/tests/test-bdrv-dr
The bdrv_reopen*() implementation doesn't like it if the graph is
changed between queuing nodes for reopen and actually reopening them
(one of the reasons is that queuing can be recursive).
So instead of draining the device only in bdrv_reopen_multiple(),
require that callers already drained all a
Since commit bde70715, base is the only node that is reopened in
commit_start(). This means that the code, which still involves an
explicit BlockReopenQueue, can now be simplified by using bdrv_reopen().
Signed-off-by: Kevin Wolf
---
block/commit.c | 8 +---
1 file changed, 1 insertion(+), 7
Signed-off-by: Kevin Wolf
---
tests/test-bdrv-drain.c | 57 +
1 file changed, 57 insertions(+)
diff --git a/tests/test-bdrv-drain.c b/tests/test-bdrv-drain.c
index 4571137928..ede5cf6e64 100644
--- a/tests/test-bdrv-drain.c
+++ b/tests/test-bdrv-dr
If bdrv_do_drained_begin/end() are called in coroutine context, they
first use a BH to get out of the coroutine context. Call some existing
tests again from a coroutine to cover this code path.
Signed-off-by: Kevin Wolf
---
tests/test-bdrv-drain.c | 51 +++
Test that drain sections are correctly propagated through the graph.
Signed-off-by: Kevin Wolf
---
tests/test-bdrv-drain.c | 74 +
1 file changed, 74 insertions(+)
diff --git a/tests/test-bdrv-drain.c b/tests/test-bdrv-drain.c
index a1e5693f33..b7
Yep, can repeat it here, it seems pretty random which error it gives:
[dgilbert@dgilbert-t530 try]$ ./x86_64-softmmu/qemu-system-x86_64 -cdrom /tmp
qemu-system-x86_64: -cdrom /tmp: Could not refresh total sector count: Invalid
argument
[dgilbert@dgilbert-t530 try]$ ./x86_64-softmmu/qemu-system-x8
bdrv_do_drained_begin() restricts the call of parent callbacks and
aio_disable_external() to the outermost drain section, but the block
driver callbacks are always called. bdrv_do_drained_end() must match
this behaviour, otherwise nodes stay drained even if begin/end calls
were balanced.
Signed-of
This is in preparation for subtree drains, i.e. drained sections that
affect not only a single node, but recursively all child nodes, too.
Calling the parent callbacks for drain is pointless when we just came
from that parent node recursively and leads to multiple increases of
bs->quiesce_counter
Block jobs already paused themselves when their main BlockBackend
entered a drained section. This is not good enough: We also want to
pause a block job and may not submit new requests if, for example, the
mirror target node should be drained.
This implements .drained_begin/end callbacks in child_j
Add a subtree drain version to the existing test cases.
Signed-off-by: Kevin Wolf
---
tests/test-bdrv-drain.c | 27 ++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/tests/test-bdrv-drain.c b/tests/test-bdrv-drain.c
index ede5cf6e64..c00d96bb2f 100644
---
Signed-off-by: Kevin Wolf
---
block/io.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/block/io.c b/block/io.c
index cf780c3cb0..b94740b8ff 100644
--- a/block/io.c
+++ b/block/io.c
@@ -330,6 +330,12 @@ void bdrv_drain_all_begin(void)
BdrvNextIterator it;
GSList *aio_ctxs = N
Block jobs must be paused if any of the involved nodes are drained.
Signed-off-by: Kevin Wolf
---
tests/test-bdrv-drain.c | 121
1 file changed, 121 insertions(+)
diff --git a/tests/test-bdrv-drain.c b/tests/test-bdrv-drain.c
index 2aa2b9aa43..01
This is currently only working correctly for bdrv_drain(), not for
bdrv_drain_all(). Leave a comment for the drain_all case, we'll address
it later.
Signed-off-by: Kevin Wolf
---
tests/test-bdrv-drain.c | 45 +
1 file changed, 45 insertions(+)
diff --
bdrv_drained_begin() waits for the completion of requests in the whole
subtree, but it only actually keeps its immediate bs parameter quiesced
until bdrv_drained_end().
Add a version that keeps the whole subtree drained. As of this commit,
graph changes cannot be allowed during a subtree drained s
From: Fam Zheng
Signed-off-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
include/block/block_int.h | 1 -
block/io.c| 18 --
2 files changed, 19 deletions(-)
diff --git a/include/block/block_int.h b/include/block/block_int.h
index a5482775ec..e107163594 100644
-
Block jobs are already paused using the BdrvChildRole drain callbacks,
so we don't need an additionall block_job_pause_all() call.
Signed-off-by: Kevin Wolf
---
block/io.c | 4
tests/test-bdrv-drain.c | 10 --
2 files changed, 4 insertions(+), 10 deletions(-)
diff --g
The existing test is for bdrv_drain_all_begin/end() only. Generalise the
test case so that it can be run for the other variants as well. At the
moment this is only bdrv_drain_begin/end(), but in a while, we'll add
another one.
Also, add a backing file to the test node to test whether the operation
This is the second part of my work to fix drain and hopefully to prevent
it from attracting bugs as much as it did in the past. There is
definitely at least a third part coming after this, see below.
In this series, the following improvments are made:
* Fix several bugs and inconsistencies
* Creat
bdrv_drain_begin() doesn't increase bs->quiesce_counter recursively,
which means that the child nodes are not actually drained. To keep this
consistent, we also shouldn't call the block driver callbacks.
Signed-off-by: Kevin Wolf
---
block/io.c | 16 +---
1 file changed, 9 insertions
On 12/19/2017 10:05 PM, Tetsuo Handa wrote:
Wei Wang wrote:
ChangeLog:
v19->v20:
1) patch 1: xbitmap
- add __rcu to "void **slot";
- remove the exceptional path.
2) patch 3: xbitmap
- DeveloperNotes: add an item to comment that the current bit range
related APIs
On Wed, Dec 20, 2017 at 08:23:04AM -0200, Daniel Henrique Barboza wrote:
> 'qmp_cpu' was implemented in commit 755f196898 ("qapi: Convert the cpu
> command") as a functional no-op, a QMP call that does nothing and
> return success. The idea, apparently, was to provide a counterpart
> for the HMP 'h
On Wed, Dec 20, 2017 at 06:06:41PM +0800, sochin.jiang wrote:
> From: "sochin.jiang"
>
> Correct a spelling error in prompt message.
>
> Signed-off-by: sochin.jiang
This fix is already sent 3 times now & on the qemu-trivial queue
Regards,
Daniel
--
|: https://berrange.com -o-h
'qmp_cpu' was implemented in commit 755f196898 ("qapi: Convert the cpu
command") as a functional no-op, a QMP call that does nothing and
return success. The idea, apparently, was to provide a counterpart
for the HMP 'hmp_cpu' command, introduced in the same commit.
After 6 years of its creation, q
Jan Dakinevich writes:
> On Tue, 19 Dec 2017 15:57:18 +0100
> Markus Armbruster wrote:
>
>> QAPI/QMP interface review only.
>>
>> You neglected to cc: the maintainers of qapi-schema.json, so I'm doing
>> that for you.
>>
>
> Thank you so much. I screwed up with this patchset at least twice: wi
On Tue, Dec 19, 2017 at 02:34:25PM -0300, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/qemu-iotests/iotests.py | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrange
>
> diff --git a/tests/qemu-iotests/iotests.py
On Tue, Dec 19, 2017 at 02:34:23PM -0300, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/qemu-iotests/065 | 4 ++--
> tests/qemu-iotests/139 | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Daniel P. Berrange
>
> diff --git a/tests/
On Tue, Dec 19, 2017 at 02:34:22PM -0300, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/qemu-iotests/093 | 2 +-
> tests/qemu-iotests/096 | 4 ++--
> tests/qemu-iotests/136 | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Ber
On Tue, Dec 19, 2017 at 02:34:24PM -0300, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/qemu-iotests/041| 6 +++---
> tests/qemu-iotests/118| 4 ++--
> tests/qemu-iotests/iotests.py | 2 +-
> 3 files changed, 6 insertions(+), 6 deletions(-)
R
From: "sochin.jiang"
Correct a spelling error in prompt message.
Signed-off-by: sochin.jiang
---
scripts/git-submodule.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh
index bc7224a..807ca0b 100755
--- a/scripts/git-sub
On 20/12/2017 10:51, Fam Zheng wrote:
> On Tue, 12/05 23:15, Fam Zheng wrote:
>> Add the property to the device model, then parse it by calling
>> blkconf_apply_backend_options().
>>
>> In addition to blk_set_perm(), the called function also handles error
>> options and wce. For error options we've
On Tue, Dec 19, 2017 at 02:34:21PM -0300, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/qemu-iotests/044 | 14 +++---
> tests/qemu-iotests/163 | 2 +-
> 2 files changed, 8 insertions(+), 8 deletions(-)
Reviewed-by: Daniel P. Berrange
>
> diff --
On Tue, Dec 19, 2017 at 02:34:20PM -0300, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/qemu-iotests/118 | 24
> 1 file changed, 12 insertions(+), 12 deletions(-)
Reviewed-by: Daniel P. Berrange
>
> diff --git a/tests/qemu-iotest
On Tue, Dec 19, 2017 at 02:34:19PM -0300, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/qemu-iotests/149| 3 ++-
> tests/qemu-iotests/165| 3 ++-
> tests/qemu-iotests/iotests.py | 5 +++--
> 3 files changed, 7 insertions(+), 4 deletions(-)
>
On 19.12.2017 21:23, Collin L. Walling wrote:
> On 12/19/2017 11:29 AM, Collin L. Walling wrote:
>> On 12/19/2017 02:31 AM, Thomas Huth wrote:
>>> On 18.12.2017 17:16, Collin L. Walling wrote:
On 12/18/2017 08:06 AM, Thomas Huth wrote:
> On 11.12.2017 23:19, Collin L. Walling wrote:
>>
> * Pavel Dovgalyuk (dovga...@ispras.ru) wrote:
> > > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com]
> > > * Pavel Dovgalyuk (pavel.dovga...@ispras.ru) wrote:
> > > > HPET saves its state by calculating the current time and recovers timer
> > > > offset using this calculated value. But
HPET saves its state by calculating the current time and recovers timer
offset using this calculated value. But these calculations include
divisions and multiplications. Therefore the timer state cannot be recovered
precise enough.
This patch introduces saving of the original value of the offset to
On Tue, Dec 19, 2017 at 02:34:18PM -0300, Philippe Mathieu-Daudé wrote:
> the socket API expects byte strings.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> scripts/qmp/qmp.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrange
>
> diff --git a/script
No, this bug tracker is for QEMU bugs only. Please report KVM-PR bugs to
the kvm-...@vger.kernel.org mailing list (see also https://www.linux-
kvm.org/page/Bugs for how to report KVM kernel bugs in general)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is
On Tue, Dec 19, 2017 at 02:34:17PM -0300, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> scripts/qemu.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrange
Regards,
Daniel
--
|: https://berrange.com -o-https://www.f
On 19/12/2017 17:37, Philippe Mathieu-Daudé wrote:
> Hi,
>
> Apparently block-tests are only run on patchew CI, not Travis, so this went
> unnoticed.
>
> Now ./check does check for this helper, and errors are easier to figure out.
>
> Regards,
>
> Phil.
>
> Philippe Mathieu-Daudé (2):
> qemu
On Tue, 12/05 23:15, Fam Zheng wrote:
> Add the property to the device model, then parse it by calling
> blkconf_apply_backend_options().
>
> In addition to blk_set_perm(), the called function also handles error
> options and wce. For error options we've already checked that the
> default values a
* Pavel Dovgalyuk (dovga...@ispras.ru) wrote:
> > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com]
> > * Pavel Dovgalyuk (pavel.dovga...@ispras.ru) wrote:
> > > HPET saves its state by calculating the current time and recovers timer
> > > offset using this calculated value. But these calcu
Ok, thanks for your answer. Then let's assume that it has been fixed by
one of the past releases.
** Changed in: qemu
Status: Incomplete => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.ne
On Wed, 12/20 10:05, Markus Armbruster wrote:
> Fam Zheng writes:
>
> > On Tue, 12/19 15:29, Markus Armbruster wrote:
> >> Adding Eric for additonal QMP design expertise.
> >>
> >> Fam Zheng writes:
> >>
> >> > Previously we only print hint lines if we are in a command line context
> >> > or H
> From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com]
> * Pavel Dovgalyuk (pavel.dovga...@ispras.ru) wrote:
> > HPET saves its state by calculating the current time and recovers timer
> > offset using this calculated value. But these calculations include
> > divisions and multiplications. The
* Pavel Dovgalyuk (pavel.dovga...@ispras.ru) wrote:
> HPET saves its state by calculating the current time and recovers timer
> offset using this calculated value. But these calculations include
> divisions and multiplications. Therefore the timer state cannot be recovered
> precise enough.
> This
On Wed, Dec 20, 2017 at 09:56:10AM +0100, Paolo Bonzini wrote:
> On 20/12/2017 04:13, Peter Xu wrote:
> > On Fri, Nov 24, 2017 at 03:34:14PM +0800, Peter Xu wrote:
> >> v2:
> >> - drop patch 1 since merged
> >> - add last patch as suggested by Paolo
> >>
> >> Please review, thanks.
> >
> > Ping fo
Fam Zheng writes:
> On Tue, 12/19 15:29, Markus Armbruster wrote:
>> Adding Eric for additonal QMP design expertise.
>>
>> Fam Zheng writes:
>>
>> > Previously we only print hint lines if we are in a command line context
>> > or HMP. However QMP errors are also eventually consumed by human and
On 20/12/2017 02:47, Alexey Kardashevskiy wrote:
>> - if we foresee having more IOMMU devices in KVM, let's rename
>> KVM_DEV_VFIO_GROUP_SET_SPAPR_TCE to KVM_DEV_VFIO_GROUP_ATTACH_IOMMU and
>> add a new function
>>
>> int iommu_memory_region_get_kvm_fd(IOMMUMemoryRegion *iommu);
>>
>> that req
On 20/12/2017 08:58, Pavel Dovgalyuk wrote:
> HPET saves its state by calculating the current time and recovers timer
> offset using this calculated value. But these calculations include
> divisions and multiplications. Therefore the timer state cannot be recovered
> precise enough.
> This patch in
On 20/12/17 08:35, Jason Wang wrote:
On 2017年12月16日 02:41, Mark Cave-Ayland wrote:
Whilst trying to debug a CRC32 endian issue for NIC multicast hash
lookups, it
struck me that it would make sense to have a common set of standard
ethernet
CRC32 functions (both little and big endian variants)
On 2017年12月19日 18:21, Zhoujian (jay) wrote:
-Original Message-
From: Jason Wang [mailto:jasow...@redhat.com]
Sent: Tuesday, December 19, 2017 5:24 PM
To: Zhoujian (jay) ; qemu-devel@nongnu.org
Cc: m...@redhat.com; Gonglei (Arei) ;
marcandre.lur...@redhat.com; Huangweidong (C) ;
wangxi
On 20/12/2017 04:13, Peter Xu wrote:
> On Fri, Nov 24, 2017 at 03:34:14PM +0800, Peter Xu wrote:
>> v2:
>> - drop patch 1 since merged
>> - add last patch as suggested by Paolo
>>
>> Please review, thanks.
>
> Ping for 2.12 dev window.
Already queued. :)
Paolo
>>
>> Peter Xu (3):
>> cpu: refa
On 2017年12月08日 12:26, Peter Xu wrote:
Please review. Thanks,
Peter Xu (2):
intel_iommu: remove X86_IOMMU_PCI_DEVFN_MAX
intel_iommu: fix error param in string
hw/i386/intel_iommu.c | 12 ++--
include/hw/i386/x86-iommu.h | 1 -
2 files changed, 6 insertions(+), 7 delet
On 2017年12月16日 02:41, Mark Cave-Ayland wrote:
Whilst trying to debug a CRC32 endian issue for NIC multicast hash lookups, it
struck me that it would make sense to have a common set of standard ethernet
CRC32 functions (both little and big endian variants) in net.c.
Patches 1 and 2 introduce th
Peter Maydell writes:
> On 18 December 2017 at 17:30, Markus Armbruster wrote:
>> The following changes since commit 411ad78115ebeb3411cf4b7622784b93dfabe259:
>>
>> Merge remote-tracking branch
>> 'remotes/stefanberger/tags/pull-tpm-2017-12-15-1' into staging (2017-12-17
>> 15:27:41 +)
>
Commit 0f5314a (v1.0) added section "Device URL Syntax" to
qemu-options.hx. It's enclosed in STEXI..ETEXI, thus affects only
qemu-options.texi, not --help. It appears as a subsection under
section "Invocation". Similarly, qemu.1 has it as a subsection under
"OPTIONS".
Commit f9dadc9 (v1.1.0) dr
-iscsi ended up under the "Device URL Syntax" heading by a sequence of
errors, as explained in the previous commit. Move it under the "Block
device options" heading. Nothing left under "Device URL Syntax";
drop the heading.
Cc: Ronnie Sahlberg
Cc: Kevin Wolf
Cc: Max Reitz
Cc: qemu-bl...@nongn
20.12.2017 04:06, John Snow wrote:
On 12/19/2017 11:07 AM, Vladimir Sementsov-Ogievskiy wrote:
13.12.2017 07:12, Fam Zheng wrote:
On Mon, 11/13 19:20, Vladimir Sementsov-Ogievskiy wrote:
Hi all.
There are three qmp commands, needed to implement external backup API.
Using these three command
Cc: Paolo Bonzini
CC: Marc-André Lureau
Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
---
qemu-options.hx | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 372cbabb7f..80b2331a32 100644
--- a/qemu-optio
Commit 43f187a broke --help: it put colons into blank lines. It
removed the colon from DEFHEADING(TITLE:) and added it back in the
macro expansion of DEFHEADING(TITLE), so hxtool can emit "@subsection
TITLE" more easily. Trouble is it's added back even for the blank
lines made with DEFHEADING().
Missed in commit 795dc6e46d, v2.4.0.
Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
---
qemu-options.hx | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 80b2331a32..84f41e6ac4 100644
--- a/qemu-options.hx
+++ b/qemu-o
The table of option parameters lacks @table and @end table. The
parameters become items in the enclosing table of options. Screwed up
when l2tpv3 was added in commit 3fb69aa. Fix the obvious way.
Cc: Jason Wang
Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
---
qemu-options
From: "Dr. David Alan Gilbert"
opt was declared as a separate local inside the last loop,
shadowing the local at the top of the function.
Signed-off-by: Dr. David Alan Gilbert
Message-Id: <20171005190725.18712-1-dgilb...@redhat.com>
Reviewed-by: Eric Blake
Signed-off-by: Markus Armbruster
---
Cc: Ronnie Sahlberg
Cc: Kevin Wolf
Cc: Max Reitz
Cc: qemu-bl...@nongnu.org
Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
Reviewed-by: Ronnie Sahlberg
---
qemu-options.hx | 6 ++
1 file changed, 6 insertions(+)
diff --git a/qemu-options.hx b/qemu-options.hx
index 3d05bc
Cc: Stefan Berger
Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
---
qemu-options.hx | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index a173378d98..372cbabb7f 100644
--- a/qemu-options.hx
+++ b/qemu-opt
Their last user went away in commit f51074cdc6, "pci-hotplug-old: Has
been dead for five major releases, bury", v2.3.0. Remove them, as new
code should use QemuOpts or maybe keyval_parse() instead.
Signed-off-by: Markus Armbruster
Message-Id: <20171006131645.17729-1-arm...@redhat.com>
Reviewed-b
The following changes since commit af352675efb7e92a1f5f6461a042a12015ab3d12:
Merge remote-tracking branch 'remotes/aurel/tags/pull-target-sh4-20171218'
into staging (2017-12-19 19:11:11 +)
are available in the git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-cmdline-2017-12
301 - 400 of 402 matches
Mail list logo
