The following changes since commit 43ab9a5376c95c61ae898a222c4d04bdf60e239b:
hw/i386/vmport: fix missing definitions with non-log trace backends
(2017-12-21 22:52:28 +)
are available in the Git repository at:
git://github.com/bonzini/qemu.git tags/for-upstream-hvf
for you to fetch chan
Hi Igor,
> -Original Message-
> From: Igor Mammedov [mailto:imamm...@redhat.com]
> Sent: Saturday, December 23, 2017 3:03 AM
> To: Zhoujian (jay)
> Cc: Huangweidong (C) ; m...@redhat.com; wangxin
> (U) ; qemu-devel@nongnu.org; Liuzhe (Cloud
> Open Labs, NFV) ; dgilb...@redhat.com; Gonglei
> -Original Message-
> From: Igor Mammedov [mailto:imamm...@redhat.com]
> Sent: Saturday, December 23, 2017 12:25 AM
> To: Zhoujian (jay)
> Cc: qemu-devel@nongnu.org; m...@redhat.com; Huangweidong (C)
> ; Gonglei (Arei) ;
> wangxin (U) ; Liuzhe (Cloud Open Labs, NFV)
> ; dgilb...@redhat.co
On Sat, Dec 23, 2017 at 11:59:54AM +0900, Tetsuo Handa wrote:
> Matthew Wilcox wrote:
> > + bit %= IDA_BITMAP_BITS;
> > + radix_tree_iter_init(&iter, index);
> > + slot = idr_get_free_cmn(root, &iter, GFP_NOWAIT | __GFP_NOWARN, index);
> > + if (IS_ERR(slot)) {
> > + if (slot == E
Don't load jump target into the CPU config, instead put it and initial
a2 as literals into the mini bootloader and use l32r to load them
natively. With these changes it should be possible to do warm reboot of
the guest.
Signed-off-by: Max Filippov
---
hw/xtensa/xtfpga.c | 28
Matthew Wilcox wrote:
> +/**
> + * xb_set_bit() - Set a bit in the XBitmap.
> + * @xb: The XBitmap.
> + * @bit: Index of the bit to set.
> + *
> + * This function is used to set a bit in the xbitmap.
> + *
> + * Return: 0 on success. -ENOMEM if memory could not be allocated.
> + */
> +int xb_set_bi
In big-endian mode, stlxp would not only store the individual doublewords
big-endian but also swap them in memory. This does not correspond to how ldxp
behaves nor how native code expects the result of stlxp to be stored in memory.
Also, when comparing if the values in memory still match what was
We have found it useful to be able to set the linkspeed and duplex
settings from the host-side for virtio_net. This obviates the need
for guest changes and settings for these fields, and does not require
custom ethtool commands for virtio_net.
In prepartion for using some of the high order feature bits, make sure that
virtio-net uses 64-bit values everywhere.
Signed-off-by: Jason Baron
Cc: "Michael S. Tsirkin"
Cc: Jason Wang
---
hw/net/virtio-net.c| 54 +-
include/hw/virtio/virtio-
The ability to set speed and duplex for virtio_net in useful in various
scenarios as described here:
16032be virtio_net: add ethtool support for set and get of settings
However, it would be nice to be able to set this from the hypervisor,
such that virtio_net doesn't require custom guest ethtool
Although linkspeed and duplex can be set in a linux guest via 'ethtool -s',
this requires custom ethtool commands for virtio-net by default.
Introduce a new feature flag, VIRTIO_NET_F_SPEED_DUPLEX, which allows
the hypervisor to export a linkspeed and duplex setting. The user can
subsequently over
On Fri, Dec 22, 2017 at 11:47:00AM -0800, Alistair Francis wrote:
> On Fri, Dec 22, 2017 at 10:45 AM, Alistair Francis
> wrote:
> > On Wed, Dec 20, 2017 at 2:06 PM, Eduardo Habkost
> > wrote:
> >> On Tue, Dec 19, 2017 at 05:03:59PM -0800, Alistair Francis wrote:
> >>> On Tue, Dec 19, 2017 at 4:5
On Fri, Dec 22, 2017 at 07:48:55PM +0100, Igor Mammedov wrote:
> On Fri, 15 Dec 2017 16:45:55 +0800
> Jay Zhou wrote:
>
> > If the VM already has N(N>8) available memory slots for vhost user,
> > the VM will be crashed in vhost_user_set_mem_table if we try to
> > hotplug the first vhost user NIC.
On Fri, Dec 22, 2017 at 12:30 PM, Markus Armbruster wrote:
> Alistair Francis writes:
>
>> On Fri, Dec 22, 2017 at 9:17 AM, Thomas Huth wrote:
>>> On 22.12.2017 16:37, Markus Armbruster wrote:
Second thoughts...
Alistair Francis writes:
>>> [...]
> #include "qemu/osdep.h"
>>
Alistair Francis writes:
> On Fri, Dec 22, 2017 at 9:17 AM, Thomas Huth wrote:
>> On 22.12.2017 16:37, Markus Armbruster wrote:
>>> Second thoughts...
>>>
>>> Alistair Francis writes:
>> [...]
#include "qemu/osdep.h"
+#include "qemu/error-report.h"
#include "qapi/error.h"
We can now merge the r_offset and w_offset into a single rw_offset.
This is possible since when the offset is used for writing in
RECEPTION state then reads are ignore. Conversely, when the offset
is used for reading when in COMPLETION state, then writes are
ignored.
Signed-off-by: Stefan Berger
Now that we have a single buffer, we also only need a single set of
read/write offsets into that buffer. This works since only one
locality can be active.
Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
---
hw/tpm/tpm_tis.c | 57 +++---
Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
---
hw/tpm/tpm_tis.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
index b8e811b..ac5f51f 100644
--- a/hw/tpm/tpm_tis.c
+++ b/hw/tpm/tpm_tis.c
@@ -974,7 +974,7 @@ static const Me
From: Stefan Berger
More recent specs of the TPM2 ACPI table add fields for the log area
start address and the log area minimum size, which we already use
for the TCPA table.
Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
---
hw/i386/acpi-build.c| 19 ++-
This is a preparatory patch for the subsequent ones where we
get rid of the flexibility of supporting any kind of buffer size
that the backend may support. We keep the size at 4096, which is
also the size the external emulator supports. So, limit the size
of the buffer we can support and pass it ba
Remove usage of TPMSizeBuffer. The size of the buffers is limited now
by s->be_buffer_size, which is the size of the buffer the TIS has
negotiated with the backend.
Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
---
hw/tpm/tpm_tis.c | 68
Since we can only be in read or write mode, we can merge the buffers
into a single buffer.
Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
---
hw/tpm/tpm_tis.c | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/hw/tpm/tpm_tis.c b/hw/t
One read buffer and one write buffer is sufficient for all localities.
The localities cannot all be active at the same time, and only the active
locality can use the r/w buffers. Inactive localities will require the
COMMAND_READY flag to be set on the STS register to move to the READY
state, which
Move the definition of TPMSizedBuffer out of tpm_tis.c into tpm_util.h
and implement tpm_sized_buffer_reset() for the following patches to use.
Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
---
hw/tpm/tpm_tis.c | 5 -
hw/tpm/tpm_util.c | 7 +++
hw/tpm/tpm_util.h | 7 +
Add a caching layer for the TPM established flag so that we don't
need to go to the emulator every time the flag is read by accessing
the REG_ACCESS register.
Signed-off-by: Stefan Berger
Reviewed-by: Marc-André Lureau
---
hw/tpm/tpm_emulator.c | 17 ++---
1 file changed, 14 inserti
The following series of patches most important parts add a caching layer
to the TPM emulator backend for reducing the number of control commands sent
to retrieve the TPMEstablished flag. They also simplify the TPM TIS internal
usage of buffers and r/w offsets in preparation for adding migration sup
On Fri, Dec 22, 2017 at 9:17 AM, Thomas Huth wrote:
> On 22.12.2017 16:37, Markus Armbruster wrote:
>> Second thoughts...
>>
>> Alistair Francis writes:
> [...]
>>> #include "qemu/osdep.h"
>>> +#include "qemu/error-report.h"
>>> #include "qapi/error.h"
>>> #include "qemu-common.h"
>>> #includ
On Fri, Dec 22, 2017 at 10:45 AM, Alistair Francis
wrote:
> On Wed, Dec 20, 2017 at 2:06 PM, Eduardo Habkost wrote:
>> On Tue, Dec 19, 2017 at 05:03:59PM -0800, Alistair Francis wrote:
>>> On Tue, Dec 19, 2017 at 4:55 PM, Alistair Francis
>>> wrote:
>>> > On Tue, Dec 19, 2017 at 4:43 PM, Peter M
On Thu, Dec 14, 2017 at 12:08:55PM +0800, Dou Liyang wrote:
> It may be hard to read the assignment statement of "next_base", so
>
> S/next_base += (1ULL << 32) - pcms->below_4g_mem_size;
> /next_base = mem_base + mem_len;
>
> ... for readability.
>
> No functionality change.
>
> Signed-off-by
On Fri, Dec 22, 2017 at 08:24:34PM +0100, Igor Mammedov wrote:
> On Wed, 20 Dec 2017 19:38:20 -0200
> Eduardo Habkost wrote:
>
> > On Tue, Dec 19, 2017 at 12:01:59PM +0800, Dou Liyang wrote:
> > > Hi Eduardo,
> > >
> > > At 12/19/2017 06:09 AM, Eduardo Habkost wrote:
> > > > On Thu, Dec 14, 2017
On Wed, 20 Dec 2017 19:38:20 -0200
Eduardo Habkost wrote:
> On Tue, Dec 19, 2017 at 12:01:59PM +0800, Dou Liyang wrote:
> > Hi Eduardo,
> >
> > At 12/19/2017 06:09 AM, Eduardo Habkost wrote:
> > > On Thu, Dec 14, 2017 at 12:08:53PM +0800, Dou Liyang wrote:
> > > > These are the patches left over
On 12/22/2017 12:52 PM, Marc-André Lureau wrote:
Hi
On Fri, Dec 22, 2017 at 6:47 PM, Stefan Berger
wrote:
On 12/22/2017 11:13 AM, Marc-André Lureau wrote:
Hi
On Fri, Dec 22, 2017 at 4:59 PM, Stefan Berger
wrote:
On 12/22/2017 07:49 AM, Marc-André Lureau wrote:
Hi
On Fri, Nov 10, 2017 at
On Mon, 18 Dec 2017 20:13:39 +
"Dr. David Alan Gilbert (git)" wrote:
> From: "Dr. David Alan Gilbert"
>
> Remove the old update mechanism, vhost_set_memory, and the functions
> and flags it used.
>
> Signed-off-by: Dr. David Alan Gilbert
> ---
[...]
> -
> -static void vhost_set_memory(Me
On Fri, 22 Dec 2017 17:25:13 +0100
Igor Mammedov wrote:
> On Fri, 15 Dec 2017 16:45:54 +0800
> Jay Zhou wrote:
[...]
> > +static void vhost_user_set_used_memslots(struct vhost_dev *dev)
> > +{
> > +int counter = 0;
> > +int i;
> > +
> > +for (i = 0; i < dev->mem->nregions; ++i) {
>
On Fri, 15 Dec 2017 16:45:55 +0800
Jay Zhou wrote:
> If the VM already has N(N>8) available memory slots for vhost user,
> the VM will be crashed in vhost_user_set_mem_table if we try to
> hotplug the first vhost user NIC.
> This patch checks if memslots number exceeded or not after updating
> vh
Hi
On Mon, Oct 23, 2017 at 4:18 PM, Marc-André Lureau
wrote:
> Add a new Linux-specific memory backend, similar to hostmem-file,
> except that it doesn't need file path. It also try to enforce memory
> sealing if available. It is thus slightly easier and secure, and is
> compatible with transpare
On Wed, Dec 20, 2017 at 2:06 PM, Eduardo Habkost wrote:
> On Tue, Dec 19, 2017 at 05:03:59PM -0800, Alistair Francis wrote:
>> On Tue, Dec 19, 2017 at 4:55 PM, Alistair Francis
>> wrote:
>> > On Tue, Dec 19, 2017 at 4:43 PM, Peter Maydell
>> > wrote:
>> >> On 20 December 2017 at 00:27, Alistair
Hi
On Fri, Dec 22, 2017 at 6:47 PM, Stefan Berger
wrote:
> On 12/22/2017 11:13 AM, Marc-André Lureau wrote:
>>
>> Hi
>>
>> On Fri, Dec 22, 2017 at 4:59 PM, Stefan Berger
>> wrote:
>>>
>>> On 12/22/2017 07:49 AM, Marc-André Lureau wrote:
Hi
On Fri, Nov 10, 2017 at 3:11 PM, Ste
On 12/22/2017 11:13 AM, Marc-André Lureau wrote:
Hi
On Fri, Dec 22, 2017 at 4:59 PM, Stefan Berger
wrote:
On 12/22/2017 07:49 AM, Marc-André Lureau wrote:
Hi
On Fri, Nov 10, 2017 at 3:11 PM, Stefan Berger
wrote:
This set of patches implements support for migrating the state of the
external
On 22.12.2017 16:37, Markus Armbruster wrote:
> Second thoughts...
>
> Alistair Francis writes:
[...]
>> #include "qemu/osdep.h"
>> +#include "qemu/error-report.h"
>> #include "qapi/error.h"
>> #include "qemu-common.h"
>> #include "cpu.h"
>> @@ -1311,8 +1312,8 @@ static void omap_prcm_apll_up
> On Dec 22, 2017, at 11:52 AM, Paolo Bonzini wrote:
>
> On 22/12/2017 17:51, Programmingkid wrote:
>> Thanks. When I tried using qemu-system-i386 with the -accel hvf feature I
>> saw this error: accel=hvf: No accelerator found.
>>
>> I tried to build the qemu-system-x86_64 target but I also s
On 22/12/2017 17:51, Programmingkid wrote:
> Thanks. When I tried using qemu-system-i386 with the -accel hvf feature I saw
> this error: accel=hvf: No accelerator found.
>
> I tried to build the qemu-system-x86_64 target but I also saw this error:
>
> /Users/misbah/desktop/qemu/target/i386/hvf/x
> On Dec 22, 2017, at 11:42 AM, Paolo Bonzini wrote:
>
> On 22/12/2017 17:26, Programmingkid wrote:
>> I was able to clone your git repository and successfully build the hvf
>> branch. The latest commit is this:
>>
>> commit aabe2a1a77b70efe96c9345f737068a0dcef0281 (HEAD -> hvf, origin/hvf)
>>
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20171222151846.28110-1-kw...@redhat.com
Subject: [Qemu-devel] [PULL v3 00/35] Block layer patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneli
On 22/12/2017 17:26, Programmingkid wrote:
> I was able to clone your git repository and successfully build the hvf
> branch. The latest commit is this:
>
> commit aabe2a1a77b70efe96c9345f737068a0dcef0281 (HEAD -> hvf, origin/hvf)
> Author: Paolo Bonzini
> Date: Thu Dec 21 00:10:03 2017 +0100
Am 22.12.2017 um 17:12 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 22.12.2017 18:43, Kevin Wolf wrote:
> > Am 22.12.2017 um 15:25 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > 22.12.2017 16:39, Kevin Wolf wrote:
> > > > Am 12.12.2017 um 17:04 hat Vladimir Sementsov-Ogievskiy geschrieben:
> On Dec 22, 2017, at 9:10 AM, qemu-devel-requ...@nongnu.org wrote:
>
> Message: 16
> Date: Fri, 22 Dec 2017 15:03:04 +0100
> From: Paolo Bonzini
> To: Peter Maydell
> Cc: QEMU Developers
> Subject: Re: [Qemu-devel] [PULL v3 00/19] Initial support for
> Hypervisor.framework
> Message-ID:
On Fri, 15 Dec 2017 16:45:54 +0800
Jay Zhou wrote:
> Used_memslots is equal to dev->mem->nregions now, it is true for
> vhost kernel, but not for vhost user, which uses the memory regions
> that have file descriptor. In fact, not all of the memory regions
> have file descriptor.
> It is usefully
22.12.2017 18:43, Kevin Wolf wrote:
Am 22.12.2017 um 15:25 hat Vladimir Sementsov-Ogievskiy geschrieben:
22.12.2017 16:39, Kevin Wolf wrote:
Am 12.12.2017 um 17:04 hat Vladimir Sementsov-Ogievskiy geschrieben:
Consider migration with shared storage. Persistent bitmaps are stored
on bdrv_inacti
Hi
On Fri, Dec 22, 2017 at 4:59 PM, Stefan Berger
wrote:
> On 12/22/2017 07:49 AM, Marc-André Lureau wrote:
>>
>> Hi
>>
>> On Fri, Nov 10, 2017 at 3:11 PM, Stefan Berger
>> wrote:
>>>
>>> This set of patches implements support for migrating the state of the
>>> external 'swtpm' TPM emulator as w
On 22/12/2017 02:51, Haozhong Zhang wrote:
> When -no-acpi option is used with Q35 machine type, no guest ACPI is
> built, but the ACPI device is still created, so only checking the
> presence of ACPI device before memory plug/unplug is not enough in
> such cases. Check whether ACPI is disabled glo
On Fri, Dec 22, 2017 at 04:55:22PM +0100, Paolo Bonzini wrote:
> scsi_disk_emulate_command passes in_buf == NULL when sent a REQUEST
> SENSE command. Check for in_len == 0 before dereferencing in_buf.
>
> Fixes: f68d98b21fa74155dc7c1fd212474379ac3c7531
> Reported-by: Roman Kagan
> Signed-off-by:
On 12/22/2017 02:53 AM, Vladimir Sementsov-Ogievskiy wrote:
21.12.2017 21:32, Eric Blake wrote:
On 12/21/2017 09:28 AM, Markus Armbruster wrote:
Looks like you forgot to cc: Eric. Fixing...
Or that he did cc me, and the mailman bug ate the cc line because of
my list subscription settings. (
Am 22.12.2017 um 15:25 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 22.12.2017 16:39, Kevin Wolf wrote:
> > Am 12.12.2017 um 17:04 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > Consider migration with shared storage. Persistent bitmaps are stored
> > > on bdrv_inactivate. Then, on destinat
On 12/22/2017 07:49 AM, Marc-André Lureau wrote:
Hi
On Fri, Nov 10, 2017 at 3:11 PM, Stefan Berger
wrote:
This set of patches implements support for migrating the state of the
external 'swtpm' TPM emulator as well as that of the emulated device
interfaces. I have primarily tested this with the
scsi_disk_emulate_command passes in_buf == NULL when sent a REQUEST
SENSE command. Check for in_len == 0 before dereferencing in_buf.
Fixes: f68d98b21fa74155dc7c1fd212474379ac3c7531
Reported-by: Roman Kagan
Signed-off-by: Paolo Bonzini
---
scsi/utils.c | 12 ++--
1 file changed, 6 inse
On Linux, a mouse event is generated for both down and up when mouse
wheel is used. This caused virtio_input_send() to be called twice each
time the wheel was used.
This commit adds a check for the button down state and only calls
virtio_input_send() when it is true.
Signed-off-by: Miika S
---
Signed-off-by: Miika S
---
hw/input/virtio-input-hid.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/input/virtio-input-hid.c b/hw/input/virtio-input-hid.c
index 9628d289f9..2cac659469 100644
--- a/hw/input/virtio-input-hid.c
+++ b/hw/input/virtio-input-hid.c
@@ -154,6 +154,8 @@ static
Second thoughts...
Alistair Francis writes:
> Replace a large number of the fprintf(stderr, "*\n" calls with
> error_report(). The functions were renamed with these commands and then
> compiler issues where manually fixed.
>
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fp
We need to remember how many of the drain sections in which a node is
were recursive (i.e. subtree drain rather than node drain), so that they
can be correctly applied when children are added or removed during the
drained section.
With this change, it is safe to modify the graph even inside a
bdrv
On Wed, Dec 20, 2017 at 06:14:44PM +0100, Paolo Bonzini wrote:
> @@ -274,52 +319,21 @@ const struct SCSISense sense_code_SPACE_ALLOC_FAILED = {
> int scsi_convert_sense(uint8_t *in_buf, int in_len,
> uint8_t *buf, int len, bool fixed)
> {
> -bool fixed_in;
> SCSIS
Alistair Francis writes:
> Replace a large number of the fprintf(stderr, "*\n" calls with
> error_report(). The functions were renamed with these commands and then
> compiler issues where manually fixed.
>
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,
> "\(
Test that drain sections are correctly propagated through the graph.
Signed-off-by: Kevin Wolf
---
tests/test-bdrv-drain.c | 74 +
1 file changed, 74 insertions(+)
diff --git a/tests/test-bdrv-drain.c b/tests/test-bdrv-drain.c
index 354c6151a0..69
Signed-off-by: Kevin Wolf
---
tests/test-bdrv-drain.c | 80 +
1 file changed, 80 insertions(+)
diff --git a/tests/test-bdrv-drain.c b/tests/test-bdrv-drain.c
index 690b585b4d..d760e2b243 100644
--- a/tests/test-bdrv-drain.c
+++ b/tests/test-bdrv-dr
Add a subtree drain version to the existing test cases.
Signed-off-by: Kevin Wolf
---
tests/test-bdrv-drain.c | 27 ++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/tests/test-bdrv-drain.c b/tests/test-bdrv-drain.c
index 9098b77ab4..f363d51b34 100644
---
This patchset adds some missing keys and mouse buttons to
hw/input/virtio-input-hid.c.
On a JIS keyboard such as this one (106/109 - JIS)
https://upload.wikimedia.org/wikipedia/commons/b/b2/Physical_keyboard_layouts_comparison_ANSI_ISO_KS_ABNT_JIS.png
the keys are located as follows:
muhenkan: lef
If bdrv_do_drained_begin/end() are called in coroutine context, they
first use a BH to get out of the coroutine context. Call some existing
tests again from a coroutine to cover this code path.
Signed-off-by: Kevin Wolf
---
tests/test-bdrv-drain.c | 59 +++
This is in preparation for subtree drains, i.e. drained sections that
affect not only a single node, but recursively all child nodes, too.
Calling the parent callbacks for drain is pointless when we just came
from that parent node recursively and leads to multiple increases of
bs->quiesce_counter
Signed-off-by: Kevin Wolf
---
tests/test-bdrv-drain.c | 57 +
1 file changed, 57 insertions(+)
diff --git a/tests/test-bdrv-drain.c b/tests/test-bdrv-drain.c
index 6da66ae841..9098b77ab4 100644
--- a/tests/test-bdrv-drain.c
+++ b/tests/test-bdrv-dr
Block jobs must be paused if any of the involved nodes are drained.
Signed-off-by: Kevin Wolf
---
tests/test-bdrv-drain.c | 121
1 file changed, 121 insertions(+)
diff --git a/tests/test-bdrv-drain.c b/tests/test-bdrv-drain.c
index 323cb0b961..97
bdrv_drained_begin() waits for the completion of requests in the whole
subtree, but it only actually keeps its immediate bs parameter quiesced
until bdrv_drained_end().
Add a version that keeps the whole subtree drained. As of this commit,
graph changes cannot be allowed during a subtree drained s
This is currently only working correctly for bdrv_drain(), not for
bdrv_drain_all(). Leave a comment for the drain_all case, we'll address
it later.
Signed-off-by: Kevin Wolf
---
tests/test-bdrv-drain.c | 45 +
1 file changed, 45 insertions(+)
diff --
bdrv_do_drained_begin() restricts the call of parent callbacks and
aio_disable_external() to the outermost drain section, but the block
driver callbacks are always called. bdrv_do_drained_end() must match
this behaviour, otherwise nodes stay drained even if begin/end calls
were balanced.
Signed-of
keycodemapdb updated to add the QKeyCodes muhenkan and katakanahiragana
Signed-off-by: Miika S
---
hw/input/virtio-input-hid.c | 7 +++
qapi/ui.json| 5 -
ui/keycodemapdb | 2 +-
3 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/hw/input/virtio-i
Block jobs already paused themselves when their main BlockBackend
entered a drained section. This is not good enough: We also want to
pause a block job and may not submit new requests if, for example, the
mirror target node should be drained.
This implements .drained_begin/end callbacks in child_j
Block jobs are already paused using the BdrvChildRole drain callbacks,
so we don't need an additional block_job_pause_all() call.
Signed-off-by: Kevin Wolf
---
block/io.c | 4
tests/test-bdrv-drain.c | 10 --
2 files changed, 4 insertions(+), 10 deletions(-)
diff --gi
bdrv_drained_begin() doesn't increase bs->quiesce_counter recursively
and also doesn't notify other parent nodes of children, which both means
that the child nodes are not actually drained, and bdrv_drained_begin()
is providing useful functionality only on a single node.
To keep things consistent,
The existing test is for bdrv_drain_all_begin/end() only. Generalise the
test case so that it can be run for the other variants as well. At the
moment this is only bdrv_drain_begin/end(), but in a while, we'll add
another one.
Also, add a backing file to the test node to test whether the operation
Signed-off-by: Kevin Wolf
Reviewed-by: Fam Zheng
---
block/io.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/block/io.c b/block/io.c
index cf780c3cb0..b94740b8ff 100644
--- a/block/io.c
+++ b/block/io.c
@@ -330,6 +330,12 @@ void bdrv_drain_all_begin(void)
BdrvNextIterator it;
From: Fam Zheng
Signed-off-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
include/block/block_int.h | 1 -
block/io.c| 18 --
2 files changed, 19 deletions(-)
diff --git a/include/block/block_int.h b/include/block/block_int.h
index a5482775ec..e107163594 100644
-
Alistair Francis writes:
> Replace a large number of the fprintf(stderr, "*\n" calls with
> error_report(). The functions were renamed with these commands and then
> compiler issues where manually fixed.
>
> find ./* -type f -exec sed -i \
> 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,
> "\(
From: Thomas Huth
Looks like we forgot to announce the deprecation of these options in
the corresponding chapter of the qemu-doc text, so let's do that now.
Signed-off-by: Thomas Huth
Reviewed-by: John Snow
Reviewed-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
qemu-doc.texi | 15
From: Thomas Huth
It's not working anymore since QEMU v1.3.0 - time to remove it now.
Signed-off-by: Thomas Huth
Reviewed-by: John Snow
Reviewed-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
blockdev.c| 11 ---
qemu-doc.texi | 6 --
2 files changed, 17 deletions(-)
d
From: Thomas Huth
It's been marked as deprecated since QEMU v2.10.0, and so far nobody
complained that we should keep it, so let's remove this legacy option
now to simplify the code quite a bit.
Signed-off-by: Thomas Huth
Reviewed-by: John Snow
Reviewed-by: Markus Armbruster
Signed-off-by: Ke
Since commit bde70715, base is the only node that is reopened in
commit_start(). This means that the code, which still involves an
explicit BlockReopenQueue, can now be simplified by using bdrv_reopen().
Signed-off-by: Kevin Wolf
Reviewed-by: Fam Zheng
---
block/commit.c | 8 +---
1 file ch
Removing a quorum child node with x-blockdev-change results in a quorum
driver state that cannot be recreated with create options because it
would require a list with gaps. This causes trouble in at least
.bdrv_refresh_filename().
Document this problem so that we won't accidentally mark the comman
From: Fam Zheng
Management tools create overlays of running guests with qemu-img:
$ qemu-img create -b /image/in/use.qcow2 -f qcow2 /overlay/image.qcow2
but this doesn't work anymore due to image locking:
qemu-img: /overlay/image.qcow2: Failed to get shared "write" lock
Is another pr
From: Edgar Kaziakhmedov
Since bdrv_co_preadv does all neccessary checks including
reading after the end of the backing file, avoid duplication
of verification before bdrv_co_preadv call.
Signed-off-by: Edgar Kaziakhmedov
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Signe
The bdrv_reopen*() implementation doesn't like it if the graph is
changed between queuing nodes for reopen and actually reopening them
(one of the reasons is that queuing can be recursive).
So instead of draining the device only in bdrv_reopen_multiple(),
require that callers already drained all a
This adds a test case that the BlockDriver callbacks for drain are
called in bdrv_drained_all_begin/end(), and that both of them are called
exactly once.
Signed-off-by: Kevin Wolf
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
---
tests/test-bdrv-drain.c | 137 +++
Commit 15afd94a047 added code to acquire and release the AioContext in
qemuio_command(). This means that the lock is taken twice now in the
call path from hmp_qemu_io(). This causes BDRV_POLL_WHILE() to hang for
any requests issued to nodes in a non-mainloop AioContext.
Dropping the first locking
Now that the bdrv_drain_invoke() calls are pulled up to the callers of
bdrv_drain_recurse(), the 'begin' parameter isn't needed any more.
Signed-off-by: Kevin Wolf
Reviewed-by: Stefan Hajnoczi
---
block/io.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/block/
From: Doug Gale
Add trace output for commands, errors, and undefined behavior.
Add guest error log output for undefined behavior.
Report invalid undefined accesses to MMIO.
Annotate unlikely error checks with unlikely.
Signed-off-by: Doug Gale
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: S
bdrv_drain_all_begin() used to call the .bdrv_co_drain_begin() driver
callback inside its polling loop. This means that how many times it got
called for each node depended on long it had to poll the event loop.
This is obviously not right and results in nodes that stay drained even
after bdrv_drai
Drain requests are propagated to child nodes, parent nodes and directly
to the AioContext. The order in which this happened was different
between all combinations of drain/drain_all and begin/end.
The correct order is to keep children only drained when their parents
are also drained. This means th
This change separates bdrv_drain_invoke(), which calls the BlockDriver
drain callbacks, from bdrv_drain_recurse(). Instead, the function
performs its own recursion now.
One reason for this is that bdrv_drain_recurse() can be called multiple
times by bdrv_drain_all_begin(), but the callbacks may on
The following changes since commit 281f327487c9c9b1599f93c589a408bbf4a651b8:
Merge remote-tracking branch 'remotes/vivier/tags/m68k-for-2.12-pull-request'
into staging (2017-12-22 00:11:36 +)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for
The device is drained, so there is no point in waiting for requests at
the end of the drained section. Remove the bdrv_drain_recurse() calls
there.
The bdrv_drain_recurse() calls were introduced in commit 481cad48e5e
in order to call the .bdrv_co_drain_end() driver callback. This is now
done by a
From: John Snow
VPC has some difficulty creating geometries of particular size.
However, we can indeed force it to use a literal one, so let's
do that for the sake of test 197, which is testing some specific
offsets.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
Commit 1f4ad7d fixed 'qemu-img info' for raw images that are currently
in use as a mirror target. It is not enough for image formats, though,
as these still unconditionally request BLK_PERM_CONSISTENT_READ.
As this permission is geared towards whether the guest-visible data is
consistent, and has
1 - 100 of 164 matches
Mail list logo
