Re: [Qemu-devel] [PATCH v20 4/7] virtio-balloon: VIRTIO_BALLOON_F_SG

2017-12-23 Thread Wei Wang
On 12/24/2017 12:45 PM, Tetsuo Handa wrote: Matthew Wilcox wrote: + unsigned long pfn = page_to_pfn(page); + int ret; + + *pfn_min = min(pfn, *pfn_min); + *pfn_max = max(pfn, *pfn_max); + + do { + if (xb_preload(GFP_NOWAIT | __GFP_NOWARN) < 0) +

Re: [Qemu-devel] [PATCH v20 3/7 RESEND] xbitmap: add more operations

2017-12-23 Thread Wei Wang
On 12/23/2017 10:33 PM, Tetsuo Handa wrote: + bitmap = rcu_dereference_raw(*slot); + if (!bitmap) { + bitmap = this_cpu_xchg(ida_bitmap, NULL); + if (!bitmap) + return -ENOMEM; I can't understand this. I can understand if it were

Re: [Qemu-devel] [PATCH v20 4/7] virtio-balloon: VIRTIO_BALLOON_F_SG

2017-12-23 Thread Tetsuo Handa
Matthew Wilcox wrote: > > + unsigned long pfn = page_to_pfn(page); > > + int ret; > > + > > + *pfn_min = min(pfn, *pfn_min); > > + *pfn_max = max(pfn, *pfn_max); > > + > > + do { > > + if (xb_preload(GFP_NOWAIT | __GFP_NOWARN) < 0) > > + return -ENOMEM; > > + >

Re: [Qemu-devel] [PATCH v20 4/7] virtio-balloon: VIRTIO_BALLOON_F_SG

2017-12-23 Thread Matthew Wilcox
On Tue, Dec 19, 2017 at 08:17:56PM +0800, Wei Wang wrote: > +/* > + * Send balloon pages in sgs to host. The balloon pages are recorded in the > + * page xbitmap. Each bit in the bitmap corresponds to a page of PAGE_SIZE. > + * The page xbitmap is searched for continuous "1" bits, which correspond

Re: [Qemu-devel] [PATCH] linux-user: MIPS set cpu to r6 CPU if binary is R6

2017-12-23 Thread Laurent Vivier
Le 19/12/2017 à 12:50, YunQiang Su a écrit : > MIPS r6 is not just simple super set for pre-R6, > it also drops some instruction and even changes encoding for some. > But r6 binary has the same header for binfmt_misc. > So here we need to detect the version of binaries and set > cpu_model for it. >

Re: [Qemu-devel] [PULL v4 00/19] Initial support for Hypervisor.framework

2017-12-23 Thread Programmingkid
> On Dec 23, 2017, at 10:13 AM, qemu-devel-requ...@nongnu.org wrote: > > The following changes since commit 43ab9a5376c95c61ae898a222c4d04bdf60e239b: > > hw/i386/vmport: fix missing definitions with non-log trace backends > (2017-12-21 22:52:28 +) > > are available in the Git repository a

Re: [Qemu-devel] [PATCH v20 3/7 RESEND] xbitmap: add more operations

2017-12-23 Thread Matthew Wilcox
On Sat, Dec 23, 2017 at 11:33:45PM +0900, Tetsuo Handa wrote: > Matthew Wilcox wrote: > > On Sat, Dec 23, 2017 at 11:59:54AM +0900, Tetsuo Handa wrote: > > > Matthew Wilcox wrote: > > > > + bit %= IDA_BITMAP_BITS; > > > > + radix_tree_iter_init(&iter, index); > > > > + slot = idr_

Re: [Qemu-devel] [PATCH v20 3/7 RESEND] xbitmap: add more operations

2017-12-23 Thread Tetsuo Handa
Matthew Wilcox wrote: > On Sat, Dec 23, 2017 at 11:59:54AM +0900, Tetsuo Handa wrote: > > Matthew Wilcox wrote: > > > + bit %= IDA_BITMAP_BITS; > > > + radix_tree_iter_init(&iter, index); > > > + slot = idr_get_free_cmn(root, &iter, GFP_NOWAIT | __GFP_NOWARN, index); > > > + if (IS_ERR(slot)) { > >

Re: [Qemu-devel] [PATCH 0/8] Small IPMI (and other) fixes

2017-12-23 Thread Corey Minyard
On 12/21/2017 05:10 PM, no-re...@patchew.org wrote: Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. The error here doesn't seem to have anything to do with these patches:

Re: [Qemu-devel] [PATCH] linux-user: Implement renameat2 when defined

2017-12-23 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20171220002941.14560-1-pal...@dabbelt.com Subject: [Qemu-devel] [PATCH] linux-user: Implement renameat2 when defined === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 tota

Re: [Qemu-devel] [PATCH 1/3] input: add missing JIS keys to virtio input

2017-12-23 Thread Miika S
Thank you for pointing out these errors. I've sent a new set of patches with the errors addressed, but later noticed that the new revision should have been titled [PATCH v2]. So to anybody reading this thread, it has been replaced with a new one. On Thu, Dec 21, 2017 at 12:35 AM, Eric Blake wrote

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [v22 1/2] virtio-crypto: Add virtio crypto device specification

2017-12-23 Thread Longpeng (Mike)
On 2017/12/18 20:29, Halil Pasic wrote: > > > On 12/18/2017 09:43 AM, Longpeng (Mike) wrote: >> Hi Halil, >> >> On 2017/12/11 21:54, Halil Pasic wrote: >> >>> >>> >>> On 12/11/2017 01:56 PM, Longpeng (Mike) wrote: On 2017/12/6 19:01, Halil Pasic wrote: > > > On

Re: [Qemu-devel] [PATCH v2 2/2] vhost: double check used memslots number

2017-12-23 Thread Zhoujian (jay)
[...] > > --- > > hw/virtio/vhost.c | 27 +++ > > 1 file changed, 23 insertions(+), 4 deletions(-) > > > > diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index > > 59a32e9..e45f5e2 100644 > > --- a/hw/virtio/vhost.c > > +++ b/hw/virtio/vhost.c > > @@ -1234,6 +1234,18

Re: [Qemu-devel] [PATCH v2 2/2] vhost: double check used memslots number

2017-12-23 Thread Zhoujian (jay)
> -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: Saturday, December 23, 2017 2:49 AM > To: Zhoujian (jay) > Cc: qemu-devel@nongnu.org; m...@redhat.com; Huangweidong (C) > ; Gonglei (Arei) ; > wangxin (U) ; Liuzhe (Cloud Open Labs, NFV) > ; dgilb...@redhat.c