Re: [Qemu-devel] [RFC v6 04/27] qobject: let object_property_get_str() use new API

2018-01-09 Thread Peter Xu
On Tue, Jan 09, 2018 at 04:53:40PM -0600, Eric Blake wrote: > On 12/19/2017 02:45 AM, Peter Xu wrote: > > We can simplify object_property_get_str() using the new > > qobject_get_try_str(). > > > > Reviewed-by: Fam Zheng > > Reviewed-by: Stefan Hajnoczi > > Signed-off-by: Peter Xu > > --- > > q

[Qemu-devel] [PATCH 0/2] tcg/ppc updates

2018-01-09 Thread Richard Henderson
I found two problems testing my ARM SVE branch on PPC64. r~ Richard Henderson (2): tcg/ppc: Support tlb offsets larger than 64k tcg/ppc: Allow a 32-bit offset to the constant pool tcg/ppc/tcg-target.inc.c | 84 +++- 1 file changed, 47 insertions

[Qemu-devel] [PATCH 2/2] tcg/ppc: Allow a 32-bit offset to the constant pool

2018-01-09 Thread Richard Henderson
We recently relaxed the limit of the number of opcodes that can appear in a TranslationBlock. In certain cases this has resulted in relocation overflow. Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.inc.c | 67 1 file changed, 39 insert

[Qemu-devel] [PATCH 1/2] tcg/ppc: Support tlb offsets larger than 64k

2018-01-09 Thread Richard Henderson
AArch64 with SVE has an offset of 80k to the 8th TLB. Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.inc.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/tcg/ppc/tcg-target.inc.c b/tcg/ppc/tcg-target.inc.c index 879885b68b..74f9b4aa34 100644 --- a/

Re: [Qemu-devel] [RFC v6 03/27] qobject: introduce qobject_get_try_str()

2018-01-09 Thread Peter Xu
On Tue, Jan 09, 2018 at 04:50:39PM -0600, Eric Blake wrote: > On 12/19/2017 02:45 AM, Peter Xu wrote: > > A quick way to fetch string from qobject when it's a QString. > > > > Reviewed-by: Fam Zheng > > Reviewed-by: Stefan Hajnoczi > > Signed-off-by: Peter Xu > > --- > > include/qapi/qmp/qstri

Re: [Qemu-devel] [PATCH v5 2/4][RFC] tap: do not close fd if only vhost failed to initialize

2018-01-09 Thread Zhoujian (jay)
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Wednesday, January 10, 2018 2:02 PM > To: Zhoujian (jay) ; qemu-devel@nongnu.org > Cc: Huangweidong (C) ; m...@redhat.com; wangxin (U) > ; Gonglei (Arei) ; > imamm...@redhat.com; Liuzhe (Ahriy, Euler) > Subject: R

Re: [Qemu-devel] [PULL 07/11] cpu-exec: don't overwrite exception_index

2018-01-09 Thread Pavel Dovgalyuk
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > On 9 January 2018 at 13:21, Pavel Dovgalyuk wrote: > > I tried to get some logs with the following code. > > It prints that there was an exception 5 and it was overwritten by the > > standard code. > > Fixed code prevents this overwrite. >

[Qemu-devel] [PATCH] target/i386: hax: Move hax_setup_qemu_emulator.

2018-01-09 Thread Tao Wu via Qemu-devel
hax_setup_qemu_emulator reference env->efer which is updated in hax_get_msrs, so it has to be called after hax_get_msrs. This fix the bug that sometimes dump_state show 32 bits regs even in 64 bits mode. Signed-off-by: Tao Wu --- target/i386/hax-all.c | 4 +--- 1 file changed, 1 insertion(+), 3

Re: [Qemu-devel] [PATCH v4 00/11] Add make check tests for Migration

2018-01-09 Thread Peter Xu
On Fri, Jan 05, 2018 at 10:52:35PM +0100, Juan Quintela wrote: > > Hi > > In v4: > > Based-on: 20180105205109.683-1-quint...@redhat.com > > Changes: > - rebase on top on v4 info_migrate patches > - Tune sleeps to make patches fast > - Create a deprecated test for deprecated commands (i.e. make

Re: [Qemu-devel] [PATCH v4 05/11] tests: Add deprecated commands migration test

2018-01-09 Thread Peter Xu
On Fri, Jan 05, 2018 at 10:52:40PM +0100, Juan Quintela wrote: > We add deprecated commands on a new test, so we don't have to add it > on normal tests. > > Signed-off-by: Juan Quintela > --- > tests/migration-test.c | 59 > ++ > 1 file changed, 5

[Qemu-devel] [PATCH 1/2] target/arm: Split out vfp_expand_imm

2018-01-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 44 1 file changed, 28 insertions(+), 16 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index ecb72e4d9c..e03cd3801a 100644 --- a/target/arm/translate

[Qemu-devel] [PATCH 2/2] target/arm: Add fp16 support to vfp_expand_imm

2018-01-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index e03cd3801a..4fe9d82a55 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -5035,6 +5035,1

[Qemu-devel] [PATCH 0/2] target/arm: split out vfp_expand_imm

2018-01-09 Thread Richard Henderson
One more piece of target/arm prep work from my SVE branch. I saw that Alex was touching the same bit of code in his ARMv8.2 fp16 patch set and thought we should coordinate on this. r~ Richard Henderson (2): target/arm: Split out vfp_expand_imm target/arm: Add fp16 support to vfp_expand_imm

Re: [Qemu-devel] [PATCH v4 04/11] tests: Use consistent names and sizes for migration

2018-01-09 Thread Peter Xu
On Fri, Jan 05, 2018 at 10:52:39PM +0100, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/migration-test.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/tests/migration-test.c b/tests/migration-test.c > index d81f22118b..f469235d0b 100644

Re: [Qemu-devel] [PATCH v4 02/11] tests: Migration ppc test was missing arguments

2018-01-09 Thread Peter Xu
On Fri, Jan 05, 2018 at 10:52:37PM +0100, Juan Quintela wrote: > Argument file is also needed there. > > Signed-off-by: Juan Quintela Reviewed-by: Peter Xu Does it also mean this? Fixes: aaf89c8a49a8c ("test: port postcopy test to ppc64") > --- > tests/migration-test.c | 3 ++- > 1 file cha

Re: [Qemu-devel] [PATCH 1/2] Add save-snapshot, load-snapshot and delete-snapshot to QAPI

2018-01-09 Thread Peter Xu
On Sun, Jan 07, 2018 at 01:23:35PM +0100, Richard Palethorpe wrote: > Add QAPI wrapper functions for the existing snapshot functionality. These > functions behave the same way as the HMP savevm, loadvm and delvm > commands. This will allow applications, such as OpenQA, to programmatically > revert

Re: [Qemu-devel] [PATCH v5 2/4][RFC] tap: do not close fd if only vhost failed to initialize

2018-01-09 Thread Jason Wang
On 2018年01月10日 12:18, Zhoujian (jay) wrote: Sorry about missing to cc Jason. Close the fd of the tap unconditionally when netdev_add tap,id=net0,vhost=on failed in net_init_tap_one() will make the followed up device_add virtio-net-pci,netdev=net0 failed too, which prints: TUNSETOFFLOA

Re: [Qemu-devel] [v23 1/2] virtio-crypto: Add virtio crypto device specification

2018-01-09 Thread Longpeng (Mike)
Hi Halil, We are fixing the Intel BUG these days, so I will go through your comments after we're done. Thanks. -- Regards, Longpeng(Mike) On 2018/1/10 1:05, Halil Pasic wrote: > > > On 12/30/2017 10:35 AM, Longpeng(Mike) wrote: >> From: Gonglei >> >> The virtio crypto device is a virtual cr

[Qemu-devel] [PATCH] tcg/arm: Fix double-word comparisons

2018-01-09 Thread Richard Henderson
The code sequence we were generating was only good for unsigned comparisons. For signed comparisions, use the sequence from gcc. Fixes booting of ppc64 firmware, with a patch changing the code sequence for ppc comparisons. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.inc.c | 112 +++

Re: [Qemu-devel] [PATCH v14 2/9] ACPI: Add APEI GHES table generation and CPER record support

2018-01-09 Thread gengdongjiu
Peter, Thank you very much for your time to review it and give some comments. On 2018/1/10 0:51, Peter Maydell wrote: >> the error type to Multi-bit ECC. >> >> [1]: >> UEFI Spec 2.6 Errata A: >> >> "N.2.5 Memory Error Section" >> -+---+--+-

Re: [Qemu-devel] [QEMU-PPC] [RFC 3/3] target/ppc: Add H-Call H_GET_CPU_CHARACTERISTICS

2018-01-09 Thread David Gibson
On Tue, Jan 09, 2018 at 08:21:03PM +1100, Suraj Jitindar Singh wrote: > The new H-Call H_GET_CPU_CHARACTERISTICS is used by the guest to query > behaviours and available characteristics of the cpu. > > Implement the handler for this new H-Call which formulates its response > based on the setting o

Re: [Qemu-devel] [QEMU-PPC] [RFC 2/3] hw/spapr/spapr_caps: Add new caps safe_[cache/bounds_check/indirect_branch]

2018-01-09 Thread David Gibson
On Tue, Jan 09, 2018 at 08:21:02PM +1100, Suraj Jitindar Singh wrote: > This patch adds three new capabilities: > cap-cfpc -> safe_cache > cap-sbbc -> safe_bounds_check > cap-ibs -> safe_indirect_branch > > Each capability is tristate with the possible values "broken", > "workaround" or "fixed".

Re: [Qemu-devel] [PULL 00/14] Migration pull request

2018-01-09 Thread Alexey Perevalov
On 01/05/2018 12:59 PM, Juan Quintela wrote: Eric Blake wrote: On 01/03/2018 03:38 AM, Juan Quintela wrote: Hi This are the changes for migration that are already reviewed. Please, apply. Alexey Perevalov (6): migration: introduce postcopy-blocktime capability migration: add p

Re: [Qemu-devel] [RFC v6 00/27] QMP: out-of-band (OOB) execution support

2018-01-09 Thread Peter Xu
On Tue, Jan 09, 2018 at 02:52:49PM +, Stefan Hajnoczi wrote: > On Tue, Dec 19, 2017 at 04:45:30PM +0800, Peter Xu wrote: > > This v6 kept most of the high level design untouched, however there > > are quite a few of changes that try to make the series more robust and > > safe. My sincere thank

Re: [Qemu-devel] [PATCH v5 2/4][RFC] tap: do not close fd if only vhost failed to initialize

2018-01-09 Thread Zhoujian (jay)
Sorry about missing to cc Jason. Close the fd of the tap unconditionally when netdev_add tap,id=net0,vhost=on failed in net_init_tap_one() will make the followed up device_add virtio-net-pci,netdev=net0 failed too, which prints: TUNSETOFFLOAD ioctl() failed: Bad file descriptor TUNSETOFFLO

Re: [Qemu-devel] [QEMU-PPC] [RFC 1/3] hw/ppc/spapr_caps: Rework spapr_caps to use uint8 internal representation

2018-01-09 Thread David Gibson
On Tue, Jan 09, 2018 at 08:21:01PM +1100, Suraj Jitindar Singh wrote: > Currently spapr_caps are tied to boolean values (on or off). This patch > reworks the caps so that they can have any value between 0 and 127, > inclusive. This allows more capabilities with various values to be > represented in

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [RFC 1/3] hw/ppc/spapr_caps: Rework spapr_caps to use uint8 internal representation

2018-01-09 Thread David Gibson
On Wed, Jan 10, 2018 at 11:19:33AM +1100, Suraj Jitindar Singh wrote: > On Tue, 2018-01-09 at 13:07 +0100, Andrea Bolognani wrote: > > On Tue, 2018-01-09 at 20:21 +1100, Suraj Jitindar Singh wrote: > > [...] > > > +static void cap_htm_allow(sPAPRMachineState *spapr, uint8_t val, > > > Error **errp)

Re: [Qemu-devel] Call for GSoC & Outreachy 2018 mentors & project ideas

2018-01-09 Thread Fam Zheng
On Tue, 01/09 13:45, Alistair Francis wrote: > On Tue, Jan 2, 2018 at 12:23 PM, Stefan Hajnoczi wrote: > > QEMU will apply to the Google Summer of Code > > (https://summerofcode.withgoogle.com/) and Outreachy > > (https://www.outreachy.org/) open source internship programs again > > this year. > >

Re: [Qemu-devel] [PULL 00/12] ppc-for-2.12 queue 20180108

2018-01-09 Thread David Gibson
On Tue, Jan 09, 2018 at 03:15:25PM +, Peter Maydell wrote: > On 9 January 2018 at 12:16, David Gibson wrote: > > Thanks. Even if you can identify which patch it is and we can > > postpone that one would be a bug help. > > Bisection blames this one: > > pbonz...@redhat.com (1): > targe

Re: [Qemu-devel] [PATCH] maint: Mention web site maintenance in README

2018-01-09 Thread Fam Zheng
On Wed, 11/29 09:25, Eric Blake wrote: > Now that we have a website that accepts patches on the list, the > main project should make it easier to find information about that > process. > > Signed-off-by: Eric Blake Reviewed-by: Fam Zheng

Re: [Qemu-devel] [PULL 00/12] ppc-for-2.12 queue 20180108

2018-01-09 Thread Richard Henderson
On 01/09/2018 07:15 AM, Peter Maydell wrote: > (This is a build for arm32, running in a chroot on an aarch64 > box, non-debug build.) It's an arm backend problem. For 64-bit setcond2, we do 0x6e5c3fa4: e1570008 cmp r7, r8 0x6e5c3fa8: 01550004 cmpeqr5, r4 0x6e5c3fac: b3a09001 movlt

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [RFC 3/3] target/ppc: Add H-Call H_GET_CPU_CHARACTERISTICS

2018-01-09 Thread Suraj Jitindar Singh
On Tue, 2018-01-09 at 09:19 -0200, Murilo Opsfelder Araújo wrote: > On 01/09/2018 07:21 AM, Suraj Jitindar Singh wrote: > > The new H-Call H_GET_CPU_CHARACTERISTICS is used by the guest to > > query > > behaviours and available characteristics of the cpu. > > > > Implement the handler for this new

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [RFC 2/3] hw/spapr/spapr_caps: Add new caps safe_[cache/bounds_check/indirect_branch]

2018-01-09 Thread Suraj Jitindar Singh
On Tue, 2018-01-09 at 09:15 -0200, Murilo Opsfelder Araújo wrote: > On 01/09/2018 07:21 AM, Suraj Jitindar Singh wrote: > > This patch adds three new capabilities: > > cap-cfpc -> safe_cache > > cap-sbbc -> safe_bounds_check > > cap-ibs -> safe_indirect_branch > > Hi, Suraj. > > What about split

Re: [Qemu-devel] [QEMU-PPC] [RFC 2/3] hw/spapr/spapr_caps: Add new caps safe_[cache/bounds_check/indirect_branch]

2018-01-09 Thread Suraj Jitindar Singh
On Tue, 2018-01-09 at 10:02 -0200, jos...@linux.vnet.ibm.com wrote: > On Tue, Jan 09, 2018 at 08:21:02PM +1100, Suraj Jitindar Singh wrote: > > This patch adds three new capabilities: > > cap-cfpc -> safe_cache > > cap-sbbc -> safe_bounds_check > > cap-ibs -> safe_indirect_branch > > > > Each cap

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [RFC 1/3] hw/ppc/spapr_caps: Rework spapr_caps to use uint8 internal representation

2018-01-09 Thread Suraj Jitindar Singh
On Tue, 2018-01-09 at 09:13 -0200, Murilo Opsfelder Araújo wrote: > On 01/09/2018 07:21 AM, Suraj Jitindar Singh wrote: > > Currently spapr_caps are tied to boolean values (on or off). This > > patch > > reworks the caps so that they can have any value between 0 and 127, > > inclusive. This allows

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [RFC 1/3] hw/ppc/spapr_caps: Rework spapr_caps to use uint8 internal representation

2018-01-09 Thread Suraj Jitindar Singh
On Tue, 2018-01-09 at 13:07 +0100, Andrea Bolognani wrote: > On Tue, 2018-01-09 at 20:21 +1100, Suraj Jitindar Singh wrote: > [...] > > +static void cap_htm_allow(sPAPRMachineState *spapr, uint8_t val, > > Error **errp) > > +{ > > +if (!val) { > > +/* TODO: We don't support disabling ht

Re: [Qemu-devel] [RFC v6 10/27] monitor: allow to use IO thread for parsing

2018-01-09 Thread Eric Blake
On 12/19/2017 02:45 AM, Peter Xu wrote: Grammar in the subject: "allow to $VERB" is not idiomatic English; correct is either "allow ${VERB}ing" or "allow $SUBJECT to $VERB". Concretely, s/to use/using/ > For each Monitor, add one field "use_io_thr" to show whether it will be > using the dedicat

Re: [Qemu-devel] [RFC v6 09/27] monitor: create monitor dedicate iothread

2018-01-09 Thread Eric Blake
On 12/19/2017 02:45 AM, Peter Xu wrote: Grammar in the subject: s/monitor dedicate/a dedicated monitor/ > Create one IOThread for the monitors, prepared to handle all the > input/output IOs using existing iothread framework. > > Signed-off-by: Peter Xu > --- > monitor.c | 29 +

Re: [Qemu-devel] [PATCH v5 11/31] hw/arm/exynos4210: use the "samsung, exynos4210-dw-mshc" device

2018-01-09 Thread Alistair Francis
On Mon, Jan 8, 2018 at 7:42 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/exynos4210.c | 12 > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c > index e8e1d81e62..eb95131221 100644

Re: [Qemu-devel] [PATCH v5 10/31] sdhci: add a Designware/Samsung host controller

2018-01-09 Thread Alistair Francis
On Mon, Jan 8, 2018 at 7:42 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/dw-mshc.c | 64 > + > hw/sd/Makefile.objs | 1 + > 2 files changed, 65 insertions(+) > create mode 100644 hw/sd/dw-mshc.c

Re: [Qemu-devel] [RFC v6 07/27] monitor: unify global init

2018-01-09 Thread Eric Blake
On 12/19/2017 02:45 AM, Peter Xu wrote: > There are many places for monitor init its globals, at least: Reads awkwardly; maybe: ...many places where the monitor initializes its globals,... > > - monitor_init_qmp_commands() at the very beginning > - single function to init monitor_lock > - in th

Re: [Qemu-devel] [RFC v6 06/27] monitor: move the cur_mon hack deeper for QMP

2018-01-09 Thread Eric Blake
On 12/19/2017 02:45 AM, Peter Xu wrote: > In monitor_qmp_read(), we have the hack to temporarily replace the > cur_mon pointer. Now we move this hack deeper inside the QMP dispatcher > routine since the Monitor pointer can be actually obtained using > container_of() upon the parser object, just li

Re: [Qemu-devel] [RFC v6 04/27] qobject: let object_property_get_str() use new API

2018-01-09 Thread Eric Blake
On 12/19/2017 02:45 AM, Peter Xu wrote: > We can simplify object_property_get_str() using the new > qobject_get_try_str(). > > Reviewed-by: Fam Zheng > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Peter Xu > --- > qom/object.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-)

Re: [Qemu-devel] [RFC v6 03/27] qobject: introduce qobject_get_try_str()

2018-01-09 Thread Eric Blake
On 12/19/2017 02:45 AM, Peter Xu wrote: > A quick way to fetch string from qobject when it's a QString. > > Reviewed-by: Fam Zheng > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Peter Xu > --- > include/qapi/qmp/qstring.h | 1 + > qobject/qstring.c | 11 +++ > 2 files change

Re: [Qemu-devel] [RFC v6 02/27] qobject: introduce qstring_get_try_str()

2018-01-09 Thread Eric Blake
On 12/19/2017 02:45 AM, Peter Xu wrote: > The only difference from qstring_get_str() is that it allows the qstring > to be NULL. If so, NULL is returned. > > CC: Eric Blake > CC: Markus Armbruster > Reviewed-by: Fam Zheng > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Peter Xu > --- > incl

Re: [Qemu-devel] [PATCH] maint: Mention web site maintenance in README

2018-01-09 Thread Eric Blake
On 11/29/2017 09:25 AM, Eric Blake wrote: > Now that we have a website that accepts patches on the list, the > main project should make it easier to find information about that > process. > > Signed-off-by: Eric Blake > --- > > Doc only, so it could go in -rc3 if we have a reason to slip it > in

Re: [Qemu-devel] [PULL] qemu-sparc updates

2018-01-09 Thread Mark Cave-Ayland
On 09/01/18 18:22, Peter Maydell wrote: The following changes since commit 4124ea4f5bd367ca6412fb2dfe7ac4d80e1504d9: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20171229' into staging (2018-01-08 16:17:04 +) are available in the git repository at: https://github.com/mca

Re: [Qemu-devel] [PATCH v5 26/31] sdhci: remove the deprecated 'capareg' property

2018-01-09 Thread Alistair Francis
On Mon, Jan 8, 2018 at 7:42 AM, Philippe Mathieu-Daudé wrote: > All SDHCI consumers have been upgraded to set correct properties. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/sd/sdhci.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(

Re: [Qemu-devel] [PATCH v5 09/31] sdhci: add a common class

2018-01-09 Thread Alistair Francis
On Mon, Jan 8, 2018 at 7:42 AM, Philippe Mathieu-Daudé wrote: > so this class can be inherited. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > include/hw/sd/sdhci.h | 12 > 1 file changed, 12 insertions(+) > > diff --git a/include/hw/sd/

Re: [Qemu-devel] [PATCH v5 05/31] sdhci: add DMA and 64-bit capabilities (Spec v2)

2018-01-09 Thread Alistair Francis
On Mon, Jan 8, 2018 at 7:42 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/sdhci-internal.h | 14 +++--- > include/hw/sd/sdhci.h | 4 > hw/sd/sdhci.c | 40 ++-- > 3 files changed, 29 insertions(+

Re: [Qemu-devel] Call for GSoC & Outreachy 2018 mentors & project ideas

2018-01-09 Thread Alistair Francis
On Tue, Jan 2, 2018 at 12:23 PM, Stefan Hajnoczi wrote: > QEMU will apply to the Google Summer of Code > (https://summerofcode.withgoogle.com/) and Outreachy > (https://www.outreachy.org/) open source internship programs again > this year. > > Do you want to mentor newcomers beginning open source

Re: [Qemu-devel] [PATCH 1/2] hw/intc/arm_gicv3: Make reserved register addresses RAZ/WI

2018-01-09 Thread Alistair Francis
On Wed, Dec 13, 2017 at 8:52 AM, Peter Maydell wrote: > The GICv3 specification says that reserved register addresses > should RAZ/WI. This means we need to return MEMTX_OK, not MEMTX_ERROR, > because now that we support generating external aborts the > latter will cause an abort on new board mode

Re: [Qemu-devel] [PATCH 2/2] hw/intc/arm_gic: reserved register addresses are RAZ/WI

2018-01-09 Thread Alistair Francis
On Wed, Dec 13, 2017 at 8:52 AM, Peter Maydell wrote: > The GICv2 specification says that reserved register addresses > must RAZ/WI; now that we implement external abort handling > for Arm CPUs this means we must return MEMTX_OK rather than > MEMTX_ERROR, to avoid generating a spurious guest data

Re: [Qemu-devel] [PATCH v1 02/21] RISC-V ELF Machine Definition

2018-01-09 Thread Alistair Francis
On Tue, Jan 2, 2018 at 4:44 PM, Michael Clark wrote: > Define RISC-V ELF machine EM_RISCV 243 > > Signed-off-by: Michael Clark Reviewed-by: Alistair Francis Alistair > --- > include/elf.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/elf.h b/include/elf.h > index e8a515c

Re: [Qemu-devel] [RFC PATCH 12/12] slirp: use HOST_SUPPORTS_UNALIGNED_ACCESS

2018-01-09 Thread Samuel Thibault
Philippe Mathieu-Daudé, on lun. 08 janv. 2018 14:29:04 -0300, wrote: > Access struct in6_addr with 'void *', then cast to 'u8 *' to avoid alignment > issues. Err, I don't understand the point. in6_addr's s6_addr is already a uint8_t by the standard. There is no non-byte access in the existing cod

Re: [Qemu-devel] [PATCH v1 01/21] RISC-V Maintainers

2018-01-09 Thread Alistair Francis
On Tue, Jan 2, 2018 at 4:44 PM, Michael Clark wrote: > Add Michael Clark, Sagar Karandikar and Bastian Koppelmann as > RISC-V Maintainers. > > Signed-off-by: Michael Clark Reviewed-by: Alistair Francis Alistair > --- > MAINTAINERS | 10 ++ > 1 file changed, 10 insertions(+) > > diff

Re: [Qemu-devel] [PATCH 09/12] slirp: add in6_dhcp_multicast()

2018-01-09 Thread Samuel Thibault
Philippe Mathieu-Daudé, on lun. 08 janv. 2018 14:29:01 -0300, wrote: > Signed-off-by: Philippe Mathieu-Daudé Applied to my tree. Thanks, Samuel > --- > slirp/dhcpv6.h | 3 +++ > slirp/udp6.c | 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/slirp/dhcpv6.h b/slirp/dh

Re: [Qemu-devel] [PATCH 08/12] slirp: removed unused code

2018-01-09 Thread Samuel Thibault
Thomas Huth, on lun. 08 janv. 2018 20:02:14 +0100, wrote: > On 08.01.2018 18:29, Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > slirp/ip.h | 13 - > > 1 file changed, 13 deletions(-) > > > > diff --git a/slirp/ip.h b/slirp/ip.h > > index e29ccd3c9

Re: [Qemu-devel] [PATCH 07/12] slirp: remove unnecessary

2018-01-09 Thread Samuel Thibault
Thomas Huth, on lun. 08 janv. 2018 20:01:10 +0100, wrote: > The subject is missing a word or two. Applied to my tree with a more complete subject :) Samuel

Re: [Qemu-devel] [PATCH 06/12] slirp: remove unused header

2018-01-09 Thread Samuel Thibault
Thomas Huth, on lun. 08 janv. 2018 19:54:27 +0100, wrote: > On 08.01.2018 18:28, Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > slirp/slirp.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/slirp/slirp.h b/slirp/slirp.h > > index 9a7287e7cc..447

Re: [Qemu-devel] [PATCH 04/12] slirp: add in6_multicast() and use it instead of IN6_IS_ADDR_MULTICAST()

2018-01-09 Thread Samuel Thibault
Richard Henderson, on mar. 09 janv. 2018 08:33:22 -0800, wrote: > On 01/08/2018 09:28 AM, Philippe Mathieu-Daudé wrote: > > Host: Mac OS 10.12.5 > > Compiler: Apple LLVM version 8.1.0 (clang-802.0.42) > > > > slirp/ip6_icmp.c:79:32: warning: taking address of packed member 'ip_src' > > of class

Re: [Qemu-devel] [PATCH 03/12] slirp: avoid IN6_IS_ADDR_UNSPECIFIED(), rather use in6_zero()

2018-01-09 Thread Samuel Thibault
Philippe Mathieu-Daudé, on lun. 08 janv. 2018 14:28:55 -0300, wrote: > Host: Mac OS 10.12.5 > Compiler: Apple LLVM version 8.1.0 (clang-802.0.42) > > slirp/ip6_icmp.c:80:38: warning: taking address of packed member 'ip_src' > of class or > structure 'ip6' may result in an unaligned poin

Re: [Qemu-devel] [PATCH 01/12] slirp: remove QEMU_PACKED from structures with don't require it

2018-01-09 Thread Samuel Thibault
Hello, Philippe Mathieu-Daudé, on lun. 08 janv. 2018 14:28:53 -0300, wrote: > struct mbuf_ptr { > struct mbuf *mptr; > uint32_t dummy; > -} QEMU_PACKED; > +}; > #else > struct mbuf_ptr { > struct mbuf *mptr; > -} QEMU_PACKED; > +}; > @@ -199,7 +199,7 @@ struct ipovly { >

Re: [Qemu-devel] [PATCH v2 0/7] macro do/while (0) cleanup

2018-01-09 Thread Eric Blake
ping On 12/01/2017 05:24 PM, Eric Blake wrote: > Noticed this by chance in the tests/ directory, so I broadened > it to a grep of the entire code base. I suspect^wKNOW many of > the bad macros were the victims of copy-and-paste from some > other bad location (particularly given how many bit-rotte

Re: [Qemu-devel] [PATCH v2 6/6] iotest 201: new test for qmp nbd-server-remove

2018-01-09 Thread Eric Blake
On 12/07/2017 09:51 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/201 | 130 > + > tests/qemu-iotests/201.out | 5 ++ > tests/qemu-iotests/group | 1 + > 3 files changed, 136

Re: [Qemu-devel] [PATCH v2 5/6] iotests: implement QemuIoInteractive class

2018-01-09 Thread Eric Blake
On 12/07/2017 09:51 AM, Vladimir Sementsov-Ogievskiy wrote: The subject says what, but there is no commit body that says why. Presumably this makes writing the test in the next patch easier, but some details in the commit message would make this obvious. > Signed-off-by: Vladimir Sementsov-Ogiev

Re: [Qemu-devel] [PATCH 1/4] spice: remove QXLWorker interface field

2018-01-09 Thread Frediano Ziglio
Thanks. How is your hand? Frediano - Original Message - > > On Sun, Dec 31, 2017 at 05:17:43AM -0500, Frediano Ziglio wrote: > > ping > > > > > > > > ping > > > > > > > > > > > ping the series > > > > > > Was on sick leave for a few weeks, back now, will process asap but will > pro

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U

2018-01-09 Thread Ala Hino
On Tue, Jan 9, 2018 at 10:11 PM, Eric Blake wrote: > On 01/09/2018 01:58 PM, Ala Hino wrote: > > >>> I know this is debatable but I think the #1 purpose of image locking is > >> to > >>> prevent data corruption; > >> > >> Isn't potentially wrong output of 'qemu-img info' a form of data > >> corru

Re: [Qemu-devel] [PATCH v2 4/6] iotest 147: add cases to test new @name parameter of nbd-server-add

2018-01-09 Thread Eric Blake
On 12/07/2017 09:51 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/147 | 68 > +- > tests/qemu-iotests/147.out | 4 +-- > 2 files changed, 57 insertions(+), 15 deletions(-) Reviewe

[Qemu-devel] [PATCHv2] linux-user: Fix sched_get/setaffinity conversion

2018-01-09 Thread Samuel Thibault
sched_get/setaffinity linux-user syscalls were missing conversions for little/big endian, which is hairy since longs may not be the same size either. For simplicity, this just introduces loops to convert bit by bit like is done for select. Signed-off-by: Samuel Thibault Reviewed-by: Laurent Vivi

Re: [Qemu-devel] [PATCH] qemu: improve hugepage allocation failure message

2018-01-09 Thread Haozhong Zhang
On 01/09/18 17:37 -0200, Marcelo Tosatti wrote: > > Improve hugepage allocation failure message, indicating > whats happening to the user. > > Signed-off-by: Marcelo Tosatti > > diff --git a/exec.c b/exec.c > index 4722e521d4..439abedb98 100644 > --- a/exec.c > +++ b/exec.c > @@ -1643,7 +1643,8

Re: [Qemu-devel] [PATCH v6 0/9] Add memfd memory backend

2018-01-09 Thread Eduardo Habkost
On Fri, Dec 22, 2017 at 07:48:43PM +0100, Marc-André Lureau wrote: > Hi > > On Mon, Oct 23, 2017 at 4:18 PM, Marc-André Lureau > wrote: > > Add a new Linux-specific memory backend, similar to hostmem-file, > > except that it doesn't need file path. It also try to enforce memory > > sealing if ava

Re: [Qemu-devel] [PATCH v2 0/6] Replace has_dynamic_sysbus with list of allowed device types

2018-01-09 Thread Eduardo Habkost
Queued on machine-next. -- Eduardo

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U

2018-01-09 Thread Eric Blake
On 01/09/2018 01:58 PM, Ala Hino wrote: >>> I know this is debatable but I think the #1 purpose of image locking is >> to >>> prevent data corruption; >> >> Isn't potentially wrong output of 'qemu-img info' a form of data >> corruption? Not data as in disk content, but metadata is data, too. >> >>

Re: [Qemu-devel] [PATCH for-2.12 v4 0/3] nvdimm: fixes for (non-)dax backends

2018-01-09 Thread Eduardo Habkost
Queued on machine-next. Thanks, and sorry for the long delay. On Mon, Dec 11, 2017 at 03:28:03PM +0800, Haozhong Zhang wrote: > Previous versions can be found at > v3: https://lists.gnu.org/archive/html/qemu-devel/2017-11/msg04785.html > v2: https://lists.gnu.org/archive/html/qemu-devel/2017

Re: [Qemu-devel] [PATCH for-2.11 v3 0/2] Check for the availability of a hotplug controller before adding a device

2018-01-09 Thread Eduardo Habkost
On Mon, Dec 18, 2017 at 12:59:50PM +0100, Thomas Huth wrote: > On 02.11.2017 11:10, Thomas Huth wrote: > > First patch is a small clean up to the error handling code in > > qdev_device_add(), and the second patch adds a proper check for > > the availability of a hotplug controller to prevent the po

Re: [Qemu-devel] [PATCH] scripts: Remove fixed entries from the device-crash-test

2018-01-09 Thread Eduardo Habkost
On Mon, Dec 18, 2017 at 05:10:38PM +0100, Thomas Huth wrote: > These are crashes / errors which have been fixed already in the past > months. We can remove these from the device-crash-test script now. > > Signed-off-by: Thomas Huth Queued on machine-next. Sorry for the long delay. -- Eduardo

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] qemu-img: Let "info" warn and go ahead without -U

2018-01-09 Thread Ala Hino
On Tue, Jan 9, 2018 at 11:58 AM, Kevin Wolf wrote: > Am 09.01.2018 um 07:24 hat Fam Zheng geschrieben: > > On Mon, 01/08 18:57, Kevin Wolf wrote: > > > I'm not sure if going back to the old behaviour for a while now would > be > > > helpful, you'd just end up with an even more confusing set of qe

Re: [Qemu-devel] Some question about savem/qcow2 incremental snapshot

2018-01-09 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@gmail.com) wrote: > On Mon, Dec 25, 2017 at 07:54:00AM +, He, Junyan wrote: > > I am now focusing on snapshot optimization for Intel NVDimm kind memory. > > Different from the normal memory, the NVDimm may be 128G, 256G or even more > > for just one guest, and its

Re: [Qemu-devel] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-01-09 Thread Eric Blake
On 12/07/2017 09:50 AM, Vladimir Sementsov-Ogievskiy wrote: > Add command for export removing. It is needed for cases when we > don't want to keep export after the operation on it was completed. > The other example is temporary node, created with blockdev-add. > If we want to delete it we should fi

Re: [Qemu-devel] [PATCH] qemu: improve hugepage allocation failure message

2018-01-09 Thread Eric Blake
On 01/09/2018 01:37 PM, Marcelo Tosatti wrote: > > Improve hugepage allocation failure message, indicating > whats happening to the user. s/whats/what's/ > > Signed-off-by: Marcelo Tosatti > > diff --git a/exec.c b/exec.c > index 4722e521d4..439abedb98 100644 > --- a/exec.c > +++ b/exec.c > @

[Qemu-devel] [PATCH] qemu: improve hugepage allocation failure message

2018-01-09 Thread Marcelo Tosatti
Improve hugepage allocation failure message, indicating whats happening to the user. Signed-off-by: Marcelo Tosatti diff --git a/exec.c b/exec.c index 4722e521d4..439abedb98 100644 --- a/exec.c +++ b/exec.c @@ -1643,7 +1643,8 @@ static void *file_ram_alloc(RAMBlock *block,

[Qemu-devel] [PATCH v2 2.5/6] hmp: Add name parameter to nbd_server_add

2018-01-09 Thread Eric Blake
Extend the flexibility of the previous QMP patch to also work in HMP. Signed-off-by: Eric Blake --- In response to Dave's request. I could also squash this into Vladimir's 2/6 if desired. hmp.c | 3 ++- hmp-commands.hx | 9 + 2 files changed, 7 insertions(+), 5 deletions(-)

Re: [Qemu-devel] [PATCH v2 2/6] qapi: add name parameter to nbd-server-add

2018-01-09 Thread Eric Blake
On 12/08/2017 11:33 AM, Dr. David Alan Gilbert wrote: >> @@ -2223,7 +2224,7 @@ void hmp_nbd_server_add(Monitor *mon, const QDict >> *qdict) >> bool writable = qdict_get_try_bool(qdict, "writable", false); >> Error *local_err = NULL; >> >> -qmp_nbd_server_add(device, true, writable

Re: [Qemu-devel] [PATCH v2 2/6] qapi: add name parameter to nbd-server-add

2018-01-09 Thread Eric Blake
On 12/07/2017 09:50 AM, Vladimir Sementsov-Ogievskiy wrote: > Allow user to specify name for new export, to not reuse internal > node name and to not show it to clients. > > This also allows creating several exports per device. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/block.

[Qemu-devel] [PATCH v1 1/3] xlnx-zynqmp-rtc: Initial commit

2018-01-09 Thread Alistair Francis
Initial commit of the ZynqMP RTC device. Signed-off-by: Alistair Francis --- hw/timer/Makefile.objs | 1 + hw/timer/xlnx-zynqmp-rtc.c | 232 + include/hw/timer/xlnx-zynqmp-rtc.h | 84 ++ 3 files changed, 317 insertions(+) c

[Qemu-devel] [PATCH v1 3/3] xlnx-zynqmp: Connect the RTC device

2018-01-09 Thread Alistair Francis
Signed-off-by: Alistair Francis --- hw/arm/xlnx-zynqmp.c | 14 ++ include/hw/arm/xlnx-zynqmp.h | 2 ++ 2 files changed, 16 insertions(+) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c index 325642058b..deef583c2a 100644 --- a/hw/arm/xlnx-zynqmp.c +++ b/hw/arm/xlnx

[Qemu-devel] [PATCH v1 2/3] xlnx-zynqmp-rtc: Add basic time support

2018-01-09 Thread Alistair Francis
Allow the guest to determine the time set from the QEMU command line. Signed-off-by: Alistair Francis --- hw/timer/xlnx-zynqmp-rtc.c | 24 include/hw/timer/xlnx-zynqmp-rtc.h | 2 ++ 2 files changed, 26 insertions(+) diff --git a/hw/timer/xlnx-zynqmp-rtc.c b/hw

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/2] GICv2 & GICv3: RAZ/WI reserved addresses rather than aborting

2018-01-09 Thread Andrew Jones
On Tue, Jan 09, 2018 at 04:35:30PM +, Peter Maydell wrote: > On 9 January 2018 at 16:29, Laszlo Ersek wrote: > > On 01/09/18 17:12, Peter Maydell wrote: > >> On 9 January 2018 at 15:58, Laszlo Ersek wrote: > >>> Sorry, no clue about any of this -- where should I read up? > >> > >> I cc'd you

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 for-2-12 12/15] s390x/tcg: fix size + content of STSI blocks

2018-01-09 Thread Thomas Huth
On 11.12.2017 14:47, David Hildenbrand wrote: > All blocks are 4k in size, which is only true for two of them right now. > Also some reserved fields were wrong, fix it and convert all reserved > fields to u8. > > This also fixes the LPAR part output in /proc/sysinfo under TCG. (for > now, everythi

Re: [Qemu-devel] [PATCH v4 1/6] vhost: Move log_dirty check

2018-01-09 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Thu, 14 Dec 2017 15:20:10 + > "Dr. David Alan Gilbert" wrote: > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > On Wed, 13 Dec 2017 18:08:02 + > > > "Dr. David Alan Gilbert (git)" wrote: > > > > > > > From: "Dr. David Alan Gilbert

Re: [Qemu-devel] [PULL 00/14] Migration pull request

2018-01-09 Thread Juan Quintela
Peter Maydell wrote: > On 5 January 2018 at 09:59, Juan Quintela wrote: >> Eric Blake wrote: >>> On 01/03/2018 03:38 AM, Juan Quintela wrote: Hi This are the changes for migration that are already reviewed. Please, apply. >>> Alexey Perevalov (6): mi

Re: [Qemu-devel] [PATCH 2/6] hw/sd/milkymist-memcard: split realize() out of SysBusDevice init()

2018-01-09 Thread Philippe Mathieu-Daudé
>> Creating the device (milkymist_memcard_create()) fails with an assertion: >> sysbus_mmio_map_common: Assertion `n >= 0 && n < dev->num_mmio' failed. > > Thanks for trying this. > > Odd 'make check-qtest-lm32' didn't catch this... Oh it actually does... My bad! GTESTER check-qtest-lm32 qemu

Re: [Qemu-devel] [PULL 00/14] Migration pull request

2018-01-09 Thread Peter Maydell
On 5 January 2018 at 09:59, Juan Quintela wrote: > Eric Blake wrote: >> On 01/03/2018 03:38 AM, Juan Quintela wrote: >>> Hi >>> >>> This are the changes for migration that are already reviewed. >>> >>> Please, apply. >>> >> >>> Alexey Perevalov (6): >>> migration: introduce postcopy-blockti

Re: [Qemu-devel] [PULL] qemu-sparc updates

2018-01-09 Thread Peter Maydell
On 8 January 2018 at 19:31, Mark Cave-Ayland wrote: > Hi Peter, > > Here is the first set of SPARC updates for 2.12. Please pull. > > > ATB, > > Mark. > > > The following changes since commit 4124ea4f5bd367ca6412fb2dfe7ac4d80e1504d9: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20

[Qemu-devel] [PULL v3] target/xtensa updates

2018-01-09 Thread Max Filippov
: Update version for v2.11.0 release (2017-12-13 14:31:09 +) are available in the git repository at: git://github.com/OSLL/qemu-xtensa.git tags/20180109-xtensa for you to fetch changes up to 5a6539e627faf9251e1db78238b9f9b870610518: target/xtensa: implement disassembler (2018-01-09 09:

Re: [Qemu-devel] [PATCH 2/6] hw/sd/milkymist-memcard: split realize() out of SysBusDevice init()

2018-01-09 Thread Philippe Mathieu-Daudé
Hi Michael, > Am 2018-01-03 17:23, schrieb Philippe Mathieu-Daudé: >> >> Create the SDCard in the realize() function. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/sd/milkymist-memcard.c | 24 +++- >> 1 file changed, 15 insertions(+), 9 deletions(-) >> >> diff --gi

Re: [Qemu-devel] [PATCH] scsi: Don't check uninitialized local variable

2018-01-09 Thread Eric Blake
On 01/09/2018 12:05 PM, Paolo Bonzini wrote: > On 08/01/2018 04:09, Fam Zheng wrote: >> After the out label there is a check on iTask.task but it is not >> initialized yet. >> >> Fixes: e38bc23454ef763deb4405ebdee6a1081aa00bc8 >> Signed-off-by: Fam Zheng >> --- >> block/iscsi.c | 3 +-- >> 1 file

Re: [Qemu-devel] [PULL v2 00/16] target/xtensa updates

2018-01-09 Thread Max Filippov
On Tue, Jan 9, 2018 at 9:44 AM, Peter Maydell wrote: > /Users/pm215/src/qemu-for-merges/target/xtensa/helper.c:63:26: error: > implicit declaration of function 'g_malloc_n' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > config->opcode_ops = g_malloc_n(opcodes, sizeof(XtensaOpc

Re: [Qemu-devel] [PATCH v6 21/29] hw/s390x: Replace fprintf(stderr, "*\n" with error_report()

2018-01-09 Thread Alistair Francis
On Tue, Jan 9, 2018 at 9:45 AM, Cornelia Huck wrote: > On Wed, 20 Dec 2017 09:24:41 -0800 > Alistair Francis wrote: > >> Replace a large number of the fprintf(stderr, "*\n" calls with >> error_report(). The functions were renamed with these commands and then >> compiler issues where manually fixe

  1   2   3   >