[Qemu-devel] [PATCH] vcpu: create vcpu thread with QEMU_THREAD_DETACHED mode

1. If we create vcpu thread with QEMU_THREAD_JOINABLE mode, we will get memory leak when vcpu thread exits, which will happen when hot-unplug vcpus. 2. We should use QLIST_FOREACH_SAFE instead of QLIST_FOREACH if we need to remove the entry in QLIST. Signed-off-by: linzhecheng

Re: [Qemu-devel] Double-free due to e5dc1a6c6c

On 01/19/2018 09:05 PM, Emilio G. Cota wrote: On Fri, Jan 19, 2018 at 17:55:27 -0500, Stefan Berger wrote: I get double-free memory errors when QEMU terminates due to commit e5dc1a6c6c. The way to reproduce the error is to 1st do a 'system_reset' in the monitor and then get into the grub

Re: [Qemu-devel] Double-free due to e5dc1a6c6c

On Fri, Jan 19, 2018 at 17:55:27 -0500, Stefan Berger wrote: > I get double-free memory errors when QEMU terminates due to commit > e5dc1a6c6c. > > The way to reproduce the error is to 1st do a 'system_reset' in the monitor > and then get into the grub console and do a 'halt' there. Can you

Re: [Qemu-devel] [RFC PATCH] migration: do not use atomic__nocheck() functions directly

On 01/19/2018 10:20 AM, Philippe Mathieu-Daudé wrote: > Maybe we should remove the __nocheck() functions and inline them in the > 'checked' functions? No, I use them in TCG, properly protected with CONFIG_ATOMIC*. r~

Re: [Qemu-devel] [PATCH v9 13/13] iotests: add dirty bitmap postcopy test

On 01/19/2018 01:08 PM, Vladimir Sementsov-Ogievskiy wrote: > 18.01.2018 12:57, Vladimir Sementsov-Ogievskiy wrote: >> 17.01.2018 21:30, John Snow wrote: >>> >>> On 12/28/2017 06:49 AM, Vladimir Sementsov-Ogievskiy wrote: Thank you for reviewing my code! >>> Time for the re-spin?

Re: [Qemu-devel] [PATCH v2 4/6] qmp: transaction support for block-dirty-bitmap-enable/disable

On 01/17/2018 10:06 AM, Vladimir Sementsov-Ogievskiy wrote: > 16.01.2018 15:54, Vladimir Sementsov-Ogievskiy wrote: >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >>   qapi/transaction.json |  4 +++ >>   blockdev.c    | 79 >>

Re: [Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

Hi Anatol, Daniel and Kevin. On 01/19/18 10:36, Anatol Pomozov wrote: Hello Jack On Wed, Jan 17, 2018 at 12:06 PM, Jack Schwartz wrote: Hi Kevin and Anatol. Kevin, thanks for your review. More inline below... On 01/15/18 07:54, Kevin Wolf wrote: Am 21.12.2017 um

Re: [Qemu-devel] [PATCH qemu v2] RFC: vfio-pci: Allow mmap of MSIX BAR

On 20/01/18 02:57, Alex Williamson wrote: > On Fri, 19 Jan 2018 19:55:49 +1100 > Alexey Kardashevskiy wrote: > >> On 19/01/18 08:59, Alex Williamson wrote: >>> On Tue, 16 Jan 2018 16:17:58 +1100 >>> Alexey Kardashevskiy wrote: >>> On 06/01/18 02:29, Alex

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

On Fri, Jan 19, 2018 at 11:27:33 +0100, Greg Kurz wrote: > On Mon, 15 Jan 2018 11:49:31 +0800 > Antonios Motakis wrote: > > On 13-Jan-18 00:14, Greg Kurz wrote: > > > On Fri, 12 Jan 2018 19:32:10 +0800 > > > Antonios Motakis wrote: (snip)

Re: [Qemu-devel] [PATCH v2 3/6] qapi: add block-dirty-bitmap-enable/disable

On 01/16/2018 07:54 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/block-core.json | 42 ++ > blockdev.c | 42 ++ > 2 files

Re: [Qemu-devel] [PATCH v2 2/6] block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap

On 01/16/2018 07:54 AM, Vladimir Sementsov-Ogievskiy wrote: > Add locks and remove comments about BQL accordingly to > dirty_bitmap_mutex definition in block_int.h. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/dirty-bitmap.c | 6 -- > 1 file

Re: [Qemu-devel] [PATCH v2 1/6] block: maintain persistent disabled bitmaps

On 01/16/2018 07:54 AM, Vladimir Sementsov-Ogievskiy wrote: > To maintain load/store disabled bitmap there is new approach: > > - deprecate @autoload flag of block-dirty-bitmap-add, make it ignored > - store enabled bitmaps as "auto" to qcow2 > - store disabled bitmaps without "auto" flag to

Re: [Qemu-devel] [PATCH v2 0/6] qmp dirty bitmap API

On 01/16/2018 07:54 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi all. > > There are three qmp commands, needed to implement external backup API. > > Using these three commands, client may do all needed bitmap management by > hand: > > on backup start we need to do a transaction: > {disable

Re: [Qemu-devel] [PATCH v4] file-posix: specify expected filetypes

On 01/19/2018 04:47 PM, John Snow wrote: > Adjust each caller of raw_open_common to specify if they are expecting > host and character devices or not. Tighten expectations of file types upon > open in the common code and refuse types that are not expected. > > This has two effects: > > (1)

[Qemu-devel] Double-free due to e5dc1a6c6c

I get double-free memory errors when QEMU terminates due to commit e5dc1a6c6c. The way to reproduce the error is to 1st do a 'system_reset' in the monitor and then get into the grub console and do a 'halt' there. Stefan commit e5dc1a6c6c4359cd783810f63eb68e9e09350708 Author:

[Qemu-devel] [PATCH v4] file-posix: specify expected filetypes

Adjust each caller of raw_open_common to specify if they are expecting host and character devices or not. Tighten expectations of file types upon open in the common code and refuse types that are not expected. This has two effects: (1) Character and block devices are now considered deprecated

Re: [Qemu-devel] [PATCH v4 1/3] xlnx-zynqmp-rtc: Initial commit

On Fri, Jan 19, 2018 at 11:22 AM, Philippe Mathieu-Daudé wrote: > Hi Alistair, > > On 01/19/2018 03:35 PM, Alistair Francis wrote: >> Initial commit of the ZynqMP RTC device. >> >> Signed-off-by: Alistair Francis >> --- >> V2: >> - Delete unused

[Qemu-devel] [PULL 2/4] ide: move ide_sect_range_ok() up

From: Anton Nefedov to use it without a forward declaration in the commit to follow Signed-off-by: Anton Nefedov Message-id: 1512735034-35327-3-git-send-email-anton.nefe...@virtuozzo.com Signed-off-by: John Snow ---

[Qemu-devel] [PULL 4/4] hw/ide: Remove duplicated definitions from ahci_internal.h

The same definitions can also be found in include/hw/ide/ahci.h so let's remove these #defines from ahci_internal.h. Signed-off-by: Thomas Huth Message-id: 1512457825-3847-1-git-send-email-th...@redhat.com [Maintainer edit: publicize object names, privatize object macros.]

[Qemu-devel] [PULL 0/4] Ide patches

The following changes since commit b384cd95eb9c6f73ad84ed1bb0717a26e29cc78f: Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-01-19 16:35:25 +) are available in the Git repository at: https://github.com/jnsnow/qemu.git

[Qemu-devel] [PULL 3/4] ide: abort TRIM operation for invalid range

From: Anton Nefedov ATA8-ACS3, 7.9 DATA SET MANAGEMENT - 06h, DMA 7.9.5 Error Outputs If the Trim bit is set to one and: a) the device detects an invalid LBA Range Entry; or b) count is greater than IDENTIFY DEVICE data word 105 (see

[Qemu-devel] [PULL 1/4] ide: pass IDEState to trim AIO callback

From: Anton Nefedov It will be needed to handle invalid requests Signed-off-by: Anton Nefedov Message-id: 1512735034-35327-2-git-send-email-anton.nefe...@virtuozzo.com Signed-off-by: John Snow --- hw/ide/core.c | 14

Re: [Qemu-devel] [PATCH 0/3] ide: abort TRIM operation for invalid range

On 12/08/2017 07:10 AM, Anton Nefedov wrote: > Started from the separate series discussion (trim statistics) , see > http://lists.nongnu.org/archive/html/qemu-devel/2017-12/msg01059.html > > There is no range check for IDE trim requests now. > Such request will likely be rejected by the block

Re: [Qemu-devel] [PATCH v2] hw/ide: Remove duplicated definitions from ahci_internal.h

On 12/07/2017 12:47 AM, Thomas Huth wrote: > On 06.12.2017 23:16, John Snow wrote: >> I tweaked this again, sorry: >> >> The names need to stay public, but the wrappers to manipulate the >> objects can stay internal. Minor difference. >> >> If that's okay, I'll just merge this in. >> OK? > >

Re: [Qemu-devel] [PATCH] ide-test: test trim requests

On 01/19/2018 07:40 AM, Anton Nefedov wrote: > Signed-off-by: Anton Nefedov > --- > tests/ide-test.c | 71 > > 1 file changed, 71 insertions(+) > > diff --git a/tests/ide-test.c b/tests/ide-test.c > index

Re: [Qemu-devel] [PATCH v2 4/5] tpm: add CRB device

On 01/19/2018 01:42 PM, Eduardo Habkost wrote: On Fri, Jan 19, 2018 at 12:10:03PM -0500, Stefan Berger wrote: On 01/19/2018 09:11 AM, Marc-André Lureau wrote: tpm_crb is a device for TPM 2.0 Command Response Buffer (CRB) Interface as defined in TCG PC Client Platform TPM Profile (PTP)

Re: [Qemu-devel] [PATCH 02/11] smbus_eeprom: replace SMBusDeviceClass::init by DeviceClass::reset

On 01/19/2018 03:15 PM, Eduardo Habkost wrote: > On Tue, Jan 16, 2018 at 10:15:46AM -0300, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/i2c/smbus_eeprom.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git

Re: [Qemu-devel] [PATCH] Revert "smbus: do not immediately complete commands"

On 01/19/2018 08:07 AM, Corey Minyard wrote: On 01/18/2018 09:17 PM, Michael S. Tsirkin wrote: On Thu, Jan 18, 2018 at 07:55:41PM -0600, miny...@acm.org wrote: From: Corey Minyard This reverts commit 880b1ffe6ec2f0ae25cc4175716227ad275e8b8a. The commit being reverted

Re: [Qemu-devel] [PATCH v2 00/13] blockjob: refactor mirror_throttle

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180119205847.7141-1-js...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/13] blockjob: refactor mirror_throttle === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PATCH v2 11/13] block/mirror: remove block_job_sleep_ns calls

We're attempting to slacken the mirror loop in three different places, but we can combine these three attempts. Combine the early loop call to block_job_pause_point with the two late-loop calls to block_job_sleep_ns. When delay_ns is 0 and it has not been SLICE_TIME since the last yield,

[Qemu-devel] [PATCH v2 10/13] block/mirror: condense cancellation and relax calls

We can count on the relax call to check cancellation for us, so condense these concurrent calls. Signed-off-by: John Snow --- block/mirror.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index 3c73caed5e..a0e0044de2

[Qemu-devel] [PATCH v2 13/13] blockjob: remove block_job_pause_point from interface

Remove the last call in block/mirror, using relax instead. relax may do nothing if we are canceled, so allow iteration to return prematurely and allow mirror_run to handle the cancellation logic. This is a functional change to mirror that should have the effect of cancelled mirror jobs being able

[Qemu-devel] [PATCH v2 12/13] blockjob: privatize block_job_sleep_ns

There's not currently any external caller of it. Except in tests, but we'll fix that here too. Replace usages in test cases with block_job_relax, which functions similarly enough to be used as a drop-in replacement. Very technically block_job_sleep_ns(job, 0) behaves differently from

[Qemu-devel] [PATCH v2 08/13] allow block_job_relax to return -ECANCELED

This is just an optimization for callers who are likely going to want to check quite close to this call if the job was canceled or not anyway. Along the same lines, add the return to block_job_pause_point and block_job_sleep_ns, so we don't have to re-check it quite so excessively.

[Qemu-devel] [PATCH v2 07/13] block/backup: use block_job_relax

See two commits back for justification. Signed-off-by: John Snow Reviewed-by: Paolo Bonzini Reviewed-by: Stefan Hajnoczi --- block/backup.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block/backup.c

[Qemu-devel] [PATCH v2 05/13] block/commit: use block_job_relax

Depending on the value of `speed` and how fast our backends are, delay_ns might be 0 very, very often. This creates some warning messages that spook users, but it's also pretty inefficient. Use block_job_relax instead to yield a little more intelligently. Signed-off-by: John Snow

[Qemu-devel] [PATCH v2 09/13] block/backup: remove yield_and_check

This is a respin of the same functionality as mirror_throttle, so trash this and replace it with the generic version. yield_and_check returned true if canceled, false otherwise. block_job_relax returns -ECANCELED if canceled, 0 otherwise. Signed-off-by: John Snow ---

[Qemu-devel] [PATCH v2 01/13] blockjob: record time of last entrance

The mirror job makes a semi-inaccurate record of the last time we yielded by recording the last time we left a "pause", but this doesn't always correlate to the time we actually last successfully ceded control. Record the time we last *exited* a yield centrally. In other words, record the time we

[Qemu-devel] [PATCH v2 06/13] block/stream: use block_job_relax

See prior commit for justification. Signed-off-by: John Snow Reviewed-by: Paolo Bonzini Reviewed-by: Stefan Hajnoczi --- block/stream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/stream.c

[Qemu-devel] [PATCH v2 00/13] blockjob: refactor mirror_throttle

mirror_throttle attempts to make sure we yield every so often when we're doing operations that may not otherwise be as cooperative as we'd like. This pattern is useful to other jobs like commit as well; if commit continuously decides not to copy data (and calculates delay_ns to be 0), we'll

[Qemu-devel] [PATCH v2 02/13] blockjob: consolidate SLICE_TIME definition

They're all the same. If it actually becomes important to configure it, it can become a job or driver property. Signed-off-by: John Snow Reviewed-by: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Reviewed-by: Jeff Cody

[Qemu-devel] [PATCH v2 03/13] blockjob: create block_job_relax

This will replace mirror_throttle, for reuse in other jobs. Signed-off-by: John Snow --- block/mirror.c | 15 ++- blockjob.c | 11 +++ include/block/blockjob_int.h | 9 + 3 files changed, 22 insertions(+), 13

[Qemu-devel] [PATCH v2 04/13] blockjob: allow block_job_throttle to take delay_ns

Instead of only sleeping for 0ms when we've hit a timeout, optionally take a longer more explicit delay_ns that always forces the sleep. Signed-off-by: John Snow --- block/mirror.c | 4 ++-- blockjob.c | 9 -

Re: [Qemu-devel] [PATCH v2] dump-guest-memory.py: fix python 2 support

On 01/19/2018 10:25 AM, Marc-André Lureau wrote: > Python GDB support may use Python 2 or 3. > > Inferior.read_memory() may return a 'buffer' with Python 2 or a > 'memoryview' with Python 3 (see also > https://sourceware.org/gdb/onlinedocs/gdb/Inferiors-In-Python.html) > > The

Re: [Qemu-devel] [PATCH v2] dump-guest-memory.py: fix python 2 support

On 01/19/18 20:48, Eric Blake wrote: > On 01/19/2018 01:18 PM, Laszlo Ersek wrote: >> On 01/19/18 17:25, Marc-André Lureau wrote: >>> Python GDB support may use Python 2 or 3. >>> >>> Inferior.read_memory() may return a 'buffer' with Python 2 or a >>> 'memoryview' with Python 3 (see also >>>

[Qemu-devel] virtio_net occasionally stops sending packets

We've been running into a fairly persistent issue where virtio_net adapters will suddenly stop sending packets when running under KVM.  This has persisted through several qemu versions, and a large number of guest kernel upgrades. What we end up seeing is the guest continuing to receive

[Qemu-devel] [PULL 00/10] target/xtensa updates

in the git repository at: git://github.com/OSLL/qemu-xtensa.git tags/20180119-xtensa for you to fetch changes up to 8030ed759be52b2517356c3d0291c45cedc65fd9: target/xtensa: disas/xtensa: fix coverity warnings (2018-01-18 10:27:04 -0800

Re: [Qemu-devel] [PATCH v6 0/3] vhost: two fixes and used_memslots refactoring

On Tue, Jan 16, 2018 at 08:17:54AM +, Zhoujian (jay) wrote: > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Tuesday, January 16, 2018 12:42 PM > > To: Zhoujian (jay) > > Cc: qemu-devel@nongnu.org; imamm...@redhat.com;

Re: [Qemu-devel] [PATCH v2] dump-guest-memory.py: fix python 2 support

On 01/19/2018 01:18 PM, Laszlo Ersek wrote: > On 01/19/18 17:25, Marc-André Lureau wrote: >> Python GDB support may use Python 2 or 3. >> >> Inferior.read_memory() may return a 'buffer' with Python 2 or a >> 'memoryview' with Python 3 (see also >>

[Qemu-devel] [PATCH] target/arm: Fix 32-bit address truncation

Commit ("3b39d734141a target/arm: Handle page table walk load failures correctly") modified both versions of the page table walking code (i.e., arm_ldl_ptw and arm_ldq_ptw) to record the result of the translation in a temporary 'data' variable so that it can be inspected before being returned.

Re: [Qemu-devel] [Qemu-arm] [PATCH v6 8/9] xlnx-zynqmp-pmu: Connect the IPI device to the PMU

On 01/19/2018 03:15 PM, Alistair Francis wrote: > On Thu, Jan 18, 2018 at 1:42 PM, Philippe Mathieu-Daudé > wrote: >> On 01/18/2018 03:38 PM, Alistair Francis wrote: >>> Signed-off-by: Alistair Francis >>> Reviewed-by: Edgar E. Iglesias

Re: [Qemu-devel] [Qemu-arm] [PATCH v6 5/9] xlnx-pmu-iomod-intc: Add the PMU Interrupt controller

On 01/19/2018 03:11 PM, Alistair Francis wrote: > On Thu, Jan 18, 2018 at 1:29 PM, Philippe Mathieu-Daudé > wrote: >> On 01/18/2018 03:38 PM, Alistair Francis wrote: >>> Add the PMU IO Module Interrupt controller device. >>> >>> Signed-off-by: Alistair Francis

Re: [Qemu-devel] [PATCH v4 1/3] xlnx-zynqmp-rtc: Initial commit

Hi Alistair, On 01/19/2018 03:35 PM, Alistair Francis wrote: > Initial commit of the ZynqMP RTC device. > > Signed-off-by: Alistair Francis > --- > V2: > - Delete unused realise function > - Remove DB_PRINT() > > include/hw/timer/xlnx-zynqmp-rtc.h | 84

Re: [Qemu-devel] [PATCH v2] dump-guest-memory.py: fix python 2 support

On 01/19/18 17:25, Marc-André Lureau wrote: > Python GDB support may use Python 2 or 3. > > Inferior.read_memory() may return a 'buffer' with Python 2 or a > 'memoryview' with Python 3 (see also > https://sourceware.org/gdb/onlinedocs/gdb/Inferiors-In-Python.html) > > The

Re: [Qemu-devel] [PATCH 06/11] sysbus: add realize() and unrealize()

On 01/19/2018 03:03 PM, Eduardo Habkost wrote: > On Tue, Jan 16, 2018 at 10:15:50AM -0300, Philippe Mathieu-Daudé wrote: > [...] >> +static void sysbus_realize(DeviceState *dev, Error **errp) >> +{ >> +SysBusDevice *sd = SYS_BUS_DEVICE(dev); >> +SysBusDeviceClass *sbc =

Re: [Qemu-devel] [PATCH 03/11] hw/i2c: convert I2CSlaveClass::init -> realize

On 01/19/2018 03:18 PM, Eduardo Habkost wrote: > On Tue, Jan 16, 2018 at 10:15:47AM -0300, Philippe Mathieu-Daudé wrote: > [...] >> -static int i2c_slave_qdev_init(DeviceState *dev) >> +static void i2c_slave_realize(DeviceState *dev, Error **errp) >> { >> I2CSlave *s = I2C_SLAVE(dev); >>

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

On 1/19/2018 7:05 PM, Greg Kurz wrote: On Fri, 19 Jan 2018 17:37:58 +0100 Veaceslav Falico wrote: On 1/19/2018 4:52 PM, Eduard Shishkin wrote: On 1/19/2018 11:27 AM, Greg Kurz wrote: On Mon, 15 Jan 2018 11:49:31 +0800 Antonios Motakis

Re: [Qemu-devel] [PATCH v2 4/5] tpm: add CRB device

On Fri, Jan 19, 2018 at 12:10:03PM -0500, Stefan Berger wrote: > On 01/19/2018 09:11 AM, Marc-André Lureau wrote: > > tpm_crb is a device for TPM 2.0 Command Response Buffer (CRB) > > Interface as defined in TCG PC Client Platform TPM Profile (PTP) > > Specification Family “2.0” Level 00 Revision

[Qemu-devel] [PATCH v4 3/3] xlnx-zynqmp: Connect the RTC device

Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- include/hw/arm/xlnx-zynqmp.h | 2 ++ hw/arm/xlnx-zynqmp.c | 14 ++ 2 files changed, 16 insertions(+)

[Qemu-devel] [PATCH v4 1/3] xlnx-zynqmp-rtc: Initial commit

Initial commit of the ZynqMP RTC device. Signed-off-by: Alistair Francis --- V2: - Delete unused realise function - Remove DB_PRINT() include/hw/timer/xlnx-zynqmp-rtc.h | 84 ++ hw/timer/xlnx-zynqmp-rtc.c | 218

[Qemu-devel] [PATCH v4 0/3] Add and connect the ZynqMP RTC

V4: - Use the RegisterAccessInfo .unimp functionality V3: - Store an offset value - Use mktimegm() - Log unimplemented writes V2: - Delete unused realise function - Add cover letter - Convert DB_PRINT() macro to trace Alistair Francis (3): xlnx-zynqmp-rtc: Initial commit

Re: [Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

Hello Jack On Wed, Jan 17, 2018 at 12:06 PM, Jack Schwartz wrote: > Hi Kevin and Anatol. > > Kevin, thanks for your review. > > More inline below... > > On 01/15/18 07:54, Kevin Wolf wrote: >> >> Am 21.12.2017 um 18:25 hat Jack Schwartz geschrieben: >>> >>> Properly

Re: [Qemu-devel] [PATCH 07/11] qdev: simplify the SysBusDeviceClass::init path

On Tue, Jan 16, 2018 at 10:15:51AM -0300, Philippe Mathieu-Daudé wrote: > The SysBusDevice is the last DeviceClass::init user. > > Instead of using > SysBusDeviceClass::realize >-> DeviceClass::realize >-> DeviceClass::init >-> sysbus_device_init > ->

[Qemu-devel] [PATCH v4 2/4] target/arm: implement SHA-3 instructions

This implements emulation of the new SHA-3 instructions that have been added as an optional extensions to the ARMv8 Crypto Extensions in ARM v8.2. Signed-off-by: Ard Biesheuvel --- target/arm/cpu.h | 1 + target/arm/translate-a64.c | 157

[Qemu-devel] [PATCH v4 0/4] target-arm: add SHA-3, SM3 and SHA512 instruction support

Changes since v3: - don't bother with helpers for the SHA3 instructions: they are simple enough to be emitted as TCG ops directly - rebase onto Richard's pending SVE work Changes since v2: - fix thinko in big-endian aware handling of 64-bit quantities: this is not needed given that the NEON

[Qemu-devel] [PATCH v4 4/4] target/arm: enable user-mode SHA-3, SM3 and SHA-512 instruction support

Add support for the new ARMv8.2 SHA-3, SM3 and SHA-512 instructions to AArch64 user mode emulation. Signed-off-by: Ard Biesheuvel --- linux-user/elfload.c | 18 ++ target/arm/cpu64.c | 3 +++ 2 files changed, 21 insertions(+) diff --git

[Qemu-devel] [PATCH v4 3/4] target/arm: implement SM3 instructions

This implements emulation of the new SM3 instructions that have been added as an optional extension to the ARMv8 Crypto Extensions in ARM v8.2. Signed-off-by: Ard Biesheuvel --- target/arm/cpu.h | 1 + target/arm/crypto_helper.c | 117 +

[Qemu-devel] [PATCH v4 1/4] target/arm: implement SHA-512 instructions

This implements emulation of the new SHA-512 instructions that have been added as an optional extension to the ARMv8 Crypto Extensions in ARM v8.2. Signed-off-by: Ard Biesheuvel --- target/arm/cpu.h | 1 + target/arm/crypto_helper.c | 75 ++-

Re: [Qemu-devel] [PATCH v9 13/13] iotests: add dirty bitmap postcopy test

On 01/19/2018 01:08 PM, Vladimir Sementsov-Ogievskiy wrote: > 18.01.2018 12:57, Vladimir Sementsov-Ogievskiy wrote: >> 17.01.2018 21:30, John Snow wrote: >>> >>> On 12/28/2017 06:49 AM, Vladimir Sementsov-Ogievskiy wrote: Thank you for reviewing my code! >>> Time for the re-spin?

Re: [Qemu-devel] [PATCH v8 09/17] sdhci: add basic Spec v1 capabilities

On Thu, Jan 18, 2018 at 10:31 AM, Philippe Mathieu-Daudé wrote: > (Note than Spec v2 is supported by default) > > we emit a warning for missing capabilities bits. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis

Re: [Qemu-devel] [RFC PATCH] migration: do not use atomic__nocheck() functions directly

On 01/19/2018 03:01 PM, Dr. David Alan Gilbert wrote: > * Philippe Mathieu-Daudé (f4...@amsat.org) wrote: >> (incorrectly use in 3be98be4e9f) >> >> Signed-off-by: Philippe Mathieu-Daudé > > I'm a bit confused; isnt the only difference between the nocheck > versions that it'll

Re: [Qemu-devel] [PATCH 03/11] hw/i2c: convert I2CSlaveClass::init -> realize

On Tue, Jan 16, 2018 at 10:15:47AM -0300, Philippe Mathieu-Daudé wrote: [...] > -static int i2c_slave_qdev_init(DeviceState *dev) > +static void i2c_slave_realize(DeviceState *dev, Error **errp) > { > I2CSlave *s = I2C_SLAVE(dev); > I2CSlaveClass *sc = I2C_SLAVE_GET_CLASS(s); > > -

Re: [Qemu-devel] [Qemu-arm] [PATCH v6 8/9] xlnx-zynqmp-pmu: Connect the IPI device to the PMU

On Thu, Jan 18, 2018 at 1:42 PM, Philippe Mathieu-Daudé wrote: > On 01/18/2018 03:38 PM, Alistair Francis wrote: >> Signed-off-by: Alistair Francis >> Reviewed-by: Edgar E. Iglesias >> --- >> V4: >> - Move the IPI to the

Re: [Qemu-devel] [PATCH 02/11] smbus_eeprom: replace SMBusDeviceClass::init by DeviceClass::reset

On Tue, Jan 16, 2018 at 10:15:46AM -0300, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i2c/smbus_eeprom.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c > index

Re: [Qemu-devel] [Qemu-arm] [PATCH v6 5/9] xlnx-pmu-iomod-intc: Add the PMU Interrupt controller

On Thu, Jan 18, 2018 at 1:29 PM, Philippe Mathieu-Daudé wrote: > On 01/18/2018 03:38 PM, Alistair Francis wrote: >> Add the PMU IO Module Interrupt controller device. >> >> Signed-off-by: Alistair Francis >> Reviewed-by: Edgar E. Iglesias

Re: [Qemu-devel] [PATCH v9 13/13] iotests: add dirty bitmap postcopy test

18.01.2018 12:57, Vladimir Sementsov-Ogievskiy wrote: 17.01.2018 21:30, John Snow wrote: On 12/28/2017 06:49 AM, Vladimir Sementsov-Ogievskiy wrote: Thank you for reviewing my code! Time for the re-spin? There's pretty good pressure to get this into 2.12 and say the non-nbd workflow model

Re: [Qemu-devel] [PULL v2 00/19] machine queue, 2018-01-19

On 19 January 2018 at 16:33, Eduardo Habkost wrote: > Changes from v1 (2018-01-18): > * Fix build failure on 32-bit > > The following changes since commit 3e5bdc6573edf0585e4085e6a4e349b135abf3b4: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

On Fri, 19 Jan 2018 17:37:58 +0100 Veaceslav Falico wrote: > On 1/19/2018 4:52 PM, Eduard Shishkin wrote: > > > > > > On 1/19/2018 11:27 AM, Greg Kurz wrote: > >> On Mon, 15 Jan 2018 11:49:31 +0800 > >> Antonios Motakis wrote: > >>

Re: [Qemu-devel] [PATCH 0/2] linux-user: Fix race between threads in page_unprotect()

Le 15/01/2018 à 13:48, Peter Maydell a écrit : > On 28 November 2017 at 14:35, Peter Maydell wrote: >> If multiple guest threads in user-mode emulation write to a >> page which QEMU has marked read-only because of cached TCG >> translations, the threads can race in

Re: [Qemu-devel] [PATCH 06/11] sysbus: add realize() and unrealize()

On Tue, Jan 16, 2018 at 10:15:50AM -0300, Philippe Mathieu-Daudé wrote: [...] > +static void sysbus_realize(DeviceState *dev, Error **errp) > +{ > +SysBusDevice *sd = SYS_BUS_DEVICE(dev); > +SysBusDeviceClass *sbc = SYS_BUS_DEVICE_GET_CLASS(sd); > + > +if (sbc->realize) { > +

Re: [Qemu-devel] [PATCH v8 07/17] sdhci: add init_readonly_registers() to initialize the CAPAB register

On Thu, Jan 18, 2018 at 10:30 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/sd/sdhci.c | 20 +--- > 1 file changed, 17 insertions(+),

Re: [Qemu-devel] [RFC PATCH] migration: do not use atomic__nocheck() functions directly

* Philippe Mathieu-Daudé (f4...@amsat.org) wrote: > (incorrectly use in 3be98be4e9f) > > Signed-off-by: Philippe Mathieu-Daudé I'm a bit confused; isnt the only difference between the nocheck versions that it'll fail at compile time instead of link? Dave > --- > currently on

Re: [Qemu-devel] [PATCH v8 01/17] sdhci: use error_propagate(local_err) in realize()

On Thu, Jan 18, 2018 at 10:30 AM, Philippe Mathieu-Daudé wrote: > avoid the "errp && *errp" pattern (not recommended in "qapi/error.h" > comments). > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair

Re: [Qemu-devel] [PATCH 01/11] smbus: add a NULL check for SMBusDeviceClass::init callbacks

On Tue, Jan 16, 2018 at 10:15:45AM -0300, Philippe Mathieu-Daudé wrote: > ensure SMBusDeviceClass::init is set before calling it > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Eduardo Habkost -- Eduardo

Re: [Qemu-devel] [PATCH v11 8/8] qemu.py: don't launch again before shutdown()

On Tue, Nov 14, 2017 at 11:22:46AM +0100, Amador Pahim wrote: > If a VM is launched, files are created and a cleanup is required before > a new launch. This cleanup is executed by shutdown(), so shutdown() must > be called even if the VM is manually terminated (i.e. using kill). > > This patch

Re: [Qemu-devel] [PATCH v11 7/8] qemu.py: launch vm only if it's not running

On Tue, Nov 14, 2017 at 11:22:45AM +0100, Amador Pahim wrote: > If we allow launching VM again we will loose track of the first launched > VM. > > Reviewed-by: Fam Zheng > Signed-off-by: Amador Pahim > --- > scripts/qemu.py | 3 +++ > 1 file changed, 3

Re: [Qemu-devel] [qemu-s390x] [PATCH 12/12] Fix configure for s390 qemu on alpine

And the from email address is also wrong. (spurious x after .com) On 01/19/2018 05:53 PM, Christian Borntraeger wrote: > ignore the 12/12, it is just one patch > > On 01/19/2018 05:42 PM, Christian Borntraeger wrote: >> From: Alice Frosi >> >> In alpine docker

Re: [Qemu-devel] [PATCH v11 6/8] qemu.py: cleanup redundant calls in launch()

On Tue, Nov 14, 2017 at 11:22:44AM +0100, Amador Pahim wrote: > Now that shutdown() is guaranteed to always execute self._load_io_log() > and self._post_shutdown(), their calls in 'except' became redundant and > we can safely replace it by a call to shutdown(). > > Reviewed-by: Fam Zheng

Re: [Qemu-devel] [PATCH v11 5/8] qemu.py: use poll() instead of 'returncode'

On Tue, Nov 14, 2017 at 11:22:43AM +0100, Amador Pahim wrote: > The 'returncode' Popen attribute is not guaranteed to be updated. It > actually depends on a call to either poll(), wait() or communicate(). > > On the other hand, poll() will: "Check if child process has terminated. > Set and return

Re: [Qemu-devel] [PATCH v11 4/8] qemu.py: always cleanup on shutdown()

On Tue, Nov 14, 2017 at 11:22:42AM +0100, Amador Pahim wrote: > Currently we only cleanup on shutdown() if the VM is running. > > To make sure we will always cleanup, this patch makes the > self._load_io_log() and the self._post_shutdown() to > always be called on shutdown(), regardless the VM

Re: [Qemu-devel] [PATCH v11 3/8] qemu.py: refactor launch()

On Tue, Nov 14, 2017 at 11:22:41AM +0100, Amador Pahim wrote: > This is just an refactor to separate the exception handler from the > actual launch procedure, improving the readability and making future > maintenances in this piece of code easier. > > Reviewed-by: Fam Zheng >

Re: [Qemu-devel] [PATCH v2] hw/char: remove legacy interface escc_init()

On 19/01/18 13:28, Laurent Vivier wrote: Move necessary stuff in escc.h and update type names. Remove slavio_serial_ms_kbd_init(). Fix code style problems reported by checkpatch.pl Update mac_newworld, mac_oldworld and sun4m to use directly the QDEV interface. Signed-off-by: Laurent Vivier

Re: [Qemu-devel] [PATCH v11 1/8] qemu.py: remove unused import

On Tue, Nov 14, 2017 at 11:22:39AM +0100, Amador Pahim wrote: > Removing 'import sys' as it's not used anywhere. > > Signed-off-by: Amador Pahim Queued on python-next. Thanks, and sorry for taking 2 months to do it. > --- > scripts/qemu.py | 1 - > 1 file changed, 1

Re: [Qemu-devel] [PATCH v11 2/8] qemu.py: better control of created files

Hi Amador, First of all, sorry for reviewing this so late. On Tue, Nov 14, 2017 at 11:22:40AM +0100, Amador Pahim wrote: > To launch a VM, we need to create basically two files: the monitor > socket (if it's a UNIX socket) and the qemu log file. > > For the qemu log file, we currently just open

Re: [Qemu-devel] [RFC] qid path collision issues in 9pfs

On 1/19/2018 4:52 PM, Eduard Shishkin wrote: > > > On 1/19/2018 11:27 AM, Greg Kurz wrote: >> On Mon, 15 Jan 2018 11:49:31 +0800 >> Antonios Motakis wrote: >> >>> On 13-Jan-18 00:14, Greg Kurz wrote: On Fri, 12 Jan 2018 19:32:10 +0800 Antonios Motakis

Re: [Qemu-devel] vhost-pci and virtio-vhost-user

On Thu, Jan 18, 2018 at 07:51:49PM +0800, Jason Wang wrote: > > > On 2018年01月18日 18:51, Stefan Hajnoczi wrote: > > On Tue, Jan 16, 2018 at 01:41:37PM +0800, Jason Wang wrote: > > > > > > On 2018年01月15日 21:56, Stefan Hajnoczi wrote: > > > > On Mon, Jan 15, 2018 at 02:56:31PM +0800, Jason Wang

Re: [Qemu-devel] [PATCH v5 00/14] Support building with py2 or py3

On Tue, Jan 16, 2018 at 01:42:03PM +, Daniel P. Berrange wrote: > This is an update for my previously posted series: > > v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg06528.html > v3: https://lists.gnu.org/archive/html/qemu-devel/2018-01/msg02978.html > v4:

Re: [Qemu-devel] [PATCH v2 4/5] tpm: add CRB device

On 01/19/2018 09:11 AM, Marc-André Lureau wrote: tpm_crb is a device for TPM 2.0 Command Response Buffer (CRB) Interface as defined in TCG PC Client Platform TPM Profile (PTP) Specification Family “2.0” Level 00 Revision 01.03 v22. The PTP allows device implementation to switch between TIS and

Re: [Qemu-devel] [PATCH V4 1/7] CAN bus simple messages transport implementation for QEMU

Hello Philippe, On Friday 19 of January 2018 13:38:11 Philippe Mathieu-Daudé wrote: > > diff --git a/hw/can/Makefile.objs b/hw/can/Makefile.objs > > new file mode 100644 > > index 00..1028d7c455 > > --- /dev/null > > +++ b/hw/can/Makefile.objs > > @@ -0,0 +1,6 @@ > > +# CAN bus interfaces

Re: [Qemu-devel] [PULL 00/27] Migration pull

On 19 January 2018 at 16:43, Alexey Perevalov wrote: > As I remember, I tested build in QEMU's docker build system, > but now I checked it on i386 Ubuntu, and yes linker says about unresolved > atomic symbols. Next week, I'll have a time to investigate it deeper. This

  1   2   3   4   >