Re: [Qemu-devel] [PATCH v5] cocoa.m: Add ability for user to specify mouse ungrab key

2018-02-01 Thread Gerd Hoffmann
Hi, > > Well, the modifier key changes are actually sent to the guest, but > > usually they have no effect there. > > > > So, if you press Ctrl-Alt-F, the guest will see the keydown and keyup > > events for ctrl and alt. It will not see the 'f', because SDL hijacks > > that. > > Maybe the f c

Re: [Qemu-devel] [PATCH] hw/audio/sb16.c: Convert file to new logging API

2018-02-01 Thread Gerd Hoffmann
> > ldebug() should probably trace points. > > I need help with this. I tried replacing ldebug() with > "qemu_log_mask(LOG_TRACE,", but that caused a lot of messages to be > printed to the terminal. It is odd because I thought I had to use "-d > trace" to make it print. Do you have another suggest

Re: [Qemu-devel] [PATCH v2 01/19] Use #include "..." for our own headers, <...> for others

2018-02-01 Thread Thomas Huth
On 01.02.2018 07:57, Markus Armbruster wrote: > Thomas Huth writes: > >> On 31.01.2018 15:48, Markus Armbruster wrote: >>> System headers should be included with <...>, our own headers with >>> "...". Offenders tracked down with an ugly, brittle and probably >>> buggy Perl script. Previous itera

[Qemu-devel] [PATCH] net/socket: change net_socket_listen_init to use qemu-socket functions

2018-02-01 Thread Zihan Yang
net_socket_listen_init directly uses parse_host_port, bind and listen, change it to use functions in include/qemu/sockets.h Signed-off-by: Zihan Yang --- net/socket.c | 30 +- 1 file changed, 9 insertions(+), 21 deletions(-) diff --git a/net/socket.c b/net/socket.c i

Re: [Qemu-devel] [RfC PATCH v2 0/5] vfio: add display support

2018-02-01 Thread Gerd Hoffmann
Hi, > > plese test and review, > > may never come to fruition. As for testing, region support was > included for NVIDIA, dmabuf for Intel... is this testing request mainly > for the Kirti and others at NVIDIA? Thanks, Yes. v1 was tested by Kirti and I've fixed up two small issues pointed ou

[Qemu-devel] [PATCH] vnc: use stubs for CONFIG_VNC=n dummy functions

2018-02-01 Thread Gerd Hoffmann
Cc: Markus Armbruster Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 21 - ui/vnc-stubs.c | 21 + ui/Makefile.objs | 1 + 3 files changed, 22 insertions(+), 21 deletions(-) create mode 100644 ui/vnc-stubs.c diff --git a/include/ui/con

[Qemu-devel] [Bug 1576347] Re: Only one NVMe device is usable in Windows (10) guest

2018-02-01 Thread Marshall Porter
Hello, I can also confirm that if you have a series of NVMe devices, at first when just the OVMF boot menu has loaded, using qemu with a -monitor and typing 'info pci', it appears that all are given valid bus addresses. However, once the Windows 10 x64 installer iso loads, it seems that every othe

Re: [Qemu-devel] [PATCH v2 1/6] hw/sd/milkymist-memcard: use qemu_log_mask()

2018-02-01 Thread Michael Walle
Am 2018-01-23 04:58, schrieb Philippe Mathieu-Daudé: Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael Walle --- hw/sd/milkymist-memcard.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/sd/milkymist-memcard.c b/hw/sd/milkymist-memcard.c inde

Re: [Qemu-devel] [PATCH v2 3/6] hw/sd/milkymist-memcard: expose a SDBus and connect the SDCard to it

2018-02-01 Thread Michael Walle
Am 2018-01-23 04:58, schrieb Philippe Mathieu-Daudé: using the sdbus_*() API. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael Walle --- hw/sd/milkymist-memcard.c | 38 +- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/hw/sd/milk

Re: [Qemu-devel] [PATCH v2 2/6] hw/sd/milkymist-memcard: split realize() out of SysBusDevice init()

2018-02-01 Thread Michael Walle
Am 2018-01-23 04:58, schrieb Philippe Mathieu-Daudé: Create the SDCard in the realize() function. Suggested-by: Michael Walle Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael Walle --- hw/sd/milkymist-memcard.c | 28 1 file changed, 16 insertions(+), 1

Re: [Qemu-devel] [PATCH] lm32: take BQL before writing IP/IM register

2018-02-01 Thread Michael Walle
Hi Peter, do you apply this patch? Or do I have to send a pull request? -michael Am 2018-01-09 18:01, schrieb Michael Walle: Writing to these registers may raise an interrupt request. Actually, this prevents the milkymist board from starting. Cc: qemu-sta...@nongnu.org Signed-off-by: Michael

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-02-01 Thread Christoffer Dall
On Wed, Jan 31, 2018 at 9:15 PM, Ard Biesheuvel wrote: > On 31 January 2018 at 19:12, Christoffer Dall > wrote: >> On Wed, Jan 31, 2018 at 7:00 PM, Ard Biesheuvel >> wrote: >>> On 31 January 2018 at 17:39, Christoffer Dall >>> wrote: On Wed, Jan 31, 2018 at 5:59 PM, Ard Biesheuvel wr

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-02-01 Thread Ard Biesheuvel
On 1 February 2018 at 09:17, Christoffer Dall wrote: > On Wed, Jan 31, 2018 at 9:15 PM, Ard Biesheuvel > wrote: >> On 31 January 2018 at 19:12, Christoffer Dall >> wrote: >>> On Wed, Jan 31, 2018 at 7:00 PM, Ard Biesheuvel >>> wrote: On 31 January 2018 at 17:39, Christoffer Dall wrot

[Qemu-devel] [PATCH qemu] slirp/debug: Print IP addresses in human readable form

2018-02-01 Thread Alexey Kardashevskiy
Signed-off-by: Alexey Kardashevskiy --- slirp/arp_table.c | 4 ++-- slirp/socket.c| 8 slirp/udp.c | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/slirp/arp_table.c b/slirp/arp_table.c index 3547043..bac608f 100644 --- a/slirp/arp_table.c +++ b/slirp/ar

[Qemu-devel] [RFC PATCH qemu] slirp: Update forwarding IP address if guest receiver non-default IP

2018-02-01 Thread Alexey Kardashevskiy
If we run QEMU with -netdev user,id=USER0,hostfwd=tcp::-:22, it starts a DHCP server and starts allocating client IPs from 10.0.2.15 so this is what the guest normally receives. Since QEMU automatically adds the DHCP starting address into the forwarding table, everything works. This is the tabl

Re: [Qemu-devel] [PULL v5 39/43] hw/hppa: Implement DINO system board

2018-02-01 Thread Thomas Huth
On 30.01.2018 05:46, Richard Henderson wrote: > From: Helge Deller > > Now that we have the prerequisites in target/hppa/, > implement the hardware for a PA7100LC. > > This also enables build for hppa-softmmu. > > Signed-off-by: Helge Deller > [rth: Since it is all new code, squashed all branc

Re: [Qemu-devel] vhost-user question

2018-02-01 Thread Dr. David Alan Gilbert
* jack.chen (zhun...@gmail.com) wrote: > thanks,but I really can not understand how the fd works,can someone > explain it or give me some reference material?? Probably the man page for the mmap system call, or an introduction to linux/unix syscalls. Just remember that any shared memory will be '

Re: [Qemu-devel] [PATCH v3 13/39] qcow2: Add l2_slice_size field to BDRVQcow2State

2018-02-01 Thread Alberto Garcia
On Wed 31 Jan 2018 08:48:08 PM CET, Max Reitz wrote: > On 2018-01-26 15:59, Alberto Garcia wrote: >> The BDRVQcow2State structure contains an l2_size field, which stores >> the number of 64-bit entries in an L2 table. >> >> For efficiency reasons we want to be able to load slices instead of >> ful

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-02-01 Thread Christoffer Dall
On Thu, Feb 1, 2018 at 10:33 AM, Ard Biesheuvel wrote: > On 1 February 2018 at 09:17, Christoffer Dall > wrote: >> On Wed, Jan 31, 2018 at 9:15 PM, Ard Biesheuvel >> wrote: >>> On 31 January 2018 at 19:12, Christoffer Dall >>> wrote: On Wed, Jan 31, 2018 at 7:00 PM, Ard Biesheuvel wr

Re: [Qemu-devel] [PATCH v2 1/2] s390x/tcg: wire up pci instructions

2018-02-01 Thread Pierre Morel
On 31/01/2018 19:17, Cornelia Huck wrote: On s390x, pci support is implemented via a set of instructions (no mmio). Unfortunately, none of them are documented in the PoP; the code is based upon the existing implementation for KVM and the Linux zpci driver. Signed-off-by: Cornelia Huck --- tar

Re: [Qemu-devel] [PATCH qemu] slirp/debug: Print IP addresses in human readable form

2018-02-01 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180201093545.33741-1-...@ozlabs.ru Subject: [Qemu-devel] [PATCH qemu] slirp/debug: Print IP addresses in human readable form === TEST SCRIPT BEGIN === #!/bin/bash BASE=ba

[Qemu-devel] [PATCH 0/3] Add more tests to the boot-serial tester

2018-02-01 Thread Thomas Huth
First patch adds new tests for the SPARC machines, second patch enables the Mac machines, too, and the third patch adds a test for the brand-new hppa softmmu machine. Thomas Huth (3): tests/boot-serial: Enable the boot-serial test on SPARC machines, too tests/boot-serial: Add tests for PowerPC

[Qemu-devel] [PATCH 1/3] tests/boot-serial: Enable the boot-serial test on SPARC machines, too

2018-02-01 Thread Thomas Huth
OpenBIOS prints out the name of the detected CPU here, so looking for this string is a nice test to verify that the CPU detection is still working correctly. Signed-off-by: Thomas Huth --- tests/Makefile.include | 2 ++ tests/boot-serial-test.c | 4 2 files changed, 6 insertions(+) diff

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-02-01 Thread Ard Biesheuvel
On 1 February 2018 at 09:59, Christoffer Dall wrote: > On Thu, Feb 1, 2018 at 10:33 AM, Ard Biesheuvel > wrote: >> On 1 February 2018 at 09:17, Christoffer Dall >> wrote: ... >>> >>> Unless I'm missing something fundamental, I think we should add >>> functionality in QEMU to clean+invalidate pag

[Qemu-devel] [PATCH 2/3] tests/boot-serial: Add tests for PowerPC Mac machines

2018-02-01 Thread Thomas Huth
OpenBIOS prints out the CPU type on these machine types, so we can use this string to test whether the CPU detection is working correctly. Signed-off-by: Thomas Huth --- tests/boot-serial-test.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/boot-serial-test.c b/tests/boot-serial-t

[Qemu-devel] [PATCH 3/3] tests/boot-serial: Add a test for the new hppa-softmmu target

2018-02-01 Thread Thomas Huth
The hppa machine comes with a firmware image, so we can easily include this in the boot-serial tester, too. Signed-off-by: Thomas Huth --- tests/Makefile.include | 2 ++ tests/boot-serial-test.c | 1 + 2 files changed, 3 insertions(+) diff --git a/tests/Makefile.include b/tests/Makefile.inclu

Re: [Qemu-devel] vhost-user question

2018-02-01 Thread jack.chen
Thanks,But my question is how the fd belonging to qemu can be used in another process such as DPDK?is fd just effective within one process? for example ,if process A open file a.txt,and it gets one fd。the fd can only be used in process A ,can it be used in process B? 2018-02-01 17:51 GMT+08:00 Dr.

Re: [Qemu-devel] [PATCH v4 0/6] nvdimm: support MAP_SYNC for memory-backend-file

2018-02-01 Thread Haozhong Zhang
On 01/31/18 19:02 -0800, Dan Williams wrote: > On Wed, Jan 31, 2018 at 6:29 PM, Haozhong Zhang > wrote: > > + vfio maintainer Alex Williamson in case my understanding of vfio is > > incorrect. > > > > On 01/31/18 16:32 -0800, Dan Williams wrote: > >> On Wed, Jan 31, 2018 at 4:24 PM, Haozhong Zhan

Re: [Qemu-devel] [PATCH] vnc: use stubs for CONFIG_VNC=n dummy functions

2018-02-01 Thread Daniel P . Berrangé
On Thu, Feb 01, 2018 at 09:45:35AM +0100, Gerd Hoffmann wrote: > Cc: Markus Armbruster > Signed-off-by: Gerd Hoffmann > --- > include/ui/console.h | 21 - > ui/vnc-stubs.c | 21 + > ui/Makefile.objs | 1 + > 3 files changed, 22 insertions(+), 21

Re: [Qemu-devel] vhost-user question

2018-02-01 Thread Dr. David Alan Gilbert
* jack.chen (zhun...@gmail.com) wrote: > Thanks,But my question is how the fd belonging to qemu can be used in > another process such as DPDK?is fd just effective within one process? > for example ,if process A open file a.txt,and it gets one fd。the fd > can only be used in process A ,can it be use

[Qemu-devel] [Bug 1716028] Re: qemu 2.10 locks images with no feature flag

2018-02-01 Thread Launchpad Bug Tracker
This bug was fixed in the package libvirt - 4.0.0-1ubuntu1 --- libvirt (4.0.0-1ubuntu1) bionic; urgency=medium * Merged with Debian unstable (4.0) This closes several bugs: - Error generating apparmor profile when hostname contains spaces (LP: #77) - qemu 2.10

Re: [Qemu-devel] [PATCH v3 18/39] qcow2: Refactor get_cluster_table()

2018-02-01 Thread Alberto Garcia
On Wed 31 Jan 2018 09:11:48 PM CET, Max Reitz wrote: > On 2018-01-26 15:59, Alberto Garcia wrote: >> After the previous patch we're now always using l2_load() in >> get_cluster_table() regardless of whether a new L2 table has to be >> allocated or not. >> >> This patch refactors that part of the c

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-02-01 Thread Andrew Jones
On Thu, Feb 01, 2018 at 10:59:54AM +0100, Christoffer Dall wrote: > On Thu, Feb 1, 2018 at 10:33 AM, Ard Biesheuvel > wrote: > > On 1 February 2018 at 09:17, Christoffer Dall > > wrote: > >> On Wed, Jan 31, 2018 at 9:15 PM, Ard Biesheuvel > >> wrote: > >>> On 31 January 2018 at 19:12, Christoffe

Re: [Qemu-devel] [PATCH] Add a git-publish configuration file

2018-02-01 Thread Stefan Hajnoczi
On Wed, Jan 31, 2018 at 11:06:05AM +0100, Marc-André Lureau wrote: > Hi > > On Wed, Jan 31, 2018 at 6:33 AM, Fam Zheng wrote: > > git-publish [1] is a convenient tool to send patches and has been > > popular among QEMU developers. Recently it has been made available in > > Fedora official repo t

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-02-01 Thread Christoffer Dall
On Thu, Feb 01, 2018 at 11:42:22AM +0100, Andrew Jones wrote: > On Thu, Feb 01, 2018 at 10:59:54AM +0100, Christoffer Dall wrote: > > On Thu, Feb 1, 2018 at 10:33 AM, Ard Biesheuvel > > wrote: > > > On 1 February 2018 at 09:17, Christoffer Dall > > > wrote: > > >> On Wed, Jan 31, 2018 at 9:15 PM,

Re: [Qemu-devel] vhost-user question

2018-02-01 Thread jack
that is what i really want to know,thanks very very much!!! from jack chen On 2/1/2018 18:30,[1]Dr. David Alan Gilbert wrote: * jack.chen (zhun...@gmail.com) wrote: > Thanks,But my question is how the fd belonging to qemu can be used in > another process such as DPDK

[Qemu-devel] [PATCH v2] vcpu: join vcpu thread after it exiting

2018-02-01 Thread linzhecheng
As we create vcpu thread with QEMU_THREAD_JOINABLE mode, we should join it after it exiting to cleanup resources. Signed-off-by: linzhecheng diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index f290f48..5cc1ba2 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -282,9 +282,9 @

[Qemu-devel] [PATCH v2] vl: pause vcpus before stopping iothreads

2018-02-01 Thread Stefan Hajnoczi
Commit dce8921b2baaf95974af8176406881872067adfa ("iothread: Stop threads before main() quits") introduced iothread_stop_all() to avoid the following virtio-scsi assertion failure: assert(blk_get_aio_context(d->conf.blk) == s->ctx); Back then the assertion failed because when bdrv_close_all() ma

Re: [Qemu-devel] [PATCH] vl: pause vcpus before stopping iothreads

2018-02-01 Thread Stefan Hajnoczi
On Wed, Jan 31, 2018 at 03:31:27PM +0100, Kevin Wolf wrote: > Am 31.01.2018 um 14:56 hat Stefan Hajnoczi geschrieben: > > On Tue, Jan 30, 2018 at 05:54:56PM +0100, Kevin Wolf wrote: > > > Am 30.01.2018 um 16:38 hat Stefan Hajnoczi geschrieben: > > > > Commit dce8921b2baaf95974af8176406881872067adfa

Re: [Qemu-devel] [PATCH] vnc: use stubs for CONFIG_VNC=n dummy functions

2018-02-01 Thread Markus Armbruster
Gerd Hoffmann writes: > Cc: Markus Armbruster > Signed-off-by: Gerd Hoffmann Cool! Reviewed-by: Markus Armbruster

[Qemu-devel] [PULL 0/1] Dump patches

2018-02-01 Thread Marc-André Lureau
The following changes since commit b05631954d6dfe93340d516660397e2c1a2a5dd6: Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20180131' into staging (2018-01-31 15:50:29 +) are available in the Git repository at: https://github.com/elmarco/qemu.git tags/dump-pull-request for yo

[Qemu-devel] [PULL 1/1] dump-guest-memory.py: skip vmcoreinfo section if not available

2018-02-01 Thread Marc-André Lureau
On some architectures, qemu doesn't support vmcoreinfo device, and dump-guest-memory fails: (gdb) dump-guest-memory /tmp/vmcore ppc64-le guest RAM blocks: target_start target_end host_addrmessage count --- -

[Qemu-devel] [PATCH v3 06/19] Include qmp-commands.h exactly where needed

2018-02-01 Thread Markus Armbruster
Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster --- block.c| 1 - blockjob.c | 1 - hw/acpi/acpi-stub.c| 1 - hw/ppc/spapr.c | 1 - hw/s390x/s390-stattrib.c | 1 - hw/smbios/smbios-stub.c|

[Qemu-devel] [PATCH v3 17/19] Drop superfluous includes of qapi/qmp/dispatch.h

2018-02-01 Thread Markus Armbruster
Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster --- monitor.c | 1 - qga/main.c| 1 - tests/test-qmp-commands.c | 1 - 3 files changed, 3 deletions(-) diff --git a/monitor.c b/monitor.c index 02d9dd8708..6f70c8db9a 10

[Qemu-devel] [PATCH v3 05/19] Drop superfluous includes of qapi/qmp/qerror.h

2018-02-01 Thread Markus Armbruster
Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster --- backends/tpm.c | 1 - block/qcow.c | 1 - block/qed.c| 1 - blockdev-nbd.c | 1 - hw/s390x/s390-virtio-ccw.c | 1 - net/colo-compare.c |

[Qemu-devel] [PATCH v3 15/19] Include qapi/qmp/qnum.h exactly where needed

2018-02-01 Thread Markus Armbruster
Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster --- tests/check-qlit.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/check-qlit.c b/tests/check-qlit.c index f012885534..5d0f65b9c7 100644 --- a/tests/check-qlit.c +++ b/tests/check-qlit.c @@

[Qemu-devel] [PATCH v3 03/19] Drop superfluous includes of qapi-types.h and test-qapi-types.h

2018-02-01 Thread Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Eric Blake Signed-off-by: Markus Armbruster --- backends/cryptodev.c | 1 - backends/hostmem.c | 1 - hmp.h| 1 - include/block/block.h| 1 - include/block/block_in

[Qemu-devel] [PATCH v3 07/19] Typedef the subtypes of QObject in qemu/typedefs.h, too

2018-02-01 Thread Markus Armbruster
This renders many inclusions of qapi/qmp/q*.h superfluous. They'll be dropped in the next few commits. Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster --- include/qapi/qmp/qbool.h | 4 ++-- include/qapi/qmp/qdict.h | 4 ++-- include/qapi/qmp/ql

[Qemu-devel] [PATCH v3 13/19] Include qapi/qmp/qstring.h exactly where needed

2018-02-01 Thread Markus Armbruster
Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster --- block.c | 1 + include/qapi/qmp/qjson.h| 2 -- monitor.c | 1 + qapi/qobject-input-visitor.c| 1 + qemu-img.c

[Qemu-devel] [PATCH v3 09/19] qdict qlist: Make most helper macros functions

2018-02-01 Thread Markus Armbruster
The macro expansions of qdict_put_TYPE() and qlist_append_TYPE() need qbool.h, qnull.h, qnum.h and qstring.h to compile. We include qnull.h and qnum.h in the headers, but not qbool.h and qstring.h. Works, because we include those wherever the macros get used. Open-coding these helpers is of dubi

[Qemu-devel] [PATCH v3 18/19] Drop superfluous includes of qapi/qmp/qjson.h

2018-02-01 Thread Markus Armbruster
Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster --- balloon.c | 1 - block/nbd.c | 1 - block/quorum.c | 1 - blockjob.c | 1 - hw/core/qdev.c

[Qemu-devel] [PATCH v3 11/19] Include qapi/qmp/qlist.h exactly where needed

2018-02-01 Thread Markus Armbruster
This cleanup makes the number of objects depending on qapi/qmp/qlist.h drop from 4551 (out of 4743) to 16 in my "build everything" tree. While there, separate #include from file comment with a blank line. Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbrust

[Qemu-devel] [PATCH v3 02/19] Clean up includes

2018-02-01 Thread Markus Armbruster
Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes, with the change to target/s390x/gen-features.c manually reverted, and blank lines around deletions collapsed. Reviewed-by: Eric Blake R

[Qemu-devel] [PATCH v3 16/19] Include qapi/qmp/qnull.h exactly where needed

2018-02-01 Thread Markus Armbruster
Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster --- target/ppc/translate.c | 1 - target/ppc/translate_init.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index eeaad9e91f..4

[Qemu-devel] [PATCH v3 01/19] Use #include "..." for our own headers, <...> for others

2018-02-01 Thread Markus Armbruster
System headers should be included with <...>, our own headers with "...". Offenders tracked down with an ugly, brittle and probably buggy Perl script. Previous iteration was commit a9c94277f0. Delete inclusions of "string.h" and "strings.h" instead of fixing them to and , because we always incl

[Qemu-devel] [PATCH v3 00/19] Clean up includes to reduce compile time

2018-02-01 Thread Markus Armbruster
We have awfully many "touch it, recompile the world" headers. Right now, I count about fifty that are prerequisites of more than half the objects in my "build everything" tree. Some of them are that way by necessity. Many of them are not. This series takes care of six I happen to touch, because

[Qemu-devel] [PATCH v3 08/19] Eliminate qapi/qmp/types.h

2018-02-01 Thread Markus Armbruster
qapi/qmp/types.h is a convenience header to include a number of qapi/qmp/ headers. Since we rarely need all of the headers qapi/qmp/types.h includes, we bypass it most of the time. Most of the places that use it don't need all the headers, either. Include the necessary headers directly, and drop

[Qemu-devel] [PATCH v3 19/19] Move include qemu/option.h from qemu-common.h to actual users

2018-02-01 Thread Markus Armbruster
qemu-common.h includes qemu/option.h, but most places that include the former don't actually need the latter. Drop the include, and add it to the places that actually need it. While there, drop superfluous includes of both headers, and separate #include from file comment with a blank line. This

[Qemu-devel] [PATCH v3 10/19] Include qapi/qmp/qobject.h exactly where needed

2018-02-01 Thread Markus Armbruster
Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster --- include/block/block.h | 1 - include/qapi/qmp/dispatch.h | 1 - include/qapi/qmp/qjson.h | 1 - include/qapi/qobject-input-visitor.h | 1 - include/qapi/qobje

Re: [Qemu-devel] [PATCH 1/3] s390x/pci: fixup the code walking IOMMU tables

2018-02-01 Thread Yi Min Zhao
在 2018/1/31 下午6:58, Cornelia Huck 写道: On Tue, 30 Jan 2018 10:47:13 +0100 Yi Min Zhao wrote: Current s390x PCI IOMMU code is lack of flags' checking, including: 1) protection bit 2) table length 3) table offset 4) intermediate tables' invalid bit 5) format control bit This patch introduces a

Re: [Qemu-devel] [PATCH v6 0/4] cryptodev: add vhost support

2018-02-01 Thread Zhoujian (jay)
Hi Michael, I am wondering whether this version is OK for you? Any comment will be appreciated, thanks. Regards, Jay > -Original Message- > From: Zhoujian (jay) > Sent: Sunday, January 21, 2018 8:55 PM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com; pbonz...@redhat.com; Huangweidong (C

[Qemu-devel] [PATCH v3 04/19] Include qapi/error.h exactly where needed

2018-02-01 Thread Markus Armbruster
This cleanup makes the number of objects depending on qapi/error.h drop from 1910 (out of 4743) to 1612 in my "build everything" tree. While there, separate #include from file comment with a blank line, and drop a useless comment on why qemu/osdep.h is included first. Reviewed-by: Eric Blake Rev

Re: [Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

2018-02-01 Thread Stefan Hajnoczi
On Wed, Jan 31, 2018 at 03:22:49PM +0100, Kevin Wolf wrote: > Am 31.01.2018 um 15:12 hat Stefan Hajnoczi geschrieben: > > There should be a separate paragraph in docs/qemu-block-drivers.texi > > explaining that share-rw=on can be used safely with format=raw if the > > guests are configured to safel

Re: [Qemu-devel] [PATCH] sii3112: Change angle brackets to quotes in #include lines

2018-02-01 Thread BALATON Zoltan
On Wed, 31 Jan 2018, David Gibson wrote: On Tue, Jan 30, 2018 at 02:10:10PM +0100, BALATON Zoltan wrote: This matches what other files do for qemu includes Signed-off-by: BALATON Zoltan Applied, thanks. Thanks but Markus instead included this in his cleanup patches here: http://lists.nongn

Re: [Qemu-devel] [PATCH 1/3] s390x/pci: fixup the code walking IOMMU tables

2018-02-01 Thread Pierre Morel
On 01/02/2018 12:28, Yi Min Zhao wrote: 在 2018/1/31 下午6:58, Cornelia Huck 写道: On Tue, 30 Jan 2018 10:47:13 +0100 Yi Min Zhao wrote: Current s390x PCI IOMMU code is lack of flags' checking, including: 1) protection bit 2) table length 3) table offset 4) intermediate tables' invalid bit 5) fo

[Qemu-devel] [PATCH] vl: fix possible int overflow for qemu_timedate_diff()

2018-02-01 Thread Gonglei
From: shenghualong When the Windows guest users set the time to year 2099, the return value of qemu_timedate_diff() will overflow with variable clock mode as below format: Let's change the return value of qemu_timedate_diff() from int to time_t to fix the possible overflow problem. Signed-of

Re: [Qemu-devel] [PATCH 3/3] s390x/pci: use the right pal and pba in reg_ioat()

2018-02-01 Thread Cornelia Huck
On Thu, 1 Feb 2018 12:33:01 +0100 Pierre Morel wrote: > On 31/01/2018 12:44, Cornelia Huck wrote: > > On Tue, 30 Jan 2018 10:47:15 +0100 > > Yi Min Zhao wrote: > > > >> When registering ioat, pba should be comprised of leftmost 52 bits and > >> rightmost 12 binary zeros, and pal should be comp

Re: [Qemu-devel] MTTCG External Halt

2018-02-01 Thread Alex Bennée
Alistair Francis writes: > On Wed, Jan 31, 2018 at 12:32 PM, Alex Bennée wrote: >> >> Alistair Francis writes: >> >>> On Tue, Jan 30, 2018 at 8:26 PM, Paolo Bonzini wrote: On 30/01/2018 18:56, Alistair Francis wrote: > > I don't have a good solution though, as setting CPU_INTERRU

Re: [Qemu-devel] [PATCH V8 1/4] mem: add share parameter to memory-backend-ram

2018-02-01 Thread Eduardo Habkost
On Thu, Feb 01, 2018 at 07:36:50AM +0200, Marcel Apfelbaum wrote: > On 01/02/2018 4:22, Michael S. Tsirkin wrote: > > On Wed, Jan 31, 2018 at 09:34:22PM -0200, Eduardo Habkost wrote: [...] > >> BTW, what's the root cause for requiring HVAs in the buffer? > > > > It's a side effect of the kernel/us

Re: [Qemu-devel] [PATCH v6 10/23] sev: add command to initialize the memory encryption context

2018-02-01 Thread Dr. David Alan Gilbert
* Brijesh Singh (brijesh.si...@amd.com) wrote: > When memory encryption is enabled, KVM_SEV_INIT command is used to > initialize the platform. The command loads the SEV related persistent > data from non-volatile storage and initializes the platform context. > This command should be first issued be

Re: [Qemu-devel] [PATCH 1/3] s390x/pci: fixup the code walking IOMMU tables

2018-02-01 Thread Cornelia Huck
On Thu, 1 Feb 2018 12:56:01 +0100 Pierre Morel wrote: > On 01/02/2018 12:28, Yi Min Zhao wrote: > > > > > > 在 2018/1/31 下午6:58, Cornelia Huck 写道: > >> On Tue, 30 Jan 2018 10:47:13 +0100 > >> Yi Min Zhao wrote: > >>> diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c > >>> index

[Qemu-devel] [Bug 1716028] Re: qemu 2.10 locks images with no feature flag

2018-02-01 Thread ChristianEhrhardt
The avoidance for libvirt driven cases to map onto share-rw is complete in Bionic now, so I started to look into a potential SRU. But looking back it seems in the meantime everybody learned how to use it. I have not seen any more dups coming in recently. The same is true for openstack and likely

Re: [Qemu-devel] [PATCH v5] cocoa.m: Add ability for user to specify mouse ungrab key

2018-02-01 Thread BALATON Zoltan
On Wed, 31 Jan 2018, Programmingkid wrote: Basically there is a array that acts as a check list. It checks off keys that belong to the ungrab sequence as they are detected. Once a non-ungrab key is detected, the check list is cleared. If all the ungrab keys are detected the ungrab code is execute

Re: [Qemu-devel] [PATCH 3/3] s390x/pci: use the right pal and pba in reg_ioat()

2018-02-01 Thread Pierre Morel
On 31/01/2018 12:44, Cornelia Huck wrote: On Tue, 30 Jan 2018 10:47:15 +0100 Yi Min Zhao wrote: When registering ioat, pba should be comprised of leftmost 52 bits and rightmost 12 binary zeros, and pal should be comprised of leftmost 52 bits and right most 12 binary ones. Let's fixup this. Re

Re: [Qemu-devel] Savevm and loadvm not working

2018-02-01 Thread sridhar kulkarni via Qemu-devel
On Tuesday, January 30, 2018 5:25 PM, Peter Xu wrote: On Tue, Jan 30, 2018 at 10:34:31AM +, sridhar kulkarni via Qemu-devel wrote: > Hi, > I am new bee to snapshot feature and how to use it correctly. My requirement > is simple, in that I want to snapshot the running VM and save t

Re: [Qemu-devel] [PATCH] pcie-root-port: let it has higher migrate priority

2018-02-01 Thread Marcel Apfelbaum
Hi Peter, On 01/02/2018 13:20, Peter Xu wrote: > In the past, we prioritized IOMMU migration so that we have such a > priority order: > > IOMMU > PCI Devices > > When migrating a guest with both vIOMMU and pcie-root-port, we'll always > migrate vIOMMU first, since pcie-root-port will be seen

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-02-01 Thread Andrew Jones
On Thu, Feb 01, 2018 at 11:48:31AM +0100, Christoffer Dall wrote: > On Thu, Feb 01, 2018 at 11:42:22AM +0100, Andrew Jones wrote: > > On Thu, Feb 01, 2018 at 10:59:54AM +0100, Christoffer Dall wrote: > > > On Thu, Feb 1, 2018 at 10:33 AM, Ard Biesheuvel > > > > If you could use dirty page tracking

Re: [Qemu-devel] Savevm and loadvm not working

2018-02-01 Thread Peter Maydell
On 1 February 2018 at 12:19, sridhar kulkarni via Qemu-devel wrote: > I thought that RAM contents are not saved because of return value > RAM_SAVE_CONTROL_NOT_SUPP. Now that you clarified about this, I debugged this > further. After doing loadvm operation, I am getting following > error,qemu-sy

Re: [Qemu-devel] [PATCH V8 1/4] mem: add share parameter to memory-backend-ram

2018-02-01 Thread Marcel Apfelbaum
On 01/02/2018 14:10, Eduardo Habkost wrote: > On Thu, Feb 01, 2018 at 07:36:50AM +0200, Marcel Apfelbaum wrote: >> On 01/02/2018 4:22, Michael S. Tsirkin wrote: >>> On Wed, Jan 31, 2018 at 09:34:22PM -0200, Eduardo Habkost wrote: > [...] BTW, what's the root cause for requiring HVAs in the buf

[Qemu-devel] [PATCH v3 12/19] Include qapi/qmp/qdict.h exactly where needed

2018-02-01 Thread Markus Armbruster
This cleanup makes the number of objects depending on qapi/qmp/qdict.h drop from 4550 (out of 4743) to 368 in my "build everything" tree. For qapi/qmp/qobject.h, the number drops from 4552 to 390. While there, separate #include from file comment with a blank line. Reviewed-by: Eric Blake Reviewe

Re: [Qemu-devel] [PATCH v2 2/2] s390x/cpumodel: allow zpci features in qemu model

2018-02-01 Thread David Hildenbrand
On 31.01.2018 19:17, Cornelia Huck wrote: > AEN can be provided unconditionally, ZPCI should be turned on > manually. > > With -cpu qemu,zpci=on, a 4.15 guest kernel can now successfully > detect virtio-pci devices under tcg. > > Signed-off-by: Cornelia Huck > --- > target/s390x/cpu_models.c

[Qemu-devel] [PATCH v3 14/19] Include qapi/qmp/qbool.h exactly where needed

2018-02-01 Thread Markus Armbruster
Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Markus Armbruster --- block.c| 1 - block/blkdebug.c | 1 - block/curl.c | 1 - block/qcow2.c | 1 - block/quorum.c | 1 - block/vv

[Qemu-devel] [PATCH] pcie-root-port: let it has higher migrate priority

2018-02-01 Thread Peter Xu
In the past, we prioritized IOMMU migration so that we have such a priority order: IOMMU > PCI Devices When migrating a guest with both vIOMMU and pcie-root-port, we'll always migrate vIOMMU first, since pcie-root-port will be seen to have the same priority of general PCI devices. That's pro

Re: [Qemu-devel] [PATCH v3 12/18] s390x: fix size + content of STSI blocks

2018-02-01 Thread Cornelia Huck
On Mon, 29 Jan 2018 13:56:17 +0100 David Hildenbrand wrote: > All blocks are 4k in size, which is only true for two of them right now. > Also some reserved fields were wrong, fix it and convert all reserved > fields to u8. > > This also fixes the LPAR part output in /proc/sysinfo under TCG. (for

Re: [Qemu-devel] [PATCH v2 1/2] s390x/tcg: wire up pci instructions

2018-02-01 Thread David Hildenbrand
On 31.01.2018 19:17, Cornelia Huck wrote: > On s390x, pci support is implemented via a set of instructions > (no mmio). Unfortunately, none of them are documented in the > PoP; the code is based upon the existing implementation for KVM > and the Linux zpci driver. > > Signed-off-by: Cornelia Huck

Re: [Qemu-devel] [PATCH v2 1/2] s390x/tcg: wire up pci instructions

2018-02-01 Thread Cornelia Huck
On Thu, 1 Feb 2018 13:42:52 +0100 David Hildenbrand wrote: > On 31.01.2018 19:17, Cornelia Huck wrote: > > +#ifndef CONFIG_USER_ONLY > > +void HELPER(clp)(CPUS390XState *env, uint32_t r2) > > +{ > > +S390CPU *cpu = s390_env_get_cpu(env); > > +int r; > > + > > +qemu_mutex_lock_iothrea

Re: [Qemu-devel] Windows balloon driver PFN issue

2018-02-01 Thread Michael S. Tsirkin
On Thu, Feb 01, 2018 at 10:33:50AM +0800, Peter Xu wrote: > On Thu, Feb 01, 2018 at 04:24:40AM +0200, Michael S. Tsirkin wrote: > > On Thu, Feb 01, 2018 at 10:18:53AM +0800, Peter Xu wrote: > > > On Wed, Jan 31, 2018 at 04:03:12PM +0200, Michael S. Tsirkin wrote: > > > > On Wed, Jan 31, 2018 at 05:

Re: [Qemu-devel] [PATCH V8 1/4] mem: add share parameter to memory-backend-ram

2018-02-01 Thread Michael S. Tsirkin
On Thu, Feb 01, 2018 at 07:36:50AM +0200, Marcel Apfelbaum wrote: > On 01/02/2018 4:22, Michael S. Tsirkin wrote: > > On Wed, Jan 31, 2018 at 09:34:22PM -0200, Eduardo Habkost wrote: > >> On Wed, Jan 31, 2018 at 11:10:07PM +0200, Michael S. Tsirkin wrote: > >>> On Wed, Jan 31, 2018 at 06:40:59PM -0

Re: [Qemu-devel] [PATCH v2 1/2] s390x/tcg: wire up pci instructions

2018-02-01 Thread David Hildenbrand
On 01.02.2018 13:48, Cornelia Huck wrote: > On Thu, 1 Feb 2018 13:42:52 +0100 > David Hildenbrand wrote: > >> On 31.01.2018 19:17, Cornelia Huck wrote: > >>> +#ifndef CONFIG_USER_ONLY >>> +void HELPER(clp)(CPUS390XState *env, uint32_t r2) >>> +{ >>> +S390CPU *cpu = s390_env_get_cpu(env); >>>

Re: [Qemu-devel] [PATCH 2/3] s390x/pci: fixup global refresh

2018-02-01 Thread Pierre Morel
On 31/01/2018 12:35, Cornelia Huck wrote: On Tue, 30 Jan 2018 10:47:14 +0100 Yi Min Zhao wrote: The VFIO common code doesn't provide the possibility to modify a previous mapping entry in another way than unmapping and mapping again with new properties. I'm wondering why other architectures do

Re: [Qemu-devel] [PATCH v2 01/19] Use #include "..." for our own headers, <...> for others

2018-02-01 Thread Eric Blake
On 02/01/2018 01:12 AM, Markus Armbruster wrote: >>> + >>> #include "qemu/osdep.h" >>> +#include >> >> is an obsolete spelling for the now-universal . We >> should NEVER need to include it; scripts/clean-includes should be taught >> to blacklist this one. > > "Programming today is a race betw

Re: [Qemu-devel] [PULL 00/13] Migration PULL request

2018-02-01 Thread Laurent Vivier
On 30/01/2018 07:29, Juan Quintela wrote: > Peter Maydell wrote: >> On 29 January 2018 at 12:09, Juan Quintela wrote: >>> Hi >>> >>> - migrate_fd_connect cleanup (dave) >>> - use MAX_VM_PACKAGED_SIZE >>> have to change (1<<32) for UINT32_MAX to get no warnings on win32 >>> - Use right s->threas

Re: [Qemu-devel] [PATCH v5] cocoa.m: Add ability for user to specify mouse ungrab key

2018-02-01 Thread Programmingkid
> On Feb 1, 2018, at 7:16 AM, BALATON Zoltan wrote: > > On Wed, 31 Jan 2018, Programmingkid wrote: Basically there is a array that acts as a check list. It checks off keys that belong to the ungrab sequence as they are detected. Once a non-ungrab key is detected, the check list is

Re: [Qemu-devel] [PATCH v3 17/39] qcow2: Update l2_allocate() to support L2 slices

2018-02-01 Thread Alberto Garcia
On Wed 31 Jan 2018 09:07:48 PM CET, Max Reitz wrote: > On 2018-01-26 15:59, Alberto Garcia wrote: >> This patch updates l2_allocate() to support the qcow2 cache returning >> L2 slices instead of full L2 tables. >> >> The old code simply gets an L2 table from the cache and initializes it >> with ze

Re: [Qemu-devel] [PATCH 1/3] s390x/pci: fixup the code walking IOMMU tables

2018-02-01 Thread Pierre Morel
On 01/02/2018 13:15, Cornelia Huck wrote: On Thu, 1 Feb 2018 12:56:01 +0100 Pierre Morel wrote: On 01/02/2018 12:28, Yi Min Zhao wrote: 在 2018/1/31 下午6:58, Cornelia Huck 写道: On Tue, 30 Jan 2018 10:47:13 +0100 Yi Min Zhao wrote: diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-ins

[Qemu-devel] [PATCH v7 1/7] memfd: add error argument, instead of perror()

2018-02-01 Thread Marc-André Lureau
This will allow callers to silence error report when the call is allowed to failed. Signed-off-by: Marc-André Lureau --- include/qemu/memfd.h | 5 +++-- hw/virtio/vhost.c| 8 +++- util/memfd.c | 57 +++- 3 files changed, 40 insert

[Qemu-devel] [PATCH v7 2/7] memfd: add hugetlb support

2018-02-01 Thread Marc-André Lureau
Linux commit 749df87bd7bee5a79cef073f5d032ddb2b211de8 (v4.14-rc1) added a new flag MFD_HUGETLB to memfd_create() that specify the file to be created resides in the hugetlbfs filesystem. This is the generic hugetlbfs filesystem not associated with any specific mount point. hugetlbfs does not suppo

[Qemu-devel] [PATCH v7 4/7] Add memfd based hostmem

2018-02-01 Thread Marc-André Lureau
Add a new memory backend, similar to hostmem-file, except that it doesn't need to create files. It also enforces memory sealing. This backend is mainly useful for sharing the memory with other processes. Note that Linux supports transparent huge-pages of shmem/memfd memory since 4.8. It is relati

[Qemu-devel] [PATCH v7 0/7] Add memfd memory backend

2018-02-01 Thread Marc-André Lureau
Hi, This series adds a new memory backend, similar to hostmem-file, except that it doesn't need to create files. It also enforces memory sealing. This backend is mainly useful for sharing the memory with other processes. Note that Linux supports transparent huge-pages of shmem/memfd memory since

[Qemu-devel] [PATCH v7 5/7] tests: keep compiling failing vhost-user tests

2018-02-01 Thread Marc-André Lureau
Let's protect the failing tests under a QTEST_VHOST_USER_FIXME environment variable, so we keep compiling the tests and we can easily run them. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff -

  1   2   3   4   >