[Qemu-devel] [PULL 10/11] vfio/common: Remove redundant copy of local variable

2018-02-06 Thread Alex Williamson
From: Alexey Kardashevskiy There is already @hostwin in vfio_listener_region_add() so there is no point in having the other one. Fixes: 2e4109de8e58 ("vfio/spapr: Create DMA window dynamically (SPAPR IOMMU v2)") Signed-off-by: Alexey Kardashevskiy Signed-off-by: Alex Williamson --- hw/vfio/c

[Qemu-devel] [PULL 05/11] vfio/pci: Add base BAR MemoryRegion

2018-02-06 Thread Alex Williamson
Add one more layer to our stack of MemoryRegions, this base region allows us to register BARs independently of the vfio region or to extend the size of BARs which do map to a region. This will be useful when we want hypervisor defined BARs or sections of BARs, for purposes such as relocating MSI-X

[Qemu-devel] [PULL 09/11] hw/vfio/platform: Init the interrupt mutex

2018-02-06 Thread Alex Williamson
From: Eric Auger Add the initialization of the mutex protecting the interrupt list. Signed-off-by: Eric Auger Signed-off-by: Alex Williamson --- hw/vfio/platform.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c index da84abf4fc4c..0d4bc0aae889

[Qemu-devel] [PULL 03/11] spapr/iommu: Enable in-kernel TCE acceleration via VFIO KVM device

2018-02-06 Thread Alex Williamson
From: Alexey Kardashevskiy In order to enable TCE operations support in KVM, we have to inform the KVM about VFIO groups being attached to specific LIOBNs; the necessary bits are implemented already by IOMMU MR and VFIO. This defines get_attr() for the SPAPR TCE IOMMU MR which makes VFIO call th

[Qemu-devel] [PULL 02/11] vfio/spapr: Use iommu memory region's get_attr()

2018-02-06 Thread Alex Williamson
From: Alexey Kardashevskiy In order to enable TCE operations support in KVM, we have to inform the KVM about VFIO groups being attached to specific LIOBNs. The KVM already knows about VFIO groups, the only bit missing is which in-kernel TCE table (the one with user visible TCEs) should update the

[Qemu-devel] [PULL 07/11] qapi: Create DEFINE_PROP_OFF_AUTO_PCIBAR

2018-02-06 Thread Alex Williamson
Add an option which allows the user to specify a PCI BAR number, including an 'off' and 'auto' selection. Cc: Markus Armbruster Cc: Eric Blake Tested-by: Alexey Kardashevskiy Reviewed-by: Eric Auger Tested-by: Eric Auger Reviewed-by: Markus Armbruster Signed-off-by: Alex Williamson --- hw/

[Qemu-devel] [PULL 04/11] vfio/pci: Fixup VFIOMSIXInfo comment

2018-02-06 Thread Alex Williamson
The fields were removed in the referenced commit, but the comment still mentions them. Fixes: 2fb9636ebf24 ("vfio-pci: Remove unused fields from VFIOMSIXInfo") Tested-by: Alexey Kardashevskiy Reviewed-by: Eric Auger Tested-by: Eric Auger Signed-off-by: Alex Williamson --- hw/vfio/pci.h |2

[Qemu-devel] [PULL 00/11] VFIO updates 2018-02-06

2018-02-06 Thread Alex Williamson
The following changes since commit 20e0d439a6ded635ec89f6135c08cd5541c68962: Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20180204' into staging (2018-02-06 14:21:41 +) are available in the Git repository at: git://github.com/awilliam/qemu-vfio.git tags/vfio-update-20180206.

[Qemu-devel] [PULL 01/11] memory/iommu: Add get_attr()

2018-02-06 Thread Alex Williamson
From: Alexey Kardashevskiy This adds get_attr() to IOMMUMemoryRegionClass, like iommu_ops::domain_get_attr in the Linux kernel. This defines the first attribute - IOMMU_ATTR_SPAPR_TCE_FD - which will be used between the pSeries machine and VFIO-PCI. Signed-off-by: Alexey Kardashevskiy Acked-by

Re: [Qemu-devel] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-02-06 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > 26.01.2018 18:05, Dr. David Alan Gilbert wrote: > > * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > > > 17.01.2018 19:03, Eric Blake wrote: > > > > On 01/17/2018 09:51 AM, Vladimir Sementsov-Ogievskiy wrote: > > >

Re: [Qemu-devel] [PATCH v2] iotests: 205: support luks format

2018-02-06 Thread Daniel P . Berrangé
On Tue, Feb 06, 2018 at 09:25:07PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Support default luks options in VM.add_drive and in new library > function qemu_img_create. Use it in 205 iotests. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- Reviewed-by: Daniel P. Berrange Regards, Dan

[Qemu-devel] [PATCH v2] iotests: 205: support luks format

2018-02-06 Thread Vladimir Sementsov-Ogievskiy
Support default luks options in VM.add_drive and in new library function qemu_img_create. Use it in 205 iotests. Signed-off-by: Vladimir Sementsov-Ogievskiy --- v2: use keysec0 and IMGKEYSECRET tests/qemu-iotests/205| 4 ++-- tests/qemu-iotests/iotests.py | 31 +++

Re: [Qemu-devel] [PATCH v5 1/1] s390x/cpu: expose the guest crash information

2018-02-06 Thread Christian Borntraeger
On 02/06/2018 04:31 PM, Eric Blake wrote: > On 02/06/2018 01:46 AM, Christian Borntraeger wrote: >> This patch is the s390 implementation of guest crash information, >> similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM >> property") and the related commits. We will detect several

[Qemu-devel] how to handle QOM 'container' objects whose contents depend on QOM properties?

2018-02-06 Thread Peter Maydell
[I've cc'd a fairly random selection of people who I thought might be interested or have an opinion.] It's fairly common to have a setup where we have a QOM container object (like an SoC) which in turn instantiates a lot of child objects (for all the devices). The neat way of doing this looks like

Re: [Qemu-devel] [PATCH] iotests: 205: support luks format

2018-02-06 Thread Daniel P . Berrangé
On Tue, Feb 06, 2018 at 08:57:38PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 06.02.2018 20:29, Daniel P. Berrangé wrote: > > On Tue, Feb 06, 2018 at 08:16:42PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > Support default luks options in VM.add_drive and in new library > > > function qem

Re: [Qemu-devel] [PATCH] iotests: 205: support luks format

2018-02-06 Thread Vladimir Sementsov-Ogievskiy
06.02.2018 21:04, Eric Blake wrote: On 02/06/2018 11:57 AM, Vladimir Sementsov-Ogievskiy wrote: +luks_default_secret_id = 'luks_secret_default_iotests_id' Can we just call this  "keysec0", so we matchh convention used by the shell script based tests. Here I'm trying to avoid intersection wit

Re: [Qemu-devel] [PATCH 2/2] qapi: add block latency histogram interface

2018-02-06 Thread Vladimir Sementsov-Ogievskiy
06.02.2018 18:50, Eric Blake wrote: On 02/06/2018 08:07 AM, Vladimir Sementsov-Ogievskiy wrote: Set (and clear) histogram through new command block-latency-histogram-set and show new statistics in query-blockstats results. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   qapi/block-core.json

Re: [Qemu-devel] [PATCH] iotests: 205: support luks format

2018-02-06 Thread Eric Blake
On 02/06/2018 11:57 AM, Vladimir Sementsov-Ogievskiy wrote: +luks_default_secret_id = 'luks_secret_default_iotests_id' Can we just call this  "keysec0", so we matchh convention used by the shell script based tests. Here I'm trying to avoid intersection with some user-defined id. You're ove

Re: [Qemu-devel] [PULL 00/11] VFIO updates 2018-02-05

2018-02-06 Thread Alex Williamson
On Tue, 6 Feb 2018 17:34:25 + Peter Maydell wrote: > On 5 February 2018 at 18:56, Alex Williamson > wrote: > > The following changes since commit f24ee107a07f093bd7ed475dd48d7ba57ea3d8fe: > > > > Merge remote-tracking branch > > 'remotes/kraxel/tags/ui-20180202-pull-request' into staging

Re: [Qemu-devel] [PATCH v2] s390x/cpumodel: model PTFF subfunctions for Multiple-epoch facility

2018-02-06 Thread Christian Borntraeger
On 02/06/2018 06:19 PM, Cornelia Huck wrote: > On Mon, 5 Feb 2018 13:37:17 +0100 > David Hildenbrand wrote: > >> On 05.02.2018 13:22, Cornelia Huck wrote: >>> On Mon, 5 Feb 2018 12:27:33 +0100 >>> David Hildenbrand wrote: >>> On 05.02.2018 12:22, Christian Borntraeger wrote: > Lo

Re: [Qemu-devel] [PATCH] iotests: 205: support luks format

2018-02-06 Thread Vladimir Sementsov-Ogievskiy
06.02.2018 20:29, Daniel P. Berrangé wrote: On Tue, Feb 06, 2018 at 08:16:42PM +0300, Vladimir Sementsov-Ogievskiy wrote: Support default luks options in VM.add_drive and in new library function qemu_img_create. Use it in 205 iotests. Signed-off-by: Vladimir Sementsov-Ogievskiy --- instead of

Re: [Qemu-devel] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-02-06 Thread Vladimir Sementsov-Ogievskiy
06.02.2018 19:06, Eric Blake wrote: On 02/06/2018 09:29 AM, Vladimir Sementsov-Ogievskiy wrote: most of commands, ported to hmp are done in same style: they just call corresponding qmp command. Isn't it better to provide common interface for calling qmp commands through HMP monitor, to never

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post with the presentations from DevConf and FOSDEM 2018

2018-02-06 Thread Paolo Bonzini
On 06/02/2018 17:36, Thomas Huth wrote: > Let's provide some links to the videos from DevConf and FOSDEM. > > Signed-off-by: Thomas Huth > --- > I've tried my best to find all talks that are related to QEMU, not sure > whether I've correctly identified all of them. If you are aware of any > ot

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post with the presentations from DevConf and FOSDEM 2018

2018-02-06 Thread Eduardo Otubo
On Tue, Feb 06, 2018 at 05:36:48PM +0100, Thomas Huth wrote: > Let's provide some links to the videos from DevConf and FOSDEM. > > Signed-off-by: Thomas Huth Reviewed-by: Eduardo Otubo > --- > I've tried my best to find all talks that are related to QEMU, not sure > whether I've correctly id

Re: [Qemu-devel] [PULL 00/11] VFIO updates 2018-02-05

2018-02-06 Thread Peter Maydell
On 5 February 2018 at 18:56, Alex Williamson wrote: > The following changes since commit f24ee107a07f093bd7ed475dd48d7ba57ea3d8fe: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180202-pull-request' > into staging (2018-02-02 18:54:11 +) > > are available in the Git repository a

Re: [Qemu-devel] [PATCH] iotests: 205: support luks format

2018-02-06 Thread Daniel P . Berrangé
On Tue, Feb 06, 2018 at 08:16:42PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Support default luks options in VM.add_drive and in new library > function qemu_img_create. Use it in 205 iotests. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > instead of > [PATCH] iotests: 205: suppor

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post with the presentations from DevConf and FOSDEM 2018

2018-02-06 Thread Marc-André Lureau
Hi On Tue, Feb 6, 2018 at 5:36 PM, Thomas Huth wrote: > Let's provide some links to the videos from DevConf and FOSDEM. > > Signed-off-by: Thomas Huth > --- > I've tried my best to find all talks that are related to QEMU, not sure > whether I've correctly identified all of them. If you are awa

Re: [Qemu-devel] [PATCH v2] s390x/cpumodel: model PTFF subfunctions for Multiple-epoch facility

2018-02-06 Thread David Hildenbrand
On 06.02.2018 18:19, Cornelia Huck wrote: > On Mon, 5 Feb 2018 13:37:17 +0100 > David Hildenbrand wrote: > >> On 05.02.2018 13:22, Cornelia Huck wrote: >>> On Mon, 5 Feb 2018 12:27:33 +0100 >>> David Hildenbrand wrote: >>> On 05.02.2018 12:22, Christian Borntraeger wrote: > Looks s

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post with the presentations from DevConf and FOSDEM 2018

2018-02-06 Thread Alex Bennée
Thomas Huth writes: > Let's provide some links to the videos from DevConf and FOSDEM. > > Signed-off-by: Thomas Huth Reviewed-by: Alex Bennée > --- > I've tried my best to find all talks that are related to QEMU, not sure > whether I've correctly identified all of them. If you are aware of

Re: [Qemu-devel] [PATCH v2] s390x/cpumodel: model PTFF subfunctions for Multiple-epoch facility

2018-02-06 Thread Cornelia Huck
On Mon, 5 Feb 2018 13:37:17 +0100 David Hildenbrand wrote: > On 05.02.2018 13:22, Cornelia Huck wrote: > > On Mon, 5 Feb 2018 12:27:33 +0100 > > David Hildenbrand wrote: > > > >> On 05.02.2018 12:22, Christian Borntraeger wrote: > >>> Looks sane on a z14. > >>> Tested-by: Christian Borntrae

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 04/12] s390-ccw: update libc

2018-02-06 Thread Collin L. Walling
On 02/06/2018 01:14 AM, Thomas Huth wrote: On 05.02.2018 21:57, Collin L. Walling wrote: Moved: memcmp from bootmap.h to libc.h (renamed from _memcmp) strlen from sclp.c to libc.h (renamed from _strlen) Added C standard functions: isdigit Added non C-standard function: itostr at

[Qemu-devel] [PATCH] iotests: 205: support luks format

2018-02-06 Thread Vladimir Sementsov-Ogievskiy
Support default luks options in VM.add_drive and in new library function qemu_img_create. Use it in 205 iotests. Signed-off-by: Vladimir Sementsov-Ogievskiy --- instead of [PATCH] iotests: 205: support only raw format let's just support luks. This patch also makes it simple to support luks in

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 05/12] s390-ccw: move auxiliary IPL data to separate location

2018-02-06 Thread Collin L. Walling
On 02/06/2018 05:13 AM, Viktor Mihajlovski wrote: On 06.02.2018 10:23, Thomas Huth wrote: On 05.02.2018 21:57, Collin L. Walling wrote: [...] diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index 0d06fc1..3e3c3b8 100644 --- a/hw/s390x/ipl.c +++ b/hw/s390x/ipl.c @@ -399,6 +399,20 @@ void s390_reipl

[Qemu-devel] [PATCH v4 17/22] fpu/softfloat: re-factor float to int/uint

2018-02-06 Thread Alex Bennée
We share the common int64/uint64_pack_decomposed function across all the helpers and simply limit the final result depending on the final size. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - apply float_flg_invalid fixes next patch v3 - re-factor to common round_to_int/u

Re: [Qemu-devel] [PATCH v2] virtio-blk: enable multiple vectors when using multiple I/O queues

2018-02-06 Thread Paolo Bonzini
On 06/02/2018 02:35, Changpeng Liu wrote: > Currently virtio-pci driver hardcoded 2 vectors for virtio-blk device, > for multiple I/O queues scenario, all the I/O queues will share one > interrupt vector, while here, enable multiple vectors according to > the number of I/O queues. > > Signed-off-b

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 09/14] hw/ppc: Replace fprintf(stderr, "*\n" with error_report()

2018-02-06 Thread Thomas Huth
On 03.02.2018 09:43, Markus Armbruster wrote: > From: Alistair Francis > > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. [...] > Some lines were then manually tweaked

[Qemu-devel] [PATCH v4 15/22] fpu/softfloat: re-factor muladd

2018-02-06 Thread Alex Bennée
We can now add float16_muladd and use the common decompose and canonicalize functions to have a single implementation for float16/32/64 muladd functions. Signed-off-by: Alex Bennée Signed-off-by: Richard Henderson --- v3 - rename functions and structures v4 - use is_nan - attribute(flatte

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 01/12] s390-ccw: refactor boot map table code

2018-02-06 Thread Collin L. Walling
On 02/06/2018 12:52 AM, Thomas Huth wrote: On 05.02.2018 21:57, Collin L. Walling wrote: - replace ScsiMbr in ECKD code with BootMapTable - fix read_block messages to reflect BMT - reduce ipl_scsi code with BMT struct Signed-off-by: Collin L. Walling --- [...] @@ -449,10 +451,8 @@ static voi

[Qemu-devel] [PATCH v4 13/22] fpu/softfloat: re-factor mul

2018-02-06 Thread Alex Bennée
We can now add float16_mul and use the common decompose and canonicalize functions to have a single implementation for float16/32/64 versions. Signed-off-by: Alex Bennée Signed-off-by: Richard Henderson --- v3 - mul compile fixes for new names - remove duplicate s-o-b - more explicit inf

[Qemu-devel] [PATCH v4 20/22] fpu/softfloat: re-factor minmax

2018-02-06 Thread Alex Bennée
Let's do the same re-factor treatment for minmax functions. I still use the MACRO trick to expand but now all the checking code is common. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - minor indentation fix v3 - fix merge conflicts from dropping MINMAX patch - fix nami

[Qemu-devel] [PATCH v4 18/22] fpu/softfloat: re-factor int/uint to float

2018-02-06 Thread Alex Bennée
These are considerably simpler as the lower order integers can just use the higher order conversion function. As the decomposed fractional part is a full 64 bit rounding and inexact handling comes from the pack functions. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - expli

[Qemu-devel] [PATCH v4 12/22] fpu/softfloat: re-factor add/sub

2018-02-06 Thread Alex Bennée
We can now add float16_add/sub and use the common decompose and canonicalize functions to have a single implementation for float16/32/64 add and sub functions. Signed-off-by: Alex Bennée Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- v3 - renames for FloatParts - sh

[Qemu-devel] [PATCH v4 14/22] fpu/softfloat: re-factor div

2018-02-06 Thread Alex Bennée
We can now add float16_div and use the common decompose and canonicalize functions to have a single implementation for float16/32/64 versions. Signed-off-by: Alex Bennée Signed-off-by: Richard Henderson --- v3 - rename functions and structures v4 - use is_nan - better attribution for div

[Qemu-devel] [PATCH v4 16/22] fpu/softfloat: re-factor round_to_int

2018-02-06 Thread Alex Bennée
We can now add float16_round_to_int and use the common round_decomposed and canonicalize functions to have a single implementation for float16/32/64 round_to_int functions. Signed-off-by: Alex Bennée Signed-off-by: Richard Henderson --- v3 - rename structures and functions v4 - move NaN han

[Qemu-devel] [PATCH v4 11/22] fpu/softfloat: define decompose structures

2018-02-06 Thread Alex Bennée
These structures pave the way for generic softfloat helper routines that will operate on fully decomposed numbers. Signed-off-by: Alex Bennée Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- v3 - comment box style - CamelCase structs - hide DECOMPOSED_BINARY_POINT -

[Qemu-devel] [PATCH v4 09/22] fpu/softfloat: improve comments on ARM NaN propagation

2018-02-06 Thread Alex Bennée
Mention the pseudo-code fragment from which this is based. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- fpu/softfloat-specialize.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h index de2c5d5702..

[Qemu-devel] [PATCH v4 10/22] fpu/softfloat: move the extract functions to the top of the file

2018-02-06 Thread Alex Bennée
This is pure code-motion during re-factoring as the helpers will be needed earlier. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Peter Maydell --- v2 - fix minor white space nit --- fpu/softfloat.c | 120 +--- 1 fi

[Qemu-devel] [PATCH v4 19/22] fpu/softfloat: re-factor scalbn

2018-02-06 Thread Alex Bennée
This is one of the simpler manipulations you could make to a floating point number. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v3 - fix renames v4 - handle NaNs with return_nan - use unlikely(is_nan) --- fpu/softfloat.c | 106 +++

[Qemu-devel] [PATCH v4 21/22] fpu/softfloat: re-factor compare

2018-02-06 Thread Alex Bennée
The compare function was already expanded from a macro. I keep the macro expansion but move most of the logic into a compare_decomposed. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - minor re-factor for better inf handling v3 - fix renaming of structs/functions v4 - us

[Qemu-devel] [PATCH v4 07/22] include/fpu/softfloat: implement float16_set_sign helper

2018-02-06 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- include/fpu/softfloat.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h index f75aa59100..59c06ef192 100644 --

[Qemu-devel] [PATCH v4 04/22] target/*/cpu.h: remove softfloat.h

2018-02-06 Thread Alex Bennée
As cpu.h is another typically widely included file which doesn't need full access to the softfloat API we can remove the includes from here as well. Where they do need types it's typically for float_status and the rounding modes so we move that to softfloat-types.h as well. As a result of not havi

[Qemu-devel] [PATCH v4 22/22] fpu/softfloat: re-factor sqrt

2018-02-06 Thread Alex Bennée
This is a little bit of a departure from softfloat's original approach as we skip the estimate step in favour of a straight iteration. Suggested-by: Richard Henderson Signed-off-by: Alex Bennée --- v3 - added to series - fixed renames of structs v4 - fix up comments - use is_nan - use

[Qemu-devel] [PATCH v4 02/22] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES

2018-02-06 Thread Alex Bennée
It's not actively built and when enabled things fail to compile. I'm not sure the type-checking is really helping here. Seeing as we "own" our softfloat now lets remove the cruft. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- include/fpu/softfloat.h | 27

[Qemu-devel] [PATCH v4 05/22] include/fpu/softfloat: implement float16_abs helper

2018-02-06 Thread Alex Bennée
This will be required when expanding the MINMAX() macro for 16 bit/half-precision operations. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell --- include/fpu/softfloat.h | 7 +++ 1 file changed, 7 insertions(+) diff

[Qemu-devel] [PATCH v4 00/22] re-factor softfloat and add fp16 functions

2018-02-06 Thread Alex Bennée
Hi, The main change is applying the __attribute__((flatten)) to some of the public functions that show up in Emilio's dbt-benchmark. This seems to be a cleaner solution that squashing inlines higher up the chain and still leaves the chance for re-use for the less widely used functions. The results

[Qemu-devel] [PATCH v4 08/22] include/fpu/softfloat: add some float16 constants

2018-02-06 Thread Alex Bennée
This defines the same set of common constants for float 16 as defined for 32 and 64 bit floats. These are often used by target helper functions. I've also removed constants that are not used by anybody. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson

[Qemu-devel] [PATCH v4 03/22] fpu/softfloat-types: new header to prevent excessive re-builds

2018-02-06 Thread Alex Bennée
The main culprit here is bswap.h which pulled in softfloat.h so it could use the types in its CPU_Float* and ldfl/stfql functions. As bswap.h is very widely included this added a compile dependency every time we touch softfloat.h. Move the typedefs for each float type into their own file so we don'

[Qemu-devel] [PATCH v4 06/22] include/fpu/softfloat: implement float16_chs helper

2018-02-06 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Peter Maydell --- include/fpu/softfloat.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h index 1d34f2c3eb..f75aa59100 100644 --- a/include/fpu/softfloat.h +++ b

[Qemu-devel] [PATCH v4 01/22] fpu/softfloat: implement float16_squash_input_denormal

2018-02-06 Thread Alex Bennée
This will be required when expanding the MINMAX() macro for 16 bit/half-precision operations. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Peter Maydell --- fpu/softfloat.c | 15 +++ include/fpu/softfloat.h | 1 + 2 files changed, 16 insertions(+)

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 11/12] s390-ccw: clear pending irqs

2018-02-06 Thread Collin L. Walling
On 02/06/2018 05:07 AM, Thomas Huth wrote: On 05.02.2018 21:57, Collin L. Walling wrote: It is possible while waiting for multiple types of external interrupts that we might have pending irqs remaining between irq consumption and irq disabling. Those interrupts could propagate to the guest after

[Qemu-devel] [qemu-web PATCH] Add a blog post with the presentations from DevConf and FOSDEM 2018

2018-02-06 Thread Thomas Huth
Let's provide some links to the videos from DevConf and FOSDEM. Signed-off-by: Thomas Huth --- I've tried my best to find all talks that are related to QEMU, not sure whether I've correctly identified all of them. If you are aware of any other talk that should be in the list here, please let m

[Qemu-devel] [PATCH] migration/xen: Check return value of qemu_fclose

2018-02-06 Thread Ross Lagerwall
QEMUFile uses buffered IO so when writing small amounts (such as the Xen device state file), the actual write call and any errors that may occur only happen as part of qemu_fclose(). Therefore, report IO errors when saving the device state under Xen by checking the return value of qemu_fclose(). S

Re: [Qemu-devel] [PATCH v11 00/20] tcg: generic vector operations

2018-02-06 Thread Alex Bennée
Richard Henderson writes: > Changes since v11: > * Use dup_const more. > * Cleanup some gvec 2i and 2s routines. > * Use more helpers and less gotos in target/arm/translate-a64.c. I just noticed the aarch64 cross build breaks: n file included from /root/src/github.com/stsquad/qemu/tcg/tc

Re: [Qemu-devel] [PATCH] block: fix write with zero flag set and iovector provided

2018-02-06 Thread Stefan Hajnoczi
On Thu, Feb 01, 2018 at 05:16:31PM +0300, Anton Nefedov wrote: > The normal bdrv_co_pwritev() use is either > - BDRV_REQ_ZERO_WRITE reset and iovector provided > - BDRV_REQ_ZERO_WRITE set and iovector == NULL > > while > - the flag reset and iovector == NULL is an assertion failure > in

Re: [Qemu-devel] [PULL 0/3] hppa-softmmu update

2018-02-06 Thread Peter Maydell
On 4 February 2018 at 22:23, Richard Henderson wrote: > Clean up, and add to, make check-qtest-hppa. > > > r~ > > > The following changes since commit fb2516ef94b8399ddded4a41c4346cbc1d5d98fc: > > Merge remote-tracking branch > 'remotes/kraxel/tags/vga-20180202-pull-request' into staging (2018-

[Qemu-devel] [PULL 10/14] tests: Create migrate-start-postcopy command

2018-02-06 Thread Dr. David Alan Gilbert (git)
From: Juan Quintela This way, it is like the rest of commands Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Signed-off-by: Dr. David Alan Gilbert --- tests/migration-test.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff -

Re: [Qemu-devel] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-02-06 Thread Eric Blake
On 02/06/2018 09:29 AM, Vladimir Sementsov-Ogievskiy wrote: most of commands, ported to hmp are done in same style: they just call corresponding qmp command. Isn't it better to provide common interface for calling qmp commands through HMP monitor, to never create hmp versions of new commands?

[Qemu-devel] [PULL 09/14] tests: Add deprecated commands migration test

2018-02-06 Thread Dr. David Alan Gilbert (git)
From: Juan Quintela We add deprecated commands on a new test, so we don't have to add it on normal tests. Signed-off-by: Juan Quintela Reviewed-by: Peter Xu Signed-off-by: Dr. David Alan Gilbert --- tests/migration-test.c | 46 ++ 1 file changed, 4

[Qemu-devel] [PULL 08/14] tests: Use consistent names for migration

2018-02-06 Thread Dr. David Alan Gilbert (git)
From: Juan Quintela Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Signed-off-by: Dr. David Alan Gilbert --- tests/migration-test.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-tes

[Qemu-devel] [PULL 14/14] migration: incoming postcopy advise sanity checks

2018-02-06 Thread Dr. David Alan Gilbert (git)
From: Greg Kurz If postcopy-ram was set on the source but not on the destination, migration doesn't occur, the destination prints an error and boots the guest: qemu-system-ppc64: Expected vmdescription section, but got 0 We end up with two running instances. This behaviour was introduced in 2.

[Qemu-devel] [PULL 12/14] migration: Recover block devices if failure in device state

2018-02-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" In e91d895 I added the new pause-before-switchover mechanism to allow migration completion to be delayed; this changes the last state prior to completion to MIGRATE_STATUS_DEVICE rather than MIGRATE_STATUS_ACTIVE. Fix the failure path in migration_completion to rec

Re: [Qemu-devel] [PATCH] vl: fix possible int overflow for qemu_timedate_diff()

2018-02-06 Thread Paolo Bonzini
On 01/02/2018 12:59, Gonglei wrote: > From: shenghualong > > When the Windows guest users set the time to year 2099, > the return value of qemu_timedate_diff() will overflow > with variable clock mode as below format: > > > > Let's change the return value of qemu_timedate_diff() from > int to

[Qemu-devel] [PULL 06/14] tests: Remove deprecated migration tests commands

2018-02-06 Thread Dr. David Alan Gilbert (git)
From: Juan Quintela We move to use migration_set_parameter() for everything. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan Gilbert --- tests/migration-test.c | 33 - 1 file changed, 8 insertions(+), 25 deletions

[Qemu-devel] [PULL 13/14] migration: Don't leak IO channels

2018-02-06 Thread Dr. David Alan Gilbert (git)
From: Ross Lagerwall Since qemu_fopen_channel_{in,out}put take references on the underlying IO channels, make sure to release our references to them. Signed-off-by: Ross Lagerwall Message-Id: <20171101142526.1006-2-ross.lagerw...@citrix.com> Reviewed-by: Daniel P. Berrange Signed-off-by: Dr. D

[Qemu-devel] [PULL 07/14] tests: Consolidate accelerators declaration

2018-02-06 Thread Dr. David Alan Gilbert (git)
From: Juan Quintela Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Signed-off-by: Dr. David Alan Gilbert --- tests/migration-test.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/tests/migration-test.c b/tests/migrat

Re: [Qemu-devel] [PATCH v6 00/23] x86: Secure Encrypted Virtualization (AMD)

2018-02-06 Thread Bruce Rogers
>>> On 1/29/2018 at 10:41 AM, wrote: > This patch series provides support for AMD's new Secure Encrypted > Virtualization (SEV) feature. > > SEV is an extension to the AMD‑V architecture which supports running > multiple VMs under the control of a hypervisor. The SEV feature allows > the memory

[Qemu-devel] [PULL 05/14] migration: Drop current address parameter from save_zero_page()

2018-02-06 Thread Dr. David Alan Gilbert (git)
From: Juan Quintela It already has RAMBlock and offset, it can calculate it itself. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan Gilbert --- migration/ram.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/migra

[Qemu-devel] [PULL 11/14] tests: Adjust sleeps for migration test

2018-02-06 Thread Dr. David Alan Gilbert (git)
From: Juan Quintela Also reorder code to not sleep when event already happened. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu Signed-off-by: Dr. David Alan Gilbert --- tests/migration-test.c | 29 ++--- 1 file changed, 14 inse

[Qemu-devel] [PULL 04/14] migration: use s->threshold_size inside migration_update_counters

2018-02-06 Thread Dr. David Alan Gilbert (git)
From: Wei Wang Fixes: b15df1ae50 ("migration: cleanup stats update into function") The threshold size is changed to be recorded in s->threshold_size. Signed-off-by: Wei Wang Reviewed-by: Peter Xu Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert -

[Qemu-devel] [PULL 03/14] migration/savevm.c: set MAX_VM_CMD_PACKAGED_SIZE to 1ul << 32

2018-02-06 Thread Dr. David Alan Gilbert (git)
From: Daniel Henrique Barboza MAX_VM_CMD_PACKAGED_SIZE is a constant used in qemu_savevm_send_packaged and loadvm_handle_cmd_packaged to determine whether a package is too big to be sent or received. qemu_savevm_send_packaged is called inside postcopy_start (migration/migration.c) to send the Mig

[Qemu-devel] [PULL 02/14] migration: Route errors down through migration_channel_connect

2018-02-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Route async errors (especially from sockets) down through migration_channel_connect and on to migrate_fd_connect where they can be cleaned up. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David

Re: [Qemu-devel] [PATCH 2/2] qapi: add block latency histogram interface

2018-02-06 Thread Eric Blake
On 02/06/2018 08:07 AM, Vladimir Sementsov-Ogievskiy wrote: Set (and clear) histogram through new command block-latency-histogram-set and show new statistics in query-blockstats results. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 62

[Qemu-devel] [PULL 01/14] migration: Allow migrate_fd_connect to take an Error *

2018-02-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Allow whatever is performing the connection to pass migrate_fd_connect an error to indicate there was a problem during connection, an allow us to clean up. The caller must free the error. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Signed-of

[Qemu-devel] [PULL 00/14] migration queue

2018-02-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit 2b3805f370521deacab974b9c9ca07d2319a8890: Merge remote-tracking branch 'remotes/stefanberger/tags/pull-tpm-2018-02-03-1' into staging (2018-02-05 09:31:37 +) are available in the Git repository at: git://github.com/dag

Re: [Qemu-devel] Qemu Trace

2018-02-06 Thread Stefan Hajnoczi
On Tue, Feb 06, 2018 at 10:55:57AM +, Peter Maydell wrote: > On 6 February 2018 at 09:17, Stefan Hajnoczi wrote: > > On Mon, Feb 05, 2018 at 03:55:01PM +, Peter Maydell wrote: > >> ...and "online processing of traces" is pretty much exactly > >> what an instrumentation plugin API is for. >

Re: [Qemu-devel] [PATCH for-2.9-rc5 v4 2/2] block: Drain BH in bdrv_drained_begin

2018-02-06 Thread Kevin Wolf
Am 18.04.2017 um 16:30 hat Fam Zheng geschrieben: > During block job completion, nothing is preventing > block_job_defer_to_main_loop_bh from being called in a nested > aio_poll(), which is a trouble, such as in this code path: > > qmp_block_commit > commit_active_start > bdrv_re

Re: [Qemu-devel] [PATCH v5 1/1] s390x/cpu: expose the guest crash information

2018-02-06 Thread Eric Blake
On 02/06/2018 01:46 AM, Christian Borntraeger wrote: This patch is the s390 implementation of guest crash information, similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM property") and the related commits. We will detect several crash reasons, with the "disabled wait" being the mo

Re: [Qemu-devel] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-02-06 Thread Vladimir Sementsov-Ogievskiy
26.01.2018 18:05, Dr. David Alan Gilbert wrote: * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: 17.01.2018 19:03, Eric Blake wrote: On 01/17/2018 09:51 AM, Vladimir Sementsov-Ogievskiy wrote: I have a script (for managing libvirt guest, but it can be adopted for qemu or even

Re: [Qemu-devel] rate limiting issues

2018-02-06 Thread Stefan Hajnoczi
On Tue, Feb 06, 2018 at 11:54:51AM +0100, Wolfgang Bumiller wrote: > On Mon, Feb 05, 2018 at 03:31:40PM +, Stefan Hajnoczi wrote: > > On Fri, Feb 02, 2018 at 12:10:22PM +0100, Wolfgang Bumiller wrote: > (...) > > > Explanation: > > > The ratelimiting code in include/qemu/ratelimit.h currently u

Re: [Qemu-devel] [RFC] exec: eliminate ram naming issue as migration

2018-02-06 Thread Igor Mammedov
On Mon, 5 Feb 2018 18:36:31 + "Dr. David Alan Gilbert" wrote: > * Tan, Jianfeng (jianfeng@intel.com) wrote: > > > > > > On 2/6/2018 12:29 AM, Igor Mammedov wrote: > > > On Mon, 5 Feb 2018 14:58:55 + > > > Jianfeng Tan wrote: > > > > > > > Existing VMs with virtio devices and

Re: [Qemu-devel] [PATCH v8 18/26] block: Add sgfnt_runtime_opts to BlockDriver

2018-02-06 Thread Alberto Garcia
On Mon 05 Feb 2018 04:18:27 PM CET, Max Reitz wrote: > --- a/block/blkdebug.c > +++ b/block/blkdebug.c > @@ -886,6 +886,21 @@ static int blkdebug_reopen_prepare(BDRVReopenState > *reopen_state, > return 0; > } > > +static const char *const blkdebug_sgfnt_runtime_opts[] = { > +"config",

Re: [Qemu-devel] [PATCH V4 10/16] qmp event: Add COLO_EXIT event to notify users while exited COLO

2018-02-06 Thread Eric Blake
On 02/05/2018 09:13 PM, Zhang Chen wrote: +## +{ 'event': 'COLO_EXIT', + 'data': {'mode': 'COLOMode', 'reason': 'COLOExitReason' } } Standard question when I see a new event: is there a way to poll for the event's information? If not, why don't we need one? Your means is we'd better print

Re: [Qemu-devel] [PATCH v4 05/14] i.MX: Add code to emulate i.MX7 SNVS IP-block

2018-02-06 Thread Andrey Smirnov
On Wed, Jan 31, 2018 at 9:10 AM, Philippe Mathieu-Daudé wrote: > On 01/15/2018 10:37 PM, Andrey Smirnov wrote: >> Add code to emulate SNVS IP-block. Currently only the bits needed to >> be able to emulate machine shutdown are implemented. >> >> Cc: Peter Maydell >> Cc: Jason Wang >> Cc: Philippe

Re: [Qemu-devel] [PATCH] block: include original filename when reporting invalid URIs

2018-02-06 Thread Eric Blake
On 02/06/2018 04:52 AM, Daniel P. Berrangé wrote: Consider passing a JSON based block driver to "qemu-img commit" $ qemu-img commit 'json:{"driver":"qcow2","file":{"driver":"gluster",\ "volume":"gv0","path":"sn1.qcow2", "server":[{"type":\

Re: [Qemu-devel] [PATCH RFC 09/21] qapi: Don't absolutize include file name in error messages

2018-02-06 Thread Eric Blake
On 02/06/2018 01:49 AM, Markus Armbruster wrote: Probably not, as our make rule strips off $(SRC_PATH): @perl -p -e 's|\Q$(SRC_PATH)\E/||g' $*.test.err | diff -q $(SRC_PATH)/$*.err - I've kept that, because it might also occur in stack backtraces. I think. Ideally, we don't have an

Re: [Qemu-devel] [PATCH v4 03/22] RISC-V CPU Core Definition

2018-02-06 Thread Igor Mammedov
On Tue, 6 Feb 2018 11:09:56 +1300 Michael Clark wrote: > On Tue, Feb 6, 2018 at 4:04 AM, Igor Mammedov wrote: > > > On Mon, 5 Feb 2018 19:22:28 +1300 > > Michael Clark wrote: > > > > > Add CPU state header, CPU definitions and initialization routines > > > > > > Signed-off-by: Michael Clark

Re: [Qemu-devel] [PATCH RFC 06/21] qapi-gen: New common driver for code and doc generators

2018-02-06 Thread Eric Blake
On 02/06/2018 01:45 AM, Markus Armbruster wrote: -def main(argv): -(input_file, output_dir, do_c, do_h, prefix, opts) = parse_command_line() - -blurb = ''' - * Schema-defined QAPI/QMP commands -''' - +def gen_commands(schema, output_dir, prefix): +blurb = ' * Schema-defined QAPI/QMP

Re: [Qemu-devel] [PATCH v9 03/13] block/dirty-bitmap: add _locked version of bdrv_reclaim_dirty_bitmap

2018-02-06 Thread Vladimir Sementsov-Ogievskiy
24.01.2018 13:16, Paolo Bonzini wrote: On 22/01/2018 13:14, Vladimir Sementsov-Ogievskiy wrote: so, accessing the bitmap needs mutex lock? Then what do you mean under accessing the bitmap? Any touch of BdrvDirtyBitmap fields? Then "reading the list" will require bitmap mutex too. Or accessing t

Re: [Qemu-devel] [PATCH v8 21/26] block: Purify .bdrv_refresh_filename()

2018-02-06 Thread Alberto Garcia
On Mon 05 Feb 2018 04:18:30 PM CET, Max Reitz wrote: > Currently, BlockDriver.bdrv_refresh_filename() is supposed to both > refresh the filename (BDS.exact_filename) and set BDS.full_open_options. > Now that we have generic code in the central bdrv_refresh_filename() for > creating BDS.full_open_op

Re: [Qemu-devel] [PATCH v4 7/9] sockets: allow SocketAddress 'fd' to reference numeric file descriptors

2018-02-06 Thread Eric Blake
On 02/06/2018 03:13 AM, Daniel P. Berrangé wrote: +++ b/qapi/sockets.json @@ -123,6 +123,13 @@ # # @unix: Unix domain socket # +# @vsock: VMCI address +# +# @fd: decimal is for file descriptor number, otherwise a file descriptor name. +# Named file descriptors are permitted in mon

<    1   2   3   4   5   >