[Qemu-devel] [PATCH 04/14] libqos: Use explicit QTestState for fw_cfg operations

2018-02-08 Thread Thomas Huth
From: Eric Blake Drop one more client of global_qtest by teaching all fw_cfg test functionality (invoked through alloc-pc) to pass in an explicit QTestState, adjusting all callers. In particular, fw_cfg-test had to reorder things to create the test state prior to creating the

[Qemu-devel] [PATCH 12/14] tests/boot-serial: Enable the boot-serial test on SPARC machines, too

2018-02-08 Thread Thomas Huth
OpenBIOS prints out the name of the detected CPU here, so looking for this string is a nice test to verify that the CPU detection is still working correctly. Acked-by: Mark Cave-Ayland Signed-off-by: Thomas Huth --- tests/Makefile.include | 2

[Qemu-devel] [PATCH 00/14] qtest patches

2018-02-08 Thread Thomas Huth
Here's a set of qtest patches that have been posted to the list before and are IMHO ready for inclusion. I've included the patches from Eric's "Preliminary libqtest cleanups" series that do not need major reworks (the rest needs some more love later), and some additional entries for the

[Qemu-devel] [PATCH 20/27] ssh: Use QAPI BlockdevOptionsSsh object

2018-02-08 Thread Kevin Wolf
Create a BlockdevOptionsSsh object in connect_to_ssh() and take the options from there. 'host_key_check' is still processed separately because it's not in the schema yet. Signed-off-by: Kevin Wolf --- block/ssh.c | 136

[Qemu-devel] [PATCH 10/14] tests/boot-sector: Drop dependence on global_qtest

2018-02-08 Thread Thomas Huth
From: Eric Blake As a general rule, we prefer avoiding implicit global state because it makes code harder to safely copy and paste without thinking about the global state. Adjust the helper code to use explicit state instead, and update all callers. Fix some trailing

[Qemu-devel] [PATCH 02/14] libqtest: Use qemu_strtoul()

2018-02-08 Thread Thomas Huth
From: Eric Blake This will keep checkpatch happy when the next patch does code motion. Fix the include order to match HACKING when adding the needed header. Signed-off-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas

[Qemu-devel] [PATCH 16/27] nfs: Use QAPI options in nfs_client_open()

2018-02-08 Thread Kevin Wolf
Using the QAPI visitor to turn all options into QAPI BlockdevOptionsNfs simplifies the code a lot. It will also be useful for implementing the QAPI based .bdrv_co_create callback. Signed-off-by: Kevin Wolf --- block/nfs.c | 176

[Qemu-devel] [Bug 1367365] Re: qemu-img fixed vhd issues

2018-02-08 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? Otherwise, can you provide some test images or a description how to create such images? ** Changed in: qemu Status: New => Incomplete -- You received

Re: [Qemu-devel] [PATCH 1/2] qmp: add query-cpus-fast

2018-02-08 Thread Eduardo Habkost
On Wed, Feb 07, 2018 at 12:50:13PM -0500, Luiz Capitulino wrote: > The query-cpus command has an extremely serious side effect: > it always interrupt all running vCPUs so that they can run > ioctl calls. This can cause a huge performance degradation for > some workloads. And most of the

[Qemu-devel] [PATCH 14/27] gluster: Support .bdrv_co_create

2018-02-08 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to gluster, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 18 ++- block/gluster.c | 149 +-- 2 files changed, 115

[Qemu-devel] [Bug 1354167] Re: On VM restart: Could not open 'poppy.qcow2': Could not read snapshots: File too large

2018-02-08 Thread Thomas Huth
Sounds this was not really a bug, but rather a file corruption problem by using qemu-img on a file that was opened by QEMU already? So could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of

[Qemu-devel] [PATCH 26/27] qemu-iotests: Test qcow2 over file image creation with QMP

2018-02-08 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/qemu-iotests/206 | 436 + tests/qemu-iotests/206.out | 209 ++ tests/qemu-iotests/group | 1 + 3 files changed, 646 insertions(+) create mode 100755

[Qemu-devel] [PATCH 27/27] qemu-iotests: Test ssh image creation over QMP

2018-02-08 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/qemu-iotests/207 | 261 + tests/qemu-iotests/207.out | 75 + tests/qemu-iotests/group | 1 + 3 files changed, 337 insertions(+) create mode 100755 tests/qemu-iotests/207

[Qemu-devel] [PATCH 21/27] ssh: QAPIfy host-key-check option

2018-02-08 Thread Kevin Wolf
This makes the host-key-check option available in blockdev-add. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 63 +++-- block/ssh.c | 88 +--- 2 files changed, 117 insertions(+), 34

[Qemu-devel] [PATCH 25/27] block: Fail bdrv_truncate() with negative size

2018-02-08 Thread Kevin Wolf
Most callers have their own checks, but something like this should also be checked centrally. As it happens, x-blockdev-create can pass negative image sizes to format drivers (because there is no QAPI type that would reject negative numbers) and triggers the check added by this patch.

[Qemu-devel] [PATCH 23/27] ssh: Support .bdrv_co_create

2018-02-08 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to ssh, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 16 - block/ssh.c | 92 +--- 2 files changed, 67 insertions(+), 41

Re: [Qemu-devel] [PATCH v2 00/32] Add ARMv8.2 half-precision functions

2018-02-08 Thread no-reply
Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180208173157.24705-1-alex.ben...@linaro.org Subject: [Qemu-devel] [PATCH v2 00/32]

[Qemu-devel] [PATCH 22/27] ssh: Pass BlockdevOptionsSsh to connect_to_ssh()

2018-02-08 Thread Kevin Wolf
Move the parsing of the QDict options up to the callers, in preparation for the .bdrv_co_create implementation that directly gets a QAPI type. Signed-off-by: Kevin Wolf --- block/ssh.c | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-)

[Qemu-devel] [PATCH 18/27] sheepdog: QAPIfy "redundacy" create option

2018-02-08 Thread Kevin Wolf
The "redundacy" option for Sheepdog image creation is currently a string that can encode one or two integers depending on its format, which at the same time implicitly selects a mode. This patch turns it into a QAPI union and converts the string into such a QAPI object before interpreting the

[Qemu-devel] [PATCH 24/27] file-posix: Fix no-op bdrv_truncate() with falloc preallocation

2018-02-08 Thread Kevin Wolf
If bdrv_truncate() is called, but the requested size is the same as before, don't call posix_fallocate(), which returns -EINVAL for length zero and would therefore make bdrv_truncate() fail. The problem can be triggered by creating a zero-sized raw image with 'falloc' preallocation mode.

[Qemu-devel] [PATCH 19/27] sheepdog: Support .bdrv_co_create

2018-02-08 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to sheepdog, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 24 +- block/sheepdog.c | 209 --- 2 files changed, 170

[Qemu-devel] [PATCH 12/27] file-posix: Support .bdrv_co_create

2018-02-08 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to file, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 20 +- block/file-posix.c | 77 +--- 2 files changed, 74

[Qemu-devel] [PATCH 15/27] rbd: Support .bdrv_co_create

2018-02-08 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to rbd, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 20 +++- block/rbd.c | 137 +-- 2 files changed, 108 insertions(+),

[Qemu-devel] [PATCH 17/27] nfs: Support .bdrv_co_create

2018-02-08 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to nfs, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 16 +++- block/nfs.c | 74 +--- 2 files changed, 74 insertions(+),

[Qemu-devel] [PULL 26/26] virtio-balloon: include statistics of disk/file caches

2018-02-08 Thread Michael S. Tsirkin
From: Tomáš Golembiovský Signed-off-by: Tomáš Golembiovský Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/standard-headers/linux/virtio_balloon.h | 3 ++- hw/virtio/virtio-balloon.c

[Qemu-devel] [PATCH 07/27] qcow2: Handle full/falloc preallocation in qcow2_create2()

2018-02-08 Thread Kevin Wolf
Once qcow2_create2() can be called directly on an already existing node, we must provide the 'full' and 'falloc' preallocation modes outside of creating the image on the protocol layer. Fortunately, we have preallocated truncate now which can provide this functionality. Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH 11/27] block: x-blockdev-create QMP command

2018-02-08 Thread Kevin Wolf
This adds a synchronous x-blockdev-create QMP command that can create qcow2 images on a given node name. We don't want to block while creating an image, so this is not the final interface in all aspects, but BlockdevCreateOptionsQcow2 and .bdrv_co_create() are what they actually might look like

[Qemu-devel] [PATCH 13/27] file-win32: Support .bdrv_co_create

2018-02-08 Thread Kevin Wolf
This adds the .bdrv_co_create driver callback to file-win32, which enables image creation over QMP. Signed-off-by: Kevin Wolf --- block/file-win32.c | 45 + 1 file changed, 37 insertions(+), 8 deletions(-) diff --git

[Qemu-devel] [PULL 22/26] hw/pci-bridge: fix pcie root port's IO hints capability

2018-02-08 Thread Michael S. Tsirkin
From: Marcel Apfelbaum The gen_pcie_root_port mem-reserve and pref32-reserve properties are defined as size (so uint64_t), but passed as uint32_t when building the 'IO hints' vendor specific capability. Passing 4G (or more) gets truncated and passed as a zero reservation. Is

[Qemu-devel] [PATCH 05/27] qcow2: Use BlockdevRef in qcow2_create2()

2018-02-08 Thread Kevin Wolf
Instead of passing a separate BlockDriverState* into qcow2_create2(), make use of the BlockdevRef that is included in BlockdevCreateOptions. Signed-off-by: Kevin Wolf --- include/block/block.h | 1 + block.c | 47 +++

[Qemu-devel] [PATCH 10/27] qcow2: Use visitor for options in qcow2_create()

2018-02-08 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/qcow2.c | 219 - tests/qemu-iotests/049.out | 8 +- tests/qemu-iotests/112.out | 4 +- 3 files changed, 84 insertions(+), 147 deletions(-) diff --git a/block/qcow2.c

[Qemu-devel] [PATCH 03/27] qcow2: Let qcow2_create() handle protocol layer

2018-02-08 Thread Kevin Wolf
Currently, qcow2_create() only parses the QemuOpts and then calls qcow2_create2() for the actual image creation, which includes both the creation of the actual file on the file system and writing a valid empty qcow2 image into that file. The plan is that qcow2_create2() becomes the function that

[Qemu-devel] [PULL 23/26] tests: acpi: fix FADT not being compared to reference table

2018-02-08 Thread Michael S. Tsirkin
From: Igor Mammedov It turns out that FADT isn't actually tested for changes against reference table, since it happens to be the 1st table in RSDT which is currently ignored. Fix it by making sure that all tables from RSDT are added to test list. NOTE: FADT contains guest

[Qemu-devel] [PATCH 01/27] block/qapi: Introduce BlockdevCreateOptions

2018-02-08 Thread Kevin Wolf
This creates a BlockdevCreateOptions union type that will contain all of the options for image creation. We'll start out with an empty struct type BlockdevCreateDummy for all drivers. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 61

[Qemu-devel] [PATCH 09/27] qdict: Introduce qdict_rename_keys()

2018-02-08 Thread Kevin Wolf
A few block drivers will need to rename .bdrv_create options for their QAPIfication, so let's have a helper function for that. Signed-off-by: Kevin Wolf --- include/qapi/qmp/qdict.h | 6 ++ qobject/qdict.c | 30 ++ 2 files changed, 36

[Qemu-devel] [PATCH 02/27] block/qapi: Add qcow2 create options to schema

2018-02-08 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- qapi/block-core.json | 45 - 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index b59b1430bb..aade602a04 100644 --- a/qapi/block-core.json +++

[Qemu-devel] [PULL 24/26] lpc: drop pcie host dependency

2018-02-08 Thread Michael S. Tsirkin
Doesn't look like that header is used. Signed-off-by: Michael S. Tsirkin --- hw/isa/lpc_ich9.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c index adcf077..e692b9f 100644 --- a/hw/isa/lpc_ich9.c +++ b/hw/isa/lpc_ich9.c @@ -39,7 +39,6

[Qemu-devel] [PATCH 04/27] qcow2: Pass BlockdevCreateOptions to qcow2_create2()

2018-02-08 Thread Kevin Wolf
All of the simple options are now passed to qcow2_create2() in a BlockdevCreateOptions object. Still missing: node-name and the encryption options. Signed-off-by: Kevin Wolf --- block/qcow2.c | 190 ++ 1 file changed, 152

[Qemu-devel] [PATCH 08/27] util: Add qemu_opts_to_qdict_filtered()

2018-02-08 Thread Kevin Wolf
This allows, given a QemuOpts for a QemuOptsList that was merged from multiple QemuOptsList, to only consider those options that exist in one specific list. Block drivers need this to separate format-layer create options from protocol-level options. Signed-off-by: Kevin Wolf

[Qemu-devel] [PULL 18/26] cryptodev-vhost-user: set the key length

2018-02-08 Thread Michael S. Tsirkin
From: Gonglei Signed-off-by: Gonglei Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/sysemu/cryptodev-vhost-user.h | 3 +++ backends/cryptodev-vhost-user.c | 4 2

[Qemu-devel] [PATCH 00/27] x-blockdev-create for protocols and qcow2

2018-02-08 Thread Kevin Wolf
This series implements a minimal QMP command that allows to create an image file on the protocol level or an image format on a given block node. Eventually, the interface is going to change to some kind of an async command (possibly a (non-)block job), but that will require more work on the job

[Qemu-devel] [PATCH 06/27] qcow2: Use QCryptoBlockCreateOptions in qcow2_create2()

2018-02-08 Thread Kevin Wolf
Instead of passing the encryption format name and the QemuOpts down, use the QCryptoBlockCreateOptions contained in BlockdevCreateOptions. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- block/qcow2.c | 62

[Qemu-devel] [PULL 12/26] pci/bus: let it has higher migration priority

2018-02-08 Thread Michael S. Tsirkin
From: Peter Xu In the past, we prioritized IOMMU migration so that we have such a priority order: IOMMU > PCI Devices When migrating a guest with both vIOMMU and a pcie-root-port, we'll always migrate vIOMMU first, since pci buses will be seen to have the same priority

[Qemu-devel] [PULL 13/26] virtio-blk: enable multiple vectors when using multiple I/O queues

2018-02-08 Thread Michael S. Tsirkin
From: Changpeng Liu Currently virtio-pci driver hardcoded 2 vectors for virtio-blk device, for multiple I/O queues scenario, all the I/O queues will share one interrupt vector, while here, enable multiple vectors according to the number of I/O queues. Signed-off-by:

[Qemu-devel] [PULL 19/26] virtio-balloon: unref the memory region before continuing

2018-02-08 Thread Michael S. Tsirkin
From: Tiwei Bie Signed-off-by: Tiwei Bie Cc: qemu-sta...@nongnu.org Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-balloon.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] "make check -j4" hangs (was: Re: chardev/char-socket: add POLLHUP handler)

2018-02-08 Thread Thomas Huth
On 30.01.2018 20:49, Paolo Bonzini wrote: > On 25/01/2018 08:51, Klim Kireev wrote: >> The following behavior was observed for QEMU configured by libvirt >> to use guest agent as usual for the guests without virtio-serial >> driver (Windows or the guest remaining in BIOS stage). >> >> In QEMU on

[Qemu-devel] [PULL 03/26] virtio: improve virtio devices initialization time

2018-02-08 Thread Michael S. Tsirkin
From: Gal Hammer The loading time of a VM is quite significant when its virtio devices use a large amount of virt-queues (e.g. a virtio-serial device with max_ports=511). Most of the time is spend in the creation of all the required event notifiers (ioeventfd and memory

[Qemu-devel] [PULL 11/26] pci-bridge/i82801b11: clear bridge registers on platform reset

2018-02-08 Thread Michael S. Tsirkin
From: Laszlo Ersek The "i82801b11-bridge" device model is a descendant of "base-pci-bridge" (TYPE_PCI_BRIDGE). However, unlike other similar devices, such as - pci-bridge, - pcie-pci-bridge, - PCIE Root Port, - xio3130 switch upstream and downstream ports, -

[Qemu-devel] [PULL 20/26] libvhost-user: Fix resource leak

2018-02-08 Thread Michael S. Tsirkin
From: Yongji Xie Free the mmaped memory when we need to mmap new memory space on vu_set_mem_table_exec() and vu_set_log_base_exec() to avoid memory leak. Also close the corresponding fd after mmap() on vu_set_log_base_exec() to avoid fd leak. Signed-off-by: Yongji Xie

[Qemu-devel] [PULL 25/26] acpi-test: update FADT

2018-02-08 Thread Michael S. Tsirkin
Previous commit ("tests: acpi: fix FADT not being compared to reference table") started tracking changes to the FADT. Generate the expected FACP files - apparently these weren't updated since 2013. Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/pc/FACP | Bin 116 ->

[Qemu-devel] [PULL 14/26] pci: removed the is_express field since a uniform interface was inserted

2018-02-08 Thread Michael S. Tsirkin
From: Yoni Bettan according to Eduardo Habkost's commit fd3b02c889 all PCIEs now implement INTERFACE_PCIE_DEVICE so we don't need is_express field anymore. Devices that implements only INTERFACE_PCIE_DEVICE (is_express == 1) or devices that implements only

[Qemu-devel] [PULL 09/26] vhost: Merge and delete unused callbacks

2018-02-08 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Now that the olf vhost_set_memory code is gone, the _nop and _add callbacks are identical and can be merged. The _del callback is no longer needed. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Igor Mammedov

[Qemu-devel] [PULL 17/26] cryptodev-vhost-user: add crypto session handler

2018-02-08 Thread Michael S. Tsirkin
From: Gonglei Introduce two vhost-user meassges: VHOST_USER_CREATE_CRYPTO_SESSION and VHOST_USER_CLOSE_CRYPTO_SESSION. At this point, the QEMU side support crypto operation in cryptodev host-user backend. Signed-off-by: Gonglei Signed-off-by:

[Qemu-devel] [PULL 21/26] libvhost-user: Support across-memory-boundary access

2018-02-08 Thread Michael S. Tsirkin
From: Yongji Xie The sg list/indirect descriptor table may be contigious in GPA but not in HVA address space. But libvhost-user wasn't aware of that. This would cause out-of-bounds access. Even a malicious guest could use it to get information from the vhost-user backend.

[Qemu-devel] [PULL 15/26] cryptodev: add vhost-user as a new cryptodev backend

2018-02-08 Thread Michael S. Tsirkin
From: Gonglei Usage: -chardev socket,id=charcrypto0,path=/path/to/your/socket -object cryptodev-vhost-user,id=cryptodev0,chardev=charcrypto0 -device virtio-crypto-pci,id=crypto0,cryptodev=cryptodev0 Signed-off-by: Gonglei Signed-off-by:

Re: [Qemu-devel] [PATCH v3 2/2] virtio: improve virtio devices initialization time

2018-02-08 Thread Michael S. Tsirkin
On Mon, Jan 29, 2018 at 04:20:57PM +0200, Gal Hammer wrote: > The loading time of a VM is quite significant when its virtio > devices use a large amount of virt-queues (e.g. a virtio-serial > device with max_ports=511). Most of the time is spend in the > creation of all the required event

[Qemu-devel] [PULL 08/26] vhost: Clean out old vhost_set_memory and friends

2018-02-08 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Remove the old update mechanism, vhost_set_memory, and the functions and flags it used. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL 07/26] vhost: Regenerate region list from changed sections list

2018-02-08 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Compare the sections list that's just been generated, and if it's different from the old one regenerate the region list. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 16/26] cryptodev: add vhost support

2018-02-08 Thread Michael S. Tsirkin
From: Gonglei Impliment the vhost-crypto's funtions, such as startup, stop and notification etc. Introduce an enum QCryptoCryptoDevBackendOptionsType in order to identify the cryptodev vhost backend is vhost-user or vhost-kernel-module (If exist). At this point, the

[Qemu-devel] [PULL 06/26] vhost: Merge sections added to temporary list

2018-02-08 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" As sections are reported by the listener to the _nop and _add methods, add them to the temporary section list but now merge them with the previous section if the new one abuts and the backend allows. Signed-off-by: Dr. David Alan Gilbert

[Qemu-devel] [PULL 05/26] vhost: Simplify ring verification checks

2018-02-08 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" vhost_verify_ring_mappings() were used to verify that rings are still accessible and related memory hasn't been moved after flatview is updated. It was doing checks by mapping ring's GPA+len and checking that HVA hadn't changed with new memory

[Qemu-devel] [PULL 10/26] vhost: Move log_dirty check

2018-02-08 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Move the log_dirty check into vhost_section. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost.c | 20

[Qemu-devel] [PULL 04/26] vhost: Build temporary section list and deref after commit

2018-02-08 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Igor spotted that there's a race, where a region that's unref'd in a _del callback might be free'd before the set_mem_table call in the _commit callback, and thus the vhost might end up using free memory. Fix this by building a complete

[Qemu-devel] [Bug 1254786] Re: qemu-m68k-static: illegal instruction ebc0 during debootstrap second stage

2018-02-08 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? There should now be support for "normal" 68k CPUs, too... ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which

[Qemu-devel] [PULL 02/26] virtio: remove event notifier cleanup call on de-assign

2018-02-08 Thread Michael S. Tsirkin
From: Gal Hammer The virtio_bus_set_host_notifier function no longer calls event_notifier_cleanup when a event notifier is removed. The commit updates the code to match the new behavior and calls virtio_bus_cleanup_host_notifier after the notifier was de-assign and no longer

[Qemu-devel] [PULL 01/26] Revert "vhost: add traces for memory listeners"

2018-02-08 Thread Michael S. Tsirkin
This reverts commit 0750b060216de69ed1f14bc08181bf4ad27fc622. Follow up patches are reworking the memory listeners, the new mechanism will add its own set of traces. Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost.c | 7 --- hw/virtio/trace-events | 6 -- 2

[Qemu-devel] [PULL 00/26] virtio, vhost, pci, pc: features, fixes and cleanups

2018-02-08 Thread Michael S. Tsirkin
The following changes since commit 008a51bbb343972dd8cf09126da8c3b87f4e1c96: Merge remote-tracking branch 'remotes/famz/tags/staging-pull-request' into staging (2018-02-08 14:31:51 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git

[Qemu-devel] [Bug 1225187] Re: qemu hangs in windows 7 host with -serial pipe:windbg

2018-02-08 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [Qemu-devel] [PATCH 3/3] build-sys: enable sanitizers by default with --enable-debug

2018-02-08 Thread Marc-André Lureau
Hi On Thu, Feb 8, 2018 at 6:46 PM, Paolo Bonzini wrote: > On 08/02/2018 17:23, Marc-André Lureau wrote: >> The original commit 247724cb302af5d70c8853154b640dfabf2bbb56 was meant >> to enable sanitizers by default when --enable-debug, but failed >> because of a gcc static

Re: [Qemu-devel] [PATCH 2/2] hw/arm/aspeed: simplify using the 'unimplemented device' for aspeed_soc.io

2018-02-08 Thread Cédric Le Goater
On 02/08/2018 06:22 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé This looks like a good idea. (Have you actually tried it ? just asking) Reviewed-by: Cédric Le Goater Thanks, C. > --- > include/hw/arm/aspeed_soc.h | 1 - >

[Qemu-devel] [PATCH 2/4] 9pfs: check for file device to avoid QID path collisions

2018-02-08 Thread antonios.motakis
From: Antonios Motakis The QID path should uniquely identify a file. However, the inode of a file is currently used as the QID path, which on its own only uniquely identifies wiles within a device. Here we track the device hosting the 9pfs share, in order to prevent

Re: [Qemu-devel] [PATCH v2 00/32] Add ARMv8.2 half-precision functions

2018-02-08 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180208173157.24705-1-alex.ben...@linaro.org Subject: [Qemu-devel] [PATCH v2 00/32] Add

[Qemu-devel] [Bug 1343827] Re: block.c: multiwrite_merge() truncates overlapping requests

2018-02-08 Thread Thomas Huth
Triaging old bug tickets... has Stefan's fix be included? Could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [PATCH 1/4] 9pfs: V9fsQID: set type of version and path to unsigned

2018-02-08 Thread antonios.motakis
From: Antonios Motakis There is no need for signedness on these QID fields for 9p. Signed-off-by: Antonios Motakis --- fsdev/9p-marshal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fsdev/9p-marshal.h

Re: [Qemu-devel] [PATCH v2 00/32] Add ARMv8.2 half-precision functions

2018-02-08 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180208173157.24705-1-alex.ben...@linaro.org Subject: [Qemu-devel] [PATCH v2 00/32] Add ARMv8.2 half-precision functions === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

Re: [Qemu-devel] [PATCH v5 09/14] pci: Use pci_config_size in pci_data_* accessors

2018-02-08 Thread Michael S. Tsirkin
On Thu, Feb 08, 2018 at 09:43:53AM -0800, Andrey Smirnov wrote: > On Thu, Feb 8, 2018 at 9:34 AM, Michael S. Tsirkin wrote: > > On Thu, Feb 08, 2018 at 05:20:53PM +, Peter Maydell wrote: > >> On 7 February 2018 at 04:24, Andrey Smirnov > >> wrote:

Re: [Qemu-devel] [RFC PATCH 2/5] vfio/quirks: Add generic support for ioveventfds

2018-02-08 Thread Alex Williamson
On Thu, 8 Feb 2018 12:11:57 +0100 Auger Eric wrote: > Hi Alex, > > On 07/02/18 01:26, Alex Williamson wrote: > > We might wish to handle some quirks via ioeventfds, add a list of > > ioeventfds to the quirk. > The commit title is a bit misleading as we only add the data

[Qemu-devel] [Bug 1331334] Re: driftfix=none and migration on Win7 guest causes time to go 10 times as fast

2018-02-08 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [Qemu-devel] [RFC PATCH 1/5] vfio/quirks: Add common quirk alloc helper

2018-02-08 Thread Alex Williamson
On Thu, 8 Feb 2018 12:10:35 +0100 Auger Eric wrote: > Hi Alex, > On 07/02/18 01:26, Alex Williamson wrote: > > This will later be used to include list initialization > > > > Signed-off-by: Alex Williamson > > --- > > hw/vfio/pci-quirks.c |

Re: [Qemu-devel] [PATCH 3/3] build-sys: enable sanitizers by default with --enable-debug

2018-02-08 Thread Paolo Bonzini
On 08/02/2018 17:23, Marc-André Lureau wrote: > The original commit 247724cb302af5d70c8853154b640dfabf2bbb56 was meant > to enable sanitizers by default when --enable-debug, but failed > because of a gcc static linking bug. Try to enable it back now that > there is a stronger check. > >

[Qemu-devel] [PATCH] g364fb: switch to using DirtyBitmapSnapshot

2018-02-08 Thread Paolo Bonzini
This removes the last user of memory_region_test_and_clear_dirty outside memory.c. Cc: Hervé Poussineau Cc: Aurelien Jarno Cc: Yongbok Kim Signed-off-by: Paolo Bonzini --- Untested... not sure where

Re: [Qemu-devel] [RFC PATCH 5/5] vfio/quirks: Enable ioeventfd quirks to be handled by vfio directly

2018-02-08 Thread Alex Williamson
On Thu, 8 Feb 2018 12:42:15 +0100 Auger Eric wrote: > Hi Alex, > On 07/02/18 01:26, Alex Williamson wrote: > > With vfio ioeventfd support, we can program vfio-pci to perform a > > specified BAR write when an eventfd is triggered. This allows the > > KVM ioeventfd to be

[Qemu-devel] [Bug 1211943] Re: #GP and aligned move instruction

2018-02-08 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [PATCH v2 14/32] arm/translate-a64: add FP16 pairwise ops simd_three_reg_same_fp16

2018-02-08 Thread Alex Bennée
This includes FMAXNMP, FADDP, FMAXP, FMINNMP, FMINP. Signed-off-by: Alex Bennée --- v2 - checkpatch fixes --- target/arm/translate-a64.c | 208 + 1 file changed, 133 insertions(+), 75 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v3 1/2] i386: Add Intel Processor Trace feature support

2018-02-08 Thread Eduardo Habkost
On Thu, Feb 08, 2018 at 01:24:46AM +, Kang, Luwei wrote: > > On Wed, Jan 31, 2018 at 11:57:45PM +0800, Luwei Kang wrote: > > > From: Chao Peng > > > > > > Expose Intel Processor Trace feature to guest. > > > > > > To make Intel PT live migration safe and get same

[Qemu-devel] [PATCH v2 16/32] arm/translate-a64: add FP16 x2 ops for simd_indexed

2018-02-08 Thread Alex Bennée
A bunch of the vectorised bitwise operations just operate on larger chunks at a time. We can do the same for the new half-precision operations by introducing some TWOHALFOP helpers which work on each half of a pair of half-precision operations at once. Hopefully all this hoop jumping will get

[Qemu-devel] [PATCH 0/4] QID path collision fix

2018-02-08 Thread antonios.motakis
From: Antonios Motakis This is an implementation that ensures that a unique 64bit QID path is generated per file. Since if a file is unique on the host is determined by both inode and device id, which are 64 and 32 bits respectively, the proper long term fix will be

[Qemu-devel] [PATCH v2 28/32] arm/translate-a64: add FP16 FRSQRTE to simd_two_reg_misc_fp16

2018-02-08 Thread Alex Bennée
Signed-off-by: Alex Bennée --- target/arm/translate-a64.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 587d072d27..fa21299061 100644 --- a/target/arm/translate-a64.c +++

Re: [Qemu-devel] [PATCH] block: unify blocksize types

2018-02-08 Thread John Snow
CC qemu-block On 02/08/2018 08:28 AM, Piotr Sarna wrote: > BlockSizes structure used in block size probing has uint32_t types > for logical and physical sizes. These fields are wrongfully assigned > to uint16_t in BlockConf, which results, among other errors, > in assigning 0 instead of 65536

[Qemu-devel] [Bug 1196498] Re: Failed to create COM port in Windows Guest VM

2018-02-08 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [Qemu-devel] [PATCH] target-i386: adds PV_DEDICATED hint CPUID feature bit

2018-02-08 Thread Eduardo Habkost
On Thu, Feb 08, 2018 at 05:44:20PM +0800, Wanpeng Li wrote: > From: Wanpeng Li > > Add PV_DEDICATED hint cpuid feature bit. > [...] > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index d70954b..cf48931 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c >

[Qemu-devel] [PATCH v2 29/32] arm/translate-a64: add FP16 FMOV to simd_mod_imm

2018-02-08 Thread Alex Bennée
Only one half-precision instruction has been added to this group. Signed-off-by: Alex Bennée --- v2 - checkpatch fixes --- target/arm/translate-a64.c | 48 -- 1 file changed, 38 insertions(+), 10 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v5 10/14] pci: Add support for Designware IP block

2018-02-08 Thread Michael S. Tsirkin
On Tue, Feb 06, 2018 at 08:24:34PM -0800, Andrey Smirnov wrote: > Add code needed to get a functional PCI subsytem when using in > conjunction with upstream Linux guest (4.13+). Tested to work against > "e1000e" (network adapter, using MSI interrupts) as well as > "usb-ehci" (USB controller, using

[Qemu-devel] [PATCH] lpc: drop pcie host dependency

2018-02-08 Thread Michael S. Tsirkin
Doesn't look like that header is used. Signed-off-by: Michael S. Tsirkin --- hw/isa/lpc_ich9.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c index adcf077..e692b9f 100644 --- a/hw/isa/lpc_ich9.c +++ b/hw/isa/lpc_ich9.c @@ -39,7 +39,6

Re: [Qemu-devel] [PATCH v5 09/14] pci: Use pci_config_size in pci_data_* accessors

2018-02-08 Thread Peter Maydell
On 8 February 2018 at 17:43, Andrey Smirnov wrote: > My only justification for this change was suggestion from Marcel to > use pci_data_* functions, instead of calling pci_host_config_*_common > explicitly in designware.c introduced in next patch in the series. My > v4

Re: [Qemu-devel] [RFC PATCH 3/5] vfio/quirks: Automatic ioeventfd enabling for NVIDIA BAR0 quirks

2018-02-08 Thread Alex Williamson
On Thu, 8 Feb 2018 12:10:02 +0100 Auger Eric wrote: > Hi Alex, > > On 07/02/18 01:26, Alex Williamson wrote: > > Record data writes that come through the NVIDIA BAR0 quirk, if we get > > enough in a row that we're only passing through, automatically enable > > an

Re: [Qemu-devel] [PULL v2 00/20] Miscellaneous patches for 2018-02-07

2018-02-08 Thread Eric Blake
On 02/08/2018 10:22 AM, Peter Maydell wrote: 2018-02-08 5:16 GMT+00:00 Markus Armbruster : The following changes since commit 20e0d439a6ded635ec89f6135c08cd5541c68962: Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20180204' into staging (2018-02-06 14:21:41

[Qemu-devel] [PATCH v2 15/32] arm/translate-a64: add FP16 FMULX/MLS/FMLA to simd_indexed

2018-02-08 Thread Alex Bennée
The helpers use the new re-factored muladd support in SoftFloat for the float16 work. Signed-off-by: Alex Bennée --- target/arm/translate-a64.c | 69 -- 1 file changed, 54 insertions(+), 15 deletions(-) diff --git

[Qemu-devel] [PATCH v2 27/32] arm/helper.c: re-factor rsqrte and add rsqrte_f16

2018-02-08 Thread Alex Bennée
Much like recpe the ARM ARM has simplified the pseudo code for the calculation which is done on a fixed point 9 bit integer maths. So while adding f16 we can also clean this up to be a little less heavy on the floating point and just return the fractional part and leave the calle's to do the final

[Qemu-devel] [Bug 1747393] Re: nvme is missing support for NVME_ADM_CMD_ASYNC_EV_REQ

2018-02-08 Thread Toomas Soome
** Description changed: NVME_ADM_CMD_ASYNC_EV_REQ is required by specification but apparently we will be responded by error when this command is used. + + The Asynchronous Event Request is a mandatory opcode required by + specification (Figure 40, Section 5 in NVMe 1.2; Figure 41, Section 5

<    1   2   3   4   5   >