Re: [Qemu-devel] [PATCH 00/14] qtest patches

2018-02-08 Thread Eric Blake
On 02/08/2018 02:09 PM, Thomas Huth wrote: Here's a set of qtest patches that have been posted to the list before and are IMHO ready for inclusion. I've included the patches from Eric's "Preliminary libqtest cleanups" series that do not need major reworks (the rest needs some more love later), an

Re: [Qemu-devel] [PATCH 01/27] block/qapi: Introduce BlockdevCreateOptions

2018-02-08 Thread Eric Blake
On 02/08/2018 01:23 PM, Kevin Wolf wrote: This creates a BlockdevCreateOptions union type that will contain all of the options for image creation. We'll start out with an empty struct type BlockdevCreateDummy for all drivers. Name here... Signed-off-by: Kevin Wolf --- qapi/block-core.json

Re: [Qemu-devel] [PATCH 02/27] block/qapi: Add qcow2 create options to schema

2018-02-08 Thread Eric Blake
On 02/08/2018 01:23 PM, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- qapi/block-core.json | 45 - 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index b59b1430bb..aade602a04 100644 --- a/

Re: [Qemu-devel] [PATCH v2] spapr: check smp_threads <= vsmt

2018-02-08 Thread David Gibson
On Thu, Feb 08, 2018 at 10:42:41AM +0100, Laurent Vivier wrote: > We ignore silently the value of smp_threads when we set > the default VSMT value, and if smp_threads is greater than VSMT > kernel is going into trouble later. > > Fixes: 8904e5a750 > ("spapr: Adjust default VSMT value for better mi

Re: [Qemu-devel] [PATCH] spapr: add missing break in h_get_cpu_characteristics()

2018-02-08 Thread David Gibson
On Thu, Feb 01, 2018 at 08:47:41PM +0100, Greg Kurz wrote: > Detected by Coverity (CID 1385702). This fixes the recently added hypercall > to let guests properly apply Spectre and Meltdown workarounds. > > Fixes: c59704b25473 "target/ppc/spapr: Add H-Call H_GET_CPU_CHARACTERISTICS" > Signed-off-by

Re: [Qemu-devel] [PATCH 04/27] qcow2: Pass BlockdevCreateOptions to qcow2_create2()

2018-02-08 Thread Eric Blake
On 02/08/2018 01:23 PM, Kevin Wolf wrote: All of the simple options are now passed to qcow2_create2() in a BlockdevCreateOptions object. Still missing: node-name and the encryption options. Signed-off-by: Kevin Wolf --- block/qcow2.c | 190 ++---

Re: [Qemu-devel] [PATCH] sii3112: Change angle brackets to quotes in #include lines

2018-02-08 Thread David Gibson
On Thu, Feb 01, 2018 at 12:51:04PM +0100, BALATON Zoltan wrote: > On Wed, 31 Jan 2018, David Gibson wrote: > > On Tue, Jan 30, 2018 at 02:10:10PM +0100, BALATON Zoltan wrote: > > > This matches what other files do for qemu includes > > > > > > Signed-off-by: BALATON Zoltan > > > > Applied, thank

Re: [Qemu-devel] [PATCH] hw/char/stm32f2xx_usart: improve TXE/TC bit handling

2018-02-08 Thread Alistair Francis
On Thu, Feb 8, 2018 at 6:58 AM, Peter Maydell wrote: > On 4 February 2018 at 20:41, Richard Braun wrote: >> Consider that data is always immediately sent. As a result, keep >> the SR_TXE and SR_TC bits always set. In addition, fix the reset value >> of the USART status register. > > Do you know w

Re: [Qemu-devel] Functional tests (AKA Avocado-based tests)

2018-02-08 Thread Alistair Francis
On Mon, Feb 5, 2018 at 8:34 AM, Cleber Rosa wrote: > > > On 02/01/2018 07:10 PM, Alistair Francis wrote: >> On Wed, Jan 17, 2018 at 4:47 PM, Cleber Rosa wrote: >>> >>> >>> On 01/17/2018 06:41 PM, Alistair Francis wrote: On Wed, Jan 17, 2018 at 12:05 AM, Cleber Rosa wrote: > TL;DR >

Re: [Qemu-devel] Functional tests (AKA Avocado-based tests)

2018-02-08 Thread Alistair Francis
On Thu, Feb 8, 2018 at 3:38 PM, Alistair Francis wrote: > On Mon, Feb 5, 2018 at 8:34 AM, Cleber Rosa wrote: >> >> >> On 02/01/2018 07:10 PM, Alistair Francis wrote: >>> On Wed, Jan 17, 2018 at 4:47 PM, Cleber Rosa wrote: On 01/17/2018 06:41 PM, Alistair Francis wrote: > On We

Re: [Qemu-devel] [PATCH v3 06/18] sdcard: simplify using the ldst API

2018-02-08 Thread Alistair Francis
On Mon, Jan 22, 2018 at 7:30 PM, Philippe Mathieu-Daudé wrote: > the code is easier to review/refactor. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/sd/sd.c | 38 +- > 1 file changed, 9 insertions(+), 29 delet

Re: [Qemu-devel] [PATCH v5 10/14] pci: Add support for Designware IP block

2018-02-08 Thread Michael S. Tsirkin
On Thu, Feb 08, 2018 at 12:43:03PM -0800, Andrey Smirnov wrote: > On Thu, Feb 8, 2018 at 12:33 PM, Michael S. Tsirkin wrote: > > On Thu, Feb 08, 2018 at 12:22:53PM -0800, Andrey Smirnov wrote: > >> On Thu, Feb 8, 2018 at 12:11 PM, Michael S. Tsirkin > >> wrote: > >> > On Thu, Feb 08, 2018 at 12:

Re: [Qemu-devel] [PATCH 1/2] hw/arm/aspeed: directly map the serial device to the system address space

2018-02-08 Thread Andrew Jeffery
On Thu, 2018-02-08 at 14:40 -0300, Philippe Mathieu-Daudé wrote: > On 02/08/2018 02:30 PM, Peter Maydell wrote: > > On 8 February 2018 at 17:22, Philippe Mathieu-Daudé wrote: > > > Signed-off-by: Philippe Mathieu-Daudé > > > --- > > > hw/arm/aspeed_soc.c | 2 +- > > > 1 file changed, 1 insertion

[Qemu-devel] [PATCH 10/54] vfio: Fix vfio-kvm group registration

2018-02-08 Thread Michael Roth
From: Alex Williamson Commit 8c37faa475f3 ("vfio-pci, ppc64/spapr: Reorder group-to-container attaching") moved registration of groups with the vfio-kvm device from vfio_get_group() to vfio_connect_container(), but it missed the case where a group is attached to an existing container and takes an

[Qemu-devel] [Resend][PATCH] qga: unset frozen state if no mount points are frozen

2018-02-08 Thread Chen Hanxiao
From: Chen Hanxiao If we set mountpoints to qmp_guest_fsfreeze_freeze_list, we may got nothing to freeze as all mountpoints are not valid. Call ga_unset_frozen in this senario. Cc: Michael Roth Signed-off-by: Chen Hanxiao --- Rebase on master qga/commands-posix.c | 6 ++ 1 file changed,

Re: [Qemu-devel] [PATCH] block: unify blocksize types

2018-02-08 Thread Fam Zheng
On Thu, 02/08 14:28, Piotr Sarna wrote: > BlockSizes structure used in block size probing has uint32_t types > for logical and physical sizes. These fields are wrongfully assigned > to uint16_t in BlockConf, which results, among other errors, > in assigning 0 instead of 65536 (which will be the cas

Re: [Qemu-devel] [PATCH 3/3] build-sys: enable sanitizers by default with --enable-debug

2018-02-08 Thread Fam Zheng
On Thu, 02/08 20:03, Marc-André Lureau wrote: > Hi > > On Thu, Feb 8, 2018 at 6:46 PM, Paolo Bonzini wrote: > > On 08/02/2018 17:23, Marc-André Lureau wrote: > >> The original commit 247724cb302af5d70c8853154b640dfabf2bbb56 was meant > >> to enable sanitizers by default when --enable-debug, but f

Re: [Qemu-devel] [PATCH 00/10] linux-user: Speed up guest space initialization on 32-bit ARM target

2018-02-08 Thread Luke Shumaker
Ping. On Thu, 28 Dec 2017 13:08:03 -0500, Luke Shumaker wrote: > > From: Luke Shumaker > > The goal of this patchset is to fix > https://bugs.launchpad.net/qemu/+bug/1740219 > > The gist is that the current linear search for an acceptable address > range is a bad strategy when the reason we di

Re: [Qemu-devel] [PATCH v2 0/3] virtio-balloon: free page hint reporting support

2018-02-08 Thread Wei Wang
On 02/09/2018 04:15 AM, Dr. David Alan Gilbert wrote: * Wei Wang (wei.w.w...@intel.com) wrote: This is the deivce part implementation to add a new feature, VIRTIO_BALLOON_F_FREE_PAGE_HINT to the virtio-balloon device. The device receives the guest free page hints from the driver and clears the c

Re: [Qemu-devel] [PATCH] target-i386: adds PV_DEDICATED hint CPUID feature bit

2018-02-08 Thread Wanpeng Li
2018-02-09 2:12 GMT+08:00 Eduardo Habkost : > On Thu, Feb 08, 2018 at 05:44:20PM +0800, Wanpeng Li wrote: >> From: Wanpeng Li >> >> Add PV_DEDICATED hint cpuid feature bit. >> > [...] >> diff --git a/target/i386/cpu.c b/target/i386/cpu.c >> index d70954b..cf48931 100644 >> --- a/target/i386/cpu.c

Re: [Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

2018-02-08 Thread Fam Zheng
On Thu, 02/01 11:44, Stefan Hajnoczi wrote: > On Wed, Jan 31, 2018 at 03:22:49PM +0100, Kevin Wolf wrote: > > Am 31.01.2018 um 15:12 hat Stefan Hajnoczi geschrieben: > > > There should be a separate paragraph in docs/qemu-block-drivers.texi > > > explaining that share-rw=on can be used safely with

Re: [Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

2018-02-08 Thread Fam Zheng
On Thu, 02/01 11:44, Stefan Hajnoczi wrote: > On Wed, Jan 31, 2018 at 03:22:49PM +0100, Kevin Wolf wrote: > > Am 31.01.2018 um 15:12 hat Stefan Hajnoczi geschrieben: > > > There should be a separate paragraph in docs/qemu-block-drivers.texi > > > explaining that share-rw=on can be used safely with

[Qemu-devel] [PULL v3 00/20] Miscellaneous patches for 2018-02-07

2018-02-08 Thread Markus Armbruster
The following changes since commit 008a51bbb343972dd8cf09126da8c3b87f4e1c96: Merge remote-tracking branch 'remotes/famz/tags/staging-pull-request' into staging (2018-02-08 14:31:51 +) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-misc-2018-02-07-v3

[Qemu-devel] [PATCH v7 2/3] qemu-img: Document --force-share / -U

2018-02-08 Thread Fam Zheng
Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- qemu-img.texi | 8 1 file changed, 8 insertions(+) diff --git a/qemu-img.texi b/qemu-img.texi index 60a0e080c6..8a26400adb 100644 --- a/qemu-img.texi +++ b/qemu-img.texi @@ -86,6 +86,14 @@ exclusive with the @var{-O} parameters. It

[Qemu-devel] [PATCH v7 0/3] qemu-img: Document --force-share / -U

2018-02-08 Thread Fam Zheng
v7: Tweak wording again "allowing concurrent writers" -> "allowing other QEMU processes to open it in write mode". [Eric, Stefan, Kevin] Add patch to document share-rw. [Stefan] v6: Tweak wording ("concurrent writers"). [Max] Fam Zheng (3): qemu-img.texi: Clean up parameter list qemu-

[Qemu-devel] [PATCH v7 3/3] docs: Document share-rw property more thoroughly

2018-02-08 Thread Fam Zheng
Suggested-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- docs/qemu-block-drivers.texi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/qemu-block-drivers.texi b/docs/qemu-block-drivers.texi index cd74767ed3..f1793692bb 100644 --- a/docs/qemu-block-drivers.texi +++ b/docs/qe

[Qemu-devel] [PATCH v7 1/3] qemu-img.texi: Clean up parameter list

2018-02-08 Thread Fam Zheng
Split options out of the "@table @var" section and create a "@table @option", then use whitespaces and blank lines consistently. Suggested-by: Kevin Wolf Signed-off-by: Fam Zheng --- qemu-img.texi | 66 +++ 1 file changed, 39 insertions(+)

Re: [Qemu-devel] [RESEND PATCH] PPC: e500: Fix duplicate kernel load and device tree overlap

2018-02-08 Thread David Gibson
On Thu, Feb 08, 2018 at 09:36:21AM +0100, David Engraf wrote: > This patch fixes an incorrect behavior when the -kernel argument has been > specified without -bios. In this case the kernel was loaded twice. At address > 32M as a raw image and afterwards by load_elf/load_uimage at the > correspondin

Re: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery

2018-02-08 Thread Peter Xu
On Thu, Feb 08, 2018 at 03:25:21AM -0800, no-re...@patchew.org wrote: > Hi, > > This series failed docker-mingw@fedora build test. Please find the testing > commands and > their output below. If you have Docker installed, you can probably reproduce > it > locally. For all the five patchew repor

Re: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery

2018-02-08 Thread Fam Zheng
On Fri, Feb 9, 2018 at 2:07 PM, Peter Xu wrote: > On Thu, Feb 08, 2018 at 03:25:21AM -0800, no-re...@patchew.org wrote: >> Hi, >> >> This series failed docker-mingw@fedora build test. Please find the testing >> commands and >> their output below. If you have Docker installed, you can probably rep

Re: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery

2018-02-08 Thread Peter Xu
On Thu, Feb 08, 2018 at 06:31:04PM +0800, Peter Xu wrote: > Tree is pushed here for better reference and testing (online tree > includes monitor OOB series): > > https://github.com/xzpeter/qemu/tree/postcopy-recovery-support Hello, Patchew, Based-on: <20180124053957.29145-1-pet...@redhat.com>

Re: [Qemu-devel] [RFC PATCH] vfio/pci: Add ioeventfd support

2018-02-08 Thread Peter Xu
On Tue, Feb 06, 2018 at 05:08:14PM -0700, Alex Williamson wrote: [...] > +long vfio_pci_ioeventfd(struct vfio_pci_device *vdev, loff_t offset, > + uint64_t data, int count, int fd) > +{ > + struct pci_dev *pdev = vdev->pdev; > + loff_t pos = offset & VFIO_PCI_OFFSET_MA

Re: [Qemu-devel] Functional tests (AKA Avocado-based tests)

2018-02-08 Thread Fam Zheng
On Thu, Jan 18, 2018 at 5:07 PM, Amador Pahim wrote: > Expanding on that, the vmimage lib downloads and caches the so called > "cloud images" from distros own repositories. Here's[1] some > documentation with usage examples, including one example on how to add > your own image provider. Linux dis

[Qemu-devel] [V9fs-developer] [RFC] we should solve create-unlink-getattr idiom

2018-02-08 Thread jiangyiwen
Hi Eric and Greg, I encountered the similar problem with create-unlink-getattr idiom. I use the testcase that create-unlink-setattr idiom, and I see the bug is reported at https://bugs.launchpad.net/qemu/+bug/1336794. Then I also see you already fix the issue and push the patch to upstream. https:

Re: [Qemu-devel] [RFC PATCH 5/5] vfio/quirks: Enable ioeventfd quirks to be handled by vfio directly

2018-02-08 Thread Peter Xu
On Tue, Feb 06, 2018 at 05:26:46PM -0700, Alex Williamson wrote: > With vfio ioeventfd support, we can program vfio-pci to perform a > specified BAR write when an eventfd is triggered. This allows the > KVM ioeventfd to be wired directly to vfio-pci, entirely avoiding > userspace handling for thes

Re: [Qemu-devel] [V9fs-developer] [RFC] we should solve create-unlink-getattr idiom

2018-02-08 Thread Veaceslav Falico
Hi Yiwen, all, On 2/9/2018 8:10 AM, jiangyiwen wrote: > Hi Eric and Greg, > > I encountered the similar problem with create-unlink-getattr idiom. > I use the testcase that create-unlink-setattr idiom, and I see the > bug is reported at https://bugs.launchpad.net/qemu/+bug/1336794. > Then I also s

Re: [Qemu-devel] [PATCH v5 12/23] RISC-V HTIF Console

2018-02-08 Thread Michael Clark
On Fri, Feb 9, 2018 at 5:35 AM, Richard Henderson < richard.hender...@linaro.org> wrote: > On 02/07/2018 05:28 PM, Michael Clark wrote: > > +++ b/hw/riscv/riscv_elf.c > > @@ -0,0 +1,244 @@ > > +/* > > + * elf.c - A simple package for manipulating symbol tables in elf > binaries. > > + * > > + * Ta

Re: [Qemu-devel] [PATCH v1] Implement support for IEEE 754-201x minimumNumber/maximumNumber

2018-02-08 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1518046997-22714-1-git-send-email-...@sifive.com Subject: [Qemu-devel] [PATCH v1] Implement support for IEEE 754-201x minimumNumber/maximumNumber === TEST SCRIPT BEGIN === #

Re: [Qemu-devel] [RESEND PATCH] PPC: e500: Fix duplicate kernel load and device tree overlap

2018-02-08 Thread David Engraf
Hello David, Am 09.02.2018 um 06:33 schrieb David Gibson: On Thu, Feb 08, 2018 at 09:36:21AM +0100, David Engraf wrote: This patch fixes an incorrect behavior when the -kernel argument has been specified without -bios. In this case the kernel was loaded twice. At address 32M as a raw image and

[Qemu-devel] [PATCH qemu v7 0/4] vfio-pci: Allow mmap of MSIX BAR

2018-02-08 Thread Alexey Kardashevskiy
Here is my latest patchset to allow mapping of MSIX BAR to the guest in order to accelerate MMIO on certains devices. This is based on sha1 008a51b Peter Maydell "Merge remote-tracking branch 'remotes/famz/tags/staging-pull-request' into staging". Please comment. Thanks. Changes: v7: * split in

[Qemu-devel] [PATCH qemu v7 3/4] vfio-pci: Allow mmap of MSIX BAR

2018-02-08 Thread Alexey Kardashevskiy
At the moment we unconditionally avoid mapping MSIX data of a BAR and emulate MSIX table in QEMU. However it is 1) not always necessary as a platform may prodive a paravirt interface for MSIX configuration; 2) can affect the speed of MMIO access by emulating them in QEMU when frequently accessed re

[Qemu-devel] [PATCH qemu v7 4/4] ppc/spapr, vfio: Turn off MSIX emulation for VFIO devices

2018-02-08 Thread Alexey Kardashevskiy
This adds a possibility for the platform to tell VFIO not to emulate MSIX so MMIO memory regions do not get split into chunks in flatview and the entire page can be registered as a KVM memory slot and make direct MMIO access possible for the guest. This enables the entire MSIX BAR mapping to the g

Re: [Qemu-devel] [PATCH v2] qmp: add query-cpus-fast

2018-02-08 Thread Viktor Mihajlovski
On 08.02.2018 21:33, Eduardo Habkost wrote: > On Thu, Feb 08, 2018 at 11:17:32AM -0500, Luiz Capitulino wrote: > [...] >> The "halted" field is somewhat controversial. On the one hand, >> it offers a convenient way to know if a guest CPU is idle or >> running. On the other hand, it's a field that c

[Qemu-devel] [PATCH qemu v7 2/4] vfio/pci: Relax DMA map errors for MMIO regions

2018-02-08 Thread Alexey Kardashevskiy
At the moment if vfio_memory_listener is registered in the system memory address space, it maps/unmaps every RAM memory region for DMA. It expects system page size aligned memory sections so vfio_dma_map would not fail and so far this has been the case. A mapping failure would be fatal. A side effe

[Qemu-devel] [PATCH qemu v7 1/4] linux-headers: update to f1517df8701c

2018-02-08 Thread Alexey Kardashevskiy
Update headers against f1517df8701c. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f1517df8701c Signed-off-by: Alexey Kardashevskiy -- Pulled because of new VFIO_REGION_INFO_CAP_MSIX_MAPPABLE --- include/standard-headers/linux/input-event-codes.h | 1 + includ

<    1   2   3   4   5