[Qemu-devel] [PULL 05/17] mailmap: set preferred spelling for Daniel Berrangé

2018-02-09 Thread Michael Tokarev
From: Daniel P. Berrangé Signed-off-by: Daniel P. Berrangé Signed-off-by: Michael Tokarev --- .mailmap | 4 1 file changed, 4 insertions(+) diff --git a/.mailmap b/.mailmap index ee81ac801e..cf689b9ec9 100644 --- a/.mailmap +++ b/.mailmap @@ -18,3 +18,7 @@ malc malc # There is also a

[Qemu-devel] [PULL 00/17] Trivial patches for 2018-02-10

2018-02-09 Thread Michael Tokarev
Here's a next pull request for the trivial-patches tree. After a very long delay. Hopefully I still remember how to apply patches :) The following changes since commit c7b02d7d032d6022060e4b393827c963c93ce63f: Merge remote-tracking branch 'remotes/stsquad/tags/pull-travis-speedup-090218-1' in

[Qemu-devel] [PULL 02/17] scripts/argparse.py: spelling (independant)

2018-02-09 Thread Michael Tokarev
Signed-off-by: Michael Tokarev Reviewed-by: Eric Blake --- scripts/argparse.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/argparse.py b/scripts/argparse.py index 288c1f06c0..27d1f28935 100644 --- a/scripts/argparse.py +++ b/scripts/argparse.py @@ -76,7 +76,7 @@ c

[Qemu-devel] [PULL 06/17] qemu-options.hx: Remove confusing spaces in parameter listings

2018-02-09 Thread Michael Tokarev
From: Thomas Huth The spaces between the parameters in the chardev and tpmdev sections are rather confusing than helpful, and prevent that the lists can be copy-n-pasted easily for real usage. We also don't use such spaces in other sections in the documentation, e.g. with the -netdev option, so l

[Qemu-devel] [PULL 01/17] qapi-schema.json: spelling (independant comparation)

2018-02-09 Thread Michael Tokarev
Signed-off-by: Michael Tokarev Reviewed-by: Eric Blake --- qapi-schema.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 5c06745c79..0262b9f20b 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -2023,7 +2023,7 @@ # # @s

Re: [Qemu-devel] fix evsrwu and others for powerpcspe

2018-02-09 Thread Thomas Huth
On 10.02.2018 08:25, Michael Tokarev wrote: > 26.12.2017 14:29, i...@mobile-stream.com wrote: >> GEN_SPEOP_ARITH2 declares non-local temporaries then calls >> gen_op_evsrwu/evsrws/evslw which generates branch insn. > > I'm Cc'ing qemu-devel@ for review, since I don't know much about how ppc > wo

Re: [Qemu-devel] [PATCHv2 01/12] cuda: do not use old_mmio accesses

2018-02-09 Thread David Gibson
On Fri, Feb 09, 2018 at 05:05:23PM -0300, Philippe Mathieu-Daudé wrote: > Hi Mark, > > On 02/09/2018 03:51 PM, Mark Cave-Ayland wrote: > > Signed-off-by: Mark Cave-Ayland > > --- > > hw/misc/macio/cuda.c | 40 > > 1 file changed, 8 insertions(+), 32 delet

Re: [Qemu-devel] [PATCHv2 02/12] cuda: don't allow writes to port output pins

2018-02-09 Thread David Gibson
On Fri, Feb 09, 2018 at 06:51:32PM +, Mark Cave-Ayland wrote: > Use the direction registers as a mask to ensure that only input pins are > updated upon write. > > Signed-off-by: Mark Cave-Ayland > Reviewed-by: Laurent Vivier > Reviewed-by: Philippe Mathieu-Daudé Applied, thanks. > --- >

Re: [Qemu-devel] [PATCHv2 01/12] cuda: do not use old_mmio accesses

2018-02-09 Thread David Gibson
On Fri, Feb 09, 2018 at 06:51:31PM +, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland Applied, thanks. > --- > hw/misc/macio/cuda.c | 40 > 1 file changed, 8 insertions(+), 32 deletions(-) > > diff --git a/hw/misc/macio/cuda.c b/hw/misc/ma

Re: [Qemu-devel] fix evsrwu and others for powerpcspe

2018-02-09 Thread Michael Tokarev
26.12.2017 14:29, i...@mobile-stream.com wrote: > GEN_SPEOP_ARITH2 declares non-local temporaries then calls > gen_op_evsrwu/evsrws/evslw which generates branch insn. I'm Cc'ing qemu-devel@ for review, since I don't know much about how ppc works. Thanks, /mjt > --- target/ppc/translate/spe-imp

Re: [Qemu-devel] [PATCH] oslib-posix: check for posix_memalign in configure script

2018-02-09 Thread Michael Tokarev
04.01.2018 20:39, Andreas Gustafsson wrote: > Check for the presence of posix_memalign() in the configure script, > not using "defined(_POSIX_C_SOURCE) && !defined(__sun__)". This > lets qemu use posix_memalign() on NetBSD versions that have it, > instead of falling back to valloc() which is waste

Re: [Qemu-devel] [PATCH qemu] configure: Allow capstone=git only if git update is not disabled

2018-02-09 Thread Michael Tokarev
15.01.2018 05:35, Alexey Kardashevskiy wrote: > Even with --disable-git-update, ./configure tries updating the capstone > submodule instead of marking it "no"; this disables capstone submodule > if git update is disabled. Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH qemu v2] machine: Polish -machine xxx,help

2018-02-09 Thread Michael Tokarev
26.10.2017 04:41, Alexey Kardashevskiy пишет: > The "-machine xxx,help" prints kernel-irqchip possible values as > "OnOffSplit", this adds separators to the printed line. Applied to -trivial, thanks, and please excuse us for the very long delay! /mjt

Re: [Qemu-devel] [PATCH] block/nvme: fix Coverity reports

2018-02-09 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 02/09/2018 12:24 PM, Paolo Bonzini wrote: >> 1) string not null terminated in sysfs_find_group_file > > CID 1385854 > >> >> 2) NULL pointer dereference and dead local variable in nvme_init. > > CID 1385855 > >> >> Signed-off-by: Paolo Bonzini >> --- >> bloc

Re: [Qemu-devel] [PULL v3 00/20] Miscellaneous patches for 2018-02-07

2018-02-09 Thread Markus Armbruster
Peter Maydell writes: > On 9 February 2018 at 05:03, Markus Armbruster wrote: >> The following changes since commit 008a51bbb343972dd8cf09126da8c3b87f4e1c96: >> >> Merge remote-tracking branch 'remotes/famz/tags/staging-pull-request' into >> staging (2018-02-08 14:31:51 +) >> >> are avail

Re: [Qemu-devel] [PATCH v5 06/14] qapi: remove '-q' arg to diff when comparing QAPI output

2018-02-09 Thread Markus Armbruster
Eric Blake writes: > On 01/16/2018 07:42 AM, Daniel P. Berrange wrote: >> When the qapi schema tests fail they merely print that the expected >> output didn't match the actual output. This is largely useless when >> trying diagnose what went wrong. Removing the '-q' arg to diff >> means that it i

Re: [Qemu-devel] [PATCH 1/1] hw/ppc: rename functions in comments

2018-02-09 Thread David Gibson
On Fri, Feb 09, 2018 at 04:13:30PM -0200, Daniel Henrique Barboza wrote: > Commit bcb5ce08cf ("spapr: Rename machine init functions for clarity") > renamed ppc_spapr_reset to spapr_machine_reset and ppc_spapr_init > to spapr_machine_init. Let's also rename the references in > comments. > > Signed-

Re: [Qemu-devel] [RFC PATCH v6 00/20] replay additions

2018-02-09 Thread Ciro Santilli
Also, what command do you use to test on ARM? I'm a bit stuck to get the drive part right, e.g.: -drive file=./buildroot/output.arm~/images/rootfs.ext2,if=scsi,id=img-direct,format=raw \ -drive driver=blkreplay,if=none,image=img-direct,id=img-blkreplay \ -device scsi-hd,drive=img-blkreplay \ fail

Re: [Qemu-devel] [PATCH v5 00/23] RISC-V QEMU Port Submission

2018-02-09 Thread Michael Clark
On Sat, Feb 10, 2018 at 8:42 AM, Richard Henderson < richard.hender...@linaro.org> wrote: > On 02/07/2018 05:28 PM, Michael Clark wrote: > > create mode 100644 hw/riscv/Makefile.objs > > create mode 100644 hw/riscv/riscv_elf.c > > create mode 100644 hw/riscv/riscv_hart.c > > create mode 100644

Re: [Qemu-devel] [PATCH v5 06/14] qapi: remove '-q' arg to diff when comparing QAPI output

2018-02-09 Thread Eric Blake
On 01/16/2018 07:42 AM, Daniel P. Berrange wrote: When the qapi schema tests fail they merely print that the expected output didn't match the actual output. This is largely useless when trying diagnose what went wrong. Removing the '-q' arg to diff means that it is still silent on successful test

Re: [Qemu-devel] [PATCH v3] block: maintain persistent disabled bitmaps

2018-02-09 Thread John Snow
On 02/02/2018 11:07 AM, Vladimir Sementsov-Ogievskiy wrote: > add info into qemu-doc.texi > rm John's r-b (sorry=( haha :) It's good to get many eyes on these things. Thanks, Max!

Re: [Qemu-devel] [PATCH v2 11/13] block/mirror: remove block_job_sleep_ns calls

2018-02-09 Thread John Snow
On 02/07/2018 05:46 PM, Max Reitz wrote: > Errr. Are you sure about that? > > Now every mirror job in the qeny process will share this single > variable. Was that your intention? > Duh, no. Thanks for the review, also. I'm currently sidetracked on something else, so I'll get back to this so

Re: [Qemu-devel] [PATCH] block: early check for blockers on drive-mirror

2018-02-09 Thread John Snow
On 02/07/2018 11:29 AM, Paolo Bonzini wrote: > Even if an op blocker is present for BLOCK_OP_TYPE_MIRROR_SOURCE, > it is checked a bit late and the result is that the target is > created even if drive-mirror subsequently fails. Add an early > check to avoid this. > > Signed-off-by: Paolo Bonzin

Re: [Qemu-devel] [RFC PATCH 5/5] vfio/quirks: Enable ioeventfd quirks to be handled by vfio directly

2018-02-09 Thread Alex Williamson
On Fri, 9 Feb 2018 15:11:45 +0800 Peter Xu wrote: > On Tue, Feb 06, 2018 at 05:26:46PM -0700, Alex Williamson wrote: > > With vfio ioeventfd support, we can program vfio-pci to perform a > > specified BAR write when an eventfd is triggered. This allows the > > KVM ioeventfd to be wired directly

Re: [Qemu-devel] [PATCH 3/4] 9pfs: stat_to_qid: use device as input to qid.path

2018-02-09 Thread Emilio G. Cota
On Fri, Feb 09, 2018 at 16:13:26 +0100, Greg Kurz wrote: > On Thu, 8 Feb 2018 19:00:18 +0100 > wrote: (snip) > > +/* creative abuse of tb_hash_func7, which is based on xxhash */ > > +static uint32_t qpp_hash(QppEntry e) > > +{ > > +return tb_hash_func7(e.ino_prefix, e.dev, 0, 0, 0); > > Hmm..

Re: [Qemu-devel] [PATCH 1/4] multiboot: Change multiboot_info from array of bytes to a C struct

2018-02-09 Thread Anatol Pomozov
Hello Actually I just fetched recent chnages and tests/multiboot/run_test.sh does not work for me anymore. I rebuilt 'master' branch without my changes and see the same issue. It looks like debug console does not print to stdio anymore. Does anyone see the same issue?

Re: [Qemu-devel] [PATCH v2] tests/migration: Add source to PC boot block

2018-02-09 Thread Wei Huang
On 02/05/2018 12:18 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The boot block used in the migration test is currently only > shipped as a hex (with the source in the git commit message), > change this to actually include the source. > > A script is added to re

Re: [Qemu-devel] [PATCH 1/4] multiboot: Change multiboot_info from array of bytes to a C struct

2018-02-09 Thread Anatol Pomozov
Hi Kevin Is the patch series look good? Are there any other unresolved issues? On Mon, Jan 29, 2018 at 12:02 PM, Kevin Wolf wrote: > Am 29.01.2018 um 19:21 hat Anatol Pomozov geschrieben: >> Hi >> >> On Mon, Jan 15, 2018 at 6:49 AM, Kevin Wolf wrote: >> > Am 13.10.2017 um 01:54 hat Anatol Pomoz

Re: [Qemu-devel] [PATCH 4/4] 9pfs: stat_to_qid: implement slow path

2018-02-09 Thread Emilio G. Cota
On Fri, Feb 09, 2018 at 16:22:33 +0100, Greg Kurz wrote: > On Thu, 8 Feb 2018 19:00:19 +0100 > wrote: (snip) > > /* stat_to_qid needs to map inode number (64 bits) and device id (32 bits) > > * to a unique QID path (64 bits). To avoid having to map and keep track > > * of up to 2^64 objects,

Re: [Qemu-devel] [RFC PATCH] vfio/pci: Add ioeventfd support

2018-02-09 Thread Alex Williamson
On Fri, 9 Feb 2018 15:05:11 +0800 Peter Xu wrote: > On Tue, Feb 06, 2018 at 05:08:14PM -0700, Alex Williamson wrote: > > [...] > > > +long vfio_pci_ioeventfd(struct vfio_pci_device *vdev, loff_t offset, > > + uint64_t data, int count, int fd) > > +{ > > + struct pci_dev *pde

[Qemu-devel] [PATCH V2 0/1] tests: Add migration test for aarch64

2018-02-09 Thread Wei Huang
This is a new version of migration-test for aarch64. This version needs to be applied on top of Dave Gilbert's recent patch "[v2] tests/migration: Add source to PC boot block". V1->V2: * Similar to Dave Gilbert's recent changes to migration-test, we provide the test source and a build script i

[Qemu-devel] [PATCH V2 1/1] tests: Add migration test for aarch64

2018-02-09 Thread Wei Huang
This patch adds migration test support for aarch64. The test code, which implements the same functionality as x86, is booted as a kernel in qemu. Here are the design choices we make for aarch64: * We choose this -kernel approach because aarch64 QEMU doesn't provide a built-in fw like x86 does.

Re: [Qemu-devel] [PATCH v2] dump: Show custom message for ENOSPC

2018-02-09 Thread joserz
On Fri, Feb 09, 2018 at 02:57:33PM -0600, Eric Blake wrote: > On 02/09/2018 02:26 PM, Yasmin Beatriz wrote: > > This patch intends to make a more specific message for when > > the system has not enough space to save guest memory. > > > > Reported-by: yilzh...@redhat.com > > Cc: Jose Ricardo Zivian

[Qemu-devel] [Bug 1732959] Re: [regression] Clock jump on source VM after migration

2018-02-09 Thread Neil Skrypuch
Two important findings: 1) If I disable ntpd on the host, this issue goes away. 2) If I forcefully induce substantial clock skew on the host (with adjtimex -f 1000), it becomes much less time intensive to reproduce this issue. Using the attached reproducer but replacing the 18h sleep wit

Re: [Qemu-devel] [PATCH v2 11/11] target/arm: Implement v8M MSPLIM and PSPLIM registers

2018-02-09 Thread Richard Henderson
On 02/09/2018 08:58 AM, Peter Maydell wrote: > The v8M architecture includes hardware support for enforcing > stack pointer limits. We don't implement this behaviour yet, > but provide the MSPLIM and PSPLIM stack pointer limit registers > as reads-as-written, so that when we do implement the checks

Re: [Qemu-devel] [PATCH v2 10/11] target/arm: Migrate v7m.other_sp

2018-02-09 Thread Richard Henderson
On 02/09/2018 08:58 AM, Peter Maydell wrote: > In commit abc24d86cc0364f we accidentally broke migration of > the stack pointer value for the mode (process, handler) the CPU > is not currently running as. (The commit correctly removed the > no-longer-used v7m.current_sp flag from the VMState but al

Re: [Qemu-devel] [PATCH v2 09/11] target/arm: Add AIRCR to vmstate struct

2018-02-09 Thread Richard Henderson
On 02/09/2018 08:58 AM, Peter Maydell wrote: > In commit commit 3b2e934463121 we added support for the AIRCR > register holding state, but forgot to add it to the vmstate > structs. Since it only holds r/w state if the security extension > is implemented, we can just add it to vmstate_m_security. >

Re: [Qemu-devel] [PATCH v2 07/11] target/arm: Implement writing to CONTROL_NS for v8M

2018-02-09 Thread Richard Henderson
On 02/09/2018 08:58 AM, Peter Maydell wrote: > In commit 50f11062d4c896 we added support for MSR/MRS access > to the NS banked special registers, but we forgot to implement > the support for writing to CONTROL_NS. Correct the omission. > > Signed-off-by: Peter Maydell > --- > target/arm/helper.c

Re: [Qemu-devel] [PATCH v2 06/11] hw/intc/armv7m_nvic: Implement SCR

2018-02-09 Thread Richard Henderson
On 02/09/2018 08:58 AM, Peter Maydell wrote: > We were previously making the system control register (SCR) > just RAZ/WI. Although we don't implement the functionality > this register controls, we should at least provide the state, > including the banked state for v8M. > > Signed-off-by: Peter May

Re: [Qemu-devel] [PATCH v2 05/11] hw/intc/armv7m_nvic: Implement cache ID registers

2018-02-09 Thread Richard Henderson
On 02/09/2018 08:58 AM, Peter Maydell wrote: > M profile cores have a similar setup for cache ID registers > to A profile: > * Cache Level ID Register (CLIDR) is a fixed value > * Cache Type Register (CTR) is a fixed value > * Cache Size ID Registers (CCSIDR) are a bank of registers; >which

Re: [Qemu-devel] [PATCH v2] dump: Show custom message for ENOSPC

2018-02-09 Thread Eric Blake
On 02/09/2018 02:26 PM, Yasmin Beatriz wrote: This patch intends to make a more specific message for when the system has not enough space to save guest memory. Reported-by: yilzh...@redhat.com Cc: Jose Ricardo Ziviani Signed-off-by: Yasmin Beatriz --- @@ -364,7 +364,11 @@ static void write_

Re: [Qemu-devel] [PATCH] dump: Show custom message for ENOSPC

2018-02-09 Thread Eric Blake
On 02/09/2018 01:31 PM, Yasmin Beatriz wrote: This patch intends to make a more specific message for when the system has not enough space to save guest memory. Reported-by: yilzh...@redhat.com Cc: Jose Ricardo Ziviani Signed-off-by: Yasmin Beatriz --- dump.c | 9 - 1 file changed, 8

Re: [Qemu-devel] [PATCH v7 17/26] target/i386: encrypt bios rom

2018-02-09 Thread Brijesh Singh
On 2/9/18 12:28 PM, Dr. David Alan Gilbert wrote: > * Brijesh Singh (brijesh.si...@amd.com) wrote: >> SEV requires that guest bios must be encrypted before booting the guest. > I'm curious; is it just the main BIOS that needs encryption - what about > things like device/PXE rom images? SEV feat

Re: [Qemu-devel] [PATCH] block: unify blocksize types

2018-02-09 Thread Eric Blake
On 02/09/2018 09:11 AM, Kevin Wolf wrote: Yes, I do, thanks - I'll prepare patch v2 today. Also, I haven't found any hidden dependencies on blocksize being <= 32768, so I assume changing the new max value to 2^31 is safe. Could somebody more familiar with qemu code confirm(or invalidate) my assu

Re: [Qemu-devel] [PATCH v2 04/11] hw/intc/armv7m_nvic: Implement v8M CPPWR register

2018-02-09 Thread Richard Henderson
On 02/09/2018 08:58 AM, Peter Maydell wrote: > The Coprocessor Power Control Register (CPPWR) is new in v8M. > It allows software to control whether coprocessors are allowed > to power down and lose their state. QEMU doesn't have any > notion of power control, so we choose the IMPDEF option of > ma

Re: [Qemu-devel] [PATCH v2 03/11] hw/intc/armv7m_nvic: Implement M profile cache maintenance ops

2018-02-09 Thread Richard Henderson
On 02/09/2018 08:58 AM, Peter Maydell wrote: > For M profile cores, cache maintenance operations are done by > writing to special registers in the system register space. > For QEMU, cache operations are always NOPs, since we don't > implement the cache. Implementing these explicitly avoids > a spur

Re: [Qemu-devel] [PATCH v2] dump: Show custom message for ENOSPC

2018-02-09 Thread Daniel Henrique Barboza
On 02/09/2018 06:26 PM, Yasmin Beatriz wrote: This patch intends to make a more specific message for when the system has not enough space to save guest memory. Reported-by: yilzh...@redhat.com Cc: Jose Ricardo Ziviani Signed-off-by: Yasmin Beatriz --- dump.c | 8 ++-- 1 file changed,

Re: [Qemu-devel] [PATCH v2 02/11] hw/intc/armv7m_nvic: Fix ICSR PENDNMISET/CLR handling

2018-02-09 Thread Richard Henderson
On 02/09/2018 08:58 AM, Peter Maydell wrote: > The PENDNMISET/CLR bits in the ICSR should be RAZ/WI from > NonSecure state if the AIRCR.BFHFNMINS bit is zero. We had > misimplemented this as making the bits RAZ/WI from both > Secure and NonSecure states. Fix this bug by checking > attrs.secure so t

Re: [Qemu-devel] [PATCH] dump: Show custom message for ENOSPC

2018-02-09 Thread Murilo Opsfelder Araujo
Hi, Yasmin. Congratulations on your first patch! On 02/09/2018 05:31 PM, Yasmin Beatriz wrote: > This patch intends to make a more specific message for when > the system has not enough space to save guest memory. > > Reported-by: yilzh...@redhat.com > Cc: Jose Ricardo Ziviani > Signed-off-by: Y

Re: [Qemu-devel] [PATCH v2 01/11] hw/intc/armv7m_nvic: Don't hardcode M profile ID registers in NVIC

2018-02-09 Thread Richard Henderson
On 02/09/2018 08:58 AM, Peter Maydell wrote: > Instead of hardcoding the values of M profile ID registers in the > NVIC, use the fields in the CPU struct. This will allow us to > give different M profile CPU types different ID register values. > > This commit includes the addition of the missing I

Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG

2018-02-09 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > This is a race that can happen when migrating TCG guests under load. > It was introduced by the change to run vCPUs outside the big QEMU lock. I can't yet confirming this fixes it; my test on the ARM box I was using are doing ... odd things - I've got

[Qemu-devel] [PATCH v2] dump: Show custom message for ENOSPC

2018-02-09 Thread Yasmin Beatriz
This patch intends to make a more specific message for when the system has not enough space to save guest memory. Reported-by: yilzh...@redhat.com Cc: Jose Ricardo Ziviani Signed-off-by: Yasmin Beatriz --- dump.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/dump.c

Re: [Qemu-devel] [PATCH v1 0/3] cpus: single-threaded TCG CPU creation improvements

2018-02-09 Thread Richard Henderson
On 02/09/2018 11:52 AM, David Hildenbrand wrote: > While looking into CPU hotplug for s390x TCG, I noticed that > single-threaded TCG does not properly inititalize CPUs > 1. Fix this > and cleanup the code a bit. > > David Hildenbrand (3): > cpus: properly inititalize CPU > 1 under single-thread

Re: [Qemu-devel] [PATCH 4/4] memory: unify loops to sync dirty log bitmap

2018-02-09 Thread Richard Henderson
On 02/09/2018 02:45 AM, Paolo Bonzini wrote: > Now that memory_region_sync_dirty_bitmap is NULL, we can unify its > loop with memory_global_dirty_log_sync's. The only difference is > that memory_region_sync_dirty_bitmap will no longer call log_sync on > FlatRanges that do have a zero dirty_log_mas

Re: [Qemu-devel] [PATCH 3/4] memory: introduce memory_global_after_dirty_log_sync

2018-02-09 Thread Richard Henderson
On 02/09/2018 02:45 AM, Paolo Bonzini wrote: > There is a race between TCG and accesses to the dirty log: > > vCPU thread reader thread > --- --- > TLB check -> slow path > notdirty_mem_write > write

Re: [Qemu-devel] [PATCH v2 4/4] acpi: build TPM Physical Presence interface

2018-02-09 Thread Stefan Berger
On 01/16/2018 10:51 AM, Stefan Berger wrote: The TPM Physical Presence interface consists of an ACPI part, a shared memory part, and code in the firmware. Users can send messages to the firmware by writing a code into the shared memory through invoking the ACPI code. When a reboot happens, the fi

Re: [Qemu-devel] [PATCH 2/4] memory: hide memory_region_sync_dirty_bitmap behind DirtyBitmapSnapshot

2018-02-09 Thread Richard Henderson
On 02/09/2018 02:45 AM, Paolo Bonzini wrote: > Simplify the users of memory_region_snapshot_and_clear_dirty, so > that they do not have to call memory_region_sync_dirty_bitmap > explicitly. > > Signed-off-by: Paolo Bonzini > --- > hw/display/cg3.c | 1 - > hw/display/exynos4210_fimd

Re: [Qemu-devel] [PATCH 1/4] memory: remove memory_region_test_and_clear_dirty

2018-02-09 Thread Richard Henderson
On 02/09/2018 02:45 AM, Paolo Bonzini wrote: > It is unused after g364fb has been converted to use DirtyBitmapSnapshot. > > Signed-off-by: Paolo Bonzini > --- > include/exec/memory.h | 24 +++- > memory.c | 8 > 2 files changed, 3 insertions(+), 29 dele

Re: [Qemu-devel] [PATCH] dump: Show custom message for ENOSPC

2018-02-09 Thread Daniel Henrique Barboza
Hi Yasmin, On 02/09/2018 05:31 PM, Yasmin Beatriz wrote: This patch intends to make a more specific message for when the system has not enough space to save guest memory. Reported-by: yilzh...@redhat.com Cc: Jose Ricardo Ziviani Signed-off-by: Yasmin Beatriz --- dump.c | 9 - 1 fil

Re: [Qemu-devel] [PATCHv2 01/12] cuda: do not use old_mmio accesses

2018-02-09 Thread Philippe Mathieu-Daudé
Hi Mark, On 02/09/2018 03:51 PM, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland > --- > hw/misc/macio/cuda.c | 40 > 1 file changed, 8 insertions(+), 32 deletions(-) > > diff --git a/hw/misc/macio/cuda.c b/hw/misc/macio/cuda.c > index 008d8bd4

Re: [Qemu-devel] [PATCHv2 11/12] ppc: move CUDAState and other CUDA-related definitions into separate cuda.h file

2018-02-09 Thread Philippe Mathieu-Daudé
On 02/09/2018 03:51 PM, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé > --- > hw/misc/macio/cuda.c | 1 + > hw/misc/macio/macio.c| 1 + > hw/ppc/mac.h | 77 --- > include/hw/misc/ma

Re: [Qemu-devel] [PATCHv2 12/12] cuda: convert to trace-events

2018-02-09 Thread Philippe Mathieu-Daudé
On 02/09/2018 03:51 PM, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland > --- > Makefile.objs | 1 + > hw/misc/macio/cuda.c | 50 > -- > hw/misc/macio/trace-events | 11 ++ > 3 files changed, 29 insertions(+), 33 d

[Qemu-devel] [qemu-web PATCH] Add "Understanding QEMU devices" blog post

2018-02-09 Thread Eric Blake
Last July, Eric Blake wrote a nice summary for newcomers about what QEMU has to do to emulate devices for the guests. So far, we missed integratating this somewhere into the QEM web site or wiki, so let's publish this now as a nice blog post for the users. Signed-off-by: Thomas Huth Message-Id: <

[Qemu-devel] [PATCH v1 3/3] cpus: CPU threads are always created initially for one CPU only

2018-02-09 Thread David Hildenbrand
It can never happen for single-threaded TCG that we have more than one CPU in the list, while the first one has not been marked as "created". Signed-off-by: David Hildenbrand --- cpus.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/cpus.c b/cpus.c index 22ab15840f..

[Qemu-devel] [PATCH v1 1/3] cpus: properly inititalize CPU > 1 under single-threaded TCG

2018-02-09 Thread David Hildenbrand
All but the first CPU are currently not fully inititalized (e.g. cpu->created is never set). Signed-off-by: David Hildenbrand --- cpus.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cpus.c b/cpus.c index f298b659f4..ade1651032 100644 --- a/cpus.c +++ b/cpus.c @@ -1863,6 +1863,9 @@ stat

[Qemu-devel] [PATCH v1 2/3] cpus: wait for CPU creation at central place

2018-02-09 Thread David Hildenbrand
We can now also wait for the CPU creation for single-threaded TCG, so we can move the waiting bits further out. Signed-off-by: David Hildenbrand --- cpus.c | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/cpus.c b/cpus.c index ade1651032..22ab15840f 100

[Qemu-devel] [PATCH v1 0/3] cpus: single-threaded TCG CPU creation improvements

2018-02-09 Thread David Hildenbrand
While looking into CPU hotplug for s390x TCG, I noticed that single-threaded TCG does not properly inititalize CPUs > 1. Fix this and cleanup the code a bit. David Hildenbrand (3): cpus: properly inititalize CPU > 1 under single-threaded TCG cpus: wait for CPU creation at central place cpus:

[Qemu-devel] [Bug 1738283] Re: 'Less than' (<), 'more than' (>), and 'pipe' (|) can't be typed via VNC

2018-02-09 Thread Brian Rak
We ran into this as well, using qemu 2.11.0. We're not using the "-k en-us" command line flag, and we're using noVNC as a client (which supports the QEMUExtendedKeyEvent encoding) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https

Re: [Qemu-devel] [PATCH] net: fix misaligned member access

2018-02-09 Thread Philippe Mathieu-Daudé
Hi Marc-André, On 02/09/2018 04:03 PM, Marc-André Lureau wrote: > Fixes the following ASAN warnings: > > /home/elmarco/src/qemu/hw/net/net_tx_pkt.c:201:27: runtime error: member > access within misaligned address 0x63128846 for type 'struct ip_header', > which requires 4 byte alignment > 0x

Re: [Qemu-devel] [PATCH v5 00/23] RISC-V QEMU Port Submission

2018-02-09 Thread Richard Henderson
On 02/07/2018 05:28 PM, Michael Clark wrote: > create mode 100644 hw/riscv/Makefile.objs > create mode 100644 hw/riscv/riscv_elf.c > create mode 100644 hw/riscv/riscv_hart.c > create mode 100644 hw/riscv/riscv_htif.c > create mode 100644 hw/riscv/sifive_clint.c > create mode 100644 hw/riscv/s

Re: [Qemu-devel] [PATCH v5 12/23] RISC-V HTIF Console

2018-02-09 Thread Richard Henderson
On 02/09/2018 01:08 AM, Michael Clark wrote: > https://github.com/michaeljclark/riscv-qemu/commit/17272f5c66adf8532f196d660d2a593c2178ac95 > >  hw/core/loader.c     |   18 -- >  include/hw/elf_ops.h |   28 >  include/hw/loader.h  |   17

[Qemu-devel] [PATCH] dump: Show custom message for ENOSPC

2018-02-09 Thread Yasmin Beatriz
This patch intends to make a more specific message for when the system has not enough space to save guest memory. Reported-by: yilzh...@redhat.com Cc: Jose Ricardo Ziviani Signed-off-by: Yasmin Beatriz --- dump.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/dump.c

Re: [Qemu-devel] [PATCHv2 00/12] cuda: various fixes, tidy-ups, and move 6522 to separate device

2018-02-09 Thread Mark Cave-Ayland
On 09/02/18 19:12, no-re...@patchew.org wrote: Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180209185142.17151-1-mark.cave-ayl...@ilande.co.uk Subject: [Qemu-devel] [PATCHv2 00/12] cuda: various fixes, tidy-ups, and

[Qemu-devel] QEMU leaves pidfile behind on exit

2018-02-09 Thread Shaun Reitan
QEMU leaves the pidfile behind on a clean exit when using the option -pidfile /var/run/qemu.pid. Should QEMU leave it behind or should it clean up after itself? I'm willing to take a crack at a patch to fix the issue, but before I do, I want to make sure that leaving the pidfile behind was not

[Qemu-devel] [PULL 2/2] block: Simplify bdrv_can_write_zeroes_with_unmap()

2018-02-09 Thread Eric Blake
We don't need the can_write_zeroes_with_unmap field in BlockDriverInfo, because it is redundant information with supported_zero_flags & BDRV_REQ_MAY_UNMAP. Note that BlockDriverInfo and supported_zero_flags are both per-device settings, rather than global state about the driver as a whole, which m

Re: [Qemu-devel] [PATCHv2 00/12] cuda: various fixes, tidy-ups, and move 6522 to separate device

2018-02-09 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180209185142.17151-1-mark.cave-ayl...@ilande.co.uk Subject: [Qemu-devel] [PATCHv2 00/12] cuda: various fixes, tidy-ups, and move 6522 to separate device === TEST SCRIPT BE

[Qemu-devel] [PULL 1/2] iotests: 205: support luks format

2018-02-09 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Support default luks options in VM.add_drive and in new library function qemu_img_create. Use it in 205 iotests. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20180206182507.21753-1-vsement...@virtuozzo.com> Reviewed-by: Daniel P. Berrange Signed-o

[Qemu-devel] [PATCH] net: fix misaligned member access

2018-02-09 Thread Marc-André Lureau
Fixes the following ASAN warnings: /home/elmarco/src/qemu/hw/net/net_tx_pkt.c:201:27: runtime error: member access within misaligned address 0x63128846 for type 'struct ip_header', which requires 4 byte alignment 0x63128846: note: pointer points here 01 00 00 00 45 00 01 a9 01 00 00 00

[Qemu-devel] [PULL 0/2] NBD patches through 2018-02-09

2018-02-09 Thread Eric Blake
The following changes since commit c7b02d7d032d6022060e4b393827c963c93ce63f: Merge remote-tracking branch 'remotes/stsquad/tags/pull-travis-speedup-090218-1' into staging (2018-02-09 16:12:34 +) are available in the Git repository at: git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2018-

[Qemu-devel] [PATCHv2 10/12] cuda: convert to use the shared mos6522 device

2018-02-09 Thread Mark Cave-Ayland
Add the relevant hooks as required for the MacOS timer calibration and delayed SR interrupt. Signed-off-by: Mark Cave-Ayland --- hw/misc/macio/cuda.c | 606 ++- hw/ppc/mac.h | 87 2 files changed, 204 insertions(+), 489 deletions(

[Qemu-devel] [PATCHv2 11/12] ppc: move CUDAState and other CUDA-related definitions into separate cuda.h file

2018-02-09 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- hw/misc/macio/cuda.c | 1 + hw/misc/macio/macio.c| 1 + hw/ppc/mac.h | 77 --- include/hw/misc/macio/cuda.h | 107 +++ 4 files changed, 109 insertions(+), 7

[Qemu-devel] [PATCHv2 05/12] cuda: rename frequency property to tb_frequency

2018-02-09 Thread Mark Cave-Ayland
This allows us to more easily differentiate between the timebase frequency used to calibrate the MacOS timers and the actual frequency of the hardware clock as indicated by CUDA_TIMER_FREQ. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/misc/macio/cuda.c | 10 +-

[Qemu-devel] [PATCHv2 08/12] cuda: factor out timebase-derived counter value and load time

2018-02-09 Thread Mark Cave-Ayland
Commit b981289c49 "PPC: Cuda: Use cuda timer to expose tbfreq to guest" altered the timer calculations from those based upon the hardware CUDA clock frequency to those based upon the CPU timebase frequency. In fact we can isolate the differences to 2 simple changes: one to the counter read value a

[Qemu-devel] [PATCHv2 09/12] misc: introduce new mos6522 VIA device and enable it for ppc builds

2018-02-09 Thread Mark Cave-Ayland
The MOS6522 VIA forms the bridge part of several Mac devices, including the Mac via-cuda and via-pmu devices. Introduce a standard mos6522 device that can be shared amongst multiple implementations. This is effectively taking the 6522 parts out of cuda.c and turning them into a separate device whi

[Qemu-devel] [PATCHv2 04/12] cuda: introduce CUDAState parameter to get_counter()

2018-02-09 Thread Mark Cave-Ayland
This will be required shortly and also happens to match nicely with the corresponding signature for set_counter(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/misc/macio/cuda.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/misc/

[Qemu-devel] [PATCHv2 07/12] cuda: set timer 1 frequency property to CUDA_TIMER_FREQ

2018-02-09 Thread Mark Cave-Ayland
Now that we have successfully decoupled the timebase frequency and the hardware timer frequency, set the timer 1 frequency property to CUDA_TIMER_FREQ and alter get_next_irq_time() to use it rather than the hard-coded constant. In addition to this we must now switch the tb_diff calculation over to

[Qemu-devel] [PATCHv2 12/12] cuda: convert to trace-events

2018-02-09 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- Makefile.objs | 1 + hw/misc/macio/cuda.c | 50 -- hw/misc/macio/trace-events | 11 ++ 3 files changed, 29 insertions(+), 33 deletions(-) create mode 100644 hw/misc/macio/trace-events dif

[Qemu-devel] [PATCHv2 03/12] cuda: don't call cuda_update() when writing to ACR register

2018-02-09 Thread Mark Cave-Ayland
The wire protocol for reading data to/from the VIA is triggered by changing inputs on port B rather than changing the timer configuration via the ACR. Signed-off-by: Mark Cave-Ayland --- hw/misc/macio/cuda.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/misc/macio/cuda.c b/hw/misc/macio/

[Qemu-devel] [PATCHv2 06/12] cuda: minor cosmetic tidy-ups to get_next_irq_time()

2018-02-09 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/misc/macio/cuda.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/hw/misc/macio/cuda.c b/hw/misc/macio/cuda.c index 232b7f61aa..408858e688 100644 --- a/hw/misc/macio/cuda.c ++

[Qemu-devel] [PATCHv2 00/12] cuda: various fixes, tidy-ups, and move 6522 to separate device

2018-02-09 Thread Mark Cave-Ayland
The Mac CUDA device (also known as via-cuda) consists of two parts: a 6522 VIA acting as an interface chip and the CUDA device itself. Currently there are at least 2 other upcoming Mac devices that include their own 6522 VIA implementations: Ben's via-pmu device and Laurent's mac_via device with t

[Qemu-devel] [PATCHv2 01/12] cuda: do not use old_mmio accesses

2018-02-09 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- hw/misc/macio/cuda.c | 40 1 file changed, 8 insertions(+), 32 deletions(-) diff --git a/hw/misc/macio/cuda.c b/hw/misc/macio/cuda.c index 008d8bd4d5..6631017ca2 100644 --- a/hw/misc/macio/cuda.c +++ b/hw/misc/macio/cud

[Qemu-devel] [PATCHv2 02/12] cuda: don't allow writes to port output pins

2018-02-09 Thread Mark Cave-Ayland
Use the direction registers as a mask to ensure that only input pins are updated upon write. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé --- hw/misc/macio/cuda.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/

Re: [Qemu-devel] [PATCH 1/1] hw/ppc: rename functions in comments

2018-02-09 Thread Philippe Mathieu-Daudé
On 02/09/2018 03:13 PM, Daniel Henrique Barboza wrote: > Commit bcb5ce08cf ("spapr: Rename machine init functions for clarity") > renamed ppc_spapr_reset to spapr_machine_reset and ppc_spapr_init > to spapr_machine_init. Let's also rename the references in > comments. > > Signed-off-by: Daniel Hen

Re: [Qemu-devel] [PATCH 10/27] qcow2: Use visitor for options in qcow2_create()

2018-02-09 Thread Max Reitz
On 2018-02-08 20:23, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 219 > - > tests/qemu-iotests/049.out | 8 +- > tests/qemu-iotests/112.out | 4 +- > 3 files changed, 84 insertions(+), 147 deletions(-) Review

Re: [Qemu-devel] [PATCH v2 32/32] arm/translate-a64: add all single op FP16 to handle_fp_1src_half

2018-02-09 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > This includes FMOV, FABS, FNEG, FSQRT and FRINT[NPMZAXI]. We re-use > existing helpers to achieve this. > > Signed-off-by: Alex Bennée > --- > target/arm/translate-a64.c | 72 > ++ > 1 file changed, 72 ins

Re: [Qemu-devel] [PATCH v2] qmp: add query-cpus-fast

2018-02-09 Thread Luiz Capitulino
On Fri, 9 Feb 2018 15:50:00 +0100 Viktor Mihajlovski wrote: > On 09.02.2018 15:27, Eduardo Habkost wrote: > [...] > >> I'm keeping it mainly for s390. Viktor, libvirt is still using > >> this field in s390, no? > >> > >> Dropping halted and having management software still using query-cpus > >> b

Re: [Qemu-devel] [PATCH v2 31/32] arm/translate-a64: implement simd_scalar_three_reg_same_fp16

2018-02-09 Thread Richard Henderson
On 02/08/2018 09:31 AM, Alex Bennée wrote: > This covers the encoding group: > > Advanced SIMD scalar three same FP16 > > As all the helpers are already there it is simply a case of calling the > existing helpers in the scalar context. > > Signed-off-by: Alex Bennée > > --- > v2 > - checkp

[Qemu-devel] [PATCH 1/2] 9p: v9fs_path_copy() readability

2018-02-09 Thread Marc-André Lureau
lhs/rhs doesn't tell much about how argument are handled, dst/src is and const arguments is clearer in my mind. Use g_memdup() while at it. Signed-off-by: Marc-André Lureau --- hw/9pfs/9p.h | 2 +- hw/9pfs/9p.c | 9 - 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/9pfs

[Qemu-devel] [PATCH 2/2] 9p: fix leak in synth_name_to_path()

2018-02-09 Thread Marc-André Lureau
Leak found thanks to ASAN: Direct leak of 8 byte(s) in 1 object(s) allocated from: #0 0x55995789ac90 in __interceptor_malloc (/home/elmarco/src/qemu/build/x86_64-softmmu/qemu-system-x86_64+0x1510c90) #1 0x7f0a91190f0c in g_malloc /home/elmarco/src/gnome/glib/builddir/../glib/gmem.c:94

Re: [Qemu-devel] [PATCH v7 17/26] target/i386: encrypt bios rom

2018-02-09 Thread Dr. David Alan Gilbert
* Brijesh Singh (brijesh.si...@amd.com) wrote: > SEV requires that guest bios must be encrypted before booting the guest. I'm curious; is it just the main BIOS that needs encryption - what about things like device/PXE rom images? Dave > > Cc: "Michael S. Tsirkin" > Cc: Paolo Bonzini > Cc: Ric

  1   2   3   4   >