On 12/02/2018 18:30, Vladimir Sementsov-Ogievskiy wrote:
> 18.01.2018 13:09, Paolo Bonzini wrote:>> We have three cases:
>>
>> 1) monitor creates and destroy bitmaps.
>>
>> 2) monitor also has to read the list. We know it operates with BQL.
>>
>> 3) users such as mirror.c create a dirty bitmap in
On 02/12/2018 03:40 PM, Benjamin Herrenschmidt wrote:
> On Mon, 2018-02-12 at 13:20 +0100, Andrea Bolognani wrote:
>> On Mon, 2018-02-12 at 13:02 +1100, Alexey Kardashevskiy wrote:
>>> On 12/02/18 09:55, Benjamin Herrenschmidt wrote:
Well, we have a problem then. It looks like Qemu broken migr
To be used to decode ARM SVE, but could be used for any fixed-width ISA.
Signed-off-by: Richard Henderson
---
Changes since v2:
* Fix tests/decode/err_init3.def.
* Mark main decoder static by default.
* Properly diagnose unspecified bits.
* Remove output file on error.
- I had been
Fixes --disable-vnc build failure.
Signed-off-by: Gerd Hoffmann
---
ui/vnc-stubs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ui/vnc-stubs.c b/ui/vnc-stubs.c
index f51280549a..06c4ac6296 100644
--- a/ui/vnc-stubs.c
+++ b/ui/vnc-stubs.c
@@ -1,5 +1,6 @@
#include "qemu/osdep.h"
#include
Your command line looks wrong, because you forgot –icount, but specified other
replay options.
I tried recording and replaying with your command line and the execution hangs
at some moment of replay.
The problem may be hidden in –dtb option, because it may add the devices
without configuring r
On Mon, Feb 12, 2018 at 5:47 AM, Pavel Dovgalyuk wrote:
> I tested ARM only with –kernel and –initrd.
>
> Can you provide the full command line and the disk image?
>
>
>
The command I tried was:
time ./buildroot/output.arm~/host/usr/bin/qemu-system-arm -M versatilepb
-append 'root=/dev/sda noka
On Fri, Feb 09, 2018 at 06:55:03PM +1100, Alexey Kardashevskiy wrote:
> This adds a possibility for the platform to tell VFIO not to emulate MSIX
> so MMIO memory regions do not get split into chunks in flatview and
> the entire page can be registered as a KVM memory slot and make direct
> MMIO acc
On Fri, Feb 09, 2018 at 06:55:02PM +1100, Alexey Kardashevskiy wrote:
> At the moment we unconditionally avoid mapping MSIX data of a BAR and
> emulate MSIX table in QEMU. However it is 1) not always necessary as
> a platform may prodive a paravirt interface for MSIX configuration;
> 2) can affect
On Tue, Feb 13, 2018 at 04:36:30PM +1100, David Gibson wrote:
> On Tue, Feb 13, 2018 at 12:15:52PM +1100, Alexey Kardashevskiy wrote:
> > On 13/02/18 03:06, Alex Williamson wrote:
> > > On Mon, 12 Feb 2018 18:05:54 +1100
> > > Alexey Kardashevskiy wrote:
> > >
> > >> On 12/02/18 16:19, David Gibs
On Tue, Feb 13, 2018 at 12:15:52PM +1100, Alexey Kardashevskiy wrote:
> On 13/02/18 03:06, Alex Williamson wrote:
> > On Mon, 12 Feb 2018 18:05:54 +1100
> > Alexey Kardashevskiy wrote:
> >
> >> On 12/02/18 16:19, David Gibson wrote:
> >>> On Fri, Feb 09, 2018 at 06:55:01PM +1100, Alexey Kardashev
On Mon, Feb 12, 2018 at 12:11:27PM +0100, Greg Kurz wrote:
> On Sat, 10 Feb 2018 20:23:07 +1100
> David Gibson wrote:
>
> > On Fri, Feb 09, 2018 at 03:06:49PM +0100, Greg Kurz wrote:
> > > On Fri, 9 Feb 2018 09:18:58 +0100
> > > Laurent Vivier wrote:
> > >
> > > > We ignore silently the valu
g_free() was moved from vhost_net_cleanup in commit e6bcb1b, so we should
free net after vhost_net_cleanup
Signed-off-by: linzhecheng
diff --git a/net/vhost-user.c b/net/vhost-user.c
index cb45512506..d024573e45 100644
--- a/net/vhost-user.c
+++ b/net/vhost-user.c
@@ -109,6 +109,7 @@ static int
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sd/sdhci-internal.h | 9 +
hw/sd/sdhci.c | 14 ++
2 files changed, 23 insertions(+)
diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-internal.h
index 0092627076..e1bb733aed 100644
--- a/hw/sd/sdhci-internal.h
+++ b/hw/sd
On 02/13/2018 01:16 AM, linzhecheng wrote:
>> -邮件原件-
>> 发件人: Philippe Mathieu-Daudé [mailto:philippe.mathieu.da...@gmail.com]
>> 代表 Philippe Mathieu-Daudé
>> 发送时间: 2018年2月13日 11:54
>> 收件人: linzhecheng ; qemu-devel@nongnu.org
>> 抄送: pbonz...@redhat.com; wangxin (U) ;
>> lidonglin ; m...@redh
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Alistair Francis
---
hw/arm/fsl-imx6.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/hw/arm/fsl-imx6.c b/hw/arm/fsl-imx6.c
index e6559a8b12..b6ac72de27 100644
--- a/hw/arm/fsl-imx6.c
+++ b/hw/arm/fsl-imx6.c
@@ -27,6 +27,8 @@
#include
[based on a patch from Alistair Francis
from qemu/xilinx tag xilinx-v2015.2]
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
---
hw/sd/sdhci-internal.h | 2 ++
include/hw/sd/sd.h | 4
hw/sd/core.c | 34 ++
hw/sd/sd.c
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Alistair Francis
---
tests/sdhci-test.c | 12
tests/Makefile.include | 1 +
2 files changed, 13 insertions(+)
diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c
index 898c43ff4f..39d0f87788 100644
--- a/tests/sdhci-test.c
+++ b
On 02/11/2018 05:39 PM, Richard Henderson wrote:
> Convert multiplication by power of two to left shift.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
> ---
> tcg/tcg-op.c | 24 ++--
> 1 file changed, 18 insertions(+), 6 deletions(-)
>
> diff --
see the Xilinx datasheet "UG1085" (v1.7)
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
---
hw/arm/xlnx-zynqmp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
index e39ad73bec..4b93a3abd2 100644
--- a/hw/arm/xlnx-zynqmp.c
++
[based on a patch from Alistair Francis
from qemu/xilinx tag xilinx-v2015.2]
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
---
hw/sd/sdhci-internal.h | 10 ++
include/hw/sd/sdhci.h | 1 +
hw/sd/sdhci.c | 22 +++---
3 files changed, 30 in
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Stefan Hajnoczi
---
tests/sdhci-test.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c
index 39d0f87788..c0b45da88a 100644
--- a/tests/sdhci-test.c
+++ b/tests/sdhci-test.c
@@ -16,6
following the datasheet.
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Alistair Francis
---
hw/arm/bcm2835_peripherals.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c
index ca971e83e0..13b63970d7 100644
--- a/hw
checking Xilinx datasheet "UG585" (v1.12.1)
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
---
hw/arm/xilinx_zynq.c | 53
tests/sdhci-test.c | 5 +
2 files changed, 34 insertions(+), 24 deletions(-)
diff --git a/h
> -邮件原件-
> 发件人: Philippe Mathieu-Daudé [mailto:philippe.mathieu.da...@gmail.com]
> 代表 Philippe Mathieu-Daudé
> 发送时间: 2018年2月13日 11:54
> 收件人: linzhecheng ; qemu-devel@nongnu.org
> 抄送: pbonz...@redhat.com; wangxin (U) ;
> lidonglin ; m...@redhat.com
> 主题: Re: [Qemu-devel] [PATCH] vhost-user
As per the Spec v3.00
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
---
include/hw/sd/sdhci.h | 2 +-
hw/sd/sdhci.c | 18 +-
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/include/hw/sd/sdhci.h b/include/hw/sd/sdhci.h
index 2a26b4
We only set a 32-bit value, but this is a good practice in case this
code is used as reference.
(missed in 5efc9016e52)
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
---
hw/arm/exynos4210.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/exynos4
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
---
hw/arm/bcm2835_peripherals.c | 21 +
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c
index 12e0dd11af..ca971e83e0 100644
--- a/hw
checking Xilinx datasheet "UG1085" (v1.7)
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
---
hw/arm/xlnx-zynqmp.c | 29 ++---
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
index ca398c4159
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Alistair Francis
---
hw/arm/exynos4210.c | 12
1 file changed, 12 insertions(+)
diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c
index d89322c7ea..06f9d1ffa4 100644
--- a/hw/arm/exynos4210.c
+++ b/hw/arm/exynos4210.c
@@ -377,6 +
Incorrect value will throw an error.
Note than Spec v2 is supported by default.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
---
hw/sd/sdhci-internal.h | 22 ++-
hw/sd/sdhci.c | 99 +-
hw/sd/trace-events
[based on a patch from Alistair Francis
from qemu/xilinx tag xilinx-v2015.2]
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
---
include/hw/sd/sd.h| 16
include/hw/sd/sdhci.h | 1 +
hw/sd/core.c | 13 +
hw/sd/sd.c| 13 +
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
---
hw/sd/core.c | 14 --
hw/sd/trace-events | 5 +
2 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/sd/core.c b/hw/sd/core.c
index 295dc44ab7..498284f109 100644
--- a/hw/sd/core.c
+++ b/
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Stefan Hajnoczi
---
tests/sdhci-test.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c
index 51af5eac67..d6eb3c3a48 100644
--- a/tests/sdhci-test.c
+++ b/tests/sdhci-test.c
@@ -14,6 +14
using many #defines is not portable when scaling to different HCI.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
---
hw/sd/sdhci.c | 74 +--
1 file changed, 16 insertions(+), 58 deletions(-)
diff --git a/hw/sd/sdhci.
From: Sai Pavan Boddu
The 64-bit ADMA address is not converted to the cpu endianes correctly.
This patch fixes the issue and uses a valid mask for the attribute data.
Signed-off-by: Sai Pavan Boddu
[AF: Re-write commit message]
Reviewed-by: Alistair Francis
---
hw/sd/sdhci.c | 4 ++--
1 file
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
---
hw/sd/sdhci-internal.h | 4 ++--
include/hw/sd/sdhci.h | 2 ++
hw/sd/sdhci.c | 27 +++
3 files changed, 27 insertions(+), 6 deletions(-)
diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
---
hw/sd/sdhci-internal.h | 4 +++-
hw/sd/sdhci.c | 20 +---
2 files changed, 8 insertions(+), 16 deletions(-)
diff --git a/hw/sd/sdhci-internal.h b/hw/sd/sdhci-internal.h
index 64556480a9..def1c7f7aa
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Stefan Hajnoczi
---
tests/sdhci-test.c | 24
1 file changed, 24 insertions(+)
diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c
index 7c50c0482b..24feea744a 100644
--- a/tests/sdhci-test.c
+++ b/tests/sdhci-test.c
@@
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Stefan Hajnoczi
---
tests/sdhci-test.c | 24
1 file changed, 24 insertions(+)
diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c
index 82f3785a72..51af5eac67 100644
--- a/tests/sdhci-test.c
+++ b/tests/sdhci-test.c
@@
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Stefan Hajnoczi
---
tests/sdhci-test.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/tests/sdhci-test.c b/tests/sdhci-test.c
index d6eb3c3a48..7c50c0482b 100644
--- a/tests/sdhci-test.c
+++ b/tests/sdhci-test.c
@@ -15,6 +15,7
The PCI model is tested with the pc/x86_64 machine,
the SysBus model with the smdkc210/arm machine.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Paolo Bonzini
---
tests/sdhci-test.c | 145 +
tests/Makefile.include | 3 +
2 files change
This series includes the last versions of both series:
- SDHCI: clean v1/v2 Specs (part 2)
- SDHCI: add tuning sequence for UHS-I cards (part 3)
Since v12:
- rebased...
- bcc'ing patchew, spaming others
Since v11:
- rebased due to conflict (IMX_USDHC fd1e5c817964)
- QSDHCI uses union (Paolo)
- do
avoid the "errp && *errp" pattern (not recommended in "qapi/error.h" comments).
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
---
hw/sd/sdhci.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index ee95e78aeb..36022
On Mon, Feb 12, 2018 at 04:03:38PM +, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> This fixes a crash for the case where a migration exits with an error
> very early, this is probably due to my recent error handling change.
>
> I also add a test to make sure this
Hi Linzhecheng,
On 02/12/2018 11:53 PM, linzhecheng wrote:
> fix memory leak
>
> Signed-off-by: linzhecheng
>
> diff --git a/net/vhost-user.c b/net/vhost-user.c
> index cb45512506..d024573e45 100644
> --- a/net/vhost-user.c
> +++ b/net/vhost-user.c
> @@ -109,6 +109,7 @@ static int vhost_user_st
On Fri, Feb 09, 2018 at 08:49:45AM +0100, David Engraf wrote:
> Hello David,
>
> Am 09.02.2018 um 06:33 schrieb David Gibson:
> > On Thu, Feb 08, 2018 at 09:36:21AM +0100, David Engraf wrote:
> > > This patch fixes an incorrect behavior when the -kernel argument has been
> > > specified without -b
fix memory leak
Signed-off-by: linzhecheng
diff --git a/net/vhost-user.c b/net/vhost-user.c
index cb45512506..d024573e45 100644
--- a/net/vhost-user.c
+++ b/net/vhost-user.c
@@ -109,6 +109,7 @@ static int vhost_user_start(int queues, NetClientState
*ncs[], CharBackend *be)
err:
if (net) {
Unsure the scope of this bug or the proper fix, so bringing it up here
first.
gdbstub.c:gdb_read_register will return 0, and thus E14, when a remote gdb
tries to call a function in the exposed linux kernel. This appears to be
because the caller expects to be able to receive a generic register siz
From: Paolo Bonzini
1) string not null terminated in sysfs_find_group_file
2) NULL pointer dereference and dead local variable in nvme_init.
Signed-off-by: Paolo Bonzini
Signed-off-by: Fam Zheng
---
v2: Fix error path.
---
block/nvme.c| 10 +++---
util/vfio-helpers.c | 2 +-
2
Quoting Michael Roth (2018-02-06 13:14:21)
> Hi everyone,
>
>
> The following new patches are queued for QEMU stable v2.11.1:
>
> https://github.com/mdroth/qemu/commits/stable-2.11-staging
>
> The re
On Mon, 02/12 15:00, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> Reviewed-by: Alistair Francis
Hmm.. Something is going weird here. It's still not in the archive
https://lists.gnu.org/archive/html/qemu-devel/2018-02/threads.html
So I manually bounced it to impor...@
On 13/02/18 03:06, Alex Williamson wrote:
> On Mon, 12 Feb 2018 18:05:54 +1100
> Alexey Kardashevskiy wrote:
>
>> On 12/02/18 16:19, David Gibson wrote:
>>> On Fri, Feb 09, 2018 at 06:55:01PM +1100, Alexey Kardashevskiy wrote:
At the moment if vfio_memory_listener is registered in the syst
On 13/02/18 01:40, Benjamin Herrenschmidt wrote:
> On Mon, 2018-02-12 at 13:20 +0100, Andrea Bolognani wrote:
>> On Mon, 2018-02-12 at 13:02 +1100, Alexey Kardashevskiy wrote:
>>> On 12/02/18 09:55, Benjamin Herrenschmidt wrote:
Well, we have a problem then. It looks like Qemu broken migration
On 12/02/2018 19:46, Philippe Mathieu-Daudé wrote:
> Travis image is based on Ubuntu Trusty (14.04), since d83414e1fd1 we get:
>
> $ sudo -E \
> apt-get -yq --no-install-suggests --no-install-recommends --force-yes \
> install \
> libaio-dev libattr1-dev libbrlapi-dev libcap-ng
On 02/11/2018 03:36 AM, Markus Armbruster wrote:
We used to generate first test and later QGA QAPI code into
qapi-generated/. Commit b93b63f574 moved the test code to tests/.
Commit 54c2e50205 moved the QGA code to qga/qapi-generated/. The
directory has been unused since.
Signed-off-by: Markus
On 02/11/2018 03:36 AM, Markus Armbruster wrote:
Fix up the reference to qmp-commands.hx in qmp.c. Missed in commit
5032a16d1d.
Fix up the reference to qmp-commands.txt in
docs/xen-save-devices-state.txt. Missed in commit 4d8bb958fa.
Signed-off-by: Markus Armbruster
---
docs/xen-save-devic
On Sun, Feb 11, 2018 at 12:39:34 -0800, Richard Henderson wrote:
> Convert multiplication by power of two to left shift.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Emilio G. Cota
Thanks,
Emilio
On 02/11/2018 03:36 AM, Markus Armbruster wrote:
Move qapi-schema.json to qapi/, so it's next to its modules, and all
files get generated to qapi/, not just the ones generated for modules.
Consistently name the generated files qapi-MODULE.EXT:
qmp-commands.[ch] become qapi-commands.[ch], qapi-ev
Allow write operations on behalf of the initiator. The
precursor to write is the sending of the write metadata
that consists of the ObjectInfo dataset. This patch introduces
a flag that is set when the responder is ready to receive
write data based on a previous SendObjectInfo operation by
the init
On 02/11/2018 03:36 AM, Markus Armbruster wrote:
* Fix guidance on error classes
* Point to generated documentation
* Drop plea for documentation, because the QAPI code generator
enforces it since commit 3313b6124b
* Minor tweaks here and there
Signed-off-by: Markus Armbruster
---
docs/
The response to a SendObjectInfo consists of the storageid,
parent obejct handle and the handle reserved for the new
incoming object
Signed-off-by: Bandan Das
---
hw/usb/dev-mtp.c | 50 +++---
1 file changed, 27 insertions(+), 23 deletions(-)
diff --g
s-speedup-090218-1' into staging
> > (2018-02-09 16:12:34 +)
> >
> > are available in the Git repository at:
> >
> > git://github.com/dgibson/qemu.git tags/ppc-for-2.12-20180212
> >
> > for you to fetch changes up to 51f233ec92cdab7030cb7407dd
Write of existing objects by the initiator is acheived by
making a temporary buffer with the new changes, deleting the
old file and then writing a new file with the same name.
Advertise delete support and mark the store READ/WRITE since
some initiators will fail the operation if the store is marked
v2:
3/5: Set mtp store flag to read only
4/5: Fix compiler warnings and change default file permissions
5/5: Fix file permissions
These patches implement write support for Qemu's MTP
emulation. Simple tests such as delete/move/edit/copy work ok.
Current issues/TODO:
- File transfers > 4GB
This patch implements a dummy ObjectInfo structure so that
it's easy to typecast the incoming data. If the metadata is
valid, write_pending is set. Also, the incoming filename
is utf-16, so, instead of depending on external libraries, just
implement a simple function to get the filename
Signed-off
Fix a possible null dereference when deleting a folder and
its contents. An ignored event might be received for its contents
after the parent folder is deleted which will return a null object.
Signed-off-by: Bandan Das
---
hw/usb/dev-mtp.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(
On 02/11/2018 03:36 AM, Markus Armbruster wrote:
With modular code generation, putting stuff right into
qapi-schema.json is a bad idea. Update writing-qmp-commands.txt
accordingly.
Signed-off-by: Markus Armbruster
---
docs/devel/writing-qmp-commands.txt | 14 +++---
1 file changed,
On 02/11/2018 03:36 AM, Markus Armbruster wrote:
The previous commit improved compile time by including less of the
generated QAPI headers. This is impossible for stuff defined directly
in qapi-schema.json, because that ends up in headers that that pull in
everything.
Move everything but includ
On 12/02/2018 20:30, Thomas Huth wrote:
> On 12.02.2018 15:42, klim wrote:
> [...]
>> I just have reverted my 2 commits and
>>
>> after that make check -j32 hangs
>>
>> with
>>
>> GTester: last random seed: R02Sb95a3bf6ab4c05540cec188081a7cc2a
>>
>> in vhost-user-test
>>
>> so it is not my fault
>
On 02/11/2018 03:36 AM, Markus Armbruster wrote:
In my "build everything" tree, a change to the types in
qapi-schema.json triggers a recompile of about 4800 out of 5100
objects.
The previous commit split up qmp-commands.h, qmp-event.h, qmp-visit.h,
qapi-types.h. Each of these headers still incl
On 02/11/2018 03:36 AM, Markus Armbruster wrote:
Our qapi-schema.json is composed of modules connected by include
directives, but the generated code is monolithic all the same: one
qapi-types.h with all the types, one qapi-visit.h with all the
visitors, and so forth. These monolithic headers get
Public bug reported:
When converting a VMDK to VHDX the resulting VHDX's Region table has a
small error. According to the VHDX specification the BAT and Metadata
entries for the region header required bit should be set to 1. In a
VHDX created by qemu-img, this bit is not set.
See Table 4: Known
On 02/11/2018 03:35 AM, Markus Armbruster wrote:
Linking code from multiple separate QAPI schemata into the same
program is possible, but involves some weirdness around built-in
types:
* We generate code for built-in types into .c only with option
--builtins. The user is responsible for gene
On Mon, Feb 12, 2018 at 03:07:26PM -0600, Brijesh Singh wrote:
> In current implementation, when -cpu ...,+sev is passed without
> appropriate SEV configuration then we populate the Fn8000_001F CPUID but
> VMCB will not have SEV bit set hence a guest will be launched as
> non-SEV.
I think we shoul
On 2/12/18 12:38 PM, Eduardo Habkost wrote:
> On Mon, Feb 12, 2018 at 09:36:52AM -0600, Brijesh Singh wrote:
>> AMD EPYC processors support memory encryption feature. The feature
>> is reported through CPUID 8000_001F[EAX].
>>
>> Fn8000_001F [EAX]:
>> Bit 0 Secure Memory Encryption (SME) suppo
On 02/11/2018 03:35 AM, Markus Armbruster wrote:
The use of QAPIGen is rather shallow so far: most of the output
accumulation is not converted. Take the next step: convert output
accumulation in the code-generating visitor classes. Helper functions
outside these classes are not converted.
Sign
On Mon, Feb 12, 2018 at 04:53:40PM -0200, Eduardo Habkost wrote:
> The following changes since commit 8e3fb8029efaf220ab48290cdb5151c682227030:
>
> Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-fetch' into
> staging (2018-02-12 13:00:03 +)
>
> are available in the Git repo
On 02/11/2018 03:35 AM, Markus Armbruster wrote:
All generated .c are named like their .h, except for qmp-marshal.c and
qmp-commands.h. To add to the confusion, tests-qmp-commands.c falsely
matches generated test-qmp-commands.h.
Get rid of this unnecessary complication.
Yay for saner naming.
On 02/12/2018 03:46 PM, Kevin O'Connor wrote:
On Fri, Feb 09, 2018 at 03:19:31PM -0500, Stefan Berger wrote:
The PPI device in this patch series allocates 0x400 bytes. 0x200 bytes are
used by the OperationRegion() in this patch series. The rest was thought of
for future extensions.
To allow bot
On Fri, Feb 09, 2018 at 03:19:31PM -0500, Stefan Berger wrote:
> The PPI device in this patch series allocates 0x400 bytes. 0x200 bytes are
> used by the OperationRegion() in this patch series. The rest was thought of
> for future extensions.
>
> To allow both firmwares to use PPI, we would need to
On 12.02.2018 13:14, Viktor Mihajlovski wrote:
> From: Luiz Capitulino
>
> The query-cpus command has an extremely serious side effect:
> it always interrupts all running vCPUs so that they can run
> ioctl calls. This can cause a huge performance degradation for
> some workloads. And most of the
On 02/11/2018 03:35 AM, Markus Armbruster wrote:
The include directive permits modular QAPI schemata, but the generated
code is monolithic all the same. To permit generating modular code,
the front end needs to pass more information on inclusions to the back
ends. The commit before last added t
On 12.02.2018 13:14, Viktor Mihajlovski wrote:
> Presently s390x is the only architecture not exposing specific
> CPU information via QMP query-cpus. Upstream discussion has shown
> that it could make sense to report the architecture specific CPU
> state, e.g. to detect that a CPU has been stopped.
On 02/12/2018 12:48 PM, Daniel P. Berrangé wrote:
From: "Daniel P. Berrange"
qemu-io puts the TTY into non-canonical mode, which means no EOF processing is
done and thus getchar() will never return the EOF constant. Instead we have to
query the TTY attributes to determine the configured EOF cha
On 02/12/2018 12:34 PM, Dr. David Alan Gilbert (git) wrote:
From: "Dr. David Alan Gilbert"
The boot block used in the migration test is currently only
shipped as a hex (with the source in the git commit message),
Would be nice to point to commit ea0c6d62 (I assume that's the commit
message y
On 02/12/2018 02:45 PM, Kevin O'Connor wrote:
On Fri, Feb 09, 2018 at 03:19:31PM -0500, Stefan Berger wrote:
I have played around with this patch and some modifications to EDK2. Though
for EDK2 the question is whether to try to circumvent their current
implementation that uses SMM or use SMM. Wi
On 02/11/2018 03:35 AM, Markus Armbruster wrote:
The generators' conversion to visitors (merge commit 9e72681d16)
changed the processing order of entities from source order to
alphabetical order. The next commit needs source order, so change it
back.
Signed-off-by: Markus Armbruster
Reviewed-b
On 02/11/2018 03:35 AM, Markus Armbruster wrote:
The parse tree is a list of expressions. Except include expressions
currently get replaced by the included file's parse tree.
Instead of throwing away the include expression, keep it with the file
name expanded so you don't have to track the incl
Hi,
This series failed docker-quick@centos6 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180212185347.8433-1-ehabk...@redhat.com
Subject: [Qemu-devel] [PULL 0/7] machine/CPU qu
On 02/11/2018 03:35 AM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
---
scripts/qapi/common.py | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
Again, not much mention of 'why' in the commit message. But
centralizing the i
On 02/11/2018 03:35 AM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
---
scripts/qapi-gen.py| 8 ++--
scripts/qapi/common.py | 23 +--
tests/qapi-schema/test-qapi.py | 10 --
3 files changed, 2
On 02/11/2018 03:35 AM, Markus Armbruster wrote:
A massive number of objects depends on QAPI-generated headers. In my
"build everything" tree, it's roughly 4800 out of 5100. This is
particularly annoying when only some of the generated files change,
say for a doc fix.
Improve qapi-gen.py to to
On Fri, Feb 09, 2018 at 03:19:31PM -0500, Stefan Berger wrote:
> I have played around with this patch and some modifications to EDK2. Though
> for EDK2 the question is whether to try to circumvent their current
> implementation that uses SMM or use SMM. With this patch so far I circumvent
> it, whi
On 02/11/2018 03:35 AM, Markus Armbruster wrote:
argparse is nicer to use than getopt, and gives us --help almost for
free.
Signed-off-by: Markus Armbruster
---
scripts/qapi-gen.py| 48 ++--
scripts/qapi/common.py | 43 -
On 02/11/2018 03:35 AM, Markus Armbruster wrote:
Whenever qapi-schema.json changes, we run six programs eleven times to
update eleven files. Similar for qga/qapi-schema.json. This is
silly. Replace the six programs by a single program that spits out
all eleven files.
The programs become modul
On 02/11/2018 03:35 AM, Markus Armbruster wrote:
Each generator carries a copyright notice for the generator itself,
and another one for the files it generates. Only the former have been
updated along the way, the latter have not, and are all out of date.
Fix by copying the generator's copyrigh
On 02/12/2018 03:31 PM, Eric Blake wrote:
> On 02/12/2018 08:46 AM, Murilo Opsfelder Araujo wrote:
>> On 02/12/2018 12:25 PM, Daniel Henrique Barboza wrote:
>>> From: Yasmin Beatriz
>>>
>>> fd_write_vmcore can fail to execute for a lot of reasons that can be
>>> retrieved by errno, but it only ret
On 12.02.2018 15:42, klim wrote:
[...]
> I just have reverted my 2 commits and
>
> after that make check -j32 hangs
>
> with
>
> GTester: last random seed: R02Sb95a3bf6ab4c05540cec188081a7cc2a
>
> in vhost-user-test
>
> so it is not my fault
You're right. I've bisected the issue again, and th
On ARM, the MSI doorbell is translated by the virtual IOMMU.
As such address_space_translate() returns the MSI controller
MMIO region and we get an "iommu map to non memory area"
message. Let's remove this latter.
Signed-off-by: Eric Auger
---
hw/vfio/common.c | 2 --
1 file changed, 2 deletions
We implement the set_page_size_mask callback to allow the
virtio-iommu to be aware of any restrictions on the page size
mask due to an underlying HW IOMMU.
Signed-off-by: Eric Auger
---
hw/virtio/trace-events | 1 +
hw/virtio/virtio-iommu.c | 16
2 files changed, 17 insertion
1 - 100 of 312 matches
Mail list logo