Re: [Qemu-devel] [PATCH 8/9] iotests: add file_path helper

2018-02-19 Thread Jeff Cody
On Fri, Feb 16, 2018 at 02:46:35PM -0600, Eric Blake wrote: > On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: > >Simple way to have auto generated filenames with auto clenup. Like > > s/clenup/cleanup/ > > >FilePath but without using 'with' statement and without additional > >indentat

[Qemu-devel] [Bug 1734810] Re: Windows guest virtual PC running abnormally slow

2018-02-19 Thread Thomas Huth
Which command line parameters are passed to QEMU? Is your system able to use KVM (e.g. did you enable virtualization support in your BIOS)? ** Changed in: qemu Status: Confirmed => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscr

Re: [Qemu-devel] [RFC PATCH v6 00/20] replay additions

2018-02-19 Thread Pavel Dovgalyuk
> From: Pavel Dovgalyuk [mailto:dovga...@ispras.ru] > > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > > On 13 February 2018 at 10:26, Pavel Dovgalyuk wrote: > > > Then I added SCSI adapter with the option –device lsi,id=scsi0 and QEMU > > > failed with the following error: > > > > > > qe

Re: [Qemu-devel] [PATCH v6] ui/cocoa.m: Add ability for user to specify mouse ungrab key

2018-02-19 Thread Gerd Hoffmann
Hi, > > (b) Restrict allowed hotkeys to modifier key(s) plus one > >non-modifier key. Forwarding modifier keydown+keyup > >to the guest has typically effects inside the guest, > >so we only have to hold back that single non-modifier > >key. That is alot easier to implement. >

Re: [Qemu-devel] [qemu-s390x] [PATCH v7 05/12] s390-ccw: move auxiliary IPL data to separate location

2018-02-19 Thread Viktor Mihajlovski
On 17.02.2018 09:11, Thomas Huth wrote: [...] > > I still think that the information should *not* be stored within the > IplParameterBlock to avoid that we pass it via DIAG 0x308, too. > If we do it like this, I'm pretty sure that we will look at this code in > a couple of years and wonder whether

Re: [Qemu-devel] [PATCH v7] ui/cocoa.m: Add ability for user to specify mouse ungrab key

2018-02-19 Thread Gerd Hoffmann
Hi, > +/* Sends any keys that were delayed because they were part of the ungrab set > */ > +static void send_key_if_delayed(Set *the_set, int keycode) > +{ > +if (contains_number(the_set, keycode)) { > +qemu_input_event_send_key_qcode(dcl->con, keycode, true); > +qemu_input_

Re: [Qemu-devel] Qemu SDL2 bug

2018-02-19 Thread Gerd Hoffmann
On Mon, Feb 19, 2018 at 08:58:51AM +0100, Howard Spoelstra wrote: > On Mon, Feb 19, 2018 at 8:09 AM, Thomas Huth wrote: > > On 18.02.2018 11:11, Howard Spoelstra wrote: > >> Hi, > >> > >> I'd like to report a bug when using the SDL2 GUI in both Linux and > >> Windows, which can be observed with in

[Qemu-devel] [PATCH v1 1/8] net: Move error reporting from net_init_client/netdev to the calling site

2018-02-19 Thread Thomas Huth
It looks strange that net_init_client() and net_init_netdev() both take an "Error **errp" parameter, but then do the error reporting with "error_report_err(local_err)" on their own. Let's move the error reporting to the calling site instead to simplify this code a little bit. Signed-off-by: Thomas

[Qemu-devel] [PATCH v1 4/8] net: Make net_client_init() static

2018-02-19 Thread Thomas Huth
The function is only used within net.c, so there's no need that this is a global function. While we're at it, also remove the unused prototype compute_mcast_idx() (the function has been removed in commit d9caeb09b107e91122d10ba4a08a). Signed-off-by: Thomas Huth --- include/net/net.h | 2 -- net

[Qemu-devel] [PATCH v1 0/8] Improvements and clean-ups related to -net

2018-02-19 Thread Thomas Huth
"-net" is a legacy option that often causes confusion and misconfigurations for the users, since most people are not aware of the underlying "vlan" (i.e. hub) concept that is used for this parameter. The prefered way of configuring your network stack is to use "--netdev" instead, which gives you a

[Qemu-devel] [PATCH v1 3/8] net: Only show vhost-user in the help text if CONFIG_POSIX is defined

2018-02-19 Thread Thomas Huth
According to net/Makefile.objs we only link in the vhost-user code if CONFIG_POSIX has been set. So the help screen should also only show this information if CONFIG_POSIX has been defined. Signed-off-by: Thomas Huth --- qemu-options.hx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qemu-o

[Qemu-devel] [PATCH v1 2/8] net: List available netdevs with "-netdev help"

2018-02-19 Thread Thomas Huth
Other options like "-chardev" or "-device" feature a nice help text with the available devices when being called with "help" or "?". Since it is quite useful, especially if you want to see which network backends have been compiled into the QEMU binary, let's provide such a help text for "-netdev",

[Qemu-devel] [PATCH v1 7/8] net: Add a new convenience option "-n" to configure default/on-board NICs

2018-02-19 Thread Thomas Huth
The legacy "-net" option can be quite confusing for the users since most people do not expect to get a "vlan" hub between their emulated guest hardware and the host backend. But so far, we are also not able to get rid of "-net" completely, since it is the only way to configure on-board NICs that ca

Re: [Qemu-devel] Qemu SDL2 bug

2018-02-19 Thread Howard Spoelstra
On Mon, Feb 19, 2018 at 9:56 AM, Gerd Hoffmann wrote: > On Mon, Feb 19, 2018 at 08:58:51AM +0100, Howard Spoelstra wrote: >> On Mon, Feb 19, 2018 at 8:09 AM, Thomas Huth wrote: >> > On 18.02.2018 11:11, Howard Spoelstra wrote: >> >> Hi, >> >> >> >> I'd like to report a bug when using the SDL2 GUI

[Qemu-devel] [PATCH v1 5/8] net: Remove the deprecated way of dumping network packets

2018-02-19 Thread Thomas Huth
"-net dump" has been marked as deprecated since QEMU v2.10, since it only works with the deprecated 'vlan' parameter. Network dumping should be done with "-object filter-dump" nowadays instead. Since nobody complained so far about the deprecation message, let's finally get rid of "-net dump" now.

[Qemu-devel] [PATCH v1 6/8] net: Remove the deprecated 'host_net_add' and 'host_net_remove' HMP commands

2018-02-19 Thread Thomas Huth
They are deprecated since QEMU v2.10, and so far nobody complained that these commands are still necessary for any reason - and since you can use 'netdev_add' and 'netdev_remove' instead, there also should not be any real reason. Since they are also standing in the way for the upcoming 'vlan' clean

[Qemu-devel] [PATCH v1 8/8] qemu-doc: Make "-net" less prominent

2018-02-19 Thread Thomas Huth
"-net" is clearly a legacy option. Yet we still use it in almost all examples in the qemu documentation, and many other spots in the network chapter. We should make it less prominent that users are not lured into using it so often anymore. So instead of starting the network chapter with "-net nic"

Re: [Qemu-devel] [PULL 0/2] hmp queue

2018-02-19 Thread Peter Maydell
On 16 February 2018 at 17:46, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The following changes since commit 5e8d6a12d643a38b82a0a713a77d1192117dbdca: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180216-pull-request' > into staging (2018-02-16 15:55:4

Re: [Qemu-devel] [PATCH 0/3] target/s390x: translation loop conversion

2018-02-19 Thread David Hildenbrand
On 17.02.2018 00:40, Emilio G. Cota wrote: > Tested with the "Moon Buggy" image: > http://www.qemu-advent-calendar.org/2014/#day-22 > > Thanks, > > Emilio > This also passes kvm-unit-tests and and fedora27 boots fine. -- Thanks, David / dhildenb

Re: [Qemu-devel] [PATCH 1/3] target/s390x: convert to DisasJumpType

2018-02-19 Thread David Hildenbrand
> switch (status) { > -case EXIT_GOTO_TB: > -case EXIT_NORETURN: > +case DISAS_GOTO_TB: > +case DISAS_NORETURN: > break; > -case EXIT_PC_STALE: > -case EXIT_PC_STALE_NOCHAIN: > +case DISAS_TOO_MANY: > +case DISAS_PC_STALE: > +case DISAS_PC_STALE_NOC

[Qemu-devel] [PULL 0/1] stable process documentation

2018-02-19 Thread Cornelia Huck
The following changes since commit e5ecc287a7bd24a1364e23e263cb60cfc8d21eb5: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20180216' into staging (2018-02-16 18:39:05 +) are available in the git repository at: git://github.com/cohuck/qemu tags/stable-doc-201

[Qemu-devel] [PULL 1/1] docs: document our stable process

2018-02-19 Thread Cornelia Huck
Some pointers on how to get a patch into stable. [contains some suggestions by mdroth and eblake] Reviewed-by: Eric Blake Reviewed-by: Michael Roth Signed-off-by: Cornelia Huck --- docs/devel/stable-process.rst | 69 +++ 1 file changed, 69 insertions(+)

Re: [Qemu-devel] Qemu SDL2 bug

2018-02-19 Thread Gerd Hoffmann
> >> Hi, > >> > >> With SDL, unlike GTK, the mouse does not move outside the window. So I > >> have to use Ctrl-Alt-G to release focus and then click in the other > >> window. After two switches the reported issue occurs. Indeed, the Alt > >> key seems to go into a state in which it is stuck. When

Re: [Qemu-devel] [PATCH 2/3] target/s390x: convert to DisasContextBase

2018-02-19 Thread David Hildenbrand
On 17.02.2018 00:40, Emilio G. Cota wrote: > Notes: > > - Kept ctx.pc and ctx.next_pc; it would be very confusing > to have ctx.base.pc_next and ctx.next_pc ! > Instead, just updated ctx.base.pc_next where relevant. So we now have ctx.pc -> same as ctx.base.pc_next -> points at the untrans

[Qemu-devel] [PATCH v3 0/2] Sam460ex emulation

2018-02-19 Thread BALATON Zoltan
This is just resending the two remaining patches (2/3 from v2 and v3 of 3/3 of previous series as a new series to have them at one place). BALATON Zoltan (2): ppc440: Add emulation of plb-pcix controller found in some 440 SoCs ppc: Add aCube Sam460ex board Makefile

[Qemu-devel] [PATCH v3 1/2] ppc440: Add emulation of plb-pcix controller found in some 440 SoCs

2018-02-19 Thread BALATON Zoltan
This is the PCIX controller found in newer 440 core SoCs e.g. the AMMC 460EX. The device tree refers to this as plb-pcix compared to the plb-pci controller in older 440 SoCs. Signed-off-by: BALATON Zoltan --- v3: No change, resend from v2 v2: - Replace debug printfs with trace functions - Fix ac

[Qemu-devel] QEMU, KVM, Jailhouse participating in Google Summer of Code 2018!

2018-02-19 Thread Stefan Hajnoczi
QEMU has been accepted into Google Summer of Code 2018 again. Here is our list of project ideas: https://wiki.qemu.org/Google_Summer_of_Code_2018 Google Summer of Code is an open source internship program that offers 12-week full-time remote work during the summer for eligible university students

[Qemu-devel] [PATCH v3 2/2] ppc: Add aCube Sam460ex board

2018-02-19 Thread BALATON Zoltan
Add emulation of aCube Sam460ex board based on AMCC 460EX embedded SoC. This is not a complete implementation yet with a lot of components still missing but enough for the U-Boot firmware to start and to boot a Linux kernel or AROS. Signed-off-by: François Revol Signed-off-by: BALATON Zoltan ---

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 3/3] ppc: Add aCube Sam460ex board

2018-02-19 Thread BALATON Zoltan
On Mon, 19 Feb 2018, David Gibson wrote: On Sun, Feb 18, 2018 at 12:48:27AM +0100, BALATON Zoltan wrote: On Fri, 16 Feb 2018, BALATON Zoltan wrote: On Fri, 16 Feb 2018, David Gibson wrote: On Thu, Feb 15, 2018 at 10:27:06PM +0100, BALATON Zoltan wrote: Add emulation of aCube Sam460ex board ba

[Qemu-devel] [PATCH v4 0/7] vfio: add display support

2018-02-19 Thread Gerd Hoffmann
This series adds support for a vgpu display to the qemu vfio code. For now only regions are supported, dmabufs will follow later. This version adds a patch to allow devices disable hotplugging, which will be used by vfio display support. Also fixed issues Alex found in review. cheers, Gerd Ge

[Qemu-devel] [PATCH v4 5/7] vfio/common: cleanup in vfio_region_finalize

2018-02-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/vfio/common.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index f895e3c335..6a8203a532 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -858,6 +858,13 @@ void vfio_region_finalize(VFIORegion *region)

[Qemu-devel] [PATCH v4 6/7] vfio/display: core & wireup

2018-02-19 Thread Gerd Hoffmann
Infrastructure for display support. Must be enabled using 'display' property. Signed-off-by: Gerd Hoffmann --- hw/vfio/pci.h | 3 +++ hw/vfio/display.c | 52 +++ hw/vfio/pci.c | 9 + hw/vfio/Makefile.objs | 2 +- 4 f

[Qemu-devel] [PATCH v4 3/7] ui/pixman: add qemu_drm_format_to_pixman()

2018-02-19 Thread Gerd Hoffmann
Map drm fourcc codes to pixman formats. Signed-off-by: Gerd Hoffmann --- include/ui/qemu-pixman.h | 5 + ui/qemu-pixman.c | 22 ++ 2 files changed, 27 insertions(+) diff --git a/include/ui/qemu-pixman.h b/include/ui/qemu-pixman.h index 4a67e01232..b7c82d17fc 100

[Qemu-devel] [PATCH v4 2/7] standard-headers: add drm/drm_fourcc.h

2018-02-19 Thread Gerd Hoffmann
So we can use the drm fourcc codes without a dependency on libdrm-devel. Signed-off-by: Gerd Hoffmann --- include/standard-headers/drm/drm_fourcc.h | 411 ++ scripts/update-linux-headers.sh | 4 + 2 files changed, 415 insertions(+) create mode 100644 incl

[Qemu-devel] [PATCH v4 7/7] vfio/display: adding region support

2018-02-19 Thread Gerd Hoffmann
Wire up region-based display. Signed-off-by: Gerd Hoffmann --- hw/vfio/pci.h | 1 + include/hw/vfio/vfio-common.h | 8 hw/vfio/display.c | 104 +- 3 files changed, 111 insertions(+), 2 deletions(-) diff --git a/hw/vfio

[Qemu-devel] [PATCH v4 1/7] linux-headers: update to 4.16-rc1

2018-02-19 Thread Gerd Hoffmann
s390 has splitted syscall numbers into unistd_{32,64}.h files, so update scripts/update-linux-headers.sh accordingly. Also add a rewrite from __BITS_PER_LONG to HOST_LONG_BITS for linux/input.h Signed-off-by: Gerd Hoffmann --- include/standard-headers/linux/input-event-codes.h | 1 + include/

Re: [Qemu-devel] [RFC PATCH v6 00/20] replay additions

2018-02-19 Thread Ciro Santilli
On Mon, Feb 19, 2018 at 8:02 AM, Pavel Dovgalyuk wrote: >> From: Pavel Dovgalyuk [mailto:dovga...@ispras.ru] >> > From: Peter Maydell [mailto:peter.mayd...@linaro.org] >> > On 13 February 2018 at 10:26, Pavel Dovgalyuk wrote: >> > > Then I added SCSI adapter with the option –device lsi,id=scsi0 a

[Qemu-devel] [PATCH v4 4/7] qdev: add hotpluggable to DeviceState

2018-02-19 Thread Gerd Hoffmann
vfio display support wants disable hotplug for certain devices, because qemu doesn't support hotplugging display devices and qemu consoles. Add a hotpluggable bool to DeviceState, initialize it from DeviceClass->hotpluggable, update device_get_hotpluggable accordingly. Devices can flip the new va

Re: [Qemu-devel] [PULL 0/1] stable process documentation

2018-02-19 Thread Peter Maydell
ble in the git repository at: > > git://github.com/cohuck/qemu tags/stable-doc-20180219 > > for you to fetch changes up to 7aa54229cfd24935d5d7bcc48534fe01934f3f52: > > docs: document our stable process (2018-02-19 10:51:16 +0100) > > ---

[Qemu-devel] [PATCH PULL v2 02/10] docs: add pvrdma device documentation.

2018-02-19 Thread Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum Signed-off-by: Yuval Shaia Reviewed-by: Shamir Rabinovitch --- docs/pvrdma.txt | 255 1 file changed, 255 insertions(+) create mode 100644 docs/pvrdma.txt diff --git a/docs/pvrdma.txt b/docs/pvrdma.txt ne

[Qemu-devel] [PATCH PULL v2 03/10] scripts/update-linux-headers: import pvrdma headers

2018-02-19 Thread Marcel Apfelbaum
Modify the script to import the headers used by the pvrdma device. Part of them are interfaces between the guest driver and the device, import them under include/standart-headers/drivers/infiniband/... . Remove the unused functions from pvrdma_verbs.h avoiding the unnecessary import of several inf

[Qemu-devel] [PATCH PULL v2 06/10] hw/rdma: Definitions for rdma device and rdma resource manager

2018-02-19 Thread Marcel Apfelbaum
From: Yuval Shaia Definition of various structures and constants used in backend and resource manager modules. Reviewed-by: Dotan Barak Reviewed-by: Zhu Yanjun Signed-off-by: Yuval Shaia Signed-off-by: Marcel Apfelbaum --- hw/rdma/rdma_backend_defs.h | 62 ++ hw/rdm

[Qemu-devel] [PATCH PULL v2 10/10] MAINTAINERS: add entry for hw/rdma

2018-02-19 Thread Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum Signed-off-by: Yuval Shaia --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 57358a08e2..6e7adad1df 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2034,6 +2034,14 @@ F: block/replication.c F: tests/test-re

[Qemu-devel] [PATCH PULL v2 00/10] RDMA patches

2018-02-19 Thread Marcel Apfelbaum
Hi Peter, Changes from V1: * split the rdma patch into several patches. * fixed license issues. * moved Linux headers to standard-headers and fixed the used types. * R-B tags on all code files (patch 4/10 doesn't have an R-B tag, but is an automatic import of Linux kernel headers). The fol

[Qemu-devel] [PATCH PULL v2 05/10] hw/rdma: Add wrappers and macros

2018-02-19 Thread Marcel Apfelbaum
From: Yuval Shaia As all mapping for this device are from driver to device, declare wrappers on top of pci_dma_*map functions. In addition, declare macros to be used for debug messages. Reviewed-by: Dotan Barak Reviewed-by: Zhu Yanjun Signed-off-by: Yuval Shaia Signed-off-by: Marcel Apfelbau

[Qemu-devel] [PATCH PULL v2 09/10] hw/rdma: Implementation of PVRDMA device

2018-02-19 Thread Marcel Apfelbaum
From: Yuval Shaia PVRDMA is the QEMU implementation of VMware's paravirtualized RDMA device. It works with its Linux Kernel driver AS IS, no need for any special guest modifications. While it complies with the VMware device, it can also communicate with bare metal RDMA-enabled machines and does

[Qemu-devel] [PATCH PULL v2 01/10] mem: add share parameter to memory-backend-ram

2018-02-19 Thread Marcel Apfelbaum
Currently only file backed memory backend can be created with a "share" flag in order to allow sharing guest RAM with other processes in the host. Add the "share" flag also to RAM Memory Backend in order to allow remapping parts of the guest RAM to different host virtual addresses. This is needed

[Qemu-devel] [PATCH PULL v2 04/10] include/standard-headers: add pvrdma related headers

2018-02-19 Thread Marcel Apfelbaum
Import the headers used by the pvrdma device. Part of them are interfaces between the guest driver and the device, imported under include/standart-headers/drivers/infiniband/... . Signed-off-by: Marcel Apfelbaum Signed-off-by: Yuval Shaia --- .../infiniband/hw/vmw_pvrdma/pvrdma_dev_api.h |

[Qemu-devel] [PATCH PULL v2 07/10] hw/rdma: Implementation of generic rdma device layers

2018-02-19 Thread Marcel Apfelbaum
From: Yuval Shaia This layer is composed of two sub-modules, backend and resource manager. Backend sub-module is responsible for all the interaction with IB layers such as ibverbs and umad (external libraries). Resource manager is a collection of functions and structures to manage RDMA resources

[Qemu-devel] [PATCH PULL v2 08/10] hw/rdma: PVRDMA commands and data-path ops

2018-02-19 Thread Marcel Apfelbaum
From: Yuval Shaia First PVRDMA sub-module - implementation of the PVRDMA device. - PVRDMA commands such as create CQ and create MR. - Data path QP operations - post_send and post_recv. - Completion handler. Reviewed-by: Dotan Barak Reviewed-by: Zhu Yanjun Signed-off-by: Yuval Shaia Signed-off

Re: [Qemu-devel] [PATCH 3/3] target/s390x: convert to TranslatorOps

2018-02-19 Thread David Hildenbrand
On 17.02.2018 00:40, Emilio G. Cota wrote: Can you keep DisasContext named dc instead of s? Avoids unnecessary changes. (e.g. s390x_tr_tb_stop()). And also matches what e.g. i386 does in their code. > Signed-off-by: Emilio G. Cota > --- > target/s390x/translate.c | 170 > ++

Re: [Qemu-devel] [qemu-s390x] [PATCH v7 05/12] s390-ccw: move auxiliary IPL data to separate location

2018-02-19 Thread Viktor Mihajlovski
On 19.02.2018 09:50, Viktor Mihajlovski wrote: > On 17.02.2018 09:11, Thomas Huth wrote: > [...] >> >> I still think that the information should *not* be stored within the >> IplParameterBlock to avoid that we pass it via DIAG 0x308, too. >> If we do it like this, I'm pretty sure that we will look

Re: [Qemu-devel] [qemu-s390x] [PATCH v7 06/12] s390-ccw: parse and set boot menu options

2018-02-19 Thread Viktor Mihajlovski
On 17.02.2018 09:26, Thomas Huth wrote: [...] >> struct QemuIplParameters { >> -uint8_t reserved1[4]; >> +uint8_t boot_menu_flags; >> +uint8_t reserved1[3]; >> +uint32_t boot_menu_timeout; >> uint64_t netboot_start_addr; >> -uint8_t reserved2[16]; >> +uint8_t rese

[Qemu-devel] [PATCH] docs: document virtio-balloon stats

2018-02-19 Thread Tomáš Golembiovský
Document statistics added in commits commit a0d06486b445985b8d128df172daefbae205bffd Author: Denis V. Lunev Date: Wed Feb 24 10:50:48 2016 +0300 virtio-balloon: add 'available' counter and commit bf1e7140ef0b3a149860ab9f05b36665133238f6 Author: Tomáš Golembiovský

Re: [Qemu-devel] [PATCH v2 1/1] virtio-balloon: include statistics of disk/file caches

2018-02-19 Thread Tomáš Golembiovský
On Wed, 14 Feb 2018 00:07:53 +0200 "Michael S. Tsirkin" wrote: > On Tue, Feb 13, 2018 at 12:29:39PM -0800, Jonathan Helman wrote: > > > > > > On 02/05/2018 04:08 AM, Tomáš Golembiovský wrote: > > > ping > > > > > > On Tue, 5 Dec 2017 13:14:46 +0100 > > > Tomáš Golembiovský wrote: > > >

[Qemu-devel] [PATCH 1/5] tricore: added some missing cpu instructions

2018-02-19 Thread David Brenken
From: David Brenken Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Florian Artmeier --- target/tricore/translate.c | 22 ++ target/tricore/tricore-opcodes.h | 4 2 files changed, 26 insertions(+) diff --git a/target/tricore/transla

[Qemu-devel] [PATCH 4/5] tricore: fixed wrong mask of PCXI_PIE

2018-02-19 Thread David Brenken
From: David Brenken Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Florian Artmeier --- target/tricore/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/tricore/cpu.h b/target/tricore/cpu.h index 6ed474c..3f8c029 100644 --- a/target/

[Qemu-devel] [PATCH 0/5] tricore: added small features + fixed wrong masks

2018-02-19 Thread David Brenken
From: David Brenken Hello, this is my first commit of a patch set for QEMU. This patch series contains a few updates for the target tricore: - adding a few additional, previously missing cpu instructions - adding CORE_ID - fixing some masks - fixing a wrong shift (context PCXI PIE) David Bre

[Qemu-devel] [PATCH 2/5] tricore: added CORE_ID

2018-02-19 Thread David Brenken
From: David Brenken Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Florian Artmeier --- target/tricore/cpu.h| 1 + target/tricore/csfr.def | 1 + 2 files changed, 2 insertions(+) diff --git a/target/tricore/cpu.h b/target/tricore/cpu.h index f41d2ce..c295763

[Qemu-devel] [PATCH 3/5] tricore: fixed wrong masking of IE

2018-02-19 Thread David Brenken
From: David Brenken Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Florian Artmeier --- target/tricore/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/tricore/cpu.h b/target/tricore/cpu.h index c295763..6ed474c 100644 --- a/target/

[Qemu-devel] [PATCH 5/5] tricore: fixed wrong shifting of PCXI PIE

2018-02-19 Thread David Brenken
From: David Brenken Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Florian Artmeier --- target/tricore/op_helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/tricore/op_helper.c b/target/tricore/op_helper.c index 7af202c..491f97d

Re: [Qemu-devel] [PATCH v1 0/8] Improvements and clean-ups related to -net

2018-02-19 Thread Eric Blake
On 02/19/2018 03:15 AM, Thomas Huth wrote: The last patch finally makes "-net" less prominent in our qemu docs, e.g. by replacing the examples that contain "-net" with "-netdev". Minor request: while doing this, can we update the documentation to mention "--netdev" and "--n" everywhere we tou

Re: [Qemu-devel] [PATCH v1 0/8] Improvements and clean-ups related to -net

2018-02-19 Thread Thomas Huth
On 19.02.2018 14:29, Eric Blake wrote: > On 02/19/2018 03:15 AM, Thomas Huth wrote: > >> The last patch finally makes "-net" less prominent in our qemu docs, >> e.g. by replacing the examples that contain "-net" with "-netdev". > > Minor request: while doing this, can we update the documentation

Re: [Qemu-devel] [PATCH v1 1/8] net: Move error reporting from net_init_client/netdev to the calling site

2018-02-19 Thread Eric Blake
On 02/19/2018 03:15 AM, Thomas Huth wrote: It looks strange that net_init_client() and net_init_netdev() both take an "Error **errp" parameter, but then do the error reporting with "error_report_err(local_err)" on their own. Let's move the error reporting to the calling site instead to simplify t

Re: [Qemu-devel] [PATCH v4 00/22] re-factor softfloat and add fp16 functions

2018-02-19 Thread Peter Maydell
On 17 February 2018 at 13:23, Alex Bennée wrote: > Peter Maydell writes: >> If you persuade git to use the --minimal, --patience or --histogram >> git diff option when generating these patches you'll find that it >> doesn't produce unreadable patches that provoke all the checkpatch >> warnings. >

Re: [Qemu-devel] [PATCH 3/3] arm/vexpress: Add proper display connector emulation

2018-02-19 Thread Linus Walleij
On Sat, Feb 17, 2018 at 7:28 PM, Philippe Mathieu-Daudé wrote: > On 02/17/2018 11:00 AM, Linus Walleij wrote: >> The assignment of the SiI9022 at address 0x39 and the EDID >> DDC I2C at address 0x50 is not strictly correct: the DDC I2C >> is there all the time but in the actual component it only

[Qemu-devel] [PATCH v5 0/2] qmp: 'wakeup-suspend-support' in query-target

2018-02-19 Thread Daniel Henrique Barboza
v5: - removed a paragraph in the recently added qemu_register_wakeup_notifier comment that was added. That paragraph was adding too much in-depth information about the current design of the system_wakeup, making it harder to understand the whole point (suggested by Mike Roth). - previous version li

[Qemu-devel] [PATCH v5 2/2] qga: update guest-suspend-ram and guest-suspend-hybrid descriptions

2018-02-19 Thread Daniel Henrique Barboza
This patch updates the descriptions of 'guest-suspend-ram' and 'guest-suspend-hybrid' to mention that both commands relies now on the existence of 'system_wakeup' and also on the proper support for wake up from suspend, retrieved by the 'wakeup-suspend-support' attribute of the 'query-target' QMP c

[Qemu-devel] [PATCH v5 1/2] qmp: adding 'wakeup-suspend-support' in query-target

2018-02-19 Thread Daniel Henrique Barboza
When issuing the qmp/hmp 'system_wakeup' command, what happens in a nutshell is: - qmp_system_wakeup_request set runstate to RUNNING, sets a wakeup_reason and notify the event - in the main_loop, all vcpus are paused, a system reset is issued, all subscribers of wakeup_notifiers receives a notific

Re: [Qemu-devel] [qemu-s390x] [PATCH v7 05/12] s390-ccw: move auxiliary IPL data to separate location

2018-02-19 Thread Thomas Huth
On 19.02.2018 13:15, Viktor Mihajlovski wrote: > On 19.02.2018 09:50, Viktor Mihajlovski wrote: >> On 17.02.2018 09:11, Thomas Huth wrote: >> [...] >>> >>> I still think that the information should *not* be stored within the >>> IplParameterBlock to avoid that we pass it via DIAG 0x308, too. >>> If

Re: [Qemu-devel] [PATCH v7 11/12] s390-ccw: set cp_receive mask only when needed and consume pending service irqs

2018-02-19 Thread Christian Borntraeger
On 02/19/2018 03:15 PM, Christian Borntraeger wrote: > > > On 02/16/2018 11:07 PM, Collin L. Walling wrote: >> It is possible while waiting for multiple types of external >> interrupts that we might have pending irqs remaining between >> irq consumption and irq-type disabling. Those interrupts

Re: [Qemu-devel] [PATCH v7 11/12] s390-ccw: set cp_receive mask only when needed and consume pending service irqs

2018-02-19 Thread Christian Borntraeger
On 02/16/2018 11:07 PM, Collin L. Walling wrote: > It is possible while waiting for multiple types of external > interrupts that we might have pending irqs remaining between > irq consumption and irq-type disabling. Those interrupts > could potentially propagate to the guest after IPL completes >

[Qemu-devel] [PATCH RFC] s390x/sclp: remove memory hotplug support

2018-02-19 Thread David Hildenbrand
>From an architecture point of view, nothing can be mapped into the address space on s390x. All there is is memory. Therefore there is also not really an interface to communicate such information to the guest. All we can do is specify the maximum ram address and guests can probe in that range if me

Re: [Qemu-devel] [PATCHv5 1/5] qmp: expose s390-specific CPU info

2018-02-19 Thread Cornelia Huck
On Fri, 16 Feb 2018 17:08:37 +0100 Viktor Mihajlovski wrote: > Presently s390x is the only architecture not exposing specific > CPU information via QMP query-cpus. Upstream discussion has shown > that it could make sense to report the architecture specific CPU > state, e.g. to detect that a CPU h

[Qemu-devel] [PATCH] docs: document how to use the l2-cache-entry-size parameter

2018-02-19 Thread Alberto Garcia
This patch updates docs/qcow2-cache.txt explaining how to use the new l2-cache-entry-size parameter. Here's a more detailed technical description of this feature: https://lists.gnu.org/archive/html/qemu-block/2017-09/msg00635.html And here are some performance numbers: https://lists.gnu.o

Re: [Qemu-devel] [PATCHv5 2/5] qmp: add query-cpus-fast

2018-02-19 Thread Cornelia Huck
On Fri, 16 Feb 2018 17:08:38 +0100 Viktor Mihajlovski wrote: > From: Luiz Capitulino > > The query-cpus command has an extremely serious side effect: > it always interrupts all running vCPUs so that they can run > ioctl calls. This can cause a huge performance degradation for > some workloads.

Re: [Qemu-devel] [PATCHv5 4/5] qemu-doc: deprecate query-cpus

2018-02-19 Thread Cornelia Huck
On Fri, 16 Feb 2018 17:08:40 +0100 Viktor Mihajlovski wrote: > Start the deprecation period for QAPI query-cpus (replaced by > query-cpus-fast) beginning with 2.12.0. > > Signed-off-by: Viktor Mihajlovski > Reviewed-by: Eric Blake > --- > qapi-schema.json | 4 > qemu-doc.texi| 4

Re: [Qemu-devel] [PATCHv5 5/5] hmp: change hmp_info_cpus to use query-cpus-fast

2018-02-19 Thread Cornelia Huck
On Fri, 16 Feb 2018 17:08:41 +0100 Viktor Mihajlovski wrote: > Changing the implementation of hmp_info_cpus() to call s/Changing/Change/ > qmp_query_cpus_fast() instead of qmp_query_cpus. This has the > following consequences: > > o No further code change required for qmp_query_cpus deprecat

Re: [Qemu-devel] [PATCHv5 0/5] add query-cpu-fast and related s390 changes

2018-02-19 Thread Cornelia Huck
On Fri, 16 Feb 2018 17:08:36 +0100 Viktor Mihajlovski wrote: > v5 synopsis: Split out HMP changes from Patch 2 into Patch 5. Please >re-review, as I've removed the a-b/r-b from Patch 2 >as well. Series looks good to me. I'd be happy to take it through the s390 tree with s

Re: [Qemu-devel] [PATCH 3/3] arm/vexpress: Add proper display connector emulation

2018-02-19 Thread Corey Minyard
On 02/19/2018 08:10 AM, Linus Walleij wrote: On Sat, Feb 17, 2018 at 7:28 PM, Philippe Mathieu-Daudé wrote: On 02/17/2018 11:00 AM, Linus Walleij wrote: The assignment of the SiI9022 at address 0x39 and the EDID DDC I2C at address 0x50 is not strictly correct: the DDC I2C is there all the time

[Qemu-devel] [PATCH 1/2] i2c: Fix some brace style issues

2018-02-19 Thread minyard
From: Corey Minyard Signed-off-by: Corey Minyard --- hw/i2c/core.c| 3 +-- include/hw/i2c/i2c.h | 6 ++ 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/i2c/core.c b/hw/i2c/core.c index 59068f1..9a54b61 100644 --- a/hw/i2c/core.c +++ b/hw/i2c/core.c @@ -19,8 +19,7 @

[Qemu-devel] [PATCH 0/2] Move the bus class to i2c.h

2018-02-19 Thread minyard
This is a couple of changes I have because I have a bus mux emulator and a multi-master bus mux emulator. Others need this change, too, so get it out there. -corey

[Qemu-devel] [PATCH 2/2] i2c: Move the bus class to i2c.h

2018-02-19 Thread minyard
From: Corey Minyard Some devices need access to it. Signed-off-by: Corey Minyard --- hw/i2c/core.c| 17 - include/hw/i2c/i2c.h | 17 + 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/hw/i2c/core.c b/hw/i2c/core.c index 9a54b61..cfccefc 1

Re: [Qemu-devel] [PATCH 1/1] tci: eliminate UB due to unaligned reads

2018-02-19 Thread Anatoly Trosinenko
Ping. Patchwork link: http://patchwork.ozlabs.org/patch/866732/ Patchew link: http://patchew.org/QEMU/20180127134908.24095-1- anatoly.trosine...@gmail.com/ Original cover letter: The code in tcg/tci.c reads some data from TCI bytecode through pointer dereferencing. As far as I know unaligned reads

Re: [Qemu-devel] [PATCH 1/2] i2c: Fix some brace style issues

2018-02-19 Thread Peter Maydell
On 19 February 2018 at 15:20, wrote: > From: Corey Minyard > > Signed-off-by: Corey Minyard Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH 2/2] i2c: Move the bus class to i2c.h

2018-02-19 Thread Peter Maydell
On 19 February 2018 at 15:20, wrote: > From: Corey Minyard > > Some devices need access to it. > > Signed-off-by: Corey Minyard > --- > hw/i2c/core.c| 17 - > include/hw/i2c/i2c.h | 17 + > 2 files changed, 17 insertions(+), 17 deletions(-) Reviewed-by:

Re: [Qemu-devel] Qemu SDL2 bug

2018-02-19 Thread Howard Spoelstra
On Mon, Feb 19, 2018 at 11:30 AM, Gerd Hoffmann wrote: >> >> Hi, >> >> >> >> With SDL, unlike GTK, the mouse does not move outside the window. So I >> >> have to use Ctrl-Alt-G to release focus and then click in the other >> >> window. After two switches the reported issue occurs. Indeed, the Alt

Re: [Qemu-devel] [PATCH v6] ui/cocoa.m: Add ability for user to specify mouse ungrab key

2018-02-19 Thread Programmingkid
> On Feb 19, 2018, at 3:48 AM, Gerd Hoffmann wrote: > > Hi, > >>> (b) Restrict allowed hotkeys to modifier key(s) plus one >>> non-modifier key. Forwarding modifier keydown+keyup >>> to the guest has typically effects inside the guest, >>> so we only have to hold back that single non-mo

Re: [Qemu-devel] [qemu-s390x] [PATCH v7 04/12] s390-ccw: update libc

2018-02-19 Thread Collin L. Walling
On 02/17/2018 02:48 AM, Thomas Huth wrote: On 16.02.2018 23:07, Collin L. Walling wrote: [...] +/** + * uitoa: + * @num: an integer (base 10) to be converted. + * @str: a pointer to a string to store the conversion. + * @len: the length of the passed string. + * + * Given an integer @num, conver

[Qemu-devel] [PATCH] docs: pcie: Spell out machine type needs for PCIe features

2018-02-19 Thread Kashyap Chamarthy
PCIe features are available only via the Q35 machine for x86, or the 'virt' machine type for AArch64 architecture. Mention that explicitly. Thanks: Daniel Berrangé Signed-off-by: Kashyap Chamarthy --- docs/pcie.txt | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/

Re: [Qemu-devel] [PATCH] docs: pcie: Spell out machine type needs for PCIe features

2018-02-19 Thread Daniel P . Berrangé
On Mon, Feb 19, 2018 at 04:43:33PM +0100, Kashyap Chamarthy wrote: > PCIe features are available only via the Q35 machine for x86, or the > 'virt' machine type for AArch64 architecture. > > Mention that explicitly. > > Thanks: Daniel Berrangé > > Signed-off-by: Kashyap Chamarthy > --- > docs/p

Re: [Qemu-devel] [PATCH v7 11/12] s390-ccw: set cp_receive mask only when needed and consume pending service irqs

2018-02-19 Thread Collin L. Walling
On 02/19/2018 09:15 AM, Christian Borntraeger wrote: On 02/16/2018 11:07 PM, Collin L. Walling wrote: It is possible while waiting for multiple types of external interrupts that we might have pending irqs remaining between irq consumption and irq-type disabling. Those interrupts could potential

Re: [Qemu-devel] [PATCH v7 11/12] s390-ccw: set cp_receive mask only when needed and consume pending service irqs

2018-02-19 Thread Collin L. Walling
On 02/19/2018 09:17 AM, Christian Borntraeger wrote: On 02/19/2018 03:15 PM, Christian Borntraeger wrote: On 02/16/2018 11:07 PM, Collin L. Walling wrote: It is possible while waiting for multiple types of external interrupts that we might have pending irqs remaining between irq consumption a

Re: [Qemu-devel] [PATCH v7] ui/cocoa.m: Add ability for user to specify mouse ungrab key

2018-02-19 Thread Programmingkid
> On Feb 19, 2018, at 3:54 AM, Gerd Hoffmann wrote: > > Hi, > >> +/* Sends any keys that were delayed because they were part of the ungrab >> set */ >> +static void send_key_if_delayed(Set *the_set, int keycode) >> +{ >> +if (contains_number(the_set, keycode)) { >> +qemu_input_eve

Re: [Qemu-devel] [PATCH v7 06/12] s390-ccw: parse and set boot menu options

2018-02-19 Thread Viktor Mihajlovski
On 16.02.2018 23:07, Collin L. Walling wrote: [...] > diff --git a/hw/s390x/ipl.h b/hw/s390x/ipl.h > index 74469b1..f632c59 100644 > --- a/hw/s390x/ipl.h > +++ b/hw/s390x/ipl.h > @@ -60,6 +60,9 @@ typedef struct IplBlockQemuScsi IplBlockQemuScsi; > > #define QIPL_ADDRESS 0xcc > > +#define BOOT_

Re: [Qemu-devel] [qemu-s390x] [PATCH v7 04/12] s390-ccw: update libc

2018-02-19 Thread Thomas Huth
On 19.02.2018 16:40, Collin L. Walling wrote: > On 02/17/2018 02:48 AM, Thomas Huth wrote: >> On 16.02.2018 23:07, Collin L. Walling wrote: >> [...] >>> +/** >>> + * uitoa: >>> + * @num: an integer (base 10) to be converted. >>> + * @str: a pointer to a string to store the conversion. >>> + * @len:

Re: [Qemu-devel] [PATCH v4 13/22] fpu/softfloat: re-factor mul

2018-02-19 Thread Alex Bennée
Peter Maydell writes: > On 6 February 2018 at 16:48, Alex Bennée wrote: >> We can now add float16_mul and use the common decompose and >> canonicalize functions to have a single implementation for >> float16/32/64 versions. >> >> Signed-off-by: Alex Bennée >> Signed-off-by: Richard Henderson

Re: [Qemu-devel] [PATCH v7 05/12] s390-ccw: move auxiliary IPL data to separate location

2018-02-19 Thread Viktor Mihajlovski
On 16.02.2018 23:07, Collin L. Walling wrote: [...] > diff --git a/hw/s390x/ipl.h b/hw/s390x/ipl.h > index 8a705e0..74469b1 100644 > --- a/hw/s390x/ipl.h > +++ b/hw/s390x/ipl.h > @@ -16,8 +16,7 @@ > #include "cpu.h" > > struct IplBlockCcw { > -uint64_t netboot_start_addr; > -uint8_t res

Re: [Qemu-devel] [PATCH v1 2/8] net: List available netdevs with "-netdev help"

2018-02-19 Thread Paolo Bonzini
On 19/02/2018 10:15, Thomas Huth wrote: > Other options like "-chardev" or "-device" feature a nice help text > with the available devices when being called with "help" or "?". > Since it is quite useful, especially if you want to see which network > backends have been compiled into the QEMU binary

Re: [Qemu-devel] [PATCH v1 1/8] net: Move error reporting from net_init_client/netdev to the calling site

2018-02-19 Thread Paolo Bonzini
On 19/02/2018 10:15, Thomas Huth wrote: > It looks strange that net_init_client() and net_init_netdev() both > take an "Error **errp" parameter, but then do the error reporting > with "error_report_err(local_err)" on their own. Let's move the > error reporting to the calling site instead to simplif

  1   2   3   >