Re: [Qemu-devel] [PATCH v2 resend] block/mirror: change the semantic of 'force' of block-job-cancel

2018-03-12 Thread John Snow
On 03/12/2018 10:13 PM, Jeff Cody wrote: > On Fri, Mar 02, 2018 at 11:20:55AM -0500, John Snow wrote: >> >> >> On 03/02/2018 10:39 AM, Eric Blake wrote: >>> On 02/26/2018 08:05 PM, Liang Li wrote: When doing drive mirror to a low speed shared storage, if there was heavy BLK IO write wor

Re: [Qemu-devel] [PATCH v10 05/12] migration: introduce postcopy-only pending

2018-03-12 Thread John Snow
On 03/12/2018 11:30 AM, Dr. David Alan Gilbert wrote: > * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: >> There would be savevm states (dirty-bitmap) which can migrate only in >> postcopy stage. The corresponding pending is introduced here. >> >> Signed-off-by: Vladimir Sementso

[Qemu-devel] [PATCH qemu v2] slirp/debug: Print IP addresses in human readable form

2018-03-12 Thread Alexey Kardashevskiy
Signed-off-by: Alexey Kardashevskiy --- checkpatch.pl complains on every single changed line as it keeps using tabs - do I need to post 's/\t//g'? --- Changes: v2: * replaced static cast to (in_addr*) with temporary structs --- slirp/arp_table.c | 4 ++-- slirp/socket.c| 8 sli

Re: [Qemu-devel] [PATCH qemu v7 2/4] vfio/pci: Relax DMA map errors for MMIO regions

2018-03-12 Thread Alexey Kardashevskiy
On 7/3/18 1:17 pm, Alexey Kardashevskiy wrote: > On 26/02/18 19:36, Alexey Kardashevskiy wrote: >> On 19/02/18 13:46, Alexey Kardashevskiy wrote: >>> On 16/02/18 16:28, David Gibson wrote: On Wed, Feb 14, 2018 at 08:55:41AM -0700, Alex Williamson wrote: > On Wed, 14 Feb 2018 19:09:16 +1100

[Qemu-devel] [Bug 1156632] Re: not receiving RESET event after system_reset command causes QMP connection to die

2018-03-12 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1156632 Title: not receivi

Re: [Qemu-devel] [PATCH v2 0/8] nbd block status base:allocation

2018-03-12 Thread Eric Blake
On 03/12/2018 09:06 PM, no-re...@patchew.org wrote: Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20180312152126.286890-1-vsement...@virtuozzo.com Subject: [Qemu-devel] [PATCH v2 0/8] nbd block status base:allocation CC bloc

Re: [Qemu-devel] [PATCH v2 2/8] nbd/server: add nbd_read_opt_name helper

2018-03-12 Thread Eric Blake
On 03/12/2018 10:21 AM, Vladimir Sementsov-Ogievskiy wrote: Add helper to read name in format: uint32 len (<= NBD_MAX_NAME_SIZE) len bytes string (not 0-terminated) The helper would be reused in following patch. s/would/will/ Signed-off-by: Vladimir Sementsov-Ogievskiy --- v2

[Qemu-devel] Partial NUMA config

2018-03-12 Thread Alexey Kardashevskiy
Hi Igor, ec78f8114bc4c1 "numa: use possible_cpus for not mapped CPUs check" added a warning about "All CPU(s) up to maxcpus should be described in NUMA config, ability to start up with partial NUMA mappings is obsoleted and will be removed in future" and this is printed when I add a numa node with

Re: [Qemu-devel] [PATCH v2 1/8] nbd/server: add nbd_opt_invalid helper

2018-03-12 Thread Eric Blake
On 03/12/2018 10:21 AM, Vladimir Sementsov-Ogievskiy wrote: NBD_REP_ERR_INVALID is often parameter to nbd_opt_drop and it would be used more in following patches. So, let's add a helper. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- v2: add Eric's r-b nbd/server.c

Re: [Qemu-devel] [PATCH v2 resend] block/mirror: change the semantic of 'force' of block-job-cancel

2018-03-12 Thread Jeff Cody
On Fri, Mar 02, 2018 at 11:20:55AM -0500, John Snow wrote: > > > On 03/02/2018 10:39 AM, Eric Blake wrote: > > On 02/26/2018 08:05 PM, Liang Li wrote: > >> When doing drive mirror to a low speed shared storage, if there was heavy > >> BLK IO write workload in VM after the 'ready' event, drive mir

Re: [Qemu-devel] [PATCH v2 0/8] nbd block status base:allocation

2018-03-12 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20180312152126.286890-1-vsement...@virtuozzo.com Subject: [Qemu-devel] [PATCH v2 0/8] nbd block status base:allocation === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked u

Re: [Qemu-devel] [PATCH v8 00/23] QMP: out-of-band (OOB) execution support

2018-03-12 Thread Peter Xu
On Mon, Mar 12, 2018 at 12:55:28PM +, Daniel P. Berrangé wrote: > On Mon, Mar 12, 2018 at 07:01:50AM -0500, Eric Blake wrote: > > On 03/09/2018 02:59 AM, Peter Xu wrote: > > > Based-on: <20180306053320.15401-1-pet...@redhat.com> > > > > > > The series is based on the following series: > > > >

Re: [Qemu-devel] [PATCH v2 0/8] nbd block status base:allocation

2018-03-12 Thread Eric Blake
On 03/12/2018 10:28 AM, Vladimir Sementsov-Ogievskiy wrote: 12.03.2018 18:21, Vladimir Sementsov-Ogievskiy wrote: Hi all. Here is minimal realization of base:allocation context of NBD block-status extension, which allows to get block status through NBD. v2 changes are in each patch after "---"

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] block: fix nbd-server-stop crash after blockdev-snapshot-sync

2018-03-12 Thread Eric Blake
On 03/08/2018 11:37 AM, Stefan Hajnoczi wrote: On Wed, Mar 07, 2018 at 05:27:45PM -0600, Eric Blake wrote: On 03/06/2018 02:48 PM, Stefan Hajnoczi wrote: The blockdev-snapshot-sync command uses bdrv_append() to update all parents to point at the external snapshot node. This breaks BlockBackend

Re: [Qemu-devel] [PATCH 1/3] qemu.py: Use items() instead of iteritems()

2018-03-12 Thread Eduardo Habkost
On Tue, Mar 13, 2018 at 12:02:39AM +0100, Philippe Mathieu-Daudé wrote: > On 03/12/2018 07:55 PM, Eduardo Habkost wrote: > > items() is less efficient on Python 2.x, but makes the code work > > on both Python 2 and Python 3. > > > > Cc: Lukáš Doktor > > Cc: Philippe Mathieu-Daudé > > Cc: Cleber

Re: [Qemu-devel] [PATCH] KVM: x86: Add support for save/load MSR_SMI_COUNT

2018-03-12 Thread Liran Alon
Another gentle ping. (Just following "If your patch seems to have been ignored" section in QEMU's submitting patches guidelines...) - liran.a...@oracle.com wrote: > Gentle ping. > (https://urldefense.proofpoint.com/v2/url?u=http-3A__patchwork.ozlabs.org_patch_878657_&d=DwIFaQ&c=RoP1YumCXCg

Re: [Qemu-devel] [PATCH v4 0/8] nvdimm: guarantee persistence of QEMU writes to persistent memory

2018-03-12 Thread Haozhong Zhang
On 03/12/18 15:39 +, Stefan Hajnoczi wrote: > On Wed, Feb 28, 2018 at 03:25:50PM +0800, Haozhong Zhang wrote: > > QEMU writes to vNVDIMM backends in the vNVDIMM label emulation and > > live migration. If the backend is on the persistent memory, QEMU needs > > to take proper operations to ensure

[Qemu-devel] [PATCH 1/3] nvram: at24c: remove doubled prefix for ERR

2018-03-12 Thread Wolfram Sang
The ERR macro already has the TYPE_AT24C_EE prefix, no need to repeat in the error message. Signed-off-by: Wolfram Sang --- hw/nvram/eeprom_at24c.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/hw/nvram/eeprom_at24c.c b/hw/nvram/eeprom_at24c.c index 5494351976..

[Qemu-devel] [PATCH 2/3] nvram: at24c: prevent segfault by checking "rom-size"

2018-03-12 Thread Wolfram Sang
The value for "rom-size" is used as a divisor, so it must not be 0 or it will segfault. A size of 0 wouldn't make sense as well. Signed-off-by: Wolfram Sang --- hw/nvram/eeprom_at24c.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/nvram/eeprom_at24c.c b/hw/nvram/eeprom_at24c.c inde

[Qemu-devel] [PATCH 3/3] nvram: at24c: use a sane default for "rom-size"

2018-03-12 Thread Wolfram Sang
0 as "rom-size" doesn't make much sense, let's use the smallest 24cXX which has 128 byte. Signed-off-by: Wolfram Sang --- hw/nvram/eeprom_at24c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/nvram/eeprom_at24c.c b/hw/nvram/eeprom_at24c.c index d82710e1df..de988f8d07 100

[Qemu-devel] [PATCH 0/3] nvram: at24c: fix problems related to "rom-size"

2018-03-12 Thread Wolfram Sang
I used this driver as a template for a custom one. While hacking on my own, I noticed some problems in this driver, too. This series fixes the first set of them, mostly related to "rom-size". It fixes a segfault. Wolfram Sang (3): nvram: at24c: remove doubled prefix for ERR nvram: at24c: preve

Re: [Qemu-devel] [PATCH 2/3] qmp.py: Encode json data before sending

2018-03-12 Thread Philippe Mathieu-Daudé
On 03/12/2018 07:55 PM, Eduardo Habkost wrote: > On Python 3, json.dumps() return a str object, which can't be > sent directly through a socket and must be encoded into a bytes > object. Use .encode('utf-8'), which will work on both Python 2 > and Python 3. > > Signed-off-by: Eduardo Habkost > -

Re: [Qemu-devel] [PATCH 1/3] qemu.py: Use items() instead of iteritems()

2018-03-12 Thread Philippe Mathieu-Daudé
On 03/12/2018 07:55 PM, Eduardo Habkost wrote: > items() is less efficient on Python 2.x, but makes the code work > on both Python 2 and Python 3. > > Cc: Lukáš Doktor > Cc: Philippe Mathieu-Daudé > Cc: Cleber Rosa > Signed-off-by: Eduardo Habkost > --- > scripts/qemu.py | 2 +- > 1 file chan

[Qemu-devel] [PULL 6/7] cpu: get rid of unused cpu_init() defines

2018-03-12 Thread Eduardo Habkost
From: Igor Mammedov cpu_init(cpu_model) were replaced by cpu_create(cpu_type) so no users are left, remove it. Signed-off-by: Igor Mammedov Acked-by: David Gibson (ppc) Reviewed-by: Eduardo Habkost Message-Id: <151827-274608-6-git-send-email-imamm...@redhat.com> Signed-off-by: Eduardo Hab

[Qemu-devel] [PULL 4/7] cpu: add CPU_RESOLVING_TYPE macro

2018-03-12 Thread Eduardo Habkost
From: Igor Mammedov it will be used for providing to cpu name resolving class for parsing cpu model for system and user emulation code. Along with change add target to null-machine tests, so that when switch to CPU_RESOLVING_TYPE happens, it would ensure that null-machine usecase still works. S

[Qemu-devel] [PULL 5/7] Use cpu_create(type) instead of cpu_init(cpu_model)

2018-03-12 Thread Eduardo Habkost
From: Igor Mammedov With all targets defining CPU_RESOLVING_TYPE, refactor cpu_parse_cpu_model(type, cpu_model) to parse_cpu_model(cpu_model) so that callers won't have to know internal resolving cpu type. Place it in exec.c so it could be called from both target independed vl.c and *-user/main.c

[Qemu-devel] [PULL 7/7] cpu: drop unnecessary NULL check and cpu_common_class_by_name()

2018-03-12 Thread Eduardo Habkost
From: Igor Mammedov both do nothing as for the first all callers parse_cpu_model() and qmp_query_cpu_model_() should provide non NULL value, so just abort if it's not so. While at it drop cpu_common_class_by_name() which is not need any more as every target has CPUClass::class_by_name callbac

[Qemu-devel] [PULL 3/7] tests: add machine 'none' with -cpu test

2018-03-12 Thread Eduardo Habkost
From: Igor Mammedov Check that "$QEMU -M none -cpu FOO" starts QEMU without error Signed-off-by: Igor Mammedov Message-Id: <151827-274608-3-git-send-email-imamm...@redhat.com> [ehabkost: include qmp/qdict.h instead of qmp/types.h] Signed-off-by: Eduardo Habkost --- tests/machine-none-test

[Qemu-devel] [PULL 2/7] nios2: 10m50_devboard: replace cpu_model with cpu_type

2018-03-12 Thread Eduardo Habkost
From: Igor Mammedov use cpu_create() instead of being removed cpu_generic_init() Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Message-Id: <151827-274608-2-git-send-email-imamm...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/nios2/10m50_devboard.c | 2 +- 1 file changed,

[Qemu-devel] [PULL 1/7] pc: correct misspelled CPU model-id for pc 2.2

2018-03-12 Thread Eduardo Habkost
From: Wang Xin Signed-off-by: Wang Xin Message-Id: <1517367668-25048-1-git-send-email-wangxinxin.w...@huawei.com> Acked-by: Michael S. Tsirkin Signed-off-by: Eduardo Habkost --- include/hw/i386/pc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/i386/pc.h b/inc

[Qemu-devel] [PULL 0/7] Machine queue, 2018-03-12

2018-03-12 Thread Eduardo Habkost
The following changes since commit 6ceb1b51f05f9e1892d082960ed602dca7b6696e: Merge remote-tracking branch 'remotes/kraxel/tags/audio-20180312-pull-request' into staging (2018-03-12 16:14:37 +) are available in the Git repository at: git://github.com/ehabkost/qemu.git tags/ma

Re: [Qemu-devel] [PATCH v6 7/9] vfio/display: core & wireup

2018-03-12 Thread Alex Williamson
On Mon, 5 Mar 2018 09:52:39 +0100 Erik Skultety wrote: > > diff --git a/hw/vfio/display.c b/hw/vfio/display.c > > new file mode 100644 > > index 00..3e997f8a44 > > --- /dev/null > > +++ b/hw/vfio/display.c > > @@ -0,0 +1,56 @@ > > +/* > > + * display support for mdev based vgpu devices >

Re: [Qemu-devel] [PATCH 0/5] nbd server fixing and refactoring before BLOCK_STATUS

2018-03-12 Thread Eric Blake
On 03/08/2018 12:46 PM, Vladimir Sementsov-Ogievskiy wrote: 01 and 02 are splitted and updated "[PATCH] nbd/server: fix space read", others are new. Vladimir Sementsov-Ogievskiy (5): nbd/server: move nbd_co_send_structured_error up nbd/server: fix sparse read nbd/server: fix: check clie

Re: [Qemu-devel] [PATCH] nbd/server: Honor FUA request on NBD_CMD_TRIM

2018-03-12 Thread Eric Blake
On 03/07/2018 04:57 PM, Eric Blake wrote: The NBD spec states that since trim requests can affect disk contents, then they should allow for FUA semantics just like writes for ensuring the disk has settled before returning. As bdrv_[co_]pdiscard() does not (yet?) support a flags argument, we can'

Re: [Qemu-devel] [PATCH 5/5] include/block/block_int: Document protocol related functions

2018-03-12 Thread Fabiano Rosas
On 2018-03-12 10:50, Max Reitz wrote: > A driver doesn't need to be a protocol driver for this, and technically > a protocol driver doesn't need to set this. Maybe we should rename it > to "filename_prefix"...? Yes, something that is closer to the filename string and farther from the notion of w

[Qemu-devel] qemu-user issue when used with uclibc-ng

2018-03-12 Thread Dave Flogeras
Hi, I use qemu-user on Gentoo to form a qemu+binfmt+chroot setup to build packages targeting an arm uclibc-ng based system. The process is described here: https://wiki.gentoo.org/wiki/Embedded_Handbook/General/Compiling_with_qemu_user_chroot After upgrading to uclibc-ng-1.0.26 I would get the fo

Re: [Qemu-devel] [PATCH V3 0/4] vfio: Introduce Live migration capability to vfio_mdev device

2018-03-12 Thread Alex Williamson
[cc +Juan] On Mon, 5 Mar 2018 14:00:49 +0800 Yulei Zhang wrote: > Summary > > This series RFC would like to resume the discussion about how to > introduce the live migration capability to vfio mdev device. > > By adding a new vfio subtype region VFIO_REGION_SUBTYPE_DEVICE_STATE, > the mdev d

[Qemu-devel] [PULL 4/4] device-crash-test: Use 'python' binary

2018-03-12 Thread Eduardo Habkost
Now the script works with Python 3, so we can use the 'python' binary provided by the system. Signed-off-by: Eduardo Habkost Message-Id: <20180312185503.5746-4-ehabk...@redhat.com> Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost --- scripts/device-crash-test | 2 +- 1 file chang

[Qemu-devel] [PULL 1/4] device-crash-test: New known crashes

2018-03-12 Thread Eduardo Habkost
We are not running the script on "make check" yet, and additional bugs were introduced recently in the tree. Whitelist the new crashes while we investigate, to allow us to run device-crash-test on "make check" as soon as possible to prevent new bugs. Cc: Pavel Pisa Cc: John Snow Signed-off-by:

[Qemu-devel] [PULL 2/4] qemu.py: Use items() instead of iteritems()

2018-03-12 Thread Eduardo Habkost
items() is less efficient on Python 2.x, but makes the code work on both Python 2 and Python 3. Cc: Lukáš Doktor Cc: Philippe Mathieu-Daudé Cc: Cleber Rosa Signed-off-by: Eduardo Habkost Message-Id: <20180312185503.5746-2-ehabk...@redhat.com> Reviewed-by: Daniel P. Berrangé Signed-off-by: Edu

[Qemu-devel] [PULL 0/4] Python queue, 2018-03-12

2018-03-12 Thread Eduardo Habkost
The following changes since commit 6ceb1b51f05f9e1892d082960ed602dca7b6696e: Merge remote-tracking branch 'remotes/kraxel/tags/audio-20180312-pull-request' into staging (2018-03-12 16:14:37 +) are available in the Git repository at: git://github.com/ehabkost/qemu.git tags/p

[Qemu-devel] [PATCH v2 4/5] block/blkreplay: Remove protocol-related fields

2018-03-12 Thread Fabiano Rosas
The blkreplay driver is not a protocol so it should implement bdrv_open instead of bdrv_file_open and not provide a protocol_name. Attempts to invoke this driver using protocol syntax (i.e. blkreplay:) will now fail gracefully: $ qemu-img info blkreplay:foo qemu-img: Could not open 'blkreplay

[Qemu-devel] [PULL 3/4] qmp.py: Encode json data before sending

2018-03-12 Thread Eduardo Habkost
On Python 3, json.dumps() return a str object, which can't be sent directly through a socket and must be encoded into a bytes object. Use .encode('utf-8'), which will work on both Python 2 and Python 3. Signed-off-by: Eduardo Habkost Message-Id: <20180312185503.5746-3-ehabk...@redhat.com> Review

[Qemu-devel] [PATCH v2 5/5] include/block/block_int: Document protocol related functions

2018-03-12 Thread Fabiano Rosas
Clarify that: - for protocols the brdv_file_open function is used instead of bdrv_open; - when protocol_name is set, a driver should expect to be given only a filename and no other options. Signed-off-by: Fabiano Rosas --- include/block/block_int.h | 8 1 file changed, 8 insertions(+)

[Qemu-devel] [PATCH v2 3/5] block/throttle: Remove protocol-related fields

2018-03-12 Thread Fabiano Rosas
The throttle driver is not a protocol so it should implement bdrv_open instead of bdrv_file_open and not provide a protocol_name. Attempts to invoke this driver using protocol syntax (i.e. throttle:) will now fail gracefully: $ qemu-img info throttle:foo qemu-img: Could not open 'throttle:foo

[Qemu-devel] [PATCH v2 0/5] block: Ensure non-protocol drivers can only be selected explicitly

2018-03-12 Thread Fabiano Rosas
Block drivers can be selected by either protocol syntax: :[:options] or explicitly: driver=[,option=...] For the protocol syntax to work, drivers should set the protocol_name field of the BlockDriver structure and provide bdrv_file_open and bdrv_parse_filename implementations. Conversely,

[Qemu-devel] [PATCH v2 1/5] block/replication: Remove protocol_name field

2018-03-12 Thread Fabiano Rosas
The protocol_name field is used when selecting a driver via protocol syntax (i.e. :). Drivers that are only selected explicitly (e.g. driver=replication,mode=primary,...) should not have a protocol_name. This patch removes the protocol_name field from the brdv_replication structure so that attempt

[Qemu-devel] [PATCH v2 2/5] block/quorum: Remove protocol-related fields

2018-03-12 Thread Fabiano Rosas
The quorum driver is not a protocol so it should implement bdrv_open instead of bdrv_file_open and not provide a protocol_name. Attempts to invoke this driver using protocol syntax (i.e. quorum:) will now fail gracefully: $ qemu-img info quorum:foo qemu-img: Could not open 'quorum:foo': Unkno

Re: [Qemu-devel] [PATCH v2 1/2] iotest 033: add misaligned write-zeroes test via truncate

2018-03-12 Thread Eric Blake
On 02/23/2018 07:34 AM, Max Reitz wrote: On 2018-02-12 14:14, Anton Nefedov wrote: This new test case only makes sense for qcow2 while iotest 033 is generic; however it matches the test purpose perfectly and also 033 contains those do_test() tricks to pass the alignment, which won't look nice be

Re: [Qemu-devel] [PATCH 3/5] nbd/server: fix: check client->closing before reply sending

2018-03-12 Thread Eric Blake
On 03/09/2018 03:51 PM, Eric Blake wrote: On 03/08/2018 12:46 PM, Vladimir Sementsov-Ogievskiy wrote: In the subject: s/reply sending/sending reply/ Signed-off-by: Vladimir Sementsov-Ogievskiy --- It's like an RFC. I'm not sure, but this place looks like a bug. Shouldn't we chack client-cl

Re: [Qemu-devel] [PATCH 7/7] vpc: Support .bdrv_co_create

2018-03-12 Thread Max Reitz
On 2018-03-09 22:46, Kevin Wolf wrote: > This adds the .bdrv_co_create driver callback to vpc, which > enables image creation over QMP. > > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 33 ++- > block/vpc.c | 152 > ++

Re: [Qemu-devel] [RFC PATCH 16/30] q35/xen: Add Xen platform device support for Q35

2018-03-12 Thread Eduardo Habkost
On Tue, Mar 13, 2018 at 06:56:37AM +1000, Alexey G wrote: > On Mon, 12 Mar 2018 16:44:06 -0300 > Eduardo Habkost wrote: > > >On Tue, Mar 13, 2018 at 04:34:01AM +1000, Alexey Gerasimenko wrote: > >> Current Xen/QEMU method to control Xen Platform device on i440 is a > >> bit odd -- enabling/disabl

Re: [Qemu-devel] [PATCH 6/7] vhdx: Support .bdrv_co_create

2018-03-12 Thread Max Reitz
On 2018-03-09 22:46, Kevin Wolf wrote: > This adds the .bdrv_co_create driver callback to vhdx, which > enables image creation over QMP. > > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 37 ++- > block/vhdx.c | 174 > ++---

Re: [Qemu-devel] [PATCH 1/1] block: fix iotest 146 output expectations

2018-03-12 Thread Eric Blake
On 03/12/2018 04:29 PM, Jeff Cody wrote: Commit bff5554843 added "force_size" into the common.filter for _filter_img_create(), but test 146 still expects it in the output. Signed-off-by: Jeff Cody --- tests/qemu-iotests/146.out | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed

Re: [Qemu-devel] [PATCH 3/7] qcow: Support .bdrv_co_create

2018-03-12 Thread Jeff Cody
On Fri, Mar 09, 2018 at 10:46:07PM +0100, Kevin Wolf wrote: > This adds the .bdrv_co_create driver callback to qcow, which > enables image creation over QMP. > > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 21 +- > block/qcow.c | 196 > +

Re: [Qemu-devel] [PATCH 2/7] qemu-iotests: Enable write tests for parallels

2018-03-12 Thread Jeff Cody
On Fri, Mar 09, 2018 at 10:46:06PM +0100, Kevin Wolf wrote: > Originally we added parallels as a read-only format to qemu-iotests > where we did just some tests with a binary image. Since then, write and > image creation support has been added to the driver, so we can now > enable it in _supported_

Re: [Qemu-devel] [PATCH 1/7] parallels: Support .bdrv_co_create

2018-03-12 Thread Jeff Cody
On Fri, Mar 09, 2018 at 10:46:05PM +0100, Kevin Wolf wrote: > This adds the .bdrv_co_create driver callback to parallels, which > enables image creation over QMP. > > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 18 - > block/parallels.c| 199 > +

[Qemu-devel] [PATCH 1/1] block: fix iotest 146 output expectations

2018-03-12 Thread Jeff Cody
Commit bff5554843 added "force_size" into the common.filter for _filter_img_create(), but test 146 still expects it in the output. Signed-off-by: Jeff Cody --- tests/qemu-iotests/146.out | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/146.out b/tests/qemu-i

Re: [Qemu-devel] [PATCH 5/7] vdi: Support .bdrv_co_create

2018-03-12 Thread Max Reitz
On 2018-03-09 22:46, Kevin Wolf wrote: > This adds the .bdrv_co_create driver callback to vdi, which > enables image creation over QMP. > > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 21 ++- > block/vdi.c | 169 > ++- >

Re: [Qemu-devel] [PATCH 4/7] qed: Support .bdrv_co_create

2018-03-12 Thread Max Reitz
On 2018-03-09 22:46, Kevin Wolf wrote: > This adds the .bdrv_co_create driver callback to qed, which > enables image creation over QMP. > > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 25 ++- > block/qed.c | 204 > ++- >

Re: [Qemu-devel] [PATCH] iotests: Fix stuck NBD process on 33

2018-03-12 Thread Max Reitz
On 2018-03-12 22:11, Eric Blake wrote: > Commit afe35cde6 added additional actions to test 33, but forgot > to reset the image between tests. As a result, './check -nbd 33' > fails because the qemu-nbd process from the first half is still > occupying the port, preventing the second half from start

[Qemu-devel] [PATCH] iotests: Fix stuck NBD process on 33

2018-03-12 Thread Eric Blake
Commit afe35cde6 added additional actions to test 33, but forgot to reset the image between tests. As a result, './check -nbd 33' fails because the qemu-nbd process from the first half is still occupying the port, preventing the second half from starting a new qemu-nbd process. Worse, the failure

[Qemu-devel] [PATCH v4 5/5] target/i386: Remove generic SMT thread check

2018-03-12 Thread Babu Moger
Remove generic non-intel check while validating hyperthreading support. Certain AMD CPUs can support hyperthreading now. CPU family with TOPOEXT feature can support hyperthreading now. Signed-off-by: Babu Moger --- target/i386/cpu.c | 15 +-- 1 file changed, 9 insertions(+), 6 delet

[Qemu-devel] [PATCH v4 0/5] Enable TOPOEXT to support hyperthreading on AMD CPU

2018-03-12 Thread Babu Moger
This series enables the TOPOEXT feature for AMD CPUs. This is required to support hyperthreading on kvm guests. This addresses the issues reported in these bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1481253 https://bugs.launchpad.net/qemu/+bug/1703506 v4: 1.Removed the checks under cpuid

[Qemu-devel] [PATCH v4 4/5] target/i386: Enable TOPOEXT feature on AMD EPYC CPU

2018-03-12 Thread Babu Moger
Enable TOPOEXT feature on EPYC CPU. This is required to support hyperthreading on VM guests. Also extend xlevel to 0x801E. Signed-off-by: Babu Moger --- target/i386/cpu.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c ind

[Qemu-devel] [PATCH v4 2/5] target/i386: Populate AMD Processor Cache Information

2018-03-12 Thread Babu Moger
From: Stanislav Lanci Add information for cpuid 0x801D leaf. Populate cache topology information for different cache types(Data Cache, Instruction Cache, L2 and L3) supported by 0x801D leaf. Please refer Processor Programming Reference (PPR) for AMD Family 17h Model for more details. Sig

[Qemu-devel] [PATCH v4 3/5] target/i386: Add support for CPUID_8000_001E for AMD

2018-03-12 Thread Babu Moger
From: Stanislav Lanci Populate threads/core_id/apic_ids/socket_id when CPUID_EXT3_TOPOEXT feature is supported. This is required to support hyperthreading feature on AMD CPUs. This is supported via CPUID_8000_001E extended functions. Signed-off-by: Stanislav Lanci Signed-off-by: Babu Moger ---

[Qemu-devel] [PATCH v4 1/5] target/i386: Generalize some of the macro definitions

2018-03-12 Thread Babu Moger
Generalize some of the macro definitions which are generic cache properties that are common between CPUID 4 and CPUID 0x801D in preparation for adding support for 0x801D. Signed-off-by: Babu Moger --- target/i386/cpu.c | 52 ++-- 1 file cha

Re: [Qemu-devel] [RFC PATCH 16/30] q35/xen: Add Xen platform device support for Q35

2018-03-12 Thread Alexey G
On Mon, 12 Mar 2018 16:44:06 -0300 Eduardo Habkost wrote: >On Tue, Mar 13, 2018 at 04:34:01AM +1000, Alexey Gerasimenko wrote: >> Current Xen/QEMU method to control Xen Platform device on i440 is a >> bit odd -- enabling/disabling Xen platform device actually modifies >> the QEMU emulated machine

[Qemu-devel] [PULL 10/36] block: Handle null backing link

2018-03-12 Thread Eric Blake
From: Max Reitz Instead of converting all "backing": null instances into "backing": "", handle a null value directly in bdrv_open_inherit(). This enables explicitly null backing links for json:{} filenames. Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Message-Id: <20180224154033.29559

[Qemu-devel] [PATCH 1/3] qemu.py: Use items() instead of iteritems()

2018-03-12 Thread Eduardo Habkost
items() is less efficient on Python 2.x, but makes the code work on both Python 2 and Python 3. Cc: Lukáš Doktor Cc: Philippe Mathieu-Daudé Cc: Cleber Rosa Signed-off-by: Eduardo Habkost --- scripts/qemu.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qemu.py b/

[Qemu-devel] [PATCH 09/11] target/m68k: implement ftanh

2018-03-12 Thread Laurent Vivier
Using local m68k floatx80_tanh() and floatx80_etoxm1() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 5 + target/m68k/helper.h | 1 + target/m68k/softfloat.c | 366 +++

[Qemu-devel] [PATCH 10/11] target/m68k: implement fsinh

2018-03-12 Thread Laurent Vivier
Using a local m68k floatx80_sinh() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 5 +++ target/m68k/helper.h | 1 + target/m68k/softfloat.c | 89

[Qemu-devel] [PATCH 11/11] target/m68k: implement fcosh

2018-03-12 Thread Laurent Vivier
Using a local m68k floatx80_cosh() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 5 +++ target/m68k/helper.h | 1 + target/m68k/softfloat.c | 81 +++

[Qemu-devel] [PATCH 06/11] target/m68k: implement fasin

2018-03-12 Thread Laurent Vivier
Using a local m68k floatx80_asin() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 5 target/m68k/helper.h | 1 + target/m68k/softfloat.c | 65 +++

[Qemu-devel] [PATCH 05/11] target/m68k: implement fatan

2018-03-12 Thread Laurent Vivier
Using a local m68k floatx80_atan() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c| 5 + target/m68k/helper.h| 1 + target/m68k/softfloat.c | 200 ++

[Qemu-devel] [PATCH 08/11] target/m68k: implement fatanh

2018-03-12 Thread Laurent Vivier
Using a local m68k floatx80_atanh() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 5 target/m68k/helper.h | 1 + target/m68k/softfloat.c | 65 ++

[Qemu-devel] [PULL 07/36] qapi: Replace qobject_to_X(o) by qobject_to(X, o)

2018-03-12 Thread Eric Blake
From: Max Reitz This patch was generated using the following Coccinelle script: @@ expression Obj; @@ ( - qobject_to_qnum(Obj) + qobject_to(QNum, Obj) | - qobject_to_qstring(Obj) + qobject_to(QString, Obj) | - qobject_to_qdict(Obj) + qobject_to(QDict, Obj) | - qobject_to_qlist(Obj) + qobject_to(

[Qemu-devel] [PATCH 01/11] target/m68k: implement ftan

2018-03-12 Thread Laurent Vivier
Using a local m68k floatx80_tan() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c| 5 + target/m68k/helper.h| 1 + target/m68k/softfloat.c | 210 +++

[Qemu-devel] [PATCH 04/11] target/m68k: implement fsincos

2018-03-12 Thread Laurent Vivier
using floatx80_sin() and floatx80_cos() Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 11 +++ target/m68k/helper.h | 1 + target/m68k/translate.c | 8 3 files changed, 20 insertions(+) diff --git a/target/m68k/fpu_helper.c b/target/m68k/fpu_helper.c index

[Qemu-devel] [PATCH 03/11] target/m68k: implement fcos

2018-03-12 Thread Laurent Vivier
Using a local m68k floatx80_cos() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 5 + target/m68k/helper.h | 1 + target/m68k/softfloat.c | 244

[Qemu-devel] [PULL 03/36] qlit: add qobject_from_qlit()

2018-03-12 Thread Eric Blake
From: Marc-André Lureau Instantiate a QObject* from a literal QLitObject. LitObject only supports int64_t for now. uint64_t and double aren't implemented. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Message-Id: <20180305172951.2150-4-marcandre.lur...@redhat.com> Signed-of

[Qemu-devel] [PATCH 02/11] target/m68k: implement fsin

2018-03-12 Thread Laurent Vivier
Using a local m68k floatx80_sin() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 5 + target/m68k/helper.h | 1 + target/m68k/softfloat.c | 247

[Qemu-devel] [PATCH 07/11] target/m68k: implement facos

2018-03-12 Thread Laurent Vivier
Using a local m68k floatx80_acos() [copied from previous: Written by Andreas Grabher for Previous, NeXT Computer Emulator.] Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 5 target/m68k/helper.h | 1 + target/m68k/softfloat.c | 70 +++

[Qemu-devel] [PATCH 00/11] implement 680x0 FPU (part 5)

2018-03-12 Thread Laurent Vivier
Implement fcosh, fsinh, ftanh, fatanh, facos, fasin, fatan, fsincos, fcos, fsin, ftan. This is the last series to implement FPU instructions for 680x0... As previously, all the floatx80 functions are copied from "Previous", the NeXT Computer Emulator, and written by Andreas Grabher. I did not im

Re: [Qemu-devel] [PULL 0/9] Socket next patches

2018-03-12 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180312201305.16972-1-berra...@redhat.com Subject: [Qemu-devel] [PULL 0/9] Socket next patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline

[Qemu-devel] [PULL 2/9] cutils: add qemu_strtoi & qemu_strtoui parsers for int/unsigned int types

2018-03-12 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" There are qemu_strtoNN functions for various sized integers. This adds two more for plain int & unsigned int types, with suitable range checking. Reviewed-by: Eric Blake Reviewed-by: Marc-André Lureau Signed-off-by: Daniel P. Berrange --- include/qemu/cutils.h |

[Qemu-devel] [PULL 3/9] sockets: pull code for testing IP availability out of specific test

2018-03-12 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" The test-io-channel-socket.c file has some useful helper functions for checking if a specific IP protocol is available. Other tests need to perform similar kinds of checks to avoid running tests that will fail due to missing IP protocols. Reviewed-by: Eric Blake Revie

[Qemu-devel] [PULL 9/9] char: allow passing pre-opened socket file descriptor at startup

2018-03-12 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" When starting QEMU management apps will usually setup a monitor socket, and then open it immediately after startup. If not using QEMU's own -daemonize arg, this process can be troublesome to handle correctly. The mgmt app will need to repeatedly call connect() until it

[Qemu-devel] [PULL 4/9] sockets: strengthen test suite IP protocol availability checks

2018-03-12 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" Instead of just checking whether it is possible to bind() on a socket, also check that we can successfully connect() to the socket we bound to. This more closely replicates the level of functionality that tests will actually use. Reviewed-by: Eric Blake Reviewed-by: M

[Qemu-devel] [PULL 11/36] block: Deprecate "backing": ""

2018-03-12 Thread Eric Blake
From: Max Reitz We have a clear replacement, so let's deprecate it. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia Message-Id: <20180224154033.29559-8-mre...@redhat.com> Signed-off-by: Eric Blake --- qemu-doc.texi| 7 +++ qapi/block-core.json | 4 ++

[Qemu-devel] [PULL 8/9] char: refactor parsing of socket address information

2018-03-12 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" To prepare for handling more address types, refactor the parsing of socket address information to make it more robust and extensible. Reviewed-by: Eric Blake Reviewed-by: Marc-André Lureau Signed-off-by: Daniel P. Berrange --- chardev/char-socket.c | 22 +++

[Qemu-devel] [PULL 6/9] sockets: check that the named file descriptor is a socket

2018-03-12 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" The SocketAddress struct has an "fd" type, which references the name of a file descriptor passed over the monitor using the "getfd" command. We currently blindly assume the FD is a socket, which can lead to hard to diagnose errors later. This adds an explicit check that

[Qemu-devel] [PULL 0/9] Socket next patches

2018-03-12 Thread Daniel P . Berrangé
The following changes since commit 819fd4699c7b36d574292bcbd8bc25e9d716c84b: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20180309a' into staging (2018-03-12 13:21:53 +) are available in the Git repository at: https://github.com/berrange/qemu tags/socket-next-pull-

[Qemu-devel] [PULL 7/9] sockets: allow SocketAddress 'fd' to reference numeric file descriptors

2018-03-12 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" The SocketAddress 'fd' kind accepts the name of a file descriptor passed to the monitor with the 'getfd' command. This makes it impossible to use the 'fd' kind in cases where a monitor is not available. This can apply in handling command line argv at startup, or simply

[Qemu-devel] [PULL 5/9] sockets: move fd_is_socket() into common sockets code

2018-03-12 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" The fd_is_socket() helper method is useful in a few places, so put it in the common sockets code. Make the code more compact while moving it. Reviewed-by: Eric Blake Reviewed-by: Marc-André Lureau Signed-off-by: Daniel P. Berrange --- include/qemu/sockets.h| 1

[Qemu-devel] [PULL 1/9] char: don't silently skip tn3270 protocol init when TLS is enabled

2018-03-12 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" Even if common tn3270 implementations do not support TLS, it is trivial to have them proxied over a proxy like stunnel which adds TLS at the sockets layer. We should thus not silently skip tn3270 protocol initialization when TLS is enabled. Reviewed-by: Eric Blake Ack

[Qemu-devel] [PULL 28/36] qapi: introduce new cmd option "allow-oob"

2018-03-12 Thread Eric Blake
From: Peter Xu Here "oob" stands for "Out-Of-Band". When "allow-oob" is set, it means the command allows out-of-band execution. The "oob" idea is proposed by Markus Armbruster in following thread: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg02057.html This new "allow-oob" boole

[Qemu-devel] [PULL 2/3] i386: Add Intel Processor Trace feature support

2018-03-12 Thread Eduardo Habkost
From: Chao Peng Expose Intel Processor Trace feature to guest. To make Intel PT live migration safe and get same CPUID information with same CPU model on diffrent host. CPUID[14] is constant in this patch. Intel PT use EPT is first supported in IceLake, the CPUID[14] get on this machine as defau

[Qemu-devel] [PULL 1/3] target-i386: add KVM_HINTS_DEDICATED performance hint

2018-03-12 Thread Eduardo Habkost
From: Wanpeng Li Add KVM_HINTS_DEDICATED performance hint, guest checks this feature bit to determine if they run on dedicated vCPUs, allowing optimizations such as usage of qspinlocks. Cc: Paolo Bonzini Cc: Radim Krčmář Cc: Eduardo Habkost Signed-off-by: Wanpeng Li Message-Id: <1518185725-6

  1   2   3   4   5   6   >