Re: [Qemu-devel] [PATCH v2] scripts/checkpatch.pl: Bug fix

2018-03-15 Thread Su Hang
Because I generate my first patch on master, it should work. I have a little trouble understanding what Mr.Peter wants me to do, would you please spare a little of your time and have a look at it? It will help me. Please... Su Hang > -Original Messages- > From: "Fam Zheng" > Sent Time:

[Qemu-devel] [PATCH for-2.13 v3 2/2] tests: Use query-usernet instead of 'info usernet'

2018-03-15 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Eric Blake --- tests/vm/basevm.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 686d88decf..f51604e0ab 100755 --- a/tests/vm/basevm.py +++ b/tests/vm/basevm.py @@ -101,7 +101,

[Qemu-devel] [PATCH for-2.13 v3 1/2] slirp: Add "query-usernet" QMP command

2018-03-15 Thread Fam Zheng
HMP "info usernet" has been available but it isn't ideal for programmed use cases. This closes the gap in QMP by adding a counterpart "query-usernet" command. It is basically translated from the HMP slirp_connection_info() loop, which now calls the QMP implementation and prints the data, just like

[Qemu-devel] [PATCH for-2.13 v3 0/2] slirp: Add query-usernet QMP command

2018-03-15 Thread Fam Zheng
v3: - Add Eric's rev-by to patch 2. - Address Eric's comments on patch 1: * Fix spell/grammar: "programmed", "awaiting". * Fix include "qapi/qapi-commands-net.h". * Underscores to dashes. * "Since 2.13" now. v2: Fix compiler error. [patchew] The command is a counterpar

Re: [Qemu-devel] [PATCH v2] scripts/checkpatch.pl: Bug fix

2018-03-15 Thread Fam Zheng
On Fri, 03/16 10:58, Su Hang wrote: > (Sorry, I don't know this patch should base on which commit, > so I generate this patch based on > commit:fb8446d94ec7a3dc0c3a7e7da672406476f075ac, > I choose this by `git log -2 scripts/checkpath.pl`. > Sincerely say sorry, if I have misunderstand any mean

Re: [Qemu-devel] [PATCH v2 0/3] Add new CD-ROM related qtests

2018-03-15 Thread Hervé Poussineau
Le 16/03/2018 à 06:39, Thomas Huth a écrit : With one of my clean-up patches (see commit 1454509726719e0933c800), I recently accidentially broke the "-cdrom" parameter (more precisely "-drive if=scsi") on a couple of boards, since there was no error detected during the "make check" regression tes

[Qemu-devel] [PATCH v2 3/3] tests/cdrom-test: Test that -cdrom parameter is working

2018-03-15 Thread Thomas Huth
Commit 1454509726719e0933c800 recently broke the "-cdrom" parameter on a couple of boards without us noticing it immediately. Thus let's add a test which checks that "-cdrom" can at least be used to start QEMU with certain machine types. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas H

[Qemu-devel] [PATCH v2 1/3] tests/boot-sector: Add magic bytes to s390x boot code header

2018-03-15 Thread Thomas Huth
We're going to use the s390x boot code for testing CD-ROM booting. But the ISO loader of the s390-ccw bios is a little bit more picky than the network loader and expects some magic bytes in the header of the file (see linux_s390_magic in pc-bios/s390-ccw/bootmap.c), so we've got to add them in our

[Qemu-devel] [PATCH v2 2/3] tests/cdrom-test: Test booting from CD-ROM ISO image file

2018-03-15 Thread Thomas Huth
We already have the code for a boot file in tests/boot-sector.c, so if the genisoimage program is available, we can easily create a bootable CD ISO image that we can use for testing whether our CD-ROM emulation and the BIOS CD-ROM boot works correctly. Signed-off-by: Thomas Huth --- tests/Makefi

[Qemu-devel] [PATCH v2 0/3] Add new CD-ROM related qtests

2018-03-15 Thread Thomas Huth
With one of my clean-up patches (see commit 1454509726719e0933c800), I recently accidentially broke the "-cdrom" parameter (more precisely "-drive if=scsi") on a couple of boards, since there was no error detected during the "make check" regression testing. This is clearly an indication that we are

Re: [Qemu-devel] [PATCH v2 3/3] vfio/pci: Add ioeventfd support

2018-03-15 Thread Peter Xu
On Thu, Mar 15, 2018 at 03:31:58PM -0600, Alex Williamson wrote: > The ioeventfd here is actually irqfd handling of an ioeventfd such as > supported in KVM. A user is able to pre-program a device write to > occur when the eventfd triggers. This is yet another instance of > eventfd-irqfd triggerin

Re: [Qemu-devel] [PATCH v4 14/29] libvhost-user+postcopy: Register new regions with the ufd

2018-03-15 Thread Peter Xu
On Thu, Mar 15, 2018 at 09:41:00AM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Mon, Mar 12, 2018 at 01:23:21PM +, Dr. David Alan Gilbert wrote: > > > * Peter Xu (pet...@redhat.com) wrote: > > > > On Thu, Mar 08, 2018 at 07:57:56PM +, Dr. David Alan Gi

Re: [Qemu-devel] Using new TCG Vector infrastructure in PowerPC

2018-03-15 Thread Nikunj A Dadhania
Richard Henderson writes: > On 03/07/2018 06:03 PM, Nikunj A Dadhania wrote: >> Hi Richard, >> >> I was working to get TCG vector support for PowerPC[1]. Started with >> converting logical operations like vector AND/OR/XOR and compare >> instructions. Found some inconsistency during my testing o

Re: [Qemu-devel] [PATCH v10 19/24] migration: Create multifd channels

2018-03-15 Thread Peter Xu
On Thu, Mar 15, 2018 at 01:57:54PM +0100, Juan Quintela wrote: > Peter Xu wrote: > > On Wed, Mar 07, 2018 at 12:00:05PM +0100, Juan Quintela wrote: > >> In both sides. We still don't transmit anything through them. > > > > s/In/On/? > > > >> > >> Signed-off-by: Juan Quintela > >> --- > >> migr

[Qemu-devel] [PATCH v2] scripts/checkpatch.pl: Bug fix

2018-03-15 Thread Su Hang
checkpatch.pl stops complaining about following pattern: """ do { //do somethins; } while (conditions); """ One things need to be mentioned: Becasue `if`, `while` and `for` check have been done in this `if` block(Line: 2356), and this block contains following statement: """ Line: 2379 $suppres

Re: [Qemu-devel] [PATCH] docker: fedora: test more components

2018-03-15 Thread Fam Zheng
On Thu, 03/15 14:47, Daniel P. Berrangé wrote: > On Tue, Mar 13, 2018 at 01:05:52PM +0100, Paolo Bonzini wrote: > > Install optional dependencies of QEMU to get better coverage. > > > > Signed-off-by: Paolo Bonzini > > --- > > tests/docker/dockerfiles/fedora.docker | 13 ++--- > > 1 file

Re: [Qemu-devel] [PATCH] i386: add KNM cpu model

2018-03-15 Thread Boqun Feng
On Wed, Mar 14, 2018 at 01:01:30PM +, Daniel P. Berrangé wrote: > On Wed, Mar 14, 2018 at 03:29:59PM +0800, Boqun Feng wrote: > > A new cpu model called "KNM" is added to model Knights Mill processors. > > Why the obscure acryonym? Can't we just call it KnightsMill so it is > obvious what it i

Re: [Qemu-devel] [PATCH v2] docker: dump 'config.log' if ./configure fails

2018-03-15 Thread Fam Zheng
On Thu, 03/15 15:27, Philippe Mathieu-Daudé wrote: > Suggested-by: Eric Blake > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Daniel P. Berrangé > --- > v2: > - avoid subshell using { ; } (Eric) > - use test_fail() instead of prep_fail() (Fam) > > tests/docker/common.rc | 4 +++- > 1 fi

[Qemu-devel] [PATCH v3 0/7] s390x: vfio-ap: guest dedicated crypto adapters

2018-03-15 Thread Tony Krowiak
This patch series is the QEMU counterpart to the KVM/kernel support for guest dedicated crypto adapters. The KVM/kernel model is built on the VFIO mediated device framework and provides the infrastructure for granting exclusive guest access to crypto devices installed on the linux host. This pa

[Qemu-devel] [PATCH v3 7/7] s390: doc: detailed specifications for AP virtualization

2018-03-15 Thread Tony Krowiak
This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how to configure AP devices for exclusive use of KVM guests. Signed-off-by: Tony Krowiak --- docs/vfio-ap.txt | 624 ++

[Qemu-devel] [PATCH v3 3/7] s390x/cpumodel: Set up CPU model for AP device support

2018-03-15 Thread Tony Krowiak
A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. CPU model features: 1. The KVM_S390_VM_CPU_FEAT_AP CPU model feature indicates that AP facilities are installed. This feature will be enabled by the kernel only if the AP facilitie

[Qemu-devel] [PATCH v3 4/7] s390x/kvm: interface to interpret AP instructions

2018-03-15 Thread Tony Krowiak
The VFIO AP device exploits interpretive execution of AP instructions (APIE). APIE is enabled by setting a device attribute via the KVM_SET_DEVICE_ATTR ioctl. Signed-off-by: Tony Krowiak --- target/s390x/kvm.c | 16 target/s390x/kvm_s390x.h |2 ++ 2 files changed, 18

[Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

2018-03-15 Thread Tony Krowiak
If the CPU model indicates that AP facility is installed on the guest (i.e., -cpu ,ap=on), then the expectation is that the AP bus running in the guest will initialize; however, if the AP instructions are not being interpreted by the firmware, then they will be intercepted and routed back to QE

[Qemu-devel] [PATCH v3 5/7] s390x/vfio: ap: Introduce VFIO AP device

2018-03-15 Thread Tony Krowiak
Introduces a VFIO based AP device. The device is defined via the QEMU command line by specifying: -device vfio-ap,sysfsdev= The mediated matrix device is created by the VFIO AP device driver by writing a UUID to a sysfs attribute file (see docs/vfio-ap.txt). The mediated matrix device will be

[Qemu-devel] [PATCH v3 1/7] linux-headers: linux header updates for AP support

2018-03-15 Thread Tony Krowiak
Updates the linux header files in preparation for introduction of the VFIO AP device: * Added a feature ID to indicate AP facilities are installed * Added a device attribute to the KVM_S390_VM_CRYPTO group to indicate whether AP instructions are to be interpreted * Added VFIO device informatio

[Qemu-devel] [PATCH v3 2/7] s390x/ap: base Adjunct Processor (AP) object

2018-03-15 Thread Tony Krowiak
This patch introduces the base object for an AP device. Signed-off-by: Tony Krowiak --- hw/s390x/Makefile.objs |1 + hw/s390x/ap-device.c | 38 ++ include/hw/s390x/ap-device.h | 38 ++ 3 files changed,

Re: [Qemu-devel] [PATCH 2/2] char: i.MX: Add support for "TX complete" interrupt

2018-03-15 Thread Bill Paul
Of all the gin joints in all the towns in all the world, Andrey Smirnov had to walk into mine at 12:11 on Thursday 15 March 2018 and say: > Add support for "TX complete"/TXDC interrupt generate by real HW since > it is needed to support guests other than Linux. > > Based on the patch by Bill Pau

Re: [Qemu-devel] [PATCH 2/2] char: i.MX: Add support for "TX complete" interrupt

2018-03-15 Thread Bill Paul
Of all the gin joints in all the towns in all the world, Bill Paul had to walk into mine at 13:45 on Thursday 15 March 2018 and say: > Of all the gin joints in all the towns in all the world, Andrey Smirnov had > to > > walk into mine at 12:11 on Thursday 15 March 2018 and say: > > Add support f

[Qemu-devel] [PATCH v2 1/3] vfio/pci: Pull BAR mapping setup from read-write path

2018-03-15 Thread Alex Williamson
This creates a common helper that we'll use for ioeventfd setup. Reviewed-by: Peter Xu Reviewed-by: Eric Auger Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci_rdwr.c | 39 ++ 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/driv

[Qemu-devel] [PATCH v2 0/3] vfio/pci: ioeventfd support

2018-03-15 Thread Alex Williamson
A vfio ioeventfd will perform the pre-specified device write on triggering of an eventfd. When coupled with KVM ioeventfds, this feature allows a VM to trap a device page for virtualization, while also registering targeted ioeventfds to maintain performance of high frequency register writes within

[Qemu-devel] [PATCH v2 3/3] vfio/pci: Add ioeventfd support

2018-03-15 Thread Alex Williamson
The ioeventfd here is actually irqfd handling of an ioeventfd such as supported in KVM. A user is able to pre-program a device write to occur when the eventfd triggers. This is yet another instance of eventfd-irqfd triggering between KVM and vfio. The impetus for this is high frequency writes to

[Qemu-devel] [PATCH v2 2/3] vfio/pci: Use endian neutral helpers

2018-03-15 Thread Alex Williamson
The iowriteXX/ioreadXX functions assume little endian hardware and convert to little endian on a write and from little endian on a read. We currently do our own explicit conversion to negate this. Instead, add some endian dependent defines to avoid all byte swaps. There should be no functional ch

Re: [Qemu-devel] [RFC PATCH] vfio/pci: Add ioeventfd support

2018-03-15 Thread Alex Williamson
On Tue, 13 Mar 2018 13:38:00 +0100 Auger Eric wrote: > On 08/02/18 02:22, Alexey Kardashevskiy wrote: > > On 08/02/18 01:12, Alex Williamson wrote: > >> On Wed, 7 Feb 2018 15:48:26 +1100 > >> Alexey Kardashevskiy wrote: > >>> On 07/02/18 15:25, Alex Williamson wrote: > On Wed, 7 Feb 2018

Re: [Qemu-devel] [PATCH 3/3] vfio/pci: Add ioeventfd support

2018-03-15 Thread Alex Williamson
On Wed, 7 Mar 2018 13:56:44 +0800 Peter Xu wrote: > On Wed, Feb 28, 2018 at 01:15:20PM -0700, Alex Williamson wrote: > > [...] > > > @@ -1174,6 +1206,8 @@ static int vfio_pci_probe(struct pci_dev *pdev, const > > struct pci_device_id *id) > > vdev->irq_type = VFIO_PCI_NUM_IRQS; > > mut

Re: [Qemu-devel] [PATCH qemu] fdc: Exit if ISA controller does not support DMA

2018-03-15 Thread John Snow
On 03/05/2018 05:15 AM, Thomas Huth wrote: > On 08.12.2017 22:29, John Snow wrote: >> >> On 11/21/2017 09:48 PM, Alexey Kardashevskiy wrote: >>> On 07/11/17 11:58, John Snow wrote: On 10/26/2017 02:46 AM, Alexey Kardashevskiy wrote: > A "powernv" machine type defines an ISA bus

Re: [Qemu-devel] [PATCH 3/3] vfio/pci: Add ioeventfd support

2018-03-15 Thread Alex Williamson
On Tue, 13 Mar 2018 14:12:34 +0100 Auger Eric wrote: > On 28/02/18 21:15, Alex Williamson wrote: > > +long vfio_pci_ioeventfd(struct vfio_pci_device *vdev, loff_t offset, > > + uint64_t data, int count, int fd) > > +{ > > + struct pci_dev *pdev = vdev->pdev; > > + loff_t pos

[Qemu-devel] [Bug 1753314] Re: UART in sabrelite machine simulation doesn't work with VxWorks 7

2018-03-15 Thread Peter Maydell
That's fine; Andrey Smirnov has taken your patch as a basis for a more cleaned-up set of changes: http://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg04608.html http://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg04609.html What we would like from you is a Signed-off-by: line to say

Re: [Qemu-devel] ARM64 Interrupt handling on QEMU

2018-03-15 Thread Peter Maydell
On 15 March 2018 at 20:24, Brijen Raval wrote: > On Thu, Mar 15, 2018 at 2:59 AM Peter Maydell > wrote: >> Exception 5 is IRQ. (These numbers are all internal to QEMU, and >> don't have any architectural or guest-visible relevance. They're >> the EXCP_* constants defined at the top of target/arm/

Re: [Qemu-devel] ARM64 Interrupt handling on QEMU

2018-03-15 Thread Brijen Raval
On Thu, Mar 15, 2018 at 2:59 AM Peter Maydell wrote: > On 15 March 2018 at 03:07, Brijen Raval wrote: > > I am booting up a custom kernel on QEMU ARM64, upon completion of its > > initial boot up it looks like it enters the arch_idle() state > > > > I enabled the -d int logging to understand wha

Re: [Qemu-devel] [PATCH 1/3] tests/boot-sector: Add magic bytes to s390x boot code header

2018-03-15 Thread Michael S. Tsirkin
On Thu, Mar 15, 2018 at 12:47:08PM +0100, Philippe Mathieu-Daudé wrote: > On 03/15/2018 08:49 AM, Thomas Huth wrote: > > We're going to use the s390x boot code for testing CD-ROM booting. > > But the ISO loader of the s390-ccw bios is a little bit more picky > > than the network loader and expects

[Qemu-devel] [PATCH] net/vde: print error on vde_open() failure

2018-03-15 Thread Julia Suvorova via Qemu-devel
Despite the fact that now when the initialization of vde fails, qemu does not end silently, no informative error is printed. The patch generates an error and pushes it through the calling function. Related bug: https://bugs.launchpad.net/qemu/+bug/676029 Signed-off-by: Julia Suvorova --- net/vd

Re: [Qemu-devel] Using new TCG Vector infrastructure in PowerPC

2018-03-15 Thread Richard Henderson
On 03/07/2018 06:03 PM, Nikunj A Dadhania wrote: > Hi Richard, > > I was working to get TCG vector support for PowerPC[1]. Started with > converting logical operations like vector AND/OR/XOR and compare > instructions. Found some inconsistency during my testing on x86 laptop > emulating PowerPC:

[Qemu-devel] [Bug 1753314] Re: UART in sabrelite machine simulation doesn't work with VxWorks 7

2018-03-15 Thread Bill Paul
As I said before: "I'm not submitting this as a patch to the development list as I'm not fully certain it complies with the hardware spec and doesn't break any other functionality." What I'm trying to say here is that while I may have been able to cobble together a hack to make the UART nominally

Re: [Qemu-devel] [PATCH v3 12/16] block/dirty-bitmap: Add bdrv_dirty_iter_next_area

2018-03-15 Thread John Snow
On 02/28/2018 01:05 PM, Max Reitz wrote: > This new function allows to look for a consecutively dirty area in a > dirty bitmap. > > Signed-off-by: Max Reitz > --- > include/block/dirty-bitmap.h | 2 ++ > block/dirty-bitmap.c | 55 > > 2 fi

Re: [Qemu-devel] [PATCH 1/5] multiboot: Reject kernels exceeding the address space

2018-03-15 Thread Jack Schwartz
On 03/15/18 10:18, Kevin Wolf wrote: Am 15.03.2018 um 17:55 hat Jack Schwartz geschrieben: On 03/15/18 08:54, Kevin Wolf wrote: Am 15.03.2018 um 06:19 hat Jack Schwartz geschrieben: Hi Kevin. My comments are inline... On 2018-03-14 10:32, Kevin Wolf wrote: The code path with a manually set

Re: [Qemu-devel] [PATCH 3/3] tests/cdrom-test: Test that -cdrom parameter is working

2018-03-15 Thread Thomas Huth
On 15.03.2018 12:42, Philippe Mathieu-Daudé wrote: > Hi Thomas, > > On 03/15/2018 08:49 AM, Thomas Huth wrote: >> Commit 1454509726719e0933c800 recently broke the "-cdrom" parameter >> on a couple of boards without that we noticed it immediately. Thus >> add a test which checks that "-cdrom" can a

Re: [Qemu-devel] [RFC 0/3] target/m68k: fix TCGv array overflow

2018-03-15 Thread Richard Henderson
On 03/16/2018 03:19 AM, Laurent Vivier wrote: > I try to fix this by introducing a new TCG function > to try to free a TCGv if it is a temporary one and > do nothing otherwise (patches 1 and 2) I would prefer not to approach this in this way. Better is to have translator helpers that allocate tem

Re: [Qemu-devel] [PATCH v2] dump-guest-memory: more descriptive lookup_type failure

2018-03-15 Thread Laszlo Ersek
On 03/14/18 16:38, Andrew Jones wrote: > We've seen a few reports of > > (gdb) source /usr/share/qemu-kvm/dump-guest-memory.py > Traceback (most recent call last): >File "/usr/share/qemu-kvm/dump-guest-memory.py", line 19, in > UINTPTR_T = gdb.lookup_type("uintptr_t") > gdb.error: No

Re: [Qemu-devel] [PATCH 1/3] tests/boot-sector: Add magic bytes to s390x boot code header

2018-03-15 Thread Thomas Huth
On 15.03.2018 12:47, Philippe Mathieu-Daudé wrote: > On 03/15/2018 08:49 AM, Thomas Huth wrote: >> We're going to use the s390x boot code for testing CD-ROM booting. >> But the ISO loader of the s390-ccw bios is a little bit more picky >> than the network loader and expects some magic bytes in the

Re: [Qemu-devel] [PATCH v2] RISC-V: Fix riscv_isa_string, use popcount to count bits

2018-03-15 Thread Peter Maydell
On 10 March 2018 at 21:25, Philippe Mathieu-Daudé wrote: > On 03/09/2018 10:01 PM, Michael Clark wrote: >> Logic bug caused the string size calculation for the RISC-V >> format ISA string to be small. This fix allows slack for rv128. >> >> Cc: Palmer Dabbelt >> Cc: Peter Maydell >> Cc: Eric Blak

Re: [Qemu-devel] [PATCH] dump-guest-memory: more descriptive lookup_type failure

2018-03-15 Thread Laszlo Ersek
On 03/14/18 15:24, no-re...@patchew.org wrote: > Checking PATCH 1/1: dump-guest-memory: more descriptive lookup_type failure... > WARNING: line over 80 characters > #34: FILE: scripts/dump-guest-memory.py:22: > +raise gdb.GdbError("Symbols must be loaded prior to sourcing > dump-guest-memory.

[Qemu-devel] [RFC 2/3] target/m68k: use tcg_temp_try_free()

2018-03-15 Thread Laurent Vivier
SRC_EA() and gen_extend() can return either a temporary TCGv or memory allocated one. Try to free the temporary one with tcg_temp_try_free(). Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 65 + 1 file changed, 65 insertions(+) diff -

[Qemu-devel] [RFC 3/3] m68k: Test if we overflow the temp variable array

2018-03-15 Thread Laurent Vivier
Since commit 15fa08f845 ("tcg: Dynamically allocate TCGOps") we have no limit to fill the TCGOps cache and we can fill the entire TCG variables array and overflow it. To avoid that, we stop the translation when the array is close to be full. Signed-off-by: Laurent Vivier --- target/m68k/transla

Re: [Qemu-devel] [PULL 0/7] Machine queue, 2018-03-12

2018-03-15 Thread Eduardo Habkost
On Thu, Mar 15, 2018 at 07:31:09PM +0100, Philippe Mathieu-Daudé wrote: > Hi Eduardo, > > On 03/13/2018 07:37 PM, Eduardo Habkost wrote: > > On Tue, Mar 13, 2018 at 06:29:10PM +, Peter Maydell wrote: > >> On 12 March 2018 at 22:34, Eduardo Habkost wrote: > >>> The following changes since comm

[Qemu-devel] [RFC 1/3] tcg: introduce tcg_temp_try_free()

2018-03-15 Thread Laurent Vivier
m68k has some functions returning either locally allocated TCGv or memory allocated TCGv (registers). We want to free locally allocated TCGv to avoid overflow in sequence like: 0xc00ae406: movel %fp@(-132),%fp@(-268) 0xc00ae40c: movel %fp@(-128),%fp@(-264) 0xc00ae412: movel %fp@(-20),%fp@(-212)

[Qemu-devel] [RFC 0/3] target/m68k: fix TCGv array overflow

2018-03-15 Thread Laurent Vivier
Since commit 15fa08f845 ("tcg: Dynamically allocate TCGOps") we have no limit to fill the TCGOps cache and we can fill the entire TCG variables array and overflow it. It seems to happen only with m68k, because m68k translator doesn't free some TCGv at end of instruction translation because the var

[Qemu-devel] [PATCH 2/2] char: i.MX: Add support for "TX complete" interrupt

2018-03-15 Thread Andrey Smirnov
Add support for "TX complete"/TXDC interrupt generate by real HW since it is needed to support guests other than Linux. Based on the patch by Bill Paul as found here: https://bugs.launchpad.net/qemu/+bug/1753314 Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: Bill Paul Cc: Peter Maydell S

[Qemu-devel] [PATCH 1/2] char: i.MX: Simplify imx_update()

2018-03-15 Thread Andrey Smirnov
Code of imx_update() is slightly confusing since the "flags" variable doesn't really corespond to anything in real hardware and server as a kitchensink accumulating events normally reported via USR1 and USR2 registers. Change the code to explicitly evaluate state of interrupts reported via USR1 an

Re: [Qemu-devel] [PATCH v4 1/5] target/i386: Generalize some of the macro definitions

2018-03-15 Thread Eduardo Habkost
Hi, Sorry for not reviewing the previous versions of this series (making it miss soft freeze). On Mon, Mar 12, 2018 at 05:00:45PM -0400, Babu Moger wrote: > Generalize some of the macro definitions which are generic cache > properties that are common between CPUID 4 and CPUID 0x801D > in pre

Re: [Qemu-devel] [PATCH v4 2/5] target/i386: Populate AMD Processor Cache Information

2018-03-15 Thread Eduardo Habkost
Hi, Sorry for not reviewing the previous versions of this series (and making it miss soft freeze). On Mon, Mar 12, 2018 at 05:00:46PM -0400, Babu Moger wrote: > From: Stanislav Lanci > > Add information for cpuid 0x801D leaf. Populate cache topology information > for different cache types(

Re: [Qemu-devel] [PULL 00/18] Linux user for 2.12 patches

2018-03-15 Thread Peter Maydell
On 13 March 2018 at 17:33, Laurent Vivier wrote: > The following changes since commit b39b61e410022f96ceb53d4381d25cba5126ac44: > > memory: fix flatview_access_valid RCU read lock/unlock imbalance > (2018-03-09 15:55:20 +) > > are available in the Git repository at: > > git://github.com/v

Re: [Qemu-devel] [PULL 0/7] Machine queue, 2018-03-12

2018-03-15 Thread Philippe Mathieu-Daudé
Hi Eduardo, On 03/13/2018 07:37 PM, Eduardo Habkost wrote: > On Tue, Mar 13, 2018 at 06:29:10PM +, Peter Maydell wrote: >> On 12 March 2018 at 22:34, Eduardo Habkost wrote: >>> The following changes since commit 6ceb1b51f05f9e1892d082960ed602dca7b6696e: >>> >>> Merge remote-tracking branch

Re: [Qemu-devel] [PULL 0/7] Machine queue, 2018-03-12

2018-03-15 Thread Eduardo Habkost
On Tue, Mar 13, 2018 at 03:37:04PM -0300, Eduardo Habkost wrote: > On Tue, Mar 13, 2018 at 06:29:10PM +, Peter Maydell wrote: > > On 12 March 2018 at 22:34, Eduardo Habkost wrote: > > > The following changes since commit > > > 6ceb1b51f05f9e1892d082960ed602dca7b6696e: > > > > > > Merge remo

[Qemu-devel] [PULL v2 6/7] cpu: get rid of unused cpu_init() defines

2018-03-15 Thread Eduardo Habkost
From: Igor Mammedov cpu_init(cpu_model) were replaced by cpu_create(cpu_type) so no users are left, remove it. Signed-off-by: Igor Mammedov Acked-by: David Gibson (ppc) Reviewed-by: Eduardo Habkost Message-Id: <151827-274608-6-git-send-email-imamm...@redhat.com> Signed-off-by: Eduardo Hab

[Qemu-devel] [PULL v2 7/7] cpu: drop unnecessary NULL check and cpu_common_class_by_name()

2018-03-15 Thread Eduardo Habkost
From: Igor Mammedov both do nothing as for the first all callers parse_cpu_model() and qmp_query_cpu_model_() should provide non NULL value, so just abort if it's not so. While at it drop cpu_common_class_by_name() which is not need any more as every target has CPUClass::class_by_name callbac

[Qemu-devel] [PULL v2 5/7] Use cpu_create(type) instead of cpu_init(cpu_model)

2018-03-15 Thread Eduardo Habkost
From: Igor Mammedov With all targets defining CPU_RESOLVING_TYPE, refactor cpu_parse_cpu_model(type, cpu_model) to parse_cpu_model(cpu_model) so that callers won't have to know internal resolving cpu type. Place it in exec.c so it could be called from both target independed vl.c and *-user/main.c

[Qemu-devel] [PULL v2 2/7] nios2: 10m50_devboard: replace cpu_model with cpu_type

2018-03-15 Thread Eduardo Habkost
From: Igor Mammedov use cpu_create() instead of being removed cpu_generic_init() Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Message-Id: <151827-274608-2-git-send-email-imamm...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/nios2/10m50_devboard.c | 2 +- 1 file changed,

[Qemu-devel] [PULL v2 4/7] cpu: add CPU_RESOLVING_TYPE macro

2018-03-15 Thread Eduardo Habkost
From: Igor Mammedov it will be used for providing to cpu name resolving class for parsing cpu model for system and user emulation code. Along with change add target to null-machine tests, so that when switch to CPU_RESOLVING_TYPE happens, it would ensure that null-machine usecase still works. S

[Qemu-devel] [PULL v2 3/7] tests: add machine 'none' with -cpu test

2018-03-15 Thread Eduardo Habkost
From: Igor Mammedov Check that "$QEMU -M none -cpu FOO" starts QEMU without error Signed-off-by: Igor Mammedov Message-Id: <151827-274608-3-git-send-email-imamm...@redhat.com> [ehabkost: include qmp/qdict.h instead of qmp/types.h] Signed-off-by: Eduardo Habkost --- tests/machine-none-test

[Qemu-devel] [PULL v2 1/7] pc: correct misspelled CPU model-id for pc 2.2

2018-03-15 Thread Eduardo Habkost
From: Wang Xin Signed-off-by: Wang Xin Message-Id: <1517367668-25048-1-git-send-email-wangxinxin.w...@huawei.com> Acked-by: Michael S. Tsirkin Signed-off-by: Eduardo Habkost --- include/hw/i386/pc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/i386/pc.h b/inc

[Qemu-devel] [PULL v2 0/7] Machine queue, 2018-03-15

2018-03-15 Thread Eduardo Habkost
Changes in v2 (v1 was 2018-03-12): * Fix bsd-user build error The following changes since commit 56e8698ffa8aba9f762f980bc21b5340b006f24b: Merge remote-tracking branch 'remotes/stsquad/tags/pull-travis-speedup-130318-1' into staging (2018-03-15 14:48:09 +) are available in the Git reposi

[Qemu-devel] [Bug 1749393] Re: sbrk() not working under qemu-user with a PIE-compiled binary?

2018-03-15 Thread Peter Ogden
Could we over-allocate the data segment by QEMU_DATA_SIZE/getrlimit(RLIMIT_DATA)/128 MB depending on what's set - similar to how the stack size is managed? My current workaround for aarch64 on x86-64 is to mmap a dynamic main executable in some far-away part of the address space but I'm not sure h

Re: [Qemu-devel] [PULL v2 00/22] KVM patches for QEMU 2.12 soft freeze

2018-03-15 Thread Peter Maydell
On 13 March 2018 at 16:41, Paolo Bonzini wrote: > The following changes since commit fb5fff15881ba7a002924b967eb211c002897983: > > Merge remote-tracking branch > 'remotes/kraxel/tags/vga-20180312-pull-request' into staging (2018-03-12 > 18:35:37 +) > > are available in the git repository a

Re: [Qemu-devel] [PULL 00/41] Block layer patches

2018-03-15 Thread John Snow
On 03/15/2018 12:56 PM, Kevin Wolf wrote: > Am 15.03.2018 um 17:42 hat Peter Maydell geschrieben: >> On 13 March 2018 at 16:17, Kevin Wolf wrote: >>> The following changes since commit 22ef7ba8e8ce7fef297549b3defcac333742b804: >>> >>> Merge remote-tracking branch 'remotes/famz/tags/staging-pul

[Qemu-devel] [PULL v2 0/3] tcg queued patches

2018-03-15 Thread Richard Henderson
Ho hum, I rushed v1 before leaving on holidays and failed to format the cover letter properly, so Peter's scripts did not pick it up. Patches 2 & 3 are real bug fixes and so still appropriate for the softfreeze. Patch 1 is trivial enough I didn't feel it needed to be held back for 2.13 developmen

[Qemu-devel] [PULL v2 2/3] tcg/i386: Support INDEX_op_dup2_vec for -m32

2018-03-15 Thread Richard Henderson
Unknown why -m32 was passing with gcc but not clang; it should have failed for both. This would be used for tcg_gen_dup_i64_vec, and visible with the right TB and an aarch64 guest. Reported-by: Max Reitz Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 9 + 1 file chang

[Qemu-devel] [PULL v2 3/3] tcg: Add choose_vector_size

2018-03-15 Thread Richard Henderson
This unifies 5 copies of checks for supported vector size, and in the process fixes a missing check in tcg_gen_gvec_2s. This lead to an assertion failure for 64-bit vector multiply, which is not available in the AVX instruction set. Suggested-by: Peter Maydell Signed-off-by: Richard Henderson -

[Qemu-devel] [PULL v2 1/3] tcg: Improve tcg_gen_muli_i32/i64

2018-03-15 Thread Richard Henderson
Convert multiplication by power of two to left shift. Reviewed-by: Emilio G. Cota Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c inde

[Qemu-devel] [Bug 1619896] Re: Unsupported ancillary data: 0/8

2018-03-15 Thread Peter Maydell
** Tags added: linux-user -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1619896 Title: Unsupported ancillary data: 0/8 Status in QEMU: New Bug description: Hello, I have the following issu

[Qemu-devel] [Bug 1680991] Re: raspi2: system timer device not implemented

2018-03-15 Thread Peter Maydell
** Summary changed: - raspi2: system timer not device implemented + raspi2: system timer device not implemented -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1680991 Title: raspi2: system timer de

[Qemu-devel] [PULL v2 00/44] Block layer patches

2018-03-15 Thread Kevin Wolf
The following changes since commit 56e8698ffa8aba9f762f980bc21b5340b006f24b: Merge remote-tracking branch 'remotes/stsquad/tags/pull-travis-speedup-130318-1' into staging (2018-03-15 14:48:09 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream

Re: [Qemu-devel] [PATCH 1/5] multiboot: Reject kernels exceeding the address space

2018-03-15 Thread Kevin Wolf
Am 15.03.2018 um 17:55 hat Jack Schwartz geschrieben: > On 03/15/18 08:54, Kevin Wolf wrote: > > Am 15.03.2018 um 06:19 hat Jack Schwartz geschrieben: > > > Hi Kevin. > > > > > > My comments are inline... > > > > > > On 2018-03-14 10:32, Kevin Wolf wrote: > > > > The code path with a manually set

Re: [Qemu-devel] [PATCH 8/9] hw/arm/bcm2836: Hardcode correct CPU type

2018-03-15 Thread Peter Maydell
On 13 March 2018 at 16:55, Andrew Baumann wrote: >> From: Qemu-devel > bounces+andrew.baumann=microsoft@nongnu.org> On Behalf Of Peter >> Maydell >> Sent: Tuesday, 13 March 2018 08:35 >> >> Now we have separate types for BCM2386 and BCM2387, we might as well >> just hard-code the CPU type they

Re: [Qemu-devel] [PATCH v2] linux-user: implement HWCAP bits on MIPS

2018-03-15 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180315151348.6451-1-james.cowg...@mips.com Subject: [Qemu-devel] [PATCH v2] linux-user: implement HWCAP bits on MIPS === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 to

Re: [Qemu-devel] [PULL 00/41] Block layer patches

2018-03-15 Thread Kevin Wolf
Am 15.03.2018 um 17:42 hat Peter Maydell geschrieben: > On 13 March 2018 at 16:17, Kevin Wolf wrote: > > The following changes since commit 22ef7ba8e8ce7fef297549b3defcac333742b804: > > > > Merge remote-tracking branch 'remotes/famz/tags/staging-pull-request' > > into staging (2018-03-13 11:42:

Re: [Qemu-devel] [PATCH 1/5] multiboot: Reject kernels exceeding the address space

2018-03-15 Thread Jack Schwartz
On 03/15/18 08:54, Kevin Wolf wrote: Am 15.03.2018 um 06:19 hat Jack Schwartz geschrieben: Hi Kevin. My comments are inline... On 2018-03-14 10:32, Kevin Wolf wrote: The code path with a manually set mh_load_addr in the Multiboot header checks that load_end_addr <= load_addr, but the path whe

Re: [Qemu-devel] -icount changes physical address assignments in QEMU 2.10/2.11

2018-03-15 Thread Peter Maydell
On 23 February 2018 at 00:39, wrote: > When porting our RTOS from QEMU 2.8 to 2.10/2.11, I ran into a problem > where 16-bit writes to the "bochs dispi interface" were being reported > differently depending on whether or not "-icount" was given to QEMU. > > For example, info mtree: > ... > 11

Re: [Qemu-devel] [Qemu-block] [PATCH] iscsi: fix iSER compilation

2018-03-15 Thread Kevin Wolf
Am 15.03.2018 um 15:30 hat Paolo Bonzini geschrieben: > This fails in Fedora 28. > > Reported-by: Andreas Schwab > Signed-off-by: Paolo Bonzini Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PULL 00/41] Block layer patches

2018-03-15 Thread Peter Maydell
On 13 March 2018 at 16:17, Kevin Wolf wrote: > The following changes since commit 22ef7ba8e8ce7fef297549b3defcac333742b804: > > Merge remote-tracking branch 'remotes/famz/tags/staging-pull-request' into > staging (2018-03-13 11:42:45 +) > > are available in the git repository at: > > git:

Re: [Qemu-devel] [PATCH] block: Fix leak of ignore_children in error path

2018-03-15 Thread Kevin Wolf
Am 15.03.2018 um 04:51 hat Fam Zheng geschrieben: > Reported-by: Max Reitz > Signed-off-by: Fam Zheng Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH] vvfat: Fix inherit_options flags

2018-03-15 Thread Kevin Wolf
Am 15.03.2018 um 04:45 hat Fam Zheng geschrieben: > Overriding flags violates the precedence rules of > bdrv_reopen_queue_child. Just like the read-only option, no-flush should > be put into the options. The same is done in bdrv_temp_snapshot_options. > > Reported-by: Stefan Hajnoczi Signed-off-b

[Qemu-devel] [Bug 1749393] Re: sbrk() not working under qemu-user with a PIE-compiled binary?

2018-03-15 Thread Peter Maydell
There seem to be two parts to this. Firstly, with a big reserved-region, which is the default for 32-bit-guest-on-64-bit-host, this code in main.c: if (reserved_va) { mmap_next_start = reserved_va; } says to start trying for the next mmap address at the top of the rese

Re: [Qemu-devel] [PATCH 00/11] implement 680x0 FPU (part 5)

2018-03-15 Thread Richard Henderson
On 03/13/2018 04:27 AM, Laurent Vivier wrote: > I have compared results of these instructions from a real m68040 and from > QEMU, and they match (sincos differs [1] because in QEMU we compute it as > sin and cos, and on m68040 sin and cos results differ also with > sincos results. It looks like a r

[Qemu-devel] [Bug 1756080] Re: QEMU does not provide non-Linux kernels with ATAGS structure on ARM targets

2018-03-15 Thread Peter Maydell
QEMU doesn't care whether the kernel you provide it is Linux or something else. If you pass -kernel something that's not an ELF file, we'll load and boot it using the Linux boot protocol (including ATAGS, potentially). If you pass an ELF file or pass -bios a binary blob, we'll just start it in the

Re: [Qemu-devel] [PATCH 1/5] multiboot: Reject kernels exceeding the address space

2018-03-15 Thread Kevin Wolf
Am 15.03.2018 um 06:19 hat Jack Schwartz geschrieben: > Hi Kevin. > > My comments are inline... > > On 2018-03-14 10:32, Kevin Wolf wrote: > > The code path with a manually set mh_load_addr in the Multiboot header > > checks that load_end_addr <= load_addr, but the path where load_end_addr > > is

[Qemu-devel] [Bug 1756080] [NEW] QEMU does not provide non-Linux kernels with ATAGS structure on ARM targets

2018-03-15 Thread barry.of.smith--- via Qemu-devel
Public bug reported: This would be a useful feature. Many kernels, particularly hobbyist kernels, have support for ATAGS. ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEM

[Qemu-devel] [Bug 1749393] Re: sbrk() not working under qemu-user with a PIE-compiled binary?

2018-03-15 Thread Matthias Klose
** Also affects: qemu (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1749393 Title: sbrk() not working under qemu-user with a PIE-compiled binary

Re: [Qemu-devel] [PATCH v2] linux-user: implement HWCAP bits on MIPS

2018-03-15 Thread Laurent Vivier
Le 15/03/2018 à 16:13, James Cowgill a écrit : > Add support for the two currently defined HWCAP bits on MIPS - R6 and > MSA. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1754372 > Signed-off-by: James Cowgill > --- > v2 changes: > - Fix kernel hwcap.h path. > > linux-user/elfload.c | 24

[Qemu-devel] [Bug 1748434] Re: Possibly wrong GICv3 behavior when secure enabled

2018-03-15 Thread Peter Maydell
Patch which should fix this: https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg04537.html ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1

[Qemu-devel] [PATCH v2] linux-user: implement HWCAP bits on MIPS

2018-03-15 Thread James Cowgill
Add support for the two currently defined HWCAP bits on MIPS - R6 and MSA. Buglink: https://bugs.launchpad.net/qemu/+bug/1754372 Signed-off-by: James Cowgill --- v2 changes: - Fix kernel hwcap.h path. linux-user/elfload.c | 24 1 file changed, 24 insertions(+) diff --

  1   2   >