Re: [Qemu-devel] [RFC 17/18] validator.py script

2018-04-17 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, Apr 17, 2018 at 02:01:53PM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: [...] >> > +command-line: '$QEMU -nodefaults -machine none' >> > +monitor-commands: >> > +- qmp: >> > + - execute: qom-list-types >> > +arguments: >> >

Re: [Qemu-devel] [RFC PATCH V4 2/4] vfio: Add vm status change callback to stop/restart the mdev device

2018-04-17 Thread Kirti Wankhede
On 4/18/2018 3:06 AM, Alex Williamson wrote: > On Wed, 18 Apr 2018 02:41:44 +0530 > Kirti Wankhede wrote: > >> On 4/18/2018 1:39 AM, Alex Williamson wrote: >>> On Wed, 18 Apr 2018 00:44:35 +0530 >>> Kirti Wankhede wrote: >>> On 4/17/2018 8:13 PM, Alex Williamson wrote: > On Tue,

Re: [Qemu-devel] Latest v2.12.0-rc4 has compiling error, rc3 is OK

2018-04-17 Thread Bob Chen
No, I downloaded the release tarball from github. 2018-04-18 14:25 GMT+08:00 Stefan Weil : > Am 18.04.2018 um 08:19 schrieb Bob Chen: > > fatal error: ui/input-keymap-atset1-to-qcode.c: No such file or > directory > > > > Build on my CentOS 7. > > > > That file is generated during the build. rc4

Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-17 Thread Balamuruhan S
On Wed, Apr 18, 2018 at 10:55:50AM +1000, David Gibson wrote: > On Tue, Apr 17, 2018 at 06:53:17PM +0530, Balamuruhan S wrote: > > expected_downtime value is not accurate with dirty_pages_rate * page_size, > > using ram_bytes_remaining would yeild it correct. > > This commit message hasn't been ch

Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-17 Thread Balamuruhan S
On Wed, Apr 18, 2018 at 10:57:26AM +1000, David Gibson wrote: > On Wed, Apr 18, 2018 at 10:55:50AM +1000, David Gibson wrote: > > On Tue, Apr 17, 2018 at 06:53:17PM +0530, Balamuruhan S wrote: > > > expected_downtime value is not accurate with dirty_pages_rate * page_size, > > > using ram_bytes_rem

[Qemu-devel] [PATCH] m68k: fix subx mem, mem instruction

2018-04-17 Thread Pavel Dovgalyuk
This patch fixes decrement of the pointers for subx mem, mem instructions. Without the patch pointers are decremented by OS_* constant value instead of retrieving the corresponding data size and using it as a decrement. Signed-off-by: Pavel Dovgalyuk --- target/m68k/translate.c |4 ++-- 1 fi

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-04-17 Thread Peter Xu
On Wed, Apr 18, 2018 at 01:12:24PM +0800, Stefan Hajnoczi wrote: > On Tue, Apr 17, 2018 at 11:05:47AM +0200, Markus Armbruster wrote: > > Stefan Hajnoczi writes: > > > > > On Mon, Apr 16, 2018 at 05:17:32PM +0800, Peter Xu wrote: > > >> On Mon, Apr 16, 2018 at 04:37:48PM +0800, Stefan Hajnoczi wr

Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree"

2018-04-17 Thread Markus Armbruster
Paolo Bonzini writes: > On 17/04/2018 14:18, Igor Mammedov wrote: >>> What's the point of an object name if it cannot be unique? >> It should be sufficient for it to be unique within parent's >> scope and object_property_add_child() should make sure that >> added object is unique within its paren

Re: [Qemu-devel] [PATCH] intel-iommu: send PSI always when notify_unmap set

2018-04-17 Thread Peter Xu
On Wed, Apr 18, 2018 at 05:29:56AM +, Liu, Yi L wrote: > > Sent: Wednesday, April 18, 2018 12:51 PM > > Subject: [Qemu-devel] [PATCH] intel-iommu: send PSI always when notify_unmap > > set > > > > During IOVA page table walk, there is a special case when: > > > > - notify_unmap is set, meanwh

Re: [Qemu-devel] Latest v2.12.0-rc4 has compiling error, rc3 is OK

2018-04-17 Thread Stefan Weil
Am 18.04.2018 um 08:19 schrieb Bob Chen: > fatal error: ui/input-keymap-atset1-to-qcode.c: No such file or directory > > Build on my CentOS 7. > That file is generated during the build. rc4 compiles in my test on Debian. Did you start your build from a fresh git clone? Stefan

[Qemu-devel] Latest v2.12.0-rc4 has compiling error, rc3 is OK

2018-04-17 Thread Bob Chen
fatal error: ui/input-keymap-atset1-to-qcode.c: No such file or directory Build on my CentOS 7.

Re: [Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-17 Thread Gerd Hoffmann
On Wed, Apr 18, 2018 at 12:40:54AM +0200, Laszlo Ersek wrote: > Add a schema that describes the different uses and properties of virtual > machine firmware. Looks good to me overall. > +{ 'enum' : 'FirmwareType', > + 'data' : [ 'bios', 'slof', 'uboot', 'uefi' ] } openbios missing. > +{ 'enum'

Re: [Qemu-devel] getdents patch for 64-bit app on 32-bit host

2018-04-17 Thread Thomas Huth
On 17.04.2018 23:53, Henry Wertz wrote: > Please find submitted a patch for getdents (this system call stands for > "get directory entries", it is passed a file descriptor pointing to a > directory and returns a struct with info on the entries in that > directory.) This patch is against qemu-2.10

Re: [Qemu-devel] [PATCH] intel-iommu: send PSI always when notify_unmap set

2018-04-17 Thread Liu, Yi L
> Sent: Wednesday, April 18, 2018 12:51 PM > Subject: [Qemu-devel] [PATCH] intel-iommu: send PSI always when notify_unmap > set > > During IOVA page table walk, there is a special case when: > > - notify_unmap is set, meanwhile > - entry is invalid This is very brief description, would you mind

Re: [Qemu-devel] [PATCH] intel-iommu: send PSI always when notify_unmap set

2018-04-17 Thread Peter Xu
On Wed, Apr 18, 2018 at 12:51:21PM +0800, Peter Xu wrote: > During IOVA page table walk, there is a special case when: > > - notify_unmap is set, meanwhile > - entry is invalid > > In the past, we skip the entry always. This is not correct. We should > send UNMAP notification to registered noti

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-04-17 Thread Stefan Hajnoczi
On Tue, Apr 17, 2018 at 11:05:47AM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > On Mon, Apr 16, 2018 at 05:17:32PM +0800, Peter Xu wrote: > >> On Mon, Apr 16, 2018 at 04:37:48PM +0800, Stefan Hajnoczi wrote: > >> > On Thu, Apr 12, 2018 at 02:11:08PM +0800, Peter Xu wrote: > >>

[Qemu-devel] [PATCH] intel-iommu: send PSI always when notify_unmap set

2018-04-17 Thread Peter Xu
During IOVA page table walk, there is a special case when: - notify_unmap is set, meanwhile - entry is invalid In the past, we skip the entry always. This is not correct. We should send UNMAP notification to registered notifiers in this case. Otherwise some stall pages will still be mapped in

Re: [Qemu-devel] [PATCH v3] spapr: Support ibm, dynamic-memory-v2 property

2018-04-17 Thread David Gibson
On Tue, Apr 17, 2018 at 02:39:09PM +0530, Bharata B Rao wrote: > On Tue, Apr 17, 2018 at 11:14:27AM +1000, David Gibson wrote: > > > static void spapr_machine_2_12_class_options(MachineClass *mc) > > > diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h > > > index d60b7c6d7a..5e044c44af

[Qemu-devel] [RFC PATCH v2 5/7] iscsi: Implement copy offloading

2018-04-17 Thread Fam Zheng
Issue EXTENDED COPY (LID1) command to implement the copy_range API. The parameter data construction code is ported from libiscsi's iscsi-dd.c. Signed-off-by: Fam Zheng --- block/iscsi.c| 266 +++ include/scsi/constants.h | 3 + 2 files c

[Qemu-devel] [RFC PATCH v2 2/7] raw: Implement copy offloading

2018-04-17 Thread Fam Zheng
Just pass down to ->file. Signed-off-by: Fam Zheng --- block/raw-format.c | 20 1 file changed, 20 insertions(+) diff --git a/block/raw-format.c b/block/raw-format.c index a378547c99..febddf00c0 100644 --- a/block/raw-format.c +++ b/block/raw-format.c @@ -482,6 +482,24 @@ s

[Qemu-devel] [RFC PATCH v2 7/7] qemu-img: Convert with copy offloading

2018-04-17 Thread Fam Zheng
The new blk_co_copy_range interface offers a more efficient way in the case of network based storage. Make use of it to allow faster convert operation. Since copy offloading cannot do zero detection ('-S') and compression (-c), only try it when these options are not used. Signed-off-by: Fam Zheng

[Qemu-devel] [RFC PATCH v2 6/7] block-backend: Add blk_co_copy_range

2018-04-17 Thread Fam Zheng
It's a BlockBackend wrapper of the BDS interface. Signed-off-by: Fam Zheng --- block/block-backend.c | 9 + include/sysemu/block-backend.h | 4 2 files changed, 13 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index 681b240b12..2a984b1864 100644

[Qemu-devel] [RFC PATCH v2 1/7] block: Introduce API for copy offloading

2018-04-17 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/io.c| 91 +++ include/block/block.h | 4 +++ include/block/block_int.h | 30 3 files changed, 125 insertions(+) diff --git a/block/io.c b/block/io.c index bd9a19a9c4..d274e9525f 1

[Qemu-devel] [RFC PATCH v2 4/7] file-posix: Implement bdrv_co_copy_range

2018-04-17 Thread Fam Zheng
With copy_file_range(2), we can implement the bdrv_co_copy_range semantics. Signed-off-by: Fam Zheng --- block/file-posix.c | 99 +++-- include/block/raw-aio.h | 10 - 2 files changed, 104 insertions(+), 5 deletions(-) diff --git a/block/file

[Qemu-devel] [RFC PATCH v2 3/7] qcow2: Implement copy offloading

2018-04-17 Thread Fam Zheng
The two callbacks are implemented quite similarly to the read/write functions: bdrv_co_copy_range_from maps for read and calls into bs->file or bs->backing depending on the allocation status; bdrv_co_copy_range_to maps for write and calls into bs->file. Signed-off-by: Fam Zheng --- block/qcow2.c

[Qemu-devel] [RFC PATCH v2 0/7] qemu-img convert with copy offloading

2018-04-17 Thread Fam Zheng
v2: - Add iscsi EXTENDED COPY. - Design change: bdrv_co_copy_range_{from,to}. [Stefan] - Retry upon EINTR. [Stefan] - Drop the bounce buffer fallback. It is inefficient to attempt the offloaded copy over and over again if the error is returned from the host rather than check

Re: [Qemu-devel] [Qemu-ppc] [PATCH for 2.13] spapr: Correct max associativity domains value for non-NUMA configs

2018-04-17 Thread David Gibson
On Tue, Apr 17, 2018 at 07:17:51PM +0200, Greg Kurz wrote: > Cc'ing David who should always be in the recipient list when posting ppc > related > patches :) > > On Tue, 17 Apr 2018 12:21:35 -0400 > Serhii Popovych wrote: > > > In non-NUMA configurations nb_numa_nodes is zero and we set 5th cell

Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-17 Thread David Gibson
On Wed, Apr 18, 2018 at 10:55:50AM +1000, David Gibson wrote: > On Tue, Apr 17, 2018 at 06:53:17PM +0530, Balamuruhan S wrote: > > expected_downtime value is not accurate with dirty_pages_rate * page_size, > > using ram_bytes_remaining would yeild it correct. > > This commit message hasn't been ch

Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-17 Thread David Gibson
On Tue, Apr 17, 2018 at 06:53:17PM +0530, Balamuruhan S wrote: > expected_downtime value is not accurate with dirty_pages_rate * page_size, > using ram_bytes_remaining would yeild it correct. This commit message hasn't been changed since v1, but the patch is doing something completely different.

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-04-17 Thread Wanpeng Li
2018-04-18 4:59 GMT+08:00 Eduardo Habkost : > On Tue, Apr 17, 2018 at 01:24:15AM -0700, Wanpeng Li wrote: [.../...] >> >> +if (env->features[FEAT_KVM_HINTS] & KVM_HINTS_DEDICATED) { >> +int disable_exits = kvm_check_extension(cs->kvm_state, >> KVM_CAP_X86_DISABLE_EXITS); >> + >> +

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-04-17 Thread Wanpeng Li
2018-04-18 2:08 GMT+08:00 Michael S. Tsirkin : > On Tue, Apr 17, 2018 at 01:24:15AM -0700, Wanpeng Li wrote: >> From: Wanpeng Li >> >> This patch adds support for KVM_CAP_X86_DISABLE_EXITS. Provides userspace >> with >> per-VM capability(KVM_CAP_X86_DISABLE_EXITS) to not intercept MWAIT/HLT/PAUSE

Re: [Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x before /0

2018-04-17 Thread Peter Maydell
On 18 April 2018 at 00:01, Peter Maydell wrote: > I don't have the original IEEE754 spec to hand though; > that may have left this unspecified. Having located a copy of 754-1985 I think that also is clear enough that float-float conversion is an operation that must quieten SNaN and raise Invalid.

Re: [Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x before /0

2018-04-17 Thread Peter Maydell
On 17 April 2018 at 23:49, Richard Henderson wrote: > On 04/17/2018 12:38 PM, Emilio G. Cota wrote: >> On Tue, Apr 17, 2018 at 22:45:51 +0100, Peter Maydell wrote: >>> On 17 April 2018 at 22:27, Emilio G. Cota wrote: (...) +cff 0xffb0, expected: 0x7ff8, returned: 0

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2018-04-17 Thread Eduardo Habkost
On Tue, Apr 17, 2018 at 06:31:57PM -0400, Cole Robinson wrote: > On 04/17/2018 05:11 PM, Eduardo Habkost wrote: > > On Tue, Apr 17, 2018 at 03:12:03PM -0400, Cole Robinson wrote: > > [...] > >> Reviving this... did any follow up changes happen? > >> > >> Marc-André patched virt-manager a few months

Re: [Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x before /0

2018-04-17 Thread Richard Henderson
On 04/17/2018 12:38 PM, Emilio G. Cota wrote: > On Tue, Apr 17, 2018 at 22:45:51 +0100, Peter Maydell wrote: >> On 17 April 2018 at 22:27, Emilio G. Cota wrote: >>> BTW I just checked with -t host on an IBM Power8, and we get >>> the same 1049 flag errors we get with -t soft plus two additional on

Re: [Qemu-devel] [PATCH v1 1/1] xilinx_spips: send dummy only if cmd requires it

2018-04-17 Thread francisco iglesias
Hi Sai, [PATCH v1] xilinx_spips: send dummy only if cmd requires it s/dummy/dummy cycles/ On 17 April 2018 at 16:18, Sai Pavan Boddu wrote: > For all the commands, which do not have an entry in > xilinx_spips_num_dummies, present logic sends dummy byte when ever we > s/dummy byte/dummy cycles

[Qemu-devel] [qemu RFC v2] qapi: add "firmware.json"

2018-04-17 Thread Laszlo Ersek
Add a schema that describes the different uses and properties of virtual machine firmware. Each firmware executable installed on a host system should come with at least one JSON file that conforms to this schema. Each file informs the management applications about the firmware's properties and one

Re: [Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x before /0

2018-04-17 Thread Emilio G. Cota
On Tue, Apr 17, 2018 at 22:45:51 +0100, Peter Maydell wrote: > On 17 April 2018 at 22:27, Emilio G. Cota wrote: > > BTW I just checked with -t host on an IBM Power8, and we get > > the same 1049 flag errors we get with -t soft plus two additional ones: > > > > +A 0xffb0, expected: 0x7fa0,

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2018-04-17 Thread Cole Robinson
On 04/17/2018 05:11 PM, Eduardo Habkost wrote: > On Tue, Apr 17, 2018 at 03:12:03PM -0400, Cole Robinson wrote: > [...] >> Reviving this... did any follow up changes happen? >> >> Marc-André patched virt-manager a few months back to enable -device >> vmcoreinfo for new VMs: >> >> https://www.redhat

Re: [Qemu-devel] [PATCH for-2.13] tcg: Improve TCGv_ptr support

2018-04-17 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180417222635.17007-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH for-2.13] tcg: Improve TCGv_ptr support === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PATCH for-2.13] tcg: Improve TCGv_ptr support

2018-04-17 Thread Richard Henderson
Drop TCGV_PTR_TO_NAT and TCGV_NAT_TO_PTR internal macros. Add tcg_temp_local_new_ptr, tcg_gen_brcondi_ptr, tcg_gen_ext_i32_ptr, tcg_gen_trunc_i64_ptr, tcg_gen_extu_ptr_i64, tcg_gen_trunc_ptr_i32. Use inlines instead of macros where possible. Signed-off-by: Richard Henderson These addition

[Qemu-devel] [PATCH for-2.13] tcg: Allow wider vectors for cmp and mul

2018-04-17 Thread Richard Henderson
In db432672, we allow wide inputs for operations such as add. However, in 212be173 and 3774030a we didn't do the same for compare and multiply. Signed-off-by: Richard Henderson --- tcg/tcg-op-vec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tcg/tcg-op-vec.c b/tcg

Re: [Qemu-devel] [PATCH 4/4] linux-headers: drop kvm_para.h

2018-04-17 Thread Eduardo Habkost
On Tue, Apr 17, 2018 at 09:58:37PM +0300, Michael S. Tsirkin wrote: > Unused now and can be removed. > > Signed-off-by: Michael S. Tsirkin Reviewed-by: Eduardo Habkost -- Eduardo

Re: [Qemu-devel] [Qemu-arm] ARM memory barrier patch

2018-04-17 Thread Richard Henderson
On 04/17/2018 11:51 AM, Peter Maydell wrote: > On 17 April 2018 at 22:32, Henry Wertz wrote: >> Please find submitted a patch for ARM memory barriers. This patch is >> against qemu-2.12-rc2 but I do believe it should apply for anything from >> 2.11.x to current. (the code being patched was added

[Qemu-devel] getdents patch for 64-bit app on 32-bit host

2018-04-17 Thread Henry Wertz
Please find submitted a patch for getdents (this system call stands for "get directory entries", it is passed a file descriptor pointing to a directory and returns a struct with info on the entries in that directory.) This patch is against qemu-2.10 series but continues to apply cleanly on current

Re: [Qemu-devel] [Qemu-arm] ARM memory barrier patch

2018-04-17 Thread Peter Maydell
On 17 April 2018 at 22:32, Henry Wertz wrote: > Please find submitted a patch for ARM memory barriers. This patch is > against qemu-2.12-rc2 but I do believe it should apply for anything from > 2.11.x to current. (the code being patched was added in for 2.11 series.) > > > I found with qemu 2.11.

Re: [Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x before /0

2018-04-17 Thread Peter Maydell
On 17 April 2018 at 22:27, Emilio G. Cota wrote: > BTW I just checked with -t host on an IBM Power8, and we get > the same 1049 flag errors we get with -t soft plus two additional ones: > > +A 0xffb0, expected: 0x7fa0, returned: 0x7fa0, \ > expected exceptions: i, returned: none > +e

Re: [Qemu-devel] [RFC PATCH V4 2/4] vfio: Add vm status change callback to stop/restart the mdev device

2018-04-17 Thread Alex Williamson
On Wed, 18 Apr 2018 02:41:44 +0530 Kirti Wankhede wrote: > On 4/18/2018 1:39 AM, Alex Williamson wrote: > > On Wed, 18 Apr 2018 00:44:35 +0530 > > Kirti Wankhede wrote: > > > >> On 4/17/2018 8:13 PM, Alex Williamson wrote: > >>> On Tue, 17 Apr 2018 13:40:32 + > >>> "Zhang, Yulei" wrote

[Qemu-devel] ARM memory barrier patch

2018-04-17 Thread Henry Wertz
Please find submitted a patch for ARM memory barriers. This patch is against qemu-2.12-rc2 but I do believe it should apply for anything from 2.11.x to current. (the code being patched was added in for 2.11 series.) I found with qemu 2.11.x or newer that I would get an illegal instruction error

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

2018-04-17 Thread Marc-André Lureau
Hi On Tue, Apr 17, 2018 at 11:19 PM, Peter Maydell wrote: > On 17 April 2018 at 19:36, Philippe Mathieu-Daudé wrote: >> Since this commit, the console on the Malta board stay black... >> >> Before: >> $ qemu-system-mips -M malta -m 512 \ >> -kernel vmlinux-3.2.0-4-4kc-malta -append 'root=/dev/

[Qemu-devel] [Bug 1654137] Re: Ctrl-A b not working in 2.8.0

2018-04-17 Thread Peter Maydell
Commit 1b2503fcf7b5932c reverted by commit 6f660996f1623034. We'll release 2.12 without a fix for this bug, and look at it for 2.13 and 2.12.1. https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg02505.html and followups describe the regression that 1b2503fcf7b5932c caused. ** Changed in: q

[Qemu-devel] [Bug 1763536] Re: go build fails under qemu-ppc64le-static (qemu-user)

2018-04-17 Thread Peter Maydell
I care more about the arm64 case, so if you're going to do one then that would be my preference. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1763536 Title: go build fails under qemu-ppc64le-stati

Re: [Qemu-devel] Patch for ARM memory barriers and getdent

2018-04-17 Thread Henry Wertz
Hi Henry; thanks for these patches. Please could you provide > a Signed-off-by: line for them? This says you're happy for us > to apply them to QEMU under our license, and we can't do anything > with them without one. The top part of > https://wiki.qemu.org/Contribute/SubmitAPatch > has more detail

Re: [Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x before /0

2018-04-17 Thread Emilio G. Cota
On Tue, Apr 17, 2018 at 21:54:03 +0100, Peter Maydell wrote: > On 17 April 2018 at 20:04, Emilio G. Cota wrote: > > Note that in fp-test I am not checking for flags that are raised > > when none are expected, because doing so gives quite a few errors. > > Just noticed that enabling this check yiel

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

2018-04-17 Thread Peter Maydell
On 17 April 2018 at 19:36, Philippe Mathieu-Daudé wrote: > Since this commit, the console on the Malta board stay black... > > Before: > $ qemu-system-mips -M malta -m 512 \ > -kernel vmlinux-3.2.0-4-4kc-malta -append 'root=/dev/sda1' \ > -nographic > [0.00] Initializing cgroup subsys

Re: [Qemu-devel] [PATCH v2 5/5] qmp: add pmemload command

2018-04-17 Thread Eric Blake
On 04/12/2018 07:50 AM, Simon Ruderich wrote: > Adapted patch from Baojun Wang [1] with the following commit message: > > I found this could be useful to have qemu-softmmu as a cross > debugger (launch with -s -S command line option), then if we can > have a command to load guest physi

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2018-04-17 Thread Eduardo Habkost
On Tue, Apr 17, 2018 at 03:12:03PM -0400, Cole Robinson wrote: [...] > Reviving this... did any follow up changes happen? > > Marc-André patched virt-manager a few months back to enable -device > vmcoreinfo for new VMs: > > https://www.redhat.com/archives/virt-tools-list/2018-February/msg00020.ht

Re: [Qemu-devel] [PATCH 2/4] include/standard-headers: add asm-x86/kvm_para.h

2018-04-17 Thread Eduardo Habkost
On Tue, Apr 17, 2018 at 09:58:25PM +0300, Michael S. Tsirkin wrote: > Import asm-x86/kvm_para.h from linux where it can > be easily used on Linux and non-Linux platforms. > > Signed-off-by: Michael S. Tsirkin Acked-by: Eduardo Habkost -- Eduardo

Re: [Qemu-devel] [PATCH 1/4] update-linux-headers.sh: drop kvm_para.h hacks

2018-04-17 Thread Eduardo Habkost
On Tue, Apr 17, 2018 at 09:58:21PM +0300, Michael S. Tsirkin wrote: > It turns out (as will be clear from follow-up patches) > we do not really need any kvm para macros host side > for now, except on x86, and there we need it > unconditionally whether we run on kvm or we don't. > > Import the x86

Re: [Qemu-devel] [RFC PATCH V4 2/4] vfio: Add vm status change callback to stop/restart the mdev device

2018-04-17 Thread Kirti Wankhede
On 4/18/2018 1:39 AM, Alex Williamson wrote: > On Wed, 18 Apr 2018 00:44:35 +0530 > Kirti Wankhede wrote: > >> On 4/17/2018 8:13 PM, Alex Williamson wrote: >>> On Tue, 17 Apr 2018 13:40:32 + >>> "Zhang, Yulei" wrote: >>> > -Original Message- > From: Alex Williamson [mail

[Qemu-devel] [Bug 1763536] Re: go build fails under qemu-ppc64le-static (qemu-user)

2018-04-17 Thread David Wilder
I will attempt to find an way to re-create without docker. The key is we need a way to create a ppc64le (or arm64) fakeroot with go that we can chroot into. That is easy to do with docker. BTW: the use case using docker and qemu-user-static is becoming fairly common way to cross build container

Re: [Qemu-devel] [PATCH] fpu/softfloat: check for Inf / x or 0 / x before /0

2018-04-17 Thread Peter Maydell
On 17 April 2018 at 20:04, Emilio G. Cota wrote: > Note that in fp-test I am not checking for flags that are raised > when none are expected, because doing so gives quite a few errors. > Just noticed that enabling this check yields 1049 of these errors for > v2.11, and before this patch that numbe

Re: [Qemu-devel] [PATCH v2 4/5] hmp: don't truncate size in hmp_memsave/hmp_pmemsave

2018-04-17 Thread Eric Blake
On 04/12/2018 07:50 AM, Simon Ruderich wrote: > The called function takes an uint64_t as size parameter and > qdict_get_int() returns an uint64_t. Don't truncate it needlessly to an > uint32_t. > > Signed-off-by: Simon Ruderich > --- > hmp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletio

Re: [Qemu-devel] [PATCH v2 3/5] cpus: use size_t in qmp_memsave/qmp_pmemsave

2018-04-17 Thread Eric Blake
On 04/12/2018 07:50 AM, Simon Ruderich wrote: > It's the natural type for object sizes and matches the return value of > sizeof(buf). > > Signed-off-by: Simon Ruderich > --- > cpus.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal

[Qemu-devel] [PATCH v4 21/21] target/arm: Send interrupts on PMU counter overflow

2018-04-17 Thread Aaron Lindsay
Setup a QEMUTimer to get a callback when we expect counters to next overflow and trigger an interrupt at that time. Signed-off-by: Aaron Lindsay --- target/arm/cpu.c| 11 + target/arm/cpu.h| 7 +++ target/arm/helper.c | 128 3 f

[Qemu-devel] [PATCH v4 16/21] target/arm: Finish implementation of PM[X]EVCNTR and PM[X]EVTYPER

2018-04-17 Thread Aaron Lindsay
Add arrays to hold the registers, the definitions themselves, access functions, and logic to reset counters when PMCR.P is set. Update filtering code to support counters other than PMCCNTR. Signed-off-by: Aaron Lindsay --- target/arm/cpu.h| 3 + target/arm/helper.c | 238 ++

[Qemu-devel] [PATCH v4 20/21] target/arm: Mark PMINTENSET accesses as possibly doing IO

2018-04-17 Thread Aaron Lindsay
This makes it match its AArch64 equivalent, PMINTENSET_EL1 Signed-off-by: Aaron Lindsay --- target/arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index 3902719..046e37c 100644 --- a/target/arm/helper.c +++ b/target/arm/h

Re: [Qemu-devel] [PATCH v2 2/5] cpus: convert qmp_memsave/qmp_pmemsave to use qemu_open

2018-04-17 Thread Eric Blake
On 04/12/2018 07:50 AM, Simon Ruderich wrote: > qemu_open() allow passing file descriptors to qemu which is used in s/allow/allows/ > restricted environments like libvirt where open() is prohibited. > > Suggested-by: Eric Blake > Signed-off-by: Simon Ruderich > --- > cpus.c | 20 ++---

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-04-17 Thread Eduardo Habkost
On Tue, Apr 17, 2018 at 01:24:15AM -0700, Wanpeng Li wrote: > From: Wanpeng Li > > This patch adds support for KVM_CAP_X86_DISABLE_EXITS. Provides userspace > with > per-VM capability(KVM_CAP_X86_DISABLE_EXITS) to not intercept MWAIT/HLT/PAUSE > in order that to improve latency in some workloa

[Qemu-devel] [PATCH v4 13/21] target/arm: Add ARM_FEATURE_V7VE for v7 Virtualization Extensions

2018-04-17 Thread Aaron Lindsay
Signed-off-by: Aaron Lindsay Reviewed-by: Philippe Mathieu-Daudé --- target/arm/cpu.c | 3 +++ target/arm/cpu.h | 1 + 2 files changed, 4 insertions(+) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 2228e4c..9d27ffc 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -774,6 +774,7 @

[Qemu-devel] [PATCH v4 18/21] target/arm: PMU: Set PMCR.N to 4

2018-04-17 Thread Aaron Lindsay
This both advertises that we support four counters and adds them to the implementation because the PMU_NUM_COUNTERS macro reads this value from the PMCR. Signed-off-by: Aaron Lindsay --- target/arm/helper.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/arm/helpe

Re: [Qemu-devel] [PATCH v2 1/5] cpus: correct coding style in qmp_memsave/qmp_pmemsave

2018-04-17 Thread Eric Blake
On 04/12/2018 07:50 AM, Simon Ruderich wrote: > Signed-off-by: Simon Ruderich > --- > cpus.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake However, as a meta-comment, this message was sent with: > Message-Id: > <68c390f22ae2afc6539cd7b127063e3d9534d50b

Re: [Qemu-devel] [PATCH 0/4] move kvm_para.h to standard-headers

2018-04-17 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1523991487-241006-1-git-send-email-...@redhat.com Subject: [Qemu-devel] [PATCH 0/4] move kvm_para.h to standard-headers === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 t

[Qemu-devel] [PATCH v4 10/21] target/arm: Filter cycle counter based on PMCCFILTR_EL0

2018-04-17 Thread Aaron Lindsay
The pmu_counter_enabled and pmu_op_start/finish functions are generic (as opposed to PMCCNTR-specific) to allow for the implementation of other events. Signed-off-by: Aaron Lindsay --- target/arm/cpu.c| 3 ++ target/arm/cpu.h| 22 +- target/arm/helper.c | 114 +

[Qemu-devel] [PATCH v4 14/21] target/arm: Implement PMOVSSET

2018-04-17 Thread Aaron Lindsay
Adding an array for v7VE+ CP registers was necessary so that PMOVSSET wasn't defined for all v7 processors. Signed-off-by: Aaron Lindsay --- target/arm/helper.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/target/arm/helper.c b/target/arm/helper.c index 20b

[Qemu-devel] [PATCH v4 19/21] target/arm: Implement PMSWINC

2018-04-17 Thread Aaron Lindsay
Signed-off-by: Aaron Lindsay --- target/arm/helper.c | 39 +-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index 7970129..3902719 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -949,6 +

[Qemu-devel] [PATCH v4 11/21] target/arm: Allow AArch32 access for PMCCFILTR

2018-04-17 Thread Aaron Lindsay
Signed-off-by: Aaron Lindsay --- target/arm/helper.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index 5953980..62cace7 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -918,6 +918,10 @@ sta

[Qemu-devel] [PATCH v4 08/21] target/arm: Allow EL change hooks to do IO

2018-04-17 Thread Aaron Lindsay
During code generation, surround CPSR writes and exception returns which call the EL change hooks with gen_io_start/end. The immediate need is for the PMU to access the clock and icount during EL change to support mode filtering. Signed-off-by: Aaron Lindsay --- target/arm/translate-a64.c | 6 +

[Qemu-devel] [PATCH v4 07/21] target/arm: Add pre-EL change hooks

2018-04-17 Thread Aaron Lindsay
Because the design of the PMU requires that the counter values be converted between their delta and guest-visible forms for mode filtering, an additional hook which occurs before the EL is changed is necessary. Signed-off-by: Aaron Lindsay --- target/arm/cpu.c | 16 target

[Qemu-devel] [PATCH v4 15/21] target/arm: Add array for supported PMU events, generate PMCEID[01]

2018-04-17 Thread Aaron Lindsay
This commit doesn't add any supported events, but provides the framework for adding them. We store the pm_event structs in a simple array, and provide the mapping from the event numbers to array indexes in the supported_event_map array. Because the value of PMCEID[01] depends upon which events are

[Qemu-devel] [PATCH v4 06/21] target/arm: Support multiple EL change hooks

2018-04-17 Thread Aaron Lindsay
Signed-off-by: Aaron Lindsay --- target/arm/cpu.c | 21 - target/arm/cpu.h | 20 ++-- target/arm/internals.h | 7 --- 3 files changed, 30 insertions(+), 18 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 022d8c5..1f689f6 10

Re: [Qemu-devel] [PATCH v4 0/9] enable numa configuration before machine_init() from QMP

2018-04-17 Thread Eduardo Habkost
On Tue, Apr 17, 2018 at 05:41:10PM +0200, Igor Mammedov wrote: > On Tue, 17 Apr 2018 11:27:39 -0300 > Eduardo Habkost wrote: > > > On Tue, Apr 17, 2018 at 04:13:34PM +0200, Markus Armbruster wrote: > > > Igor Mammedov writes: > > > > > > [...] > > > > Series allows to configure NUMA mapping a

[Qemu-devel] [PATCH v4 09/21] target/arm: Fix bitmask for PMCCFILTR writes

2018-04-17 Thread Aaron Lindsay
It was shifted to the left one bit too few. Signed-off-by: Aaron Lindsay Reviewed-by: Peter Maydell --- target/arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index de3be11..8158d33 100644 --- a/target/arm/helper.c +++ b

[Qemu-devel] [PATCH v4 03/21] target/arm: Reorganize PMCCNTR accesses

2018-04-17 Thread Aaron Lindsay
pmccntr_read and pmccntr_write contained duplicate code that was already being handled by pmccntr_sync. Consolidate the duplicated code into two functions: pmccntr_op_start and pmccntr_op_finish. Add a companion to c15_ccnt in CPUARMState so that we can simultaneously save both the architectural re

[Qemu-devel] [PATCH v4 17/21] target/arm: PMU: Add instruction and cycle events

2018-04-17 Thread Aaron Lindsay
The instruction event is only enabled when icount is used, cycles are always supported. Always defining get_cycle_count (but altering its behavior depending on CONFIG_USER_ONLY) allows us to remove some CONFIG_USER_ONLY #defines throughout the rest of the code. Signed-off-by: Aaron Lindsay --- t

[Qemu-devel] [Bug 1654137] Re: Ctrl-A b not working in 2.8.0

2018-04-17 Thread Philippe Mathieu-Daudé
Hi Andreas, beware... while 1b2503fcf7b5 fixes this bug, it introduces another regression. I suggest waiting for the release tag before cherry-picking it. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bug

[Qemu-devel] [PATCH v4 04/21] target/arm: Mask PMU register writes based on PMCR_EL0.N

2018-04-17 Thread Aaron Lindsay
This is in preparation for enabling counters other than PMCCNTR Signed-off-by: Aaron Lindsay Reviewed-by: Peter Maydell --- target/arm/helper.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index f6

[Qemu-devel] [PATCH v4 01/21] target/arm: Check PMCNTEN for whether PMCCNTR is enabled

2018-04-17 Thread Aaron Lindsay
Signed-off-by: Aaron Lindsay Reviewed-by: Peter Maydell --- target/arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index b14fdab..485004e 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -994,7 +994,7 @@ stat

[Qemu-devel] [PATCH v4 12/21] target/arm: Make PMOVSCLR and PMUSERENR 64 bits wide

2018-04-17 Thread Aaron Lindsay
This is a bug fix to ensure 64-bit reads of these registers don't read adjacent data. Signed-off-by: Aaron Lindsay --- target/arm/cpu.h| 4 ++-- target/arm/helper.c | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index a56e9a0..9f

[Qemu-devel] [PATCH v4 02/21] target/arm: Treat PMCCNTR as alias of PMCCNTR_EL0

2018-04-17 Thread Aaron Lindsay
They share the same underlying state Signed-off-by: Aaron Lindsay Reviewed-by: Peter Maydell --- target/arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index 485004e..83ea8f4 100644 --- a/target/arm/helper.c +++ b/target

[Qemu-devel] [PATCH v4 05/21] target/arm: Fetch GICv3 state directly from CPUARMState

2018-04-17 Thread Aaron Lindsay
This eliminates the need for fetching it from el_change_hook_opaque, and allows for supporting multiple el_change_hooks without having to hack something together to find the registered opaque belonging to GICv3. Signed-off-by: Aaron Lindsay Reviewed-by: Peter Maydell --- hw/intc/arm_gicv3_cpuif

[Qemu-devel] [PATCH v4 00/21] More fully implement ARM PMUv3

2018-04-17 Thread Aaron Lindsay
The ARM PMU implementation currently contains a basic cycle counter, but it is often useful to gather counts of other events and filter them based on execution mode. These patches flesh out the implementations of various PMU registers including PM[X]EVCNTR and PM[X]EVTYPER, add a struct definition

[Qemu-devel] [Bug 1654137] Re: Ctrl-A b not working in 2.8.0

2018-04-17 Thread Andreas Gustafsson
Fixed on qemu mainline in 1b2503fcf7b5932c5a3779ca2ceb92bd403c4ee7 - thanks. I have backported the fix to pkgsrc as qemu-2.11.1nb3. ** Changed in: qemu Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribe

Re: [Qemu-devel] [RFC PATCH V4 2/4] vfio: Add vm status change callback to stop/restart the mdev device

2018-04-17 Thread Alex Williamson
On Wed, 18 Apr 2018 00:44:35 +0530 Kirti Wankhede wrote: > On 4/17/2018 8:13 PM, Alex Williamson wrote: > > On Tue, 17 Apr 2018 13:40:32 + > > "Zhang, Yulei" wrote: > > > >>> -Original Message- > >>> From: Alex Williamson [mailto:alex.william...@redhat.com] > >>> Sent: Tuesday, Ap

Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again

2018-04-17 Thread Peter Maydell
On 17 April 2018 at 19:36, Philippe Mathieu-Daudé wrote: > Hi, > Opinions welcome on whether this is a regression fix worth putting into rc4. >>> >>> It is a regression, but a long standing one - we've been broken for quite >>> a while since 2.9.0 or even before. >>> >>> If we're doing a

Re: [Qemu-devel] [PATCH 3/4] x86/cpu: use standard-headers/asm-x86.kvm_para.h

2018-04-17 Thread Eduardo Habkost
On Tue, Apr 17, 2018 at 09:58:25PM +0300, Michael S. Tsirkin wrote: > Switch to the header we imported from Linux, > this allows us to drop a hack in kvm_i386.h. > More code will be dropped in the next patch. > > Signed-off-by: Michael S. Tsirkin > --- > include/sysemu/kvm.h | 1 - > target/i3

Re: [Qemu-devel] [PATCH v3 12/22] target/arm: Filter cycle counter based on PMCCFILTR_EL0

2018-04-17 Thread Aaron Lindsay
On Apr 17 16:37, Peter Maydell wrote: > On 17 April 2018 at 16:21, Aaron Lindsay wrote: > > On Apr 12 13:36, Aaron Lindsay wrote: > >> On Apr 12 18:15, Peter Maydell wrote: > >> > On 16 March 2018 at 20:31, Aaron Lindsay wrote: > >> > > diff --git a/target/arm/cpu.h b/target/arm/cpu.h > >> > > in

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test new qemu-nbd --nolist option

2018-04-17 Thread Eric Blake
On 04/13/2018 02:26 PM, Nir Soffer wrote: > Add new test module for tesing the --nolist option. > > Signed-off-by: Nir Soffer > --- > +iotests.log('Check that listing exports is allowed by default') > +disk, nbd_sock = iotests.file_path('disk1', 'nbd-sock1') > +iotests.qemu_img_create('-f', iote

Re: [Qemu-devel] [PATCH 1/3] nbd: Add option to disallow listing exports

2018-04-17 Thread Eric Blake
On 04/16/2018 06:00 AM, Daniel P. Berrangé wrote: > On Mon, Apr 16, 2018 at 11:53:41AM +0100, Richard W.M. Jones wrote: >> On Mon, Apr 16, 2018 at 11:31:18AM +0100, Daniel P. Berrangé wrote: >>> Essentially this is abusing the export name as a crude authentication >>> token. There are NBD servers t

Re: [Qemu-devel] [PATCH 1/3] nbd: Add option to disallow listing exports

2018-04-17 Thread Eric Blake
On 04/13/2018 02:26 PM, Nir Soffer wrote: > When a management application expose images using qemu-nbd, it needs a > secure way to allow temporary access to the disk. Using a random export > name can solve this problem: > > nbd://server:10809/22965f19-9ab5-4d18-94e1-cbeb321fa433 I share Dan's

  1   2   3   >