On Mon, May 07, 2018 at 06:00:56PM +0100, Peter Maydell wrote:
> On 7 May 2018 at 15:30, Gerd Hoffmann wrote:
> > The only one which passes global_vmstate == false is "-device
> > secondary-vga", and that does *not* register vga ioports (the
> > registers can be accessed via mmio pci bar though).
ACK.
cc stable?
On 05/07/2018 05:51 PM, Cornelia Huck wrote:
> Thomas reported that the subchannel for a 3270 device that ended up
> in a broken state (status pending even though not enabled) did not
> get out of that state even after a reboot (which involves a subsytem
> reset). The reason fo
Signed-off-by: Peter Xu
---
tests/test-interval-tree.c | 190 +
tests/Makefile.include | 2 +
2 files changed, 192 insertions(+)
create mode 100644 tests/test-interval-tree.c
diff --git a/tests/test-interval-tree.c b/tests/test-interval-tree.c
new file
On Tue, 8 May 2018 09:17:08 +0200
Christian Borntraeger wrote:
> ACK.
>
> cc stable?
Probably. We'd also need patch 1 for that.
>
>
>
> On 05/07/2018 05:51 PM, Cornelia Huck wrote:
> > Thomas reported that the subchannel for a 3270 device that ended up
> > in a broken state (status pending
Daniel P. Berrangé wrote:
> On Wed, Apr 04, 2018 at 01:27:24PM +0200, Juan Quintela wrote:
>> Migration code needs that function in hmp.c (so we need to export it),
>> and it needs it on tests/migration-test.c, so we need to move it to a
>> place where it is compiled into the test framework.
>
> T
"Dr. David Alan Gilbert" wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
>> It will be used to store the uri parameters. We want this only for
>> tcp, so we don't set it for other uris. We need it to know what port
>> is migration running.
>>
>> Signed-off-by: Juan Quintela
>>
>> --
>>
Daniel P. Berrangé wrote:
> On Thu, Apr 12, 2018 at 02:09:33PM +0100, Dr. David Alan Gilbert wrote:
>> * Juan Quintela (quint...@redhat.com) wrote:
>> > It will be used to store the uri parameters. We want this only for
>> > tcp, so we don't set it for other uris. We need it to know what port
>>
On Fri, May 4, 2018 at 5:39 PM, Emanuele Giuseppe Esposito
wrote:
> my name is Emanuele and I am one of the students selected to participate at
> the Google Summer of Code with QEMU.
> I'll work on the current test driver framework and will try to improve it
> (i.e. automatically detect devices
Daniel P. Berrangé wrote:
> On Wed, Apr 04, 2018 at 01:27:27PM +0200, Juan Quintela wrote:
>> It will be used to store the uri parameters. We want this only for
>> tcp, so we don't set it for other uris. We need it to know what port
>> is migration running.
>>
>> Signed-off-by: Juan Quintela
>>
* ChristianEhrhardt (1769...@bugs.launchpad.net) wrote:
> > Interesting; I thought this was supposed to work.
>
> Exactly that was my thought when triaging it initially
> Furthermore I assume people working la57 (https://lwn.net/Articles/730925/)
> and such ran tests on much bigger sizes.
I assu
ping for review?
thanks
-- PMM
On 27 April 2018 at 12:01, Peter Maydell wrote:
> Coverity (CID1390573) spots that we forgot to free the
> gpioname strings in a loop in the iotkit realize function.
> Correct the error.
>
> This isn't a significant leak, because this function
> only ever runs once
On Tue, Mar 13, 2018 at 04:33:43PM +0800, junyan...@intel.com wrote:
> From: Junyan He
>
> The nvdimm size is huge, sometimes it is more than 256G or even more.
> This is a huge burden for snapshot saving. One snapshot point with
> nvdimm may occupy more than 50G disk space even with compression
On Mon, 7 May 2018 12:53:45 -0500
Eric Blake wrote:
> On 05/07/2018 04:02 AM, Greg Kurz wrote:
> > qemu-system-ppc fails to build with GCC 8.0.1:
> >
> > /home/hsp/src/qemu-master/hw/ppc/e500.c: In function
> > ‘ppce500_load_device_tree’:
> > /home/hsp/src/qemu-master/hw/ppc/e500.c:442:37: erro
* Igor Mammedov (imamm...@redhat.com) wrote:
> On Fri, 4 May 2018 13:26:51 +0100
> "Dr. David Alan Gilbert" wrote:
>
> > * Igor Mammedov (imamm...@redhat.com) wrote:
> > > On Thu, 26 Apr 2018 03:37:51 -0400 (EDT)
> > > Pankaj Gupta wrote:
> > >
> > > trimming CC list to keep people that might b
On 4 May 2018 at 18:55, Peter Maydell wrote:
> v2: fixed format string errors in trace messages.
>
> -- PMM
>
> The following changes since commit c8b7e627b4269a3bc3ae41d9f420547a47e6d9b9:
>
> Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-05-04' into
> staging (2018-05-04 14:42
On Fri, 4 May 2018 15:16:05 +0200
Cornelia Huck wrote:
> The 3270 code will try to post an attention interrupt when the
> 3270 emulator (e.g. x3270) attaches. If the guest has not yet
> enabled the subchannel for the 3270 device, we will give it a
> spurious status during msch when it does so la
On Thu, Apr 26, 2018 at 10:57:55AM -0300, Eduardo Habkost wrote:
> (Starting a new thread, for more visibility)
>
> (This was: Re: [Qemu-devel] [RFC PATCH] tests/device-introspect: Test
> devices with all machines, not only with "none")
>
> On Thu, Apr 26, 2018 at 01:54:43PM +0200, Markus Armbrus
On Sat, Apr 28, 2018 at 01:54:24PM +0800, Jay Zhou wrote:
> This patch removes the dead code, which fixes Coverity (CID 1390600) issue.
>
> Signed-off-by: Jay Zhou
> ---
> backends/cryptodev-vhost-user.c | 5 -
> 1 file changed, 5 deletions(-)
Reviewed-by: Stefan Hajnoczi
signature.asc
D
On Tue, May 8, 2018 at 10:37 AM, Dr. David Alan Gilbert wrote:
> * ChristianEhrhardt (1769...@bugs.launchpad.net) wrote:
> > > Interesting; I thought this was supposed to work.
> >
> > Exactly that was my thought when triaging it initially
> > Furthermore I assume people working la57 (https://lwn
On Sat, Apr 28, 2018 at 11:59:41PM +0100, Andrew Wood via Qemu-devel wrote:
> Ive been looking into the possibility of using a unix signal to send an acpi
> shutdown request to a VM, and came across a posting on this l in March 1.
> See https://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg04
I've run into a compilation error today with the current version of GCC 8:
In file included from s390-ccw.h:49,
from main.c:12:
cio.h:128:1: error: alignment 1 of 'struct tpi_info' is less than 4
[-Werror=packed-not-aligned]
} __attribute__ ((packed));
^
cc1: all warnings being
On Wed, May 02, 2018 at 06:04:21PM +0800, Peter Xu wrote:
> Add some explicit comment for both Readline and cpu_set/cpu_get helpers
> that they do not need the mon_lock protection.
>
> Signed-off-by: Peter Xu
> ---
> monitor.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff
On Wed, May 02, 2018 at 06:04:19PM +0800, Peter Xu wrote:
> The out_lock was only protecting a few Monitor fields. In the future
> the monitor code will start to run in multiple threads. We turn it into
> a bigger lock to protect not only the out buffer but also all the rest.
> For now we share t
On 4 March 2018 at 17:32, Laurent Vivier wrote:
> Using a local m68k floatx80_mod()
> [copied from previous:
> Written by Andreas Grabher for Previous, NeXT Computer Emulator.]
>
> The quotient byte of the FPSR is updated with
> the result of the operation.
>
> Signed-off-by: Laurent Vivier
> Rev
On Wed, May 02, 2018 at 06:04:22PM +0800, Peter Xu wrote:
> Similar to previous patch, but introduce a new global big lock for
> mon_fdsets. Take it where needed.
>
> Signed-off-by: Peter Xu
> ---
> monitor.c | 64
> ---
> 1 file chan
On Wed, May 02, 2018 at 11:55:52AM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> Use qemu_set_nonblock rather than a simple fcntl; cleaner
> and I have no reason to change other flags.
>
> Reported-by: Peter Maydell
> Signed-off-by: Dr. David Alan Gilbert
> --
On Fri, Apr 27, 2018 at 05:23:10PM +0100, Stefan Hajnoczi wrote:
> v2:
> * Add comment on !__linux__ situation [Fam]
> * Add file-posix.c x-check-cache-dropped=on|off option [DaveG, Kevin]
>
> file-posix.c only supports shared storage live migration with -drive
> cache.direct=off due to cache co
On Tue, May 08, 2018 at 11:23:38AM +0100, Stefan Hajnoczi wrote:
> On Wed, May 02, 2018 at 06:04:21PM +0800, Peter Xu wrote:
> > Add some explicit comment for both Readline and cpu_set/cpu_get helpers
> > that they do not need the mon_lock protection.
> >
> > Signed-off-by: Peter Xu
> > ---
> >
On Mon, May 07, 2018 at 01:04:17PM -0500, Eric Blake wrote:
> On 05/06/2018 10:32 PM, Yi Min Zhao wrote:
>
> In the subject line: s/avoid to compile/avoid compiling/
>
> > If CONFIG_SECCOMP is undefined, the option 'elevatorprivileges' remains
>
> s/elevator/elevate/
>
> > complied. This would
On Fri, Apr 27, 2018 at 12:01:37PM +0100, Peter Maydell wrote:
> Coverity (CID1390573) spots that we forgot to free the
> gpioname strings in a loop in the iotkit realize function.
> Correct the error.
>
> This isn't a significant leak, because this function
> only ever runs once.
>
> Signed-off-
* ChristianEhrhardt (1769...@bugs.launchpad.net) wrote:
> On Tue, May 8, 2018 at 10:37 AM, Dr. David Alan Gilbert > wrote:
>
> > * ChristianEhrhardt (1769...@bugs.launchpad.net) wrote:
> > > > Interesting; I thought this was supposed to work.
> > >
> > > Exactly that was my thought when triaging
On 27 April 2018 at 14:49, Alex Bennée wrote:
>
> Peter Maydell writes:
>
>> On 21 February 2018 at 11:05, Alex Bennée wrote:
>>> +/*
>>> + * Integer to float conversions
>>> + *
>>> + * Returns the result of converting the two's complement integer `a'
>>> + * to the floating-point format. The c
On Sat, May 05, 2018 at 12:05:10AM +0200, Paolo Bonzini wrote:
> On 04/05/2018 18:00, Daniel P. Berrangé wrote:
> > Based on that doc and https://repology.org/metapackage/glib/versions,
> > I identified that we could feasibly set min glib to 2.42. Note that
> > this would be dropping RHEL-6 as a bu
On Tue, 8 May 2018 12:17:52 +0200
Thomas Huth wrote:
> I've run into a compilation error today with the current version of GCC 8:
>
> In file included from s390-ccw.h:49,
> from main.c:12:
> cio.h:128:1: error: alignment 1 of 'struct tpi_info' is less than 4
> [-Werror=packed-
Am 08.05.2018 um 12:32 hat Stefan Hajnoczi geschrieben:
> On Fri, Apr 27, 2018 at 05:23:10PM +0100, Stefan Hajnoczi wrote:
> > v2:
> > * Add comment on !__linux__ situation [Fam]
> > * Add file-posix.c x-check-cache-dropped=on|off option [DaveG, Kevin]
> >
> > file-posix.c only supports shared s
On 04/22/2018 12:01 PM, Halil Pasic wrote:
On 04/22/2018 05:43 PM, Tony Krowiak wrote:
+FEAT_INIT_MISC("ap", "AP facilities installed"),
Why plural ('facilities')? Would not s/facilities/instructions be
more end-user
friendly?
It's a matter of opinion. I prefer facilities because AP
On 08.05.2018 07:33, Thomas Huth wrote:
> On 07.05.2018 21:32, Eduardo Habkost wrote:
>> On Mon, May 07, 2018 at 09:13:57PM +0200, Thomas Huth wrote:
>>> On 07.05.2018 20:21, Eduardo Habkost wrote:
On Mon, May 07, 2018 at 06:50:35PM +0200, Markus Armbruster wrote:
> Eduardo Habkost writes
* Peter Xu (pet...@redhat.com) wrote:
> After we updated the dirty bitmaps of ramblocks, we also need to update
> the critical fields in RAMState to make sure it is ready for a resume.
>
> Signed-off-by: Peter Xu
> ---
> migration/ram.c| 45 -
>
Peter Maydell writes:
> On 27 April 2018 at 14:49, Alex Bennée wrote:
>>
>> Peter Maydell writes:
>>
>>> On 21 February 2018 at 11:05, Alex Bennée wrote:
+/*
+ * Integer to float conversions
+ *
+ * Returns the result of converting the two's complement integer `a'
+ *
Hmm, if we know that QEMU guests will crash & burn when > 1 TB mem, when
host-phys-bits/phys-bits are unset, then perhaps libvirt should do the
right thing by default here. eg we can't use host-phys-bits=true due to
migration compat issues, but if we see > 1TB mem, libvirt could
reasonably set phys
On 8 May 2018 at 10:34, Greg Kurz wrote:
> On Mon, 7 May 2018 12:53:45 -0500
> Eric Blake wrote:
>
>> On 05/07/2018 04:02 AM, Greg Kurz wrote:
>> > qemu-system-ppc fails to build with GCC 8.0.1:
>> >
>> > /home/hsp/src/qemu-master/hw/ppc/e500.c: In function
>> > ‘ppce500_load_device_tree’:
>> >
On 08.05.2018 12:44, Cornelia Huck wrote:
> On Tue, 8 May 2018 12:17:52 +0200
> Thomas Huth wrote:
>
>> I've run into a compilation error today with the current version of GCC 8:
>>
>> In file included from s390-ccw.h:49,
>> from main.c:12:
>> cio.h:128:1: error: alignment 1 of
On Tue, 8 May 2018 12:49:59 +0200
Thomas Huth wrote:
> On 08.05.2018 12:44, Cornelia Huck wrote:
> > On Tue, 8 May 2018 12:17:52 +0200
> > Thomas Huth wrote:
> >
> >> I've run into a compilation error today with the current version of GCC 8:
> >>
> >> In file included from s390-ccw.h:49,
> >
On 05/08/2018 01:06 PM, Cornelia Huck wrote:
> On Tue, 8 May 2018 12:49:59 +0200
> Thomas Huth wrote:
>
>> On 08.05.2018 12:44, Cornelia Huck wrote:
>>> On Tue, 8 May 2018 12:17:52 +0200
>>> Thomas Huth wrote:
>>>
I've run into a compilation error today with the current version of GCC
On 08.05.2018 13:06, Cornelia Huck wrote:
> On Tue, 8 May 2018 12:49:59 +0200
> Thomas Huth wrote:
>
>> On 08.05.2018 12:44, Cornelia Huck wrote:
>>> On Tue, 8 May 2018 12:17:52 +0200
>>> Thomas Huth wrote:
>>>
I've run into a compilation error today with the current version of GCC 8:
>
On Thu, May 03, 2018 at 08:10:59PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> Update the migration docs:
>
> Among other changes:
> * Added a general list of advice for device authors
> * Reordered the section on conditional state (subsections etc)
>
* Daniel Berrange (1769...@bugs.launchpad.net) wrote:
> Hmm, if we know that QEMU guests will crash & burn when > 1 TB mem, when
> host-phys-bits/phys-bits are unset, then perhaps libvirt should do the
> right thing by default here. eg we can't use host-phys-bits=true due to
> migration compat issu
Peter Maydell writes:
> It is implementation defined whether a multiply-add of
> (0,inf,qnan) or (inf,0,qnan) raises InvalidaOperation or
> not, so we let the target-specific pickNaNMulAdd function
> handle this. This means that we must do the "return the
> default NaN in default NaN mode" check
* Peter Xu (pet...@redhat.com) wrote:
> Let's introduce a lock for that QEMUFile since we are going to operate
> on it in multiple threads.
>
> Signed-off-by: Peter Xu
Reviewed-by: Dr. David Alan Gilbert
> ---
> migration/migration.h | 6 ++
> migration/channel.c | 3 ++-
> migration/
On 08/05/2018 12:42, Daniel P. Berrangé wrote:
> On Sat, May 05, 2018 at 12:05:10AM +0200, Paolo Bonzini wrote:
>> On 04/05/2018 18:00, Daniel P. Berrangé wrote:
>>> Based on that doc and https://repology.org/metapackage/glib/versions,
>>> I identified that we could feasibly set min glib to 2.42. N
On Thu, May 03, 2018 at 10:17:51AM +0100, Peter Maydell wrote:
> On 3 May 2018 at 10:05, Joel Stanley wrote:
> I'm a bit reluctant to take these patches until we have an
> actual cortex-m0 model, because anything we take into QEMU
> master is then something we have to support. My rule of thumb
> i
On Thu, May 03, 2018 at 06:35:31PM +0930, Joel Stanley wrote:
> diff --git a/hw/arm/nrf51_soc.c b/hw/arm/nrf51_soc.c
> new file mode 100644
> index ..a2e3d6f013f0
> --- /dev/null
> +++ b/hw/arm/nrf51_soc.c
> @@ -0,0 +1,101 @@
> +/*
> + * Nordic Semiconductor nRF51 SoC
> + *
> + * Copyri
Am 09.03.2018 um 15:11 hat Alberto Garcia geschrieben:
> The QMP version of this command can take a qdev ID since 7a9877a02635,
> but the HMP version is still using the deprecated block device name so
> there's no way to refer to a block device added like this:
>
> -blockdev
> node-name=disk0,d
On Thu, May 03, 2018 at 06:35:30PM +0930, Joel Stanley wrote:
> Hello,
>
> This short series implements a minimal definition of the Nordic
> Semiconductor nRF51, a Cortex-M0 ARM SoC, and the BBC micro:bit, a
> machine that will use this SoC.
>
> This work will serve as the base for our Google Sum
"Michael S. Tsirkin" wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
No, it is not by accident.
qemu-version.h and config-host.
"Michael S. Tsirkin" wrote:
> When pulling in headers that are in the child directory of the C file
> (as opposed to one in include/), we should use its relative path, with
> name of the child directory. Full path including the current directory
> works more or less by accident.
>
> Signed-off-by:
On Tue, 8 May 2018 12:17:52 +0200
Thomas Huth wrote:
> I've run into a compilation error today with the current version of GCC 8:
>
> In file included from s390-ccw.h:49,
> from main.c:12:
> cio.h:128:1: error: alignment 1 of 'struct tpi_info' is less than 4
> [-Werror=packed-
"Michael S. Tsirkin" wrote:
> This way they are easier to find using standard rules.
>
> Signed-off-by: Michael S. Tsirkin
Nack.
This are _internal_ files, that shouldn't be used anywere elese.
Except that we need them to write tests. We only have two scopes
on qemu:
- internal: only for
Updates the linux header files in preparation for introduction
of the VFIO AP device:
* Added a feature ID to indicate AP facilities are installed
* Added a device attribute to the KVM_S390_VM_CRYPTO group to
indicate whether AP instructions are to be interpreted
* Added VFIO device informatio
This patch provides documentation describing the AP architecture and
design concepts behind the virtualization of AP devices. It also
includes an example of how to configure AP devices for exclusive
use of KVM guests.
Signed-off-by: Tony Krowiak
---
docs/vfio-ap.txt | 649 ++
Create a qcow2 directly on bare block device with
"-o preallocation=metadata" option. When read this qcow2, it will
return dirty data of block device. This patch add QCOW_OFLAG_ZERO
for all preallocated l2 entry if the underlying device is a bare
block device.
Signed-off-by: Ivan Ren
---
block/q
This patch introduces the base object for an AP device.
Signed-off-by: Tony Krowiak
---
hw/s390x/Makefile.objs |1 +
hw/s390x/ap-device.c | 39 +++
include/hw/s390x/ap-device.h | 38 ++
3 files changed,
This patch series is the QEMU counterpart to the KVM/kernel support for
guest dedicated crypto adapters. The KVM/kernel model is built on the
VFIO mediated device framework and provides the infrastructure for
granting exclusive guest access to crypto devices installed on the linux
host. This pa
A new CPU model feature and two new CPU model facilities are
introduced to support AP devices for a KVM guest.
CPU model features:
1. The KVM_S390_VM_CPU_FEAT_AP CPU model feature indicates that
AP facilities are installed. This feature will be enabled by
the kernel only if the AP facilitie
Introduces a VFIO based AP device. The device is defined via
the QEMU command line by specifying:
-device vfio-ap,sysfsdev=
There may be only one vfio-ap device configured for a guest.
The mediated matrix device is created by the VFIO AP device
driver by writing a UUID to a sysfs attribute f
Lidong Chen wrote:
> if qio_channel_rdma_readv return QIO_CHANNEL_ERR_BLOCK, the destination qemu
> crash.
>
> The backtrace is:
> (gdb) bt
> #0 0x in ?? ()
> #1 0x008db50e in qio_channel_set_aio_fd_handler (ioc=0x38111e0,
> ctx=0x3726080,
> io_read=0x8db
Added entries for the s390 adjunct processor (AP) support.
Signed-off-by: Tony Krowiak
---
MAINTAINERS | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 459e359..c9e8d7b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -82,6 +82,7
Lidong Chen wrote:
> when qio_channel_read return QIO_CHANNEL_ERR_BLOCK, the source qemu crash.
>
> The backtrace is:
> (gdb) bt
> #0 0x7fb20aba91d7 in raise () from /lib64/libc.so.6
> #1 0x7fb20abaa8c8 in abort () from /lib64/libc.so.6
> #2 0x7fb20aba2146 in __asser
On Thu, May 03, 2018 at 12:59:16PM +0200, Laurent Vivier wrote:
> Le 03/05/2018 à 12:24, GitHub a écrit :
> ...
> > Compare: https://github.com/qemu/qemu/compare/26bd8d98c4b3...98bae9c4afb4
> > **NOTE:** This service been marked for deprecation:
> > https://developer.github.com/changes/2018-
Hi,
Travis CI hit this error testing commit 853f8ca13cd6d256:
$ clang --version
Apple LLVM version 8.1.0 (clang-802.0.42)
Target: x86_64-apple-darwin16.7.0
$ ./configure
C compilerclang
host CPU x86_64
...
TPM support yes
libssh2 support no
TPM passthrough no
TPM emula
On Thu, Apr 26, 2018 at 08:43:05AM -0500, Eric Blake wrote:
> We are gradually moving away from sector-based interfaces, towards
> byte-based. Now that all callers of blocking I/O have been converted
> to use our preferred byte-based bdrv_p{read,write}(), we can
> delete the unused bdrv_{read,writ
Hi Michael,
On 05/03/2018 04:50 PM, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
>
> Signed-off-by: Micha
On 05/03/2018 04:51 PM, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
>
> Signed-off-by: Michael S. Tsirkin
On Tue, 8 May 2018 14:46:08 +0200
Cornelia Huck wrote:
> On Tue, 8 May 2018 08:25:03 -0400
> Tony Krowiak wrote:
>
> > Added entries for the s390 adjunct processor (AP) support.
> >
> > Signed-off-by: Tony Krowiak
> > ---
> > MAINTAINERS | 14 ++
> > 1 files changed, 14 insert
On Tue, 8 May 2018 08:25:03 -0400
Tony Krowiak wrote:
> Added entries for the s390 adjunct processor (AP) support.
>
> Signed-off-by: Tony Krowiak
> ---
> MAINTAINERS | 14 ++
> 1 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index
On Fri, May 04, 2018 at 12:51:47PM +0200, Paolo Bonzini wrote:
> osdep.h is only needed for files that are compiled directly.
> Remove it from included C source files, and rename them to
> *.inc.c so that scripts/clean-includes knows to skip them.
>
> Cc: Eric Blake
> Cc: Michael S. Tsirkin
> Si
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1525782303-16940-1-git-send-email-akrow...@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH v5 0/6] s390x: vfio-ap: guest dedicated crypto
adapters
=== TEST SCRIPT BEGIN ===
On Mon, 7 May 2018 17:51:28 +0200
Cornelia Huck wrote:
> On Friday, Thomas noticed some problems with 3270 devices. One result
> was "s390x/css: disabled subchannels cannot be status pending", but
> a reboot did not cure the previous broken status. Turns out that 3270
> devices are missing a res
On 05/08/2018 09:25 AM, Juan Quintela wrote:
> "Michael S. Tsirkin" wrote:
>> This way they are easier to find using standard rules.
>>
>> Signed-off-by: Michael S. Tsirkin
>
> Nack.
>
> This are _internal_ files, that shouldn't be used anywere elese.
>
> Except that we need them to write
On 05/03/2018 04:50 PM, Michael S. Tsirkin wrote:
> We don't use net/clients.h, drop that include.
>
> Signed-off-by: Michael S. Tsirkin
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
> ---
> hw/net/rocker/rocker_fp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --
On 05/03/2018 04:50 PM, Michael S. Tsirkin wrote:
> No reason for vhost-scsi to pull in migration headers directly.
>
> Signed-off-by: Michael S. Tsirkin
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
> ---
> hw/scsi/vhost-scsi-common.c | 1 -
> 1 file changed, 1 delet
On 05/08/2018 06:16 AM, Peter Maydell wrote:
> ping for review?
>
> thanks
> -- PMM
>
> On 27 April 2018 at 12:01, Peter Maydell wrote:
>> Coverity (CID1390573) spots that we forgot to free the
>> gpioname strings in a loop in the iotkit realize function.
>> Correct the error.
>>
>> This isn't a
On Fri, May 04, 2018 at 01:46:19PM -0400, Jeff Cody wrote:
> On Fri, May 04, 2018 at 04:50:12PM +0100, Stefan Hajnoczi wrote:
> > The 185 qemu-iotests test case was in a bad state for the QEMU 2.12 release.
> > We fudged the expected test output to make it pass, except for
> > non-deterministic beh
On Fri, May 04, 2018 at 08:43:43PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 04.05.2018 18:50, Stefan Hajnoczi wrote:
> > Commit 8565c3ab537e78f3e69977ec2c609dc9417a806e ("qemu-iotests: fix
> > 185") identified a race condition in a sub-test.
> >
> > Similar issues also affect the other sub-tes
On 05/08/2018 07:21 AM, Juan Quintela wrote:
"Michael S. Tsirkin" wrote:
When pulling in headers that are in the same directory as C file (as
opposed to one in include/), we should use its relative path, without a
directory. Directory based path works more or less by accident.
No, it is not b
On 07.05.2018 09:14, Markus Armbruster wrote:
[...]
> Two (possibly confused) questions:
>
> 1. The user can add nics without convenience options:
>
> $ upstream-qemu -display none -nodefaults -device e1000
> upstream-qemu: warning: nic e1000.0 has no peer
>
>Shouldn't we silence the
* Peter Xu (pet...@redhat.com) wrote:
> It pauses an ongoing migration. Currently it only supports postcopy.
> Note that this command will work on either side of the migration.
> Basically when we trigger this on one side, it'll interrupt the other
> side as well since the other side will get noti
Hi,
> d) For smaller amount of RAM it might still fail if
> RAM+rounding+pci+hotplug space goes over the limit.
> Figuring that limit out is tricky (and I thought it
> might be BIOS/EFI dependent as well depending where they
> decide to put their PCI devices)
Both seabios and o
On 6 May 2018 at 00:35, Michael Clark wrote:
> The following changes since commit c8b7e627b4269a3bc3ae41d9f420547a47e6d9b9:
>
> Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-05-04' into
> staging (2018-05-04 14:42:46 +0100)
>
> are available in the git repository at:
>
> http
On 7 May 2018 at 10:44, Gerd Hoffmann wrote:
> The following changes since commit c8b7e627b4269a3bc3ae41d9f420547a47e6d9b9:
>
> Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-05-04' into
> staging (2018-05-04 14:42:46 +0100)
>
> are available in the git repository at:
>
> git:
On Fri, 4 May 2018 02:24:12 +0200
Thomas Huth wrote:
> On 03.05.2018 21:50, Michael S. Tsirkin wrote:
> > we just need a struct name, let's add a forward
> > declaration instead of an include.
> >
> > Signed-off-by: Michael S. Tsirkin
> > ---
> > include/hw/s390x/sclp.h | 3 ++-
> > 1 file cha
On 05/07/2018 05:51 PM, Cornelia Huck wrote:
On Friday, Thomas noticed some problems with 3270 devices. One result
was "s390x/css: disabled subchannels cannot be status pending", but
a reboot did not cure the previous broken status. Turns out that 3270
devices are missing a reset handler.
This
On 05/07/2018 05:51 PM, Cornelia Huck wrote:
All the different virtio ccw devices use the same reset handler,
so let's move setting it into the base virtio ccw device class.
Signed-off-by: Cornelia Huck
Reviewed-by: Halil Pasic
---
hw/s390x/virtio-ccw.c | 13 +
[..]
On 08.05.2018 15:23, Cornelia Huck wrote:
> On Fri, 4 May 2018 02:24:12 +0200
> Thomas Huth wrote:
>
>> On 03.05.2018 21:50, Michael S. Tsirkin wrote:
>>> we just need a struct name, let's add a forward
>>> declaration instead of an include.
>>>
>>> Signed-off-by: Michael S. Tsirkin
>>> ---
>>>
On 8 May 2018 at 13:41, Philippe Mathieu-Daudé wrote:
> Hi,
>
> Travis CI hit this error testing commit 853f8ca13cd6d256:
>
> $ clang --version
> Apple LLVM version 8.1.0 (clang-802.0.42)
> Target: x86_64-apple-darwin16.7.0
>
> $ ./configure
> C compilerclang
> host CPU x86_64
> .
On 05/07/2018 05:51 PM, Cornelia Huck wrote:
Thomas reported that the subchannel for a 3270 device that ended up
in a broken state (status pending even though not enabled) did not
get out of that state even after a reboot (which involves a subsytem
reset). The reason for this is that the 3270
On Tue, 8 May 2018 15:38:03 +0200
Thomas Huth wrote:
> On 08.05.2018 15:23, Cornelia Huck wrote:
> > On Fri, 4 May 2018 02:24:12 +0200
> > Thomas Huth wrote:
> >
> >> On 03.05.2018 21:50, Michael S. Tsirkin wrote:
> >>> we just need a struct name, let's add a forward
> >>> declaration inste
On 05/08/2018 02:46 PM, Cornelia Huck wrote:
On Tue, 8 May 2018 08:25:03 -0400
Tony Krowiak wrote:
Added entries for the s390 adjunct processor (AP) support.
Signed-off-by: Tony Krowiak
---
MAINTAINERS | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
[..]
+M
On Thu, 3 May 2018 22:51:43 +0300
"Michael S. Tsirkin" wrote:
> This way they are easier to find.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> hw/s390x/s390-virtio-ccw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio
On Tue, May 08, 2018 at 09:41:05AM -0300, Philippe Mathieu-Daudé wrote:
> Hi,
>
> Travis CI hit this error testing commit 853f8ca13cd6d256:
>
> $ clang --version
> Apple LLVM version 8.1.0 (clang-802.0.42)
> Target: x86_64-apple-darwin16.7.0
>
> $ ./configure
> C compilerclang
> host CPU
1 - 100 of 387 matches
Mail list logo
