[Qemu-devel] [PATCH v2 1/4] vmdk: Refactor vmdk_create_extent

2018-05-15 Thread Fam Zheng
The extracted vmdk_init_extent takes a BlockBackend object and initializes the format metadata. It is the common part between "qemu-img create" and "blockdev-create". Add a "BlockBackend *pbb" parameter to vmdk_create_extent, to return the opened BB to the caller in the next patch.

Re: [Qemu-devel] [PATCH v6 2/2] qga: update guest-suspend-ram and guest-suspend-hybrid descriptions

2018-05-15 Thread Markus Armbruster
Daniel Henrique Barboza writes: > This patch updates the descriptions of 'guest-suspend-ram' and > 'guest-suspend-hybrid' to mention that both commands relies now > on the existence of 'system_wakeup' and also on the proper support > for wake up from suspend, retrieved by

Re: [Qemu-devel] [qemu-s390x] virtio-ccw.c vs larger VIRTIO_QUEUE_MAX (coverity warning CID 1390619)

2018-05-15 Thread Halil Pasic
On 05/15/2018 04:01 PM, Cornelia Huck wrote: On Tue, 15 May 2018 15:17:51 +0200 Halil Pasic wrote: 8< From: Halil Pasic Date: Tue, 15 May 2018 13:57:44 +0200 Subject:

Re: [Qemu-devel] [PATCH V7 RESEND 13/17] COLO: flush host dirty ram from cache

2018-05-15 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangc...@gmail.com) wrote: > From: zhanghailiang > > Don't need to flush all VM's ram from cache, only > flush the dirty pages since last checkpoint > > Signed-off-by: Li Zhijian > Signed-off-by: Zhang Chen

[Qemu-devel] [PATCH] ccid-card-passthru: fix regression in realize()

2018-05-15 Thread Marc-André Lureau
Since cc847bfd16d894fd8c1a2ce25f31772f6cdbbc74, CCID card-passthru fails to intialize, because it changed a debug line to an error, probably by mistake. Change it back to a DPRINTF debug. (solves Boxes creating VM with smartcard passthru failing to start) Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH v2 1/2] hw/isa/superio: Fix inconsistent use of Chardev->be

2018-05-15 Thread Paolo Bonzini
On 15/05/2018 17:24, Philippe Mathieu-Daudé wrote: > 4c3119a6e3e and cd9526ab7c0 introduced an incorrect and inconsistent > use of Chardev->be. Also, this CharBackend member is private and is > not supposed to be accessible. > > Fix it by removing the inconsistent check. > > Cc:

Re: [Qemu-devel] [PATCH v2] numa: clarify error message when node index is out of range in -numa dist, ...

2018-05-15 Thread Andrew Jones
On Tue, May 15, 2018 at 04:48:33PM +0200, Igor Mammedov wrote: > When using following CLI: > -numa dist,src=128,dst=1,val=20 > user gets a rather confusing error message: >"Invalid node 128, max possible could be 128" > > Where 128 is number of nodes that QEMU supports (MAX_NODES), > while

Re: [Qemu-devel] [PATCH RFC] qemu-error: introduce error_report_once

2018-05-15 Thread Eric Blake
On 05/15/2018 04:13 AM, Peter Xu wrote: I stole the printk_once() macro. I always wanted to be able to print some error directly if there is a buffer to dump, however we can't use error_report() really quite often when there can be any DDOS attack. To avoid that, we can introduce a print-once

Re: [Qemu-devel] [PATCH] linux-user: update comments to point to cpu_create()

2018-05-15 Thread Laurent Vivier
Le 15/05/2018 à 16:22, Igor Mammedov a écrit : > On Tue, 15 May 2018 13:32:33 +0200 > Laurent Vivier wrote: > >> Le 15/05/2018 à 13:17, Igor Mammedov a écrit : >>> cpu_init() was replaced by cpu_create() since 2.12 but comments >>> weren't updated. So update stale comments

Re: [Qemu-devel] [PATCH v2 1/2] hw/isa/superio: Fix inconsistent use of Chardev->be

2018-05-15 Thread Marc-André Lureau
On Tue, May 15, 2018 at 5:24 PM, Philippe Mathieu-Daudé wrote: > 4c3119a6e3e and cd9526ab7c0 introduced an incorrect and inconsistent > use of Chardev->be. Also, this CharBackend member is private and is > not supposed to be accessible. > > Fix it by removing the inconsistent

Re: [Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-15 Thread Eric Blake
On 05/15/2018 06:33 AM, Yi Min Zhao wrote: If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capability and then trigger the guest startup fails. So this patch excludes the code s/trigger the guest startup

[Qemu-devel] [PATCH v2 0/2] mux: fix ctrl-a b again

2018-05-15 Thread Philippe Mathieu-Daudé
Hi, this series contains the rebased patches for the ctrl-a+b fix. Please consider to include in qemu-stable. Regards, Phil. v2: - rebase on Peter serial cleanup: "Drop compile time limit on number of serial ports" http://lists.nongnu.org/archive/html/qemu-devel/2018-04/msg03376.html -

[Qemu-devel] [PATCH v2 2/2] mux: fix ctrl-a b again

2018-05-15 Thread Philippe Mathieu-Daudé
From: Marc-André Lureau Commit fb5e19d2e1472e96d72d5e4d89c20033f8ab345c originally fixed the regression, but was inadvertently broken again in merge commit 2d6752d38d8acda. Fixes: https://bugs.launchpad.net/qemu/+bug/1654137 Cc: qemu-sta...@nongnu.org

[Qemu-devel] [PATCH v2 1/2] hw/isa/superio: Fix inconsistent use of Chardev->be

2018-05-15 Thread Philippe Mathieu-Daudé
4c3119a6e3e and cd9526ab7c0 introduced an incorrect and inconsistent use of Chardev->be. Also, this CharBackend member is private and is not supposed to be accessible. Fix it by removing the inconsistent check. Cc: qemu-sta...@nongnu.org Reported-by: Marc-André Lureau

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 02/18] memory-device: introduce separate config option

2018-05-15 Thread Eric Blake
On 05/14/2018 07:20 PM, Murilo Opsfelder Araujo wrote: On Mon, May 14, 2018 at 12:00:07PM +0200, David Hildenbrand wrote: Some architectures might support memory devices, while they don't support DIMM/NVDIMM. So let's - Rename CONFIG_MEM_HOTPLUG to CONFIG_MEM_DEVICE - Intriduce CONFIG_DIMM and

Re: [Qemu-devel] [PATCH 1/2] qapi: allow flat unions with empty branches

2018-05-15 Thread Eric Blake
On 05/15/2018 02:01 AM, Markus Armbruster wrote: QAPI language design alternatives: 1. Having unions cover all discriminator values explicitly is useful. 2. Having unions repeat all the discriminator values explicitly is not useful. All we need is replacing the code enforcing that by code

Re: [Qemu-devel] [PATCH] HACKING: document preference for g_new instead of g_malloc

2018-05-15 Thread Alex Bennée
Murilo Opsfelder Araujo writes: > This patch documents the preference for g_new instead of g_malloc. The > reasons were adapted from commit b45c03f585ea9bb1af76c73e82195418c294919d. > > Discussion in QEMU's mailing list: >

Re: [Qemu-devel] [PATCH] memory.h: Fix typo in documentation comment

2018-05-15 Thread Alex Bennée
Peter Maydell writes: > Signed-off-by: Peter Maydell > --- > include/exec/memory.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/exec/memory.h b/include/exec/memory.h > index 525619a5f4..4fa1227f13 100644 >

Re: [Qemu-devel] [PATCH v2 1/3] xen-hvm: create separate function for ioreq server initialization

2018-05-15 Thread Anthony PERARD
On Thu, May 10, 2018 at 10:15:16AM +0100, Paul Durrant wrote: > The code is sufficiently substantial that it improves code readability > to put it in a new function called by xen_hvm_init() rather than having > it inline. > > Signed-off-by: Paul Durrant Reviewed-by:

Re: [Qemu-devel] [PULL 2/4] net: Remove the deprecated "vlan" parameter

2018-05-15 Thread Eric Blake
On 05/14/2018 02:55 AM, Jason Wang wrote: From: Thomas Huth It's been marked as deprecated since QEMU v2.9.0, so that should have been enough time for everybody to either just drop unnecessary "vlan=0" parameters, to switch to the modern -device + -netdev syntax for

Re: [Qemu-devel] [PATCH v5 4/6] s390x/vfio: ap: Introduce VFIO AP device

2018-05-15 Thread Tony Krowiak
On 05/15/2018 03:55 AM, Pierre Morel wrote: On 14/05/2018 21:26, Tony Krowiak wrote: On 05/11/2018 05:02 AM, Pierre Morel wrote: On 10/05/2018 15:10, Tony Krowiak wrote: On 05/09/2018 10:28 AM, Halil Pasic wrote: On 05/08/2018 02:25 PM, Tony Krowiak wrote: Introduces a VFIO based AP

Re: [Qemu-devel] [PATCH 1/2] hw/virtio: Fix brace Werror with clang 6.0.0

2018-05-15 Thread Eric Blake
On 05/11/2018 08:48 PM, Richard Henderson wrote: The warning is hw/virtio/vhost-user.c:1319:26: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces] VhostUserMsg msg = { 0 }; ^ {} While the original

Re: [Qemu-devel] [PATCH v5 3/6] s390x/cpumodel: Set up CPU model for AP device support

2018-05-15 Thread Tony Krowiak
On 05/15/2018 08:00 AM, Pierre Morel wrote: On 08/05/2018 14:25, Tony Krowiak wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. CPU model features: 1. The KVM_S390_VM_CPU_FEAT_AP CPU model feature indicates that AP

Re: [Qemu-devel] [PATCH] configure: Use strings command from cross development tools

2018-05-15 Thread Peter Maydell
On 15 May 2018 at 16:00, Eric Blake wrote: > On 05/13/2018 03:50 AM, Stefan Weil wrote: >> >> This fixes cross builds for the (rare) case where cross binutils >> but no native binutils are installed. >> >> Signed-off-by: Stefan Weil >> --- >> configure | 5

Re: [Qemu-devel] [PATCH v5 10/28] target/arm: convert conversion helpers to fpst/ahp_flag

2018-05-15 Thread Richard Henderson
On 05/15/2018 03:08 AM, Peter Maydell wrote: > On 14 May 2018 at 23:12, Richard Henderson > wrote: >> From: Alex Bennée >> >> Instead of passing env and leaving it up to the helper to get the >> right fpstatus we pass it explicitly. There

Re: [Qemu-devel] [PATCH] configure: Use strings command from cross development tools

2018-05-15 Thread Eric Blake
On 05/13/2018 03:50 AM, Stefan Weil wrote: This fixes cross builds for the (rare) case where cross binutils but no native binutils are installed. Signed-off-by: Stefan Weil --- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PULL 00/16] target-arm queue

2018-05-15 Thread Peter Maydell
On 15 May 2018 at 15:06, Peter Maydell <peter.mayd...@linaro.org> wrote: > The following changes since commit ad1b4ec39caa5b3f17cbd8160283a03a3dcfe2ae: > > Merge remote-tracking branch > 'remotes/kraxel/tags/input-20180515-pull-request' into staging (2018-05-15

Re: [Qemu-devel] [PATCH v9 1/9] mirror: inherit supported write/zero flags

2018-05-15 Thread Anton Nefedov
On 15/5/2018 5:35 PM, Eric Blake wrote: On 05/08/2018 09:58 AM, Anton Nefedov wrote: diff --git a/block/mirror.c b/block/mirror.c index 820f512..a22ddef 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -1098,6 +1098,15 @@ static BlockDriver bdrv_mirror_top = {   .bdrv_child_perm

Re: [Qemu-devel] [PATCH] disas/libvixl: Fix VIXL_FALLTHROUGH macro for QEMU

2018-05-15 Thread Richard Henderson
On 05/15/2018 06:25 AM, Peter Maydell wrote: > On 15 May 2018 at 14:13, Stefan Weil wrote: >> This is fixed in upstream vixl, in fact: >> >> https://git.linaro.org/arm/vixl.git/commit/?id=de326f850f736c3a337fda52845ed3d2e620cc02 >> >> That fix will work for the moment, but is

Re: [Qemu-devel] [PATCH v3 5/6] migration: implement bi-directional RDMA QIOChannel

2018-05-15 Thread Paolo Bonzini
On 05/05/2018 16:35, Lidong Chen wrote: > @@ -2635,12 +2637,20 @@ static ssize_t qio_channel_rdma_writev(QIOChannel > *ioc, > { > QIOChannelRDMA *rioc = QIO_CHANNEL_RDMA(ioc); > QEMUFile *f = rioc->file; > -RDMAContext *rdma = rioc->rdma; > +RDMAContext *rdma; > int ret; >

Re: [Qemu-devel] [PATCH V7 RESEND 09/17] COLO: Flush memory data from ram cache

2018-05-15 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangc...@gmail.com) wrote: > During the time of VM's running, PVM may dirty some pages, we will transfer > PVM's dirty pages to SVM and store them into SVM's RAM cache at next > checkpoint > time. So, the content of SVM's RAM cache will always be same with PVM's memory > after

Re: [Qemu-devel] [PATCH] disas/libvixl: Fix VIXL_FALLTHROUGH macro for QEMU

2018-05-15 Thread Peter Maydell
On 15 May 2018 at 15:46, Richard Henderson wrote: > On 05/15/2018 06:25 AM, Peter Maydell wrote: >> I guess that having the compiler check is better than finding them >> later with coverity. It's a shame gcc doesn't support the standard >> mechanism of using /* fallthrough */ to

Re: [Qemu-devel] [PATCH v9 3/9] quorum: set supported write/zero flags

2018-05-15 Thread Eric Blake
On 05/08/2018 09:58 AM, Anton Nefedov wrote: Signed-off-by: Anton Nefedov Reviewed-by: Alberto Garcia --- block/quorum.c | 20 1 file changed, 20 insertions(+) Reviewed-by: Eric Blake -- Eric Blake,

[Qemu-devel] [PATCH v2] numa: clarify error message when node index is out of range in -numa dist, ...

2018-05-15 Thread Igor Mammedov
When using following CLI: -numa dist,src=128,dst=1,val=20 user gets a rather confusing error message: "Invalid node 128, max possible could be 128" Where 128 is number of nodes that QEMU supports (MAX_NODES), while src/dst is an index up to that limit, so it should be MAX_NODES - 1 in error

Re: [Qemu-devel] [PATCH] numa: clarify error message when node index is out of range in -numa dist, ...

2018-05-15 Thread Igor Mammedov
On Tue, 15 May 2018 16:24:50 +0200 Andrew Jones wrote: > Pretty long patch summary line. Do we not try to limit that? > > On Tue, May 15, 2018 at 12:40:58PM +0200, Igor Mammedov wrote: > > When using following CLI: > > -numa dist,src=128,dst=1,val=20 > > user getsi a

Re: [Qemu-devel] [PATCH v9 1/9] mirror: inherit supported write/zero flags

2018-05-15 Thread Eric Blake
On 05/08/2018 09:58 AM, Anton Nefedov wrote: Signed-off-by: Anton Nefedov Reviewed-by: Alberto Garcia --- block/mirror.c | 11 +++ 1 file changed, 11 insertions(+) Reviewed-by: Eric Blake That said, diff --git

Re: [Qemu-devel] [PATCH] WHPX Add signature CPUID

2018-05-15 Thread Paolo Bonzini
On 15/05/2018 13:37, petrutlucia...@gmail.com wrote: > From: Lucian Petrut > > Adds the CPUID trap for CPUID 0x4000, sending the WHPX signature > to the guest upon request. This is consistent with other QEMU > accelerators (KVM). > > Signed-off-by: Alessandro

Re: [Qemu-devel] [PATCH 00/42] Generic background jobs

2018-05-15 Thread Eric Blake
On 05/15/2018 09:15 AM, Kevin Wolf wrote: Am 09.05.2018 um 18:25 hat Kevin Wolf geschrieben: Before we can make x-blockdev-create a background job, we need to generalise the job infrastructure so that it can be used without any associated block node. This series extracts a Job object from the

Re: [Qemu-devel] [PATCH v1 1/7] hmat acpi: Build Memory Subsystem Address Range Structre(s) in ACPI HMAT

2018-05-15 Thread Igor Mammedov
On Wed, 9 May 2018 16:34:29 +0800 Liu Jingqi wrote: series submission note Could you use cover letter when sending multipatch series please? It should describe whole series impact and provides anchor point for thread. Look for 'git --cover-letter' in git's man page.

[Qemu-devel] [PATCH v3] memory.h: Improve IOMMU related documentation

2018-05-15 Thread Peter Maydell
Add more detail to the documentation for memory_region_init_iommu() and other IOMMU-related functions and data structures. Signed-off-by: Peter Maydell --- v2->v3 changes: * minor wording tweaks per Eric's review * moved the bit about requirements to notify out from

Re: [Qemu-devel] [PATCH] memory.h: Fix typo in documentation comment

2018-05-15 Thread Paolo Bonzini
On 15/05/2018 15:48, Peter Maydell wrote: > Signed-off-by: Peter Maydell > --- > include/exec/memory.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/exec/memory.h b/include/exec/memory.h > index 525619a5f4..4fa1227f13 100644 > ---

Re: [Qemu-devel] [PATCH] riscv: remove define cpu_init()

2018-05-15 Thread Philippe Mathieu-Daudé
On 05/15/2018 08:16 AM, Igor Mammedov wrote: > cpu_init() was removed since 2.12, so drop define that now isn't used > nad point to nowhere. > > Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé > --- > target/riscv/cpu.h | 1 - > 1 file

Re: [Qemu-devel] [PATCH] coverity-model: replay data is considered trusted

2018-05-15 Thread Markus Armbruster
Paolo Bonzini writes: > On 15/05/2018 14:00, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> Replay data is not considered a possible attack vector; add a model that >>> does not use getc so that "tainted data" warnings are suppressed. >>> >>>

Re: [Qemu-devel] [PATCH v1 1/7] hmat acpi: Build Memory Subsystem Address Range Structre(s) in ACPI HMAT

2018-05-15 Thread Igor Mammedov
On Wed, 9 May 2018 16:34:29 +0800 Liu Jingqi wrote: > HMAT is defined in ACPI 6.2: 5.2.27 Heterogeneous Memory Attribute Table > (HMAT). > The specification references below link: > http://www.uefi.org/sites/default/files/resources/ACPI_6_2.pdf > > It describes the

Re: [Qemu-devel] [PATCH v9 2/9] blkverify: set supported write/zero flags

2018-05-15 Thread Eric Blake
On 05/08/2018 09:58 AM, Anton Nefedov wrote: Signed-off-by: Anton Nefedov Reviewed-by: Alberto Garcia Reviewed-by: Max Reitz --- block/blkverify.c | 9 + 1 file changed, 9 insertions(+) diff --git

[Qemu-devel] [PATCH] memory: get rid of memory_region_init_reservation

2018-05-15 Thread Paolo Bonzini
The function has been deprecated for 2.5 years, and there are just a handful of users. Convert them to memory_region_init_io with NULL callbacks, and while at it pass the right device as the owner. Signed-off-by: Paolo Bonzini --- docs/devel/memory.txt | 5 ++---

Re: [Qemu-devel] [PATCH] numa: clarify error message when node index is out of range in -numa dist, ...

2018-05-15 Thread Andrew Jones
Pretty long patch summary line. Do we not try to limit that? On Tue, May 15, 2018 at 12:40:58PM +0200, Igor Mammedov wrote: > When using following CLI: > -numa dist,src=128,dst=1,val=20 > user getsi a rather confusing error message: gets >"Invalid node 128, max possible could be 128" >

Re: [Qemu-devel] [PATCH] linux-user: update comments to point to cpu_create()

2018-05-15 Thread Igor Mammedov
On Tue, 15 May 2018 13:32:33 +0200 Laurent Vivier wrote: > Le 15/05/2018 à 13:17, Igor Mammedov a écrit : > > cpu_init() was replaced by cpu_create() since 2.12 but comments > > weren't updated. So update stale comments now. > > > > Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [PATCH qemu v2] slirp/debug: Print IP addresses in human readable form

2018-05-15 Thread Eric Blake
On 05/14/2018 02:00 AM, Alexey Kardashevskiy wrote: On 13/3/18 6:44 pm, Samuel Thibault wrote: Alexey Kardashevskiy, on mar. 13 mars 2018 15:49:44 +1100, wrote: Signed-off-by: Alexey Kardashevskiy Applied to my tree, thanks! And what is your tree, is this something to be

Re: [Qemu-devel] [PATCH v4] migration: discard non-migratable RAMBlocks

2018-05-15 Thread Dr. David Alan Gilbert
* Cédric Le Goater (c...@kaod.org) wrote: > On the POWER9 processor, the XIVE interrupt controller can control > interrupt sources using MMIO to trigger events, to EOI or to turn off > the sources. Priority management and interrupt acknowledgment is also > controlled by MMIO in the presenter

Re: [Qemu-devel] [PATCH v5 0/2] qmp: 'wakeup-suspend-support' in query-target

2018-05-15 Thread Daniel Henrique Barboza
On 05/15/2018 02:29 AM, Markus Armbruster wrote: git-am isn't happy on current master. The conflicts look simple enough for a maintainer to resolve, but that's yet another hurdle. Best to respin, I think (assuming you still want the patches to go in). Just respinned it to v6. Let's see how

Re: [Qemu-devel] [PATCH V7 10/17] qmp event: Add COLO_EXIT event to notify users while exited COLO

2018-05-15 Thread Markus Armbruster
Zhang Chen writes: > From: zhanghailiang > > If some errors happen during VM's COLO FT stage, it's important to > notify the users of this event. Together with 'x-colo-lost-heartbeat', > Users can intervene in COLO's failover work

Re: [Qemu-devel] [PATCH] HACKING: document preference for g_new instead of g_malloc

2018-05-15 Thread Eric Blake
On 05/15/2018 08:49 AM, Murilo Opsfelder Araujo wrote: This patch documents the preference for g_new instead of g_malloc. The reasons were adapted from commit b45c03f585ea9bb1af76c73e82195418c294919d. Discussion in QEMU's mailing list:

[Qemu-devel] [PATCH v6 1/2] qmp: adding 'wakeup-suspend-support' in query-target

2018-05-15 Thread Daniel Henrique Barboza
When issuing the qmp/hmp 'system_wakeup' command, what happens in a nutshell is: - qmp_system_wakeup_request set runstate to RUNNING, sets a wakeup_reason and notify the event - in the main_loop, all vcpus are paused, a system reset is issued, all subscribers of wakeup_notifiers receives a

Re: [Qemu-devel] [PATCH V7 11/17] qapi: Add new command to query colo status

2018-05-15 Thread Markus Armbruster
Zhang Chen writes: > Libvirt or other high level software can use this command query colo status. > You can test this command like that: > {'execute':'query-colo-status'} > > Signed-off-by: Zhang Chen > --- > migration/colo.c| 34

Re: [Qemu-devel] [PATCH 00/42] Generic background jobs

2018-05-15 Thread Kevin Wolf
Am 09.05.2018 um 18:25 hat Kevin Wolf geschrieben: > Before we can make x-blockdev-create a background job, we need to > generalise the job infrastructure so that it can be used without any > associated block node. > > This series extracts a Job object from the block job infrastructure, > which

[Qemu-devel] [PATCH v6 2/2] qga: update guest-suspend-ram and guest-suspend-hybrid descriptions

2018-05-15 Thread Daniel Henrique Barboza
This patch updates the descriptions of 'guest-suspend-ram' and 'guest-suspend-hybrid' to mention that both commands relies now on the existence of 'system_wakeup' and also on the proper support for wake up from suspend, retrieved by the 'wakeup-suspend-support' attribute of the 'query-target' QMP

Re: [Qemu-devel] [PATCH v2 1/1] qmp.c: system_wakeup: adding RUN_STATE_SUSPENDED check before proceeding

2018-05-15 Thread Eric Blake
On 05/14/2018 04:50 PM, Daniel Henrique Barboza wrote: The qmp/hmp command 'system_wakeup' is simply a direct call to 'qemu_system_wakeup_request' from vl.c. This function verifies if runstate is SUSPENDED and if the wake up reason is valid before proceeding. However, no error or warning is

[Qemu-devel] [PATCH v6 0/2] qmp: 'wakeup-suspend-support' in query-target

2018-05-15 Thread Daniel Henrique Barboza
v6: - rebased with current master after being buried for a few months - previous version link: https://lists.gnu.org/archive/html/qemu-devel/2018-02/msg04882.html v5: - removed a paragraph in the recently added qemu_register_wakeup_notifier comment that was added. That paragraph was adding too

[Qemu-devel] [PULL 13/16] target/arm: Implement FMOV (immediate) for fp16

2018-05-15 Thread Peter Maydell
From: Alex Bennée All the hard work is already done by vfp_expand_imm, we just need to make sure we pick up the correct size. Cc: qemu-sta...@nongnu.org Reviewed-by: Peter Maydell Signed-off-by: Alex Bennée Tested-by:

Re: [Qemu-devel] [PATCH v3 1/4] tpm: implement virtual memory device for TPM PPI

2018-05-15 Thread Stefan Berger
On 05/15/2018 08:14 AM, Marc-André Lureau wrote: From: Stefan Berger Implement a virtual memory device for the TPM Physical Presence interface. The memory is located at 0xfffef000 and used by ACPI to send messages to the It's now located at 0xFED45000. I changed

[Qemu-devel] [PULL 14/16] target/arm: Fix sqrt_f16 exception raising

2018-05-15 Thread Peter Maydell
From: Alex Bennée We are meant to explicitly pass fpst, not cpu_env. Cc: qemu-sta...@nongnu.org Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Richard Henderson

[Qemu-devel] [PULL 02/16] fpu/softfloat: Don't set Invalid for float-to-int(MAXINT)

2018-05-15 Thread Peter Maydell
In float-to-integer conversion, if the floating point input converts exactly to the largest or smallest integer that fits in to the result type, this is not an overflow. In this situation we were producing the correct result value, but were incorrectly setting the Invalid flag. For example for Arm

[Qemu-devel] [PATCH] iothread: fix epollfd leak in the process of delIOThread

2018-05-15 Thread Jie Wang
When we call addIOThread, the epollfd created in aio_context_setup, but not close it in the process of delIOThread, so the epollfd will leak. Signed-off-by: Jie Wang --- iothread.c | 1 + 1 file changed, 1 insertion(+) diff --git a/iothread.c b/iothread.c index

[Qemu-devel] [PULL 09/16] target/arm: Implement FP data-processing (2 source) for fp16

2018-05-15 Thread Peter Maydell
From: Richard Henderson We missed all of the scalar fp16 binary operations. Cc: qemu-sta...@nongnu.org Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson Tested-by: Alex Bennée

[Qemu-devel] [PULL 16/16] tcg: Optionally log FPU state in TCG -d cpu logging

2018-05-15 Thread Peter Maydell
Usually the logging of the CPU state produced by -d cpu is sufficient to diagnose problems, but sometimes you want to see the state of the floating point registers as well. We don't want to enable that by default as it adds a lot of extra data to the log; instead, allow it to be optionally enabled

[Qemu-devel] [PULL 11/16] target/arm: Implement FCMP for fp16

2018-05-15 Thread Peter Maydell
From: Alex Bennée These where missed out from the rest of the half-precision work. Cc: qemu-sta...@nongnu.org Reviewed-by: Peter Maydell Signed-off-by: Alex Bennée Tested-by: Alex Bennée

Re: [Qemu-devel] [PATCH 39/42] job: Add lifecycle QMP commands

2018-05-15 Thread Kevin Wolf
Am 15.05.2018 um 00:31 hat Max Reitz geschrieben: > On 2018-05-09 18:26, Kevin Wolf wrote: > > This adds QMP commands that control the transition between states of the > > job lifecycle. > > > > Signed-off-by: Kevin Wolf > > --- > > qapi/job.json | 112

[Qemu-devel] [PULL 01/16] fpu/softfloat: int_to_float ensure r fully initialised

2018-05-15 Thread Peter Maydell
From: Alex Bennée Reported by Coverity (CID1390635). We ensure this for uint_to_float later on so we might as well mirror that. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Peter Maydell

[Qemu-devel] [PULL 08/16] target/arm: Introduce and use read_fp_hreg

2018-05-15 Thread Peter Maydell
From: Richard Henderson Cc: qemu-sta...@nongnu.org Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Tested-by: Alex Bennée Message-id:

[Qemu-devel] [PULL 03/16] target/arm: Fix fp_status_f16 tininess before rounding

2018-05-15 Thread Peter Maydell
In commit d81ce0ef2c4f105 we added an extra float_status field fp_status_fp16 for Arm, but forgot to initialize it correctly by setting it to float_tininess_before_rounding. This currently will only cause problems for the new V8_FP16 feature, since the float-to-float conversion code doesn't use it

[Qemu-devel] [PULL 07/16] target/arm: Implement FCVT (scalar, fixed-point) for fp16

2018-05-15 Thread Peter Maydell
From: Richard Henderson Cc: qemu-sta...@nongnu.org Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson Tested-by: Alex Bennée Message-id:

[Qemu-devel] [PULL 12/16] target/arm: Implement FCSEL for fp16

2018-05-15 Thread Peter Maydell
From: Alex Bennée These were missed out from the rest of the half-precision work. Cc: qemu-sta...@nongnu.org Reviewed-by: Peter Maydell Signed-off-by: Alex Bennée Tested-by: Alex Bennée

[Qemu-devel] [PULL 05/16] target/arm: Early exit after unallocated_encoding in disas_fp_int_conv

2018-05-15 Thread Peter Maydell
From: Richard Henderson No sense in emitting code after the exception. Signed-off-by: Richard Henderson Tested-by: Alex Bennée Message-id: 20180512003217.9105-3-richard.hender...@linaro.org Reviewed-by: Peter

[Qemu-devel] [PULL 15/16] sdcard: Correct CRC16 offset in sd_function_switch()

2018-05-15 Thread Peter Maydell
From: Philippe Mathieu-Daudé Per the Physical Layer Simplified Spec. "4.3.10.4 Switch Function Status": The block length is predefined to 512 bits and "4.10.2 SD Status": The SD Status contains status bits that are related to the SD Memory Card proprietary features and

[Qemu-devel] [PULL 04/16] target/arm: Implement FMOV (general) for fp16

2018-05-15 Thread Peter Maydell
From: Richard Henderson Adding the fp16 moves to/from general registers. Cc: qemu-sta...@nongnu.org Signed-off-by: Richard Henderson Tested-by: Alex Bennée Message-id:

[Qemu-devel] [PULL 06/16] target/arm: Implement FCVT (scalar, integer) for fp16

2018-05-15 Thread Peter Maydell
From: Richard Henderson Cc: qemu-sta...@nongnu.org Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson Tested-by: Alex Bennée Message-id:

[Qemu-devel] [PULL 00/16] target-arm queue

2018-05-15 Thread Peter Maydell
The following changes since commit ad1b4ec39caa5b3f17cbd8160283a03a3dcfe2ae: Merge remote-tracking branch 'remotes/kraxel/tags/input-20180515-pull-request' into staging (2018-05-15 12:50:06 +0100) are available in the Git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git

[Qemu-devel] [PULL 10/16] target/arm: Implement FP data-processing (3 source) for fp16

2018-05-15 Thread Peter Maydell
From: Richard Henderson We missed all of the scalar fp16 fma operations. Cc: qemu-sta...@nongnu.org Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson Tested-by: Alex Bennée

Re: [Qemu-devel] [PATCH] WHPX Add signature CPUID

2018-05-15 Thread Justin Terry (VM) via Qemu-devel
Thanks for the patch Lucian. Looks good to me! -Justin > -Original Message- > From: petrutlucia...@gmail.com > Sent: Tuesday, May 15, 2018 4:38 AM > Cc: Lucian Petrut ; apilotti > ; Justin Terry

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 16/17] s390x: initialize memory region for memory devices

2018-05-15 Thread Murilo Opsfelder Araujo
On Tue, May 15, 2018 at 09:57:43AM +0200, David Hildenbrand wrote: > On 15.05.2018 07:58, Markus Armbruster wrote: > > Murilo Opsfelder Araujo writes: > > > >> On Sat, May 12, 2018 at 09:53:54AM +0200, David Hildenbrand wrote: > >>> On 11.05.2018 20:43, Eduardo Habkost

Re: [Qemu-devel] [qemu-s390x] virtio-ccw.c vs larger VIRTIO_QUEUE_MAX (coverity warning CID 1390619)

2018-05-15 Thread Cornelia Huck
On Tue, 15 May 2018 15:17:51 +0200 Halil Pasic wrote: > 8< > From: Halil Pasic > Date: Tue, 15 May 2018 13:57:44 +0200 > Subject: [PATCH] WIP: cleanup virtio notify > >

Re: [Qemu-devel] [PULL 0/2] Input 20180515 patches

2018-05-15 Thread Peter Maydell
are available in the git repository at: > > git://git.kraxel.org/qemu tags/input-20180515-pull-request > > for you to fetch changes up to 7abe7eb29494b4e4a11ec99ae5623083409a2f1e: > > ps2: Fix mouse stream corruption due

Re: [Qemu-devel] [PATCH v5 00/28] softfloat patch roundup

2018-05-15 Thread Alex Bennée
Richard Henderson writes: > This is my SNaN patch set, Alex's float-float refactor, and a couple > of other random outstanding fpu patches. This has been reordered so > as to be bisectable, since the float-float refactor requires the snan > work to avoid breakage.

Re: [Qemu-devel] [PATCH v5 23/28] fpu/softfloat: Make is_nan et al available to softfloat-specialize.h

2018-05-15 Thread Alex Bennée
Richard Henderson writes: > We will need these helpers within softfloat-specialize.h, so move > the definitions above the include. After specialization, they will > not always be used so mark them to avoid the Werror. > > Signed-off-by: Richard Henderson

Re: [Qemu-devel] [PATCH v5 22/28] fpu/softfloat: Specialize on snan_bit_is_one

2018-05-15 Thread Alex Bennée
Richard Henderson writes: > Only MIPS requires snan_bit_is_one to be variable. While we are > specializing softfloat behaviour, allow other targets to eliminate > this runtime check. > > Cc: Aurelien Jarno > Cc: Yongbok Kim

[Qemu-devel] [PATCH] HACKING: document preference for g_new instead of g_malloc

2018-05-15 Thread Murilo Opsfelder Araujo
This patch documents the preference for g_new instead of g_malloc. The reasons were adapted from commit b45c03f585ea9bb1af76c73e82195418c294919d. Discussion in QEMU's mailing list: http://lists.nongnu.org/archive/html/qemu-devel/2018-05/msg03238.html Cc: qemu-devel@nongnu.org Cc: David

[Qemu-devel] [PATCH] memory.h: Fix typo in documentation comment

2018-05-15 Thread Peter Maydell
Signed-off-by: Peter Maydell --- include/exec/memory.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 525619a5f4..4fa1227f13 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -679,7

Re: [Qemu-devel] [PATCH v5 28/28] fpu/softfloat: Define floatN_silence_nan in terms of parts_silence_nan

2018-05-15 Thread Alex Bennée
Richard Henderson writes: > Isolate the target-specific choice to 3 functions instead of 6. > > The code in floatx80_default_nan tried to be over-general. There are > only two targets that support this format: x86 and m68k. Thus there > is no point in inventing a

Re: [Qemu-devel] [PATCH v5 27/28] fpu/softfloat: Clean up parts_default_nan

2018-05-15 Thread Alex Bennée
Richard Henderson writes: > Reduce the number of ifdefs. Correct the result for OpenRISC > and TriCore (although TriCore fixed in target-specific code). > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée

Re: [Qemu-devel] [PATCH v5 21/28] fpu/softfloat: Remove floatX_maybe_silence_nan

2018-05-15 Thread Alex Bennée
Richard Henderson writes: > These functions are now unused. > > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- >

Re: [Qemu-devel] [PATCH v5 20/28] fpu/softfloat: Use float*_silence_nan in propagateFloat*NaN

2018-05-15 Thread Alex Bennée
Richard Henderson writes: > We have already checked the arguments for SNaN; > we don't need to do it again. > > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée

Re: [Qemu-devel] [PATCH] replace functions which are only available in glib-2.24

2018-05-15 Thread Thomas Huth
On 15.05.2018 10:41, Paolo Bonzini wrote: > On 15/05/2018 09:42, Markus Armbruster wrote: >> Olaf Hering writes: >> >>> Currently the minimal supported version of glib is 2.22. >>> Since testing is done with a glib that claims to be 2.22, but in fact >>> has APIs from newer

Re: [Qemu-devel] [PATCH v5 15/28] target/hppa: Remove floatX_maybe_silence_nan from conversions

2018-05-15 Thread Alex Bennée
Richard Henderson writes: > This is now handled properly by the generic softfloat code. > > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée >

Re: [Qemu-devel] [qemu-s390x] virtio-ccw.c vs larger VIRTIO_QUEUE_MAX (coverity warning CID 1390619)

2018-05-15 Thread Cornelia Huck
On Tue, 15 May 2018 14:00:30 +0200 Halil Pasic wrote: > On 05/15/2018 10:32 AM, Cornelia Huck wrote: > > On Mon, 14 May 2018 19:12:27 +0100 > > Peter Maydell wrote: > >> (Other odd code in that function: > >> vector = 0; > >> [...] > >>

Re: [Qemu-devel] [PATCH v5 12/28] target/arm: Remove floatX_maybe_silence_nan from conversions

2018-05-15 Thread Alex Bennée
Richard Henderson writes: > This is now handled properly by the generic softfloat code. > > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée >

[Qemu-devel] [Bug 1771238] Re: Not able to passthrough > 32 PCIe devices to a KVM Guest

2018-05-15 Thread David Coronel
** Changed in: qemu (Ubuntu) Importance: High => Undecided -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1771238 Title: Not able to passthrough > 32 PCIe devices to a KVM Guest Status in QEMU:

Re: [Qemu-devel] [PATCH] disas/libvixl: Fix VIXL_FALLTHROUGH macro for QEMU

2018-05-15 Thread Peter Maydell
On 15 May 2018 at 14:13, Stefan Weil wrote: > This is fixed in upstream vixl, in fact: > > https://git.linaro.org/arm/vixl.git/commit/?id=de326f850f736c3a337fda52845ed3d2e620cc02 > > That fix will work for the moment, but is not sufficient for the future > because it only

Re: [Qemu-devel] [PATCH v5 09/28] target/arm: Use floatX_silence_nan when we have already checked for SNaN

2018-05-15 Thread Alex Bennée
Richard Henderson writes: > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/helper-a64.c | 6 +++--- >

Re: [Qemu-devel] [qemu-s390x] virtio-ccw.c vs larger VIRTIO_QUEUE_MAX (coverity warning CID 1390619)

2018-05-15 Thread Halil Pasic
On 05/15/2018 02:07 PM, Peter Maydell wrote: On 15 May 2018 at 13:00, Halil Pasic wrote: To sum it up, my take on the whole is the diff below. I can convert it to a proper patch if we agree that's the way to go. From: Halil Pasic Date: Tue, 15 May

<    1   2   3   4   5   >