[Qemu-devel] [PATCH v3] ARM: ACPI: Fix use-after-free due to memory realloc

2018-05-30 Thread Shannon Zhao
acpi_data_push uses g_array_set_size to resize the memory size. If there is no enough contiguous memory, the address will be changed. So previous pointer could not be used any more. It must update the pointer and use the new one. Also, previous codes wrongly use le32 conversion of iort->node_offse

[Qemu-devel] [PATCH qemu v3] qom: Document qom/device-list-properties implementation specific

2018-05-30 Thread Alexey Kardashevskiy
The recently introduced qom-list-properties QMP command raised a question what properties it (and its cousin - device-list-properties) can possibly print - only those defined by DeviceClass::props or dynamically created in TypeInfo::instance_init() so properties created elsewhere won't show up and

[Qemu-devel] [PATCH qemu v3 1/2] object: Handle objects with no parents

2018-05-30 Thread Alexey Kardashevskiy
At the moment object_get_canonical_path() crashes if the object or one of its parents does not have a parent, for example, a KVM accelerator object. This adds a check for obj!=NULL in a loop to prevent the crash. In order not to return a wrong path, this checks for currently resolved partial path

[Qemu-devel] [PATCH qemu v3 2/2] memory/hmp: Print owners/parents in "info mtree"

2018-05-30 Thread Alexey Kardashevskiy
This adds owners/parents (which are the same, just occasionally owner==NULL) printing for memory regions; a new '-o' flag enabled new output. Signed-off-by: Alexey Kardashevskiy --- Changes: v3: * removed QOM's "id" property as there are no objects left which would have this property and own an M

[Qemu-devel] [PATCH qemu v3 0/2] memory/hmp: Print owners/parents in "info mtree"

2018-05-30 Thread Alexey Kardashevskiy
This is a debug extension to "into mtree" to print a memory region owner/parent. This is based on sha1 e609fa7 Peter Maydell "Merge remote-tracking branch 'remotes/edgar/tags/edgar/xilinx-next-2018-05-29-v1.for-upstream' into staging". Please comment. Thanks. Alexey Kardashevskiy (2): objec

Re: [Qemu-devel] [PATCH] qga: add mountpoint usage to GuestFilesystemInfo

2018-05-30 Thread Chen Hanxiao
At 2018-05-30 11:19:27, "Eric Blake" wrote: >On 05/29/2018 10:01 PM, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> This patch adds support for getting the usage of mounted >> filesystem. >> It's very useful when we try to monitor guest's filesystem. >> Use df of coreutils for reference. >>

Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw: define loadparm length

2018-05-30 Thread Cornelia Huck
On Tue, 29 May 2018 00:40:09 -0400 Collin Walling wrote: > Loadparm is defined by the s390 architecture to be 8 bytes > in length. Let's define this size in the s390-ccw bios. > > Suggested-by: Laszlo Ersek > Signed-off-by: Collin Walling > --- > pc-bios/s390-ccw/iplb.h | 4 +++- > pc-bios/s3

Re: [Qemu-devel] [PATCH] vfio/pci: Default display option to "off"

2018-05-30 Thread Erik Skultety
On Tue, May 29, 2018 at 09:24:08AM -0600, Alex Williamson wrote: > [Cc +Erik,libvirt] > > Sorry, should have cc'd libvirt with this initially since display > support is under development. I think "off" is the better > compatibility option, but perhaps the damage is done since it was the > 2.12 def

[Qemu-devel] [PATCH 0/4] aspeed: add MMIO exec support to the FMC controller

2018-05-30 Thread Cédric Le Goater
Hello, When MMIO execution support is active, these changes let the Aspeed SoC machine boot directly from CE0. As there is still some issues, the feature is disabled by default and should be activated with : -global driver=aspeed.smc,property=mmio-exec,value=true Thanks, C. Cédric Le G

[Qemu-devel] [PATCH 2/4] aspeed/smc: rename aspeed_smc_flash_send_addr() to aspeed_smc_flash_setup()

2018-05-30 Thread Cédric Le Goater
Also handle the fake transfers for dummy bytes in this setup routine. It will be useful when we activate MMIO execution. Signed-off-by: Cédric Le Goater --- hw/ssi/aspeed_smc.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/hw/ssi/aspeed_smc

[Qemu-devel] [PATCH 3/4] aspeed/smc: add a new memory region dedicated to MMIO execution

2018-05-30 Thread Cédric Le Goater
The Aspeed SoC are generally booted from one of the flash modules behind the FMC controller. The FMC CS0 flash module is mapped at a specific address depending on the SoC revision and also at 0x0, the default boot-up address. To support this second mapping, we add a new 'ROM' like memory region un

[Qemu-devel] [PATCH 1/4] aspeed/smc: fix HW strapping

2018-05-30 Thread Cédric Le Goater
Only the flash type is strapped by HW. The 4BYTE mode is set by firmware when the flash device is detected. Signed-off-by: Cédric Le Goater --- hw/ssi/aspeed_smc.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index 5059396bc

[Qemu-devel] [PATCH 4/4] hw/arm/aspeed: boot from the FMC CE0 flash module

2018-05-30 Thread Cédric Le Goater
When MMIO execution is activated on the FMC controller, remove the copy of the flash module contents in a ROM memory region and boot directly from CE0. Booting from an alternate module (FMC CE1) should be possible. There is still some work to support the module swap when the watchdog resets the sy

Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw: define loadparm length

2018-05-30 Thread Thomas Huth
On 30.05.2018 09:47, Cornelia Huck wrote: > On Tue, 29 May 2018 00:40:09 -0400 > Collin Walling wrote: > >> Loadparm is defined by the s390 architecture to be 8 bytes >> in length. Let's define this size in the s390-ccw bios. >> >> Suggested-by: Laszlo Ersek >> Signed-off-by: Collin Walling >>

Re: [Qemu-devel] [RFC] monitor: turn on Out-Of-Band by default again

2018-05-30 Thread Peter Xu
On Tue, May 22, 2018 at 02:40:26PM -0400, John Snow wrote: > > > On 05/21/2018 10:13 AM, Eric Blake wrote: > > On 05/21/2018 03:42 AM, Peter Xu wrote: > >> We turned Out-Of-Band feature of monitors off for 2.12 release.  Now we > >> try to turn that on again. > > > > "try to turn" sounds weak, l

[Qemu-devel] [Bug 1774149] [NEW] qemu-user x86_64 x86 gdb call function from gdb doesn't work

2018-05-30 Thread mou
Public bug reported: While running qemu user x86_64 x86 with gdb server, calling functions are not working. Here is how to reproduce it: run in a terminal: $ qemu-x86_64 -g 12345 -L / /bin/ls In another terminal run gdb: (gdb) file /bin/ls (gdb) target remote :12345 (gdb) b _init (gdb) c (gdb)

[Qemu-devel] [PATCH v2] qga: add mountpoint usage to GuestFilesystemInfo

2018-05-30 Thread Chen Hanxiao
From: Chen Hanxiao This patch adds support for getting the usage of mounted filesystem. It's very useful when we try to monitor guest's filesystem. Cc: Michael Roth Signed-off-by: Chen Hanxiao --- v2: add description in qapi-schema and version numbers qga/commands-posix.c | 17 +++

Re: [Qemu-devel] qemu:handle_cpu_signal received signal outside vCPU context

2018-05-30 Thread Andreas Schwab
On Mär 19 2018, Michael Clark wrote: > On Mon, Mar 19, 2018 at 9:17 AM, Andreas Schwab wrote: > >> I'm seeing this error while building gedit for riscv64 with linux-user >> emulation: >> >> $ LD_LIBRARY_PATH=gedit/.libs qemu-riscv64 gedit/.libs/gedit >> --introspect-dump=/tmp/tmp-introspectnj0xl

Re: [Qemu-devel] [PATCH v3] ARM: ACPI: Fix use-after-free due to memory realloc

2018-05-30 Thread Auger Eric
Hi Shannon, On 05/30/2018 09:05 AM, Shannon Zhao wrote: > acpi_data_push uses g_array_set_size to resize the memory size. If there > is no enough contiguous memory, the address will be changed. So previous > pointer could not be used any more. It must update the pointer and use > the new one. > >

Re: [Qemu-devel] [PATCH] socket: dont't free msgfds if error equals EAGAIN

2018-05-30 Thread Gonglei (Arei)
> -Original Message- > From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Wednesday, May 30, 2018 3:33 AM > To: linzhecheng ; Marc-André Lureau > > Cc: QEMU ; Paolo Bonzini ; > wangxin (U) ; Gonglei (Arei) > ; pet...@redhat.com; berra...@redhat.com > Subject: Re: [Qemu-devel] [PATCH] so

Re: [Qemu-devel] [PATCH v7 4/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-05-30 Thread Wei Wang
On 05/29/2018 11:24 PM, Michael S. Tsirkin wrote: On Tue, Apr 24, 2018 at 02:13:47PM +0800, Wei Wang wrote: +/* + * Balloon will report pages which were free at the time of this call. As the + * reporting happens asynchronously, dirty bit logging must be enabled before + * this call is made. + *

[Qemu-devel] [PATCH 2/3] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-05-30 Thread Thomas Huth
Since it is quite cumbersome to manually create a combined kernel with initrd image for network booting, we now support loading via pxelinux configuration files, too. In these files, the kernel, initrd and command line parameters can be specified seperately, and the firmware then takes care of glue

[Qemu-devel] [PATCH 1/3] pc-bios/s390-ccw/net: Update code for the latest changes in SLOF

2018-05-30 Thread Thomas Huth
The ip_version information now has to be stored in the filename_ip_t structure, and there is now a common function called tftp_get_error_info() which can be used to get the error string for a TFTP error code. We can also get rid of some superfluous "(char *)" casts now. Signed-off-by: Thomas Huth

[Qemu-devel] [PATCH 0/3] pc-bios/s390-ccw: Allow network booting via pxelinux.cfg

2018-05-30 Thread Thomas Huth
This patch series adds pxelinux.cfg-style network booting to the s390-ccw firmware. The core pxelinux.cfg loading and parsing logic has recently been merged to SLOF, so these patches now just have to make sure to call the right functions to get the config file loaded and parsed. Once this is done,

[Qemu-devel] [PATCH 3/3] pc-bios/s390-ccw/net: Try to load pxelinux.cfg file accoring to the UUID

2018-05-30 Thread Thomas Huth
With the STSI instruction, we can get the UUID of the current VM instance, so we can support loading pxelinux config files via UUID in the file name, too. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/netmain.c | 46 +- 1 file changed, 45 insertions(

Re: [Qemu-devel] [PATCH v4 09/21] target: Do not include "exec/exec-all.h" if it is not necessary

2018-05-30 Thread Paolo Bonzini
On 30/05/2018 07:50, Philippe Mathieu-Daudé wrote: >>> No, not all :/ >>> I started with "(cpu_loop_|tlb_|tb_)" then kept brutebuilding until no >>> more errors appear. In 2 more steps I added "cpu_address_space_init|" >>> then "|GETPC|singlestep|TranslationBlock". Quick and dirty enough for my >>>

[Qemu-devel] [PATCH v4 00/12] Enable postcopy RDMA live migration

2018-05-30 Thread Lidong Chen
The RDMA QIOChannel does not support bi-directional communication, so when RDMA live migration with postcopy enabled, the source qemu return path get qemu file error. These patches implement bi-directional communication for RDMA QIOChannel and disable the RDMA WRITE during the postcopy phase.

[Qemu-devel] [PATCH v4 02/12] migration: create a dedicated connection for rdma return path

2018-05-30 Thread Lidong Chen
From: Lidong Chen If start a RDMA migration with postcopy enabled, the source qemu establish a dedicated connection for return path. Signed-off-by: Lidong Chen Reviewed-by: Dr. David Alan Gilbert --- migration/rdma.c | 94 ++-- 1 file change

[Qemu-devel] [PATCH v4 01/12] migration: disable RDMA WRITE after postcopy started

2018-05-30 Thread Lidong Chen
From: Lidong Chen RDMA WRITE operations are performed with no notification to the destination qemu, then the destination qemu can not wakeup. This patch disable RDMA WRITE after postcopy started. Signed-off-by: Lidong Chen Reviewed-by: Dr. David Alan Gilbert --- migration/qemu-file.c | 8 +++

[Qemu-devel] [PATCH v4 09/12] migration: invoke qio_channel_yield only when qemu_in_coroutine()

2018-05-30 Thread Lidong Chen
From: Lidong Chen when qio_channel_read return QIO_CHANNEL_ERR_BLOCK, the source qemu crash. The backtrace is: (gdb) bt #0 0x7fb20aba91d7 in raise () from /lib64/libc.so.6 #1 0x7fb20abaa8c8 in abort () from /lib64/libc.so.6 #2 0x7fb20aba2146 in __assert_fail_base (

[Qemu-devel] [PATCH v4 03/12] migration: remove unnecessary variables len in QIOChannelRDMA

2018-05-30 Thread Lidong Chen
From: Lidong Chen Because qio_channel_rdma_writev and qio_channel_rdma_readv maybe invoked by different threads concurrently, this patch removes unnecessary variables len in QIOChannelRDMA and use local variable instead. Signed-off-by: Lidong Chen Reviewed-by: Dr. David Alan Gilbert Reviewed-b

[Qemu-devel] [PATCH v4 08/12] migration: implement io_set_aio_fd_handler function for RDMA QIOChannel

2018-05-30 Thread Lidong Chen
From: Lidong Chen if qio_channel_rdma_readv return QIO_CHANNEL_ERR_BLOCK, the destination qemu crash. The backtrace is: (gdb) bt #0 0x in ?? () #1 0x008db50e in qio_channel_set_aio_fd_handler (ioc=0x38111e0, ctx=0x3726080, io_read=0x8db841 , io_write=0x

[Qemu-devel] [PATCH v4 04/12] migration: avoid concurrent invoke channel_close by different threads

2018-05-30 Thread Lidong Chen
From: Lidong Chen The channel_close maybe invoked by different threads. For example, source qemu invokes qemu_fclose in main thread, migration thread and return path thread. Destination qemu invokes qemu_fclose in main thread, listen thread and COLO incoming thread. Add a mutex in QEMUFile struc

[Qemu-devel] [PATCH v4 06/12] migration: Stop rdma yielding during incoming postcopy

2018-05-30 Thread Lidong Chen
From: Lidong Chen During incoming postcopy, the destination qemu will invoke qemu_rdma_wait_comp_channel in a seprate thread. So does not use rdma yield, and poll the completion channel fd instead. Signed-off-by: Lidong Chen Reviewed-by: Dr. David Alan Gilbert --- migration/rdma.c | 4 +++- 1

[Qemu-devel] [PATCH v4 05/12] migration: implement bi-directional RDMA QIOChannel

2018-05-30 Thread Lidong Chen
From: Lidong Chen This patch implements bi-directional RDMA QIOChannel. Because different threads may access RDMAQIOChannel currently, this patch use RCU to protect it. Signed-off-by: Lidong Chen --- migration/colo.c | 2 + migration/migration.c| 2 + migration/postcopy-ram.c |

[Qemu-devel] [PATCH v4 12/12] migration: implement the shutdown for RDMA QIOChannel

2018-05-30 Thread Lidong Chen
Because RDMA QIOChannel not implement shutdown function, If the to_dst_file was set error, the return path thread will wait forever. and the migration thread will wait return path thread exit. the backtrace of return path thread is: (gdb) bt #0 0x7f372a76bb0f in ppoll () from /lib64/libc

[Qemu-devel] [PATCH v4 07/12] migration: not wait RDMA_CM_EVENT_DISCONNECTED event after rdma_disconnect

2018-05-30 Thread Lidong Chen
From: Lidong Chen When cancel migration during RDMA precopy, the source qemu main thread hangs sometime. The backtrace is: (gdb) bt #0 0x7f249eabd43d in write () from /lib64/libpthread.so.0 #1 0x7f24a1ce98e4 in rdma_get_cm_event (channel=0x4675d10, event=0x7ffe2f643dd0) a

[Qemu-devel] [PATCH v4 10/12] migration: create a dedicated thread to release rdma resource

2018-05-30 Thread Lidong Chen
ibv_dereg_mr wait for a long time for big memory size virtual server. The test result is: 10GB 326ms 20GB 699ms 30GB 1021ms 40GB 1387ms 50GB 1712ms 60GB 2034ms 70GB 2457ms 80GB 2807ms 90GB 3107ms 100GB 3474ms 110GB 3735ms 120GB 4064ms 130GB 4567ms 140GB 4886ms

[Qemu-devel] [PATCH v4 11/12] migration: poll the cm event while wait RDMA work request completion

2018-05-30 Thread Lidong Chen
If the peer qemu is crashed, the qemu_rdma_wait_comp_channel function maybe loop forever. so we should also poll the cm event fd, and when receive any cm event, we consider some error happened. Signed-off-by: Lidong Chen --- migration/rdma.c | 35 --- 1 file chang

Re: [Qemu-devel] [PATCH v2 03/16] job: Add error message for failing jobs

2018-05-30 Thread Max Reitz
On 2018-05-29 22:38, Kevin Wolf wrote: > So far we relied on job->ret and strerror() to produce an error message > for failed jobs. Not surprisingly, this tends to result in completely > useless messages. > > This adds a Job.error field that can contain an error string for a > failing job, and a p

Re: [Qemu-devel] [PATCH v2 06/16] qemu-iotests: Add VM.qmp_log()

2018-05-30 Thread Max Reitz
On 2018-05-29 22:39, Kevin Wolf wrote: > This adds a helper function that logs both the QMP request and the > received response before returning it. > > Signed-off-by: Kevin Wolf > Reviewed-by: Jeff Cody > --- > tests/qemu-iotests/iotests.py | 11 +++ > 1 file changed, 11 insertions(+)

Re: [Qemu-devel] [PATCH v2 07/16] qemu-iotests: Add iotests.img_info_log()

2018-05-30 Thread Max Reitz
On 2018-05-29 22:39, Kevin Wolf wrote: > This adds a filter function to postprocess 'qemu-img info' input > (similar to what _img_info does), and an img_info_log() function that > calls 'qemu-img info' and logs the filtered output. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/iotests

Re: [Qemu-devel] [PATCH v2 08/16] qemu-iotests: Add VM.run_job()

2018-05-30 Thread Max Reitz
On 2018-05-29 22:39, Kevin Wolf wrote: > Add an iotests.py function that runs a job and only returns when it is > destroyed. An error is logged when the job failed and job-finalize and > job-dismiss commands are issued if necessary. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/iotest

Re: [Qemu-devel] [PATCH v2 09/16] qemu-iotests: iotests.py helper for non-file protocols

2018-05-30 Thread Max Reitz
On 2018-05-29 22:39, Kevin Wolf wrote: > This adds two helper functions that are useful for test cases that make > use of a non-file protocol (specifically ssh). > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/iotests.py | 17 + > 1 file changed, 17 insertions(+) Review

[Qemu-devel] [PATCH v2] pnv: add a physical mapping array describing MMIO ranges in each chip

2018-05-30 Thread Cédric Le Goater
Based on previous work done in skiboot, the physical mapping array helps in calculating the MMIO ranges of each controller depending on the chip id and the chip type. This is will be particularly useful for the P9 models which use less the XSCOM bus and rely more on MMIOs. A link on the chip is no

Re: [Qemu-devel] [PATCH v2 10/16] qemu-iotests: Rewrite 206 for blockdev-create job

2018-05-30 Thread Max Reitz
On 2018-05-29 22:39, Kevin Wolf wrote: > This rewrites the test case 206 to work with the new x-blockdev-create > job rather than the old synchronous version of the command. > > All of the test cases stay the same as before, but in order to be able > to implement proper job handling, the test case

Re: [Qemu-devel] [PATCH 2/5] hw/i386: Rename 2.13 machine types to 3.0

2018-05-30 Thread Igor Mammedov
On Tue, 22 May 2018 11:39:57 +0100 Peter Maydell wrote: > Rename the 2.13 machine types to match what we're going to > use as our next release number. > > Signed-off-by: Peter Maydell > --- [...] q35 hunk of this patch for no apparent reasons causes change of the NVDIMM's DSM page allocated by

Re: [Qemu-devel] [PATCH v4 09/21] target: Do not include "exec/exec-all.h" if it is not necessary

2018-05-30 Thread Cornelia Huck
On Mon, 28 May 2018 20:27:07 -0300 Philippe Mathieu-Daudé wrote: > Code change produced with: > $ git grep '#include "exec/exec-all.h"' | \ > cut -d: -f-1 | \ > xargs egrep -L > "(cpu_address_space_init|cpu_loop_|tlb_|tb_|GETPC|singlestep|TranslationBlock)" > | \ > xargs s

Re: [Qemu-devel] [PATCH v2] monitor: report entirety of hmp command on error

2018-05-30 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > David, looks like your turf. Yep, I've got it on my list to take. Dave > Collin Walling writes: > > > When a user incorrectly provides an hmp command, an error response will be > > printed that prompts the user to try "help ". However, when > >

Re: [Qemu-devel] [PATCH v2 11/16] qemu-iotests: Rewrite 207 for blockdev-create job

2018-05-30 Thread Max Reitz
On 2018-05-29 22:39, Kevin Wolf wrote: > This rewrites the test case 207 to work with the new x-blockdev-create > job rather than the old synchronous version of the command. > > Most of the test cases stay the same as before (the exception being some > improved 'size' options that allow distinguis

Re: [Qemu-devel] [PATCH 2/5] hw/i386: Rename 2.13 machine types to 3.0

2018-05-30 Thread Paolo Bonzini
On 30/05/2018 12:11, Igor Mammedov wrote: > -Name (MEMA, 0x07FFE000) > +Name (MEMA, 0x07FFF000) > } > > As far as I see it should safe wrt NVDIMMs, > but the question is what in this commit forced Seabios > to change allocated address? Probably 2.13 is longer than 3.0 or something like t

Re: [Qemu-devel] [PATCH v2] pnv: add a physical mapping array describing MMIO ranges in each chip

2018-05-30 Thread Greg Kurz
On Wed, 30 May 2018 12:07:54 +0200 Cédric Le Goater wrote: > Based on previous work done in skiboot, the physical mapping array > helps in calculating the MMIO ranges of each controller depending on > the chip id and the chip type. This is will be particularly useful for > the P9 models which use

Re: [Qemu-devel] [PATCH qemu v2 1/2] memory/hmp: Print owners/parents in "info mtree"

2018-05-30 Thread Paolo Bonzini
On 30/05/2018 06:57, Alexey Kardashevskiy wrote: > hw/intc/apic_common.c|489| object_property_add(obj, "id", "uint32", > hw/ppc/spapr_drc.c|557| object_property_add_uint32_ptr(obj, "id", &drc->id, > NULL); > > This does not look like "remove the "id" property altogether" :) Does this > mean we sti

[Qemu-devel] "socket" host network backend: suggested improvements and fixes

2018-05-30 Thread Artem Pisarenko
Hi to all. I'm working on integrating QEMU networking to simulation environment and found socket backend very convenient: it's simple, easy to use (i.e no intermediate things required, such as tap/tun adapter, vde switch, etc.) and transparent to host environment (i.e. it doesn't pollutes system w

Re: [Qemu-devel] [PATCH v7 00/11] enable numa configuration before machine_init() from QMP

2018-05-30 Thread Igor Mammedov
Eduardo, I've rebased series on top of current master the only change in several patches was s/2.13/3.0/ otherwise there weren't any other conflicts. You can find rebased version at https://github.com/imammedo/qemu.git qmp_preconfig_v9

Re: [Qemu-devel] [PATCH 2/5] hw/i386: Rename 2.13 machine types to 3.0

2018-05-30 Thread Igor Mammedov
On Wed, 30 May 2018 12:19:59 +0200 Paolo Bonzini wrote: > On 30/05/2018 12:11, Igor Mammedov wrote: > > -Name (MEMA, 0x07FFE000) > > +Name (MEMA, 0x07FFF000) > > } Michael, could you update ACPI test blobs in your next pull request please? > > As far as I see it should safe wrt NVDIMMs

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-30 Thread Eduardo Otubo
On 29/05/2018 - 18:05:25, Yi Min Zhao wrote: > > > 在 2018/5/29 下午5:37, Paolo Bonzini 写道: > > On 29/05/2018 09:31, Yi Min Zhao wrote: > > > If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains > > > compiled. This would make libvirt set the corresponding capability and > > > then

[Qemu-devel] [PATCH v1 4/8] docker: update Travis docker image

2018-05-30 Thread Alex Bennée
This is still poorly documented by Travis but according to: https://docs.travis-ci.com/user/common-build-problems/#Running-a-Container-Based-Docker-Image-Locally their reference images are now hosted on Docker Hub. So we update the FROM line to refer to the new default image. We also need a fe

[Qemu-devel] [PATCH v1 7/8] .travis.yml: update GCC sanitizer build to GCC 7

2018-05-30 Thread Alex Bennée
GCC has moved on and so should we. We also enable apt update to ensure we get the latest build from the toolchain PPA. Signed-off-by: Alex Bennée --- .travis.yml | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index e99af6f357..ecc4367036 10

[Qemu-devel] [PATCH v1 1/8] .travis.yml: disable linux-user build for gcov

2018-05-30 Thread Alex Bennée
Currently the default testing doesn't exercise the linux-user builds so there is no point spending time building them. We may want to enable a separate gcov build once linux-user testing is re-enabled although it's likely to report very low coverage. Signed-off-by: Alex Bennée --- .travis.yml |

[Qemu-devel] [PATCH v1 0/8] Travis stability and a few docker patches

2018-05-30 Thread Alex Bennée
Hi, Again the final patch won't make it into a pull-request but I'm just keeping it around to keep track of failures. So far my numerous re-builds have been mainly plain timeouts. The alternate co-routine builds are sailing the closest to timeout purgatory which makes me think we should limit the

[Qemu-devel] [PATCH v1 3/8] docker: do not display deprecated images in 'make docker' help

2018-05-30 Thread Alex Bennée
From: Philippe Mathieu-Daudé the 'debian' base image is deprecated since 3e11974988d8 Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/docker/Makefile.include b/tes

[Qemu-devel] [PATCH v1 5/8] .travis.yml: rationalise clang testing

2018-05-30 Thread Alex Bennée
As Travis includes Clang 5.0 in its own build environment there is no point manually building with older Clangs. We still need to test with the two pythons though so we leave them as system only builds. We also split the clang build into two as it often exceeds the 40 minute build time limit. Sign

[Qemu-devel] [PATCH v1 8/8] tests/Makefile: mark flakey tests (!UPSTREAM)

2018-05-30 Thread Alex Bennée
This is a bookmarking commit to keep track of the failures I'm currently seeing in Travis. They are currently: 1. test-aio GTESTER tests/test-thread-pool ** ERROR:tests/test-aio.c:501:test_timer_schedule: assertion failed: (aio_poll(ctx, true)) GTester: last random seed: R02S66126aca97f9606b33e5

[Qemu-devel] [PATCH v1 2/8] docker: sort images list displayed by 'make docker'

2018-05-30 Thread Alex Bennée
From: Philippe Mathieu-Daudé we can now directly see different version sort consecutively. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/Makefile.include b/tes

Re: [Qemu-devel] [PATCH 2/3] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-05-30 Thread Viktor VM Mihajlovski
On 30.05.2018 11:16, Thomas Huth wrote: > Since it is quite cumbersome to manually create a combined kernel with > initrd image for network booting, we now support loading via pxelinux > configuration files, too. In these files, the kernel, initrd and command > line parameters can be specified sepe

[Qemu-devel] [PATCH v1 6/8] .travis.yml: make current setup explicit

2018-05-30 Thread Alex Bennée
Add some commentary and make the selection of Container based Trusty build explicit. We will need to add VM builds later when using docker. Signed-off-by: Alex Bennée --- .travis.yml | 4 1 file changed, 4 insertions(+) diff --git a/.travis.yml b/.travis.yml index 85ee2a1edb..e99af6f357 10

[Qemu-devel] [PATCH] migration/block-dirty-bitmap: fix dirty_bitmap_load

2018-05-30 Thread Vladimir Sementsov-Ogievskiy
dirty_bitmap_load_header return code is obtained but not handled. Fix this. Bug was introduced in b35ebdf076d697bc "migration: add postcopy migration of dirty bitmaps" with the whole function. Signed-off-by: Vladimir Sementsov-Ogievskiy --- migration/block-dirty-bitmap.c | 3 +++ 1 file changed

[Qemu-devel] [RFC v3 0/8] KVM/ARM: Relax the max 123 vcpus limitation along with KVM GICv3

2018-05-30 Thread Eric Auger
Currently the max number of VCPUs usable along with the KVM GICv3 device is limited to 123. The rationale is a single redistributor region was supported and this latter was set to [0x80A, 0x900] within the guest physical address space, surrounded with DIST and UART MMIO regions. [1] now al

[Qemu-devel] [RFC v3 6/8] hw/arm/virt-acpi-build: Advertise one or two GICR structures

2018-05-30 Thread Eric Auger
Depending on the number of smp_cpus we now register one or two GICR structures. Signed-off-by: Eric Auger --- hw/arm/virt-acpi-build.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 92ceee9..6a4340a 100644 --- a/hw/arm/virt-

[Qemu-devel] [RFC v3 1/8] linux-headers: Partial update for KVM/ARM multiple redistributor region registration

2018-05-30 Thread Eric Auger
This updates KVM/ARM headers against https://github.com/eauger/linux/tree/v4.17-rc2-rdist-regions-v6 Signed-off-by: Eric Auger --- linux-headers/asm-arm/kvm.h | 1 + linux-headers/asm-arm64/kvm.h | 1 + 2 files changed, 2 insertions(+) diff --git a/linux-headers/asm-arm/kvm.h b/linux-headers/

[Qemu-devel] [RFC v3 4/8] hw/intc/arm_gicv3_kvm: Get prepared to handle multiple redist regions

2018-05-30 Thread Eric Auger
Let's check if KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION is supported. If not, we check the number of redist region is equal to 1 and use the legacy KVM_VGIC_V3_ADDR_TYPE_REDIST attribute. Otherwise we use the new attribute and allow to register multiple regions to the KVM device. Signed-off-by: Eric Au

[Qemu-devel] [Bug 1396052] Re: migration failed when running BurnInTest in guest

2018-05-30 Thread z08687
Thanks for your reply. I didn't start dest vm. The vm just in pause state and crash. static void process_incoming_migration_co(void *opaque) { -- ret = qemu_loadvm_state(mis->from_src_file); -- return when recieve "QEMU_VM_EOF" -- mis->bh = qemu_bh_new(p

[Qemu-devel] [RFC v3 7/8] hw/arm/virt: Register two redistributor regions when necessary

2018-05-30 Thread Eric Auger
With a VGICv3 KVM device, if the number of vcpus exceeds the capacity of the legacy redistributor region (123 redistributors), we now attempt to register a second redistributor region. Up to 512 redistributors can fit in this latter on top of the 123 allowed by the legacy redistributor region. Reg

[Qemu-devel] [RFC v3 2/8] target/arm: Allow KVM device address overwriting

2018-05-30 Thread Eric Auger
for KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION attribute, the attribute data pointed to by kvm_device_attr.addr is a OR of the redistributor region address and other fields such as the index of the redistributor region and the number of redistributors the region can contain. The existing machine init don

[Qemu-devel] [RFC v3 3/8] hw/intc/arm_gicv3: Introduce redist-region-count array property

2018-05-30 Thread Eric Auger
To prepare for multiple redistributor regions, we introduce an array of uint32_t properties that stores the redistributor count of each redistributor region. Non accelerated VGICv3 only supports a single redistributor region. The capacity of all redist regions is checked against the number of vcpu

[Qemu-devel] [RFC v3 5/8] hw/arm/virt: GICv3 DT node with one or two redistributor regions

2018-05-30 Thread Eric Auger
This patch allows the creation of a GICv3 node with 1 or 2 redistributor regions depending on the number of smu_cpus. The second redistributor region is located just after the existing RAM region, at 256GB and contains up to up to 512 vcpus. Please refer to kernel documentation for further node de

[Qemu-devel] [RFC v3 8/8] hw/arm/virt: Add virt-3.0 machine type supporting up to 512 vcpus

2018-05-30 Thread Eric Auger
Add virt-3.0 machine type. This machine type allows up to 512 vcpus whereas for earlier machine types, max_cpus was set to 255 and any attempt to start the machine with vcpus > 255 was rejected at vl.c/main level. Signed-off-by: Eric Auger --- hw/arm/virt.c | 32 +---

Re: [Qemu-devel] [PATCH 01/17] block: iterate_format with account of whitelisting

2018-05-30 Thread Max Reitz
On 2018-04-26 18:19, Roman Kagan wrote: > bdrv_iterate_format (which is currently only used for printing out the > formats supported by the block layer) doesn't take format whitelisting > into account. > > As a result, QEMU lies when asked for the list of block drivers it > supports with "-drive f

Re: [Qemu-devel] [PATCH 02/17] iotests: iotests.py: prevent deadlock in subprocess

2018-05-30 Thread Max Reitz
On 2018-04-26 18:19, Roman Kagan wrote: > A subprocess whose std{out,err} is subprocess.PIPE may block writing its > output, so .wait() should not be called on it until the pipes are read > completely on the caller's side. > > Subprocess.communicate takes care of this. > > Signed-off-by: Roman Ka

Re: [Qemu-devel] [RFC] monitor: turn on Out-Of-Band by default again

2018-05-30 Thread Peter Xu
On Wed, May 30, 2018 at 04:04:58PM +0800, Peter Xu wrote: > On Tue, May 22, 2018 at 02:40:26PM -0400, John Snow wrote: > > > > > > On 05/21/2018 10:13 AM, Eric Blake wrote: > > > On 05/21/2018 03:42 AM, Peter Xu wrote: > > >> We turned Out-Of-Band feature of monitors off for 2.12 release.  Now we

Re: [Qemu-devel] [PATCH 10/13] 9p: darwin: *xattr_nofollow implementations

2018-05-30 Thread Greg Kurz
On Sat, 26 May 2018 01:23:12 -0400 k...@juliacomputing.com wrote: > From: Keno Fischer > > Signed-off-by: Keno Fischer > --- As mentioned in patch 3, this should go to 9p-util-darwin.c > hw/9pfs/9p-util.c | 49 + > 1 file changed, 45 insertions

Re: [Qemu-devel] [RFC v3 5/8] hw/arm/virt: GICv3 DT node with one or two redistributor regions

2018-05-30 Thread Igor Mammedov
On Wed, 30 May 2018 13:45:38 +0200 Eric Auger wrote: > This patch allows the creation of a GICv3 node with 1 or 2 > redistributor regions depending on the number of smu_cpus. > The second redistributor region is located just after the > existing RAM region, at 256GB and contains up to up to 512 v

Re: [Qemu-devel] [PATCH 12/13] 9p: darwin: Provide a fallback implementation for utimensat

2018-05-30 Thread Greg Kurz
On Sat, 26 May 2018 01:23:14 -0400 k...@juliacomputing.com wrote: > From: Keno Fischer > > This function is new in Mac OS 10.13. Provide a fallback implementation > when building against older SDKs. > > Signed-off-by: Keno Fischer > --- As with patch 10, this should go to 9p-util-darwin.c >

Re: [Qemu-devel] [PATCH 03/17] iotests: ask qemu for supported formats

2018-05-30 Thread Max Reitz
On 2018-04-26 18:19, Roman Kagan wrote: > Add helper functions to query the block drivers actually supported by > QEMU using "-drive format=?". This allows to skip certain tests that > require drivers not built in or whitelisted in QEMU. > > Signed-off-by: Roman Kagan > --- > tests/qemu-iotests

[Qemu-devel] [qemu-web PATCH] Add a blog post about the new -nic parameter

2018-05-30 Thread Thomas Huth
QEMU v2.12 features a new, useful parameter called "-nic". Let's throw some light on this new parameter with a new blog post. Signed-off-by: Thomas Huth --- _posts/2018-05-30-nic-parameter.md | 126 + screenshots/2018-05-30-qemu-cli-net.png| Bin 0 -> 24020

Re: [Qemu-devel] [PATCH 04/17] iotest 030: skip quorum test setup/teardown too

2018-05-30 Thread Max Reitz
On 2018-04-26 18:19, Roman Kagan wrote: > If quorum driver is not enabled, test 030 skips the corresponding > testcase. This, however, is insufficient: quorum is first used in the > testsuite's setUp. > > To avoid erroring out here, skip setUp/tearDown, too. > > Signed-off-by: Roman Kagan > ---

Re: [Qemu-devel] [PATCH 05/17] iotest 030: require blkdebug

2018-05-30 Thread Max Reitz
On 2018-04-26 18:19, Roman Kagan wrote: > This test uses blkdebug extensively so notrun it if blkdebug is > disabled in QEMU. > > Signed-off-by: Roman Kagan > --- > tests/qemu-iotests/030 | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digit

Re: [Qemu-devel] [PATCH 11/13] 9p: darwin: Mark mknod as unsupported

2018-05-30 Thread Greg Kurz
On Sat, 26 May 2018 01:23:13 -0400 k...@juliacomputing.com wrote: > From: Keno Fischer > > Signed-off-by: Keno Fischer > --- > hw/9pfs/9p-local.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c > index c55ea25..3e358b7 100644 > --- a/h

Re: [Qemu-devel] [PATCH 06/17] iotest 055: skip unsupported backup target formats

2018-05-30 Thread Max Reitz
On 2018-04-26 18:19, Roman Kagan wrote: > Signed-off-by: Roman Kagan > --- > tests/qemu-iotests/055 | 12 > 1 file changed, 12 insertions(+) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH 07/17] iotest 055: require blkdebug

2018-05-30 Thread Max Reitz
On 2018-04-26 18:19, Roman Kagan wrote: > This test uses blkdebug extensively so notrun it if blkdebug is > disabled in QEMU. > > Signed-off-by: Roman Kagan > --- > tests/qemu-iotests/055 | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digit

Re: [Qemu-devel] [RFC v3 5/8] hw/arm/virt: GICv3 DT node with one or two redistributor regions

2018-05-30 Thread Auger Eric
Hi Igor, On 05/30/2018 02:13 PM, Igor Mammedov wrote: > On Wed, 30 May 2018 13:45:38 +0200 > Eric Auger wrote: > >> This patch allows the creation of a GICv3 node with 1 or 2 >> redistributor regions depending on the number of smu_cpus. >> The second redistributor region is located just after th

Re: [Qemu-devel] [PATCH v4 07/12] migration: not wait RDMA_CM_EVENT_DISCONNECTED event after rdma_disconnect

2018-05-30 Thread Dr. David Alan Gilbert
* Lidong Chen (jemmy858...@gmail.com) wrote: > From: Lidong Chen > > When cancel migration during RDMA precopy, the source qemu main thread hangs > sometime. > > The backtrace is: > (gdb) bt > #0 0x7f249eabd43d in write () from /lib64/libpthread.so.0 > #1 0x7f24a1ce98e4 in

Re: [Qemu-devel] [PATCH 08/17] iotest 056: skip testcases using blkdebug if disabled

2018-05-30 Thread Max Reitz
On 2018-04-26 18:19, Roman Kagan wrote: > Signed-off-by: Roman Kagan > --- > tests/qemu-iotests/056 | 3 +++ > 1 file changed, 3 insertions(+) TestBeforeWriteNotifier uses blkdebug (and null-co) in its setUp function. Maybe you just want to skip the whole test if blkdebug is disabled. Then aga

Re: [Qemu-devel] [PATCH 00/17] iotests: don't choke on disabled drivers

2018-05-30 Thread Max Reitz
On 2018-04-26 18:19, Roman Kagan wrote: > Some iotests assume availability of certain block drivers, and fail if > the driver is not supported by QEMU because it was disabled at configure > time. > > This series tries to address that, by making QEMU report the actual list > of supported block driv

Re: [Qemu-devel] [PATCH 0/4] aspeed: add MMIO exec support to the FMC controller

2018-05-30 Thread Peter Maydell
On 30 May 2018 at 08:49, Cédric Le Goater wrote: > Hello, > > When MMIO execution support is active, these changes let the Aspeed > SoC machine boot directly from CE0. As there is still some > issues, the feature is disabled by default and should be activated > with : > > -global driver=as

Re: [Qemu-devel] [[Qemu devel] RFC] hw/net: Add Smartfusion2 emac block

2018-05-30 Thread sundeep subbaraya
Hi Philippe, On Sun, May 27, 2018 at 8:56 AM, Philippe Mathieu-Daudé wrote: > On 05/26/2018 06:53 AM, Subbaraya Sundeep wrote: >> Modelled Ethernet MAC of Smartfusion2 SoC. >> Micrel KSZ8051 PHY is present on Emcraft's SOM kit hence same >> PHY is emulated. >> >> Signed-off-by: Subbaraya Sundeep

Re: [Qemu-devel] [PATCH 0/4] aspeed: add MMIO exec support to the FMC controller

2018-05-30 Thread Cédric Le Goater
On 05/30/2018 02:40 PM, Peter Maydell wrote: > On 30 May 2018 at 08:49, Cédric Le Goater wrote: >> Hello, >> >> When MMIO execution support is active, these changes let the Aspeed >> SoC machine boot directly from CE0. As there is still some >> issues, the feature is disabled by default and should

Re: [Qemu-devel] [PATCH v7 4/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-05-30 Thread Michael S. Tsirkin
On Wed, May 30, 2018 at 05:12:09PM +0800, Wei Wang wrote: > On 05/29/2018 11:24 PM, Michael S. Tsirkin wrote: > > On Tue, Apr 24, 2018 at 02:13:47PM +0800, Wei Wang wrote: > > > +/* > > > + * Balloon will report pages which were free at the time of this call. > > > As the > > > + * reporting happe

[Qemu-devel] [PATCH] fix Segmentation fault when emulating a bluetooth device 'dev'

2018-05-30 Thread Fei Li
The current code bt_hid_send_data() did not check whether its first parameter *ch is NULL, which will cause a "Segmentation fault" when *ch is NULL as ch->remote_mtu will be directly referenced later in this function. E.g. when called by bt_hid_datain() and hid->interrupt is NULL with "qemu-system-

  1   2   3   4   >