Re: [Qemu-devel] [PATCH v2 2/2] vl: fix use of --daemonize with --preconfig

2018-06-04 Thread Michal Privoznik
On 06/04/2018 02:03 PM, Daniel P. Berrangé wrote: > When using --daemonize, the initial lead process will fork a child and > then wait to be notified that setup is complete via a pipe, before it > exits. When using --preconfig there is an extra call to main_loop() > before the notification is done

Re: [Qemu-devel] [PULL 0/2] Docker patches

2018-06-04 Thread Peter Maydell
On 4 June 2018 at 08:10, Fam Zheng wrote: > The following changes since commit 392fba9f583223786f844dce9b2e7f9a0ce0147a: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-travis-updates-010618-1' into staging (2018-06-01 > 17:32:30 +0100) > > are available in the Git repository at:

[Qemu-devel] [PATCH v1 2/7] configure: add test for docker availability

2018-06-04 Thread Alex Bennée
This tests for a working docker installation without sudo and sets up config-host.mak accordingly. This will be useful from cross compiling things in the future. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- configure | 17 + 1 file changed, 17 insertions(+) dif

[Qemu-devel] [PATCH v1 1/7] docker: add "probe" command for configure

2018-06-04 Thread Alex Bennée
This is a helper function for the configure script. It replies yes, sudo or no to inform the user if non-interactive docker support is available. We trap the Exception to fail gracefully. Signed-off-by: Alex Bennée Reviewed-by: Fam Zheng --- tests/docker/docker.py | 18 ++ 1 fil

[Qemu-devel] [PATCH v1 5/7] docker: Update fedora image to 28

2018-06-04 Thread Alex Bennée
From: Fam Zheng Signed-off-by: Fam Zheng Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/fedora.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker index b706f42405..65d7761cf5 10064

[Qemu-devel] [PATCH v1 3/7] Makefile: Rename TARGET_DIRS to TARGET_LIST

2018-06-04 Thread Alex Bennée
From: Fam Zheng To be more accurate on its purpose and make code that looks for a certain target out of this variable more readable. Signed-off-by: Fam Zheng Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée ---

[Qemu-devel] [PATCH v1 6/7] docker: test-mingw: use SDL2 and GTK+3

2018-06-04 Thread Alex Bennée
From: Paolo Bonzini Do not test the deprecated API versions. debian-win32-cross and debian-win64-cross are already using SDL2 (they do not cover GTK+ at all). Signed-off-by: Paolo Bonzini Reviewed-by: Daniel P. Berrangé [AJB: fix merge conflicts] Signed-off-by: Alex Bennée --- tests/docker

[Qemu-devel] [PATCH v1 0/7] updates for Docker

2018-06-04 Thread Alex Bennée
Hi, I was prompted on IRC so I've gathered together some of the outstanding docker related patches from the list. It also includes a few of the docker related tweaks from my mega TCG testing series whcih should hopefully bring the delta down. I plan to send the pull request in tomorrow if nothing

[Qemu-devel] [PATCH v1 4/7] docker: Add fedora-i386-cross image

2018-06-04 Thread Alex Bennée
From: Fam Zheng It has some basic *-devel.i686 packages to be used with "gcc -m32" as a 32 bit cross build environment. Signed-off-by: Fam Zheng [AJB: add glibc-static] Signed-off-by: Alex Bennée Tested-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/fedora-i386-cross.docker | 14 +++

[Qemu-devel] [PATCH v1 7/7] docker: add debian/tricore image

2018-06-04 Thread Alex Bennée
From: Philippe Mathieu-Daudé TriCore binutils is built from Bastian Koppelmann repository. Note: There is no TriCore compiler in this image (only assembler/linker). Signed-off-by: Philippe Mathieu-Daudé [AJB: base of Debian9, add to Makefile.include] Signed-off-by: Alex Bennée --- tests/dock

Re: [Qemu-devel] [PATCH v2 2/2] vl: fix use of --daemonize with --preconfig

2018-06-04 Thread Igor Mammedov
On Mon, 4 Jun 2018 16:21:48 +0200 Michal Privoznik wrote: > On 06/04/2018 02:03 PM, Daniel P. Berrangé wrote: > > When using --daemonize, the initial lead process will fork a child and > > then wait to be notified that setup is complete via a pipe, before it > > exits. When using --preconfig the

Re: [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues

2018-06-04 Thread Marc-André Lureau
Hi On Mon, Jun 4, 2018 at 10:06 AM, Peter Xu wrote: > Previously we cleanup the queues when we got CLOSED event. It was used > to make sure we won't leftover replies/events of a old client to a new > client. Now this patch postpones that until OPENED. > > In most cases, it does not really matte

Re: [Qemu-devel] [PATCH 15/27] iommu: Add IOMMU index argument to notifier APIs

2018-06-04 Thread Alex Bennée
Peter Maydell writes: > On 23 May 2018 at 10:08, Alex Bennée wrote: >> >> Peter Maydell writes: >> >>> Add support for multiple IOMMU indexes to the IOMMU notifier APIs. >>> When initializing a notifier with iommu_notifier_init(), the caller >>> must pass the IOMMU index that it is interested

[Qemu-devel] [PATCH v2 0/3] usb: fix bugs reported by Clang Static Analyzer

2018-06-04 Thread Philippe Mathieu-Daudé
Since v1 [1]: - zero-initialize c->argv[] as suggested by Gerd Hoffmann - drop 4th patch, bug already fixed in 53735bef108 [1] http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg07453.html Philippe Mathieu-Daudé (3): usb: correctly handle Zero Length Packets usb/dev-mtp: Fix use of un

[Qemu-devel] [PATCH v2 1/3] usb: correctly handle Zero Length Packets

2018-06-04 Thread Philippe Mathieu-Daudé
USB Specification Revision 2.0, §5.5.3: The Data stage of a control transfer from an endpoint to the host is complete when the endpoint does one of the following: • Has transferred exactly the amount of data specified during the Setup stage • Transfers a packet with a payload size less than

[Qemu-devel] [PATCH v2 2/3] usb/dev-mtp: Fix use of uninitialized values

2018-06-04 Thread Philippe Mathieu-Daudé
This fixes: hw/usb/dev-mtp.c:971:5: warning: 4th function call argument is an uninitialized value trace_usb_mtp_op_get_partial_object(s->dev.addr, o->handle, o->path, c->argv[1], c->argv[2]);

Re: [Qemu-devel] [PATCH v2 2/2] vl: fix use of --daemonize with --preconfig

2018-06-04 Thread Daniel P . Berrangé
On Mon, Jun 04, 2018 at 05:01:11PM +0200, Igor Mammedov wrote: > On Mon, 4 Jun 2018 16:21:48 +0200 > Michal Privoznik wrote: > > > On 06/04/2018 02:03 PM, Daniel P. Berrangé wrote: > > > When using --daemonize, the initial lead process will fork a child and > > > then wait to be notified that set

[Qemu-devel] [PATCH v2 3/3] usb/dev-mtp: Fix use of uninitialized values

2018-06-04 Thread Philippe Mathieu-Daudé
This fixes: hw/usb/dev-mtp.c:1212:13: warning: 2nd function call argument is an uninitialized value o = usb_mtp_object_lookup(s, c->argv[0]); ^~~~ Reported-by: Clang Static Analyzer Suggested-by: Gerd Hoffmann Signed-off-by: Philippe Mathieu-Dau

Re: [Qemu-devel] [PATCH for 2.10 26/35] linux-user: use is_error() to avoid warnings and make the code clearer

2018-06-04 Thread Laurent Vivier
Le 04/06/2018 à 16:20, Philippe Mathieu-Daudé a écrit : > On 06/03/2018 08:33 PM, Laurent Vivier wrote: >> Le 29/05/2018 à 17:19, Laurent Vivier a écrit : >>> Le 29/05/2018 à 16:25, Philippe Mathieu-Daudé a écrit : Hi Laurent, >>> >>> Hi Philippe, >>> On 07/24/2017 04:16 PM, Laurent Vivie

[Qemu-devel] [PULL 00/17] Linux user for 3.0 patches

2018-06-04 Thread Laurent Vivier
The following changes since commit 392fba9f583223786f844dce9b2e7f9a0ce0147a: Merge remote-tracking branch 'remotes/stsquad/tags/pull-travis-updates-010618-1' into staging (2018-06-01 17:32:30 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-fo

[Qemu-devel] [PULL 06/17] linux-user: move arm/aarch64/m68k fcntl definitions to [arm|aarch64|m68k]/target_fcntl.h

2018-06-04 Thread Laurent Vivier
No code change. Signed-off-by: Laurent Vivier Acked-by: Richard Henderson Message-Id: <20180529194207.31503-5-laur...@vivier.eu> --- linux-user/aarch64/target_fcntl.h | 5 + linux-user/arm/target_fcntl.h | 6 ++ linux-user/m68k/target_fcntl.h| 6 ++ linux-user/syscall_defs.h

[Qemu-devel] [PULL 12/17] linux-user: move sparc signal definitions to sparc/target_signal.h

2018-06-04 Thread Laurent Vivier
Remove sparc64/target_signal.h, use sparc/target_signal.h instead. Signed-off-by: Laurent Vivier Message-Id: <20180529194207.31503-11-laur...@vivier.eu> --- linux-user/sparc/target_signal.h | 48 +++ linux-user/sparc64/signal.c| 1 - linux-user/sparc64/

[Qemu-devel] [PULL 07/17] linux-user: move mips/mips64 fcntl definitions to mips/target_fcntl.h

2018-06-04 Thread Laurent Vivier
No code change. Signed-off-by: Laurent Vivier Message-Id: <20180529194207.31503-6-laur...@vivier.eu> --- linux-user/mips/target_fcntl.h | 27 +++ linux-user/syscall_defs.h | 31 ++- 2 files changed, 29 insertions(+), 29 deletions(-) diff

[Qemu-devel] [PULL 01/17] syscall: replace strcpy() by g_strlcpy()

2018-06-04 Thread Laurent Vivier
From: Philippe Mathieu-Daudé linux-user/syscall.c:9860:17: warning: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119 str

[Qemu-devel] [PULL 09/17] linux-user: move sparc/sparc64 fcntl definitions to sparc/target_fcntl.h

2018-06-04 Thread Laurent Vivier
No code change. Signed-off-by: Laurent Vivier Message-Id: <20180529194207.31503-8-laur...@vivier.eu> --- linux-user/sparc/target_fcntl.h | 34 ++ linux-user/syscall_defs.h | 39 --- 2 files changed, 34 insertions(+), 39 de

[Qemu-devel] [PULL 05/17] linux-user: move hppa fcntl definitions to hppa/target_fcntl.h

2018-06-04 Thread Laurent Vivier
No code change. Signed-off-by: Laurent Vivier Acked-by: Richard Henderson Message-Id: <20180529194207.31503-4-laur...@vivier.eu> --- linux-user/hppa/target_fcntl.h | 31 +++ linux-user/syscall_defs.h | 34 +- 2 files changed, 32 i

[Qemu-devel] [PULL 04/17] linux-user: move alpha fcntl definitions to alpha/target_fcntl.h

2018-06-04 Thread Laurent Vivier
No code change. Signed-off-by: Laurent Vivier Acked-by: Richard Henderson Message-Id: <20180529194207.31503-3-laur...@vivier.eu> --- linux-user/alpha/target_fcntl.h | 29 + linux-user/syscall_defs.h | 32 ++-- 2 files changed, 31 ins

[Qemu-devel] [PULL 11/17] linux-user: move generic signal definitions to generic/signal.h

2018-06-04 Thread Laurent Vivier
No code change. Signed-off-by: Laurent Vivier Message-Id: <20180529194207.31503-10-laur...@vivier.eu> --- linux-user/aarch64/target_signal.h| 2 ++ linux-user/arm/target_signal.h| 2 ++ linux-user/cris/target_signal.h | 2 ++ linux-user/generic/signal.h | 57 ++

[Qemu-devel] [PULL 02/17] linux-user: SPARC "rd %tick" can be used by user application

2018-06-04 Thread Laurent Vivier
we have the same problem decribed in 7d6b1daedd ("linux-user, ppc: mftbl can be used by user application") for ppc in the case of sparc. When we use an application trying to resolve a name, it hangs in 0xff5dd40c: rd %tick, %o5 0xff5dd410: srlx %o5, 0x20, %o4 0x000

[Qemu-devel] [PULL 16/17] linux-user: move hppa signal definitions to hppa/target_signal.h

2018-06-04 Thread Laurent Vivier
No code change. Signed-off-by: Laurent Vivier Message-Id: <20180529194207.31503-15-laur...@vivier.eu> --- linux-user/hppa/target_signal.h | 46 linux-user/syscall_defs.h | 52 - 2 files changed, 46 insertions(+),

[Qemu-devel] [PULL 13/17] linux-user: move mips signal definitions to mips/target_signal.h

2018-06-04 Thread Laurent Vivier
No code change. Signed-off-by: Laurent Vivier Message-Id: <20180529194207.31503-12-laur...@vivier.eu> --- linux-user/mips/target_signal.h | 50 ++ linux-user/mips64/target_signal.h | 49 ++ linux-user/syscall_defs.h | 56 +

[Qemu-devel] [PULL 08/17] linux-user: move ppc fcntl definitions to ppc/target_fcntl.h

2018-06-04 Thread Laurent Vivier
No code change. Signed-off-by: Laurent Vivier Message-Id: <20180529194207.31503-7-laur...@vivier.eu> --- linux-user/ppc/target_fcntl.h | 6 ++ linux-user/syscall_defs.h | 7 +-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/linux-user/ppc/target_fcntl.h b/linux-user/

[Qemu-devel] [PATCH v2 07/13] hw/misc/tz-mpc.c: Implement correct blocked-access behaviour

2018-06-04 Thread Peter Maydell
The MPC is guest-configurable for whether blocked accesses: * should be RAZ/WI or cause a bus error * should generate an interrupt or not Implement this behaviour in the blocked-access handlers. Signed-off-by: Peter Maydell --- hw/misc/tz-mpc.c | 50 +++

[Qemu-devel] [PULL 14/17] linux-user: move openrisc signal definitions to openrisc/target_signal.h

2018-06-04 Thread Laurent Vivier
No code change. Signed-off-by: Laurent Vivier Message-Id: <20180529194207.31503-13-laur...@vivier.eu> --- linux-user/openrisc/target_signal.h | 8 linux-user/syscall_defs.h | 10 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/linux-user/openrisc/tar

[Qemu-devel] [PULL 15/17] linux-user: move alpha signal definitions to alpha/target_signal.h

2018-06-04 Thread Laurent Vivier
No code change. Signed-off-by: Laurent Vivier Message-Id: <20180529194207.31503-14-laur...@vivier.eu> --- linux-user/alpha/target_signal.h | 45 +++ linux-user/syscall_defs.h| 51 ++-- 2 files changed, 47 insertions(+),

Re: [Qemu-devel] [PATCH v4 00/19] reverse debugging

2018-06-04 Thread Alex Bennée
Pavel Dovgalyuk writes: > Ping? I started having a look but I ran into this straight away. First I recorded a boot of the kernel: ./aarch64-softmmu/qemu-system-aarch64 -machine virt,graphics=on,gic-version=3,virtualization=on -cpu cortex-a53 --serial mon:stdio -display none -kernel ../im

[Qemu-devel] [PATCH v2 08/13] hw/misc/tz_mpc.c: Honour the BLK_LUT settings in translate

2018-06-04 Thread Peter Maydell
The final part of the Memory Protection Controller we need to implement is actually using the BLK_LUT data programmed by the guest to determine whether to block the transaction or not. Since this means we now change transaction mappings when the guest writes to BLK_LUT, we must also call the IOMMU

[Qemu-devel] [PULL 03/17] linux-user: move generic fcntl definitions to generic/fcntl.h

2018-06-04 Thread Laurent Vivier
add a per target target_fcntl.h and include the generic one from them No code change. Signed-off-by: Laurent Vivier Message-Id: <20180529194207.31503-2-laur...@vivier.eu> --- linux-user/aarch64/target_fcntl.h| 11 +++ linux-user/alpha/target_fcntl.h | 11 +++ linux-user/arm/target_fc

[Qemu-devel] [PULL 10/17] linux-user: move get_sp_from_cpustate() to target_cpu.h

2018-06-04 Thread Laurent Vivier
Remove useless includes Fix HPPA include guard. Signed-off-by: Laurent Vivier Acked-by: Richard Henderson Message-Id: <20180529194207.31503-9-laur...@vivier.eu> --- linux-user/aarch64/signal.c | 1 - linux-user/aarch64/target_cpu.h | 4 linux-user/aarch64/target_signal.h

[Qemu-devel] [PULL 17/17] linux-user: remove useless #if

2018-06-04 Thread Laurent Vivier
Remove a "#if defined(XX) || defined(YY) || ..." with all available targets Signed-off-by: Laurent Vivier Message-Id: <20180529194207.31503-16-laur...@vivier.eu> --- linux-user/syscall_defs.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/linux-user/syscall_defs.h b/linux-user/sy

[Qemu-devel] [PATCH v2 06/13] hw/misc/tz-mpc.c: Implement registers

2018-06-04 Thread Peter Maydell
Implement the missing registers for the TZ MPC. Signed-off-by: Peter Maydell --- include/hw/misc/tz-mpc.h | 10 +++ hw/misc/tz-mpc.c | 137 ++- 2 files changed, 144 insertions(+), 3 deletions(-) diff --git a/include/hw/misc/tz-mpc.h b/include/hw/misc

[Qemu-devel] [PATCH RESEND 1/2] linux-user: Export use is_error(), use it to avoid warnings

2018-06-04 Thread Philippe Mathieu-Daudé
This fixes: linux-user/flatload.c:740:9: warning: Loss of sign in implicit conversion if (res > (unsigned long)-4096) ^~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier --- linux-user/qemu.h| 5 + linux-user/syscal

[Qemu-devel] [PATCH v2 09/13] hw/core/or-irq: Support more than 16 inputs to an OR gate

2018-06-04 Thread Peter Maydell
For the IoTKit MPC support, we need to wire together the interrupt outputs of 17 MPCs; this exceeds the current value of MAX_OR_LINES. Increase MAX_OR_LINES to 32 (which should be enough for anyone). The tricky part is retaining the migration compatibility for existing OR gates; we add a subsectio

[Qemu-devel] [PATCH v2 00/13] iommu: support txattrs, support TCG execution, implement TZ MPC

2018-06-04 Thread Peter Maydell
Hi; this is v2 of my iommu patchset, which does: * support IOMMUs that are aware of memory transaction attributes and may generate different translations for different attributes * support TCG execution out of memory which is behind an IOMMU * implement the Arm TrustZone Memory Protection Con

[Qemu-devel] [PATCH RESEND 2/2] linux-user: Use is_error() to avoid warnings and make the code clearer

2018-06-04 Thread Philippe Mathieu-Daudé
This fixes: linux-user/flatload.c:740:9: warning: Loss of sign in implicit conversion if (res > (unsigned long)-4096) ^~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier --- linux-user/flatload.c | 15 +-- 1 fil

Re: [Qemu-devel] [PATCH] main-loop: document IOCanReadHandler

2018-06-04 Thread Paolo Bonzini
On 02/06/2018 10:52, Stefan Hajnoczi wrote: > Signed-off-by: Stefan Hajnoczi > --- > include/qemu/main-loop.h | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/include/qemu/main-loop.h b/include/qemu/main-loop.h > index 6b4b60bf6d..721aa2416a 100644 > --- a/include/qemu/ma

[Qemu-devel] [PATCH v2 05/13] hw/misc/tz-mpc.c: Implement the Arm TrustZone Memory Protection Controller

2018-06-04 Thread Peter Maydell
Implement the Arm TrustZone Memory Protection Controller, which sits in front of RAM and allows secure software to configure it to either pass through or reject transactions. We implement the MPC as a QEMU IOMMU, which will direct transactions either through to the devices and memory behind it or

Re: [Qemu-devel] [PATCH 15/27] iommu: Add IOMMU index argument to notifier APIs

2018-06-04 Thread Peter Maydell
On 4 June 2018 at 16:09, Alex Bennée wrote: > > Peter Maydell writes: > >> On 23 May 2018 at 10:08, Alex Bennée wrote: >>> Its a minor thing but are we ever expecting iommu_idx to ever be >>> negative? >> >> Coming back to this one -- no, we don't expect negative iommu_idxs. >> But on the other

[Qemu-devel] [PATCH v2 04/13] exec.c: Handle IOMMUs in address_space_translate_for_iotlb()

2018-06-04 Thread Peter Maydell
Currently we don't support board configurations that put an IOMMU in the path of the CPU's memory transactions, and instead just assert() if the memory region fonud in address_space_translate_for_iotlb() is an IOMMUMemoryRegion. Remove this limitation by having the function handle IOMMUs. This is

Re: [Qemu-devel] [PULL 0/2] Vga 20180604 patches

2018-06-04 Thread Peter Maydell
; > are available in the git repository at: > > git://git.kraxel.org/qemu tags/vga-20180604-pull-request > > for you to fetch changes up to 6bc2fd57e1fc2d1957d1ff952793c53764130218: > > vga: cleanup surface handling (2018-06-04 09:44:10 +0200) > > --

[Qemu-devel] [PATCH v2 03/13] iommu: Add IOMMU index argument to translate method

2018-06-04 Thread Peter Maydell
Add an IOMMU index argument to the translate method of IOMMUs. Since all of our current IOMMU implementations support only a single IOMMU index, this has no effect on the behaviour. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée --- include/exec/memory.h

[Qemu-devel] [PATCH v2 02/13] iommu: Add IOMMU index argument to notifier APIs

2018-06-04 Thread Peter Maydell
Add support for multiple IOMMU indexes to the IOMMU notifier APIs. When initializing a notifier with iommu_notifier_init(), the caller must pass the IOMMU index that it is interested in. When a change happens, the IOMMU implementation must pass memory_region_notify_iommu() the IOMMU index that has

Re: [Qemu-devel] [PATCH 0/1] vmstatification of 0323 [for 2.8?]

2018-06-04 Thread Paolo Bonzini
On 02/06/2018 07:09, Philippe Mathieu-Daudé wrote: > > I realized the binary expect CMD8 to not return, to use the SD card > with Spec v1.x. Which is the very patch Paul Brook attached... > http://lists.nongnu.org/archive/html/qemu-devel/2012-04/msg03790.html > > curl > http://lists.nongnu.org/ar

[Qemu-devel] [PATCH v2 11/13] hw/arm/iotkit: Instantiate MPC

2018-06-04 Thread Peter Maydell
Wire up the one MPC that is part of the IoTKit itself. For the moment we don't wire up its interrupt line. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée --- include/hw/arm/iotkit.h | 2 ++ hw/arm/iotkit.c | 38 +++--- 2 files changed, 29 insertio

[Qemu-devel] [PATCH v2 01/13] iommu: Add IOMMU index concept to IOMMU API

2018-06-04 Thread Peter Maydell
If an IOMMU supports mappings that care about the memory transaction attributes, then it no longer has a unique address -> output mapping, but more than one. We can represent these using an IOMMU index, analogous to TCG's mmu indexes. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson -

Re: [Qemu-devel] [PATCH 1/6] ahci: move PIO Setup FIS before transfer, fix it for ATAPI commands

2018-06-04 Thread Paolo Bonzini
On 02/06/2018 03:22, John Snow wrote: > - Status: Should be the status register after receiving the H2D Register > update FIS, but prior to the data transfer, I think. "New value of the > Status register of the Command Block for initiation of host data > transfer." > I think this is being s

[Qemu-devel] [PATCH v2 10/13] hw/misc/iotkit-secctl.c: Implement SECMPCINTSTATUS

2018-06-04 Thread Peter Maydell
Implement the SECMPCINTSTATUS register. This is the only register in the security controller that deals with Memory Protection Controllers, and it simply provides a read-only view of the interrupt lines from the various MPCs in the system. Signed-off-by: Peter Maydell --- include/hw/misc/iotkit-

[Qemu-devel] [PATCH v2 13/13] hw/arm/mps2-tz.c: Instantiate MPCs

2018-06-04 Thread Peter Maydell
Instantiate and wire up the Memory Protection Controllers in the MPS2 board itself. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée --- hw/arm/mps2-tz.c | 71 ++-- 1 file changed, 44 insertions(+), 27 deletions(-) diff --git a/hw/arm/mps2-tz.c

Re: [Qemu-devel] [PULL 00/17] Linux user for 3.0 patches

2018-06-04 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180604152015.13359-1-laur...@vivier.eu Subject: [Qemu-devel] [PULL 00/17] Linux user for 3.0 patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --

Re: [Qemu-devel] [PATCH v2 2/2] vl: fix use of --daemonize with --preconfig

2018-06-04 Thread Igor Mammedov
On Mon, 4 Jun 2018 16:15:23 +0100 Daniel P. Berrangé wrote: > On Mon, Jun 04, 2018 at 05:01:11PM +0200, Igor Mammedov wrote: > > On Mon, 4 Jun 2018 16:21:48 +0200 > > Michal Privoznik wrote: > > > > > On 06/04/2018 02:03 PM, Daniel P. Berrangé wrote: > > > > When using --daemonize, the init

[Qemu-devel] [PATCH RESEND v2 0/2] linux-user: fix bugs reported by Clang Static Analyzer

2018-06-04 Thread Philippe Mathieu-Daudé
This is a resend of v1 resend ... not sure what happened previously, MTA sent: 550 8-bit characters not allowed in subject (see RFC 2822, sections 3.6.5, 2.2.1) v1 here: http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg07453.html Philippe Mathieu-Daudé (2): linux-user: Export us

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-04 Thread Igor Mammedov
On Mon, 4 Jun 2018 13:03:44 +0100 Daniel P. Berrangé wrote: > The RUN_STATE_PRECONFIG state is not supposed to be reachable unless the > --preconfig argument is given to QEMU, but when it was introduced in: > > commit 047f7038f586d2150f16c6d9ba9cfd0479f0f6ac > Author: Igor Mammedov > Dat

[Qemu-devel] [PATCH RESEND v2 1/2] linux-user: Export use is_error(), use it to avoid warnings

2018-06-04 Thread Philippe Mathieu-Daudé
This fixes: linux-user/flatload.c:740:9: warning: Loss of sign in implicit conversion if (res > (unsigned long)-4096) ^~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier --- linux-user/qemu.h| 5 + linux-user/syscal

[Qemu-devel] [PATCH RESEND v2 2/2] linux-user: Use is_error() to avoid warnings and make the code clearer

2018-06-04 Thread Philippe Mathieu-Daudé
This fixes: linux-user/flatload.c:740:9: warning: Loss of sign in implicit conversion if (res > (unsigned long)-4096) ^~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier --- linux-user/flatload.c | 15 +-- 1 fil

Re: [Qemu-devel] [PATCH 6/6] ide: introduce ide_transfer_start_norecurse

2018-06-04 Thread Paolo Bonzini
On 02/06/2018 03:17, John Snow wrote: > > > On 04/17/2018 11:39 AM, Paolo Bonzini wrote: >> For the case where the end_transfer_func is also the caller of >> ide_transfer_start, the mutual recursion can lead to unlimited >> stack usage. Introduce a new version that can be used to change >> tail

Re: [Qemu-devel] [PATCH 6/8] sdcard: Disable SEND_IF_COND (CMD8) for Spec v1

2018-06-04 Thread Paolo Bonzini
On 03/06/2018 02:08, Philippe Mathieu-Daudé wrote: > Paolo, I guess this would be a good use of the > Based-on: 201204252110.20873.p...@codesourcery.com tag in > the git history :P Oh, I see you did send it. Thanks! "Based-on" means that it applies to a tree with that patch. It doesn't mean tha

Re: [Qemu-devel] [PATCH 2/6] ide: push end_transfer_func out of start_transfer callback, rename callback

2018-06-04 Thread Paolo Bonzini
On 02/06/2018 02:24, John Snow wrote: >> -if (s->bus->dma->ops->start_transfer) { >> -s->bus->dma->ops->start_transfer(s->bus->dma); >> +if (!s->bus->dma->ops->pio_transfer) { >> +s->end_transfer_func = end_transfer_func; >> +return; >> } >> +s->bus->dma->op

Re: [Qemu-devel] [PATCH v2] qcow2: add overlap check for bitmap directory

2018-06-04 Thread Vladimir Sementsov-Ogievskiy
20.04.2018 15:12, Vladimir Sementsov-Ogievskiy wrote: 19.04.2018 23:57, John Snow wrote: On 03/19/2018 04:07 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- If it appropriate for 2.12, let's push it. If not - then for 2.13. I wonder if I can make the

Re: [Qemu-devel] [PATCH v4 13/14] memory-device: factor out unplug into hotplug handler

2018-06-04 Thread David Hildenbrand
>> # hw/mem/pc-dimm.c >> mhp_pc_dimm_assigned_slot(int slot) "%d" >> mhp_pc_dimm_assigned_address(uint64_t addr) "0x%"PRIx64 >> +# hw/mem/memory-device.c >> +memory_device_unassign_address(uint64_t addr) "0x%"PRIx64 > maybe split out tracing into a separate patch? Can do, although I think thi

[Qemu-devel] [PATCH v2 12/13] hw/arm/iotkit: Wire up MPC interrupt lines

2018-06-04 Thread Peter Maydell
The interrupt outputs from the MPC in the IoTKit and the expansion MPCs in the board must be wired up to the security controller, and also all ORed together to produce a single line to the NVIC. Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée --- include/hw/arm/iotkit.h | 6 hw/arm/

Re: [Qemu-devel] [PATCH v6] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR

2018-06-04 Thread Peter Maydell
On 1 June 2018 at 02:36, Shannon Zhao wrote: > While we skip the GIC_INTERNAL irqs, we don't change the register offset > accordingly. This will overlap the GICR registers value and leave the > last GIC_INTERNAL irq's registers out of update. > > Fix this by skipping the registers banked by GICR.

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-04 Thread Daniel P . Berrangé
On Mon, Jun 04, 2018 at 05:40:32PM +0200, Igor Mammedov wrote: > On Mon, 4 Jun 2018 13:03:44 +0100 > Daniel P. Berrangé wrote: > > > The RUN_STATE_PRECONFIG state is not supposed to be reachable unless the > > --preconfig argument is given to QEMU, but when it was introduced in: > > > > commi

[Qemu-devel] [PATCH] CODING_STYLE: Define our preferred form for multiline comments

2018-06-04 Thread Peter Maydell
The codebase has a bit of a mix of /* multiline comments * like this */ and /* multiline comments like this in the GNU Coding Standards style */ State a preference for the former. Signed-off-by: Peter Maydell --- I admit that to some extent I'm imposing my aesthetic preferences here; p

Re: [Qemu-devel] [PATCH v2 00/13] iommu: support txattrs, support TCG execution, implement TZ MPC

2018-06-04 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180604152941.20374-1-peter.mayd...@linaro.org Subject: [Qemu-devel] [PATCH v2 00/13] iommu: support txattrs, support TCG execution, implement TZ MPC === TEST SCRIPT BEGIN

Re: [Qemu-devel] [PATCH v3b 06/18] target/arm: Implement SVE conditionally broadcast/extract element

2018-06-04 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 2 + > target/arm/sve_helper.c| 11 ++ > target/arm/translate-sve.c | 318 + > target/arm/sve.decode | 20 +++ > 4 files chan

Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

2018-06-04 Thread Michael S. Tsirkin
On Mon, Jun 04, 2018 at 02:01:29PM +0100, Daniel P. Berrangé wrote: > On Mon, Jun 04, 2018 at 09:54:15AM -0300, Eduardo Habkost wrote: > > On Mon, Jun 04, 2018 at 04:38:22AM +0300, Michael S. Tsirkin wrote: > > > On Sun, Jun 03, 2018 at 12:27:49PM +0300, Marcel Apfelbaum wrote: > > > > Moving to QE

Re: [Qemu-devel] [PATCH v3b 01/18] target/arm: Extend vec_reg_offset to larger sizes

2018-06-04 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Rearrange the arithmetic so that we are agnostic about the total size > of the vector and the size of the element. This will allow us to index > up to the 32nd byte and with 16-byte elements. > > Signed-off-by: Richard Henderson > --- > target

Re: [Qemu-devel] [PATCH v3b 07/18] target/arm: Implement SVE copy to vector (predicated)

2018-06-04 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/translate-sve.c | 19 +++ > target/arm/sve.decode | 6 ++ > 2 files changed, 25 insertions(+) Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

2018-06-04 Thread Daniel P . Berrangé
On Mon, Jun 04, 2018 at 07:48:51PM +0300, Michael S. Tsirkin wrote: > On Mon, Jun 04, 2018 at 02:01:29PM +0100, Daniel P. Berrangé wrote: > > On Mon, Jun 04, 2018 at 09:54:15AM -0300, Eduardo Habkost wrote: > > > On Mon, Jun 04, 2018 at 04:38:22AM +0300, Michael S. Tsirkin wrote: > > > > On Sun, Ju

Re: [Qemu-devel] [PATCH v3b 08/18] target/arm: Implement SVE reverse within elements

2018-06-04 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 14 + > target/arm/sve_helper.c| 41 +++--- > target/arm/translate-sve.c | 38 +++ > target/ar

Re: [Qemu-devel] [PATCH v3b 09/18] target/arm: Implement SVE vector splice (predicated)

2018-06-04 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 2 ++ > target/arm/sve_helper.c| 37 + > target/arm/translate-sve.c | 13 + > target/arm/sve.decode | 3 +++ > 4 fi

Re: [Qemu-devel] [PATCH v3b 10/18] target/arm: Implement SVE Select Vectors Group

2018-06-04 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 9 +++ > target/arm/sve_helper.c| 55 ++ > target/arm/translate-sve.c | 2 ++ > target/arm/sve.decode | 6 + > 4 files

Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

2018-06-04 Thread Michael S. Tsirkin
On Mon, Jun 04, 2018 at 10:26:24AM -0300, Eduardo Habkost wrote: > On Mon, Jun 04, 2018 at 02:01:29PM +0100, Daniel P. Berrangé wrote: > > On Mon, Jun 04, 2018 at 09:54:15AM -0300, Eduardo Habkost wrote: > > > On Mon, Jun 04, 2018 at 04:38:22AM +0300, Michael S. Tsirkin wrote: > > > > On Sun, Jun 0

[Qemu-devel] [RFC PATCH] target/ppc: extend eieio for POWER9

2018-06-04 Thread Cédric Le Goater
POWER9 introduced a new variant of the eieio instruction using bit 6 as a hint to tell the CPU it is a store-forwarding barrier. The usage of this eieio extension was recently added in Linux 4.17 which activated the "support for a store forwarding barrier at kernel entry/exit". This loosen the QE

Re: [Qemu-devel] [PATCH v2] qcow2: add overlap check for bitmap directory

2018-06-04 Thread John Snow
On 06/04/2018 12:11 PM, Vladimir Sementsov-Ogievskiy wrote: > 20.04.2018 15:12, Vladimir Sementsov-Ogievskiy wrote: >> 19.04.2018 23:57, John Snow wrote: >>> >>> On 03/19/2018 04:07 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- If it

Re: [Qemu-devel] [PATCH v3b 11/18] target/arm: Implement SVE Integer Compare - Vectors Group

2018-06-04 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 115 +++ > target/arm/sve_helper.c| 187 + > target/arm/translate-sve.c | 91 ++ > target/arm/sve

Re: [Qemu-devel] [PULL 0/2] Vga 20180604 patches

2018-06-04 Thread Peter Maydell
0618-1' into staging (2018-06-01 >> 17:32:30 +0100) >> >> are available in the git repository at: >> >> git://git.kraxel.org/qemu tags/vga-20180604-pull-request >> >> for you to fetch changes up to 6bc2fd57e1fc2d1957d1ff95279

Re: [Qemu-devel] [PATCH v3b 12/18] target/arm: Implement SVE Integer Compare - Immediate Group

2018-06-04 Thread Peter Maydell
On 30 May 2018 at 19:01, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 44 +++ > target/arm/sve_helper.c| 88 ++ > target/arm/translate-sve.c | 66 > target/arm

Re: [Qemu-devel] [PATCH v2 1/2] vl: don't use RUN_STATE_PRECONFIG as initial state

2018-06-04 Thread Igor Mammedov
On Mon, 4 Jun 2018 17:11:57 +0100 Daniel P. Berrangé wrote: > On Mon, Jun 04, 2018 at 05:40:32PM +0200, Igor Mammedov wrote: > > On Mon, 4 Jun 2018 13:03:44 +0100 > > Daniel P. Berrangé wrote: > > > > > The RUN_STATE_PRECONFIG state is not supposed to be reachable unless the > > > --preconfi

Re: [Qemu-devel] [PATCH 2/6] ide: push end_transfer_func out of start_transfer callback, rename callback

2018-06-04 Thread John Snow
On 06/04/2018 11:48 AM, Paolo Bonzini wrote: > On 02/06/2018 02:24, John Snow wrote: >>> -if (s->bus->dma->ops->start_transfer) { >>> -s->bus->dma->ops->start_transfer(s->bus->dma); >>> +if (!s->bus->dma->ops->pio_transfer) { >>> +s->end_transfer_func = end_transfer_func;

Re: [Qemu-devel] [PATCH v7 0/7] aspeed: add a witherspoon-bmc machine

2018-06-04 Thread Peter Maydell
On 30 May 2018 at 07:40, Cédric Le Goater wrote: > Hello > > This series adds a new Aspeed machine to emulate the BMC of a > Witherspoon system. It also extends the other Aspeed machines with I2C > devices and adds a simple model for the pca9552 LED blinker present on > the Witherspoon board. > >

Re: [Qemu-devel] [PATCH] CODING_STYLE: Define our preferred form for multiline comments

2018-06-04 Thread John Snow
On 06/04/2018 12:21 PM, Peter Maydell wrote: > The codebase has a bit of a mix of > /* multiline comments > * like this > */ > and > /* multiline comments like this > in the GNU Coding Standards style */ > > State a preference for the former. > > Signed-off-by: Peter Maydell > --- >

Re: [Qemu-devel] [RFC PATCH] hw/registerfields: Deposit fields "in place"

2018-06-04 Thread Alistair Francis
On Sat, Jun 2, 2018 at 3:26 PM, Philippe Mathieu-Daudé wrote: > On 06/02/2018 05:55 PM, Philippe Mathieu-Daudé wrote: >> These macros are always used to deposit a field in place. >> Update them to take the pointer argument. >> >> As these macros are constructed using compound statements, >> it is

Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

2018-06-04 Thread John Snow
On 06/04/2018 08:35 AM, Paolo Bonzini wrote: > On 04/06/2018 14:24, Igor Mammedov wrote: >>> Yes it's easy to add -machine pc but there's no documentation >>> that tells you to do so. Add to that shortcuts like -cdrom >>> stop working, hotplug needs extra bridges to work, and one >>> can see tha

Re: [Qemu-devel] [PATCH 0/8] sdcard: cleanup the SD_SPEC version

2018-06-04 Thread Alistair Francis
On Sat, Jun 2, 2018 at 5:08 PM, Philippe Mathieu-Daudé wrote: > Hi, > > This series adds a 'spec_version' property to the SD Card device, > to allow to limit some commands to specific spec version range > (some firmwares use this feature to detect which spec version the > card implements). > > Thi

Re: [Qemu-devel] [PATCH 2/8] sdcard: Allow commands valid in SPI mode

2018-06-04 Thread Alistair Francis
On Sat, Jun 2, 2018 at 5:08 PM, Philippe Mathieu-Daudé wrote: > From the "Physical Layer Simplified Specification Version 1.10" > Chapter 7.3 "SPI Mode Transaction Packets" > Table 57: "Commands and arguments" > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis Alistair

Re: [Qemu-devel] [PATCH 3/8] sdcard: Add a 'spec_version' property

2018-06-04 Thread Alistair Francis
On Sat, Jun 2, 2018 at 5:08 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > include/hw/sd/sd.h | 4 > hw/sd/sd.c | 11 +++ > 2 files changed, 15 insertions(+) > > diff --git a/include/hw/sd/sd.h b/

Re: [Qemu-devel] [PATCH 4/8] sdcard: Set Spec v2.00 as default

2018-06-04 Thread Alistair Francis
On Sat, Jun 2, 2018 at 5:08 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > include/hw/sd/sd.h | 1 + > hw/sd/sd.c | 13 + > 2 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/includ

Re: [Qemu-devel] [PATCH 5/8] hw/sd/ssi-sd: Force cards connected in SPI mode to use Spec v1.10

2018-06-04 Thread Alistair Francis
On Sat, Jun 2, 2018 at 5:08 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Can you add a justification for this in the commit message? Alistair > --- > hw/sd/ssi-sd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/sd/ssi-sd.c b/hw/sd/ssi-sd.c > index

Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

2018-06-04 Thread Marcel Apfelbaum
Hi Michael, On 06/04/2018 04:38 AM, Michael S. Tsirkin wrote: On Sun, Jun 03, 2018 at 12:27:49PM +0300, Marcel Apfelbaum wrote: Moving to QEMU 3.0 seems like a good opportunity for such a change. I440FX is really old and does not support modern features like IOMMU. Q35's SATA emulation is fast

  1   2   3   4   >