[Qemu-devel] [PULL 13/30] ahci: fix host register max address

2018-06-08 Thread John Snow
Yes, comment, it ought to be 0x2C. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20180531222835.16558-11-js...@redhat.com Signed-off-by: John Snow --- hw/ide/ahci_internal.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/ide/ahci_internal.h

[Qemu-devel] [PULL 14/30] ahci: modify ahci_mem_read_32 to work on register numbers

2018-06-08 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20180531222835.16558-12-js...@redhat.com Signed-off-by: John Snow --- hw/ide/ahci.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 5be43ba2d0..99c

[Qemu-devel] [PULL 06/30] ahci: make port read traces more descriptive

2018-06-08 Thread John Snow
A trace is added to let us watch unimplemented registers specifically, as these are more likely to cause us trouble. Otherwise, the port read traces now tell us what register is getting hit, which is nicer. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20180531222835.1

[Qemu-devel] [PULL 09/30] ahci: modify ahci_port_write to use register numbers

2018-06-08 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20180531222835.16558-7-js...@redhat.com Signed-off-by: John Snow --- hw/ide/ahci.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index

[Qemu-devel] [PULL 01/30] ahci: trim signatures on raise/lower

2018-06-08 Thread John Snow
These functions work on the AHCI device, not the individual AHCI devices, so trim the AHCIDevice argument. Signed-off-by: John Snow Reviewed-by: Stefan Hajnoczi Reviewed-by: Jeff Cody Message-id: 20180531004323.4611-2-js...@redhat.com Signed-off-by: John Snow --- hw/ide/ahci.c | 8 1

[Qemu-devel] [PULL 03/30] ahci: don't schedule unnecessary BH

2018-06-08 Thread John Snow
The comment gives us a hint. *Maybe* we still have something to process. Well, why not check? Signed-off-by: John Snow Reviewed-by: Stefan Hajnoczi Reviewed-by: Jeff Cody Message-id: 20180531004323.4611-4-js...@redhat.com Signed-off-by: John Snow --- hw/ide/ahci.c | 3 +-- 1 file changed, 1 i

[Qemu-devel] [PULL 12/30] ahci: add host register enumeration

2018-06-08 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20180531222835.16558-10-js...@redhat.com Signed-off-by: John Snow --- hw/ide/ahci.c | 15 +++ hw/ide/ahci_internal.h | 15 +++ 2 files changed, 30 insertions(+) diff --git a/hw/ide/ahci.c

[Qemu-devel] [PULL 08/30] ahci: combine identical clauses in port write

2018-06-08 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20180531222835.16558-6-js...@redhat.com Signed-off-by: John Snow --- hw/ide/ahci.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index a19f46c301..2aea9c3e12 100644 --- a/hw/ide/ahci.

[Qemu-devel] [PULL 19/30] ahci: make ahci_mem_write traces more descriptive

2018-06-08 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20180531222835.16558-17-js...@redhat.com [Fixed format specifiers. --js] Signed-off-by: John Snow --- hw/ide/ahci.c | 15 ++- hw/ide/trace-events | 4 +++- 2 files changed, 17 insertions(+), 2 deletions(

[Qemu-devel] [PULL 11/30] ahci: delete old port register address definitions

2018-06-08 Thread John Snow
They're now unused. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20180531222835.16558-9-js...@redhat.com Signed-off-by: John Snow --- hw/ide/ahci_internal.h | 18 -- 1 file changed, 18 deletions(-) diff --git a/hw/ide/ahci_internal.h b/hw/ide/ahci_i

[Qemu-devel] [PULL 00/30] Ide patches

2018-06-08 Thread John Snow
The following changes since commit 0d2fa03dae4fbe185a082f361342b1e30aed4582: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20180608' into staging (2018-06-08 16:26:51 +0100) are available in the Git repository at: https://github.com/jnsnow/qemu.git tag

[Qemu-devel] [PULL 05/30] ahci: modify ahci_port_read to use register numbers

2018-06-08 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20180531222835.16558-3-js...@redhat.com Signed-off-by: John Snow --- hw/ide/ahci.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c

[Qemu-devel] [PULL 02/30] ahci: fix PxCI register race

2018-06-08 Thread John Snow
Fixes: https://bugs.launchpad.net/qemu/+bug/1769189 AHCI presently signals completion prior to the PxCI register being cleared to indicate completion. If a guest driver attempts to issue a new command in its IRQ handler, it might be surprised to learn there is still a command pending. In the case

Re: [Qemu-devel] [qemu PATCH 4/5] machine: fix some misspelled words

2018-06-08 Thread Ross Zwisler
On Fri, Jun 08, 2018 at 07:38:17AM +0200, Thomas Huth wrote: > On 08.06.2018 00:31, Ross Zwisler wrote: > > Normally this might not be worth fixing, but several of these are strings > > which are displayed to users. > > > > Signed-off-by: Ross Zwisler > > --- > > hw/core/machine.c | 6 +++--- > >

Re: [Qemu-devel] [PULL 52/53] char: Remove unwanted crlf conversion

2018-06-08 Thread Greg Kurz
On Thu, 31 May 2018 19:16:05 +0200 Paolo Bonzini wrote: > From: Patryk Olszewski > > This patch fixes a bug in serial that made it almost impossible for guest > to communicate with devices through host's serial. > > OPOST flag in c_oflag enables output processing letting other flags in > c_ofl

Re: [Qemu-devel] [PATCH 0/8] Add a standard authorization framework

2018-06-08 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180608170933.9137-1-berra...@redhat.com Subject: [Qemu-devel] [PATCH 0/8] Add a standard

[Qemu-devel] [PATCH 0/2] python: Remove unused compatibility modules

2018-06-08 Thread Eduardo Habkost
Now that we require Python >= 2.7, we don't need scripts/argparse.py and scripts/ordereddict.py anymore. Eduardo Habkost (2): python: Remove scripts/argparse.py python: Remove scripts/ordereddict.py scripts/argparse.py| 2406 scripts/ordereddict.p

[Qemu-devel] [PATCH 2/2] python: Remove scripts/ordereddict.py

2018-06-08 Thread Eduardo Habkost
Python 2.7 (the minimum Python version we require) provides collections.OrderedDict on the standard library, so we don't need to carry our own implementation. Signed-off-by: Eduardo Habkost --- scripts/ordereddict.py | 128 - scripts/qapi/common.py | 5 +

[Qemu-devel] [PATCH 1/2] python: Remove scripts/argparse.py

2018-06-08 Thread Eduardo Habkost
Python 2.7 (the minimum Python version we require) already provides the argparse module on the standard library. Signed-off-by: Eduardo Habkost --- scripts/argparse.py | 2406 --- 1 file changed, 2406 deletions(-) delete mode 100644 scripts/argparse.py d

Re: [Qemu-devel] [PATCH v4 4/6] nbd/server: implement dirty bitmap export

2018-06-08 Thread Vladimir Sementsov-Ogievskiy
08.06.2018 18:23, Vladimir Sementsov-Ogievskiy wrote: Handle new NBD meta namespace: "qemu", and corresponding queries: "qemu:dirty-bitmap:". With new metadata context negotiated, BLOCK_STATUS query will reply with dirty-bitmap data, converted to extents. New public function nbd_export_bitmap se

Re: [Qemu-devel] [PATCH v3 3/3] glib: enforce the minimum required version and warn about old APIs

2018-06-08 Thread Thomas Huth
On 08.06.2018 15:16, Daniel P. Berrangé wrote: > There are two useful macros that can be defined before including > glib.h that are related to the min required glib version > > - GLIB_VERSION_MIN_REQUIRED > >When this is defined, if code uses an API that was deprecated >in this version,

Re: [Qemu-devel] [PATCH v3 1/3] util: remove redundant include of glib.h and add osdep.h

2018-06-08 Thread Thomas Huth
On 08.06.2018 15:16, Daniel P. Berrangé wrote: > Code must only ever include glib.h indirectly via the glib-compat.h > header file, because we will need some macros set before glib.h is > pulled in. Adding extra includes of glib.h will (soon) cause compile > failures such as: > > In file included

Re: [Qemu-devel] [RFC v2 11/12] Add virtio-gpu vhost-user backend

2018-06-08 Thread Marc-André Lureau
Hi On Mon, Jun 4, 2018 at 11:37 AM, Gerd Hoffmann wrote: > On Fri, Jun 01, 2018 at 06:27:48PM +0200, Marc-André Lureau wrote: >> Add to virtio-gpu devices a "vhost-user" property. When set, the >> associated vhost-user backend is used to handle the virtio rings. >> >> For now, a socketpair is cre

Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch

2018-06-08 Thread Thomas Huth
On 08.06.2018 18:24, Michael S. Tsirkin wrote: > On Fri, Jun 08, 2018 at 05:16:30PM +0100, Peter Maydell wrote: >> On 8 June 2018 at 17:03, Michael S. Tsirkin wrote: >>> Pull requests are somewhat different, they are usually tested for lack >>> of warnings. This change didn't arrive as a result of

Re: [Qemu-devel] [PATCH v4 2/6] nbd/server: refactor NBDExportMetaContexts

2018-06-08 Thread Vladimir Sementsov-Ogievskiy
08.06.2018 18:23, Vladimir Sementsov-Ogievskiy wrote: Use NBDExport pointer instead of just export name: there no needs to store duplicated name in the struct, moreover, NBDExport will be used further. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 23 +++

Re: [Qemu-devel] [PATCH] Purge uses of banned g_assert_FOO()

2018-06-08 Thread Eric Blake
On 06/08/2018 12:02 PM, Markus Armbruster wrote: We banned use of certain g_assert_FOO() functions outside tests, and made checkpatch.pl flag them (commit 6e9389563e5). We neglected to purge existing uses. Do that now. Signed-off-by: Markus Armbruster --- Reviewed-by: Eric Blake -- Eric B

Re: [Qemu-devel] [PATCH v2 0/2] vl: Partial support for non-scalar properties with -object

2018-06-08 Thread Daniel P . Berrangé
On Mon, May 28, 2018 at 11:31:03AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > Just a ping to say I'd like us to restart work this patch and try to get > > it mergable for the 2.13 cycle, so I can rely it on for the ACL support > > I've had out of tree since 2.6 :-) > > Fa

Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig

2018-06-08 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Dr. David Alan Gilbert" writes: > >> > >> > * Markus Armbruster (arm...@redhat.com) wrote: > >> >> "Dr. David Alan Gilbert" writes: > >> >> > >> >> > *

Re: [Qemu-devel] [PATCH] Purge uses of banned g_assert_FOO()

2018-06-08 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 07:02:31PM +0200, Markus Armbruster wrote: > We banned use of certain g_assert_FOO() functions outside tests, and > made checkpatch.pl flag them (commit 6e9389563e5). We neglected to > purge existing uses. Do that now. > > Signed-off-by: Markus Armbruster > --- > hw/ide

[Qemu-devel] [PATCH 8/8] authz: delete existing ACL implementation

2018-06-08 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" The 'qemu_acl' type was a previous non-QOM based attempt to provide an authorization facility in QEMU. Because it is non-QOM based it cannot be created via the command line and requires special monitor commands to manipulate it. The new QAuthZ subclasses provide a supe

[Qemu-devel] [PATCH 7/8] authz: add QAuthZPAM object type for authorizing using PAM

2018-06-08 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" Add an authorization backend that talks to PAM to check whether the user identity is allowed. This only uses the PAM account validation facility, which is essentially just a check to see if the provided username is permitted access. It doesn't use the authentication or

[Qemu-devel] [PATCH 5/8] authz: add QAuthZList object type for an access control list

2018-06-08 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" Add a QAuthZList object type that implements the QAuthZ interface. This built-in implementation maintains a trivial access control list with a sequence of match rules and a final default policy. This replicates the functionality currently provided by the qemu_acl module

[Qemu-devel] [PATCH 4/8] authz: add QAuthZSimple object type for trivial auth checks

2018-06-08 Thread Daniel P . Berrangé
In many cases a single VM will just need to whilelist a single identity as the allowed user of network services. This is especially the case for TLS live migration (optionally with NBD storage) where we just need to whitelist the x509 certificate distinguished name of the source QEMU host. Signed-

[Qemu-devel] [PATCH 1/8] util: add helper APIs for dealing with inotify

2018-06-08 Thread Daniel P . Berrangé
The inotify userspace API for reading events is quite horrible, so it is useful to wrap it in a more friendly API to avoid duplicating code across many users in QEMU. Signed-off-by: Daniel P. Berrangé --- MAINTAINERS| 6 ++ include/qemu/inotify.h | 49 +++ util/Makefil

[Qemu-devel] [PATCH 6/8] authz: add QAuthZListFile object type for a file access control list

2018-06-08 Thread Daniel P . Berrangé
Add a QAuthZListFile object type that implements the QAuthZ interface. This built-in implementation is a proxy around the QAtuhZList object type, initializing it from an external file, and optionally, automatically reloading it whenever it changes. To create an instance of this object via the QMP

[Qemu-devel] [PATCH 3/8] authz: add QAuthZ object as an authorization base class

2018-06-08 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" The current qemu_acl module provides a simple access control list facility inside QEMU, which is used via a set of monitor commands acl_show, acl_policy, acl_add, acl_remove & acl_reset. Note there is no ability to create ACLs - the network services (eg VNC server) wer

[Qemu-devel] [PATCH 0/8] Add a standard authorization framework

2018-06-08 Thread Daniel P . Berrangé
The current network services now support encryption via TLS and in some cases support authentication via SASL. In cases where SASL is not available, x509 client certificates can be used as a crude authorization scheme, but using a sub-CA and controlling who you give certs to. In general this is not

[Qemu-devel] [PATCH 2/8] hw/usb: switch MTP to use new inotify APIs

2018-06-08 Thread Daniel P . Berrangé
The internal inotify APIs allow alot of conditional statements to be cleared out, and provide a simpler callback for handling events. Signed-off-by: Daniel P. Berrangé --- hw/usb/dev-mtp.c | 238 +++ 1 file changed, 97 insertions(+), 141 deletions(-)

[Qemu-devel] [PATCH] Purge uses of banned g_assert_FOO()

2018-06-08 Thread Markus Armbruster
We banned use of certain g_assert_FOO() functions outside tests, and made checkpatch.pl flag them (commit 6e9389563e5). We neglected to purge existing uses. Do that now. Signed-off-by: Markus Armbruster --- hw/ide/ahci.c | 2 +- hw/ppc/spapr_ovec.c | 12 ++--

Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig

2018-06-08 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert" writes: >> >> > * Markus Armbruster (arm...@redhat.com) wrote: >> >> "Dr. David Alan Gilbert" writes: >> >> >> >> > * Markus Armbruster (arm...@redhat.com) wrote: >> >> >> Peter Xu w

Re: [Qemu-devel] [Qemu-block] Some question about savem/qcow2 incremental snapshot

2018-06-08 Thread Pankaj Gupta
> Hi Junyan, Just want to add in same email thread there is discussion by Stefan & Kevin describing ways of handling NVDIMM similar to block device with the pros & cons of the approach. In light of that we have to consider this as memory but support of qcow2 is required for snapshot, handli

Re: [Qemu-devel] [Qemu-block] Some question about savem/qcow2 incremental snapshot

2018-06-08 Thread Pankaj Gupta
Hi Junyan, > I think nvdimm kind memory can really save the content(no matter real or > emulated). But I think it is still > memory, as I understand, its data should be stored in the qcow2 image or some > external snapshot data > image, so that we can copy this qcow2 image to other place and re

Re: [Qemu-devel] [Qemu-block] Some question about savem/qcow2 incremental snapshot

2018-06-08 Thread Junyan He
I think nvdimm kind memory can really save the content(no matter real or emulated). But I think it is still memory, as I understand, its data should be stored in the qcow2 image or some external snapshot data image, so that we can copy this qcow2 image to other place and restore the same envir

Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch

2018-06-08 Thread Michael S. Tsirkin
On Fri, Jun 08, 2018 at 05:16:30PM +0100, Peter Maydell wrote: > On 8 June 2018 at 17:03, Michael S. Tsirkin wrote: > > Pull requests are somewhat different, they are usually tested for lack > > of warnings. This change didn't arrive as a result of a pull request > > maybe that's why it slipped th

Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch

2018-06-08 Thread Michael S. Tsirkin
On Fri, Jun 08, 2018 at 05:14:09PM +0100, Peter Maydell wrote: > On 8 June 2018 at 16:59, Michael S. Tsirkin wrote: > > The expected value tests are a debugging aid. They do not catch bugs and > > aren't designed to. In particular the comparisons do not even run if > > IASL isn't installed. > > I

Re: [Qemu-devel] [PATCH v2 0/3] glib: update the min required version

2018-06-08 Thread Peter Maydell
On 8 June 2018 at 13:00, Peter Maydell wrote: > Note that updating to MXE is still on my todo list; I'll let > you know when I get to it... ...and now I've updated my windows crossbuild environment. thanks -- PMM

Re: [Qemu-devel] [PATCH v2] Show values and description when using "qom-list"

2018-06-08 Thread Andreas Färber
Am 08.06.2018 um 11:41 schrieb Dr. David Alan Gilbert: > * Andreas Färber (afaer...@suse.de) wrote: >> Am 01.06.2018 um 17:39 schrieb Ricardo Perez Blanco: >>> For debugging purposes it is very useful to: >>> - See the description of the field. This information is already filled >>>in but not

Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch

2018-06-08 Thread Peter Maydell
On 8 June 2018 at 17:03, Michael S. Tsirkin wrote: > Pull requests are somewhat different, they are usually tested for lack > of warnings. This change didn't arrive as a result of a pull request > maybe that's why it slipped through the cracks. Peter? > > Maybe we need a "pedantic" flag to fail on

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 5/8] hw/timer: Add basic M41T80 emulation

2018-06-08 Thread BALATON Zoltan
On Fri, 8 Jun 2018, Cédric Le Goater wrote: On 06/06/2018 03:31 PM, BALATON Zoltan wrote: Basic emulation of the M41T80 serial (I2C) RTC chip. Only getting time of day is implemented. Setting time and RTC alarm are not supported. Signed-off-by: BALATON Zoltan --- MAINTAINERS

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Cleber Rosa
On 06/08/2018 10:30 AM, Eduardo Habkost wrote: > All of the supported build platforms documented in qemu-doc.texi > should already support Python 2.7. > > Removing support for Python 2.6 will allow us to remove some > compatibility modules we carry in the QEMU tree: > > * scripts/argparse.py >

Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch

2018-06-08 Thread Peter Maydell
On 8 June 2018 at 16:59, Michael S. Tsirkin wrote: > The expected value tests are a debugging aid. They do not catch bugs and > aren't designed to. In particular the comparisons do not even run if > IASL isn't installed. If they're not actually tests to catch bugs, maybe we shouldn't be running t

[Qemu-devel] [RFC PATCH 0/3] Better docker dependency checking

2018-06-08 Thread Alex Bennée
Hi, These patches apply on top of my tcg/testing patch series and attempt to make the dependancy checking a bit smarter within the confines of what Make can achieve. The basic idea is although the debian-sid-image will always rebuild by making it a conditional dependancy we can only trigger this w

Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch

2018-06-08 Thread Michael S. Tsirkin
On Fri, Jun 08, 2018 at 07:17:51AM +0200, Thomas Huth wrote: > On 08.06.2018 01:09, Michael S. Tsirkin wrote: > > On Thu, Jun 07, 2018 at 04:31:08PM -0600, Ross Zwisler wrote: > >> Currently if "make check" detects a mismatch in the ASL generated during > >> testing, we print an error such as: > >>

[Qemu-devel] [RFC PATCH 2/3] dcoker: docker.py add check sub-command

2018-06-08 Thread Alex Bennée
This command allows you to check if we need to re-build a docker image. If the image isn't in the repository or the checksums don't match then we return false and some text (for processing in makefiles). Signed-off-by: Alex Bennée --- tests/docker/docker.py | 22 ++ 1 file ch

[Qemu-devel] [RFC PATCH 1/3] docker: docker.py don't conflate checksums for extra_files

2018-06-08 Thread Alex Bennée
This just gets confusing especially as the helper function doesn't even take into account any extra files (or the executable). Currently the actual check just ignores them and also passes the result through _dockerfile_preprocess so we fix that too. Signed-off-by: Alex Bennée --- tests/docker/do

Re: [Qemu-devel] [qemu PATCH 3/5] hw/i386: Update SSDT table used by "make check"

2018-06-08 Thread Michael S. Tsirkin
On Fri, Jun 08, 2018 at 09:24:49AM -0500, Eric Blake wrote: > On 06/07/2018 06:14 PM, Michael S. Tsirkin wrote: > > On Thu, Jun 07, 2018 at 04:31:09PM -0600, Ross Zwisler wrote: > > > This commit: > > > > > > commit aa78a16d8645 ("hw/i386: Rename 2.13 machine types to 3.0") > > > > > > updated th

[Qemu-devel] [RFC PATCH 3/3] docker: remove SUBMAKE_NOCACHE_HACK for debian-sid based images

2018-06-08 Thread Alex Bennée
Now we can conditionally make docker-image-debian-sid a dependency depending on if we actually need to re-build our image we can remove this hack and use that mechanism. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 25 ++--- tests/tcg/Makefile.include|

Re: [Qemu-devel] [PATCH] chardev: Restore CR,LF on stdio

2018-06-08 Thread Patryk Olszewski
W dniu 08.06.2018 o 17:25, Peter Maydell pisze: > On 8 June 2018 at 06:47, Thomas Huth wrote: >> On 07.06.2018 23:08, Philippe Mathieu-Daudé wrote: >>> Remove the 'stair-step output' on stdio. >>> >>> This partially reverts commit 12fb0ac05, which was correct >>> on the mailing list but got corrup

Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch

2018-06-08 Thread Michael S. Tsirkin
On Fri, Jun 08, 2018 at 09:34:02AM -0600, Ross Zwisler wrote: > On Fri, Jun 08, 2018 at 07:17:51AM +0200, Thomas Huth wrote: > > On 08.06.2018 01:09, Michael S. Tsirkin wrote: > > > On Thu, Jun 07, 2018 at 04:31:08PM -0600, Ross Zwisler wrote: > > >> Currently if "make check" detects a mismatch in

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-08 Thread Pierre Morel
On 08/06/2018 16:45, Cornelia Huck wrote: On Fri, 8 Jun 2018 15:13:28 +0200 Halil Pasic wrote: On 06/08/2018 02:20 PM, Cornelia Huck wrote: My proposal is to do the same copying to scsw(r) again, which would mean we get a request with both the halt and the start bit set. The vfio code now nee

Re: [Qemu-devel] [qemu PATCH 1/5] gitignore: ignore generated qapi job files

2018-06-08 Thread Ross Zwisler
On Fri, Jun 08, 2018 at 09:59:00AM -0500, Eric Blake wrote: > On 06/07/2018 05:31 PM, Ross Zwisler wrote: > > With a fully built QEMU I currently see the following with "git status": > > > >Untracked files: > > (use "git add ..." to include in what will be committed) > > > > qapi/qap

Re: [Qemu-devel] [PATCH] block/qcow2: save dirty_bitmaps_loaded during reopen

2018-06-08 Thread Vladimir Sementsov-Ogievskiy
08.06.2018 15:32, Vladimir Sementsov-Ogievskiy wrote: This variable was introduced to handle reopens. We need it on the following qcow2_do_open, to don't try load bitmaps again. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch

2018-06-08 Thread Ross Zwisler
On Fri, Jun 08, 2018 at 07:17:51AM +0200, Thomas Huth wrote: > On 08.06.2018 01:09, Michael S. Tsirkin wrote: > > On Thu, Jun 07, 2018 at 04:31:08PM -0600, Ross Zwisler wrote: > >> Currently if "make check" detects a mismatch in the ASL generated during > >> testing, we print an error such as: > >>

[Qemu-devel] [PATCH v4 4/6] nbd/server: implement dirty bitmap export

2018-06-08 Thread Vladimir Sementsov-Ogievskiy
Handle new NBD meta namespace: "qemu", and corresponding queries: "qemu:dirty-bitmap:". With new metadata context negotiated, BLOCK_STATUS query will reply with dirty-bitmap data, converted to extents. New public function nbd_export_bitmap selects bitmap to export. For now, only one bitmap may be

Re: [Qemu-devel] [PATCH] chardev: Restore CR,LF on stdio

2018-06-08 Thread Peter Maydell
On 8 June 2018 at 06:47, Thomas Huth wrote: > On 07.06.2018 23:08, Philippe Mathieu-Daudé wrote: >> Remove the 'stair-step output' on stdio. >> >> This partially reverts commit 12fb0ac05, which was correct >> on the mailing list but got corrupted by the maintainer :p >> >> Introduced-by: 3b876140-

[Qemu-devel] [PATCH v4 3/6] nbd/server: add nbd_meta_empty_or_pattern helper

2018-06-08 Thread Vladimir Sementsov-Ogievskiy
Add nbd_meta_pattern() and nbd_meta_empty_or_pattern() helpers for metadata query parsing. nbd_meta_pattern() will be reused for "qemu" namespace in following patches. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 86 +---

[Qemu-devel] [PATCH v4 2/6] nbd/server: refactor NBDExportMetaContexts

2018-06-08 Thread Vladimir Sementsov-Ogievskiy
Use NBDExport pointer instead of just export name: there no needs to store duplicated name in the struct, moreover, NBDExport will be used further. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff -

[Qemu-devel] [PATCH v4 5/6] qapi: new qmp command nbd-server-add-bitmap

2018-06-08 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block.json | 23 +++ blockdev-nbd.c | 23 +++ 2 files changed, 46 insertions(+) diff --git a/qapi/block.json b/qapi/block.json index c694524002..ddbca2e286 100644 --- a/qapi/block.json +++ b/qapi/block.

[Qemu-devel] [PATCH v4 6/6] docs/interop: add nbd.txt

2018-06-08 Thread Vladimir Sementsov-Ogievskiy
Describe new metadata namespace: "qemu". Signed-off-by: Vladimir Sementsov-Ogievskiy --- docs/interop/nbd.txt | 37 + MAINTAINERS | 1 + 2 files changed, 38 insertions(+) create mode 100644 docs/interop/nbd.txt diff --git a/docs/interop/nbd.txt b/d

[Qemu-devel] [PATCH v4 1/6] nbd/server: fix trace

2018-06-08 Thread Vladimir Sementsov-Ogievskiy
Return code = 1 doesn't mean that we parsed base:allocation. Use correct traces in both -parsed and -skipped cases. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/nbd/server.c b/nbd/server.c index 9e1f2271

[Qemu-devel] [PATCH v4 0/6] NBD export

2018-06-08 Thread Vladimir Sementsov-Ogievskiy
Hi all. This is a proposal and realization of new NBD meta context: qemu. New possible queries will look like: qemu:dirty-bitmap: Mapping from export-bitmap-name to BdrvDirtyBitmap is done through qmp command nbd-server-add-bitmap. For now, only one bitmap export is allowed per NBD export, howev

[Qemu-devel] [PATCH] throttle: Fix crash on reopen

2018-06-08 Thread Alberto Garcia
The throttle block filter can be reopened, and with this it is possible to change the throttle group that the filter belongs to. The way the code does that is the following: - On throttle_reopen_prepare(): create a new ThrottleGroupMember and attach it to the new throttle group. - On thr

Re: [Qemu-devel] [PATCH v4 04/14] pc: prepare for multi stage hotplug handlers

2018-06-08 Thread Michael S. Tsirkin
On Fri, Jun 08, 2018 at 03:07:53PM +0200, David Hildenbrand wrote: > On 08.06.2018 14:55, Michael S. Tsirkin wrote: > > On Fri, Jun 08, 2018 at 02:32:09PM +0200, David Hildenbrand wrote: > >> > > if (TYPE_PC_DIMM) { > > pc_dimm_plug() > > /* do here additional concrete machine s

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 11:55:59AM -0300, Eduardo Habkost wrote: > On Fri, Jun 08, 2018 at 03:37:47PM +0100, Daniel P. Berrangé wrote: > > On Fri, Jun 08, 2018 at 11:30:26AM -0300, Eduardo Habkost wrote: > > > All of the supported build platforms documented in qemu-doc.texi > > > should already sup

Re: [Qemu-devel] [PATCH 00/11] misc: Add trailing '\n' to qemu_log() calls

2018-06-08 Thread John Snow
On 06/08/2018 06:54 AM, Peter Maydell wrote: > On 6 June 2018 at 20:43, John Snow wrote: >> so error_setg must be used WITHOUT \n and logging must happen with \n? >> >> If we're sure that's the way we want to have things laid out, we really >> ought to augment checkpatch to catch this -- becaus

Re: [Qemu-devel] Cortex M0 emulation tasks

2018-06-08 Thread Stefan Hajnoczi
On Mon, May 28, 2018 at 3:26 PM, Stefan Hajnoczi wrote: > Tasks: > > D3.3 Instruction Support > D3.5.1 Alignment support Julia and I have discussed these two tasks and she will work on them. I will implement an undefined instruction test case that verifies that all undefined instructions do inde

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 11:30:26AM -0300, Eduardo Habkost wrote: > All of the supported build platforms documented in qemu-doc.texi > should already support Python 2.7. > > Removing support for Python 2.6 will allow us to remove some > compatibility modules we carry in the QEMU tree: > > * script

Re: [Qemu-devel] [PATCH v2 1/4] hw/block/fdc: Replace error_setg(&error_abort) by assert()

2018-06-08 Thread John Snow
On 06/08/2018 02:05 AM, Markus Armbruster wrote: > John Snow writes: > >> On 06/07/2018 10:46 AM, Philippe Mathieu-Daudé wrote: >>> Use assert() instead of error_setg(&error_abort), >>> as suggested by the "qapi/error.h" documentation: >>> >>> Please don't error_setg(&error_fatal, ...), us

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Eduardo Habkost
On Fri, Jun 08, 2018 at 11:30:26AM -0300, Eduardo Habkost wrote: > All of the supported build platforms documented in qemu-doc.texi > should already support Python 2.7. > > Removing support for Python 2.6 will allow us to remove some > compatibility modules we carry in the QEMU tree: > > * script

Re: [Qemu-devel] [qemu PATCH 1/5] gitignore: ignore generated qapi job files

2018-06-08 Thread Eric Blake
On 06/08/2018 09:59 AM, Eric Blake wrote: On 06/07/2018 05:31 PM, Ross Zwisler wrote: With a fully built QEMU I currently see the following with "git status":    Untracked files: (use "git add ..." to include in what will be committed)    qapi/qapi-commands-job.c    qapi/qapi-comm

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Philippe Mathieu-Daudé
On 06/08/2018 11:40 AM, Daniel P. Berrangé wrote: > On Fri, Jun 08, 2018 at 11:37:36AM -0300, Philippe Mathieu-Daudé wrote: >> Cc'ing Eric >> >> On 06/08/2018 11:30 AM, Eduardo Habkost wrote: >>> All of the supported build platforms documented in qemu-doc.texi >>> should already support Python 2.7.

Re: [Qemu-devel] [qemu PATCH 1/5] gitignore: ignore generated qapi job files

2018-06-08 Thread Eric Blake
On 06/07/2018 05:31 PM, Ross Zwisler wrote: With a fully built QEMU I currently see the following with "git status": Untracked files: (use "git add ..." to include in what will be committed) qapi/qapi-commands-job.c qapi/qapi-commands-job.h qapi/qapi-events-job.c

Re: [Qemu-devel] [RFC v2 05/12] vhost-user: split vhost_user_read()

2018-06-08 Thread Philippe Mathieu-Daudé
On 06/01/2018 01:27 PM, Marc-André Lureau wrote: > Split vhost_user_read(), so only header can be read with > vhost_user_read_header(). > > Signed-off-by: Marc-André Lureau > --- > hw/virtio/vhost-user.c | 27 +++ > 1 file changed, 19 insertions(+), 8 deletions(-) > > di

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Eduardo Habkost
On Fri, Jun 08, 2018 at 03:37:47PM +0100, Daniel P. Berrangé wrote: > On Fri, Jun 08, 2018 at 11:30:26AM -0300, Eduardo Habkost wrote: > > All of the supported build platforms documented in qemu-doc.texi > > should already support Python 2.7. > > > > Removing support for Python 2.6 will allow us t

Re: [Qemu-devel] [RFC v2 03/12] vhost-user: wrap some read/write with retry handling

2018-06-08 Thread Philippe Mathieu-Daudé
On 06/01/2018 01:27 PM, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé > --- > hw/virtio/vhost-user.c | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c > in

Re: [Qemu-devel] [RFC v2 01/12] chardev: avoid crash if no associated address

2018-06-08 Thread Philippe Mathieu-Daudé
On 06/01/2018 01:27 PM, Marc-André Lureau wrote: > A socket chardev may not have associated address (when adding client > fd manually for example). But on disconnect, updating socket filename > expects an address and may lead to this crash: > > Thread 1 "qemu-system-x86" received signal SIGSEGV,

[Qemu-devel] [Bug 1708462] Re: Support Python 3 to build

2018-06-08 Thread Eduardo Habkost
The series mentioned in comment #3 was merged in v2.12.0, see commit c21965a0c8b979c306e927f158257e5b0fa3a1f9. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launch

Re: [Qemu-devel] [PATCH v3 1/3] util: remove redundant include of glib.h and add osdep.h

2018-06-08 Thread Eric Blake
On 06/08/2018 08:16 AM, Daniel P. Berrangé wrote: Code must only ever include glib.h indirectly via the glib-compat.h header file, because we will need some macros set before glib.h is pulled in. Adding extra includes of glib.h will (soon) cause compile failures such as: In file included from /h

Re: [Qemu-devel] [RFC v2 02/12] libvhost-user: exit by default on VHOST_USER_NONE

2018-06-08 Thread Philippe Mathieu-Daudé
On 06/01/2018 01:27 PM, Marc-André Lureau wrote: > Since commit 2566378d6d13bf4d28c7770bdbda5f7682594bbe, libvhost-user > no longer panics on disconnect (rc == 0), and instead silently ignores > an invalid VHOST_USER_NONE message. > > Without extra work from the API user, this will simply busy-loo

Re: [Qemu-devel] [PATCH RFC 2/2] vfio-ccw: support for halt/clear subchannel

2018-06-08 Thread Cornelia Huck
On Fri, 8 Jun 2018 15:13:28 +0200 Halil Pasic wrote: > On 06/08/2018 02:20 PM, Cornelia Huck wrote: > >>> My proposal is to do the same > >>> copying to scsw(r) again, which would mean we get a request with both > >>> the halt and the start bit set. The vfio code now needs to do a hsch > >>> (ins

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 0/7] sdcard: cleanup the SD_SPEC version

2018-06-08 Thread Philippe Mathieu-Daudé
On 06/08/2018 09:14 AM, Peter Maydell wrote: > On 7 June 2018 at 19:06, Philippe Mathieu-Daudé wrote: >> Since v2: >> - heavy documentation improvements >> - squashed previous 3+4 "add spec_version property default to v2" for >> atomicity >> - SSI/SD patch downgraded to RFC >> - added Alistair R-

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 11:37:36AM -0300, Philippe Mathieu-Daudé wrote: > Cc'ing Eric > > On 06/08/2018 11:30 AM, Eduardo Habkost wrote: > > All of the supported build platforms documented in qemu-doc.texi > > should already support Python 2.7. > > https://lists.gnu.org/archive/html/qemu-devel/20

[Qemu-devel] [PATCH] hw/pvrdma: Bugfix - provide the correct attr_mask to query_qp

2018-06-08 Thread Yuval Shaia
Calling rdma_rm_query_qp with attr_mask equals to -1 leads to error where backend query_qp fails to retrieve the needed QP attributes. Fix it by providing the attr_mask we got from driver. Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_cmd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 delet

[Qemu-devel] [Bug 1463172] Re: destination arm board hangs after migration from x86 source

2018-06-08 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribe

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 11:30:26AM -0300, Eduardo Habkost wrote: > All of the supported build platforms documented in qemu-doc.texi > should already support Python 2.7. > > Removing support for Python 2.6 will allow us to remove some > compatibility modules we carry in the QEMU tree: > > * script

[Qemu-devel] [Bug 1463812] Re: qemu-system-ppc64 V2.30 cause RHEL5.9 disk corruption

2018-06-08 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribe

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Philippe Mathieu-Daudé
Cc'ing Eric On 06/08/2018 11:30 AM, Eduardo Habkost wrote: > All of the supported build platforms documented in qemu-doc.texi > should already support Python 2.7. https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg05173.html On 08/25/2017 11:40 AM, Peter Maydell wrote: > Our choices ab

[Qemu-devel] [Bug 1463909] Re: virtio: networking not working when guest's eth0 is not in promiscuous mode

2018-06-08 Thread Thomas Huth
** Project changed: qemu => qemu (Ubuntu) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1463909 Title: virtio: networking not working when guest's eth0 is not in promiscuous mode Status in qemu

Re: [Qemu-devel] [PULL 0/5] slirp updates

2018-06-08 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180608061316.4909-1-samuel.thiba...@ens-lyon.org Subject: [Qemu-devel] [PULL 0/5] slirp updates === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneli

[Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

2018-06-08 Thread Eduardo Habkost
All of the supported build platforms documented in qemu-doc.texi should already support Python 2.7. Removing support for Python 2.6 will allow us to remove some compatibility modules we carry in the QEMU tree: * scripts/argparse.py * scripts/ordereddict.py Python 2.6 is also not receiving bug fi

<    1   2   3   4   5   >