[Qemu-devel] [PULL 1/1] block: Ignore generated job QAPI files

2018-06-13 Thread Jeff Cody
From: Eric Blake Commit bf42508f introduced new generated files; make sure they don't get accidentally committed from an in-tree build. Signed-off-by: Eric Blake Reviewed-by: Jeff Cody Reviewed-by: Max Reitz Message-id: 20180531212435.165261-1-ebl...@redhat.com Signed-off-by: Jeff Cody ---

Re: [Qemu-devel] [PATCH v1 07/11] pc-dimm: get_memory_region() can never fail

2018-06-13 Thread David Hildenbrand
On 13.06.2018 16:07, David Hildenbrand wrote: > On 13.06.2018 15:03, Igor Mammedov wrote: >> On Mon, 11 Jun 2018 14:16:51 +0200 >> David Hildenbrand wrote: >> >>> We already verify when realizing that the memdev property has been >>> set. We have no more accesses to get_memory_region() before the

Re: [Qemu-devel] [RFC v2 1/3] pci_expander_bridge: add type TYPE_PXB_PCIE_HOST

2018-06-13 Thread Michael S. Tsirkin
On Wed, Jun 13, 2018 at 04:23:40PM +0800, Zihan Yang wrote: > Michael S. Tsirkin 于2018年6月12日周二 下午9:43写道: > > > > On Tue, Jun 12, 2018 at 05:13:22PM +0800, Zihan Yang wrote: > > > The inner host bridge created by pxb-pcie is TYPE_PXB_PCI_HOST by default, > > > add a new type TYPE_PXB_PCIE_HOST to

Re: [Qemu-devel] [PATCH 2/2] hw/arm/armv7m: Remove unused armv7m_init() function

2018-06-13 Thread Stefan Hajnoczi
On Fri, Jun 01, 2018 at 03:43:28PM +0100, Peter Maydell wrote: > Remove the now-unused armv7m_init() function. This was a legacy from > before we properly QOMified ARMv7M, and it has some flaws: > > * it combines work that needs to be done by an SoC object (creating >and initializing the

Re: [Qemu-devel] [PATCH] hw/i386: Fix IVHD entry length for AMD IOMMU

2018-06-13 Thread Jan Kiszka
On 2018-06-13 16:26, Michael S. Tsirkin wrote: > On Tue, May 22, 2018 at 09:06:56AM +0200, Jan Kiszka wrote: >> On 2018-03-29 14:51, Jan Kiszka wrote: >>> From: Jan Kiszka >>> >>> Counting from the IVHD ID field to the all-devices entry, we have 28 >>> bytes, not 36. >>> >>> Signed-off-by: Jan

Re: [Qemu-devel] [PATCH 1/2] stellaris: Stop using armv7m_init()

2018-06-13 Thread Stefan Hajnoczi
On Fri, Jun 01, 2018 at 03:43:27PM +0100, Peter Maydell wrote: > The stellaris board is still using the legacy armv7m_init() function, > which predates conversion of the ARMv7M into a proper QOM container > object. Make the board code directly create the ARMv7M object instead. > > Signed-off-by:

Re: [Qemu-devel] [PATCH] loader: implement START_SEG_ADDR_RECORD

2018-06-13 Thread Stefan Hajnoczi
On Tue, Jun 12, 2018 at 01:46:34PM +0800, Su Hang wrote: > > I do have time, the function mentioned in last comments isn't difficult to > implement, but I wonder how to write corresponding qtest-case for cortex-m3. > You > know, becuase #current# QEMU doesn't surpport the cortex-m3 instruction,

Re: [Qemu-devel] [PATCH] hw/i386: Fix IVHD entry length for AMD IOMMU

2018-06-13 Thread Michael S. Tsirkin
On Tue, May 22, 2018 at 09:06:56AM +0200, Jan Kiszka wrote: > On 2018-03-29 14:51, Jan Kiszka wrote: > > From: Jan Kiszka > > > > Counting from the IVHD ID field to the all-devices entry, we have 28 > > bytes, not 36. > > > > Signed-off-by: Jan Kiszka > > --- > > hw/i386/acpi-build.c | 2 +- >

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] jobs: minor doc fixups

2018-06-13 Thread Kevin Wolf
Am 07.06.2018 um 01:02 hat John Snow geschrieben: > One is from my manual completion series, > the other is from the recent refactor. Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [libvirt] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig

2018-06-13 Thread Daniel P . Berrangé
On Wed, Jun 13, 2018 at 11:17:30AM -0300, Eduardo Habkost wrote: > On Tue, Jun 12, 2018 at 01:50:33PM +0100, Daniel P. Berrangé wrote: > > On Tue, Jun 12, 2018 at 02:42:05PM +0200, Igor Mammedov wrote: > > > We can keep daemonizing flow in QEMU as it's now. > > > But Eduardo's idea about libvirt

Re: [Qemu-devel] [PATCH] monitor: postpone monitor_qmp_cleanup_queues

2018-06-13 Thread Stefan Hajnoczi
On Tue, Jun 12, 2018 at 01:47:00PM +0800, Peter Xu wrote: > On Mon, Jun 11, 2018 at 05:45:49PM +0100, Stefan Hajnoczi wrote: > > On Fri, Jun 08, 2018 at 10:18:25AM +0200, Markus Armbruster wrote: > > > Stefan Hajnoczi writes: > > > > On Fri, Jun 08, 2018 at 12:42:35PM +0800, Peter Xu wrote: > > >

Re: [Qemu-devel] [PATCH v5 04/10] migration: implement bi-directional RDMA QIOChannel

2018-06-13 Thread Dr. David Alan Gilbert
* Lidong Chen (jemmy858...@gmail.com) wrote: > From: Lidong Chen > > This patch implements bi-directional RDMA QIOChannel. Because different > threads may access RDMAQIOChannel currently, this patch use RCU to protect it. > > Signed-off-by: Lidong Chen Paolo: Does it make sense the way RCU is

Re: [Qemu-devel] [PATCH 3/3] target/ppc: filter out non-zero PCR values when using TCG

2018-06-13 Thread Greg Kurz
On Wed, 13 Jun 2018 22:05:02 +1000 David Gibson wrote: > On Wed, Jun 13, 2018 at 10:19:15AM +0200, Greg Kurz wrote: > > On Wed, 13 Jun 2018 10:45:06 +1000 > > David Gibson wrote: > > > > > On Tue, Jun 12, 2018 at 07:04:15PM +0200, Greg Kurz wrote: > > > > Bits set in the PCR disable

Re: [Qemu-devel] [PATCH v2] exec: Fix MAP_RAM for cached access

2018-06-13 Thread Auger Eric
Hi Paolo, On 06/13/2018 03:53 PM, Paolo Bonzini wrote: > On 13/06/2018 15:44, Auger Eric wrote: >>> Queuing this patch. I'm not sure how I missed this, I have actually >>> tested it with SMMU. >> no problem. Strange also I was the only one facing the issue. > > No, I must have blundered it

Re: [Qemu-devel] [PATCH v5 09/10] migration: poll the cm event while wait RDMA work request completion

2018-06-13 Thread Dr. David Alan Gilbert
* Lidong Chen (jemmy858...@gmail.com) wrote: > If the peer qemu is crashed, the qemu_rdma_wait_comp_channel function > maybe loop forever. so we should also poll the cm event fd, and when > receive RDMA_CM_EVENT_DISCONNECTED and RDMA_CM_EVENT_DEVICE_REMOVAL, > we consider some error happened. > >

Re: [Qemu-devel] [PATCH 3/3] block: Remove deprecated -drive option serial

2018-06-13 Thread Markus Armbruster
Kevin Wolf writes: > The -drive option serial was deprecated in QEMU 2.10. It's time to > remove it. > > Tests need to be updated to set the serial number with -global instead > of using the -drive option. > > Signed-off-by: Kevin Wolf > --- > include/hw/block/block.h | 1 - >

Re: [Qemu-devel] [PATCH v2] cpu hot-del: leak fix by free the relevant members

2018-06-13 Thread Igor Mammedov
On Wed, 13 Jun 2018 13:15:37 + "liujunjie (A)" wrote: > Hi > > > -Original Message- > > From: Igor Mammedov [mailto:imamm...@redhat.com] > > Sent: Tuesday, June 12, 2018 9:40 PM > > To: liujunjie (A) > > Cc: pbonz...@redhat.com; r...@twiddle.net; crosthwaite.pe...@gmail.com; > >

Re: [Qemu-devel] [libvirt] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig

2018-06-13 Thread Eduardo Habkost
On Tue, Jun 12, 2018 at 01:50:33PM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 12, 2018 at 02:42:05PM +0200, Igor Mammedov wrote: > > We can keep daemonizing flow in QEMU as it's now. > > But Eduardo's idea about libvirt created socked + letting QEMU connect to it > > has a merit. It should fix

Re: [Qemu-devel] [PATCH v1 10/11] pc-dimm: introduce and use pc_dimm_memory_pre_plug()

2018-06-13 Thread David Hildenbrand
On 13.06.2018 15:10, Igor Mammedov wrote: > On Mon, 11 Jun 2018 14:16:54 +0200 > David Hildenbrand wrote: > >> We'll be factoring out some pc-dimm specific and some memory-device >> checks next. >> >> Signed-off-by: David Hildenbrand >> --- >> hw/i386/pc.c | 2 ++ >>

Re: [Qemu-devel] [RFC PATCH 1/1] nvdimm: let qemu requiring section alignment of pmem resource.

2018-06-13 Thread Stefan Hajnoczi
On Tue, Jun 12, 2018 at 11:04:25PM +0800, Haozhong Zhang wrote: > On 06/11/18 19:55, Dan Williams wrote: > > On Mon, Jun 11, 2018 at 9:26 AM, Stefan Hajnoczi > > wrote: > > > On Mon, Jun 11, 2018 at 06:54:25PM +0800, Zhang Yi wrote: > > >> Nvdimm driver use Memory hot-plug APIs to map it's pmem

Re: [Qemu-devel] [PATCH] Remove COPYING.PYTHON

2018-06-13 Thread Stefan Hajnoczi
On Mon, Jun 11, 2018 at 03:01:52PM -0300, Eduardo Habkost wrote: > The COPYING.PYTHON file was added when we added the compatibility > argparse.py module, which was licensed under the Python Software > Foundation License Version 2. > > Now the compatibility argparse.py module was removed, and we

Re: [Qemu-devel] [PATCH 1/4] Replace '-machine accel=xyz' with '-accel xyz'

2018-06-13 Thread Thomas Huth
On 13.06.2018 15:54, Paolo Bonzini wrote: > On 13/06/2018 14:53, Thomas Huth wrote: >> On 13.06.2018 14:48, Paolo Bonzini wrote: >>> On 13/06/2018 07:05, Thomas Huth wrote: diff --git a/tests/vmgenid-test.c b/tests/vmgenid-test.c index 8d915c6..4324034 100644 ---

Re: [Qemu-devel] [PATCH] tracing.txt: add missing '-' for trace option

2018-06-13 Thread Yaowei Bai
On Wed, Jun 13, 2018 at 06:27:49AM -0500, Eric Blake wrote: > On 06/12/2018 10:50 PM, Emilio G. Cota wrote: > >On Tue, Jun 12, 2018 at 23:15:49 -0400, Yaowei Bai wrote: > >>Signed-off-by: Yaowei Bai > >>--- > >> docs/devel/tracing.txt | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [Qemu-devel] [PATCH 1/2] hw/mips/jazz: create ESP device directly via qdev

2018-06-13 Thread Paolo Bonzini
On 13/06/2018 15:06, Mark Cave-Ayland wrote: >> >> Heh, those are disgusting indeed. :)  So I guess it would have to stay, >> only MIPS can use the pure MemoryRegion-based approach. > > The only option I can think of is inserting an AddressSpace between the > esp/ledma device and the IOMMU

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 5/8] hw/timer: Add basic M41T80 emulation

2018-06-13 Thread BALATON Zoltan
On Wed, 13 Jun 2018, David Gibson wrote: On Wed, Jun 13, 2018 at 10:50:59AM +0200, BALATON Zoltan wrote: On Wed, 13 Jun 2018, David Gibson wrote: On Wed, Jun 06, 2018 at 07:35:28PM +0200, BALATON Zoltan wrote: On Wed, 6 Jun 2018, Philippe Mathieu-Daudé wrote: On 06/06/2018 10:31 AM, BALATON

Re: [Qemu-devel] [PATCH v1 00/11] pc-dimm: next bunch of cleanups

2018-06-13 Thread David Hildenbrand
On 13.06.2018 15:34, Igor Mammedov wrote: > On Mon, 11 Jun 2018 14:16:44 +0200 > David Hildenbrand wrote: > >> This is another set of cleanups as the result from >> [PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers >> And is based on the two series >> [PATCH v1 0/2] memory:

[Qemu-devel] Questions about qemu enabling TCI (tcg/tci.c)

2018-06-13 Thread yt zhang
Dear technicians, Good day. I encountered some difficulties in learning about the TCI part of QEMU. When I use the following configuration command to enable TCI: "configure --enable-tcg-interpreter" Run the command as: "qemu-x86_64 hello-one" (hello-one is my own executable

Re: [Qemu-devel] [PATCH v2 01/10] qapi: Add default-variant for flat unions

2018-06-13 Thread Max Reitz
On 2018-06-12 17:25, Markus Armbruster wrote: > Max Reitz writes: > >> This patch allows specifying a discriminator that is an optional member >> of the base struct. In such a case, a default value must be provided >> that is used when no value is given. > > Hmm. Can you explain why you need

Re: [Qemu-devel] [PATCH v1 07/11] pc-dimm: get_memory_region() can never fail

2018-06-13 Thread David Hildenbrand
On 13.06.2018 15:03, Igor Mammedov wrote: > On Mon, 11 Jun 2018 14:16:51 +0200 > David Hildenbrand wrote: > >> We already verify when realizing that the memdev property has been >> set. We have no more accesses to get_memory_region() before the device >> is realized. > this stems from assumption

Re: [Qemu-devel] [PATCH] target/arm: Allow ARMv6-M Thumb2 instructions

2018-06-13 Thread Stefan Hajnoczi
On Tue, Jun 12, 2018 at 11:46:32PM +0300, Julia Suvorova wrote: > ARMv6-M supports 6 Thumb2 instructions. This patch checks for these > instructions and allows their execution. > Like Thumb2 cores, ARMv6-M always interprets BL instruction as 32-bit. > > This patch is required for future Cortex-M0

Re: [Qemu-devel] [PATCH 2/3] block: Remove deprecated -drive option addr

2018-06-13 Thread Markus Armbruster
Kevin Wolf writes: > The -drive option addr was deprecated in QEMU 2.10. It's time to remove > it. > > Signed-off-by: Kevin Wolf One of my first additions to QEMU... and a bit of an embarrassment. Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v1 06/11] pc-dimm: don't allow to access "size" before the device was realized

2018-06-13 Thread David Hildenbrand
On 13.06.2018 14:56, Igor Mammedov wrote: > On Mon, 11 Jun 2018 14:16:50 +0200 > David Hildenbrand wrote: > >> "size" should not be queried before the device was realized. Let' make >> that explicit. >> >> Signed-off-by: David Hildenbrand > It's generic property getter, it should work even

Re: [Qemu-devel] [PATCH v2 3/8] ppc4xx_i2c: Implement directcntl register

2018-06-13 Thread BALATON Zoltan
On Wed, 13 Jun 2018, David Gibson wrote: On Wed, Jun 13, 2018 at 10:54:22AM +0200, BALATON Zoltan wrote: On Wed, 13 Jun 2018, David Gibson wrote: On Wed, Jun 06, 2018 at 03:31:48PM +0200, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan --- default-configs/ppc-softmmu.mak| 1 +

Re: [Qemu-devel] [PATCH 1/3] block: Remove deprecated -drive geometry options

2018-06-13 Thread Markus Armbruster
Kevin Wolf writes: > The -drive options cyls, heads, secs and trans were deprecated in > QEMU 2.10. It's time to remove them. > > hd-geo-test tested both the old version with geometry options in -drive > and the new one with -device. Therefore the code using -drive doesn't > have to be replaced

Re: [Qemu-devel] [PATCH v1 05/11] spapr: move memory hotplug size check into plug code

2018-06-13 Thread Igor Mammedov
On Wed, 13 Jun 2018 13:05:53 +0200 David Hildenbrand wrote: > On 13.06.2018 13:01, Igor Mammedov wrote: > > On Mon, 11 Jun 2018 14:16:49 +0200 > > David Hildenbrand wrote: > > > >> This might look like a step backwards, but it is not. get_memory_region() > >> should not be called on

Re: [Qemu-devel] [PATCH 1/4] Replace '-machine accel=xyz' with '-accel xyz'

2018-06-13 Thread Paolo Bonzini
On 13/06/2018 14:53, Thomas Huth wrote: > On 13.06.2018 14:48, Paolo Bonzini wrote: >> On 13/06/2018 07:05, Thomas Huth wrote: >>> diff --git a/tests/vmgenid-test.c b/tests/vmgenid-test.c >>> index 8d915c6..4324034 100644 >>> --- a/tests/vmgenid-test.c >>> +++ b/tests/vmgenid-test.c >>> @@ -131,7

Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-13 Thread Daniel P . Berrangé
On Wed, Jun 13, 2018 at 10:47:45AM -0300, Eduardo Habkost wrote: > On Tue, Jun 12, 2018 at 09:49:14AM +0100, Dr. David Alan Gilbert wrote: > [...] > > > > People have been trying to add qom-get etc for quite a while (I tried a > > > > couple of years ago); it gets stuck in type display issues.

Re: [Qemu-devel] [PATCH v2] exec: Fix MAP_RAM for cached access

2018-06-13 Thread Paolo Bonzini
On 13/06/2018 15:44, Auger Eric wrote: >> Queuing this patch. I'm not sure how I missed this, I have actually >> tested it with SMMU. > no problem. Strange also I was the only one facing the issue. No, I must have blundered it between testing and posting the patches. >> Do you also need the

Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-13 Thread Eduardo Habkost
On Tue, Jun 12, 2018 at 09:49:14AM +0100, Dr. David Alan Gilbert wrote: [...] > > > People have been trying to add qom-get etc for quite a while (I tried a > > > couple of years ago); it gets stuck in type display issues. I've not > > > directly seen a need for those other variants, but qom-get

Re: [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore

2018-06-13 Thread Daniel P . Berrangé
On Wed, Jun 13, 2018 at 02:38:40PM +0100, Stefan Hajnoczi wrote: > On Wed, Jun 13, 2018 at 07:05:21AM +0200, Thomas Huth wrote: > > We've got three ways of enabling an accelerator: -machine accel=xyz, > > -accel xyz and -enable-xyz. For new QEMU users, this must be very > > confusing ("Which one

Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

2018-06-13 Thread Eduardo Habkost
On Tue, Jun 12, 2018 at 09:00:20AM +0200, Markus Armbruster wrote: > Igor Mammedov writes: > > > On Mon, 11 Jun 2018 15:40:16 -0300 > > Eduardo Habkost wrote: > > > >> On Mon, Jun 11, 2018 at 02:01:52PM +0200, Markus Armbruster wrote: > >> > * Eduardo, why does "info numa" have no QMP

Re: [Qemu-devel] [PATCH v2] exec: Fix MAP_RAM for cached access

2018-06-13 Thread Auger Eric
Hi Paolo, On 06/13/2018 03:36 PM, Paolo Bonzini wrote: > On 13/06/2018 15:19, Eric Auger wrote: >> When an IOMMUMemoryRegion is in front of a virtio device, >> address_space_cache_init does not set cache->ptr as the memory >> region is not RAM. However when the device performs an access, >> we

Re: [Qemu-devel] [PATCH 3/4] qemu-options: Improve the documentation of '-accel' and '-machine accel=...'

2018-06-13 Thread Stefan Hajnoczi
On Wed, Jun 13, 2018 at 07:05:20AM +0200, Thomas Huth wrote: > Instead of repeating the same text for both options, let's rather change > the '-machine accel' documentation to point to the preferred '-accel' option > instead. > And in the documenation of the -accel option, make it clear that you

Re: [Qemu-devel] [PATCH 1/4] Replace '-machine accel=xyz' with '-accel xyz'

2018-06-13 Thread Stefan Hajnoczi
On Wed, Jun 13, 2018 at 07:05:18AM +0200, Thomas Huth wrote: > We've got a separate option to configure the accelerator nowadays. > Use it in the source and examples to demonstrate that this is the > preferred way of setting this option now. > > Signed-off-by: Thomas Huth > --- > qemu-doc.texi

Re: [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore

2018-06-13 Thread Stefan Hajnoczi
On Wed, Jun 13, 2018 at 07:05:21AM +0200, Thomas Huth wrote: > We've got three ways of enabling an accelerator: -machine accel=xyz, > -accel xyz and -enable-xyz. For new QEMU users, this must be very > confusing ("Which one do I have to use? Is there a difference between > the options?"). While

Re: [Qemu-devel] [PATCH 0/4] Clean up accelerator options

2018-06-13 Thread Stefan Hajnoczi
On Wed, Jun 13, 2018 at 07:05:17AM +0200, Thomas Huth wrote: > The current state of the accelerator options is quite messy: There are > three ways of enabling an accelerator (-machine accel=xyz, -accel xyz > and -enable-xyz) and this can be very confusing for the users. This > patch series now

Re: [Qemu-devel] [PATCH 2/4] Replace '-enable-kvm' with '-accel kvm' in docs and help texts

2018-06-13 Thread Stefan Hajnoczi
On Wed, Jun 13, 2018 at 07:05:19AM +0200, Thomas Huth wrote: > The preferred way to select the KVM accelerator is to use "-accel kvm" > these days, so let's be consistent in our documentation and help texts. > > Signed-off-by: Thomas Huth > --- > docs/COLO-FT.txt | 8 >

Re: [Qemu-devel] [PATCH v2] exec: Fix MAP_RAM for cached access

2018-06-13 Thread Paolo Bonzini
On 13/06/2018 15:19, Eric Auger wrote: > When an IOMMUMemoryRegion is in front of a virtio device, > address_space_cache_init does not set cache->ptr as the memory > region is not RAM. However when the device performs an access, > we end up in glue() which performs the translation and then uses >

Re: [Qemu-devel] [PATCH v1 00/11] pc-dimm: next bunch of cleanups

2018-06-13 Thread Igor Mammedov
On Mon, 11 Jun 2018 14:16:44 +0200 David Hildenbrand wrote: > This is another set of cleanups as the result from > [PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers > And is based on the two series > [PATCH v1 0/2] memory: fix alignment checks/asserts > [PATCH v2 0/6]

Re: [Qemu-devel] [PATCH 0/3] block: Remove deprecated -drive options

2018-06-13 Thread Cole Robinson
On 06/13/2018 08:34 AM, Kevin Wolf wrote: > We deprecated a bunch of -drive options in 2.10, so let's remove them > for 3.0. > > Kevin Wolf (3): > block: Remove deprecated -drive geometry options > block: Remove deprecated -drive option addr > block: Remove deprecated -drive option serial >

Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments

2018-06-13 Thread Stefan Hajnoczi
On Mon, Jun 11, 2018 at 03:17:16PM +0100, Peter Maydell wrote: > The codebase has a bit of a mix of different multiline > comment styles. State a preference for the Linux kernel > style: > /* > * Star on the left for each line. > * Leading slash-star and trailing star-slash > *

Re: [Qemu-devel] [PATCH] exec: Fix MAP_RAM for cached access

2018-06-13 Thread Auger Eric
Hi Paolo, On 06/13/2018 11:56 AM, Paolo Bonzini wrote: > On 12/06/2018 21:05, Eric Auger wrote: >> When an IOMMUMemoryRegion is in front of a virtio device, >> address_space_cache_init does not set cache->ptr as the memory >> region is not RAM. However when the device performs an access, >> we

[Qemu-devel] [PULL 1/3] Revert "Makefile: add target to print generated files"

2018-06-13 Thread Markus Armbruster
This reverts commit 9578f8cc3e8bd71de8e3f543dc7b95644d64824e. The patch snuck in by accident without having been posted to qemu-devel. It's entirely redundant: existing target print-% already serves the purpose. Cc: Michael S. Tsirkin Signed-off-by: Markus Armbruster Message-Id:

[Qemu-devel] [RISU PATCH v3 13/22] risu: move optional args to each architecture

2018-06-13 Thread Alex Bennée
The key variables here are: *arch_long_opts and *arch_extra_help. If they are not NULL then we concatenate the extra options to appropriate structure to enable the support. Adding architecture short options is not supported. This also includes moving the ARM specific test_fp_exc/test-fp-exc into

[Qemu-devel] [RISU PATCH v3 12/22] contrib/generate_all.sh: allow passing of arguments to risugen

2018-06-13 Thread Alex Bennée
This allows us to use any new risugen options when generating all our test patterns. Signed-off-by: Alex Bennée --- contrib/generate_all.sh | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/contrib/generate_all.sh b/contrib/generate_all.sh index

[Qemu-devel] [RISU PATCH v3 20/22] risu_reginfo_aarch64: add SVE support to reginfo_dump_mismatch

2018-06-13 Thread Alex Bennée
Signed-off-by: Alex Bennée --- v2 - include ffr in comparison - mild re-factor of preg cmp/diff v3 - re-factoring --- risu_reginfo_aarch64.c | 74 ++ 1 file changed, 74 insertions(+) diff --git a/risu_reginfo_aarch64.c b/risu_reginfo_aarch64.c

[Qemu-devel] [RISU PATCH v3 22/22] risu_reginfo_aarch64: handle variable VQ

2018-06-13 Thread Alex Bennée
This involves parsing the command line parameter and calling the kernel to set the VQ limit. We also add dumping of the register state in the main register dump. Signed-off-by: Alex Bennée --- risu_reginfo_aarch64.c | 164 + 1 file changed, 115

[Qemu-devel] [PATCH v2] exec: Fix MAP_RAM for cached access

2018-06-13 Thread Eric Auger
When an IOMMUMemoryRegion is in front of a virtio device, address_space_cache_init does not set cache->ptr as the memory region is not RAM. However when the device performs an access, we end up in glue() which performs the translation and then uses MAP_RAM. This latter uses the unset ptr and

Re: [Qemu-devel] [PATCH v1 10/11] pc-dimm: introduce and use pc_dimm_memory_pre_plug()

2018-06-13 Thread Igor Mammedov
On Mon, 11 Jun 2018 14:16:54 +0200 David Hildenbrand wrote: > We'll be factoring out some pc-dimm specific and some memory-device > checks next. > > Signed-off-by: David Hildenbrand > --- > hw/i386/pc.c | 2 ++ > hw/mem/pc-dimm.c | 5 + > hw/ppc/spapr.c | 1 +

[Qemu-devel] [RISU PATCH v3 21/22] risu_reginfo_aarch64: limit SVE_VQ_MAX to current architecture

2018-06-13 Thread Alex Bennée
From: Richard Henderson The kernel headers optimistically assume it's going to grow but as we are never going to use that many on current hardware we limit SVE_VQ_MAX to what we will. Signed-off-by: Richard Henderson Signed-off-by: Alex Bennée --- risu_reginfo_aarch64.h | 5 + 1 file

[Qemu-devel] [RISU PATCH v3 18/22] risu_reginfo_aarch64: left justify regnums and drop masks

2018-06-13 Thread Alex Bennée
Left justification is more pleasing to the eye than the default. We also drop the masking which isn't needed as we are casting to a smaller size anyway. This was split out of Richard's re-factoring work for SVE. Signed-off-by: Alex Bennée --- risu_reginfo_aarch64.c | 14 +++--- 1 file

Re: [Qemu-devel] [PATCH v2] cpu hot-del: leak fix by free the relevant members

2018-06-13 Thread liujunjie (A)
Hi > -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: Tuesday, June 12, 2018 9:40 PM > To: liujunjie (A) > Cc: pbonz...@redhat.com; r...@twiddle.net; crosthwaite.pe...@gmail.com; > linzhecheng ; Huangweidong (C) > ; wangxin (U) > ; qemu-devel@nongnu.org;

[Qemu-devel] [PULL 3/3] Purge uses of banned g_assert_FOO()

2018-06-13 Thread Markus Armbruster
We banned use of certain g_assert_FOO() functions outside tests, and made checkpatch.pl flag them (commit 6e9389563e5). We neglected to purge existing uses. Do that now. Signed-off-by: Markus Armbruster Message-Id: <20180608170231.27912-1-arm...@redhat.com> Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH 1/2] hw/mips/jazz: create ESP device directly via qdev

2018-06-13 Thread Mark Cave-Ayland
On 13/06/18 12:19, Paolo Bonzini wrote: On 13/06/2018 12:36, Mark Cave-Ayland wrote: Check out hw/dma/sparc32_dma.c for some ugly examples: espdma_memory_read()/espdma_memory_write() update the DMA address pointer register after each read/write, and ledma_memory_read()/ledma_memory_write()

[Qemu-devel] [PULL 2/3] coverity-model: replay data is considered trusted

2018-06-13 Thread Markus Armbruster
From: Paolo Bonzini Replay data is not considered a possible attack vector; add a model that does not use getc so that "tainted data" warnings are suppressed. Signed-off-by: Paolo Bonzini Message-Id: <20180514141218.28438-1-pbonz...@redhat.com> Reviewed-by: Markus Armbruster [Whitespace

Re: [Qemu-devel] [PATCH v1 07/11] pc-dimm: get_memory_region() can never fail

2018-06-13 Thread Igor Mammedov
On Mon, 11 Jun 2018 14:16:51 +0200 David Hildenbrand wrote: > We already verify when realizing that the memdev property has been > set. We have no more accesses to get_memory_region() before the device > is realized. this stems from assumption that get_memory_region shouldn't be called before

[Qemu-devel] [RISU PATCH v3 16/22] risu_reginfo_aarch64: unionify VFP regs

2018-06-13 Thread Alex Bennée
This is preparation for the SVE work as we won't want to be carrying around both VFP and SVE registers at the same time as they overlap. Signed-off-by: Alex Bennée --- risu_reginfo_aarch64.c | 16 risu_reginfo_aarch64.h | 9 - 2 files changed, 16 insertions(+), 9

[Qemu-devel] [PULL 0/3] Miscellaneous patches for 2018-06-13

2018-06-13 Thread Markus Armbruster
The following changes since commit 2ab09bf2f9f55b9fb8d2de6eb2ba2a8570e268e2: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20180612-pull-request' into staging (2018-06-12 15:34:34 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git

Re: [Qemu-devel] [PATCH v1 06/11] pc-dimm: don't allow to access "size" before the device was realized

2018-06-13 Thread Igor Mammedov
On Mon, 11 Jun 2018 14:16:50 +0200 David Hildenbrand wrote: > "size" should not be queried before the device was realized. Let' make > that explicit. > > Signed-off-by: David Hildenbrand It's generic property getter, it should work even before realize is called. if issues described in 5/11

[Qemu-devel] [RISU PATCH v3 14/22] risu: add process_arch_opt

2018-06-13 Thread Alex Bennée
From: Richard Henderson Allows the backend to do more that just set a flag when it comes to processing options. Signed-off-by: Richard Henderson [AJB: tweaked order, added stdlib includes] Signed-off-by: Alex Bennée --- risu.c | 33 +++-- risu.h

[Qemu-devel] [RISU PATCH v3 19/22] risu_reginfo_aarch64: add support for copying SVE register state

2018-06-13 Thread Alex Bennée
Add the ability to save SVE registers from the signal context. This is controlled with an optional flag --test-sve. The whole thing is conditionally compiled when SVE support is in the sigcontext headers. Signed-off-by: Alex Bennée --- v2 - support EXTRA_MAGIC contexts v3 - handle

[Qemu-devel] [RISU PATCH v3 11/22] risugen: add dtype_msz address helper

2018-06-13 Thread Alex Bennée
From: Richard Henderson Signed-off-by: Richard Henderson Signed-off-by: Alex Bennée --- risugen_arm.pm | 9 + 1 file changed, 9 insertions(+) diff --git a/risugen_arm.pm b/risugen_arm.pm index 696bf5f..8d423b1 100644 --- a/risugen_arm.pm +++ b/risugen_arm.pm @@ -765,6 +765,15 @@ sub

[Qemu-devel] [RISU PATCH v3 10/22] risugen: add reg_plus_imm_pl and reg_plus_imm_vl address helpers

2018-06-13 Thread Alex Bennée
From: Richard Henderson Signed-off-by: Alex Bennée --- risugen_arm.pm | 126 + 1 file changed, 126 insertions(+) diff --git a/risugen_arm.pm b/risugen_arm.pm index 485e94e..696bf5f 100644 --- a/risugen_arm.pm +++ b/risugen_arm.pm @@ -306,6

[Qemu-devel] [RISU PATCH v3 15/22] risu_reginfo_aarch64: drop stray ;

2018-06-13 Thread Alex Bennée
Signed-off-by: Alex Bennée --- risu_reginfo_aarch64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/risu_reginfo_aarch64.c b/risu_reginfo_aarch64.c index c270e0b..34dd9af 100644 --- a/risu_reginfo_aarch64.c +++ b/risu_reginfo_aarch64.c @@ -66,7 +66,7 @@ void

[Qemu-devel] [RISU PATCH v3 05/22] risu: add zlib indication to help text

2018-06-13 Thread Alex Bennée
This is a simple aide-memoir as it can be tricky to determine this with a simple statically compiled binary. Signed-off-by: Alex Bennée --- risu.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/risu.c b/risu.c index 616fc33..c684c90 100644 --- a/risu.c +++ b/risu.c @@

[Qemu-devel] [RISU PATCH v3 06/22] Makefile: include risu_reginfo_$(ARCH) in HDRS

2018-06-13 Thread Alex Bennée
Otherwise changes to reginfo don't cause the whole thing to be re-built causing much confusion when bisecting. Signed-off-by: Alex Bennée --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 16e48a0..4aad448 100644 --- a/Makefile +++

[Qemu-devel] [RISU PATCH v3 17/22] risu_reginfo: introduce reginfo_size()

2018-06-13 Thread Alex Bennée
In preparation for conditionally supporting SVE we need to be able to have different sized reginfos. This introduces reginfo_size() to abstract the size away to the code the actually knows. For aarch64 we also use this while initialising the block. Signed-off-by: Alex Bennée --- reginfo.c

[Qemu-devel] [RISU PATCH v3 09/22] risugen: use fewer insns for aarch64 immediate load

2018-06-13 Thread Alex Bennée
From: Richard Henderson Signed-off-by: Alex Bennée --- risugen_arm.pm | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/risugen_arm.pm b/risugen_arm.pm index 83e521d..485e94e 100644 --- a/risugen_arm.pm +++ b/risugen_arm.pm @@ -261,15

[Qemu-devel] [RISU PATCH v3 04/22] build-all-arches: do a distclean $(SRC) configured

2018-06-13 Thread Alex Bennée
This can cause much confusion when you have been building in your source tree. I've added a distclean so we don't unexpectedly drop the config for normal make clean invocations. Signed-off-by: Alex Bennée --- Makefile| 3 +++ build-all-archs | 10 ++ 2 files changed, 13

[Qemu-devel] [RISU PATCH v3 08/22] risugen: Initialize sve predicates with random data

2018-06-13 Thread Alex Bennée
From: Richard Henderson Using ptrue makes most of the uses of predicates trivial. Therefore, initialize them to something interesting. Signed-off-by: Richard Henderson Signed-off-by: Alex Bennée --- risugen_arm.pm | 48 ++-- 1 file changed, 34

[Qemu-devel] [RISU PATCH v3 01/22] risu_reginfo_aarch64: include signal.h for FPSIMD_MAGIC

2018-06-13 Thread Alex Bennée
Building with the Bionic Beaver cross compilers fails which probably means we were getting this as a side effect before. Include the correct header to get at these bits. Signed-off-by: Alex Bennée --- risu_reginfo_aarch64.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [RISU PATCH v3 00/22] SVE support and various misc fixes

2018-06-13 Thread Alex Bennée
Hi, The core concept of the code hasn't changed much but I've done some restructuring so we can still use an SVE enabled binary to run our existing tests without having to regenerate everything. I've folded a bunch of Richard's fixes into the relevant patches and also split some patches up that

[Qemu-devel] [RISU PATCH v3 07/22] risugen: add --sve support

2018-06-13 Thread Alex Bennée
This is similar to the approach used by the FP/simd data in so far as we generate a block of random data and then load into it. The loading is actually done by the current vector length but that is implicit in the run anyway. Signed-off-by: Alex Bennée --- v2 - only one SIMD/FP/SVE block as

[Qemu-devel] [RISU PATCH v3 03/22] build-all-arches: expand the range of docker images

2018-06-13 Thread Alex Bennée
We won't actually want power, we want ppc64el for the 64 bit version. Also we will soon have m68k so include that as well. Signed-off-by: Alex Bennée --- build-all-archs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-all-archs b/build-all-archs index fa2ac90..a2f5cff

[Qemu-devel] [RISU PATCH v3 02/22] comms: include header for writev

2018-06-13 Thread Alex Bennée
The compiler complains about implicit declarations otherwise. Signed-off-by: Alex Bennée --- comms.c | 1 + 1 file changed, 1 insertion(+) diff --git a/comms.c b/comms.c index 2900c33..6946fd9 100644 --- a/comms.c +++ b/comms.c @@ -17,6 +17,7 @@ #include #include #include +#include

Re: [Qemu-devel] [PATCH 1/4] Replace '-machine accel=xyz' with '-accel xyz'

2018-06-13 Thread Thomas Huth
On 13.06.2018 14:48, Paolo Bonzini wrote: > On 13/06/2018 07:05, Thomas Huth wrote: >> diff --git a/tests/vmgenid-test.c b/tests/vmgenid-test.c >> index 8d915c6..4324034 100644 >> --- a/tests/vmgenid-test.c >> +++ b/tests/vmgenid-test.c >> @@ -131,7 +131,7 @@ static void

Re: [Qemu-devel] [PATCH 2/4] Replace '-enable-kvm' with '-accel kvm' in docs and help texts

2018-06-13 Thread Paolo Bonzini
On 13/06/2018 07:05, Thomas Huth wrote: > The preferred way to select the KVM accelerator is to use "-accel kvm" > these days, so let's be consistent in our documentation and help texts. > > Signed-off-by: Thomas Huth > --- > docs/COLO-FT.txt | 8 > docs/can.txt

Re: [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore

2018-06-13 Thread Paolo Bonzini
On 13/06/2018 07:05, Thomas Huth wrote: > We've got three ways of enabling an accelerator: -machine accel=xyz, > -accel xyz and -enable-xyz. For new QEMU users, this must be very > confusing ("Which one do I have to use? Is there a difference between > the options?"). While -enable-kvm was useful

Re: [Qemu-devel] [PATCH 1/4] Replace '-machine accel=xyz' with '-accel xyz'

2018-06-13 Thread Paolo Bonzini
On 13/06/2018 07:05, Thomas Huth wrote: > diff --git a/tests/vmgenid-test.c b/tests/vmgenid-test.c > index 8d915c6..4324034 100644 > --- a/tests/vmgenid-test.c > +++ b/tests/vmgenid-test.c > @@ -131,7 +131,7 @@ static void read_guid_from_monitor(QemuUUID *guid) > static char disk[] =

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add an entry for qemu-options* files in main directory

2018-06-13 Thread Paolo Bonzini
On 13/06/2018 08:23, Markus Armbruster wrote: > >>> Do you think you could still be available as (co-)maintainer of that new >>> section? If not, who are going to be the maintainers of that new >>> section? Paolo? Eric? Daniel? ...? >> Well, currently it's going through me. I'd add vl.c too, by

[Qemu-devel] [PATCH 2/3] block: Remove deprecated -drive option addr

2018-06-13 Thread Kevin Wolf
The -drive option addr was deprecated in QEMU 2.10. It's time to remove it. Signed-off-by: Kevin Wolf --- include/sysemu/blockdev.h | 1 - blockdev.c| 17 + device-hotplug.c | 4 qemu-doc.texi | 5 - qemu-options.hx | 5

[Qemu-devel] [PATCH 3/3] block: Remove deprecated -drive option serial

2018-06-13 Thread Kevin Wolf
The -drive option serial was deprecated in QEMU 2.10. It's time to remove it. Tests need to be updated to set the serial number with -global instead of using the -drive option. Signed-off-by: Kevin Wolf --- include/hw/block/block.h | 1 - include/sysemu/blockdev.h | 1 -

Re: [Qemu-devel] [PATCH] s390x/cpumodels: add z14 Model ZR1

2018-06-13 Thread Cornelia Huck
On Wed, 13 Jun 2018 10:18:19 +0200 Christian Borntraeger wrote: > introduce the new z14 Model ZR1 cpu model. Mostly identical to z14, only > the cpu type differs (3906 vs. 3907) > > Signed-off-by: Christian Borntraeger > --- > target/s390x/cpu_models.c | 1 + > 1 file changed, 1 insertion(+)

[Qemu-devel] [PATCH 0/3] block: Remove deprecated -drive options

2018-06-13 Thread Kevin Wolf
We deprecated a bunch of -drive options in 2.10, so let's remove them for 3.0. Kevin Wolf (3): block: Remove deprecated -drive geometry options block: Remove deprecated -drive option addr block: Remove deprecated -drive option serial include/hw/block/block.h | 1 -

[Qemu-devel] [PATCH v5 1/4] hw/display: add ramfb, a simple boot framebuffer living in guest ram

2018-06-13 Thread Gerd Hoffmann
The boot framebuffer is expected to be configured by the firmware, so it uses fw_cfg as interface. Initialization goes as follows: (1) Check whenever etc/ramfb is present. (2) Allocate framebuffer from RAM. (3) Fill struct RAMFBCfg, write it to etc/ramfb. Done. You can write stuff to the

[Qemu-devel] [PATCH 1/3] block: Remove deprecated -drive geometry options

2018-06-13 Thread Kevin Wolf
The -drive options cyls, heads, secs and trans were deprecated in QEMU 2.10. It's time to remove them. hd-geo-test tested both the old version with geometry options in -drive and the new one with -device. Therefore the code using -drive doesn't have to be replaced there, we just need to remove

[Qemu-devel] [PATCH v5 3/4] hw/vfio/display: add ramfb support

2018-06-13 Thread Gerd Hoffmann
So we have a boot display when using a vgpu as primary display. Use vfio-pci-ramfb instead of vfio-pci to enable it. Signed-off-by: Gerd Hoffmann --- include/hw/vfio/vfio-common.h | 2 ++ hw/vfio/display.c | 12 hw/vfio/pci.c | 15 +++ 3

[Qemu-devel] [PATCH v5 2/4] hw/display: add standalone ramfb device

2018-06-13 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/hw/display/ramfb.h| 3 +++ hw/arm/sysbus-fdt.c | 7 + hw/arm/virt.c | 2 ++ hw/display/ramfb-standalone.c | 62 +++ hw/i386/pc_piix.c | 2 ++ hw/i386/pc_q35.c

Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments

2018-06-13 Thread Peter Maydell
On 12 June 2018 at 18:30, Richard Henderson wrote: > On 06/11/2018 04:17 AM, Peter Maydell wrote: >> The codebase has a bit of a mix of different multiline >> comment styles. State a preference for the Linux kernel >> style: >> /* >> * Star on the left for each line. >> * Leading

[Qemu-devel] [PATCH v5 4/4] Add ramfb MAINTAINERS entry

2018-06-13 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8a94517e9e..2401028766 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1331,6 +1331,12 @@ F: hw/display/bochs-display.c F: include/hw/display/vga.h F:

<    1   2   3   4   5   >