Re: [Qemu-devel] [PATCH v1 05/11] spapr: move memory hotplug size check into plug code

2018-06-14 Thread David Hildenbrand
On 13.06.2018 15:57, Igor Mammedov wrote: > On Wed, 13 Jun 2018 13:05:53 +0200 > David Hildenbrand wrote: > >> On 13.06.2018 13:01, Igor Mammedov wrote: >>> On Mon, 11 Jun 2018 14:16:49 +0200 >>> David Hildenbrand wrote: >>> This might look like a step backwards, but it is not. get_memor

[Qemu-devel] [Bug 1769189] Re: Issue with qemu 2.12.0 + SATA

2018-06-14 Thread Robert Hu
Hi, Where can I find the fix patch at present? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1769189 Title: Issue with qemu 2.12.0 + SATA Status in QEMU: Fix Committed Bug description: [EDIT:

Re: [Qemu-devel] [PATCH v2] pnv: add a physical mapping array describing MMIO ranges in each chip

2018-06-14 Thread Cédric Le Goater
On 06/14/2018 08:44 AM, David Gibson wrote: > On Wed, Jun 13, 2018 at 09:03:22AM +0200, Cédric Le Goater wrote: >> On 06/13/2018 02:47 AM, David Gibson wrote: >>> On Tue, Jun 12, 2018 at 08:13:49AM +0200, Cédric Le Goater wrote: On 06/12/2018 07:58 AM, David Gibson wrote: > On Wed, Jun 06,

Re: [Qemu-devel] [PATCH v4 1/2] qapi: allow empty branches in flat unions

2018-06-14 Thread Markus Armbruster
Anton Nefedov writes: > It often happens that just a few discriminator values imply extra data in > a flat union. Existing checks did not make possible to leave other values > uncovered. Such cases had to be worked around by either stating a dummy > (empty) type or introducing another (subset) di

Re: [Qemu-devel] [PATCH v2] exec: Fix MAP_RAM for cached access

2018-06-14 Thread Auger Eric
Hi Peter, On 06/14/2018 03:52 AM, Peter Xu wrote: > On Wed, Jun 13, 2018 at 04:20:34PM +0200, Auger Eric wrote: >> Hi Paolo, >> >> On 06/13/2018 03:53 PM, Paolo Bonzini wrote: >>> On 13/06/2018 15:44, Auger Eric wrote: > Queuing this patch. I'm not sure how I missed this, I have actually

Re: [Qemu-devel] [PATCH v4 2/2] qapi: remove empty flat union branches and types

2018-06-14 Thread Markus Armbruster
Anton Nefedov writes: > Flat unions may now have uncovered branches, so it is possible to get rid > of empty types defined for that purpose only. > > Signed-off-by: Anton Nefedov I observe a nice shrinking of generated code: qapi-doc.texi | 134 - qapi-introspect.c | 1124

Re: [Qemu-devel] [PATCH v3 2/9] ppc4xx_i2c: Implement directcntl register

2018-06-14 Thread BALATON Zoltan
On Thu, 14 Jun 2018, David Gibson wrote: On Thu, Jun 14, 2018 at 02:17:00AM +0200, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan Patch looks good, but it needs a commit message. What is the directcntl register? Now does the bitbang interface play into that? (Note that I know the answe

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 5/8] hw/timer: Add basic M41T80 emulation

2018-06-14 Thread BALATON Zoltan
On Thu, 14 Jun 2018, David Gibson wrote: On Wed, Jun 13, 2018 at 04:13:57PM +0200, BALATON Zoltan wrote: I don't see the problem. The addr register selects the register to read or write. It is set by the first write when the device is accessed the first time (this is denoted by addr == -1 (or re

[Qemu-devel] Error: virtio_net: Too few free TX rings available.

2018-06-14 Thread Bo YU
Hello, A am newbie to qemu. I am using qemu now: qemu-io --version qemu-io version 2.12.50 (v2.12.0-1296-g2ab09bf2f9-dirty) Copyright (c) 2003-2017 Fabrice Bellard and the QEMU Project developers I have to talk about using qemu with libvirt recently libvirt deadlocked when libvirt fetching qemu c

[Qemu-devel] [PATCH] hw/intc/arm_gicv3: fix an extra left-shift when reading IPRIORITYR

2018-06-14 Thread Amol Surati
When either GICD_IPRIORITYR or GICR_IPRIORITYR is read as a 32-bit register, the post left-shift operator in the for loop causes an extra shift after the least significant byte has been placed. The 32-bit value actually returned is therefore the expected value shifted left by 8 bits. Signed-off-b

Re: [Qemu-devel] [PATCH v3 8/9] sm501: Perform a full update after palette change

2018-06-14 Thread BALATON Zoltan
On Thu, 14 Jun 2018, David Gibson wrote: On Thu, Jun 14, 2018 at 02:17:00AM +0200, BALATON Zoltan wrote: From: Sebastian Bauer Signed-off-by: Sebastian Bauer Signed-off-by: BALATON Zoltan Commit message. Why is this necessary? Maybe because changing palette does not change display unles

Re: [Qemu-devel] [PATCH v3 9/9] target/ppc: Add missing opcode for icbt on PPC440

2018-06-14 Thread BALATON Zoltan
On Thu, 14 Jun 2018, David Gibson wrote: On Thu, Jun 14, 2018 at 02:17:00AM +0200, BALATON Zoltan wrote: Maybe amend commit message like this: According to PPC440 User Manual PPC440 has two opcodes for icbt, add the missing one. If you can do this when committing then please feel free to ad

[Qemu-devel] [PATCH v5.2 1/2] qga: add mountpoint usage info to GuestFilesystemInfo

2018-06-14 Thread Chen Hanxiao
From: Chen Hanxiao This patch adds support for getting the usage of mounted filesystem. The usage of fs stored as used_bytes and total_bytes. It's very useful when we try to monitor guest's filesystem. Cc: Michael Roth Cc: Daniel P. Berrangé Reviewed-by: Eric Blake Signed-off-by: Chen Hanxiao

[Qemu-devel] [PATCH v5.2 2/2] qga-win: add driver path usage to GuestFilesystemInfo

2018-06-14 Thread Chen Hanxiao
From: Chen Hanxiao This patch adds support for getting the usage of windows driver path. The usage of fs stored as used_bytes and total_bytes. Cc: Michael Roth Signed-off-by: Chen Hanxiao --- v2: unpack usage as used-bytes and total-bytes qga/commands-win32.c | 12 1 file chan

Re: [Qemu-devel] [PATCH v3 7/9] sm501: Implement i2c part for reading monitor EDID

2018-06-14 Thread BALATON Zoltan
On Thu, 14 Jun 2018, David Gibson wrote: On Thu, Jun 14, 2018 at 02:17:00AM +0200, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan Again needs a commit message expanding on what this is and why it's useful. What else need to be explained apart from that SM501 has an i2c part which is u

[Qemu-devel] [PATCH v5.2 0/2] qga: report the usage of fs in guests

2018-06-14 Thread Chen Hanxiao
This series report the usage of guest's fs by "used_bytes" and "total_bytes" in guest-get-fsinfo. Chen Hanxiao (2): qga: add mountpoint usage info to GuestFilesystemInfo qga-win: add driver path usage to GuestFilesystemInfo qga/commands-posix.c | 15 +++ qga/commands-win32.c | 12

Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

2018-06-14 Thread Daniel P . Berrangé
On Wed, Jun 13, 2018 at 03:05:08PM -0300, Eduardo Habkost wrote: > Getting back to this discussion: > > On Tue, Jun 05, 2018 at 09:43:00AM +0100, Daniel P. Berrangé wrote: > > On Tue, Jun 05, 2018 at 09:27:46AM +0200, Gerd Hoffmann wrote: > > > Hi, > > > > > > > > Add to that shortcuts like -

[Qemu-devel] [PATCH resend v2] qga: unset frozen state if no mount points are frozen

2018-06-14 Thread Chen Hanxiao
From: Chen Hanxiao If we set mountpoints to qmp_guest_fsfreeze_freeze_list, we may got nothing to freeze as all mountpoints are not valid. So call ga_unset_frozen in this senario. Also, if we return 0 frozen fs, there is no need to call guest-fsfreeze-thaw. Cc: Michael Roth Signed-off-by: Chen

Re: [Qemu-devel] Is there a way to package QEMU binaries?

2018-06-14 Thread Daniel P . Berrangé
On Thu, Jun 14, 2018 at 10:55:21AM +0800, Peter Xu wrote: > On Wed, Jun 13, 2018 at 10:28:09AM +0100, Daniel P. Berrangé wrote: > > On Wed, Jun 13, 2018 at 12:02:59PM +0800, Peter Xu wrote: > > > On Tue, Jun 12, 2018 at 09:52:45AM +0100, Peter Maydell wrote: > > > > On 12 June 2018 at 07:24, Peter

[Qemu-devel] [RFC v2] target/arm: add ARMv6-M UNDEFINED 32-bit instruction test

2018-06-14 Thread Stefan Hajnoczi
Test that 32-bit instructions declared UNDEFINED in the ARMv6-M Reference Manual really do raise an exception. Also test that the 6 32-bit instructions defined in the ARMv6-M Reference Manual do not raise an exception. The Intel HEX (.hex) file is included to save people the trouble of installing

Re: [Qemu-devel] [PATCH] target/arm: Allow ARMv6-M Thumb2 instructions

2018-06-14 Thread Stefan Hajnoczi
On Wed, Jun 13, 2018 at 08:10:23PM +0300, Julia Suvorova via Qemu-devel wrote: > On 13.06.2018 17:05, Stefan Hajnoczi wrote: > > On Tue, Jun 12, 2018 at 11:46:32PM +0300, Julia Suvorova wrote: > > > ARMv6-M supports 6 Thumb2 instructions. This patch checks for these > > > instructions and allows th

Re: [Qemu-devel] [PATCH v2 0/2] kvm: x86 CPU power management

2018-06-14 Thread Daniel P . Berrangé
On Tue, Jun 12, 2018 at 09:47:11PM +0300, Michael S. Tsirkin wrote: > This adds ability to expose host CPU power management capabilities to > guests. For intel guests, this is sufficient for guest to enable > low power CPU power management. For AMD guests it isn't sufficient, > deeper C-states are

Re: [Qemu-devel] [PATCH v3 1/9] ppc4xx_i2c: Remove unimplemented sdata and intr registers

2018-06-14 Thread BALATON Zoltan
On Thu, 14 Jun 2018, David Gibson wrote: On Thu, Jun 14, 2018 at 02:17:00AM +0200, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan But.. they are implemented. Albeit as an entirely software controlled register. They were implemented only in that they could be written and read but did

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-14 Thread Daniel P . Berrangé
On Wed, Jun 13, 2018 at 07:28:08PM +0200, Halil Pasic wrote: > > > On 06/13/2018 05:05 PM, Daniel P. Berrangé wrote: > > On Wed, Jun 13, 2018 at 11:01:05AM -0400, Farhan Ali wrote: > > > Hi Daniel > > > > > > On 06/13/2018 05:37 AM, Daniel P. Berrangé wrote: > > > > On Tue, Jun 12, 2018 at 03:48

Re: [Qemu-devel] [PATCH] ui: darwin: gtk: Add missing input keymap

2018-06-14 Thread Daniel P . Berrangé
On Wed, Jun 13, 2018 at 07:51:56PM -0400, Keno Fischer wrote: > In appears the input keymap for osx was forgotten in the commit that > converted the gtk frontend to keycodemapdb. Add it. > > Fixes: 2ec78706 ("ui: convert GTK and SDL1 frontends to keycodemapdb") > CC: Daniel P. Berrange > Signed-o

Re: [Qemu-devel] [PATCH] ui: darwin: gtk: Add missing input keymap

2018-06-14 Thread Daniel P . Berrangé
CC'ing Gerd as ui/ tree maintainer. On Thu, Jun 14, 2018 at 09:23:55AM +0100, Daniel P. Berrangé wrote: > On Wed, Jun 13, 2018 at 07:51:56PM -0400, Keno Fischer wrote: > > In appears the input keymap for osx was forgotten in the commit that > > converted the gtk frontend to keycodemapdb. Add it. >

Re: [Qemu-devel] [PATCH v4 3/3] hw/vfio/display: add ramfb support

2018-06-14 Thread Laszlo Ersek
On 06/14/18 00:36, Gerd Hoffmann wrote: > On Wed, Jun 13, 2018 at 01:50:47PM -0600, Alex Williamson wrote: >> I suppose in the UEFI case runtime services can be used to continue >> writing this display, > > Yes. Small clarification for the wording -- "UEFI runtime services" do not include anythi

[Qemu-devel] [PULL 0/2] Ui 20180614 patches

2018-06-14 Thread Gerd Hoffmann
The following changes since commit 2ab09bf2f9f55b9fb8d2de6eb2ba2a8570e268e2: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20180612-pull-request' into staging (2018-06-12 15:34:34 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-20180614-pu

[Qemu-devel] [PULL 1/2] ui: darwin: gtk: Add missing input keymap

2018-06-14 Thread Gerd Hoffmann
From: Keno Fischer In appears the input keymap for osx was forgotten in the commit that converted the gtk frontend to keycodemapdb. Add it. Fixes: 2ec78706 ("ui: convert GTK and SDL1 frontends to keycodemapdb") CC: Daniel P. Berrange Signed-off-by: Keno Fischer Message-id: 1528933916-40670-1-g

Re: [Qemu-devel] [RISU PATCH v3 05/22] risu: add zlib indication to help text

2018-06-14 Thread Alex Bennée
Richard Henderson writes: > On 06/13/2018 02:55 AM, Alex Bennée wrote: >> This is a simple aide-memoir as it can be tricky to determine this >> with a simple statically compiled binary. >> >> Signed-off-by: Alex Bennée >> --- >> risu.c | 5 - >> 1 file changed, 4 insertions(+), 1 deletion

[Qemu-devel] [PULL 2/2] sdl2: restore window dimensions by resize

2018-06-14 Thread Gerd Hoffmann
From: Amadeusz Sławiński instead of destroying and recreating window, fixes segfault caused by handle_keyup trying to access no more existing window when using Ctrl-Alt-U to restore window "un-scaled" dimensions Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. [Switching

Re: [Qemu-devel] [PATCH 0/4] Fix usb-ccid hotplug regression

2018-06-14 Thread Gerd Hoffmann
On Wed, Jun 13, 2018 at 06:18:19PM +0200, Paolo Bonzini wrote: > On 31/05/2018 21:51, Marc-André Lureau wrote: > > Hi, > > > > The following series fixes the usb-ccid hotplug regression introduced > > by commit 675f22c6d3b0: the plugged device is not completely removed > > on device_del anymore, d

Re: [Qemu-devel] [RFC v2] target/arm: add ARMv6-M UNDEFINED 32-bit instruction test

2018-06-14 Thread Alex Bennée
Stefan Hajnoczi writes: > Test that 32-bit instructions declared UNDEFINED in the ARMv6-M > Reference Manual really do raise an exception. Also test that the 6 > 32-bit instructions defined in the ARMv6-M Reference Manual do not raise > an exception. > > The Intel HEX (.hex) file is included t

Re: [Qemu-devel] [PATCH 12/18] block-qdict: Clean up qdict_crumple() a bit

2018-06-14 Thread Kevin Wolf
Am 13.06.2018 um 17:23 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 12.06.2018 um 14:58 hat Markus Armbruster geschrieben: > >> When you mix scalar and non-scalar keys, whether you get an "already > >> set as scalar" or an "already set as dict" error depends on qdict > >> iter

Re: [Qemu-devel] [PATCH V8 11/17] qapi: Add new command to query colo status

2018-06-14 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Zhang Chen (zhangc...@gmail.com) wrote: >> On Mon, Jun 11, 2018 at 2:48 PM, Markus Armbruster >> wrote: >> >> > Zhang Chen writes: >> > >> > > On Thu, Jun 7, 2018 at 8:59 PM, Markus Armbruster >> > > wrote: >> > > >> > >> Zhang Chen writes: >> > >> >> >

Re: [Qemu-devel] [PATCH 12/18] block-qdict: Clean up qdict_crumple() a bit

2018-06-14 Thread Daniel P . Berrangé
On Thu, Jun 14, 2018 at 10:40:58AM +0200, Kevin Wolf wrote: > Am 13.06.2018 um 17:23 hat Markus Armbruster geschrieben: > > Kevin Wolf writes: > > > > > Am 12.06.2018 um 14:58 hat Markus Armbruster geschrieben: > > >> When you mix scalar and non-scalar keys, whether you get an "already > > >> set

[Qemu-devel] [PATCH] pc-bios/s390-ccw: Optimize the s390-ccw bios for size

2018-06-14 Thread Thomas Huth
Since we're storing the firmware blobs in the QEMU git repository, it would be nice if the blobs would be a little bit smaller. By using -Os and -fno-asynchronous-unwind-tables the size of the s390-ccw.img can be decreased by ca. 4kB, and the size of s390-netboot.img even by ca. 45kB. The change of

Re: [Qemu-devel] [PATCH 2/3] migration: Wake rate limiting for urgent requests

2018-06-14 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Jun 13, 2018 at 11:26:41AM +0100, Dr. David Alan Gilbert (git) wrote: > > [...] > > > @@ -2932,10 +2943,24 @@ static void *migration_thread(void *opaque) > > > > migration_update_counters(s, current_time); > > > > +urgent = fals

Re: [Qemu-devel] [PATCH 9/9] hw/arm/virt: Add virt-3.0 machine type

2018-06-14 Thread Laszlo Ersek
Hi Eric, On 06/14/18 08:27, Auger Eric wrote: > Hi Laszlo, > > On 06/13/2018 11:05 PM, Laszlo Ersek wrote: >> On 06/13/18 10:48, Eric Auger wrote: >> >>> PATCH: merge of ECAM and VCPU extension >>> - Laszlo reviewed the ECAM changes but I dropped his R-b >>> due to the squash >> >> Was there an

Re: [Qemu-devel] [PATCH 9/9] hw/arm/virt: Add virt-3.0 machine type

2018-06-14 Thread Daniel P . Berrangé
On Thu, Jun 14, 2018 at 10:56:20AM +0200, Laszlo Ersek wrote: > Hi Eric, > > On 06/14/18 08:27, Auger Eric wrote: > > Hi Laszlo, > > > > On 06/13/2018 11:05 PM, Laszlo Ersek wrote: > >> On 06/13/18 10:48, Eric Auger wrote: > >> > >>> PATCH: merge of ECAM and VCPU extension > >>> - Laszlo reviewed

Re: [Qemu-devel] [PATCH v4 1/2] qapi: allow empty branches in flat unions

2018-06-14 Thread Anton Nefedov
On 14/6/2018 10:19 AM, Markus Armbruster wrote: Anton Nefedov writes: It often happens that just a few discriminator values imply extra data in a flat union. Existing checks did not make possible to leave other values uncovered. Such cases had to be worked around by either stating a dummy (

Re: [Qemu-devel] [PATCH v0 2/2] qmp: add block-set-copy-on-read command

2018-06-14 Thread Kevin Wolf
Am 13.06.2018 um 18:41 hat Max Reitz geschrieben: > On 2018-06-13 18:02, Eric Blake wrote: > > On 06/13/2018 10:47 AM, Denis Plotnikov wrote: > >> The command enables/disables copy-on-read mode for VM's disk while > >> VM is running. > >> > >> This is needed when using external disk readers to shap

Re: [Qemu-devel] [PATCH v0 2/2] qmp: add block-set-copy-on-read command

2018-06-14 Thread Alberto Garcia
On Thu 14 Jun 2018 11:00:55 AM CEST, Kevin Wolf wrote: > Am 13.06.2018 um 18:41 hat Max Reitz geschrieben: >> On 2018-06-13 18:02, Eric Blake wrote: >> > On 06/13/2018 10:47 AM, Denis Plotnikov wrote: >> >> The command enables/disables copy-on-read mode for VM's disk while >> >> VM is running. >>

Re: [Qemu-devel] [PATCH 9/9] hw/arm/virt: Add virt-3.0 machine type

2018-06-14 Thread Auger Eric
Hi Laszlo, On 06/14/2018 10:56 AM, Laszlo Ersek wrote: > Hi Eric, > > On 06/14/18 08:27, Auger Eric wrote: >> Hi Laszlo, >> >> On 06/13/2018 11:05 PM, Laszlo Ersek wrote: >>> On 06/13/18 10:48, Eric Auger wrote: >>> PATCH: merge of ECAM and VCPU extension - Laszlo reviewed the ECAM chang

Re: [Qemu-devel] [PATCH 9/9] hw/arm/virt: Add virt-3.0 machine type

2018-06-14 Thread Auger Eric
Hi Dan, Laszlo, On 06/14/2018 10:59 AM, Daniel P. Berrangé wrote: > On Thu, Jun 14, 2018 at 10:56:20AM +0200, Laszlo Ersek wrote: >> Hi Eric, >> >> On 06/14/18 08:27, Auger Eric wrote: >>> Hi Laszlo, >>> >>> On 06/13/2018 11:05 PM, Laszlo Ersek wrote: On 06/13/18 10:48, Eric Auger wrote:

Re: [Qemu-devel] [PATCH v4 04/14] pc: prepare for multi stage hotplug handlers

2018-06-14 Thread Igor Mammedov
On Thu, 14 Jun 2018 08:14:05 +0200 David Hildenbrand wrote: > On 14.06.2018 00:05, Michael S. Tsirkin wrote: > > On Wed, Jun 13, 2018 at 09:37:54PM +0200, David Hildenbrand wrote: > > [ ... specific to machine_foo wiring ...] > > > > virtio_mem_plug() { > >

Re: [Qemu-devel] [PATCH v0 2/2] qmp: add block-set-copy-on-read command

2018-06-14 Thread Kevin Wolf
Am 14.06.2018 um 11:03 hat Alberto Garcia geschrieben: > On Thu 14 Jun 2018 11:00:55 AM CEST, Kevin Wolf wrote: > > Am 13.06.2018 um 18:41 hat Max Reitz geschrieben: > >> On 2018-06-13 18:02, Eric Blake wrote: > >> > On 06/13/2018 10:47 AM, Denis Plotnikov wrote: > >> >> The command enables/disabl

Re: [Qemu-devel] [PATCH v4 04/14] pc: prepare for multi stage hotplug handlers

2018-06-14 Thread Igor Mammedov
On Wed, 13 Jun 2018 17:51:01 +0200 David Hildenbrand wrote: > On 13.06.2018 17:48, Igor Mammedov wrote: > > On Wed, 13 Jun 2018 12:58:46 +0200 > > David Hildenbrand wrote: > > > >> On 08.06.2018 17:12, Michael S. Tsirkin wrote: > >>> On Fri, Jun 08, 2018 at 03:07:53PM +0200, David Hildenbra

Re: [Qemu-devel] [PATCH V8 11/17] qapi: Add new command to query colo status

2018-06-14 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Zhang Chen (zhangc...@gmail.com) wrote: > >> On Mon, Jun 11, 2018 at 2:48 PM, Markus Armbruster > >> wrote: > >> > >> > Zhang Chen writes: > >> > > >> > > On Thu, Jun 7, 2018 at 8:59 PM, Markus Armbruster

Re: [Qemu-devel] [PATCH v4 3/3] hw/vfio/display: add ramfb support

2018-06-14 Thread Erik Skultety
On Thu, Jun 14, 2018 at 12:36:25AM +0200, Gerd Hoffmann wrote: > On Wed, Jun 13, 2018 at 01:50:47PM -0600, Alex Williamson wrote: > > On Wed, 13 Jun 2018 10:41:49 +0200 > > Gerd Hoffmann wrote: > > > > > So we have a boot display when using a vgpu as primary display. > > > > > > Use vfio-pci-ramfb

[Qemu-devel] [PATCH v2 0/4] block: Remove deprecated -drive options

2018-06-14 Thread Kevin Wolf
We deprecated a bunch of -drive options in 2.10, so let's remove them for 3.0. v2: - Simplified hd-geo-test code after removing test cases [Markus] - Split patch 3 and 4 so that the deprecation warning code can be easily restored if we ever need it again [Markus] Kevin Wolf (4): block: Remove

[Qemu-devel] [PATCH v2 1/4] block: Remove deprecated -drive geometry options

2018-06-14 Thread Kevin Wolf
The -drive options cyls, heads, secs and trans were deprecated in QEMU 2.10. It's time to remove them. hd-geo-test tested both the old version with geometry options in -drive and the new one with -device. Therefore the code using -drive doesn't have to be replaced there, we just need to remove the

[Qemu-devel] [PATCH v2 3/4] block: Remove deprecated -drive option serial

2018-06-14 Thread Kevin Wolf
The -drive option serial was deprecated in QEMU 2.10. It's time to remove it. Tests need to be updated to set the serial number with -global instead of using the -drive option. Signed-off-by: Kevin Wolf Reviewed-by: Markus Armbruster Reviewed-by: Jeff Cody Signed-off-by: Kevin Wolf --- inclu

[Qemu-devel] [PATCH v2 2/4] block: Remove deprecated -drive option addr

2018-06-14 Thread Kevin Wolf
The -drive option addr was deprecated in QEMU 2.10. It's time to remove it. Signed-off-by: Kevin Wolf Reviewed-by: Markus Armbruster Reviewed-by: Jeff Cody --- include/sysemu/blockdev.h | 1 - blockdev.c| 17 + device-hotplug.c | 4 qemu-doc.texi

[Qemu-devel] [PATCH v2 4/4] block: Remove dead deprecation warning code

2018-06-14 Thread Kevin Wolf
We removed all options from the 'deprecated' array, so the code is dead and can be removed as well. Signed-off-by: Kevin Wolf --- blockdev.c | 12 1 file changed, 12 deletions(-) diff --git a/blockdev.c b/blockdev.c index 695e10d398..4ab3d6ec0b 100644 --- a/blockdev.c +++ b/blockde

Re: [Qemu-devel] [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-14 Thread Cornelia Huck
I've been pointed to this discussion (which I had missed previously) and I'm getting a headache. Let me first summarize how I understand how this feature is supposed to work, then I'll respond to some individual points. The basic idea is to enable guests to migrate seamlessly, while still making i

Re: [Qemu-devel] [PULL 0/8] Linux user for 3.0 patches

2018-06-14 Thread Peter Maydell
On 12 June 2018 at 11:58, Laurent Vivier wrote: > The following changes since commit 9f55925b8f50a962d1d08d815044db7767ae3838: > > Merge remote-tracking branch > 'remotes/vivier/tags/m68k-for-3.0-pull-request' into staging (2018-06-11 > 12:46:16 +0100) > > are available in the Git repository a

Re: [Qemu-devel] Questions about qemu enabling TCI (tcg/tci.c)

2018-06-14 Thread Peter Maydell
On 13 June 2018 at 15:10, yt zhang wrote: > Dear technicians, > Good day. > I encountered some difficulties in learning about the TCI part of QEMU. > When I use the following configuration command to enable TCI: > > "configure --enable-tcg-interpreter" > > Run the command as: > >

Re: [Qemu-devel] bug in reopen arch

2018-06-14 Thread Kevin Wolf
Am 12.06.2018 um 20:57 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > I've faced the following problem: > >     1. create image with dirty bitmap, a.qcow2 (start qemu and run qmp >     command block-dirty-bitmap-add) > >     2. run the following commands: > >     qemu-img creat

Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments

2018-06-14 Thread Peter Maydell
On 13 June 2018 at 17:55, John Snow wrote: > The same reasoning could be used to justify > > /* two > * lines */ > > as it's ... actually just two lines. I think people don't seem to like > this much either (why? does it look 'naked' on the end?) I dislike the way it breaks up the line of stars.

Re: [Qemu-devel] [PATCH] ps2: check PS2Queue wptr pointer in post_load routine

2018-06-14 Thread liujunjie (A)
ping > -Original Message- > From: liujunjie (A) > Sent: Thursday, June 07, 2018 4:03 PM > To: kra...@redhat.com; berra...@redhat.com > Cc: Gonglei (Arei) ; wangxin (U) > ; Huangweidong (C) > ; fangying ; > qemu-devel@nongnu.org; liujunjie (A) > Subject: [PATCH] ps2: check PS2Queue wptr po

Re: [Qemu-devel] Is there a way to package QEMU binaries?

2018-06-14 Thread Peter Maydell
On 14 June 2018 at 09:14, Daniel P. Berrangé wrote: > On Thu, Jun 14, 2018 at 10:55:21AM +0800, Peter Xu wrote: >> Then is there an easy way to port the specfile and tools to QEMU >> repository so that we can pack that even with a git tree? > Well if we want to have a RPM spec file for QEMU distr

[Qemu-devel] [RFCv2 PATCH 0/1] SPARC64: add icount support

2018-06-14 Thread Mark Cave-Ayland
This is a patch I've had in an earlier form for a while but never really developed due to experiencing random hangs when writing to the SPARC64 CPU timers. Fortunately it seems the recent icount timer fixes have resolved the underlying issues and with this patch I am able to boot all my qemu-syst

[Qemu-devel] [RFCv2 PATCH 1/1] SPARC64: add icount support

2018-06-14 Thread Mark Cave-Ayland
This patch adds gen_io_start()/gen_io_end() to various instructions as required in order to boot my OpenBIOS test images on qemu-system-sparc64 with icount enabled. Signed-off-by: Mark Cave-Ayland --- target/sparc/translate.c | 97 1 file changed,

Re: [Qemu-devel] [qemu-s390x] [PATCH] pc-bios/s390-ccw: Optimize the s390-ccw bios for size

2018-06-14 Thread Christian Borntraeger
On 06/14/2018 10:48 AM, Thomas Huth wrote: > Since we're storing the firmware blobs in the QEMU git repository, it > would be nice if the blobs would be a little bit smaller. By using -Os > and -fno-asynchronous-unwind-tables the size of the s390-ccw.img can be > decreased by ca. 4kB, and the siz

Re: [Qemu-devel] [PATCH 2/3] migration: Wake rate limiting for urgent requests

2018-06-14 Thread Peter Xu
On Thu, Jun 14, 2018 at 09:50:35AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Wed, Jun 13, 2018 at 11:26:41AM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > > [...] > > > > > @@ -2932,10 +2943,24 @@ static void *migration_thread(void *opaque) > > >

Re: [Qemu-devel] [PATCH 3/3] migration/postcopy: Wake rate limit sleep on postcopy request

2018-06-14 Thread Peter Xu
On Wed, Jun 13, 2018 at 11:26:42AM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Use the 'urgent request' mechanism added in the previous patch > for entries added to the postcopy request queue for RAM. Ignore > the rate limiting while we have requests. > > Sig

Re: [Qemu-devel] Is there a way to package QEMU binaries?

2018-06-14 Thread Peter Xu
On Thu, Jun 14, 2018 at 11:50:23AM +0100, Peter Maydell wrote: > On 14 June 2018 at 09:14, Daniel P. Berrangé wrote: > > On Thu, Jun 14, 2018 at 10:55:21AM +0800, Peter Xu wrote: > >> Then is there an easy way to port the specfile and tools to QEMU > >> repository so that we can pack that even wit

Re: [Qemu-devel] [qemu-s390x] [PATCH] pc-bios/s390-ccw: Optimize the s390-ccw bios for size

2018-06-14 Thread Thomas Huth
On 14.06.2018 12:55, Christian Borntraeger wrote: > > On 06/14/2018 10:48 AM, Thomas Huth wrote: >> Since we're storing the firmware blobs in the QEMU git repository, it >> would be nice if the blobs would be a little bit smaller. By using -Os >> and -fno-asynchronous-unwind-tables the size of the

Re: [Qemu-devel] [PATCH] xilinx_spips: Make dma transactions as per dma_burst_size

2018-06-14 Thread Edgar E. Iglesias
On Thu, Jun 14, 2018 at 10:57:04AM +0530, Sai Pavan Boddu wrote: > Qspi dma has a burst length of 64 bytes, So limit transaction length to > 64 max. Hi Sai, Is this a v2 or a resend? > > Signed-off-by: Sai Pavan Boddu > --- > hw/ssi/xilinx_spips.c | 18 +++--- > include/hw

Re: [Qemu-devel] [PATCH 12/18] block-qdict: Clean up qdict_crumple() a bit

2018-06-14 Thread Markus Armbruster
Kevin Wolf writes: > Am 13.06.2018 um 17:23 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 12.06.2018 um 14:58 hat Markus Armbruster geschrieben: >> >> When you mix scalar and non-scalar keys, whether you get an "already >> >> set as scalar" or an "already set as dict" erro

Re: [Qemu-devel] [PULL 0/3] Miscellaneous patches for 2018-06-13

2018-06-14 Thread Peter Maydell
On 13 June 2018 at 14:10, Markus Armbruster wrote: > The following changes since commit 2ab09bf2f9f55b9fb8d2de6eb2ba2a8570e268e2: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20180612-pull-request' into staging (2018-06-12 > 15:34:34 +0100) > > are available in the Git repositor

Re: [Qemu-devel] [PULL 50/69] hw/alpha/dp264: Use the TYPE_SMC37C669_SUPERIO

2018-06-14 Thread Philippe Mathieu-Daudé
On 06/13/2018 02:17 PM, Philippe Mathieu-Daudé wrote: > On 06/13/2018 01:35 PM, Philippe Mathieu-Daudé wrote: >> On 06/13/2018 01:21 PM, Paolo Bonzini wrote: >>> On 01/06/2018 20:51, Emilio G. Cota wrote: On Tue, Mar 13, 2018 at 23:47:00 +0100, Paolo Bonzini wrote: > From: Philippe Mathieu

Re: [Qemu-devel] [libvirt] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig

2018-06-14 Thread Igor Mammedov
On Wed, 13 Jun 2018 14:09:32 -0300 Eduardo Habkost wrote: > On Wed, Jun 13, 2018 at 03:23:09PM +0100, Daniel P. Berrangé wrote: > > On Wed, Jun 13, 2018 at 11:17:30AM -0300, Eduardo Habkost wrote: > > > On Tue, Jun 12, 2018 at 01:50:33PM +0100, Daniel P. Berrangé wrote: > > > > On Tue, Jun 12

Re: [Qemu-devel] [PULL 0/3] Miscellaneous patches for 2018-06-13

2018-06-14 Thread Markus Armbruster
no-re...@patchew.org writes: > Hi, > > This series seems to have some coding style problems. See output below for > more information: Quick respin coming.

[Qemu-devel] [PULL v2 2/3] coverity-model: replay data is considered trusted

2018-06-14 Thread Markus Armbruster
From: Paolo Bonzini Replay data is not considered a possible attack vector; add a model that does not use getc so that "tainted data" warnings are suppressed. Signed-off-by: Paolo Bonzini Message-Id: <20180514141218.28438-1-pbonz...@redhat.com> Reviewed-by: Markus Armbruster [Whitespace tweake

[Qemu-devel] [PULL v2 0/3] Miscellaneous patches for 2018-06-13

2018-06-14 Thread Markus Armbruster
The following changes since commit 2ab09bf2f9f55b9fb8d2de6eb2ba2a8570e268e2: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20180612-pull-request' into staging (2018-06-12 15:34:34 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-misc-2018-06-

[Qemu-devel] [PULL v2 3/3] Purge uses of banned g_assert_FOO()

2018-06-14 Thread Markus Armbruster
We banned use of certain g_assert_FOO() functions outside tests, and made checkpatch.pl flag them (commit 6e9389563e5). We neglected to purge existing uses. Do that now. Signed-off-by: Markus Armbruster Message-Id: <20180608170231.27912-1-arm...@redhat.com> Reviewed-by: Eric Blake Reviewed-by:

[Qemu-devel] [PULL v2 1/3] Revert "Makefile: add target to print generated files"

2018-06-14 Thread Markus Armbruster
This reverts commit 9578f8cc3e8bd71de8e3f543dc7b95644d64824e. The patch snuck in by accident without having been posted to qemu-devel. It's entirely redundant: existing target print-% already serves the purpose. Cc: Michael S. Tsirkin Signed-off-by: Markus Armbruster Message-Id: <2018050405424

Re: [Qemu-devel] [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-14 Thread Michael S. Tsirkin
On Wed, Jun 13, 2018 at 06:02:01PM -0700, Siwei Liu wrote: > >> And it's the guest that needs failover support not the VM. > > > > > > Isn't guest and VM synonymous? Guest is whatever software is running on top of the hypervisor. The virtual machine is the interface between the two. -- MST

Re: [Qemu-devel] [PATCH v4 2/2] intel-iommu: start to use error_report_once

2018-06-14 Thread Markus Armbruster
Auger Eric writes: > Hi, > On 06/13/2018 10:05 AM, Markus Armbruster wrote: >> Peter Xu writes: >> >>> Replace existing trace_vtd_err() with error_report_once() then stderr >>> will capture something if any of the error happens, meanwhile we don't >>> suffer from any DDOS. Then remove the trac

[Qemu-devel] [PATCH v1 1/3] travis: display config.log when configure fails

2018-06-14 Thread Alex Bennée
From: Daniel P. Berrangé When configure fails in CI systems we must be able to see the contents of the config.log file to diagnose the root cause. Signed-off-by: Daniel P. Berrangé Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Fam Zheng [AJB: used Eric's suggested

[Qemu-devel] [PATCH v1 0/3] Current Travis Patches

2018-06-14 Thread Alex Bennée
Hi, Mine are mostly aimed at reducing the build time of a number of bits of the matrix which keep tripping up on the time limit. I'll put the pull-req in tomorrow if there are no major complaints. Alex Bennée (2): travis: reduce coverage of gprof build travis: reduce time taken for trace-back

[Qemu-devel] [PATCH v1 2/3] travis: reduce coverage of gprof build

2018-06-14 Thread Alex Bennée
This build is regularly timing out and even switching off linux-user wasn't enough. Instead explicitly choose a target list of broadly the "major" architectures. This is enough to check the gprof build machinery works without worrying about the actual coverage results. I did try various YAML const

[Qemu-devel] [PATCH v1 3/3] travis: reduce time taken for trace-backend testing

2018-06-14 Thread Alex Bennée
These builds are reaching regular timeouts and probably don't need to be so widely exercised. ftrace and ust in particular are used in conjunction with whole system profiling which makes most sense with KVM setups, hence the native softmmu target. We also expand simple to cover the multiple log ba

Re: [Qemu-devel] [PULL v2 0/3] Miscellaneous patches for 2018-06-13

2018-06-14 Thread Peter Maydell
On 14 June 2018 at 13:43, Markus Armbruster wrote: > The following changes since commit 2ab09bf2f9f55b9fb8d2de6eb2ba2a8570e268e2: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20180612-pull-request' into staging (2018-06-12 > 15:34:34 +0100) > > are available in the Git repositor

Re: [Qemu-devel] [PATCH v4 1/3] osdep: add wait.h compat macros

2018-06-14 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > Man page for WCOREDUMP says: > > WCOREDUMP(wstatus) returns true if the child produced a core dump. > This macro should be employed only if WIFSIGNALED returned true. > > This macro is not specified in POSIX.1-2001 and is not > available on some UNIX im

Re: [Qemu-devel] Is there a way to package QEMU binaries?

2018-06-14 Thread Alex Bennée
Peter Xu writes: > On Thu, Jun 14, 2018 at 11:50:23AM +0100, Peter Maydell wrote: >> On 14 June 2018 at 09:14, Daniel P. Berrangé wrote: >> > On Thu, Jun 14, 2018 at 10:55:21AM +0800, Peter Xu wrote: >> >> Then is there an easy way to port the specfile and tools to QEMU >> >> repository so tha

Re: [Qemu-devel] [PATCH v4 2/2] intel-iommu: start to use error_report_once

2018-06-14 Thread Peter Maydell
On 14 June 2018 at 13:51, Markus Armbruster wrote: > Auger Eric writes: > >> Hi, >> On 06/13/2018 10:05 AM, Markus Armbruster wrote: >>> Peter Xu writes: >>> Replace existing trace_vtd_err() with error_report_once() then stderr will capture something if any of the error happens, meanwh

Re: [Qemu-devel] [PATCH v1 06/11] pc-dimm: don't allow to access "size" before the device was realized

2018-06-14 Thread Igor Mammedov
On Wed, 13 Jun 2018 18:33:37 -0300 Eduardo Habkost wrote: > On Wed, Jun 13, 2018 at 04:03:35PM +0200, David Hildenbrand wrote: > > On 13.06.2018 14:56, Igor Mammedov wrote: > > > On Mon, 11 Jun 2018 14:16:50 +0200 > > > David Hildenbrand wrote: > > > > > >> "size" should not be queried befo

Re: [Qemu-devel] [PATCH v1 2/3] travis: reduce coverage of gprof build

2018-06-14 Thread Philippe Mathieu-Daudé
On 06/14/2018 09:53 AM, Alex Bennée wrote: > This build is regularly timing out and even switching off linux-user > wasn't enough. Instead explicitly choose a target list of broadly the > "major" architectures. This is enough to check the gprof build > machinery works without worrying about the act

Re: [Qemu-devel] [PATCH v4 1/3] osdep: add wait.h compat macros

2018-06-14 Thread Peter Maydell
On 14 June 2018 at 13:56, Markus Armbruster wrote: > Suggest to drop the last sentence from the comment, and have the commit > message state you're providing a stub. This patch is already in upstream, commit 28012e190e68... thanks -- PMM

Re: [Qemu-devel] [PULL 0/1] Block patches

2018-06-14 Thread Peter Maydell
On 13 June 2018 at 15:53, Jeff Cody wrote: > The following changes since commit 2ab09bf2f9f55b9fb8d2de6eb2ba2a8570e268e2: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20180612-pull-request' into staging (2018-06-12 > 15:34:34 +0100) > > are available in the git repository at: >

Re: [Qemu-devel] [PATCH 2/3] qcow2: refactor data compression

2018-06-14 Thread Kevin Wolf
Am 08.06.2018 um 21:20 hat Vladimir Sementsov-Ogievskiy geschrieben: > Make a separate function for compression to be parallelized later. > - use .avail_aut field instead of .next_out to calculate size of s/avail_aut/avail_out/ >compressed data. It looks more natural and it allows to keep de

Re: [Qemu-devel] [PATCH v2 3/4] block: Remove deprecated -drive option serial

2018-06-14 Thread Richard W.M. Jones
On Thu, Jun 14, 2018 at 11:55:43AM +0200, Kevin Wolf wrote: > The -drive option serial was deprecated in QEMU 2.10. It's time to > remove it. > > Tests need to be updated to set the serial number with -global instead > of using the -drive option. Libguestfs uses this option to set the disk serial

Re: [Qemu-devel] [PATCH v1 3/3] travis: reduce time taken for trace-backend testing

2018-06-14 Thread Philippe Mathieu-Daudé
On 06/14/2018 09:53 AM, Alex Bennée wrote: > These builds are reaching regular timeouts and probably don't need to > be so widely exercised. ftrace and ust in particular are used in > conjunction with whole system profiling which makes most sense with > KVM setups, hence the native softmmu target.

Re: [Qemu-devel] [PATCH 12/18] block-qdict: Clean up qdict_crumple() a bit

2018-06-14 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Jun 14, 2018 at 10:40:58AM +0200, Kevin Wolf wrote: >> Am 13.06.2018 um 17:23 hat Markus Armbruster geschrieben: >> > Kevin Wolf writes: >> > >> > > Am 12.06.2018 um 14:58 hat Markus Armbruster geschrieben: >> > >> When you mix scalar and non-scalar keys, wh

Re: [Qemu-devel] [PULL v2 0/3] Miscellaneous patches for 2018-06-13

2018-06-14 Thread Markus Armbruster
Peter Maydell writes: > On 14 June 2018 at 13:43, Markus Armbruster wrote: >> The following changes since commit 2ab09bf2f9f55b9fb8d2de6eb2ba2a8570e268e2: >> >> Merge remote-tracking branch >> 'remotes/kraxel/tags/usb-20180612-pull-request' into staging (2018-06-12 >> 15:34:34 +0100) >> >> a

Re: [Qemu-devel] [PATCH v3 0/7] Reenable hmp for preconfig mode

2018-06-14 Thread Igor Mammedov
On Mon, 11 Jun 2018 14:44:41 +0200 Markus Armbruster wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> Let's also provide "quit", both in HMP and QMP. > > > > I tried enabling quit, but it fails with an incorrect > > state transition. > >

Re: [Qemu-devel] [PATCH 3/3] qcow2: add compress threads

2018-06-14 Thread Kevin Wolf
Am 08.06.2018 um 21:20 hat Vladimir Sementsov-Ogievskiy geschrieben: > Do data compression in separate threads. This significantly improve > performance for qemu-img convert with -W (allow async writes) and -c > (compressed) options. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Looks correct

  1   2   3   4   >