Re: [Qemu-devel] [PATCH v4 2/3] hw/arm/sysbus-fdt: Replace error_setg(&error_fatal) by error_report() + exit()

2018-06-25 Thread Auger Eric
Hi Philippe, On 06/25/2018 06:57 PM, Philippe Mathieu-Daudé wrote: > Use error_report() + exit() instead of error_setg(&error_fatal), > as suggested by the "qapi/error.h" documentation: > >Please don't error_setg(&error_fatal, ...), use error_report() and >exit(), because that's more obvio

[Qemu-devel] [PATCH] sdl2: add checking for NULL

2018-06-25 Thread Pavel Dovgalyuk
Sometimes SDL2 console can't be retrieved on events and scon variable becomes NULL. This patch prevents processing of the events when the console is not available. Signed-off-by: Pavel Dovgalyuk Signed-off-by: Maria Klimushenkova --- ui/sdl2.c |6 +++--- 1 file changed, 3 insertions(+), 3 d

[Qemu-devel] [PATCH] sdl2: fix copypaste issues

2018-06-25 Thread Pavel Dovgalyuk
This patch fixes text and mouse event processing. These functions used 'key' field of the event instead of appropriate 'text', 'motion', 'button', or 'wheel'. Signed-off-by: Pavel Dovgalyuk Signed-off-by: Maria Klimushenkova --- ui/sdl2.c |8 1 file changed, 4 insertions(+), 4 dele

[Qemu-devel] [PATCH] vga: set owner for mmio regions

2018-06-25 Thread Gerd Hoffmann
This makes sure the regions are properly cleaned when unplugging -device seconday-vga. Reported-by: Thomas Huth Signed-off-by: Gerd Hoffmann --- hw/display/vga_int.h| 1 + hw/display/vga-pci.c| 11 ++- hw/display/virtio-vga.c | 2 +- 3 files changed, 8 insertions(+), 6 deletio

Re: [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore

2018-06-25 Thread Paolo Bonzini
On 25/06/2018 21:51, Eduardo Habkost wrote: >> Before that we should ask what the benefit is in changing the default >> for qemu-system-*. Nobody is using it in practice to start QEMU with >> KVM enabled... > > How can you be sure? If qemu-system-* is installed with KVM > compiled in, libvirt wil

Re: [Qemu-devel] s390 qemu boot failure in -next

2018-06-25 Thread Thomas Huth
On 26.06.2018 07:32, Georgi Guninski wrote: > On Mon, Jun 25, 2018 at 09:27:59AM +0200, Christian Borntraeger wrote: >> -/* Overwrite parameters in the kernel image, which are "rom" */ >> -strcpy(rom_ptr(KERN_PARM_AREA), ipl->cmdline); > >> +strcpy(rom_ptr(KERN_

[Qemu-devel] [PATCH 1/1] block/dirty-bitmap: Useless bitmaps in image can be removed

2018-06-25 Thread 13466399134
From: Yao Xu <13466399...@163.com> If qemu-kvm quit without saving bitmaps to image(coredump, host kernel panic, or host pooweroff), bitmaps in image can not be safely used anymore, and also can not be removed. Useless bitmaps should be removed. "block-dirty-bitmap-remove" failed, because block_d

Re: [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore

2018-06-25 Thread Thomas Huth
On 25.06.2018 20:26, Paolo Bonzini wrote: > On 25/06/2018 19:30, Eduardo Habkost wrote: Attentive distros could even replace the wrapper script by a link. >>> If they are okay with replacing the "KVM only" semantics with "KVM or >>> TCG", which I think is generally worse. >> >> If we can't get

[Qemu-devel] [Bug 628082] Re: nl-be keymap is wrong

2018-06-25 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/628082 Title: nl-be keymap

[Qemu-devel] [Bug 1660599] Re: v2.8.0 won't compile if g++ compiler doesn't understand "-fstack-protector-strong"

2018-06-25 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1660599 Title: v2.8.0 won'

[Qemu-devel] block/dirty-bitmap: Useless bitmaps in image can be removed

2018-06-25 Thread yaoxu
If qemu-kvm quit without saving bitmaps to image(coredump, host kernel panic, or host pooweroff), bitmaps in image can not be safely used anymore, and also can not be removed. Useless bitmaps should be removed. Signed-off-by: yaoxu --- diff --git a/blockdev.c b/blockdev.c index 58d7570932..c85056

Re: [Qemu-devel] [PATCH 1/1] target/m68k: correctly disassemble move16

2018-06-25 Thread Thomas Huth
Am Mon, 25 Jun 2018 22:35:59 +0200 schrieb Laurent Vivier : > "move16 %a0@+,%a1@" and "fmovel (cpid=3) %a0@-,%fpcr" > share the same opcode. > > To fix that, backport the fix from binutils: > > 2005-11-10 Andreas Schwab > > * m68k-dis.c (print_insn_m68k): Only match FPU insns with >

[Qemu-devel] block/dirty-bitmap: Useless bitmaps in image can be removed

2018-06-25 Thread yaoxu
If qemu-kvm quit without saving bitmaps to image(coredump, host kernel panic, or host pooweroff), bitmaps in image can not be safely used anymore, and also can not be removed. Useless bitmaps should be removed. Signed-off-by: yaoxu --- diff --git a/blockdev.c b/blockdev.c index 58d7570932..c85056

Re: [Qemu-devel] [PATCH v2 5/5] ppc/xics: rework the ICS classes inheritance tree

2018-06-25 Thread David Gibson
On Mon, Jun 25, 2018 at 11:17:18AM +0200, Cédric Le Goater wrote: > With the previous changes, we can now let the ICS_KVM class inherit > directly from ICS_BASE class and not from the intermediate ICS_SIMPLE. > It makes the class hierarchy much cleaner. > > What is left in the top classes is the l

Re: [Qemu-devel] [PATCH v2] util/async: avoid NULL pointer dereference

2018-06-25 Thread WangJie (Pluto)
Thanks Stefan, will you push it to master branch? On 2018/6/18 23:50, Stefan Hajnoczi wrote: > On Tue, Jun 12, 2018 at 07:26:25AM +0800, Jie Wang wrote: >> if laio_init create linux_aio failed and return NULL, NULL pointer >> dereference will occur when laio_attach_aio_context dereference >> linux

Re: [Qemu-devel] [PATCH v2 3/5] ppx/xics: introduce a parent_reset in ICSStateClass

2018-06-25 Thread David Gibson
On Mon, Jun 25, 2018 at 11:17:16AM +0200, Cédric Le Goater wrote: > Just like for the realize handlers, this makes possible to move the > common ICSState code of the reset handlers in the ics-base class. > > Signed-off-by: Cédric Le Goater Applied, thanks. > --- > include/hw/ppc/xics.h | 1 +

Re: [Qemu-devel] [PATCH v2 2/5] ppc/xics: move the instance_init handler under the ics-base class

2018-06-25 Thread David Gibson
On Mon, Jun 25, 2018 at 11:17:15AM +0200, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- > hw/intc/xics.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) Applied, thanks. > diff --git a/hw/intc/xics.c b/hw/intc/xics.c > index d6066d561fdc..83340770f7c0

Re: [Qemu-devel] [PATCH v2 1/5] ppc/xics: introduce a parent_realize in ICSStateClass

2018-06-25 Thread David Gibson
On Mon, Jun 25, 2018 at 11:17:14AM +0200, Cédric Le Goater wrote: > This makes possible to move the common ICSState code of the realize > handlers in the ics-base class. > > Signed-off-by: Cédric Le Goater Applied to ppc-for-3.0, thanks. > --- > include/hw/ppc/xics.h | 3 ++- > hw/intc/xics.c

Re: [Qemu-devel] [PATCH v2 4/5] ppc/xics: move the vmstate structures under the ics-base class

2018-06-25 Thread David Gibson
On Mon, Jun 25, 2018 at 11:17:17AM +0200, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater Applied, thanks. > --- > hw/intc/xics.c | 112 > - > 1 file changed, 56 insertions(+), 56 deletions(-) > > diff --git a/hw/intc/xics.c b/

Re: [Qemu-devel] [PATCH v5 41/46] hw/ppc: Use the IEC binary prefix definitions

2018-06-25 Thread David Gibson
On Mon, Jun 25, 2018 at 09:42:33AM -0300, Philippe Mathieu-Daudé wrote: > It eases code review, unit is explicit. > > Patch generated using: > > $ git grep -n '[<>][<>]= ?[1-5]0' > > and modified manually. > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: David Gibson > --- > hw/ppc/sa

Re: [Qemu-devel] [Qemu-block][RFC PATCH] hw/block/nvme: add optional parameter num_queues for nvme device

2018-06-25 Thread Keith Busch
On Tue, Jun 26, 2018 at 09:44:56AM +0800, Weiping Zhang wrote: > Add an optional paramter num_queues for device, and set it > to 64 by default. > > Signed-off-by: Weiping Zhang Looks good to me. Acked-by: Keith Busch

Re: [Qemu-devel] [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-25 Thread Michael S. Tsirkin
On Mon, Jun 25, 2018 at 10:54:09AM -0700, Samudrala, Sridhar wrote: > > > > > Might not neccessarily be something wrong, but it's very limited to > > > > > prohibit the MAC of VF from changing when enslaved by failover. > > > > You mean guest changing MAC? I'm not sure why we prohibit that. > > > I

Re: [Qemu-devel] [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-25 Thread Michael S. Tsirkin
On Mon, Jun 25, 2018 at 11:55:12AM +0200, Cornelia Huck wrote: > On Fri, 22 Jun 2018 22:05:50 +0300 > "Michael S. Tsirkin" wrote: > > > On Fri, Jun 22, 2018 at 05:09:55PM +0200, Cornelia Huck wrote: > > > On Thu, 21 Jun 2018 21:20:13 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Th

Re: [Qemu-devel] [PATCH 1/2] ide/hw/core: fix crash on processing a partial-sector-size DMA xfer

2018-06-25 Thread Amol Surati
On Mon, Jun 25, 2018 at 05:10:23PM -0400, John Snow wrote: > > > On 06/20/2018 12:29 AM, Amol Surati wrote: > > Fixes: https://bugs.launchpad.net/qemu/+bug/1777315 > > > > QEMU's short PRD policy applies to a DMA transfer of size < 512 bytes. > > But it fails to consider transfers which are >= 5

Re: [Qemu-devel] [PATCH v5 00/46] Use the IEC binary prefix definitions

2018-06-25 Thread Michael S. Tsirkin
On Mon, Jun 25, 2018 at 09:41:52AM -0300, Philippe Mathieu-Daudé wrote: > Hi, > > This series: > > - split the byte-based definitions from "qemu/cutils.h" to "qemu/units.h" > (this now triggers WARNING: 1 added file, does MAINTAINERS need updating?) > - clean hw/ includes; > - replace different

[Qemu-devel] [PULL 1/2] vl.c: do not allow --daemonize in combination with --preconfig CLI option

2018-06-25 Thread Eduardo Habkost
From: Igor Mammedov some users when using --daemonize expect that QEMU will parse CLI options, initialize VM and only then complete daemonzation by signalling lead process to exit and start listening on monitor socket. So users treat parent process exit as sync point to connect to QEMU's monitor.

[Qemu-devel] [PULL 2/2] hw/i386: Deprecate the machine types pc-0.10 and pc-0.11

2018-06-25 Thread Eduardo Habkost
From: Thomas Huth The oldest machine type which is still used in a still maintained distro is a pc-0.12 based machine type in RHEL6, so everything that is older than pc-0.12 should not be used anymore. Thus let's deprecate pc-0.10 and pc-0.11 so that we can finally remove them in a future release

[Qemu-devel] [PULL 0/2] Machine queue, 2018-06-25

2018-06-25 Thread Eduardo Habkost
The following changes since commit 35e238c9330669882487f9929e0aa97900431853: Merge remote-tracking branch 'remotes/kraxel/tags/audio-20180625-pull-request' into staging (2018-06-25 15:25:26 +0100) are available in the Git repository at: git://github.com/ehabkost/qemu.git tags/ma

[Qemu-devel] [PATCH] ehci: Don't fetch a NULL current qtd but advance the queue instead.

2018-06-25 Thread Sebastian Bauer
Fetching qtd with the NULL address most likely makes no sense so from now on, we handle it this case similarly as if the terminate (T) bit is not set, which is already an exception as according to section 3.6 of the EHCI spec there is no T bit defined for the current_qtd field. The spec is a bit v

Re: [Qemu-devel] [PATCH v2] docs: add guidance on configuring CPU models for x86

2018-06-25 Thread Eduardo Habkost
On Mon, Jun 18, 2018 at 11:18:47AM +0100, Daniel P. Berrangé wrote: > With the recent set of CPU hardware vulnerabilities on x86, it is > increasingly difficult to understand which CPU configurations are > good to use and what flaws they might be vulnerable to. > > This doc attempts to help manage

[Qemu-devel] [PULL 09/12] i386: Allow TOPOEXT to be enabled on older kernels

2018-06-25 Thread Eduardo Habkost
From: Babu Moger Enabling TOPOEXT feature might cause compatibility issues if older kernels does not set this feature. Lets set this feature unconditionally. Signed-off-by: Babu Moger Message-Id: <1528939107-17193-2-git-send-email-babu.mo...@amd.com> [ehabkost: rewrite comment and commit messag

[Qemu-devel] [PULL 12/12] i386: Remove generic SMT thread check

2018-06-25 Thread Eduardo Habkost
From: Babu Moger Remove generic non-intel check while validating hyperthreading support. Certain AMD CPUs can support hyperthreading now. CPU family with TOPOEXT feature can support hyperthreading now. Signed-off-by: Babu Moger Tested-by: Geoffrey McRae Reviewed-by: Eduardo Habkost Message-I

[Qemu-devel] [PULL 11/12] i386: Enable TOPOEXT feature on AMD EPYC CPU

2018-06-25 Thread Eduardo Habkost
From: Babu Moger Enable TOPOEXT feature on EPYC CPU. This is required to support hyperthreading on VM guests. Also extend xlevel to 0x801E. Disable topoext on PC_COMPAT_2_12 and keep xlevel 0x800a. Signed-off-by: Babu Moger Message-Id: <1529443919-67509-3-git-send-email-babu.mo...@amd.

[Qemu-devel] [PULL 05/12] i386: Remove osxsave CPUID flag name

2018-06-25 Thread Eduardo Habkost
OSXAVE is not a static feature flag: it changes dynamically at runtime depending on CR4, and it was never configurable: KVM never returned OSXSAVE on GET_SUPPORTED_CPUID, and it is not included in TCG_EXT_FEATURES. Remove OSXSAVE from the feature name array so users don't try to configure it manua

[Qemu-devel] [PULL 07/12] i386: define the AMD 'amd-ssbd' CPUID feature bit

2018-06-25 Thread Eduardo Habkost
From: Konrad Rzeszutek Wilk AMD future CPUs expose _two_ ways to utilize the Intel equivalant of the Speculative Store Bypass Disable. The first is via the virtualized VIRT_SPEC CTRL MSR (0xC001_011f) and the second is via the SPEC_CTRL MSR (0x48). The document titled: 124441_AMD64_SpeculativeSto

Re: [Qemu-devel] [Bug 1778350] Re: Android-x86 4.4-r5 won't boot on QEMU since v2.11.0-rc2

2018-06-25 Thread Michael S. Tsirkin
On Mon, Jun 25, 2018 at 01:46:16PM -0400, John Snow wrote: > CC Michael Tsirkin > > On 06/25/2018 06:53 AM, navicrej wrote: > > After 'git bisect' -ing it I found the commit that is responsible for > > this: > > > > https://git.qemu.org/?p=qemu.git;a=commitdiff;h=9fa99d2519cbf71f871e46871df12cb44

[Qemu-devel] [PULL 04/12] i386: display known CPUID features linewrapped, in alphabetical order

2018-06-25 Thread Eduardo Habkost
From: Daniel P. Berrangé When using '-cpu help' the list of CPUID features is grouped according to the internal low level CPUID grouping. The data printed results in very long lines too. This combines to make it hard for users to read the output and identify if QEMU knows about the feature they

[Qemu-devel] [PULL 10/12] i386: Fix up the Node id for CPUID_8000_001E

2018-06-25 Thread Eduardo Habkost
From: Babu Moger This is part of topoext support. To keep the compatibility, it is better we support all the combination of nr_cores and nr_threads currently supported. By allowing more nr_cores and nr_threads, we might end up with more nodes than we can actually support with the real hardware. W

[Qemu-devel] [PULL 08/12] i386: Define AMD's no SSB mitigation needed.

2018-06-25 Thread Eduardo Habkost
From: Konrad Rzeszutek Wilk AMD future CPUs expose a mechanism to tell the guest that the Speculative Store Bypass Disable is not needed and that the CPU is all good. This is exposed via the CPUID 8000_0008.EBX[26] bit. See 124441_AMD64_SpeculativeStoreBypassDisable_Whitepaper_final.pdf A copy

[Qemu-devel] [PULL 02/12] i386: improve alignment of CPU model listing

2018-06-25 Thread Eduardo Habkost
From: Daniel P. Berrangé Since the addition of the -IBRS CPU model variants, the descriptions shown by '-cpu help' are not well aligned, as several model names overflow the space allowed. Right aligning the CPU model names is also not attractive, because it obscures the common name prefixes of ma

[Qemu-devel] [PULL 06/12] i386: Remove ospke CPUID flag name

2018-06-25 Thread Eduardo Habkost
OSPKE is not a static feature flag: it changes dynamically at runtime depending on CR4, and it was never configurable: KVM never returned OSPKE on GET_SUPPORTED_CPUID, and on TCG enables it automatically if CR4_PKE_MASK is set. Remove OSPKE from the feature name array so users don't try to configu

[Qemu-devel] [PULL 01/12] i386: Add support for CPUID_8000_001E for AMD

2018-06-25 Thread Eduardo Habkost
From: Babu Moger Add support for cpuid leaf CPUID_8000_001E. Build the config that closely match the underlying hardware. Please refer to the Processor Programming Reference (PPR) for AMD Family 17h Model for more details. Signed-off-by: Babu Moger Message-Id: <1528498581-131037-2-git-send-emai

[Qemu-devel] [PULL 03/12] i386: improve sorting of CPU model names

2018-06-25 Thread Eduardo Habkost
From: Daniel P. Berrangé The current list of CPU model names output by "-cpu help" is sorted alphabetically based on the internal QOM class name. The text that is displayed, however, uses the CPU model name, which is equivalent to the QOM class name, minus a suffix. Unfortunately that suffix has

[Qemu-devel] [PULL 00/12] x86 queue, 2018-06-25

2018-06-25 Thread Eduardo Habkost
The following changes since commit 35e238c9330669882487f9929e0aa97900431853: Merge remote-tracking branch 'remotes/kraxel/tags/audio-20180625-pull-request' into staging (2018-06-25 15:25:26 +0100) are available in the Git repository at: git://github.com/ehabkost/qemu.git tag

Re: [Qemu-devel] [PATCH] fix fdiv instruction

2018-06-25 Thread Programmingkid
> On Jun 25, 2018, at 5:08 PM, Richard Henderson > wrote: > > On Mon, Jun 25, 2018, 08:23 G 3 wrote: > > > > Try > > > > uint64_t expected_answer = 0xdeadbeef; > > ... > > c.i = expected_answer; > > asm volatile("fdiv %0, %1, %2" : "+f"(c.d) : "f"(1.0), "f"(0.0)); > >

Re: [Qemu-devel] [PATCH 0/2] dirty bitmap fixes

2018-06-25 Thread John Snow
On 06/25/2018 12:57 PM, Vladimir Sementsov-Ogievskiy wrote: > Vladimir Sementsov-Ogievskiy (2): > block/dirty-bitmap: add bdrv_enable_dirty_bitmap_locked > dirty-bitmap: fix double lock on bitmap enabling > > include/block/dirty-bitmap.h | 1 + > block/dirty-bitmap.c | 12

Re: [Qemu-devel] [PATCH 0/2] dirty bitmap fixes

2018-06-25 Thread John Snow
On 06/25/2018 12:57 PM, Vladimir Sementsov-Ogievskiy wrote: > Vladimir Sementsov-Ogievskiy (2): > block/dirty-bitmap: add bdrv_enable_dirty_bitmap_locked > dirty-bitmap: fix double lock on bitmap enabling > > include/block/dirty-bitmap.h | 1 + > block/dirty-bitmap.c | 12

Re: [Qemu-devel] [PULL 1/1] ahci: fix FIS I bit and PIO Setup FIS interrupt

2018-06-25 Thread John Snow
Michael: It's probably much too late to include this in the 2.12.1 roundup, isn't it? I'd either push for you to include this fix OR to drop the other ATAPI related fix... --js On 06/25/2018 05:11 PM, John Snow wrote: > From: Paolo Bonzini > > The "I" bit in PIO Setup and D2H FISes is exclusiv

[Qemu-devel] [PULL 0/1] Ide patches

2018-06-25 Thread John Snow
The following changes since commit 35e238c9330669882487f9929e0aa97900431853: Merge remote-tracking branch 'remotes/kraxel/tags/audio-20180625-pull-request' into staging (2018-06-25 15:25:26 +0100) are available in the Git repository at: https://github.com/jnsnow/qemu.git tag

[Qemu-devel] [PULL 1/1] ahci: fix FIS I bit and PIO Setup FIS interrupt

2018-06-25 Thread John Snow
From: Paolo Bonzini The "I" bit in PIO Setup and D2H FISes is exclusively a device concept and the irqstatus register in the controller does not matter. The SATA spec says when it should be one; for D2H FISes in practice it is always set, while the PIO Setup FIS has several subcases that are doc

Re: [Qemu-devel] [PATCH 1/2] ide/hw/core: fix crash on processing a partial-sector-size DMA xfer

2018-06-25 Thread John Snow
On 06/20/2018 12:29 AM, Amol Surati wrote: > Fixes: https://bugs.launchpad.net/qemu/+bug/1777315 > > QEMU's short PRD policy applies to a DMA transfer of size < 512 bytes. > But it fails to consider transfers which are >= 512 bytes, but are > not a multiple of 512 bytes. > > Such transfers are

Re: [Qemu-devel] [PATCH] fix fdiv instruction

2018-06-25 Thread Richard Henderson
On Mon, Jun 25, 2018, 08:23 G 3 wrote: > > > > Try > > > > uint64_t expected_answer = 0xdeadbeef; > > ... > > c.i = expected_answer; > > asm volatile("fdiv %0, %1, %2" : "+f"(c.d) : "f"(1.0), "f"(0.0)); > > > > to avoid depending on uninitialized data. (This expected valu

Re: [Qemu-devel] [PATCH v3 5/5] tests/tcg/aarch64: userspace system register test

2018-06-25 Thread Alex Bennée
Alex Bennée writes: > This tests a bunch of registers that the kernel allows userspace to > read including the CPUID registers. > > Signed-off-by: Alex Bennée > --- > tests/tcg/aarch64/Makefile.target | 2 +- > tests/tcg/aarch64/sysregs.c | 99 +++ > 2 files

[Qemu-devel] [PATCH 1/1] target/m68k: correctly disassemble move16

2018-06-25 Thread Laurent Vivier
"move16 %a0@+,%a1@" and "fmovel (cpid=3) %a0@-,%fpcr" share the same opcode. To fix that, backport the fix from binutils: 2005-11-10 Andreas Schwab * m68k-dis.c (print_insn_m68k): Only match FPU insns with coprocessor ID 1. Reported-by: Thomas Huth Signed-off-by: Laurent Vivier

[Qemu-devel] [PATCH 0/1] target/m68k: correctly disassemble move16

2018-06-25 Thread Laurent Vivier
"move16 %a0@+,%a1@" and "fmovel (cpid=3) %a0@-,%fpcr" share the same opcode... but QEMU executes move16 (and M68040 too). You can try: --8<--- move16.S .data src: .long 0x01020304, 0x05060708, 0x090a0b0c, 0x0d0e0f00 dst: .lo

Re: [Qemu-devel] [PATCH] qemu-img: align is_allocated_sectors to 4k

2018-06-25 Thread Peter Lieven
Am 11.06.2018 um 16:04 schrieb Max Reitz: > On 2018-06-11 15:59, Peter Lieven wrote: >> Am 11.06.2018 um 15:30 schrieb Max Reitz: >>> On 2018-06-07 14:46, Peter Lieven wrote: We currently don't enforce that the sparse segments we detect during convert are aligned. This leads to unnec

[Qemu-devel] [PULL 0/9] Target MIPS queue, 2018-06-25

2018-06-25 Thread Aleksandar Markovic
From: Aleksandar Markovic The following changes since commit 35e238c9330669882487f9929e0aa97900431853: Merge remote-tracking branch 'remotes/kraxel/tags/audio-20180625-pull-request' into staging (2018-06-25 15:25:26 +0100) are available in the git repository at: https://

[Qemu-devel] [PULL 3/9] hw/mips/mips_malta: don't make bios region 'nomigrate'

2018-06-25 Thread Aleksandar Markovic
From: Peter Maydell Currently we use memory_region_init_rom_nomigrate() to create the "bios.1fc" memory region, and we don't manually register it with vmstate_register_ram(). This currently means that its contents are migrated but as a ram block whose name is the empty string; in future it may me

[Qemu-devel] [PULL 5/9] target/mips: Raise a RI when given fs is n/a from CTC1

2018-06-25 Thread Aleksandar Markovic
From: Yongbok Kim Fix to raise a Reserved Instruction exception when given fs is not available from CTC1. Signed-off-by: Yongbok Kim Reviewed-by: Aleksandar Markovic Signed-off-by: Aleksandar Markovic --- target/mips/op_helper.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/m

[Qemu-devel] [PULL 2/9] hw/mips/boston: don't make flash region 'nomigrate'

2018-06-25 Thread Aleksandar Markovic
From: Peter Maydell Currently we use memory_region_init_rom_nomigrate() to create the "boston.flash" memory region, and we don't manually register it with vmstate_register_ram(). This currently means that its contents are migrated but as a ram block whose name is the empty string; in future it ma

[Qemu-devel] [PULL 1/9] MAINTAINERS: update target-mips maintainers

2018-06-25 Thread Aleksandar Markovic
From: Aleksandar Markovic Yongbok Kim transfers duties of QEMU for target MIPS maintainer to myself as he leaves MIPS. Many thanks to Yongbok for his substantial contributing to QEMU for MIPS over many years and taking care of its maintainance for almost two years. Signed-off-by: Aleksandar Mark

[Qemu-devel] [PULL 7/9] target/mips: Update gen_flt_ldst()

2018-06-25 Thread Aleksandar Markovic
From: Yongbok Kim Update gen_flt_ldst() in order to reuse the functions for nanoMIPS Signed-off-by: Yongbok Kim Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar Markovic Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 15 +++ 1 file changed, 7 inserti

[Qemu-devel] [PULL 6/9] target/mips: Fix microMIPS on reset

2018-06-25 Thread Aleksandar Markovic
From: Yongbok Kim Fix to activate microMIPS (and nanoMIPS) on reset when Config3.ISA == {1, 3} Signed-off-by: Yongbok Kim Reviewed-by: Aleksandar Markovic Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/mips/trans

[Qemu-devel] [PULL 4/9] hw/pci-host/xilinx-pcie: don't make "io" region be RAM

2018-06-25 Thread Aleksandar Markovic
From: Peter Maydell Currently we use memory_region_init_rom_nomigrate() to create the "io" memory region to pass to pci_register_root_bus(). This is a dummy region, because this PCI controller doesn't support accesses to PCI IO space. There is no reason for the dummy region to be a RAM region; i

[Qemu-devel] [PULL 8/9] target/mips: Fix data type for offset

2018-06-25 Thread Aleksandar Markovic
From: Yongbok Kim Offset can be larger than 16 bit from nanoMIPS, and immediate field can be larger than 16 bits as well. Signed-off-by: Yongbok Kim Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar Markovic Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 8 --

[Qemu-devel] [PULL 9/9] target/mips: Fix gdbstub to read/write 64 bit FP registers

2018-06-25 Thread Aleksandar Markovic
From: Yongbok Kim Fix gdbstub to read/write 64 bit FP registers Signed-off-by: Yongbok Kim Reviewed-by: Aleksandar Markovic Signed-off-by: Aleksandar Markovic --- target/mips/gdbstub.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/mips/gdbstub.c b/target/mips/g

Re: [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore

2018-06-25 Thread Eduardo Habkost
On Mon, Jun 25, 2018 at 08:26:28PM +0200, Paolo Bonzini wrote: > On 25/06/2018 19:30, Eduardo Habkost wrote: > >>> Attentive distros could even replace the wrapper script by a link. > >> If they are okay with replacing the "KVM only" semantics with "KVM or > >> TCG", which I think is generally wors

Re: [Qemu-devel] Choosing PCR banks for swtpm's TPM 2

2018-06-25 Thread Stefan Berger
On 06/25/2018 11:05 AM, Stefan Berger wrote: Hi!  I am sending this email to solicit input on the choice of the PCR banks to enable for swtpm's TPM 2. I have currently enabled 4 PCR banks for SHA{1,256,384,512}. The downside of this is that running the TPM 2 with so many PCR banks has a perfo

Re: [Qemu-devel] [PATCH] s390/boot: block uncompressed vmlinux booting attempts

2018-06-25 Thread Guenter Roeck
On Mon, Jun 25, 2018 at 05:09:19PM +0200, Vasily Gorbik wrote: > Since uncompressed kernel image "vmlinux" elf file is not bootable under > qemu anymore, add a check which would report that. > > Qemu users are encouraged to use bzImage or > arch/s390/boot/compressed/vmlinux instead. > > The check

Re: [Qemu-devel] [PATCH] Deprecate the -enable-hax option

2018-06-25 Thread Stefan Weil
Am 25.06.2018 um 20:28 schrieb Paolo Bonzini: > On 25/06/2018 20:22, Thomas Huth wrote: >> We currently have got three ways of turning on the HAX accelerator: >> "-machine accel=hax", "-accel hax" and "-enable-hax". That's really >> confusing and overloaded. Since "-accel" is our preferred way to e

[Qemu-devel] [Bug 1331859] Re: QEMU kernel panic on Windows with arithmetic syntax error

2018-06-25 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscrib

Re: [Qemu-devel] [PATCH v2] Show values and description when using "qom-list"

2018-06-25 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> Markus Armbruster writes: >> >> > Andreas Färber writes: >> > >> >> Am 08.06.2018 um 11:41 schrieb Dr. David Alan Gilbert: >> >>> * Andreas Färber (afaer...@suse.de) wrote: >> Am 01.06.2018 um 17:39 schri

Re: [Qemu-devel] [PATCH] Deprecate the -enable-hax option

2018-06-25 Thread Paolo Bonzini
On 25/06/2018 20:22, Thomas Huth wrote: > We currently have got three ways of turning on the HAX accelerator: > "-machine accel=hax", "-accel hax" and "-enable-hax". That's really > confusing and overloaded. Since "-accel" is our preferred way to enable > an accelerator nowadays, and "-accel hax" i

Re: [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore

2018-06-25 Thread Paolo Bonzini
On 25/06/2018 19:30, Eduardo Habkost wrote: >>> Attentive distros could even replace the wrapper script by a link. >> If they are okay with replacing the "KVM only" semantics with "KVM or >> TCG", which I think is generally worse. > > If we can't get agreement on what's the right default for each >

[Qemu-devel] [PATCH] Deprecate the -enable-hax option

2018-06-25 Thread Thomas Huth
We currently have got three ways of turning on the HAX accelerator: "-machine accel=hax", "-accel hax" and "-enable-hax". That's really confusing and overloaded. Since "-accel" is our preferred way to enable an accelerator nowadays, and "-accel hax" is even less to type than "-enable-hax", let's de

[Qemu-devel] map host MMIO address to guest

2018-06-25 Thread Huaicheng Li
Hi all, I'm trying to map a host MMIO region (host PCIe device BAR) into guest physical address space. The goal is to enable direct control over that host MMIO region from guest OS by accessing a certain GPA. I know the address of the host MMIO region (one page). First I map the page into QEMU pr

Re: [Qemu-devel] [PATCH] migration: invalidate cache before source start

2018-06-25 Thread John Snow
On 06/25/2018 01:50 PM, Dr. David Alan Gilbert wrote: > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: >> * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: >>> 15.06.2018 15:06, Dr. David Alan Gilbert wrote: * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wro

Re: [Qemu-devel] [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-25 Thread Samudrala, Sridhar
On 6/22/2018 5:17 PM, Siwei Liu wrote: On Fri, Jun 22, 2018 at 4:40 PM, Siwei Liu wrote: On Fri, Jun 22, 2018 at 3:25 PM, Michael S. Tsirkin wrote: On Fri, Jun 22, 2018 at 02:51:11PM -0700, Siwei Liu wrote: On Fri, Jun 22, 2018 at 2:29 PM, Michael S. Tsirkin wrote: On Fri, Jun 22, 2018 at

Re: [Qemu-devel] [PATCH] migration: invalidate cache before source start

2018-06-25 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > > 15.06.2018 15:06, Dr. David Alan Gilbert wrote: > > > * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > > > > Invalidate cache before source start in case of

Re: [Qemu-devel] [PATCH v5 18/35] target/arm: Implement SVE Floating Point Multiply Indexed Group

2018-06-25 Thread Peter Maydell
On 21 June 2018 at 02:53, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper.h| 14 +++ > target/arm/translate-sve.c | 50 ++ > target/arm/vec_helper.c| 48 > target/ar

Re: [Qemu-devel] [Bug 1778350] Re: Android-x86 4.4-r5 won't boot on QEMU since v2.11.0-rc2

2018-06-25 Thread John Snow
CC Michael Tsirkin On 06/25/2018 06:53 AM, navicrej wrote: > After 'git bisect' -ing it I found the commit that is responsible for > this: > > https://git.qemu.org/?p=qemu.git;a=commitdiff;h=9fa99d2519cbf71f871e46871df12cb446dc1c3e >

[Qemu-devel] [PATCH v5] ssh: switch from libssh2 to libssh

2018-06-25 Thread Pino Toscano
Rewrite the implementation of the ssh block driver to use libssh instead of libssh2. The libssh library has various advantages over libssh2: - easier API for authentication (for example for using ssh-agent) - easier API for known_hosts handling - supports newer types of keys in known_hosts Kerber

Re: [Qemu-devel] [PATCH v4] ssh: switch from libssh2 to libssh

2018-06-25 Thread Pino Toscano
On Tuesday, 13 February 2018 19:49:12 CET Max Reitz wrote: > On 2018-01-18 17:44, Pino Toscano wrote: > > Rewrite the implementation of the ssh block driver to use libssh instead > > of libssh2. The libssh library has various advantages over libssh2: > > - easier API for authentication (for exampl

Re: [Qemu-devel] block/dirty-bitmap: Useless bitmaps in image can be removed

2018-06-25 Thread John Snow
On 06/24/2018 11:36 PM, 13466399...@163.com wrote: > If qemu-kvm quit without saving bitmaps to image(coredump, host kernel panic, > or host pooweroff), bitmaps in image can not be safely used anymore, and also > can not be removed. Useless bitmaps should be removed. > > Signed-off-by: yaoxu <1

Re: [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore

2018-06-25 Thread Eduardo Habkost
On Mon, Jun 25, 2018 at 12:28:34PM +0200, Paolo Bonzini wrote: > On 25/06/2018 08:50, Markus Armbruster wrote: > > Paolo Bonzini writes: > > > >> On 22/06/2018 21:35, Eduardo Habkost wrote: > > Why is this better than using KVM by default if it's available? > The answer is (as almost alw

Re: [Qemu-devel] [PATCH v5 17/35] target/arm: Implement SVE floating-point arithmetic with immediate

2018-06-25 Thread Peter Maydell
On 21 June 2018 at 02:53, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 56 > target/arm/sve_helper.c| 69 +++ > target/arm/translate-sve.c | 75 +++

Re: [Qemu-devel] [PATCH v5 16/35] target/arm: Implement SVE floating-point compare vectors

2018-06-25 Thread Peter Maydell
On 21 June 2018 at 02:53, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 49 ++ > target/arm/sve_helper.c| 62 ++ > target/arm/translate-sve.c | 40 > ta

Re: [Qemu-devel] [RFC PATCH] docker: Add debian-xtensa-cross image

2018-06-25 Thread Philippe Mathieu-Daudé
On 06/25/2018 02:18 PM, Max Filippov wrote: > On Mon, Jun 25, 2018 at 10:10 AM, Philippe Mathieu-Daudé > wrote: >> On 06/25/2018 01:59 PM, Emilio G. Cota wrote: >>> On Sat, Jun 23, 2018 at 20:24:09 -0700, Max Filippov wrote: # first bad commit: [0b5c91f74f3c83a36f37740969df8c775c997e69]

Re: [Qemu-devel] [PATCH] crypto: Implement TLS Pre-Shared Keys (PSK).

2018-06-25 Thread Daniel P . Berrangé
On Mon, Jun 25, 2018 at 06:07:15PM +0100, Richard W.M. Jones wrote: > Pre-Shared Keys (PSK) is a simpler mechanism for enabling TLS > connections than using certificates. It requires only a simple secret > key: > > $ mkdir -m 0700 /tmp/keys > $ psktool -u rjones -p /tmp/keys/keys.psk > $ ca

Re: [Qemu-devel] [PATCH] nbd/client: add x-block-status hack for testing server

2018-06-25 Thread John Snow
On 06/25/2018 09:50 AM, Max Reitz wrote: > On 2018-06-21 05:25, Eric Blake wrote: >> In order to test that the NBD server is properly advertising >> dirty bitmaps, we need a bare minimum client that can request >> and read the context. This patch is a hack (hence the use of >> the x- prefix) tha

Re: [Qemu-devel] [PATCH] translate-all: fix locking of TBs whose two pages share the same physical page

2018-06-25 Thread Philippe Mathieu-Daudé
On 06/25/2018 01:31 PM, Emilio G. Cota wrote: > Commit 0b5c91f ("translate-all: use per-page locking in !user-mode", > 2018-06-15) introduced per-page locking. It assumed that the physical > pages corresponding to a TB (at most two pages) are always distinct, > which is wrong. For instance, an xten

Re: [Qemu-devel] [RFC PATCH] docker: Add debian-xtensa-cross image

2018-06-25 Thread Max Filippov
On Mon, Jun 25, 2018 at 10:10 AM, Philippe Mathieu-Daudé wrote: > On 06/25/2018 01:59 PM, Emilio G. Cota wrote: >> On Sat, Jun 23, 2018 at 20:24:09 -0700, Max Filippov wrote: >>> # first bad commit: [0b5c91f74f3c83a36f37740969df8c775c997e69] >>> translate-all: use per-page locking in !user-mode >>

Re: [Qemu-devel] [PATCH] migration: invalidate cache before source start

2018-06-25 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > 15.06.2018 15:06, Dr. David Alan Gilbert wrote: > > * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > > > Invalidate cache before source start in case of failed migration. > > > > > > Signed-off-by: Vladimir Sement

Re: [Qemu-devel] [PATCH v4 1/3] hw/block/fdc: Replace error_setg(&error_abort) by assert()

2018-06-25 Thread John Snow
On 06/25/2018 12:57 PM, Philippe Mathieu-Daudé wrote: > Use assert() instead of error_setg(&error_abort), > as suggested by the "qapi/error.h" documentation: > > Please don't error_setg(&error_fatal, ...), use error_report() and > exit(), because that's more obvious. > Likewise, don

Re: [Qemu-devel] [PATCH v5 14/35] target/arm: Implement SVE first-fault gather loads

2018-06-25 Thread Peter Maydell
On 21 June 2018 at 02:53, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/arm/helper-sve.h| 67 > target/arm/sve_helper.c| 88 ++ > target/arm/translate-sve.c | 126 - > 3 files

Re: [Qemu-devel] [RFC PATCH] docker: Add debian-xtensa-cross image

2018-06-25 Thread Philippe Mathieu-Daudé
On 06/25/2018 01:59 PM, Emilio G. Cota wrote: > On Sat, Jun 23, 2018 at 20:24:09 -0700, Max Filippov wrote: >> # first bad commit: [0b5c91f74f3c83a36f37740969df8c775c997e69] >> translate-all: use per-page locking in !user-mode >> >> Emilio, could you please take a look? The following test locks up

[Qemu-devel] [PATCH v4 0/3] qapi/error: converts error_setg(&error_fatal) to error_report() + exit()

2018-06-25 Thread Philippe Mathieu-Daudé
Hi, This series converts error_setg(&error_fatal) to error_report() + exit() as suggested by the "qapi/error.h" documentation. This reduce Coverity and Clang static analyzer positive falses. See http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg07585.html: On 07/24/2017 04:52 PM, E

[Qemu-devel] [PATCH] crypto: Implement TLS Pre-Shared Keys (PSK).

2018-06-25 Thread Richard W.M. Jones
Pre-Shared Keys (PSK) is a simpler mechanism for enabling TLS connections than using certificates. It requires only a simple secret key: $ mkdir -m 0700 /tmp/keys $ psktool -u rjones -p /tmp/keys/keys.psk $ cat /tmp/keys/keys.psk rjones:d543770c15ad93d76443fb56f501a31969235f47e999720ae8d2

[Qemu-devel] [PATCH] crypto: Implement TLS Pre-Shared Keys (PSK).

2018-06-25 Thread Richard W.M. Jones
TLS-PSK (Pre-Shared Keys) lets us set up TLS connections much more easily, especially for NBD. This is a "version 0" of the patch for now, mainly to solicit comments. It needs documentation at least. Rich.

[Qemu-devel] [PATCH 1/2] block/dirty-bitmap: add bdrv_enable_dirty_bitmap_locked

2018-06-25 Thread Vladimir Sementsov-Ogievskiy
Add _locked version of bdrv_enable_dirty_bitmap, to fix dirty bitmap migration in the following patch. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/dirty-bitmap.h | 1 + block/dirty-bitmap.c | 9 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/in

  1   2   3   4   >