[Qemu-devel] [PULL 17/35] target/ppc: Split out gen_load_locked

2018-07-02 Thread David Gibson
From: Richard Henderson Leave only the minimal amount of code within the LDAR macro, moving the rest of the code into gen_load_locked. Use MO_ALIGN and remove the explicit call to gen_check_align. Signed-off-by: Richard Henderson Signed-off-by: David Gibson --- target/ppc/translate.c | 35

[Qemu-devel] [PULL 01/35] mac_dbdma: only dump commands for debug enabled channels

2018-07-02 Thread David Gibson
From: Mark Cave-Ayland This enables us to apply the same filter in DEBUG_DBDMA_CHANMASK to the DBDMA command execution debug output. Signed-off-by: Mark Cave-Ayland Signed-off-by: David Gibson --- hw/misc/macio/mac_dbdma.c | 21 +++-- 1 file changed, 11 insertions(+), 10

[Qemu-devel] [PULL 10/35] ppc/pnv: fix pnv_core_realize() error handling

2018-07-02 Thread David Gibson
From: Cédric Le Goater commit d35aefa9ae15 ("ppc/pnv: introduce a new intc_create() operation to the chip model") changed the object link in the pnv_core_realize() routine but a return was forgotten in case of error, which can lead to more problems afterwards (segv) Signed-off-by: Cédric Le

[Qemu-devel] [PULL 00/35] ppc-for-3.0 queue 20180703

2018-07-02 Thread David Gibson
The following changes since commit ab08440a4ee09032d1a9cb22fdcab23bc7e1c656: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180702' into staging (2018-07-02 17:57:46 +0100) are available in the Git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-3.0-20180703

Re: [Qemu-devel] [PATCH v0 0/7] Background snapshots

2018-07-02 Thread Peter Xu
On Mon, Jul 02, 2018 at 03:40:31PM +0300, Denis Plotnikov wrote: > > > On 02.07.2018 14:23, Peter Xu wrote: > > On Fri, Jun 29, 2018 at 11:03:13AM +0300, Denis Plotnikov wrote: > > > The patch set adds the ability to make external snapshots while VM is > > > running. > > > > Hi, Denis, > > >

Re: [Qemu-devel] [PATCH 2/2] qapi: Drop qapi-gen --unmask option

2018-07-02 Thread Markus Armbruster
Eric Blake writes: > On 07/02/2018 01:48 PM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Now that we have useful access to the type name as a comment >>> in the generated qapi-introspect.c, we don't need to regenerate >>> code with a temporary -u option just to get at type names. >>>

Re: [Qemu-devel] [PULL, 14/18] translate-all: discard TB when tb_link_page returns an existing matching TB

2018-07-02 Thread Pavel Dovgalyuk
> From: Emilio G. Cota [mailto:c...@braap.org] > On Mon, Jul 02, 2018 at 08:52:14 +0300, Pavel Dovgalyuk wrote: > > The same failure can be reproduced with linux-0.2.img, which was > > downloaded from QEMU site. > > I can't find it now, but I can upload this file if needed. > > Please upload it

Re: [Qemu-devel] [PATCH 1/2] qapi: Add comments to aid debugging generated introspection

2018-07-02 Thread Markus Armbruster
Eric Blake writes: > On 07/02/2018 01:43 PM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 06/29/2018 02:55 PM, Eric Blake wrote: We consciously chose in commit 1a9a507b to hide QAPI type names from the generated introspection output, but added a command line option -u

Re: [Qemu-devel] [PATCH 00/32] qmp: Fixes and cleanups around OOB commands

2018-07-02 Thread Markus Armbruster
Copying Michael Roth for the qemu-ga parts, belatedly.

[Qemu-devel] [PATCH] module: Use QEMU_MODULE_PATH as a search path

2018-07-02 Thread ryang
The current paths for modules are CONFIG_QEMU_MODDIR and paths relative to the executable. Qemu and its modules can be installed and executed in paths that are different from these search paths. This change allows a search path to be specified by environment variable. An example usage for this is

Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

2018-07-02 Thread David Gibson
On Mon, Jul 02, 2018 at 09:42:49AM +0200, Sebastian Bauer wrote: > Am 2018-07-02 07:22, schrieb David Gibson: > > And now unapplied, since it breaks make check all over the place for > > ppc64-softmmu. > > > > Please folks, running an all-targets make check is really the > > *minimum* bar for

[Qemu-devel] [PATCH] ui/cocoa.m: replace scrollingDeltaY with deltaY

2018-07-02 Thread John Arbuckle
The NSEvent class method scrollingDeltaY is available for Mac OS 10.7 and newer. Since QEMU supports Mac OS 10.5 and up, we need to be using a method that is available on these version of Mac OS X. The deltaY method is a method that does the same thing as scrollingDeltaY and is available on Mac

Re: [Qemu-devel] [PATCH] migration: add capability to bypass the shared memory

2018-07-02 Thread Peng Tao
On Tue, Jul 3, 2018 at 6:15 AM, Andrea Arcangeli wrote: > Hello, > > On Mon, Jul 02, 2018 at 09:52:08PM +0800, Peng Tao wrote: >> I think we can write some host generated random seeds to guest's >> urandom device, when cloning VMs from the same template before handing >> it to users. Is it enough

Re: [Qemu-devel] [PATCH v2] e1000e: Prevent MSI/MSI-X storms

2018-07-02 Thread Jason Wang
On 2018年07月02日 13:14, Jan Kiszka wrote: On 2018-07-02 05:40, Jason Wang wrote: On 2018年06月30日 14:13, Jan Kiszka wrote: On 2018-04-05 19:41, Jan Kiszka wrote: From: Jan Kiszka Only signal MSI/MSI-X events on rising edges. So far we re-triggered the interrupt sources even if the guest did

Re: [Qemu-devel] [PATCH 06/12] migration: do not detect zero page for compression

2018-07-02 Thread Xiao Guangrong
On 06/29/2018 05:42 PM, Dr. David Alan Gilbert wrote: * Xiao Guangrong (guangrong.x...@gmail.com) wrote: Hi Peter, Sorry for the delay as i was busy on other things. On 06/19/2018 03:30 PM, Peter Xu wrote: On Mon, Jun 04, 2018 at 05:55:14PM +0800, guangrong.x...@gmail.com wrote: From:

[Qemu-devel] [PULL 3/3] backup: Use copy offloading

2018-07-02 Thread Jeff Cody
From: Fam Zheng The implementation is similar to the 'qemu-img convert'. In the beginning of the job, offloaded copy is attempted. If it fails, further I/O will go through the existing bounce buffer code path. Then, as Kevin pointed out, both this and qemu-img convert can benefit from a local

[Qemu-devel] [PULL 1/3] block: Fix parameter checking in bdrv_co_copy_range_internal

2018-07-02 Thread Jeff Cody
From: Fam Zheng src may be NULL if BDRV_REQ_ZERO_WRITE flag is set, in this case only check dst and dst->bs. This bug was introduced when moving in the request tracking code from bdrv_co_copy_range, in 37aec7d75eb. This especially fixes the possible segfault when initializing src_bs with a NULL

[Qemu-devel] [PULL 2/3] block: Honour BDRV_REQ_NO_SERIALISING in copy range

2018-07-02 Thread Jeff Cody
From: Fam Zheng This semantics is needed by drive-backup so implement it before using this API there. Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng Message-id: 20180703023758.14422-3-f...@redhat.com Signed-off-by: Jeff Cody --- block/io.c| 6 -- include/block/block.h

[Qemu-devel] [PULL 0/3] Block patches

2018-07-02 Thread Jeff Cody
The following changes since commit ab08440a4ee09032d1a9cb22fdcab23bc7e1c656: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180702' into staging (2018-07-02 17:57:46 +0100) are available in the Git repository at: git://github.com/codyprime/qemu-kvm-jtc.git tags/block-pull

Re: [Qemu-devel] [PATCH] target/ppc: set is_jmp on ppc_tr_breakpoint_check

2018-07-02 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 1530568927-4738-1-git-send-email-c...@braap.org Subject: [Qemu-devel] [PATCH] target/ppc: set is_jmp on ppc_tr_breakpoint_check === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: set is_jmp on ppc_tr_breakpoint_check

2018-07-02 Thread David Gibson
On Mon, Jul 02, 2018 at 11:22:57PM -0400, Emilio G. Cota wrote: > On Tue, Jul 03, 2018 at 11:03:48 +1000, David Gibson wrote: > > On Mon, Jul 02, 2018 at 06:02:07PM -0400, Emilio G. Cota wrote: > > > The use of GDB breakpoints was broken by b0c2d52 ("target/ppc: convert > > > to TranslatorOps",

Re: [Qemu-devel] [PATCH 07/32] qmp: Make "id" optional again even in "oob" monitors

2018-07-02 Thread Peter Xu
On Mon, Jul 02, 2018 at 06:21:53PM +0200, Markus Armbruster wrote: > Commit cf869d53172 "qmp: support out-of-band (oob) execution" made > "id" mandatory for all commands when the client accepted capability > "oob". This is rather onerous when you play with QMP by hand, and > unnecessarily so:

Re: [Qemu-devel] [PATCH v4 0/3] backup: Use copy offloading

2018-07-02 Thread Jeff Cody
On Tue, Jul 03, 2018 at 10:37:55AM +0800, Fam Zheng wrote: > v4: Rebase to master. > Pick up Stefan's rev-bys. > Include a block/io.c fix to fix a new issue caused by recent block/io.c > change - our drive-backup cases in iotests exposes the bug loudly. > > This enhances the backup

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: set is_jmp on ppc_tr_breakpoint_check

2018-07-02 Thread Emilio G. Cota
On Tue, Jul 03, 2018 at 11:03:48 +1000, David Gibson wrote: > On Mon, Jul 02, 2018 at 06:02:07PM -0400, Emilio G. Cota wrote: > > The use of GDB breakpoints was broken by b0c2d52 ("target/ppc: convert > > to TranslatorOps", 2018-02-16). > > > > Fix it by setting is_jmp, so that we break from the

Re: [Qemu-devel] [PATCH v4 1/3] block: Fix parameter checking in bdrv_co_copy_range_internal

2018-07-02 Thread Jeff Cody
On Tue, Jul 03, 2018 at 10:37:56AM +0800, Fam Zheng wrote: > src may be NULL if BDRV_REQ_ZERO_WRITE flag is set, in this case only > check dst and dst->bs. This bug was introduced when moving in the > request tracking code from bdrv_co_copy_range, in 37aec7d75eb. > > This especially fixes the

Re: [Qemu-devel] [virtio-dev] [PATCH v3 2/3] Add "Group Identifier" support to Red Hat PCI bridge.

2018-07-02 Thread Siwei Liu
On Fri, Jun 29, 2018 at 3:19 PM, Venu Busireddy wrote: > Add the "Vendor-Specific" capability to the Red Hat PCI bridge device > "pci-bridge", to contain the "Group Identifier" that will be used to pair > a virtio device with the passthrough device attached to that bridge. Also, > change the

[Qemu-devel] [Bug 1779634] Re: qemu-x86_64 on aarch64 reports "Synchronous External Abort"

2018-07-02 Thread He Yi
Thanks very much @Peter Maydell, when invoking these tools through docker/qemu-user I really saw syscall disorders, even strace fails. You are right these tools have x86_64 syscall numbers & perhaps mmaps of /dev/mem to allocate contiguous memory region for DMA transactions. Then the goal cannot

[Qemu-devel] [PATCH v4 3/3] backup: Use copy offloading

2018-07-02 Thread Fam Zheng
The implementation is similar to the 'qemu-img convert'. In the beginning of the job, offloaded copy is attempted. If it fails, further I/O will go through the existing bounce buffer code path. Then, as Kevin pointed out, both this and qemu-img convert can benefit from a local check if one

[Qemu-devel] [PATCH v4 1/3] block: Fix parameter checking in bdrv_co_copy_range_internal

2018-07-02 Thread Fam Zheng
src may be NULL if BDRV_REQ_ZERO_WRITE flag is set, in this case only check dst and dst->bs. This bug was introduced when moving in the request tracking code from bdrv_co_copy_range, in 37aec7d75eb. This especially fixes the possible segfault when initializing src_bs with a NULL src.

Re: [Qemu-devel] [PATCH 32/32] qapi: Polish command flags documentation in qapi-code-gen.txt

2018-07-02 Thread Eric Blake
On 07/02/2018 11:22 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- docs/devel/qapi-code-gen.txt | 61 +++- 1 file changed, 25 insertions(+), 36 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat,

[Qemu-devel] [PATCH v4 2/3] block: Honour BDRV_REQ_NO_SERIALISING in copy range

2018-07-02 Thread Fam Zheng
This semantics is needed by drive-backup so implement it before using this API there. Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- block/io.c| 6 -- include/block/block.h | 5 +++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/block/io.c

[Qemu-devel] [PATCH v4 0/3] backup: Use copy offloading

2018-07-02 Thread Fam Zheng
v4: Rebase to master. Pick up Stefan's rev-bys. Include a block/io.c fix to fix a new issue caused by recent block/io.c change - our drive-backup cases in iotests exposes the bug loudly. This enhances the backup job to make use of the copy offloading API. It eliminates the necessity

Re: [Qemu-devel] [PATCH 31/32] monitor: Improve some comments

2018-07-02 Thread Eric Blake
On 07/02/2018 11:22 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- monitor.c | 100 -- 1 file changed, 45 insertions(+), 55 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat,

Re: [Qemu-devel] [PATCH 30/32] qmp: Clean up capability negotiation after commit 02130314d8c

2018-07-02 Thread Eric Blake
On 07/02/2018 11:22 AM, Markus Armbruster wrote: qmp_greeting() offers capabilities to the client, and qmp_qmp_capabilities() accepts or denies capabilities requested by the client. The two compute the set of available capabilities independently. Not nice. Clean this up as follows. Compute

Re: [Qemu-devel] [PATCH 29/32] qobject: Let qobject_from_jsonf() fail instead of abort

2018-07-02 Thread Eric Blake
On 07/02/2018 11:22 AM, Markus Armbruster wrote: qobject_from_jsonf() aborts on error, unlike qobject_from_jsonv(), which returns null. Since all remaining users of qobject_from_jsonf() cope fine with null, change it to return null. Signed-off-by: Markus Armbruster --- qobject/qjson.c | 5

Re: [Qemu-devel] [PATCH 28/32] qmp: Switch timestamp_put() to qdict_from_jsonf_nofail()

2018-07-02 Thread Eric Blake
On 07/02/2018 11:22 AM, Markus Armbruster wrote: There's just one use of qobject_from_jsonf() to parse a JSON object left: timestamp_put(). Switch it to qdict_from_jsonf_nofail(). Signed-off-by: Markus Armbruster --- qapi/qmp-event.c | 10 +- 1 file changed, 5 insertions(+), 5

Re: [Qemu-devel] [PATCH 27/32] qmp: Add some comments around null responses

2018-07-02 Thread Eric Blake
On 07/02/2018 11:22 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- qapi/qmp-dispatch.c | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Eric Blake diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c index 761812e924..6f2d466596 100644 --- a/qapi/qmp-dispatch.c

Re: [Qemu-devel] [PATCH 26/32] qmp: Simplify monitor_qmp_respond()

2018-07-02 Thread Eric Blake
On 07/02/2018 11:22 AM, Markus Armbruster wrote: monitor_qmp_respond() takes both a response object and an error object. If an error object is non-null, the response object must be null, and the response is built from the error object. Of the two callers, one always passes a null response

Re: [Qemu-devel] [PATCH 25/32] qmp: Replace get_qmp_greeting() by qmp_greeting()

2018-07-02 Thread Eric Blake
On 07/02/2018 11:22 AM, Markus Armbruster wrote: get_qmp_greeting() returns a QDict * as QObject *. It's caller converts it right back. Return QDict * instead. While there, rename to qmp_greeting(). Signed-off-by: Markus Armbruster --- monitor.c | 13 +++-- 1 file changed, 7

Re: [Qemu-devel] [PATCH 24/32] qmp: Replace monitor_json_emitter{, raw}() by qmp_{queue, send}_response()

2018-07-02 Thread Eric Blake
On 07/02/2018 11:22 AM, Markus Armbruster wrote: monitor_json_emitter() and monitor_json_emitter_raw() are unnecessarily general: they can send arbitrary JSON values, even though we only ever use them for QMP, which may send only JSON objects. Specialize the argument from QObject * to QDict *,

Re: [Qemu-devel] [PATCH 23/32] qmp: Use QDict * instead of QObject * for response objects

2018-07-02 Thread Eric Blake
On 07/02/2018 11:22 AM, Markus Armbruster wrote: By using the more specific type, we get fewer downcasts. The downcasts are safe, but not obviously so, at least not locally. Signed-off-by: Markus Armbruster --- Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat,

Re: [Qemu-devel] [PATCH 22/32] qmp: De-duplicate error response building

2018-07-02 Thread Eric Blake
On 07/02/2018 11:22 AM, Markus Armbruster wrote: All callers of qmp_build_error_object() duplicate the code to wrap it in a response object. Replace it by qmp_error_response() that captures the duplicated code, including error_free(). Signed-off-by: Markus Armbruster ---

Re: [Qemu-devel] [PATCH 21/32] qobject: New qdict_from_jsonf_nofail()

2018-07-02 Thread Eric Blake
On 07/02/2018 11:22 AM, Markus Armbruster wrote: Many uses of qobject_from_jsonf() convert JSON objects. Create new convenience function qdict_from_jsonf_nofail() that includes the conversion to QDict. The next few commits will put it to use. Signed-off-by: Markus Armbruster ---

Re: [Qemu-devel] [PATCH 20/32] monitor: Peel off @mon_global wrapper

2018-07-02 Thread Eric Blake
On 07/02/2018 11:22 AM, Markus Armbruster wrote: Wrapping global variables in a struct without a use for the wrapper struct buys us nothing but longer lines. Unwrap them. Well, it also makes it slightly more obvious where you are using a global variable, and thus need to be careful of

Re: [Qemu-devel] [PATCH 19/32] monitor: Rename use_io_thr to use_io_thread

2018-07-02 Thread Eric Blake
On 07/02/2018 11:22 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- monitor.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/monitor.c b/monitor.c index fd83a57dda..10b6634d3e 100644 --- a/monitor.c +++ b/monitor.c @@ -206,11

Re: [Qemu-devel] [PATCH 18/32] qmp: Don't let JSON errors jump the queue

2018-07-02 Thread Eric Blake
On 07/02/2018 11:22 AM, Markus Armbruster wrote: handle_qmp_command() reports JSON syntax errors right away. This is wrong when OOB is enabled, because the errors can "jump the queue" then. The previous commit fixed the same bug for semantic errors, by delaying the checking until dispatch. We

Re: [Qemu-devel] [PATCH 17/32] qmp: Don't let malformed in-band commands jump the queue

2018-07-02 Thread Eric Blake
On 07/02/2018 11:22 AM, Markus Armbruster wrote: handle_qmp_command() reports certain errors right away. This is wrong when OOB is enabled, because the errors can "jump the queue" then, as the previous commit demonstrates. To fix, we need to delay errors until dispatch. Do that for semantic

Re: [Qemu-devel] [PATCH 16/32] tests/qmp-test: Demonstrate QMP errors jumping the queue

2018-07-02 Thread Eric Blake
On 07/02/2018 11:22 AM, Markus Armbruster wrote: When OOB is enabled, out-of-band commands are executed right away, everything else is queued. This lets out-of-band commands "jump the queue". However, certain errors are always reported right away, and therefore can jump the queue even when the

Re: [Qemu-devel] [PATCH 15/32] qmp: Simplify code around monitor_qmp_dispatch_one()

2018-07-02 Thread Eric Blake
On 07/02/2018 11:22 AM, Markus Armbruster wrote: Change monitor_qmp_dispatch_one() to take its parameters unwrapped, move monitor_resume() to the one caller that needs it, rename the function to monitor_qmp_dispatch(). Signed-off-by: Markus Armbruster --- monitor.c | 58

Re: [Qemu-devel] [PATCH 14/32] qmp: Always free QMPRequest with qmp_request_free()

2018-07-02 Thread Eric Blake
On 07/02/2018 11:22 AM, Markus Armbruster wrote: monitor_qmp_dispatch_one() frees a QMPRequest manually, because it needs to keep a reference to ->id. Premature optimization. Take an additional reference so we can use qmp_request_free(). Signed-off-by: Markus Armbruster --- monitor.c | 6

[Qemu-devel] [PATCH v2] ui/cocoa.m: prevent stuck command key when going into full screen mode

2018-07-02 Thread John Arbuckle
When the user pushes Command-F in QEMU while the mouse is ungrabbed, QEMU goes into full screen mode. When the user finally releases the command key, it is sent to the guest as an event. The makes the guest operating system think the command key is down when it is really up. To prevent this

Re: [Qemu-devel] [PATCH 13/32] qmp: Revert change to handle_qmp_command tracepoint

2018-07-02 Thread Eric Blake
On 07/02/2018 11:21 AM, Markus Armbruster wrote: Commit 71da4667db6 "monitor: separate QMP parser and dispatcher" moved the handle_qmp_command tracepoint from handle_qmp_command() to monitor_qmp_dispatch_one(). This delays tracing from enqueue time to dequeue time. Revert that. Dequeue

Re: [Qemu-devel] [PATCH 12/32] qmp: Redo how the client requests out-of-band execution

2018-07-02 Thread Eric Blake
On 07/02/2018 11:21 AM, Markus Armbruster wrote: Commit cf869d53172 "qmp: support out-of-band (oob) execution" added a general mechanism for command-independent arguments just for an out-of-band flag: The "control" key is introduced to store this extra flag. "control" field is used

Re: [Qemu-devel] [PATCH 11/32] qmp qemu-ga: Fix qemu-ga not to accept "control"

2018-07-02 Thread Eric Blake
On 07/02/2018 11:21 AM, Markus Armbruster wrote: Commit cf869d53172 "qmp: support out-of-band (oob) execution" accidentally made qemu-ga accept and ignore "control". Fix that. Out-of-band execution in a monitor that doesn't support it now fails with {"error": {"class": "GenericError",

Re: [Qemu-devel] [PATCH 10/32] tests/test-qga: Demonstrate the guest-agent ignores "control"

2018-07-02 Thread Eric Blake
On 07/02/2018 11:21 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- tests/test-qga.c | 17 + 1 file changed, 17 insertions(+) Well, if we get rid of 'control' in favor of 'exec-oob', this test would still have to test that QGA doesn't support oob.

Re: [Qemu-devel] [PATCH 1/4] tests/vm: Support proxy / corporate firewall

2018-07-02 Thread Fam Zheng
On Mon, 07/02 12:11, Philippe Mathieu-Daudé wrote: > Hi Fam, > > On 07/02/2018 04:12 AM, Fam Zheng wrote: > > On Thu, 06/28 12:35, Philippe Mathieu-Daudé wrote: > >> If ftp_proxy/http_proxy/https_proxy standard environment variables > >> are available, pass them to the vm images. > >> > >> As per

[Qemu-devel] [PULL 4/6] iotests: add 222 to test basic fleecing

2018-07-02 Thread Eric Blake
From: John Snow Signed-off-by: John Snow Message-Id: <20180702194630.9360-3-js...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Eric Blake --- tests/qemu-iotests/222 | 155 + tests/qemu-iotests/222.out | 67

[Qemu-devel] [PULL 6/6] iotests: New test 223 for exporting dirty bitmap over NBD

2018-07-02 Thread Eric Blake
Although this test is NOT a full test of image fleecing (as it intentionally uses just a single block device directly exported over NBD, rather than trying to set up a blockdev-backup job with multiple BDS involved), it DOES prove that qemu as a server is able to properly expose a dirty bitmap

[Qemu-devel] [PULL 5/6] nbd/client: Add x-dirty-bitmap to query bitmap from server

2018-07-02 Thread Eric Blake
In order to test that the NBD server is properly advertising dirty bitmaps, we need a bare minimum client that can request and read the context. Since feature freeze for 3.0 is imminent, this is the smallest workable patch, which replaces the qemu block status report with the results of the NBD

[Qemu-devel] [PULL 2/6] iscsi: Avoid potential for get_status overflow

2018-07-02 Thread Eric Blake
Detected by Coverity: Multiplying two 32-bit int and assigning the result to a 64-bit number is a risk of overflow. Prior to the conversion to byte-based interfaces, the block layer took care of ensuring that a status request never exceeded 2G in the driver; but after that conversion, the block

[Qemu-devel] [PULL 0/6] NBD patches for 2018-07-02 (3.0 soft freeze)

2018-07-02 Thread Eric Blake
The following changes since commit ab08440a4ee09032d1a9cb22fdcab23bc7e1c656: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180702' into staging (2018-07-02 17:57:46 +0100) are available in the Git repository at: git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2018-07-02 for you

[Qemu-devel] [PULL 1/6] nbd/server: Fix dirty bitmap logic regression

2018-07-02 Thread Eric Blake
In my hurry to fix a build failure, I introduced a logic bug. The assertion conditional is backwards, meaning that qemu will now abort instead of reporting dirty bitmap status. The bug can only be tickled by an NBD client using an exported dirty bitmap (which is still an experimental QMP

[Qemu-devel] [PULL 3/6] blockdev: enable non-root nodes for backup source

2018-07-02 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy This is needed to implement the image-fleecing workflow where we create a temporary node backed by an active node, then start backupdev-backup sync=none from the active node to the temp node. In this case, the active node is now a root node AND a backing node,

Re: [Qemu-devel] [Qemu-ppc] [PATCH v6 5/5] target/ppc: Relax reserved bitmask of indexed store instructions

2018-07-02 Thread David Gibson
On Fri, Jun 29, 2018 at 12:38:33AM +0200, BALATON Zoltan wrote: > The PPC440 User Manual says that if bit 31 is set, the contents of > CR[CR0] are undefined for indexed store instructions but this form is > not invalid. Other PPC variants confirming to recent ISA where this > bit may be reserved

Re: [Qemu-devel] [PATCH v2] ppc: Include vga cirrus card into the compiling process

2018-07-02 Thread David Gibson
On Mon, Jul 02, 2018 at 09:13:45PM +0200, Sebastian Bauer wrote: > Drivers for this card exists on PPC-based AmigaOS guests so it is useful to > allow users to emulate the graphics card for PPC machines. > > As cirrus vga is currently preferred over std(vga) in absence of any user > choice, this

Re: [Qemu-devel] [PATCH 0/4] block: Trivial fixes in offloading code

2018-07-02 Thread Fam Zheng
On Mon, 07/02 14:35, Max Reitz wrote: > On 2018-07-02 04:58, Fam Zheng wrote: > > These are the low priority ones spotted by Kevin and Max last week. > > > > Fam Zheng (4): > > qcow2: Drop unused cluster_data > > file-posix: Fix fd_open check in raw_co_copy_range_to > > qcow2: Drop

Re: [Qemu-devel] [PATCH 1/2] vmdk: Fix possible segfault with non-VMDK backing

2018-07-02 Thread Fam Zheng
On Mon, 07/02 23:07, Max Reitz wrote: > VMDK performs a probing check in vmdk_co_create_opts() to prevent the > user from assigning non-VMDK files as a backing file, because it only > supports VMDK backing files. However, with the @backing runtime option, > it is possible to assign arbitrary

[Qemu-devel] [PATCH] pc: Fix typo on PC_COMPAT_2_12

2018-07-02 Thread Eduardo Habkost
I forgot a hyphen when amending the compat code on commit e0051647 ("i386: Enable TOPOEXT feature on AMD EPYC CPU"). Fixes: e00516475c270dcb6705753da96063f95699abf2 Signed-off-by: Eduardo Habkost --- Bug detected by compat_checker: https://github.com/ehabkost/gdb-qemu --- include/hw/i386/pc.h |

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: set is_jmp on ppc_tr_breakpoint_check

2018-07-02 Thread David Gibson
On Mon, Jul 02, 2018 at 06:02:07PM -0400, Emilio G. Cota wrote: > The use of GDB breakpoints was broken by b0c2d52 ("target/ppc: convert > to TranslatorOps", 2018-02-16). > > Fix it by setting is_jmp, so that we break from the translation loop > as originally intended. > > Tested-by: Mark

Re: [Qemu-devel] [PATCH v2 2/2] iotests: New test 223 for exporting dirty bitmap over NBD

2018-07-02 Thread Eric Blake
On 07/02/2018 04:27 PM, John Snow wrote: +{ "execute": "block-dirty-bitmap-add", + "arguments": { +"node": "n", +"name": "b", Saving a few precious bytes. Would "mynode" and "mybitmap" be any friendlier? :) +"persistent": true + } +} +{ "execute": "quit" } +EOF + +echo

Re: [Qemu-devel] [PATCH v3 4/4] pc-dimm: assign and verify the "addr" property during pre_plug

2018-07-02 Thread David Gibson
On Mon, Jul 02, 2018 at 11:37:55AM +0200, David Hildenbrand wrote: > We can assign and verify the slot before realizing and trying to plug. > reading/writing the address property should never fail for DIMMs, so let's > reduce error handling a bit by using _abort. Getting access to the > memory

Re: [Qemu-devel] [PATCH v2 0/7] Misc sm501 improvements

2018-07-02 Thread David Gibson
On Mon, Jul 02, 2018 at 10:42:07AM +0100, Peter Maydell wrote: > On 30 June 2018 at 21:34, BALATON Zoltan wrote: > > On Tue, 26 Jun 2018, BALATON Zoltan wrote: > >> > >> Version 2 of the sm501 changes with fixes that are needed to get > >> AmigaOS 4.1FE to boot and able to produce graphics. > >>

Re: [Qemu-devel] [PATCH v3] spapr: compute default value of "hpt-max-page-size" later

2018-07-02 Thread David Gibson
On Mon, Jul 02, 2018 at 10:54:56AM +0200, Greg Kurz wrote: > It is currently not possible to run a pseries-2.12 or older machine > with HV KVM. QEMU prints the following and exits right away. > > qemu-system-ppc64: KVM doesn't support for base page shift 34 > > The "hpt-max-page-size" capability

Re: [Qemu-devel] [PULL 00/25] OpenRISC updates for 3.0

2018-07-02 Thread Stafford Horne
Hello Alex, On Tue, Jul 3, 2018, 12:34 AM Alex Bennée wrote: > > Stafford Horne writes: > > > > > > OpenRISC cleanups and Fixes for QEMU 3.0 > > In the interests of getting the tests/tcg/openrisc stuff up and running > again

[Qemu-devel] [PULL 0/3] pc, virtio: fixes

2018-07-02 Thread Michael S. Tsirkin
The following changes since commit 00928a421d47f49691cace1207481b7aad31b1f1: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20180626' into staging (2018-06-26 18:23:49 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git

[Qemu-devel] [PULL 1/3] hw/i386: Fix IVHD entry length for AMD IOMMU

2018-07-02 Thread Michael S. Tsirkin
From: Jan Kiszka Counting from the IVHD ID field to the all-devices entry, we have 28 bytes, not 36. Signed-off-by: Jan Kiszka Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH v3 20/20] docker: add linux-user powered cross builder for QEMU

2018-07-02 Thread Philippe Mathieu-Daudé
On 07/02/2018 05:35 PM, Philippe Mathieu-Daudé wrote: > On 07/02/2018 11:30 AM, Alex Bennée wrote: >> We can't use cross compilers in the current Debian stable and Debian >> sid is sketchy as hell. So for powerpc fall back to dog-fooding our >> own linux-user to do the build. >> >> As we can only

[Qemu-devel] [PULL 3/3] virtio-rng: process pending requests on DRIVER_OK

2018-07-02 Thread Michael S. Tsirkin
From: Pankaj Gupta virtio-rng device causes old guest kernels(2.6.32) to hang on latest qemu. The driver attempts to read from the virtio-rng device too early in it's initialization. Qemu detects guest is not ready and returns, resulting in hang. To fix handle pending requests when guest is

[Qemu-devel] [PULL 2/3] hw/i386: Fix AMDVI GATS and HATS encodings

2018-07-02 Thread Michael S. Tsirkin
From: Jan Kiszka We support up to 6 levels, but those are encoded as 10b according to the AMD IOMMU spec (chapter 3.3.1, Extended Feature Register). Signed-off-by: Jan Kiszka Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/amd_iommu.h | 4 ++-- 1 file changed,

[Qemu-devel] 2018-07-02 Incremental Backup Status Report

2018-07-02 Thread John Snow
I'm tracking the following series for Incremental Backup right now; if it's not on this list, I don't know about it: [Qemu-devel] [PATCH v4 0/2] block: formalize and test fleecing​ [Qemu-devel] [PATCH v2 0/3] image fleecing [Qemu-devel] [PATCH] migration: Appease coverity, skip empty block trees

Re: [Qemu-devel] [PATCH 1/2] hw/net: Add support for Intel pch_gbe ethernet

2018-07-02 Thread Philippe Mathieu-Daudé
Cc'ing Jason, the "Network devices" maintainer. On 02/17/2018 04:22 PM, Paul Burton wrote: > This patch introduces support for emulating the ethernet controller > found in the Intel EG20T Platform Controller Hub, referred to as pch_gbe > for consistency with both Linux & U-Boot. > >

Re: [Qemu-devel] [PATCH] migration: add capability to bypass the shared memory

2018-07-02 Thread Andrea Arcangeli
Hello, On Mon, Jul 02, 2018 at 09:52:08PM +0800, Peng Tao wrote: > I think we can write some host generated random seeds to guest's > urandom device, when cloning VMs from the same template before handing > it to users. Is it enough or do you think there are more to do w/ > re-randomizing? That

[Qemu-devel] [PATCH] target/ppc: set is_jmp on ppc_tr_breakpoint_check

2018-07-02 Thread Emilio G. Cota
The use of GDB breakpoints was broken by b0c2d52 ("target/ppc: convert to TranslatorOps", 2018-02-16). Fix it by setting is_jmp, so that we break from the translation loop as originally intended. Tested-by: Mark Cave-Ayland Reported-by: Mark Cave-Ayland Signed-off-by: Emilio G. Cota --- (I'll

Re: [Qemu-devel] [PATCH] migration: add capability to bypass the shared memory

2018-07-02 Thread Andrea Arcangeli
Hello everyone, On Mon, Jul 02, 2018 at 02:10:54PM +0100, Stefan Hajnoczi wrote: > Marcelo, Andrea, Paolo: There was a more complex local migration > approach in 2013 with fd passing and vmsplice. They specifically > avoided the approach proposed in this patch, but I don't remember why. > > The

Re: [Qemu-devel] [PATCH 09/32] qmp qemu-ga: Revert change that accidentally made qemu-ga accept "id"

2018-07-02 Thread Eric Blake
On 07/02/2018 11:21 AM, Markus Armbruster wrote: Commit cf869d53172 "qmp: support out-of-band (oob) execution" changed how we check "id": Note that in the patch I exported qmp_dispatch_check_obj() to be used to check the request earlier, and at the same time allowed "id" field to

Re: [Qemu-devel] [PATCH v1] machine: properly free device_memory

2018-07-02 Thread Eduardo Habkost
On Mon, Jul 02, 2018 at 11:41:52AM +0200, David Hildenbrand wrote: > Machines might have inititalized device_memory if they support memory > devices, so let's properly free it. > > Signed-off-by: David Hildenbrand Queued, thanks. -- Eduardo

Re: [Qemu-devel] [PATCH] target-i386: adds PV_SEND_IPI CPUID feature bit

2018-07-02 Thread Eduardo Habkost
On Mon, Jul 02, 2018 at 06:22:51PM +0800, Wanpeng Li wrote: > From: Wanpeng Li > > Adds PV_SEND_IPI CPUID feature bit. > Thanks! Paolo, Radim: can I assume the bit is already reserved and queue this patch, or should I wait until the KVM patch is merged into kvm.git? -- Eduardo

Re: [Qemu-devel] [Bug 1778350] Re: Android-x86 4.4-r5 won't boot on QEMU since v2.11.0-rc2

2018-07-02 Thread Michael S. Tsirkin
I looked at it and while I might be wrong, I suspect it's a bug in ACPI parser in that version of Linux. Is there a way for you to try a later Linux version? Alternatively, I tried to build 4.4-rc2 on Fedora and couldn't. On Tue, Jun 26, 2018 at 09:13:12AM -, navicrej wrote: > Nevermind that,

Re: [Qemu-devel] [PATCH v2 2/2] iotests: New test 223 for exporting dirty bitmap over NBD

2018-07-02 Thread John Snow
On 07/02/2018 03:14 PM, Eric Blake wrote: > Although this test is NOT a full test of image fleecing (as it > intentionally uses just a single block device directly exported > over NBD, rather than trying to set up a blockdev-backup job with > multiple BDS involved), it DOES prove that qemu as a

Re: [Qemu-devel] [PATCH v3] spapr: compute default value of "hpt-max-page-size" later

2018-07-02 Thread Eduardo Habkost
On Mon, Jul 02, 2018 at 10:54:56AM +0200, Greg Kurz wrote: > It is currently not possible to run a pseries-2.12 or older machine > with HV KVM. QEMU prints the following and exits right away. > > qemu-system-ppc64: KVM doesn't support for base page shift 34 > > The "hpt-max-page-size" capability

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-02 Thread si-wei liu
On 7/2/2018 9:14 AM, Roman Kagan wrote: On Fri, Jun 29, 2018 at 05:19:03PM -0500, Venu Busireddy wrote: The patch set "Enable virtio_net to act as a standby for a passthru device" [1] deals with live migration of guests that use passthrough devices. However, that scheme uses the MAC address

Re: [Qemu-devel] [PATCH 08/32] tests/test-qga: Demonstrate the guest-agent ignores "id"

2018-07-02 Thread Eric Blake
On 07/02/2018 11:21 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- tests/test-qga.c | 17 + 1 file changed, 17 insertions(+) diff --git a/tests/test-qga.c b/tests/test-qga.c index 30c9643257..4edd35535d 100644 --- a/tests/test-qga.c +++ b/tests/test-qga.c

Re: [Qemu-devel] [PATCH 07/32] qmp: Make "id" optional again even in "oob" monitors

2018-07-02 Thread Eric Blake
On 07/02/2018 11:21 AM, Markus Armbruster wrote: Commit cf869d53172 "qmp: support out-of-band (oob) execution" made "id" mandatory for all commands when the client accepted capability "oob". This is rather onerous when you play with QMP by hand, and unnecessarily so: only out-of-band commands

Re: [Qemu-devel] [PATCH 06/32] tests/qmp-test: Test in-band command doesn't overtake

2018-07-02 Thread Eric Blake
On 07/02/2018 11:21 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- tests/qmp-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qmp-test.c b/tests/qmp-test.c index b4e54e8970..3932901146 100644 --- a/tests/qmp-test.c +++ b/tests/qmp-test.c @@ -236,10

[Qemu-devel] [PATCH 1/2] vmdk: Fix possible segfault with non-VMDK backing

2018-07-02 Thread Max Reitz
VMDK performs a probing check in vmdk_co_create_opts() to prevent the user from assigning non-VMDK files as a backing file, because it only supports VMDK backing files. However, with the @backing runtime option, it is possible to assign arbitrary nodes as backing nodes, regardless of what the

Re: [Qemu-devel] [PATCH 05/32] qmp: Get rid of x-oob-test command

2018-07-02 Thread Eric Blake
On 07/02/2018 11:21 AM, Markus Armbruster wrote: tests/qmp-test tests an out-of-band command overtaking a slow in-band command. To do that, it needs: 1. An in-band command that *reliably* takes long enough to be overtaken. 2. An out-of-band command to do the overtaking. 3. To avoid

[Qemu-devel] [PATCH 0/2] vmdk: Fix possible segfault with non-VMDK backing

2018-07-02 Thread Max Reitz
The VMDK driver assumes that its backing file is always a VMDK file, too, because it verifies that when creating the overlay. However, that verification means nothing at runtime, and consequently you can assign non-VMDK backing files to a VMDK node. This then breaks because the driver accesses

[Qemu-devel] [PATCH 2/2] iotests: Add VMDK backing file correlation test

2018-07-02 Thread Max Reitz
This new test verifies that VMDK backing file reads fail when the backing file has a non-matching CID. This includes non-VMDK backing files. Signed-off-by: Max Reitz --- tests/qemu-iotests/225 | 132 + tests/qemu-iotests/225.out | 24 +++

Re: [Qemu-devel] [PATCH 04/32] qmp: Document COMMAND_DROPPED design flaw

2018-07-02 Thread Eric Blake
On 07/02/2018 11:21 AM, Markus Armbruster wrote: Events are broadcast to all monitors. If another monitor's client has a command with the same ID in flight, the event will incorrectly claim that command was dropped. This must be fixed before out-of-band execution can graduate from

Re: [Qemu-devel] [PATCH 0/6] hyperv: refactor HvSintRoute management

2018-07-02 Thread Eric Blake
On 07/02/2018 11:58 AM, Roman Kagan wrote: This series modifies the management of HvSintRoute, which is an important building block in Hyper-V emulation infrastructure, to make it easier to maintain and enhance, and paves the way to the more complete Synthetic Interrupt Controller (SynIC)

  1   2   3   4   5   6   >