Re: [Qemu-devel] RDMA wrongly detected as being supported on FreeBSD

2018-07-28 Thread Rebecca Cran via Qemu-devel
On 7/25/18 1:32 AM, Thomas Huth wrote: > > When was it still working for you the last time? Was it still working > with v3.0-rc1 ? Or just with v2.12 ? Any chance that you could bisect > the problem to determine when it has been introduced? I'm not sure if it's FreeBSD that might have changed to

[Qemu-devel] [PATCH v2] slirp: fix ICMP handling on macOS hosts

2018-07-28 Thread aoates--- via Qemu-devel
From: Andrew Oates On Linux, SOCK_DGRAM+IPPROTO_ICMP sockets give only the ICMP packet when read from. On macOS, however, the socket acts like a SOCK_RAW socket and includes the IP header as well. This change strips the extra IP header from the received packet on macOS before sending it to the

Re: [Qemu-devel] [PATCH] slirp: fix ICMP handling on macOS hosts

2018-07-28 Thread Andrew Oates via Qemu-devel
On Sat, Jul 28, 2018, 13:53 Samuel Thibault wrote: > Hello, > > aoa...@google.com, le mer. 25 juil. 2018 21:08:12 -0400, a ecrit: > > From: Andrew Oates > > > > On Linux, SOCK_DGRAM+IPPROTO_ICMP sockets give only the ICMP packet when > > read from. On macOS, however, the socket acts like a SOCK

Re: [Qemu-devel] [PATCH for-3.0] pc: acpi: fix memhp regression by reducing stub SRAT entry size

2018-07-28 Thread Michael S. Tsirkin
On Fri, Jul 27, 2018 at 06:52:40PM -0300, Eduardo Habkost wrote: > On Fri, Jul 27, 2018 at 04:50:31PM +0200, Igor Mammedov wrote: > [...] > > NOTE TO MAINTAINER: UPDATE REFERRENCE APCI TABLE BLOBS IN TESTS > > Why this needs to be done manually? Can't the ACPI table update > be included in the e-

Re: [Qemu-devel] [PATCH hack dontapply v2 7/7] pc: HACK: acpi: tie in _CST object to Processor

2018-07-28 Thread Michael S. Tsirkin
On Fri, Jul 27, 2018 at 05:02:06PM +0200, Igor Mammedov wrote: > On Thu, 26 Jul 2018 18:49:57 +0300 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 25, 2018 at 04:49:08PM +0200, Igor Mammedov wrote: > > > On Wed, 25 Jul 2018 15:50:09 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On We

Re: [Qemu-devel] [PATCH v1 for 3.0 0/2] fix for bug 1783362

2018-07-28 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180726132947.28538-1-alex.ben...@linaro.org Subject: [Qemu-devel] [PATCH v1 for 3.0 0/2] fix for bug 1783362 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(gi

Re: [Qemu-devel] [PATCH] slirp: fix ICMP handling on macOS hosts

2018-07-28 Thread Samuel Thibault
Hello, aoa...@google.com, le mer. 25 juil. 2018 21:08:12 -0400, a ecrit: > From: Andrew Oates > > On Linux, SOCK_DGRAM+IPPROTO_ICMP sockets give only the ICMP packet when > read from. On macOS, however, the socket acts like a SOCK_RAW socket > and includes the IP header as well. > > This chang

Re: [Qemu-devel] [PATCH v1 for 3.0 2/2] tests: add check_invalid_maps to test-mmap

2018-07-28 Thread Richard Henderson
On 07/26/2018 06:29 AM, Alex Bennée wrote: > This adds a test to make sure we fail properly for a 0 length mmap. > There are most likely other failure conditions we should also check. > > Signed-off-by: Alex Bennée > Cc: umarcor <1783...@bugs.launchpad.net> > --- > tests/tcg/multiarch/test-mmap.

Re: [Qemu-devel] [PATCH for-3.0 1/2] armv7m_nvic: Fix m-security subsection name

2018-07-28 Thread Richard Henderson
On 07/27/2018 04:38 AM, Peter Maydell wrote: > The vmstate save/load code insists that subsections of a VMState must > have names which include their parent VMState's name as a leading > substring. Unfortunately it neither documents this nor checks it on > device init or state save, but instead fa

Re: [Qemu-devel] [PATCH v1 1/1] configure: Add RISC-V host support

2018-07-28 Thread Richard Henderson
On 07/27/2018 04:49 PM, Alistair Francis wrote: > Allow QEMU to be built to run on a RISC-V host. > > QEMU does not yet have a RISC-V TCG or user mode target port, but > running other architectures on RISC-V using TCI does work. > > Signed-off-by: Alistair Francis > --- > configure | 18 +++

Re: [Qemu-devel] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature

2018-07-28 Thread Niels de Vos
On Sat, Jul 28, 2018 at 12:18:39AM -0400, Jeff Cody wrote: > On Fri, Jul 27, 2018 at 08:24:05AM -0500, Eric Blake wrote: > > On 07/27/2018 03:19 AM, Niels de Vos wrote: > > >From: Prasanna Kumar Kalever > > > > > >New versions of Glusters libgfapi.so have an updated glfs_ftruncate() > > >function

[Qemu-devel] [PULL v2 3/3] qstring: Move qstring_from_substr()'s @end one to the right

2018-07-28 Thread Markus Armbruster
qstring_from_substr() takes the index of the substring's first and last character. qstring_from_substr(s, 0, SIZE_MAX) denotes an empty substring. Awkward. Shift the end index one to the right. This simplifies both qstring_from_substr() and its callers. Signed-off-by: Markus Armbruster Review

[Qemu-devel] [PULL v2 2/3] qstring: Assert size calculations don't overflow

2018-07-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-Id: <20180727062204.10401-2-arm...@redhat.com> Reviewed-by: Eric Blake --- qobject/qstring.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qobject/qstring.c b/qobject/qstring.c index 18b8eb82f8..1bb7784a88 100644 --- a/qobject/q

[Qemu-devel] [PULL v2 0/3] QObject patches for 2018-07-27 (3.0.0-rc3)

2018-07-28 Thread Markus Armbruster
The following changes since commit 18a398f6a39df4b08ff86ac0d38384193ca5f4cc: Update version for v3.0.0-rc2 release (2018-07-24 22:06:31 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qobject-2018-07-27-v2 for you to fetch changes up to ba891d68b4ff

Re: [Qemu-devel] [PULL 0/3] QObject patches for 2018-07-27 (3.0.0-rc3)

2018-07-28 Thread Markus Armbruster
Peter Maydell writes: > On 27 July 2018 at 16:55, Markus Armbruster wrote: >> The following changes since commit 18a398f6a39df4b08ff86ac0d38384193ca5f4cc: >> >> Update version for v3.0.0-rc2 release (2018-07-24 22:06:31 +0100) >> >> are available in the Git repository at: >> >> git://repo.or

[Qemu-devel] [PULL v2 1/3] qstring: Fix qstring_from_substr() not to provoke int overflow

2018-07-28 Thread Markus Armbruster
From: liujunjie qstring_from_substr() parameters @start and @end are of type int. blkdebug_parse_filename(), blkverify_parse_filename(), nbd_parse_uri(), and qstring_from_str() pass @end values of type size_t or ptrdiff_t. Values exceeding INT_MAX get truncated, with possibly disastrous results.