On 10/08/18 23:46, Hervé Poussineau wrote:
> 40p machine type should be used instead.
>
> Signed-off-by: Hervé Poussineau
> ---
> qemu-deprecated.texi | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
> index 9920a85adc..9c7ff3fe2d 10064
On 08/09/2018 01:22 AM, Richard Henderson wrote:
> We can choose the endianness at translation time, rather than
> re-computing it at execution time.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
> ---
> target/arm/helper-sve.h| 48 +
> t
On 08/09/2018 01:22 AM, Richard Henderson wrote:
> We can choose the endianness at translation time, rather than
> re-computing it at execution time.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
> ---
> target/arm/helper-sve.h| 117 +++---
> tar
On 08/10/2018 03:47 PM, John Paul Adrian Glaubitz wrote:
> Fantastic, this fixes it! Can we get this into 3.0.0 before release?
Probably not, as -rc4 was supposed to be the last pre-release on Tuesday. But
perhaps a revised version can make 3.0.1 (I see problems with this fix).
r~
On 08/10/2018 03:25 PM, Laurent Vivier wrote:
> +++ b/target/sh4/translate.c
> @@ -253,7 +253,6 @@ static void gen_goto_tb(DisasContext *ctx, int n,
> target_ulong dest)
> tcg_gen_lookup_and_goto_ptr();
> }
> }
> -ctx->base.is_jmp = DISAS_NORETURN;
> }
>
Looking
> On 10 Aug 2018, at 13:00, Gerd Hoffmann wrote:
>
> Hi,
>
>> +if (cmd == SVGA_CMD_UPDATE_VERBOSE)
>> +vmsvga_fifo_read(s);
>
> Code style. qemu wants braces unconditionally. There might be more of
> this in following patches. You can use scripts/checkpatch.pl
> On 10 Aug 2018, at 13:14, Gerd Hoffmann wrote:
>
> On Thu, Aug 09, 2018 at 02:46:13PM +0300, Liran Alon wrote:
>> Hi,
>>
>> This patch series aim to fix many issues in vmware-svga emulation
>> which have prevented it from being fully functional in a wide-variety
>> of guests.
>
> Nice job
> On 10 Aug 2018, at 12:56, Gerd Hoffmann wrote:
>
> Hi,
>
>> +case SVGA_REG_DISPLAY_WIDTH:
>> +if ((s->display_id == 0) || (s->display_id == SVGA_ID_INVALID))
>> +ret = s->new_width ? s->new_width : surface_width(surface);
>> +else
>> +ret = 0;
>>
On 08/11/2018 12:25 AM, Laurent Vivier wrote:
> This patch revert changes from 4834871bc9 that are
> not only state renaming.
>
> This fixes java in a linux-user chroot:
> $ java --version
> qemu-sh4: .../accel/tcg/cpu-exec.c:634: cpu_loop_exec_tb: Assertion
> `use_icount' failed.
> qemu: u
40p machine type should be used instead.
Signed-off-by: Hervé Poussineau
---
qemu-deprecated.texi | 6 ++
1 file changed, 6 insertions(+)
diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
index 9920a85adc..9c7ff3fe2d 100644
--- a/qemu-deprecated.texi
+++ b/qemu-deprecated.texi
@@ -21
This patch revert changes from 4834871bc9 that are
not only state renaming.
This fixes java in a linux-user chroot:
$ java --version
qemu-sh4: .../accel/tcg/cpu-exec.c:634: cpu_loop_exec_tb: Assertion
`use_icount' failed.
qemu: uncaught target signal 6 (Aborted) - core dumped
Aborted (cor
On 10/08/18 21:18, Hervé Poussineau wrote:
> Le 10/08/2018 à 14:04, Mark Cave-Ayland a écrit :
>> Instead initialise the device via qdev to allow us to set device
>> properties
>> directly as required.
>>
>> Signed-off-by: Mark Cave-Ayland
>> ---
>> hw/ppc/prep.c | 13 +++--
>> 1 file
This change seems to fix the problem:
diff --git a/target/sh4/translate.c b/target/sh4/translate.c
index 1b9a201d6d..5010b0d349 100644
--- a/target/sh4/translate.c
+++ b/target/sh4/translate.c
@@ -253,7 +253,6 @@ static void gen_goto_tb(DisasContext *ctx, int n,
target_ulong dest)
tc
Le 10/08/2018 à 14:04, Mark Cave-Ayland a écrit :
Instead initialise the device via qdev to allow us to set device properties
directly as required.
Signed-off-by: Mark Cave-Ayland
---
hw/ppc/prep.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/hw/ppc/prep
On 08/10/2018 10:39 AM, Emilio G. Cota wrote:
> Signed-off-by: Emilio G. Cota
> ---
> target/riscv/translate.c | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/target/riscv/translate.c b/target/riscv/translate.c
> index 66a80ca772..18d7b6d147 100644
> --- a/target/r
Hello,
Le 10/08/2018 à 18:17, Programmingkid a écrit :
Can a real 40p machine boot Windows NT 4.0 PowerPC?
Yes.
A real 40p machine is able to run (at least):
- Windows NT (up to 4.0 SP1)
- AIX (up to 4.3.3)
- the beta of OS/2 PowerPC
- Solaris
- Linux
- NetBSD/PReP
However, Windows NT emu
Le 10/08/2018 à 21:28, Richard Henderson a écrit :
> On 08/10/2018 11:53 AM, Laurent Vivier wrote:
>> -{ TARGET_NR_msync, "msync" , NULL, NULL, NULL },
>> +{ TARGET_NR_msync, "msync" , "%s(%#x,%d,%x)", NULL, NULL },
>
> Would you mind having a look at my linux-user reorg proposal?
> It would make
Le 10/08/2018 à 21:30, Richard Henderson a écrit :
> On 08/10/2018 11:53 AM, Laurent Vivier wrote:
>> sparc32plus has 64bit long type but only 32bit virtual address space.
>>
>> For instance, "apt-get upgrade" failed because of a mmap()/msync()
>> sequence.
>>
>> mmap() returned 0xff252000 but msyn
We were using the wrong flush-to-zero bit for the non-half input.
Fixes: 46d33d1e3c9
Cc: qemu-sta...@nongnu.org (3.0.1)
Reported-by: Laurent Desnogues
Signed-off-by: Richard Henderson
---
target/arm/translate-sve.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/a
This makes float16_muladd correctly use FZ16 not FZ.
Fixes: 6ceabaad110
Cc: qemu-sta...@nongnu.org (3.0.1)
Reported-by: Laurent Desnogues
Signed-off-by: Richard Henderson
---
target/arm/sve_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/arm/sve_helper.c b/ta
When FZ is set, input_denormal exceptions are recognized, but this does
not happen with FZ16. The softfloat code has no way to distinguish
these bits and will raise such exceptions into fp_status_f16.flags,
so ignore them when computing the accumulated flags.
Cc: qemu-sta...@nongnu.org (3.0.1)
Re
For 0x1.3p+0 + 0x1.ffep+14 = 0x1.0001fffp+15
we dropped the sticky bit and so failed to raise inexact.
Reported-by: Laurent Desnogues
Signed-off-by: Richard Henderson
---
fpu/softfloat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fpu/softfloat.c b/fpu/so
All from problems reported by Laurent this week. Five of them are
SVE related, but while trying to simplify one of the reports I
discovered that I had broken ARMv8.3 just before final commit.
r~
Richard Henderson (6):
target/arm: Adjust FPCR_MASK for FZ16
target/arm: Ignore float_flag_inpu
These insns require u=1; failed to include that in the switch
cases. This probably happened during one of the rebases just
before final commit.
Fixes: d17b7cdcf4e
Signed-off-by: Richard Henderson
---
target/arm/translate-a64.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
When support for FZ16 was added, we failed to include the bit
within FPCR_MASK, which means that it could never be set.
Continue to zero FZ16 when ARMv8.2-FP16 is not enabled.
Fixes: d81ce0ef2c4
Cc: qemu-sta...@nongnu.org (3.0.1)
Reported-by: Laurent Desnogues
Signed-off-by: Richard Henderson
--
On 08/10/2018 11:53 AM, Laurent Vivier wrote:
> sparc32plus has 64bit long type but only 32bit virtual address space.
>
> For instance, "apt-get upgrade" failed because of a mmap()/msync()
> sequence.
>
> mmap() returned 0xff252000 but msync() used g2h(0xff252000)
> to find the host addre
On 08/10/2018 11:53 AM, Laurent Vivier wrote:
> -{ TARGET_NR_msync, "msync" , NULL, NULL, NULL },
> +{ TARGET_NR_msync, "msync" , "%s(%#x,%d,%x)", NULL, NULL },
Would you mind having a look at my linux-user reorg proposal?
It would make this change redundant.
https://lists.gnu.org/archive/html/qe
On Fri, Aug 10, 2018 at 02:04:47PM +0300, Ilya Maximets wrote:
> On 10.08.2018 12:34, Michael S. Tsirkin wrote:
> > On Fri, Aug 10, 2018 at 11:28:47AM +0300, Ilya Maximets wrote:
> >> On 10.08.2018 01:51, Michael S. Tsirkin wrote:
> >>> On Thu, Aug 09, 2018 at 07:54:37PM +0300, Ilya Maximets wrote:
On 08/10/2018 02:13 AM, Alex Bennée wrote:
>> +for (intptr_t reg_off = find_next_active(vg, 0, reg_max, esz);
>
> Hmm this blew up CI complaining about c99-isms, but QEMU is supposed to
> be c99 compliant.
>
> https://travis-ci.org/stsquad/qemu/builds/414248994
Bah. That's what I get for
Signed-off-by: Laurent Vivier
---
linux-user/strace.list | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/strace.list b/linux-user/strace.list
index ff8bb19f5f..c4a0e3510a 100644
--- a/linux-user/strace.list
+++ b/linux-user/strace.list
@@ -624,7 +624,7 @@
{ TARGET_
sparc32plus has 64bit long type but only 32bit virtual address space.
For instance, "apt-get upgrade" failed because of a mmap()/msync()
sequence.
mmap() returned 0xff252000 but msync() used g2h(0xff252000)
to find the host address. The "(target_ulong)" in g2h() doesn't fix the
address be
On Fri, Aug 10, 2018 at 06:01:06PM +0200, Igor Mammedov wrote:
> On Fri, 10 Aug 2018 16:06:57 +0200
> Igor Mammedov wrote:
>
> > Commit 848a1cc1e8b04 while introducing SRAT entries for DIMM and NVDIMM
> > also introduced fake entries for gaps between memory devices, assuming
> > that we need all
Mmm. I guess the wiki page is just wrong, then. I have some prototype patches
that work, but I need to check somehow what the real hardware's response to
various edge cases is:
* trying to set a virtual screen size that's smaller than the physical screen
size
* trying to set the virtual x/y of
Reviewed-by: Richard Henderson
Signed-off-by: Emilio G. Cota
---
target/riscv/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/riscv/translate.c b/target/riscv/translate.c
index 0b6be74f2d..ec2988b4f6 100644
--- a/target/riscv/translate.c
+++ b/target/riscv/
Performance impact of this and the previous commits, measured with
the very-easy-to-cross-compile rv8-bench:
https://github.com/rv8-io/rv8-bench
Host: Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz
- Key:
before: master
after1,2,3: the 3 commits in this series (i.e. 3 is this commit)
- User-mode
Reviewed-by: Richard Henderson
Signed-off-by: Emilio G. Cota
---
target/riscv/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/riscv/translate.c b/target/riscv/translate.c
index ec2988b4f6..66a80ca772 100644
--- a/target/riscv/translate.c
+++ b/target/riscv/
Changes wrt v1: changed patch 3 as suggested by Richard. Also
added his R-b's.
You can fetch this series from:
https://github.com/cota/qemu/tree/riscv-lookup_ptr-v2
Thanks,
Emilio
On 08/10/2018 11:26 AM, Kevin Wolf wrote:
This adds some tests for block-commit with the new options top-node and
base-node (taking node names) instead of top and base (taking file
names).
May need a rewrite if you like my idea of "by-node":true.
Signed-off-by: Kevin Wolf
---
tests/qemu-i
On 10/08/2018 16:11, Murilo Opsfelder Araujo wrote:
> After commit b3f1c8c413bc83e4a2cc7a63e4eddf9fe6449052 "qemu-pr-helper: use new
> libmultipath API", QEMU started using new libmultipath API, which is not
> available on CentOS 7.x.
>
> This fixes that by probing the new libmultipath API in conf
On 08/10/2018 11:26 AM, Kevin Wolf wrote:
The block-commit QMP command required specifying the top and base nodes
of the commit jobs using the file name of that node. While this works
in simple cases (local files with absolute paths), the file names
generated for more complicated setups can be ha
The virtual size must be at least the size of the physical display. One
approach toward double-buffering is to make the virtual height twice the
physical height. To "flip" the displays you simply change the start of
the visible view port.
See these:
https://lb.raspberrypi.org/forums/viewtopic.p
On 08/10/2018 02:11 PM, Alex Bennée wrote:
> The default Travis gcc is so old it default to -std=gnu89 which will
> fall over on some c99ism you are allowed to use in the QEMU source
> tree. As we also use some GNU extensions make it -std=gnu99 instead of
> -std=c99.
>
> Signed-off-by: Alex Bennée
On 08/08/2018 07:03 AM, Markus Armbruster wrote:
json_lexer_init() takes the function to process a token as an
argument. It's always json_message_process_token(). Makes the code
harder to understand for no actual gain. Drop the indirection.
Signed-off-by: Markus Armbruster
---
Reviewed-by:
On 08/08/2018 07:03 AM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
---
tests/check-qjson.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
Reviewed-by: Eric Blake
diff --git a/tests/check-qjson.c b/tests/check-qjson.c
index 3d3a3f105f..c8c0ad95a6 100644
On 08/08/2018 07:03 AM, Markus Armbruster wrote:
The JSON parser treats each half of a surrogate pair as unpaired
surrogate. Fix it to recognize surrogate pairs.
Signed-off-by: Markus Armbruster
---
qobject/json-parser.c | 16 +++-
tests/check-qjson.c | 3 +--
2 files change
Hi,
While I was reviewing Richard's SVE series I found Travis choking on
some perfectly valid c99. It turns out that Travis default image is
old enough that gcc defaults to -std=gnu89 hence the problem. However
switching to c99 isn't enough as we use GNUisms and even gnu99 still
trips up on qemu-s
QEMU is not a pure C99 code-base as anyone attempting to build with
-std=c99 will find out.
Signed-off-by: Alex Bennée
---
HACKING | 5 +
1 file changed, 5 insertions(+)
diff --git a/HACKING b/HACKING
index 0fc3e0fc04..e042dd1f4f 100644
--- a/HACKING
+++ b/HACKING
@@ -189,6 +189,11 @@ In ad
The default Travis gcc is so old it default to -std=gnu89 which will
fall over on some c99ism you are allowed to use in the QEMU source
tree. As we also use some GNU extensions make it -std=gnu99 instead of
-std=c99.
Signed-off-by: Alex Bennée
---
.travis.yml | 2 +-
1 file changed, 1 insertion(
The expansion of ((struct scmp_arg_cmp){1, SCMP_CMP_NE, 5}) doesn't
work with -std=gnu99.
Signed-off-by: Alex Bennée
---
qemu-seccomp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-seccomp.c b/qemu-seccomp.c
index 9cd8eb9499..4dc1c22924 100644
--- a/qemu-seccomp.c
+++
On 10/08/2018 14:53, Peter Maydell wrote:
>> But otherwise, at least Eric, you, me (only now I admit), Thomas
>> expressed a preference for the other style; on the other side it's
>> Markus, Stefan, Conny and Alex, some of whom were okay with applying
>> maintainer discretion; John and rth wanted a
08.08.2018 15:49, Vladimir Sementsov-Ogievskiy wrote:
The function alters bdrv_dirty_iter_next_area(), which is wrong and
less efficient (see next commit for description).
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/dirty-bitmap.h | 3 +++
include/qemu/hbitmap.h | 15
Anyone? My offer of free use of my machine to support Qemu on Solaris
still stands. Perhaps I'm asking in the wrong place?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1785698
Title:
Solaris bui
This adds some tests for block-commit with the new options top-node and
base-node (taking node names) instead of top and base (taking file
names).
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/040 | 52 --
tests/qemu-iotests/040.out | 4 ++--
2
Kevin Wolf (2):
commit: Add top-node/base-node options
qemu-iotests: Test commit with top-node/base-node
qapi/block-core.json | 24 +++--
blockdev.c | 32 ++--
tests/qemu-iotests/040 | 52 +++
The block-commit QMP command required specifying the top and base nodes
of the commit jobs using the file name of that node. While this works
in simple cases (local files with absolute paths), the file names
generated for more complicated setups can be hard to predict.
This adds two new options to
On Thu, Aug 09, 2018 at 10:40:10PM +0200, Hervé Poussineau wrote:
> - prep machine is a fictional machine, so has no specifications. Which
> devices can be changed/added/removed without impact? Are interrupts
> correctly mapped?
> - prep firmware (OHW) has support only for IDE drives (no SCSI).
Hi Aleksandar,
On 08/06/2018 02:00 PM, Aleksandar Markovic wrote:
> From: Paul Burton
>
> Setup the GT64120 BARs in the nanoMIPS bootloader, in the same way that
> they are setup in the MIPS32 bootloader. This is necessary for Linux to
> be able to access peripherals, including the UART.
>
> Si
> On Aug 9, 2018, at 5:35 PM, qemu-devel-requ...@nongnu.org wrote:
>
> Date: Thu, 9 Aug 2018 22:40:10 +0200
> From: Herv? Poussineau
> To: qemu-devel@nongnu.org
> Cc: Mark Cave-Ayland , David Gibson
> , Alexander Graf ,
> qemu-...@nongnu.org, Herv? Poussineau
> Subject: [Qemu-deve
On 08/08/2018 07:03 AM, Markus Armbruster wrote:
The JSON parser translates invalid \u to garbage instead of
rejecting it, and swallows \u.
Fix by using mod_utf8_encode() instead of flawed wchar_to_utf8().
Valid surrogate pairs are now differently broken: they're rejected
instead of tra
On 08/10/2018 10:48 AM, Eric Blake wrote:
* Note:
- * - Input must be encoded in UTF-8.
+ * - Input must be encoded in modified UTF-8.
Worth documenting this in the QMP doc as an explicit extension? In
general, our QMP interfaces that take binary input do so via base64
encoding, rather th
On Fri, 10 Aug 2018 16:06:57 +0200
Igor Mammedov wrote:
> Commit 848a1cc1e8b04 while introducing SRAT entries for DIMM and NVDIMM
> also introduced fake entries for gaps between memory devices, assuming
> that we need all possible range covered with SRAT entries.
> And it did it wrong since gap w
On 08/08/2018 07:03 AM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
---
qobject/json-parser.c | 42 +++---
1 file changed, 19 insertions(+), 23 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
On 08/08/2018 07:03 AM, Markus Armbruster wrote:
Both lexer and parser reject invalid escape sequences in strings. The
parser's check is useless.
Drop the lexer's escape sequence checking, and make it accept the same
characters after '\' it accepts elsewhere in strings. It now produces
On Thu, 9 Aug 2018 13:10:44 -0300
Eduardo Habkost wrote:
> On Thu, Aug 09, 2018 at 11:10:54AM +0200, Igor Mammedov wrote:
> > On Thu, 2 Aug 2018 10:39:22 -0300
> > Eduardo Habkost wrote:
> >
> > > On Thu, Aug 02, 2018 at 12:09:37PM +0200, Igor Mammedov wrote:
> > > > On Tue, 31 Jul 2018 12:
On 08/08/2018 07:03 AM, Markus Armbruster wrote:
This is consistent with qobject_to_json(). See commit e2ec3f97680.
Side note: that commit mentions that on output, ASCII DEL (0x7f) is
always escaped. RFC 7159 does not require it to be escaped on input, but
I wonder if any of your earlier tes
On Thu, Apr 26, 2018 at 1:34 PM, Pavel Dovgalyuk wrote:
> > From: Ciro Santilli [mailto:ciro.santi...@gmail.com]
> > On Wed, Apr 25, 2018 at 1:45 PM, Pavel Dovgalyuk
> > wrote:
> > > GDB remote protocol supports reverse debugging of the targets.
> > > It includes 'reverse step' and 'reverse cont
From: Stefan Berger
The TPM Physical Presence interface consists of an ACPI part, a shared
memory part, and code in the firmware. Users can send messages to the
firmware by writing a code into the shared memory through invoking the
ACPI code. When a reboot happens, the firmware looks for the code
This allows to pass the last failing test from the Windows HLK TPM 2.0
TCG PPI 1.3 tests.
The interface is described in the "TCG Platform Reset Attack
Mitigation Specification", chapter 6 "ACPI _DSM Function". According
to Laszlo, it's not so easy to implement in OVMF, he suggested to do
it in qem
On 08/08/2018 07:03 AM, Markus Armbruster wrote:
Both the lexer and the parser (attempt to) validate UTF-8 in JSON
strings.
The commit before previous made the parser reject invalid UTF-8
sequences. Since then, anything the lexer rejects, the parser would
reject as well. Thus, the lexer's
From: Stefan Berger
To avoid having to hard code the base address of the PPI virtual
memory device we introduce a fw_cfg file etc/tpm/config that holds the
base address of the PPI device, the version of the PPI interface and
the version of the attached TPM.
Signed-off-by: Stefan Berger
[ Marc-A
From: Stefan Berger
Implement a virtual memory device for the TPM Physical Presence interface.
The memory is located at 0xFED45000 and used by ACPI to send messages to the
firmware (BIOS) and by the firmware to provide parameters for each one of
the supported codes.
This interface should be used
The following patch is going to add compatiblity parameters.
Signed-off-by: Marc-André Lureau
---
include/hw/compat.h | 4 +++-
include/hw/i386/pc.h | 5 -
hw/i386/pc_piix.c| 13 -
hw/i386/pc_q35.c | 12 +++-
4 files changed, 30 insertions(+), 4 deletions(-)
d
The following patches implement the TPM Physical Presence Interface,
make use of a new memory region and a fw_cfg entry. Enable PPI by
default with >3.0 machine type, to avoid migration issues.
Signed-off-by: Marc-André Lureau
Reviewed-by: Igor Mammedov
---
include/hw/compat.h | 12 +++-
Hi,
The following patches implement the TPM Physical Presence Interface
that allows a user to set a command via ACPI (sysfs entry in Linux)
that, upon the next reboot, the firmware looks for and acts upon by
sending sequences of commands to the TPM.
A dedicated memory region is added to the TPM C
On 08/08/2018 07:03 AM, Markus Armbruster wrote:
Quiz time! When a parser reports multiple errors, but the user gets
to see just one, which one is (on average) the least useful one?
:)
Reproducer: feeding
{"abc\xC2ijk": 1}\n
to QMP produces
{"error": {"class": "GenericError", "
On 08/10/2018 09:40 AM, Markus Armbruster wrote:
+cp = mod_utf8_codepoint(ptr, 6, &end);
Why are you hard-coding 6 here, rather than computing min(6,
strchr(ptr,0)-ptr)? If the user passes an invalid sequence at the end
of the string, can we end up making mod_utf8_codepoint() read
On 08/10/2018 09:06 AM, Robert Hoo wrote:
In the subject: s/funcitons/functions/
Also, it may be worth using a topic prefix (most of our commit messages
resemble:
topic: Description of patch
to make it easier to spot patches by topic).
Add an util function feature_word_description(), which
Paolo Bonzini wrote:
> On 10/08/2018 13:08, Juan Quintela wrote:
>>> Emanuele's qos-test would do this automatically. It would be nicer to
>>> convert the whole ISA subsystem to use libqos and qos-test...
>> Can we get this in until we get some volunteer for that other work?
>> /me full of things
On 08/10/2018 08:28 AM, Eric Blake wrote:
Instead of using a raw assert, print the information in an
easier to understand way:
/i386/ahci/sanity: tests/libqtest.c:119: kill_qemu() detected QEMU death from
signal 11 (Segmentation fault) (core dumped)
Well, it would help if my commit message ac
On 08/09/2018 02:43 PM, Emilio G. Cota wrote:
> diff --git a/target/riscv/translate.c b/target/riscv/translate.c
> index 66a80ca772..98e0311606 100644
> --- a/target/riscv/translate.c
> +++ b/target/riscv/translate.c
> @@ -1872,7 +1872,7 @@ static void riscv_tr_tb_stop(DisasContextBase *dcbase,
>
On 08/09/2018 02:43 PM, Emilio G. Cota wrote:
> Signed-off-by: Emilio G. Cota
> ---
> target/riscv/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/riscv/translate.c b/target/riscv/translate.c
> index 0b6be74f2d..ec2988b4f6 100644
> --- a/target/riscv/t
On 08/09/2018 02:43 PM, Emilio G. Cota wrote:
> Signed-off-by: Emilio G. Cota
> ---
> target/riscv/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/riscv/translate.c b/target/riscv/translate.c
> index ec2988b4f6..66a80ca772 100644
> --- a/target/riscv/t
Eric Blake writes:
> On 08/10/2018 06:55 AM, Markus Armbruster wrote:
>> Commit ba51ef25571 moved hw/dma/sun4m_iommu.c to
>> hw/sparc/sun4m_iommu.c without updating MAINTAINERS.
>>
>> Commit f5980f757c0 deleted include/hw/sparc/sun4m.h without updating
>> MAINTAINERS.
>>
>> Commit 0bcc8e5bd8d fat
On 08/10/2018 09:31 AM, Markus Armbruster wrote:
+ *
+ * [Numbers:]
Worth also calling out:
[Objects:]
object = begin-object [ member *( value-separator member ) ]
end-object
member = string name-separator value
[Arrays:]
array = begin-array [ value *( value
On 08/10/2018 09:18 AM, Markus Armbruster wrote:
Eric Blake writes:
On 08/08/2018 07:02 AM, Markus Armbruster wrote:
utf8_string() tests only double quoted strings. Cover single quoted
strings, too: store the strings to test without quotes, then wrap them
in either kind of quote.
Signed-off
On 08/06/2018 01:59 PM, Aleksandar Markovic wrote:
> From: Aleksandar Markovic
>
> Remove duplicate preprocessor constant definition for EF_MIPS_ARCH.
>
> The duplicate was introduced in commit 45506bdd. It placed the
> constant EF_MIPS_ARCH in a better place, however it did not remove
> the ori
Eric Blake writes:
> On 08/08/2018 07:02 AM, Markus Armbruster wrote:
>> We reject bytes that can't occur in valid UTF-8 (\xC0..\xC1,
>> \xF5..\xFF in the lexer. That's insufficient; there's plenty of
>> invalid UTF-8 not containing these bytes, as demonstrated by
>> check-qjson:
>>
>> * Malform
On 08/10/2018 06:55 AM, Markus Armbruster wrote:
Commit ba51ef25571 moved hw/dma/sun4m_iommu.c to
hw/sparc/sun4m_iommu.c without updating MAINTAINERS.
Commit f5980f757c0 deleted include/hw/sparc/sun4m.h without updating
MAINTAINERS.
Commit 0bcc8e5bd8d fat-fingered tests/check-block-qdict.c.
Co
On Fri 10 Aug 2018 08:26:43 AM CEST, Leonid Bloch wrote:
> Previously, the L2 cache was allocated without considering the image
> size, and an option existed to manually determine its size.
This is not quite correct: the L2 cache was set to the maximum needed
for the image when "cache-size" was la
Eric Blake writes:
> On 08/08/2018 07:02 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster
>> ---
>> qobject/json-lexer.c | 80 +++-
>> 1 file changed, 71 insertions(+), 9 deletions(-)
>>
>
>> + *
>> + * [Numbers:]
>
> Worth also calling
On 08/08/2018 07:03 AM, Markus Armbruster wrote:
Section "QGA Synchronization" specifies that sending "a raw 0xFF
sentinel byte" makes the server "reset its state and discard all
pending data prior to the sentinel." What actually happens there is a
lexical error, which will produce one ore more
Eric Blake writes:
> On 08/08/2018 07:02 AM, Markus Armbruster wrote:
>> Fix the lexer to reject unescaped control characters in JSON strings,
>> in accordance with RFC 7159.
>
> Question - can this break existing QMP clients that were relying on
> this extension working?
In theory, yes.
The "e
Eric Blake writes:
> On 08/08/2018 07:02 AM, Markus Armbruster wrote:
>> utf8_string() tests only double quoted strings. Cover single quoted
>> strings, too: store the strings to test without quotes, then wrap them
>> in either kind of quote.
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> t
Eric Blake writes:
> On 08/08/2018 07:02 AM, Markus Armbruster wrote:
>> Merge a few closely related test strings, and drop a few redundant
>> ones.
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> tests/check-qjson.c | 14 ++
>> 1 file changed, 2 insertions(+), 12 deletions(-)
>>
Eric Blake writes:
> On 08/08/2018 07:02 AM, Markus Armbruster wrote:
>> Cover surrogates, invalid escapes, and noncharacters. This
>> demonstrates that valid surrogate pairs are misinterpreted, and
>> invalid surrogates and noncharacters aren't rejected.
>>
>> Signed-off-by: Markus Armbruster
After commit b3f1c8c413bc83e4a2cc7a63e4eddf9fe6449052 "qemu-pr-helper: use new
libmultipath API", QEMU started using new libmultipath API, which is not
available on CentOS 7.x.
This fixes that by probing the new libmultipath API in configure. If it fails,
then try probing the old API. If it fail
Eric Blake writes:
> On 08/08/2018 07:02 AM, Markus Armbruster wrote:
>> escaped_string() first tests double quoted strings, then repeats a few
>> tests with single quotes. Repeat all of them: store the strings to
>> test without quotes, and wrap them in either kind of quote for
>> testing.
>>
>
Define FeatureWordType.
Expand FeatureWordInfo to support both CPUID type feature word as well as
MSR type's.
Change feature_word_info[] accordingly.
Signed-off-by: Robert Hoo
---
target/i386/cpu.c | 133 ++
target/i386/cpu.h | 5 ++
2 files
Commit 848a1cc1e8b04 while introducing SRAT entries for DIMM and NVDIMM
also introduced fake entries for gaps between memory devices, assuming
that we need all possible range covered with SRAT entries.
And it did it wrong since gap would overlap with preceeding entry.
Reproduced with following CLI:
KVM side has added the framework (kvm.git:d1d93fa90) to support MSR based
features.
Here is the QEMU part, including data structure changes/expanding, referring
functions changes, and the implementations on
KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl.
Changelog:
v3: patch 2&3 in
1 - 100 of 191 matches
Mail list logo
