Re: [Qemu-devel] [PATCH 1/1] libqtest: Improve error reporting for bad read from QEMU

2018-08-15 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 08/15/2018 11:19 AM, Markus Armbruster wrote: >> When read() from the qtest socket or the QMP socket fails or EOFs, we >> report "Broken pipe" and exit(1). This commonly happens when QEMU >> crashes. It also happens when QEMU refuses to run because the test >

Re: [Qemu-devel] [PATCH 16/21] block/commit: refactor commit to use job callbacks

2018-08-15 Thread Kevin Wolf
Am 15.08.2018 um 23:17 hat John Snow geschrieben: > On 08/09/2018 11:12 AM, Kevin Wolf wrote: > > Am 07.08.2018 um 06:33 hat John Snow geschrieben: > >> Use the component callbacks; prepare, commit, abort, and clean. > >> > >> NB: prepare is only called when the job has not yet failed; > >> and abo

Re: [Qemu-devel] [PATCH 04/21] block/commit: utilize job_exit shim

2018-08-15 Thread Kevin Wolf
Am 15.08.2018 um 22:52 hat John Snow geschrieben: > On 08/08/2018 12:29 PM, Kevin Wolf wrote: > > Am 07.08.2018 um 06:33 hat John Snow geschrieben: > >> Change the manual deferment to commit_complete into the implicit > >> callback to job_exit. > >> > >> Signed-off-by: John Snow > > > > There is

Re: [Qemu-devel] [RFC PATCH] rbd: Don't convert keypairs to JSON and back

2018-08-15 Thread Markus Armbruster
Max Reitz writes: > On 2018-08-15 10:12, Markus Armbruster wrote: >> Max Reitz writes: > > [...] > >>> To me personally the issue is that if you can specify a plain filename, >>> bdrv_refresh_filename() should give you that plain filename back. So >>> rbd's implementation of that is lacking. W

Re: [Qemu-devel] [PATCH] hw/rdma: Abort send-op if fail to create addr handler

2018-08-15 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180814100010.2546-1-yuval.sh...@oracle.com Subject: [Qemu-devel] [PATCH] hw/rdma: Abort

Re: [Qemu-devel] [PATCH v9 0/6] Add support for TPM Physical Presence interface

2018-08-15 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180810153223.28409-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH v9 0/6] Add support for TPM Physical Presence interface === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [RFC PATCH] rbd: Don't convert keypairs to JSON and back

2018-08-15 Thread Markus Armbruster
Jeff Cody writes: > On Wed, Aug 15, 2018 at 10:12:12AM +0200, Markus Armbruster wrote: >> Max Reitz writes: >> >> > On 2018-07-28 06:32, Jeff Cody wrote: >> >> On Wed, Jul 25, 2018 at 05:01:44PM +0100, Daniel P. Berrangé wrote: >> >>> On Wed, Jul 25, 2018 at 10:56:48AM -0500, Eric Blake wrote:

Re: [Qemu-devel] [PATCH for-3.1 v10 00/31] block: Fix some filename generation issues

2018-08-15 Thread Markus Armbruster
Max Reitz writes: > On 2018-08-15 05:43, no-re...@patchew.org wrote: >> Hi, >> >> This series seems to have some coding style problems. See output below for >> more information: > > [...] > >> === OUTPUT BEGIN === >> Checking PATCH 1/31: block: Use bdrv_refresh_filename() to pull... >> Checking

Re: [Qemu-devel] [PATCH v3 5/5] qmp: add pmemload command

2018-08-15 Thread Markus Armbruster
Simon Ruderich writes: > On Wed, Aug 15, 2018 at 04:29:25PM +0200, Markus Armbruster wrote: >>> For the HMP or the QMP interface? >> >> Both. > > Ok. > >>> If you think 'offset' is not necessary I can also drop it >>> completely. >> >> I think it's a reasonable feature, and since you already code

Re: [Qemu-devel] [PATCH 1/3] qsp: QEMU's Synchronization Profiler

2018-08-15 Thread Fam Zheng
On Thu, 08/16 00:29, Emilio G. Cota wrote: > On Wed, Aug 15, 2018 at 19:55:14 -0400, Emilio G. Cota wrote: > > On Wed, Aug 15, 2018 at 00:53:23 -0400, Emilio G. Cota wrote: > > > On Wed, Aug 15, 2018 at 11:09:42 +0800, Fam Zheng wrote: > > > > On Mon, 08/13 13:11, Emilio G. Cota wrote: > > > > > +

Re: [Qemu-devel] [PULL 00/17] Block and testing patches

2018-08-15 Thread Fam Zheng
On Wed, 08/15 16:35, Peter Maydell wrote: > On 15 August 2018 at 04:12, Fam Zheng wrote: > > The following changes since commit 38441756b70eec5807b5f60dad11a93a91199866: > > > > Update version for v3.0.0 release (2018-08-14 16:38:43 +0100) > > > > tests/vm: Only use -cpu 'host' if KVM is ava

Re: [Qemu-devel] [PATCH v2] ppc: add DBCR based debugging

2018-08-15 Thread David Gibson
On Tue, Aug 14, 2018 at 06:09:51PM +0200, Roman Kapl wrote: > Add support for DBCR (debug control register) based debugging as used on > BookE ppc. So far supports only branch and single-step events, but these are > the important ones. GDB in Linux guest can now do single-stepping. > > Signed-off-

Re: [Qemu-devel] [PATCH 1/3] qsp: QEMU's Synchronization Profiler

2018-08-15 Thread Emilio G. Cota
On Wed, Aug 15, 2018 at 19:55:14 -0400, Emilio G. Cota wrote: > On Wed, Aug 15, 2018 at 00:53:23 -0400, Emilio G. Cota wrote: > > On Wed, Aug 15, 2018 at 11:09:42 +0800, Fam Zheng wrote: > > > On Mon, 08/13 13:11, Emilio G. Cota wrote: > > > > + --enable-sync-profiler) sync_profiler="yes" > > > >

Re: [Qemu-devel] [PATCH 2/2] qemu-img: Add dd seek= option

2018-08-15 Thread Max Reitz
On 2018-08-16 04:57, Eric Blake wrote: > On 08/15/2018 09:49 PM, Max Reitz wrote: > In my opinion, we do not want feature parity with dd.  What we do want is feature parity with convert. >>> >>> Well, convert is lacking a way to specify a subset of one file to move >>> to a (possibly dif

Re: [Qemu-devel] [PATCH 2/2] qemu-img: Add dd seek= option

2018-08-15 Thread Eric Blake
On 08/15/2018 09:49 PM, Max Reitz wrote: In my opinion, we do not want feature parity with dd.  What we do want is feature parity with convert. Well, convert is lacking a way to specify a subset of one file to move to a (possibly different) subset of the other.  I'm fine if we want to enhance

[Qemu-devel] [PATCH 5/5] target/ppc: Convert to HAVE_CMPXCHG128 and HAVE_ATOMIC128

2018-08-15 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/ppc/helper.h | 2 +- target/ppc/mem_helper.c | 33 ++-- target/ppc/translate.c | 115 +--- 3 files changed, 88 insertions(+), 62 deletions(-) diff --git a/target/ppc/helper.h b/target/ppc/helper.h ind

[Qemu-devel] [PATCH 1/5] tcg: Split CONFIG_ATOMIC128

2018-08-15 Thread Richard Henderson
GCC7+ will no longer advertise support for 16-byte __atomic operations if only cmpxchg is supported, as for x86_64. Fortunately, x86_64 still has support for __sync_compare_and_swap_16 and we can make use of that. AArch64 does not have, nor ever has had such support, so open-code it. Signed-off-b

[Qemu-devel] [PATCH 4/5] target/arm: Convert to HAVE_CMPXCHG128

2018-08-15 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/helper-a64.c | 259 +--- 1 file changed, 133 insertions(+), 126 deletions(-) diff --git a/target/arm/helper-a64.c b/target/arm/helper-a64.c index 7f6ad3000b..6e4e1b8a19 100644 --- a/target/arm/helper-a64.c +++ b/

[Qemu-devel] [PATCH 2/5] target/i386: Convert to HAVE_CMPXCHG128

2018-08-15 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/i386/mem_helper.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/target/i386/mem_helper.c b/target/i386/mem_helper.c index 30c26b9d9c..6cc53bcb40 100644 --- a/target/i386/mem_helper.c +++ b/target/i386/mem_helper.c @@ -23,6

[Qemu-devel] [PATCH 3/5] target/s390x: Convert to HAVE_CMPXCHG128 and HAVE_ATOMIC128

2018-08-15 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 87 +-- 1 file changed, 37 insertions(+), 50 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index e21a47fb4d..908b1254c8 100644 --- a/target/s390x/mem_helper.c ++

[Qemu-devel] [PATCH 0/5] tcg: Reorg 128-bit atomic operations

2018-08-15 Thread Richard Henderson
The other day Emilio noticed that we weren't setting CONFIG_ATOMIC128 for x86_64, despite forcing -mcx16 on the command-line. It seems that gcc has changed behaviour with version 7. There's a rather long discussion about this: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80878 It does not appear

Re: [Qemu-devel] [PATCH 2/2] qemu-img: Add dd seek= option

2018-08-15 Thread Max Reitz
On 2018-08-16 04:39, Eric Blake wrote: > On 08/15/2018 09:20 PM, Max Reitz wrote: >> On 2018-08-15 04:56, Eric Blake wrote: >>> For feature parity with dd, we want to be able to specify >>> the offset within the output file, just as we can specify >>> the offset for the input (in particular, this m

Re: [Qemu-devel] [PATCH 2/2] qemu-img: Add dd seek= option

2018-08-15 Thread Eric Blake
On 08/15/2018 09:39 PM, Eric Blake wrote: (My full opinion on the matter: dd has a horrible interface.  I don't quite see why we replicated that inside qemu-img.  Also, if you want to use dd, why not use qemu-nbd + Linux nbd device + real dd?) Because of performance: qemu-nbd + Linux nbd devic

Re: [Qemu-devel] [PATCH 2/2] qemu-img: Add dd seek= option

2018-08-15 Thread Eric Blake
On 08/15/2018 09:20 PM, Max Reitz wrote: On 2018-08-15 04:56, Eric Blake wrote: For feature parity with dd, we want to be able to specify the offset within the output file, just as we can specify the offset for the input (in particular, this makes copying a subset range of guest-visible bytes fr

Re: [Qemu-devel] [PATCH 2/2] qemu-img: Add dd seek= option

2018-08-15 Thread Max Reitz
On 2018-08-15 04:56, Eric Blake wrote: > For feature parity with dd, we want to be able to specify > the offset within the output file, just as we can specify > the offset for the input (in particular, this makes copying > a subset range of guest-visible bytes from one file to > another much easier

Re: [Qemu-devel] [PATCH 1/2] qemu-img: Fix dd with skip= and count=

2018-08-15 Thread Max Reitz
On 2018-08-16 04:17, Eric Blake wrote: > On 08/15/2018 09:03 PM, Max Reitz wrote: > >>> @@ -4559,19 +4559,23 @@ static int img_dd(int argc, char **argv) >>>   goto out; >>>   } >>> >>> +    /* Overflow means the specified offset is beyond input image's >>> size */ >>> +    if (dd.flags

Re: [Qemu-devel] [PATCH 1/2] qemu-img: Fix dd with skip= and count=

2018-08-15 Thread Eric Blake
On 08/15/2018 09:03 PM, Max Reitz wrote: @@ -4559,19 +4559,23 @@ static int img_dd(int argc, char **argv) goto out; } +/* Overflow means the specified offset is beyond input image's size */ +if (dd.flags & C_SKIP && (in.offset > INT64_MAX / in.bsz || +

Re: [Qemu-devel] [PATCH 0/2] Improve qemu-img dd

2018-08-15 Thread Eric Blake
On 08/14/2018 09:56 PM, Eric Blake wrote: I was trying to test NBD fleecing by copying subsets of one file to another, and had the idea to use: $ export NBD drive to be fleeced on port 10809 $ qemu-img create -f qcow2 copy $size $ qemu-nbd -f qcow2 -p 10810 copy $ qemu-img dd -f raw -O raw if=nb

[Qemu-devel] [PATCH 1/2] qemu-img: Fix dd with skip= and count=

2018-08-15 Thread Max Reitz
On 2018-08-15 04:56, Eric Blake wrote: > When both skip= and count= are active, qemu-img dd was not copying > enough data. It didn't help that the code made the same check for > dd.flags & C_SKIP in two separate places. Compute 'size' as the > amount of bytes to be read, and 'end' as the offset to

Re: [Qemu-devel] [PATCH v6 11/13] tests: remove "0.15" prefix for test-qmp-cmds

2018-08-15 Thread Peter Xu
On Wed, Aug 15, 2018 at 03:48:57PM +0200, Thomas Huth wrote: > On 08/15/2018 03:37 PM, Peter Xu wrote: > > The "0.15" prefix seems useless. Remove them. > > > > Signed-off-by: Peter Xu > > --- > > tests/test-qmp-cmds.c | 10 +- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > >

Re: [Qemu-devel] [PATCH v6 11/13] tests: remove "0.15" prefix for test-qmp-cmds

2018-08-15 Thread Peter Xu
On Wed, Aug 15, 2018 at 08:11:22PM +0200, Marc-André Lureau wrote: > On Wed, Aug 15, 2018 at 3:37 PM, Peter Xu wrote: > > The "0.15" prefix seems useless. Remove them. > > > > Signed-off-by: Peter Xu > > I sent a similar patch long ago, and it is finally queued by Markus! > :) "tests: change /0

[Qemu-devel] How do you do when write more than 16TB data to qcow2 on ext4?

2018-08-15 Thread lampahome
We all know there's a file size limit 16TB in ext4 and other fs has their limit,too. If I create an qcow2 20TB on ext4 and write to it more than 16TB. Data more than 16TB can't be written to qcow2. So, is there any better ways to solve this situation? What I thought is to create new qcow2 called

[Qemu-devel] vTPM 2.0 is recognized as vTPM 1.2 on the Win 10 virtual machine

2018-08-15 Thread 汤福
Hi, I want to use the vTPM in a qemu Windows image. Unfortunately, it didn't work. First, the equipment: TPM 2.0 hardware CentOS 7.2 Qemu v2.10.2 SeaBIOS 1.11.0 libtpm and so on My host is centos 7.2 with the TPM 2.0 hardware and qemu v2.10.2. I make the libtpm and seabios with ./configure, make

[Qemu-devel] [PATCH] target-i386: fix segment limit check in ljmp

2018-08-15 Thread andrew
From: Andrew Oates The current implementation has three bugs, * segment limits are not enforced in protected mode if the L bit is set in the target segment descriptor[1] * segment limits are not enforced in compatability mode (ljmp to 32-bit code segment in long mode) * #GP(new_cs) is ge

Re: [Qemu-devel] [PATCH 0/7] qcow2: async handling of fragmented io

2018-08-15 Thread Max Reitz
On 2018-08-07 19:43, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is an asynchronous scheme for handling fragmented qcow2 > reads and writes. Both qcow2 read and write functions loops through > sequential portions of data. The series aim it to parallelize these > loops iterations. > > I

[Qemu-devel] [PATCH v4] slirp: fix ICMP handling on macOS hosts

2018-08-15 Thread andrew
From: Andrew Oates On Linux, SOCK_DGRAM+IPPROTO_ICMP sockets give only the ICMP packet when read from. On macOS, however, the socket acts like a SOCK_RAW socket and includes the IP header as well. This change strips the extra IP header from the received packet on macOS before sending it to the

Re: [Qemu-devel] [PATCH v4] slirp: fix ICMP handling on macOS hosts

2018-08-15 Thread Samuel Thibault
and...@andrewoates.com, le mer. 15 août 2018 20:18:45 -0400, a ecrit: > v4: drop packets that are too short for an IP header Applied to my tree, thanks! Samuel

Re: [Qemu-devel] [PATCH for-3.1 v10 00/31] block: Fix some filename generation issues

2018-08-15 Thread Max Reitz
On 2018-08-15 05:43, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: [...] > === OUTPUT BEGIN === > Checking PATCH 1/31: block: Use bdrv_refresh_filename() to pull... > Checking PATCH 2/31: block: Use children l

Re: [Qemu-devel] [RFC PATCH] rbd: Don't convert keypairs to JSON and back

2018-08-15 Thread Max Reitz
On 2018-08-15 10:12, Markus Armbruster wrote: > Max Reitz writes: [...] >> To me personally the issue is that if you can specify a plain filename, >> bdrv_refresh_filename() should give you that plain filename back. So >> rbd's implementation of that is lacking. Well, it just doesn't exist. >

Re: [Qemu-devel] [PATCH 1/3] qsp: QEMU's Synchronization Profiler

2018-08-15 Thread Emilio G. Cota
On Wed, Aug 15, 2018 at 00:53:23 -0400, Emilio G. Cota wrote: > On Wed, Aug 15, 2018 at 11:09:42 +0800, Fam Zheng wrote: > > On Mon, 08/13 13:11, Emilio G. Cota wrote: > > > + --enable-sync-profiler) sync_profiler="yes" > > > + ;; > > > > Curious, not asking for a change: can this be made a runt

Re: [Qemu-devel] [PATCH 0/3] synchronization profiler

2018-08-15 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180813171132.21939-1-c...@braap.org Subject: [Qemu-devel] [PATCH 0/3] synchronization profiler === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --onelin

Re: [Qemu-devel] [PATCH v6 5/6] loader: Implement .hex file loader

2018-08-15 Thread Alistair Francis
On Tue, Aug 14, 2018 at 9:27 AM, Stefan Hajnoczi wrote: > From: Su Hang > > This patch adds Intel Hexadecimal Object File format support to the > generic loader device. The file format specification is available here: > http://www.piclist.com/techref/fileext/hex/intel.htm > > This file format is

Re: [Qemu-devel] [PATCH] block: for jobs, do not clear user_paused until after the resume

2018-08-15 Thread Jeff Cody
On Wed, Aug 15, 2018 at 05:23:43PM -0400, John Snow wrote: > > > On 08/15/2018 11:59 AM, Jeff Cody wrote: > > The function job_cancel_async() will always cause an assert for blockjob > > user resume. We set job->user_paused to false, and then call > > job->driver->user_resume(). In the case of

Re: [Qemu-devel] [PATCH] block: for jobs, do not clear user_paused until after the resume

2018-08-15 Thread Jeff Cody
On Wed, Aug 15, 2018 at 04:25:16PM -0500, Eric Blake wrote: > On 08/15/2018 10:59 AM, Jeff Cody wrote: > >The function job_cancel_async() will always cause an assert for blockjob > >user resume. We set job->user_paused to false, and then call > >job->driver->user_resume(). In the case of blockjob

Re: [Qemu-devel] [PATCH] block: increased maximum size of vvfat devices

2018-08-15 Thread Eric Blake
On 08/15/2018 01:48 PM, Arkasha wrote: This fixes the problem of the impossibility to create FAT disks larger than 504 mb: The change CHS made it possible to obtain a larger disk. Also, auto-detection of disk parameters was added depending on the volume of the connected files: The size of all f

Re: [Qemu-devel] [PATCH] block: for jobs, do not clear user_paused until after the resume

2018-08-15 Thread Eric Blake
On 08/15/2018 10:59 AM, Jeff Cody wrote: The function job_cancel_async() will always cause an assert for blockjob user resume. We set job->user_paused to false, and then call job->driver->user_resume(). In the case of blockjobs, this is the block_job_user_resume() function. In that function, w

Re: [Qemu-devel] [PATCH] block: for jobs, do not clear user_paused until after the resume

2018-08-15 Thread John Snow
On 08/15/2018 11:59 AM, Jeff Cody wrote: > The function job_cancel_async() will always cause an assert for blockjob > user resume. We set job->user_paused to false, and then call > job->driver->user_resume(). In the case of blockjobs, this is the > block_job_user_resume() function. > > In tha

Re: [Qemu-devel] [PATCH 16/21] block/commit: refactor commit to use job callbacks

2018-08-15 Thread John Snow
On 08/09/2018 11:12 AM, Kevin Wolf wrote: > Am 07.08.2018 um 06:33 hat John Snow geschrieben: >> Use the component callbacks; prepare, commit, abort, and clean. >> >> NB: prepare is only called when the job has not yet failed; >> and abort can be called after prepare. >> >> complete -> prepare -

Re: [Qemu-devel] [PATCH v6 3/4] spapr: introduce a IRQ controller backend to the machine

2018-08-15 Thread Cédric Le Goater
On 08/12/2018 04:58 AM, David Gibson wrote: > > On Fri, Aug 10, 2018 at 09:47:49AM +0200, Cédric Le Goater wrote: >> On 08/10/2018 02:46 AM, David Gibson wrote: >>> On Mon, Jul 30, 2018 at 04:11:33PM +0200, Cédric Le Goater wrote: This proposal moves all the related IRQ routines of the sPAPR

Re: [Qemu-devel] [PULL 0/5] Miscellaneous patches for 2018-08-15

2018-08-15 Thread Peter Maydell
On 15 August 2018 at 08:13, Markus Armbruster wrote: > The following changes since commit 38441756b70eec5807b5f60dad11a93a91199866: > > Update version for v3.0.0 release (2018-08-14 16:38:43 +0100) > > are available in the Git repository at: > > git://repo.or.cz/qemu/armbru.git tags/pull-misc-

Re: [Qemu-devel] [PATCH 04/21] block/commit: utilize job_exit shim

2018-08-15 Thread John Snow
On 08/08/2018 12:29 PM, Kevin Wolf wrote: > Am 07.08.2018 um 06:33 hat John Snow geschrieben: >> Change the manual deferment to commit_complete into the implicit >> callback to job_exit. >> >> Signed-off-by: John Snow > > There is one tricky thing in this patch that the commit message could be

[Qemu-devel] [PATCH] block: for jobs, do not clear user_paused until after the resume

2018-08-15 Thread Jeff Cody
The function job_cancel_async() will always cause an assert for blockjob user resume. We set job->user_paused to false, and then call job->driver->user_resume(). In the case of blockjobs, this is the block_job_user_resume() function. In that function, we assert that job.user_paused is set to tru

[Qemu-devel] [PATCH] block: increased maximum size of vvfat devices

2018-08-15 Thread Arkasha
This fixes the problem of the impossibility to create FAT disks larger than 504 mb: The change CHS made it possible to obtain a larger disk. Also, auto-detection of disk parameters was added depending on the volume of the connected files: The size of all folders and files on the created disk is c

[Qemu-devel] [PATCH] qtest: Add set_irq_in command to set IRQ/GPIO level

2018-08-15 Thread Steffen Görtz
Adds a new qtest command "set_irq_in" which allows to set qemu gpio lines to a given level. Based on https://lists.gnu.org/archive/html/qemu-devel/2012-12/msg02363.html which never got merged. Signed-off-by: Steffen Görtz Originally-by: Matthew Ogilvie --- qtest.c | 37 +++

Re: [Qemu-devel] [PATCH v3 5/5] qmp: add pmemload command

2018-08-15 Thread Simon Ruderich
On Wed, Aug 15, 2018 at 04:29:25PM +0200, Markus Armbruster wrote: >> For the HMP or the QMP interface? > > Both. Ok. >> If you think 'offset' is not necessary I can also drop it >> completely. > > I think it's a reasonable feature, and since you already coded it up... In that case, should size

Re: [Qemu-devel] [PATCH v2 17/22] virtio: split vhost-user-scsi bits from virtio-pci

2018-08-15 Thread Thomas Huth
On 08/08/2018 01:48 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs | 1 + > hw/virtio/vhost-user-scsi-pci.c | 89 + > hw/virtio/virtio-pci.c | 58 - > 3 files changed, 90 insertions(+),

[Qemu-devel] [Bug 1787012] Re: Solaris build error: Bad string

2018-08-15 Thread Michele Denber
You are absolutely correct. I found the right problem but the wrong reason. Note that: # which tr /usr/bin/tr # uname -s | tr '[/]' '[_]' Bad string # uname -s | /usr/xpg4/bin/tr '[/]' '[_]' SunOS # So it's just another POSIX problem with Solaris, not a bug. Solaris provides all the POSIX stu

Re: [Qemu-devel] [PULL 00/19] MIPS queue for QEMU upstream, August 14, 2018

2018-08-15 Thread Peter Maydell
On 15 August 2018 at 20:35, Aleksandar Markovic wrote: > These functions are used in the patches that follow in nanoMIPS series, but > not submitted in this pull request. > > Ok, I will reorganize the patches so that there is no such case, and will > send the new pull request soon. > > Do we requi

[Qemu-devel] [PATCH 2/2] qemu-option: improve qemu_opts_print_help() output

2018-08-15 Thread Marc-André Lureau
Modify qemu_opts_print_help(): - to print expected argument type - skip description if not available - sort lines - prefix with the list name (like qdev, to avoid confusion) - drop 16-chars alignment, use a '-' as seperator for option name and description For ex, "-spice ?" output is changed fro

[Qemu-devel] [PATCH 1/2] qemu-option: add help fallback to print the list of options

2018-08-15 Thread Marc-André Lureau
QDev options accept '?' or 'help' in the list of parameters, which is really handy to list the available options. Unfortunately, this isn't built in QemuOpts. qemu_opts_parse_noisily() seems to be the common path for command line options, so place a fallback to check for '?' and print help listing

Re: [Qemu-devel] ?==?utf-8?q? [PULL?==?utf-8?q? 00/19] MIPS queue for QEMU upstream, August 14, 2018

2018-08-15 Thread Aleksandar Markovic
These functions are used in the patches that follow in nanoMIPS series, but not submitted in this pull request. Ok, I will reorganize the patches so that there is no such case, and will send the new pull request soon. Do we require that bisect works for clang builds too (meaning that after ea

Re: [Qemu-devel] [PULL 00/17] Block and testing patches

2018-08-15 Thread Peter Maydell
On 15 August 2018 at 04:12, Fam Zheng wrote: > The following changes since commit 38441756b70eec5807b5f60dad11a93a91199866: > > Update version for v3.0.0 release (2018-08-14 16:38:43 +0100) > tests/vm: Only use -cpu 'host' if KVM is available Incidentally, why did you go with this one rathe

Re: [Qemu-devel] [PATCH 1/1] libqtest: Improve error reporting for bad read from QEMU

2018-08-15 Thread Eric Blake
On 08/15/2018 09:19 AM, Markus Armbruster wrote: When read() from the qtest socket or the QMP socket fails or EOFs, we report "Broken pipe" and exit(1). This commonly happens when QEMU crashes. It also happens when QEMU refuses to run because the test passed it bad arguments. Sadly, we neglect

Re: [Qemu-devel] [PATCH v4] tests/libqtest: Improve kill_qemu()

2018-08-15 Thread Eric Blake
On 08/15/2018 08:35 AM, Markus Armbruster wrote: /i386/ahci/sanity: tests/libqtest.c:119: kill_qemu() detected QEMU death from signal 11 (Segmentation fault) (core dumped) Well, it would help if my commit message actually matched... +const char *dump = WCOREDUMP(wstatus) ?

Re: [Qemu-devel] [Bug 1785698] Re: Solaris build error: unknown type name ‘gcry_error_t’

2018-08-15 Thread Michele Denber
On 08-15-2018 6:50 AM, Peter Maydell wrote: > The executables are created in the subdirectories for each target, so > x86_64-softmmu/qemu-system-x86_64 and so on. > Oh duh! :-) I'm really glad I asked. I've been trying to figure out why there was no executable and no errors. Sure enough, I fou

Re: [Qemu-devel] [PATCH v2 16/22] virtio: split vhost-user-blk bits from virtio-pci

2018-08-15 Thread Thomas Huth
On 08/08/2018 01:48 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs| 1 + > hw/virtio/vhost-user-blk-pci.c | 88 ++ > hw/virtio/virtio-pci.c | 60 --- > 3 files changed, 89 insertions(+),

Re: [Qemu-devel] [PULL 00/19] MIPS queue for QEMU upstream, August 14, 2018

2018-08-15 Thread Peter Maydell
On 14 August 2018 at 19:16, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > The following changes since commit 38441756b70eec5807b5f60dad11a93a91199866: > > Update version for v3.0.0 release (2018-08-14 16:38:43 +0100) > > are available in the git repository at: > > https://github.

Re: [Qemu-devel] [PATCH 1/1] kvm: add call to qemu_add_opts() for -overcommit option

2018-08-15 Thread Mark Kanda
On 8/15/2018 12:57 PM, prasad.singamse...@oracle.com wrote: From: Prasad Singamsetty qemu command fails to process -overcommit option. Add the missing call to qemu_add_opts() in vl.c. Signed-off-by: Prasad Singamsetty Reviewed-by: Mark Kanda --- vl.c | 1 + 1 file changed, 1 insert

Re: [Qemu-devel] [PULL 00/17] Block and testing patches

2018-08-15 Thread Peter Maydell
On 15 August 2018 at 04:12, Fam Zheng wrote: > The following changes since commit 38441756b70eec5807b5f60dad11a93a91199866: > > Update version for v3.0.0 release (2018-08-14 16:38:43 +0100) > > are available in the Git repository at: > > git://github.com/famz/qemu.git tags/block-and-testing-pu

Re: [Qemu-devel] [PATCH v2 15/22] virtio: split 9p bits from virtio-pci

2018-08-15 Thread Thomas Huth
On 08/08/2018 01:48 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs | 1 + > hw/virtio/virtio-9p-pci.c | 74 +++ > hw/virtio/virtio-pci.c| 52 --- > 3 files changed, 75 insertions(+), 52 del

Re: [Qemu-devel] [PATCH 0/7] Some improvements in z/Arch instructions support

2018-08-15 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180810030139.25916-1-pavel.zbits...@gmail.com Subject: [Qemu-devel] [PATCH 0/7] Some improvements in z/Arch instructions support === TEST SCRIPT BEGIN === #!/bin/bash BAS

Re: [Qemu-devel] [PATCH v2 15/22] virtio: split 9p bits from virtio-pci

2018-08-15 Thread Thomas Huth
On 08/08/2018 01:48 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs | 1 + > hw/virtio/virtio-9p-pci.c | 74 +++ > hw/virtio/virtio-pci.c| 52 --- > 3 files changed, 75 insertions(+), 52 del

Re: [Qemu-devel] [PATCH v6 11/13] tests: remove "0.15" prefix for test-qmp-cmds

2018-08-15 Thread Marc-André Lureau
On Wed, Aug 15, 2018 at 3:37 PM, Peter Xu wrote: > The "0.15" prefix seems useless. Remove them. > > Signed-off-by: Peter Xu I sent a similar patch long ago, and it is finally queued by Markus! :) "tests: change /0.15/* tests to /qmp/*" > --- > tests/test-qmp-cmds.c | 10 +- > 1 file

Re: [Qemu-devel] [Qemu-arm] [PATCH 14/16] hw/dma/pl080: Correct bug in register address decode logic

2018-08-15 Thread Peter Maydell
On 15 August 2018 at 15:39, Philippe Mathieu-Daudé wrote: > On 08/09/2018 10:01 AM, Peter Maydell wrote: >> diff --git a/hw/dma/pl080.c b/hw/dma/pl080.c >> index a7aacad74f0..8f92550392b 100644 >> --- a/hw/dma/pl080.c >> +++ b/hw/dma/pl080.c >> @@ -229,7 +229,7 @@ static uint64_t pl080_read(void *

[Qemu-devel] [PATCH 1/1] kvm: add call to qemu_add_opts() for -overcommit option

2018-08-15 Thread prasad . singamsetty
From: Prasad Singamsetty qemu command fails to process -overcommit option. Add the missing call to qemu_add_opts() in vl.c. Signed-off-by: Prasad Singamsetty --- vl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/vl.c b/vl.c index 16b913f9d5..12d27fa028 100644 --- a/vl.c +++ b/vl.c @@ -2

Re: [Qemu-devel] [Qemu-arm] [PATCH v4 5/6] loader: Implement .hex file loader

2018-08-15 Thread Stefan Hajnoczi
On Wed, Aug 15, 2018 at 3:18 PM Philippe Mathieu-Daudé wrote: > On 08/13/2018 12:56 PM, Stefan Hajnoczi wrote: > > On Fri, Aug 10, 2018 at 02:00:44AM -0300, Philippe Mathieu-Daudé wrote: > >> On 08/03/2018 11:47 AM, Stefan Hajnoczi wrote: > >>> +parser->rom_start_address = parser->next_add

Re: [Qemu-devel] [PATCH v2 19/22] virtio: split virtio-scsi bits from virtio-pci

2018-08-15 Thread Thomas Huth
On 08/08/2018 01:48 PM, Juan Quintela wrote: > Notice that we can't still run tests with it disabled. Both cdrom-test and > drive_del-test use virtio-scsi without checking if it is enabled. > > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs | 1 + > hw/virtio/virtio-pci.c

Re: [Qemu-devel] [PATCH v2 18/22] virtio: split vhost-scsi bits from virtio-pci

2018-08-15 Thread Thomas Huth
On 08/08/2018 01:48 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs| 1 + > hw/virtio/vhost-scsi-pci.c | 94 ++ > hw/virtio/virtio-pci.c | 59 > 3 files changed, 95 insertions(+), 59 dele

Re: [Qemu-devel] [PATCH v2 14/22] virtio: split balloon bits from virtio-pci

2018-08-15 Thread Thomas Huth
On 08/08/2018 01:48 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs| 1 + > hw/virtio/virtio-balloon-pci.c | 82 ++ > hw/virtio/virtio-pci.c | 57 --- > tests/Makefile.include | 4

Re: [Qemu-devel] [PATCH] target/arm: crash on conditional instr in it block

2018-08-15 Thread Roman Kapl
Hi and thanks for review, On 08/14/2018 08:12 PM, Peter Maydell wrote: On 14 August 2018 at 17:54, Roman Kapl wrote: If an instruction is conditional (like CBZ) and it is executed conditionally (using the ITx instruction), a jump to undefined label is generated. Fix the 'skip on condtion' cod

Re: [Qemu-devel] [Qemu-block] [PATCH 00/21] jobs: defer graph changes until finalize

2018-08-15 Thread Peter Krempa
On Wed, Aug 15, 2018 at 17:00:29 +0200, Kevin Wolf wrote: > Am 15.08.2018 um 16:44 hat Peter Krempa geschrieben: > > On Tue, Aug 07, 2018 at 00:33:28 -0400, John Snow wrote: > > > This series forces all jobs to use the "finalize" semantics that were > > > introduced previously, but only exposed via

Re: [Qemu-devel] [Qemu-block] [PATCH 00/21] jobs: defer graph changes until finalize

2018-08-15 Thread Kevin Wolf
Am 15.08.2018 um 16:44 hat Peter Krempa geschrieben: > On Tue, Aug 07, 2018 at 00:33:28 -0400, John Snow wrote: > > This series forces all jobs to use the "finalize" semantics that were > > introduced previously, but only exposed via the backup jobs. > > This series looks huge, but it's mostly mech

Re: [Qemu-devel] [PATCH v4] tests/libqtest: Improve kill_qemu()

2018-08-15 Thread Philippe Mathieu-Daudé
On 08/15/2018 10:35 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 08/13/2018 02:17 AM, Markus Armbruster wrote: >>> Eric Blake writes: >>> On 08/10/2018 08:28 AM, Eric Blake wrote: > Instead of using a raw assert, print the information in an > easier to understand way: >

Re: [Qemu-devel] [PATCH 1/1] libqtest: Improve error reporting for bad read from QEMU

2018-08-15 Thread Philippe Mathieu-Daudé
On 08/15/2018 11:19 AM, Markus Armbruster wrote: > When read() from the qtest socket or the QMP socket fails or EOFs, we > report "Broken pipe" and exit(1). This commonly happens when QEMU > crashes. It also happens when QEMU refuses to run because the test > passed it bad arguments. Sadly, we n

Re: [Qemu-devel] [Qemu-block] [PATCH 00/21] jobs: defer graph changes until finalize

2018-08-15 Thread Peter Krempa
On Tue, Aug 07, 2018 at 00:33:28 -0400, John Snow wrote: > This series forces all jobs to use the "finalize" semantics that were > introduced previously, but only exposed via the backup jobs. > This series looks huge, but it's mostly mechanical changes broken out > into a series of much smaller com

Re: [Qemu-devel] [Qemu-arm] [PATCH 14/16] hw/dma/pl080: Correct bug in register address decode logic

2018-08-15 Thread Philippe Mathieu-Daudé
On 08/09/2018 10:01 AM, Peter Maydell wrote: > A bug in the handling of the register address decode logic > for the PL08x meant that we were incorrectly treating > accesses to the DMA channel registers (DMACCxSrcAddr, > DMACCxDestaddr, DMACCxLLI, DMACCxControl, DMACCxConfiguration) > as bad offsets

Re: [Qemu-devel] [PATCH v3 5/5] qmp: add pmemload command

2018-08-15 Thread Markus Armbruster
Simon Ruderich writes: > On Wed, Aug 15, 2018 at 06:22:51AM +0200, Markus Armbruster wrote: >>> My initial patch didn't have the offset. It was suggested by Eric >>> Blake in <0a960aa8-2a3f-8667-3d46-cecf8e65e...@redhat.com>: >>> >>> On Tue, Apr 10, 2018 at 04:33:03PM -0500, Eric Blake wrote: >>>

[Qemu-devel] [PATCH 1/1] libqtest: Improve error reporting for bad read from QEMU

2018-08-15 Thread Markus Armbruster
When read() from the qtest socket or the QMP socket fails or EOFs, we report "Broken pipe" and exit(1). This commonly happens when QEMU crashes. It also happens when QEMU refuses to run because the test passed it bad arguments. Sadly, we neglect to report either. Improve this by calling abort()

[Qemu-devel] [PATCH 0/1] libqtest: Improve error reporting for bad read from QEMU

2018-08-15 Thread Markus Armbruster
Eric Blake's "[PATCH v4] tests/libqtest: Improve kill_qemu()" improves how we report how QEMU terminated. Sadly, we bypass kill_qemu() in certain failure modes. Fix that. Based-on: <20180810132800.38549-1-ebl...@redhat.com> Markus Armbruster (1): libqtest: Improve error reporting for bad read

Re: [Qemu-devel] [Qemu-arm] [PATCH v4 5/6] loader: Implement .hex file loader

2018-08-15 Thread Philippe Mathieu-Daudé
On 08/13/2018 12:56 PM, Stefan Hajnoczi wrote: > On Fri, Aug 10, 2018 at 02:00:44AM -0300, Philippe Mathieu-Daudé wrote: >> On 08/03/2018 11:47 AM, Stefan Hajnoczi wrote: >>> +parser->rom_start_address = parser->next_address_to_write; >>> +parser->current_rom_index = 0; >>> +

Re: [Qemu-devel] [RFC PATCH 0/4] add hand-rolled fallback when capstone fails

2018-08-15 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180808123934.17450-1-alex.ben...@linaro.org Subject: [Qemu-devel] [RFC PATCH 0/4] add hand-rolled fallback when capstone fails === TEST SCRIPT BEGIN === #!/bin/bash BASE=

Re: [Qemu-devel] [PATCH v3] slirp: fix ICMP handling on macOS hosts

2018-08-15 Thread Andrew Oates via Qemu-devel
On Wed, Aug 15, 2018 at 7:03 AM Samuel Thibault wrote: > Andrew Oates, le mar. 14 août 2018 22:35:21 -0400, a ecrit: > > On Linux, SOCK_DGRAM+IPPROTO_ICMP sockets give only the ICMP packet when > > read from. On macOS, however, the socket acts like a SOCK_RAW socket > > and includes the IP heade

[Qemu-devel] [PATCH] imx_serial: Generate interrupt on receive data ready if enabled

2018-08-15 Thread Hans-Erik Floryd
Generate an interrupt if USR2_RDR and UCR4_DREN are both set. Signed-off-by: Hans-Erik Floryd --- hw/char/imx_serial.c | 3 ++- include/hw/char/imx_serial.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/char/imx_serial.c b/hw/char/imx_serial.c index 0747db9..1e3

[Qemu-devel] [PATCH v6 12/13] tests: add oob functional test for test-qmp-cmds

2018-08-15 Thread Peter Xu
Straightforward test just to let the test-qmp-cmds be complete. Signed-off-by: Peter Xu --- tests/test-qmp-cmds.c | 16 1 file changed, 16 insertions(+) diff --git a/tests/test-qmp-cmds.c b/tests/test-qmp-cmds.c index 989819b26d..a51432f09d 100644 --- a/tests/test-qmp-cmds.c ++

[Qemu-devel] [PATCH v6 09/13] Revert "tests: Add parameter to qtest_init_without_qmp_handshake"

2018-08-15 Thread Peter Xu
This reverts commit ddee57e0176f6ab53b13c6c97605b62737a8fd7a. Meanwhile, revert one line from fa198ad9bdef to make sure qtest_init_without_qmp_handshake() will only pass in one parameter. Reviewed-by: Markus Armbruster Signed-off-by: Peter Xu --- tests/libqtest.c | 10 -- tests/libqtes

[Qemu-devel] [Bug 1787070] Re: Guests using the qxl-vga are freezing

2018-08-15 Thread Leonardo Müller
I have run the openSUSE guest again, the output of the gdb command can be seen at https://paste.ubuntu.com/p/mCRMvkNWYq/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1787070 Title: Guests using th

Re: [Qemu-devel] [PATCH v6 11/13] tests: remove "0.15" prefix for test-qmp-cmds

2018-08-15 Thread Thomas Huth
On 08/15/2018 03:37 PM, Peter Xu wrote: > The "0.15" prefix seems useless. Remove them. > > Signed-off-by: Peter Xu > --- > tests/test-qmp-cmds.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tests/test-qmp-cmds.c b/tests/test-qmp-cmds.c > index ba41a6161e

[Qemu-devel] [PATCH v6 08/13] monitor: remove "x-oob", turn oob on by default

2018-08-15 Thread Peter Xu
OOB commands were introduced in commit cf869d53172. Unfortunately, we ran into a regression, and had to disable them by default for 2.12 (commit be933ffc23). http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html The regression has since been fixed (commit 951702f39c7 "monitor: bin

[Qemu-devel] [PATCH v6 07/13] monitor: restrict response queue length too

2018-08-15 Thread Peter Xu
Before this patch we were only monitoring the request queue, but it's still possible that a client only sends requests but it never eats any reply from us. In that case our response queue might grow with unlimited responses and put us at risk. Now we play the similar trick as we have done to the

[Qemu-devel] [PATCH v6 06/13] qapi: remove COMMAND_DROPPED event

2018-08-15 Thread Peter Xu
Now it was not used any more. Drop it, especially if we can do that before we release QEMU 3.0. Signed-off-by: Peter Xu --- docs/interop/qmp-spec.txt | 5 +++-- qapi/misc.json| 40 --- 2 files changed, 3 insertions(+), 42 deletions(-) diff --git

  1   2   >