Re: [Qemu-devel] [PATCH 0/2] pvrdma: Extend device state

2018-09-02 Thread Yuval Shaia
On Sun, Sep 02, 2018 at 11:48:11AM +0300, Yuval Shaia wrote: > pvrdma device state is compose of the state of the following: > - rdma backend device > - vmxnet3 device on PCI function 0 > - pvrdma device on PCI function 1 > > This patch-set aim to make it. > > Patch 1: Make vmxnet3 accessible fro

[Qemu-devel] [PATCH 4/4] LICENSE.md : Reformatted to fit the Markdown (.md) format.

2018-09-02 Thread Yoni Bettan
Signed-off-by: Yoni Bettan --- LICENSE => LICENSE.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) rename LICENSE => LICENSE.md (90%) diff --git a/LICENSE b/LICENSE.md similarity index 90% rename from LICENSE rename to LICENSE.md index 0e0b4b9553..644e953429 100644 --- a/LICENSE +++

[Qemu-devel] [PATCH 2/4] CODING_STYLE.md : Reformatted to fit the Markdown (.md) format.

2018-09-02 Thread Yoni Bettan
Signed-off-by: Yoni Bettan --- CODING_STYLE => CODING_STYLE.md | 151 +--- 1 file changed, 80 insertions(+), 71 deletions(-) rename CODING_STYLE => CODING_STYLE.md (50%) diff --git a/CODING_STYLE b/CODING_STYLE.md similarity index 50% rename from CODING_STYLE rename

[Qemu-devel] [PATCH v4 0/3] x86: QEMU side support on MSR based features

2018-09-02 Thread Robert Hoo
KVM side has added the framework (kvm.git:d1d93fa90) to support MSR based features. Here is the QEMU part, including data structure changes/expanding, referring functions changes, and the implementations on KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl. Changelog: v4: Re-o

[Qemu-devel] [PATCH v4 2/3] kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl

2018-09-02 Thread Robert Hoo
Add kvm_get_supported_feature_msrs() to get supported MSR feature index list. Add kvm_arch_get_supported_msr_feature() to get each MSR features value. Signed-off-by: Robert Hoo --- include/sysemu/kvm.h | 2 ++ target/i386/cpu.c| 7 ++--- target/i386/kvm.c| 72 ++

[Qemu-devel] [PATCH v4 3/3] x86: define a new MSR based feature word -- FEATURE_WORDS_ARCH_CAPABILITIES

2018-09-02 Thread Robert Hoo
Note RSBA is specially treated -- no matter host support it or not, qemu pretends it is supported. Signed-off-by: Robert Hoo --- target/i386/cpu.c | 27 ++- target/i386/cpu.h | 12 2 files changed, 38 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu

[Qemu-devel] [PATCH v4 1/3] x86: Data structure changes to support MSR based features

2018-09-02 Thread Robert Hoo
Add FeatureWordType indicator in struct FeatureWordInfo. Change feature_word_info[] accordingly. Change existing functions that refer to feature_word_info[] accordingly. Signed-off-by: Robert Hoo --- target/i386/cpu.c | 172 +- 1 file changed,

[Qemu-devel] [PATCH 1/4] README.md : Reformatted to fit the Markdown (.md) format.

2018-09-02 Thread Yoni Bettan
Signed-off-by: Yoni Bettan --- README => README.md | 87 +++-- 1 file changed, 44 insertions(+), 43 deletions(-) rename README => README.md (68%) diff --git a/README b/README.md similarity index 68% rename from README rename to README.md index 49a9fd09cd.

[Qemu-devel] [PATCH 0/4] Reformatted INFO files to fit the Markdown (.md) format.

2018-09-02 Thread Yoni Bettan
This patch make INFO files (e.g. README, CODING_STYLE etc) much more readable when watched from GitHub GUI. ./VERSION and ./MAINTAINERS were leave untouched otherwise ./scripts/get_maintainer.pl breaks. ./COPYING and ./COPYING.LIB were leave untouched because it look likes they come from GNU and

Re: [Qemu-devel] [PATCH v5 0/3] Some improvements in z/Arch instructions support

2018-09-02 Thread David Hildenbrand
On 02.09.2018 02:33, Pavel Zbitskiy wrote: > Changes since v4: > > * Simplified alignment checks by using tcg_gen_qemu_ld_i64 and > MO_ALIGN*. > > Pavel Zbitskiy (3): > target/s390x: use regular spaces in translate.c > target/s390x: exception on non-aligned LPSW(E) > target/s390x: impleme

[Qemu-devel] [PATCH] Fix a deadlock case in the CPU hotplug flow

2018-09-02 Thread Jose Ricardo Ziviani
We need to set cs->halted to 1 before calling ppc_set_compat. The reason is that ppc_set_compat kicks up the new thread created to manage the hotplugged KVM virtual CPU and the code drives directly to KVM_RUN ioctl. When cs->halted is 1, the code: int kvm_cpu_exec(CPUState *cpu) ... if (kvm_a

[Qemu-devel] [PATCH 3/4] HACKING.md : Reformatted to fit the Markdown (.md) format.

2018-09-02 Thread Yoni Bettan
Signed-off-by: Yoni Bettan --- HACKING => HACKING.md | 186 ++ 1 file changed, 97 insertions(+), 89 deletions(-) rename HACKING => HACKING.md (53%) diff --git a/HACKING b/HACKING.md similarity index 53% rename from HACKING rename to HACKING.md index 0fc3e

[Qemu-devel] [PATCH] Fix a deadlock case in the CPU hotplug flow

2018-09-02 Thread Jose Ricardo Ziviani
From: Jose Ricardo Ziviani We need to set cs->halted to 1 before calling ppc_set_compat. The reason is that ppc_set_compat kicks up the new thread created to manage the hotplugged KVM virtual CPU and the code drives directly to KVM_RUN ioctl. When cs->halted is 1, the code: int kvm_cpu_exec(CPUS

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Fix a deadlock case in the CPU hotplug flow

2018-09-02 Thread Greg Kurz
On Sun, 2 Sep 2018 02:01:12 -0300 Jose Ricardo Ziviani wrote: > From: Jose Ricardo Ziviani > > We need to set cs->halted to 1 before calling ppc_set_compat. The reason > is that ppc_set_compat kicks up the new thread created to manage the > hotplugged KVM virtual CPU and the code drives direct

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Fix a deadlock case in the CPU hotplug flow

2018-09-02 Thread Greg Kurz
On Sun, 2 Sep 2018 11:19:04 -0300 Jose Ricardo Ziviani wrote: > We need to set cs->halted to 1 before calling ppc_set_compat. The reason > is that ppc_set_compat kicks up the new thread created to manage the > hotplugged KVM virtual CPU and the code drives directly to KVM_RUN > ioctl. When cs->h

Re: [Qemu-devel] [PATCH 0/4] Reformatted INFO files to fit the Markdown (.md) format.

2018-09-02 Thread Peter Maydell
On 2 September 2018 at 13:36, Yoni Bettan wrote: > This patch make INFO files (e.g. README, CODING_STYLE etc) much more > readable when watched from GitHub GUI. > > ./VERSION and ./MAINTAINERS were leave untouched otherwise > ./scripts/get_maintainer.pl breaks. > > ./COPYING and ./COPYING.LIB were

[Qemu-devel] [PATCH V2 0/3] Formatted INFO files to fit Markdown (.md) format.

2018-09-02 Thread Yoni Bettan
This patch make INFO files (e.g. README, CODING_STYLE and HACKING) much more readable when watched from GitHub GUI. ./VERSION, ./MAINTAINERS were leave untouched otherwise ./scripts/get_maintainer.pl breaks. ./COPYING, ./LICENSE ./COPYING.LIB were leave untouched because it look likes they come f

[Qemu-devel] [PATCH V2 1/3] README.md : Formatted to fit Markdown (.md) format.

2018-09-02 Thread Yoni Bettan
Also updated scripts/checkpatch.pl and made it reference to README.md instead of README. Signed-off-by: Yoni Bettan --- README => README.md | 89 ++- scripts/checkpatch.pl | 2 +- 2 files changed, 46 insertions(+), 45 deletions(-) rename README => READ

[Qemu-devel] [PATCH V2 2/3] CODING_STYLE.md : Formatted to fit Markdown (.md) format.

2018-09-02 Thread Yoni Bettan
Signed-off-by: Yoni Bettan --- CODING_STYLE => CODING_STYLE.md | 151 +--- 1 file changed, 80 insertions(+), 71 deletions(-) rename CODING_STYLE => CODING_STYLE.md (50%) diff --git a/CODING_STYLE b/CODING_STYLE.md similarity index 50% rename from CODING_STYLE rename

[Qemu-devel] [PATCH V2 3/3] HACKING.md : Formatted to fit Markdown (.md) format.

2018-09-02 Thread Yoni Bettan
Signed-off-by: Yoni Bettan --- HACKING => HACKING.md | 186 ++ 1 file changed, 97 insertions(+), 89 deletions(-) rename HACKING => HACKING.md (53%) diff --git a/HACKING b/HACKING.md similarity index 53% rename from HACKING rename to HACKING.md index 0fc3e

Re: [Qemu-devel] [PATCH 0/4] Reformatted INFO files to fit the Markdown (.md) format.

2018-09-02 Thread Yoni Bettan
On 9/2/18 8:13 PM, Peter Maydell wrote: On 2 September 2018 at 13:36, Yoni Bettan wrote: This patch make INFO files (e.g. README, CODING_STYLE etc) much more readable when watched from GitHub GUI. ./VERSION and ./MAINTAINERS were leave untouched otherwise ./scripts/get_maintainer.pl breaks.

Re: [Qemu-devel] [PATCH 0/4] Reformatted INFO files to fit the Markdown (.md) format.

2018-09-02 Thread Yoni Bettan
Please ignore this message as a V2 was already sent. Thanks, Yoni. On 9/2/18 3:36 PM, Yoni Bettan wrote: This patch make INFO files (e.g. README, CODING_STYLE etc) much more readable when watched from GitHub GUI. ./VERSION and ./MAINTAINERS were leave untouched otherwise ./scripts/get_maint

Re: [Qemu-devel] [PATCH] Fix a deadlock case in the CPU hotplug flow

2018-09-02 Thread David Gibson
On Sun, Sep 02, 2018 at 11:19:04AM -0300, Jose Ricardo Ziviani wrote: > We need to set cs->halted to 1 before calling ppc_set_compat. The reason > is that ppc_set_compat kicks up the new thread created to manage the > hotplugged KVM virtual CPU and the code drives directly to KVM_RUN > ioctl. When

Re: [Qemu-devel] [RFC 3/6] vhost-net: Expose vhost_net_get_fd

2018-09-02 Thread Jason Wang
On 2018年08月30日 22:27, Sameeh Jubran wrote: From: Sameeh Jubran Signed-off-by: Sameeh Jubran Better explain the motivation in the commit log. Thanks --- hw/net/vhost_net.c | 2 +- include/hw/virtio/virtio-net.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) dif

Re: [Qemu-devel] [RFC 2/6] tap: Add support for bpf ioctls

2018-09-02 Thread Jason Wang
On 2018年08月30日 22:27, Sameeh Jubran wrote: From: Sameeh Jubran Starting from kernel v4.16 tun device supports TUNSETSTEERINGEBPF and TUNSETFILTEREBPF. Signed-off-by: Sameeh Jubran --- include/net/net.h | 3 ++- net/tap-bsd.c | 5 + net/tap-linux.c | 29 +

Re: [Qemu-devel] [RFC 4/6] virtio-net: implement steering mode feature

2018-09-02 Thread Jason Wang
On 2018年08月30日 22:27, Sameeh Jubran wrote: From: Sameeh Jubran Signed-off-by: Sameeh Jubran --- hw/net/virtio-net.c | 65 + include/hw/virtio/virtio-net.h | 3 ++ include/standard-headers/linux/virtio_net.h | 55 +

Re: [Qemu-devel] [RFC 5/6] virtio-net: steering mode: Implement rss support

2018-09-02 Thread Jason Wang
On 2018年08月30日 22:27, Sameeh Jubran wrote: From: Sameeh Jubran Signed-off-by: Sameeh Jubran --- hw/net/virtio-net.c | 122 1 file changed, 105 insertions(+), 17 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index

Re: [Qemu-devel] [RFC 0/6] Virtio-net: Support RSS

2018-09-02 Thread Jason Wang
On 2018年08月30日 22:27, Sameeh Jubran wrote: From: Sameeh Jubran This series implements the Steering Mode feature which was introduced on the virtio-dev list a while ago, which can be found here: * https://lists.oasis-open.org/archives/virtio-dev/201805/msg00024.html The first three patches a

[Qemu-devel] [PATCH v7 1/7] qapi: Fix build_params() for empty parameter list

2018-09-02 Thread Peter Xu
From: Markus Armbruster build_params() returns '' instead of 'void' when there are no parameters. Can't happen now, but the next commit will change that. Signed-off-by: Markus Armbruster [peterx: compose the patch from email replies] Signed-off-by: Peter Xu --- scripts/qapi/common.py | 10 ++

[Qemu-devel] [PATCH v7 0/7] monitor: enable OOB by default

2018-09-02 Thread Peter Xu
(this series is based on Markus's monitor-next tree so if patchew spits something out with "apply failure" then it's expected) v7: - use Markus's commit message for patch "qapi: Drop qapi_event_send_FOO()'s Error ** argument" [Markus] - update commit message for "qapi: remove COMMAND_DROPPED ev

[Qemu-devel] [PATCH v7 3/7] monitor: suspend monitor instead of send CMD_DROP

2018-09-02 Thread Peter Xu
When we received too many qmp commands, previously we'll send COMMAND_DROPPED events to monitors, then we'll drop the requests. Now instead of dropping the command we stop reading from input when we notice the queue is getting full. Note that here since we removed the need_resume flag we need to

[Qemu-devel] [PATCH v7 7/7] tests: add oob functional test for test-qmp-cmds

2018-09-02 Thread Peter Xu
Straightforward test just to let the test-qmp-cmds be complete. Signed-off-by: Peter Xu --- tests/test-qmp-cmds.c | 16 1 file changed, 16 insertions(+) diff --git a/tests/test-qmp-cmds.c b/tests/test-qmp-cmds.c index ab414fa0c9..23c68c7944 100644 --- a/tests/test-qmp-cmds.c ++

[Qemu-devel] [PATCH v7 2/7] qapi: Drop qapi_event_send_FOO()'s Error ** argument

2018-09-02 Thread Peter Xu
The generated qapi_event_send_FOO() take an Error ** argument. They can't actually fail, because all they do with the argument is passing it to functions that can't fail: the QObject output visitor, and the @qmp_emit callback, which is either monitor_qapi_event_queue() or event_test_emit(). Drop

[Qemu-devel] [PATCH v7 6/7] Revert "tests: Add parameter to qtest_init_without_qmp_handshake"

2018-09-02 Thread Peter Xu
This reverts commit ddee57e0176f6ab53b13c6c97605b62737a8fd7a. Meanwhile, revert one line from fa198ad9bdef to make sure qtest_init_without_qmp_handshake() will only pass in one parameter. Reviewed-by: Markus Armbruster Signed-off-by: Peter Xu --- tests/libqtest.c | 10 -- tests/libqtes

[Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-02 Thread Peter Xu
Now it was not used any more, drop it. We can still do that since out-of-band is still experimental, and this event is only used when out-of-band is enabled. Signed-off-by: Peter Xu --- docs/interop/qmp-spec.txt | 5 +++-- qapi/misc.json| 40 ---

Re: [Qemu-devel] [PATCH 1/1] kvm: add call to qemu_add_opts() for -overcommit option

2018-09-02 Thread Thomas Huth
On 2018-08-15 19:57, prasad.singamse...@oracle.com wrote: > From: Prasad Singamsetty > > qemu command fails to process -overcommit option. Add the missing > call to qemu_add_opts() in vl.c. > > Signed-off-by: Prasad Singamsetty > --- > vl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --g

[Qemu-devel] [PATCH v7 5/7] monitor: remove "x-oob", turn oob on by default

2018-09-02 Thread Peter Xu
OOB commands were introduced in commit cf869d53172. Unfortunately, we ran into a regression, and had to disable them by default for 2.12 (commit be933ffc23). http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html The regression has since been fixed (commit 951702f39c7 "monitor: bin

[Qemu-devel] [PATCH V12 01/19] filter-rewriter: Add TCP state machine and fix memory leak in connection_track_table

2018-09-02 Thread Zhang Chen
We add almost full TCP state machine in filter-rewriter, except TCPS_LISTEN and some simplify in VM active close FIN states. After a net connection is closed, we didn't clear its releated resources in connection_track_table, which will lead to memory leak. Let't track the state of net connection,

[Qemu-devel] [PATCH V12 00/19] COLO: integrate colo frame with block replication and COLO proxy

2018-09-02 Thread Zhang Chen
Hi~ All~ COLO Frame, block replication and COLO proxy(colo-compare,filter-mirror, filter-redirector,filter-rewriter) have been exist in qemu for long time, it's time to integrate these three parts to make COLO really works. In this series, we have some optimizations for COLO frame, including sep

[Qemu-devel] [PATCH V12 02/19] colo-compare: implement the process of checkpoint

2018-09-02 Thread Zhang Chen
While do checkpoint, we need to flush all the unhandled packets, By using the filter notifier mechanism, we can easily to notify every compare object to do this process, which runs inside of compare threads as a coroutine. Signed-off-by: zhanghailiang Signed-off-by: Zhang Chen Signed-off-by: Zha

[Qemu-devel] [Bug 1787505] Re: Solaris host: no network connection, mouse pointer mismatch

2018-09-02 Thread Thomas Huth
** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1787505 Title: Solaris host: no network connection, mouse pointer mismatch Status in QEMU: Invalid

[Qemu-devel] [PATCH V12 03/19] colo-compare: use notifier to notify packets comparing result

2018-09-02 Thread Zhang Chen
It's a good idea to use notifier to notify COLO frame of inconsistent packets comparing. Signed-off-by: Zhang Chen Signed-off-by: Zhang Chen Signed-off-by: zhanghailiang --- net/colo-compare.c | 37 ++--- net/colo-compare.h | 2 ++ 2 files changed, 28 insertion

[Qemu-devel] [PATCH V12 07/19] COLO: Load dirty pages into SVM's RAM cache firstly

2018-09-02 Thread Zhang Chen
We should not load PVM's state directly into SVM, because there maybe some errors happen when SVM is receving data, which will break SVM. We need to ensure receving all data before load the state into SVM. We use an extra memory to cache these data (PVM's ram). The ram cache in secondary side is i

[Qemu-devel] [PATCH V12 04/19] COLO: integrate colo compare with colo frame

2018-09-02 Thread Zhang Chen
For COLO FT, both the PVM and SVM run at the same time, only sync the state while it needs. So here, let SVM runs while not doing checkpoint, change DEFAULT_MIGRATE_X_CHECKPOINT_DELAY to 200*100. Besides, we forgot to release colo_checkpoint_semd and colo_delay_timer, fix them here. Signed-off-b

[Qemu-devel] [PATCH V12 08/19] ram/COLO: Record the dirty pages that SVM received

2018-09-02 Thread Zhang Chen
We record the address of the dirty pages that received, it will help flushing pages that cached into SVM. Here, it is a trick, we record dirty pages by re-using migration dirty bitmap. In the later patch, we will start the dirty log for SVM, just like migration, in this way, we can record both the

[Qemu-devel] [PATCH V12 09/19] COLO: Flush memory data from ram cache

2018-09-02 Thread Zhang Chen
During the time of VM's running, PVM may dirty some pages, we will transfer PVM's dirty pages to SVM and store them into SVM's RAM cache at next checkpoint time. So, the content of SVM's RAM cache will always be same with PVM's memory after checkpoint. Instead of flushing all content of PVM's RAM

[Qemu-devel] [PATCH V12 05/19] COLO: Add block replication into colo process

2018-09-02 Thread Zhang Chen
Make sure master start block replication after slave's block replication started. Besides, we need to activate VM's blocks before goes into COLO state. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Signed-off-by: Zhang Chen Signed-off-by: Zhang Chen --- migration/colo.c | 43 ++

[Qemu-devel] [PATCH V12 06/19] COLO: Remove colo_state migration struct

2018-09-02 Thread Zhang Chen
We need to know if migration is going into COLO state for incoming side before start normal migration. Instead by using the VMStateDescription to send colo_state from source side to destination side, we use MIG_CMD_ENABLE_COLO to indicate whether COLO is enabled or not. Signed-off-by: zhanghailia

[Qemu-devel] [PATCH V12 10/19] qmp event: Add COLO_EXIT event to notify users while exited COLO

2018-09-02 Thread Zhang Chen
From: zhanghailiang If some errors happen during VM's COLO FT stage, it's important to notify the users of this event. Together with 'x-colo-lost-heartbeat', Users can intervene in COLO's failover work immediately. If users don't want to get involved in COLO's failover verdict, it is still necess

[Qemu-devel] [PATCH V12 19/19] docs: Add COLO status diagram to COLO-FT.txt

2018-09-02 Thread Zhang Chen
From: Zhang Chen This diagram make user better understand COLO. Suggested by Markus Armbruster. Signed-off-by: Zhang Chen Signed-off-by: Zhang Chen --- docs/COLO-FT.txt | 34 ++ 1 file changed, 34 insertions(+) diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt

[Qemu-devel] [PATCH V12 11/19] qapi/migration.json: Rename COLO unknown mode to none mode.

2018-09-02 Thread Zhang Chen
From: Zhang Chen Suggested by Markus Armbruster rename COLO unknown mode to none mode. Signed-off-by: Zhang Chen Signed-off-by: Zhang Chen Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster --- migration/colo-failover.c | 2 +- migration/colo.c | 2 +- qapi/migration.json

[Qemu-devel] [PATCH V12 12/19] qapi: Add new command to query colo status

2018-09-02 Thread Zhang Chen
Libvirt or other high level software can use this command query colo status. You can test this command like that: {'execute':'query-colo-status'} Signed-off-by: Zhang Chen Signed-off-by: Zhang Chen --- migration/colo.c| 21 + qapi/migration.json | 32

[Qemu-devel] [PATCH V12 14/19] COLO: flush host dirty ram from cache

2018-09-02 Thread Zhang Chen
From: zhanghailiang Don't need to flush all VM's ram from cache, only flush the dirty pages since last checkpoint Signed-off-by: Li Zhijian Signed-off-by: Zhang Chen Signed-off-by: Zhang Chen Signed-off-by: zhanghailiang Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 9 +

[Qemu-devel] [PATCH V12 13/19] savevm: split the process of different stages for loadvm/savevm

2018-09-02 Thread Zhang Chen
There are several stages during loadvm/savevm process. In different stage, migration incoming processes different types of sections. We want to control these stages more accuracy, it will benefit COLO performance, we don't have to save type of QEMU_VM_SECTION_START sections everytime while do check

[Qemu-devel] [PATCH V12 15/19] filter: Add handle_event method for NetFilterClass

2018-09-02 Thread Zhang Chen
Filter needs to process the event of checkpoint/failover or other event passed by COLO frame. Signed-off-by: zhanghailiang Signed-off-by: Zhang Chen Signed-off-by: Zhang Chen --- include/net/filter.h | 5 + net/filter.c | 17 + net/net.c| 19 +++

[Qemu-devel] [PATCH V12 18/19] COLO: quick failover process by kick COLO thread

2018-09-02 Thread Zhang Chen
From: zhanghailiang COLO thread may sleep at qemu_sem_wait(&s->colo_checkpoint_sem), while failover works begin, It's better to wakeup it to quick the process. Signed-off-by: zhanghailiang Reviewed-by: Dr. David Alan Gilbert --- migration/colo.c | 8 1 file changed, 8 insertions(+)

[Qemu-devel] [PATCH V12 17/19] COLO: notify net filters about checkpoint/failover event

2018-09-02 Thread Zhang Chen
From: zhanghailiang Notify all net filters about the checkpoint and failover event. Signed-off-by: zhanghailiang Reviewed-by: Dr. David Alan Gilbert --- migration/colo.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/migration/colo.c b/migration/colo.c index 25d279decf..

[Qemu-devel] [PATCH V12 16/19] filter-rewriter: handle checkpoint and failover event

2018-09-02 Thread Zhang Chen
After one round of checkpoint, the states between PVM and SVM become consistent, so it is unnecessary to adjust the sequence of net packets for old connections, besides, while failover happens, filter-rewriter will into failover mode that needn't handle the new TCP connection. Signed-off-by: zhang

Re: [Qemu-devel] [PULL 8/9] tests: add qmp/qom-set-without-value test

2018-09-02 Thread Thomas Huth
On 2018-08-31 16:35, Markus Armbruster wrote: > Thomas Huth writes: > >> On 2018-08-31 15:24, Marc-André Lureau wrote: >>> Hi >>> On Fri, Aug 31, 2018 at 3:18 PM Thomas Huth wrote: On 2018-08-31 14:04, Markus Armbruster wrote: > Thomas Huth writes: > >> From: Marc-André Lu

[Qemu-devel] [Bug 1789751] Re: Using -overcommit flag leads to qemu crashing

2018-09-02 Thread Thomas Huth
It seems to be fixed already: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=1fdd4748711a62d863744 ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bu

Re: [Qemu-devel] [PATCH] tests/check-qjson: fix a leak

2018-09-02 Thread Thomas Huth
On 2018-09-01 23:19, Marc-André Lureau wrote: > Spotted by ASAN: > = > ==11893==ERROR: LeakSanitizer: detected memory leaks > > Direct leak of 1120 byte(s) in 28 object(s) allocated from: > #0 0x7fd0515b0c48 in malloc (/lib64/liba

Re: [Qemu-devel] [PATCH v4 10/10] qmp: common 'id' handling & make QGA conform to QMP spec

2018-09-02 Thread Markus Armbruster
Marc-André Lureau writes: > On Sat, Sep 1, 2018 at 12:59 PM, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >>> Let qmp_dispatch() copy the 'id' field. That way any qmp client will >>> conform to the specification, including QGA. Furthermore, it >>> simplifies the work for qemu monito

Re: [Qemu-devel] [PATCH v7 0/7] monitor: enable OOB by default

2018-09-02 Thread Markus Armbruster
Peter Xu writes: > (this series is based on Markus's monitor-next tree so if patchew > spits something out with "apply failure" then it's expected) Easy to avoid with suitable Based: tags in the cover letter: Based-on: <20180828191048.29806-1-arm...@redhat.com> Based-on: <2018090716.1675-1

Re: [Qemu-devel] [PATCH] tests/check-qjson: fix a leak

2018-09-02 Thread Markus Armbruster
Marc-André Lureau writes: > Spotted by ASAN: > = > ==11893==ERROR: LeakSanitizer: detected memory leaks > > Direct leak of 1120 byte(s) in 28 object(s) allocated from: > #0 0x7fd0515b0c48 in malloc (/lib64/libasan.so.5+0xeec48) >

Re: [Qemu-devel] [PATCH] tests/check-qjson: fix a leak

2018-09-02 Thread Markus Armbruster
Thomas Huth writes: > On 2018-09-01 23:19, Marc-André Lureau wrote: >> Spotted by ASAN: >> = >> ==11893==ERROR: LeakSanitizer: detected memory leaks >> >> Direct leak of 1120 byte(s) in 28 object(s) allocated from: >> #0 0x7fd05

Re: [Qemu-devel] [PATCH] tests/check-qjson: fix a leak

2018-09-02 Thread Thomas Huth
On 2018-09-03 07:51, Markus Armbruster wrote: > Thomas Huth writes: > >> On 2018-09-01 23:19, Marc-André Lureau wrote: >>> Spotted by ASAN: >>> = >>> ==11893==ERROR: LeakSanitizer: detected memory leaks >>> >>> Direct leak of 1120 by

Re: [Qemu-devel] [PATCH] input-linux: toggle for lock keys

2018-09-02 Thread Gerd Hoffmann
On Fri, Aug 31, 2018 at 01:31:06PM +, Ryan El Kochta wrote: > On Aug 31, 2018, 2:07 AM, Gerd Hoffmann wrote: > > Hi, > > > That's a wonderful idea. Would you be comfortable with > > grab_toggle=custom:x:x as well? > > What this is supposed to do? > > cheers, > Gerd > > It would be the same

[Qemu-devel] [PULL 1/5] virtio-vga: fix reset

2018-09-02 Thread Gerd Hoffmann
We must call the reset functions for both virtio-gpu and vga to properly reset the combo device. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Message-id: 2018082313.27792-2-kra...@redhat.com --- include/hw/virtio/virtio-gpu.h | 1 + hw/display/virtio-gpu.c| 2 +- hw/d

[Qemu-devel] [PULL 0/5] Vga 20180903 patches

2018-09-02 Thread Gerd Hoffmann
The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452: Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' into staging (2018-08-27 16:44:20 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/vga-20180903-pull-request

[Qemu-devel] [PULL 2/5] Revert "virtio-gpu: fix crashes upon warm reboot with vga mode"

2018-09-02 Thread Gerd Hoffmann
This reverts commit 93f874fe9dbe0b997b5a9459840957efd13d7191. Now with virtio-vga being resetted properly the crash workaround is not needed any more. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Message-id: 2018082313.27792-3-kra...@redhat.com --- include/hw/virtio/virtio-g