[Qemu-devel] [PATCH] vl.c: print error message if load fw_cfg file failed

2018-10-06 Thread Li Qiang
It makes sense to print the error message while reading file failed. Signed-off-by: Li Qiang --- vl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index cc55fe04a2..3db410e771 100644 --- a/vl.c +++ b/vl.c @@ -2207,8 +2207,9 @@ static int parse_fw_cfg(void

[Qemu-devel] [Bug 1483070] Re: VIRTIO Sequential Write IOPS limits not working

2018-10-06 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1483070 Title: VIRTIO Sequ

Re: [Qemu-devel] [RFC PATCH 04/21] trace: enable the exec_tb trace events

2018-10-06 Thread Emilio G. Cota
On Fri, Oct 05, 2018 at 16:48:53 +0100, Alex Bennée wrote: > Our performance isn't so critical that we can't spare a simple flag > check when we exec a TB considering everything else we check in the > outer loop. [I know this is just done to illustrate how function names in plugins can bind to tra

Re: [Qemu-devel] [RFC PATCH 14/21] trace: add support for plugin infrastructure

2018-10-06 Thread Emilio G. Cota
On Fri, Oct 05, 2018 at 16:49:03 +0100, Alex Bennée wrote: (snip) > +static int bind_to_tracepoints(GModule *g_module, GPtrArray *events) > +{ > +int count = 0; > +TraceEventIter iter; > +TraceEvent *ev; > + > +trace_event_iter_init(&iter, "*"); > +while ((ev = trace_event_iter_

Re: [Qemu-devel] [RFC PATCH 00/21] Trace updates and plugin RFC

2018-10-06 Thread Emilio G. Cota
On Fri, Oct 05, 2018 at 16:48:49 +0100, Alex Bennée wrote: (snip) > ==Known Limitations== > > Currently there is only one hook allowed per trace event. We could > make this more flexible or simply just error out if two plugins try > and hook to the same point. What are the expectations of running

[Qemu-devel] [RFC 0/6] Dynamic TLB sizing

2018-10-06 Thread Emilio G. Cota
After reading this paper [1], I wondered whether how far one could push the idea of dynamic TLB resizing. We discussed it briefly in this thread: https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg02340.html Since then, (1) rth helped me (thanks!) with TCG backend code, and (2) I've abando

[Qemu-devel] [RFC 6/6] cputlb: dynamically resize TLBs based on use rate

2018-10-06 Thread Emilio G. Cota
Perform the resizing only on flushes, otherwise we'd have to take a perf hit by either rehashing the array or unnecessarily flushing it. We grow the array aggressively, and reduce the size more slowly. This accommodates mixed workloads, where some processes might be memory-heavy while others are n

[Qemu-devel] [RFC 5/6] cpu-defs: define MIN_CPU_TLB_SIZE

2018-10-06 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- include/exec/cpu-defs.h | 6 +++--- accel/tcg/cputlb.c| 2 +- tcg/i386/tcg-target.inc.c | 3 ++- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/include/exec/cpu-defs.h b/include/exec/cpu-defs.h index af9fe04b0b..27b9433976 100644 --- a/i

[Qemu-devel] [RFC 4/6] tcg: define TCG_TARGET_TLB_MAX_INDEX_BITS

2018-10-06 Thread Emilio G. Cota
From: Pranith Kumar This paves the way for implementing a dynamically-sized softmmu. Signed-off-by: Pranith Kumar Signed-off-by: Emilio G. Cota --- tcg/aarch64/tcg-target.h | 1 + tcg/arm/tcg-target.h | 1 + tcg/i386/tcg-target.h| 2 ++ tcg/mips/tcg-target.h| 2 ++ tcg/ppc/tcg-tar

[Qemu-devel] [RFC 2/6] cputlb: do not evict invalid entries to the vtlb

2018-10-06 Thread Emilio G. Cota
Currently we evict an entry to the victim TLB when it doesn't match the current address. But it could be that there's no match because the current entry is invalid. Do not evict the entry to the vtlb in that case. This change will help us keep track of the TLB's use rate. Signed-off-by: Emilio G.

[Qemu-devel] [RFC 3/6] cputlb: track TLB use rates

2018-10-06 Thread Emilio G. Cota
This paves the way for implementing a dynamically-sized softmmu. Signed-off-by: Emilio G. Cota --- include/exec/cpu-defs.h | 1 + accel/tcg/cputlb.c | 17 ++--- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/include/exec/cpu-defs.h b/include/exec/cpu-defs.h ind

[Qemu-devel] [RFC 1/6] (XXX) cputlb: separate MMU allocation + run-time sizing

2018-10-06 Thread Emilio G. Cota
No dynamic sizing yet, but the indirection is there. XXX: - convert other TCG backends Signed-off-by: Emilio G. Cota --- accel/tcg/softmmu_template.h | 14 + include/exec/cpu-defs.h | 14 ++--- include/exec/cpu_ldst.h | 2 +- include/exec/cpu_ldst_template.h |

[Qemu-devel] [Bug 1796520] [NEW] autogen crashes on qemu-sh4-user after 61dedf2af7

2018-10-06 Thread John Paul Adrian Glaubitz
Public bug reported: Running "autogen --help" crashes on qemu-sh4-user with: (sid-sh4-sbuild)root@nofan:/# autogen --help Unhandled trap: 0x180 pc=0xf64dd2de sr=0x pr=0xf63b9c74 fpscr=0x0008 spc=0x ssr=0x gbr=0xf61102a8 vbr=0x sgr=0x dbr=0x dela

[Qemu-devel] vhost: add virtio-vhost-user transport

2018-10-06 Thread Nikos Dragazis
Hi everyone, In response to a previous email of mine here: https://lists.01.org/pipermail/spdk/2018-September/002488.html I would like to share that I have added support for a new virtio-vhost-user transport to SPDK. and have a working demo of the SPDK vhost-scsi target over this transport. I ha

Re: [Qemu-devel] [SPDK] virtio-vhost-user with virtio-scsi: end-to-end setup

2018-10-06 Thread Nikos Dragazis
Hi Pawel, Thank you for your quick reply. I appreciate your help. I’m sorry for the late response. I am glad to tell you that I have a working demo at last. I have managed to solve my problem. You were right about the IO channels. Function spdk_scsi_dev_allocate_io_channels() fails to allocate t

Re: [Qemu-devel] [RFC PATCH 10/21] qom/cpu: add a cpu_exit trace event

2018-10-06 Thread Richard Henderson
On 10/5/18 8:48 AM, Alex Bennée wrote: > This is useful for tracing cpu_exit events where we signal the CPU to > come back to the main loop. > > Signed-off-by: Alex Bennée > --- > qom/cpu.c| 3 +++ > qom/trace-events | 4 > 2 files changed, 7 insertions(+) Reviewed-by: Richard Hend

[Qemu-devel] [PATCH] qemu-io-cmds: Fix two format strings

2018-10-06 Thread Stefan Weil
Use %zu instead of %zd for unsigned numbers. This fixes two error messages from the LSTM static code analyzer: This argument should be of type 'ssize_t' but is of type 'unsigned long' Signed-off-by: Stefan Weil --- qemu-io-cmds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [Qemu-devel] [RFC PATCH 06/21] trace: show trace point counts in the monitor

2018-10-06 Thread Richard Henderson
On 10/5/18 8:48 AM, Alex Bennée wrote: > Now we have counts for each trace point we can expose them in the > monitor when the user queries what trace points are available. > > Signed-off-by: Alex Bennée > --- > monitor.c | 5 +++-- > qapi/trace.json | 3 ++- > trace/qmp.c | 1 + > 3 fi

Re: [Qemu-devel] [RFC PATCH 05/21] trace: keep a count of trace-point hits

2018-10-06 Thread Richard Henderson
On 10/5/18 8:48 AM, Alex Bennée wrote: > @@ -81,6 +81,8 @@ def generate_c(event, group): > cond = "trace_event_get_state(%s)" % event_id > > out('', > +'%(event_obj)s.count++;', > +'', > 'if (!%(cond)s) {', > 'return;', > '

Re: [Qemu-devel] [RFC PATCH 03/21] linux-user: add -dfilter progtext shortcut

2018-10-06 Thread Richard Henderson
On 10/5/18 8:48 AM, Alex Bennée wrote: > When debugging you often don't care about the libraries but just the > code in the testcase. Rather than make the user build this by hand > offer a shortcut. > > Signed-off-by: Alex Bennée > Reviewed-by: Laurent Vivier > --- > linux-user/main.c | 16

Re: [Qemu-devel] [RFC PATCH 04/21] trace: enable the exec_tb trace events

2018-10-06 Thread Richard Henderson
On 10/5/18 8:48 AM, Alex Bennée wrote: > Our performance isn't so critical that we can't spare a simple flag > check when we exec a TB considering everything else we check in the > outer loop. > > Signed-off-by: Alex Bennée > --- > accel/tcg/trace-events | 9 + > 1 file changed, 5 insert

Re: [Qemu-devel] [RFC PATCH 02/21] util/log: add qemu_dfilter_append_range()

2018-10-06 Thread Richard Henderson
On 10/5/18 8:48 AM, Alex Bennée wrote: > This allows us to add to the dfilter range as we go. > > Signed-off-by: Alex Bennée > --- > include/qemu/log.h | 1 + > util/log.c | 6 ++ > 2 files changed, 7 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [RFC PATCH 01/21] util/log: allow -dfilter to stack

2018-10-06 Thread Richard Henderson
On 10/5/18 8:48 AM, Alex Bennée wrote: > The original dfilter was patched to avoid a leak in the case of > multiple -dfilter ranges. There is no reason not to allow the user to > stack several dfilter options rather than push them all into one mega > line. We avoid the leak by simply only allocatin

[Qemu-devel] [PATCH] target/i386: kvm: just return after migrate_add_blocker failed

2018-10-06 Thread Li Qiang
When migrate_add_blocker failed, the invtsc_mig_blocker is not appended so no need to remove. This can save several instructions. Signed-off-by: Li Qiang --- target/i386/kvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/kvm.c b/target/i386/kvm.c index 0b2a07d3