On 10/11/2018 09:19 PM, Markus Armbruster wrote:
Fei Li writes:
The caller of qemu_init_vcpu() already passed the **errp to handle
Which caller? There are many. Or do you mean "The callers"?
Oh, sorry, I mean "The callers" :)
errors. In view of this, add a new Error parameter to the
Copying Marc-André for a possible connection to his recent work on
improving help. Marc-André, search for "format=help". Just in case you
have further observations to offer.
Max Reitz writes:
> On 08.10.18 19:31, Markus Armbruster wrote:
>> Calling error_report() from within a a function that
On 10/11/2018 09:13 PM, Markus Armbruster wrote:
Fei Li writes:
Add a new Error parameter for vnc_display_init() to handle errors
in its caller: vnc_init_func(), just like vnc_display_open() does.
And let the call trace propagate the Error.
Besides, make vnc_start_worker_thread() return a
On 10/11/2018 06:02 PM, Markus Armbruster wrote:
Fei Li writes:
Currently, when qemu_signal_init() fails it only returns a non-zero
value but without propagating any Error. But its callers need a
non-null err when runs error_report_err(err), or else 0->msg occurs.
The bug is in
During an active background migraion, snapshot will trigger a
segmentfault. As snapshot clears the "current_migration" struct
and updates "to_dst_file" before it finds out that there is a
migration task, Migration accesses the null pointer in
"current_migration" struct and qemu crashes eventually.
Define a TYPE_VFIO_PCI and drop DO_UPCAST.
Signed-off-by: Li Qiang
---
hw/vfio/pci.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 866f0deeb7..3f232aedff 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@
The virtio-balloon devices was never really thought out for cases
other than 4kiB pagesize on both guest and host. It works in some
cases, but in others can be ineffectual or even cause guest memory
corruption.
This series makes a handful of preliminary cleanups, then makes a
change to safely,
Currently, virtio-balloon uses madvise() with MADV_DONTNEED to actually
discard RAM pages inserted into the balloon. This is basically a Linux
only interface (MADV_DONTNEED exists on some other platforms, but doesn't
always have the same semantics). It also doesn't work on hugepages and has
some
This replaces the balloon_page() internal interface with
ballon_inflate_page(), with a slightly different interface. The new
interface will make future alterations simpler.
Signed-off-by: David Gibson
---
hw/virtio/virtio-balloon.c | 17 +++--
1 file changed, 7 insertions(+), 10
The virtio-balloon device's verification of the address given to it by the
guest has a number of faults:
* The addresses here are guest physical addresses, which should be
'hwaddr' rather than 'ram_addr_t' (the distinction is admittedly
pretty subtle and confusing)
* We don't
The virtio-balloon always works in units of 4kiB (BALLOON_PAGE_SIZE), but
on the host side, we can only actually discard memory in units of the host
page size.
At present we handle this very badly: we silently ignore balloon requests
that aren't host page aligned, and for requests that are host
When the balloon is inflated, we discard memory place in it using madvise()
with MADV_DONTNEED. And when we deflate it we use MADV_WILLNEED, which
sounds like it makes sense but is actually unnecessary.
The misleadingly named MADV_DONTNEED just discards the memory in question,
it doesn't set any
> -Original Message-
> From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> Sent: Thursday, October 11, 2018 4:35 AM
> To: Liu, Jingqi
> Cc: Xu, Tao3 ; pbonz...@redhat.com; r...@twiddle.net;
> qemu-devel@nongnu.org; Robert Hoo
> Subject: Re: [PATCH 1/1] i386: Add new model of
The following changes since commit 75e50c80e051423a6f55a34ee4a1eec842444a5b:
Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2018-10-10' into
staging (2018-10-11 10:43:37 +0100)
are available in the Git repository at:
git://github.com/famz/qemu.git tags/block-pull-request
for
From: Marc-André Lureau
-object iothread,id=foo,? will crash qemu:
qemu-system-x86_64:qemu-thread-posix.c:128: qemu_cond_destroy: Assertion
`cond->initialized' failed.
Use thread_id != -1 to check if iothread_complete() finished
successfully and the mutex/cond have been initialized.
From: Paolo Bonzini
nvme_poll_queues is already protected by q->lock, and
AIO callbacks are invoked outside the AioContext lock.
So remove the acquire/release pair in nvme_handle_event.
Signed-off-by: Paolo Bonzini
Message-Id: <20180814062739.19640-1-pbonz...@redhat.com>
Signed-off-by: Fam
On Thu, Oct 11, 2018 at 04:41:52PM -0700, Richard Henderson wrote:
1;5202;0c> There are a few bugs here, primarily wrt usage of GETPC().
> But there is opportunity to share more code between paths
> that operate on different floating point types.
>
> This is not everything that could be done, but
On 10/11/18 7:05 PM, Peter Maydell wrote:
On 11 October 2018 at 11:45, Philippe Mathieu-Daudé wrote:
On 11/10/2018 11:00, Mao Zhongyi wrote:
Cc: Jan Kiszka
Cc: Peter Maydell
Cc: Gerd Hoffmann
To: qemu-...@nongnu.org
Signed-off-by: Mao Zhongyi
---
hw/arm/musicpal.c | 16
On 10/11/18 6:39 PM, Philippe Mathieu-Daudé wrote:
Hi Mao,
On 11/10/2018 11:00, Mao Zhongyi wrote:
The header file wm8750.h contains '#define TYPE_WM8750 "wm8750"'
macro, but '#define CODEC "wm8750"' macro is redefined in wm8750.c,
just remove the local CODEC macro and replace it with
On 10/11/2018 07:22 PM, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
hw/ipmi/ipmi_bmc_extern.c | 4
1 file changed, 4 deletions(-)
diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c
index bf0b7ee0f5..8c78b9804b 100644
---
Since IOCanReadHandler now returns an unsigned value, the assertion
does not make sense anymore. We choose however to keep a "fail-safe"
assertion to catch undesired overflows.
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
chardev/char.c | 17 +
Note than tcp_chr_recv() already use size_t.
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
chardev/char-socket.c | 2 +-
include/chardev/char.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
chardev/char-fd.c | 2 +-
include/chardev/char-fd.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/chardev/char-fd.c b/chardev/char-fd.c
index bb426fa4b1..900da2f935 100644
---
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
backends/rng-egd.c | 4 ++--
chardev/char-mux.c | 2 +-
gdbstub.c | 2 +-
hw/arm/pxa2xx.c | 2 +-
hw/arm/strongarm.c | 2 +-
hw/char/bcm2835_aux.c | 2 +-
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
chardev/char.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/chardev/char.c b/chardev/char.c
index e115166995..952f9c9bcc 100644
--- a/chardev/char.c
+++ b/chardev/char.c
@@ -159,12 +159,15 @@ int
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
chardev/char-fe.c | 8
chardev/char-win-stdio.c | 2 +-
chardev/char-win.c| 2 +-
include/chardev/char-fe.h | 6 +++---
4 files changed, 9 insertions(+), 9 deletions(-)
diff --git
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
chardev/baum.c | 2 +-
chardev/char-fd.c | 2 +-
chardev/char-mux.c | 2 +-
chardev/char-pty.c | 2 +-
chardev/char-ringbuf.c | 4 ++--
chardev/char-socket.c | 2 +-
chardev/char-udp.c | 2 +-
Signed-off-by: Philippe Mathieu-Daudé
---
target/xtensa/xtensa-semi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/target/xtensa/xtensa-semi.c b/target/xtensa/xtensa-semi.c
index 2f76216276..e389069f0b 100644
--- a/target/xtensa/xtensa-semi.c
+++ b/target/xtensa/xtensa-semi.c
@@ -161,7
IOWatchPoll::fd_can_read() simply returns a boolean value.
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
---
chardev/char-fd.c | 4 ++--
chardev/char-io.c | 4 ++--
chardev/char-pty.c| 4 ++--
chardev/char-socket.c | 6 +++---
chardev/char-udp.c
The number of bytes can not be negative nor zero.
Fixed 2 format string:
- hw/char/spapr_vty.c
- hw/usb/ccid-card-passthru.c
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Alberto Garcia
---
backends/rng-egd.c | 2 +-
chardev/char-mux.c | 2 +-
Hi Paolo,
Here are the changes you suggested in
https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02294.html
First two simple cleanups while here,
then slowly convert backends then frontends.
Regards,
Phil.
Philippe Mathieu-Daudé (11):
hw/ipmi: Remove unnecessary declarations
Signed-off-by: Philippe Mathieu-Daudé
---
hw/ipmi/ipmi_bmc_extern.c | 4
1 file changed, 4 deletions(-)
diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c
index bf0b7ee0f5..8c78b9804b 100644
--- a/hw/ipmi/ipmi_bmc_extern.c
+++ b/hw/ipmi/ipmi_bmc_extern.c
@@ -85,10 +85,6 @@
Signed-off-by: Philippe Mathieu-Daudé
---
gdbstub.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/gdbstub.c b/gdbstub.c
index c8478de8f5..c4e4f9f082 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -20,7 +20,6 @@
#include "qapi/error.h"
#include "qemu/error-report.h"
#include "qemu/cutils.h"
On Thu, Oct 11, 2018 at 03:04:08PM +0200, Greg Kurz wrote:
> On Thu, 11 Oct 2018 13:02:50 +0200
> Philippe Mathieu-Daudé wrote:
>
> > Hi Greg,
> >
> > On 11/10/2018 09:00, Greg Kurz wrote:
> > > According to CODING_STYLE, structured types names are expected to be
> > > in CamelCase. PCI is
On Thu, 11 Oct 2018 02:34:16 PDT (-0700), peter.mayd...@linaro.org wrote:
On 10 October 2018 at 19:22, Palmer Dabbelt wrote:
On Wed, 10 Oct 2018 11:10:07 PDT (-0700), peter.mayd...@linaro.org wrote:
On 10 October 2018 at 18:49, Palmer Dabbelt wrote:
we should really
get the ball rolling
On Thu, Oct 11, 2018 at 4:46 AM Fam Zheng wrote:
> On Mon, 10/01 01:23, Philippe Mathieu-Daudé wrote:
> > Signed-off-by: Philippe Mathieu-Daudé
> > ---
> > v2: Add get_default_jobs (Fam suggestion)
> > ---
> > tests/vm/basevm.py | 13 ++---
> > 1 file changed, 10 insertions(+), 3
Signed-off-by: Richard Henderson
---
target/ppc/fpu_helper.c | 67 +
1 file changed, 28 insertions(+), 39 deletions(-)
diff --git a/target/ppc/fpu_helper.c b/target/ppc/fpu_helper.c
index 127c08bcec..2ed4f42275 100644
--- a/target/ppc/fpu_helper.c
+++
The always_inline trick only works if the function is always
called from the outer-most helper. But it isn't, so pass in
the outer-most return address. There's no need for a switch
statement whose argument is always a constant. Unravel the
switch and goto via more helpers.
Signed-off-by:
Signed-off-by: Richard Henderson
---
target/ppc/fpu_helper.c | 52 +++--
1 file changed, 24 insertions(+), 28 deletions(-)
diff --git a/target/ppc/fpu_helper.c b/target/ppc/fpu_helper.c
index ef251d062f..127c08bcec 100644
--- a/target/ppc/fpu_helper.c
+++
Signed-off-by: Richard Henderson
---
target/ppc/fpu_helper.c | 60 ++---
1 file changed, 26 insertions(+), 34 deletions(-)
diff --git a/target/ppc/fpu_helper.c b/target/ppc/fpu_helper.c
index 9ae55b1e93..111ce12a37 100644
--- a/target/ppc/fpu_helper.c
+++
Signed-off-by: Richard Henderson
---
target/ppc/fpu_helper.c | 43 +++--
1 file changed, 20 insertions(+), 23 deletions(-)
diff --git a/target/ppc/fpu_helper.c b/target/ppc/fpu_helper.c
index 111ce12a37..ef251d062f 100644
--- a/target/ppc/fpu_helper.c
+++
Use do_float_check_status directly, so that we don't get confused
about which return address we're using. And definitely don't use
helper_float_check_status.
Signed-off-by: Richard Henderson
---
target/ppc/fpu_helper.c | 77 +++--
1 file changed, 35
There are a few bugs here, primarily wrt usage of GETPC().
But there is opportunity to share more code between paths
that operate on different floating point types.
This is not everything that could be done, but it's a good start.
Better for this not to hang out on a branch for another release.
Having a separate, logical classifiation of numbers will
unify more error paths for different formats.
Signed-off-by: Richard Henderson
---
target/ppc/fpu_helper.c | 94 ++---
1 file changed, 51 insertions(+), 43 deletions(-)
diff --git
On 11/10/2018 22:51, Richard Henderson wrote:
> This is done generically in translator_loop.
>
> Reported-by: Laurent Desnogues
> Signed-off-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
> ---
> target/arm/translate-a64.c | 1 -
> target/arm/translate.c | 1 -
> 2 files
On 11/10/2018 22:51, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
> ---
> target/arm/translate.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/target/arm/translate.c b/target/arm/translate.c
> index
On 10/9/18 10:51 AM, Emilio G. Cota wrote:
> From: Richard Henderson
>
> Isolate the computation of an index from an address into a
> helper before we change that function.
>
> Reviewed-by: Alex Bennée
> Signed-off-by: Richard Henderson
> [ cota: convert tlb_vaddr_to_host; use atomic_read on
On 10/9/18 10:45 AM, Emilio G. Cota wrote:
> v4: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg01421.html
>
> Changes since v4:
>
> - Add two patches to remove early calls to tlb_flush.
>
> You can fetch the series from:
> https://github.com/cota/qemu/tree/tlb-lock-v5
Queued,
On 10/10/18 7:48 AM, Emilio G. Cota wrote:
> The first patch we've seen before -- I'm taking it from the
> atomic interrupt_request series.
>
> The other three patches are related to TCG profiling. One
> of them is a build fix that I suspect has gone unnoticed
> due to its dependence on
On Thu, Oct 11, 2018 at 9:13 PM Philippe Mathieu-Daudé
wrote:
>
> When using an incorrect backend for the debugcon, QEMU exits silently
> without any error indication, which is confusing.
> Add a message that the character backend is invalid.
>
> Signed-off-by: Philippe Mathieu-Daudé
On Thu, Oct 11, 2018 at 09:31:23PM +0200, Kamil Rytarowski wrote:
> On 11.10.2018 16:25, Brad Smith wrote:
> > On 10/11/2018 5:41 AM, Kamil Rytarowski wrote:
> >
> >> On 11.10.2018 11:36, Peter Maydell wrote:
> >>> On 11 October 2018 at 00:55, Brad Smith wrote:
> And from FreeBSD...
>
On Mon, 17 Sep 2018 08:17:29 +0200
Gerd Hoffmann wrote:
> So we have a boot display when using a vgpu as primary display.
>
> ramfb depends on a fw_cfg file. fw_cfg files can not be added and
> removed at runtime, therefore a ramfb-enabled vfio device can't be
> hotplugged.
>
> Add a
Move mla_op and mls_op expanders from translate-a64.c.
Signed-off-by: Richard Henderson
---
target/arm/translate.h | 2 +
target/arm/translate-a64.c | 106 -
target/arm/translate.c | 134 -
3 files changed, 120
Hi All,
On Thu, Oct 11, 2018 at 7:22 AM Palmer Dabbelt wrote:
> On Wed, 10 Oct 2018 11:10:07 PDT (-0700), peter.mayd...@linaro.org wrote:
> > On 10 October 2018 at 18:49, Palmer Dabbelt wrote:
> >> we should really
> >> get the ball rolling on our big patch backlog.
> >
> > Yes, please do.
Move cmtst_op expanders from translate-a64.c.
Signed-off-by: Richard Henderson
---
target/arm/translate.h | 2 +
target/arm/translate-a64.c | 38 --
target/arm/translate.c | 81 +++---
3 files changed, 60 insertions(+), 61 deletions(-)
Signed-off-by: Richard Henderson
---
target/arm/translate.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/target/arm/translate.c b/target/arm/translate.c
index 4dcd7123e9..fae132791a 100644
--- a/target/arm/translate.c
+++ b/target/arm/translate.c
@@
Move shi_op and sli_op expanders from translate-a64.c.
Signed-off-by: Richard Henderson
---
target/arm/translate.h | 2 +
target/arm/translate-a64.c | 152 +--
target/arm/translate.c | 244 ++---
3 files changed, 179 insertions(+),
For a sequence of loads or stores from a single register,
little-endian operations can be promoted to an 8-byte op.
This can reduce the number of operations by a factor of 8.
Signed-off-by: Richard Henderson
---
target/arm/translate.c | 10 ++
1 file changed, 10 insertions(+)
diff
Instead of shifts and masks, use direct loads and stores from
the neon register file.
Signed-off-by: Richard Henderson
---
target/arm/translate.c | 92 +++---
1 file changed, 50 insertions(+), 42 deletions(-)
diff --git a/target/arm/translate.c
For a sequence of loads or stores from a single register,
little-endian operations can be promoted to an 8-byte op.
This can reduce the number of operations by a factor of 8.
Signed-off-by: Richard Henderson
---
target/arm/translate-a64.c | 66 +++---
1 file
Move ssra_op and usra_op expanders from translate-a64.c.
Signed-off-by: Richard Henderson
---
target/arm/translate.h | 2 +
target/arm/translate-a64.c | 106
target/arm/translate.c | 139 ++---
3 files changed, 130
Signed-off-by: Richard Henderson
---
target/arm/translate.c | 70 +-
1 file changed, 48 insertions(+), 22 deletions(-)
diff --git a/target/arm/translate.c b/target/arm/translate.c
index e195efcc55..a16f323d52 100644
--- a/target/arm/translate.c
+++
Signed-off-by: Richard Henderson
---
target/arm/translate.c | 67 --
1 file changed, 39 insertions(+), 28 deletions(-)
diff --git a/target/arm/translate.c b/target/arm/translate.c
index 4ac526e298..109689a286 100644
--- a/target/arm/translate.c
+++
Instead of shifts and masks, use direct loads and stores from the neon
register file. Mirror the iteration structure of the ARM pseudocode
more closely. Correct the parameters of the VLD2 A2 insn.
Signed-off-by: Richard Henderson
---
target/arm/translate.c | 170
Also introduces neon_element_offset to find the env offset
of a specific element within a neon register.
Signed-off-by: Richard Henderson
---
target/arm/translate.c | 63 --
1 file changed, 36 insertions(+), 27 deletions(-)
diff --git
Signed-off-by: Richard Henderson
---
target/arm/translate.c | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/target/arm/translate.c b/target/arm/translate.c
index fae132791a..e195efcc55 100644
--- a/target/arm/translate.c
+++
Move expanders for VBSL, VBIT, and VBIF from translate-a64.c.
Signed-off-by: Richard Henderson
---
target/arm/translate.h | 6 +-
target/arm/translate-a64.c | 61 --
target/arm/translate.c | 162 +++--
3 files changed, 123 insertions(+),
Signed-off-by: Richard Henderson
---
target/arm/translate.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target/arm/translate.c b/target/arm/translate.c
index 736880ee71..d59ffa1c67 100644
--- a/target/arm/translate.c
+++ b/target/arm/translate.c
@@ -72,7 +72,7 @@
Signed-off-by: Richard Henderson
---
target/arm/translate-a64.c | 28 +++-
1 file changed, 3 insertions(+), 25 deletions(-)
diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index ac9723c1b9..fff99ca303 100644
--- a/target/arm/translate-a64.c
+++
Signed-off-by: Richard Henderson
---
target/arm/translate.c | 29 ++---
1 file changed, 10 insertions(+), 19 deletions(-)
diff --git a/target/arm/translate.c b/target/arm/translate.c
index 4ab9f69b01..4dcd7123e9 100644
--- a/target/arm/translate.c
+++
Signed-off-by: Richard Henderson
---
target/arm/translate.c | 81 ++
1 file changed, 26 insertions(+), 55 deletions(-)
diff --git a/target/arm/translate.c b/target/arm/translate.c
index a9bd93bba1..1e79a1eec0 100644
--- a/target/arm/translate.c
+++
From: Richard Henderson
This can reduce the number of opcodes required for certain
complex forms of load-multiple (e.g. ld4.16b).
Signed-off-by: Richard Henderson
---
target/arm/translate-a64.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git
The conversion to gvec is by no means complete, but it brings aa32
to parity with the work already done for aa64. Plus some misc changes,
at least one of which has been sitting on a branch for 2 years. ;-P
I've run the result through Alex's aarch32-all.tar.xz RISU tests.
There are no
This is done generically in translator_loop.
Reported-by: Laurent Desnogues
Signed-off-by: Richard Henderson
---
target/arm/translate-a64.c | 1 -
target/arm/translate.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index
From: Michael Clark
Cc: Palmer Dabbelt
Cc: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Alistair Francis
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Palmer Dabbelt
Signed-off-by: Alistair Francis
---
hw/riscv/sifive_u.c | 4 +++-
hw/riscv/spike.c| 6 --
From: Michael Clark
Cc: Palmer Dabbelt
Cc: Sagar Karandikar
Cc: Bastian Koppelmann
Cc: Alistair Francis
Signed-off-by: Michael Clark
Reviewed-by: Alistair Francis
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Palmer Dabbelt
Signed-off-by: Alistair Francis
---
hw/riscv/virt.c | 2 ++
From: Michael Clark
This patch makes op_helper.c contain only instruction
operation helpers used by translate.c and moves any
unrelated cpu helpers into cpu_helper.c. No logic is
changed by this patch.
Cc: Sagar Karandikar
Cc: Bastian Koppelmann
Cc: Palmer Dabbelt
Cc: Alistair Francis
From: Michael Clark
* Add user-mode CSR defininitions.
* Reorder CSR definitions to match the specification.
* Change H mode interrupt comment to 'reserved'.
* Remove unused X_COP interrupt.
* Add user-mode interrupts.
* Remove erroneous until comments on machine mode interrupts.
* Move together
Connect the gpex PCIe device based on the device tree included in the
HiFive Unleashed ROM.
Signed-off-by: Alistair Francis
---
default-configs/riscv32-softmmu.mak | 6 ++-
default-configs/riscv64-softmmu.mak | 6 ++-
hw/riscv/virt.c | 58 +
From: Michael Clark
Change the API of riscv_set_local_interrupt to take a
write mask and value to allow setting and clearing of
multiple local interrupts atomically in a single call.
Rename the new function to riscv_cpu_update_mip.
Cc: Sagar Karandikar
Cc: Bastian Koppelmann
Cc: Palmer
Signed-off-by: Alistair Francis
---
default-configs/riscv32-softmmu.mak | 1 +
default-configs/riscv64-softmmu.mak | 1 +
hw/riscv/virt.c | 20 +---
3 files changed, 19 insertions(+), 3 deletions(-)
diff --git a/default-configs/riscv32-softmmu.mak
Increase the number of interrupts to match the HiFive Unleashed board.
Signed-off-by: Alistair Francis
---
include/hw/riscv/virt.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/riscv/virt.h b/include/hw/riscv/virt.h
index 91163d6cbf..7cb2742070 100644
---
Connect the Xilinx PCIe device based on the information in the device
tree stored in the ROM of the HiFish Unleashed board.
Signed-off-by: Alistair Francis
---
hw/riscv/sifive_u.c | 64 +
include/hw/riscv/sifive_u.h | 4 ++-
2 files changed, 67
Enable compile support for VGA devices. This allows the user to conenct
a display by adding '-device bochs-display -display sdl' to their
command line argument.
Signed-off-by: Alistair Francis
---
default-configs/riscv32-softmmu.mak | 3 +++
default-configs/riscv64-softmmu.mak | 3 +++
-20181011
for you to fetch changes up to f39e645c5f5e9f2b3d41e9c1ad84caae1829cce2:
RISC-V: Don't add NULL bootargs to device-tree (2018-10-11 10:30:26 -0700)
riscv: Connect PCIe and apply some misc patches
Connect PCIe to the RISC
On 10/11/18 4:45 AM, Markus Armbruster wrote:
Daniel Henrique Barboza writes:
The qmp/hmp command 'system_wakeup' is simply a direct call to
'qemu_system_wakeup_request' from vl.c. This function verifies if
runstate is SUSPENDED and if the wake up reason is valid before
proceeding.
On 11.10.2018 16:25, Brad Smith wrote:
> On 10/11/2018 5:41 AM, Kamil Rytarowski wrote:
>
>> On 11.10.2018 11:36, Peter Maydell wrote:
>>> On 11 October 2018 at 00:55, Brad Smith wrote:
And from FreeBSD...
MAP_STACK MAP_STACK implies MAP_ANON, and offset of 0. The fd
From: Thomas Huth
We can re-use the s390-ccw bios code to implement a small firmware
for a s390x guest which prints out the "A" and "B" characters and
modifies the memory, as required for the migration test.
[quintela: Converted the compile script to Makefile rules]
Signed-off-by: Juan Quintela
From: Wei Huang
This patch adds migration test support for aarch64. The test code, which
implements the same functionality as x86, is booted as a kernel in qemu.
Here are the design choices we make for aarch64:
* We choose this -kernel approach because aarch64 QEMU doesn't provide a
From: Ilya Maximets
POSTCOPY_NOTIFY_INBOUND_END handlers will remove userfault fds
from the postcopy_remote_fds array which could be still in
use by the fault thread. Let's stop the thread before
notification to avoid possible accessing wrong memory.
Fixes: 46343570c06e ("vhost+postcopy: Wire
From: Juan Quintela
Several changes:
- We only allow generate header "inside" the tree. Why? Because we
need to connit the result, so it makes no sense to generate them on
the build dir.
- We only generate a single target each time. Getting all the
cross-compilers correctly is an
From: "Denis V. Lunev"
According to PCI specification, subsystem id and subsystem vendor id
are present only in type 0 and type 2 headers (at different offsets),
but not in type 1 headers.
Thus we should make this data optional in struct PciDeviceId and skip
reporting them via HMP if the
From: Ilya Maximets
According to documentation, NEED_REPLY_MASK should not be set
for VHOST_USER_SET_MEM_TABLE request in postcopy mode.
This restriction was mistakenly applied to 'reply_supported'
variable, which is local and used only for non-postcopy case.
CC: Dr. David Alan Gilbert
Fixes:
From: "Dr. David Alan Gilbert"
The following changes since commit 75e50c80e051423a6f55a34ee4a1eec842444a5b:
Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2018-10-10' into
staging (2018-10-11 10:43:37 +0100)
are available in the Git repository at:
From: Ilya Maximets
'fd' received from the vhost side is never freed.
Also, everything (including 'postcopy_listen' state) should be
cleaned up on vhost cleanup.
Fixes: 46343570c06e ("vhost+postcopy: Wire up POSTCOPY_END notify")
Fixes: f82c11165ffa ("vhost+postcopy: Register shared ufd with
* Juan Quintela (quint...@redhat.com) wrote:
> Several changes:
> - We only allow generate header "inside" the tree. Why? Because we
> need to connit the result, so it makes no sense to generate them on
> the build dir.
> - We only generate a single target each time. Getting all the
>
* Markus Armbruster (arm...@redhat.com) wrote:
> "Denis V. Lunev" writes:
>
> > According to PCI specification subsystem id and subsystem vendor id are
> > optinal and could be abscent in Type1 header and can be found on
> > different offsets within Type0 and Type2 headers.
>
> Well, they *are*
Eric Blake writes:
> On 10/8/18 12:31 PM, Markus Armbruster wrote:
>> Calling error_report() from within a a function that takes an Error **
>
> s/a a/a/
Fixing, thanks!
>> argument is suspicious. qemu_fsdev_add() does that, and its caller
>> fsdev_init_func() then fails without setting an
On Wed, Oct 10, 2018 at 03:30:25PM +0200, Philippe Mathieu-Daudé wrote:
> Cc'ing Eduardo since it might make sens to have this series go via his
> machine-next tree, rather than Jason's net tree.
Queued on machine-next, thanks!
>
> On 01/10/2018 08:37, Cédric Le Goater wrote:
> > Hello,
> >
>
Markus Armbruster writes:
> Calling error_report() in a function that takes an Error ** argument
> is suspicious. vnc_init_func() does that, and then fails without
> setting an error. Its caller main(), via qemu_opts_foreach(), is fine
> with it, but clean it up anyway.
>
> Cc: Gerd Hoffmann
1 - 100 of 322 matches
Mail list logo
