[Qemu-devel] [Bug 1485180] Re: Ctrl Alt G -- Multiple Virtual Machines

2018-10-26 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1485180 Title: Ctrl Alt G

[Qemu-devel] [Bug 1493033] Re: memory leak/high memory usage with spice webdav feature

2018-10-26 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1493033 Title: memory

Re: [Qemu-devel] [PATCH 04/10] cputlb: Split large page tracking per mmu_idx

2018-10-26 Thread Emilio G. Cota
On Tue, Oct 23, 2018 at 08:02:47 +0100, Richard Henderson wrote: > +static void tlb_flush_page_locked(CPUArchState *env, int midx, > + target_ulong addr) > +{ > +target_ulong lp_addr = env->tlb_d[midx].large_page_addr; > +target_ulong lp_mask =

Re: [Qemu-devel] [PATCH 2/4] migration: introduce lockless multithreads model

2018-10-26 Thread Emilio G. Cota
On Wed, Oct 17, 2018 at 12:10:15 +0200, Paolo Bonzini wrote: > On 16/10/2018 13:10, guangrong.x...@gmail.com wrote: > An idea: the total number of requests is going to be very small, and a > PtrRing is not the nicest data structure for multiple producer/single > consumer. So you could instead:

Re: [Qemu-devel] [PULL 0/3] MIPS queue for October 2018 - part 3

2018-10-26 Thread Peter Maydell
On 25 October 2018 at 21:19, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > The following changes since commit 808ebd66e467f77c0d1f8c6346235f81e9c99cf2: > > Merge remote-tracking branch 'remotes/riscv/tags/riscv-for-master-3.1-sf0' > into staging (2018-10-25 17:41:03 +0100) > >

[Qemu-devel] template for a script for running an ad-hoc QEMU image

2018-10-26 Thread Peter Maydell
In a conversation this week I mentioned the scripts I use for running ad-hoc QEMU guest images that I have. The idea here is just that by making sure that whenever I get a test image I set it up to be run in the same way, I don't have the problem of trying to remember how to run the guest if I

Re: [Qemu-devel] [PATCH 0/3] target/mips: Rename MMI-related code elements

2018-10-26 Thread Fredrik Noring
Hi Aleksandar, > This series renames MMI-related code elements so that they do not > contain TX79 substring. Tx79 is one of CPUs that support MMI ASE. > Opcodes and other code elements should be as generic as possible, > and should not contain CPU name if they are supported by multiple > CPUs. In

Re: [Qemu-devel] [PATCH v1] lsi53c895a: check message length value is valid

2018-10-26 Thread Peter Maydell
On 26 October 2018 at 20:43, P J P wrote: > From: Prasad J Pandit > > While writing a message in 'lsi_do_msgin', message length value > in 'msg_len' could be invalid. Add check to avoid OOB access issue. > > Signed-off-by: Prasad J Pandit > --- > hw/scsi/lsi53c895a.c | 15 ++- > 1

[Qemu-devel] [PATCH 3/3] target/mips: Rename MMI-related functions

2018-10-26 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename MMI-related functions. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index

[Qemu-devel] [PATCH 0/3] target/mips: Rename MMI-related code elements

2018-10-26 Thread Aleksandar Markovic
From: Aleksandar Markovic This series renames MMI-related code elements so that they do not contain TX79 substring. Tx79 is one of CPUs that support MMI ASE. Opcodes and other code elements should be as generic as possible, and should not contain CPU name if they are supported by multiple CPUs.

[Qemu-devel] [PATCH 1/3] target/mips: Rename MMI-related masks

2018-10-26 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename MMI-related masks. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 51a5488..e38d50d 100644 ---

[Qemu-devel] [PATCH 2/3] target/mips: Rename MMI-related opcodes

2018-10-26 Thread Aleksandar Markovic
From: Aleksandar Markovic Rename MMI-related opcodes. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 470 1 file changed, 235 insertions(+), 235 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c

Re: [Qemu-devel] [PATCH v1] bt: use size_t type for length parameters instead of int

2018-10-26 Thread P J P
+-- On Sun, 21 Oct 2018, P J P wrote --+ | The length parameter values are not negative, thus use an unsigned | type 'size_t' for them. Many routines pass 'len' values to memcpy(3) | calls. If it was negative, it could lead to memory corruption issues. | Add check to avoid it. | | Reported-by:

[Qemu-devel] [PATCH v1] lsi53c895a: check message length value is valid

2018-10-26 Thread P J P
From: Prasad J Pandit While writing a message in 'lsi_do_msgin', message length value in 'msg_len' could be invalid. Add check to avoid OOB access issue. Signed-off-by: Prasad J Pandit --- hw/scsi/lsi53c895a.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) Update v1:

Re: [Qemu-devel] [PULL v2 00/28] pci, pc, virtio: fixes, features

2018-10-26 Thread Peter Maydell
On 26 October 2018 at 14:26, Singh, Brijesh wrote: > > > On 10/25/2018 07:59 PM, Michael S. Tsirkin wrote: >> On Thu, Oct 25, 2018 at 08:16:44PM +0100, Peter Maydell wrote: >>> These should presumably all be "ULL". (The "UL" suffix is >>> usually a bug, as it's either unnecessary or should be

Re: [Qemu-devel] [PULL v2 00/43] Machine queue, 2018-10-25

2018-10-26 Thread Peter Maydell
On 25 October 2018 at 14:32, Eduardo Habkost wrote: > Changes v1 -> v2: > * Fix 'make check' warnings (Igor) > > > The following changes since commit 13399aad4fa87b2878c49d02a5d3bafa6c966ba3: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-10-22' > into staging

Re: [Qemu-devel] [PATCH 5/6] Determine the desired FPU mode

2018-10-26 Thread Aleksandar Markovic
> From: Peter Maydell > Subject: Re: [Qemu-devel] [PATCH 5/6] Determine the desired FPU mode > > On 26 October 2018 at 15:21, Stefan Markovic > wrote: > > From: Stefan Markovic > > > > Floating-point mode is calculated from MIPS.abiflags FP ABI value > > (based on kernel implementation).

Re: [Qemu-devel] [PATCH] lsi53c895a: check message length value

2018-10-26 Thread P J P
+-- On Fri, 26 Oct 2018, Mark Kanda wrote --+ | Yes, please use that acknowledgement text in lieu of a 'Reported-by' line. Okay, thank you. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F

Re: [Qemu-devel] [PATCH 3/3] cirrus: mark as deprecated

2018-10-26 Thread P J P
+-- On Fri, 26 Oct 2018, Daniel P. Berrangé wrote --+ | ... | One thing we should do, however, is to make it clear which of the | device models we consider secure, and which we consider only usable | in a friendly guest environment, as we have very different code | maintainership & quality

Re: [Qemu-devel] [PATCH v2] migration: avoid segmentfault when take a snapshot of a VM which being migrated

2018-10-26 Thread Dr. David Alan Gilbert
* Jia Lina (jialin...@baidu.com) wrote: > During an active background migration, snapshot will trigger a > segmentfault. As snapshot clears the "current_migration" struct > and updates "to_dst_file" before it finds out that there is a > migration task, Migration accesses the null pointer in >

Re: [Qemu-devel] [PATCH] lsi53c895a: check message length value

2018-10-26 Thread Mark Kanda
On 10/26/2018 1:37 PM, P J P wrote: +-- On Fri, 26 Oct 2018, Mark Kanda wrote --+ | Deja vu requested that we include the following text in the commit message: | | Discovered by Deja vu Security. Reported by Oracle. | | Would that be acceptable? Generally an email-id is used/preferred in

Re: [Qemu-devel] [PATCH] lsi53c895a: check message length value

2018-10-26 Thread P J P
+-- On Fri, 26 Oct 2018, Mark Kanda wrote --+ | Deja vu requested that we include the following text in the commit message: | | Discovered by Deja vu Security. Reported by Oracle. | | Would that be acceptable? Generally an email-id is used/preferred in the commit log message. We could

[Qemu-devel] [PATCH] decodetree: Allow multiple input files

2018-10-26 Thread Richard Henderson
While it would be possible to concatenate input files with make, passing the original input files to decodetree.py allows us to generate error messages which allows compilation environments (read: emacs) to next-error to the correct input file. Signed-off-by: Richard Henderson --- Bastian, I

Re: [Qemu-devel] [PATCH] target/riscv/pmp.c: pmpcfg_csr_read returns bogus value on RV64

2018-10-26 Thread Dayeol Lee
Hi, I submitted the patch, but just found this has been already fixed by Michael Clark and pushed to riscv/riscv-qemu https://github.com/riscv/riscv-qemu/pull/166 but not in the upstream. Do we still need this patch? Thanks, Dayeol On Fri, Oct 26, 2018 at 11:04 AM Dayeol Lee wrote: >

Re: [Qemu-devel] [PATCH 5/6] Determine the desired FPU mode

2018-10-26 Thread Peter Maydell
On 26 October 2018 at 15:21, Stefan Markovic wrote: > From: Stefan Markovic > > Floating-point mode is calculated from MIPS.abiflags FP ABI value > (based on kernel implementation). Illegal combinations are rejected. > > Signed-off-by: Stefan Markovic > --- > linux-user/mips/cpu_loop.c | 75 >

[Qemu-devel] [PATCH] target/riscv/pmp.c: pmpcfg_csr_read returns bogus value on RV64

2018-10-26 Thread Dayeol Lee
pmp_read_cfg() returns 8-bit value, which is combined together to form a single pmpcfg CSR. The default promotion rules will result in an integer here ("i*8" is integer, which flows through) resulting in a 32-bit signed value on most hosts. That's bogus on RV64I, with the high bits of the CSR

Re: [Qemu-devel] [PATCH 0/6] target/mips: Add support for prctl() PR_GET_FP_MODE and PR_SET_FP_MODE

2018-10-26 Thread Aleksandar Markovic
> Subject: [PATCH 0/6] target/mips: Add support for prctl() PR_GET_FP_MODE and > PR_SET_FP_MODE > > From: Stefan Markovic > > This series includes support for prctl() PR_GET_FP_MODE and PR_SET_FP_MODE. > This requires extracting MIPS.abiflags section from ELF file and fp_abi value > handling.

Re: [Qemu-devel] [PATCH v2] ppc/pnv: check size before data buffer access

2018-10-26 Thread Cédric Le Goater
On 10/26/18 2:33 PM, P J P wrote: > From: Prasad J Pandit > > While performing PowerNV memory r/w operations, the access length > 'sz' could exceed the data[4] buffer size. Add check to avoid OOB > access. > > Reported-by: Moguofang > Signed-off-by: Prasad J Pandit Reviewed-by: Cédric Le

Re: [Qemu-devel] [PATCH 1/6] Define MIPS_ABI_FP_UNKNOWN macro

2018-10-26 Thread Aleksandar Markovic
> Subject: [PATCH 1/6] Define MIPS_ABI_FP_UNKNOWN macro > > From: Stefan Markovic > > Signed-off-by: Stefan Markovic > --- A brief commit message is needed. From what kernel or glibc header is this constant copied? Other than that: Reviewed-by: Aleksandar Markovic

Re: [Qemu-devel] [PATCH 2/6] Extend image_info struct with MIPS specific fp_abi and interp_fp_abi fields

2018-10-26 Thread Aleksandar Markovic
> Subject: [PATCH 2/6] Extend image_info struct with MIPS specific fp_abi and > interp_fp_abi fields > > From: Stefan Markovic > > Signed-off-by: Stefan Markovic > --- A brief commit message is needed. Perhaps with the description of the role/purpose of two fields introduced in this patch.

Re: [Qemu-devel] [PATCH 3/6] Extract MIPS abiflags from ELF file

2018-10-26 Thread Aleksandar Markovic
> Subject: [PATCH 3/6] Extract MIPS abiflags from ELF file > > From: Stefan Markovic > > Signed-off-by: Stefan Markovic > --- A brief commit message is needed. Other than that: Reviewed-by: Aleksandar Markovic

Re: [Qemu-devel] [RFC v4 70/71] cpus-common: move exclusive_idle higher in the file

2018-10-26 Thread Richard Henderson
On 10/25/18 3:46 PM, Emilio G. Cota wrote: > This will simplify the following commit's diff. > > Signed-off-by: Emilio G. Cota > --- > cpus-common.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [RFC v4 36/71] arm: convert to cpu_interrupt_request

2018-10-26 Thread Emilio G. Cota
On Fri, Oct 26, 2018 at 14:39:21 +0100, Alex Bennée wrote: > > Emilio G. Cota writes: > > > Cc: Peter Maydell > > This will need to catch-up in the next re-base as there is a merge conflict. Yep, this series is so long that I decided to keep the same baseline as in v3, so that I could just

Re: [Qemu-devel] [RFC v4 68/71] cpu: add async_run_on_cpu_no_bql

2018-10-26 Thread Richard Henderson
On 10/25/18 3:46 PM, Emilio G. Cota wrote: > Some async jobs do not need the BQL. > > Signed-off-by: Emilio G. Cota > --- > include/qom/cpu.h | 14 ++ > cpus-common.c | 39 ++- > 2 files changed, 48 insertions(+), 5 deletions(-) Reviewed-by:

Re: [Qemu-devel] [PATCH 4/6] Read and set FP ABI value from MIPS abiflags

2018-10-26 Thread Aleksandar Markovic
> Subject: [PATCH 4/6] Read and set FP ABI value from MIPS abiflags > > From: Stefan Markovic > > Signed-off-by: Stefan Markovic > --- A short commit message is needed. Other than that: Reviewed-by: Aleksandar Markovic

Re: [Qemu-devel] [RFC v4 65/71] xtensa: convert to cpu_has_work_with_iothread_lock

2018-10-26 Thread Richard Henderson
On 10/25/18 3:46 PM, Emilio G. Cota wrote: > Soon we will call cpu_has_work without the BQL. > > Cc: Max Filippov > Signed-off-by: Emilio G. Cota > --- > target/xtensa/cpu.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 5/6] Determine the desired FPU mode

2018-10-26 Thread Aleksandar Markovic
> Subject: [PATCH 5/6] Determine the desired FPU mode > > From: Stefan Markovic > > Floating-point mode is calculated from MIPS.abiflags FP ABI value > (based on kernel implementation). Illegal combinations are rejected. > > Signed-off-by: Stefan Markovic > --- Reviewed-by: Aleksandar

Re: [Qemu-devel] [RFC v4 67/71] cpus-common: release BQL earlier in run_on_cpu

2018-10-26 Thread Richard Henderson
On 10/25/18 3:46 PM, Emilio G. Cota wrote: > After completing the conversion to per-CPU locks, there is no need > to release the BQL after having called cpu_kick. > > Signed-off-by: Emilio G. Cota > --- > cpus-common.c | 20 +--- > 1 file changed, 5 insertions(+), 15

Re: [Qemu-devel] [PATCH 6/6] Add prctl() PR_SET_FP_MODE and PR_GET_FP_MODE implementations

2018-10-26 Thread Aleksandar Markovic
> From: Stefan Markovic > Subject: [PATCH 6/6] Add prctl() PR_SET_FP_MODE and PR_GET_FP_MODE > implementations > > From: Stefan Markovic > > Signed-off-by: Stefan Markovic > #define TARGET_PR_SET_FP_MODE 45 > #define TARGET_PR_GET_FP_MODE 46 > +#define TARGET_PR_FP_MODE_FR (1 << 0) >

Re: [Qemu-devel] [RFC v4 58/71] cpu: call .cpu_has_work with the CPU lock held

2018-10-26 Thread Richard Henderson
On 10/25/18 3:46 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > include/qom/cpu.h | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [RFC v4 64/71] sparc: convert to cpu_has_work_with_iothread_lock

2018-10-26 Thread Richard Henderson
On 10/25/18 3:46 PM, Emilio G. Cota wrote: > Soon we will call cpu_has_work without the BQL. > > Cc: Mark Cave-Ayland > Cc: Artyom Tarasenko > Signed-off-by: Emilio G. Cota > --- > target/sparc/cpu.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson

Re: [Qemu-devel] [RFC v4 63/71] riscv: convert to cpu_has_work_with_iothread_lock

2018-10-26 Thread Richard Henderson
On 10/25/18 3:46 PM, Emilio G. Cota wrote: > Soon we will call cpu_has_work without the BQL. > > Cc: Michael Clark > Cc: Palmer Dabbelt > Cc: Sagar Karandikar > Cc: Bastian Koppelmann > Reviewed-by: Palmer Dabbelt > Signed-off-by: Emilio G. Cota > --- > target/riscv/cpu.c | 5 - > 1

[Qemu-devel] [PULL 11/20] cpu.h: fix a typo in comment

2018-10-26 Thread Laurent Vivier
From: Li Qiang Found by reading the code. Signed-off-by: Li Qiang Message-Id: <1536150548-2797-1-git-send-email-liq...@gmail.com> Signed-off-by: Laurent Vivier --- include/qom/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qom/cpu.h b/include/qom/cpu.h

Re: [Qemu-devel] [RFC v4 62/71] s390x: convert to cpu_has_work_with_iothread_lock

2018-10-26 Thread Richard Henderson
On 10/25/18 3:46 PM, Emilio G. Cota wrote: > Soon we will call cpu_has_work without the BQL. > > Cc: Cornelia Huck > Cc: Alexander Graf > Cc: David Hildenbrand > Cc: qemu-s3...@nongnu.org > Signed-off-by: Emilio G. Cota > --- > target/s390x/cpu.c | 4 +++- > 1 file changed, 3 insertions(+),

Re: [Qemu-devel] [RFC v4 61/71] mips: convert to cpu_has_work_with_iothread_lock

2018-10-26 Thread Richard Henderson
On 10/25/18 3:46 PM, Emilio G. Cota wrote: > Soon we will call cpu_has_work without the BQL. > > Cc: Aurelien Jarno > Cc: Aleksandar Markovic > Signed-off-by: Emilio G. Cota > --- > target/mips/cpu.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson

[Qemu-devel] [PULL 07/20] scripts/decodetree.py: remove unused imports

2018-10-26 Thread Laurent Vivier
From: Cleber Rosa Signed-off-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181004161852.11673-8-cr...@redhat.com> Signed-off-by: Laurent Vivier --- scripts/decodetree.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/decodetree.py b/scripts/decodetree.py

[Qemu-devel] [PULL 05/20] qemu-iotests: fix filename containing checks

2018-10-26 Thread Laurent Vivier
From: Cleber Rosa Commit cce293a2945 moved some functions from common.config to common.rc, but the error messages still reference the old file location. Signed-off-by: Cleber Rosa Reviewed-by: Max Reitz Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181004161852.11673-5-cr...@redhat.com>

Re: [Qemu-devel] [RFC v4 60/71] ppc: convert to cpu_has_work_with_iothread_lock

2018-10-26 Thread Richard Henderson
On 10/25/18 3:46 PM, Emilio G. Cota wrote: > Soon we will call cpu_has_work without the BQL. > > Cc: David Gibson > Cc: Alexander Graf > Cc: qemu-...@nongnu.org > Signed-off-by: Emilio G. Cota > --- > target/ppc/translate_init.inc.c | 16 > 1 file changed, 12 insertions(+), 4

[Qemu-devel] [PULL 06/20] docs/devel/testing.rst: add missing newlines after code block

2018-10-26 Thread Laurent Vivier
From: Cleber Rosa The line immediate following a ".. code::" block is considered to contains arguments to the "code directive". The lack of a new line gives me during at parse time: testing.rst:63: (ERROR/3) Error in "code" directive: maximum 1 argument(s) allowed, 3 supplied. ..

[Qemu-devel] [PULL 19/20] milkymist-minimac2: Use qemu_log_mask(GUEST_ERROR) instead of error_report

2018-10-26 Thread Laurent Vivier
From: Philippe Mathieu-Daudé qemu_log_mask(GUEST_ERROR) is more appropriate: $ qemu -d help Log items (comma separated): guest_errorslog when the guest OS does something invalid (eg accessing a non-existent register) Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael Walle

Re: [Qemu-devel] [RFC v4 59/71] cpu: introduce cpu_has_work_with_iothread_lock

2018-10-26 Thread Richard Henderson
On 10/25/18 3:46 PM, Emilio G. Cota wrote: > It will gain some users soon. > > Suggested-by: Paolo Bonzini > Signed-off-by: Emilio G. Cota > --- > include/qom/cpu.h | 36 +--- > 1 file changed, 33 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson

[Qemu-devel] [PULL 00/20] Trivial patches patches

2018-10-26 Thread Laurent Vivier
The following changes since commit 808ebd66e467f77c0d1f8c6346235f81e9c99cf2: Merge remote-tracking branch 'remotes/riscv/tags/riscv-for-master-3.1-sf0' into staging (2018-10-25 17:41:03 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git

[Qemu-devel] [PULL 20/20] ppc: move at24c to its own CONFIG_ symbol

2018-10-26 Thread Laurent Vivier
From: Paolo Bonzini AT24c EEPROM is currently gated by CONFIG_I2C, and as such it is being included in all emulators that use I2C, even if they do not really need it. Separate it and, since it was added for the e500 machines, add it to qemu-system-ppc and qemu-system-ppc64. Signed-off-by:

Re: [Qemu-devel] [RFC v4 57/71] accel/tcg: convert to cpu_interrupt_request

2018-10-26 Thread Richard Henderson
On 10/25/18 3:46 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > accel/tcg/cpu-exec.c | 15 --- > accel/tcg/tcg-all.c | 12 +--- > accel/tcg/translate-all.c | 2 +- > 3 files changed, 18 insertions(+), 11 deletions(-) Reviewed-by: Richard

[Qemu-devel] [PULL 04/20] tests/tcg/README: fix location for lm32 tests

2018-10-26 Thread Laurent Vivier
From: Cleber Rosa Point to the right and obvious location for lm32 tests. Signed-off-by: Cleber Rosa Reviewed-by: Thomas Huth Acked-by: Alex Bennée Message-Id: <20181004161852.11673-3-cr...@redhat.com> Signed-off-by: Laurent Vivier --- tests/tcg/README | 2 +- 1 file changed, 1

[Qemu-devel] [PULL 03/20] memory.h: fix typos in comments

2018-10-26 Thread Laurent Vivier
From: Li Qiang Signed-off-by: Li Qiang Reviewed-by: Peter Maydell Message-Id: <1539080467-2976-1-git-send-email-liq...@gmail.com> [lv: s/types/typos/] Signed-off-by: Laurent Vivier --- include/exec/memory.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PULL 08/20] scripts/qemu.py: remove trailing quotes on docstring

2018-10-26 Thread Laurent Vivier
From: Cleber Rosa Signed-off-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181004161852.11673-11-cr...@redhat.com> Signed-off-by: Laurent Vivier --- scripts/qemu.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qemu.py b/scripts/qemu.py

[Qemu-devel] [PULL 14/20] qobject: Catch another straggler for use of qdict_put_str()

2018-10-26 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/qobject.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Acked-by:

[Qemu-devel] [PULL 01/20] configs/alpha: Remove unused CONFIG_PARALLEL_ISA switch

2018-10-26 Thread Laurent Vivier
From: Thomas Huth We don't use CONFIG_PARALLEL_ISA in any of our Makefiles, so this is just a dead config option which can be removed. Fixes: a4cb773928e047b137c6998209cf2eec857fac6b Signed-off-by: Thomas Huth Acked-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[Qemu-devel] [PULL 10/20] linux-user: fix comment s/atomic_write/atomic_set/

2018-10-26 Thread Laurent Vivier
From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Message-Id: <20180811211011.6277-1-c...@braap.org> Signed-off-by: Laurent Vivier --- linux-user/qemu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/qemu.h b/linux-user/qemu.h index 1beb6a2cfc..dde3f26f5a

[Qemu-devel] [PULL 09/20] qemu-iotests: make 218 executable

2018-10-26 Thread Laurent Vivier
From: Cleber Rosa Commit 990dc39c made all tests executable at the time, but 218 came in later, and missing those permissions. Signed-off-by: Cleber Rosa Message-Id: <20181004161852.11673-4-cr...@redhat.com> Signed-off-by: Laurent Vivier --- tests/qemu-iotests/218 | 0 1 file changed, 0

[Qemu-devel] [PULL 15/20] xen: Use the PCI_DEVICE macro

2018-10-26 Thread Laurent Vivier
From: Philippe Mathieu-Daudé TYPE_XEN_PT_DEVICE is a subclass of TYPE_PCI_DEVICE, the clean way to access the PCIDevice pointer is using the PCI_DEVICE() macro. Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Acked-by: Anthony PERARD

Re: [Qemu-devel] [RFC v4 48/71] mips: convert to cpu_interrupt_request

2018-10-26 Thread Richard Henderson
On 10/25/18 3:46 PM, Emilio G. Cota wrote: > Cc: Aurelien Jarno > Cc: Aleksandar Markovic > Cc: James Hogan > Signed-off-by: Emilio G. Cota > --- > target/mips/cpu.c | 7 --- > target/mips/kvm.c | 2 +- > 2 files changed, 5 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson

[Qemu-devel] [PULL 17/20] hw/pci-host: Remove useless parenthesis around DIV_ROUND_UP macro

2018-10-26 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/round.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Acked-by:

[Qemu-devel] [PULL 13/20] configure: Support pkg-config for zlib

2018-10-26 Thread Laurent Vivier
From: Stefan Weil This is needed for builds with the mingw64-* packages from Cygwin, but also works for Linux. Move the zlib test also more to the end because users should get information on the really important missing packages (which also require zlib) first. Signed-off-by: Stefan Weil

[Qemu-devel] [PULL 18/20] hw/intc/gicv3: Remove useless parenthesis around DIV_ROUND_UP macro

2018-10-26 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/round.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin Message-Id:

[Qemu-devel] [PULL 02/20] vga_int: remove unused function protype

2018-10-26 Thread Laurent Vivier
From: yuchenlin Signed-off-by: yuchenlin Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181022080053.9379-1-yuchen...@synology.com> Signed-off-by: Laurent Vivier --- hw/display/vga_int.h | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/vga_int.h b/hw/display/vga_int.h index

[Qemu-devel] [PULL 16/20] tests/bios-tables-test: Remove an useless cast

2018-10-26 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Patch created mechanically by rerunning: $ spatch --sp-file scripts/coccinelle/typecast.cocci \ --macro-file scripts/cocci-macro-file.h \ --dir . --in-place Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Acked-by:

Re: [Qemu-devel] [PATCH 1/1] hostmem-file: remove the invalid pmem object id.

2018-10-26 Thread Eduardo Habkost
On Wed, Oct 24, 2018 at 10:14:56PM +0800, Zhang Yi wrote: > We will never get the canonical path from the object > before object_property_add_child. > > Signed-off-by: Zhang Yi Thanks. I'm queueing it on machine-next, after rewriting the subject line as: hostmem-file: remove object id from

Re: [Qemu-devel] [RFC v4 42/71] ppc: convert to cpu_interrupt_request

2018-10-26 Thread Richard Henderson
On 10/25/18 3:46 PM, Emilio G. Cota wrote: > Cc: David Gibson > Cc: Alexander Graf > Cc: qemu-...@nongnu.org > Signed-off-by: Emilio G. Cota > --- > hw/ppc/ppc.c| 2 +- > target/ppc/excp_helper.c| 2 +- > target/ppc/kvm.c| 4 ++-- >

[Qemu-devel] [PULL 12/20] tests: Fix typos in comments and help message (found by codespell)

2018-10-26 Thread Laurent Vivier
From: Stefan Weil Fix also a grammar issue. Signed-off-by: Stefan Weil Reviewed-by: Alex Bennée Message-Id: <20180713054755.23323-1...@weilnetz.de> Signed-off-by: Laurent Vivier --- tests/bios-tables-test.c | 2 +- tests/docker/Makefile.include | 2 +-

Re: [Qemu-devel] [PATCH v2 02/29] targer/riscv: Activate decodetree and implemnt LUI & AUIPC

2018-10-26 Thread Palmer Dabbelt
On Fri, 26 Oct 2018 07:53:17 PDT (-0700), Bastian Koppelmann wrote: On 10/26/18 3:58 PM, Richard Henderson wrote: On 10/26/18 11:49 AM, Bastian Koppelmann wrote: I think you can pick up everything up to the RVC conversion which still needs the work suggested by Richard. Thanks, for picking it

Re: [Qemu-devel] [PATCH 00/10] Trivial fixes and clean ups

2018-10-26 Thread Eduardo Habkost
On Thu, Oct 04, 2018 at 12:18:42PM -0400, Cleber Rosa wrote: > Just a collection of trivial fixes and clean ups that have been lying > around here for some time. I'm queueing patches 07-10 on python-next. I'm aware that Laurent already queued some of them (thanks!), but I want to avoid conflicts

Re: [Qemu-devel] [Qemu-block] [PATCH 09/10] scripts/qemu.py: use a more consistent docstring style

2018-10-26 Thread Eduardo Habkost
On Mon, Oct 08, 2018 at 03:44:14PM -0400, John Snow wrote: > > > On 10/04/2018 12:18 PM, Cleber Rosa wrote: > > Signed-off-by: Cleber Rosa > > --- > > dtc | 2 +- > > scripts/qemu.py | 65 +++-- > > 2 files changed, 42 insertions(+), 25

Re: [Qemu-devel] [PATCH RFC 0/2] Fix migration issues

2018-10-26 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Fri, Oct 26, 2018 at 09:10:19PM +0800, Fei Li wrote: > > > > > > On 10/25/2018 08:58 PM, Peter Xu wrote: > > > On Thu, Oct 25, 2018 at 05:04:00PM +0800, Fei Li wrote: > > > > > > [...] > > > > > > > @@ -1325,22 +1325,24 @@ bool

Re: [Qemu-devel] [PATCH v7 0/3] Bootstrap Python venv and acceptance/functional tests

2018-10-26 Thread Eduardo Habkost
On Thu, Oct 18, 2018 at 11:31:31AM -0400, Cleber Rosa wrote: > TL;DR > = > > Allow acceptance tests to be run with `make check-acceptance`. Queued on python-next, thanks! -- Eduardo

Re: [Qemu-devel] [RFC v4 41/71] i386/hvf: convert to cpu_request_interrupt

2018-10-26 Thread Richard Henderson
On 10/25/18 3:46 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > target/i386/hvf/hvf.c| 8 +--- > target/i386/hvf/x86hvf.c | 26 +++--- > 2 files changed, 20 insertions(+), 14 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 1/9] qom/user-creatable: add a few helper macros

2018-10-26 Thread Eduardo Habkost
On Mon, Oct 22, 2018 at 03:33:30PM +0100, Igor Mammedov wrote: > On Wed, 12 Sep 2018 16:55:23 +0400 > Marc-André Lureau wrote: > > > Improve a bit code readability. > > > > Signed-off-by: Marc-André Lureau > > --- > > include/qom/object_interfaces.h | 4 > > qom/object.c

Re: [Qemu-devel] [RFC v4 40/71] i386/whpx-all: convert to cpu_interrupt_request

2018-10-26 Thread Richard Henderson
On 10/25/18 3:46 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > target/i386/whpx-all.c | 41 - > 1 file changed, 24 insertions(+), 17 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [RFC v4 39/71] i386/hax-all: convert to cpu_interrupt_request

2018-10-26 Thread Richard Henderson
On 10/25/18 3:46 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > target/i386/hax-all.c | 30 +- > 1 file changed, 17 insertions(+), 13 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [RFC v4 38/71] i386/kvm: convert to cpu_interrupt_request

2018-10-26 Thread Richard Henderson
On 10/25/18 3:46 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > target/i386/kvm.c | 54 +++ > 1 file changed, 31 insertions(+), 23 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [RFC v4 32/71] exec: use cpu_reset_interrupt

2018-10-26 Thread Richard Henderson
On 10/25/18 3:46 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > exec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [RFC v4 37/71] i386: convert to cpu_interrupt_request

2018-10-26 Thread Richard Henderson
On 10/25/18 3:46 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > target/i386/cpu.c| 2 +- > target/i386/helper.c | 4 ++-- > target/i386/svm_helper.c | 4 ++-- > 3 files changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [RFC v4 30/71] cpu: define cpu_interrupt_request helpers

2018-10-26 Thread Richard Henderson
On 10/25/18 3:46 PM, Emilio G. Cota wrote: > Add a comment about how atomic_read works here. The comment refers to > a "BQL-less CPU loop", which will materialize toward the end > of this series. > > Note that the modifications to cpu_reset_interrupt are there to > avoid deadlock during the CPU

Re: [Qemu-devel] [RFC v4 23/71] riscv: convert to cpu_halted

2018-10-26 Thread Richard Henderson
On 10/25/18 3:45 PM, Emilio G. Cota wrote: > Cc: Michael Clark > Cc: Palmer Dabbelt > Cc: Sagar Karandikar > Cc: Bastian Koppelmann > Cc: Alistair Francis > Reviewed-by: Palmer Dabbelt > Signed-off-by: Emilio G. Cota > --- > target/riscv/op_helper.c | 2 +- > 1 file changed, 1

Re: [Qemu-devel] [RFC v4 29/71] cpu-exec: convert to cpu_halted

2018-10-26 Thread Richard Henderson
On 10/25/18 3:46 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > accel/tcg/cpu-exec.c | 24 > 1 file changed, 20 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [RFC v4 13/71] microblaze: convert to helper_cpu_halted_set

2018-10-26 Thread Richard Henderson
On 10/25/18 3:45 PM, Emilio G. Cota wrote: > Cc: "Edgar E. Iglesias" > Signed-off-by: Emilio G. Cota > --- > target/microblaze/translate.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [RFC v4 15/71] tcg-runtime: convert to cpu_halted_set

2018-10-26 Thread Richard Henderson
On 10/25/18 3:45 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > accel/tcg/tcg-runtime.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [RFC v4 17/71] ppc: convert to cpu_halted

2018-10-26 Thread Richard Henderson
On 10/25/18 3:45 PM, Emilio G. Cota wrote: > In ppce500_spin.c, acquire the lock just once to update > both cpu->halted and cpu->stopped. > > In hw/ppc/spapr_hcall.c, acquire the lock just once to > update cpu->halted and call cpu_has_work, since later > in the series we'll acquire the BQL (if

Re: [Qemu-devel] [RFC v4 11/71] m68k: convert to helper_cpu_halted_set

2018-10-26 Thread Richard Henderson
On 10/25/18 3:45 PM, Emilio G. Cota wrote: > Cc: Laurent Vivier > Signed-off-by: Emilio G. Cota > --- > target/m68k/translate.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [RFC v4 12/71] alpha: convert to helper_cpu_halted_set

2018-10-26 Thread Richard Henderson
On 10/25/18 3:45 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > target/alpha/translate.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [RFC v4 10/71] hppa: convert to helper_cpu_halted_set

2018-10-26 Thread Richard Henderson
On 10/25/18 3:45 PM, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > target/hppa/translate.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [RFC v4 08/71] ppc: convert to helper_cpu_halted_set

2018-10-26 Thread Richard Henderson
On 10/25/18 3:45 PM, Emilio G. Cota wrote: > Cc: David Gibson > Cc: Alexander Graf > Cc: qemu-...@nongnu.org > Signed-off-by: Emilio G. Cota > --- > target/ppc/translate.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [RFC v4 09/71] cris: convert to helper_cpu_halted_set

2018-10-26 Thread Richard Henderson
On 10/25/18 3:45 PM, Emilio G. Cota wrote: > And fix the temp leak along the way. > > Cc: "Edgar E. Iglesias" > Signed-off-by: Emilio G. Cota > --- > target/cris/translate.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [RFC v4 07/71] tcg-runtime: define helper_cpu_halted_set

2018-10-26 Thread Richard Henderson
On 10/25/18 3:45 PM, Emilio G. Cota wrote: > +void HELPER(cpu_halted_set)(CPUArchState *env, uint32_t val) > +{ > +CPUState *cpu = ENV_GET_CPU(env); > + > +cpu->halted = val; > +} I suppose this is fine as a first step. I'd like to clean up all of the targets to also use a helper like

Re: [Qemu-devel] [PATCH v2 02/29] targer/riscv: Activate decodetree and implemnt LUI & AUIPC

2018-10-26 Thread Bastian Koppelmann
On 10/26/18 3:58 PM, Richard Henderson wrote: On 10/26/18 11:49 AM, Bastian Koppelmann wrote: I think you can pick up everything up to the RVC conversion which still needs the work suggested by Richard. Thanks, for picking it up :) Even then I thought we were talking about splitting the RV64

Re: [Qemu-devel] [RFC v4 04/71] cpu: make qemu_work_cond per-cpu

2018-10-26 Thread Richard Henderson
On 10/25/18 3:45 PM, Emilio G. Cota wrote: > This eliminates the need to use the BQL to queue CPU work. > > While at it, give the per-cpu field a generic name ("cond") since > it will soon be used for more than just queueing CPU work. > > Signed-off-by: Emilio G. Cota > --- > include/qom/cpu.h

Re: [Qemu-devel] [RFC v4 03/71] cpu: introduce cpu_mutex_lock/unlock

2018-10-26 Thread Richard Henderson
On 10/25/18 3:45 PM, Emilio G. Cota wrote: > The few direct users of >lock will be converted soon. > > Signed-off-by: Emilio G. Cota > --- > include/qom/cpu.h | 33 +++ > cpus.c | 48 +++-- > stubs/cpu-lock.c

[Qemu-devel] [PATCH 1/6] Define MIPS_ABI_FP_UNKNOWN macro

2018-10-26 Thread Stefan Markovic
From: Stefan Markovic Signed-off-by: Stefan Markovic --- include/elf.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/elf.h b/include/elf.h index 5f45f9b..c151164 100644 --- a/include/elf.h +++ b/include/elf.h @@ -87,6 +87,8 @@ typedef int64_t Elf64_Sxword; #define

[Qemu-devel] [PATCH 6/6] Add prctl() PR_SET_FP_MODE and PR_GET_FP_MODE implementations

2018-10-26 Thread Stefan Markovic
From: Stefan Markovic Signed-off-by: Stefan Markovic --- linux-user/mips/target_syscall.h | 2 ++ linux-user/mips64/target_syscall.h | 2 ++ linux-user/syscall.c | 62 +++--- 3 files changed, 62 insertions(+), 4 deletions(-) diff --git

  1   2   3   >