On Mon, Oct 29, 2018 at 04:57:27PM +0400, Marc-André Lureau wrote:
> Hi,
>
> Here is a small series of fixes for the monitor, mostly related to
> threading issues.
Hi, Marc-André, Markus,
I'd be glad to know how you think about these monitor series,
considering that I just noticed it's exactly
On Mon, Oct 29, 2018 at 04:57:32PM +0400, Marc-André Lureau wrote:
> Add a monitor_destroyed global to check if monitor_cleanup() has been
> already called. In this case, don't insert the new monitor in the
> list, but free it instead.
Pure question: how to trigger the condition when doing
There is no need to make another reference.
Signed-off-by: Li Qiang
---
hw/block/nvme.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index a406c23..f63e344 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -1235,7 +1235,7 @@
When it is zero, it causes segv. Backtrack:
Thread 5 "qemu-system-x86" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffc6c17700 (LWP 51808)]
0x55acbd90 in nvme_start_ctrl (n=0x624c8100) at hw/block/nvme.c:820
warning: Source file is more recent than executable.
As this function can fail.
Signed-off-by: Li Qiang
---
hw/block/nvme.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 72c9644..a406c23 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -1250,7 +1250,10 @@ static void
Including sanity check and code cleanup.
Li Qiang (4):
nvme: use TYPE_NVME instead of constant string
nvme: ensure the num_queues is not zero
nvme: check msix_init_exclusive_bar return value
nvme: use pci_dev directly in nvme_realize
hw/block/nvme.c | 17 -
1 file
Signed-off-by: Li Qiang
---
hw/block/nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index fc7dacb..676cc48 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -1379,7 +1379,7 @@ static void nvme_instance_init(Object *obj)
}
At 2018-10-30 08:08:55, "Philippe Mathieu-Daudé" wrote:
>On 28/10/18 13:40, Li Qiang wrote:
>> Signed-off-by: Li Qiang
>> ---
>> tests/fw_cfg-test.c | 13 -
>> 1 file changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c
>>
On 2018/10/30 3:59, Philippe Mathieu-Daudé wrote:
Shannon Zhao's email at Huawei is bouncing: remove it.
X-Failed-Recipients: zhaoshengl...@huawei.com
** Address not found **
Your message wasn't delivered to zhaoshengl...@huawei.com because the
address couldn't be found, or
This is useful to write qtest about fw_cfg file entry.
Signed-off-by: Li Qiang
---
tests/libqos/fw_cfg.c | 33 +
tests/libqos/fw_cfg.h | 2 ++
2 files changed, 35 insertions(+)
diff --git a/tests/libqos/fw_cfg.c b/tests/libqos/fw_cfg.c
index
This patchset is the test case for the following patch:
https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg05254.html
v2:
Change qfw_cfg_get_file per Philippe's review:
https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg06340.html
Li Qiang (2):
tests: fw_cfg: add a function to get
Signed-off-by: Li Qiang
---
tests/fw_cfg-test.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c
index 1c5103fe1c..aeabd17ec0 100644
--- a/tests/fw_cfg-test.c
+++ b/tests/fw_cfg-test.c
@@ -99,6 +99,15 @@ static void
The original code just follow the TCP state diagram,
but in this case, we can skip the TCPS_TIME_WAIT state to simplify
the implementation.
Signed-off-by: Zhang Chen
---
net/filter-rewriter.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/filter-rewriter.c
On Mon, Oct 29, 2018 at 04:57:29PM +0400, Marc-André Lureau wrote:
> Chardev backends may not handle safely IO events from concurrent
> threads. Better to wake up the chardev from the monitor IO thread if
> it's being used as the chardev context.
>
> Unify code paths by using a BH in all cases.
>
On Mon, Oct 29, 2018 at 04:57:28PM +0400, Marc-André Lureau wrote:
> The function were not named with "mon_iothread", or following the AIO
> vs GMainContext distinction. Inline them instead.
>
> Signed-off-by: Marc-André Lureau
Reviewed-by: Peter Xu
--
Peter Xu
Quoting Tomáš Golembiovský (2018-10-23 06:23:09)
> Note that PCI controller reporting on Windows was and still is broken.
> Unfortunately I don't know how to fix it at the momemnt. See commit message
> and
> code comment. If anyone has environment where the original code works let me
> know.
Hi, everyone.
When I have installed the QEMU3.0.0 in the Linux on non X86 CPUS, I want to
use user space emulator to run Wine. I can get the source code for Wine and the
RPM file for Wine from the WineHQ web page.
I used to compile Wine in the X86-based Linux system and used it to run most
On Tue, Oct 30, 2018 at 10:02 AM Jason Wang wrote:
>
> On 2018/10/29 下午7:01, Peter Maydell wrote:
> > On 19 October 2018 at 04:22, Jason Wang wrote:
> >> From: Zhang Chen
> >>
> >> We add almost full TCP state machine in filter-rewriter, except
> >> TCPS_LISTEN and some simplify in VM active
On 2018/10/29 下午7:01, Peter Maydell wrote:
On 19 October 2018 at 04:22, Jason Wang wrote:
From: Zhang Chen
We add almost full TCP state machine in filter-rewriter, except
TCPS_LISTEN and some simplify in VM active close FIN states.
The reason for this simplify job is because guest kernel
Hello Philippe,
Thanks for your review,
I will send v2 later.
Thanks.
Li Qiang
在 2018/10/30 7:46, Philippe Mathieu-Daudé 写道:
> Hi Li,
>
> On 28/10/18 13:40, Li Qiang wrote:
>> This is useful to write qtest abount fw_cfg file entry.
>>
>> Signed-off-by: Li Qiang
>> ---
>>
On Mon, Oct 29, 2018 at 10:56:57AM +0100, Igor Mammedov wrote:
> On Fri, 26 Oct 2018 12:13:21 -0300
> Eduardo Habkost wrote:
>
> > On Mon, Oct 22, 2018 at 03:33:30PM +0100, Igor Mammedov wrote:
> > > On Wed, 12 Sep 2018 16:55:23 +0400
> > > Marc-André Lureau wrote:
> > >
> > > > Improve a
Philippe Mathieu-Daudé 于2018年10月30日周二 上午7:50写道：
> On 25/10/18 3:45, Li Qiang wrote:
> > Hello Laszlo and Philippe ,
> >
> > Thanks for your review,
> >
> >
> >
> > Philippe Mathieu-Daudé mailto:phi...@redhat.com>> 于
> > 2018年10月25日周四 上午6:56写道：
> >
> > Hi,
> >
> > On 24/10/18 13:35,
在 2018/10/30 8:08, Philippe Mathieu-Daudé 写道:
> On 28/10/18 13:40, Li Qiang wrote:
>> Signed-off-by: Li Qiang
>> ---
>> tests/fw_cfg-test.c | 13 -
>> 1 file changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c
>> index
Glad you think it's worth it.
Thanks,
Sebastien
From: Philippe Mathieu-Daudé [phi...@redhat.com]
Sent: Monday, October 29, 2018 2:02 PM
To: Samuel Ortiz; qemu-devel@nongnu.org
Cc: Michael S. Tsirkin; Jing Liu; Boeuf, Sebastien; Paolo Bonzini; Igor Mammedov
Yes makes sense. Let's change the naming.
Thanks,
Sebastien
From: Philippe Mathieu-Daudé [phi...@redhat.com]
Sent: Monday, October 29, 2018 12:46 PM
To: Samuel Ortiz; qemu-devel@nongnu.org
Cc: Eduardo Habkost; Michael S. Tsirkin; Jing Liu; Boeuf,
Fix the extraneous extra blank lines in the test output when running with V=1.
Before:
TEST: tests/bios-tables-test... (pid=25678)
/i386/acpi/piix4:
Looking for expected file 'tests/acpi-test-data/pc/DSDT'
Using expected file 'tests/acpi-test-data/pc/DSDT'
Looking for
On 28/10/18 13:40, Li Qiang wrote:
Signed-off-by: Li Qiang
---
tests/fw_cfg-test.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c
index 1c5103fe1c..37765f15f8 100644
--- a/tests/fw_cfg-test.c
+++
On Mon, Oct 29, 2018 at 4:24 PM Philippe Mathieu-Daudé
wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Alistair
> ---
> MAINTAINERS| 1 +
> hw/arm/xilinx_zynq.c | 18 ++
> hw/dma/pl330.c | 2 +-
> include/hw/dma/pl330.h
On 25/10/18 3:45, Li Qiang wrote:
Hello Laszlo and Philippe ,
Thanks for your review,
Philippe Mathieu-Daudé mailto:phi...@redhat.com>> 于
2018年10月25日周四 上午6:56写道：
Hi,
On 24/10/18 13:35, Laszlo Ersek wrote:
> On 10/24/18 09:11, Li Qiang wrote:
>> This can avoid setting a
On Mon, Oct 29, 2018 at 4:21 PM Philippe Mathieu-Daudé
wrote:
>
> From: Guenter Roeck
>
> QEMU already supports pl330. Instantiate it for smdkc210.
>
> Signed-off-by: Guenter Roeck
> Reviewed-by: Philippe Mathieu-Daudé
> [PMD: Use pl330_init from "hw/dma/pl330.h"]
> Signed-off-by: Philippe
On Mon, Oct 29, 2018 at 4:22 PM Philippe Mathieu-Daudé
wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Alistair
> ---
> hw/arm/xilinx_zynq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c
>
Hi Li,
On 28/10/18 13:40, Li Qiang wrote:
This is useful to write qtest abount fw_cfg file entry.
Signed-off-by: Li Qiang
---
tests/libqos/fw_cfg.c | 30 ++
tests/libqos/fw_cfg.h | 2 ++
2 files changed, 32 insertions(+)
diff --git a/tests/libqos/fw_cfg.c
Hi Marc, Laurent.
On Mon, Oct 29, 2018 at 2:43 PM Mark Cave-Ayland
wrote:
>
> From: Laurent Vivier
>
> On Sparc and PowerMac, the bit 0 of the address
> selects the register type (control or data) and
> bit 1 selects the channel (B or A).
>
> On m68k Macintosh, the bit 0 selects the channel and
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS| 1 +
hw/arm/xilinx_zynq.c | 18 ++
hw/dma/pl330.c | 2 +-
include/hw/dma/pl330.h | 41 +
4 files changed, 45 insertions(+), 17 deletions(-)
create mode 100644
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/xilinx_zynq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c
index f1496d2927..57497b0c4d 100644
--- a/hw/arm/xilinx_zynq.c
+++ b/hw/arm/xilinx_zynq.c
@@ -294,7 +294,7 @@ static void
From: Guenter Roeck
QEMU already supports pl330. Instantiate it for smdkc210.
Signed-off-by: Guenter Roeck
Reviewed-by: Philippe Mathieu-Daudé
[PMD: Use pl330_init from "hw/dma/pl330.h"]
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/exynos4_boards.c | 12
1 file changed, 12
Hi, this series is another intent to salvage previous work from Guenter Roeck:
https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg06302.html
Instead of duplicate the pl330_init() from the xilinx_zynq, I factored it out.
Regards,
Phil.
Guenter Roeck (1):
arm: exynos4: Add dma support
From: Guenter Roeck
Signed-off-by: Guenter Roeck
Reviewed-by: Philippe Mathieu-Daudé
[PMD: Intented tabs -> space]
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/allwinner-a10.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwinner-a10.c
index
From: Guenter Roeck
Signed-off-by: Guenter Roeck
Signed-off-by: Philippe Mathieu-Daudé
---
Gerd: You already review this code here:
https://lists.gnu.org/archive/html/qemu-arm/2017-01/msg00345.html
Can we use your R-b again?
hw/usb/hcd-ehci-sysbus.c | 17 +
hw/usb/hcd-ehci.h
From: Guenter Roeck
Signed-off-by: Guenter Roeck
Reviewed-by: Philippe Mathieu-Daudé
[PMD: Intented tabs -> space]
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/allwinner-a10.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwinner-a10.c
index
Hi, this series intend to salvage previous work from Guenter Roeck [1].
A similar series from Icenowy Zheng was later reviewed by Gerd Hoffmann:
https://lists.gnu.org/archive/html/qemu-arm/2017-01/msg00345.html [2].
I reviewed patches 1 and 3, Gerd already reviewed patch 2 ([2]), if he
agrees to
On 29/10/18 21:24, Guenter Roeck wrote:
On Mon, Oct 29, 2018 at 04:03:40PM +0100, Philippe Mathieu-Daudé wrote:
On 29/10/18 15:09, Guenter Roeck wrote:
On 10/29/18 6:24 AM, Peter Maydell wrote:
On 27 October 2018 at 12:04, Guenter Roeck wrote:
On 10/26/18 3:12 AM, Peter Maydell wrote:
Hi
On Mon, Oct 29, 2018 at 16:34:49 +, Alex Bennée wrote:
>
> Emilio G. Cota writes:
>
> > We don't pass a pointer to qemu_global_mutex anymore.
> >
> > Reviewed-by: Richard Henderson
> > Signed-off-by: Emilio G. Cota
>
> As discussed on IRC I don't fundamentally object to this being in
>
From: Vladimir Sementsov-Ogievskiy
This patch aims to bring the following behavior:
1. We don't load bitmaps, when started in inactive mode. It's the case
of incoming migration. In this case we wait for bitmaps migration
through migration channel (if 'dirty-bitmaps' capability is enabled) or
From: Vladimir Sementsov-Ogievskiy
Before previous patch, iotest 169 was actually broken for the case
test_persistent__not_migbitmap__offline_shared, while formally
passing.
After migration log of vm_b had message:
qemu-system-x86_64: Could not reopen qcow2 layer: Bitmap already
In prior commits that made merge transactionable, we removed the
assertion that merge cannot operate on disabled bitmaps. In addition,
we want to make sure that we are prohibiting merges to "locked" bitmaps.
Use the new user_locked function to check.
Reported-by: Eric Blake
Signed-off-by: John
Whether it's "locked" or "frozen", it's in use and should
not be allowed for the purposes of this operation.
Signed-off-by: John Snow
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-id: 20181002230218.13949-7-js...@redhat.com
Signed-off-by: John Snow
---
nbd/server.c | 4 ++--
1 file
Similarly to merge, it's OK to allow clear operations on disabled
bitmaps, as this condition only means that they are not recording
new writes. We are free to clear it if the user requests it.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
We're not being consistent about this. If it's in use by an operation,
the user should not be able to change the behavior of that bitmap.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-id: 20181002230218.13949-5-js...@redhat.com
Instead of both frozen and qmp_locked checks, wrap it into one check.
frozen implies the bitmap is split in two (for backup), and shouldn't
be modified. qmp_locked implies it's being used by another operation,
like being exported over NBD. In both cases it means we shouldn't allow
the user to
From: Vladimir Sementsov-Ogievskiy
This variable doesn't work as it should, because it is actually cleared
in qcow2_co_invalidate_cache() by memset(). Drop it, as the following
patch will introduce new behavior.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Signed-off-by:
From: Eric Blake
We need an accurate count of the number of bits set in a bitmap
after a merge. In particular, since the merge operation short-circuits
a merge from an empty source, if you have bitmaps A, B, and C where
B started empty, then merge C into B, and B into A, an inaccurate
count
If the bitmap is frozen, we shouldn't touch it.
Signed-off-by: John Snow
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-id: 20181002230218.13949-6-js...@redhat.com
Signed-off-by: John Snow
---
blockdev.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
From: Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy
[Maintainer edit -- touched up error message. --js]
Reviewed-by: John Snow
Signed-off-by: John Snow
---
block/qcow2.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/block/qcow2.c
From: Vladimir Sementsov-Ogievskiy
New action is like clean action: do the whole thing in .prepare and
undo in .abort. This behavior for bitmap-changing actions is needed
because backup job actions use bitmap in .prepare.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
From: Vladimir Sementsov-Ogievskiy
Rename block-dirty-bitmap-clear transaction handlers to reuse them for
x-block-dirty-bitmap-merge transaction in the following patch.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Signed-off-by: John Snow
---
blockdev.c | 8
1
From: Vladimir Sementsov-Ogievskiy
Test that we can resume source vm after [failed] migration, and bitmaps
are ok.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: John Snow
---
tests/qemu-iotests/169 | 60 +-
From: Vladimir Sementsov-Ogievskiy
Add backup parameter to bdrv_merge_dirty_bitmap() to be used then with
bdrv_restore_dirty_bitmap() if it needed to restore the bitmap after
merge operation.
This is needed to implement bitmap merge transaction action in further
commit.
Signed-off-by: Vladimir
From: Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Signed-off-by: John Snow
---
tests/qemu-iotests/169 | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/qemu-iotests/169 b/tests/qemu-iotests/169
index f243db9955..df408f8367 100755
---
The following changes since commit 62b658db1df7c6fa574caae038144f24bf6ca495:
Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into
staging (2018-10-29 17:03:27 +)
are available in the Git repository at:
https://github.com/jnsnow/qemu.git tags/bitmaps-pull-request
From: Vladimir Sementsov-Ogievskiy
Use more generic names to reuse the function for bitmap merge in the
following commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
Signed-off-by: John Snow
---
block/dirty-bitmap.c | 4 ++--
blockdev.c| 2 +-
It is only an oversight that we don't allow incremental backup with
blockdev-backup. Add the bitmap argument which enables this.
Signed-off-by: John Snow
Message-id: 20180830211605.13683-2-js...@redhat.com
Signed-off-by: John Snow
---
blockdev.c | 18 +-
From: Vladimir Sementsov-Ogievskiy
Move checks from qmp_x_block_dirty_bitmap_merge() to
bdrv_merge_dirty_bitmap(), to share them with dirty bitmap merge
transaction action in future commit.
Note: for now, only qmp_x_block_dirty_bitmap_merge() calls
bdrv_merge_dirty_bitmap().
Signed-off-by:
On 29/10/18 18:01, Samuel Ortiz wrote:
All PC machine type derivatives will use the same ACPI table build
methods. But with that change in place, any new x86 machine type will be
able to re-use the acpi-build API and customize part of it by defining
its own ACPI table build methods.
Hi Samuel,
On 29/10/18 18:01, Samuel Ortiz wrote:
It is going to be used by the PC machine type as the MADT table builder
method and thus needs to be exported outside of acpi-build.c
Also, now that the generic build_madt() API is exported, we have to
rename the ARM static one in order to avoid
On 29.10.18 16:42, Christian Borntraeger wrote:
> I discussed the following maintainer updates at the kvm forum with
> Conny. This is the first set of changes.
> Can the affected persons please Ack the relevant patches?
>
> PS: Alex, do you still want to be listed?
No, I've been meaning to
Hi Samuel,
On 29/10/18 18:01, Samuel Ortiz wrote:
In order to decouple ACPI APIs from specific machine types, we are
creating an ACPI builder interface that each ACPI platform can choose to
implement.
This way, a new machine type can re-use the high level ACPI APIs and
define some custom table
On 29/10/18 18:01, Samuel Ortiz wrote:
From: Sebastien Boeuf
Instead of using the machine type specific method find_i440fx() to
retrieve the PCI bus, this commit aims to rely on the fact that the
PCI bus is known by the structure AcpiPciHpState.
When the structure is initialized through
Le 29/10/2018 à 15:53, Aleksandar Markovic a écrit :
>> From: Stefan Markovic
>> Subject: [PATCH v2 0/6] target/mips: Add support for prctl() PR_GET_FP_MODE
>> and PR_SET_FP_MODE
>>
>> From: Stefan Markovic
>>
>> This series includes support for prctl() PR_GET_FP_MODE and PR_SET_FP_MODE.
>>
On Mon, Oct 29, 2018 at 04:03:40PM +0100, Philippe Mathieu-Daudé wrote:
> Hi Guenter,
>
> On 29/10/18 15:09, Guenter Roeck wrote:
> >On 10/29/18 6:24 AM, Peter Maydell wrote:
> >>On 27 October 2018 at 12:04, Guenter Roeck wrote:
> >>>On 10/26/18 3:12 AM, Peter Maydell wrote:
> Hi Guenter;
On Mon, Oct 29, 2018 at 7:46 PM Stefan Hajnoczi wrote:
> @@ -39,8 +47,12 @@ static void microbit_init(MachineState *machine)
> _fatal);
> object_property_set_bool(soc, true, "realized", _fatal);
>
> -armv7m_load_kernel(ARM_CPU(first_cpu),
On 10/26/2018 10:22 AM, Daniel P. Berrangé wrote:
>
> On Fri, Oct 26, 2018 at 04:03:51PM +0200, Markus Armbruster wrote:
>> This is from my (imperfect) notes, corrections welcome.
>>
>> Motivation: QEMU contains stuff of dubious value, which gets in the way
>> in various (sometimes painful and
From: Li Qiang
Call it in device unrealize function.
Signed-off-by: Li Qiang
Message-id: 1539946236-18028-2-git-send-email-liq...@gmail.com
Signed-off-by: Gerd Hoffmann
---
hw/usb/ccid-card-emulated.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/hw/usb/ccid-card-emulated.c
From: Li Qiang
Signed-off-by: Li Qiang
Message-id: 1539946236-18028-3-git-send-email-liq...@gmail.com
Signed-off-by: Gerd Hoffmann
---
hw/usb/ccid-card-emulated.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/hw/usb/ccid-card-emulated.c
From: Li Qiang
This can avoid setting OCHIState.num_ports to a negative num.
Signed-off-by: Li Qiang
Message-id: 1540263618-18344-1-git-send-email-liq...@gmail.com
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-ohci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
The following changes since commit b312532fd03413d0e6ae6767ec793a3e30f487b8:
Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging
(2018-10-19 19:01:07 +0100)
are available in the git repository at:
git://git.kraxel.org/qemu tags/usb-20181029-pull-request
for you
On Sat, 27 Oct 2018 01:42:02 PDT (-0700), alistai...@gmail.com wrote:
On Fri, Oct 26, 2018 at 7:14 PM Dayeol Lee wrote:
Hi,
I submitted the patch, but just found this has been already fixed by
Michael Clark
and pushed to riscv/riscv-qemu https://github.com/riscv/riscv-qemu/pull/166
but not
Shannon Zhao's email at Huawei is bouncing: remove it.
X-Failed-Recipients: zhaoshengl...@huawei.com
** Address not found **
Your message wasn't delivered to zhaoshengl...@huawei.com because the
address couldn't be found, or is unable to receive mail.
Note that the section still
Hi Samuel,
On 29/10/18 18:01, Samuel Ortiz wrote:
ACPI tables are platform and machine type and even architecture
agnostic, and as such we want to provide an internal ACPI API that
only depends on platform agnostic information.
For the x86 architecture, in order to build ACPI tables
On 29/10/18 18:01, Samuel Ortiz wrote:
From: Sebastien Boeuf
The ACPI hotplug support for PCI devices APIs are not x86 or even
machine type specific. In order for future machine types to be able to
re-use that code, we export it through the architecture agnostic
hw/acpi folder.
Signed-off-by:
Microbit programs are typically in Intel HEX (.hex) format. The generic
loader supports .hex files but it doesn't work as expected:
$ qemu-system-arm -M microbit -device loader,file=microbit.hex
Guest image must be specified (using -kernel)
This error comes from armv7m_load_kernel(). Don't
On 29/10/18 18:01, Samuel Ortiz wrote:
From: Yang Zhong
The SRAT ACPI table is not x86 specific and will be needed for the
Hardware-reduced ACPI implementation. So we should export it through the
architecture independent hw/acpi folder.
Also, now that the generic build_srat() API is exported,
On 29/10/18 18:01, Samuel Ortiz wrote:
This property is currently defined under i386/pc while it only describes
a region size that's eventually fetched from the AML ACPI code.
We can make it more generic and shareable across machine types by moving
it to memory-device.h instead.
It makes sens
On 29/10/18 18:01, Samuel Ortiz wrote:
CPU and memory ACPI hotplug are not necessarily handled through SCI
events. For example, with Hardware-reduced ACPI, the GED device will
manage ACPI hotplug entirely.
As a consequence, we make the CPU and memory specific events AML
generation optional. The
On 29/10/18 18:01, Samuel Ortiz wrote:
From: Yang Zhong
The ACPI MCFG getter is not x86 specific and could be called from
anywhere within generic ACPI API, so let's export it.
Signed-off-by: Yang Zhong
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
---
On 29/10/18 20:23, Philippe Mathieu-Daudé wrote:
On 29/10/18 18:01, Samuel Ortiz wrote:
From: Yang Zhong
The AML build routines for the PCI host bridge and the corresponding
DSDT addition are neither x86 nor PC machine type specific.
We can move them to the architecture agnostic hw/acpi
On 10/29/2018 11:42 AM, Christian Borntraeger wrote:
Eric and Farhan will help with maintaining vfio-ccw.
Signed-off-by: Christian Borntraeger
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index d794bd7..10045b6 100644
--- a/MAINTAINERS
On 29/10/18 18:01, Samuel Ortiz wrote:
From: Yang Zhong
The AML build routines for the PCI host bridge and the corresponding
DSDT addition are neither x86 nor PC machine type specific.
We can move them to the architecture agnostic hw/acpi folder, and by
carrying all the needed information
Hi Yang, Samuel.
On 29/10/18 18:01, Samuel Ortiz wrote:
From: Yang Zhong
Make it more flexible by having it parsing a PCI host paths array
instead of open coding those paths deep down into the code logic itself.
This will be needed for PCI machine types that are neither emulatiing the
ich9
Hi, Cameron.
The step "Start QEMU and boot Mac OS X 10.4.11" is not clear to me. Is
there a location where one could download such image and boot?
I wonder how one without access to a Mac image can reproduce this issue.
Cheers
Murilo
--
You received this bug notification because you are a
On 29/10/18 18:01, Samuel Ortiz wrote:
From: Yang Zhong
Most of the AML build routines under acpi-build are not even
architecture specific. They can be moved to the more generic hw/acpi
folder where they could be shared across machine types and
architectures.
Signed-off-by: Yang Zhong
---
On 29/10/18 18:01, Samuel Ortiz wrote:
This is going to be needed by the Hardware-reduced ACPI routines.
Signed-off-by: Samuel Ortiz
---
hw/acpi/aml-build.c | 8
hw/i386/acpi-build.c| 8
include/hw/acpi/aml-build.h | 2 ++
3 files changed, 10
Hi Samuel,
On 29/10/18 18:01, Samuel Ortiz wrote:
The hardware-reduced API will need to build RSDP as well, so we should
export this routine. While doing so, we also slightly change the
function prototype. Since no caller needs it, and to make it more
consistent with the rest of the AML build
On Mon, 29 Oct 2018 10:59:47 PDT (-0700), Peter Maydell wrote:
On 29 October 2018 at 17:14, Palmer Dabbelt wrote:
I don't think we have anything ready to go right now: your PCIe patches
still have some outstanding feedback (on interrupt stuff), and Bastian's
decodetree stuff has some patches
On 29 October 2018 at 13:56, Stefan Hajnoczi wrote:
> The following changes since commit 285278ca785f5fa9a570927e1c0958a2ca2b2150:
>
> Merge remote-tracking branch 'remotes/famz/tags/testing-pull-request' into
> staging (2018-10-27 19:55:08 +0100)
>
> are available in the Git repository at:
>
On 10/29/2018 01:52 PM, Vladimir Sementsov-Ogievskiy wrote:
> ping2
>
> Hi, what about this finally? Looks like everyone see a lot of comments
> and thing, that there should be a new version, but actually, there is
> almost unrelated discussion and/or answered questions. Only rephrasing
>
On 29/10/2018 18:56, Paolo Bonzini wrote:
> On 26/10/2018 22:55, Peter Maydell wrote:
>>> +assert(len <= LSI_MAX_MSGIN_LEN);
>>> pci_dma_write(PCI_DEVICE(s), s->dnad, s->msg, len);
>>> /* Linux drivers rely on the last byte being in the SIDL. */
>>> s->sidl = s->msg[len - 1];
On 29 October 2018 at 17:14, Palmer Dabbelt wrote:
> I don't think we have anything ready to go right now: your PCIe patches
> still have some outstanding feedback (on interrupt stuff), and Bastian's
> decodetree stuff has some patches from Richard Henderson that should be
> merged in. I was
On 26/10/2018 22:55, Peter Maydell wrote:
>> +assert(len <= LSI_MAX_MSGIN_LEN);
>> pci_dma_write(PCI_DEVICE(s), s->dnad, s->msg, len);
>> /* Linux drivers rely on the last byte being in the SIDL. */
>> s->sidl = s->msg[len - 1];
> Is it possible to get here with len == 0 ?
No,
ping2
Hi, what about this finally? Looks like everyone see a lot of comments
and thing, that there should be a new version, but actually, there is
almost unrelated discussion and/or answered questions. Only rephrasing
by Eric in patch 2 may be applied, to change something.
The series fix the
1 - 100 of 382 matches
Mail list logo
