Re: [Qemu-devel] [PATCH] chardev: fix mess in OPENED/CLOSED events when muxed

2018-11-02 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 0084f7223c080cdbdfc2c5a2d132f8d6c0eff866.1541083966.git.artem.k.pisare...@gmail.com

[Qemu-devel] [Bug 588688] Re: Hard disk images are supporting ATAPI commands. They should fail.

2018-11-02 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/588688 Title: Hard disk

[Qemu-devel] [Bug 588693] Re: CD-ROM devices always return a one session, one track TOC

2018-11-02 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/588693 Title: CD-ROM

Re: [Qemu-devel] [PATCH v2 00/10] hostmem: use object "id" for memory region name with >= 3.1

2018-11-02 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20181030150453.9344-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/10]

Re: [Qemu-devel] [PATCH v3 00/13] arm: nRF51 Devices and Microbit Support

2018-11-02 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20181031002526.14262-1-cont...@steffen-goertz.de Subject: [Qemu-devel] [PATCH v3 00/13]

Re: [Qemu-devel] [PATCH v2 00/10] hostmem: use object "id" for memory region name with >= 3.1

2018-11-02 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20181030150453.9344-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/10]

Re: [Qemu-devel] [PATCH v3 00/13] arm: nRF51 Devices and Microbit Support

2018-11-02 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20181031002526.14262-1-cont...@steffen-goertz.de Subject: [Qemu-devel] [PATCH v3 00/13]

[Qemu-devel] [PATCH] vdi: Use a literal number of bytes for DEFAULT_CLUSTER_SIZE

2018-11-02 Thread Leonid Bloch
If an expression is used to define DEFAULT_CLUSTER_SIZE, when compiled, it will be embedded as a literal expression in the binary (as the default value) because it is stringified to mark the size of the default value. Now this is fixed by using a defined number to define this value.

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-02 Thread Liran Alon
> On 2 Nov 2018, at 18:39, Jim Mattson wrote: > > On Thu, Nov 1, 2018 at 8:46 PM, Liran Alon wrote: > >> Hmm this makes sense. >> >> This means though that the patch I have submitted here isn't good enough. >> My patch currently assumes that when it attempts to get nested state from >>

[Qemu-devel] [PATCH] include: Add a comment to explain the origin of sizes' lookup table

2018-11-02 Thread Leonid Bloch
The lookup table for power-of-two sizes was added in commit 540b8492618eb for the purpose of having convenient shortcuts for these sizes in cases when the literal number has to be present at compile time, and expressions as '(1 * KiB)' can not be used. One such case is the stringification of

[Qemu-devel] [PATCH v2] target/xtensa: drop num_[core_]regs from dc232b/dc233c configs

2018-11-02 Thread Max Filippov
gdb_regmap::num_core_regs field is initialized incorrectly in the dc232b and dc233c configurations. As a result the following message is displayed when attaching to an xtensa linux-user process: "Register 105 is not available", and gdb is unable to control the inferior. Now that

Re: [Qemu-devel] [PATCH] qemu/units: Move out QCow2 specific definitions

2018-11-02 Thread Leonid Bloch
Hi, On 11/2/18 5:28 PM, Kevin Wolf wrote: > Am 02.11.2018 um 15:52 hat Eric Blake geschrieben: >> On 11/2/18 9:10 AM, Kevin Wolf wrote: >>> Am 02.11.2018 um 13:37 hat Philippe Mathieu-Daudé geschrieben: Hi Kevin, On 2/11/18 12:07, Kevin Wolf wrote: > Am 02.11.2018 um 09:58 hat

Re: [Qemu-devel] [PATCH] tests/bios-tables-test: Sanitize test verbose output

2018-11-02 Thread Thomas Huth
On 2018-10-30 00:18, Philippe Mathieu-Daudé wrote: > Fix the extraneous extra blank lines in the test output when running with V=1. > > Before: > > TEST: tests/bios-tables-test... (pid=25678) > /i386/acpi/piix4: > Looking for expected file 'tests/acpi-test-data/pc/DSDT' > >

Re: [Qemu-devel] strange situation, guest cpu thread spinning at ~100%, but display not yet initialized

2018-11-02 Thread Chris Friesen
On 11/2/2018 11:51 AM, Dr. David Alan Gilbert wrote: This is ringing a bell; if it's actually suck in the BIOS, then please: a) Really make sure all your vCPUs are actually pinned/free on real CPUs b) I suspect it is https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg00470.html

Re: [Qemu-devel] [PATCH v2 0/5] target/arm: KVM vs ARMISARegisters

2018-11-02 Thread Christoffer Dall
On Fri, Nov 02, 2018 at 04:36:35PM +, Peter Maydell wrote: > On 2 November 2018 at 14:54, Richard Henderson > wrote: > > My previous patch set for replacing feature bits with id registers > > failed to consider that these id registers are beginning to control > > migration, and thus we must

[Qemu-devel] [PATCH 1/1] Add vhost-pci-blk driver

2018-11-02 Thread Vitaly Mayatskikh
This driver uses the kernel-mode acceleration for virtio-blk and allows to get a near bare metal disk performance inside a VM. Signed-off-by: Vitaly Mayatskikh --- configure | 10 +++ default-configs/virtio.mak | 1 + hw/block/Makefile.objs | 1 +

[Qemu-devel] [PATCH 0/1] Add vhost-pci-blk driver

2018-11-02 Thread Vitaly Mayatskikh
This driver moves virtio-blk host-side processing to kernel (via new vhost_blk kernel driver). It accelerates virtual disk performance close to bare metal levels, especially for parellel loads. For example, fio numjobs=16 gets 101k randread IOPS using virtio-blk and 1202k IOPS using vhost-blk,

Re: [Qemu-devel] strange situation, guest cpu thread spinning at ~100%, but display not yet initialized

2018-11-02 Thread Chris Friesen
On 11/2/2018 1:51 AM, Alex Bennée wrote: Chris Friesen writes: Hi all, I have an odd situation which occurs very infrequently and I'm hoping to get some advice on how to debug. Apologies for the length of this message, I tried to include as much potentially useful information as possible.

Re: [Qemu-devel] [PULL v3 00/10] target-arm queue

2018-11-02 Thread Peter Maydell
+) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20181102 > > for you to fetch changes up to 6f16da53ffe4567c0353f85055df04860eb4e6fc: > > hw/arm: versal:

[Qemu-devel] [Bug 1800993] Re: How to Migration VM Built on Qemu Souce Code Installation

2018-11-02 Thread John Snow
Hi, this is the bug tracker and not a support request form, so I'm closing this issue. (You've already emailed the mailing list, so you already know where to find us!) Thanks, --John ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a

Re: [Qemu-devel] How to emulate block I/O timeout on qemu side?

2018-11-02 Thread John Snow
On 11/02/2018 01:55 PM, Marc Olson wrote: > On 11/2/18 10:49 AM, John Snow wrote: >> On 11/02/2018 04:11 AM, Dongli Zhang wrote: >>> Hi, >>> >>> Is there any way to emulate I/O timeout on qemu side (not fault >>> injection in VM >>> kernel) without modifying qemu source code? >>> >>> For

Re: [Qemu-devel] [PATCH 2/2] target/mips: Fix decoding mechanism of R5900 DIV1 and DIVU1

2018-11-02 Thread Philippe Mathieu-Daudé
On 2/11/18 17:08, Fredrik Noring wrote: DIV1 and DIVU1 are generated in gen_div1_tx79 instead of the generic gen_muldiv. Fixes: be9c42c90d1 (R5900-specific opcodes overlap with generic opcodes) Signed-off-by: Fredrik Noring Reviewed-by: Philippe Mathieu-Daudé ---

Re: [Qemu-devel] [PATCH 1/2] target/mips: Fix decoding mechanism of R5900 MFLO1, MFHI1, MTLO1 and MTHI1

2018-11-02 Thread Philippe Mathieu-Daudé
On 2/11/18 17:08, Fredrik Noring wrote: MFLO1, MFHI1, MTLO1 and MTHI1 are generated in gen_HILO1_tx79 instead of the generic gen_HILO. Aleksandar, if you are OK with this patch, can you add: Fixes: 8d927f7cb4b Signed-off-by: Fredrik Noring Reviewed-by: Philippe Mathieu-Daudé ---

Re: [Qemu-devel] [PATCH v2 for-3.1 1/4] tests: Move tests/acpi-test-data/ to tests/data/acpi/

2018-11-02 Thread Philippe Mathieu-Daudé
On 2/11/18 18:42, Peter Maydell wrote: On 2 November 2018 at 17:38, Philippe Mathieu-Daudé wrote: Hi Peter, On 2/11/18 12:52, Peter Maydell wrote: We can remove entirely the note in rebuild-expected-aml.sh about copying any new data files, because now they will be in the source directory,

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/2] target/arm: fix some ATS* bugs

2018-11-02 Thread Peter Maydell
Ping for code review, please? thanks -- PMM On 16 October 2018 at 10:37, Peter Maydell wrote: > This small patchset fixes a couple of bugs in our ATS insn > handling: > * for faults reported to the 64-bit PAR we were not >setting the S and PTW bits to indicate stage 2 >fault

Re: [Qemu-devel] How to emulate block I/O timeout on qemu side?

2018-11-02 Thread Marc Olson via Qemu-devel
On 11/2/18 10:49 AM, John Snow wrote: On 11/02/2018 04:11 AM, Dongli Zhang wrote: Hi, Is there any way to emulate I/O timeout on qemu side (not fault injection in VM kernel) without modifying qemu source code? For instance, I would like to observe/study/debug the I/O timeout handling of nvme,

Re: [Qemu-devel] Correction needed for R5900 instruction decoding

2018-11-02 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 1/11/18 12:06, Aleksandar Markovic wrote: Hi, Fridrik, I did some closer code inspection of R5900 in last few days, and I noticed some sub-optimal implementation in the area where R5900-specific opcodes overlap with the rest-of-MIPS-CPUs opcodes. The right implementation

Re: [Qemu-devel] strange situation, guest cpu thread spinning at ~100%, but display not yet initialized

2018-11-02 Thread Dr. David Alan Gilbert
* Chris Friesen (chris.frie...@windriver.com) wrote: > On 11/2/2018 10:55 AM, Alex Bennée wrote: > > > > Chris Friesen writes: > > > Given the "not initialized" message on the console, I wasn't sure > > > whether the kernel had even started yet. > > > > There will be a lot that happens between

Re: [Qemu-devel] How to emulate block I/O timeout on qemu side?

2018-11-02 Thread John Snow
On 11/02/2018 04:11 AM, Dongli Zhang wrote: > Hi, > > Is there any way to emulate I/O timeout on qemu side (not fault injection in > VM > kernel) without modifying qemu source code? > > For instance, I would like to observe/study/debug the I/O timeout handling of > nvme, scsi, virtio-blk

Re: [Qemu-devel] [PATCH v2 for-3.1 1/4] tests: Move tests/acpi-test-data/ to tests/data/acpi/

2018-11-02 Thread Peter Maydell
On 2 November 2018 at 17:38, Philippe Mathieu-Daudé wrote: > Hi Peter, > > On 2/11/18 12:52, Peter Maydell wrote: >> We can remove entirely the note in rebuild-expected-aml.sh >> about copying any new data files, because now they will >> be in the source directory, not the build directory, and >>

Re: [Qemu-devel] [PATCH v2 for-3.1 0/4] configure: symlink directories, not wildcarded files

2018-11-02 Thread Philippe Mathieu-Daudé
On 2/11/18 12:52, Peter Maydell wrote: This patchset fixes a problem with our build infrastructure that meant that MST's recent 'pci, pc, virtio' pullreq failed tests. Currently our configure script has a wildcard loop that creates symlinks for every data file in tests/acpi-test-data from the

Re: [Qemu-devel] Regarding: Migration of VM created using qemu source code built

2018-11-02 Thread John Snow
On 11/01/2018 03:14 AM, aditya bhardwaj wrote: > Respected Sir, > > I followed https://wiki.qemu.org/Hosts/Linux to build qemu from source > code. Its installed successfully with Ubuntu 16.04 VM created using VNC > server. > > *Now, Could you please suggest me how to migrate VM from one host

Re: [Qemu-devel] [PATCH v2 for-3.1 1/4] tests: Move tests/acpi-test-data/ to tests/data/acpi/

2018-11-02 Thread Philippe Mathieu-Daudé
Hi Peter, On 2/11/18 12:52, Peter Maydell wrote: Currently tests/acpi-test-data contains data files used by the bios-tables-test, and configure individually symlinks those data files into the build directory using a wildcard. Using a wildcard like this is a bad idea, because if a new data file

[Qemu-devel] [PULL 03/10] hw/arm/nrf51_soc: Connect UART to nRF51 SoC

2018-11-02 Thread Peter Maydell
From: Julia Suvorova Wire up nRF51 UART in the corresponding SoC. Signed-off-by: Julia Suvorova Reviewed-by: Stefan Hajnoczi Reviewed-by: Alistair Francis Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- include/hw/arm/nrf51_soc.h | 3 +++ hw/arm/microbit.c | 2 ++

[Qemu-devel] [PULL 04/10] tests/boot-serial-test: Add microbit board testcase

2018-11-02 Thread Peter Maydell
From: Julia Suvorova New mini-kernel test for nRF51 SoC UART. Signed-off-by: Julia Suvorova Acked-by: Thomas Huth Reviewed-by: Stefan Hajnoczi Signed-off-by: Peter Maydell --- tests/boot-serial-test.c | 19 +++ 1 file changed, 19 insertions(+) diff --git

[Qemu-devel] [PULL 05/10] MAINTAINERS: Remove bouncing email in ARM ACPI

2018-11-02 Thread Peter Maydell
From: Philippe Mathieu-Daudé Shannon Zhao's email at Huawei is bouncing: remove it. X-Failed-Recipients: zhaoshengl...@huawei.com ** Address not found ** Your message wasn't delivered to zhaoshengl...@huawei.com because the address couldn't be found, or is unable to receive mail.

[Qemu-devel] [PULL 08/10] target/arm: Conditionalize some asserts on aarch32 support

2018-11-02 Thread Peter Maydell
From: Richard Henderson When populating id registers from kvm, on a host that doesn't support aarch32 mode at all, neither arm_div nor jazelle will be supported either. Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée Tested-by: Alex Bennée Message-id:

[Qemu-devel] [PULL 07/10] hw/arm/xilinx_zynq: Use the ARRAY_SIZE macro

2018-11-02 Thread Peter Maydell
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/arm/xilinx_zynq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PULL v3 00/10] target-arm queue

2018-11-02 Thread Peter Maydell
/pull-target-arm-20181102 for you to fetch changes up to 6f16da53ffe4567c0353f85055df04860eb4e6fc: hw/arm: versal: Add a virtual Xilinx Versal board (2018-11-02 14:11:31 +) target-arm queue: * microbit: Add the UART to our

[Qemu-devel] [PULL 09/10] hw/arm: versal: Add a model of Xilinx Versal SoC

2018-11-02 Thread Peter Maydell
From: "Edgar E. Iglesias" Add a model of Xilinx Versal SoC. Signed-off-by: Edgar E. Iglesias Message-id: 20181102131913.1535-2-edgar.igles...@xilinx.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/arm/Makefile.objs| 1 + include/hw/arm/xlnx-versal.h

[Qemu-devel] [PULL 10/10] hw/arm: versal: Add a virtual Xilinx Versal board

2018-11-02 Thread Peter Maydell
From: "Edgar E. Iglesias" Add a virtual Xilinx Versal board. This board is based on the Xilinx Versal SoC. The exact details of what peripherals are attached to this board will remain in control of QEMU. QEMU will generate an FDT on the fly for Linux and other software to auto-discover

[Qemu-devel] [PATCH v4 12/13] arm: Instantiate NRF51 Timers

2018-11-02 Thread Steffen Görtz
Instantiates TIMER0 - TIMER2 Signed-off-by: Steffen Görtz Reviewed-by: Stefan Hajnoczi --- hw/arm/nrf51_soc.c | 27 +++ include/hw/arm/nrf51_soc.h | 4 2 files changed, 31 insertions(+) diff --git a/hw/arm/nrf51_soc.c b/hw/arm/nrf51_soc.c index

[Qemu-devel] [PULL 01/10] hw/arm/virt: Set VIRT_COMPAT_3_0 compat

2018-11-02 Thread Peter Maydell
From: Eric Auger We are missing the VIRT_COMPAT_3_0 definition and setting. Let's add them. Signed-off-by: Eric Auger Reviewed-by: Andrew Jones Message-id: 20181024085602.16611-1-eric.au...@redhat.com Signed-off-by: Peter Maydell --- hw/arm/virt.c | 4 1 file changed, 4 insertions(+)

[Qemu-devel] [PULL 02/10] hw/char: Implement nRF51 SoC UART

2018-11-02 Thread Peter Maydell
From: Julia Suvorova Not implemented: CTS/NCTS, PSEL*. Signed-off-by: Julia Suvorova Reviewed-by: Stefan Hajnoczi Signed-off-by: Peter Maydell --- hw/char/Makefile.objs| 1 + include/hw/char/nrf51_uart.h | 78 + hw/char/nrf51_uart.c | 330

[Qemu-devel] [PATCH v4 11/13] hw/timer/nrf51_timer: Add nRF51 Timer peripheral

2018-11-02 Thread Steffen Görtz
This patch adds the model for the nRF51 timer peripheral. Currently, only the TIMER mode is implemented. Signed-off-by: Steffen Görtz --- hw/timer/Makefile.objs | 1 + hw/timer/nrf51_timer.c | 368 + hw/timer/trace-events | 5 +

[Qemu-devel] [PULL 06/10] strongarm: mask off high[31:28] bits from dir and state registers

2018-11-02 Thread Peter Maydell
From: Prasad J Pandit The high[31:28] bits of 'direction' and 'state' registers of SA-1100/SA-1110 device are reserved. Setting them may lead to OOB 's->handler[]' array access issue. Mask off [31:28] bits to avoid it. Reported-by: Moguofang Signed-off-by: Prasad J Pandit Message-id:

Re: [Qemu-devel] strange situation, guest cpu thread spinning at ~100%, but display not yet initialized

2018-11-02 Thread Chris Friesen
On 11/2/2018 10:55 AM, Alex Bennée wrote: Chris Friesen writes: Given the "not initialized" message on the console, I wasn't sure whether the kernel had even started yet. There will be a lot that happens between the kernel decompressing and some sort of video hardware output being started.

[Qemu-devel] [PATCH v4 02/13] arm: Add header to host common definition for nRF51 SOC peripherals

2018-11-02 Thread Steffen Görtz
Adds a header that provides definitions that are used across nRF51 peripherals Signed-off-by: Steffen Görtz Reviewed-by: Stefan Hajnoczi --- hw/arm/nrf51_soc.c | 33 ++ include/hw/arm/nrf51.h | 45

[Qemu-devel] [PATCH v4 09/13] arm: Instantiate NRF51 general purpose I/O

2018-11-02 Thread Steffen Görtz
Instantiates GPIO peripheral model Signed-off-by: Steffen Görtz Reviewed-by: Stefan Hajnoczi --- hw/arm/nrf51_soc.c | 16 include/hw/arm/nrf51_soc.h | 2 ++ 2 files changed, 18 insertions(+) diff --git a/hw/arm/nrf51_soc.c b/hw/arm/nrf51_soc.c index

[Qemu-devel] [PATCH v4 10/13] tests/microbit-test: Add Tests for nRF51 GPIO

2018-11-02 Thread Steffen Görtz
The test suite for the nRF51 GPIO peripheral for now only tests initial state. Additionally a set of tests testing an implementation detail of the model are included. Signed-off-by: Steffen Görtz Reviewed-by: Stefan Hajnoczi --- tests/microbit-test.c | 137

[Qemu-devel] [PATCH v4 06/13] arm: Instantiate NRF51 special NVM's and NVMC

2018-11-02 Thread Steffen Görtz
Instantiates UICR, FICR and NVMC in nRF51 SOC. Signed-off-by: Steffen Görtz Reviewed-by: Stefan Hajnoczi --- hw/arm/nrf51_soc.c | 37 ++--- include/hw/arm/nrf51_soc.h | 2 ++ 2 files changed, 36 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v4 08/13] hw/gpio/nrf51_gpio: Add nRF51 GPIO peripheral

2018-11-02 Thread Steffen Görtz
This adds a model of the nRF51 GPIO peripheral. Reference Manual: http://infocenter.nordicsemi.com/pdf/nRF51_RM_v3.0.pdf The nRF51 series microcontrollers support up to 32 GPIO pins in various configurations. The pins can be used as input pins with pull-ups or pull-down. Furthermore, three

[Qemu-devel] [PATCH v4 07/13] tests: Add bbc:microbit / nRF51 test suite

2018-11-02 Thread Steffen Görtz
The microbit-test includes tests for the nRF51 NVMC peripheral and will host future nRF51 peripheral tests and board-level bbc:microbit tests. Signed-off-by: Steffen Görtz Reviewed-by: Stefan Hajnoczi --- tests/Makefile.include | 2 + tests/microbit-test.c | 117

[Qemu-devel] [PATCH v4 13/13] arm: Add Clock peripheral stub to NRF51 SOC

2018-11-02 Thread Steffen Görtz
This stubs enables the microbit-micropython firmware to run on the microbit machine. Signed-off-by: Steffen Görtz Reviewed-by: Stefan Hajnoczi --- hw/arm/nrf51_soc.c | 27 +++ include/hw/arm/nrf51_soc.h | 1 + 2 files changed, 28 insertions(+) diff --git

[Qemu-devel] [PATCH v4 01/13] qtest: Add set_irq_in command to set IRQ/GPIO level

2018-11-02 Thread Steffen Görtz
Adds a new qtest command "set_irq_in" which allows to set qemu gpio lines to a given level. Based on https://lists.gnu.org/archive/html/qemu-devel/2012-12/msg02363.html which never got merged. Signed-off-by: Steffen Görtz Originally-by: Matthew Ogilvie Reviewed-by: Stefan Hajnoczi ---

[Qemu-devel] [PATCH v4 05/13] hw/nvram/nrf51_nvm: Add nRF51 non-volatile memories

2018-11-02 Thread Steffen Görtz
The nRF51 contains three regions of non-volatile memory (NVM): - CODE (R/W): contains code - FICR (R): Factory information like code size, chip id etc. - UICR (R/W): Changeable configuration data. Lock bits, Code protection configuration, Bootloader address, Nordic SoftRadio configuration,

[Qemu-devel] [PATCH v4 04/13] arm: Instantiate NRF51 random number generator

2018-11-02 Thread Steffen Görtz
Use RNG in SOC. Signed-off-by: Steffen Görtz Reviewed-by: Stefan Hajnoczi --- hw/arm/nrf51_soc.c | 16 include/hw/arm/nrf51_soc.h | 2 ++ 2 files changed, 18 insertions(+) diff --git a/hw/arm/nrf51_soc.c b/hw/arm/nrf51_soc.c index 55f8eaafcb..d2a19b8ead 100644 ---

[Qemu-devel] [PATCH v4 00/13] arm: nRF51 Devices and Microbit Support

2018-11-02 Thread Steffen Görtz
This series contains additional peripheral devices for the nRF51822 microcontroller. Included devices: - Random Number Generator - Non-volatile Memories - General purpose I/O - Timer - Stub for clock peripheral v4: * Use int's instead of long's in set_irq_in, allow arbitrary base, fix

[Qemu-devel] [PATCH v4 03/13] hw/misc/nrf51_rng: Add NRF51 random number generator peripheral

2018-11-02 Thread Steffen Görtz
Add a model of the NRF51 random number generator peripheral. This is a simple random generator that continuously generates new random values after startup. Reference Manual: http://infocenter.nordicsemi.com/pdf/nRF51_RM_v3.0.pdf Signed-off-by: Steffen Görtz Reviewed-by: Stefan Hajnoczi ---

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-02 Thread Jim Mattson via Qemu-devel
On Fri, Nov 2, 2018 at 9:58 AM, Daniel P. Berrangé wrote: > On Fri, Nov 02, 2018 at 09:44:54AM -0700, Jim Mattson via Qemu-devel wrote: >> On Fri, Nov 2, 2018 at 5:59 AM, Liran Alon wrote: >> > >> >> >>> Therefore, I don't think that we want this versioning to be based on >> >>> KVM_CAP at all.

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-02 Thread Daniel P . Berrangé
On Fri, Nov 02, 2018 at 09:44:54AM -0700, Jim Mattson via Qemu-devel wrote: > On Fri, Nov 2, 2018 at 5:59 AM, Liran Alon wrote: > > > > >>> Therefore, I don't think that we want this versioning to be based on > >>> KVM_CAP at all. > >>> It seems that we would want the process to behave as

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-02 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Fri, Nov 02, 2018 at 10:40:35AM +0100, Paolo Bonzini wrote: > > On 02/11/2018 04:46, Liran Alon wrote: > > >> On Thu, Nov1, 2018 at 09:45 AM, Jim Mattson wrote: > > > > > >>> On Thu, Nov 1, 2018 at 8:56 AM, Dr. David Alan Gilbert > > >>>

Re: [Qemu-devel] strange situation, guest cpu thread spinning at ~100%, but display not yet initialized

2018-11-02 Thread Alex Bennée
Chris Friesen writes: > On 11/2/2018 1:51 AM, Alex Bennée wrote: >> >> Chris Friesen writes: >> >>> Hi all, >>> >>> I have an odd situation which occurs very infrequently and I'm hoping >>> to get some advice on how to debug. Apologies for the length of this >>> message, I tried to include

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-02 Thread Daniel P . Berrangé
On Fri, Nov 02, 2018 at 10:40:35AM +0100, Paolo Bonzini wrote: > On 02/11/2018 04:46, Liran Alon wrote: > >> On Thu, Nov1, 2018 at 09:45 AM, Jim Mattson wrote: > > > >>> On Thu, Nov 1, 2018 at 8:56 AM, Dr. David Alan Gilbert > >>> wrote: > > > >>> So if I have matching host kernels it should

Re: [Qemu-devel] [PATCH v3 11/13] hw/timer/nrf51_timer: Add nRF51 Timer peripheral

2018-11-02 Thread Steffen Görtz
Hi Stefan, > > Does anything rearm a running timer after live migration? fixed in upcoming version. Steffen

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-02 Thread Jim Mattson via Qemu-devel
On Fri, Nov 2, 2018 at 5:59 AM, Liran Alon wrote: > >>> Therefore, I don't think that we want this versioning to be based on >>> KVM_CAP at all. >>> It seems that we would want the process to behave as follows: >>> 1) Mgmt-layer at dest queries dest host max supported nested_state size. >>>

[Qemu-devel] ping Re: [PATCH v4 00/11] backup-top filter driver for backup

2018-11-02 Thread Vladimir Sementsov-Ogievskiy
ping 15.10.2018 19:06, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > These series introduce backup-top driver. It's a filter-node, which > do copy-before-write operation. Mirror uses filter-node for handling > guest writes, let's move to filter-node (from write-notifiers) for > backup too

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-11-02 Thread Jim Mattson via Qemu-devel
On Thu, Nov 1, 2018 at 8:46 PM, Liran Alon wrote: > Hmm this makes sense. > > This means though that the patch I have submitted here isn't good enough. > My patch currently assumes that when it attempts to get nested state from KVM, > QEMU should always set nested_state->size to max size

Re: [Qemu-devel] [PATCH v2 0/5] target/arm: KVM vs ARMISARegisters

2018-11-02 Thread Peter Maydell
On 2 November 2018 at 14:54, Richard Henderson wrote: > My previous patch set for replacing feature bits with id registers > failed to consider that these id registers are beginning to control > migration, and thus we must fill them in for KVM as well. > > Thus, we want to initialize these values

Re: [Qemu-devel] [PATCH RFC v7 5/9] migration: fix the multifd code when sending less channels

2018-11-02 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Fri, Nov 02, 2018 at 11:00:24AM +0800, Fei Li wrote: > > > > > > On 11/02/2018 10:37 AM, Peter Xu wrote: > > > On Thu, Nov 01, 2018 at 06:17:11PM +0800, Fei Li wrote: > > > > Set the migration state to "failed" instead of "setup" when failing > > > > to

Re: [Qemu-devel] [PULL 39/45] target/arm: Reorg NEON VLD/VST all elements

2018-11-02 Thread Laurent Vivier
On 19/10/2018 18:57, Peter Maydell wrote: > From: Richard Henderson > > Instead of shifts and masks, use direct loads and stores from the neon > register file. Mirror the iteration structure of the ARM pseudocode > more closely. Correct the parameters of the VLD2 A2 insn. > > Note that this

Re: [Qemu-devel] [PATCH v3 08/13] hw/gpio/nrf51_gpio: Add nRF51 GPIO peripheral

2018-11-02 Thread Steffen Görtz
Hi Peter, > > >> +static void reflect_dir_bit_in_cnf(NRF51GPIOState *s) >> +{ >> +uint32_t value = s->dir; >> +for (size_t i = 0; i < NRF51_GPIO_PINS; i++) { > > Similarly here, and I think I saw another use somewhere else > in this patchset too. I have removed the c99 style

Re: [Qemu-devel] [PATCH v1 2/7] pcihp: overwrite hotplug handler recursively from the start

2018-11-02 Thread Michael S. Tsirkin
On Fri, Nov 02, 2018 at 02:00:32PM +0100, Igor Mammedov wrote: > On Fri, 2 Nov 2018 12:43:10 +0100 > David Hildenbrand wrote: > > > On 01.11.18 15:10, Igor Mammedov wrote: > > > On Wed, 24 Oct 2018 12:19:25 +0200 > > > David Hildenbrand wrote: > > > > > >> For now, the hotplug handler is not

Re: [Qemu-devel] [PATCH v3 08/13] hw/gpio/nrf51_gpio: Add nRF51 GPIO peripheral

2018-11-02 Thread Steffen Görtz
Hi Stefan, > > gcc (GCC) 8.2.1 20181011 doesn't know that extract32(..., 3) can only > result in values [0, 7] so it warns that state can be uninitialized. > > It might be simplest to include a default case that returns false (with > a comment). > thank you for your remarks. Will be in the next

[Qemu-devel] [PATCH 1/2] target/mips: Fix decoding mechanism of R5900 MFLO1, MFHI1, MTLO1 and MTHI1

2018-11-02 Thread Fredrik Noring
MFLO1, MFHI1, MTLO1 and MTHI1 are generated in gen_HILO1_tx79 instead of the generic gen_HILO. Signed-off-by: Fredrik Noring --- target/mips/translate.c | 67 ++--- 1 file changed, 56 insertions(+), 11 deletions(-) diff --git a/target/mips/translate.c

[Qemu-devel] [PATCH 2/2] target/mips: Fix decoding mechanism of R5900 DIV1 and DIVU1

2018-11-02 Thread Fredrik Noring
DIV1 and DIVU1 are generated in gen_div1_tx79 instead of the generic gen_muldiv. Signed-off-by: Fredrik Noring --- target/mips/translate.c | 65 + 1 file changed, 59 insertions(+), 6 deletions(-) diff --git a/target/mips/translate.c

[Qemu-devel] [PATCH 0/2] target/mips: Fix decoding mechanisms of R5900 M{F, T}{HI, LO}1 and DIV[U]1

2018-11-02 Thread Fredrik Noring
This series amends the R5900 support with the following changes: - MFLO1, MFHI1, MTLO1 and MTHI1 are generated in gen_HILO1_tx79 instead of the generic gen_HILO. - DIV1 and DIVU1 are generated in gen_div1_tx79 instead of the generic gen_muldiv. Fredrik Noring (2): target/mips: Fix

Re: [Qemu-devel] [PATCH v3 05/13] hw/nvram/nrf51_nvm: Add nRF51 non-volatile memories

2018-11-02 Thread Steffen Görtz
Hi Stefan, > > Indentation is off here. One way of formatting it: > > address_space_write(>as, i * NRF51_PAGE_SIZE, > MEMTXATTRS_UNSPECIFIED, s->empty_page, > NRF51_PAGE_SIZE); Good catch. >> +static void

Re: [Qemu-devel] [PATCH v3 05/13] hw/nvram/nrf51_nvm: Add nRF51 non-volatile memories

2018-11-02 Thread Steffen Görtz
Hi Stefan, > I'm a fan of '-' instead of '_' in qdev property names. There are more > instances of '-' than '_', but it's up to you. Agree. Changed. Best, Steffen

Re: [Qemu-devel] [PATCH v3 12/13] arm: Instantiate NRF51 Timers

2018-11-02 Thread Steffen Görtz
Hi Stefan, > > Indentation is off here. One way of formatting it: > > address_space_write(>as, i * NRF51_PAGE_SIZE, > MEMTXATTRS_UNSPECIFIED, s->empty_page, > NRF51_PAGE_SIZE); Good catch. >> +static void

Re: [Qemu-devel] Correction needed for R5900 instruction decoding

2018-11-02 Thread Fredrik Noring
Hi Peter, > From the other side of things, as a submaintainer around release > time there's often a lot of work to do and it's easy to confuse > different patchsets or forget the status of them, so it's useful > to have a patch series which is exactly the set of patches that > the submitter

Re: [Qemu-devel] [PATCH] nvme: fix oob access issue(CVE-2018-16847)

2018-11-02 Thread Keith Busch
On Thu, Nov 01, 2018 at 06:22:43PM -0700, Li Qiang wrote: > Currently, the nvme_cmb_ops mr doesn't check the addr and size. > This can lead an oob access issue. This is triggerable in the guest. > Add check to avoid this issue. > > Fixes CVE-2018-16847. > > Reported-by: Li Qiang > Reviewed-by:

Re: [Qemu-devel] [PATCH] nvme: fix oob access issue(CVE-2018-16847)

2018-11-02 Thread Kevin Wolf
Am 02.11.2018 um 16:22 hat Li Qiang geschrieben: > Hello Kevin, > > Kevin Wolf 于2018年11月2日周五 下午6:54写道: > > > Am 02.11.2018 um 02:22 hat Li Qiang geschrieben: > > > Currently, the nvme_cmb_ops mr doesn't check the addr and size. > > > This can lead an oob access issue. This is triggerable in the

Re: [Qemu-devel] [PATCH v3 02/13] arm: Add header to host common definition for nRF51 SOC peripherals

2018-11-02 Thread Steffen Görtz
Hi Julia, > Why do we need an extra file for this? nrf51_soc.h seemed like a good fit. nrf51_soc.h is not included in the peripheral devices. It would be possible to put the definitions into nrf51_soc.h but i just did not want to mix up the dependency directions. > What's the purpose of

Re: [Qemu-devel] [PATCH] qemu/units: Move out QCow2 specific definitions

2018-11-02 Thread Kevin Wolf
Am 02.11.2018 um 15:52 hat Eric Blake geschrieben: > On 11/2/18 9:10 AM, Kevin Wolf wrote: > > Am 02.11.2018 um 13:37 hat Philippe Mathieu-Daudé geschrieben: > > > Hi Kevin, > > > > > > On 2/11/18 12:07, Kevin Wolf wrote: > > > > Am 02.11.2018 um 09:58 hat Philippe Mathieu-Daudé geschrieben: > >

[Qemu-devel] [PATCH v6 09/10] dp8393x: manage big endian bus

2018-11-02 Thread Mark Cave-Ayland
From: Laurent Vivier This is needed by Quadra 800, this card can run on little-endian or big-endian bus. Signed-off-by: Laurent Vivier Tested-by: Hervé Poussineau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Hervé Poussineau --- hw/net/dp8393x.c | 88

[Qemu-devel] [PATCH v6 05/10] esp: add pseudo-DMA as used by Macintosh

2018-11-02 Thread Mark Cave-Ayland
From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/scsi/esp.c | 291 +- include/hw/scsi/esp.h | 7 ++ 2 files changed, 269 insertions(+), 29 deletions(-) diff

[Qemu-devel] [PATCH v6 08/10] hw/m68k: add a dummy SWIM floppy controller

2018-11-02 Thread Mark Cave-Ayland
From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau --- hw/block/Makefile.objs | 1 + hw/block/swim.c | 415 include/hw/block/swim.h |

[Qemu-devel] [PATCH v6 10/10] hw/m68k: define Macintosh Quadra 800

2018-11-02 Thread Mark Cave-Ayland
From: Laurent Vivier If you want to test the machine, it doesn't yet boot a MacROM, but you can boot a linux kernel from the command line. You can install your own disk using debian-installer with: ./qemu-system-m68k \ -M q800 \ -serial none -serial mon:stdio \ -m 1000M -drive

[Qemu-devel] [PATCH v6 02/10] hw/m68k: implement ADB bus support for via

2018-11-02 Thread Mark Cave-Ayland
From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau --- hw/misc/mac_via.c | 190 ++ include/hw/misc/mac_via.h | 7 ++ 2 files changed, 197

[Qemu-devel] [PATCH v6 06/10] hw/m68k: add Nubus support

2018-11-02 Thread Mark Cave-Ayland
From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/Makefile.objs| 1 + hw/nubus/Makefile.objs | 4 + hw/nubus/mac-nubus-bridge.c | 45 hw/nubus/nubus-bridge.c

[Qemu-devel] [PATCH v6 04/10] hw/m68k: add macfb video card

2018-11-02 Thread Mark Cave-Ayland
From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau --- arch_init.c| 4 + hw/display/Makefile.objs | 1 + hw/display/macfb.c | 419

[Qemu-devel] [PATCH v6 07/10] hw/m68k: add Nubus support for macfb video card

2018-11-02 Thread Mark Cave-Ayland
Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau --- hw/display/macfb.c | 56 ++ include/hw/display/macfb.h | 21 + 2 files changed, 77

[Qemu-devel] [PATCH v6 01/10] hw/m68k: add via support

2018-11-02 Thread Mark Cave-Ayland
From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau --- hw/misc/Makefile.objs | 1 + hw/misc/mac_via.c | 666 ++ include/hw/misc/mac_via.h

[Qemu-devel] [PATCH v6 00/10] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-11-02 Thread Mark Cave-Ayland
(MCA: here's the latest version of the q800 patchset. I've hope that I've addressed most of the comments, plus this will now boot into the Debian installer correctly when applied to git master. Outstanding comments: 1) Should the comment blocks copied from the Linux headers be removed

[Qemu-devel] [PATCH v6 03/10] escc: introduce a selector for the register bit

2018-11-02 Thread Mark Cave-Ayland
From: Laurent Vivier On Sparc and PowerMac, the bit 0 of the address selects the register type (control or data) and bit 1 selects the channel (B or A). On m68k Macintosh, the bit 0 selects the channel and bit 1 the register type. This patch introduces a new parameter (bit_swap) to the device

Re: [Qemu-devel] [PATCH] nvme: fix oob access issue(CVE-2018-16847)

2018-11-02 Thread Li Qiang
Hello Kevin, Kevin Wolf 于2018年11月2日周五 下午6:54写道: > Am 02.11.2018 um 02:22 hat Li Qiang geschrieben: > > Currently, the nvme_cmb_ops mr doesn't check the addr and size. > > This can lead an oob access issue. This is triggerable in the guest. > > Add check to avoid this issue. > > > > Fixes

Re: [Qemu-devel] Correction needed for R5900 instruction decoding

2018-11-02 Thread Peter Maydell
On 2 November 2018 at 15:03, Aleksandar Markovic wrote: > Hi, Fredrik. > >> From: Fredrik Noring >> Subject: Re: [Qemu-devel] Correction needed for R5900 instruction decoding >> >> Hi Aleksandar, >> >> > It is now code freeze before 3.1, the code base is being stabilized, and >> > only important

[Qemu-devel] [PATCH 0/3] nbd-client: drop extra error noise

2018-11-02 Thread Vladimir Sementsov-Ogievskiy
Hi all. It was discussed, that error messages, produced by error_reprt_err's, added in f140e300 are 1. not really needed 2. subject to race conditions And it was decided to drop them (switch to trace-points), look thread https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg00833.html So,

[Qemu-devel] [PATCH 3/3] block/nbd-client: use traces instead of noisy error_report_err

2018-11-02 Thread Vladimir Sementsov-Ogievskiy
Reduce extra noise of nbd-client, change 083 correspondingly. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd-client.c | 27 +++ block/trace-events | 4 tests/qemu-iotests/083.out | 28 3 files changed, 27

  1   2   3   >