Re: [Qemu-devel] [PATCH v3 2/7] qapi: correctly parse uint64_t values from strings

2018-11-03 Thread David Gibson
On Wed, Oct 31, 2018 at 06:18:33PM +0100, David Hildenbrand wrote: > On 31.10.18 15:32, Markus Armbruster wrote: > > David Hildenbrand writes: > > > >> Right now, we parse uint64_t values just like int64_t values, resulting > >> in negative values getting accepted and certain valid large numbers

Re: [Qemu-devel] [PATCH v2] ppc/pnv: check size before data buffer access

2018-11-03 Thread David Gibson
On Fri, Oct 26, 2018 at 06:03:58PM +0530, P J P wrote: > From: Prasad J Pandit > > While performing PowerNV memory r/w operations, the access length > 'sz' could exceed the data[4] buffer size. Add check to avoid OOB > access. > > Reported-by: Moguofang > Signed-off-by: Prasad J Pandit

Re: [Qemu-devel] [PATCH] softfloat: don't execute ppc64 ISA 3.0B instruction if it is not supported

2018-11-03 Thread David Gibson
On Thu, Nov 01, 2018 at 06:54:59PM +0100, Laurent Vivier wrote: > On 01/11/2018 18:49, Peter Maydell wrote: > > On 1 November 2018 at 17:38, Laurent Vivier wrote: > >> commit 27ae5109a2 has introduced an assembly instruction only supported > >> by ISA 3.0B and it fails to execute on previous

Re: [Qemu-devel] [PATCH] target/ppc: fix mtmsr instruction for icount

2018-11-03 Thread David Gibson
On Tue, Oct 30, 2018 at 12:30:31PM +0300, Pavel Dovgalyuk wrote: > This patch fixes processing of mtmsr instructions in icount mode. > In this mode writing to interrupt/peripheral state is controlled > by can_do_io flag. This flag must be set explicitly before helper > function invocation. > >

Re: [Qemu-devel] [PATCH for-3.1] hw/ppc/mac_newworld: Free openpic_irqs array after use

2018-11-03 Thread David Gibson
On Thu, Nov 01, 2018 at 04:17:58PM +, Peter Maydell wrote: > In ppc_core99_init(), we allocate an openpic_irqs array, which > we then use to collect up the various qemu_irqs which we're > going to connect to the interrupt controller. Once we've > called sysbus_connect_irq() to connect them all

Re: [Qemu-devel] [PATCH for 3.2 v2 0/7] hw/arm/bcm2835: Add basic support for cprman (clock subsystem)

2018-11-03 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20181102001303.32640-1-f4...@amsat.org Subject: [Qemu-devel] [PATCH for 3.2 v2 0/7]

Re: [Qemu-devel] [PATCH 0/3] Performance improvements for xen_disk

2018-11-03 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 154115098499.664.15585399091081300567.st...@dhcp-3-135.uk.xensource.com Subject: [Qemu-devel] [PATCH 0/3] Performance improvements for xen_disk === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH RFC v7 0/9] qemu_thread_create: propagate errors to callers to check

2018-11-03 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20181101101715.9443-1-...@suse.com Subject: [Qemu-devel] [PATCH RFC v7 0/9]

Re: [Qemu-devel] How to emulate block I/O timeout on qemu side?

2018-11-03 Thread Dongli Zhang
Hi all, I tried with the patch at: https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg00394.html The patch is applied to qemu-3.0.0. Below configuration is used to test the feature for guest VM nvme. # qemu-system-x86_64 \ -smp 4 -m 2000M -enable-kvm -vnc :0 -monitor stdio \ -net nic

[Qemu-devel] [PATCH] hw: virtio-pci: drop DO_UPCAST

2018-11-03 Thread Li Qiang
Use VIRTIO_PCI MACRO instead. Signed-off-by: Li Qiang --- hw/virtio/virtio-pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index a954799267..277dc20c81 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c

[Qemu-devel] [PATCH] qga-win: fix leaks of build_guest_disk_info()

2018-11-03 Thread Marc-André Lureau
Introduced in commit b1ba8890e63ce9432c41c5c3fc229f54c87c9c99, vol_h handle should be closed, and "out" cleanup should be done after DeviceIoControl() fails. Signed-off-by: Marc-André Lureau --- qga/commands-win32.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH v2 0/5] target/arm: KVM vs ARMISARegisters

2018-11-03 Thread Marc Zyngier
On Sat, 3 Nov 2018 09:53:44 + Richard Henderson wrote: Hi Richard, > Although, while I have you, Christopher, is there a way to extract the Limited > Ordering Region registers without modifying guest state? Those are > multiplexed > with LORN_EL1. We actively hide the LORegion feature

Re: [Qemu-devel] [PATCH v2 0/5] target/arm: KVM vs ARMISARegisters

2018-11-03 Thread Richard Henderson
On 11/2/18 7:35 PM, Christoffer Dall wrote: >> It looks like the kernel can handle reads of ID_ISAR0_EL1 >> through ID_ISAR5_EL1, but not ID_ISAR6_EL1, any of the >> MVFR*_EL1 or ID_AA64_ISAR* or ID_AA64PFR*. >> >> This is probably because the kernel is way too old to be >> interestingly

Re: [Qemu-devel] [PATCH v3] arm: exynos4: Add dma support for smdkc210

2018-11-03 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20181030193044.25954-1-phi...@redhat.com Subject: [Qemu-devel] [PATCH v3] arm: exynos4:

Re: [Qemu-devel] [PULL 0/2] Misc next patches

2018-11-03 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181031113651.32430-1-berra...@redhat.com Subject: [Qemu-devel] [PULL 0/2] Misc next patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline